How post-review must be used?
Hello, Just another thread because this is not related to the exception handling. It seems that I misuse post-review. I was thinking that I had to launch it (wherever I was), and it would ask me what was my SVN repos, what was my diff file, ans it would send the update to the server. Seems it does no do that. It seems it is looking for some info about the repos. Does it took the info from REVIEWBOARD_URL = http://192.168.1.200/ reviews? If yes, admitting I have misconfigured my server (because it does not detect the SVN repos. How can I check my repos config? In fact I've also tried to declare a review via the web interface sending it a .diff. But trying to see diff, it show me a blank page. So what, Snv repos declaration is misconfigured. If yes, where could I find a log to check this? I must admit I'm a little bit lost. For the moment I haven't set the svn properties, just using .reviewboardrc but it doesn't seems to have any effect. REVIEWBOARD_URL = http://192.168.1.200/reviews; So what, more a server repos misconfig? Laurent --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How post-review must be used?
I apologize in advance for the stream of consciousness nature of this email. But hopefully, it helps. You can set the reviewboard:url property by doingsvn propedit reviewboard:url . inside the directory for the repository using cygwin. When you run post-review you'll want to be inside that directory. Make sure that you also have the repository set up in the review-board admin ui ( http://code.google.com/docreader/#p=reviewboards=reviewboardt=Adding_Repositories ) I am not a windows user, so I am unaware of any gotchas with Cygwin, but from reading your emails I gather the following information. The cleartool error that you're getting is not the problem. It sounds like you are using a svn server. And post-review is unable to find the reviewboard url and your current working directory (when you run post-review) isn't inside the repository. /Vinay On Fri, Mar 20, 2009 at 2:50 PM, Christian Hammond chip...@chipx86.comwrote: You must set either the REVIEWBOARD_URL variable within .reviewboardrc or set the reviewboard:url property on your SVN directory for the project. The property is preferred, and there are instructions for this within the post-review script. The repository URL provided by running `svn info` is what you must use in Review Board itself in the repository entry. Did you create a Repository entry in the admin UI in Review Board, and what is it set to? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Fri, Mar 20, 2009 at 2:37 PM, laurent.dufrec...@gmail.com laurent.dufrec...@gmail.com wrote: Hello, Just another thread because this is not related to the exception handling. It seems that I misuse post-review. I was thinking that I had to launch it (wherever I was), and it would ask me what was my SVN repos, what was my diff file, ans it would send the update to the server. Seems it does no do that. It seems it is looking for some info about the repos. Does it took the info from REVIEWBOARD_URL = http://192.168.1.200/ reviews? If yes, admitting I have misconfigured my server (because it does not detect the SVN repos. How can I check my repos config? In fact I've also tried to declare a review via the web interface sending it a .diff. But trying to see diff, it show me a blank page. So what, Snv repos declaration is misconfigured. If yes, where could I find a log to check this? I must admit I'm a little bit lost. For the moment I haven't set the svn properties, just using .reviewboardrc but it doesn't seems to have any effect. REVIEWBOARD_URL = http://192.168.1.200/reviews; So what, more a server repos misconfig? Laurent --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How post-review must be used?
Hi christian your mail helps me!
svn info gave the URL. I didn't get for what it was used while reading the
doc.
The fact is there is a ' ' space in my repos URL, and it add to be
translated to %20 ... teah I know (I didn't choose the path name ;) )
so I changed the name from svn://www.xxx.com/mypath with space/etc/ by the
one taht svn info gave me:
svn://www.xxx.com/mypath%20with%20space/etc/ and now I got a traceback in
the web interface! Good
File
/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha4-py2.5.egg/reviewboard/scmtools/svn.py,
line 115, in get_file
raise SCMError('Login to the SCM server failed.')
SCMError: Login to the SCM server failed.
So now I have to double check my user/password and I think it will be ok :)
2009/3/20 Christian Hammond chip...@chipx86.com
You must set either the REVIEWBOARD_URL variable within .reviewboardrc or
set the reviewboard:url property on your SVN directory for the project.
The property is preferred, and there are instructions for this within the
post-review script.
The repository URL provided by running `svn info` is what you must use in
Review Board itself in the repository entry.
Did you create a Repository entry in the admin UI in Review Board, and what
is it set to?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com
On Fri, Mar 20, 2009 at 2:37 PM, laurent.dufrec...@gmail.com
laurent.dufrec...@gmail.com wrote:
Hello,
Just another thread because this is not related to the exception
handling.
It seems that I misuse post-review.
I was thinking that I had to launch it (wherever I was), and it would
ask me what was my SVN repos, what was my diff file, ans it would send
the update to the server.
Seems it does no do that. It seems it is looking for some info about
the repos.
Does it took the info from REVIEWBOARD_URL = http://192.168.1.200/
reviews?
If yes, admitting I have misconfigured my server (because it does not
detect the SVN repos. How can I check my repos config?
In fact I've also tried to declare a review via the web interface
sending it a .diff.
But trying to see diff, it show me a blank page. So what, Snv repos
declaration is misconfigured. If yes, where could I find a log to
check this?
I must admit I'm a little bit lost. For the moment I haven't set the
svn properties, just using .reviewboardrc but it doesn't seems to have
any effect.
REVIEWBOARD_URL = http://192.168.1.200/reviews;
So what, more a server repos misconfig?
Laurent
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: How post-review must be used?
OK that's better. I decided to first give a try to linux, since it seems your base platfrom. I've managed to post my first review that support diff. Here are some point you could find interesting (as I think I've done all the basic stupid things a newbie user will do): First a little exaplantion: My repos is like this: - www..xxx - project1 - porject 2 etc... 1) First in repos creation; I checkout project1 and so I thought in repos path in repos creation I thougth I had to put svn://www..xxx/project1. (copying svn info) It seems I only needed to put svn://www..xxx (and not svn://www..xxx/ ...) yeah, when I say that I did all the possible mistakes... 2)I think I've got a bug, each time I create a newreview: - modify a file - post-review Review request #10 posted. - then I access to my board it appears in draft I fill the missing things a) reviewer group b) description c) testing done d) summary - i click publish - I get an error 500 with no information - I reclick and all is then ok ... So all start to go not so bad ;) Finally I 've choosed to FORCE REVIEWBOARD_URL = http://192.168.X.XXX/reviews/; in the script And all is working very well. Will do some test under windows monday since I need to be on the local network for that :) Will do a little report, couls help you improve this interesting piece of software ;) Laurent On Mar 20, 10:50 pm, Christian Hammond chip...@chipx86.com wrote: You must set either the REVIEWBOARD_URL variable within .reviewboardrc or set the reviewboard:url property on your SVN directory for the project. The property is preferred, and there are instructions for this within the post-review script. The repository URL provided by running `svn info` is what you must use in Review Board itself in the repository entry. Did you create a Repository entry in the admin UI in Review Board, and what is it set to? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Mar 20, 2009 at 2:37 PM, laurent.dufrec...@gmail.com laurent.dufrec...@gmail.com wrote: Hello, Just another thread because this is not related to the exception handling. It seems that I misuse post-review. I was thinking that I had to launch it (wherever I was), and it would ask me what was my SVN repos, what was my diff file, ans it would send the update to the server. Seems it does no do that. It seems it is looking for some info about the repos. Does it took the info from REVIEWBOARD_URL = http://192.168.1.200/ reviews? If yes, admitting I have misconfigured my server (because it does not detect the SVN repos. How can I check my repos config? In fact I've also tried to declare a review via the web interface sending it a .diff. But trying to see diff, it show me a blank page. So what, Snv repos declaration is misconfigured. If yes, where could I find a log to check this? I must admit I'm a little bit lost. For the moment I haven't set the svn properties, just using .reviewboardrc but it doesn't seems to have any effect. REVIEWBOARD_URL = http://192.168.1.200/reviews; So what, more a server repos misconfig? Laurent --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
