Re: Trouble posting reviews since 1.0.1 upgrade
On Wed, Aug 12, 2009 at 23:53, Christian Hammondchip...@chipx86.com wrote: It sounds like it's actually using the ClearCase SCM instead of your own. Are you sure your repository entry is still mapping to your custom SCM? In 1.0, we accidentally left out the database entry for the ClearCase SCM, and added it back. When you did the rb-site upgrade, it probably replaced your entry with the ClearCase one. This is pretty much the problem with using the database for these registrations. I'm looking into doing some introspection to find all the available SCMs instead of looking them up from a database so that this won't be an issue in the future. You're right. Our SCM was replaced by ClearCase. After adding a new row for our SCM and fixing the configuration for the respective repository everything is working again. Thanks for the speedy help! Regards, Thilo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Trouble posting reviews since 1.0.1 upgrade
Hello everybody,
since upgrading from 1.0rc2 to 1.0.1 I have trouble posting reviews to
RB using a custom post-review implementation. The problem is that the
JSON response does not contain too many error details, just:
{fields: {path: [substring not found]}, stat: fail, err:
{msg: One or more fields had errors, code: 105}}
The log level is set to DEBUG, but nothing meaningful shows up in the log.
I am slightly lost how to determine the root cause of this issue. Any
advice how to diagnose it is highly appreciated.
Thanks,
Thilo
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Trouble posting reviews since 1.0.1 upgrade
Hello Christian, On Wednesday 12 August 2009 22:25:03 Christian Hammond wrote: There's another thread on this problem as well. Are you using ClearCase? no, this happens with a proprietary SCM, for which I added support to RB and post-review. So, I cannot rule out that my scm implementation is subtly broken and the error was masked in versions up to 1.0rc2. Regards, Thilo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Trouble posting reviews since 1.0.1 upgrade
Given that this error has been seen on both yours and ClearCase, it's possible it's somewhere internal to Review Board. Try this... Edit reviewboard/webapi/json.py, scroll down to the new_diff function, and locate the except Exception, e: line. Remove that whole block for that exception (including the except: line) and then restart your web server. If you run post-review with --debug again, you should see an error page instead (assuming you still have DEBUG set to True). I imagine this is where the error is being caught and turned into a field error. I'd really like to know what the results are of this test, and where the problem is. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Wed, Aug 12, 2009 at 1:41 PM, Thilo-Alexander Ginkel th...@ginkel.comwrote: Hello Christian, On Wednesday 12 August 2009 22:25:03 Christian Hammond wrote: There's another thread on this problem as well. Are you using ClearCase? no, this happens with a proprietary SCM, for which I added support to RB and post-review. So, I cannot rule out that my scm implementation is subtly broken and the error was masked in versions up to 1.0rc2. Regards, Thilo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Trouble posting reviews since 1.0.1 upgrade
It sounds like it's actually using the ClearCase SCM instead of your own. Are you sure your repository entry is still mapping to your custom SCM? In 1.0, we accidentally left out the database entry for the ClearCase SCM, and added it back. When you did the rb-site upgrade, it probably replaced your entry with the ClearCase one. This is pretty much the problem with using the database for these registrations. I'm looking into doing some introspection to find all the available SCMs instead of looking them up from a database so that this won't be an issue in the future. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Wed, Aug 12, 2009 at 2:27 PM, Thilo-Alexander Ginkel th...@ginkel.comwrote: On Wednesday 12 August 2009 22:55:44 Christian Hammond wrote: Given that this error has been seen on both yours and ClearCase, it's possible it's somewhere internal to Review Board. Try this... Edit reviewboard/webapi/json.py, scroll down to the new_diff function, and locate the except Exception, e: line. Remove that whole block for that exception (including the except: line) and then restart your web server. If you run post-review with --debug again, you should see an error page instead (assuming you still have DEBUG set to True). I imagine this is where the error is being caught and turned into a field error. I'd really like to know what the results are of this test, and where the problem is. Strangely, RB seems to route the diff upload through the ClearCase SCM. The error happens at: [...] reviewboard\scmtools\core.py:51 reviewboard\scmtools\clearcase.py:43 reviewboard\scmtools\clearcase.py:81: elem_path = elem_path[elem_path.rindex(vobs/)+5:] Vars: drive '' elem_path u'/MessageConfiguration.java' path u'/MessageConfiguration.java' Thanks, Thilo --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
