Re: Review Board 1.6 RC1 released
On Thu, Jun 23, 2011 at 10:55 PM, N.S.S.R.Murthy murthyn...@gmail.comwrote: Thank you Christian for quick reply. Please see my answers below. I don't see any screenshot attached, but did you create the repository in the administration UI? If we don't show it, then we generally couldn't load a valid repository. Yes, a valid SVN repository was created and used on 1.5.5 version. But I revisited it's configuration based on your suggestion above. When I tied to save the configuration, facing the error Unable to create directory /var/www/reviews.amer.actel.com/data/.subversion, which is needed for the Subversion configuration. Create this directory and set the web server's user as the the owner. Okay, then it should be just a matter of adding that and setting the permissions. I think I'm going to do some better checks for that after a server upgrade so you don't end up hitting it without realizing. Did you run 'rb-site upgrade' and restart your web server? I am just site admin. Our server admin surely ran the 'rb-site upgrade'. I will ask our server admin whether he restarted the server. Below are steps followed to upgrade. 1. Backed up MySQL with mysqldump 2. Backed up /var, /opt/memcache and /etc using tar. 3. root@wolf.62 easy_install -f http://downloads.reviewboard.org/releases/ReviewBoard/1.6/ -U http://downloads.reviewboard.org/releases/ReviewBoard/1.6/%0A-UReviewBoard 4. root@wolf.64 rb-site upgrade /var/www/reviews.amer.actel.com 5. root@wolf.65 service httpd restart 6. root@wolf.70 service memcached stop 7. root@wolf.71 service memcached start Can you look at the web server log files and reviewboard log files (you may have to enable logging in Admin - Settings - Logging) and see what errors show up? It seems a logs directory needs to be created for this. I will get it done and update you back. I don't understand what you mean here. What are you clicking? How are you generating the diff being posted to Review Board? How did you put anything up if #1 above wasn't working? The web UI is actually creating a review request with graphics only option. Then it is allowing to add file of any type. We can open these added files by clicking the link provided in the review request. But we cannot comment on this. May be this will be fixed if we add a valid repository. Ahh, I misunderstood what you were saying. Okay, I will take a look at that and get a fix in for 1.6. Would you mind filing a bug so we can better track it? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Bug in Reviewboard 1.6beta2 and 1.6RC1
Hi,
I have just hit an issue using post-review to upload a
post-commit review of a subversion revision range, specifying the
--bugs-closed paramter. I was using the 1.6beta2 version and have just
upgraded to 1.6RC1 and the problem still exists. The post-review is from
RBTools 0.3.2.
Uploading a diff without using the --bugs-closed option
works fine, creating a draft review which can then be updated through
the web ui. However if I try to use the --bugs-closed option, it creates
a review, but whenever trying to view the review through the ui, I get
the following Internal Server Error:
Exception thrown for user rcowa
at http://reviewboard/r/55/
not enough arguments for format
string
Traceback (most recent call last):
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/core/handlers/base.py,
line 111, in get_response
response = callback(request, *callback_args,
**callback_kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6rc1-py2.4.egg/reviewboard/accounts/decorators.py,
line 21, in _check
return view_func(*args, **kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6rc1-py2.4.egg/reviewboard/reviews/views.py,
line 433, in review_detail
RequestContext(request,
_make_review_request_context(review_request, {
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/shortcuts/__init__.py,
line 20, in render_to_response
return
HttpResponse(loader.render_to_string(*args, **kwargs),
**httpresponse_kwargs)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader.py,
line 183, in render_to_string
return t.render(Context(dictionary))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 123, in render
return self._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in _render
return self.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node, context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
return node.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader_tags.py,
line 127, in render
return compiled_parent._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in _render
return self.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node, context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
return node.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader_tags.py,
line 127, in render
return compiled_parent._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in _render
return self.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node, context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
return node.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader_tags.py,
line 64, in render
result = block.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node, context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
return node.render(context)
File
/usr/lib/python2.4/site-packages/Djblets-0.6.8-py2.4.egg/djblets/util/decorators.py,
line 186, in render
return self.tag_func(context, self.nodelist,
*args)
File
/usr/lib/python2.4/site-packages/Djblets-0.6.8-py2.4.egg/djblets/util/templatetags/djblets_deco.py,
line 42, in box
return render_to_string('deco/box.html', {
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node, context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
return node.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader_tags.py,
line 159, in render
return self.render_template(self.template,
context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader_tags.py,
line 141, in render_template
output = template.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 123, in render
return self._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in
Re: Bug in Reviewboard 1.6beta2 and 1.6RC1
We can fix this symptom, but it's due to a configuration issue. The bug
tracker configured for your repository is missing a %s.
I'll put a fix in tonight for the crash. It just won't set up a link without
a fixed URL.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Jun 24, 2011 at 1:14 AM, Rob Coward r...@jive-videos.net wrote:
**
Hi,
I have just hit an issue using post-review to upload a post-commit review
of a subversion revision range, specifying the --bugs-closed paramter. I was
using the 1.6beta2 version and have just upgraded to 1.6RC1 and the problem
still exists. The post-review is from RBTools 0.3.2.
Uploading a diff without using the --bugs-closed option works fine,
creating a draft review which can then be updated through the web ui.
However if I try to use the --bugs-closed option, it creates a review, but
whenever trying to view the review through the ui, I get the following
Internal Server Error:
Exception thrown for user rcowa at http://reviewboard/r/55/
not enough arguments for format string
Traceback (most recent call last):
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/core/handlers/base.py,
line 111, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6rc1-py2.4.egg/reviewboard/accounts/decorators.py,
line 21, in _check
return view_func(*args, **kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6rc1-py2.4.egg/reviewboard/reviews/views.py,
line 433, in review_detail
RequestContext(request, _make_review_request_context(review_request, {
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/shortcuts/__init__.py,
line 20, in render_to_response
return HttpResponse(loader.render_to_string(*args, **kwargs),
**httpresponse_kwargs)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader.py,
line 183, in render_to_string
return t.render(Context(dictionary))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 123, in render
return self._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in _render
return self.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node, context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
return node.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader_tags.py,
line 127, in render
return compiled_parent._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in _render
return self.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node, context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
return node.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader_tags.py,
line 127, in render
return compiled_parent._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in _render
return self.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node, context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
return node.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader_tags.py,
line 64, in render
result = block.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node, context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
return node.render(context)
File
/usr/lib/python2.4/site-packages/Djblets-0.6.8-py2.4.egg/djblets/util/decorators.py,
line 186, in render
return self.tag_func(context, self.nodelist, *args)
File
/usr/lib/python2.4/site-packages/Djblets-0.6.8-py2.4.egg/djblets/util/templatetags/djblets_deco.py,
line 42, in box
return render_to_string('deco/box.html', {
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node, context))
File
Re: Bug in Reviewboard 1.6beta2 and 1.6RC1
Ah, also just noticed that adding a bug number after the review was
created also triggers the error, confirming what you are saying about a
possible config issue rather than post-review doing something wrong.
In the repo admin screen I just have http://bugzilla.group.game.net;
as the Bug tracker URL and this used to work fine resulting in the
correct links (at least in 1.6beta1 - I dont remember if we have added
any new reviews since updating to 1.6beta2).
Was a change made
somewhere requiring the url to be specified as
http://bugzilla.group.game.net/show_bug.cgi?id=%s; ?
I've updated the
url against the repository in question and I'm still getting the same
error when trying to view a newly created review with a bug number
against it.
Regards,
Rob
On Fri, 24 Jun 2011 01:19:15 -0700,
Christian Hammond wrote:
Sorry, I spoke too soon. This is already
checked. The problem actually may be too many %s in the bug tracker URL.
Can you check if there's only one?
Christian
--
Christian
Hammond - chip...@chipx86.com [10]
Review Board -
http://www.reviewboard.org [11]
VMware, Inc. - http://www.vmware.com
[12]
On Fri, Jun 24, 2011 at 1:16 AM, Christian Hammond wrote:
We can fix this symptom, but it's due to a configuration issue. The
bug tracker configured for your repository is missing a %s.
I'll
put a fix in tonight for the crash. It just won't set up a link without
a fixed URL.
Christian
--
Christian Hammond -
chip...@chipx86.com [6]
Review Board - http://www.reviewboard.org
[7]
VMware, Inc. - http://www.vmware.com [8]
On Fri, Jun 24,
2011 at 1:14 AM, Rob Coward wrote:
Hi,
I have just hit
an issue using post-review to upload a post-commit review of a
subversion revision range, specifying the --bugs-closed paramter. I was
using the 1.6beta2 version and have just upgraded to 1.6RC1 and the
problem still exists. The post-review is from RBTools 0.3.2.
Uploading a diff without using the --bugs-closed option works fine,
creating a draft review which can then be updated through the web ui.
However if I try to use the --bugs-closed option, it creates a review,
but whenever trying to view the review through the ui, I get the
following Internal Server Error:
Exception thrown for user
rcowa at http://reviewboard/r/55/ [1]
not enough arguments for
format string
Traceback (most recent call last):
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/core/handlers/base.py,
line 111, in get_response
response = callback(request,
*callback_args, **callback_kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6rc1-py2.4.egg/reviewboard/accounts/decorators.py,
line 21, in _check
return view_func(*args, **kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6rc1-py2.4.egg/reviewboard/reviews/views.py,
line 433, in review_detail
RequestContext(request,
_make_review_request_context(review_request, {
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/shortcuts/__init__.py,
line 20, in render_to_response
return
HttpResponse(loader.render_to_string(*args, **kwargs),
**httpresponse_kwargs)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader.py,
line 183, in render_to_string
return
t.render(Context(dictionary))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 123, in render
return self._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in _render
return self.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node,
context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
return node.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader_tags.py,
line 127, in render
return compiled_parent._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in _render
return self.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node,
context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
return node.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader_tags.py,
line 127, in render
return compiled_parent._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in _render
return self.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node,
context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
Re: Bug in Reviewboard 1.6beta2 and 1.6RC1
I imagine the bug tracker was set to Bugzilla, with that being the bugzilla
server. What should happen is we should then auto-append the whole
show_bug.cgi?id=%s when saving the repository. Perhaps something went
wrong there. If you could try to reproduce that, by setting it back to
Bugzilla in the dropdown, it would help confirm that theory.
If you could also send a screenshot of the repository page (to me directly,
probably with portions blurred out) it would help me to see the state of
things.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Jun 24, 2011 at 1:47 AM, Rob Coward r...@jive-videos.net wrote:
**
Ah, also just noticed that adding a bug number after the review was created
also triggers the error, confirming what you are saying about a possible
config issue rather than post-review doing something wrong.
In the repo admin screen I just have http://bugzilla.group.game.net; as
the Bug tracker URL and this used to work fine resulting in the correct
links (at least in 1.6beta1 - I dont remember if we have added any new
reviews since updating to 1.6beta2).
Was a change made somewhere requiring the url to be specified as
http://bugzilla.group.game.net/show_bug.cgi?id=%s; ?
I've updated the url against the repository in question and I'm still
getting the same error when trying to view a newly created review with a bug
number against it.
Regards,
Rob
On Fri, 24 Jun 2011 01:19:15 -0700, Christian Hammond wrote:
Sorry, I spoke too soon. This is already checked. The problem actually may
be too many %s in the bug tracker URL. Can you check if there's only one?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Jun 24, 2011 at 1:16 AM, Christian Hammond chip...@chipx86.comwrote:
We can fix this symptom, but it's due to a configuration issue. The bug
tracker configured for your repository is missing a %s.
I'll put a fix in tonight for the crash. It just won't set up a link
without a fixed URL.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Jun 24, 2011 at 1:14 AM, Rob Coward r...@jive-videos.net wrote:
Hi,
I have just hit an issue using post-review to upload a post-commit review
of a subversion revision range, specifying the --bugs-closed paramter. I was
using the 1.6beta2 version and have just upgraded to 1.6RC1 and the problem
still exists. The post-review is from RBTools 0.3.2.
Uploading a diff without using the --bugs-closed option works fine,
creating a draft review which can then be updated through the web ui.
However if I try to use the --bugs-closed option, it creates a review, but
whenever trying to view the review through the ui, I get the following
Internal Server Error:
Exception thrown for user rcowa at http://reviewboard/r/55/
not enough arguments for format string
Traceback (most recent call last):
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/core/handlers/base.py,
line 111, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6rc1-py2.4.egg/reviewboard/accounts/decorators.py,
line 21, in _check
return view_func(*args, **kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6rc1-py2.4.egg/reviewboard/reviews/views.py,
line 433, in review_detail
RequestContext(request, _make_review_request_context(review_request, {
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/shortcuts/__init__.py,
line 20, in render_to_response
return HttpResponse(loader.render_to_string(*args, **kwargs),
**httpresponse_kwargs)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader.py,
line 183, in render_to_string
return t.render(Context(dictionary))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 123, in render
return self._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in _render
return self.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node, context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 757, in render_node
return node.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader_tags.py,
line 127, in render
return compiled_parent._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in _render
return self.nodelist.render(context)
File
Re: Review Board 1.6 RC1 released
On Thu, Jun 23, 2011 at 11:13 PM, Christian Hammond chip...@chipx86.comwrote: I don't understand what you mean here. What are you clicking? How are you generating the diff being posted to Review Board? How did you put anything up if #1 above wasn't working? The web UI is actually creating a review request with graphics only option. Then it is allowing to add file of any type. We can open these added files by clicking the link provided in the review request. But we cannot comment on this. May be this will be fixed if we add a valid repository. Ahh, I misunderstood what you were saying. Okay, I will take a look at that and get a fix in for 1.6. Would you mind filing a bug so we can better track it? Nevermind, we have a fix upstream. -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Bug in Reviewboard 1.6beta2 and 1.6RC1
Hi Christian,
I guess something in the database must have got
corrupted somehow. I changed the drop down, changed it back to Bugzilla
and re-saved the repository details and all seems to be working again
now. The reviews where I had added a bug number now display without
error, and I can upload new review using post-review with the
--bugs-closed option as well.
Thanks for the help
Rob
On Fri, 24
Jun 2011 01:58:24 -0700, Christian Hammond wrote:
I imagine the bug
tracker was set to Bugzilla, with that being the bugzilla server. What
should happen is we should then auto-append the whole
show_bug.cgi?id=%s when saving the repository. Perhaps something went
wrong there. If you could try to reproduce that, by setting it back to
Bugzilla in the dropdown, it would help confirm that theory.
If you
could also send a screenshot of the repository page (to me directly,
probably with portions blurred out) it would help me to see the state of
things.
Christian
--
Christian Hammond -
chip...@chipx86.com [24]
Review Board - http://www.reviewboard.org
[25]
VMware, Inc. - http://www.vmware.com [26]
On Fri, Jun 24,
2011 at 1:47 AM, Rob Coward wrote:
Ah, also just noticed that
adding a bug number after the review was created also triggers the
error, confirming what you are saying about a possible config issue
rather than post-review doing something wrong.
In the repo admin
screen I just have http://bugzilla.group.game.net [18] as the Bug
tracker URL and this used to work fine resulting in the correct links
(at least in 1.6beta1 - I dont remember if we have added any new reviews
since updating to 1.6beta2).
Was a change made somewhere
requiring the url to be specified as
http://bugzilla.group.game.net/show_bug.cgi?id=%s [19] ?
I've
updated the url against the repository in question and I'm still getting
the same error when trying to view a newly created review with a bug
number against it.
Regards,
Rob
On Fri, 24 Jun
2011 01:19:15 -0700, Christian Hammond wrote:
Sorry, I spoke
too soon. This is already checked. The problem actually may be too many
%s in the bug tracker URL. Can you check if there's only one?
Christian
--
Christian Hammond - chip...@chipx86.com
[10]
Review Board - http://www.reviewboard.org [11]
VMware, Inc.
- http://www.vmware.com [12]
On Fri, Jun 24, 2011 at 1:16 AM,
Christian Hammond wrote:
We can fix this symptom, but it's due
to a configuration issue. The bug tracker configured for your repository
is missing a %s.
I'll put a fix in tonight for the crash. It
just won't set up a link without a fixed URL.
Christian
--
Christian Hammond - chip...@chipx86.com [6]
Review
Board - http://www.reviewboard.org [7]
VMware, Inc. -
http://www.vmware.com [8]
On Fri, Jun 24, 2011 at 1:14 AM,
Rob Coward wrote:
Hi,
I have just hit an issue
using post-review to upload a post-commit review of a subversion
revision range, specifying the --bugs-closed paramter. I was using the
1.6beta2 version and have just upgraded to 1.6RC1 and the problem still
exists. The post-review is from RBTools 0.3.2.
Uploading a
diff without using the --bugs-closed option works fine, creating a draft
review which can then be updated through the web ui. However if I try to
use the --bugs-closed option, it creates a review, but whenever trying
to view the review through the ui, I get the following Internal Server
Error:
Exception thrown for user rcowa at
http://reviewboard/r/55/ [1]
not enough arguments for
format string
Traceback (most recent call last):
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/core/handlers/base.py,
line 111, in get_response
response = callback(request,
*callback_args, **callback_kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6rc1-py2.4.egg/reviewboard/accounts/decorators.py,
line 21, in _check
return view_func(*args, **kwargs)
File
/usr/lib/python2.4/site-packages/ReviewBoard-1.6rc1-py2.4.egg/reviewboard/reviews/views.py,
line 433, in review_detail
RequestContext(request,
_make_review_request_context(review_request, {
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/shortcuts/__init__.py,
line 20, in render_to_response
return
HttpResponse(loader.render_to_string(*args, **kwargs),
**httpresponse_kwargs)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/loader.py,
line 183, in render_to_string
return
t.render(Context(dictionary))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 123, in render
return self._render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 117, in _render
return self.nodelist.render(context)
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
line 744, in render
bits.append(self.render_node(node,
context))
File
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/template/base.py,
Re: post-reviews: The requested URL could not be retrieved
Hmm, let me try to start over. There's a file called .reviewboardrc that can be created, on windows I put it on %APPDATA% folder. It's meant for post-review settings. There's some info about it here: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#reviewboardrc It is a python file, so I created it and put the two lines below on it to set an environment variable that will cause post-review to bypass my proxy server, which requires authentication that i doesn't handle well: import os os.environ[no_proxy] = * It was the best way I found to automatically bypass proxy on each user's machine. On Wed, Jun 22, 2011 at 10:58 PM, ptrchen ptrc...@gmail.com wrote: How do I get parsed as a Python file? Got a link or instructions? Thanks! On Jun 22, 2:55 pm, Leonel Togniolli tognio...@gmail.com wrote: It's not. It's an optional file that you can create and add settings. It's parsed as a python file so that's why my workaround works. On Tue, Jun 21, 2011 at 8:36 PM, ptrchen ptrc...@gmail.com wrote: Looking at my %appdata% folder... Does .reviewboardrc get automatically installed? I don't see it in my %appdata% folder. Thanks! Peter On Jun 21, 12:42 pm, Leonel Togniolli tognio...@gmail.com wrote: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#r... On windows, I have it on each user's %appdata% folder. On Tue, Jun 21, 2011 at 4:20 PM, ptrchen ptrc...@gmail.com wrote: Hi Leonel, Thanks for the reply, but where may I find .reviewboardrc? Thanks! Peter On Jun 20, 4:42 am, Leonel Togniolli tognio...@gmail.com wrote: Hi ptrchen, I worked around this issue by adding two lines to .reviewboardrc import os os.environ[no_proxy] = * On Fri, Jun 17, 2011 at 7:48 PM, ptrchen ptrc...@gmail.com wrote: Hi Christian, I think this page suggestions that should address my issues, correct? http://groups.google.com/group/reviewboard/browse_thread/thread/69e33... On Jun 10, 4:54 pm, ptrchen ptrc...@gmail.com wrote: Sorry Chrisitan, never mind, I misread your post. I'll do some more digging for overriding the proxy configuration On Jun 10, 4:51 pm,ptrchenptrc...@gmail.com wrote: Ah, so would setting the environment variable in the command prompt window do the trick? On Jun 10, 4:32 pm, Christian Hammond chip...@chipx86.com wrote: We've seen people run into this sort of error with proxy servers. Regardless of your client-side proxy server configuration (say, in your Internet settings, on Windows), it may still use the proxy server on post-review. The error output looks very much like it came from a proxy server, meaning that the request is going out to the proxy, and the proxy can't find the domain. You'll need to blacklist it. I don't recall if it will at all respect this black list with Python running on Windows. If it's Linux, then you want to be sure your http_proxy environment variable isn't set. This has come up a couple of times, and it's clear we need a setting in post-review itself to just override the proxy configuration. If you search on this mailing list, you'll probably find a couple other solutions. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Fri, Jun 10, 2011 at 3:55 PM,ptrchenptrc...@gmail.com wrote: Sorry for not listing all the output, but company policy prohibits me from doing that. Yes, the error lists the hostname and FQDN Also, we do give it the FQDN following the --server option On Jun 10, 2:56 pm, Tucker j...@gmail.com wrote: Does the error actually only list the hostname and not the fully qualified name? If so, that may be part of your problem (throwing out guesses). Have you tried using the fully qualified name? On Fri, Jun 10, 2011 at 11:22 AM,ptrchenptrc...@gmail.com wrote: Hi Tucker, Thanks for the reply. I ran nslookup server_name from both server_name (XP server) and from a sparc-solaris2.10 machine. Both return Name: server_name.domain Address: ip_address On Jun 10, 11:15 am, Tucker j...@gmail.com wrote: You appear to have a DNS problem: Unable to determine IP address from host name for server_name. What does nslookup server_name say? On Thu, Jun 9, 2011 at 7:12 PM,ptrchenptrc...@gmail.com wrote: Hi, We've been trying to run post-review but have been running into a requested URL could not be retrieved error We're running: ReviewBoard 1.5.5 on Windows XP
Re: Issue 2106 in reviewboard: Diff updates after ship it
Comment #1 on issue 2106 by intro...@gmail.com: Diff updates after ship it http://code.google.com/p/reviewboard/issues/detail?id=2106 Same issue for our project. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2147 in reviewboard: enable site error
Updates: Status: NeedInfo Owner: chip...@gmail.com Labels: -Type-Defect Type-Support Comment #1 on issue 2147 by chip...@gmail.com: enable site error http://code.google.com/p/reviewboard/issues/detail?id=2147 Well that's a new one. So it's complaining about not being able to access os.environ['PATH']. It's showing up in META though. What I'd suggest is editing your Review Board Apache config and adding an explicit: SetEnv PATH /usr/local/bin:/usr/bin:/bin See if that fixes anything. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2147 in reviewboard: enable site error
Comment #2 on issue 2147 by sys520...@gmail.com: enable site error
http://code.google.com/p/reviewboard/issues/detail?id=2147
I try to change Review Board Apache config to:
IfModule mod_fcgid.c
AddHandler fcgid-script .fcgi
/IfModule
IfModule mod_fastcgi.c
AddHandler fastcgi-script .fcgi
FastCGIServer /var/www/reviews.example.com/htdocs/reviewboard.fcgi
-socket /var/www/reviews.example.com/tmp/fastcgi.sock
/IfModule
VirtualHost *:8080
ServerName test
DocumentRoot /var/www/reviews.example.com/htdocs
SetEnv PATH /usr/local/bin:/usr/bin:/bin
# Alias static media requests to filesystem
Alias /media /var/www/reviews.example.com/htdocs/media
Alias /errordocs /var/www/reviews.example.com/htdocs/errordocs
# Error handlers
ErrorDocument 500 /errordocs/500.html
Directory /var/www/reviews.example.com/htdocs
AllowOverride All
/Directory
# Direct all other requests to the fastcgi server
RewriteEngine on
IfModule mod_fcgid.c
RewriteRule ^/(media.*)$ /$1 [QSA,L,PT]
RewriteRule ^/(errordocs.*)$ /$1 [QSA,L,PT]
/IfModule
IfModule mod_fastcgi.c
RewriteRule ^/(media.*)$ /$1 [QSA,L,PT]
RewriteRule ^/(errordocs.*)$ /$1 [QSA,L,PT]
/IfModule
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^/(.*)$ /reviewboard.fcgi/$1 [QSA,L]
/VirtualHost
and restart apache2 , but error mistakes are still in.
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2134 in reviewboard: Diff breaks the review board.
Comment #3 on issue 2134 by natetas...@gmail.com: Diff breaks the review board. http://code.google.com/p/reviewboard/issues/detail?id=2134 Okay, I *think* I know what's causing *my* problem, but now I'm not sure that this is the same bug - it just appears to be. After banging my head against the code for a couple hours, though, I'm still not quite sure the best way to fix it. The issue is that in SVNTool.get_file, normpath is not correct - somehow, for me, path gets passed in as //trunk/tools/install.py (it is stored in the db this way), and normpath becomes svn://my.svn.url/repo//trunk/tools/install.py, which is not what is returned by self.client.propget - it returns svn://my.svn.url/repo/trunk/tools/install.py. So, mine is either a bug in generating the diff entry (as it should not have two leading slashes when stored - and if I build a command with `svn diff`, just like post-review does, my repo returns the files without slashes, so that's being added somehow in post processing, before the diff model is saved), or it's intended to be saved with two slashes, and there is an error with processing it in __normalize_revision -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
