Re: Announce - BitNami Windows installer for ReviewBoard
Hi, I have done reviewboard installation for my team and I have documented it here. http://technical-nonsense.blogspot.in/search/label/REVIEWBOARD%20INSTALLATION%20IN%20WINDOWS I am hoping that it might be useful. I have installed it on a 32 bit windows. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
getting and parsing a json apicall result
Hi Everybody!
I modified the serverside to make same validation, when submitting a
review. I made modification in webapi/resource.py in class
ReviewRequestResource(WebAPIResource). I modified the update function to
not submit a review if the validation is failed. I returning with http
response to client.
In /static/rb/js/review.js there is function call
gReviewRequest.close({
type: RB.ReviewRequest.CLOSE_SUBMITTED,
description: subdesc,
buttons: gDraftBannerButtons
});
This function make an HTTP PUT request to close the review. I would like to
get and process the answer. How can I get the answer. I am quite new in
Javascript and jQuery, but it seems that function call does not have any
return value. I tested with firebug the firefox get the answer for this
HTTP PUT request which is generated by this gReviewRequest.close function.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Enabling Searching on RB 1.7.21
Hi I am seeing a pylucene warning on my RB setting page: == Enable search Provides a search field for quickly searching through review requests. PyLucene (with JCC) is required to enable search. See the documentation for instructions. == Is this to mean that RB thinks that I do not have pylucene installed? I checked and it sure seems to have landed where python ought to find it: /.local/lib/python2.6/site-packages/lucene-3.6.2-py2.6-linux-x86_64.egg (!). this module can import in python without any error. [root@vm-fes-rb reviews]# python Python 2.6.6 (r266:84292, Jan 22 2014, 09:42:36) [GCC 4.4.7 20120313 (Red Hat 4.4.7-4)] on linux2 Type help, copyright, credits or license for more information. import lucene pip freeze will give lucene==3.6.2 JCC==2.15 ReviewBoard==1.7.21 any help here ? thx Stefan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
ReviewBoard 2.0beta2 for Fedora is now (semi-)available!
I have put together a testing repository of ReviewBoard 2.0 for interested parties to experiment with. This has not yet been committed to the standard Fedora repositories (due to it's beta nature). I am instead offering a COPR (Collection Of Package Repositories; Fedora's equivalent to Ubuntu's PPAs) for the 2.0 beta series. You can find this repository at http://copr.fedoraproject.org/coprs/sgallagh/ReviewBoard2/ and install either the Fedora 20 or Rawhide repository files by downloading them to /etc/yum.repos.d/ and then running 'yum install ReviewBoard' (or 'yum update ReviewBoard'). As this is pre-release software, PLEASE do not use this on a production system. Also, please do not file bugs against the Fedora package. Any issues encountered with ReviewBoard should be filed in the upstream tracker (except packaging issues which should be directed to me). If you're interested in trying it out, please give it a go! -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review only update testing-done field for existing request
How about from rbtools.api.client import RBClient server_url = https://server root # choose the review request Id # RRId=some review request number # choose the field to update RRDField=changedescription # the value to set RRDValue=This is a change description # connect to the server client=RBClient(server_url) # find the root object root=client.get_root() # get the review request rr=root.get_review_request(review_request_id=RRId) # make a new draft draft=rr.get_or_create_draft() # change the specified field update_args = RRDField + = \ + RRDValue+ \ eval (draft.update( + update_args + ) ) #publish the draft draft.update(public=True) On Tuesday, October 1, 2013 5:25:05 AM UTC-7, Lynn Lin wrote: Thanks,any hint to us to write a customize script to support this? On Tuesday, October 1, 2013 5:53:14 AM UTC+8, Christian Hammond wrote: --change-only really is intended only for Perforce, and will not work for this case. Today, you cannot set only a field without uploading a diff using post-review or rbt post. That would need to be added. It would be pretty easy, though, to write a custom script using the RBTools Python API to just upload the fields you want. We probably should introduce a command for setting fields only, but we don't have that today. Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Mon, Sep 30, 2013 at 2:34 PM, Steve seide...@gmail.com wrote: I haven't tried this, but does it work if you include the --change-only option? --steve On Saturday, September 28, 2013 8:04:36 PM UTC-7, Lynn Lin wrote: Environment: Git source code repostior y Linux ubuntu RBTools:0.5.2 Reviewboard:1.6.1 I try to *ONLY* update testing-done field for a existing review request on reviewboard through post-review here is my command: post-review --testing-done=cppcheck results,unit test results link abc -r 9906 -p output: There don't seem to be any diffs! Could post-review support only update testing-done field? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review only update testing-done field for existing request
For the update call, instead of using eval, just do:
fields = {
RRDField: RRDValue,
}
draft.update(fields)
or:
draft.update(**{
RRDField: RRDValue,
})
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On Thu, Jan 23, 2014 at 12:52 PM, markdbe...@gmail.com wrote:
How about
from rbtools.api.client import RBClient
server_url = https://server root
# choose the review request Id
# RRId=some review request number
# choose the field to update
RRDField=changedescription
# the value to set
RRDValue=This is a change description
# connect to the server
client=RBClient(server_url)
# find the root object
root=client.get_root()
# get the review request
rr=root.get_review_request(review_request_id=RRId)
# make a new draft
draft=rr.get_or_create_draft()
# change the specified field
update_args = RRDField + = \ + RRDValue+ \
eval (draft.update( + update_args + ) )
#publish the draft
draft.update(public=True)
On Tuesday, October 1, 2013 5:25:05 AM UTC-7, Lynn Lin wrote:
Thanks,any hint to us to write a customize script to support this?
On Tuesday, October 1, 2013 5:53:14 AM UTC+8, Christian Hammond wrote:
--change-only really is intended only for Perforce, and will not work
for this case.
Today, you cannot set only a field without uploading a diff using
post-review or rbt post. That would need to be added.
It would be pretty easy, though, to write a custom script using the
RBTools Python API to just upload the fields you want. We probably should
introduce a command for setting fields only, but we don't have that today.
Christian
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On Mon, Sep 30, 2013 at 2:34 PM, Steve seide...@gmail.com wrote:
I haven't tried this, but does it work if you include the --change-only
option?
--steve
On Saturday, September 28, 2013 8:04:36 PM UTC-7, Lynn Lin wrote:
Environment:
Git source code repostior
y Linux ubuntu
RBTools:0.5.2
Reviewboard:1.6.1
I try to *ONLY* update testing-done field for a existing review
request on reviewboard through post-review
here is my command:
post-review --testing-done=cppcheck results,unit test results link abc
-r 9906 -p
output:
There don't seem to be any diffs!
Could post-review support only update testing-done field?
--
Get the Review Board Power Pack at http://www.reviewboard.org/
powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google
Groups reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send
an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: ReviewBoard 2.0beta2 for Fedora is now (semi-)available!
Thanks, Stephen! That's above and beyond. Hope this makes it easier for some of you to try out the betas. We're making good progress on a third beta/RC, so keep the feedback coming! Christian On Thursday, January 23, 2014, Stephen Gallagher step...@gallagherhome.com wrote: I have put together a testing repository of ReviewBoard 2.0 for interested parties to experiment with. This has not yet been committed to the standard Fedora repositories (due to it's beta nature). I am instead offering a COPR (Collection Of Package Repositories; Fedora's equivalent to Ubuntu's PPAs) for the 2.0 beta series. You can find this repository at http://copr.fedoraproject.org/coprs/sgallagh/ReviewBoard2/ and install either the Fedora 20 or Rawhide repository files by downloading them to /etc/yum.repos.d/ and then running 'yum install ReviewBoard' (or 'yum update ReviewBoard'). As this is pre-release software, PLEASE do not use this on a production system. Also, please do not file bugs against the Fedora package. Any issues encountered with ReviewBoard should be filed in the upstream tracker (except packaging issues which should be directed to me). If you're interested in trying it out, please give it a go! -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com javascript:;. For more options, visit https://groups.google.com/groups/opt_out. -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review only update testing-done field for existing request
Yep, much better not to use eval(). thanks.
On Thursday, January 23, 2014 1:40:26 PM UTC-8, Christian Hammond wrote:
For the update call, instead of using eval, just do:
fields = {
RRDField: RRDValue,
}
draft.update(fields)
or:
draft.update(**{
RRDField: RRDValue,
})
--
Christian Hammond - chi...@chipx86.com javascript:
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On Thu, Jan 23, 2014 at 12:52 PM, markd...@gmail.com javascript:wrote:
How about
from rbtools.api.client import RBClient
server_url = https://server root
# choose the review request Id
# RRId=some review request number
# choose the field to update
RRDField=changedescription
# the value to set
RRDValue=This is a change description
# connect to the server
client=RBClient(server_url)
# find the root object
root=client.get_root()
# get the review request
rr=root.get_review_request(review_request_id=RRId)
# make a new draft
draft=rr.get_or_create_draft()
# change the specified field
update_args = RRDField + = \ + RRDValue+ \
eval (draft.update( + update_args + ) )
#publish the draft
draft.update(public=True)
On Tuesday, October 1, 2013 5:25:05 AM UTC-7, Lynn Lin wrote:
Thanks,any hint to us to write a customize script to support this?
On Tuesday, October 1, 2013 5:53:14 AM UTC+8, Christian Hammond wrote:
--change-only really is intended only for Perforce, and will not work
for this case.
Today, you cannot set only a field without uploading a diff using
post-review or rbt post. That would need to be added.
It would be pretty easy, though, to write a custom script using the
RBTools Python API to just upload the fields you want. We probably should
introduce a command for setting fields only, but we don't have that today.
Christian
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On Mon, Sep 30, 2013 at 2:34 PM, Steve seide...@gmail.com wrote:
I haven't tried this, but does it work if you include the
--change-only option?
--steve
On Saturday, September 28, 2013 8:04:36 PM UTC-7, Lynn Lin wrote:
Environment:
Git source code repostior
y Linux ubuntu
RBTools:0.5.2
Reviewboard:1.6.1
I try to *ONLY* update testing-done field for a existing review
request on reviewboard through post-review
here is my command:
post-review --testing-done=cppcheck results,unit test results link abc
-r 9906 -p
output:
There don't seem to be any diffs!
Could post-review support only update testing-done field?
--
Get the Review Board Power Pack at http://www.reviewboard.org/
powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google
Groups reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send
an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard...@googlegroups.com javascript:.
For more options, visit https://groups.google.com/groups/opt_out.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
rbtools: Could not load SCM Client ?
One of my users is getting the error message below when posting a review. The post succeeds. rbt post --debug 123456 ERROR:root:Could not load SCM Client svn: No module named etree ERROR:root:Could not load SCM Client git: No module named etree ERROR:root:Could not load SCM Client mercurial: No module named etree Maybe that should be a debug message, not error ? Thanks Mark -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: rbtools: Could not load SCM Client ?
oh it's rb tools v0.5.5 On Thursday, January 23, 2014 3:14:58 PM UTC-8, markd...@gmail.com wrote: One of my users is getting the error message below when posting a review. The post succeeds. rbt post --debug 123456 ERROR:root:Could not load SCM Client svn: No module named etree ERROR:root:Could not load SCM Client git: No module named etree ERROR:root:Could not load SCM Client mercurial: No module named etree Maybe that should be a debug message, not error ? Thanks Mark -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: rbtools: Could not load SCM Client ?
That should definitely be an error. That means Subversion (and Git and Mercurial) should be broken. I gather that install is using Python 2.4. Seems like xml.etree, which is a new dependency (shipped with Python), is non-existent for 2.4. We'll need to fix this in a point release. However, I recommend getting people onto newer versions of Python, and RBTools 0.6 will drop Python 2.4. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Thu, Jan 23, 2014 at 3:14 PM, markdbe...@gmail.com wrote: One of my users is getting the error message below when posting a review. The post succeeds. rbt post --debug 123456 ERROR:root:Could not load SCM Client svn: No module named etree ERROR:root:Could not load SCM Client git: No module named etree ERROR:root:Could not load SCM Client mercurial: No module named etree Maybe that should be a debug message, not error ? Thanks Mark -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: rbtools: Could not load SCM Client ?
ah right, and we were using Perforce. Still I can fix the Python version easy enough. Thanks, Christian ! On Thursday, January 23, 2014 3:17:48 PM UTC-8, Christian Hammond wrote: That should definitely be an error. That means Subversion (and Git and Mercurial) should be broken. I gather that install is using Python 2.4. Seems like xml.etree, which is a new dependency (shipped with Python), is non-existent for 2.4. We'll need to fix this in a point release. However, I recommend getting people onto newer versions of Python, and RBTools 0.6 will drop Python 2.4. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Thu, Jan 23, 2014 at 3:14 PM, markd...@gmail.com javascript: wrote: One of my users is getting the error message below when posting a review. The post succeeds. rbt post --debug 123456 ERROR:root:Could not load SCM Client svn: No module named etree ERROR:root:Could not load SCM Client git: No module named etree ERROR:root:Could not load SCM Client mercurial: No module named etree Maybe that should be a debug message, not error ? Thanks Mark -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
How to allow users to select their Group on Standard Registration
I was wondering if is possible to allow the users to select their group if standard registration is selected -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3202 in reviewboard: 'Last updated' column for review request in 'My Dashboard' page, displays incorrect time, if the server's and the client's time zones are different
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3202 by rajengin...@gmail.com: 'Last updated' column for review request in 'My Dashboard' page, displays incorrect time, if the server's and the client's time zones are different http://code.google.com/p/reviewboard/issues/detail?id=3202 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be rejected. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? Reviewboard 1.7.17 What's the URL of the page containing the problem? /rb/s/../dashboard What steps will reproduce the problem? 1.set the local system time zone as IST 2.set the server(review board installed box) time zone as PST 3.create a review request from local system 4.goto 'My dashboard' and see the 'All Incoming Review Requests' 5.see the 'Last updated' column of the newly created review request. 6.It may show the difference of 13 hours approximately,which seems to be wrong. What is the expected output? What do you see instead? It should show the actual time difference based on the server's time zone.And,it should mention the server's time zone. What operating system are you using? What browser? Linux , firefox 26.0 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3203 in reviewboard: rbt doesn't authenticate some requests
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3203 by mra...@rapitasystems.com: rbt doesn't authenticate some requests http://code.google.com/p/reviewboard/issues/detail?id=3203 What version are you running? 1.7.20 What steps will reproduce the problem? 1. Set up a web server configured for basic authentication over HTTPS 2. Set up a ReviewBoard install configured for authentication over LDAP 3. Ensure no .reviewboardrc is set for a user 3. Attempt to query ReviewBoard using manually-specified username and password: rbt status --server https://host/reviewboard --user user --password password What is the expected output? What do you see instead? rbt outputs: CRITICAL:root:HTTP 401 Attached is rpt --debug output. Please provide any additional information below. Apache access log shows two requests, with the second lacking any authorization: 127.0.0.1 - user [23/Jan/2014:14:35:19 +] GET /reviewboard/api/ HTTP/1.1 200 15665 - RBTools/0.5.5 127.0.0.1 - - [23/Jan/2014:14:35:20 +] GET /reviewboard/api/info/ HTTP/1.1 401 8817 - RBTools/0.5.5 This seems to be something to do with PresetHTTPAuthHandler in request.py being used again before reset and so not adding auth headers. Attachments: rbt debug.txt 2.9 KB -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Issue 3204 in reviewboard: Viewing review groups that you are watching no longer works.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3204 by erik.l...@gmail.com: Viewing review groups that you are watching no longer works. http://code.google.com/p/reviewboard/issues/detail?id=3204 What version are you running? 1.7.21 What's the URL of the page containing the problem? http://reviewboard/reviews/dashboard/?view=to-groupgroup=AutomationCouncil What steps will reproduce the problem? 1. Click on a review group that you are watching (but not subscribed to) 2. You'll get a 404 error What is the expected output? What do you see instead? I expect to see a list of reviews for that group; instead I get a does not exist page (404). What operating system are you using? What browser? OS X. Chrome. Please provide any additional information below. If I'm subscribed to the group, those views work but simply groups that I'm watching do not. It doesn't seem to matter if the group has 0 reviews or 0. The server is also raising the following exception: 2014-01-23 20:26:47,032 - ERROR - - Exception thrown for user erik.latt at http://reviewboard/reviews/dashboard/?view=to-groupgroup=AutomationCouncil Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/Django-1.4.10-py2.7.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/auth/util.py, line 47, in _checklogin return view_func(request, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/accounts/decorators.py, line 52, in _check_valid_prefs return view_func(request, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/reviews/views.py, line 840, in dashboard return grid.render_to_response(template_name, extra_context=context) File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/datagrid/grids.py, line 794, in render_to_response self.load_state(render_context) File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/datagrid/grids.py, line 579, in load_state if self.load_extra_state(profile): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.21-py2.7.egg/reviewboard/reviews/datagrids.py, line 684, in load_extra_state raise Http404 Http404 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3204 in reviewboard: Viewing review groups that you are watching no longer works.
Comment #1 on issue 3204 by erik.l...@gmail.com: Viewing review groups that you are watching no longer works. http://code.google.com/p/reviewboard/issues/detail?id=3204 Ah, it looks like this is somewhat by design: https://github.com/reviewboard/reviewboard/commit/d0611ab9b407814bfd5ce0cd0d4c8ebd5f40f1ba However, I feel that this makes the watched groups feature pointless. I understand the need to honor private groups but couldn't couldn't we just check if Group.is_accessible_by() rather than checking if the user is a member of the group? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3204 in reviewboard: Viewing review groups that you are watching no longer works.
Updates: Status: Confirmed Labels: Milestone-Release1.7.x Comment #2 on issue 3204 by chip...@gmail.com: Viewing review groups that you are watching no longer works. http://code.google.com/p/reviewboard/issues/detail?id=3204 Sort of by design, but it wasn't intended to impact watched groups. Those should be allowed as well, so long as the user has access. We'll want to fix this. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3204 in reviewboard: Viewing review groups that you are watching no longer works.
Updates: Labels: EasyFix Comment #3 on issue 3204 by chip...@gmail.com: Viewing review groups that you are watching no longer works. http://code.google.com/p/reviewboard/issues/detail?id=3204 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 3204 in reviewboard: Viewing review groups that you are watching no longer works.
Comment #4 on issue 3204 by jmm.lind...@gmail.com: Viewing review groups that you are watching no longer works. http://code.google.com/p/reviewboard/issues/detail?id=3204 I will take a look on this. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
