404 when adding line comment
I just got Review Board up and running today using Apache+mod_python
+memcache on Windows (py25).
First question: Is this the right group to post a question to? :)
Things seem to work fairly smoothly, but when I try to save a comment
to a line of code in a diff I get a 404 at the top of the screen.
Looking at my apache log I see the following:
No FileDiff matches the given query.
Traceback (most recent call last):
File c:\python25\lib\site-packages\django-1.1-py2.5.egg\django\core
\handlers\base.py, line 92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File c:\python25\lib\site-packages\django-1.1-py2.5.egg\django\views
\decorators\cache.py, line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File c:\python25\lib\site-packages\ReviewBoard-1.1alpha1-py2.5.egg
\reviewboard\webapi\decorators.py, line 20, in _check
return view_func(request, *args, **kwargs)
File c:\python25\lib\site-packages\ReviewBoard-1.1alpha1-py2.5.egg
\reviewboard\webapi\json.py, line 1345, in diff_line_comments
diffset__revision=diff_revision)
File c:\python25\lib\site-packages\django-1.1-py2.5.egg\django
\shortcuts\__init__.py, line 87, in get_object_or_404
raise Http404('No %s matches the given query.' %
queryset.model._meta.object_name)
Http404: No FileDiff matches the given query.
The diff was uploaded via the post-review tool.
Pv
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: 404 when adding line comment
Yes, I meant to install and try out the dev version.
The review was still a draft and had not been published.
I published the review and could make a comment fine.
I did a quick discussion search for 404 (and related), but did not see
anything.
Also interesting, when I had the review in draft and used the admin to
view the review request draft to change I got a 500 error.
Once published I can admin the non-draft review just fine.
Pv
On Sep 23, 5:05 pm, Christian Hammond chip...@chipx86.com wrote:
Hi,
Yep, this is the right mailing list.
So first of all, did you mean to install the in-development version? That's
perfectly fine, but I want to make sure.
Was the review request published? Or did you leave a comment on the diff
before publishing the review request? That will cause this. There's a bug or
two open on this somewhere.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Wed, Sep 23, 2009 at 4:56 PM, Pv p...@swooby.com wrote:
I just got Review Board up and running today using Apache+mod_python
+memcache on Windows (py25).
First question: Is this the right group to post a question to? :)
Things seem to work fairly smoothly, but when I try to save a comment
to a line of code in a diff I get a 404 at the top of the screen.
Looking at my apache log I see the following:
No FileDiff matches the given query.
Traceback (most recent call last):
File c:\python25\lib\site-packages\django-1.1-py2.5.egg\django\core
\handlers\base.py, line 92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File c:\python25\lib\site-packages\django-1.1-py2.5.egg\django\views
\decorators\cache.py, line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File c:\python25\lib\site-packages\ReviewBoard-1.1alpha1-py2.5.egg
\reviewboard\webapi\decorators.py, line 20, in _check
return view_func(request, *args, **kwargs)
File c:\python25\lib\site-packages\ReviewBoard-1.1alpha1-py2.5.egg
\reviewboard\webapi\json.py, line 1345, in diff_line_comments
diffset__revision=diff_revision)
File c:\python25\lib\site-packages\django-1.1-py2.5.egg\django
\shortcuts\__init__.py, line 87, in get_object_or_404
raise Http404('No %s matches the given query.' %
queryset.model._meta.object_name)
Http404: No FileDiff matches the given query.
The diff was uploaded via the post-review tool.
Pv
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
easy_install rbtools on py26?
I had ActivePython 2.6 installed and installed ezsetup for py26 (on a x64 Windows 2K8 Server). I then tried easy_install rbtools and it failed when installing the simplejson egg. easy_install simplejson also fails with the same error. The simplejson site says that py26 includes json and that simplejson is for legacy support on 2.5 2.4. So why does easy_install rbtools want to install simplejson? Thanks! Pv --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
RBTools 0.2beta2 halts/fails outputting Cannot display: file marked as a binary type
I am doing a post-commit review on a teammate's checked in C# code on an SVN server. I run: post-review -d --revision-range=24506 And I get the following output: svn info repository info: Path: svn://devsrvsea01/svnroot, Base path: /trunk/StopProcess, Supports changesets: False svn propget reviewboard:url C:\src\trunk\StopProcess svn propget reviewboard:url C:\src\trunk\ svn diff --diff-cmd=diff -r 24506 Failed to execute command: ['svn', 'diff', '--diff-cmd=diff', '-r', '24506'] ['Index: StopProcess/obj/Debug/StopProcess.exe\n', '=== \n', 'Cannot display: file marked as a binary type.\n', 'svn:mime-type = application/octet-stream\n', 'Index: StopProcess/obj/Debug/ StopProcess.pdb\n', '=== \n', 'Cannot display: file marked as a binary type.\n', 'svn:mime-type = application/octet-stream\n', 'Index: StopProcess/obj/Debug/StopProcess.csproj.FileListAbsolute.txt\n', ' ===\n', svn: Can't start process 'diff': The system cannot find the file specified. \n] I understand the origin of the error, but the code of post-review looks like it should ignore this. Am I doing something wrong? Pv --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: RBTools 0.2beta2 halts/fails outputting Cannot display: file marked as a binary type
Duh! This is a diff problem that I ran in to before...fixing now. Pv On Oct 29, 10:43 am, Pv p...@swooby.com wrote: I am doing a post-commit review on a teammate's checked in C# code on an SVN server. I run: post-review -d --revision-range=24506 And I get the following output: svn info repository info: Path: svn://devsrvsea01/svnroot, Base path: /trunk/StopProcess, Supports changesets: False svn propget reviewboard:url C:\src\trunk\StopProcess svn propget reviewboard:url C:\src\trunk\ svn diff --diff-cmd=diff -r 24506 Failed to execute command: ['svn', 'diff', '--diff-cmd=diff', '-r', '24506'] ['Index: StopProcess/obj/Debug/StopProcess.exe\n', '=== \n', 'Cannot display: file marked as a binary type.\n', 'svn:mime-type = application/octet-stream\n', 'Index: StopProcess/obj/Debug/ StopProcess.pdb\n', '=== \n', 'Cannot display: file marked as a binary type.\n', 'svn:mime-type = application/octet-stream\n', 'Index: StopProcess/obj/Debug/StopProcess.csproj.FileListAbsolute.txt\n', ' ===\n', svn: Can't start process 'diff': The system cannot find the file specified. \n] I understand the origin of the error, but the code of post-review looks like it should ignore this. Am I doing something wrong? Pv --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: RBTools 0.2beta2 halts/fails outputting Cannot display: file marked as a binary type
Opened 1378 Pv On Oct 29, 11:34 am, Christian Hammond chip...@chipx86.com wrote: Glad you figured it out. We need to check for that and fail gracefully. Would you mind filing a bug so we can track it for the release? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Oct 29, 2009 at 11:10 AM, Pv p...@swooby.com wrote: Yes, it was a simple diff not being in my path problem. Pv On Oct 29, 10:49 am, Pv p...@swooby.com wrote: Duh! This is a diff problem that I ran in to before...fixing now. Pv On Oct 29, 10:43 am, Pv p...@swooby.com wrote: I am doing a post-commit review on a teammate's checked in C# code on an SVN server. I run: post-review -d --revision-range=24506 And I get the following output: svn info repository info: Path: svn://devsrvsea01/svnroot, Base path: /trunk/StopProcess, Supports changesets: False svn propget reviewboard:url C:\src\trunk\StopProcess svn propget reviewboard:url C:\src\trunk\ svn diff --diff-cmd=diff -r 24506 Failed to execute command: ['svn', 'diff', '--diff-cmd=diff', '-r', '24506'] ['Index: StopProcess/obj/Debug/StopProcess.exe\n', '=== \n', 'Cannot display: file marked as a binary type.\n', 'svn:mime-type = application/octet-stream\n', 'Index: StopProcess/obj/Debug/ StopProcess.pdb\n', '=== \n', 'Cannot display: file marked as a binary type.\n', 'svn:mime-type = application/octet-stream\n', 'Index: StopProcess/obj/Debug/StopProcess.csproj.FileListAbsolute.txt\n', ' ===\n', svn: Can't start process 'diff': The system cannot find the file specified. \n] I understand the origin of the error, but the code of post-review looks like it should ignore this. Am I doing something wrong? Pv To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
How to post-commit review a first time checkin?
I am using the following command to do a post-commit review on a first
time checkin:
post-review -d --revision-range=24506
Obviously, I am not specifying a from:to range, but since this is a
first time checking any earlier from svn rev # wouldn't exist in the
newly created path.
The [debug] output I get is this:
svn info
repository info: Path: svn://devsrvsea01/svnroot, Base path:
/trunk/StopProcess, Supports changesets: False
svn propget reviewboard:url C:\svns\tps\trunk\StopProcess
svn propget reviewboard:url C:\svns\tps\trunk\
svn diff --diff-cmd=diff -r 24506
Looking for '10.100.120.86 /' cookie in C:\Documents and
Settings\User\Local Settings\Application Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP GETting /api/json/repositories/
HTTP GETting /api/json/repositories/1/info/
repository info: Path: svn://devsrvsea01/svnroot, Base path:
/trunk/TPS/QA/StopProcess, Supports changesets: False
HTTP POSTing to http://10.100.120.86/api/json/reviewrequests/new/:
{'repository_path': 'svn://devsrvsea01/svnroot'}
Review request created
Uploading diff, size: 0
HTTP POSTing to http://10.100.120.86/api/json/reviewrequests/14/diff/new/:
{'basedir': '/trunk/TPS/QA/StopProcess'}
Error uploading diff: One or more fields had errors (105)
{'fields': {'path': ['The submitted file is empty.']}, 'stat': 'fail',
'err': {'msg': 'One or more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.
Since
--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: easy_install rbtools on py26?
http://code.google.com/p/reviewboard/issues/detail?id=1383 On Nov 2, 12:42 pm, Christian Hammond chip...@chipx86.com wrote: Can you file a bug on this? We just need to turn off the sqlite dependency when building Python 2.6 packages. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Oct 29, 2009 at 10:37 AM, Pv p...@swooby.com wrote: I had ActivePython 2.6 installed and installed ezsetup for py26 (on a x64 Windows 2K8 Server). I then tried easy_install rbtools and it failed when installing the simplejson egg. easy_install simplejson also fails with the same error. The simplejson site says that py26 includes json and that simplejson is for legacy support on 2.5 2.4. So why does easy_install rbtools want to install simplejson? Thanks! Pv To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review error: WindowsError: [Error 2] The system cannot find the file specified
I ran in to the same thing and opened a bug to make a missing diff
binary a friendlier message.
Pv
On Nov 6, 10:24 pm, Akhilesh akhileshjo...@gmail.com wrote:
After a lot of troubleshooting I found the problem: diff.exe was not
present in the PATH.
On Nov 6, 2:57 pm, Akhilesh akhileshjo...@gmail.com wrote:
I have setup Reviewboard on Windows and now setting up post-review on
client machine so that I can start creating review requests.
I'm getting following error:
C:\p4post-review 25159 -d p4 info
repository info: Path: ssb-sc.mimosasystems.com:1666, Base path: None,
Supports changesets: True
p4 counters
Generating diff for changenum 25159
p4 describe -s 25159
Processing edit of
//mimosa/dev/dev-EWS/Products/FDA/Components/MsiIndexer/DocumentIndexer/Ind
exDisposer.cs
Writing
//mimosa/dev/dev-EWS/Products/FDA/Components/MsiIndexer/DocumentIndexer/In
dexDisposer.cs#4 to c:\docume~1\admini~1.jam\locals~1\temp\tmp2gtu3-
p4 print -o c:\docume~1\admini~1.jam\locals~1\temp\tmp2gtu3- -q
//mimosa/dev/dev-EWS/Products/FDA/Components/MsiIndexer/DocumentIndexer/Ind
exDisposer.cs#4
Writing
//mimosa/dev/dev-EWS/Products/FDA/Components/MsiIndexer/DocumentIndexer/In
dexDisposer.cs#5 to c:\docume~1\admini~1.jam\locals~1\temp\tmpxqneeh
p4 print -o c:\docume~1\admini~1.jam\locals~1\temp\tmpxqneeh -q
//mimosa/dev/dev-EWS/Products/FDA/Components/MsiIndexer/DocumentIndexer/Ind
exDisposer.cs#5
diff -urNp c:\docume~1\admini~1.jam\locals~1\temp\tmp2gtu3-
c:\docume~1\admini~1.jam\locals~1\temp\tmpxqneeh
Traceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in
module
load_entry_point('RBTools==0.2beta2', 'console_scripts', 'post-
review')()
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line
2511, in main
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line
1358, in diff
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line
1609, in _changenum_diff
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line
1639, in _do_diff
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line
2112, in execute
File C:\Python25\lib\subprocess.py, line 593, in __init__
errread, errwrite)
File C:\Python25\lib\subprocess.py, line 793, in _execute_child
startupinfo)
WindowsError: [Error 2] The system cannot find the file specified
C:\p4
Any ideas?
--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Can't create/edit repo w/ 20091110 nightly build
I've fought this one all day while setting up a new RB server. Server: W2K3, Apache2.2, Python25, plus all of the other required trimmings. I have installed 2 other RB servers [on XP] and hadn't seen this problem before. I install the server and can log in and create users and change other various settings (and they stick). However, when I add a [SVN] Repo the server hangs for a few seconds when I click Save and then the page clears and [depending on the browser] an error is displayed. In Chrome the error is: This webpage is not available. The webpage at http://codereview/admin/db/scmtools/repository/2/ might be temporarily down or it may have moved permanently to a new web address. More information on this error Below is the original error message Error 101 (net::ERR_CONNECTION_RESET): Unknown error. In IE the error page is pretty much useless. I have what I think is full logging enabled in Apache and RB, but nothing useful is getting written. I had a workaround where I uninstalled the Nightly build, installed 1.1, and then could successfully add my SVN repos. I then upgraded back to the Nightly, ran rb-site upgrade, and could see the created repos. I then went in to edit/change them and as soon as I clicked Save the same problem occured. I am getting ready to fire up a dev version... Is there a handy wayto run an installed version in a console [in Windows] (outside of Apache)? --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Can't create/edit repo w/ 20091110 nightly build
Running dev version does same thing; it immediately quits.
The output is:
Running dependency checks (set DEBUG=False to turn this off)...
Warning: p4python (=07.3) not found. Perforce integration will not
work.
Warning: hg not found. Mercurial integration will not work.
Warning: PyLucene (with JCC) is required to enable search. See the
documentation for instructions.
Warning: cvs binary not found. CVS integration will not work.
Warning: git binary not found. Git integration will not work.
Warning: mtn binary not found. Monotone integration will not work.
Please see http://www.reviewboard.org/docs/manual/dev/admin/
for help setting up Review Board.
Validating models...
0 errors found
Django version 1.1.1, using settings 'reviewboard.settings'
Development server is running at http://0.0.0.0:8080/
Quit the server with CTRL-BREAK.
2009-11-10 18:22:58,647 - INFO - Logging to .\reviewboard.log with a
minimum level of DEBUG
2009-11-10 18:22:58,647 - INFO - Log file for Review Board v1.1 alpha
2 (dev) (PID 3824)
[10/Nov/2009 18:22:59] GET /admin/db/scmtools/repository/add/ HTTP/
1.1 304 0
[10/Nov/2009 18:22:59] GET /media/rb/css/admin.css?1257541875 HTTP/
1.1 304 0
[10/Nov/2009 18:22:59] GET /admin/db/jsi18n/ HTTP/1.1 200 353
[10/Nov/2009 18:22:59] GET /media/djblets/js/jquery-1.3.2.min.js HTTP/
1.1 304 0
[10/Nov/2009 18:22:59] GET /media/rb/js/repositoryform.js?
{{MEDIA_SERIAL} HTTP/1.1 304 0
...and then it exits back to the command-prompt.
--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Can't create/edit repo w/ 20091110 nightly build
Well, I cleaned my W2K3 Server's Python25 directory and reinstalled all required modules and things started to work fine. I inherited the machine, and I guess it was in a dirty state. :( All is good now! Pv --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1
NOTE: If I manually browse to my reviewboard server and upload the
diff it accepts it no problem.
I am not doing anything to intentionally encode these files beyond the
default VS2K8 encoding.
Pv
On Feb 23, 4:20 pm, Pv p...@swooby.com wrote:
I have installed a fresh copy of Win7 x64 and VS2K8.
I then installed Py2.6 + RBTools 0.2rc1.
I create a new C# project, svn add, and then post-review the project.
I get a UnicodeDecodeError on the Solution's/Project's xml/config
files.
There is a signature of \xef\xbb\xbf at the beginning of these
files.
So I do this:
c:\svn diff --diff-cmd=diff output.txt
c:\python.exef = open('output.txt')
s = f.read()
unicode(s)
...
UnicodeDecodeError: ...
NOTE that a s.encode('utf8') seems to work fine, but if I alter
rbtools to do that, the reviewboard server croaks on the upload.
Has anyone seen this issue recently?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1
1.1 alpha 2 (dev)
I am pretty sure this aborts in RBTools itself before it ever gets to
the server.
Again, a manual upload of the diff file to the server works fine.
Pv
On Feb 23, 5:27 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Pv,
Which version of Review Board is this?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Feb 23, 2010 at 4:26 PM, Pv p...@swooby.com wrote:
NOTE: If I manually browse to my reviewboard server and upload the
diff it accepts it no problem.
I am not doing anything to intentionally encode these files beyond the
default VS2K8 encoding.
Pv
On Feb 23, 4:20 pm, Pv p...@swooby.com wrote:
I have installed a fresh copy of Win7 x64 and VS2K8.
I then installed Py2.6 + RBTools 0.2rc1.
I create a new C# project, svn add, and then post-review the project.
I get a UnicodeDecodeError on the Solution's/Project's xml/config
files.
There is a signature of \xef\xbb\xbf at the beginning of these
files.
So I do this:
c:\svn diff --diff-cmd=diff output.txt
c:\python.exef = open('output.txt')
s = f.read()
unicode(s)
...
UnicodeDecodeError: ...
NOTE that a s.encode('utf8') seems to work fine, but if I alter
rbtools to do that, the reviewboard server croaks on the upload.
Has anyone seen this issue recently?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr
oups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1
FYI: I ran an older version of post-review on the same code and it
uploaded just fine.
I easy_install -U rbtools and ran post-review -r # and it failed
w/ the UnicodeDecodeError.
Again, the files post-review is having a hard time with use the
default encoding of Visual Studio 2008.
After running in to the problem w/ default encoding I have tried
saving the culprit files w/ various other encodings, but nothing seems
to make post-review happy.
Pv
On Feb 24, 4:55 pm, Pv p...@swooby.com wrote:
1.1 alpha 2 (dev)
I am pretty sure this aborts in RBTools itself before it ever gets to
the server.
Again, a manual upload of the diff file to the server works fine.
Pv
On Feb 23, 5:27 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Pv,
Which version of Review Board is this?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Feb 23, 2010 at 4:26 PM, Pv p...@swooby.com wrote:
NOTE: If I manually browse to my reviewboard server and upload the
diff it accepts it no problem.
I am not doing anything to intentionally encode these files beyond the
default VS2K8 encoding.
Pv
On Feb 23, 4:20 pm, Pv p...@swooby.com wrote:
I have installed a fresh copy of Win7 x64 and VS2K8.
I then installed Py2.6 + RBTools 0.2rc1.
I create a new C# project, svn add, and then post-review the project.
I get a UnicodeDecodeError on the Solution's/Project's xml/config
files.
There is a signature of \xef\xbb\xbf at the beginning of these
files.
So I do this:
c:\svn diff --diff-cmd=diff output.txt
c:\python.exef = open('output.txt')
s = f.read()
unicode(s)
...
UnicodeDecodeError: ...
NOTE that a s.encode('utf8') seems to work fine, but if I alter
rbtools to do that, the reviewboard server croaks on the upload.
Has anyone seen this issue recently?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr
oups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1
Yes, I just commented that out and the upload was successful. Pv On Feb 25, 12:25 pm, Thilo-Alexander Ginkel th...@ginkel.com wrote: On Thursday 25 February 2010 01:55:42 Pv wrote: I am pretty sure this aborts in RBTools itself before it ever gets to the server. Again, a manual upload of the diff file to the server works fine. Couldhttp://reviews.reviewboard.org/r/1298/have caused this? Regards, Thilo -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1
It should have been:
return content_type, content.encode('utf-8', 'ignore')
Pv
On Feb 25, 12:43 pm, Pv p...@swooby.com wrote:
Yes, I just commented that out and the upload was successful.
Pv
On Feb 25, 12:25 pm, Thilo-Alexander Ginkel th...@ginkel.com
wrote:
On Thursday 25 February 2010 01:55:42 Pv wrote:
I am pretty sure this aborts in RBTools itself before it ever gets to
the server.
Again, a manual upload of the diff file to the server works fine.
Couldhttp://reviews.reviewboard.org/r/1298/havecaused this?
Regards,
Thilo
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1
Actually, that doesn't work either.
This stuff has always blown my mind a bit:
s = 'La Pe\xf1a'
print s
La Pe±a
s.encode('utf8')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not in range(128)
s.encode('utf8','ignore')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not in range(128)
s.encode('utf8','replace')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not in range(128)
u = unicode(s, 'utf8')
Traceback (most recent call last):
File stdin, line 1, in module
File C:\Python25\lib\encodings\utf_8.py, line 16, in decode
return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode bytes in position 5-6:
unexpected end of data
u = unicode(s, 'utf8', 'ignore')
u
u'La Pe'
u = unicode(s, 'utf8', 'replace')
u
u'La Pe\ufffd'
I don't know the best final result for the upload would be.
Pv
On Feb 25, 12:48 pm, Pv p...@swooby.com wrote:
It should have been:
return content_type, content.encode('utf-8', 'ignore')
Pv
On Feb 25, 12:43 pm, Pv p...@swooby.com wrote:
Yes, I just commented that out and the upload was successful.
Pv
On Feb 25, 12:25 pm, Thilo-Alexander Ginkel th...@ginkel.com
wrote:
On Thursday 25 February 2010 01:55:42 Pv wrote:
I am pretty sure this aborts in RBTools itself before it ever gets to
the server.
Again, a manual upload of the diff file to the server works fine.
Couldhttp://reviews.reviewboard.org/r/1298/havecausedthis?
Regards,
Thilo
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1
Sorry for the poor formatting (couldn't find how to edit the previous
post):
s = 'La Pe\xf1a'
print s
La Pe±a
s.encode('utf8')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not in range(128)
s.encode('utf8','ignore')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not in range(128)
s.encode('utf8','replace')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not in range(128)
u = unicode(s, 'utf8')
Traceback (most recent call last):
File stdin, line 1, in module
File C:\Python25\lib\encodings\utf_8.py, line 16, in decode
return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode bytes in position 5-6:
unexpected end of data
u = unicode(s, 'utf8', 'ignore')
u
u'La Pe'
u = unicode(s, 'utf8', 'replace')
u
u'La Pe\ufffd'
Pv
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: RBTools UnicodeDecodeError of fresh VS2K8 project from fresh Win7 x64 + Py26 + RBTools0.2RC1
Considering all Visual Studio 2008 new source code files have initial
unicode BOM characters, any diff of source files from a default VS
install should do.
I am surprised *anyone* that uses VS can use post-review.
I set up a new user on the latest RBTools and had them modify a
checked in file and run post-review.
post-review failed w/ the same error code.
I deleted their rbtools egg file and re-installed RBTools using the
following command:
easy_install -Z -U rbtools
I then went in to the rbtools postreview.py file, and changed:
return content_type, content.encode('utf-8')
to:
return content_type, content#.encode('utf-8')
The user's post-review worked fine after that.
Notably, this explains why *all* of my VS source file reviews have a
red rectangle boxing some token char(s) at the beginning of the
diff(s).
That is the BOM char that reviewboard doesn't like.
The post-review utf8 patch was intended to remove those...but I
don't think removing them is the best solution.
It would be best if reviewboard itself could just display the unicode
chars, optionally without boxing them in a red rectangle.
It would also be nice if reviewboard diffs wouldn't put a red
rectangle around the initial BOM chars.
The existence of BOM chars is normal and should be gracefully/silently
ignored.
A red box indicates to me an error/warning of some sort.
If the BOM differs between the two files then that should be
gracefully indicated.
Pv
On Feb 26, 11:13 am, Christian Hammond chip...@chipx86.com wrote:
Mine too. We really need some example diffs that break things so we can put
them into the unit test suite and verify when we fix it that other diffs
don't break.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Feb 25, 2010 at 1:03 PM, Pv p...@swooby.com wrote:
Sorry for the poor formatting (couldn't find how to edit the previous
post):
s = 'La Pe\xf1a'
print s
La Pe±a
s.encode('utf8')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not in range(128)
s.encode('utf8','ignore')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not in range(128)
s.encode('utf8','replace')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not in range(128)
u = unicode(s, 'utf8')
Traceback (most recent call last):
File stdin, line 1, in module
File C:\Python25\lib\encodings\utf_8.py, line 16, in decode
return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode bytes in position 5-6:
unexpected end of data
u = unicode(s, 'utf8', 'ignore')
u
u'La Pe'
u = unicode(s, 'utf8', 'replace')
u
u'La Pe\ufffd'
Pv
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr
oups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
