Re: Issue 2684 in reviewboard: comments are shown out-of-order
Updates: Owner: chip...@gmail.com Labels: Component-Reviews Milestone-Release1.6.x Comment #1 on issue 2684 by chip...@gmail.com: comments are shown out-of-order http://code.google.com/p/reviewboard/issues/detail?id=2684 Looking into it. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2685 in reviewboard: Attached files are not shown in draft state
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2685 by clip...@gmail.com: Attached files are not shown in draft state http://code.google.com/p/reviewboard/issues/detail?id=2685 What version are you running? 1.6.10, 1.7.10 alpha 0 (web demo) also affected What steps will reproduce the problem? 1. Create a new review request. 2. Attach a file (drag drop or Add file menu). File appears below the Testing done field. 3. Leave the draft (click to My Dashboard). 4. Open the draft. What is the expected output? What do you see instead? The file I just attached is not there. If I publish it, it appears, but in draft state I cannot edit or delete it. If I attach another file, the new one is visible (but not the first one), and after publishing both are there. What operating system are you using? What browser? Window 7 64 bit, Chrome 20.0, Firefox 9.0.1 (probably not browser dependent) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2684 in reviewboard: comments are shown out-of-order
Comment #2 on issue 2684 by vlov...@gmail.com: comments are shown out-of-order http://code.google.com/p/reviewboard/issues/detail?id=2684 Some screenshots demonstrating the problem (hopefully it's helpful). Attachments: reviewboard_random_time.png 28.3 KB reviewboard_reverse_time.png 32.2 KB -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2684 in reviewboard: comments are shown out-of-order
Updates: Status: Fixed Labels: -Priority-Medium Priority-High Comment #3 on issue 2684 by chip...@gmail.com: comments are shown out-of-order http://code.google.com/p/reviewboard/issues/detail?id=2684 Thanks for all the detailed info. It really helped me narrow it down and make both a fix and a test case for it. We'll put it into a 1.6.11 release, once we ensure there aren't any other major regressions. Pushed to release-1.6.x (4efa16e) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2685 in reviewboard: Attached files are not shown in draft state
Updates: Status: NeedInfo Owner: chip...@gmail.com Labels: -Priority-Medium Priority-High Component-Reviews Milestone-Release1.6.x Comment #1 on issue 2685 by chip...@gmail.com: Attached files are not shown in draft state http://code.google.com/p/reviewboard/issues/detail?id=2685 Does shift-reloading cause it to appear again? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2685 in reviewboard: Attached files are not shown in draft state
Updates: Status: Confirmed Comment #2 on issue 2685 by chip...@gmail.com: Attached files are not shown in draft state http://code.google.com/p/reviewboard/issues/detail?id=2685 Nevermind, it doesn't. Looking into this. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2686 by cea...@gmail.com: 1.6.10 breaks svn+ssh for Subversion http://code.google.com/p/reviewboard/issues/detail?id=2686 What version are you running? 1.6.10 What's the URL of the page containing the problem? Any page that requests a diff and the respository edit pages. What steps will reproduce the problem? 1. Take a working 1.6.9 install using Subversion with svn+ssh. 2. Update to 1.6.10 using rb-site script. 3. Attempt to access a review that doesn't have a cached diff which is hosted by a Subversion svn+ssh respository. What is the expected output? What do you see instead? The diffs should load. Rather, the logs display the following: 13:25:32DEBUG SVNTool: Attempting ssh connection with host: , username: reviewboard 13:25:32DEBUG starting thread (client mode): 0x92628bd0L 13:25:32INFO Connected (version 2.0, client OpenSSH_5.3p1) 13:25:32DEBUG kex algos:['diffie-hellman-group-exchange-sha256', 'diffie-hellman-group-exchange-sha1', 'diffie-hellman-group14-sha1', 'diffie-hellman-group1-sha1'] server key:['ssh-rsa', 'ssh-dss'] client encrypt:['aes128-ctr', 'aes192-ctr', 'aes256-ctr', 'arcfour256', 'arcfour128', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'cast128-cbc', 'aes192-cbc', 'aes256-cbc', 'arcfour', 'rijndael-...@lysator.liu.se'] server encrypt:['aes128-ctr', 'aes192-ctr', 'aes256-ctr', 'arcfour256', 'arcfour128', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'cast128-cbc', 'aes192-cbc', 'aes256-cbc', 'arcfour', 'rijndael-...@lysator.liu.se'] client mac:['hmac-md5', 'hmac-sha1', 'umac...@openssh.com', 'hmac-ripemd160', 'hmac-ripemd...@openssh.com', 'hmac-sha1-96', 'hmac-md5-96'] server mac:['hmac-md5', 'hmac-sha1', 'umac...@openssh.com', 'hmac-ripemd160', 'hmac-ripemd...@openssh.com', 'hmac-sha1-96', 'hmac-md5-96'] client compress:['none', 'z...@openssh.com'] server compress:['none', 'z...@openssh.com'] client lang:[''] server lang:[''] kex follows?False 13:25:32DEBUG Ciphers agreed: local=aes128-ctr, remote=aes128-ctr 13:25:32DEBUG using kex diffie-hellman-group1-sha1; server key type ssh-rsa; cipher: local aes128-ctr, remote aes128-ctr; mac: local hmac-sha1, remote hmac-sha1; compression: local none, remote none 13:25:32DEBUG Switch to new keys ... 13:25:32DEBUG Trying SSH key 6d41f76410303cb216b7b8f7c687dab6 13:25:32DEBUG userauth is OK 13:25:32INFO Authentication (publickey) successful! 13:25:32DEBUG EOF in transport thread 13:25:33ERROR SVN: Failed to get repository information for svn+ssh://reviewboard@/home/svn/repo: Network connection closed unexpectedly 13:25:33DEBUG EOF in transport thread What operating system are you using? What browser? Windows, Chrome Please provide any additional information below. I downgraded to 1.6.9 by using easy_install to install 1.6.9 and ran the rb-site script against the install. I realize that any database schema changes between 1.6.9 and 1.6.10 will cause other breakage, but when I did this, the svn+ssh connection began working again. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Updates: Status: NeedInfo Comment #1 on issue 2686 by chip...@gmail.com: 1.6.10 breaks svn+ssh for Subversion http://code.google.com/p/reviewboard/issues/detail?id=2686 Are you sure it wasn't coincidental timing? We don't have any changes to either rbssh or svn in this release. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Comment #2 on issue 2686 by cea...@gmail.com: 1.6.10 breaks svn+ssh for Subversion http://code.google.com/p/reviewboard/issues/detail?id=2686 I don't know how it could be since it seems to work correctly with version 1.6.9. Is there something I can do to get more information about the failure? Everything online seems to indicate that it is an SSH issue, but I have tested and retested those settings. Could this be due to a change in the version of a dependency in this version of ReviewBoard? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Comment #3 on issue 2686 by chip...@gmail.com: 1.6.10 breaks svn+ssh for Subversion http://code.google.com/p/reviewboard/issues/detail?id=2686 No dependency changes were made. The only SCM code that changed was some file parsing for CVS and some hosting support for Mercurial, neither of which comes anywhere near the Subversion code. Certainly nothing changed to impact SSH/rb-ssh code. I believe it's working in 1.6.9, but that traceback is showing some communication error between rb-site and the repository. That's why I'm wondering if there happened to be some downtime as you were trying 1.6.10 that resolved itself (or someone resolved it) after. Nothing else to me is making sense right now. I don't think there's anything more to get out of that failure. As it said, the connection was closed unexpectedly, presumably because of a server issue or it not liking something that was sent across. Would you be able to set up a 1.6.10 on a developer box/VM/virtualenv and see if it still happens? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Comment #4 on issue 2686 by cea...@gmail.com: 1.6.10 breaks svn+ssh for Subversion http://code.google.com/p/reviewboard/issues/detail?id=2686 I moved the /var/lib/reviewboard to /var/lib/reviewboard-backup and did a fresh install of 1.6.10 to /var/lib/reviewboard using sqlite as the database. This should ensure that there wasn't anything in my existing database confusing things. I then restarted memcached and apache2. After going to the install the first time, it informed me that the data directory had the wrong permissions. I ran the command to fix them. I added a repository and was asked to trust the host. The following error: Unable to authenticate against this repository using one of the supported authentication types. I copied the old id_rsa over using the following command. I have tested this id_rsa with ssh -i and connected successfully to the svn server. sudo cp -a /var/lib/reviewboard-backup/data/.ssh/id_rsa /var/lib/reviewboard/data/.ssh/id_rsa ReviewBoard didn't pick this up, so I downloaded the key from the server and used the ReviewBoard UI to upload the SSH key. This picked up the key. I then tried to add the repository again and saw the following error: A repository was not found at the specified path. I went ahead and did the same process described above using ReviewBoard 1.6.9 using sudo easy_install ReviewBoard==1.6.9 and the rest of the procedure is the same. The result was that no errors were thrown and the repository is added without problems. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Comment #5 on issue 2686 by cea...@gmail.com: 1.6.10 breaks svn+ssh for Subversion http://code.google.com/p/reviewboard/issues/detail?id=2686 By the way, the server I am running on is Ubuntu 10.04.4 LTS -- Linux reviewboard 2.6.32-30-generic #59-Ubuntu SMP Tue Mar 1 21:30:46 UTC 2011 x86_64 GNU/Linux with Python 2.6.5 -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Comment #7 on issue 2686 by cea...@gmail.com: 1.6.10 breaks svn+ssh for Subversion http://code.google.com/p/reviewboard/issues/detail?id=2686 I am currently setting up a VM with CentOS 5 to see if that makes a difference. The log from the previous attempt follows: 13:45:09DEBUG SVNTool: Attempting ssh connection with host: , username: reviewboard 13:45:09DEBUG starting thread (client mode): 0x71514790L 13:45:09INFO Connected (version 2.0, client OpenSSH_5.3p1) 13:45:09DEBUG kex algos:['diffie-hellman-group-exchange-sha256', 'diffie-hellman-group-exchange-sha1', 'diffie-hellman-group14-sha1', 'diffie-hellman-group1-sha1'] server key:['ssh-rsa', 'ssh-dss'] client encrypt:['aes128-ctr', 'aes192-ctr', 'aes256-ctr', 'arcfour256', 'arcfour128', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'cast128-cbc', 'aes192-cbc', 'aes256-cbc', 'arcfour', 'rijndael-...@lysator.liu.se'] server encrypt:['aes128-ctr', 'aes192-ctr', 'aes256-ctr', 'arcfour256', 'arcfour128', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'cast128-cbc', 'aes192-cbc', 'aes256-cbc', 'arcfour', 'rijndael-...@lysator.liu.se'] client mac:['hmac-md5', 'hmac-sha1', 'umac...@openssh.com', 'hmac-ripemd160', 'hmac-ripemd...@openssh.com', 'hmac-sha1-96', 'hmac-md5-96'] server mac:['hmac-md5', 'hmac-sha1', 'umac...@openssh.com', 'hmac-ripemd160', 'hmac-ripemd...@openssh.com', 'hmac-sha1-96', 'hmac-md5-96'] client compress:['none', 'z...@openssh.com'] server compress:['none', 'z...@openssh.com'] client lang:[''] server lang:[''] kex follows?False 13:45:09DEBUG Ciphers agreed: local=aes128-ctr, remote=aes128-ctr 13:45:09DEBUG using kex diffie-hellman-group1-sha1; server key type ssh-rsa; cipher: local aes128-ctr, remote aes128-ctr; mac: local hmac-sha1, remote hmac-sha1; compression: local none, remote none 13:45:09DEBUG Switch to new keys ... 13:45:09DEBUG Trying SSH key 6d41f76410303cb216b7b8f7c687dab6 13:45:09DEBUG userauth is OK 13:45:09INFO Authentication (publickey) successful! 13:45:09DEBUG EOF in transport thread 13:45:09ERROR SVN: Failed to get repository information for svn+ssh://reviewboard@/home/svn/: Network connection closed unexpectedly 13:45:09DEBUG EOF in transport thread -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Comment #8 on issue 2686 by chip...@gmail.com: 1.6.10 breaks svn+ssh for Subversion http://code.google.com/p/reviewboard/issues/detail?id=2686 Try setting the DEBUG_RBSSH to 1 in the environment for Apache (SetEnv), and set DEBUG_LOGDIR to the directory you're using for reviewboard.log. There may be some more info there. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Comment #9 on issue 2686 by cea...@gmail.com: 1.6.10 breaks svn+ssh for Subversion http://code.google.com/p/reviewboard/issues/detail?id=2686 I added both of those to my apache configuration in the VirtualHost associated with ReviewBoard at the beginning as follows, but I didn't see any new information appear in the log and I don't see any new log files. VirtualHost *:80 SetEnv DEBUG_RBSSH 1 SetEnv DEBUG_LOGDIR /var/lib/reviewboard/logs/ ServerName reviewboard DocumentRoot /var/lib/reviewboard/htdocs . . . Also, I have run into issues using CentOS as a base since the default yum repos don't have all the needed packages. It appears from the documentation that the Debian-based distros are the preferred bases anyhow so I am probably giving up on that avenue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Comment #10 on issue 2686 by chip...@gmail.com: 1.6.10 breaks svn+ssh for Subversion http://code.google.com/p/reviewboard/issues/detail?id=2686 Debian-based distros are definitely a lot easier. Fedora's not bad either, since they maintain up-to-date RB packages. Sorry, I was in a rush and gave you the wrong environment variable for the log directory. It should be RBSSH_LOG_DIR. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2686 in reviewboard: 1.6.10 breaks svn+ssh for Subversion
Comment #11 on issue 2686 by cea...@gmail.com: 1.6.10 breaks svn+ssh for Subversion http://code.google.com/p/reviewboard/issues/detail?id=2686 I made that change, but it still isn't giving me the additional output. I made sure to restart apache2 and memcached. I tried moving the SetEnv options into the Location tag with the other ones in case that made a difference too. It didn't. I noticed in the apache config, there is also a reference to PythonDebug Off. Is that something I can turn on to get more data or is that more for gdb-style stepping? VirtualHost *:80 ServerName reviewboard DocumentRoot /var/lib/reviewboard/htdocs # Error handlers ErrorDocument 500 /errordocs/500.html # Serve django pages Location / PythonPath ['/var/lib/reviewboard/conf'] + sys.path SetEnv DEBUG_RBSSH 1 SetEnv RBSSH_LOG_DIR /var/lib/reviewboard/logs/ SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings SetEnv PYTHON_EGG_CACHE /var/lib/reviewboard/tmp/egg_cache SetEnv HOME /var/lib/reviewboard/data SetHandler mod_python PythonHandler django.core.handlers.modpython PythonAutoReload Off PythonDebug Off # Used to run multiple mod_python sites in the same apache PythonInterpreter reviewboard_reviewboard /Location . . . (I am heading out for the day, but I will check back tomorrow morning to see if you have any other suggestions for how to get more debug output and help solve this problem. I really appreciate your help so far, thanks!) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
