Re: Djblets Ticket #5016: perforce rbt post fails with 500 internal error
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/5016/ -- New update by shubhar For Beanbag, Inc. > Djblets > Ticket #5016 Reply: How was your Python installed? What built that environment? I'm looking at the details and flow behind the error and the default encoding for streams isn't what I'd expect. Can you run this on the server: ```shell $ /webapp/PYTHON_VENVS/ReviewBoard-6.0.1-venv/bin/python import locale print(locale.getencoding()) ``` -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20231213233455.12733.46961%40ip-10-1-54-209.ec2.internal.
Re: Djblets Ticket #5016: perforce rbt post fails with 500 internal error
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/5016/ -- New update by shubhar For Beanbag, Inc. > Djblets > Ticket #5016 Reply: Oh, and part of that patch (the part to `setup.py`) won't be able to apply to an installed copy. It's meant for the source tree. If it complains, you can skip that file. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20231213232823.12735.18372%40ip-10-1-54-209.ec2.internal.
Re: Djblets Ticket #5016: perforce rbt post fails with 500 internal error
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/5016/ -- New update by shubhar For Beanbag, Inc. > Djblets > Ticket #5016 Reply: 1. We're still trying to figure that out. There's a few things we're coordinating for a release right now, and we have to wait until things are in place. The thing about this failure is that, provided you're using the same version of Python between your old RB5 install and RB6, you honestly should have had the same problem. This was an issue in the third-party module, and the same version would have been used in both. I haven't been able to reproduce this yet, but I'll have a couple more follow-up questions on that in a minute. 2. You can use the version of pip you used above and install the `publicsuffixlist` package, and then apply this patch to your `/lib/python3.11/site-packages/djblets/`: https://reviews.reviewboard.org/r/13454/diff/raw/ That should get you the patch file. You'd want to back up your `djblets` directory before proceeding. If all goes well, you can restart your web server and try to reproduce the problem. So those questions: 1. Is your `/webapp` path and everything in it local to the file system, or mounted over something like NFS? 2. Was Review Board 5 installed and managed on Python 3.11, or was it using an older version? 3. Can you think of any differences in the deployment between your RB5 and RB6 that might be useful for me to know? Thanks! -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20231213231849.12735.12961%40ip-10-1-54-209.ec2.internal.
Re: Djblets Ticket #5016: perforce rbt post fails with 500 internal error
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/5016/ -- New update by shubhar For Beanbag, Inc. > Djblets > Ticket #5016 Reply: We have a fix pending for this, switching to a modern, maintained alternative to `publicsuffix`. We'll ship this in Djblets 4.1 soon. If you have a support contract with us, we can get you tailored builds, or you can try backporting the patch internally and seeing if it resolves your problem. https://reviews.reviewboard.org/r/13454/ Status: - New + PendingReview Project: - reviewboard + djblets Tags: + Component:EMail Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20231213090006.12737.88232%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #5016: perforce rbt post fails with 500 internal error
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/5016/ -- New update by shubhar For Beanbag, Inc. > Review Board > Ticket #5016 Reply: Hmm, interesting. Looks like an issue in a third-party module we use. We'll look into what's going on there. Thank you for the log! Can you check the result of `/webapp/reviewboard/site_prob-6.0.1/venv/bin/pip show publicsuffix` (path based on what's in the logs -- feel free to adjust if needed) and show me what that says? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20231213050117.12736.16266%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #5016: perforce rbt post fails with 500 internal error
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/5016/ -- New update by shubhar For Beanbag, Inc. > Review Board > Ticket #5016 Reply: Thanks for the report! There should be a server-side error somewhere as well, perhaps e-mailed to the administrator, or found in the `reviewboard.log` file. Would you be able to locate the backtrace there and attach it? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20231213023924.26629.16820%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #5012: requests to /api/... do not use public server name but private IP address
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/5012/ -- New update by HeroicAlbeit For Beanbag, Inc. > Review Board > Ticket #5012 Reply: Thanks for the detailed information! Our default Nginx setup forwards over the requested hostname to Review Board, and Review Board then uses that hostname to construct URLs for the APIs. In this case, Review Board is seeing its host as being ``, which probably makes sense in this case, though we'll need to verify. Since your Nginx isn't serving up as ``, the host it's sending along to Django isn't going to be ``, so one of two options will need to be explored: 1. Changing `proxy_set_header Host $host` to `proxy_set_header Host your_public_server_name`. 2. If API Gateway forwards on a host using `X-Forwarded-Host` in the request, then you can set `USE_X_FORWARDED_HOST = True` in Review Board's `/site/conf/settings_local.py`. (This would need to be tested for sure). The latter is off by default for security reasons, and should only be turned on if in this exact situation. We'll need to do some work on our end to add documentation and comments throughout these files to cover these scenarios. Can you see if one or both of those work, and let me know? We'll then get this documented on our end. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20231107215013.23425.24134%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #5001: Please add detailed information about reviewboard URL to rbt login
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/5001/ -- New update by shubhar For Beanbag, Inc. > RBTools > Ticket #5001 Reply: Good suggestion, and I agree, we should do that. Status: - New + Confirmed Milestones: + Release-5.x -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20230308015244.26440.50079%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4999: Linux installation page has incorrect Python Version
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4999/ -- New update by CodeScrubber For Beanbag, Inc. > Review Board > Ticket #4999 Reply: Ah I was going to let you know today and give you a summary. All the installation docs (both in the manual and the Get Review Board page) have been fully redone. They're backed by automated testing in Debian, RHEL, Fedora, and CentoS Stream environments, both LTS and latest releases, so that new issues won't crop up without us noticing. Along with this, we have new upgrade docs, optimization docs, SELinux docs, and more. If you end up running through the guides again, and hit any issues at all, please let me know! -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20230302010657.32146.29490%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #5000: The first command on the Debian/Ubunu Get Reviewboard page is wrong
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/5000/ -- New update by CodeScrubber For Beanbag, Inc. > Review Board > Ticket #5000 Reply: Could be. I'm using Chrome as well, but we're also currently using an old version of the text editor component here, and it's due for an upgrade. We should be deploying the new instructions (which are all backed by automated Docker-based tests) next week. In the meantime, if we can help you get going, go ahead and e-mail us at supp...@beanbaginc.com and we'll help get you going. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20230224044849.10393.95504%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #5000: The first command on the Debian/Ubunu Get Reviewboard page is wrong
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/5000/ -- New update by CodeScrubber For Beanbag, Inc. > Review Board > Ticket #5000 Reply: This report is timely. New versions of these instructions are going up in a couple days. Regarding the bug editing text in the issue tracker, that is.. very bad. What browser/device are you using? I need to reproduce that. Status: - New + NeedInfo -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20230224001424.9923.29995%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4990: use p4 fstat to capture 'headType' (file type) so that it can be displayed in ReviewBoard diffs
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4990/ -- New update by shubhar For Beanbag, Inc. > RBTools > Ticket #4990 Reply: We agree, and have begun baking in some ability to capture data like that. The limiting factor is that diff formats generally don't include metadata like this, and Perforce diffs certainly don't. The long-term plan is to move our Perforce diff implementation over to [DiffX](https://diffx.org), which later Review Board 4.0.x versions support. That'll allow us to capture data like that in RBTools. We still need to add UI for this in Review Board, and we're looking at that for Review Board 6 (in development) or 7. Status: - New + Confirmed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20230207044118.30335.14469%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4988: Fail to post diff with perforce repo: 'Value to convert is unexpected type %s',
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4988/ -- New update by benjackson For Beanbag, Inc. > Review Board > Ticket #4988 Reply: Found a regression with the fix, but we'll get reworked version in for 5.0.2 (which is going out tonight/tomorrow). `force_text()`/`force_str()` will assume an encoding if the object is a `bytes` or converts to a `bytes`. The problem with this is that we can't assume at this particular stage. We instead need to use the configured encoding list. This matters particularly for people working with some Chinese encodings. `convert_to_unicode()` is responsible for trying the configured encodings, but since the fix was passing in the forced-encode, it never got a chance. That's not a problem for `Revision` instances, but is for raw revisions. Probably not even a problem there (revisions are generally effectively ASCII in most SCMs), but it's more of a problem when forcing the encoding for filenames (which are completely at the whim of the developers committing code). Making a change to specifically check for and cast the `Revision` before storing it instead, which should be a bit safer. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20230207032257.30335.48780%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4982: After Migrating to new upgraded version , Creating new review from UI page not working
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4982/ -- New update by MayurPatil For Beanbag, Inc. > Review Board > Ticket #4982 Reply: Thanks for the report. Can you try the following to gather a bit more information from the browser: 1. Open the browser's developer tools 2. Click the Network tab 3. Reload the page, repeat the process 4. Look at all the API requests and send me the request and response payloads (headers are not needed) 5. Check the Console tab, see if any errors show up Also, is the review request ultimately being created, just not redirected to? Status: - New + NeedInfo -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20221018210357.14904.21442%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #2106: Diff updates after "ship it"
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/2106/ -- New update by jonathan.mc@gmai* (Google Code) For Beanbag, Inc. > Review Board > Ticket #2106 Reply: Pushed to release-5.0.x (ce79281706321b36ca499e1332a769e191e20574). Status: - Confirmed + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20220914063837.31311.85977%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4973: rbt patch - SVN - failing with "a bytes-like object is required, not 'str'"
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4973/ -- New update by rpowell For Beanbag, Inc. > RBTools > Ticket #4973 Reply: Fixed in 14b3b248cc9c079453fde5df43db755f2cd90b3a. This will go into 3.1.2 and 4.0. Status: - Confirmed + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20220816021217.16339.74480%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4975: `rbt post` should infer default reviewers from Google/Gerrit-style OWNERS, GitLab-/GitHub-style CODEOWNERS files
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4975/ -- New update by beasleyr-vmw For Beanbag, Inc. > RBTools > Ticket #4975 Reply: Hey Ryan. Interesting idea. We'll have to mull this one over. Review Board is probably still where we'd prefer to have default reviewer logic live, because: 1. Not everyone uses RBTools (there are a lot of in-house clients and integrations out there using our API) 2. Not everyone upgrades (as an example, your RBTools 2.0 is a major version behind, soon two major versions) 3. Having default reviewer logic live both client-side and server-side is messy (and we don't want it to live fully client-side -- we have customer who require complete server-side control of reviewers) We've had a long-standing goal to change up how default reviewers work. Right now they're regex-based, as you noted. The plan though is to let admins define rules using our Conditions support (which we use for service integrations). These would allow for anything from regex rules to "look up default reviewers from this file/URL" to "ask this extension/webhook for reviewers". With that in place, an admin could define a rule that allows review requests posted against one set of repos to use `CODEOWNERS` while review requests against another set would have very strict default reviewers. That'd have the additional benefits of: 1. Keeping default reviewer management centralized, working whether RBTools is used (or whether people are even running latest versions -- yours is a major version behind, for example) 2. Being able to always use the latest official source for a `CODEOWNERS` (people may be working locally in older branches that aren't up-to-date) 3. Letting the `CODEOWNERS` inclusion be part of a ruleset 4. Treating `CODEOWNERS` as just one possible source (we have customers today who use other sources and use hacks to tie into default reviewers) We have some internal tracking around this work. I'm including this as part of that task. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20220815224822.16338.18551%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4973: rbt patch - SVN - failing with "a bytes-like object is required, not 'str'"
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4973/ -- New update by rpowell For Beanbag, Inc. > RBTools > Ticket #4973 Reply: We'll get this into 3.1.2. Thanks! Status: - New + Confirmed Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20220815213111.16335.90874%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4969: interdiff sometimes fails with a variable used before assignment
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4969/ -- New update by grim For Beanbag, Inc. > Review Board > Ticket #4969 Reply: Fixed in 86b164ec28d6178f8ede774911cad664bf891e2c. Status: - PendingReview + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20220614011928.12982.82412%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4972: rbt patch on rbt 3.1 fails with `got multiple values for keyword argument 'with_errors'`
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4972/ -- New update by grim For Beanbag, Inc. > RBTools > Ticket #4972 Reply: Fixed in 0c16a55480ecb4f7d3559a0f90ae9f67f50ec4af, and being released this week in RBTools 3.1.1. Status: - New + Fixed Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20220613031212.12982.3535%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4969: interdiff sometimes fails with a variable used before assignment
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4969/ -- New update by grim For Beanbag, Inc. > Review Board > Ticket #4969 Reply: Fix up for review: https://reviews.reviewboard.org/r/12362/ Status: - New + PendingReview Milestones: + Release-4.0.x Tags: + Component:DiffViewer Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20220613031054.12979.71446%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4971: "invalid literal for int" when expanding collapsed lines in a multi-commit review
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4971/ -- New update by phord For Beanbag, Inc. > Review Board > Ticket #4971 Reply: Fixed in Review Board 4.0.7 (coming this week). Commit 53de1446814f460a87587c039a53ebafcbbe0e00 Status: - New + Fixed Milestones: + Release-4.0.x Tags: + Component:DiffViewer Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20220613030923.12977.80047%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4969: interdiff sometimes fails with a variable used before assignment
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4969/ -- New update by grim For Beanbag, Inc. > Review Board > Ticket #4969 Reply: I looked into this a bit when you reported this to me, and... the cause of that `UnboundLocalError` is easily fixed, but it shouldn't be hitting that code to begin with unless it'd be in a state where `j` would be assigned. So there's a real bug with that function, but also something leading to that function being called. Kinda weird. Going to require some investigation. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20220504223303.11774.79207%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4966: RBTools windows download link points to non-existent .exe
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4966/ -- New update by anitschk For Beanbag, Inc. > RBTools > Ticket #4966 Reply: We actually had the upload path for downloads.reviewboard.org wrong during release. We wanted to keep that at 3.0. Sorry about that, and thanks for reporting it! It's fixed, and the link on the site should work correctly again. Status: - New + Fixed Tags: - Priority:Medium + Priority:Critical Summary: - RBTools windows download link points to non-existent .exe + RBTools windows download link points to non-existent .exe Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20220328205400.6802.11181%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4932: Error creating a review request with a SVN repository
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4932/ -- New update by dkmorgan For Beanbag, Inc. > Review Board > Ticket #4932 Reply: Are there any changes in that diff aside from standard modifications to files, deleted files, or newly-introduced files? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210709020323.1628.44927%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4932: Error creating a review request with a SVN repository
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4932/ -- New update by dkmorgan For Beanbag, Inc. > Review Board > Ticket #4932 Reply: Hmm, interesting. There must be a situation our unit tests aren't covering. Wonder what that diff looks like. We'll get a fix into 4.0.4. Status: - New + Confirmed Milestones: + Release-4.0.x Tags: + SCM:Subversion Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210709020154.1626.50438%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4933: Missing CSS and JS files (/static ?) after migration to official container
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4933/ -- New update by kofemann For Beanbag, Inc. > Review Board > Ticket #4933 Reply: Sorry you had to deal with this.. Yeah, Django/Gunicorn does not serve up static media, so something like nginx is required. The [Serving Content](https://www.reviewboard.org/docs/manual/4.0/admin/installation/docker/#serving-content) docs are intended to cover this, but we need to make some adjustments, as people often miss this. We'll fix up the `sitedir`/`site` issue. Definitely a problem that's probably confused plenty of people. What did you need to run for SELinux? We can add that to the docs. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210708225505.1626.88332%40ip-10-1-54-209.ec2.internal.
Re: ReviewBoard 4.0.2 + Issue with LDAP based authentication
Your version of the ldap module needs to be upgraded. Try installing the “ReviewBoard[ldap]” package (using the same installation method, pip or easy_install, that you used to install Review Board). Christian On Sat, Jun 26, 2021 at 10:40 harish.va...@gmail.com < harish.varadara...@gmail.com> wrote: > Hi All, > > we are getting the below error with LDAP (per httpd error_log) post > upgrade to RB 4.0.2 and site upgrade. > > [Sat Jun 26 17:35:57.763873 2021] [:error] [pid 24259] TypeError: > initialize() got an unexpected keyword argument 'bytes_mode' > [Sat Jun 26 17:36:20.653493 2021] [:error] [pid 24262] 2021-06-26 > 17:36:20,653 - ERROR - - reviewboard.accounts.backends.ldap - Unexpected > error occurred while authenticating with LDAP: initialize() got an > unexpected keyword argument 'bytes_mode' > [Sat Jun 26 17:36:20.653508 2021] [:error] [pid 24262] Traceback (most > recent call last): > [Sat Jun 26 17:36:20.653510 2021] [:error] [pid 24262] File > "/usr/lib/python2.7/site-packages/ReviewBoard-4.0.2-py2.7.egg/reviewboard/accounts/backends/ldap.py", > line 339, in _connect > [Sat Jun 26 17:36:20.653512 2021] [:error] [pid 24262] > bytes_mode=False) > [Sat Jun 26 17:36:20.653513 2021] [:error] [pid 24262] TypeError: > initialize() got an unexpected keyword argument 'bytes_mode' > > Any idea on how to fix this. > > Thanks. > > -- > You received this message because you are subscribed to the Google Groups > "reviewboard-issues" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard-issues+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/reviewboard-issues/b8110876-e025-4aa3-b7aa-ecd6ff7d66acn%40googlegroups.com > <https://groups.google.com/d/msgid/reviewboard-issues/b8110876-e025-4aa3-b7aa-ecd6ff7d66acn%40googlegroups.com?utm_medium=email_source=footer> > . > -- -- Christian Hammond President/CEO of Beanbag Makers of Review Board -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/CAE7Vnd%3D87%3DXqCZe6zbSicEG1Y2%2BgddNtH8i%2BekJzX%2BpZdz0%2B8Q%40mail.gmail.com.
Re: Review Board Ticket #4929: Bug in list users API
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4929/ -- New update by kosta For Beanbag, Inc. > Review Board > Ticket #4929 Reply: Interesting. That should only be able to happen when Review Board is connected to LDAP or Active Directory. If an unknown user is referenced on a review request, Review Board will ask the LDAP/AD server if it's aware of the user. If the server says it is, Review Board creates a local entry. Sounds like that's what's happening, for some reason. Are you using LDAP/AD? If so, is that username present in it? Can you show me what the invalid characters are? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210622212813.24031.10662%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4929: Bug in list users API
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4929/ -- New update by kosta For Beanbag, Inc. > Review Board > Ticket #4929 Reply: I'm not able to reproduce this. Are you an admin on the server? If so, can you get me a copy of the backtrace from the `reviewboard.log` file? Status: - New + NeedInfo -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210620234830.28380.48476%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4928: Could not determine the GitLab API version for http://192.168.9.92 due to an unexpected error ('HostingServiceHTTPRequest' object has no attribute 'method').
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4928/ -- New update by HEICHAI For Beanbag, Inc. > Review Board > Ticket #4928 Reply: Review requests up at https://reviews.reviewboard.org/r/11644/ and https://reviews.reviewboard.org/r/11646/. Status: - Confirmed + PendingReview -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210603105423.27981.1439%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4928: Could not determine the GitLab API version for http://192.168.9.92 due to an unexpected error ('HostingServiceHTTPRequest' object has no attribute 'method').
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4928/ -- New update by HEICHAI For Beanbag, Inc. > Review Board > Ticket #4928 Reply: Looks to be a regression. We've found the issue, and will issue a fix in 4.0.2 (expected Tuesday of next week). Status: - New + Confirmed Milestones: + Release-4.0.x Tags: + Component:HostingServices Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210603102935.27979.41674%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4918: rb-site does not work on python 2.7
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4918/ -- New update by splatter2 For Beanbag, Inc. > Review Board > Ticket #4918 Reply: Fixed on `release-4.0.x` (`8fc5e4e7aa13ad79ab712df0c6f324668cfbb83d`) Status: - Confirmed + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210525040252.6882.11452%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4923: webhooks send duplicate Content-Length headers under python3
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4923/ -- New update by nuxi For Beanbag, Inc. > Review Board > Ticket #4923 Reply: Fixed on `release-4.0.x` (`66edba4cfb50eed3ca9b705512ed609db70f0b16`) Status: - Confirmed + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210525040026.6886.96977%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4922: Too much precision on memcached stats
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4922/ -- New update by mblythe For Beanbag, Inc. > Review Board > Ticket #4922 Reply: Fixed on `release-4.0.x` (`28bd1cdf042f2090c4f6a41ae8f8e6cc455cc095`) Status: - Confirmed + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210525040126.6884.18712%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4918: rb-site does not work on python 2.7
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4918/ -- New update by splatter2 For Beanbag, Inc. > Review Board > Ticket #4918 Reply: Figured out the cause, and the solution. We'll have this in 4.0.1 tonight. Status: - NeedInfo + Confirmed Milestones: + Release-4.0.x Tags: + Component:RB-Site Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210524230748.10697.36644%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4922: Too much precision on memcached stats
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4922/ -- New update by mblythe For Beanbag, Inc. > Review Board > Ticket #4922 Reply: This will be fixed in 4.0.1 tonight. Status: - New + Confirmed Milestones: + Release-4.0.x Tags: + Component:Admin Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210524222658.10695.82767%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4921: Cannot load DB dump
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4921/ -- New update by mblythe For Beanbag, Inc. > Review Board > Ticket #4921 Reply: This tool has been removed in 4.0. Status: - Confirmed + WontFix -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210524221607.10696.32575%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4920: Crash while running 'rb-site manage dumpdb'
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4920/ -- New update by mblythe For Beanbag, Inc. > Review Board > Ticket #4920 Reply: Thanks. Yeah, documentation would be good here. We're working to get the new tool in shape, which will make this a lot easier. Given that we had to nuke the old tool, though, I have to close as WontFix. Status: - New + WontFix -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210524221715.10694.80899%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4923: webhooks send duplicate Content-Length headers under python3
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4923/ -- New update by nuxi For Beanbag, Inc. > Review Board > Ticket #4923 Reply: Fix is going into 4.0.1 tonight. Status: - New + Confirmed Milestones: + Release-4.0.x Tags: + Component:Webhooks Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210524221421.10697.46848%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4920: Crash while running 'rb-site manage dumpdb'
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4920/ -- New update by mblythe For Beanbag, Inc. > Review Board > Ticket #4920 Reply: After much analysis, and making a real attempt and keeping things compatible, the unfortunate conclusion is that we're removing these tools for 4.0. As mentioned, `dumpdb`/`loaddb` are fairly thin wrappers around Django's `dumpdata`/`loaddata`, and those are absolutely not forwards/backwards-compatible between the versions of Django used for Review Board 3.0/4.0. These were never really fully built for production use anyway, more for development (in fact, loading requires a development setup). There are plenty of issues deep within Django for compatible serialization, and we'd have to rewrite much of that stack, which isn't worth the time, given the work going into Power Pack. We'll be adding a deprecation notice and warning when running these tools in 3.0.21, and we'll be stubbing them out entirely in 4.0, showing just an error message with guidance on alternatives. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210413011043.7809.31692%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4920: Crash while running 'rb-site manage dumpdb'
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4920/ -- New update by mblythe For Beanbag, Inc. > Review Board > Ticket #4920 Reply: Hmm, that's strange. Looks more like an issue in Django's code. I'll see if I can reproduce. As mentioned on issue #4921, we're probably going to have to phase out these tools at some point, due to issues like this in Django. Native database dump/restore tools are more reliable. We do have a successor to dumpdb/loaddb that's in the works that avoids all the Django compatibility issues that these tools have (as they're based on Django's own loaddata/dumpdata, and aren't necessarily cross-version-compatible). That'll be coming as a free component to [Power Pack](https://www.reviewboard.org/powerpack/) in the future. Milestones: + Release-4.0 Tags: + Component:RB-Site Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210407221748.14745.67943%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4921: Cannot load DB dump
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4921/ -- New update by mblythe For Beanbag, Inc. > Review Board > Ticket #4921 Reply: Thanks for the report! I see where this went wrong (Django changed how these management commands work, and it looks like this wasn't updated properly). We'll get this fixed for 4.0 final. We are aiming to deprecate loaddb/dumpdb, as they just don't work well between releases of Django. Best bet in most situations is to use the database's native SQL dump/load tools for constructing a new database. Status: - New + Confirmed Milestones: + Release-4.0 Tags: + Component:RB-Site Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210407221440.14746.7434%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4692: Can’t toggle interdiff control on iPad
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4692/ -- New update by grossag For Beanbag, Inc. > Review Board > Ticket #4692 Reply: Hey Adam, Yeah, this was part of a series of UI changes that got pushed back (there's a lot of things competing for our time. I have some in-progress work for adding touch control and accessibility to this slider. It's missing the Review Board 4.0 release window, but I'm planning to get it into a 4.0.x. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210330091316.3315.60963%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4919: Support enforced reviewers
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4919/ -- New update by almt For Beanbag, Inc. > Review Board > Ticket #4919 Reply: This is a good idea for a feature. It's probably not something we'll be putting in any time soon (we'd want to think a lot about how this would work — there are a lot of different workflows out there). Extensions can provide this today. You can write an extension that listens to a `review_request_publishing` signal, check the reviewers, and raise a `PublishError` preventing it, if it doesn't match what's expected. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210330091524.3315.70166%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4918: rb-site does not work on python 2.7
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4918/ -- New update by splatter2 For Beanbag, Inc. > Review Board > Ticket #4918 Reply: Hmm, this code has been around for 6 years. Wonder if this is a version on Python 2.7.5 (which is very old). Is it bailing simply when running rb-site at all? Are you using any other version in production? If so, what version of Python is in use? Status: - New + NeedInfo -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210307004614.29596.41535%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4913: python 2.7 compatibility
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4913/ -- New update by splatter2 For Beanbag, Inc. > Review Board > Ticket #4913 Reply: Thanks! This will be part of 3.0.21 (fixed in `6d0c7ed62ee6023ee7e91bc6b68aae20bcd8273d` on `release-3.0.x`). Status: - NeedInfo + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210223024654.22330.1904%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4913: python 2.7 compatibility
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4913/ -- New update by splatter2 For Beanbag, Inc. > Review Board > Ticket #4913 Reply: Patch up at https://reviews.reviewboard.org/r/11471/ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210216075021.31628.95010%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4911: ReviewBoard 4 for svn repositories can't Create from a local change
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4911/ -- New update by Rand01ph For Beanbag, Inc. > Review Board > Ticket #4911 Reply: Fix up for review at https://reviews.reviewboard.org/r/11470/ This will be part of RC 1 this week. Status: - New + Fixed Milestones: + Release-4.0 Tags: + Component:Reviews + Priority:Critical + SCM:Subversion Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210216074858.31628.62984%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4913: python 2.7 compatibility
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4913/ -- New update by splatter2 For Beanbag, Inc. > Review Board > Ticket #4913 Reply: Thanks for the heads up! Can you verify whether you're using `easy_install` or `pip`? It seems the capping is already happening naturally through `pip` packages, but probably not `easy_install` (which isn't as smart about this, and won't be supported much longer). Status: - New + NeedInfo Milestones: + Release-3.0.x + Release-4.0 Tags: + Component:Deployment Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20210216055959.31623.14096%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4893: Invisible floating `Publish Review` button that is clickable
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4893/ -- New update by keanweng97 For Beanbag, Inc. > Review Board > Ticket #4893 Milestones: + Release-4.0 Tags: + Component:Reviews + Project:ReviewBoard Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20201229213435.5260.52309%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4881: Improve visual appearance of "Security Center" in admin
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4881/ -- New update by david For Beanbag, Inc. > Review Board > Ticket #4881 Reply: Landed on release-4.0.x (edd8cb3d07d2cedd3c8d2d9a759b544f46651698). Status: - New + Fixed Milestones: + Release-4.0 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20201216223709.28501.37618%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4194: Include real line numbers for diff comments in API, webhook payloads
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4194/ -- New update by pawolf For Beanbag, Inc. > Review Board > Ticket #4194 Reply: I'm sorry, not really. There are some reasons it's not provided that are more technical implementation details than anything. It is something we really should be doing, and I'm going to try to get this on the roadmap, but it won't help you for now. There is a workaround, though. You can access the [file diff data API](https://www.reviewboard.org/docs/manual/3.0/webapi/2.0/resources/file-diff/) by making a GET request to this with an `Accept: application/vnd.reviewboard.org.diff.data+json` header and the parameters for the file being commented on. This will give you underlying data used to build the diff viewer. This contains the real line numbers and those row numbers. From there, you can access the appropriate row and get the original/modified line numbers for the row number. This is available in Review Board 2.5 as well, but it's worth mentioning that 2.5 is no longer seeing any new development. 3.0 will soon be going into maintenance mode as well, as 4.0 is coming out before long. Would you be able to talk about what your webhook does? We're planning work on a new major version of the API and reworking some internals, so I want to gather use cases and see what makes sense. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20200904223540.27173.82287%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4850: AttributeError: 'User' object has no attribute 'user'
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4850/ -- New update by Misery For Beanbag, Inc. > Review Board > Ticket #4850 Status: - New + PendingReview Milestones: + Release-3.0.x Tags: + Component:API Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20200623092810.5049.92104%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4788: Ability to configure which messages are sent to Slack
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4788/ -- New update by avanthong For Beanbag, Inc. > Review Board > Ticket #4788 Reply: It's not on the roadmap (the roadmap is densely packed at the moment) but it is something I think would be valuable to add. I'm happy to accept patches for this. We also work with students each semester, and this could be a good starter project for one in the Fall. Status: - New + Confirmed Tags: + Component:Integration + StudentProject -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20200607215312.8807.39117%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4862: tabs in issues section gets back to "Open issues" every 10 seconds when some checks/tests are updating results.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4862/ -- New update by theBoss For Beanbag, Inc. > Review Board > Ticket #4862 Reply: Yeah, I can verify this. I'll take a look. We're pretty swamped right now, but I should be able to get it in for 3.0.18 (release date TBD). Status: - New + Confirmed Milestones: + Release-3.0.x Tags: + Component:Reviews Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20200225094935.25552.46755%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #193: Wish: tight integration with bug trackers
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/193/ -- New update by cuv@gmai* (Google Code) For Beanbag, Inc. > Review Board > Ticket #193 Milestones: + Release-5.0 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20191220222751.12934.18942%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #193: Wish: tight integration with bug trackers
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/193/ -- New update by cuv@gmai* (Google Code) For Beanbag, Inc. > Review Board > Ticket #193 Reply: We want this too. It can be done through a custom extension, but to do it really well, built-in, requires a lot of work on our representation of bug trackers within Review Board. We're aiming to start on this once Review Board 4.0 launches. Milestones: - Extensions -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20191220222606.12937.27774%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4848: Right side is sometimes missed on Google Chrome
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4848/ -- New update by ShatalovaD For Beanbag, Inc. > Review Board > Ticket #4848 Reply: Strange. I haven't encountered this myself. Do any of the files shown in that diff viewer have very long unbreakable lines? We have seen situations where this causes issues. We set the proper CSS to tell the browser to force the lines to wrap, but have occasionally seen regressions in browsers trying to handle this. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20191112224542.2.72828%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/ -- New update by c0d3h4x0r For Beanbag, Inc. > RBTools > Ticket #4819 Reply: Yep, we have a mailing list where we announce all new releases (or other important updates). It's fairly low-traffic -- we try not to waste your time. https://www.reviewboard.org/mailing-lists/ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190822232856.2634.47866%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/ -- New update by c0d3h4x0r For Beanbag, Inc. > RBTools > Ticket #4819 Reply: Fix is up for review: https://reviews.reviewboard.org/r/10666/ Dan, I'm also curious if you already applied the previous patch that was referenced. This is part 2 of a fix. Status: - Confirmed + PendingReview -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190821102943.3384.4853%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/ -- New update by c0d3h4x0r For Beanbag, Inc. > RBTools > Ticket #4819 Reply: (+ debug log) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190821101914.3384.80016%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/ -- New update by c0d3h4x0r For Beanbag, Inc. > RBTools > Ticket #4819 Reply: @dan_regan, I'm interested in what issue you're seeing exactly, because the patch (well, a variation on the concept) _does_ fix the issue here. Can you provide a full backtrace? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190821101902.3380.88142%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/ -- New update by c0d3h4x0r For Beanbag, Inc. > RBTools > Ticket #4819 Reply: I'm sorry, this fell through the cracks. This will be fixed in the next release of RBTools, alongside other Python 3.x fixes. Status: - NeedInfo + Confirmed Milestones: + Release-1.0.x Tags: - Priority:Medium + Priority:High + SCM:Perforce Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190821095509.3383.86495%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4841: When using :smiley_code:, it doesn't render correct emoji. For example, using :ok_hand: renders a broken image, and then the unicode symbol. The symbol is rendered becau
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4841/ -- New update by OmShiv For Beanbag, Inc. > Review Board > Ticket #4841 Reply: This was fixed in Review Board 3.0.15. It was due to a change in the URL for the CDN we used for Emoji. Status: - New + Duplicate Duplicate of: + 4817 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190821095131.3381.64841%40ip-10-1-54-209.ec2.internal.
Re: Review Board Ticket #4828: Provide triggering user in webhook json
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4828/ -- New update by splatter2 For Beanbag, Inc. > Review Board > Ticket #4828 Reply: Definitely worth adding. Status: - New + Confirmed Milestones: + Release-4.0 Tags: + Component:Webhooks Assigned to: + david -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190713042635.7283.22209%40ip-10-1-54-209.ec2.internal. For more options, visit https://groups.google.com/d/optout.
Re: RBTools Ticket #4832: post-review fails to post diff to reviewboard server
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4832/ -- New update by kavimalargks For Beanbag, Inc. > RBTools > Ticket #4832 Reply: RBTools 0.4.3 is 6 years old at this point. I'm afraid you'll need to upgrade to a modern version, which should have this fixed. Status: - New + Fixed Project: - reviewboard + rbtools Summary: - post-review fails to post diff to reviewboard server + post-review fails to post diff to reviewboard server -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190713042518.7283.8873%40ip-10-1-54-209.ec2.internal. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4833: export Excel
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4833/ -- New update by dotoricry For Beanbag, Inc. > Review Board > Ticket #4833 Reply: Can you provide more information on what you're looking to do? We need a lot more details about this feature request, including examples of what you're looking for. If we added this feature, it would be a part of our licensed add-on product, [Power Pack](https://www.reviewboard.org/powerpack/). Status: - New + NeedInfo -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190713042340.7283.90089%40ip-10-1-54-209.ec2.internal. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4835: Diff View syntax highlighting broken for Angular html template files
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4835/ -- New update by splatter2 For Beanbag, Inc. > Review Board > Ticket #4835 Reply: We use [Pygments](http://pygments.org/) for all syntax highlighting, which does support the highlighting, but we currently choose a lexer based on filename and not the content. The reason is that for a long time, some file types (large XML-based documents in particular) were so slow to guess that Pygments would sometimes stall Apache threads. I don't believe this is a problem anymore, so we probably will want to move to content-based lexer selection, but probably not until Review Board 4.0, due to the significant behavior change (which I'm sure will cause other regressions). What file extension are you using for these files? Just `.html`? Status: - New + NeedInfo Milestones: + Release-3.0.x + Release-4.0 Tags: + Component:DiffViewer -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190713042022.32372.50492%40ip-10-1-54-209.ec2.internal. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4824: Use a better text diff'ing algorithm (at least as an option)
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4824/ -- New update by jsyjr For Beanbag, Inc. > Review Board > Ticket #4824 Reply: We do have plans to improve diffing, and have wanted to do this for a while. There are cases where the current algorithm works better, and cases where other algorithms work better, and the plan is to weigh a default based on the file type but to also attempt a couple different algorithms and analyze them to determine the best one. There's a lot of work required to get there. Won't happen for 4.0, but maybe 5.0. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190528182914.32247.28865%40ip-10-1-54-209.ec2.internal. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4821: if you only delete a comment - it is not marked as a change
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4821/ -- New update by narlah For Beanbag, Inc. > Review Board > Ticket #4821 Reply: Would you be able to send a publicly-viewable source file and a diff that reproduces the issue? Status: - New + NeedInfo Tags: + Component:DiffViewer -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190521082322.9692.13060%40ip-10-1-54-209.ec2.internal. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4817: Emojis are not being displayed correctly
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4817/ -- New update by joekuang For Beanbag, Inc. > Review Board > Ticket #4817 Reply: Fixed on release-3.0.x (4c314f2185093125fcf75778f07e3845ab4b9280). Scheduled for 3.0.15. Status: - New + Fixed Milestones: + Release-3.0.x Tags: + Component:Reviews Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4800: Logs filling up with avatar service errors
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4800/ -- New update by splatter2 For Beanbag, Inc. > Review Board > Ticket #4800 Reply: Should be fixed for the upcoming Djblets 1.0.12/Review Board 3.0.15 releases (6731d9b977f13687405089cf792ce21210209327 on Djblets release-1.0.x). Status: - Confirmed + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4800: Logs filling up with avatar service errors
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4800/ -- New update by splatter2 For Beanbag, Inc. > Review Board > Ticket #4800 Reply: I think I see why. We'll get a fix for 3.0.15. Status: - New + Confirmed Milestones: + Release-3.0.x Tags: + Component:Avatars + Component:Avatars Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: RBTools Ticket #4804: rbt patch doesn't work with svn 1.10 and above
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4804/ -- New update by samsun387 For Beanbag, Inc. > RBTools > Ticket #4804 Reply: svn 1.10 should be working. Looks like it's unhappy with the version it's seeing. Can you run `svn --version` and show me the output? Also, run your patch command with `--debug` as the first argument and show me the resulting log. I need to see where it's going wrong. Status: - New + NeedInfo -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: RBTools Ticket #4799: rbt diff Index line only show file name and "rbt diff" line ending contains extra "\r"
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4799/ -- New update by jackdai For Beanbag, Inc. > RBTools > Ticket #4799 Reply: Hi, Can you show me the plain `svn diff` as well? Status: - New + NeedInfo -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4798: "There was an error displaying this diff." for any SVN file that no longer exists at its former location
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4798/ -- New update by a-dogg For Beanbag, Inc. > Review Board > Ticket #4798 Reply: How's the diff being generated? Is this `svn diff`, RBTools, or an in-house product? Status: - New + NeedInfo -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Djblets Ticket #4578: Please add option to disable "send on behalf"
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4578/ -- New update by streamofstars For Beanbag, Inc. > Djblets > Ticket #4578 Reply: Fixed on release-1.0.x (cf6dfe1e155493746abf94fa483ecec5f349b1a2). This will be part of the upcoming 1.0.10, and Review Board will have a setting for it in the E-Mail Settings page. Status: - Confirmed + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Djblets Ticket #4578: Please add option to disable "send on behalf"
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4578/ -- New update by streamofstars For Beanbag, Inc. > Djblets > Ticket #4578 Reply: Sorry, this won't make the release. There's some regressions with this, so we're having to back it out. Status: - Fixed + Confirmed Project: - reviewboard + djblets Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4790: Can't clear out the reviewers groups feild
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4790/ -- New update by patrikha For Beanbag, Inc. > Review Board > Ticket #4790 Reply: Fix up for review: https://reviews.reviewboard.org/r/10411/ Status: - New + PendingReview -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4790: Can't clear out the reviewers groups feild
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4790/ -- New update by patrikha For Beanbag, Inc. > Review Board > Ticket #4790 Milestones: + Release-3.0.x Tags: - Priority:Medium + Component:WebUI + Priority:High Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4790: Can't clear out the reviewers groups feild
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4790/ -- New update by patrikha For Beanbag, Inc. > Review Board > Ticket #4790 Reply: Looking into getting a fix out for this soon. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4759: Webhooks are broken in 3.0.9
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4759/ -- New update by splatter2 For Beanbag, Inc. > Review Board > Ticket #4759 Reply: There's going to be a fix for this in today's release. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4737: Adding Gitlab Repository fails with Gitlab 11.x
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4737/ -- New update by mckownam For Beanbag, Inc. > Review Board > Ticket #4737 Reply: Added improved error information (containing possible solutions) to diagnose failures on release-3.0.x (b7fb9cf78f10962215f22d3a552c11f23e49d987). -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4759: Webhooks are broken in 3.0.9
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4759/ -- New update by splatter2 For Beanbag, Inc. > Review Board > Ticket #4759 Reply: Fix up for review. It'll be in 3.0.10. Sorry for the trouble! https://reviews.reviewboard.org/r/10235/ Status: - New + PendingReview Milestones: + Release-3.0.x Tags: - Priority:Medium + Component:Webhooks + Priority:High -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #3906: Spellchecker does not work in comments field
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/3906/ -- New update by den.a**@gmai* (Google Code) For Beanbag, Inc. > Review Board > Ticket #3906 Reply: You can turn it off in your account settings. Rich text is frequently used, so we won't be getting rid of it, but it is optional. As more tools (and browsers themselves) begin using the same component we use, I'm still hopeful we'll get proper spell check support in time. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Djblets Ticket #4742: Exception when reading UTF-8 encoded metadata of extension
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4742/ -- New update by fschlager For Beanbag, Inc. > Djblets > Ticket #4742 Reply: We're preparing a release for this, hopefully out in the next couple days. We hoped to get it out earlier, but had some delays on our end. You can temporarily work around this if you don't mind modifying extension.py and changing that line to: ```python data = b'\n'.join(lines) ``` -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4730: Reviewboard repository names are limited to 64 characters
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4730/ -- New update by mgokhale-arbor For Beanbag, Inc. > Review Board > Ticket #4730 Reply: I wouldn't say that the limit is a bug, but I can see where your naming scheme runs into problems. I think a limit of 255 produces other problems, namely the display of names in the New Review Request page and elsewhere. _Usually_, repositories in Review Board are named after the actual name of the repository on whatever service is being used, with a namespace being used to disambiguate (so for instance, `Review Board` and `RBTools` would be repository names, but `CI Infrastructure` and `Web Server Infrastructure` might be used instead of `ci-team/infrastructure` and `web-team/infrastructure`. It's easier to read/consume by users, avoids a lot of wrapping issues that longer names provide, and survives the moving of repositories to other groups down the road after reorgs. I'm not against bumping up the limit, but I wouldn't want to do it in a point release, since that impacts many customers of ours who have to be careful about when they perform upgrades that impact database schema. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: RBTools Ticket #4728: Git svn : diff can't be generated because of badly formatted call to git rev-list
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4728/ -- New update by KG For Beanbag, Inc. > RBTools > Ticket #4728 Milestones: + Release-1.0.x -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: RBTools Ticket #4728: Git svn : diff can't be generated because of badly formatted call to git rev-list
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4728/ -- New update by KG For Beanbag, Inc. > RBTools > Ticket #4728 Reply: Thanks! Definitely had this wrong. We'll get a fix into 1.0.2. Status: - New + Confirmed Tags: + SCM:Git Assigned to: + david -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: RBTools Ticket #4711: "putch() argument 1 must be char, not unicode" when authenticating
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4711/ -- New update by ACascarino For Beanbag, Inc. > RBTools > Ticket #4711 Reply: There's no public document for this, but we've tested all the commands and have been dogfooding this for many months. This particular issue occurs only on Windows, though (which has its own very annoying and specific characteristics when it comes to string types), and as we're primarily doing development on Linux/Mac, we haven't hit this issue ourselves. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4712: Internal Error when getting status updates when a previous status update is error.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4712/ -- New update by jcannon For Beanbag, Inc. > Review Board > Ticket #4712 Reply: Thanks for the fix! It's on release-3.0.x (4d321f4f30a83152c53e2dc3cd38962948cefd66) and going out today. Status: - NeedInfo + Fixed Milestones: + Release-3.0.x Tags: + Component:Reviews -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4708: Please make update emails more concise.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4708/ -- New update by solarmist For Beanbag, Inc. > Review Board > Ticket #4708 Reply: It's common for people to be introduced to a review request later in the review cycle for a change, and at that point they're often newly introduced to the e-mail thread. Without the quoting, the context in the thread is lost. We have companies that highly depend on the e-mail threads, where linking to the review request URL isn't sufficient. (We actually get the opposite of this request at times -- make them more verbose, include more information.) Reducing the information in the thread would impact those companies. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4699: Wrong filtering of opcodes for an interdiff
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4699/ -- New update by alexG For Beanbag, Inc. > Review Board > Ticket #4699 Reply: Thanks for the contribution, but as mentioned above, I have a rewrite of the algorith mthat does the right thing. It's aimed for the next 3.0.x release (had to delay it for other reasons). -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4693: Long time loading diff chunks for interdiffs
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4693/ -- New update by alexG For Beanbag, Inc. > Review Board > Ticket #4693 Reply: At the point of the diff chunk generation, it should have already fetched the files, and is now just patching them, diffing into chunks, and generating HTML from them. Something is definitely going very wrong. Larger files than that take a lot less time on our servers with much lower specs, with large numbers of active users. I'm not sure what to point to, but we're probably getting to a point where the kind of diagnostics I'd need to do would require a support contract in place (custom builds and maybe a live session to test things on the server). -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4693: Long time loading diff chunks for interdiffs
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4693/ -- New update by alexG For Beanbag, Inc. > Review Board > Ticket #4693 Reply: Try setting a line limit there (say, 8000 lines). That will turn off syntax highlighting if the file is too big, which should cut down on the time taken. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4693: Long time loading diff chunks for interdiffs
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4693/ -- New update by alexG For Beanbag, Inc. > Review Board > Ticket #4693 Reply: Wow, 8 seconds and 24 seconds is way too long. That doesn't seem right at all for the specs you're listing. I'd expect < 1 second. How big are these files on the server? What VM technology are you using? Are those specs the VM's or the underlying server's? What else is running on that server? Can you show me a span of the log file containing timings to help me get a complete picture? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4693: Long time loading diff chunks for interdiffs
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4693/ -- New update by alexG For Beanbag, Inc. > Review Board > Ticket #4693 Reply: Hi, So first, let's address the slowdown. This is absolutely not normal behavior, and points to a problem communicating with the repository. What type of repository are you using? Can you make sure debug logging is enabled in Admin UI -> Logging, reproduce this behavior, and then look in reviewboard.log and look for the log timings for fetching files from the repository? Also, what are the specs for the server you're running Review Board on? As for the proposals: 1. This would actually make the problem worse. We calculate chunks on-demand so that we don't have to do all of it in one HTTP request (which will definitely time out in your situation). We also don't want to store them permanently, as that will take up a _lot_ of space and will cause problems as we fix or tweak the diff viewer. 2. We wouldn't want to add an explicit button (as this is not normally an issue on installs, and people are used to the current behavior). However, Review Board 3.0 does make improvements to the interaction with the slider behind the scenes, being smarter about cancelling previous loads and starting new ones. 3. I'm not opposed to having per-file full-expand buttons (we already allow for expanding individual chunks), but it should not matter in your case. Once the diffs have already been processed and put in memcached, an expand does not have to re-process all the diffs. Is it possible your memcached isn't actually working? Status: - New + NeedInfo -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4679: Cannot save bug tracker settings for trac or jira
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4679/ -- New update by Misery For Beanbag, Inc. > Review Board > Ticket #4679 Reply: Fixed on release-3.0.x (d1e67884bad1042a3308fdc0d4f3ef8816dce9b4). Status: - PendingReview + Fixed -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4679: Cannot save bug tracker settings for trac or jira
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4679/ -- New update by Misery For Beanbag, Inc. > Review Board > Ticket #4679 Reply: Fix up for review. https://reviews.reviewboard.org/r/9900/ Sorry this took so long. Had some other priorities to attend to. Release with this will be out in a little over a week. Status: - New + PendingReview Milestones: + Release-3.0.x Tags: + Component:Admin Assigned to: + chipx86 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
