Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #23 on issue 2916 by prog...@gmail.com: Review Board does not respect line endings https://code.google.com/p/reviewboard/issues/detail?id=2916 I think issue 3198 is another duplicate of this issue This issue issue affect me too- i need the patch to preserve the original CRLFs to be able to cleanly apply the patches. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #24 on issue 2916 by chip...@gmail.com: Review Board does not respect line endings https://code.google.com/p/reviewboard/issues/detail?id=2916 This bug has moved to https://hellosplat.com/s/beanbag/tickets/2916/. Please post any updates there. You can use your existing Google login. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #21 on issue 2916 by ja...@jasonantman.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 I'm being bitten by this issue as well, and it's a real pain when trying to wrap automation around ReviewBoard (i.e. a Jenkins job that has a git commit hash, and tries to make sure the current diff against master matches the one that was shipped). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #19 on issue 2916 by inebriec...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 1.7.14 has this issue as well... -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #17 on issue 2916 by javawiz...@opengroove.org: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 1.7.9 also has this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #16 on issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 What version of the RB is planned to include this patch? Version 1.7.7.1 does not contain its. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #11 on issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 We running 1.6.16 Everything works fine with patches that contains unix line endings or unix line endings+windows line endings. But gives the error if the patch contains only windows line endings. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #12 on issue 2916 by rajas...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Just verified that its not in 1.6.16 either, You would need to be on the 1.7 tree to have that change. The stripping of the newlines is what makes the difference. With my patch on 1.7 tree, it would work because the strip takes care of removing the newlines before the regex parsing happens, but with 1.6.x, since the regex looks like for a line ending with revision () it fails because windows styled line endings have a \r\n tacked after the revision (). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #13 on issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 I see. That is your patch is only suitable for the 1.7 tree? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #8 on issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Some problem detected with this patch. Unable to add patch with windows line endings (CRLF). Trying to add such patch gives the following error: Unable to parse diff revision header '(revision NNN) ' NNN - revision number. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #10 on issue 2916 by rajas...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Are you running 1.6.15? I can see that the string is stripped (which should remove the newlines) before the regex is applied (failing the regex throws the error you mentioned), but the strip is not in the 1.6.15 branch, only on master (1.7 or above). You might want to try it on a 1.7 reviewboard to see if its still a problem. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #7 on issue 2916 by vsavc...@productengine.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Tested the patch, works well. Thank a lot! Looking forward to seeing it in a release. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #6 on issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 How we can apply this patch? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #5 on issue 2916 by rajas...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Posted a patch for this at http://reviews.reviewboard.org/r/3970/. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #3 on issue 2916 by rajas...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Chris/David, Would it work if we make DiffParser class init do a data.splitlines(True) instead of data.splitlines(), which will keep the line-endings intact(instead of stripping it as it does now and the code manually tacking a \n at the end). We would then have to manipulate the patch method in diffutils.py to strip the line-endings in a way that patch can understand. That way, the data stored in filediffdata remains the same as what the user uploaded, and can be downloaded as such. Maybe Im over-simplifying this issue but thought Id check with you guys before I start on this. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #4 on issue 2916 by chip...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 Perhaps... Line endings in general are a real problem in diffs, because not only do you have \n and \r\n to deal with, but some things will stupidly give you \r\r\n and other mixtures. If that change passes all unit tests, then I'm okay shipping it and seeing if there's fallout. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2916 in reviewboard: Review Board does not respect line endings
Comment #1 on issue 2916 by guilhem@mines-paris.org: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 We are seeing exactly the same problem, in the MySQL group of Oracle. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Issue 2916 in reviewboard: Review Board does not respect line endings
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2916 by kanoni...@gmail.com: Review Board does not respect line endings http://code.google.com/p/reviewboard/issues/detail?id=2916 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this bug report! What version are you running? 1.6.15 What's the URL of the page containing the problem? Any diff viewer page. What steps will reproduce the problem? Patches downloaded from the Review Board seem to always have Unix line endings (LF), no matter what line endings the original patch has. I.e. if you submit a patch that contains DOS line endings (CRLF) to Review board and then download it from the review request, the DOS line endings get lost. You cannot apply such a patch. What is the expected output? What do you see instead? What we need is for Review Board to always preserve original line endings, i.e. an uploaded patch should not change when you download it back. For example, if the source contains mixture of DOS and Unix line endings, it should be preserved as is, otherwise applying the patch will fail. What operating system are you using? What browser? Windows/Linux, Chrome,Firefox, Opera. Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
