Re: Review Request 42155: AMBARI-14605 '[RAM_DISK]' configured in dfs.datanode.data.dir fails to validate

[yao lei]

> On 五月 4, 2016, 4:14 a.m., Matt wrote:
> > You may close this review as it has been submitted already.

ok,thanks,Matt


- yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42155/#review131621
---


On 五月 3, 2016, 4:57 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42155/
> ---
> 
> (Updated 五月 3, 2016, 4:57 a.m.)
> 
> 
> Review request for Ambari and Matt.
> 
> 
> Bugs: AMBARI-14605
> https://issues.apache.org/jira/browse/AMBARI-14605
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS now support four kinds of heterogeneous storage types: ARCHIVE, DISK, 
> SSD and RAM_DISK.
> If we configure dfs.datanode.data.dir as [RAM_DISK]/anydir,it fails to 
> validate.
> please see 
> https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/ArchivalStorage.html#Configuration
> A
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/validator.js 9d11746 
>   ambari-web/test/utils/validator_test.js ef90561 
> 
> Diff: https://reviews.apache.org/r/42155/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> But Ambari Web Unit Test fails in trunk for other reasons described in 
> https://builds.apache.org/job/Ambari-trunk-test-patch/4848//artifact/patch-work/testrun_ambari-web.txt
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 42155: AMBARI-14605 '[RAM_DISK]' configured in dfs.datanode.data.dir fails to validate

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42155/#review131621
---



You may close this review as it has been submitted already.

- Matt


On May 2, 2016, 9:57 p.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42155/
> ---
> 
> (Updated May 2, 2016, 9:57 p.m.)
> 
> 
> Review request for Ambari and Matt.
> 
> 
> Bugs: AMBARI-14605
> https://issues.apache.org/jira/browse/AMBARI-14605
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS now support four kinds of heterogeneous storage types: ARCHIVE, DISK, 
> SSD and RAM_DISK.
> If we configure dfs.datanode.data.dir as [RAM_DISK]/anydir,it fails to 
> validate.
> please see 
> https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/ArchivalStorage.html#Configuration
> A
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/validator.js 9d11746 
>   ambari-web/test/utils/validator_test.js ef90561 
> 
> Diff: https://reviews.apache.org/r/42155/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> But Ambari Web Unit Test fails in trunk for other reasons described in 
> https://builds.apache.org/job/Ambari-trunk-test-patch/4848//artifact/patch-work/testrun_ambari-web.txt
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 46959: AMBARI-16240: Ambari operation history: Syntax error in Ambari-DDL-Postgres-CREATE.sql causes ambari-server setup to fail in 2.4.0.0-489

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46959/
---

(Updated May 3, 2016, 8:57 p.m.)


Review request for Ambari, Ajit Kumar and Sumit Mohanty.


Changes
---

Fix Derby DB as well.


Bugs: AMBARI-16240
https://issues.apache.org/jira/browse/AMBARI-16240


Repository: ambari


Description
---

AMBARI-16240: Ambari operation history: Syntax error in 
Ambari-DDL-Postgres-CREATE.sql causes ambari-server setup to fail in 2.4.0.0-489

** Issue **:

Presence of highlighted semi-colon below causes setup of Ambari 2.4.0.0-489 to 
fail in PostgresDB. 

./ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
1087   select 'servicecomponent_history_id_seq', 0
1088   union all
1089   select 'blueprint_setting_id_seq', 0**;**
{color}
1090   union all
1091   select 'ambari_operation_history_id_seq', 0;


Diffs (updated)
-

  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
c9026378b4167ab9c857151e1e5d529ca6cadc45 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
85cc0be5520327800de9f0e4fa84daf78b53b7af 

Diff: https://reviews.apache.org/r/46959/diff/


Testing
---

** Manual Testing **

Ran the Ambari-DDL-Postgres-CREATE.sql file on an emtpy *ambari* database on 
Postgres SQL server and verified that no exceptions were thrown.


Thanks,

Nahappan Somasundaram

Review Request 46959: AMBARI-16240: Ambari operation history: Syntax error in Ambari-DDL-Postgres-CREATE.sql causes ambari-server setup to fail in 2.4.0.0-489

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46959/
---

Review request for Ambari, Ajit Kumar and Sumit Mohanty.


Bugs: AMBARI-16240
https://issues.apache.org/jira/browse/AMBARI-16240


Repository: ambari


Description
---

AMBARI-16240: Ambari operation history: Syntax error in 
Ambari-DDL-Postgres-CREATE.sql causes ambari-server setup to fail in 2.4.0.0-489

** Issue **:

Presence of highlighted semi-colon below causes setup of Ambari 2.4.0.0-489 to 
fail in PostgresDB. 

./ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
1087   select 'servicecomponent_history_id_seq', 0
1088   union all
1089   select 'blueprint_setting_id_seq', 0**;**
{color}
1090   union all
1091   select 'ambari_operation_history_id_seq', 0;


Diffs
-

  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
85cc0be5520327800de9f0e4fa84daf78b53b7af 

Diff: https://reviews.apache.org/r/46959/diff/


Testing
---

** Manual Testing **

Ran the Ambari-DDL-Postgres-CREATE.sql file on an emtpy *ambari* database on 
Postgres SQL server and verified that no exceptions were thrown.


Thanks,

Nahappan Somasundaram

Re: Review Request 46947: AMBARI-16235: Add beeline, hive-exec and hive log properties to /etc/hive2/conf

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46947/#review131611
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 (line 86)


I believe this call creates hive-log4j.properties file that will conflict 
with hive-log4j2.properties

We need to add some logic to ensure that only one of them remain.

One way to check it is that the unit tests has lines asserting that 
hive-log4j.properties file has been created.


- Sumit Mohanty


On May 4, 2016, 2:52 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46947/
> ---
> 
> (Updated May 4, 2016, 2:52 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16235
> https://issues.apache.org/jira/browse/AMBARI-16235
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-16235: Add beeline, hive-exec and hive log properties to 
> /etc/hive2/conf
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  e8532dac9d9324b2f45e89464132b4f4435020c1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  ec43fead7002106ee363d7c13e55a1e72d3fa5d8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/beeline-log4j2.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 6a0d777488a7f5a3b9b75262e2a8afcdb52d8d83 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 
> 9bff890b4c4f71fe1b65253a5151683a7e7b3611 
> 
> Diff: https://reviews.apache.org/r/46947/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [6.993s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.046s]
> [INFO] Ambari Web  SUCCESS [25.223s]
> [INFO] Ambari Views .. SUCCESS [1.502s]
> [INFO] Ambari Admin View . SUCCESS [8.011s]
> [INFO] ambari-metrics  SUCCESS [0.435s]
> [INFO] Ambari Metrics Common . SUCCESS [0.698s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.337s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.595s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.729s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.830s]
> [INFO] Ambari Metrics Collector .. SUCCESS [7.989s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.314s]
> [INFO] Ambari Metrics Grafana  SUCCESS [1.042s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:22.548s]
> [INFO] Ambari Server . SUCCESS [3:00.467s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.466s]
> [INFO] Ambari Agent .. SUCCESS [26.489s]
> [INFO] Ambari Client . SUCCESS [0.053s]
> [INFO] Ambari Python Client .. SUCCESS [0.844s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.173s]
> [INFO] Ambari Shell .. SUCCESS [0.043s]
> [INFO] Ambari Python Shell ... SUCCESS [0.707s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.963s]
> [INFO] ambari-logsearch .. SUCCESS [0.370s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.212s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [6.810s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [2.038s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [0.782s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.095s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 

Re: Review Request 46947: AMBARI-16235: Add beeline, hive-exec and hive log properties to /etc/hive2/conf

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46947/
---

(Updated May 3, 2016, 7:52 p.m.)


Review request for Ambari, Sumit Mohanty and Swapan Shridhar.


Changes
---

hive-log4j2.xml: @ to process-id@host-name


Bugs: AMBARI-16235
https://issues.apache.org/jira/browse/AMBARI-16235


Repository: ambari


Description
---

AMBARI-16235: Add beeline, hive-exec and hive log properties to /etc/hive2/conf


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 e8532dac9d9324b2f45e89464132b4f4435020c1 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 ec43fead7002106ee363d7c13e55a1e72d3fa5d8 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/beeline-log4j2.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
6a0d777488a7f5a3b9b75262e2a8afcdb52d8d83 
  ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 
9bff890b4c4f71fe1b65253a5151683a7e7b3611 

Diff: https://reviews.apache.org/r/46947/diff/


Testing
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [6.993s]
[INFO] Apache Ambari Project POM . SUCCESS [0.046s]
[INFO] Ambari Web  SUCCESS [25.223s]
[INFO] Ambari Views .. SUCCESS [1.502s]
[INFO] Ambari Admin View . SUCCESS [8.011s]
[INFO] ambari-metrics  SUCCESS [0.435s]
[INFO] Ambari Metrics Common . SUCCESS [0.698s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.337s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.595s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.729s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.830s]
[INFO] Ambari Metrics Collector .. SUCCESS [7.989s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.314s]
[INFO] Ambari Metrics Grafana  SUCCESS [1.042s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:22.548s]
[INFO] Ambari Server . SUCCESS [3:00.467s]
[INFO] Ambari Functional Tests ... SUCCESS [1.466s]
[INFO] Ambari Agent .. SUCCESS [26.489s]
[INFO] Ambari Client . SUCCESS [0.053s]
[INFO] Ambari Python Client .. SUCCESS [0.844s]
[INFO] Ambari Groovy Client .. SUCCESS [2.173s]
[INFO] Ambari Shell .. SUCCESS [0.043s]
[INFO] Ambari Python Shell ... SUCCESS [0.707s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.963s]
[INFO] ambari-logsearch .. SUCCESS [0.370s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.212s]
[INFO] Ambari Logsearch Portal ... SUCCESS [6.810s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [2.038s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [0.782s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.095s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:05.520s
[INFO] Finished at: Tue May 03 14:00:49 PDT 2016
[INFO] Final Memory: 280M/1165M
[INFO] 

** 2. mvn test -DskipSurefireTests **

--
Ran 261 tests in 6.631s

OK
--
Total run:1013
Total errors:0
Total failures:0
OK
INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
INFO: Return code from stack upgrade command, retcode = 0
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor 

Re: Review Request 46953: AMBARI-16239: Incorrect warning for not selecting nfs_gateway_hosts

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46953/#review131597
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On May 4, 2016, 12:36 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46953/
> ---
> 
> (Updated May 4, 2016, 12:36 a.m.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Zhe (Joe) Wang.
> 
> 
> Bugs: AMBARI-16239
> https://issues.apache.org/jira/browse/AMBARI-16239
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix empty value check for [] case;
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/configs/objects/service_config_property.js a244dfd 
> 
> Diff: https://reviews.apache.org/r/46953/diff/
> 
> 
> Testing
> ---
> 
> Manually tested for live cluster.
> All unit tests passed.
>   27526 tests complete (26 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Review Request 46953: AMBARI-16239: Incorrect warning for not selecting nfs_gateway_hosts

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46953/
---

Review request for Ambari, Andriy Babiichuk and Zhe (Joe) Wang.


Bugs: AMBARI-16239
https://issues.apache.org/jira/browse/AMBARI-16239


Repository: ambari


Description
---

Fix empty value check for [] case;


Diffs
-

  ambari-web/app/models/configs/objects/service_config_property.js a244dfd 

Diff: https://reviews.apache.org/r/46953/diff/


Testing
---

Manually tested for live cluster.
All unit tests passed.
  27526 tests complete (26 seconds)
  154 tests pending


Thanks,

Richard Zang

Review Request 46951: AMBARI-16238 VDF UI edits: #1

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46951/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi 
Wang, and Yusaku Sako.


Bugs: AMBARI-16238
https://issues.apache.org/jira/browse/AMBARI-16238


Repository: ambari


Description
---

Minor UX changes to VDF flow. This was during Install Wizard but same should be 
applied to Version Registration, etc.


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
 e6748b8 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
 8246c2b 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
175792c 
  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 3e0bd30 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/modals/BodyForUseRedhatSatellite.html
 PRE-CREATION 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
 26068a2 
  ambari-web/app/controllers/installer.js 02511e8 
  ambari-web/app/controllers/wizard/step1_controller.js 86117c8 
  ambari-web/app/controllers/wizard/step8_controller.js 11ff7ed 
  ambari-web/app/mappers/stack_mapper.js e3fb8fc 
  ambari-web/app/messages.js c5e1145 
  ambari-web/app/models/stack_version/service_simple.js 3f4b36d 
  ambari-web/app/styles/application.less 87fc485 
  ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 
63690b7 
  ambari-web/app/templates/main/host/details/doDeleteHostPopup.hbs d209d54 
  ambari-web/app/templates/wizard/step1.hbs 2b5dc38 
  ambari-web/app/templates/wizard/step8.hbs 9a56b28 
  ambari-web/app/utils/ajax/ajax.js bccdc1b 
  ambari-web/app/views/wizard/step10_view.js d1e7be7 
  ambari-web/app/views/wizard/step1_view.js 7348cbf 
  ambari-web/app/views/wizard/step7/assign_master_view.js 1ad818a 
  ambari-web/test/controllers/wizard/step8_test.js a3e3f7e 
  ambari-web/test/views/wizard/step10_view_test.js 92668e6 
  ambari-web/test/views/wizard/step7/assign_master_view_test.js 7c4a63e 

Diff: https://reviews.apache.org/r/46951/diff/


Testing
---

Modified test cases.
ambari-web:
27526 tests complete (23 seconds)
154 tests pending
ambari-admin:
Executed 64 of 64 SUCCESS (0.115 secs / 0.335 secs)
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

[Ajit Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46944/#review131590
---


Ship it!




Ship It!

- Ajit Kumar


On May 3, 2016, 7:36 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46944/
> ---
> 
> (Updated May 3, 2016, 7:36 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-16230
> https://issues.apache.org/jira/browse/AMBARI-16230
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 2 different type of errors can occur during adding any new service to Ambari:
> 
> org.apache.ambari.server.AmbariException: Unable to create a default alert 
> group for unknown service  in cluster
> 
> org.apache.ambari.server.ServiceNotFoundException: Service not found, 
> clusterName=c1, serviceName=
> 
> The reason is that: ServiceInstalledEvent can be handled quicker than 
> ServiceImpl.persist() can finish
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  47342f3 
> 
> Diff: https://reviews.apache.org/r/46944/diff/
> 
> 
> Testing
> ---
> 
> Unit Testing is in progress..
> FT: added new services about 10 times, has no any errors thrown.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

[Matt]

> On May 3, 2016, 4:14 p.m., Matt wrote:
> >

Discussed this in person:
This function is not used anywhere else, besides PXF service. Logging would be 
taken care of by PXF service component.


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46949/#review131580
---


On May 3, 2016, 4:05 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46949/
> ---
> 
> (Updated May 3, 2016, 4:05 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16237
> https://issues.apache.org/jira/browse/AMBARI-16237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF alerts shows "Configuration parameter 'fs_root' was not found in 
> configurations dictionary!" when both namnodes are down on secured NN HA 
> environment, which the error message is not too clear.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
>  ee16c9b 
> 
> Diff: https://reviews.apache.org/r/46949/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46949/#review131580
---


Ship it!





ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
 (line 141)


Is there a possibility where active_namenodes can be an empty list? - A 
case where both namenodes are down?



ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
 (line 143)


Do you need to log this explicitly using Logger.fail() or does it get 
logged automatically to std-err log, which shows up the UI?


- Matt


On May 3, 2016, 4:05 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46949/
> ---
> 
> (Updated May 3, 2016, 4:05 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16237
> https://issues.apache.org/jira/browse/AMBARI-16237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF alerts shows "Configuration parameter 'fs_root' was not found in 
> configurations dictionary!" when both namnodes are down on secured NN HA 
> environment, which the error message is not too clear.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
>  ee16c9b 
> 
> Diff: https://reviews.apache.org/r/46949/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review131579
---



The functionality of ServiceAdvisor works as expected. However more 
clarification is needed on how to use inheritance and override service advisor 
defined in common-services. 
For example:
HAWQ200ServiceAdvisor is defined under commmon-services. I'd like to override 
the method getComponentLayoutScheme with some new logic for HDP 2.3 stack. 
Followed the documentation in 
ambari-server/src/main/resources/stacks/service_advisor.py but it did not work 
as expected.

- Matt


On May 3, 2016, 12:04 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated May 3, 2016, 12:04 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  356adb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 5a2bf84 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 1680f21 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> f475798 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 9979e7e 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 2080c52 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46927: AMBARI-16210. Update Storm Ambari stack definition to work with 1.0 release.

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46927/#review131570
---


Ship it!




Ship It!

- Jaimin Jetly


On May 3, 2016, 4:52 a.m., Sriharsha Chintalapani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46927/
> ---
> 
> (Updated May 3, 2016, 4:52 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-16210. Update Storm Ambari stack definition to work with 1.0 release.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml
>  5a3901a 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/pacemaker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py
>  d0b717f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/metainfo.xml 
> a296bfa 
> 
> Diff: https://reviews.apache.org/r/46927/diff/
> 
> 
> Testing
> ---
> 
> Deployed a 3 node cluster and ran sample topologies. Also kerbeorized the 
> cluster.
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>

Review Request 46947: AMBARI-16235: Add beeline, hive-exec and hive log properties to /etc/hive2/conf

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46947/
---

Review request for Ambari, Sumit Mohanty and Swapan Shridhar.


Bugs: AMBARI-16235
https://issues.apache.org/jira/browse/AMBARI-16235


Repository: ambari


Description
---

AMBARI-16235: Add beeline, hive-exec and hive log properties to /etc/hive2/conf


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 e8532dac9d9324b2f45e89464132b4f4435020c1 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 cef2cbc14a809c792314b0620c415d8130a0cd1e 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/beeline-log4j2.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
6a0d777488a7f5a3b9b75262e2a8afcdb52d8d83 
  ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 
9bff890b4c4f71fe1b65253a5151683a7e7b3611 

Diff: https://reviews.apache.org/r/46947/diff/


Testing
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [6.993s]
[INFO] Apache Ambari Project POM . SUCCESS [0.046s]
[INFO] Ambari Web  SUCCESS [25.223s]
[INFO] Ambari Views .. SUCCESS [1.502s]
[INFO] Ambari Admin View . SUCCESS [8.011s]
[INFO] ambari-metrics  SUCCESS [0.435s]
[INFO] Ambari Metrics Common . SUCCESS [0.698s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.337s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.595s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.729s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.830s]
[INFO] Ambari Metrics Collector .. SUCCESS [7.989s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.314s]
[INFO] Ambari Metrics Grafana  SUCCESS [1.042s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:22.548s]
[INFO] Ambari Server . SUCCESS [3:00.467s]
[INFO] Ambari Functional Tests ... SUCCESS [1.466s]
[INFO] Ambari Agent .. SUCCESS [26.489s]
[INFO] Ambari Client . SUCCESS [0.053s]
[INFO] Ambari Python Client .. SUCCESS [0.844s]
[INFO] Ambari Groovy Client .. SUCCESS [2.173s]
[INFO] Ambari Shell .. SUCCESS [0.043s]
[INFO] Ambari Python Shell ... SUCCESS [0.707s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.963s]
[INFO] ambari-logsearch .. SUCCESS [0.370s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.212s]
[INFO] Ambari Logsearch Portal ... SUCCESS [6.810s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [2.038s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [0.782s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.095s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:05.520s
[INFO] Finished at: Tue May 03 14:00:49 PDT 2016
[INFO] Final Memory: 280M/1165M
[INFO] 

** 2. mvn test -DskipSurefireTests **

--
Ran 261 tests in 6.631s

OK
--
Total run:1013
Total errors:0
Total failures:0
OK
INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
INFO: Return code from stack upgrade command, retcode = 0
StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
Returning DefaultStackAdvisor implementation
StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
Returning XYZ101StackAdvisor implementation
[INFO] 
[INFO] BUILD 

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46545/#review131562
---


Ship it!




The upgrade catalog stuff will be in a separate Jira?

- Jonathan Hurley


On May 3, 2016, 4:09 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46545/
> ---
> 
> (Updated May 3, 2016, 4:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, 
> Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16029
> https://issues.apache.org/jira/browse/AMBARI-16029
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-16029: Ambari version history - Create DB table, constraints and 
> sequence id.
> 
> ** Issue **
> In order to support tracking of ambari version, a DB table is required.
> 
> ** Fix **
> Create ambari_operation_history table to store from version, to version, 
> install type, start and stop timestamps.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> 319afa579e6f5090588fb90fe619ee7b6bae6d78 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> 9a20b8c05801f61a91a092afd4424173a94d7f17 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> e1da7190d6fb929277c834b29cb537107d857bc3 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> ab1eec42fcba467e0bae19674a7877c79eb77b8e 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> bd869f454ae7ec1c84a9cbd418875f10c023a0c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> fdba489f2d0759e9c1282dfad38036f9bce3673d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
> a1da8e5c8343ae554b4e95717cda085c7f79bc46 
> 
> Diff: https://reviews.apache.org/r/46545/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [11.109s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.037s]
> [INFO] Ambari Web  SUCCESS [32.312s]
> [INFO] Ambari Views .. SUCCESS [1.275s]
> [INFO] Ambari Admin View . SUCCESS [8.752s]
> [INFO] ambari-metrics  SUCCESS [0.375s]
> [INFO] Ambari Metrics Common . SUCCESS [0.521s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.184s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.616s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.678s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [2.215s]
> [INFO] Ambari Metrics Collector .. SUCCESS [8.408s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.389s]
> [INFO] Ambari Metrics Grafana  SUCCESS [1.170s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:21.702s]
> [INFO] Ambari Server . SUCCESS [3:40.188s]
> [INFO] Ambari Functional Tests ... SUCCESS [3.530s]
> [INFO] Ambari Agent .. SUCCESS [30.377s]
> [INFO] Ambari Client . SUCCESS [0.106s]
> [INFO] Ambari Python Client .. SUCCESS [1.418s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.914s]
> [INFO] Ambari Shell .. SUCCESS [0.077s]
> [INFO] Ambari Python Shell ... SUCCESS [1.011s]
> [INFO] Ambari Groovy Shell ... SUCCESS [1.401s]
> [INFO] ambari-logsearch .. SUCCESS [0.329s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.377s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [8.035s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [2.534s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [0.906s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.150s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 7:08.197s
> [INFO] Finished at: Tue May 03 13:06:54 PDT 2016
> [INFO] Final Memory: 281M/1172M
> [INFO] 
> 

Re: Review Request 46931: Updated grok lib version(0.1.1 to 0.1.4) to get latest fixes.

[Robert Nettleton]

> On May 3, 2016, 8:28 p.m., Sumit Mohanty wrote:
> > Ship It!

I've just pushed this patch to trunk.

Could the submitter please close out this ReviewBoard as "Submitted"?  

Thanks.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46931/#review131546
---


On May 3, 2016, 11:42 a.m., Hayat Behlim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46931/
> ---
> 
> (Updated May 3, 2016, 11:42 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16211
> https://issues.apache.org/jira/browse/AMBARI-16211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains : 
> Some log messages were not getting parsed due to grok lib issue with v.0.1.1, 
> need to update grok to latest version.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 12255fe 
> 
> Diff: https://reviews.apache.org/r/46931/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hayat Behlim
> 
>

Re: Review Request 46931: Updated grok lib version(0.1.1 to 0.1.4) to get latest fixes.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46931/#review131546
---


Ship it!




Ship It!

- Sumit Mohanty


On May 3, 2016, 11:42 a.m., Hayat Behlim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46931/
> ---
> 
> (Updated May 3, 2016, 11:42 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16211
> https://issues.apache.org/jira/browse/AMBARI-16211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains : 
> Some log messages were not getting parsed due to grok lib issue with v.0.1.1, 
> need to update grok to latest version.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 12255fe 
> 
> Diff: https://reviews.apache.org/r/46931/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hayat Behlim
> 
>

Re: Review Request 46931: Updated grok lib version(0.1.1 to 0.1.4) to get latest fixes.

[Don Bosco Durai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46931/#review131545
---


Ship it!




Ship It!

- Don Bosco Durai


On May 3, 2016, 11:42 a.m., Hayat Behlim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46931/
> ---
> 
> (Updated May 3, 2016, 11:42 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16211
> https://issues.apache.org/jira/browse/AMBARI-16211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains : 
> Some log messages were not getting parsed due to grok lib issue with v.0.1.1, 
> need to update grok to latest version.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 12255fe 
> 
> Diff: https://reviews.apache.org/r/46931/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hayat Behlim
> 
>

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46545/
---

(Updated May 3, 2016, 1:09 p.m.)


Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, 
Jayush Luniya, and Sumit Mohanty.


Changes
---

Updated build and verification.


Bugs: AMBARI-16029
https://issues.apache.org/jira/browse/AMBARI-16029


Repository: ambari


Description
---

AMBARI-16029: Ambari version history - Create DB table, constraints and 
sequence id.

** Issue **
In order to support tracking of ambari version, a DB table is required.

** Fix **
Create ambari_operation_history table to store from version, to version, 
install type, start and stop timestamps.


Diffs
-

  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
319afa579e6f5090588fb90fe619ee7b6bae6d78 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
9a20b8c05801f61a91a092afd4424173a94d7f17 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
e1da7190d6fb929277c834b29cb537107d857bc3 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
ab1eec42fcba467e0bae19674a7877c79eb77b8e 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
bd869f454ae7ec1c84a9cbd418875f10c023a0c2 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
fdba489f2d0759e9c1282dfad38036f9bce3673d 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
a1da8e5c8343ae554b4e95717cda085c7f79bc46 

Diff: https://reviews.apache.org/r/46545/diff/


Testing (updated)
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [11.109s]
[INFO] Apache Ambari Project POM . SUCCESS [0.037s]
[INFO] Ambari Web  SUCCESS [32.312s]
[INFO] Ambari Views .. SUCCESS [1.275s]
[INFO] Ambari Admin View . SUCCESS [8.752s]
[INFO] ambari-metrics  SUCCESS [0.375s]
[INFO] Ambari Metrics Common . SUCCESS [0.521s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.184s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.616s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.678s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [2.215s]
[INFO] Ambari Metrics Collector .. SUCCESS [8.408s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.389s]
[INFO] Ambari Metrics Grafana  SUCCESS [1.170s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:21.702s]
[INFO] Ambari Server . SUCCESS [3:40.188s]
[INFO] Ambari Functional Tests ... SUCCESS [3.530s]
[INFO] Ambari Agent .. SUCCESS [30.377s]
[INFO] Ambari Client . SUCCESS [0.106s]
[INFO] Ambari Python Client .. SUCCESS [1.418s]
[INFO] Ambari Groovy Client .. SUCCESS [2.914s]
[INFO] Ambari Shell .. SUCCESS [0.077s]
[INFO] Ambari Python Shell ... SUCCESS [1.011s]
[INFO] Ambari Groovy Shell ... SUCCESS [1.401s]
[INFO] ambari-logsearch .. SUCCESS [0.329s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.377s]
[INFO] Ambari Logsearch Portal ... SUCCESS [8.035s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [2.534s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [0.906s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.150s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 7:08.197s
[INFO] Finished at: Tue May 03 13:06:54 PDT 2016
[INFO] Final Memory: 281M/1172M
[INFO] 


** 2. Manual testing **
Tested with Ambari-DDL-Postgres-EMBEDDED-CREATE.sql. Copied the SQL script to a 
VM and ran ambari-server reset. Verified the schema:

ambari=> \d+ ambari_operation_history
   Table "ambari.ambari_operation_history"
 Column |  Type  | Modifiers | Storage  | Description
++---+--+-
 id | bigint | not null  | plain|
 from_version   | 

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

[Ajit Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46545/#review131542
---


Ship it!




Ship It!

- Ajit Kumar


On May 3, 2016, 4:33 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46545/
> ---
> 
> (Updated May 3, 2016, 4:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, 
> Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16029
> https://issues.apache.org/jira/browse/AMBARI-16029
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-16029: Ambari version history - Create DB table, constraints and 
> sequence id.
> 
> ** Issue **
> In order to support tracking of ambari version, a DB table is required.
> 
> ** Fix **
> Create ambari_operation_history table to store from version, to version, 
> install type, start and stop timestamps.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> 319afa579e6f5090588fb90fe619ee7b6bae6d78 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> 9a20b8c05801f61a91a092afd4424173a94d7f17 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> e1da7190d6fb929277c834b29cb537107d857bc3 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> ab1eec42fcba467e0bae19674a7877c79eb77b8e 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> bd869f454ae7ec1c84a9cbd418875f10c023a0c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> fdba489f2d0759e9c1282dfad38036f9bce3673d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
> a1da8e5c8343ae554b4e95717cda085c7f79bc46 
> 
> Diff: https://reviews.apache.org/r/46545/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [5.113s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.038s]
> [INFO] Ambari Web  SUCCESS [26.897s]
> [INFO] Ambari Views .. SUCCESS [1.400s]
> [INFO] Ambari Admin View . SUCCESS [9.242s]
> [INFO] ambari-metrics  SUCCESS [0.346s]
> [INFO] Ambari Metrics Common . SUCCESS [0.528s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.237s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.566s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.600s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.531s]
> [INFO] Ambari Metrics Collector .. SUCCESS [7.183s]
> [INFO] Ambari Metrics Monitor  SUCCESS [1.853s]
> [INFO] Ambari Metrics Grafana  SUCCESS [1.031s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.252s]
> [INFO] Ambari Server . SUCCESS [2:58.522s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.194s]
> [INFO] Ambari Agent .. SUCCESS [25.339s]
> [INFO] Ambari Client . SUCCESS [0.047s]
> [INFO] Ambari Python Client .. SUCCESS [0.947s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.196s]
> [INFO] Ambari Shell .. SUCCESS [0.038s]
> [INFO] Ambari Python Shell ... SUCCESS [0.693s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.907s]
> [INFO] ambari-logsearch .. SUCCESS [0.253s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.069s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [1.570s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.190s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.079s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 5:56.545s
> [INFO] Finished at: Thu Apr 21 16:14:34 PDT 2016
> [INFO] Final Memory: 274M/1094M
> [INFO] 
> 
> 
> 
> ** 2. Manual testing **
> Tested with Ambari-DDL-Postgres-EMBEDDED-CREATE.sql. Copied the SQL script 

Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46944/
---

Review request for Ambari, Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-16230
https://issues.apache.org/jira/browse/AMBARI-16230


Repository: ambari


Description
---

2 different type of errors can occur during adding any new service to Ambari:

org.apache.ambari.server.AmbariException: Unable to create a default alert 
group for unknown service  in cluster

org.apache.ambari.server.ServiceNotFoundException: Service not found, 
clusterName=c1, serviceName=

The reason is that: ServiceInstalledEvent can be handled quicker than 
ServiceImpl.persist() can finish


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 47342f3 

Diff: https://reviews.apache.org/r/46944/diff/


Testing
---

Unit Testing is in progress..
FT: added new services about 10 times, has no any errors thrown.


Thanks,

Oliver Szabo

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/
---

(Updated May 3, 2016, 7:04 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.


Changes
---

This fixes the issue Lav brought up about configuration validation not calling 
the service advisors.


Bugs: AMBARI-15226
https://issues.apache.org/jira/browse/AMBARI-15226


Repository: ambari


Description
---

Currently the stack advisor is defined under each stack version such as 
HDP/2.3. The problem with this is that it restricts the services that can be 
added to the stack. If a custom service is to be added, they would need to 
modify the stack advisor. If the configuration recommendation and validation 
can be done at the service level then the custom service could just include 
their own recommendations and validations separately.


Diffs (updated)
-

  ambari-server/src/main/assemblies/server.xml e1a4919 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 df65010 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 00c8696 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
 ca1968e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
 6c6fa91 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
 636de37 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
 356adb1 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
b7e09a9 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
 d27e52a 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
5a2bf84 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
1680f21 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
f475798 
  ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/stack_advisor.py 9979e7e 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2080c52 

Diff: https://reviews.apache.org/r/44210/diff/


Testing
---

Ran all the non java unit tests.  

Total run:945
Total errors:0
Total failures:0

Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
their service advisors were called.


Thanks,

Tim Thorpe

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46853/
---

(Updated May 3, 2016, 6:12 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16175
https://issues.apache.org/jira/browse/AMBARI-16175


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This  subtask cleans up import * from resource_management and replace it for 
specific imports for:
Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia services


Diffs
-

  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
 09a3d90 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
 33d3273 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/service_check.py
 a7067cb 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
 3c3d804 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
 eb1b6d7 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
 7fb9715 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
 b769a0d 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
 cf0efef 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py
 4d0d7f3 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
 a5abe1c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 32b8fdb 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
 21b491d 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
 3c4bffc 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
 2bdb4c0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 43c1ea6 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
 4b08cbc 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 defd6f0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
 194a3fb 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
 4c54214 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
 64ace1a 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
 a201619 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server_upgrade.py
 6277086 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_windows.py
 b213028 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/service_check.py
 473b7c3 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
 9df2ba6 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_check.py
 25d9a08 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
 1333605 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_windows.py
 66e9852 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/functions.py
 02c44f0 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia.py
 9a69b72 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_monitor.py
 feb0af3 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_monitor_service.py
 58d512c 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_server.py
 8d75d7f 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_server_service.py
 70fdbf6 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/params.py
 30f8ee4 
  

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46853/
---

(Updated May 3, 2016, 6:11 p.m.)


Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Bugs: AMBARI-16175
https://issues.apache.org/jira/browse/AMBARI-16175


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This  subtask cleans up import * from resource_management and replace it for 
specific imports for:
Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia services


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
 09a3d90 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
 33d3273 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/service_check.py
 a7067cb 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
 3c3d804 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
 eb1b6d7 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
 7fb9715 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
 b769a0d 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
 cf0efef 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py
 4d0d7f3 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
 a5abe1c 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 32b8fdb 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
 21b491d 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
 3c4bffc 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
 2bdb4c0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 43c1ea6 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
 4b08cbc 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 defd6f0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
 194a3fb 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
 4c54214 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
 64ace1a 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
 a201619 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server_upgrade.py
 6277086 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_windows.py
 b213028 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/service_check.py
 473b7c3 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
 9df2ba6 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_check.py
 25d9a08 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
 1333605 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_windows.py
 66e9852 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/functions.py
 02c44f0 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia.py
 9a69b72 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_monitor.py
 feb0af3 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_monitor_service.py
 58d512c 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_server.py
 8d75d7f 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_server_service.py
 70fdbf6 
  
ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/params.py
 30f8ee4 
  

Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46738/#review131535
---




contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
 (line 54)


You may need to think about upgrading the ViewInstanceProperties tables. 
This would fail if upgrade is not done in database.


- DIPAYAN BHOWMICK


On April 27, 2016, 2:16 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46738/
> ---
> 
> (Updated April 27, 2016, 2:16 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16138
> https://issues.apache.org/jira/browse/AMBARI-16138
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If view is managed by ambari, then fetching the webhdfsurl, webhdfs auth and 
> hive auth based on the hive and hdfs service config.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
> 05b55d2 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
>  1442748 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParserFactory.java
>  f5e9bcf 
>   contrib/views/hive/src/main/resources/view.xml 8f8a470 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java
>  25db721 
>   contrib/views/pig/src/main/resources/view.xml 9df91f8 
>   contrib/views/tez/readme.md fdb9459 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java
>  440ac65 
>   contrib/views/tez/src/main/resources/view.xml d8105f1 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
>  a8ef43f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
>  c8ca6cd 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  4518ac6 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
>  455ca20 
> 
> Diff: https://reviews.apache.org/r/46738/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested on local Vm.
> Tested Hive, Pig, Hdfs and Tez views with HDFS HA and kerberos.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

> On April 30, 2016, 12:21 a.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 85
> > 
> >
> > Unless HAWQ is using YARN as the scheduler, HAWQ may still be 
> > functional and we may need not restart HAWQ with the move of RM. 
> > So do you think should we restart it only when HAWQ is using 
> > hawq_global_rm_type as yarn ?
> 
> jun aoki wrote:
> I thought it'd be a good idea but data.Cluters won't return enoguh 
> information to decide if HAWQ is on YARN. 
> ```
> data.Clusters.desired_configs["hawq-site"]
> Object {tag: "TOPOLOGY_RESOLVED", user: "admin", version: 2}
> ```
> Let me know if you have a better idea to find it out.
> 
> bhuvnesh chaudhary wrote:
> You can get the configuration as soon you reach onLoadConfigs, and then 
> you can use it which is before the start service ?
> 
> Matt wrote:
> That sounds better to me. Modify the array after receiving the config.
> If HAWQ is using YARN, append value 'HAWQ' to RESOURCEMANAGER's array 
> value.
> 
> jun aoki wrote:
> I'm checking right now to see if it works.

Good stuff Bhuvnesh, it works.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131231
---


On May 3, 2016, 12:59 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated May 3, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46941: Add Zookeeper dependency to LogSearch components for better Blueprint validation

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46941/#review131531
---


Ship it!




Ship It!

- Oliver Szabo


On May 3, 2016, 4:42 p.m., Robert Nettleton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46941/
> ---
> 
> (Updated May 3, 2016, 4:42 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Miklos Gergely, Oliver Szabo, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16227
> https://issues.apache.org/jira/browse/AMBARI-16227
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch resolves AMBARI-16227. 
> 
> This patch implements the following:
> 
> - Updates the LogSearch stack metadata (metainfo.xml), in order to add the 
> dependency on the "ZOOKEEPER_SERVER" component.  All LogSearch components 
> require access to the Zookeeper quorum, so any inclusion of a LogSearch 
> component should also include the ZOOKEEPER_SERVER.  
> - This fix will provide better validation for Blueprint deployments.  Adding 
> this change will cause invalid Blueprints to fail when a user attempts to 
> POST the Blueprint to ambari-server.  This can help with Blueprint creation 
> and debugging, since omission of the Zookeeper quorum will eventually cause a 
> Cluster deployment with LogSearch to fail.  Adding the validation here 
> provides for a simpler debugging experience.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 3f96571 
> 
> Diff: https://reviews.apache.org/r/46941/diff/
> 
> 
> Testing
> ---
> 
> 1. Tested this stack change against a 3-node HDFS, Yarn, and LogSearch 
> Blueprint deployment.  With this patch applied, an attempt to POST a 
> Blueprint with LogSearch, but without the "ZOOKEEPER_SERVER" component 
> included, causes a failure at POST time.  Verified that adding the 
> "ZOOKEEPER_SERVER" to the Blueprint allows the POST to succeed, and that the 
> cluster itself deploys properly as well.
> 2. Ran the ambari-server "mvn clean test" suite, which passed completely with 
> this patch applied.
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

[Juanjo Marron]

> On May 3, 2016, 12:32 a.m., Matt wrote:
> > Ship It!

Waiting for Hadoop QA to have new patch available with installation and service 
checks tests performed
Will upload it soon.
Thanks for the review


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46853/#review131430
---


On April 30, 2016, 12:51 a.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46853/
> ---
> 
> (Updated April 30, 2016, 12:51 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-16175
> https://issues.apache.org/jira/browse/AMBARI-16175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This  subtask cleans up import * from resource_management and replace it for 
> specific imports for:
> Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
>  09a3d90 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
>  33d3273 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/service_check.py
>  a7067cb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
>  3c3d804 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
>  eb1b6d7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
>  7fb9715 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
>  b769a0d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
>  cf0efef 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py
>  4d0d7f3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  a5abe1c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  32b8fdb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
>  21b491d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
>  3c4bffc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  2bdb4c0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  43c1ea6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  4b08cbc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  defd6f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  194a3fb 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  4c54214 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  64ace1a 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  a201619 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server_upgrade.py
>  6277086 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_windows.py
>  b213028 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/service_check.py
>  473b7c3 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
>  9df2ba6 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_check.py
>  25d9a08 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  1333605 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_windows.py
>  66e9852 
>   
> ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/functions.py
>  02c44f0 
>   
> 

Review Request 46941: Add Zookeeper dependency to LogSearch components for better Blueprint validation

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46941/
---

Review request for Ambari, Don Bosco Durai, Miklos Gergely, Oliver Szabo, and 
Sumit Mohanty.


Bugs: AMBARI-16227
https://issues.apache.org/jira/browse/AMBARI-16227


Repository: ambari


Description
---

This patch resolves AMBARI-16227. 

This patch implements the following:

- Updates the LogSearch stack metadata (metainfo.xml), in order to add the 
dependency on the "ZOOKEEPER_SERVER" component.  All LogSearch components 
require access to the Zookeeper quorum, so any inclusion of a LogSearch 
component should also include the ZOOKEEPER_SERVER.  
- This fix will provide better validation for Blueprint deployments.  Adding 
this change will cause invalid Blueprints to fail when a user attempts to POST 
the Blueprint to ambari-server.  This can help with Blueprint creation and 
debugging, since omission of the Zookeeper quorum will eventually cause a 
Cluster deployment with LogSearch to fail.  Adding the validation here provides 
for a simpler debugging experience.


Diffs
-

  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
3f96571 

Diff: https://reviews.apache.org/r/46941/diff/


Testing
---

1. Tested this stack change against a 3-node HDFS, Yarn, and LogSearch 
Blueprint deployment.  With this patch applied, an attempt to POST a Blueprint 
with LogSearch, but without the "ZOOKEEPER_SERVER" component included, causes a 
failure at POST time.  Verified that adding the "ZOOKEEPER_SERVER" to the 
Blueprint allows the POST to succeed, and that the cluster itself deploys 
properly as well.
2. Ran the ambari-server "mvn clean test" suite, which passed completely with 
this patch applied.


Thanks,

Robert Nettleton

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On May 2, 2016, 11:07 p.m., Lav Jain wrote:
> > ambari-server/src/main/resources/stacks/stack_advisor.py, line 644
> > 
> >
> > This method is not being called because the corresponding method in 
> > 2.0.6 stack advisor is overriding it.
> 
> Tim Thorpe wrote:
> Hi Lav, I don't see the 2.0.6 stack advisor overriding this method (def 
> validateComponentLayout).  It does override the method 
> getComponentLayoutValidations which gets called by validateComponentLayout 
> but in that method it calls super getComponentLayoutValidations first:
>   def getComponentLayoutValidations(self, services, hosts):
> """Returns array of Validation objects about issues with hostnames 
> components assigned to"""
> items = super(HDP206StackAdvisor, 
> self).getComponentLayoutValidations(services, hosts)
> 
> Lav Jain wrote:
> Hi Tim,
> 
> The method being overridden is getConfigurationsValidationItems():
> 
> 
> https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py#L929-L956

Thanks, just confirmed it.  I'll make sure the 2.0.6 stack advisor calls the 
super method.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review131409
---


On May 3, 2016, 2:21 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated May 3, 2016, 2:21 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  356adb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 5a2bf84 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 1680f21 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> f475798 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 9979e7e 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 2080c52 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Lav Jain]

> On May 2, 2016, 11:07 p.m., Lav Jain wrote:
> > ambari-server/src/main/resources/stacks/stack_advisor.py, line 644
> > 
> >
> > This method is not being called because the corresponding method in 
> > 2.0.6 stack advisor is overriding it.
> 
> Tim Thorpe wrote:
> Hi Lav, I don't see the 2.0.6 stack advisor overriding this method (def 
> validateComponentLayout).  It does override the method 
> getComponentLayoutValidations which gets called by validateComponentLayout 
> but in that method it calls super getComponentLayoutValidations first:
>   def getComponentLayoutValidations(self, services, hosts):
> """Returns array of Validation objects about issues with hostnames 
> components assigned to"""
> items = super(HDP206StackAdvisor, 
> self).getComponentLayoutValidations(services, hosts)

Hi Tim,

The method being overridden is getConfigurationsValidationItems():

https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py#L929-L956


- Lav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review131409
---


On May 3, 2016, 2:21 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated May 3, 2016, 2:21 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  356adb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 5a2bf84 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 1680f21 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> f475798 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 9979e7e 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 2080c52 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46545/
---

(Updated May 3, 2016, 9:33 a.m.)


Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, 
Jayush Luniya, and Sumit Mohanty.


Changes
---

Revert to using BIGINT for timestamp.


Bugs: AMBARI-16029
https://issues.apache.org/jira/browse/AMBARI-16029


Repository: ambari


Description
---

AMBARI-16029: Ambari version history - Create DB table, constraints and 
sequence id.

** Issue **
In order to support tracking of ambari version, a DB table is required.

** Fix **
Create ambari_operation_history table to store from version, to version, 
install type, start and stop timestamps.


Diffs (updated)
-

  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
319afa579e6f5090588fb90fe619ee7b6bae6d78 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
9a20b8c05801f61a91a092afd4424173a94d7f17 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
e1da7190d6fb929277c834b29cb537107d857bc3 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
ab1eec42fcba467e0bae19674a7877c79eb77b8e 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
bd869f454ae7ec1c84a9cbd418875f10c023a0c2 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
fdba489f2d0759e9c1282dfad38036f9bce3673d 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
a1da8e5c8343ae554b4e95717cda085c7f79bc46 

Diff: https://reviews.apache.org/r/46545/diff/


Testing
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [5.113s]
[INFO] Apache Ambari Project POM . SUCCESS [0.038s]
[INFO] Ambari Web  SUCCESS [26.897s]
[INFO] Ambari Views .. SUCCESS [1.400s]
[INFO] Ambari Admin View . SUCCESS [9.242s]
[INFO] ambari-metrics  SUCCESS [0.346s]
[INFO] Ambari Metrics Common . SUCCESS [0.528s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.237s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.566s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.600s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.531s]
[INFO] Ambari Metrics Collector .. SUCCESS [7.183s]
[INFO] Ambari Metrics Monitor  SUCCESS [1.853s]
[INFO] Ambari Metrics Grafana  SUCCESS [1.031s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:18.252s]
[INFO] Ambari Server . SUCCESS [2:58.522s]
[INFO] Ambari Functional Tests ... SUCCESS [2.194s]
[INFO] Ambari Agent .. SUCCESS [25.339s]
[INFO] Ambari Client . SUCCESS [0.047s]
[INFO] Ambari Python Client .. SUCCESS [0.947s]
[INFO] Ambari Groovy Client .. SUCCESS [2.196s]
[INFO] Ambari Shell .. SUCCESS [0.038s]
[INFO] Ambari Python Shell ... SUCCESS [0.693s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.907s]
[INFO] ambari-logsearch .. SUCCESS [0.253s]
[INFO] Ambari Logsearch Portal ... SUCCESS [7.069s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [1.570s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.190s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.079s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 5:56.545s
[INFO] Finished at: Thu Apr 21 16:14:34 PDT 2016
[INFO] Final Memory: 274M/1094M
[INFO] 


** 2. Manual testing **
Tested with Ambari-DDL-Postgres-EMBEDDED-CREATE.sql. Copied the SQL script to a 
VM and ran ambari-server reset. Verified the schema:

ambari=> \d+ ambari_version_history
 Table "ambari.ambari_version_history"
 Column  |  Type  | Modifiers | Storage  | Description
-++---+--+-
 id  | bigint | not null  | plain|
 from_version| character varying(255) | not null  | extended |
 to_version  | character 

Re: Review Request 46925: Write out new log property files under /etc/hive2/conf

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46925/#review131513
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 (line 149)


Nit: The existing formatting has the closing parenthesis on a new line 
aligned at the first column :-)


- Nahappan Somasundaram


On May 3, 2016, 7:29 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46925/
> ---
> 
> (Updated May 3, 2016, 7:29 a.m.)
> 
> 
> Review request for Ambari, Nahappan Somasundaram and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16209
> https://issues.apache.org/jira/browse/AMBARI-16209
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Write out new log property files under /etc/hive2/conf
> llap-daemon-log4j2.properties (from llap-daemon-log4j2.properties.template)
> llap-cli-log4j2.properties (from llap-cli-log4j2.properties.template)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  24047ff 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  2e1a2af 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
>  1c60285 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 5712995 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json e7bb056 
> 
> Diff: https://reviews.apache.org/r/46925/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46545/#review131508
---




ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql (lines 844 - 845)


We store timestamps as epoch longs. This is for several reasons:

- JPA plays nicer with them
- We can easily translate these into rendered dates based on user timezone



ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql (line 838)


27 characters - what's Oracle's limit? Is it 25?


- Jonathan Hurley


On May 2, 2016, 6:33 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46545/
> ---
> 
> (Updated May 2, 2016, 6:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, 
> Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16029
> https://issues.apache.org/jira/browse/AMBARI-16029
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-16029: Ambari version history - Create DB table, constraints and 
> sequence id.
> 
> ** Issue **
> In order to support tracking of ambari version, a DB table is required.
> 
> ** Fix **
> Create ambari_operation_history table to store from version, to version, 
> install type, start and stop timestamps.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> 319afa579e6f5090588fb90fe619ee7b6bae6d78 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> 9a20b8c05801f61a91a092afd4424173a94d7f17 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> e1da7190d6fb929277c834b29cb537107d857bc3 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> ab1eec42fcba467e0bae19674a7877c79eb77b8e 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> bd869f454ae7ec1c84a9cbd418875f10c023a0c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> fdba489f2d0759e9c1282dfad38036f9bce3673d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
> a1da8e5c8343ae554b4e95717cda085c7f79bc46 
> 
> Diff: https://reviews.apache.org/r/46545/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [5.113s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.038s]
> [INFO] Ambari Web  SUCCESS [26.897s]
> [INFO] Ambari Views .. SUCCESS [1.400s]
> [INFO] Ambari Admin View . SUCCESS [9.242s]
> [INFO] ambari-metrics  SUCCESS [0.346s]
> [INFO] Ambari Metrics Common . SUCCESS [0.528s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.237s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.566s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.600s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.531s]
> [INFO] Ambari Metrics Collector .. SUCCESS [7.183s]
> [INFO] Ambari Metrics Monitor  SUCCESS [1.853s]
> [INFO] Ambari Metrics Grafana  SUCCESS [1.031s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.252s]
> [INFO] Ambari Server . SUCCESS [2:58.522s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.194s]
> [INFO] Ambari Agent .. SUCCESS [25.339s]
> [INFO] Ambari Client . SUCCESS [0.047s]
> [INFO] Ambari Python Client .. SUCCESS [0.947s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.196s]
> [INFO] Ambari Shell .. SUCCESS [0.038s]
> [INFO] Ambari Python Shell ... SUCCESS [0.693s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.907s]
> [INFO] ambari-logsearch .. SUCCESS [0.253s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.069s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [1.570s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.190s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.079s]
> [INFO] 
> 

Re: Review Request 46925: Write out new log property files under /etc/hive2/conf

[Sumit Mohanty]

> On May 3, 2016, 7:32 a.m., Swapan Shridhar wrote:
> > ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json, line 52
> > 
> >
> > is \n intentional ?

Yes to simulate new lines in content properties in config.


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46925/#review131466
---


On May 3, 2016, 4:27 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46925/
> ---
> 
> (Updated May 3, 2016, 4:27 a.m.)
> 
> 
> Review request for Ambari, Nahappan Somasundaram and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16209
> https://issues.apache.org/jira/browse/AMBARI-16209
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Write out new log property files under /etc/hive2/conf
> llap-daemon-log4j2.properties (from llap-daemon-log4j2.properties.template)
> llap-cli-log4j2.properties (from llap-cli-log4j2.properties.template)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  24047ff 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  2e1a2af 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
>  1c60285 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 5712995 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json e7bb056 
> 
> Diff: https://reviews.apache.org/r/46925/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 46925: Write out new log property files under /etc/hive2/conf

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46925/
---

(Updated May 3, 2016, 2:29 p.m.)


Review request for Ambari, Nahappan Somasundaram and Swapan Shridhar.


Changes
---

Changes based on the comments.


Bugs: AMBARI-16209
https://issues.apache.org/jira/browse/AMBARI-16209


Repository: ambari


Description
---

Write out new log property files under /etc/hive2/conf
llap-daemon-log4j2.properties (from llap-daemon-log4j2.properties.template)
llap-cli-log4j2.properties (from llap-cli-log4j2.properties.template)


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 24047ff 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 2e1a2af 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
 1c60285 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 5712995 
  ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json e7bb056 

Diff: https://reviews.apache.org/r/46925/diff/


Testing
---

Ran unit tests.


Thanks,

Sumit Mohanty

Re: Review Request 46925: Write out new log property files under /etc/hive2/conf

[Sumit Mohanty]

> On May 3, 2016, 2 p.m., Nahappan Somasundaram wrote:
> > ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py, line 
> > 270
> > 
> >
> > Is the newline intentional?

Yes to simulate new lines in content properties in config.


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46925/#review131499
---


On May 3, 2016, 4:27 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46925/
> ---
> 
> (Updated May 3, 2016, 4:27 a.m.)
> 
> 
> Review request for Ambari, Nahappan Somasundaram and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16209
> https://issues.apache.org/jira/browse/AMBARI-16209
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Write out new log property files under /etc/hive2/conf
> llap-daemon-log4j2.properties (from llap-daemon-log4j2.properties.template)
> llap-cli-log4j2.properties (from llap-cli-log4j2.properties.template)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  24047ff 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  2e1a2af 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
>  1c60285 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 5712995 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json e7bb056 
> 
> Diff: https://reviews.apache.org/r/46925/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/
---

(Updated May 3, 2016, 2:21 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.


Changes
---

This patch fixes the common-services naming convention so that it uses service 
name and version.  I attempted to install HAWQ on a 3 node cluster.  It 
recommended the standby on node 2 and the master on node 3.  So looks like its 
working properly.  Also I checked the services.json in 
/var/run/ambari-server/stack-recommendations/1 and it returns 
HAWQ200ServiceAdvisor.

cat services.json | grep -A 2 -B 2 advisor_name
  "stack_name" : "HDP",
  "stack_version" : "2.3",
  "advisor_name" : "HAWQ200ServiceAdvisor",
  "advisor_path" : 
"/var/lib/ambari-server/resources/common-services/HAWQ/2.0.0/service_advisor.py"
},


Bugs: AMBARI-15226
https://issues.apache.org/jira/browse/AMBARI-15226


Repository: ambari


Description
---

Currently the stack advisor is defined under each stack version such as 
HDP/2.3. The problem with this is that it restricts the services that can be 
added to the stack. If a custom service is to be added, they would need to 
modify the stack advisor. If the configuration recommendation and validation 
can be done at the service level then the custom service could just include 
their own recommendations and validations separately.


Diffs (updated)
-

  ambari-server/src/main/assemblies/server.xml e1a4919 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 df65010 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
 00c8696 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
 ca1968e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
 6c6fa91 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
 636de37 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
 356adb1 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
b7e09a9 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
 d27e52a 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
5a2bf84 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
1680f21 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
f475798 
  ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/stack_advisor.py 9979e7e 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2080c52 

Diff: https://reviews.apache.org/r/44210/diff/


Testing
---

Ran all the non java unit tests.  

Total run:945
Total errors:0
Total failures:0

Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
their service advisors were called.


Thanks,

Tim Thorpe

Re: Review Request 46925: Write out new log property files under /etc/hive2/conf

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46925/#review131499
---




ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py (line 180)


Looks like the parenthesis got auto-formated.



ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py (line 268)


Formatting of parenthesis not consistent with existing code.



ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py (line 270)


Is the newline intentional?


- Nahappan Somasundaram


On May 2, 2016, 9:27 p.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46925/
> ---
> 
> (Updated May 2, 2016, 9:27 p.m.)
> 
> 
> Review request for Ambari, Nahappan Somasundaram and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16209
> https://issues.apache.org/jira/browse/AMBARI-16209
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Write out new log property files under /etc/hive2/conf
> llap-daemon-log4j2.properties (from llap-daemon-log4j2.properties.template)
> llap-cli-log4j2.properties (from llap-cli-log4j2.properties.template)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  24047ff 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  2e1a2af 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
>  1c60285 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 5712995 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json e7bb056 
> 
> Diff: https://reviews.apache.org/r/46925/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On May 2, 2016, 11:07 p.m., Lav Jain wrote:
> > ambari-server/src/main/resources/stacks/stack_advisor.py, line 644
> > 
> >
> > This method is not being called because the corresponding method in 
> > 2.0.6 stack advisor is overriding it.

Hi Lav, I don't see the 2.0.6 stack advisor overriding this method (def 
validateComponentLayout).  It does override the method 
getComponentLayoutValidations which gets called by validateComponentLayout but 
in that method it calls super getComponentLayoutValidations first:
  def getComponentLayoutValidations(self, services, hosts):
"""Returns array of Validation objects about issues with hostnames 
components assigned to"""
items = super(HDP206StackAdvisor, 
self).getComponentLayoutValidations(services, hosts)


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review131409
---


On April 29, 2016, 8:11 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 29, 2016, 8:11 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  356adb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 5a2bf84 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 1680f21 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> f475798 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 9979e7e 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 2080c52 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46899: Disable alternate user search functionality by default

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46899/#review131493
---


Ship it!




Ship It!

- Laszlo Puskas


On May 2, 2016, 8:01 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46899/
> ---
> 
> (Updated May 2, 2016, 8:01 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Laszlo Puskas, 
> Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-16205
> https://issues.apache.org/jira/browse/AMBARI-16205
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added `authentication.ldap.alternateUserSearchEnabled` configuration property 
> through which it can be controlled if the ldap alternate user search is 
> enabled or not. The default value for this property is `false.`
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  87f40d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  7b2a95c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  99ec786 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
>  f5d1412 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
>  b076e85 
> 
> Diff: https://reviews.apache.org/r/46899/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing.
> 
> Unit test results:
> Results :
> 
> Tests run: 4305, Failures: 0, Errors: 0, Skipped: 32
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 46899: Disable alternate user search functionality by default

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46899/#review131487
---


Ship it!




Ship It!

- Sandor Magyari


On May 2, 2016, 8:01 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46899/
> ---
> 
> (Updated May 2, 2016, 8:01 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Laszlo Puskas, 
> Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-16205
> https://issues.apache.org/jira/browse/AMBARI-16205
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added `authentication.ldap.alternateUserSearchEnabled` configuration property 
> through which it can be controlled if the ldap alternate user search is 
> enabled or not. The default value for this property is `false.`
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  87f40d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  7b2a95c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  99ec786 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
>  f5d1412 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
>  b076e85 
> 
> Diff: https://reviews.apache.org/r/46899/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing.
> 
> Unit test results:
> Results :
> 
> Tests run: 4305, Failures: 0, Errors: 0, Skipped: 32
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 46899: Disable alternate user search functionality by default

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46899/#review131486
---


Ship it!




Ship It!

- Balázs Bence Sári


On May 2, 2016, 8:01 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46899/
> ---
> 
> (Updated May 2, 2016, 8:01 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Laszlo Puskas, 
> Robert Levas, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-16205
> https://issues.apache.org/jira/browse/AMBARI-16205
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added `authentication.ldap.alternateUserSearchEnabled` configuration property 
> through which it can be controlled if the ldap alternate user search is 
> enabled or not. The default value for this property is `false.`
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  87f40d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
>  7b2a95c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  99ec786 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
>  f5d1412 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
>  b076e85 
> 
> Diff: https://reviews.apache.org/r/46899/diff/
> 
> 
> Testing
> ---
> 
> Performed manual testing.
> 
> Unit test results:
> Results :
> 
> Tests run: 4305, Failures: 0, Errors: 0, Skipped: 32
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Review Request 46931: Updated grok lib version(0.1.1 to 0.1.4) to get latest fixes.

[Hayat Behlim]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46931/
---

Review request for Ambari.


Bugs: AMBARI-16211
https://issues.apache.org/jira/browse/AMBARI-16211


Repository: ambari


Description
---

Patch contains : 
Some log messages were not getting parsed due to grok lib issue with v.0.1.1, 
need to update grok to latest version.


Diffs
-

  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 12255fe 

Diff: https://reviews.apache.org/r/46931/diff/


Testing
---


Thanks,

Hayat Behlim

Re: Review Request 46925: Write out new log property files under /etc/hive2/conf

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46925/#review131466
---




ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json (line 52)


is \n intentional ?


- Swapan Shridhar


On May 3, 2016, 4:27 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46925/
> ---
> 
> (Updated May 3, 2016, 4:27 a.m.)
> 
> 
> Review request for Ambari, Nahappan Somasundaram and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16209
> https://issues.apache.org/jira/browse/AMBARI-16209
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Write out new log property files under /etc/hive2/conf
> llap-daemon-log4j2.properties (from llap-daemon-log4j2.properties.template)
> llap-cli-log4j2.properties (from llap-cli-log4j2.properties.template)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  24047ff 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  2e1a2af 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml
>  1c60285 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 5712995 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json e7bb056 
> 
> Diff: https://reviews.apache.org/r/46925/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>