date:20160711



> On July 12, 2016, 12:10 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py,
> >  line 39
> > 
> >
> > Lets add the logic to read from hive-interactive-site as well

Done.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49934/#review141807
---


On July 12, 2016, 3:14 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49934/
> ---
> 
> (Updated July 12, 2016, 3:14 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17665
> https://issues.apache.org/jira/browse/AMBARI-17665
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Current value : HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY = 
> '{{hive.server2.transport.mode/hive.server2.authentication}}'
>   **Fixed to :** HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY = 
> '{{hive-site/hive.server2.authentication}}'
>   
> 
> - Added the required extra '-' for 'findAppTimeout' param in llapstatus 
> command.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
>  e390fcd 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  c32aba2 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  875852f 
> 
> Diff: https://reviews.apache.org/r/49934/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 49934: AMBARI-17665. Fix the typo in 'alert_hive_interactive_thrift_port.py' for 'HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY'. Also, adding the required extra '-' for 'findAppTimeo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49934/
---

(Updated July 12, 2016, 3:14 a.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Added suggestions made by Sumit.


Bugs: AMBARI-17665
https://issues.apache.org/jira/browse/AMBARI-17665


Repository: ambari


Description
---

- Current value : HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY = 
'{{hive.server2.transport.mode/hive.server2.authentication}}'
  **Fixed to :** HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY = 
'{{hive-site/hive.server2.authentication}}'
  

- Added the required extra '-' for 'findAppTimeout' param in llapstatus command.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
 e390fcd 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
 c32aba2 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 875852f 

Diff: https://reviews.apache.org/r/49934/diff/


Testing
---

- Python UT passes.


Thanks,

Swapan Shridhar

Re: Review Request 49786: AMBARI-17615 : AMS metrics GET API does not work for same metric with multiple aggregation functions

2016-07-11 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49786/#review141829
---


Ship it!




Ship It!

- Sid Wagle


On July 11, 2016, 8:14 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49786/
> ---
> 
> (Updated July 11, 2016, 8:14 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17615
> https://issues.apache.org/jira/browse/AMBARI-17615
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMS API which used to work in previous versions is now broken in 2.4.0 version
> 
> GET 
> 
> http://:6188/ws/v1/timeline/metrics?metricNames=bytes_in._min,bytes_in._max,bytes_in._sum,bytes_in._avg=HOST=hours=146692800=146743920=
> 
> failed. Status:400
> {
> "exception": "BadRequestException",
> "message": "java.lang.Exception: Multiple aggregate functions not supported.",
> "javaClassName": "org.apache.hadoop.yarn.webapp.BadRequestException"
> }
> 
> This impacts SmartSense capture
> 
> FIX
> 
> Changed data structure that stores the MetricName -> Aggregation Function 
> from HashMap to Multimap, so that we can have 1 metric name mapping to 
> separate lists of functions.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  9510574 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  bbd6d83 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java
>  29e2664 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  ae1aa5a 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java
>  a86fa11 
> 
> Diff: https://reviews.apache.org/r/49786/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> Apache
> 
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12816764/AMBARI-17615.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 3 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in 
> ambari-metrics/ambari-metrics-timelineservice.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7732//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7732//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 49935: AMBARI-17633 yarn.nodemanager.remote-app-log-dir should be added stickybit.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49935/
---

Review request for Ambari, Andrew Onischuk, jun aoki, and Myroslav Papirkovskyy.


Bugs: AMBARI-17633
https://issues.apache.org/jira/browse/AMBARI-17633


Repository: ambari


Description
---

When installing YARN+MapReduce2, I got a WARN message in nodemanager log(in Log 
Search View) like below
```
2016-07-09 06:30:21,865 WARN logaggregation.LogAggregationService 
LogAggregationService.java:230 - Remote Root Log Dir [/app-logs] already exist, 
but with incorrect permissions. Expected: [rwxrwxrwt], Found: [rwxrwxrwx]. The 
cluster may have problems with multiple users. 
```
I think the cause of this WARN is 
[this](https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py#L115).
We should add stickybit to yarn.nodemanager.remote-app-log-dir.


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 ce312e0 

Diff: https://reviews.apache.org/r/49935/diff/


Testing
---

mvn clean test && manual test

I think Hadoop QA result is unrelated to this patch


Thanks,

Masahiro Tanaka

Re: Review Request 49934: AMBARI-17665. Fix the typo in 'alert_hive_interactive_thrift_port.py' for 'HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY'. Also, adding the required extra '-' for 'findAppTimeo

2016-07-11 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49934/#review141807
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
 (line 39)


Lets add the logic to read from hive-interactive-site as well


- Sumit Mohanty


On July 11, 2016, 11:50 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49934/
> ---
> 
> (Updated July 11, 2016, 11:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17665
> https://issues.apache.org/jira/browse/AMBARI-17665
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Current value : HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY = 
> '{{hive.server2.transport.mode/hive.server2.authentication}}'
>   **Fixed to :** HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY = 
> '{{hive-site/hive.server2.authentication}}'
>   
> 
> - Added the required extra '-' for 'findAppTimeout' param in llapstatus 
> command.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
>  e390fcd 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  c32aba2 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  875852f 
> 
> Diff: https://reviews.apache.org/r/49934/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 49930: AMBARI-17614 Clean up import * for AMBARI_METRICS services

2016-07-11 Thread Juanjo Marron


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49930/#review141805
---


Ship it!




Ship It!

- Juanjo  Marron


On July 11, 2016, 10:59 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49930/
> ---
> 
> (Updated July 11, 2016, 10:59 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jayush Luniya, and Juanjo  
> Marron.
> 
> 
> Bugs: AMBARI-17614
> https://issues.apache.org/jira/browse/AMBARI-17614
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py
>  and 
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
> uses `from resource_management import *`. It increases code tracking 
> difficulty.
> I think this is related to AMBARI-16101
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
>  7dc66b2 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py
>  fa4e8a4 
> 
> Diff: https://reviews.apache.org/r/49930/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 49931: AMBARI-17663 - Hosts page: JS error when sorting

2016-07-11 Thread Zhe (Joe) Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49931/#review141803
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On July 11, 2016, 11:42 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49931/
> ---
> 
> (Updated July 11, 2016, 11:42 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang and Xi Wang.
> 
> 
> Bugs: AMBARI-17663
> https://issues.apache.org/jira/browse/AMBARI-17663
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix undefined reference.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/sort_view.js bbb6004 
> 
> Diff: https://reviews.apache.org/r/49931/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   29018 tests complete (27 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 49934: AMBARI-17665. Fix the typo in 'alert_hive_interactive_thrift_port.py' for 'HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY'. Also, adding the required extra '-' for 'findAppTimeo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49934/
---

(Updated July 11, 2016, 11:50 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17665
https://issues.apache.org/jira/browse/AMBARI-17665


Repository: ambari


Description (updated)
---

- Current value : HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY = 
'{{hive.server2.transport.mode/hive.server2.authentication}}'
  **Fixed to :** HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY = 
'{{hive-site/hive.server2.authentication}}'
  

- Added the required extra '-' for 'findAppTimeout' param in llapstatus command.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
 e390fcd 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
 c32aba2 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 875852f 

Diff: https://reviews.apache.org/r/49934/diff/


Testing (updated)
---

- Python UT passes.


Thanks,

Swapan Shridhar

Review Request 49934: AMBARI-17665. Fix the typo in 'alert_hive_interactive_thrift_port.py' for 'HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY'. Also, adding the required extra '-' for 'findAppTimeout'


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49934/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17665
https://issues.apache.org/jira/browse/AMBARI-17665


Repository: ambari


Description
---

- Current value : HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY = 
'{{hive.server2.transport.mode/hive.server2.authentication}}'
  **Fixed to :** HIVE_SERVER2_INTERACTIVE_AUTHENTICATION_KEY = 
'{{hive-site/hive.server2.authentication}}'
  

- Added the required extra '-' for 'findAppTimeout' param in llapstatus comamnd.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
 e390fcd 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
 c32aba2 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 875852f 

Diff: https://reviews.apache.org/r/49934/diff/


Testing
---


Thanks,

Swapan Shridhar

Review Request 49931: AMBARI-17663 - Hosts page: JS error when sorting

2016-07-11 Thread Richard Zang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49931/
---

Review request for Ambari, Zhe (Joe) Wang and Xi Wang.


Bugs: AMBARI-17663
https://issues.apache.org/jira/browse/AMBARI-17663


Repository: ambari


Description
---

Fix undefined reference.


Diffs
-

  ambari-web/app/views/common/sort_view.js bbb6004 

Diff: https://reviews.apache.org/r/49931/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  29018 tests complete (27 seconds)
  154 tests pending


Thanks,

Richard Zang

Review Request 49930: AMBARI-17614 Clean up import * for AMBARI_METRICS services


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49930/
---

Review request for Ambari, Aravindan Vijayan, Jayush Luniya, and Juanjo  Marron.


Bugs: AMBARI-17614
https://issues.apache.org/jira/browse/AMBARI-17614


Repository: ambari


Description
---

ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py
 and 
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
uses `from resource_management import *`. It increases code tracking difficulty.
I think this is related to AMBARI-16101


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
 7dc66b2 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py
 fa4e8a4 

Diff: https://reviews.apache.org/r/49930/diff/


Testing
---

mvn clean test


Thanks,

Masahiro Tanaka

Re: Review Request 44464: AMBARI-15321. Adding support for Hive Server Interactive Alerts.

2016-07-11 Thread Vaibhav Gumashta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44464/#review141795
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
 (line 39)


There is a typo in this line.


- Vaibhav Gumashta


On March 7, 2016, 7:57 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44464/
> ---
> 
> (Updated March 7, 2016, 7:57 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15321
> https://issues.apache.org/jira/browse/AMBARI-15321
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * HiveServerInteractive. Adding support for Hive Server Interactive Alerts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 
> cf99435 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44464/diff/
> 
> 
> Testing
> ---
> 
> * Not done. Will be done when code for "Hive Server Interactive" is checked 
> in. 
> * UT test Task opened for tracking. 
> https://hortonworks.jira.com/browse/BUG-53941
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/#review141786
---



Should I UpgradeCatalog250.java as we are readying to release Ambari2.4.0?

- Masahiro Tanaka


On July 11, 2016, 9:50 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48972/
> ---
> 
> (Updated July 11, 2016, 9:50 p.m.)
> 
> 
> Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17253
> https://issues.apache.org/jira/browse/AMBARI-17253
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are too many WARNING in ZooKeeper log.
> ```
> 2016-06-15 21:02:15,405 - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of 
> stream exception
> EndOfStreamException: Unable to read additional data from client sessionid 
> 0x0, likely client has closed socket
> at 
> org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228)
> at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208)
> at java.lang.Thread.run(Thread.java:745)
> ```
> 
> It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port 
> to do monitoring.
> We should use 'ruok' to monitor zookeepers.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 
>   ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java
>  d7279de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  7ef12a7 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json 
> 469036a 
> 
> Diff: https://reviews.apache.org/r/48972/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/
---

(Updated July 11, 2016, 9:50 p.m.)


Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole.


Changes
---

Update a patch


Bugs: AMBARI-17253
https://issues.apache.org/jira/browse/AMBARI-17253


Repository: ambari


Description
---

There are too many WARNING in ZooKeeper log.
```
2016-06-15 21:02:15,405 - WARN  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of 
stream exception
EndOfStreamException: Unable to read additional data from client sessionid 0x0, 
likely client has closed socket
at 
org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228)
at 
org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208)
at java.lang.Thread.run(Thread.java:745)
```

It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port to 
do monitoring.
We should use 'ruok' to monitor zookeepers.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 
  ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java
 d7279de 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 7ef12a7 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json 
469036a 

Diff: https://reviews.apache.org/r/48972/diff/


Testing
---

mvn clean test

```
+1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
This message is automatically generated.
```


Thanks,

Masahiro Tanaka

Re: Review Request 49927: Atlas HA fails to come up with error finding ids


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49927/
---

(Updated July 11, 2016, 9:42 p.m.)


Review request for Ambari, Madhan Neethiraj, Nahappan Somasundaram, Sumit 
Mohanty, and Suma Shivaprasad.


Bugs: AMBARI-17662
https://issues.apache.org/jira/browse/AMBARI-17662


Repository: ambari


Description
---

Deploy multiple Atlas servers and one of them will fail since it will be 
missing its ids.

To fix this,

atlas.server.ha.enabled will not be shown on the UI and instead derived. But if 
for whatever reason we need to do some debugging/troubleshooting on Atlas, we 
may allow the user to override the property.

* single Atlas Server => write config with atlas.server.ha.enabled=false (if 
atlas.server.ha.enabled is set to true, still write it out as false)
* multiple Atlas Servers => write config with atlas.server.ha.enabled=true 
(only if atlas.server.ha.enabled is not a property, otherwise, take its value)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 c3af4eb 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 36fb1ea 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
 0b0d2ae 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
 0fe0827 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 b595868 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 58cce06 

Diff: https://reviews.apache.org/r/49927/diff/


Testing
---

Verified following use cases

1 Atlas Server: set atlas.server.ha.enabled=false
1 Atlas Server with atlas.server.ha.enabled=true, changed 
atlas.server.ha.enabled=false since doesn't make sense with a single server
2 Atlas Servers: set atlas.server.ha.enabled=true
2 Atlas Servers with atlas.server.ha.enabled=true, kept 
atlas.server.ha.enabled=true
2 Atlas Servers with atlas.server.ha.enabled=false, kept 
atlas.server.ha.enabled=false

mvn clean test
--
Total run:1018
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 49927: Atlas HA fails to come up with error finding ids


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49927/#review141783
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 


These properties will be calculated on the python side instead, no need to 
have them show up on the UI.



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 (line 35)


This is the important logic



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 (line 64)


What if the user already has the property atlas.server.ha.enabled, then 
only allow setting it to true if they don't change it to false and they have 
multiple Atlas servers.



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 


Already defined in status_params.py



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 


This was dead code, it did nothing



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
 (line 32)


Will remove this.


- Alejandro Fernandez


On July 11, 2016, 9:38 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49927/
> ---
> 
> (Updated July 11, 2016, 9:38 p.m.)
> 
> 
> Review request for Ambari, Madhan Neethiraj, Nahappan Somasundaram, Sumit 
> Mohanty, and Suma Shivaprasad.
> 
> 
> Bugs: AMBARI-17662
> https://issues.apache.org/jira/browse/AMBARI-17662
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deploy multiple Atlas servers and one of them will fail since it will be 
> missing its ids.
> 
> To fix this,
> 
> atlas.server.ha.enabled will not be shown on the UI and instead derived. But 
> if for whatever reason we need to do some debugging/troubleshooting on Atlas, 
> we may allow the user to override the property.
> 
> * single Atlas Server => write config with atlas.server.ha.enabled=false (if 
> atlas.server.ha.enabled is set to true, still write it out as false)
> * multiple Atlas Servers => write config with atlas.server.ha.enabled=true 
> (only if atlas.server.ha.enabled is not a property, otherwise, take its value)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  c3af4eb 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  36fb1ea 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  0b0d2ae 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  0fe0827 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  b595868 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 58cce06 
> 
> Diff: https://reviews.apache.org/r/49927/diff/
> 
> 
> Testing
> ---
> 
> Verified following use cases
> 
> 1 Atlas Server: set atlas.server.ha.enabled=false
> 1 Atlas Server with atlas.server.ha.enabled=true, changed 
> atlas.server.ha.enabled=false since doesn't make sense with a single server
> 2 Atlas Servers: set atlas.server.ha.enabled=true
> 2 Atlas Servers with atlas.server.ha.enabled=true, kept 
> atlas.server.ha.enabled=true
> 2 Atlas Servers with atlas.server.ha.enabled=false, kept 
> atlas.server.ha.enabled=false
> 
> mvn clean test
> --
> Total run:1018
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 49927: Atlas HA fails to come up with error finding ids


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49927/
---

Review request for Ambari, Madhan Neethiraj, Nahappan Somasundaram, Sumit 
Mohanty, and Suma Shivaprasad.


Bugs: AMBARI-17662
https://issues.apache.org/jira/browse/AMBARI-17662


Repository: ambari


Description
---

Deploy multiple Atlas servers and one of them will fail since it will be 
missing its ids.

To fix this,

atlas.server.ha.enabled will not be shown on the UI and instead derived. But if 
for whatever reason we need to do some debugging/troubleshooting on Atlas, we 
may allow the user to override the property.

* single Atlas Server => write config with atlas.server.ha.enabled=false (if 
atlas.server.ha.enabled is set to true, still write it out as false)
* multiple Atlas Servers => write config with atlas.server.ha.enabled=true 
(only if atlas.server.ha.enabled is not a property, otherwise, take its value)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 c3af4eb 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 36fb1ea 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
 0b0d2ae 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
 0fe0827 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 b595868 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 58cce06 

Diff: https://reviews.apache.org/r/49927/diff/


Testing
---

Verified following use cases

1 Atlas Server: set atlas.server.ha.enabled=false
1 Atlas Server with atlas.server.ha.enabled=true, changed 
atlas.server.ha.enabled=false since doesn't make sense with a single server
2 Atlas Servers: set atlas.server.ha.enabled=true
2 Atlas Servers with atlas.server.ha.enabled=true, kept 
atlas.server.ha.enabled=true
2 Atlas Servers with atlas.server.ha.enabled=false, kept 
atlas.server.ha.enabled=false

mvn clean test
--
Total run:1018
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 49915: EU Downgrade Does Not Stop Services


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49915/#review141766
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 11, 2016, 7:17 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49915/
> ---
> 
> (Updated July 11, 2016, 7:17 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-17660
> https://issues.apache.org/jira/browse/AMBARI-17660
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When downgrading an express upgrade, the orchestration of the downgrade does 
> not perform the same steps as the upgrade did. Namely, the stopping of high- 
> and low-level services is not present. This leads to a scenario like this:
> 
> - Upgrade HDP 2.x to 2.y
> -- Stop Storm
> -- Stop ZK
> -- Update Stack to 2.y
> -- Restart ZK on 2.y
> -- Restart Storm on 2.y
> 
> - Downgrade  HDP 2.y to 2.x
> -- Update Stack to 2.x
> -- Restart ZK on 2.x
> -- Restart Storm on 2.x
> 
> Notice that we didn't stop the running services. This leads to a problem 
> where actions which must take place while services are down can't complete 
> successfully.
> 
> The case in point is Storm. Between HDP 2.4 and HDP 2.5, Storm changed the 
> name of a serialized class. Part of the Storm upgrade/downgrade is to always 
> delete local storm data. However, during an EU, if Nimbus and Supervisor are 
> co-located on the same host, Supervisor will write out 2.5 data since it 
> wasn't shut down. Consider:
> 
> - Nimbus deletes local data and restarts on the downgrade version
> - A running 2.5 Supervisor on the same host then re-creates that directory 
> and puts 2.5 data back in
> - When the 2.5 Supervisor goes to downgrade and restart, it can't delete that 
> data again since Nimbus is already running and would stop.
> 
> For this reason, we should always ensure that services are stopped on the 
> downgrade for an EU.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
>  4c44afe 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
>  6495dda 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  a665723 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  90b2f2a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  96ea82d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  948c0e5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  a7383a2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  d89a38a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  00dbaa7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  072f4b0 
> 
> Diff: https://reviews.apache.org/r/49915/diff/
> 
> 
> Testing
> ---
> 
> Verified that on HDP 2.4 to 2.5, Storm supervisors are no longer writing to 
> local data since they were stopped on downgrade.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 49640: Identify config changes added to Ambari-2.4.0 and mark them to not get added during Ambari upgrade


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49640/#review141765
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 11, 2016, 7:41 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49640/
> ---
> 
> (Updated July 11, 2016, 7:41 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17564
> https://issues.apache.org/jira/browse/AMBARI-17564
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Now that we have the mechanism to prevent configs from getting added as part 
> of Ambari upgrade, lets identify the configs that got added in 2.4.0 and mark 
> them as not to be added during Ambari upgrade.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  b4eecec 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  871e571 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  61b4233 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
>  52e9fe5 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
>  8087204 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  68961c1 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
>  9811191 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  0602d11 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
>  61437d5 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  29c46e9 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
>  d0e51eb 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  c158894 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
>  a0bd322 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
>  fd0cb3e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml
>  f3bbce8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
>  8d8af19 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml
>  6a0991b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  902fdc9 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/OOZIE/configuration/oozie-site.xml
>  766fe62 
> 
> Diff: https://reviews.apache.org/r/49640/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 49786: AMBARI-17615 : AMS metrics GET API does not work for same metric with multiple aggregation functions

2016-07-11 Thread Aravindan Vijayan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49786/
---

(Updated July 11, 2016, 8:14 p.m.)

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.

Changes
---

Review comments addressed.

Bugs: AMBARI-17615
https://issues.apache.org/jira/browse/AMBARI-17615

Repository: ambari

Description
---

AMS API which used to work in previous versions is now broken in 2.4.0 version

GET

http://:6188/ws/v1/timeline/metrics?metricNames=bytes_in._min,bytes_in._max,bytes_in._sum,bytes_in._avg=HOST=hours=146692800=146743920=

failed. Status:400
{
"exception": "BadRequestException",
"message": "java.lang.Exception: Multiple aggregate functions not supported.",
"javaClassName": "org.apache.hadoop.yarn.webapp.BadRequestException"
}

This impacts SmartSense capture

FIX

Changed data structure that stores the MetricName -> Aggregation Function from
HashMap to Multimap, so that we can have 1 metric name mapping to separate
lists of functions.

Diffs (updated)
-

ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf

ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
9510574

ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
bbd6d83

ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java
29e2664

ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
ae1aa5a

ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java
a86fa11

Diff: https://reviews.apache.org/r/49786/diff/

Testing
---

mvn clean test

Apache

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12816764/AMBARI-17615.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in
ambari-metrics/ambari-metrics-timelineservice.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/7732//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7732//console
This message is automatically generated.

Thanks,

Aravindan Vijayan

Review Request 49915: EU Downgrade Does Not Stop Services

2016-07-11 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49915/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
Cole.


Bugs: AMBARI-17660
https://issues.apache.org/jira/browse/AMBARI-17660


Repository: ambari


Description
---

When downgrading an express upgrade, the orchestration of the downgrade does 
not perform the same steps as the upgrade did. Namely, the stopping of high- 
and low-level services is not present. This leads to a scenario like this:

- Upgrade HDP 2.x to 2.y
-- Stop Storm
-- Stop ZK
-- Update Stack to 2.y
-- Restart ZK on 2.y
-- Restart Storm on 2.y

- Downgrade  HDP 2.y to 2.x
-- Update Stack to 2.x
-- Restart ZK on 2.x
-- Restart Storm on 2.x

Notice that we didn't stop the running services. This leads to a problem where 
actions which must take place while services are down can't complete 
successfully.

The case in point is Storm. Between HDP 2.4 and HDP 2.5, Storm changed the name 
of a serialized class. Part of the Storm upgrade/downgrade is to always delete 
local storm data. However, during an EU, if Nimbus and Supervisor are 
co-located on the same host, Supervisor will write out 2.5 data since it wasn't 
shut down. Consider:

- Nimbus deletes local data and restarts on the downgrade version
- A running 2.5 Supervisor on the same host then re-creates that directory and 
puts 2.5 data back in
- When the 2.5 Supervisor goes to downgrade and restart, it can't delete that 
data again since Nimbus is already running and would stop.

For this reason, we should always ensure that services are stopped on the 
downgrade for an EU.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
 4c44afe 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
 6495dda 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
 a665723 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
 90b2f2a 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 96ea82d 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 948c0e5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 a7383a2 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 d89a38a 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 00dbaa7 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 072f4b0 

Diff: https://reviews.apache.org/r/49915/diff/


Testing
---

Verified that on HDP 2.4 to 2.5, Storm supervisors are no longer writing to 
local data since they were stopped on downgrade.


Thanks,

Jonathan Hurley

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.



> On July 11, 2016, 3:46 p.m., Jonathan Hurley wrote:
> >

Thank you for reviewing! I'm going to fix the issues, and wait till the other 
reviewers leave comments that we should use `parameters` or not.


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/#review141703
---


On July 8, 2016, 8:20 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48972/
> ---
> 
> (Updated July 8, 2016, 8:20 p.m.)
> 
> 
> Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17253
> https://issues.apache.org/jira/browse/AMBARI-17253
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are too many WARNING in ZooKeeper log.
> ```
> 2016-06-15 21:02:15,405 - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of 
> stream exception
> EndOfStreamException: Unable to read additional data from client sessionid 
> 0x0, likely client has closed socket
> at 
> org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228)
> at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208)
> at java.lang.Thread.run(Thread.java:745)
> ```
> 
> It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port 
> to do monitoring.
> We should use 'ruok' to monitor zookeepers.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 
>   ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java
>  d7279de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  7ef12a7 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json 
> 469036a 
> 
> Diff: https://reviews.apache.org/r/48972/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 49905: AMBARI-17645 Update JDK version of Dockerfile in dev-support


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49905/
---

(Updated July 11, 2016, 5:27 p.m.)


Review request for Ambari, Jaimin Jetly, jun aoki, and Sumit Mohanty.


Bugs: AMBARI-17645
https://issues.apache.org/jira/browse/AMBARI-17645


Repository: ambari


Description
---

The Dockerfile in dev-support uses Java 7 while its support is finished. It 
would be nice it is Java 8 for developing purpose.


Diffs
-

  dev-support/docker/docker/Dockerfile 802d20a 

Diff: https://reviews.apache.org/r/49905/diff/


Testing (updated)
---

Hadooop QAed & manual tests done

```
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12817064/AMBARI-17645.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7768//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7768//console
This message is automatically generated.
```


Thanks,

Masahiro Tanaka

Re: Review Request 49905: AMBARI-17645 Update JDK version of Dockerfile in dev-support


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49905/#review141727
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 11, 2016, 5:27 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49905/
> ---
> 
> (Updated July 11, 2016, 5:27 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, jun aoki, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17645
> https://issues.apache.org/jira/browse/AMBARI-17645
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Dockerfile in dev-support uses Java 7 while its support is finished. It 
> would be nice it is Java 8 for developing purpose.
> 
> 
> Diffs
> -
> 
>   dev-support/docker/docker/Dockerfile 802d20a 
> 
> Diff: https://reviews.apache.org/r/49905/diff/
> 
> 
> Testing
> ---
> 
> Hadooop QAed & manual tests done
> 
> ```
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12817064/AMBARI-17645.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7768//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7768//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Review Request 49905: AMBARI-17645 Update JDK version of Dockerfile in dev-support


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49905/
---

Review request for Ambari, Jaimin Jetly, jun aoki, and Sumit Mohanty.


Bugs: AMBARI-17645
https://issues.apache.org/jira/browse/AMBARI-17645


Repository: ambari


Description
---

The Dockerfile in dev-support uses Java 7 while its support is finished. It 
would be nice it is Java 8 for developing purpose.


Diffs
-

  dev-support/docker/docker/Dockerfile 802d20a 

Diff: https://reviews.apache.org/r/49905/diff/


Testing
---

```
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12817064/AMBARI-17645.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7768//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7768//console
This message is automatically generated.
```


Thanks,

Masahiro Tanaka

Re: Review Request 49831: AMBARI-17562 - Adding single stack, extension and service should be removed from management pack support

2016-07-11 Thread Jayush Luniya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49831/#review141725
---


Ship it!




Ship It!

- Jayush Luniya


On July 8, 2016, 9:13 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49831/
> ---
> 
> (Updated July 8, 2016, 9:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Mahadev Konar, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17562
> https://issues.apache.org/jira/browse/AMBARI-17562
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This code is duplicated by the ability to add multiple stacks, extensions and 
> addon services. There is no reason to maintain both code paths.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/setupMpacks.py 5acc92c 
>   ambari-server/src/test/python/TestMpacks.py 0995280 
>   
> ambari-server/src/test/python/mpacks/myservice-ambari-mpack-1.0.0.0/mpack.json
>  0af6949 
> 
> Diff: https://reviews.apache.org/r/49831/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test -DskipSurefireTests
> 
> No errors related to the mpack tests
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 49902: Storm nimbus server fails to come up with CNF backtype.storm.metric.IClusterReporter error

2016-07-11 Thread Dmytro Sen



> On Июль 11, 2016, 4:35 п.п., Sid Wagle wrote:
> > Looks good but can you add Jayush as reviewer as well.

Added Jayush.
That's a draft yet. Will fix unit tests and commit tomorrow.
Now exact storm(and all installed services) version is passed from server to 
the agents. If version 1+ then new sink will be used.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49902/#review141716
---


On Июль 11, 2016, 4:16 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49902/
> ---
> 
> (Updated Июль 11, 2016, 4:16 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-17658
> https://issues.apache.org/jira/browse/AMBARI-17658
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Correct storm link should be used for non-HDP stacks as well.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  9c262d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  6750faf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e0528a0 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  052994d 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  bce71ca 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  ef2c536 
> 
> Diff: https://reviews.apache.org/r/49902/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 49898: ACL support for Logsearch Solr

2016-07-11 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49898/
---

Review request for Ambari, Miklos Gergely, Robert Levas, Robert Nettleton, 
Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-17653
https://issues.apache.org/jira/browse/AMBARI-17653


Repository: ambari


Description
---

Add abillity to use jaas file to authenticate on znode. (that was missing in 
upload configuration to zk)
- Get rid of zkcli of Solr (we can manage everything from solr-client, that 
will be useful, later we can use Watchers with async zookeeper command, which 
can wait until a znode is accessible etc.)
- add new functionalities for solrCloudCli (and solr_cloud_util) like 
setup_kerberos and add_sasl_users, with those we can copy all of the data 
between secure/unsecure znodes (sync...its needed because we have strict 
permissions, but if we disable kerberos we can not change them back), and we 
can create new sasl users. (also it set workd permission on secure node)...in 
the end I not use these features in ambari, using 2 znode (as hbase does) is a 
bit tricky solution. we have some other components where we are not using 
secure zookeeper. if we can find a good solution there later then I can use 
these features (or change them if neededlike, it would be good if we can 
use a zk super user...in that case we do not need to switch between znodes)
- user state json file to track what is the state of the cluster 
(secure/unsecure), that is used to figure it out an enable/disable kerberos 
task happening or there is not state change at all
- remove a lot of unused j2 file from logsearch module
- add retries for atlas/ranger if solr or znode not accessible
- better error messages for timing errors


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 4ecddf2 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 
3428dd8 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/global.config.json.j2
 cd51118 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/input.config.json.j2
 bc48503 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml.j2 
4338ee3 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/output.config.json.j2
 63c590e 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh.j2 
713a73a 
  
ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/solrconfig.xml.j2
 cb9bea5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/core.properties.j2
 5185057 
  
ambari-logsearch/ambari-logsearch-portal/src/main/configsets/hadoop_logs/conf/solrconfig.xml.j2
 0152880 
  ambari-logsearch/ambari-logsearch-portal/src/main/resources/log4j.xml.j2 
3b6eac9 
  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2
 8e3966e 
  ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh.j2 cb78c58 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml bc3babe 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 1e3cca5 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 33e94d0 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 de90859 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractStateFileZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperConfigCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java
 c9e8558 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CheckConfigZkCommand.java
 819395c 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CheckZnodeZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CopyZnodeZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateSaslUsersZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateSolrZnodeZkCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java
 2a0fa31

Review Request 49902: Storm nimbus server fails to come up with CNF backtype.storm.metric.IClusterReporter error

2016-07-11 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49902/
---

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-17658
https://issues.apache.org/jira/browse/AMBARI-17658


Repository: ambari


Description
---

Correct storm link should be used for non-HDP stacks as well.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 9c262d9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 6750faf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 e0528a0 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 052994d 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
 bce71ca 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
 ef2c536 

Diff: https://reviews.apache.org/r/49902/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-07-11 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/#review141703
---




ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py (line 66)


I'm 50/50 on the fence about using parameters for this:
- On one hand, they are constructs which should be consistent across all 
port alerts. Parameters by nature are not consistent - they are meant to extend 
alerts to provide coverage of an area which wasn't thought of originally. In 
this case, we can change the port alert behavior and just include a command and 
response as first-class citizens of the definition

- On the other hand, parameters gives us a way to represent them in the UI 
and decorate them with descriptions. 

I'm not going to flag this, but I'm curious to get the opinions of the 
other reviewers here. Originally, I was thinking of something like this:

```
"source": {
  "type": "PORT",
  "uri": "{{zoo.cfg/clientPort}}",
  "default_port": 2181,
  "socket_command": "ruok",
  "socket_response": "imok",
  ...
```



ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json 
(line 61)


"A socket command which queries ZooKeeper to respond with its state. The 
expected response is imok."



ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json 
(line 66)


socket.command.response



ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json 
(lines 67 - 69)


The expected response to the socket command.


- Jonathan Hurley


On July 8, 2016, 4:20 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48972/
> ---
> 
> (Updated July 8, 2016, 4:20 p.m.)
> 
> 
> Review request for Ambari, Florian Barca, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17253
> https://issues.apache.org/jira/browse/AMBARI-17253
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are too many WARNING in ZooKeeper log.
> ```
> 2016-06-15 21:02:15,405 - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxn@357] - caught end of 
> stream exception
> EndOfStreamException: Unable to read additional data from client sessionid 
> 0x0, likely client has closed socket
> at 
> org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:228)
> at 
> org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:208)
> at java.lang.Thread.run(Thread.java:745)
> ```
> 
> It may be because of Ambari Alert. Ambari Alert pings to the zookeeper port 
> to do monitoring.
> We should use 'ruok' to monitor zookeepers.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1918327 
>   ambari-agent/src/test/python/ambari_agent/TestPortAlert.py dffa56c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java
>  d7279de 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  7ef12a7 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/alerts.json 
> 469036a 
> 
> Diff: https://reviews.apache.org/r/48972/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12811835/AMBARI-17253.2.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in .
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 49808: Host service mapping has incorrect default mapping

2016-07-11 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49808/#review141701
---


Ship it!




Ship It!

- Dmytro Sen


On Июль 11, 2016, 3:29 п.п., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49808/
> ---
> 
> (Updated Июль 11, 2016, 3:29 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-17624
> https://issues.apache.org/jira/browse/AMBARI-17624
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Activity Analyzer and Explorer are salves with cardinality
> [0-1].  
> However the default selection maps to all hosts. This used to work fine in
> previous builds, but seems to be broken recently
> 
> Ambari version:
> 
> 
> 
> [root@cn030 ~]# rpm -qa | grep ambari
> ambari-agent-2.4.0.0-764.x86_64
> ambari-server-2.4.0.0-764.x86_64
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 7c6470f 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 931d59b 
> 
> Diff: https://reviews.apache.org/r/49808/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 49808: Host service mapping has incorrect default mapping

2016-07-11 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49808/
---

(Updated July 11, 2016, 3:29 p.m.)


Review request for Ambari, Dmytro Sen and Srimanth Gunturi.


Bugs: AMBARI-17624
https://issues.apache.org/jira/browse/AMBARI-17624


Repository: ambari


Description
---

Activity Analyzer and Explorer are salves with cardinality
[0-1].  
However the default selection maps to all hosts. This used to work fine in
previous builds, but seems to be broken recently

Ambari version:



[root@cn030 ~]# rpm -qa | grep ambari
ambari-agent-2.4.0.0-764.x86_64
ambari-server-2.4.0.0-764.x86_64


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/stack_advisor.py 7c6470f 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
931d59b 

Diff: https://reviews.apache.org/r/49808/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 49897: AMBARI-17617: Set default log level for Ranger KMS to INFO

2016-07-11 Thread Velmurugan Periasamy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49897/#review141699
---


Ship it!




Ship It!

- Velmurugan Periasamy


On July 11, 2016, 2:39 p.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49897/
> ---
> 
> (Updated July 11, 2016, 2:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit 
> Mohanty, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17617
> https://issues.apache.org/jira/browse/AMBARI-17617
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kms log file is getting bigger till 18 GB , causing No space left on device 
> for inode.
> Problem is :
> 1. by default debug log is generated in the kms.log fle
> 2. there is no split in log file if there is over flow of logs in kms.log 
> file like other access audit logs file and xa_portal logs.
> 
> Fixed the above by setting default log level to INFO.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml
>  61aede3 
> 
> Diff: https://reviews.apache.org/r/49897/diff/
> 
> 
> Testing
> ---
> 
> Tested on a local centos6 cluster with kms and monitored the log file.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 49786: AMBARI-17615 : AMS metrics GET API does not work for same metric with multiple aggregation functions

2016-07-11 Thread Aravindan Vijayan



> On July 11, 2016, 3:13 a.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java,
> >  line 290
> > 
> >
> > Why is this function static in a non-helper class ?

For test access, from HBaseTimelineMetricStoreTest


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49786/#review141633
---


On July 8, 2016, 6:26 a.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49786/
> ---
> 
> (Updated July 8, 2016, 6:26 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17615
> https://issues.apache.org/jira/browse/AMBARI-17615
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMS API which used to work in previous versions is now broken in 2.4.0 version
> 
> GET 
> 
> http://:6188/ws/v1/timeline/metrics?metricNames=bytes_in._min,bytes_in._max,bytes_in._sum,bytes_in._avg=HOST=hours=146692800=146743920=
> 
> failed. Status:400
> {
> "exception": "BadRequestException",
> "message": "java.lang.Exception: Multiple aggregate functions not supported.",
> "javaClassName": "org.apache.hadoop.yarn.webapp.BadRequestException"
> }
> 
> This impacts SmartSense capture
> 
> FIX
> 
> Changed data structure that stores the MetricName -> Aggregation Function 
> from HashMap to Multimap, so that we can have 1 metric name mapping to 
> separate lists of functions.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  9510574 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  bbd6d83 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStoreTest.java
>  29e2664 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  ae1aa5a 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java
>  a86fa11 
> 
> Diff: https://reviews.apache.org/r/49786/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> Apache
> 
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12816764/AMBARI-17615.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 3 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in 
> ambari-metrics/ambari-metrics-timelineservice.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7732//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7732//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 49897: AMBARI-17617: Set default log level for Ranger KMS to INFO

2016-07-11 Thread Gautam Borad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49897/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit Mohanty, 
Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-17617
https://issues.apache.org/jira/browse/AMBARI-17617


Repository: ambari


Description
---

Kms log file is getting bigger till 18 GB , causing No space left on device for 
inode.
Problem is :
1. by default debug log is generated in the kms.log fle
2. there is no split in log file if there is over flow of logs in kms.log file 
like other access audit logs file and xa_portal logs.

Fixed the above by setting default log level to INFO.


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml
 61aede3 

Diff: https://reviews.apache.org/r/49897/diff/


Testing
---

Tested on a local centos6 cluster with kms and monitored the log file.


Thanks,

Gautam Borad

Review Request 49895: AMBARI-17631: preinstall-check script should use AMBARI-AGENT REST API for the list of agents

2016-07-11 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49895/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-17631
https://issues.apache.org/jira/browse/AMBARI-17631


Repository: ambari


Description
---

it should use the existing services/AMBARI/components/AMBARI-AGENT rest api for 
the list of agents


Diffs
-

  contrib/utils/preinstall-check/src/main/python/preinstall_checker.py 7ff7e4c 

Diff: https://reviews.apache.org/r/49895/diff/


Testing
---

Run the script against a cluster just Ambari server and Ambari Agent nodes 
installed.verify the script can get the correct list of ambari agents.


Thanks,

Di Li

Re: Review Request 49894: Installation of Components was failed on suse12 with suse11sp3 ambari/hdp repo

2016-07-11 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49894/#review141690
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On July 11, 2016, 5 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49894/
> ---
> 
> (Updated July 11, 2016, 5 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-17654
> https://issues.apache.org/jira/browse/AMBARI-17654
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:  
> 1) Try to deploy ambari on sles12 by using suse11sp3 repo as was proposed
> before
> 
> **Cluster:** 
> 
> Actual result:  
> Installation of Components are failed on suse12 with suse11sp3 ambari/hdp repo
> 
> 
> 
> 
> 2016-07-06 12:22:59,978 - checked_call['rpm -q --queryformat 
> '%{version}-%{release}' hdp-select | sed -e 's/\.el[0-9]//g''] {'stderr': -1}
> 2016-07-06 12:22:59,994 - checked_call returned (0, '2.5.0.0-887', '')
> 2016-07-06 12:23:00,001 - Package['hadoop_2_5_0_0_887'] 
> {'retry_on_repo_unavailability': True, 'retry_count': 5}
> 2016-07-06 12:23:00,019 - Skipping installation of existing package 
> hadoop_2_5_0_0_887
> 2016-07-06 12:23:00,020 - Package['snappy'] 
> {'retry_on_repo_unavailability': True, 'retry_count': 5}
> 2016-07-06 12:23:00,095 - Skipping installation of existing package snappy
> 2016-07-06 12:23:00,096 - Package['snappy-devel'] 
> {'retry_on_repo_unavailability': True, 'retry_count': 5}
> 2016-07-06 12:23:00,105 - Skipping installation of existing package 
> snappy-devel
> 2016-07-06 12:23:00,107 - Package['lzo'] {'retry_on_repo_unavailability': 
> True, 'retry_count': 5}
> 2016-07-06 12:23:00,209 - Installing package lzo ('/usr/bin/zypper 
> --quiet install --auto-agree-with-licenses --no-confirm lzo')
> 
> Command failed after 1 tries
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
>  28605e4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> eb65b88 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 
> b95caae 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 
> f2014db 
> 
> Diff: https://reviews.apache.org/r/49894/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 49894: Installation of Components was failed on suse12 with suse11sp3 ambari/hdp repo

2016-07-11 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49894/
---

(Updated July 11, 2016, 2 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Summary (updated)
-

Installation of Components was failed on suse12 with suse11sp3 ambari/hdp repo


Bugs: AMBARI-17654
https://issues.apache.org/jira/browse/AMBARI-17654


Repository: ambari


Description
---

STR:  
1) Try to deploy ambari on sles12 by using suse11sp3 repo as was proposed
before

**Cluster:** 

Actual result:  
Installation of Components are failed on suse12 with suse11sp3 ambari/hdp repo




2016-07-06 12:22:59,978 - checked_call['rpm -q --queryformat 
'%{version}-%{release}' hdp-select | sed -e 's/\.el[0-9]//g''] {'stderr': -1}
2016-07-06 12:22:59,994 - checked_call returned (0, '2.5.0.0-887', '')
2016-07-06 12:23:00,001 - Package['hadoop_2_5_0_0_887'] 
{'retry_on_repo_unavailability': True, 'retry_count': 5}
2016-07-06 12:23:00,019 - Skipping installation of existing package 
hadoop_2_5_0_0_887
2016-07-06 12:23:00,020 - Package['snappy'] 
{'retry_on_repo_unavailability': True, 'retry_count': 5}
2016-07-06 12:23:00,095 - Skipping installation of existing package snappy
2016-07-06 12:23:00,096 - Package['snappy-devel'] 
{'retry_on_repo_unavailability': True, 'retry_count': 5}
2016-07-06 12:23:00,105 - Skipping installation of existing package 
snappy-devel
2016-07-06 12:23:00,107 - Package['lzo'] {'retry_on_repo_unavailability': 
True, 'retry_count': 5}
2016-07-06 12:23:00,209 - Installing package lzo ('/usr/bin/zypper --quiet 
install --auto-agree-with-licenses --no-confirm lzo')

Command failed after 1 tries


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
 28605e4 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
eb65b88 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 
b95caae 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 
f2014db 

Diff: https://reviews.apache.org/r/49894/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 49894: Installation of Components are failed on suse12 with suse11sp3 ambari/hdp repo

2016-07-11 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49894/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17654
https://issues.apache.org/jira/browse/AMBARI-17654


Repository: ambari


Description
---

STR:  
1) Try to deploy ambari on sles12 by using suse11sp3 repo as was proposed
before

**Cluster:** 

Actual result:  
Installation of Components are failed on suse12 with suse11sp3 ambari/hdp repo




2016-07-06 12:22:59,978 - checked_call['rpm -q --queryformat 
'%{version}-%{release}' hdp-select | sed -e 's/\.el[0-9]//g''] {'stderr': -1}
2016-07-06 12:22:59,994 - checked_call returned (0, '2.5.0.0-887', '')
2016-07-06 12:23:00,001 - Package['hadoop_2_5_0_0_887'] 
{'retry_on_repo_unavailability': True, 'retry_count': 5}
2016-07-06 12:23:00,019 - Skipping installation of existing package 
hadoop_2_5_0_0_887
2016-07-06 12:23:00,020 - Package['snappy'] 
{'retry_on_repo_unavailability': True, 'retry_count': 5}
2016-07-06 12:23:00,095 - Skipping installation of existing package snappy
2016-07-06 12:23:00,096 - Package['snappy-devel'] 
{'retry_on_repo_unavailability': True, 'retry_count': 5}
2016-07-06 12:23:00,105 - Skipping installation of existing package 
snappy-devel
2016-07-06 12:23:00,107 - Package['lzo'] {'retry_on_repo_unavailability': 
True, 'retry_count': 5}
2016-07-06 12:23:00,209 - Installing package lzo ('/usr/bin/zypper --quiet 
install --auto-agree-with-licenses --no-confirm lzo')

Command failed after 1 tries


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
 28605e4 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
eb65b88 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 
b95caae 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 
f2014db 

Diff: https://reviews.apache.org/r/49894/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 49640: Identify config changes added to Ambari-2.4.0 and mark them to not get added during Ambari upgrade

2016-07-11 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49640/
---

(Updated July 11, 2016, 4:38 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.


Changes
---

Fixed comments, added defaults where possible. Some properties are not used at 
our python scripts. Also it's hard to set reasonable defaults for some 
properties, I'll post a list of such properties.


Bugs: AMBARI-17564
https://issues.apache.org/jira/browse/AMBARI-17564


Repository: ambari


Description
---

Now that we have the mechanism to prevent configs from getting added as part of 
Ambari upgrade, lets identify the configs that got added in 2.4.0 and mark them 
as not to be added during Ambari upgrade.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
 b4eecec 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 871e571 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
 61b4233 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
 52e9fe5 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
 8087204 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 68961c1 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml
 9811191 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 0602d11 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
 61437d5 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml
 d8012dd 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
 29c46e9 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml
 d0e51eb 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 c158894 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-tagsync-site.xml
 a0bd322 
  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml
 e7a851c 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml
 6951db0 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-env.xml
 152c463 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
89e05d7 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
 fd0cb3e 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml
 f3bbce8 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
 8d8af19 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml
 6a0991b 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
 902fdc9 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/OOZIE/configuration/oozie-site.xml
 766fe62 

Diff: https://reviews.apache.org/r/49640/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 49857: Spark Interpreter fails with "HiveException: org.apache.thrift.transport.TTransportException"


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49857/#review141684
---


Ship it!




Ship It!

- Rohit Choudhary


On July 11, 2016, 12:52 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49857/
> ---
> 
> (Updated July 11, 2016, 12:52 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17639
> https://issues.apache.org/jira/browse/AMBARI-17639
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - this fix creates the missing hive-site.xml in zeppelin conf
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  075219a 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  6016ae1 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh
>  891fb29 
> 
> Diff: https://reviews.apache.org/r/49857/diff/
> 
> 
> Testing
> ---
> 
> manually tested on kerberized centOS cluster
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 49857: Spark Interpreter fails with "HiveException: org.apache.thrift.transport.TTransportException"

2016-07-11 Thread Renjith Kamath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49857/
---

(Updated July 11, 2016, 12:52 p.m.)


Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, 
Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-17639
https://issues.apache.org/jira/browse/AMBARI-17639


Repository: ambari


Description
---

- this fix creates the missing hive-site.xml in zeppelin conf


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 075219a 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 6016ae1 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh
 891fb29 

Diff: https://reviews.apache.org/r/49857/diff/


Testing
---

manually tested on kerberized centOS cluster


Thanks,

Renjith Kamath

Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-11 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49891/
---

Review request for Ambari, Andrew Onischuk and Jonathan Hurley.


Bugs: AMBARI-17651
https://issues.apache.org/jira/browse/AMBARI-17651


Repository: ambari


Description
---

Restart indicator is not shown after modifying the configs.
Test case modified the hdfs config 'Namenode new generation size'. But still 
after saving the configuration, restart icon is not shown.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 94a8fe0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
 d4e3828 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
46a3f3e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 fdb997b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 666111b 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
 dc8017a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
 0ff143c 

Diff: https://reviews.apache.org/r/49891/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 49889: Fix logfeeder inputs for hbase and hdfs

2016-07-11 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49889/#review141673
---


Ship it!




Ship It!

- Sebastian Toader


On July 11, 2016, 1:54 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49889/
> ---
> 
> (Updated July 11, 2016, 1:54 p.m.)
> 
> 
> Review request for Ambari, Dharmesh Makwana, Sumit Mohanty, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-17649
> https://issues.apache.org/jira/browse/AMBARI-17649
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - reference error in hdfs audit logs
> - do not use hard coded user name for hbase
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hbase.json.j2
>  42c5683 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hdfs.json.j2
>  639b4f5 
> 
> Diff: https://reviews.apache.org/r/49889/diff/
> 
> 
> Testing
> ---
> 
> Total run:1017
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 49889: Fix logfeeder inputs for hbase and hdfs

2016-07-11 Thread Dharmesh Makwana


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49889/#review141671
---


Ship it!




Ship It!

- Dharmesh Makwana


On July 11, 2016, 11:54 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49889/
> ---
> 
> (Updated July 11, 2016, 11:54 a.m.)
> 
> 
> Review request for Ambari, Dharmesh Makwana, Sumit Mohanty, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-17649
> https://issues.apache.org/jira/browse/AMBARI-17649
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - reference error in hdfs audit logs
> - do not use hard coded user name for hbase
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hbase.json.j2
>  42c5683 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hdfs.json.j2
>  639b4f5 
> 
> Diff: https://reviews.apache.org/r/49889/diff/
> 
> 
> Testing
> ---
> 
> Total run:1017
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 49861: Changes to stack advisor framework to help with service advisors

2016-07-11 Thread Tim Thorpe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49861/#review141670
---


Ship it!




Ship It!

- Tim Thorpe


On July 9, 2016, 9:22 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49861/
> ---
> 
> (Updated July 9, 2016, 9:22 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, Matt, Srimanth Gunturi, 
> and Tim Thorpe.
> 
> 
> Bugs: AMBARI-17642
> https://issues.apache.org/jira/browse/AMBARI-17642
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The following changes are needed in the stack advisor framework to help with 
> service advisors:
> 
> - Add additional logging to show why a service advisor implementation was not 
> loaded
> - Move `isSecurityEnabled` from `stacks/HDP/2.0.6/services/stack_advisor.py` 
> to a class member of `DefaultStackAdvisor` in `stacks/stack_advisor.py` so 
> that all stack and service advisors may be able to use it
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 3f66216 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 990c314 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 23c0320 
> 
> Diff: https://reviews.apache.org/r/49861/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results (python only):
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:56.308s
> [INFO] Finished at: Sat Jul 09 16:12:31 EDT 2016
> [INFO] Final Memory: 65M/1700M
> [INFO] 
> 
> 
> #Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 49889: Fix logfeeder inputs for hbase and hdfs

2016-07-11 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49889/
---

Review request for Ambari, Dharmesh Kakadia, Sumit Mohanty, and Sebastian 
Toader.


Bugs: AMBARI-17649
https://issues.apache.org/jira/browse/AMBARI-17649


Repository: ambari


Description
---

- reference error in hdfs audit logs
- do not use hard coded user name for hbase


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hbase.json.j2
 42c5683 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hdfs.json.j2
 639b4f5 

Diff: https://reviews.apache.org/r/49889/diff/


Testing
---

Total run:1017
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 49857: Spark Interpreter fails with "HiveException: org.apache.thrift.transport.TTransportException"


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49857/#review141667
---


Ship it!




Ship It!

- Rohit Choudhary


On July 9, 2016, 6:04 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49857/
> ---
> 
> (Updated July 9, 2016, 6:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17639
> https://issues.apache.org/jira/browse/AMBARI-17639
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - this fix creates the missing hive-site.xml in zeppelin conf
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  075219a 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh
>  891fb29 
> 
> Diff: https://reviews.apache.org/r/49857/diff/
> 
> 
> Testing
> ---
> 
> manually tested on kerberized centOS cluster
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 49859: Zeppelin service: Dependencies for phoenix in JDBC interpreter are not configured by default


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49859/#review141666
---


Ship it!




Ship It!

- Rohit Choudhary


On July 9, 2016, 6:48 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49859/
> ---
> 
> (Updated July 9, 2016, 6:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17632
> https://issues.apache.org/jira/browse/AMBARI-17632
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> fixed the service def script to configure default interpreter settings
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  075219a 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  6016ae1 
> 
> Diff: https://reviews.apache.org/r/49859/diff/
> 
> 
> Testing
> ---
> 
> manually tested on secure and unsecure centOS cluster
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 49858: Zeppelin service: remove principal and keytab from interpreter settings when kerberos is disabled on a secure cluster