Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50532/
---

(Updated July 29, 2016, 10:38 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-17949
https://issues.apache.org/jira/browse/AMBARI-17949


Repository: ambari


Description
---

In hive-log4j content, the following needs to be added during HDP upgrades to 
2.5.

# Silence HadoopMetrics2Reporter INFO logs
log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 5d2cc54 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
d0332ed 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 dbabd7c 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
102f97e 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsActionTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50532/diff/


Testing
---

Added unit tests.
Tested EU from HDP 2.4 to 2.5.
Tested RU from HDP 2.3 to 2.5


Thanks,

Aravindan Vijayan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144210
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 29, 2016, 8:14 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated July 29, 2016, 8:14 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Review Request 50616: Coverity Scan Security Vulnerability - SQL injection

2016-07-29 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50616/
---

Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-17962
https://issues.apache.org/jira/browse/AMBARI-17962


Repository: ambari


Description
---

The Ambari coverity scan found two "High impact security" issues, both SQL 
Injections.  They are both the same coding issue, but one is in 
OracleConnector.java, and one is in the analogous method in 
PostgresConnector.java.

This is the key description:
```
CID 167755 (#1 of 1): SQL injection (SQLI)9. sql_taint: Insecure concatenation 
of a SQL statement. The value searchClause is tainted.

Perform one of the following to guard against SQL injection attacks.
* Parameterize the SQL statement using ? positional characters. Bind the 
tainted values to the ? positional parameters using one of the 
PreparedStatement.set* methods.
* Validate user-supplied values against predefined constant values. Concatenate 
these constant values into the SQL statement.
* Cast tainted values to safe types such as integers. Concatenate these type 
safe values into the statement.

[More 
Information|https://scan3.coverity.com/doc/en/cov_checker_ref.html#id_sql_generic]
```

This is the one in OracleConnector.java, lines 32 -55:

```
32  @Override
  8. taint_path_param: Parameter searchClause receives the tainted data.
33  protected PreparedStatement getQualifiedPS(Statements statement, String 
searchClause, Workflows.WorkflowDBEntry.WorkflowFields field, boolean 
sortAscending, int offset, int limit) throws IOException {
34if (db == null)
35  throw new IOException("db not initialized");
36
37String order = " ORDER BY " + field.toString() + " " + (sortAscending ? 
SORT_ASC : SORT_DESC);
38
39String query = "select * \n" +
40"  from ( select " +
41//"/*+ FIRST_ROWS(n) */ \n" +
42"  a.*, ROWNUM rnum \n" +
43"  from ("
  CID 167755 (#1 of 1): SQL injection (SQLI)9. sql_taint: Insecure 
concatenation of a SQL statement. The value searchClause is tainted.
  Perform one of the following to guard against SQL injection attacks.

Parameterize the SQL statement using ? positional characters. Bind the 
tainted values to the ? positional parameters using one of the 
PreparedStatement.set* methods.
Validate user-supplied values against predefined constant values. 
Concatenate these constant values into the SQL statement.
Cast tainted values to safe types such as integers. Concatenate these type 
safe values into the statement.

More Information
44+ statement.getStatementString() + searchClause + order +
45") a \n" +
46"  where ROWNUM <= " + (offset + limit) + ") \n" +
47"where rnum  >= " + offset;
48
49try {
  10. sql_sink: Passing the tainted value query to the SQL API 
java.sql.Connection.prepareStatement(java.lang.String) may allow an attacker to 
inject SQL.
50  return db.prepareStatement(query);
51} catch (SQLException e) {
52  throw new IOException(e);
53}
54
55  }
```
This is the one in PostgresConnector.java, lines 495-504:

``` 
   8. taint_path_param: Parameter searchClause receives the tainted data.
495  protected PreparedStatement getQualifiedPS(Statements statement, String 
searchClause) throws IOException {
496if (db == null)
497  throw new IOException("postgres db not initialized");
498try {
499  // LOG.debug("preparing " + statement.getStatementString() + 
searchClause);
   CID 167743 (#1 of 1): SQL injection (SQLI)9. sql_taint: Insecure 
concatenation of a SQL statement. The value searchClause is tainted. Passing 
the tainted command to the SQL API 
java.sql.Connection.prepareStatement(java.lang.String) may allow an attacker to 
inject SQL.
   Perform one of the following to guard against SQL injection attacks.

Parameterize the SQL statement using ? positional characters. Bind the 
tainted values to the ? positional parameters using one of the 
PreparedStatement.set* methods.
Validate user-supplied values against predefined constant values. 
Concatenate these constant values into the SQL statement.
Cast tainted values to safe types such as integers. Concatenate these type 
safe values into the statement.

More Information
500  return db.prepareStatement(statement.getStatementString() + 
searchClause);
501} catch (SQLException e) {
502  throw new IOException(e);
503}
504  }
```

#Solution
Remove code supporting an unsupported REST API call to obtain jobtracker 
information.  his entry point is handled by 
{{org.apache.ambari.eventdb.webservice.WorkflowJsonService}}.  By removing this 
class and cleaning up orphaned code, the SQL injection issue list above will be 
solved.


Diffs
-

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/
---

(Updated July 29, 2016, 1:14 p.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Fixed tailing space and fixed HBase name


Bugs: AMBARI-17955
https://issues.apache.org/jira/browse/AMBARI-17955


Repository: ambari


Description
---

Enabled the registration of optionally downloaded berkeley db jar file.   
Introduce Berekley DB as a jdbc-db (even though it is actually not.   Download 
je-5.0.73.jar if not already present and inform users on how to register

also, fixed Atlas integration changes with classname and packagename


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 dd1cda0 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 ebe3634 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
8d5cdc9 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
f8ba3e9 

Diff: https://reviews.apache.org/r/50595/diff/


Testing
---

Tested downloading of the jar file by registering with ambari server
Tested Falcon/Atlas component names


Thanks,

Venkat Ranganathan

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Venkat Ranganathan 


> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py, line 
> > 1132
> > 
> >
> > What happens if the version changes?

The version cannot change as that is the only version we can support - but I 
don't think this symlink is even needed - so can drop it


> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py, line 
> > 1143
> > 
> >
> > Why is there a version number in this jar name?

Will remove 5.0* but the only version we support is that.


> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py,
> >  line 203
> > 
> >
> > If there are any exceptions, please log it.

Since we log exceptions in DonwloadSource did not do it.   But it does not hurt 
to add it here also.  will add


> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py,
> >  line 211
> > 
> >
> > Typo.

will fix.  thanks


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144139
---


On July 29, 2016, 11:56 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated July 29, 2016, 11:56 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/
---

(Updated July 29, 2016, 11:56 a.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Addressed review comments


Bugs: AMBARI-17955
https://issues.apache.org/jira/browse/AMBARI-17955


Repository: ambari


Description
---

Enabled the registration of optionally downloaded berkeley db jar file.   
Introduce Berekley DB as a jdbc-db (even though it is actually not.   Download 
je-5.0.73.jar if not already present and inform users on how to register

also, fixed Atlas integration changes with classname and packagename


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 dd1cda0 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 ebe3634 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
8d5cdc9 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
f8ba3e9 

Diff: https://reviews.apache.org/r/50595/diff/


Testing
---

Tested downloading of the jar file by registering with ambari server
Tested Falcon/Atlas component names


Thanks,

Venkat Ranganathan

Re: Review Request 50554: Ambari upgrade reports error upgrading view tables - possibly not an error but confusing

2016-07-29 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50554/#review144141
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 28, 2016, 11:37 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50554/
> ---
> 
> (Updated July 28, 2016, 11:37 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Pallav Kulshreshtha, Rohit 
> Choudhary, Sumit Mohanty, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17941
> https://issues.apache.org/jira/browse/AMBARI-17941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> changed the error message and handling
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  a3d9c89 
> 
> Diff: https://reviews.apache.org/r/50554/diff/
> 
> 
> Testing
> ---
> 
> manual testing
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install

2016-07-29 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50595/#review144139
---




ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py (line 1132)


What happens if the version changes?



ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py (line 1143)


Why is there a version number in this jar name?



ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 (line 203)


If there are any exceptions, please log it.



ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 (line 211)


Typo.


- Alejandro Fernandez


On July 29, 2016, 5:51 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50595/
> ---
> 
> (Updated July 29, 2016, 5:51 a.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17955
> https://issues.apache.org/jira/browse/AMBARI-17955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled the registration of optionally downloaded berkeley db jar file.   
> Introduce Berekley DB as a jdbc-db (even though it is actually not.   
> Download je-5.0.73.jar if not already present and inform users on how to 
> register
> 
> also, fixed Atlas integration changes with classname and packagename
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> d09bd77 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  dd1cda0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  ebe3634 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 8d5cdc9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> f8ba3e9 
> 
> Diff: https://reviews.apache.org/r/50595/diff/
> 
> 
> Testing
> ---
> 
> Tested downloading of the jar file by registering with ambari server
> Tested Falcon/Atlas component names
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50612: Hive Ranger plug in broken after upgrade to HDP 2.4.0

2016-07-29 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50612/#review144138
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 29, 2016, 5:43 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50612/
> ---
> 
> (Updated July 29, 2016, 5:43 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17964
> https://issues.apache.org/jira/browse/AMBARI-17964
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I've managed to reproduce the issue during Ambari upgrade 2.0.2 to 2.2.1.1.
> 
> The issue seems to be that hive_security_authorization is missing in 2.0.2, 
> so during upgrade hive_security_authorization it is added with value None 
> (because code supports only Kerberos, and not Ranger), and then 
> {{hive.security.authorization.manager}} and 
> {{hive.security.authenticator.manager}} are  immediately removed at 
> UpgradeCatalog210 if hive_security_authorization value is None.
> 
> {code}
> boolean isHiveSecurityAuthPresent = 
> cluster.getDesiredConfigByType("hive-env").getProperties().containsKey("hive_security_authorization");
> String hiveSecurityAuth="";
> 
> if ("kerberos".equalsIgnoreCase(hive_server2_auth) && 
> cluster.getServices().containsKey("KERBEROS")){
> hiveSecurityAuth = "SQLStdAuth";
> isHiveSecurityAuthPresent = true;
> hiveEnvProps.put("hive_security_authorization", hiveSecurityAuth);
> } else {
> if (isHiveSecurityAuthPresent) {
> hiveSecurityAuth = 
> cluster.getDesiredConfigByType("hive-env").getProperties().get("hive_security_authorization");
> }
> }
> 
> if (isHiveSecurityAuthPresent && "none".equalsIgnoreCase(hiveSecurityAuth)) {
> hiveServerSiteRemoveProps.add("hive.security.authorization.manager");
> hiveServerSiteRemoveProps.add("hive.security.authenticator.manager");
> }
> updateConfigurationPropertiesForCluster(cluster, "hive-env", hiveEnvProps, 
> true, true);
> removeConfigurationPropertiesFromCluster(cluster, "hiveserver2-site", 
> hiveServerSiteRemoveProps);
> }
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  b958f3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java
>  72ae7b4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
>  f0ec36f 
> 
> Diff: https://reviews.apache.org/r/50612/diff/
> 
> 
> Testing
> ---
> 
> tested on live cluster
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 50612: Hive Ranger plug in broken after upgrade to HDP 2.4.0

2016-07-29 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50612/
---

(Updated July 29, 2016, 8:43 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-17964
https://issues.apache.org/jira/browse/AMBARI-17964


Repository: ambari


Description
---

I've managed to reproduce the issue during Ambari upgrade 2.0.2 to 2.2.1.1.

The issue seems to be that hive_security_authorization is missing in 2.0.2, so 
during upgrade hive_security_authorization it is added with value None (because 
code supports only Kerberos, and not Ranger), and then 
{{hive.security.authorization.manager}} and 
{{hive.security.authenticator.manager}} are  immediately removed at 
UpgradeCatalog210 if hive_security_authorization value is None.

{code}
boolean isHiveSecurityAuthPresent = 
cluster.getDesiredConfigByType("hive-env").getProperties().containsKey("hive_security_authorization");
String hiveSecurityAuth="";

if ("kerberos".equalsIgnoreCase(hive_server2_auth) && 
cluster.getServices().containsKey("KERBEROS")){
hiveSecurityAuth = "SQLStdAuth";
isHiveSecurityAuthPresent = true;
hiveEnvProps.put("hive_security_authorization", hiveSecurityAuth);
} else {
if (isHiveSecurityAuthPresent) {
hiveSecurityAuth = 
cluster.getDesiredConfigByType("hive-env").getProperties().get("hive_security_authorization");
}
}

if (isHiveSecurityAuthPresent && "none".equalsIgnoreCase(hiveSecurityAuth)) {
hiveServerSiteRemoveProps.add("hive.security.authorization.manager");
hiveServerSiteRemoveProps.add("hive.security.authenticator.manager");
}
updateConfigurationPropertiesForCluster(cluster, "hive-env", hiveEnvProps, 
true, true);
removeConfigurationPropertiesFromCluster(cluster, "hiveserver2-site", 
hiveServerSiteRemoveProps);
}
{code}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 b958f3a 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java
 72ae7b4 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
 f0ec36f 

Diff: https://reviews.apache.org/r/50612/diff/


Testing (updated)
---

tested on live cluster

mvn clean test


Thanks,

Dmitro Lisnichenko

Review Request 50612: Hive Ranger plug in broken after upgrade to HDP 2.4.0

2016-07-29 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50612/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-17964
https://issues.apache.org/jira/browse/AMBARI-17964


Repository: ambari


Description
---

I've managed to reproduce the issue during Ambari upgrade 2.0.2 to 2.2.1.1.

The issue seems to be that hive_security_authorization is missing in 2.0.2, so 
during upgrade hive_security_authorization it is added with value None (because 
code supports only Kerberos, and not Ranger), and then 
{{hive.security.authorization.manager}} and 
{{hive.security.authenticator.manager}} are  immediately removed at 
UpgradeCatalog210 if hive_security_authorization value is None.

{code}
boolean isHiveSecurityAuthPresent = 
cluster.getDesiredConfigByType("hive-env").getProperties().containsKey("hive_security_authorization");
String hiveSecurityAuth="";

if ("kerberos".equalsIgnoreCase(hive_server2_auth) && 
cluster.getServices().containsKey("KERBEROS")){
hiveSecurityAuth = "SQLStdAuth";
isHiveSecurityAuthPresent = true;
hiveEnvProps.put("hive_security_authorization", hiveSecurityAuth);
} else {
if (isHiveSecurityAuthPresent) {
hiveSecurityAuth = 
cluster.getDesiredConfigByType("hive-env").getProperties().get("hive_security_authorization");
}
}

if (isHiveSecurityAuthPresent && "none".equalsIgnoreCase(hiveSecurityAuth)) {
hiveServerSiteRemoveProps.add("hive.security.authorization.manager");
hiveServerSiteRemoveProps.add("hive.security.authenticator.manager");
}
updateConfigurationPropertiesForCluster(cluster, "hive-env", hiveEnvProps, 
true, true);
removeConfigurationPropertiesFromCluster(cluster, "hiveserver2-site", 
hiveServerSiteRemoveProps);
}
{code}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 b958f3a 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java
 72ae7b4 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java
 f0ec36f 

Diff: https://reviews.apache.org/r/50612/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Dmytro Grinenko 


> On July 29, 2016, 10:26 a.m., Dmytro Grinenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java,
> >  line 73
> > 
> >
> > please use regexp, as 
> > log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop   property can 
> > be already defined with different set of values or can be present without 
> > an coment.
> > 
> > 
> > for an example 
> > "^\s*log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop\s*=\s*(.*)$"
> 
> Dmytro Grinenko wrote:
> 
> ^\s*log4j\.logger\.com\.github\.joshelser\.dropwizard\.metrics\.hadoop\s*=\s*(.*)$
>  , that nice code formatting on rb
> 
> Aravindan Vijayan wrote:
> Good catch Dmytro. But, this package does not exist in HDP 2.4 (or HDP 
> 2.3). Hence, the hive-log4j content ideally can never have this line. The 
> only way it might have it is through this Upgrade action. 
> 
> Also, in the rare case that the user had actually set the log level of 
> this package to a specific value, I feel we should not change it. Hence, can 
> we just look for the string 
> "log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop" instead of 
> pattern? What do you suggest?

yep, it would be enought just to check that this property doen't exist without 
cary about value.

I understand that it could be too much, but since user able to change that 
configuration manully on his own, we should assume that property could be 
already present.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50532/#review144072
---


On July 29, 2016, 5:19 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50532/
> ---
> 
> (Updated July 29, 2016, 5:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17949
> https://issues.apache.org/jira/browse/AMBARI-17949
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In hive-log4j content, the following needs to be added during HDP upgrades to 
> 2.5.
> 
> # Silence HadoopMetrics2Reporter INFO logs
> log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  9daced9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7a3a19e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  64c58d8 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 2168868 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsActionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50532/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> Tested EU from HDP 2.4 to 2.5.
> Tested RU from HDP 2.3 to 2.5
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50532/#review144131
---


Ship it!




Nicely done

- Alejandro Fernandez


On July 29, 2016, 5:19 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50532/
> ---
> 
> (Updated July 29, 2016, 5:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17949
> https://issues.apache.org/jira/browse/AMBARI-17949
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In hive-log4j content, the following needs to be added during HDP upgrades to 
> 2.5.
> 
> # Silence HadoopMetrics2Reporter INFO logs
> log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  9daced9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7a3a19e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  64c58d8 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 2168868 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsActionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50532/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> Tested EU from HDP 2.4 to 2.5.
> Tested RU from HDP 2.3 to 2.5
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 50606: Move masters can't succeed with Service admin user as it requires "Delete component" that is not allowed for it

2016-07-29 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50606/#review144130
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 29, 2016, 4:16 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50606/
> ---
> 
> (Updated July 29, 2016, 4:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Myroslav 
> Papirkovskyy, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17960
> https://issues.apache.org/jira/browse/AMBARI-17960
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1) Create a service admin user
> 2) Log in using service admin user
> 3) Move to HCAT service
> 4) At step4 it will fail to "Delete WebHCAT service"
> On looking at the network for Chrome, looks like service admin is not allowed 
> to delete the component and throws 403 and the page reloads.
> PS : This may be failing from some time but was blocked due to other issues
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  d0f8aa8 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 0a456eb 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3e2e144 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c0f2368 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c4f9dfc 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> d42445d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1300746 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8f0dae0 
> 
> Diff: https://reviews.apache.org/r/50606/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50532/
---

(Updated July 29, 2016, 5:19 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-17949
https://issues.apache.org/jira/browse/AMBARI-17949


Repository: ambari


Description
---

In hive-log4j content, the following needs to be added during HDP upgrades to 
2.5.

# Silence HadoopMetrics2Reporter INFO logs
log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 9daced9 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
7a3a19e 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 64c58d8 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
2168868 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsActionTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50532/diff/


Testing
---

Added unit tests.
Tested EU from HDP 2.4 to 2.5.
Tested RU from HDP 2.3 to 2.5


Thanks,

Aravindan Vijayan

Re: Review Request 50606: Move masters can't succeed with Service admin user as it requires "Delete component" that is not allowed for it

2016-07-29 Thread Dmytro Grinenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50606/#review144127
---


Ship it!




Ship It!

- Dmytro Grinenko


On July 29, 2016, 4:16 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50606/
> ---
> 
> (Updated July 29, 2016, 4:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Myroslav 
> Papirkovskyy, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17960
> https://issues.apache.org/jira/browse/AMBARI-17960
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1) Create a service admin user
> 2) Log in using service admin user
> 3) Move to HCAT service
> 4) At step4 it will fail to "Delete WebHCAT service"
> On looking at the network for Chrome, looks like service admin is not allowed 
> to delete the component and throws 403 and the page reloads.
> PS : This may be failing from some time but was blocked due to other issues
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  d0f8aa8 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 0a456eb 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3e2e144 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c0f2368 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c4f9dfc 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> d42445d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1300746 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8f0dae0 
> 
> Diff: https://reviews.apache.org/r/50606/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Aravindan Vijayan 


> On July 29, 2016, 10:26 a.m., Dmytro Grinenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java,
> >  line 73
> > 
> >
> > please use regexp, as 
> > log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop   property can 
> > be already defined with different set of values or can be present without 
> > an coment.
> > 
> > 
> > for an example 
> > "^\s*log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop\s*=\s*(.*)$"
> 
> Dmytro Grinenko wrote:
> 
> ^\s*log4j\.logger\.com\.github\.joshelser\.dropwizard\.metrics\.hadoop\s*=\s*(.*)$
>  , that nice code formatting on rb

Good catch Dmytro. But, this package does not exist in HDP 2.4 (or HDP 2.3). 
Hence, the hive-log4j content ideally can never have this line. The only way it 
might have it is through this Upgrade action. 

Also, in the rare case that the user had actually set the log level of this 
package to a specific value, I feel we should not change it. Hence, can we just 
look for the string 
"log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop" instead of 
pattern? What do you suggest?


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50532/#review144072
---


On July 28, 2016, 11:07 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50532/
> ---
> 
> (Updated July 28, 2016, 11:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17949
> https://issues.apache.org/jira/browse/AMBARI-17949
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In hive-log4j content, the following needs to be added during HDP upgrades to 
> 2.5.
> 
> # Silence HadoopMetrics2Reporter INFO logs
> log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7197e29 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7a3a19e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  902c421 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 2168868 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsActionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50532/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> Tested EU from HDP 2.4 to 2.5.
> Tested RU from HDP 2.3 to 2.5
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 50606: Move masters can't succeed with Service admin user as it requires "Delete component" that is not allowed for it

2016-07-29 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50606/#review144117
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On July 29, 2016, 7:16 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50606/
> ---
> 
> (Updated July 29, 2016, 7:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Myroslav 
> Papirkovskyy, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17960
> https://issues.apache.org/jira/browse/AMBARI-17960
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1) Create a service admin user
> 2) Log in using service admin user
> 3) Move to HCAT service
> 4) At step4 it will fail to "Delete WebHCAT service"
> On looking at the network for Chrome, looks like service admin is not allowed 
> to delete the component and throws 403 and the page reloads.
> PS : This may be failing from some time but was blocked due to other issues
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  d0f8aa8 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 0a456eb 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3e2e144 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c0f2368 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c4f9dfc 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> d42445d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1300746 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8f0dae0 
> 
> Diff: https://reviews.apache.org/r/50606/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 50606: Move masters can't succeed with Service admin user as it requires "Delete component" that is not allowed for it

2016-07-29 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50606/#review144116
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Липень 29, 2016, 4:16 після полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50606/
> ---
> 
> (Updated Липень 29, 2016, 4:16 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Myroslav 
> Papirkovskyy, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17960
> https://issues.apache.org/jira/browse/AMBARI-17960
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1) Create a service admin user
> 2) Log in using service admin user
> 3) Move to HCAT service
> 4) At step4 it will fail to "Delete WebHCAT service"
> On looking at the network for Chrome, looks like service admin is not allowed 
> to delete the component and throws 403 and the page reloads.
> PS : This may be failing from some time but was blocked due to other issues
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  d0f8aa8 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 0a456eb 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3e2e144 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c0f2368 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c4f9dfc 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> d42445d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1300746 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8f0dae0 
> 
> Diff: https://reviews.apache.org/r/50606/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 50606: Move masters can't succeed with Service admin user as it requires "Delete component" that is not allowed for it

2016-07-29 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50606/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Myroslav 
Papirkovskyy, and Vitalyi Brodetskyi.


Bugs: AMBARI-17960
https://issues.apache.org/jira/browse/AMBARI-17960


Repository: ambari


Description
---

1) Create a service admin user
2) Log in using service admin user
3) Move to HCAT service
4) At step4 it will fail to "Delete WebHCAT service"
On looking at the network for Chrome, looks like service admin is not allowed 
to delete the component and throws 403 and the page reloads.
PS : This may be failing from some time but was blocked due to other issues


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 d0f8aa8 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 0a456eb 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3e2e144 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c0f2368 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql c4f9dfc 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
d42445d 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1300746 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8f0dae0 

Diff: https://reviews.apache.org/r/50606/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 50605: hadoop.security.* properties should not be set in hive-site.xml (hive-interactive-site)

2016-07-29 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50605/#review144114
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Липень 29, 2016, 3:36 після полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50605/
> ---
> 
> (Updated Липень 29, 2016, 3:36 після полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17959
> https://issues.apache.org/jira/browse/AMBARI-17959
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberizing a cluster - the following 2 properties get added to 
> hive-interactive-site.
> hadoop.security.authentication - KERBEROS
> hadoop.security.authorization - true
> These properties don't belong in hive-site, and should not be added. Adding 
> them here will cause something to break in the future, and likely a long 
> support call.
> Marking as critical to get attention - if this is a simple, please fix in 
> 2.4.0
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
> 499aa32 
> 
> Diff: https://reviews.apache.org/r/50605/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 50605: hadoop.security.* properties should not be set in hive-site.xml (hive-interactive-site)

2016-07-29 Thread Dmytro Grinenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50605/#review144113
---


Ship it!




Ship It!

- Dmytro Grinenko


On July 29, 2016, 3:36 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50605/
> ---
> 
> (Updated July 29, 2016, 3:36 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17959
> https://issues.apache.org/jira/browse/AMBARI-17959
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberizing a cluster - the following 2 properties get added to 
> hive-interactive-site.
> hadoop.security.authentication - KERBEROS
> hadoop.security.authorization - true
> These properties don't belong in hive-site, and should not be added. Adding 
> them here will cause something to break in the future, and likely a long 
> support call.
> Marking as critical to get attention - if this is a simple, please fix in 
> 2.4.0
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
> 499aa32 
> 
> Diff: https://reviews.apache.org/r/50605/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 50605: hadoop.security.* properties should not be set in hive-site.xml (hive-interactive-site)

2016-07-29 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50605/
---

Review request for Ambari, Dmitro Lisnichenko, Myroslav Papirkovskyy, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-17959
https://issues.apache.org/jira/browse/AMBARI-17959


Repository: ambari


Description
---

When kerberizing a cluster - the following 2 properties get added to 
hive-interactive-site.
hadoop.security.authentication - KERBEROS
hadoop.security.authorization - true
These properties don't belong in hive-site, and should not be added. Adding 
them here will cause something to break in the future, and likely a long 
support call.
Marking as critical to get attention - if this is a simple, please fix in 2.4.0


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
499aa32 

Diff: https://reviews.apache.org/r/50605/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50532/#review144098
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
 (lines 80 - 81)


Also, instead of just saying "content was set to", you should call out the 
type as well. 

Maybe:

`Updated hive-log4j/content to prevent HadoopMetrics2Reporter from 
appearing in the logs`



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
 (line 85)


Clarify this to:

`hive-log4j/content already contains the correct  HadoopMetrics2Reporter 
properties`


- Jonathan Hurley


On July 28, 2016, 7:07 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50532/
> ---
> 
> (Updated July 28, 2016, 7:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17949
> https://issues.apache.org/jira/browse/AMBARI-17949
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In hive-log4j content, the following needs to be added during HDP upgrades to 
> 2.5.
> 
> # Silence HadoopMetrics2Reporter INFO logs
> log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7197e29 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7a3a19e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  902c421 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 2168868 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsActionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50532/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> Tested EU from HDP 2.4 to 2.5.
> Tested RU from HDP 2.3 to 2.5
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50532/#review144095
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
 (lines 80 - 81)


This will be huge and probably not look right to the command output, which 
is available on the UI.  Use some text saying something like "Updated 
hive-log4j/content to WARN on metrics"

Make the text as descriptive as you like, as long as you don't put full 
context of log4j.properties.


- Nate Cole


On July 28, 2016, 7:07 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50532/
> ---
> 
> (Updated July 28, 2016, 7:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17949
> https://issues.apache.org/jira/browse/AMBARI-17949
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In hive-log4j content, the following needs to be added during HDP upgrades to 
> 2.5.
> 
> # Silence HadoopMetrics2Reporter INFO logs
> log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7197e29 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7a3a19e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  902c421 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 2168868 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsActionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50532/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> Tested EU from HDP 2.4 to 2.5.
> Tested RU from HDP 2.3 to 2.5
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2

2016-07-29 Thread Mugdha Varadkar 


> On July 28, 2016, 4:16 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py,
> >  line 74
> > 
> >
> > I don't think you need the `upgrade_type is not None` since you have an 
> > equality check right after it.

Updated it latest patch


> On July 28, 2016, 4:16 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py,
> >  line 66
> > 
> >
> > I don't think you need the `upgrade_type is not None` since you have an 
> > equality check right after it.

Updated it latest patch


> On July 28, 2016, 4:16 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py,
> >  lines 67-68
> > 
> >
> > I'd rather see a specific check in the stack feature stuff for this; 
> > it's not clear what combination of stack features affect this.

Yes it is specific for stack 2.2 only


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50565/#review143950
---


On July 29, 2016, 12:16 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50565/
> ---
> 
> (Updated July 29, 2016, 12:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Nate Cole, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17945
> https://issues.apache.org/jira/browse/AMBARI-17945
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of changes done in this AMBARI-17840, following changes are required 
> to handle EU scenario :
> 
> 1] need to change the owner/mode of stop script and 
> 2] create symbolic link if it does not exists.
> 
> 
> This patch handles the following upgrade scenarios:
> 1) ranger admin from 2.2.x to 2.2.y
> 2) ranger usersync from 2.2.x to 2.3, 2.4
> 3) ranger kms from 2.3 to 2.3.x, 2.4, 2.5
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  c0534f3 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
>  5ce0617 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
>  cbdcc8c 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py
>  55c0486 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  4888aa6 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
> 95310d5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  6e7e272 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  b368db3 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> 9eb4a44 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> e67b82c 
> 
> Diff: https://reviews.apache.org/r/50565/diff/
> 
> 
> Testing
> ---
> 
> Tested EU from
> 2.2 to 2.2
> 2.2 to 2.4
> 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2

2016-07-29 Thread Mugdha Varadkar 


> On July 28, 2016, 8:10 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml,
> >  lines 659-665
> > 
> >
> > I think you might be able to use the "modern"  here:
> >  > if-type="ranger-site" if-key="http.enabled" if-value="false" />

Updated it latest patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50565/#review143990
---


On July 29, 2016, 12:16 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50565/
> ---
> 
> (Updated July 29, 2016, 12:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Nate Cole, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17945
> https://issues.apache.org/jira/browse/AMBARI-17945
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of changes done in this AMBARI-17840, following changes are required 
> to handle EU scenario :
> 
> 1] need to change the owner/mode of stop script and 
> 2] create symbolic link if it does not exists.
> 
> 
> This patch handles the following upgrade scenarios:
> 1) ranger admin from 2.2.x to 2.2.y
> 2) ranger usersync from 2.2.x to 2.3, 2.4
> 3) ranger kms from 2.3 to 2.3.x, 2.4, 2.5
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  c0534f3 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
>  5ce0617 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
>  cbdcc8c 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py
>  55c0486 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  4888aa6 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
> 95310d5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  6e7e272 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  b368db3 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> 9eb4a44 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> e67b82c 
> 
> Diff: https://reviews.apache.org/r/50565/diff/
> 
> 
> Testing
> ---
> 
> Tested EU from
> 2.2 to 2.2
> 2.2 to 2.4
> 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50565: AMBARI-17945 Ranger UserSync restart failed during EU from 2.2.9 to 2.4.2

2016-07-29 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50565/
---

(Updated July 29, 2016, 12:16 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, 
Nate Cole, Srimanth Gunturi, and Velmurugan Periasamy.


Changes
---

Address Jonathan's comments


Bugs: AMBARI-17945
https://issues.apache.org/jira/browse/AMBARI-17945


Repository: ambari


Description
---

As part of changes done in this AMBARI-17840, following changes are required to 
handle EU scenario :

1] need to change the owner/mode of stop script and 
2] create symbolic link if it does not exists.


This patch handles the following upgrade scenarios:
1) ranger admin from 2.2.x to 2.2.y
2) ranger usersync from 2.2.x to 2.3, 2.4
3) ranger kms from 2.3 to 2.3.x, 2.4, 2.5


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 c0534f3 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
 5ce0617 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
 cbdcc8c 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py
 55c0486 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 4888aa6 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/config-upgrade.xml 
95310d5 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
 6e7e272 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
 b368db3 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
9eb4a44 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
e67b82c 

Diff: https://reviews.apache.org/r/50565/diff/


Testing
---

Tested EU from
2.2 to 2.2
2.2 to 2.4
2.4 to 2.5


Thanks,

Mugdha Varadkar

Re: Review Request 50532: AMBARI-17949 : Disable INFO logs from HadoopMetrics2Reporter for hive on upgrade to 2.5

2016-07-29 Thread Dmytro Grinenko 


> On July 29, 2016, 10:26 a.m., Dmytro Grinenko wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java,
> >  line 73
> > 
> >
> > please use regexp, as 
> > log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop   property can 
> > be already defined with different set of values or can be present without 
> > an coment.
> > 
> > 
> > for an example 
> > "^\s*log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop\s*=\s*(.*)$"

^\s*log4j\.logger\.com\.github\.joshelser\.dropwizard\.metrics\.hadoop\s*=\s*(.*)$
 , that nice code formatting on rb


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50532/#review144072
---


On July 28, 2016, 11:07 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50532/
> ---
> 
> (Updated July 28, 2016, 11:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan 
> Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17949
> https://issues.apache.org/jira/browse/AMBARI-17949
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In hive-log4j content, the following needs to be added during HDP upgrades to 
> 2.5.
> 
> # Silence HadoopMetrics2Reporter INFO logs
> log4j.logger.com.github.joshelser.dropwizard.metrics.hadoop=WARN,DRFA
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7197e29 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7a3a19e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  902c421 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 2168868 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/HiveLog4jMetricsActionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50532/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> Tested EU from HDP 2.4 to 2.5.
> Tested RU from HDP 2.3 to 2.5
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 50554: Ambari upgrade reports error upgrading view tables - possibly not an error but confusing

2016-07-29 Thread Ashwin Rajeev 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50554/#review144061
---


Ship it!




Ship It!

- Ashwin Rajeev


On July 28, 2016, 11:37 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50554/
> ---
> 
> (Updated July 28, 2016, 11:37 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Pallav Kulshreshtha, Rohit 
> Choudhary, Sumit Mohanty, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17941
> https://issues.apache.org/jira/browse/AMBARI-17941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> changed the error message and handling
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  a3d9c89 
> 
> Diff: https://reviews.apache.org/r/50554/diff/
> 
> 
> Testing
> ---
> 
> manual testing
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>