date:20161130



> On Nov. 29, 2016, 6:53 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml,
> >  line 32
> > 
> >
> > This property will be added automatically after an Ambari Upgrade with 
> > the value "false". Should this be smarter to detect if Atlas and Storm are 
> > in the cluster and if so then set the value to true?
> 
> Mugdha Varadkar wrote:
> Hi Alejandro,
> Yes there is a way this can be handled in UpgradeCatalog250.java. This 
> fix will is getting handled in 
> https://issues.apache.org/jira/browse/AMBARI-19024
> 
> Alejandro Fernandez wrote:
> Mugdha, a lot of the items I brought up are being deferred to another 
> Jira. In my opinion, they should be done as part of this commit. Typically, 
> it's ok to create another Jira for additional functionality, but not very 
> common to fix more issues with the current patch. Thanks.

Updated in latest patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54169/#review157296
---


On Dec. 1, 2016, 6:59 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54169/
> ---
> 
> (Updated Dec. 1, 2016, 6:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19007
> https://issues.apache.org/jira/browse/AMBARI-19007
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1) Introduced new flag for all the hook suported 
> components(HIVE,STORM,SQOOP,FALCON)under there respective env config-type.
> 2) If ATLAS service is present/selected for install, stack-advisor will set 
> the hook flag. This flag value is used to recommend the expected 
> configuration required for hook to work.
> 3) For Blue-print based installation user need to set hook flag and add 
> common-atlas application properties under each hook config-type eg: 
> hive-atlas-application.properties config-type which are require to 
> communicate with external ATLAS
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
>  a1d2f95 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  ec846f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  52de784 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  09cced6 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  4429253 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  0fb21d0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  150f629 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
>  5e2c709 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  bcc598a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  01e5f00 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  fe3f34a 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml
>  f682e97 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml
>  f7823d2 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
>  283f54d 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
>  68f06db 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml
>  9547335 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  e753e98 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  bda4fe2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
>  ab350dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml
>  b71f4a9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 775dbab 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  f2dd099 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>

Re: Review Request 54169: AMBARI-19007 Atlas to support configuration of hooks from separate cluster


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54169/
---

(Updated Dec. 1, 2016, 6:59 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
and Sumit Mohanty.


Changes
---

Addressed AMBARI-19024(Ambari upgrade scenario) fix in latest patch


Bugs: AMBARI-19007
https://issues.apache.org/jira/browse/AMBARI-19007


Repository: ambari


Description
---

1) Introduced new flag for all the hook suported 
components(HIVE,STORM,SQOOP,FALCON)under there respective env config-type.
2) If ATLAS service is present/selected for install, stack-advisor will set the 
hook flag. This flag value is used to recommend the expected configuration 
required for hook to work.
3) For Blue-print based installation user need to set hook flag and add 
common-atlas application properties under each hook config-type eg: 
hive-atlas-application.properties config-type which are require to communicate 
with external ATLAS


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
 a1d2f95 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 ec846f8 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 52de784 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
 09cced6 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 4429253 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 0fb21d0 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
 150f629 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
 5e2c709 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 bcc598a 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 01e5f00 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
 fe3f34a 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml
 f682e97 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml
 f7823d2 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
 283f54d 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
 68f06db 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml
 9547335 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 e753e98 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
 bda4fe2 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
 ab350dc 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml
 b71f4a9 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
775dbab 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 f2dd099 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 ce0b387 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 39cbbce 

Diff: https://reviews.apache.org/r/54169/diff/


Testing
---

Tested Atlas installation via UI and blue-print. With blueprint used 
config_recommendation_strategy as NEVER_APPLY and 
ALWAYS_APPLY_DONT_OVERRIDE_CUSTOM_VALUES


mvn -DskipPythonTests -Dtest=BlueprintConfigurationProcessorTest test

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessorTest
Tests run: 167, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.101 sec - 
in 
org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessorTest

Results :

Tests run: 167, Failures: 0, Errors: 0, Skipped: 0


[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24.484s
[INFO] Finished at: Tue Nov 29 11:40:30 UTC 2016
[INFO] Final Memory: 62M/797M
[INFO] 


Thanks,

Mugdha Varadkar

Re: Review Request 54244: CAPACITY-SCHEDULER & PIG View not loading for Ambari-2.5.0

2016-11-30 Thread DIPAYAN BHOWMICK



> On Dec. 1, 2016, 6:43 a.m., DIPAYAN BHOWMICK wrote:
> > Ship It!

Applied the patch and build pig and cap-sched view and deployed in local VM. 
The view works after the patch.


- DIPAYAN


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54244/#review157557
---


On Dec. 1, 2016, 6:31 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54244/
> ---
> 
> (Updated Dec. 1, 2016, 6:31 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19043
> https://issues.apache.org/jira/browse/AMBARI-19043
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler and Pig Views are not loading after node upgrade changes 
> in Ambari-2.5.
> This patch fixes the issue in both views.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js fa1e05a 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/app.js 866b8a7 
> 
> Diff: https://reviews.apache.org/r/54244/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 54244: CAPACITY-SCHEDULER & PIG View not loading for Ambari-2.5.0

2016-11-30 Thread DIPAYAN BHOWMICK


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54244/#review157557
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Dec. 1, 2016, 6:31 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54244/
> ---
> 
> (Updated Dec. 1, 2016, 6:31 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19043
> https://issues.apache.org/jira/browse/AMBARI-19043
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Capacity Scheduler and Pig Views are not loading after node upgrade changes 
> in Ambari-2.5.
> This patch fixes the issue in both views.
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js fa1e05a 
>   contrib/views/pig/src/main/resources/ui/pig-web/app/app.js 866b8a7 
> 
> Diff: https://reviews.apache.org/r/54244/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 54239: AMBARI-19042: Ambari-server: OOZIE stack definition changes required to support credential store

2016-11-30 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54239/#review157546
---


Ship it!




Ship It!

- Sumit Mohanty


On Dec. 1, 2016, 2:17 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54239/
> ---
> 
> (Updated Dec. 1, 2016, 2:17 a.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19042
> https://issues.apache.org/jira/browse/AMBARI-19042
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19042: Ambari-server: OOZIE stack definition changes required to 
> support credential store
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/metainfo.xml 
> 027e8b406f35cfbb5b26332b63ee22f3214ac304 
> 
> Diff: https://reviews.apache.org/r/54239/diff/
> 
> 
> Testing
> ---
> 
> ** Manual Testing **
> 
> Deployed a VM with ambari-server JAR from local build and HDP 2.5 
> metainfo.xml for OOZIE. Installed OOZIE and verified that the 
> *servicedesiredstate* table had *credential_store_supported* as 1.
> 
> ambari=> select service_name, credential_store_supported, 
> credential_store_enabled from servicedesiredstate;
>  service_name | credential_store_supported | credential_store_enabled
> --++--
>  ZOOKEEPER|  0 |0
>  HDFS |  0 |0
>  MAPREDUCE2   |  0 |0
>  OOZIE|  1 |0
>  YARN |  0 |0
>  PIG  |  0 |0
>  SLIDER   |  0 |0
>  TEZ  |  0 |0
>  HIVE |  1 |0
> (9 rows)
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled



> On Nov. 30, 2016, 3:07 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java,
> >  lines 142-147
> > 
> >
> > This usage is confusing.  What about using a non-optional 
> > "value-default" attribute (you can use a better name) that you use when the 
> > config value doesn't exist?  That way the author has more direct control 
> > over what's going to happen when the config knob doesn't exist.

I called it "return_value_if_config_missing"


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54145/#review157407
---


On Nov. 30, 2016, 11:54 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54145/
> ---
> 
> (Updated Nov. 30, 2016, 11:54 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Sumit Mohanty, 
> and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19006
> https://issues.apache.org/jira/browse/AMBARI-19006
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Today, the Express Upgrade packs message users to stop YARN queues if they do 
> not have work preserving recovery enabled.
> However, there's no message reminding users to enable it again.
> 
> E.g.,
> ```
> 
>   false
>   true
>   
> 
>   
>  property="yarn.resourcemanager.work-preserving-recovery.enabled" value="true" 
> comparison="not-equal"/>
> 
>   Before continuing, please start all YARN queues if you 
> stopped them in a previous step.
> 
>   
> 
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java
>  1bd88e4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  d824309 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  882e78b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  1d964f8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  fe2598b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  b7d7983 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  ea9c60c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  6597cde 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  414ce15 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  fc4c8c5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  d34d476 
>   ambari-server/src/main/resources/upgrade-pack.xsd 45cf5fa 
> 
> Diff: https://reviews.apache.org/r/54145/diff/
> 
> 
> Testing
> ---
> 
> Tested manually during EU from HDP 2.5 to 2.6
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled



> On Nov. 30, 2016, 12:34 p.m., Tim Thorpe wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml,
> >  line 420
> > 
> >
> > Duplicates?
> > With this section, do you really need the following section as well:
> > 
> > 
> >   UPGRADE
> >> title="Start YARN Queues">
> > 
> >   Please start previously stopped YARN 
> > queues.

Removed it from all files. Good catch.


> On Nov. 30, 2016, 12:34 p.m., Tim Thorpe wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java,
> >  line 153
> > 
> >
> > Usually the return value for EQUALS != NOT_EQUALS.  In this case if the 
> > property doesn't exist the return values will be the same.
> > 
> > For NOT_EQUALS, there are really 2 cases.  The obvious one where the 
> > property exists and the more difficult one where the property doesn't 
> > exist.  When the property doesn't exist, it would be much better if we 
> > could provide a default value to compare.
> > 
> >  > property="yarn.resourcemanager.work-preserving-recovery.enabled" 
> > value="true" comparison="not-equals" default="false"/>

I added return_value_if_config_missing so that the user has more control on the 
behavior.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54145/#review157398
---


On Nov. 30, 2016, 11:54 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54145/
> ---
> 
> (Updated Nov. 30, 2016, 11:54 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Sumit Mohanty, 
> and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19006
> https://issues.apache.org/jira/browse/AMBARI-19006
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Today, the Express Upgrade packs message users to stop YARN queues if they do 
> not have work preserving recovery enabled.
> However, there's no message reminding users to enable it again.
> 
> E.g.,
> ```
> 
>   false
>   true
>   
> 
>   
>  property="yarn.resourcemanager.work-preserving-recovery.enabled" value="true" 
> comparison="not-equal"/>
> 
>   Before continuing, please start all YARN queues if you 
> stopped them in a previous step.
> 
>   
> 
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java
>  1bd88e4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  d824309 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  882e78b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  1d964f8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  fe2598b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  b7d7983 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  ea9c60c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  6597cde 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  414ce15 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  fc4c8c5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  d34d476 
>   ambari-server/src/main/resources/upgrade-pack.xsd 45cf5fa 
> 
> Diff: https://reviews.apache.org/r/54145/diff/
> 
> 
> Testing
> ---
> 
> Tested manually during EU from HDP 2.5 to 2.6
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 54231: Deployment failing at creating principal [addendum]

2016-11-30 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157496
---


Ship it!




Ship It!

- Sumit Mohanty


On Nov. 30, 2016, 11:32 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> ---
> 
> (Updated Nov. 30, 2016, 11:32 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster deployment via blueprint failed at creating principals
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 77d3a4d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  9be8751 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
>  2f756fb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
>  99f47c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
>  4c40a5d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
>  34ac91f 
> 
> Diff: https://reviews.apache.org/r/54231/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 54231: Deployment failing at creating principal [addendum]

2016-11-30 Thread Mahadev Konar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157490
---



/home/crashtua/dev/ambari-work/usr/lib/python2.6/site-packages/ambari_server/setupAgent.py`
 |  this looks wrong no?

- Mahadev Konar


On Nov. 30, 2016, 10:04 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> ---
> 
> (Updated Nov. 30, 2016, 10:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster deployment via blueprint failed at creating principals
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 77d3a4d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  9be8751 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
>  2f756fb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
>  99f47c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
>  4c40a5d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
>  34ac91f 
> 
> Diff: https://reviews.apache.org/r/54231/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 54208: Log Search: Cannot increase the number of shards per node for solr collections

2016-11-30 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54208/#review157486
---


Fix it, then Ship it!





ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
 (line 237)


If you assume that slices isn't null, then there is no point to check if 
it's not empty, you may as well iterate over an empty collection too, the 
result would be the same. I suggest to remove this line to have less levels.


- Miklos Gergely


On Nov. 30, 2016, 5:15 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54208/
> ---
> 
> (Updated Nov. 30, 2016, 5:15 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-19033
> https://issues.apache.org/jira/browse/AMBARI-19033
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case of in logsearch.properties, the number of shards changes -> it cannot 
> create new shards per cores, because there is a maxShardsPerCore property is 
> set in zk config. To change that we need to use MODIFYCOLLECTION http call 
> against any solr server on solr cloud.
> 
> solr4j client library does not support MODIFYCOLLECTION action on 
> collections, so i had to implement the behaviour through a simple http call. 
> (HttpCleintUtil is used, so it should work with ssl and kerberos as well)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
>  834ba38 
> 
> Diff: https://reviews.apache.org/r/54208/diff/
> 
> 
> Testing
> ---
> 
> testing done (manually increase the number of shards with  changing the 
> logsearch.properties)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-11-30 Thread Nahappan Somasundaram


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/
---

(Updated Nov. 30, 2016, 2:09 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and Sumit 
Mohanty.


Changes
---

Fixed the following code reviews:
1. Use credential_lib_dir
2. Use conf_dir from conf_select to get the location of the JCEKS file
3. Check for null in EC::service before setting credentialStoreEnabled
4. Use config.get(section, key, default)


Bugs: AMBARI-1
https://issues.apache.org/jira/browse/AMBARI-1


Repository: ambari


Description
---

AMBARI-1: Ambari-agent: Create configuration files with JCEKS information


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 
61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
ebd350652309f3be2b5b6f54e28f99624607dba0 
  ambari-agent/src/packages/tarball/all.xml 
c4812087976f9ec38c20d92c20747eb8988d8290 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 29737ee5a5631b33a41323d3b059ec95fc2804bf 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 a25b875cecb6e6b59990e665d6464eb58a1bb352 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 

Diff: https://reviews.apache.org/r/53747/diff/


Testing
---

** 1. mvn clean install -DskipTests **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.433s]
[INFO] Apache Ambari Project POM . SUCCESS [0.040s]
[INFO] Ambari Web  SUCCESS [1:11.223s]
[INFO] Ambari Views .. SUCCESS [1.128s]
[INFO] Ambari Admin View . SUCCESS [6.366s]
[INFO] utility ... SUCCESS [0.359s]
[INFO] ambari-metrics  SUCCESS [0.721s]
[INFO] Ambari Metrics Common . SUCCESS [6.490s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
[INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
[INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
[INFO] Ambari Server . SUCCESS [2:28.842s]
[INFO] Ambari Functional Tests ... SUCCESS [1.071s]
[INFO] Ambari Agent .. SUCCESS [25.738s]
[INFO] Ambari Client . SUCCESS [0.050s]
[INFO] Ambari Python Client .. SUCCESS [0.945s]
[INFO] Ambari Groovy Client .. SUCCESS [1.984s]
[INFO] Ambari Shell .. SUCCESS [0.035s]
[INFO] Ambari Python Shell ... SUCCESS [0.653s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
[INFO] ambari-logsearch .. SUCCESS [0.299s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
[INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
[INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.091s]
[INFO] Ambari Logsearch Integration Test . SUCCESS [0.372s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:23.315s
[INFO] Finished at: Mon Nov 14 13:44:45 PST 2016
[INFO] Final Memory: 327M/1187M
[INFO] 

** 2. mvn test -DskipPythonTests -Dtest=*ExecutionCommand*,*HeartBeatHandler* **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.actionmanager.ExecutionCommandWrapperTest
Tests run: 2, Failures: 0,

Re: Review Request 54231: Deployment failing at creating principal [addendum]

2016-11-30 Thread Robert Levas



> On Nov. 30, 2016, 5:05 p.m., Robert Nettleton wrote:
> > Ship It!
> 
> Robert Nettleton wrote:
> Sorry, my "Ship It" was based on the SQL patch.

doh... thanks for the quick response though... it was just too quick. ;)


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157480
---


On Nov. 30, 2016, 5:04 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> ---
> 
> (Updated Nov. 30, 2016, 5:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster deployment via blueprint failed at creating principals
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 77d3a4d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  9be8751 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
>  2f756fb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
>  99f47c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
>  4c40a5d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
>  34ac91f 
> 
> Diff: https://reviews.apache.org/r/54231/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 54231: Deployment failing at creating principal [addendum]

2016-11-30 Thread Robert Nettleton



> On Nov. 30, 2016, 10:05 p.m., Robert Nettleton wrote:
> > Ship It!

Sorry, my "Ship It" was based on the SQL patch.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157480
---


On Nov. 30, 2016, 10:04 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> ---
> 
> (Updated Nov. 30, 2016, 10:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster deployment via blueprint failed at creating principals
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 77d3a4d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  9be8751 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
>  2f756fb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
>  99f47c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
>  4c40a5d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
>  34ac91f 
> 
> Diff: https://reviews.apache.org/r/54231/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 54231: Deployment failing at creating principal [addendum]

2016-11-30 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/#review157480
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 30, 2016, 10:04 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54231/
> ---
> 
> (Updated Nov. 30, 2016, 10:04 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18755
> https://issues.apache.org/jira/browse/AMBARI-18755
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster deployment via blueprint failed at creating principals
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 77d3a4d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  9be8751 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
>  2f756fb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
>  99f47c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
>  4c40a5d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
>  34ac91f 
> 
> Diff: https://reviews.apache.org/r/54231/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 54231: Deployment failing at creating principal [addendum]

2016-11-30 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/
---

(Updated Nov. 30, 2016, 5:04 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.


Changes
---

Originally uploaded wrong patch... this is the correct patch.


Bugs: AMBARI-18755
https://issues.apache.org/jira/browse/AMBARI-18755


Repository: ambari


Description
---

Cluster deployment via blueprint failed at creating principals


Diffs (updated)
-

  ambari-server/docs/configuration/index.md 77d3a4d 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 9be8751 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
 2f756fb 
  
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
 99f47c5 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
 4c40a5d 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
 34ac91f 

Diff: https://reviews.apache.org/r/54231/diff/


Testing
---

Manually tested


Thanks,

Robert Levas

Review Request 54231: Deployment failing at creating principal [addendum]

2016-11-30 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54231/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-18755
https://issues.apache.org/jira/browse/AMBARI-18755


Repository: ambari


Description
---

Cluster deployment via blueprint failed at creating principals


Diffs
-

  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4ba371a 

Diff: https://reviews.apache.org/r/54231/diff/


Testing
---

Manually tested


Thanks,

Robert Levas

Re: Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

2016-11-30 Thread Attila Doroszlai



> On Nov. 30, 2016, 10:25 p.m., Sid Wagle wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java,
> >  line 130
> > 
> >
> > Line length too long, generally Ambari codebase has too many violations 
> > to count but can you retrict to something like 200 chars for consistency?
> 
> Sid Wagle wrote:
> Or 120.

Done.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53977/#review157468
---


On Nov. 30, 2016, 10:42 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53977/
> ---
> 
> (Updated Nov. 30, 2016, 10:42 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Oliver 
> Szabo, Sandor Magyari, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18956
> https://issues.apache.org/jira/browse/AMBARI-18956
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> `EntityTransaction` may be marked 
> [rollback-only](http://docs.oracle.com/javaee/6/api/javax/persistence/EntityTransaction.html#setRollbackOnly())
>  due to exception.  If `@Transactional` is not marked to `rollbackOn` such 
> exception, Ambari still attempts to commit the transaction.  The end result 
> for the transaction is the same (rollback), but instead of the original 
> exception a `RollbackException` is reported, so information is lost.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptor.java
>  d7ba463 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53977/diff/
> 
> 
> Testing
> ---
> 
> * Added unit test
> * Tested on live cluster by triggering the downscale problem
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

2016-11-30 Thread Attila Doroszlai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53977/
---

(Updated Nov. 30, 2016, 10:42 p.m.)


Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Oliver Szabo, 
Sandor Magyari, Sebastian Toader, and Sid Wagle.


Changes
---

Limit line length


Bugs: AMBARI-18956
https://issues.apache.org/jira/browse/AMBARI-18956


Repository: ambari


Description
---

`EntityTransaction` may be marked 
[rollback-only](http://docs.oracle.com/javaee/6/api/javax/persistence/EntityTransaction.html#setRollbackOnly())
 due to exception.  If `@Transactional` is not marked to `rollbackOn` such 
exception, Ambari still attempts to commit the transaction.  The end result for 
the transaction is the same (rollback), but instead of the original exception a 
`RollbackException` is reported, so information is lost.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptor.java
 d7ba463 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/53977/diff/


Testing
---

* Added unit test
* Tested on live cluster by triggering the downscale problem


Thanks,

Attila Doroszlai

Re: Review Request 54207: HDFS Metric alerts turns to UNKNOWN state with error "'NoneType' object has no attribute 'split'"

2016-11-30 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54207/
---

(Updated Ноя. 30, 2016, 9:31 п.п.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-19032
https://issues.apache.org/jira/browse/AMBARI-19032


Repository: ambari


Description
---

HDFS Metric alerts turns to UNKNOWN state with error "'NoneType' object has no 
attribute 'split'".
STR:
Update the alert definition interval to 1 min, and thresholds to have minimum 
values to trigger the Alert.


Diffs (updated)
-

  ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 2eb0b6d 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 769d0c1 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/AbstractTimelineMetricSinkTest.java
 5e016f8 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 2bfc6db 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
 e00c1f5 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
 008e9d6 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 1f32c41 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
 4efdae5 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 0cb88fe 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 e753e98 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 4603c8b 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py
 7cd9340 

Diff: https://reviews.apache.org/r/54207/diff/


Testing
---

Unit tests passed.


Thanks,

Dmytro Sen

Re: Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

2016-11-30 Thread Sid Wagle



> On Nov. 30, 2016, 9:25 p.m., Sid Wagle wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java,
> >  line 130
> > 
> >
> > Line length too long, generally Ambari codebase has too many violations 
> > to count but can you retrict to something like 200 chars for consistency?

Or 120.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53977/#review157468
---


On Nov. 29, 2016, 7:19 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53977/
> ---
> 
> (Updated Nov. 29, 2016, 7:19 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Oliver 
> Szabo, Sandor Magyari, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18956
> https://issues.apache.org/jira/browse/AMBARI-18956
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> `EntityTransaction` may be marked 
> [rollback-only](http://docs.oracle.com/javaee/6/api/javax/persistence/EntityTransaction.html#setRollbackOnly())
>  due to exception.  If `@Transactional` is not marked to `rollbackOn` such 
> exception, Ambari still attempts to commit the transaction.  The end result 
> for the transaction is the same (rollback), but instead of the original 
> exception a `RollbackException` is reported, so information is lost.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptor.java
>  d7ba463 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53977/diff/
> 
> 
> Testing
> ---
> 
> * Added unit test
> * Tested on live cluster by triggering the downscale problem
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

2016-11-30 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53977/#review157468
---


Ship it!





ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java
 (line 130)


Line length too long, generally Ambari codebase has too many violations to 
count but can you retrict to something like 200 chars for consistency?


- Sid Wagle


On Nov. 29, 2016, 7:19 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53977/
> ---
> 
> (Updated Nov. 29, 2016, 7:19 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Oliver 
> Szabo, Sandor Magyari, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18956
> https://issues.apache.org/jira/browse/AMBARI-18956
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> `EntityTransaction` may be marked 
> [rollback-only](http://docs.oracle.com/javaee/6/api/javax/persistence/EntityTransaction.html#setRollbackOnly())
>  due to exception.  If `@Transactional` is not marked to `rollbackOn` such 
> exception, Ambari still attempts to commit the transaction.  The end result 
> for the transaction is the same (rollback), but instead of the original 
> exception a `RollbackException` is reported, so information is lost.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptor.java
>  d7ba463 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53977/diff/
> 
> 
> Testing
> ---
> 
> * Added unit test
> * Tested on live cluster by triggering the downscale problem
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 53977: Ambari attempts to commit transactions marked as rollback-only

2016-11-30 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53977/#review157466
---


Ship it!




Ship It!

- Oliver Szabo


On Nov. 29, 2016, 7:19 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53977/
> ---
> 
> (Updated Nov. 29, 2016, 7:19 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Oliver 
> Szabo, Sandor Magyari, Sebastian Toader, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18956
> https://issues.apache.org/jira/browse/AMBARI-18956
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> `EntityTransaction` may be marked 
> [rollback-only](http://docs.oracle.com/javaee/6/api/javax/persistence/EntityTransaction.html#setRollbackOnly())
>  due to exception.  If `@Transactional` is not marked to `rollbackOn` such 
> exception, Ambari still attempts to commit the transaction.  The end result 
> for the transaction is the same (rollback), but instead of the original 
> exception a `RollbackException` is reported, so information is lost.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptor.java
>  d7ba463 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53977/diff/
> 
> 
> Testing
> ---
> 
> * Added unit test
> * Tested on live cluster by triggering the downscale problem
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 54122: AMBARI-18994 In HA cluster copy the hdfs-site.xml and hbase-site.xml to Ranger conf directory

2016-11-30 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54122/#review157465
---


Ship it!




Ship It!

- Sumit Mohanty


On Nov. 28, 2016, 1:10 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54122/
> ---
> 
> (Updated Nov. 28, 2016, 1:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Vishal Suvagia, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18994
> https://issues.apache.org/jira/browse/AMBARI-18994
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In present , for HA cluster we have to symlink hbase-site.xml and 
> hdfs-site.xml to the /etc/ranger/admin/conf to Test connection be successful 
> in HDFS and HBASE Repo.
> Actually the better approach is copying these files to /etc/ranger/admin/conf 
> as all the services might be running in different nodes.
> and it is better if it done while enabling corresponding plugin itself.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  6debaf1 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  f1b4797 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
> f330bc9 
> 
> Diff: https://reviews.apache.org/r/54122/diff/
> 
> 
> Testing
> ---
> 
> Running tests for stack:2.5 service:RANGER
> test_configure_default (test_ranger_admin.TestRangerAdmin) ... 2016-11-28 
> 18:32:51,664 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_configure_secured (test_ranger_admin.TestRangerAdmin) ... 2016-11-28 
> 18:32:51,694 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_start_default (test_ranger_admin.TestRangerAdmin) ... 2016-11-28 
> 18:32:51,730 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_start_secured (test_ranger_admin.TestRangerAdmin) ... 2016-11-28 
> 18:32:51,769 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_stop_default (test_ranger_admin.TestRangerAdmin) ... 2016-11-28 
> 18:32:51,808 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54175/#review157463
---


Ship it!




Ship It!

- Nate Cole


On Nov. 30, 2016, 3:08 p.m., Duc Le wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54175/
> ---
> 
> (Updated Nov. 30, 2016, 3:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-19020
> https://issues.apache.org/jira/browse/AMBARI-19020
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.6/metainfo.xml 
> 525078e 
> 
> Diff: https://reviews.apache.org/r/54175/diff/
> 
> 
> Testing
> ---
> 
> Manifest change only. Unit test not affected. Tested E2E.
> 
> 
> Thanks,
> 
> Duc Le
> 
>

Re: Review Request 54207: HDFS Metric alerts turns to UNKNOWN state with error "'NoneType' object has no attribute 'split'"

2016-11-30 Thread Aravindan Vijayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54207/#review157456
---




ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py (line 31)


Do we need an empty check for "all_collectors_string" here ?


- Aravindan Vijayan


On Nov. 30, 2016, 4:32 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54207/
> ---
> 
> (Updated Nov. 30, 2016, 4:32 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-19032
> https://issues.apache.org/jira/browse/AMBARI-19032
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS Metric alerts turns to UNKNOWN state with error "'NoneType' object has 
> no attribute 'split'".
> STR:
> Update the alert definition interval to 1 min, and thresholds to have minimum 
> values to trigger the Alert.
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 
> 7b4e8f5 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  769d0c1 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/AbstractTimelineMetricSinkTest.java
>  5e016f8 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  802e684 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  e00c1f5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  e278d0d 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
>  008e9d6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  1f32c41 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
>  4efdae5 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  01e5f00 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  0cb88fe 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  e753e98 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  4603c8b 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py
>  7cd9340 
> 
> Diff: https://reviews.apache.org/r/54207/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5

2016-11-30 Thread Duc Le


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54175/
---

(Updated Nov. 30, 2016, 8:08 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Changes
---

Added Ubuntu 14/16 to common-services


Bugs: AMBARI-19020
https://issues.apache.org/jira/browse/AMBARI-19020


Repository: ambari


Description
---

AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.6/metainfo.xml 
525078e 

Diff: https://reviews.apache.org/r/54175/diff/


Testing
---

Manifest change only. Unit test not affected. Tested E2E.


Thanks,

Duc Le

Re: Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5



> On Nov. 30, 2016, 2:54 p.m., Nate Cole wrote:
> > This commit had to be reverted - it's breaking centos and suse deployments. 
> >  You either have to put the changes in common-services or add the other 
> > OSes in the stack file.
> 
> Duc Le wrote:
> Is putting in common-services the preferred option?

Other services do it in common-services, so I would say do it there and leave 
the stack file alone.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54175/#review157453
---


On Nov. 29, 2016, 3:11 p.m., Duc Le wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54175/
> ---
> 
> (Updated Nov. 29, 2016, 3:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-19020
> https://issues.apache.org/jira/browse/AMBARI-19020
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZOOKEEPER/metainfo.xml
>  de8ebd9 
> 
> Diff: https://reviews.apache.org/r/54175/diff/
> 
> 
> Testing
> ---
> 
> Manifest change only. Unit test not affected. Tested E2E.
> 
> 
> Thanks,
> 
> Duc Le
> 
>

Re: Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5

2016-11-30 Thread Duc Le



> On Nov. 30, 2016, 7:54 p.m., Nate Cole wrote:
> > This commit had to be reverted - it's breaking centos and suse deployments. 
> >  You either have to put the changes in common-services or add the other 
> > OSes in the stack file.

Is putting in common-services the preferred option?


- Duc


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54175/#review157453
---


On Nov. 29, 2016, 8:11 p.m., Duc Le wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54175/
> ---
> 
> (Updated Nov. 29, 2016, 8:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-19020
> https://issues.apache.org/jira/browse/AMBARI-19020
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZOOKEEPER/metainfo.xml
>  de8ebd9 
> 
> Diff: https://reviews.apache.org/r/54175/diff/
> 
> 
> Testing
> ---
> 
> Manifest change only. Unit test not affected. Tested E2E.
> 
> 
> Thanks,
> 
> Duc Le
> 
>

Re: Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54175/#review157453
---



This commit had to be reverted - it's breaking centos and suse deployments.  
You either have to put the changes in common-services or add the other OSes in 
the stack file.

- Nate Cole


On Nov. 29, 2016, 3:11 p.m., Duc Le wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54175/
> ---
> 
> (Updated Nov. 29, 2016, 3:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-19020
> https://issues.apache.org/jira/browse/AMBARI-19020
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZOOKEEPER/metainfo.xml
>  de8ebd9 
> 
> Diff: https://reviews.apache.org/r/54175/diff/
> 
> 
> Testing
> ---
> 
> Manifest change only. Unit test not affected. Tested E2E.
> 
> 
> Thanks,
> 
> Duc Le
> 
>

Re: Review Request 54189: After adding an Atlas server the first restart command fails since stop doesn't have any configs; if no pid dir exists during stop, perform no-op



> On Nov. 30, 2016, 10:27 a.m., Mugdha Varadkar wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py,
> >  line 139
> > 
> >
> > Considering scenario 2 in your description, shouldn't the pid property 
> > be editable only at installation ?
> > 
> > As per my knowledge : Whenever a service is installed it will first 
> > trigger the start call  and then user have option to restart. 
> > Is there any way user can trigger restart after install ?

The UI allows both a Start (assuming no other Atlas Servers are up) and a 
Restart (assuming at least one Atlas Server is up).
Because Ambari is idempotent, the "restart" command should still be allowed 
immediately after adding a new Atlas Server instance. However, at that point, 
the pid dir does not exist, so a stop command is bound to fail since configs 
have never been written out. For this reason, I check the existence of the pid 
dir and perform a no-op if it doesn't exist.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54189/#review157393
---


On Nov. 30, 2016, 1:15 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54189/
> ---
> 
> (Updated Nov. 30, 2016, 1:15 a.m.)
> 
> 
> Review request for Ambari, Mugdha Varadkar, Sumit Mohanty, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-19023
> https://issues.apache.org/jira/browse/AMBARI-19023
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Whenever adding an Atlas Server on a host, if the user executes the first 
> command as a "restart" (stop+start) instead of a "start" command, then the 
> stop command will fail because Ambari will not have generated any configs yet 
> so Atlas' atlas_stop.py will fail.
> 
> To fix it, during a stop command,
> If the pid dir doesn't exist, this means either
> 1. The user just added Atlas service and issued a restart command 
> (stop+start). So stop should be a no-op since there's nothing to stop because 
> the pid dir does not exist.
> 
> OR
> 
> 2. The user changed the value of the pid dir config and incorrectly issued a 
> restart command.
> In which case the stop command cannot do anything since Ambari doesn't know 
> which process to kill.
> The start command will spawn another instance.
> The user should have issued a stop, changed the config, and then started it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  a469ebb 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> 585dc94 
> 
> Diff: https://reviews.apache.org/r/54189/diff/
> 
> 
> Testing
> ---
> 
> Verified on a life cluster.
> 
> Python unit tests passed.
> --
> Total run:1166
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 54224: Upgrade History Displays Wrong Upgrade Type


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54224/#review157444
---


Ship it!




Ship It!

- Alejandro Fernandez


On Nov. 30, 2016, 7:25 p.m., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54224/
> ---
> 
> (Updated Nov. 30, 2016, 7:25 p.m.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19034
> https://issues.apache.org/jira/browse/AMBARI-19034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Perform a HOST_ORDERED upgrade. After the upgrade has completed, navigate to 
> the "Upgrade History". The type of upgrade displayed is "Rolling".
> Additionally, when clicking on the upgrade, it shows as "HOST_ORDERED" 
> instead of "Host Ordered"
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> 3a78e30 
>   ambari-web/app/mappers/stack_upgrade_history_mapper.js 63088a7 
>   ambari-web/app/messages.js a16d0ea 
>   ambari-web/app/models/stack_version/stack_upgrade_history.js d4a89dc 
>   ambari-web/app/styles/stack_versions.less f67e03e 
>   
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_details_view.js 
> 983c26a 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 
> 31e1478 
> 
> Diff: https://reviews.apache.org/r/54224/diff/
> 
> 
> Testing
> ---
> 
> 20020 tests complete (27 seconds)
>   155 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Re: Review Request 54224: Upgrade History Displays Wrong Upgrade Type

2016-11-30 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54224/#review157449
---




ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js (line 294)


var displayName = type ? type.get('displayName') : 
record.get('upgradeType');

Should still try to normalize the name, so that "FUTURE_UPGRADE_TYPE" can 
be converted to "Future Upgrade Type"


- Di Li


On Nov. 30, 2016, 7:25 p.m., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54224/
> ---
> 
> (Updated Nov. 30, 2016, 7:25 p.m.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19034
> https://issues.apache.org/jira/browse/AMBARI-19034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Perform a HOST_ORDERED upgrade. After the upgrade has completed, navigate to 
> the "Upgrade History". The type of upgrade displayed is "Rolling".
> Additionally, when clicking on the upgrade, it shows as "HOST_ORDERED" 
> instead of "Host Ordered"
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> 3a78e30 
>   ambari-web/app/mappers/stack_upgrade_history_mapper.js 63088a7 
>   ambari-web/app/messages.js a16d0ea 
>   ambari-web/app/models/stack_version/stack_upgrade_history.js d4a89dc 
>   ambari-web/app/styles/stack_versions.less f67e03e 
>   
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_details_view.js 
> 983c26a 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 
> 31e1478 
> 
> Diff: https://reviews.apache.org/r/54224/diff/
> 
> 
> Testing
> ---
> 
> 20020 tests complete (27 seconds)
>   155 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Re: Review Request 54169: AMBARI-19007 Atlas to support configuration of hooks from separate cluster



> On Nov. 29, 2016, 6:53 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml,
> >  line 32
> > 
> >
> > This property will be added automatically after an Ambari Upgrade with 
> > the value "false". Should this be smarter to detect if Atlas and Storm are 
> > in the cluster and if so then set the value to true?
> 
> Mugdha Varadkar wrote:
> Hi Alejandro,
> Yes there is a way this can be handled in UpgradeCatalog250.java. This 
> fix will is getting handled in 
> https://issues.apache.org/jira/browse/AMBARI-19024

Mugdha, a lot of the items I brought up are being deferred to another Jira. In 
my opinion, they should be done as part of this commit. Typically, it's ok to 
create another Jira for additional functionality, but not very common to fix 
more issues with the current patch. Thanks.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54169/#review157296
---


On Nov. 29, 2016, 5:42 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54169/
> ---
> 
> (Updated Nov. 29, 2016, 5:42 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19007
> https://issues.apache.org/jira/browse/AMBARI-19007
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1) Introduced new flag for all the hook suported 
> components(HIVE,STORM,SQOOP,FALCON)under there respective env config-type.
> 2) If ATLAS service is present/selected for install, stack-advisor will set 
> the hook flag. This flag value is used to recommend the expected 
> configuration required for hook to work.
> 3) For Blue-print based installation user need to set hook flag and add 
> common-atlas application properties under each hook config-type eg: 
> hive-atlas-application.properties config-type which are require to 
> communicate with external ATLAS
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
>  a1d2f95 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  ec846f8 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
>  09cced6 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  4429253 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  0fb21d0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  150f629 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
>  5e2c709 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  bcc598a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  01e5f00 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  fe3f34a 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-env.xml
>  f682e97 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml
>  f7823d2 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
>  283f54d 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
>  68f06db 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml
>  9547335 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  e753e98 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  bda4fe2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
>  ab350dc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml
>  b71f4a9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 775dbab 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  f2dd099 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 39cbbce 
> 
> Diff: https://reviews.apache.org/r/54169/diff/
> 
> 
> Testing
> ---
> 
> Tested Atlas installation via UI and blue-print. With blueprint used 
>

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information



> On Nov. 30, 2016, 10:13 a.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, 
> > lines 203-204
> > 
> >
> > Would still prefer keytool over a custom class.  What did you find in 
> > your investigation why we couldn't use it?  It feels really really dirty to 
> > required a hadoop library to build the agent.
> 
> Nahappan Somasundaram wrote:
> Unfortunately Java keytool cannot be use for storing credentials, only 
> PKI pairs. We have to use the CredentialShell class for this purpose.

Bummer :(


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53747/#review157408
---


On Nov. 29, 2016, 11:29 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53747/
> ---
> 
> (Updated Nov. 29, 2016, 11:29 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-1: Ambari-agent: Create configuration files with JCEKS information
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 
> 61948d4b1f5db37f0c9800a01187ede2cb8f92f2 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> ebd350652309f3be2b5b6f54e28f99624607dba0 
>   ambari-agent/src/packages/tarball/all.xml 
> c4812087976f9ec38c20d92c20747eb8988d8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  29737ee5a5631b33a41323d3b059ec95fc2804bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  a25b875cecb6e6b59990e665d6464eb58a1bb352 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  a50a1162a4b1ee6604e641a1a21ecf3f15fe96fa 
> 
> Diff: https://reviews.apache.org/r/53747/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.433s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.040s]
> [INFO] Ambari Web  SUCCESS [1:11.223s]
> [INFO] Ambari Views .. SUCCESS [1.128s]
> [INFO] Ambari Admin View . SUCCESS [6.366s]
> [INFO] utility ... SUCCESS [0.359s]
> [INFO] ambari-metrics  SUCCESS [0.721s]
> [INFO] Ambari Metrics Common . SUCCESS [6.490s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.222s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.221s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.192s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.991s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.501s]
> [INFO] Ambari Metrics Collector .. SUCCESS [9.142s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.627s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.828s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:13.892s]
> [INFO] Ambari Server . SUCCESS [2:28.842s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.071s]
> [INFO] Ambari Agent .. SUCCESS [25.738s]
> [INFO] Ambari Client . SUCCESS [0.050s]
> [INFO] Ambari Python Client .. SUCCESS [0.945s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.984s]
> [INFO] Ambari Shell .. SUCCESS [0.035s]
> [INFO] Ambari Python Shell ... SUCCESS [0.653s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.782s]
> [INFO] ambari-logsearch .. SUCCESS [0.299s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.200s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.170s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.326s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.665s]
> [INFO] Ambari Logsearch Assembly . SUCCESS

Re: Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54175/#review157445
---



This has been pushed to trunk and branch-2.5.  The feature branch is no longer 
available, and we won't be porting to branch-2.4 at this time.

- Nate Cole


On Nov. 29, 2016, 3:11 p.m., Duc Le wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54175/
> ---
> 
> (Updated Nov. 29, 2016, 3:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-19020
> https://issues.apache.org/jira/browse/AMBARI-19020
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZOOKEEPER/metainfo.xml
>  de8ebd9 
> 
> Diff: https://reviews.apache.org/r/54175/diff/
> 
> 
> Testing
> ---
> 
> Manifest change only. Unit test not affected. Tested E2E.
> 
> 
> Thanks,
> 
> Duc Le
> 
>

Review Request 54224: Upgrade History Displays Wrong Upgrade Type

2016-11-30 Thread Andrii Tkach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54224/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19034
https://issues.apache.org/jira/browse/AMBARI-19034


Repository: ambari


Description
---

Perform a HOST_ORDERED upgrade. After the upgrade has completed, navigate to 
the "Upgrade History". The type of upgrade displayed is "Rolling".
Additionally, when clicking on the upgrade, it shows as "HOST_ORDERED" instead 
of "Host Ordered"


Diffs
-

  ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
3a78e30 
  ambari-web/app/mappers/stack_upgrade_history_mapper.js 63088a7 
  ambari-web/app/messages.js a16d0ea 
  ambari-web/app/models/stack_version/stack_upgrade_history.js d4a89dc 
  ambari-web/app/styles/stack_versions.less f67e03e 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_details_view.js 
983c26a 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 31e1478 

Diff: https://reviews.apache.org/r/54224/diff/


Testing
---

20020 tests complete (27 seconds)
  155 tests pending


Thanks,

Andrii Tkach

Re: Review Request 54031: Remove Zeppelin View from Ambari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54031/#review157443
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 (line 183)


Do these tables also need to delete the record?

viewinstancedata, viewinstanceproperty, viewparameter, viewresource, 
viewentity


- Alejandro Fernandez


On Nov. 30, 2016, 9:46 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54031/
> ---
> 
> (Updated Nov. 30, 2016, 9:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18975
> https://issues.apache.org/jira/browse/AMBARI-18975
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> details in the jira ticket
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  52de784 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  4135919 
>   contrib/views/pom.xml ca5aef4 
>   contrib/views/zeppelin/pom.xml 6a7f585 
>   
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java
>  8f94260 
>   
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java
>  ab61a3d 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml 6b2d156 
>   contrib/views/zeppelin/src/main/resources/view.log4j.properties 15d264e 
>   contrib/views/zeppelin/src/main/resources/view.xml 323e09a 
> 
> Diff: https://reviews.apache.org/r/54031/diff/
> 
> 
> Testing
> ---
> 
> manually tested
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 54195: AMBARI-18780. Fix livy configuration upgrade from HDP 2.5 to HDP 2.6


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54195/#review157442
---


Ship it!




Ship It!

- Alejandro Fernandez


On Nov. 30, 2016, 4 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54195/
> ---
> 
> (Updated Nov. 30, 2016, 4 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18780
> https://issues.apache.org/jira/browse/AMBARI-18780
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix upgrade from HDP 2.5 to 2.6 for non-rolling and rolling upgrade
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 87ede63 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  fc4c8c5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> eb4309a 
> 
> Diff: https://reviews.apache.org/r/54195/diff/
> 
> 
> Testing
> ---
> 
> I have tested non-rolling upgrade, but fails with non-rolling upgrade. Here's 
> the error I get. 
> 
> 2016-11-29 11:07:56,332 - Could not determine stack version for component 
> hadoop-hdfs-zkfc by calling '/usr/bin/hdp-select status hadoop-hdfs-zkfc > 
> /tmp/tmpcguSMN'. Return Code: 1, Output: ERROR: Invalid package - 
> hadoop-hdfs-zkfc
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/#review157441
---


Ship it!




Ship It!

- Alejandro Fernandez


On Nov. 29, 2016, 3:56 a.m., Weiwei Yang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54121/
> ---
> 
> (Updated Nov. 29, 2016, 3:56 a.m.)
> 
> 
> Review request for Ambari and Di Li.
> 
> 
> Bugs: AMBARI-18929
> https://issues.apache.org/jira/browse/AMBARI-18929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Improve the logic of yarn service check, let it work as long as active RM is 
> working fine
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  c0bd480 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py 
> bb671aa 
> 
> Diff: https://reviews.apache.org/r/54121/diff/
> 
> 
> Testing
> ---
> 
> HA environment
>  1. Both active & standby RMs are up : SUCCESS
>  2. Shutdown standby RM, active remains up : SUCCESS
>  3. Shutdown active RM, active transited to the other RM : SUCCESS
>  4. Shutdown zookeeper, both RMs are standby : FAIL
>  5. Both RMs are down : FAIL
> 
> Non-HA environment
>  1. RM is up : SUCCESS
>  2. RM is down : FAIL
> 
> 
> Thanks,
> 
> Weiwei Yang
> 
>

Re: Review Request 53727: Provide SSL related configurations for Ranger-Tagsync.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53727/#review157439
---




ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 (line 525)


Can this be added to its own function?



ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/configuration/ranger-tagsync-site.xml
 (line 23)


EU/RU will have to change this value for existing clusters. Please edit all 
of the upgrade packs from HDP 2.4/2.5 -> 2.6 for EU and RU.


- Alejandro Fernandez


On Nov. 17, 2016, 2:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53727/
> ---
> 
> (Updated Nov. 17, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, Mugdha Varadkar, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18874
> https://issues.apache.org/jira/browse/AMBARI-18874
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to provide ssl related configurations for Ranger-Tagsync service.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  3431495 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  6debaf1 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  1efa7e9 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  f1b4797 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/atlas-tagsync-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-tagsync-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-tagsync-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.7.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  dd87b72 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/configuration/ranger-tagsync-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 
> 6287e00 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53727/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger with Tagsync installation on CentOS 6.
> 
> Verified Unit-tests:
> 
> test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:01:42,649 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111
> 2016-11-17 20:01:42,670 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111
> ok
> test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok
> test_start_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:01:42,691 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111
> ok
> test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:01:42,712 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111
> ok
> 
> 
> test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:02:05,297 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:02:05,318 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_start_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:02:05,336 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:02:05,355 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> 
> 
> Thanks,
> 
> Vishal Suvagia

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

2016-11-30 Thread Juanjo Marron


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53103/#review157438
---


Ship it!




Ship It!

- Juanjo  Marron


On Nov. 30, 2016, 6:43 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53103/
> ---
> 
> (Updated Nov. 30, 2016, 6:43 p.m.)
> 
> 
> Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Juanjo  Marron, Pallav 
> Kulshreshtha, Venkat Ranganathan, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18600
> https://issues.apache.org/jira/browse/AMBARI-18600
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the workflow designer view instance, if there is no log available for the 
> workflow, then the spinner is seen giving the impression that logs are still 
> being retrieved. This happens for all the logs, viz. the job log, error log 
> and audit log.
> 
> A message sould be displayed when there are no messages in the log.
> 
> The test failure for this patch is caused by an existing issue unrelated to 
> this patch.
> 
> Failed to execute goal on project wfmanager: Could not resolve dependencies 
> for project org.apache.ambari.contrib.views:wfmanager:jar:0.1.0.0-SNAPSHOT: 
> Failure to find 
> org.apache.ambari.contrib.views:ambari-views-commons:jar:2.0.0.0-SNAPSHOT in 
> https://oss.sonatype.org/content/groups/staging was cached in the local 
> repository, resolution will not be reattempted until the update interval of 
> oss.sonatype.org has elapsed or updates are forced -> [Help 1]
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> e403dc4 
> 
> Diff: https://reviews.apache.org/r/53103/diff/
> 
> 
> Testing
> ---
> 
> Manual tests.
> 
> 
> File Attachments
> 
> 
> C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18600
>   
> https://reviews.apache.org/media/uploaded/files/2016/10/27/5b87e2e8-23e1-456c-ab5d-f157db437624__AMBARI-18600.patch
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

2016-11-30 Thread Sangeeta Ravindran

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53103/
---

(Updated Nov. 30, 2016, 6:43 p.m.)

Review request for Ambari, Di Li, DIPAYAN BHOWMICK, Juanjo Marron, Pallav
Kulshreshtha, Venkat Ranganathan, and Yusaku Sako.

Changes
---

Updated patch based on latest code

Bugs: AMBARI-18600
https://issues.apache.org/jira/browse/AMBARI-18600

Repository: ambari

Description
---

In the workflow designer view instance, if there is no log available for the
workflow, then the spinner is seen giving the impression that logs are still
being retrieved. This happens for all the logs, viz. the job log, error log and
audit log.

A message sould be displayed when there are no messages in the log.

The test failure for this patch is caused by an existing issue unrelated to
this patch.

Failed to execute goal on project wfmanager: Could not resolve dependencies for
project org.apache.ambari.contrib.views:wfmanager:jar:0.1.0.0-SNAPSHOT: Failure
to find
org.apache.ambari.contrib.views:ambari-views-commons:jar:2.0.0.0-SNAPSHOT in
https://oss.sonatype.org/content/groups/staging was cached in the local
repository, resolution will not be reattempted until the update interval of
oss.sonatype.org has elapsed or updates are forced -> [Help 1]

Diffs (updated)
-

contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js
e403dc4

Diff: https://reviews.apache.org/r/53103/diff/

Testing
---

Manual tests.

File Attachments

C:\Sangeeta\Work\BigData\Ambari\Jira Submissions\18600

https://reviews.apache.org/media/uploaded/files/2016/10/27/5b87e2e8-23e1-456c-ab5d-f157db437624__AMBARI-18600.patch

Thanks,

Sangeeta Ravindran

Re: Review Request 54208: Log Search: Cannot increase the number of shards per node for solr collections

2016-11-30 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54208/#review157437
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 30, 2016, 5:15 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54208/
> ---
> 
> (Updated Nov. 30, 2016, 5:15 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-19033
> https://issues.apache.org/jira/browse/AMBARI-19033
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case of in logsearch.properties, the number of shards changes -> it cannot 
> create new shards per cores, because there is a maxShardsPerCore property is 
> set in zk config. To change that we need to use MODIFYCOLLECTION http call 
> against any solr server on solr cloud.
> 
> solr4j client library does not support MODIFYCOLLECTION action on 
> collections, so i had to implement the behaviour through a simple http call. 
> (HttpCleintUtil is used, so it should work with ssl and kerberos as well)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
>  834ba38 
> 
> Diff: https://reviews.apache.org/r/54208/diff/
> 
> 
> Testing
> ---
> 
> testing done (manually increase the number of shards with  changing the 
> logsearch.properties)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 53953: Extend current quick link JSON with properties

2016-11-30 Thread Balázs Bence Sári



> On Nov. 30, 2016, 4:46 p.m., Di Li wrote:
> > ambari-server/src/test/resources/child_quicklinks_with_properties.json, 
> > line 23
> > 
> >
> > How UI determines if a property (or rather criteria) is met to 
> > show/hide a quicklink? Are they determined by matching property defined 
> > with values known to the UI? I wonder if the properties should be a 2 
> > dimentional structure (similar to how the port is determined) than one.

UI will receive enriched information which will contain a *visible: true|false* 
field for each link.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53953/#review157419
---


On Nov. 22, 2016, 1:20 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53953/
> ---
> 
> (Updated Nov. 22, 2016, 1:20 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-18949
> https://issues.apache.org/jira/browse/AMBARI-18949
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Quick link data json should have an optional properties field for each link. 
> This field is a list of Strings and can contain informative tags about the 
> quicklink such a sso or authenticated.
> New json parser should be compatible with legacy quick links not having this 
> field.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  091926f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
>  38176aa 
>   ambari-server/src/test/resources/child_quicklinks_with_properties.json 
> PRE-CREATION 
>   ambari-server/src/test/resources/parent_quicklinks_with_properties.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53953/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit test
> - Did manual testing
> - Run all tests in ambari-server. Failures were irrelevant.
> 
> Failed tests:
>   UpgradeCatalog222Test.testInitializeStromAndKafkaWidgets:1118
>   Unexpected method call 
> AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for interface 
> org.apache.ambari.server.state.Cluster, EasyMock for interface 
> org.apache.ambari.server.state.Service):
> AmbariManagementController.getClusters(): expected: at least 0, actual: 1
> AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for 
> interface org.apache.ambari.server.state.Cluster, EasyMock for interface 
> org.apache.ambari.server.state.Service): expected: 1, actual: 0
>   DataStoreImplTest.testFind:526 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testRemove:475 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update:357 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update_longStringValue:426
>   Expectation failure on verify:
> DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
> Tests in error:
>   KerberosCheckerTest.testCheckFailed »  Unexpected exception, 
> expected   KerberosCheckerTest.testCheckPassed:62 » ClassCast class 
> sun.security.provider...
>   AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:98 » 
> Linkage
>   ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:50 » Ambari File 
> /Us...
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54175/#review157430
---


Ship it!




Ship It!

- Nate Cole


On Nov. 29, 2016, 3:11 p.m., Duc Le wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54175/
> ---
> 
> (Updated Nov. 29, 2016, 3:11 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-19020
> https://issues.apache.org/jira/browse/AMBARI-19020
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZOOKEEPER/metainfo.xml
>  de8ebd9 
> 
> Diff: https://reviews.apache.org/r/54175/diff/
> 
> 
> Testing
> ---
> 
> Manifest change only. Unit test not affected. Tested E2E.
> 
> 
> Thanks,
> 
> Duc Le
> 
>

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54086/#review157411
---


Ship it!




Ship It!

- Nate Cole


On Nov. 29, 2016, 4:32 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54086/
> ---
> 
> (Updated Nov. 29, 2016, 4:32 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-18987
> https://issues.apache.org/jira/browse/AMBARI-18987
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A general check that takes list of services defined in upgrade XML and check 
> if they are installed, fail the check if there is at least one hit.
> 
> Displaying different error messages depending on if a service does not 
> support upgrade or if a service is removed in the new release ( the two types 
> are specified via different properties in the upgrade XML files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicePresenceCheck.java
>  0f4eeb1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  1d964f8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  fe2598b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 10219b5 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 55fc284 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  ea9c60c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  6597cde 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 5e457cf 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> d4f4ff9 
> 
> Diff: https://reviews.apache.org/r/54086/diff/
> 
> 
> Testing
> ---
> 
> new unit tests
> installed an AMbari 2.4.2 cluster, upgrade it to Ambari trunk cluster, update 
> upgrade xml files with the new service check, then run upgrade, verify it 
> fails prechecks accordingly.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54145/#review157407
---




ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java
 (lines 138 - 143)


This usage is confusing.  What about using a non-optional "value-default" 
attribute (you can use a better name) that you use when the config value 
doesn't exist?  That way the author has more direct control over what's going 
to happen when the config knob doesn't exist.



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java
 (lines 142 - 143)


formatting


- Nate Cole


On Nov. 29, 2016, 6:29 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54145/
> ---
> 
> (Updated Nov. 29, 2016, 6:29 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Sumit Mohanty, 
> and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19006
> https://issues.apache.org/jira/browse/AMBARI-19006
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Today, the Express Upgrade packs message users to stop YARN queues if they do 
> not have work preserving recovery enabled.
> However, there's no message reminding users to enable it again.
> 
> E.g.,
> ```
> 
>   false
>   true
>   
> 
>   
>  property="yarn.resourcemanager.work-preserving-recovery.enabled" value="true" 
> comparison="not-equal"/>
> 
>   Before continuing, please start all YARN queues if you 
> stopped them in a previous step.
> 
>   
> 
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java
>  1bd88e4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  d824309 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  882e78b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  1d964f8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  fe2598b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  b7d7983 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  ea9c60c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  6597cde 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  414ce15 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  fc4c8c5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  d34d476 
>   ambari-server/src/main/resources/upgrade-pack.xsd 45cf5fa 
> 
> Diff: https://reviews.apache.org/r/54145/diff/
> 
> 
> Testing
> ---
> 
> Tested manually during EU from HDP 2.5 to 2.6
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 53727: Provide SSL related configurations for Ranger-Tagsync.


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53727/#review157401
---


Ship it!




Ship It!

- Mugdha Varadkar


On Nov. 17, 2016, 2:51 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53727/
> ---
> 
> (Updated Nov. 17, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, Mugdha Varadkar, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18874
> https://issues.apache.org/jira/browse/AMBARI-18874
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to provide ssl related configurations for Ranger-Tagsync service.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  3431495 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  6debaf1 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  1efa7e9 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  f1b4797 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/atlas-tagsync-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-tagsync-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-tagsync-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER/0.7.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  dd87b72 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/configuration/ranger-tagsync-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml 
> 6287e00 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53727/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger with Tagsync installation on CentOS 6.
> 
> Verified Unit-tests:
> 
> test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:01:42,649 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111
> 2016-11-17 20:01:42,670 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111
> ok
> test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok
> test_start_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:01:42,691 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111
> ok
> test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:01:42,712 - Stack Feature Version Info: stack_version=2.6, 
> version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111
> ok
> 
> 
> test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:02:05,297 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:02:05,318 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_start_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:02:05,336 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 
> 20:02:05,355 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> ok
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 54204: Service Auto Start operations are permitted during Upgrade

2016-11-30 Thread Aleksandr Kovalenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54204/#review157400
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Ноя. 30, 2016, 12:35 п.п., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54204/
> ---
> 
> (Updated Ноя. 30, 2016, 12:35 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-19030
> https://issues.apache.org/jira/browse/AMBARI-19030
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Please see attached screenshots
> While an Express Upgrade is in progress, I am able to perform 'Service Auto 
> Start' operations like enable/disable auto start for a service component
> In-line with our standard mechanism of not allowing any operations during 
> upgrade (unless it is paused), it would be good to disable 'Service Auto 
> Start' during Upgrade - so as to not have any undesirable side-effects on the 
> system during an Upgrade
> 
> 
> Diffs
> -
> 
>   ambari-web/app/templates/main/admin/service_auto_start.hbs 7334995 
>   ambari-web/app/views/main/admin.js 704527b 
>   ambari-web/app/views/main/admin/service_auto_start.js 7b4e46c 
>   ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js 
> 8588b04 
> 
> Diff: https://reviews.apache.org/r/54204/diff/
> 
> 
> Testing
> ---
> 
> 20020 tests complete (27 seconds)
> 155 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Review Request 54204: Service Auto Start operations are permitted during Upgrade

2016-11-30 Thread Andrii Tkach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54204/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19030
https://issues.apache.org/jira/browse/AMBARI-19030


Repository: ambari


Description
---

Please see attached screenshots
While an Express Upgrade is in progress, I am able to perform 'Service Auto 
Start' operations like enable/disable auto start for a service component
In-line with our standard mechanism of not allowing any operations during 
upgrade (unless it is paused), it would be good to disable 'Service Auto Start' 
during Upgrade - so as to not have any undesirable side-effects on the system 
during an Upgrade


Diffs
-

  ambari-web/app/templates/main/admin/service_auto_start.hbs 7334995 
  ambari-web/app/views/main/admin.js 704527b 
  ambari-web/app/views/main/admin/service_auto_start.js 7b4e46c 
  ambari-web/app/views/main/admin/service_auto_start/component_auto_start.js 
8588b04 

Diff: https://reviews.apache.org/r/54204/diff/


Testing
---

20020 tests complete (27 seconds)
155 tests pending


Thanks,

Andrii Tkach

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled

2016-11-30 Thread Tim Thorpe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54145/#review157398
---




ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java
 (line 149)


Usually the return value for EQUALS != NOT_EQUALS.  In this case if the 
property doesn't exist the return values will be the same.

For NOT_EQUALS, there are really 2 cases.  The obvious one where the 
property exists and the more difficult one where the property doesn't exist.  
When the property doesn't exist, it would be much better if we could provide a 
default value to compare.





ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 (line 420)


Duplicates?
With this section, do you really need the following section as well:


  UPGRADE
  

  Please start previously stopped YARN queues.


- Tim Thorpe


On Nov. 29, 2016, 11:29 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54145/
> ---
> 
> (Updated Nov. 29, 2016, 11:29 p.m.)
> 
> 
> Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Sumit Mohanty, 
> and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19006
> https://issues.apache.org/jira/browse/AMBARI-19006
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Today, the Express Upgrade packs message users to stop YARN queues if they do 
> not have work preserving recovery enabled.
> However, there's no message reminding users to enable it again.
> 
> E.g.,
> ```
> 
>   false
>   true
>   
> 
>   
>  property="yarn.resourcemanager.work-preserving-recovery.enabled" value="true" 
> comparison="not-equal"/>
> 
>   Before continuing, please start all YARN queues if you 
> stopped them in a previous step.
> 
>   
> 
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java
>  1bd88e4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  d824309 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  882e78b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  1d964f8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  fe2598b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  b7d7983 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  ea9c60c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  6597cde 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  414ce15 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  fc4c8c5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  d34d476 
>   ambari-server/src/main/resources/upgrade-pack.xsd 45cf5fa 
> 
> Diff: https://reviews.apache.org/r/54145/diff/
> 
> 
> Testing
> ---
> 
> Tested manually during EU from HDP 2.5 to 2.6
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster

2016-11-30 Thread Tim Thorpe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54121/#review157397
---


Ship it!




Ship It!

- Tim Thorpe


On Nov. 29, 2016, 3:56 a.m., Weiwei Yang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54121/
> ---
> 
> (Updated Nov. 29, 2016, 3:56 a.m.)
> 
> 
> Review request for Ambari and Di Li.
> 
> 
> Bugs: AMBARI-18929
> https://issues.apache.org/jira/browse/AMBARI-18929
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Improve the logic of yarn service check, let it work as long as active RM is 
> working fine
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  c0bd480 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_service_check.py 
> bb671aa 
> 
> Diff: https://reviews.apache.org/r/54121/diff/
> 
> 
> Testing
> ---
> 
> HA environment
>  1. Both active & standby RMs are up : SUCCESS
>  2. Shutdown standby RM, active remains up : SUCCESS
>  3. Shutdown active RM, active transited to the other RM : SUCCESS
>  4. Shutdown zookeeper, both RMs are standby : FAIL
>  5. Both RMs are down : FAIL
> 
> Non-HA environment
>  1. RM is up : SUCCESS
>  2. RM is down : FAIL
> 
> 
> Thanks,
> 
> Weiwei Yang
> 
>

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-30 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54124/
---

(Updated Ноя. 30, 2016, 11:49 д.п.)


Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-18997
https://issues.apache.org/jira/browse/AMBARI-18997


Repository: ambari


Description
---

ambari-server.pid file might not be created on slow hardware, but 
"ambari-server start" exits with 0


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/utils.py 5188a48 
  ambari-server/src/main/python/ambari_server_main.py 62f8980 
  ambari-server/src/test/python/TestAmbariServer.py 76857cd 
  ambari-server/src/test/python/TestUtils.py bedd75c 

Diff: https://reviews.apache.org/r/54124/diff/


Testing
---

Unit tests passed

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [3.655s]
[INFO] Apache Ambari Project POM . SUCCESS [0.005s]
[INFO] Ambari Views .. SUCCESS [1.987s]
[INFO] utility ... SUCCESS [0.402s]
[INFO] ambari-metrics  SUCCESS [0.324s]
[INFO] Ambari Metrics Common . SUCCESS [0.735s]
[INFO] Ambari Server . SUCCESS [1:02.776s]
[INFO] 
[INFO] BUILD SUCCESS


Thanks,

Dmytro Sen

Re: Review Request 54203: Manage JournalNode tweaks

2016-11-30 Thread Andrii Tkach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54203/#review157396
---


Ship it!




Ship It!

- Andrii Tkach


On Nov. 30, 2016, 11:21 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54203/
> ---
> 
> (Updated Nov. 30, 2016, 11:21 a.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: ambari-19027
> https://issues.apache.org/jira/browse/ambari-19027
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I reviewed the changes that are in ambari-server-2.5.0.0-340.x86_64. I 
> noticed most of the wording changes are in there, but not all. I've updated 
> the deck to keep only show the changes that still need to be made.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js aa43687 
>   ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs 
> 547d364 
> 
> Diff: https://reviews.apache.org/r/54203/diff/
> 
> 
> Testing
> ---
> 
> 20020 tests complete (31 seconds)
>   155 tests pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 54203: Manage JournalNode tweaks

2016-11-30 Thread Oleg Nechiporenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54203/
---

Review request for Ambari and Andrii Tkach.


Bugs: ambari-19027
https://issues.apache.org/jira/browse/ambari-19027


Repository: ambari


Description
---

I reviewed the changes that are in ambari-server-2.5.0.0-340.x86_64. I noticed 
most of the wording changes are in there, but not all. I've updated the deck to 
keep only show the changes that still need to be made.


Diffs
-

  ambari-web/app/messages.js aa43687 
  ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs 
547d364 

Diff: https://reviews.apache.org/r/54203/diff/


Testing
---

20020 tests complete (31 seconds)
  155 tests pending


Thanks,

Oleg Nechiporenko

Re: Review Request 54202: Add Host Wizard: validation failed on Assign Slaves step

2016-11-30 Thread Alexandr Antonenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54202/#review157394
---


Ship it!




Ship It!

- Alexandr Antonenko


On Nov. 30, 2016, 10:22 a.m., Denys Buzhor wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54202/
> ---
> 
> (Updated Nov. 30, 2016, 10:22 a.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-19026
> https://issues.apache.org/jira/browse/AMBARI-19026
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> *  Install cluster with ZooKeeper
> *  Run Add Host Wizard
> *  Proceed to Assign Slaves and Clients step
> 
> AR: First validation call returns error regarding missed components.
> ER: No validation errors appears on initial stage.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step6_controller.js dfd0687 
>   ambari-web/test/controllers/wizard/step6_test.js b2bc879 
> 
> Diff: https://reviews.apache.org/r/54202/diff/
> 
> 
> Testing
> ---
> 
> 20020 tests complete (26 seconds)
> 155 tests pending
> 
> 
> Thanks,
> 
> Denys Buzhor
> 
>

Re: Review Request 54189: After adding an Atlas server the first restart command fails since stop doesn't have any configs; if no pid dir exists during stop, perform no-op