Review Request 55257: AMBARI-19398 : Namenode not resolved while submitting workflow in certain environments

2017-01-05 Thread Padma Priya N 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55257/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
Kulshreshtha.


Bugs: AMBARI-19398
https://issues.apache.org/jira/browse/AMBARI-19398


Repository: ambari


Description
---

Namenode is not resovled while creating configuration in job.properties while 
submitting workflow in certain environments.
Step.
if the hdfs-site does not have dfs.namenode.rpc-address property workflow 
submission fails.
Expected.
certain environments may not have dfs.namenode.rpc-address set, and in those 
environments workflow should be submitted without error


Diffs
-

  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/AmbariIOUtil.java
 93447b7 
  
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java
 2779f05 
  contrib/views/wfmanager/src/main/resources/view.xml b8e2fcc 

Diff: https://reviews.apache.org/r/55257/diff/


Testing
---

Manual


Thanks,

Padma Priya N

Re: Review Request 55206: AMBARI-19385: Resolve variables in workflow if workflow path in coordinator contains variables.

2017-01-05 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55206/#review160684
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 5, 2017, 12:14 p.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55206/
> ---
> 
> (Updated Jan. 5, 2017, 12:14 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-19385
> https://issues.apache.org/jira/browse/AMBARI-19385
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Resolve variables in workflow ,if workflow path in coordinator contains 
> variables..
> Steps:
> while creating coordinator use variables while configuring the workflow path. 
> User is not prompted for the variables in workflow.
> 
> Expected.
> the variables in workflow should be prompted for user to submit.
> 
> Also need to add custom properties that the user can configure while 
> submitting workflow/coordinator/bundle.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 122b956 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> 904901c 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 3454374 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
> 8b685f0 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js
>  0ebd9a7 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  5b5cd68 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs
>  f0d9ee3 
> 
> Diff: https://reviews.apache.org/r/55206/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 55209: ATS service check failed on navigating to Hive View

2017-01-05 Thread DIPAYAN BHOWMICK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55209/#review160681
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 5, 2017, 1:30 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55209/
> ---
> 
> (Updated Jan. 5, 2017, 1:30 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19382
> https://issues.apache.org/jira/browse/AMBARI-19382
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The ats url is not correctly form when it is https. Using utils to form ats 
> url now.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/HelpService.java
>  702b38a 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/atsJobs/ATSParserFactory.java
>  4ff2621 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HelpService.java
>  9fe 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/atsJobs/ATSParserFactory.java
>  343202e 
> 
> Diff: https://reviews.apache.org/r/55209/diff/
> 
> 
> Testing
> ---
> 
> Manual.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Review Request 55250: AMBARI-19384. Wrong placeholder in REST metrics error message

2017-01-05 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55250/
---

Review request for Ambari and Jonathan Hurley.


Bugs: AMBARI-19384
https://issues.apache.org/jira/browse/AMBARI-19384


Repository: ambari


Description
---

Replaced `$s` with `%s`


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
 0b8dd62d067ee61f78d5cdf16babf9f8f3c8842b 

Diff: https://reviews.apache.org/r/55250/diff/


Testing
---

None, trivial change


Thanks,

Attila Doroszlai

Re: Review Request 55206: AMBARI-19385: Resolve variables in workflow if workflow path in coordinator contains variables.

2017-01-05 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55206/#review160680
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Jan. 5, 2017, 12:14 p.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55206/
> ---
> 
> (Updated Jan. 5, 2017, 12:14 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-19385
> https://issues.apache.org/jira/browse/AMBARI-19385
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Resolve variables in workflow ,if workflow path in coordinator contains 
> variables..
> Steps:
> while creating coordinator use variables while configuring the workflow path. 
> User is not prompted for the variables in workflow.
> 
> Expected.
> the variables in workflow should be prompted for user to submit.
> 
> Also need to add custom properties that the user can configure while 
> submitting workflow/coordinator/bundle.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 122b956 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> 904901c 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 3454374 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
> 8b685f0 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js
>  0ebd9a7 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  5b5cd68 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs
>  f0d9ee3 
> 
> Diff: https://reviews.apache.org/r/55206/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 55206: AMBARI-19385: Resolve variables in workflow if workflow path in coordinator contains variables.

2017-01-05 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55206/#review160678
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 5, 2017, 12:14 p.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55206/
> ---
> 
> (Updated Jan. 5, 2017, 12:14 p.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-19385
> https://issues.apache.org/jira/browse/AMBARI-19385
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Resolve variables in workflow ,if workflow path in coordinator contains 
> variables..
> Steps:
> while creating coordinator use variables while configuring the workflow path. 
> User is not prompted for the variables in workflow.
> 
> Expected.
> the variables in workflow should be prompted for user to submit.
> 
> Also need to add custom properties that the user can configure while 
> submitting workflow/coordinator/bundle.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 122b956 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> 904901c 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 3454374 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
> 8b685f0 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js
>  0ebd9a7 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
>  5b5cd68 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs
>  f0d9ee3 
> 
> Diff: https://reviews.apache.org/r/55206/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Review Request 55249: Infra Solr Upgrade support 2.4 -> 2.5

2017-01-05 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55249/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-19397
https://issues.apache.org/jira/browse/AMBARI-19397


Repository: ambari


Description
---

Upgrade Infra solr related properties for ambari 2.5.0.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 3701e2f 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-log4j.xml
 b22dbf2 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 c89522f 
  ambari-web/app/data/HDP2/site_properties.js 6c2d5e1 

Diff: https://reviews.apache.org/r/55249/diff/


Testing
---

Checked configuration differences between ambari infra in ambari version 2.4 
and 2.5.
Manually did a yum upgrade:
- implemented propertiy changes in UpgradeCatalog250.java
- checked the new configurations were added properly


Thanks,

Miklos Gergely

Re: Review Request 55245: ambari-web action to download all client configs of a service

2017-01-05 Thread Yusaku Sako 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55245/#review160663
---


Ship it!




Ship It!

- Yusaku Sako


On Jan. 6, 2017, 1:21 a.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55245/
> ---
> 
> (Updated Jan. 6, 2017, 1:21 a.m.)
> 
> 
> Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19394
> https://issues.apache.org/jira/browse/AMBARI-19394
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a new ambari-web action to download all client configs of a service. This 
> action should be added in the submenu for "Download Client Conifgs" labelled 
> item in the service action
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/item.js be3fac1 
>   ambari-web/app/messages.js 3642e5a 
>   ambari-web/test/controllers/main/service/item_test.js 78ed0a6 
> 
> Diff: https://reviews.apache.org/r/55245/diff/
> 
> 
> Testing
> ---
> 
> verified that patch works as expected on a cluster.
> verified that all ambari-web unit tests passes with the patch:
> 20121 passing (16s)
> 153 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Review Request 55244: Relax checkstyle rules since causing unit test failures

2017-01-05 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55244/
---

Review request for Ambari.


Bugs: AMBARI-19395
https://issues.apache.org/jira/browse/AMBARI-19395


Repository: ambari


Description
---

Unit tests on Apache are failing because the checkstyle rules are too strict, 
especially when it comes to imports.

Right now, it requires this, which I want to remove because it means that 
everyone has to use an IDE and setup the same rules for something that is 
trivial at compile-time and actually causes more headaches for developers.

```

  
  
  
   
  

```


Diffs
-

  ambari-admin/pom.xml 4a8bba3 
  ambari-server/checkstyle.xml bf7698d 
  ambari-views/pom.xml 4121fb5 
  utility/pom.xml 6f60206 

Diff: https://reviews.apache.org/r/55244/diff/


Testing
---

mvn checkstyle:checkstyle


Thanks,

Alejandro Fernandez

Re: Review Request 55232: Grafana datasource changes to accommodate new visualizations for TopN

2017-01-05 Thread Vivek Ratnavel Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55232/
---

(Updated Jan. 5, 2017, 11:44 p.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Changes
---

1) Removed labels for the first three graphs.
2) Included the word "Sliding Window" in titles of all graphs.
3) Added an option "All" to the hosts dropdown and had it selected by default.

Verified Manually.


Bugs: AMBARI-19373
https://issues.apache.org/jira/browse/AMBARI-19373


Repository: ambari


Description
---

We need a visualization of a scatter plot for NNTop metrics for HDFS.


Diffs (updated)
-

  ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js eb883e8 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-topn.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/55232/diff/


Testing
---

Verified Manually using a canary build in a 5 node cluster.


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 55233: Improve and Fix "Hosts page" after new guidelines

2017-01-05 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55233/#review160643
---


Ship it!




Ship It!

- Jaimin Jetly


On Jan. 5, 2017, 10:18 p.m., Xi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55233/
> ---
> 
> (Updated Jan. 5, 2017, 10:18 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19313
> https://issues.apache.org/jira/browse/AMBARI-19313
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hosts filter:
> 1. Not aligned with Actions button.
> 2. Filter dropdown menu, all host filter texts should be same font family as 
> other texts
> 3. Remove icon has shadow, should not
> 
> Hosts table:
> 4. Text in every table row was not centered.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 7d18cf5 
> 
> Diff: https://reviews.apache.org/r/55233/diff/
> 
> 
> Testing
> ---
> 
> 19976 passing (20s)
> 153 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>

Re: Review Request 55234: AMBARI-19393 - Cluster User role is able to view auto start page

2017-01-05 Thread Xi Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55234/#review160640
---


Ship it!




Ship It!

- Xi Wang


On Jan. 5, 2017, 2:42 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55234/
> ---
> 
> (Updated Jan. 5, 2017, 2:42 p.m.)
> 
> 
> Review request for Ambari and Xi Wang.
> 
> 
> Bugs: AMBARI-19393
> https://issues.apache.org/jira/browse/AMBARI-19393
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When logged in with Cluster User role, if auto start page url is pasted it 
> should directly navigate to dashboard page.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/routes/main.js e837110 
> 
> Diff: https://reviews.apache.org/r/55234/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster. All unit tests passed.
>   19976 passing (17s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Review Request 55233: Improve and Fix "Hosts page" after new guidelines

2017-01-05 Thread Xi Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55233/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, and Yusaku Sako.


Bugs: AMBARI-19313
https://issues.apache.org/jira/browse/AMBARI-19313


Repository: ambari


Description
---

Hosts filter:
1. Not aligned with Actions button.
2. Filter dropdown menu, all host filter texts should be same font family as 
other texts
3. Remove icon has shadow, should not

Hosts table:
4. Text in every table row was not centered.


Diffs
-

  ambari-web/app/styles/application.less 7d18cf5 

Diff: https://reviews.apache.org/r/55233/diff/


Testing
---

19976 passing (20s)
153 pending


Thanks,

Xi Wang

Review Request 55232: Grafana datasource changes to accommodate new visualizations for TopN

2017-01-05 Thread Vivek Ratnavel Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55232/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-19373
https://issues.apache.org/jira/browse/AMBARI-19373


Repository: ambari


Description
---

We need a visualization of a scatter plot for NNTop metrics for HDFS.


Diffs
-

  ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js eb883e8 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDP/grafana-hdfs-topn.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/55232/diff/


Testing
---

Verified Manually using a canary build in a 5 node cluster.


Thanks,

Vivek Ratnavel Subramanian

Review Request 55230: HOU Fails To Restart NameNode in non-HA Cluster

2017-01-05 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55230/
---

Review request for Ambari, Dmytro Grinenko and Nate Cole.


Bugs: AMBARI-19344
https://issues.apache.org/jira/browse/AMBARI-19344


Repository: ambari


Description
---

When restarting NameNode during an HOU, NN throws an error because it was 
improperly put into rollingUpgrade mode.

*Steps*
# Deploy HDP-2.5.0.0 with Ambari-2.5.0.0-547 build (non-HA cluster)
# Start Host Ordered Upgrade to HDP-2.5.3
 
*Result:* Error at pre Upgrade HDFS step

```
PREPARE rolling upgrade ...
17/01/03 17:07:51 WARN retry.RetryInvocationHandler: Exception while invoking 
ClientNamenodeProtocolTranslatorPB.rollingUpgrade over null. Not retrying 
because try once and fail.
org.apache.hadoop.ipc.RemoteException(java.io.IOException): Safe mode should be 
turned ON in order to create namespace image.
at 
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startRollingUpgradeInternalForNonHA(FSNamesystem.java:7839)

rollingUpgrade: Safe mode should be turned ON in order to create namespace 
image.
```


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
 23119f0 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 86f68e5 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs_namenode.py
 23119f0 
  
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/namenode.py
 86f68e5 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
 f6480bf 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-ordered-upgrade.xml
 1b29af3 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2627ddf 

Diff: https://reviews.apache.org/r/55230/diff/


Testing
---

--
Total run:1157
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 50.822 s
[INFO] Finished at: 2017-01-05T16:29:21-05:00
[INFO] Final Memory: 17M/310M
[INFO] 


Thanks,

Jonathan Hurley

Review Request 55229: AMBARI-19392. Status command executor may use obsolete settings

2017-01-05 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55229/
---

Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, Sumit Mohanty, 
Sebastian Toader, and Sid Wagle.


Bugs: AMBARI-19392
https://issues.apache.org/jira/browse/AMBARI-19392


Repository: ambari


Description
---

Spawn status command executor after registration


Diffs
-

  ambari-agent/src/main/python/ambari_agent/Controller.py 56b1992 

Diff: https://reviews.apache.org/r/55229/diff/


Testing
---

Manual testing (verify that `agent.auto.cache.update=false` setting from server 
is applied in both processes).

Unit tests:

```
Ran 452 tests in 21.374s

OK
```


Thanks,

Attila Doroszlai

Re: Review Request 55207: Heartbeat version transitions must update Component alongside Cluster

2017-01-05 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55207/#review160613
---




ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
 (line 73)


What should the behavior be if the record has a version of NONE? No 
comparison will happen.


- Alejandro Fernandez


On Jan. 5, 2017, 6:37 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55207/
> ---
> 
> (Updated Jan. 5, 2017, 6:37 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-19381
> https://issues.apache.org/jira/browse/AMBARI-19381
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The repository version per component and state of the repository should be 
> updated on heartbeat just as cluster is.
> 
> Long term, the cluster_version will no longer be used; that is a separate 
> effort.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  0046ec6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java
>  9dbda20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  65cfcaa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  7c90cab 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  f5a5b0c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
>  cc7b503 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java
>  987e44f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
>  9d35e2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  210de62 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
>  9b93517 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentVersionEntity.java
>  5085d18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  e93ab9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  236091b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  7d35d2e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  d6bbbac 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
>   ambari-server/src/main/resources/properties.json b7e0988 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  7758924 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
>  3529bef 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
>  fb508ea 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> ead0a2d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
>  0f615ee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  36afa03 
> 
> Diff: https://reviews.apache.org/r/55207/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> 
> Results :
> 
> Tests run: 4837, Failures: 0, Errors: 0, Skipped: 37
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 55207: Heartbeat version transitions must update Component alongside Cluster

2017-01-05 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55207/
---

(Updated Jan. 5, 2017, 1:37 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
Jonathan Hurley.


Bugs: AMBARI-19381
https://issues.apache.org/jira/browse/AMBARI-19381


Repository: ambari


Description
---

The repository version per component and state of the repository should be 
updated on heartbeat just as cluster is.

Long term, the cluster_version will no longer be used; that is a separate 
effort.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 0046ec6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java
 9dbda20 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
 65cfcaa 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 7c90cab 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 f5a5b0c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
 cc7b503 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java
 987e44f 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
 9d35e2a 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 210de62 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
 9b93517 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentVersionEntity.java
 5085d18 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 e93ab9a 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 236091b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 7d35d2e 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
 d6bbbac 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
  ambari-server/src/main/resources/properties.json b7e0988 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
 7758924 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
 3529bef 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
 fb508ea 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
ead0a2d 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
 0f615ee 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
 36afa03 

Diff: https://reviews.apache.org/r/55207/diff/


Testing (updated)
---

Manual.  Automated:


Results :

Tests run: 4837, Failures: 0, Errors: 0, Skipped: 37


Thanks,

Nate Cole

Re: Review Request 55213: PERF: disabling security fails

2017-01-05 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55213/#review160608
---


Ship it!




Ship It!

- Sid Wagle


On Jan. 5, 2017, 3:32 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55213/
> ---
> 
> (Updated Jan. 5, 2017, 3:32 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19388
> https://issues.apache.org/jira/browse/AMBARI-19388
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When you are trying to disable security om perf cluster it fails.
> 1) For cluster with 1200 agents it works fine but for cluster with 1850 
> agents it fails.
> 2) According to what i found, root cause is PUT request to 
> http://:8080/api/v1/clusters/ with data 
> like "security_type" : "NONE". So, this request trying to change security 
> type from KERBEROS to NONE and fails by timeout of three minutes.
> 3) Interesting thing, request to change security type fails and UI showing 
> Error on disable security window. But in the same time in BG operations 
> process which destroying keytabs proceed work.
> 4) One more thing. After failed disabling kerberos, if you will click restart 
> the same request(update security type) will finish work in a few seconds.
> So, what we need to do is to connect profiler and find out what exactly take 
> so much time for request to change security type.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  0cf46df 
> 
> Diff: https://reviews.apache.org/r/55213/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 55207: Heartbeat version transitions must update Component alongside Cluster

2017-01-05 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55207/
---

(Updated Jan. 5, 2017, 12:51 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
Jonathan Hurley.


Changes
---

Fix for comments and checkstyle fixes.


Bugs: AMBARI-19381
https://issues.apache.org/jira/browse/AMBARI-19381


Repository: ambari


Description
---

The repository version per component and state of the repository should be 
updated on heartbeat just as cluster is.

Long term, the cluster_version will no longer be used; that is a separate 
effort.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 0046ec6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java
 9dbda20 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
 65cfcaa 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 7c90cab 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
 f5a5b0c 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
 cc7b503 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java
 987e44f 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
 9d35e2a 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
 210de62 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
 9b93517 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentVersionEntity.java
 5085d18 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 e93ab9a 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 236091b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 7d35d2e 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
 d6bbbac 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
  ambari-server/src/main/resources/properties.json b7e0988 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
 7758924 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
 3529bef 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
 fb508ea 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
ead0a2d 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
 0f615ee 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
 36afa03 

Diff: https://reviews.apache.org/r/55207/diff/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 55182: Add common log rotation settings to ranger, ranger-kms and falcon

2017-01-05 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55182/#review160606
---


Ship it!




Ship It!

- Sumit Mohanty


On Jan. 5, 2017, 4:33 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55182/
> ---
> 
> (Updated Jan. 5, 2017, 4:33 p.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19368
> https://issues.apache.org/jira/browse/AMBARI-19368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add common log rotation settings to ranger, ranger-kms and falcon
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml
>  ecf68a9 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  4a12b9f 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  6d1ae03 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  ddbd9d7 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  ac4e54e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml
>  9f0cdbf 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml
>  afeb422 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml
>  768c153 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml
>  20b2dc1 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  7fb8ba6 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  82dcb6b 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py 
> 8079147 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 4ad5c0f 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json 49c8a7b 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 
> f2a0405 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 
> 8e8e68b 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py 
> f5e55b3 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 
> 36fa15b 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> 3d79e0a 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 
> 32219b3 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 
> 42f75e2 
> 
> Diff: https://reviews.apache.org/r/55182/diff/
> 
> 
> Testing
> ---
> 
> Verified changes through API and Database
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 55182: Add common log rotation settings to ranger, ranger-kms and falcon

2017-01-05 Thread Madhuvanthi Radhakrishnan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55182/
---

(Updated Jan. 5, 2017, 4:33 p.m.)


Review request for Ambari and Sumit Mohanty.


Changes
---

Modified some test scripts for falcon.


Bugs: AMBARI-19368
https://issues.apache.org/jira/browse/AMBARI-19368


Repository: ambari


Description
---

Add common log rotation settings to ranger, ranger-kms and falcon


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml
 ecf68a9 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 4a12b9f 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 6d1ae03 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 ddbd9d7 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 ac4e54e 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-log4j.xml
 9f0cdbf 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-log4j.xml
 afeb422 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/usersync-log4j.xml
 768c153 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml
 20b2dc1 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 7fb8ba6 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 82dcb6b 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py 8079147 
  ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 4ad5c0f 
  ambari-server/src/test/python/stacks/2.1/configs/default.json 49c8a7b 
  ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json f2a0405 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 8e8e68b 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py 
f5e55b3 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 
36fa15b 
  ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
3d79e0a 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 32219b3 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py 
42f75e2 

Diff: https://reviews.apache.org/r/55182/diff/


Testing
---

Verified changes through API and Database


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 55207: Heartbeat version transitions must update Component alongside Cluster

2017-01-05 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55207/#review160602
---




ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 (lines 120 - 121)


Either way - I'm fine leaving it. It's actually a nice pattern to have for 
testing. Lets you pass in mocks for these DAOs if you need to. Sometimes for 
tests it's easier to overload the ctor like this.

Anyway, it was just something to mention.


- Jonathan Hurley


On Jan. 5, 2017, 8:12 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55207/
> ---
> 
> (Updated Jan. 5, 2017, 8:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-19381
> https://issues.apache.org/jira/browse/AMBARI-19381
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The repository version per component and state of the repository should be 
> updated on heartbeat just as cluster is.
> 
> Long term, the cluster_version will no longer be used; that is a separate 
> effort.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java
>  9dbda20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  65cfcaa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  f5a5b0c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
>  cc7b503 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java
>  987e44f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
>  9d35e2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
>  9b93517 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentVersionEntity.java
>  5085d18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  e93ab9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  236091b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  d6bbbac 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
>   ambari-server/src/main/resources/properties.json b7e0988 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  045d017 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
>  3529bef 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> 15e81c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
>  0f615ee 
> 
> Diff: https://reviews.apache.org/r/55207/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 55207: Heartbeat version transitions must update Component alongside Cluster

2017-01-05 Thread Nate Cole 


> On Jan. 5, 2017, 11:10 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql, line 185
> > 
> >
> > Typo; extra NOT. Should be:
> > 
> > repo_state VARCHAR2(255) DEFAULT 'INIT' NOT NULL,

Good catch.  Will fix.


> On Jan. 5, 2017, 11:10 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java,
> >  lines 643-645
> > 
> >
> > So the event which invokes this is done on a synchronous bus. I think 
> > it's synchronous b/c the heartbeat processor uses the results, so it has to 
> > be done on the thread handling the heartbeat.
> > 
> > This method does a lot with the database, which will slow down the 
> > thread. On a large cluster, could this be a problem? If the heartbeat 
> > processor doesn't use the result of this method's calculations, then 
> > perhaps we can create a new async bus for this kind of stuff. It would 
> > still listen to the same event being fired from the heartbeat processor.
> > 
> > Doesn't even need to change in this review - just thought I'd flag it 
> > for discussion.

There is a lot of DB work, but the amount done with this change isn't much more 
than what was there (one extra query).  I'll open a new JIRA.


> On Jan. 5, 2017, 11:10 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java,
> >  lines 120-121
> > 
> >
> > Just as a point (don't need to change it now), but unless the 
> > constructor (or a method it calls) needs these, you can just @Inject them 
> > and not worry about having them in the ctor.

Ah, yes, you're right - brain freeze from having to write jahvaahh 
:)  Will fix, as I found a bunch of checkstyle warnings anyway.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55207/#review160598
---


On Jan. 5, 2017, 8:12 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55207/
> ---
> 
> (Updated Jan. 5, 2017, 8:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-19381
> https://issues.apache.org/jira/browse/AMBARI-19381
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The repository version per component and state of the repository should be 
> updated on heartbeat just as cluster is.
> 
> Long term, the cluster_version will no longer be used; that is a separate 
> effort.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java
>  9dbda20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  65cfcaa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  f5a5b0c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
>  cc7b503 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java
>  987e44f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
>  9d35e2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
>  9b93517 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentVersionEntity.java
>  5085d18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  e93ab9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  236091b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  d6bbbac 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
>   ambari-server/src/main/resources/properties.json b7e0988 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  045d017 
>   
>

Re: Review Request 55207: Heartbeat version transitions must update Component alongside Cluster

2017-01-05 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55207/#review160598
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java
 (line 204)


Doc.



ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 (lines 120 - 121)


Just as a point (don't need to change it now), but unless the constructor 
(or a method it calls) needs these, you can just @Inject them and not worry 
about having them in the ctor.



ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 (lines 643 - 645)


So the event which invokes this is done on a synchronous bus. I think it's 
synchronous b/c the heartbeat processor uses the results, so it has to be done 
on the thread handling the heartbeat.

This method does a lot with the database, which will slow down the thread. 
On a large cluster, could this be a problem? If the heartbeat processor doesn't 
use the result of this method's calculations, then perhaps we can create a new 
async bus for this kind of stuff. It would still listen to the same event being 
fired from the heartbeat processor.

Doesn't even need to change in this review - just thought I'd flag it for 
discussion.



ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql (line 185)


Typo; extra NOT. Should be:

repo_state VARCHAR2(255) DEFAULT 'INIT' NOT NULL,


- Jonathan Hurley


On Jan. 5, 2017, 8:12 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55207/
> ---
> 
> (Updated Jan. 5, 2017, 8:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-19381
> https://issues.apache.org/jira/browse/AMBARI-19381
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The repository version per component and state of the repository should be 
> updated on heartbeat just as cluster is.
> 
> Long term, the cluster_version will no longer be used; that is a separate 
> effort.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java
>  9dbda20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  65cfcaa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
>  f5a5b0c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
>  cc7b503 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java
>  987e44f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
>  9d35e2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
>  9b93517 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentVersionEntity.java
>  5085d18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
>  e93ab9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  236091b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  d6bbbac 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
>   ambari-server/src/main/resources/properties.json b7e0988 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  045d017 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
>  3529bef 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
> 15e81c5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
>  0f615ee 
> 
> Diff: https://reviews.apache.org/r/55207/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 55193: Executing ambari-server unit tests with JDK 1.8 results in unit test failures

2017-01-05 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55193/#review160594
---


Ship it!




Ship It!

- Nate Cole


On Jan. 4, 2017, 8:50 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55193/
> ---
> 
> (Updated Jan. 4, 2017, 8:50 p.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Jaimin Jetly, Jonathan Hurley, 
> Laszlo Puskas, and Nate Cole.
> 
> 
> Bugs: AMBARI-19365
> https://issues.apache.org/jira/browse/AMBARI-19365
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following unit tests fails when executed with JDK 1.8
> ```
> mvn test -Dtest=DataStoreImplTest
> mvn clean test -Dtest=UpgradeCatalog222Test
> mvn test -Dtest=KerberosCheckerTest,AmbariBasicAuthenticationFilterTest
> ```
> Same unit tests passes if the environment is switched to use JDK 1.7
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java
>  e0a3d55 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/LoginContextHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosCheckerTest.java
>  570a50b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/JvmMetricsSourceTest.java
>  a6aa5d5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilterTest.java
>  7e36128 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
>  9d4fb3e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java
>  60643b3 
> 
> Diff: https://reviews.apache.org/r/55193/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests with Oracle JDK 1.7 and Oracle JDK 1.8.
> Manually tested Ambari
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 55107: LogSearch upgrade support 2.4 -> 2.5

2017-01-05 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55107/#review160593
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 5, 2017, 3:02 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55107/
> ---
> 
> (Updated Jan. 5, 2017, 3:02 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19330
> https://issues.apache.org/jira/browse/AMBARI-19330
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Upgrade the logsearch properties from 2.4 to 2.5
> 
> Also fixed some property descriptions / display names / xml formatting issues
> 
> Also added some missing site_properties elements
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  38c7537 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-ambari-config.xml
>  64d7946 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml
>  8358266 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  bc65e3c 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
>  9371530 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-output-config.xml
>  85654c8 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
>  e7cd476 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-system_log-env.xml
>  b8dd4b9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml
>  6272dd1 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml
>  66b9bba 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-log4j.xml.j2
>  cc5addf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  370588a 
>   ambari-web/app/data/HDP2/site_properties.js e2a4d4e 
> 
> Diff: https://reviews.apache.org/r/55107/diff/
> 
> 
> Testing
> ---
> 
> Check configuration differences between logsearch in ambari version 2.4 and 
> 2.5.
> Manually did a yum upgrade with new packages, then during ambari upgrade:
> - checked the new configurations were added properly
> - implemented renames/deletions in UpgradeCatalog250.java
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 55213: PERF: disabling security fails

2017-01-05 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55213/
---

Review request for Ambari, Myroslav Papirkovskyy, Sid Wagle, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-19388
https://issues.apache.org/jira/browse/AMBARI-19388


Repository: ambari


Description
---

When you are trying to disable security om perf cluster it fails.
1) For cluster with 1200 agents it works fine but for cluster with 1850 agents 
it fails.
2) According to what i found, root cause is PUT request to 
http://:8080/api/v1/clusters/ with data like 
"security_type" : "NONE". So, this request trying to change security type from 
KERBEROS to NONE and fails by timeout of three minutes.
3) Interesting thing, request to change security type fails and UI showing 
Error on disable security window. But in the same time in BG operations process 
which destroying keytabs proceed work.
4) One more thing. After failed disabling kerberos, if you will click restart 
the same request(update security type) will finish work in a few seconds.
So, what we need to do is to connect profiler and find out what exactly take so 
much time for request to change security type.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 0cf46df 

Diff: https://reviews.apache.org/r/55213/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 55212: When deleting services UI shows a lot of configs to be changing but none changes

2017-01-05 Thread Oleg Nechiporenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55212/#review160588
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Янв. 5, 2017, 2:49 п.п., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55212/
> ---
> 
> (Updated Янв. 5, 2017, 2:49 п.п.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-19387
> https://issues.apache.org/jira/browse/AMBARI-19387
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> It appears that UI feedback shows the sum total of configs recommended by 
> stack advisor even if only a subset of the configs are actually applied.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/info/configs.js b5538e0 
>   ambari-web/app/controllers/main/service/item.js 8921e22 
>   ambari-web/app/mixins/common/configs/enhanced_configs.js f92aac1 
>   ambari-web/test/controllers/main/service/info/config_test.js a06ff8a 
>   ambari-web/test/mixins/common/configs/enhanced_configs_test.js a9c9770 
> 
> Diff: https://reviews.apache.org/r/55212/diff/
> 
> 
> Testing
> ---
> 
> 20129 tests complete (21 seconds)
>   153 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Re: Review Request 55193: Executing ambari-server unit tests with JDK 1.8 results in unit test failures

2017-01-05 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55193/#review160589
---


Ship it!




Ship It!

- Jonathan Hurley


On Jan. 4, 2017, 8:50 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55193/
> ---
> 
> (Updated Jan. 4, 2017, 8:50 p.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Jaimin Jetly, Jonathan Hurley, 
> Laszlo Puskas, and Nate Cole.
> 
> 
> Bugs: AMBARI-19365
> https://issues.apache.org/jira/browse/AMBARI-19365
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following unit tests fails when executed with JDK 1.8
> ```
> mvn test -Dtest=DataStoreImplTest
> mvn clean test -Dtest=UpgradeCatalog222Test
> mvn test -Dtest=KerberosCheckerTest,AmbariBasicAuthenticationFilterTest
> ```
> Same unit tests passes if the environment is switched to use JDK 1.7
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java
>  e0a3d55 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/LoginContextHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosCheckerTest.java
>  570a50b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/metric/system/impl/JvmMetricsSourceTest.java
>  a6aa5d5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilterTest.java
>  7e36128 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
>  9d4fb3e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/persistence/DataStoreImplTest.java
>  60643b3 
> 
> Diff: https://reviews.apache.org/r/55193/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests with Oracle JDK 1.7 and Oracle JDK 1.8.
> Manually tested Ambari
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 55210: Config Groups: Save button not enabled while trying to overwrite configs

2017-01-05 Thread Andrii Tkach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55210/#review160584
---


Ship it!




Ship It!

- Andrii Tkach


On Jan. 5, 2017, 1:46 p.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55210/
> ---
> 
> (Updated Jan. 5, 2017, 1:46 p.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: ambari-19182
> https://issues.apache.org/jira/browse/ambari-19182
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR: 
> -> For a service, create a config group
> -> Go to configs page, select the config group. Now try to overwrite a 
> config, Save button is not enabled here.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/models/configs/objects/service_config.js 7d07467 
>   
> ambari-web/test/controllers/main/admin/highAvailability/journalNode/step4_controller_test.js
>  ba92b54 
>   
> ambari-web/test/controllers/main/admin/highAvailability/resourceManager/step3_controller_test.js
>  665d8e6 
>   ambari-web/test/utils/config_test.js 7c2515a 
> 
> Diff: https://reviews.apache.org/r/55210/diff/
> 
> 
> Testing
> ---
> 
> 20126 tests complete (25 seconds)
>   153 tests pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 55210: Config Groups: Save button not enabled while trying to overwrite configs

2017-01-05 Thread Oleg Nechiporenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55210/
---

Review request for Ambari and Andrii Tkach.


Bugs: ambari-19182
https://issues.apache.org/jira/browse/ambari-19182


Repository: ambari


Description
---

STR: 
-> For a service, create a config group
-> Go to configs page, select the config group. Now try to overwrite a config, 
Save button is not enabled here.


Diffs
-

  ambari-web/app/models/configs/objects/service_config.js 7d07467 
  
ambari-web/test/controllers/main/admin/highAvailability/journalNode/step4_controller_test.js
 ba92b54 
  
ambari-web/test/controllers/main/admin/highAvailability/resourceManager/step3_controller_test.js
 665d8e6 
  ambari-web/test/utils/config_test.js 7c2515a 

Diff: https://reviews.apache.org/r/55210/diff/


Testing
---

20126 tests complete (25 seconds)
  153 tests pending


Thanks,

Oleg Nechiporenko

Review Request 55209: ATS service check failed on navigating to Hive View

2017-01-05 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55209/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-19382
https://issues.apache.org/jira/browse/AMBARI-19382


Repository: ambari


Description
---

The ats url is not correctly form when it is https. Using utils to form ats url 
now.


Diffs
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/HelpService.java
 702b38a 
  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/atsJobs/ATSParserFactory.java
 4ff2621 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HelpService.java
 9fe 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/atsJobs/ATSParserFactory.java
 343202e 

Diff: https://reviews.apache.org/r/55209/diff/


Testing
---

Manual.


Thanks,

Gaurav Nagar

Review Request 55206: AMBARI-19385: Resolve variables in workflow if workflow path in coordinator contains variables.

2017-01-05 Thread Padma Priya N 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55206/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
Kulshreshtha.


Bugs: AMBARI-19385
https://issues.apache.org/jira/browse/AMBARI-19385


Repository: ambari


Description
---

Resolve variables in workflow ,if workflow path in coordinator contains 
variables..
Steps:
while creating coordinator use variables while configuring the workflow path. 
User is not prompted for the variables in workflow.

Expected.
the variables in workflow should be prompted for user to submit.

Also need to add custom properties that the user can configure while submitting 
workflow/coordinator/bundle.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
122b956 
  contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
904901c 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
3454374 
  contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
8b685f0 
  
contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js
 0ebd9a7 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs
 5b5cd68 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs
 f0d9ee3 

Diff: https://reviews.apache.org/r/55206/diff/


Testing
---

Manual


Thanks,

Padma Priya N

Review Request 55205: Configs changes after adding/deleting host component: value shouldn't be changed if it differs in host names order only

2017-01-05 Thread Andriy Babiichuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55205/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-19383
https://issues.apache.org/jira/browse/AMBARI-19383


Repository: ambari


Description
---

There are properties containing list of host names in their value that are 
affected by adding or deleting component to host (for example, storm 
.zookeeper.servers). In some cases, if current and recommended value differ in 
host names order only, these values are handled as different ones.


Diffs
-

  ambari-web/app/controllers/main/host/details.js 4a7cce4 
  ambari-web/app/utils/config.js d0dbb69 
  ambari-web/app/utils/configs/add_component_config_initializer.js 7e3fedf 
  ambari-web/app/utils/configs/hosts_based_initializer_mixin.js d0d2503 
  ambari-web/test/controllers/main/host/details_test.js a4cb177 
  ambari-web/test/utils/config_test.js 8c450ed 

Diff: https://reviews.apache.org/r/55205/diff/


Testing
---

20114 tests complete (24 seconds)
  153 tests pending


Thanks,

Andriy Babiichuk

Re: Review Request 55195: solr_cloud_util.py should update solr data in ZK if it has changed

2017-01-05 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55195/#review160576
---




ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 (line 62)


where is the reload collection action? that basically means we will need to 
restart solr after this operation (if something changed)


- Oliver Szabo


On Jan. 5, 2017, 9:45 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55195/
> ---
> 
> (Updated Jan. 5, 2017, 9:45 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19374
> https://issues.apache.org/jira/browse/AMBARI-19374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> solr_cloud_util.py updates only solrconfig.xml changes in the zookeeper, it 
> should update any kind of solr data change.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  521c9c6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  a568cb7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  9ff9c74 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  ac4e54e 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> f2fec70 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> 00dd641 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 584763d 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 
> 32219b3 
> 
> Diff: https://reviews.apache.org/r/55195/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster:
> 
> - installing new services
> - restarting services
> - upgrading services
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 55203: AMBARI-19380. Workflow Draft Save-Not working

2017-01-05 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55203/#review160575
---


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 5, 2017, 10:02 a.m., Madhan Reddy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55203/
> ---
> 
> (Updated Jan. 5, 2017, 10:02 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19380
> https://issues.apache.org/jira/browse/AMBARI-19380
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Workflow should be able to save as draft even if it has errors. The 
> configuration should be stored as .draft.json in the proper location. 
> On retrieving, user should be able to load the draft on choosing the draft.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> b02e021 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 
> 8514cb0 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
>  6e1b054 
> 
> Diff: https://reviews.apache.org/r/55203/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>

Review Request 55203: AMBARI-19380. Workflow Draft Save-Not working

2017-01-05 Thread Madhan Reddy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55203/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
Kulshreshtha.


Bugs: AMBARI-19380
https://issues.apache.org/jira/browse/AMBARI-19380


Repository: ambari


Description
---

Workflow should be able to save as draft even if it has errors. The 
configuration should be stored as .draft.json in the proper location. 
On retrieving, user should be able to load the draft on choosing the draft.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
b02e021 
  contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 
8514cb0 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 6e1b054 

Diff: https://reviews.apache.org/r/55203/diff/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 55195: solr_cloud_util.py should update solr data in ZK if it has changed

2017-01-05 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55195/
---

(Updated Jan. 5, 2017, 9:45 a.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

update unit tests


Bugs: AMBARI-19374
https://issues.apache.org/jira/browse/AMBARI-19374


Repository: ambari


Description
---

solr_cloud_util.py updates only solrconfig.xml changes in the zookeeper, it 
should update any kind of solr data change.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 521c9c6 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 a568cb7 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 9ff9c74 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 ac4e54e 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
f2fec70 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 00dd641 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 584763d 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 32219b3 

Diff: https://reviews.apache.org/r/55195/diff/


Testing
---

Tested on local cluster:

- installing new services
- restarting services
- upgrading services


Thanks,

Miklos Gergely

Re: Review Request 55170: UI elements misalignment in dashboard screen of WFD

2017-01-05 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55170/#review160573
---


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 4, 2017, 12:32 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55170/
> ---
> 
> (Updated Jan. 4, 2017, 12:32 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Prabhjyot Singh.
> 
> 
> Bugs: AMBARI-19359
> https://issues.apache.org/jira/browse/AMBARI-19359
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We have applied CSS changes to fix the allignment of UI elements.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 4e8d82a 
> 
> Diff: https://reviews.apache.org/r/55170/diff/
> 
> 
> Testing
> ---
> 
> We have tested the UI styles by filtering the dashboard with Workflows, 
> Coordinators, Bundles
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 55170: UI elements misalignment in dashboard screen of WFD

2017-01-05 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55170/#review160572
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Jan. 4, 2017, 12:32 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55170/
> ---
> 
> (Updated Jan. 4, 2017, 12:32 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> Pallav Kulshreshtha, and Prabhjyot Singh.
> 
> 
> Bugs: AMBARI-19359
> https://issues.apache.org/jira/browse/AMBARI-19359
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We have applied CSS changes to fix the allignment of UI elements.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 4e8d82a 
> 
> Diff: https://reviews.apache.org/r/55170/diff/
> 
> 
> Testing
> ---
> 
> We have tested the UI styles by filtering the dashboard with Workflows, 
> Coordinators, Bundles
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 55087: Zeppelin stop failed during EU while deleting pid file with customized service user

2017-01-05 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55087/#review160567
---


Ship it!




Ship It!

- Gaurav Nagar


On Dec. 29, 2016, 5:09 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55087/
> ---
> 
> (Updated Dec. 29, 2016, 5:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19316
> https://issues.apache.org/jira/browse/AMBARI-19316
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Zeppelin stop during upgrade fails due to the following permission issue
> - rm: cannot remove 
> ‘/var/run/zeppelin/zeppelin-cstm-zeppelin-ctr-e85-1482808692054-0723-01-03.hwx.site.pid’:
>  Permission denied
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  04089ce 
> 
> Diff: https://reviews.apache.org/r/55087/diff/
> 
> 
> Testing
> ---
> 
> Tested on CentOS 6
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 55196: Not able to save FS action node after populating job xml value

2017-01-05 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55196/
---

(Updated Jan. 5, 2017, 8:34 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Renjith Kamath.


Bugs: AMBARI-19367
https://issues.apache.org/jira/browse/AMBARI-19367


Repository: ambari


Description (updated)
---

We have intiated the job-xml property in the FS action editor intialization.


Diffs
-

  contrib/views/wfmanager/.gitignore PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action.js 
6233b62 

Diff: https://reviews.apache.org/r/55196/diff/


Testing
---

We have created the FS-action editor and added job-xml properties and tested 
preview xml.


Thanks,

venkat sairam

Review Request 55196: Not able to save FS action node after populating job xml value

2017-01-05 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55196/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
Pallav Kulshreshtha, and Renjith Kamath.


Bugs: AMBARI-19367
https://issues.apache.org/jira/browse/AMBARI-19367


Repository: ambari


Description
---

We have intiated the job xml property in the FS action editor intialization.


Diffs
-

  contrib/views/wfmanager/.gitignore PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action.js 
6233b62 

Diff: https://reviews.apache.org/r/55196/diff/


Testing
---

We have created the FS-action editor and added job-xml properties and tested 
preview xml.


Thanks,

venkat sairam