date:20170214


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/#review165612
---




contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 
120)


This will select first db from dblist.
Are we always assuming that only first db is selected? Or user can select 
the database from the side pane to execute query?


- Gaurav Nagar


On Feb. 14, 2017, 1:59 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56661/
> ---
> 
> (Updated Feb. 14, 2017, 1:59 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20009
> https://issues.apache.org/jira/browse/AMBARI-20009
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Tables are not listed when we select the database and the process selection 
> of database is not clear
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 
> 5a869c2 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 88202ff 
> 
> Diff: https://reviews.apache.org/r/56661/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56669: Ambari Views do not appear in full screen view


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56669/#review165611
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 14, 2017, 5:42 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56669/
> ---
> 
> (Updated Feb. 14, 2017, 5:42 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20012
> https://issues.apache.org/jira/browse/AMBARI-20012
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> changing the css in on enter and on exit of the route.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/routes/view.js 752f14d 
> 
> Diff: https://reviews.apache.org/r/56669/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/
---

(Updated Feb. 15, 2017, 12:25 a.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Juanjo  
Marron.


Changes
---

Addressed review comments


Repository: ambari


Description
---

Updated to remove deprecated property and updated property in latest release


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 96b7750 

Diff: https://reviews.apache.org/r/56677/diff/


Testing
---


Thanks,

Bharat Viswanadham

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari



> On Feb. 14, 2017, 11:02 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml,
> >  line 157
> > 
> >
> > During a fresh install this is correct.
> > 
> > I'm asking what the behavior should be for the property that is being 
> > deleted during a stack upgrade, EU/RU to this version of Kafka.
> 
> Bharat Viswanadham wrote:
> During EU/RU, property log.cleanup.interval.mins should be deleted. 
> So,during EU/RU the old property should be deleted and new property should be 
> replaced.

In that case, keep the old property, but add this annotation.
true

This will allow EU/RU to attempt to delete the property when moving to that 
stack version.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review165588
---


On Feb. 14, 2017, 7:35 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56677/
> ---
> 
> (Updated Feb. 14, 2017, 7:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Juanjo  
> Marron.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated to remove deprecated property and updated property in latest release
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> Diff: https://reviews.apache.org/r/56677/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari



> On Feb. 14, 2017, 11:02 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml,
> >  line 157
> > 
> >
> > During a fresh install this is correct.
> > 
> > I'm asking what the behavior should be for the property that is being 
> > deleted during a stack upgrade, EU/RU to this version of Kafka.

During EU/RU, property log.cleanup.interval.mins should be deleted. So,during 
EU/RU the old property should be deleted and new property should be replaced.


- Bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review165588
---


On Feb. 14, 2017, 7:35 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56677/
> ---
> 
> (Updated Feb. 14, 2017, 7:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Juanjo  
> Marron.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated to remove deprecated property and updated property in latest release
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> Diff: https://reviews.apache.org/r/56677/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 56597: Externalize the logic for making navigation bar interactive

2017-02-14 Thread Jaimin Jetly


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56597/#review165592
---


Ship it!




Ship It!

- Jaimin Jetly


On Feb. 13, 2017, 11:50 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56597/
> ---
> 
> (Updated Feb. 13, 2017, 11:50 a.m.)
> 
> 
> Review request for Ambari and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-19983
> https://issues.apache.org/jira/browse/AMBARI-19983
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Externalize the logic for making navigation bar interactive
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/data/clusters/info.json PRE-CREATION 
>   ambari-web/app/styles/side_navigation.less 48b8699 
>   ambari-web/app/styles/theme/bootstrap-ambari.css adbddcd 
>   ambari-web/app/templates/application.hbs f18d314 
>   ambari-web/app/templates/main/side-menu-item.hbs 27739c8 
>   ambari-web/app/views/application.js f79aad9 
>   ambari-web/app/views/main/menu.js d82d56a 
>   ambari-web/brunch-config.js d646fdc 
>   ambari-web/vendor/scripts/theme/bootstrap-ambari.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56597/diff/
> 
> 
> Testing
> ---
> 
> 20325 passing (22s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari



> On Feb. 14, 2017, 11:02 p.m., Alejandro Fernandez wrote:
> >

This property is updated in Kafka 0.8.1 
https://issues.apache.org/jira/browse/KAFKA-1113

So, during EU/RU this property should be deleted. (Here to this version of 
Kafka means, is it to latest version of Kafka in later HDP relase?)


- Bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review165588
---


On Feb. 14, 2017, 7:35 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56677/
> ---
> 
> (Updated Feb. 14, 2017, 7:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Juanjo  
> Marron.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated to remove deprecated property and updated property in latest release
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> Diff: https://reviews.apache.org/r/56677/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review165588
---




ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 (line 157)


During a fresh install this is correct.

I'm asking what the behavior should be for the property that is being 
deleted during a stack upgrade, EU/RU to this version of Kafka.


- Alejandro Fernandez


On Feb. 14, 2017, 7:35 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56677/
> ---
> 
> (Updated Feb. 14, 2017, 7:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Juanjo  
> Marron.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated to remove deprecated property and updated property in latest release
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> Diff: https://reviews.apache.org/r/56677/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

2017-02-14 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56418/#review165585
---


Ship it!




Ship It!

- Robert Nettleton


On Feb. 9, 2017, 11:14 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56418/
> ---
> 
> (Updated Feb. 9, 2017, 11:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert 
> Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19909
> https://issues.apache.org/jira/browse/AMBARI-19909
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Export Blueprints does not contain the settings object and hence the 
> credential store values
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
>  1a9ea91 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java
>  1fe48df 
> 
> Diff: https://reviews.apache.org/r/56418/diff/
> 
> 
> Testing
> ---
> 
> Issued 
> http://c6401.ambari.apache.org:8080/api/v1/clusters/credential?format=blueprint
>  command to ensure that the settings object is present.
> Resultant blueprint has the following object added:
> "settings" : [
> {
>   "recovery_settings" : [
> {
>   "recovery_enabled" : "true"
> }
>   ]
> },
> {
>   "service_settings" : [
> {
>   "name" : "OOZIE",
>   "credential_store_enabled" : "true"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "HIVE",
>   "credential_store_enabled" : "true"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "HDFS"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "AMBARI_METRICS"
> }
>   ]
> },
> {
>   "component_settings" : [
> {
>   "recovery_enabled" : "true",
>   "name" : "METRICS_COLLECTOR"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "SECONDARY_NAMENODE"
> },
> {
>   "recovery_enabled" : "true",
>   "name" : "WEBHCAT_SERVER"
> }
>   ]
> }
>   ]
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup

2017-02-14 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165584
---


Ship it!




Ship It!

- Robert Nettleton


On Feb. 14, 2017, 7:06 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 14, 2017, 7:06 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> This patch still does not contain atlas/ranger fixes (it will, that review is 
> mosly for review, i will include ranger/atlas changes later).
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> cd88fec 
> 
> Diff: https://reviews.apache.org/r/56671/diff/
> 
> 
> Testing
> ---
> 
> unit tests done, still writing unit tests for atlas/ranger additions.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari

> On Feb. 14, 2017, 8:39 p.m., Alejandro Fernandez wrote:
> >

But when some one does fresh install of HDP 2.6 this property should not be 
there correct? So, if i still have this 

log.cleanup.interval.mins
10
The frequency in minutes that the log cleaner checks whether 
any log segment is eligible for deletion to meet the retention policies.

  along with new property as below, both will be there when do we fresh 
install. Am i correct or I am missing something?

   log.retention.check.interval.ms
   60

 The frequency in milliseconds that the log cleaner checks whether any log 
segment is eligible for deletion to meet the retention policies.

- Bharat

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review165570
---

On Feb. 14, 2017, 7:35 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56677/
> ---
> 
> (Updated Feb. 14, 2017, 7:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Juanjo  
> Marron.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated to remove deprecated property and updated property in latest release
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> Diff: https://reviews.apache.org/r/56677/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Review Request 56685: Document security issue related to setting security.agent.hostname.validate to false

2017-02-14 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56685/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20018
https://issues.apache.org/jira/browse/AMBARI-20018


Repository: ambari


Description
---

Document security issue related to setting security.agent.hostname.validate to 
"false".

If set to "false", invalid hostnames may be used in OpenSSL commands used to 
create the agent-side certificates when 2-way SSL is enabled. This could lead 
to issues when executing OpenSSL as described in CVE-2014-3582. See 
https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Vulnerabilities.


Diffs
-

  ambari-server/docs/configuration/index.md 50864f2 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 5020790 

Diff: https://reviews.apache.org/r/56685/diff/


Testing
---

No testing necessary.  Documentation change, only.


Thanks,

Robert Levas

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165571
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 14, 2017, 7:06 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 14, 2017, 7:06 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> This patch still does not contain atlas/ranger fixes (it will, that review is 
> mosly for review, i will include ranger/atlas changes later).
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> cd88fec 
> 
> Diff: https://reviews.apache.org/r/56671/diff/
> 
> 
> Testing
> ---
> 
> unit tests done, still writing unit tests for atlas/ranger additions.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/#review165570
---




ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 (line 157)


Does log.cleanup.interval.mins need to be deleted during stack upgrades to 
HDP 2.6?

If so, you can annotate it with a "deleted" tag so that EU/RU will delete 
it automatically.

Set  for all properties.


- Alejandro Fernandez


On Feb. 14, 2017, 7:35 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56677/
> ---
> 
> (Updated Feb. 14, 2017, 7:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Juanjo  
> Marron.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Updated to remove deprecated property and updated property in latest release
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  96b7750 
> 
> Diff: https://reviews.apache.org/r/56677/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Review Request 56679: Hosts page moving through pages gets progressively slower to the point of being unusable

2017-02-14 Thread Andrii Tkach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56679/
---

Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, and Yusaku Sako.


Bugs: AMBARI-20016
https://issues.apache.org/jira/browse/AMBARI-20016


Repository: ambari


Description
---

STR:
On a 1000-node cluster, go to Hosts page
Set the page size to 100 (shows hosts 1-100)
Using the paging controls, go to the next page (shows hosts 101-200) - this 
takes several seconds
Using the paging controls, go to the next page (shows hosts 201-300) - this 
takes longer
Repeat showing the next set of hosts. This gets progressively slower. I gave up 
when I hit 701-800 since the page got totally stuck after waiting for 3 minutes.


Diffs
-

  ambari-web/app/controllers/main.js 87a483e 
  ambari-web/app/controllers/main/service/add_controller.js f312a5a 
  ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
4cf22d4 
  ambari-web/app/controllers/wizard/step7_controller.js 1d24ee3 
  ambari-web/app/mappers/alert_definition_summary_mapper.js 8b59c7c 
  ambari-web/app/mappers/alert_definitions_mapper.js c400b89 
  ambari-web/app/mappers/alert_groups_mapper.js c079c21 
  ambari-web/app/mappers/alert_instances_mapper.js 269941b 
  ambari-web/app/mappers/alert_notification_mapper.js 9567c77 
  ambari-web/app/mappers/cluster_mapper.js 5689867 
  ambari-web/app/mappers/components_state_mapper.js 89d5af2 
  ambari-web/app/mappers/configs/config_groups_mapper.js fe3d7a1 
  ambari-web/app/mappers/configs/service_config_version_mapper.js 68bf235 
  ambari-web/app/mappers/configs/themes_mapper.js 8ad51bd 
  ambari-web/app/mappers/hosts_mapper.js 3c7dd70 
  ambari-web/app/mappers/quicklinks_mapper.js 6cb1fe0 
  ambari-web/app/mappers/repository_version_mapper.js 48e460b 
  ambari-web/app/mappers/root_service_mapper.js 1e0e070 
  ambari-web/app/mappers/server_data_mapper.js a99d8ae 
  ambari-web/app/mappers/service_mapper.js 9a330f9 
  ambari-web/app/mappers/service_metrics_mapper.js c4f37df 
  ambari-web/app/mappers/stack_mapper.js b1a5faf 
  ambari-web/app/mappers/stack_service_mapper.js 21c4db9 
  ambari-web/app/mappers/stack_upgrade_history_mapper.js 823ae80 
  ambari-web/app/mappers/stack_version_mapper.js bd37288 
  ambari-web/app/mappers/target_cluster_mapper.js f774213 
  ambari-web/app/mappers/users_mapper.js 80d7feb 
  ambari-web/app/mappers/widget_mapper.js 0991d4f 
  ambari-web/app/mixins/main/service/configs/config_overridable.js 93dea5f 
  ambari-web/app/mixins/main/service/groups_mapping.js 0781aa3 
  ambari-web/app/models/user.js 4dde8ec 
  ambari-web/app/utils/http_client.js 9b8346c 
  ambari-web/test/controllers/main/admin_test.js b2828d0 
  ambari-web/test/controllers/main/host/details_test.js 17b1eec 
  ambari-web/test/controllers/main/service/add_controller_test.js 715f46a 
  ambari-web/test/controllers/main/service/item_test.js 6430ab6 
  ambari-web/test/mappers/alert_groups_mapper_test.js 9480e3d 
  ambari-web/test/mixins/main/service/configs/config_overridable_test.js 
b1eb099 
  ambari-web/test/models/host_component_test.js d577005 
  ambari-web/test/models/host_stack_version_test.js 702e284 
  ambari-web/test/models/rack_test.js a63eaba 
  ambari-web/test/models/stack_service_test.js bc101e0 
  ambari-web/test/utils/http_client_test.js 589c44e 

Diff: https://reviews.apache.org/r/56679/diff/


Testing
---

20340 passing (34s)
  153 pending


Thanks,

Andrii Tkach

Review Request 56678: PixieDust - Decrease Service Check running time under 3 mins

2017-02-14 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56678/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.

Bugs: AMBARI-20017
https://issues.apache.org/jira/browse/AMBARI-20017

Repository: ambari

Description
---

Right now, Ambari has a timeout of 5-10 mins for Service Checks.
We need to ensure service checks pass in less than 3 mins for all services.

This means we need to potentially use a different configuration property if one
doesn't exist already so that QE can set it during the Ambari devdeploy tests
(in order to speed up the tests).

This will likely result in bugs in either the Ambari python scripts or the
actual services, for which we will create Jiras and assign to the appropriate
stack team.

This patch implements cluster_env/strict_service_check_type property. Possible
values are minimal (handled inside service check, runs shorter service check
action) and full (default action). If value is minimal, I also reduce service
check timeout when generating command on server in 2 times. This way we adapt
to service check timeouts that may be different for different services. If
service check takes 9 minutes of 10-minute timeout to pass on our non-busy
cluster, then it will probably take more then 10 minutes on customers real
cluster, and that is bad thing (bug).

Diffs
-

ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
b601893
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
13d0993

ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
3af8f08

Diff: https://reviews.apache.org/r/56678/diff/

Testing
---

mvn clean test

Thanks,

Dmitro Lisnichenko

Re: Review Request 56627: Cluster deployment fails if cluster template has fewer host_groups than that in blueprint

2017-02-14 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56627/#review165566
---


Ship it!




Ship It!

- Di Li


On Feb. 14, 2017, 12:37 a.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56627/
> ---
> 
> (Updated Feb. 14, 2017, 12:37 a.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19991
> https://issues.apache.org/jira/browse/AMBARI-19991
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster creation REST API request gets accepted when, cluster template does 
> not list all the host_groups mentioned in the blueprint. But cluster 
> deployment fails showing error message in the logs
> Caused by: java.lang.IllegalArgumentException: 
> TopologyManager.ConfigureClusterTask - prerequisites for config request 
> processing not yet satisfied
> at 
> org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:908)
> at 
> org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:889)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
>  d0a4df9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java
>  1f31d05 
> 
> Diff: https://reviews.apache.org/r/56627/diff/
> 
> 
> Testing
> ---
> 
> Tested manually, updated test cases
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 56636: When yarn-site.xml is changed, MapReduce related components should be required to restart

2017-02-14 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/#review165564
---


Ship it!




Ship It!

- Di Li


On Feb. 14, 2017, 3 a.m., Yuanbo Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56636/
> ---
> 
> (Updated Feb. 14, 2017, 3 a.m.)
> 
> 
> Review request for Ambari and Di Li.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some properties in yarn-site.xml are used by MR components, such as 
> "yarn.admin.acl", it's a good practice to have MR restart when yarn-site.xml 
> is modified.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 
> 25e242b 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 
> 14eae07 
> 
> Diff: https://reviews.apache.org/r/56636/diff/
> 
> 
> Testing
> ---
> 
> The test failure in https://issues.apache.org/jira/browse/AMBARI-19911 is not 
> related.
> 
> 
> Thanks,
> 
> Yuanbo Liu
> 
>

Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56677/
---

Review request for Ambari and Alejandro Fernandez.


Repository: ambari


Description
---

Updated to remove deprecated property and updated property in latest release


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 96b7750 

Diff: https://reviews.apache.org/r/56677/diff/


Testing
---


Thanks,

Bharat Viswanadham

Re: Review Request 56661: HiveView2.0: Table list under DB panel on Query tab appears only if clicked on db name and Not clear how to set the database

2017-02-14 Thread DIPAYAN BHOWMICK


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/#review165558
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 14, 2017, 1:59 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56661/
> ---
> 
> (Updated Feb. 14, 2017, 1:59 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20009
> https://issues.apache.org/jira/browse/AMBARI-20009
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Tables are not listed when we select the database and the process selection 
> of database is not clear
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 
> 5a869c2 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 88202ff 
> 
> Diff: https://reviews.apache.org/r/56661/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup



> On Feb. 14, 2017, 6:44 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py,
> >  line 270
> > 
> >
> > My point was that domain variable is never defined in the same scope as 
> > the return statement, so it assumes that the len will always be 2.

domain is overriden only if the len is 2. otherwise it uses that its in 
kerberos-env (with that we can define users with custom REALM)


> On Feb. 14, 2017, 6:44 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py,
> >  line 283
> > 
> >
> > My point is that we should make our python code robust, since callers 
> > are free to change behavior. Just good robustness practice

i do not feel its really good, to doulbe check, but at least what i can do is 
throw an exception when the method is used wrongly.


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165546
---


On Feb. 14, 2017, 6:40 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 14, 2017, 6:40 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> This patch still does not contain atlas/ranger fixes (it will, that review is 
> mosly for review, i will include ranger/atlas changes later).
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/
---

(Updated Feb. 14, 2017, 7:06 p.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
Nettleton.


Changes
---

throw Exception in case of principal, realm or solr hosts param is missing.


Bugs: AMBARI-20013
https://issues.apache.org/jira/browse/AMBARI-20013


Repository: ambari


Description
---

- make sure solr keytab and solr user is created on logsearch/ranger/atlas hosts
- created a new solr_cloud_util method called add roles (curl for adding user 
roles)
- updated secure znode method (adding infra-solr by default)
- move generated security.json into a static file
- added a custom security.json which can be used instead of the generated 
security.json

This patch still does not contain atlas/ranger fixes (it will, that review is 
mosly for review, i will include ranger/atlas changes later).

In ranger/atlas stack, the following calls can be used for securing znode and 
update user-roles:

solr_cloud_util.secure_znode(config=params.config, 
zookeeper_quorum=params.zookeeper_quorum,
 
solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
 jaas_file=params.logsearch_jaas_file,
 java64_home=params.java64_home, 
sasl_users=["myuser1@HOST", "myuser2"])
 
and 

solr_cloud_util.add_solr_roles(params.config,
   roles = ["ranger_audit_user"],
   new_service_principals = ["audituser1", 
"audituser2"])
   
about ranger plugins:

there is a way to use these methods in other services like storm etc. , the 
problem is its needed to infra-solr be started, so if we include these in a lot 
of other services, it can really slows down the deployment. that is the reason 
why i kept the property dependencies in infra-solr-security-json config. other 
then that, with the changes ranger can start successfully if its added later to 
the cluster, and for plugins, infra-solr will be flagged to be restarted.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 4628211 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 e193a8c 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 ab9aa61 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 8d72f42 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 ed764f0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
bc8e351 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
49d1b10 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 fecd802 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 ba91e20 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
253e32e 
  ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
cd88fec 

Diff: https://reviews.apache.org/r/56671/diff/


Testing
---

unit tests done, still writing unit tests for atlas/ranger additions.


Thanks,

Oliver Szabo

Re: Review Request 56673: Perform Kinit on Kafka Start


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56673/#review165554
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 14, 2017, 6:58 p.m., Bharat Viswanadham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56673/
> ---
> 
> (Updated Feb. 14, 2017, 6:58 p.m.)
> 
> 
> Review request for Ambari and Juanjo  Marron.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Perform Kinit on Kafka Start
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  0901730 
> 
> Diff: https://reviews.apache.org/r/56673/diff/
> 
> 
> Testing
> ---
> 
> Kerberoized the cluster and then checked for kafka user the kinit has 
> performed or not.
> ran the command klist for kafka user and able to see cached ticket under 
> kafka user
> [root@idyll1 ~]# su kafka
> [kafka@idyll1 root]$ klist
> Ticket cache: FILE:/tmp/krb5cc_1004
> Default principal: kafka/idyll1.fyre.ibm@ibm.com
> 
> Valid starting ExpiresService principal
> 02/14/17 10:21:41  02/15/17 10:21:41  krbtgt/ibm@ibm.com
>   renew until 02/14/17 10:21:41
> 
> 
> Thanks,
> 
> Bharat Viswanadham
> 
>

Re: Review Request 56636: When yarn-site.xml is changed, MapReduce related components should be required to restart


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56636/#review165552
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 14, 2017, 3 a.m., Yuanbo Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56636/
> ---
> 
> (Updated Feb. 14, 2017, 3 a.m.)
> 
> 
> Review request for Ambari and Di Li.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some properties in yarn-site.xml are used by MR components, such as 
> "yarn.admin.acl", it's a good practice to have MR restart when yarn-site.xml 
> is modified.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml 
> 25e242b 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 
> 14eae07 
> 
> Diff: https://reviews.apache.org/r/56636/diff/
> 
> 
> Testing
> ---
> 
> The test failure in https://issues.apache.org/jira/browse/AMBARI-19911 is not 
> related.
> 
> 
> Thanks,
> 
> Yuanbo Liu
> 
>

Re: Review Request 56673: Perform Kinit on Kafka Start


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56673/
---

(Updated Feb. 14, 2017, 6:58 p.m.)


Review request for Ambari and Juanjo  Marron.


Repository: ambari


Description
---

Perform Kinit on Kafka Start


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
 0901730 

Diff: https://reviews.apache.org/r/56673/diff/


Testing
---

Kerberoized the cluster and then checked for kafka user the kinit has performed 
or not.
ran the command klist for kafka user and able to see cached ticket under kafka 
user
[root@idyll1 ~]# su kafka
[kafka@idyll1 root]$ klist
Ticket cache: FILE:/tmp/krb5cc_1004
Default principal: kafka/idyll1.fyre.ibm@ibm.com

Valid starting ExpiresService principal
02/14/17 10:21:41  02/15/17 10:21:41  krbtgt/ibm@ibm.com
renew until 02/14/17 10:21:41


Thanks,

Bharat Viswanadham

Re: Review Request 56669: Ambari Views do not appear in full screen view

2017-02-14 Thread DIPAYAN BHOWMICK


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56669/#review165549
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 14, 2017, 5:42 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56669/
> ---
> 
> (Updated Feb. 14, 2017, 5:42 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20012
> https://issues.apache.org/jira/browse/AMBARI-20012
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> changing the css in on enter and on exit of the route.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/routes/view.js 752f14d 
> 
> Diff: https://reviews.apache.org/r/56669/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 56607: AMBARI-19915 Add Ranger KMS SSL properties in ambari stack



> On Feb. 13, 2017, 7:18 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py,
> >  line 148
> > 
> >
> > Today, we have symlinks from /etc/$comp/conf -> 
> > /usr/hdp/current/$comp/conf so that configs still work during stack 
> > upgrades (RU/EU). This seems to be a flat directory.
> > 
> > How is it going to be used?
> > What will happen during stack upgrades or downgrades?
> 
> Mugdha Varadkar wrote:
> Hi Alejandro,
> 
> For Ranger KMS: the "conf" symlinks is created under the path 
> /etc/ranger/kms/. This flat directory path is created by rpm package. I added 
> this code if in case the path is not created, it may be created from Ambari, 
> also this path is needed to create some additional files.

What is actually stored in that directory?
If any files are overriden by installing a different version, then that will 
cause problems during stack upgrade.
We shouldn't be using fixed paths any more.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56607/#review165378
---


On Feb. 14, 2017, 1:18 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56607/
> ---
> 
> (Updated Feb. 14, 2017, 1:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19915
> https://issues.apache.org/jira/browse/AMBARI-19915
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Below SSL properties needs to be added in Ambari for Ranger KMS service
> - ranger.service.https.attrib.keystore.file
> - ranger.service.https.attrib.client.auth
> - ranger.service.https.attrib.keystore.keyalias  
> - ranger.service.https.attrib.keystore.pass
> - ranger.credential.provider.path
> - ranger.service.https.attrib.keystore.credential.alias
> 
> Along with addition of these properties, need to secure password property.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  8fd5c8d 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
> 12fde7e 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml
>  7dea07f 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  742cb93 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  05e8881 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  0fd1766 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 54072ad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  31b20cf 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 88486e6 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 44a9b7c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  4d70156 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 5b92e5f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 23564ad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  24db720 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 818a6c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER_KMS/configuration/ranger-kms-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 969c3dd 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> 57f9f34 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> b7f8cbb 
> 
> Diff: https://reviews.apache.org/r/56607/diff/
> 
> 
> Testing
> ---
> 
> Test Case:
> 
> Running tests for stack:2.5 service:RANGER_KMS
> test_configure_default (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,451 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-777, current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
> 2017-02-13 19:08:27,467 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> ok
> test_configure_secured (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,502 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> 2017-02-13 19:08:27,518 - Using hadoop conf dir: 
>

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165546
---




ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 (line 270)


My point was that domain variable is never defined in the same scope as the 
return statement, so it assumes that the len will always be 2.



ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 (line 283)


My point is that we should make our python code robust, since callers are 
free to change behavior. Just good robustness practice


- Alejandro Fernandez


On Feb. 14, 2017, 6:40 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 14, 2017, 6:40 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> This patch still does not contain atlas/ranger fixes (it will, that review is 
> mosly for review, i will include ranger/atlas changes later).
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> cd88fec 
> 
> Diff: https://reviews.apache.org/r/56671/diff/
> 
> 
> Testing
> ---
> 
> unit tests done, still writing unit tests for atlas/ranger additions.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/
---

(Updated Feb. 14, 2017, 6:40 p.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
Nettleton.


Changes
---

rename domain to realm


Bugs: AMBARI-20013
https://issues.apache.org/jira/browse/AMBARI-20013


Repository: ambari


Description
---

- make sure solr keytab and solr user is created on logsearch/ranger/atlas hosts
- created a new solr_cloud_util method called add roles (curl for adding user 
roles)
- updated secure znode method (adding infra-solr by default)
- move generated security.json into a static file
- added a custom security.json which can be used instead of the generated 
security.json

This patch still does not contain atlas/ranger fixes (it will, that review is 
mosly for review, i will include ranger/atlas changes later).

In ranger/atlas stack, the following calls can be used for securing znode and 
update user-roles:

solr_cloud_util.secure_znode(config=params.config, 
zookeeper_quorum=params.zookeeper_quorum,
 
solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
 jaas_file=params.logsearch_jaas_file,
 java64_home=params.java64_home, 
sasl_users=["myuser1@HOST", "myuser2"])
 
and 

solr_cloud_util.add_solr_roles(params.config,
   roles = ["ranger_audit_user"],
   new_service_principals = ["audituser1", 
"audituser2"])
   
about ranger plugins:

there is a way to use these methods in other services like storm etc. , the 
problem is its needed to infra-solr be started, so if we include these in a lot 
of other services, it can really slows down the deployment. that is the reason 
why i kept the property dependencies in infra-solr-security-json config. other 
then that, with the changes ranger can start successfully if its added later to 
the cluster, and for plugins, infra-solr will be flagged to be restarted.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 4628211 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 e193a8c 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 ab9aa61 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 8d72f42 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 ed764f0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
bc8e351 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
49d1b10 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 fecd802 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 ba91e20 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
253e32e 
  ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
cd88fec 

Diff: https://reviews.apache.org/r/56671/diff/


Testing
---

unit tests done, still writing unit tests for atlas/ranger additions.


Thanks,

Oliver Szabo

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup



> On Feb. 14, 2017, 6:32 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py,
> >  line 283
> > 
> >
> > Make this robust, if solr_hosts is empty, then this will throw an index 
> > out of bounds exception.

we cannot reach that state as we are only using that method if we have at least 
one element.


> On Feb. 14, 2017, 6:32 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py,
> >  line 262
> > 
> >
> > Make this more robust. This assumes that "@" exists.

if it does not exist it returns with the full string.


> On Feb. 14, 2017, 6:32 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py,
> >  line 270
> > 
> >
> > domain is never defined above so if the len is not 2 it will throw an 
> > error.

actually its defined as we get it as a parameter (from kerberos env)

but the name itself is wrong so i will rename it to realm. accidentally i used 
wrong naming here


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165538
---


On Feb. 14, 2017, 6:03 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 14, 2017, 6:03 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> This patch still does not contain atlas/ranger fixes (it will, that review is 
> mosly for review, i will include ranger/atlas changes later).
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
>

Re: Review Request 56641: Change Livy recovery folder permission to 0700


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56641/#review165544
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 14, 2017, 5:29 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56641/
> ---
> 
> (Updated Feb. 14, 2017, 5:29 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17
> https://issues.apache.org/jira/browse/AMBARI-17
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change Livy recovery folder permission to 0700
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  32615c3 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
>  2e92509 
>   ambari-server/src/test/python/stacks/2.5/SPARK/test_spark_livy.py b9199c7 
>   ambari-server/src/test/python/stacks/2.6/SPARK2/test_spark_livy2.py 75aec84 
> 
> Diff: https://reviews.apache.org/r/56641/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 56659: Add "Manage alert notifications" authorization


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/#review165542
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 14, 2017, 5:07 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56659/
> ---
> 
> (Updated Feb. 14, 2017, 5:07 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Dmitro 
> Lisnichenko, Laszlo Puskas, Robert Levas, Sebastian Toader, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20008
> https://issues.apache.org/jira/browse/AMBARI-20008
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "Manage alert notifications" authorization and protect resoure with it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  4010528 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
>  969772f 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
> 
> Diff: https://reviews.apache.org/r/56659/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 53686: Stage and Request status should be persisted in the database

2017-02-14 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53686/#review165540
---


Ship it!




Ship It!

- Nate Cole


On Feb. 6, 2017, 6:09 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53686/
> ---
> 
> (Updated Feb. 6, 2017, 6:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-18868
> https://issues.apache.org/jira/browse/AMBARI-18868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stage and Request status should be persisted in the database.
> 
> upgrading to ambari-3.0.0 should add status for all present stages and 
> request for the cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  7837a7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  dabcb98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java
>  31e11c1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
> 4a05b32 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java
>  3c415df 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskEventPublisher.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  02c4091 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> 1c4d0a3 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
> d2f899f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
>  74271b9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
>  7944d21 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  f9c8810 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java
>  9ca0470 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  4f90ef3 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
>  177ac70 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
>  ade625a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/alerts/AmbariPerformanceRunnableTest.java
>  7b1a5a2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  a0701b6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
>  619e367 
>   
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListenerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  b1c10f5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java
>  9d339e2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java
>  ed95b0b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  d7979e8 
> 
> Diff: https://reviews.apache.org/r/53686/diff/
> 
> 
> Testing
> ---
> 
> Verified manually on a cluster by making api requests and upgrading ambari.
> Add unit tests.
> Verified that the patch does not break any existing unit tests on dev box. 
> Jenkins job overall unit test result pending..
> Verified on 1000 node cluster that the patch does not regress big operations. 
> Executed Stop Services and Start Services API call which gernerated

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165538
---




ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 (line 262)


Make this more robust. This assumes that "@" exists.



ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 (line 270)


domain is never defined above so if the len is not 2 it will throw an error.



ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 (line 283)


Make this robust, if solr_hosts is empty, then this will throw an index out 
of bounds exception.


- Alejandro Fernandez


On Feb. 14, 2017, 6:03 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 14, 2017, 6:03 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> This patch still does not contain atlas/ranger fixes (it will, that review is 
> mosly for review, i will include ranger/atlas changes later).
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> cd88fec 
> 
> Diff: https://reviews.apache.org/r/56671/diff/
> 
> 
> Testing
> ---
> 
> unit tests done, still writing unit tests for atlas/ranger additions.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56599: ambari-server upgrade is not idempotent

2017-02-14 Thread Attila Magyar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/
---

(Updated Feb. 14, 2017, 6:19 p.m.)


Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
Levas, and Sebastian Toader.


Changes
---

fixed imports


Bugs: AMBARI-19984
https://issues.apache.org/jira/browse/AMBARI-19984


Repository: ambari


Description
---

Running ambari-upgrade multiple times cause an exception due to violation of 
unique database constraint (the same RoleAuthorization can be added multiple 
times to admin permissions).


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
 fb01cca 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/internal/InternalAuthenticationToken.java
 8e69004 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 4b33bcd 
  
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
 1e68f9d 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
 7fb8867 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
 0cd4f12f 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 2836858 

Diff: https://reviews.apache.org/r/56599/diff/


Testing
---

Added new unittest that checks if adding RoleAuthorization is idempotent.

Tested manually:
 - installed ambari 2.4
 - upgraded to ambari 2.5
 - set version back to 2.4 by running: update metainfo set metainfo_value = 
'2.4.0' where metainfo_key = 'version';
 - upgraded to ambari 2.5 again
 - started ambari-server checked the UI


Existing tests ran clealy

--
Ran 465 tests in 15.977s

Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39


Thanks,

Attila Magyar

Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/
---

Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
Nettleton.


Bugs: AMBARI-20013
https://issues.apache.org/jira/browse/AMBARI-20013


Repository: ambari


Description
---

- make sure solr keytab and solr user is created on logsearch/ranger/atlas hosts
- created a new solr_cloud_util method called add roles (curl for adding user 
roles)
- updated secure znode method (adding infra-solr by default)
- move generated security.json into a static file
- added a custom security.json which can be used instead of the generated 
security.json

This patch still does not contain atlas/ranger fixes (it will, that review is 
mosly for review, i will include ranger/atlas changes later).

In ranger/atlas stack, the following calls can be used for securing znode and 
update user-roles:

solr_cloud_util.secure_znode(config=params.config, 
zookeeper_quorum=params.zookeeper_quorum,
 
solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
 jaas_file=params.logsearch_jaas_file,
 java64_home=params.java64_home, 
sasl_users=["myuser1@HOST", "myuser2"])
 
and 

solr_cloud_util.add_solr_roles(params.config,
   roles = ["ranger_audit_user"],
   new_service_principals = ["audituser1", 
"audituser2"])
   
about ranger plugins:

there is a way to use these methods in other services like storm etc. , the 
problem is its needed to infra-solr be started, so if we include these in a lot 
of other services, it can really slows down the deployment. that is the reason 
why i kept the property dependencies in infra-solr-security-json config. other 
then that, with the changes ranger can start successfully if its added later to 
the cluster, and for plugins, infra-solr will be flagged to be restarted.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 4628211 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 e193a8c 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 ab9aa61 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 8d72f42 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 ed764f0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
bc8e351 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
49d1b10 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 fecd802 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 ba91e20 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
253e32e 
  ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
cd88fec 

Diff: https://reviews.apache.org/r/56671/diff/


Testing
---

unit tests done, still writing unit tests for atlas/ranger additions.


Thanks,

Oliver Szabo

Re: Review Request 56599: ambari-server upgrade is not idempotent

2017-02-14 Thread Attila Doroszlai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165534
---




ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
 (line 40)


[ERROR] 
/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java:40:
 Wrong order for 'java.util.LinkedHashSet' import. [ImportOrder]



ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
 (line 391)


[ERROR] 
/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java:38:8:
 Unused import - java.util.Collection. [UnusedImports]


- Attila Doroszlai


On Feb. 14, 2017, 3:38 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 14, 2017, 3:38 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/internal/InternalAuthenticationToken.java
>  8e69004 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
>  1e68f9d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
>  7fb8867 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  cee490b 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56599: ambari-server upgrade is not idempotent

2017-02-14 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165529
---


Ship it!




Ship It!

- Robert Levas


On Feb. 14, 2017, 9:38 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 14, 2017, 9:38 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/internal/InternalAuthenticationToken.java
>  8e69004 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
>  1e68f9d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
>  7fb8867 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  cee490b 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion



> On Feb. 14, 2017, 4:54 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java,
> >  line 780
> > 
> >
> > I thought Logger uses {} for the replacement token?  I wonder if this 
> > ever worked.

Sure, and it works. This line does not originate from me, I simply changed 
LOG.error(...) to error(...).


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165527
---


On Feb. 14, 2017, 3:27 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 14, 2017, 3:27 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  2dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-14 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165527
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 721)


I thought Logger uses {} for the replacement token?  I wonder if this ever 
worked.



ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
 (lines 30 - 36)


Pretty clear, but should doc anyway.



ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java
 (lines 22 - 25)


Any specific reason for a new Exception class?  There's remarkable changed 
that isn't covered by a "regular" AmbariException.


- Nate Cole


On Feb. 14, 2017, 10:27 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 14, 2017, 10:27 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  2dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-14 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165523
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (lines 85 - 107)


Can you provide some basic documentation for the methods here?



ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
 (lines 24 - 25)


Make this a JavaDoc comment for better visibility.


- Jonathan Hurley


On Feb. 14, 2017, 10:27 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 14, 2017, 10:27 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  2dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56231: AMBARI-19829: Several HDFS/YARN widgets on Heatmaps show N/A

2017-02-14 Thread Qin Liu



> On Feb. 13, 2017, 11:53 p.m., Aravindan Vijayan wrote:
> > Ship It!

Thank you so much Aravindan!


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56231/#review165406
---


On Feb. 14, 2017, 2:38 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56231/
> ---
> 
> (Updated Feb. 14, 2017, 2:38 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Aravindan Vijayan, and Dmytro Sen.
> 
> 
> Bugs: AMBARI-19829
> https://issues.apache.org/jira/browse/AMBARI-19829
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The following HDFS/YARN widgets on Heatmaps show N/A:
> 1. HDFS - HDFS Bytes Written, HDFS Bytes Read, DataNode Process Disk I/O 
> Utilization, and DataNode Process Network I/O Utilization
> 2. YARN - Container Failures
> 
> The issue was introduced by AMBARI-15835 "Rate metrics requesting widgets do 
> not show up on Ambari" which introduced rate metrics and applied rate metrics 
> to several HBASE/HDFS/YARN widgets on Summary pages as well as Heatmap pages. 
> Rate metrics work fine on Summary pages but they don't work on Heatmap pages 
> because current Heatmap design can only show point-in-time metrics and rate 
> metrics need a time range.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> bcfb2cc 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/widgets.json 
> 4a645b0 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/YARN_widgets.json
>  4b76a17 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/YARN_widgets.json
>  782f21d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> 4a645b0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/YARN_widgets.json
>  782f21d 
> 
> Diff: https://reviews.apache.org/r/56231/diff/
> 
> 
> Testing
> ---
> 
> Manually tested in UI.
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 56659: Add "Manage alert notifications" authorization

2017-02-14 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/#review165520
---


Ship it!




Ship It!

- Robert Levas


On Feb. 14, 2017, 7:21 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56659/
> ---
> 
> (Updated Feb. 14, 2017, 7:21 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20008
> https://issues.apache.org/jira/browse/AMBARI-20008
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "Manage alert notifications" authorization and protect resoure with it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  4010528 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
>  969772f 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 
> 
> Diff: https://reviews.apache.org/r/56659/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion



> On Feb. 10, 2017, 1:38 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  line 714
> > 
> >
> > Doc.

Method is deleted.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165118
---


On Feb. 14, 2017, 3:27 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 14, 2017, 3:27 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  2dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion



> On Feb. 10, 2017, 2:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  lines 715-729
> > 
> >
> > This is strange - why not make the DatabaseConsistencyCheckHelper do 
> > this exception handling/logic and call it directly instead of having yet 
> > another method call in AmbariServer?  Separation of concerns would be 
> > helpful.
> 
> Balázs Bence Sári wrote:
> I agree with this finding. I copied existing behavior that's why it is 
> here. I'll move it to DB checker.

Please have look at the new implementation. I simplified error handling here, 
however not completely removed. I left DB Consistency checker's concern to 
provide a check result and AmbariServer's concern to decide what to do with the 
check result (e.g. exit with 1 exit code if errors occured in the checks). 
However, I greatly simplified the overcomplicated logic there.


> On Feb. 10, 2017, 2:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  lines 724-726
> > 
> >
> > Use logging here, not System.out.println(...)
> 
> Balázs Bence Sári wrote:
> I copied existing behavior. I think the reason why it is here that the 
> python script checks the standard out, so the intention is to make sure this 
> line appears there, irrespectively of the logging config.

I reduced the occasions of System.out.println's in Ambari Server (a lot of them 
existed in the original version). I am hesitating to completely removing them 
as in this case the explicit intention is to make that line appear on 
System.out, not the application log (as the python script relies on the console 
output) and I think the most reliable way to achieve that is to use 
System.out.println.
If I try to achieve that with loggers:
1. Users may reconfigure logging, in that case the python script will miss the 
output.
2. Previously (not sure if it is still the case) Java server apps suffered from 
loggers sometimes not getting flushed when System.exit() was called.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165122
---


On Feb. 14, 2017, 3:27 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 14, 2017, 3:27 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  2dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56643: Hive View 2.0 upload table issues : char support, endline support and temp file deletion

2017-02-14 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56643/#review165518
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 14, 2017, 5:56 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56643/
> ---
> 
> (Updated Feb. 14, 2017, 5:56 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> following bugs in upload table feature have been resolved in this patch:
> 1. does not support to specify endlines in input file's fields
> 2. if column datatype is char or varchar it gives error.
> 3. temporary table does not get deleted if error occurs in table upload.
> Options
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js 
> 066168c 
>   contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 
> 29e9891 
>   contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js 
> b550dbe 
>   contrib/views/hive20/src/main/resources/ui/app/models/column.js 73a9824 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js
>  0e61905 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs
>  c63f502 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs
>  4f3b98a 
> 
> Diff: https://reviews.apache.org/r/56643/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 56656: Log Search should not hide external Solr button even if it's mandatory

2017-02-14 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56656/#review165519
---


Ship it!




Ship It!

- Robert Nettleton


On Feb. 14, 2017, 11:49 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56656/
> ---
> 
> (Updated Feb. 14, 2017, 11:49 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20006
> https://issues.apache.org/jira/browse/AMBARI-20006
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hiding the External Solr button may cause an issue, if the cluster was 
> installed via blueprint, without the stack advisor used. In this case the 
> value is stuck at false, and as the button is hidden it can't even turned on.
> 
> also
> - removed some unused code
> - moved some non project specific code from LogSearch to a new utility class 
> called WebUtil
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  70053d2 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  86c1edd 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  b15ae43 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
>  ace278f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrServiceLogPropsConfig.java
>  81935d4 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/WebUtil.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java
>  fdda542 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchSecurityContextFormationFilter.java
>  b427749 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchUsernamePasswordAuthenticationFilter.java
>  24ec2d4 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 0bdf319 
> 
> Diff: https://reviews.apache.org/r/56656/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/
---

(Updated Feb. 14, 2017, 3:27 p.m.)


Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.


Changes
---

Review comments addressed


Bugs: AMBARI-19957
https://issues.apache.org/jira/browse/AMBARI-19957


Repository: ambari


Description
---

Postgres allows multiple schemas on a database user's search path, that is 
users can query from tables in different schemas without the need of prefixing 
the tables in the query. 

This can lead to confusion when after an unsuccessful upgrade DBA's restore the 
tables into a different schema (e.g. public) to Ambari's configured one. As a 
result, Ambari server may see different data than indended.

New consistency checks on server startup warn the user in such situations.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 7aa8652 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
 2dd 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 1704546 
  ambari-server/src/main/python/ambari_server_main.py 7a21333 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 f73562d 

Diff: https://reviews.apache.org/r/56540/diff/


Testing
---

- Wrote new unit tests
- Run all tests for ambari-server (all passed)
- Performed manual testing


Thanks,

Balázs Bence Sári

Re: Review Request 56641: Change Livy recovery folder permission to 0700

2017-02-14 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56641/#review165515
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 14, 2017, 5:29 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56641/
> ---
> 
> (Updated Feb. 14, 2017, 5:29 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17
> https://issues.apache.org/jira/browse/AMBARI-17
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change Livy recovery folder permission to 0700
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
>  32615c3 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_livy2.py
>  2e92509 
>   ambari-server/src/test/python/stacks/2.5/SPARK/test_spark_livy.py b9199c7 
>   ambari-server/src/test/python/stacks/2.6/SPARK2/test_spark_livy2.py 75aec84 
> 
> Diff: https://reviews.apache.org/r/56641/diff/
> 
> 
> Testing
> ---
> 
> Manual verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 56663: Critical alert: 'Percent JournalNodes Available' appears after upgrade from ambari 2.2.2.0 to 2.5.0.0

2017-02-14 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56663/#review165513
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Лют. 14, 2017, 3:13 після полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56663/
> ---
> 
> (Updated Лют. 14, 2017, 3:13 після полудня)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20010
> https://issues.apache.org/jira/browse/AMBARI-20010
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1)Deploy cluster
> 2) Enable AMS Distr. mode
> 2)Make ambari only upgrade
> 
> *Actual result:* Critical alert: 'Percent JournalNodes Available' appears 
> after upgrade from ambari 2.2.2.0 to 2.5.0.0
> 
>{
>   "href" : "http://host1:8080/api/v1/clusters/cl1/alerts/129;,
>   "Alert" : {
> "cluster_name" : "cl1",
> "component_name" : null,
> "definition_id" : 60,
> "definition_name" : "journalnode_process_percent",
> "firmness" : "HARD",
> "host_name" : null,
> "id" : 129,
> "instance" : null,
> "label" : "Percent JournalNodes Available",
> "latest_timestamp" : 1485911969646,
> "maintenance_state" : "OFF",
> "occurrences" : 1,
> "original_timestamp" : 1485911969646,
> "repeat_tolerance" : 1,
> "repeat_tolerance_remaining" : 0,
> "scope" : "SERVICE",
> "service_name" : "HDFS",
> "state" : "CRITICAL",
> "text" : "affected: [3], total: [3]"
>   }
> },
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  1f93f1f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  cee490b 
> 
> Diff: https://reviews.apache.org/r/56663/diff/
> 
> 
> Testing
> ---
> 
> Unit test + manual tests
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 56663: Critical alert: 'Percent JournalNodes Available' appears after upgrade from ambari 2.2.2.0 to 2.5.0.0

2017-02-14 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56663/
---

(Updated Фев. 14, 2017, 3:13 п.п.)


Review request for Ambari, Jonathan Hurley, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-20010
https://issues.apache.org/jira/browse/AMBARI-20010


Repository: ambari


Description
---

STR:
1)Deploy cluster
2) Enable AMS Distr. mode
2)Make ambari only upgrade

*Actual result:* Critical alert: 'Percent JournalNodes Available' appears after 
upgrade from ambari 2.2.2.0 to 2.5.0.0

   {
  "href" : "http://host1:8080/api/v1/clusters/cl1/alerts/129;,
  "Alert" : {
"cluster_name" : "cl1",
"component_name" : null,
"definition_id" : 60,
"definition_name" : "journalnode_process_percent",
"firmness" : "HARD",
"host_name" : null,
"id" : 129,
"instance" : null,
"label" : "Percent JournalNodes Available",
"latest_timestamp" : 1485911969646,
"maintenance_state" : "OFF",
"occurrences" : 1,
"original_timestamp" : 1485911969646,
"repeat_tolerance" : 1,
"repeat_tolerance_remaining" : 0,
"scope" : "SERVICE",
"service_name" : "HDFS",
"state" : "CRITICAL",
"text" : "affected: [3], total: [3]"
  }
},


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 1f93f1f 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 cee490b 

Diff: https://reviews.apache.org/r/56663/diff/


Testing
---

Unit test + manual tests


Thanks,

Dmytro Sen

Re: Review Request 56664: JS error in the "Supervisors Live" widget

2017-02-14 Thread Denys Buzhor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56664/#review165510
---


Ship it!




Ship It!

- Denys Buzhor


On Feb. 14, 2017, 2:43 p.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56664/
> ---
> 
> (Updated Feb. 14, 2017, 2:43 p.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: AMBARI-20011
> https://issues.apache.org/jira/browse/AMBARI-20011
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Widget can't be edited because of JS-error
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/main/dashboard/widgets/supervisor_live.js b8e36ca 
> 
> Diff: https://reviews.apache.org/r/56664/diff/
> 
> 
> Testing
> ---
> 
> 20345 passing (24s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 56664: JS error in the "Supervisors Live" widget

2017-02-14 Thread Oleg Nechiporenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56664/
---

Review request for Ambari and Denys Buzhor.


Bugs: AMBARI-20011
https://issues.apache.org/jira/browse/AMBARI-20011


Repository: ambari


Description
---

Widget can't be edited because of JS-error


Diffs
-

  ambari-web/app/views/main/dashboard/widgets/supervisor_live.js b8e36ca 

Diff: https://reviews.apache.org/r/56664/diff/


Testing
---

20345 passing (24s)
  153 pending


Thanks,

Oleg Nechiporenko

Re: Review Request 56663: Critical alert: 'Percent JournalNodes Available' appears after upgrade from ambari 2.2.2.0 to 2.5.0.0

2017-02-14 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56663/#review165508
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 (line 183)


Doc.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 (line 191)


You can use {} here for the log parameter.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 (line 202)


You can use {} here for the log parameter.


- Jonathan Hurley


On Feb. 14, 2017, 9:09 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56663/
> ---
> 
> (Updated Feb. 14, 2017, 9:09 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20010
> https://issues.apache.org/jira/browse/AMBARI-20010
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1)Deploy cluster
> 2) Enable AMS Distr. mode
> 2)Make ambari only upgrade
> 
> *Actual result:* Critical alert: 'Percent JournalNodes Available' appears 
> after upgrade from ambari 2.2.2.0 to 2.5.0.0
> 
>{
>   "href" : "http://host1:8080/api/v1/clusters/cl1/alerts/129;,
>   "Alert" : {
> "cluster_name" : "cl1",
> "component_name" : null,
> "definition_id" : 60,
> "definition_name" : "journalnode_process_percent",
> "firmness" : "HARD",
> "host_name" : null,
> "id" : 129,
> "instance" : null,
> "label" : "Percent JournalNodes Available",
> "latest_timestamp" : 1485911969646,
> "maintenance_state" : "OFF",
> "occurrences" : 1,
> "original_timestamp" : 1485911969646,
> "repeat_tolerance" : 1,
> "repeat_tolerance_remaining" : 0,
> "scope" : "SERVICE",
> "service_name" : "HDFS",
> "state" : "CRITICAL",
> "text" : "affected: [3], total: [3]"
>   }
> },
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  1f93f1f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  cee490b 
> 
> Diff: https://reviews.apache.org/r/56663/diff/
> 
> 
> Testing
> ---
> 
> Unit test + manual tests
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 56660: AMBARI-20005:Credentials from one workflow are getting associated across other workflow

2017-02-14 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56660/#review165503
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 14, 2017, 1:06 p.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56660/
> ---
> 
> (Updated Feb. 14, 2017, 1:06 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20005
> https://issues.apache.org/jira/browse/AMBARI-20005
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by clearing credentials array when creating a workflow
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 1f02426 
> 
> Diff: https://reviews.apache.org/r/56660/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56661: HiveView2.0: Table list under DB panel on Query tab appears only if clicked on db name and Not clear how to set the database

2017-02-14 Thread venkat sairam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/
---

(Updated Feb. 14, 2017, 1:59 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Changes
---

Fixed review comments


Bugs: AMBARI-20009
https://issues.apache.org/jira/browse/AMBARI-20009


Repository: ambari


Description
---

Tables are not listed when we select the database and the process selection of 
database is not clear


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
88202ff 

Diff: https://reviews.apache.org/r/56661/diff/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56599: ambari-server upgrade is not idempotent

2017-02-14 Thread Jonathan Hurley



> On Feb. 13, 2017, 10:49 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java,
> >  lines 243-251
> > 
> >
> > Any reason you didn't use a Set here (especially since the contract 
> > only defines a Collection)?
> 
> Attila Magyar wrote:
> The existing code uses ArrayList. I'm not sure if it will break anything 
> if I change it to Set.
> 
> Attila Magyar wrote:
> @jhurley
> 
> If we change it to set then we should remove the setter, and use 
> addAuthorization() all over the place.
> 
> public void setAuthorizations(Collection 
> authorizations) {
>   this.authorizations = authorizations;
> }
> 
> 
> The setAuthorizations() is used at one place in production code, and in 
> 10 tests. But it will behave differently because it won't preserver the 
> ordering. Or we can use LinkedHashSet to preserve the ordering too. What do 
> you think?
> 
> Jonathan Hurley wrote:
> A LinkedHashSet will retain order - beyond that, since you're doing the 
> contains() check here which hash to iterate over the whole list, it seems to 
> make sense to use a Set.

I suggested using the LHS, but I don't think ReviewBoard published my comment. 
The reason I flagged this is because we're trying to enforce a data constraint 
using an if-statement (if !contains()) which could be error prone if this 
collection is modified elsewhere in the future. My thought was why not just use 
a collection that has this restriction built-in. If it's a pain to change for 
some reason (since callers use the setter method), then I'm OK leaving it. I 
thought it would be a relatively simply change.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165341
---


On Feb. 13, 2017, 8:48 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 13, 2017, 8:48 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  1c742ef 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Review Request 56661: HiveView2.0: Table list under DB panel on Query tab appears only if clicked on db name and Not clear how to set the database

2017-02-14 Thread venkat sairam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-20009
https://issues.apache.org/jira/browse/AMBARI-20009


Repository: ambari


Description
---

Tables are not listed when we select the database and the process selection of 
database is not clear


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
88202ff 

Diff: https://reviews.apache.org/r/56661/diff/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56607: AMBARI-19915 Add Ranger KMS SSL properties in ambari stack

2017-02-14 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56607/
---

(Updated Feb. 14, 2017, 1:18 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
and Velmurugan Periasamy.


Bugs: AMBARI-19915
https://issues.apache.org/jira/browse/AMBARI-19915


Repository: ambari


Description
---

Below SSL properties needs to be added in Ambari for Ranger KMS service
- ranger.service.https.attrib.keystore.file
- ranger.service.https.attrib.client.auth
- ranger.service.https.attrib.keystore.keyalias  
- ranger.service.https.attrib.keystore.pass
- ranger.credential.provider.path
- ranger.service.https.attrib.keystore.credential.alias

Along with addition of these properties, need to secure password property.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 8fd5c8d 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
12fde7e 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml
 7dea07f 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 742cb93 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 05e8881 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 0fd1766 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
54072ad 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 31b20cf 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
88486e6 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
44a9b7c 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 4d70156 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
5b92e5f 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
23564ad 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 24db720 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
818a6c0 
  
ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER_KMS/configuration/ranger-kms-site.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
969c3dd 
  ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
57f9f34 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py b7f8cbb 

Diff: https://reviews.apache.org/r/56607/diff/


Testing
---

Test Case:

Running tests for stack:2.5 service:RANGER_KMS
test_configure_default (test_kms_server.TestRangerKMS) ... 2017-02-13 
19:08:27,451 - Stack Feature Version Info: stack_version=2.5, 
version=2.5.0.0-777, current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
2017-02-13 19:08:27,467 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
ok
test_configure_secured (test_kms_server.TestRangerKMS) ... 2017-02-13 
19:08:27,502 - Stack Feature Version Info: stack_version=2.5, 
version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
2017-02-13 19:08:27,518 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
ok
test_start_default (test_kms_server.TestRangerKMS) ... 2017-02-13 19:08:27,533 
- Stack Feature Version Info: stack_version=2.5, version=2.5.0.0-777, 
current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
2017-02-13 19:08:27,550 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
2017-02-13 19:08:27,555 - Rangeradmin: Skip ranger admin if it's down !
ok
test_start_secured (test_kms_server.TestRangerKMS) ... 2017-02-13 19:08:27,568 
- Stack Feature Version Info: stack_version=2.5, version=2.5.0.0-801, 
current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
2017-02-13 19:08:27,597 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
2017-02-13 19:08:27,602 - RangeradminV2: Skip ranger admin if it's down !
2017-02-13 19:08:27,602 - KMS repository c1_kms exist
ok
test_stop_default (test_kms_server.TestRangerKMS) ... 2017-02-13 19:08:27,618 - 
Stack Feature Version Info: stack_version=2.5, version=2.5.0.0-777, 
current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
2017-02-13 19:08:27,639 - Using hadoop conf dir: 
/usr/hdp/current/hadoop-client/conf
ok

--
Ran 5 tests in 0.277s

OK

test_recommendRangerKMSConfigurations 
(test_stack_advisor.TestHDP26StackAdvisor) ... ok


Thanks,

Mugdha Varadkar

Review Request 56660: AMBARI-20005:Credentials from one workflow are getting associated across other workflow

2017-02-14 Thread Padma Priya N


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56660/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-20005
https://issues.apache.org/jira/browse/AMBARI-20005


Repository: ambari


Description
---

Fixed by clearing credentials array when creating a workflow


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 1f02426 

Diff: https://reviews.apache.org/r/56660/diff/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 56648: AMBARI-20001.Workflow manager- preview workflow has xml encodings


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56648/#review165496
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 14, 2017, 9:39 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56648/
> ---
> 
> (Updated Feb. 14, 2017, 9:39 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20001
> https://issues.apache.org/jira/browse/AMBARI-20001
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replaced encoded xml strings with actual values
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
> dde012d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/preview-dialog.js
>  cd6c171 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 
> a2210a6 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/preview-dialog.hbs
>  bbf7ce1 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
> e793aac 
> 
> Diff: https://reviews.apache.org/r/56648/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56647: AMBARI-20000.Workflow Manager optimising finding nodes


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56647/#review165495
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 14, 2017, 9:13 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56647/
> ---
> 
> (Updated Feb. 14, 2017, 9:13 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-2
> https://issues.apache.org/jira/browse/AMBARI-2
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Find node is optimized using cytoscape methods. object is serialized and 
> deserialized using JSOG rather than json.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js
>  65d097414b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js
>  ad664d7709 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> a5536af377 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
>  8202c6d484 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 
> 92820f9b42 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 
> b918d70200 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js
>  656df4bb73 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 02842c5d41 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs
>  0810f64285 
>   contrib/views/wfmanager/src/main/resources/ui/bower.json b66a190fcc 
>   contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js bf48e9c911 
> 
> Diff: https://reviews.apache.org/r/56647/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> belliraj hb
> 
>

Review Request 56659: Add "Manage alert notifications" authorization

2017-02-14 Thread Eugene Chekanskiy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/
---

Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-20008
https://issues.apache.org/jira/browse/AMBARI-20008


Repository: ambari


Description
---

Add "Manage alert notifications" authorization and protect resoure with it.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
 4010528 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
 969772f 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b79c945 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c502bc 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql c6d4ad0 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1be87bb 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql abe48e8 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 169a464 

Diff: https://reviews.apache.org/r/56659/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 56656: Log Search should not hide external Solr button even if it's mandatory


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56656/#review165494
---


Ship it!




Ship It!

- Oliver Szabo


On Feb. 14, 2017, 11:49 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56656/
> ---
> 
> (Updated Feb. 14, 2017, 11:49 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20006
> https://issues.apache.org/jira/browse/AMBARI-20006
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hiding the External Solr button may cause an issue, if the cluster was 
> installed via blueprint, without the stack advisor used. In this case the 
> value is stuck at false, and as the button is hidden it can't even turned on.
> 
> also
> - removed some unused code
> - moved some non project specific code from LogSearch to a new utility class 
> called WebUtil
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  70053d2 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  86c1edd 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  b15ae43 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
>  ace278f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrServiceLogPropsConfig.java
>  81935d4 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/WebUtil.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java
>  fdda542 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchSecurityContextFormationFilter.java
>  b427749 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchUsernamePasswordAuthenticationFilter.java
>  24ec2d4 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 0bdf319 
> 
> Diff: https://reviews.apache.org/r/56656/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 56656: Log Search should not hide external Solr button even if it's mandatory

2017-02-14 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56656/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-20006
https://issues.apache.org/jira/browse/AMBARI-20006


Repository: ambari


Description
---

Hiding the External Solr button may cause an issue, if the cluster was 
installed via blueprint, without the stack advisor used. In this case the value 
is stuck at false, and as the button is hidden it can't even turned on.

also
- removed some unused code
- moved some non project specific code from LogSearch to a new utility class 
called WebUtil


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 70053d2 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
 86c1edd 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 b15ae43 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
 ace278f 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrServiceLogPropsConfig.java
 81935d4 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/WebUtil.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java
 fdda542 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchSecurityContextFormationFilter.java
 b427749 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchUsernamePasswordAuthenticationFilter.java
 24ec2d4 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
0bdf319 

Diff: https://reviews.apache.org/r/56656/diff/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Re: Review Request 56653: UI on Admin page-> Auto Start tab is not consistent

2017-02-14 Thread Denys Buzhor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56653/#review165489
---


Ship it!




Ship It!

- Denys Buzhor


On Feb. 14, 2017, 11:13 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56653/
> ---
> 
> (Updated Feb. 14, 2017, 11:13 a.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-20002
> https://issues.apache.org/jira/browse/ambari-20002
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UI on Admin page, Auto Start tab is not consistent. Observing that the Auto 
> Start button on Admin tab is sometimes a checkbox and sometimes a Toggle 
> Button.
> STR:
> -> Upgrade ambari from 2.2.2.0 to 2.5.0
> -> On Firefox Version 45, go to admin page -> Auto Start Tab
> It was manually reproduced on Firefox Version 44
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/main/admin/service_auto_start.js 6f7d644 
>   ambari-web/test/controllers/main/service/info/config_test.js 8ca48b1 
> 
> Diff: https://reviews.apache.org/r/56653/diff/
> 
> 
> Testing
> ---
> 
> 20345 passing (21s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 56653: UI on Admin page-> Auto Start tab is not consistent

2017-02-14 Thread Oleg Nechiporenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56653/
---

Review request for Ambari.


Bugs: ambari-20002
https://issues.apache.org/jira/browse/ambari-20002


Repository: ambari


Description
---

UI on Admin page, Auto Start tab is not consistent. Observing that the Auto 
Start button on Admin tab is sometimes a checkbox and sometimes a Toggle Button.
STR:
-> Upgrade ambari from 2.2.2.0 to 2.5.0
-> On Firefox Version 45, go to admin page -> Auto Start Tab
It was manually reproduced on Firefox Version 44


Diffs
-

  ambari-web/app/views/main/admin/service_auto_start.js 6f7d644 
  ambari-web/test/controllers/main/service/info/config_test.js 8ca48b1 

Diff: https://reviews.apache.org/r/56653/diff/


Testing
---

20345 passing (21s)
  153 pending


Thanks,

Oleg Nechiporenko

Re: Review Request 56607: AMBARI-19915 Add Ranger KMS SSL properties in ambari stack

2017-02-14 Thread Mugdha Varadkar



> On Feb. 13, 2017, 7:18 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py,
> >  line 148
> > 
> >
> > Today, we have symlinks from /etc/$comp/conf -> 
> > /usr/hdp/current/$comp/conf so that configs still work during stack 
> > upgrades (RU/EU). This seems to be a flat directory.
> > 
> > How is it going to be used?
> > What will happen during stack upgrades or downgrades?

Hi Alejandro,

For Ranger KMS: the "conf" symlinks is created under the path /etc/ranger/kms/. 
This flat directory path is created by rpm package. I added this code if in 
case the path is not created, it may be created from Ambari, also this path is 
needed to create some additional files.


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56607/#review165378
---


On Feb. 13, 2017, 7:14 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56607/
> ---
> 
> (Updated Feb. 13, 2017, 7:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19915
> https://issues.apache.org/jira/browse/AMBARI-19915
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Below SSL properties needs to be added in Ambari for Ranger KMS service
> - ranger.service.https.attrib.keystore.file
> - ranger.service.https.attrib.client.auth
> - ranger.service.https.attrib.keystore.keyalias  
> - ranger.service.https.attrib.keystore.pass
> - ranger.credential.provider.path
> - ranger.service.https.attrib.keystore.credential.alias
> 
> Along with addition of these properties, need to secure password property.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  8fd5c8d 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml
>  7dea07f 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  742cb93 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  05e8881 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  0fd1766 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 54072ad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  c64d6ed 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 58db4a9 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 44a9b7c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  92c5902 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 30b5d13 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 23564ad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  75515a5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> b83525a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER_KMS/configuration/ranger-kms-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 969c3dd 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> 57f9f34 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> b7f8cbb 
> 
> Diff: https://reviews.apache.org/r/56607/diff/
> 
> 
> Testing
> ---
> 
> Test Case:
> 
> Running tests for stack:2.5 service:RANGER_KMS
> test_configure_default (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,451 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-777, current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
> 2017-02-13 19:08:27,467 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> ok
> test_configure_secured (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,502 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> 2017-02-13 19:08:27,518 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> ok
> test_start_default (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,533 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-777, current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
> 2017-02-13 19:08:27,550 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> 2017-02-13 19:08:27,555 -

Re: Review Request 56599: ambari-server upgrade is not idempotent

2017-02-14 Thread Attila Magyar



> On Feb. 13, 2017, 3:49 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java,
> >  lines 243-251
> > 
> >
> > Any reason you didn't use a Set here (especially since the contract 
> > only defines a Collection)?
> 
> Attila Magyar wrote:
> The existing code uses ArrayList. I'm not sure if it will break anything 
> if I change it to Set.

@jhurley

If we change it to set then we should remove the setter, and use 
addAuthorization() all over the place.

public void setAuthorizations(Collection 
authorizations) {
  this.authorizations = authorizations;
}


The setAuthorizations() is used at one place in production code, and in 10 
tests. But it will behave differently because it won't preserver the ordering. 
Or we can use LinkedHashSet to preserve the ordering too. What do you think?


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165341
---


On Feb. 13, 2017, 1:48 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56599/
> ---
> 
> (Updated Feb. 13, 2017, 1:48 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert 
> Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19984
> https://issues.apache.org/jira/browse/AMBARI-19984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running ambari-upgrade multiple times cause an exception due to violation of 
> unique database constraint (the same RoleAuthorization can be added multiple 
> times to admin permissions).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
>  fb01cca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  4b33bcd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  0cd4f12f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  1c742ef 
> 
> Diff: https://reviews.apache.org/r/56599/diff/
> 
> 
> Testing
> ---
> 
> Added new unittest that checks if adding RoleAuthorization is idempotent.
> 
> Tested manually:
>  - installed ambari 2.4
>  - upgraded to ambari 2.5
>  - set version back to 2.4 by running: update metainfo set metainfo_value = 
> '2.4.0' where metainfo_key = 'version';
>  - upgraded to ambari 2.5 again
>  - started ambari-server checked the UI
> 
> 
> Existing tests ran clealy
> 
> --
> Ran 465 tests in 15.977s
> 
> Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56647: AMBARI-20000.Workflow Manager optimising finding nodes

2017-02-14 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56647/#review165479
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 14, 2017, 9:13 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56647/
> ---
> 
> (Updated Feb. 14, 2017, 9:13 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-2
> https://issues.apache.org/jira/browse/AMBARI-2
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Find node is optimized using cytoscape methods. object is serialized and 
> deserialized using JSOG rather than json.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js
>  65d097414b 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js
>  ad664d7709 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> a5536af377 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
>  8202c6d484 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 
> 92820f9b42 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 
> b918d70200 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js
>  656df4bb73 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 02842c5d41 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs
>  0810f64285 
>   contrib/views/wfmanager/src/main/resources/ui/bower.json b66a190fcc 
>   contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js bf48e9c911 
> 
> Diff: https://reviews.apache.org/r/56647/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> belliraj hb
> 
>

Review Request 56648: AMBARI-20001.Workflow manager- preview workflow has xml encodings

2017-02-14 Thread Padma Priya N


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56648/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-20001
https://issues.apache.org/jira/browse/AMBARI-20001


Repository: ambari


Description
---

Replaced encoded xml strings with actual values


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
dde012d 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/preview-dialog.js 
cd6c171 
  contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 
a2210a6 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/preview-dialog.hbs
 bbf7ce1 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
e793aac 

Diff: https://reviews.apache.org/r/56648/diff/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 56643: Hive View 2.0 upload table issues : char support, endline support and temp file deletion

2017-02-14 Thread DIPAYAN BHOWMICK


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56643/#review165475
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 14, 2017, 5:56 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56643/
> ---
> 
> (Updated Feb. 14, 2017, 5:56 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> following bugs in upload table feature have been resolved in this patch:
> 1. does not support to specify endlines in input file's fields
> 2. if column datatype is char or varchar it gives error.
> 3. temporary table does not get deleted if error occurs in table upload.
> Options
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js 
> 066168c 
>   contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js 
> 29e9891 
>   contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js 
> b550dbe 
>   contrib/views/hive20/src/main/resources/ui/app/models/column.js 73a9824 
>   
> contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js
>  0e61905 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs
>  c63f502 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/databases/database/tables/new.hbs
>  4f3b98a 
> 
> Diff: https://reviews.apache.org/r/56643/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 56643: Hive View 2.0 upload table issues : char support, endline support and temp file deletion