Re: Review Request 64446: Log Search UI: improve histogram display
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64446/#review193241 --- Ship it! Ship It! - Oleg Nechiporenko On Dec. 8, 2017, 11:33 a.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64446/ > --- > > (Updated Dec. 8, 2017, 11:33 a.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-22615 > https://issues.apache.org/jira/browse/AMBARI-22615 > > > Repository: ambari > > > Description > --- > > 1. Add tooltip over columns > 2. Add legend > 3. Add display of selected time interval length > 4. Reduce the height of the histogram > 5. When narrowing in on time in the histogram we need to make the bars wider > to fill more of the gap > 6. Also when zooming in we should have text to tell you the gap > 7. The amount of space between the y axis and the bars needs to be increased > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/src/app/classes/histogram-options.ts > dee5d98 > ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less > a6e5616 > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.html > 299e46e > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.less > e8d3240 > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.spec.ts > 9e056be > > ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.ts > e255166 > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts > e754aa4 > ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 6c916aa > > > Diff: https://reviews.apache.org/r/64446/diff/1/ > > > Testing > --- > > Executed 221 of 221 SUCCESS (5.452 secs / 5.358 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 63587: Log Search UI: move top menu down
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63587/#review190181 --- Ship it! Ship It! - Oleg Nechiporenko On Ноя. 6, 2017, 5:16 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63587/ > --- > > (Updated Ноя. 6, 2017, 5:16 п.п.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-22368 > https://issues.apache.org/jira/browse/AMBARI-22368 > > > Repository: ambari > > > Description > --- > > Top menu (Undo, Redo, Refresh, History) should be located on one line with > tabs, aligned to right. Logout button should remain on its place. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 37cd869 > > ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/action-menu/action-menu.component.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.html > a0444c9 > ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.less > 8731582 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html > 70150a5 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.less > 23d5f92 > > ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.html > 2061582 > ambari-logsearch/ambari-logsearch-web/src/app/components/mixins.less > 2e46213 > > ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.html > a7858a5 > > ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.less > 4fe899a > > ambari-logsearch/ambari-logsearch-web/src/app/components/top-menu/top-menu.component.ts > 73b6131 > ambari-logsearch/ambari-logsearch-web/src/app/components/variables.less > 150ac56 > > > Diff: https://reviews.apache.org/r/63587/diff/1/ > > > Testing > --- > > Executed 109 of 109 SUCCESS (2.729 secs / 2.668 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 62766: Log Search UI: add event bars for Components list item
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62766/#review187082 --- Ship it! Ship It! - Oleg Nechiporenko On Окт. 4, 2017, 11:10 д.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62766/ > --- > > (Updated Окт. 4, 2017, 11:10 д.п.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-22128 > https://issues.apache.org/jira/browse/AMBARI-22128 > > > Repository: ambari > > > Description > --- > > Every item of Components filter control should include the bar which reflects > the ratio between events of different types for the corresponding component. > Should be similar to Hosts filter. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html > fc3dac8 > ambari-logsearch/ambari-logsearch-web/src/app/models/node.model.ts 2891d142 > ambari-logsearch/ambari-logsearch-web/src/app/models/store.model.ts a6a084f > > ambari-logsearch/ambari-logsearch-web/src/app/services/component-generator.service.ts > c49f40f > > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.spec.ts > e3f731e > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts > 0fff75d > > ambari-logsearch/ambari-logsearch-web/src/app/services/http-client.service.ts > 44a5f6a > > > Diff: https://reviews.apache.org/r/62766/diff/1/ > > > Testing > --- > > Executed 91 of 91 SUCCESS (2.144 secs / 2.103 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 62689: Log Search UI: implement service logs actions functionality
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62689/#review186665 --- Ship it! Ship It! - Oleg Nechiporenko On Сен. 29, 2017, 12:49 п.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62689/ > --- > > (Updated Сен. 29, 2017, 12:49 п.п.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-22093 > https://issues.apache.org/jira/browse/AMBARI-22093 > > > Repository: ambari > > > Description > --- > > Implement Copy, Open Log and Context actions for logs list entries. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts c4dc698 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/active-service-log-entry.class.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/app/classes/list-item.class.ts > adb023b > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts > e36bf18 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-truncated-query-params.class.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/classes/service-log-context-entry.class.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.html > 9536573 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts > f7227b1 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.html > 316d3f9 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts > eacac04 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.ts > 82656cf > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts > a01a3f3 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts > 85e7ecb > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts > ae5a4af > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/log-file-entry/log-file-entry.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html > 5145b76 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.spec.ts > 811c6e6 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts > b1fad17 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html > 2942b20 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less > 577043f > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.spec.ts > 8c67a13 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts > aeb55da > > ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.html > 69b3887 > > ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.less > 9736628 > > ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-conta
Re: Review Request 62497: Log Search UI: host filter should be performed using hostList parameter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62497/#review185958 --- Ship it! Ship It! - Oleg Nechiporenko On Сен. 22, 2017, 8:58 д.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62497/ > --- > > (Updated Сен. 22, 2017, 8:58 д.п.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-22037 > https://issues.apache.org/jira/browse/AMBARI-22037 > > > Repository: ambari > > > Description > --- > > Hosts should be filtered using ```hostList``` request parameter instead of > ```host_name```, since it doesn't support conditions for multiple selection. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/audit-logs-query-params.class.ts > ef8cf28 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-histogram-query-params.class.ts > 572af03 > > ambari-logsearch/ambari-logsearch-web/src/app/classes/queries/service-logs-query-params.class.ts > c88ec46 > ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts > 718149e > > ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts > a90d099 > > ambari-logsearch/ambari-logsearch-web/src/app/services/mock-api-data.service.ts > ec89d9f > ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json e3f4c69 > > > Diff: https://reviews.apache.org/r/62497/diff/1/ > > > Testing > --- > > Executed 86 of 86 SUCCESS (1.902 secs / 1.883 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 62242: AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62242/#review185407 --- Ship it! Ship It! - Oleg Nechiporenko On Sept. 13, 2017, 6:31 p.m., Jason Golieb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62242/ > --- > > (Updated Sept. 13, 2017, 6:31 p.m.) > > > Review request for Ambari, Denys Buzhor, Jaimin Jetly, and Yusaku Sako. > > > Bugs: AMBARI-21933 > https://issues.apache.org/jira/browse/AMBARI-21933 > > > Repository: ambari > > > Description > --- > > Implement breadcrumb navigation in the Background Operations modal and the > drill-down views within it. This also affects the use of these views in the > High Availability wizard. The breadcrumbs will provide a better navigation > experience within this series of dialogs, helping the user to see the context > of the current view and to navigate back up the hierarchy more easily. It > will also be more consistent with the overall UX of Ambari 3.0.0. > > > Diffs > - > > ambari-web/app/controllers/global/background_operations_controller.js > de420b5a131 > > ambari-web/app/controllers/main/admin/highAvailability/progress_popup_controller.js > 4cbe59b020c > ambari-web/app/messages.js 87a5e97a68d > ambari-web/app/styles/modal_popups.less f7fe88be71d > ambari-web/app/templates/common/breadcrumbs.hbs 89353d9f065 > ambari-web/app/templates/common/host_progress_popup.hbs 03c014cefa0 > ambari-web/app/utils/host_progress_popup.js 5bd02cd76de > ambari-web/app/views/common/breadcrumbs_view.js e35a1965215 > ambari-web/app/views/common/host_progress_popup_body_view.js 057f8bcf3c4 > ambari-web/test/controllers/global/background_operations_test.js > 4a8235c484b > > ambari-web/test/controllers/main/admin/highAvailability/progress_popup_controller_test.js > 364d9b0b451 > ambari-web/test/utils/host_progress_popup_test.js dea2666fd47 > ambari-web/test/views/common/breadcrumbs_view_test.js eff19f63b88 > ambari-web/test/views/common/host_progress_popup_body_view_test.js > 5ccc0245101 > > > Diff: https://reviews.apache.org/r/62242/diff/2/ > > > Testing > --- > > 21293 passing > > > Thanks, > > Jason Golieb > >
Re: Review Request 62184: Log Search UI: unit tests setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62184/#review184966 --- Ship it! Ship It! - Oleg Nechiporenko On Сен. 8, 2017, 11:43 д.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62184/ > --- > > (Updated Сен. 8, 2017, 11:43 д.п.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-21915 > https://issues.apache.org/jira/browse/AMBARI-21915 > > > Repository: ambari > > > Description > --- > > 1. Unit tests should be executed in headless browser. > 2. Externalize setup for unit tests. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web/.angular-cli.json cc74739 > ambari-logsearch/ambari-logsearch-web/karma.conf.js 0512808 > ambari-logsearch/ambari-logsearch-web/package.json 92c5043 > > ambari-logsearch/ambari-logsearch-web/src/app/components/app.component.spec.ts > bc16ea4 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts > 8efe320 > > ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts > 5409d30 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts > 5d58b5c > > ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts > 323aa56 > > ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts > 2ced41e > > ambari-logsearch/ambari-logsearch-web/src/app/components/login-form/login-form.component.spec.ts > fd54fe6 > > ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.spec.ts > 02c3b23 > > ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts > 6c9e021 > > ambari-logsearch/ambari-logsearch-web/src/app/components/modal/modal.component.spec.ts > 802bd13 > > ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.spec.ts > 7a15bbc > > ambari-logsearch/ambari-logsearch-web/src/app/components/search-box/search-box.component.spec.ts > 2b3a957 > > ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.component.spec.ts > 0ef17de > > ambari-logsearch/ambari-logsearch-web/src/app/services/http-client.service.spec.ts > 0dfb0f3 > ambari-logsearch/ambari-logsearch-web/src/app/test-config.spec.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web/src/test.ts 6597b1c > ambari-logsearch/ambari-logsearch-web/yarn.lock 4883a15 > > > Diff: https://reviews.apache.org/r/62184/diff/1/ > > > Testing > --- > > Executed 84 of 84 SUCCESS (1.828 secs / 1.798 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 61718: Log Search UI: implement histogram filtering by all possible criterias
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61718/#review183143 --- Ship it! Ship It! - Oleg Nechiporenko On Aug. 17, 2017, 4:52 p.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61718/ > --- > > (Updated Aug. 17, 2017, 4:52 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-21747 > https://issues.apache.org/jira/browse/AMBARI-21747 > > > Repository: ambari > > > Description > --- > > Service logs histogram API request should contain parameters for filtering by > message/cluster/component/level/hostname. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-histogram-query-params.class.ts > 5402214 > > ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-query-params.class.ts > 125b237 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.ts > 57a147c > > > Diff: https://reviews.apache.org/r/61718/diff/1/ > > > Testing > --- > > Executed 78 of 78 SUCCESS (1.429 secs / 1.39 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 61710: Log Search UI: implement multiple options select for filters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61710/#review183115 --- Ship it! Ship It! - Oleg Nechiporenko On Aug. 17, 2017, 10:10 a.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61710/ > --- > > (Updated Aug. 17, 2017, 10:10 a.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-21740 > https://issues.apache.org/jira/browse/AMBARI-21740 > > > Repository: ambari > > > Description > --- > > User should be able to select several options of given filtering instance at > once. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-query-params.class.ts > 0914864 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.html > b2ce3a0 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.html > b777b52 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.ts > 029d87b > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.html > db4ee79 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.less > 0853883 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.ts > 3e9a445 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.ts > 2f8c969 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.ts > c414782 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html > d2de5e2 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.spec.ts > 4d6509b > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.ts > 40e7d89 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html > caae24e > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.html > f18285f > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts > d1baedc > ambari-logsearch/ambari-logsearch-web-new/src/app/components/variables.less > 7715876 > ambari-logsearch/ambari-logsearch-web-new/src/app/models/app-state.model.ts > 028c10d > ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts > 13a1e68 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/component-actions.service.ts > f79ba45 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts > 009b263 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/mock-api-data.service.ts > 985a0bf > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.spec.ts > a93eee5 > ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.ts > 7180ebb > > > Diff: https://reviews.apache.org/r/61710/diff/1/ > > > Testing > --- > > Executed 57 of 57 SUCCESS (1.367 secs / 1.345 secs) > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 61549: Log Search UI: implement histogram for service logs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61549/#review182568 --- Ship it! Ship It! - Oleg Nechiporenko On Авг. 10, 2017, 10:22 д.п., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61549/ > --- > > (Updated Авг. 10, 2017, 10:22 д.п.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-21699 > https://issues.apache.org/jira/browse/AMBARI-21699 > > > Repository: ambari > > > Description > --- > > Log entries should be displayed on histogram as well as in form of list. > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web-new/package.json 847787b > ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 503aa46 > > ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-histogram-query-params.class.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html > 4c84b9c > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.less > 76c16a5 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts > 7427fc1 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/main-container/main-container.component.html > 42a8fbf > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/time-histogram/time-histogram.component.html > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/time-histogram/time-histogram.component.less > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/time-histogram/time-histogram.component.spec.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/time-histogram/time-histogram.component.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/src/app/mock-data.ts 3d04122 > ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts > 190ab7e > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts > c317076 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/http-client.service.ts > 0d06899 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/bar-graphs.service.ts > e9a3cb7 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/reducers.service.ts > 6665901 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/service-logs-histogram-data.service.ts > PRE-CREATION > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/service-logs.service.ts > 24c3776 > ambari-logsearch/ambari-logsearch-web-new/yarn.lock 6e592a7 > > > Diff: https://reviews.apache.org/r/61549/diff/1/ > > > Testing > --- > > Executed 51 of 51 SUCCESS > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 61425: Services are not started for the correct count of nodes selected in the Hosts list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61425/#review182205 --- Ship it! Ship It! - Oleg Nechiporenko On Aug. 4, 2017, 1:44 p.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61425/ > --- > > (Updated Aug. 4, 2017, 1:44 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-21661 > https://issues.apache.org/jira/browse/AMBARI-21661 > > > Repository: ambari > > > Description > --- > > **STR:** > 1. Select hosts where nodemanagers are hosted on "Hosts" page. Number of > hosts selected should be more than the page size. This can be done by > selecting "Nodemanager: all" and then selecting subset of hosts as shown in > attached video or multiple host names on which nodemanager are hosted > 2. Go to actions->selected hosts and restart nodemangers. > 3. A popup showing nodemanagers that will be restarted is shown for > confirmation to the user. > > **Expected Result:** hosts shown in the pop should be the same as selected on > "Hosts" page > **Actual Result:** There is a mismatch between hosts shown in the popup from > what was selected by the user. Also if the popup is dismissed and reopen > again there is a mismatch. > > > Diffs > - > > ambari-web/app/controllers/main/host/bulk_operations_controller.js 34d61d8 > > > Diff: https://reviews.apache.org/r/61425/diff/1/ > > > Testing > --- > > 21266 passing (20s) > 128 pending > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 61424: Stack selection page does not load the HDP stacks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61424/#review182200 --- Ship it! Ship It! - Oleg Nechiporenko On Aug. 4, 2017, 12:08 p.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61424/ > --- > > (Updated Aug. 4, 2017, 12:08 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-21660 > https://issues.apache.org/jira/browse/AMBARI-21660 > > > Repository: ambari > > > Description > --- > > During installation of HDP, the stack selection page doesnt load the HDP > stacks. > If the page is refreshed, the stacks appear. > > > Diffs > - > > ambari-web/app/controllers/wizard/step1_controller.js 22456af > ambari-web/app/routes/installer.js eae03a7 > ambari-web/app/templates/wizard/step1.hbs 5faf056 > ambari-web/app/views/wizard/step1_view.js 9ab4fde > ambari-web/test/controllers/wizard/step1_test.js 296fe50 > ambari-web/test/views/wizard/step1_view_test.js edf8e0c > > > Diff: https://reviews.apache.org/r/61424/diff/1/ > > > Testing > --- > > 21266 passing (31s) > 128 pending > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 61373: Alerts list not sorted by status even though header displayed as sorted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61373/#review181953 --- Ship it! Ship It! - Oleg Nechiporenko On Aug. 2, 2017, 9:20 a.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61373/ > --- > > (Updated Aug. 2, 2017, 9:20 a.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-21632 > https://issues.apache.org/jira/browse/AMBARI-21632 > > > Repository: ambari > > > Description > --- > > Alerts list not sorted by status even though header displayed as sorted while > landing on alerts page. > > Note: Sort works fine when explicitly clicked on sort headers. > STR: > 1. Login to Amabri > 2. Navigate to Alerts page > 3. Expected to list the alerts sorted by Status by default but not sorted by > status. > Attaching screenshot. > > > Diffs > - > > ambari-web/app/views/main/alert_definitions_view.js a578c84 > ambari-web/test/views/main/alert_definitions_view_test.js 8692ae4 > > > Diff: https://reviews.apache.org/r/61373/diff/1/ > > > Testing > --- > > 21227 passing (26s) > 128 pending > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 60650: Log Search UI: production build issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60650/#review179620 --- Ship it! Ship It! - Oleg Nechiporenko On July 5, 2017, 11:01 a.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60650/ > --- > > (Updated July 5, 2017, 11:01 a.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-21403 > https://issues.apache.org/jira/browse/AMBARI-21403 > > > Repository: ambari > > > Description > --- > > - Incorrect request header is sent on login > - Login form is displayed to user on visiting the application page even if > authorization is active > - AJAX requests are sent twice > - `FilterButtonComponent` fails to be compiled: `ERROR in No template > specified for component FilterButtonComponent` > - JS error after login: `ERROR TypeError: Cannot read property 'timeZone' of > undefined`, no content under navbar is displayed > - JS error on logs loading: `ERROR TypeError: Cannot read property 'map' of > undefined`, no logs loaded as result > - URL params in logs request aren't encoded > > > Diffs > - > > ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 1e0ebb0 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.ts > 85031b6 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.spec.ts > 3442132 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.ts > c5a17c2 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.ts > 808fcf8 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.ts > 3da53ca > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts > 9f4522b > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.ts > 84210dc > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.spec.ts > 740593f > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.ts > 857b511 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html > 256b547 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts > b2ae9b0 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/login-form/login-form.component.html > 37a96e9 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/login-form/login-form.component.spec.ts > 0498ee4 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/login-form/login-form.component.ts > 2a93775 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html > df72502 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts > efa05e4 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/main-container/main-container.component.html > 61d1b93 > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/main-container/main-container.component.spec.ts > 536f1ef > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/main-container/main-container.component.ts > bac39ec > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.spec.ts > d53677d > > ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts > 08b555c > ambari-logsearch/ambari-logsearch-web-new/src/app/models/app-state.model.ts > PRE-CREATION > ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts > c169c1b > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/component-actions.service.spec.ts > 303fdab > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/component-actions.service.ts > 4cde0a0 > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts > 9f6b7dc > > ambari-logsearch/ambari-logsearch-web-new/src/app/services/http-client.service.spec.ts > 083ea23 > >
Review Request 58345: Remove duplicate condition from route
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58345/
---
Review request for Ambari and Denys Buzhor.
Bugs: ambari-20732
https://issues.apache.org/jira/browse/ambari-20732
Repository: ambari
Description
---
{{adminServiceAutoStart.enter}} contains duplicate
{{!App.isAuthorized('CLUSTER.MANAGE_AUTO_START')}}.
Diffs
-
ambari-web/app/routes/main.js 0a2375e
ambari-web/test/controllers/main_test.js 9673092
ambari-web/test/init_test.js db72744
Diff: https://reviews.apache.org/r/58345/diff/1/
Testing
---
20663 passing (23s)
128 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 58300: Remove singleNodeInstall flag from ambari-web code
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58300/#review171442 --- Ship it! Ship It! - Oleg Nechiporenko On April 10, 2017, 1:55 p.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58300/ > --- > > (Updated April 10, 2017, 1:55 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-20723 > https://issues.apache.org/jira/browse/AMBARI-20723 > > > Repository: ambari > > > Description > --- > > Remove App.singleNodeInstall flag and all the related code from ambari-web as > it's no more necessary. > > > Diffs > - > > ambari-web/app/assets/test/tests.js ef8d0bc > ambari-web/app/config.js 47eb788 > ambari-web/app/templates/main/service/services/oozie.hbs 3706eb4 > ambari-web/app/views.js 3ed1a37 > ambari-web/app/views/common/quick_view_link_view.js 3f3a3a3 > ambari-web/app/views/main/service/info/summary.js 551a3fd > ambari-web/app/views/main/service/services/hbase.js d2716aa > ambari-web/app/views/main/service/services/hdfs.js 79208b9 > ambari-web/app/views/main/service/services/oozie.js f7a645d > ambari-web/test/views/common/quick_link_view_test.js c0d58c8 > ambari-web/test/views/main/service/info/summary_test.js 51fd2f2 > ambari-web/test/views/main/service/services/hbase_test.js 6c0f1f1 > ambari-web/test/views/main/service/services/hdfs_test.js 4de5f0b > ambari-web/test/views/main/service/services/oozie_test.js c95e65f > > > Diff: https://reviews.apache.org/r/58300/diff/1/ > > > Testing > --- > > 20669 passing (23s) > 128 pending > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 58207: Select Version step of installer: repo URL validation message issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58207/#review171115 --- Ship it! Ship It! - Oleg Nechiporenko On April 5, 2017, 12:06 p.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58207/ > --- > > (Updated April 5, 2017, 12:06 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-20681 > https://issues.apache.org/jira/browse/AMBARI-20681 > > > Repository: ambari > > > Description > --- > > 1. Error message that contains long repository URL overflows the popover > block. > 2. Popover has no title. > > > Diffs > - > > ambari-web/app/views/wizard/step1_view.js 0161985 > > > Diff: https://reviews.apache.org/r/58207/diff/1/ > > > Testing > --- > > 20674 passing (19s) > 128 pending > > > Thanks, > > Andrii Babiichuk > >
Review Request 57985: Comparison for configs with list of hostNames doesn't show all hosts correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57985/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-20602 https://issues.apache.org/jira/browse/ambari-20602 Repository: ambari Description --- Normal format for such configs - "HostName and N others". Sometimes "HostName" is missing and value is shown as "and N others". Diffs - ambari-web/app/templates/wizard/component_hosts.hbs 802b970 ambari-web/app/views/common/controls_view.js 120ca9a ambari-web/test/views/common/controls_view_test.js 3ff5253 Diff: https://reviews.apache.org/r/57985/diff/1/ Testing --- 20606 passing (23s) 128 pending Thanks, Oleg Nechiporenko
Review Request 57943: Not all config groups are shown in the config history table
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57943/
---
Review request for Ambari and Denys Buzhor.
Bugs: ambari-20577
https://issues.apache.org/jira/browse/ambari-20577
Repository: ambari
Description
---
Filter view should be bound to the {{controller.content.[]}}
Diffs
-
ambari-web/app/views/main/dashboard/config_history_view.js 0acf556
ambari-web/test/controllers/wizard/step8_test.js 15b9245
ambari-web/test/views/main/dashboard/config_history_view_test.js d799c44
Diff: https://reviews.apache.org/r/57943/diff/1/
Testing
---
20606 passing (21s)
128 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 57907: Versions page: unable to set 'Skip Repository Base URL validation' option
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57907/#review17 --- Ship it! Ship It! - Oleg Nechiporenko On March 24, 2017, 11:49 a.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57907/ > --- > > (Updated March 24, 2017, 11:49 a.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-20557 > https://issues.apache.org/jira/browse/AMBARI-20557 > > > Repository: ambari > > > Description > --- > > **STR** > 1. Go to Versions page. > 2. Open Details for any stack version. > 2. In opened popup, click 'Edit' icon. > 3. In another opened popup, try to set 'Skip Repository Base URL validation' > option. > > **Result** > - JS error thrown: > ``` > Uncaught TypeError: Cannot read property 'forEach' of undefined > at Class.change (app.js:206179) > ``` > - Option is not set. > > > Diffs > - > > ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js > a714149 > > ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js > 58067a2 > > > Diff: https://reviews.apache.org/r/57907/diff/1/ > > > Testing > --- > > 20604 passing (20s) > 128 pending > > > Thanks, > > Andrii Babiichuk > >
Re: Review Request 57507: Diff tool shows additional line when comparing configs from custom config group
> On March 16, 2017, 8:26 p.m., Jaimin Jetly wrote: > > If there is no UX impact and patch has been tested to work e2e then please > > commit it. This patch just fix an issue with some "unknown" field that appears when two version of not default config group are compared. IDK what UX impact it may do. - Oleg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57507/#review169207 --- On March 16, 2017, 12:49 p.m., Oleg Nechiporenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57507/ > --- > > (Updated March 16, 2017, 12:49 p.m.) > > > Review request for Ambari and Jaimin Jetly. > > > Bugs: ambari-20388 > https://issues.apache.org/jira/browse/ambari-20388 > > > Repository: ambari > > > Description > --- > > - Create a custom config group for a service > - Update few properties and save to get a version for this custom group > - Add another property and save just to generate more config version > - Compare these 2 versions. Usually diff shows only the values from compared > versions > - But looks like it shows the current value and the values in each version as > well. > - In default group we dont see that extra line with the current value. > > > Diffs > - > > ambari-web/app/controllers/main/service/info/configs.js 786c6f9 > ambari-web/app/mixins/common/configs/configs_comparator.js d4551b4 > ambari-web/app/templates/common/configs/service_config_category.hbs 9890525 > ambari-web/app/views/common/controls_view.js 4bd4a61 > > > Diff: https://reviews.apache.org/r/57507/diff/2/ > > > Testing > --- > > 20559 passing (23s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
Review Request 57688: Start/Stop Service command may silently fail without any reporting for user
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57688/
---
Review request for Ambari and Denys Buzhor.
Bugs: ambari-20481
https://issues.apache.org/jira/browse/ambari-20481
Repository: ambari
Description
---
* Go to HDFS
* Click "Start" or "Stop" on Service Actions menu
* Request may fails
*ER* Popup with reason should be shown (e.g. {{defaultErrorHandler}})
*AR* Nothing happens
Diffs
-
ambari-web/app/controllers/main/service/item.js 5169564
ambari-web/test/controllers/main/service/item_test.js c4a50ea
Diff: https://reviews.apache.org/r/57688/diff/1/
Testing
---
20580 passing (22s)
153 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 57507: Diff tool shows additional line when comparing configs from custom config group
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57507/ --- (Updated March 16, 2017, 12:49 p.m.) Review request for Ambari and Jaimin Jetly. Changes --- Extra patch added Bugs: ambari-20388 https://issues.apache.org/jira/browse/ambari-20388 Repository: ambari Description --- - Create a custom config group for a service - Update few properties and save to get a version for this custom group - Add another property and save just to generate more config version - Compare these 2 versions. Usually diff shows only the values from compared versions - But looks like it shows the current value and the values in each version as well. - In default group we dont see that extra line with the current value. Diffs (updated) - ambari-web/app/controllers/main/service/info/configs.js 786c6f9 ambari-web/app/mixins/common/configs/configs_comparator.js d4551b4 ambari-web/app/templates/common/configs/service_config_category.hbs 9890525 ambari-web/app/views/common/controls_view.js 4bd4a61 Diff: https://reviews.apache.org/r/57507/diff/2/ Changes: https://reviews.apache.org/r/57507/diff/1-2/ Testing --- 20559 passing (23s) 153 pending Thanks, Oleg Nechiporenko
Review Request 57637: Few breadcrumbs are missing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57637/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-20456 https://issues.apache.org/jira/browse/ambari-20456 Repository: ambari Description --- * admin/stack/versions * admin/stack/history * some views Add ability to generate breadcrumbs from Routes if they are not set manually Diffs - ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js a760f0c ambari-web/app/routes/activate_hawq_standby_routes.js 9ba6073 ambari-web/app/routes/add_hawq_standby_routes.js 346f506 ambari-web/app/routes/add_kerberos_routes.js 462ce44 ambari-web/app/routes/high_availability_routes.js 8f5fb13 ambari-web/app/routes/main.js aace4a2 ambari-web/app/routes/manage_journalnode_routes.js 90b45b0 ambari-web/app/routes/ra_high_availability_routes.js 5be6c44 ambari-web/app/routes/reassign_master_routes.js 341172b ambari-web/app/routes/remove_hawq_standby_routes.js 64250ee ambari-web/app/routes/rm_high_availability_routes.js d8aa8b3 ambari-web/app/routes/stack_upgrade_routes.js f95dd6e ambari-web/app/routes/view.js 22a4057 ambari-web/app/routes/views.js 073507c ambari-web/app/views/common/breadcrumbs_view.js f9073ba ambari-web/test/views/common/breadcrumbs_view_test.js 751811c Diff: https://reviews.apache.org/r/57637/diff/1/ Testing --- 20578 passing (21s) 153 pending Thanks, Oleg Nechiporenko
Re: Review Request 57600: Services actions menu is not fully displayed under some circumstances
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57600/#review168900 --- Ship it! Ship It! - Oleg Nechiporenko On March 14, 2017, 2:44 p.m., Andrii Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57600/ > --- > > (Updated March 14, 2017, 2:44 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-20444 > https://issues.apache.org/jira/browse/AMBARI-20444 > > > Repository: ambari > > > Description > --- > > **STR** > 1. Go to service configs page. > 2. Before configs are rendered, switch to another service tab (Summary, > Heatmaps). > 3. Expand services actions dropdown. > > **Result** > Dropdown is partially hidden. > > Also, dropdown isn't displayed at all in IE and Safari. > > > Diffs > - > > ambari-web/app/styles/theme/bootstrap-ambari.css a0b24e5 > ambari-web/vendor/scripts/theme/bootstrap-ambari.js e75bd6b > > > Diff: https://reviews.apache.org/r/57600/diff/1/ > > > Testing > --- > > 20562 passing (23s) > 153 pending > > > Thanks, > > Andrii Babiichuk > >
Review Request 57591: Alert Definition "Last Changed" field is shown incorrect if alert wan't triggered any time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57591/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-20441 https://issues.apache.org/jira/browse/AMBARI-20441 Repository: ambari Description --- * Go to Alert Definition details page for Definition with NONE status (e.g. "NameNode Heap Usage (Daily)") *AR* "Last Changed" is shown as "Jan 01 1970" *ER* This field should be empty Diffs - ambari-web/app/models/alerts/alert_definition.js b55ef1b ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js f987c52 ambari-web/test/models/alerts/alert_definition_test.js 3d8b62d Diff: https://reviews.apache.org/r/57591/diff/1/ Testing --- 20562 passing (21s) 153 pending Thanks, Oleg Nechiporenko
Review Request 57554: JS error when filtering config history table
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57554/
---
Review request for Ambari and Andrii Tkach.
Bugs: ambari-20415
https://issues.apache.org/jira/browse/ambari-20415
Repository: ambari
Description
---
* Open Config History Page
* Filter table by Group Name
*AR* JS-error appears:
{noformat}Uncaught TypeError: this.saveStartIndex is not a function{noformat}
Diffs
-
ambari-web/app/mixins/common/table_server_view_mixin.js d44a09e
ambari-web/app/views/main/dashboard/config_history_view.js 7bd9e4a
ambari-web/test/mixins/common/table_server_view_mixin_test.js ae750de
Diff: https://reviews.apache.org/r/57554/diff/1/
Testing
---
20559 passing (22s)
153 pending
Thanks,
Oleg Nechiporenko
Review Request 57507: Diff tool shows additional line when comparing configs from custom config group
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57507/ --- Review request for Ambari and Jaimin Jetly. Bugs: ambari-20388 https://issues.apache.org/jira/browse/ambari-20388 Repository: ambari Description --- - Create a custom config group for a service - Update few properties and save to get a version for this custom group - Add another property and save just to generate more config version - Compare these 2 versions. Usually diff shows only the values from compared versions - But looks like it shows the current value and the values in each version as well. - In default group we dont see that extra line with the current value. Diffs - ambari-web/app/templates/common/configs/service_config_category.hbs 9890525 Diff: https://reviews.apache.org/r/57507/diff/1/ Testing --- 20559 passing (23s) 153 pending Thanks, Oleg Nechiporenko
Re: Review Request 57268: AMBARI-20287 - Filter in Customize Services Page doesn't bring up all properties that matches
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57268/#review168466 --- Ship it! Ship It! - Oleg Nechiporenko On Март 8, 2017, 12:39 д.п., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57268/ > --- > > (Updated Март 8, 2017, 12:39 д.п.) > > > Review request for Ambari, Andrii Babiichuk, Jaimin Jetly, Oleg Nechiporenko, > and Yusaku Sako. > > > Bugs: AMBARI-20287 > https://issues.apache.org/jira/browse/AMBARI-20287 > > > Repository: ambari > > > Description > --- > > Take subSectionTab into consideration on show/hide > > > Diffs > - > > ambari-web/app/models/configs/theme/sub_section.js 7274569 > ambari-web/app/models/configs/theme/sub_section_tab.js 2262882 > ambari-web/app/views/common/configs/service_config_layout_tab_view.js > 466a88d > ambari-web/test/models/configs/theme/sub_section_tab_test.js 0c3b98c > > > Diff: https://reviews.apache.org/r/57268/diff/2/ > > > Testing > --- > > Manully tested on live cluster. All unit tests passed. > 20560 passing (25s) > 153 pending > > > Thanks, > > Richard Zang > >
Review Request 57457: Remove duplicate code from wizard menu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57457/
---
Review request for Ambari and Denys Buzhor.
Bugs: AMBARI-20375
https://issues.apache.org/jira/browse/AMBARI-20375
Repository: ambari
Description
---
{{'isStep..Disabled'}} and {{'isStep..Completed'}} may be rewritten as computed
macros
Diffs
-
ambari-web/app/mixins/wizard/wizard_menu_view.js 90b7354
ambari-web/app/views/main/service/reassign_view.js 4adbf11
Diff: https://reviews.apache.org/r/57457/diff/1/
Testing
---
20573 passing (22s)
153 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 57268: AMBARI-20287 - Filter in Customize Services Page doesn't bring up all properties that matches
> On March 4, 2017, 2:33 a.m., Jaimin Jetly wrote: > > ambari-web/app/models/configs/theme/sub_section_tab.js > > Line 84 (original), 84-87 (patched) > > <https://reviews.apache.org/r/57268/diff/1/?file=1655325#file1655325line84> > > > > Whats the reason behind making this computed property volatile ? > > Richard Zang wrote: > Adding volatile here is because I keep getting inconsistent result on > this computed property during manual test, so add volatile to make sure the > value is consistent even it's updated more than once in one digest loop. What kind of "inconsistent" did you get? - Oleg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57268/#review167925 --- On March 8, 2017, 12:39 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57268/ > --- > > (Updated March 8, 2017, 12:39 a.m.) > > > Review request for Ambari, Andrii Babiichuk, Jaimin Jetly, Oleg Nechiporenko, > and Yusaku Sako. > > > Bugs: AMBARI-20287 > https://issues.apache.org/jira/browse/AMBARI-20287 > > > Repository: ambari > > > Description > --- > > Take subSectionTab into consideration on show/hide > > > Diffs > - > > ambari-web/app/models/configs/theme/sub_section.js 7274569 > ambari-web/app/models/configs/theme/sub_section_tab.js 2262882 > ambari-web/app/views/common/configs/service_config_layout_tab_view.js > 466a88d > ambari-web/test/models/configs/theme/sub_section_tab_test.js 0c3b98c > > > Diff: https://reviews.apache.org/r/57268/diff/2/ > > > Testing > --- > > Manully tested on live cluster. All unit tests passed. > 20560 passing (25s) > 153 pending > > > Thanks, > > Richard Zang > >
Review Request 57367: Alert Definition Name with brackets marked as invalid
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57367/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-20338 https://issues.apache.org/jira/browse/ambari-20338 Repository: ambari Description --- * Go to definition details page "NameNode Heap Usage (Daily)" * Click Edit definition name * It's already marked as invalid *ER* Name with brackets should not be marked as invalid Diffs - ambari-web/app/messages.js 44bf13e ambari-web/app/utils/validator.js 5173702 ambari-web/test/utils/validator_test.js 8565b3d Diff: https://reviews.apache.org/r/57367/diff/1/ Testing --- 20575 passing (23s) 153 pending Thanks, Oleg Nechiporenko
Review Request 57286: Popup "Save changed" appears when user switches config versions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57286/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-20297 https://issues.apache.org/jira/browse/ambari-20297 Repository: ambari Description --- * Create several config versions * Switch to one of them * While it's loading (spinner is shown) try to switch to another version *ER* Confirmation popup should not be shown *AR* This popup is shown Diffs - ambari-web/app/views/common/configs/config_history_flow.js 0cd6b7f Diff: https://reviews.apache.org/r/57286/diff/1/ Testing --- 30365 passing (22s) 157 pending Thanks, Oleg Nechiporenko
Review Request 57280: While Comparing versions, value in latest version is not shown for custom property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57280/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-20286 https://issues.apache.org/jira/browse/AMBARI-20286 Repository: ambari Description --- Difftool which shows the comparison between 2versions doesnt show custom properties added to a service Diffs - ambari-web/app/mixins/common/configs/configs_comparator.js 4adc5ae ambari-web/app/models/configs/objects/service_config_property.js ed72dc3 ambari-web/app/templates/common/configs/service_config_category.hbs c9bedc5 ambari-web/app/utils/config.js 8eeca5f ambari-web/test/views/common/table_view_test.js dd289b0 Diff: https://reviews.apache.org/r/57280/diff/1/ Testing --- 20574 passing (22s) 153 pending Thanks, Oleg Nechiporenko
Review Request 57138: Don't recalculate side-menu content when moving to the views
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57138/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-20231 https://issues.apache.org/jira/browse/AMBARI-20231 Repository: ambari Description --- Side menu should not be rerendered when user is moved to some View. Diffs - ambari-web/app/controllers/main/views_controller.js e2e9281 ambari-web/app/views/application.js 207e77f ambari-web/app/views/main/menu.js 91aaad7 ambari-web/app/views/main/views_view.js 46b3e43 ambari-web/test/controllers/main/admin/highAvailability/nameNode/step4_controller_test.js e850339 ambari-web/test/controllers/main/admin/highAvailability/nameNode/step7_controller_test.js d2b385a ambari-web/test/controllers/main/admin/highAvailability/nameNode/step8_controller_test.js 4af3aa9 ambari-web/test/controllers/main/admin/highAvailability/nameNode/wizard_controller_test.js 577f07b Diff: https://reviews.apache.org/r/57138/diff/ Testing --- 20520 passing (23s) 153 pending Thanks, Oleg Nechiporenko
Review Request 57081: Not able to delete custom property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57081/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-20147 https://issues.apache.org/jira/browse/ambari-20147 Repository: ambari Description --- Steps to reproduce the issue: 1. Under Hive service , Create a custom Group called "hive-group1" 2. Add a property say "hive.mv.files.thread" 3. save the configurations 4. Again go to hive configurations, select hive-group1 group and then try to delete the configuration by clicking "-" , it does nothing - in console fails with JS error as Uncaught TypeError: Cannot read property 'without' of null at Class.removeOverride (app.js:185869) at handler (vendor.js:21227) at HTMLAnchorElement. (vendor.js:13019) at HTMLDivElement.dispatch (vendor.js:126) at HTMLDivElement.i (vendor.js:126) Diffs - ambari-web/app/mixins/common/configs/configs_comparator.js b619aca ambari-web/app/views/common/configs/overriddenPropertyRow_view.js 86e9c60 Diff: https://reviews.apache.org/r/57081/diff/ Testing --- 20490 passing (23s) 153 pending Thanks, Oleg Nechiporenko
Re: Review Request 57037: Manage Configuration Group Hosts popup is way too small to be useful when it is needed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57037/#review166703 --- Ship it! Ship It! - Oleg Nechiporenko On Feb. 24, 2017, 1:49 p.m., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57037/ > --- > > (Updated Feb. 24, 2017, 1:49 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-20172 > https://issues.apache.org/jira/browse/AMBARI-20172 > > > Repository: ambari > > > Description > --- > > The Configuration Group Hosts popup is really small and showed only 6 hosts > at a time. > There's a filter to show 100 hosts per page, but even with that page size, a > max of 6 hosts are shown without having to scroll. > The popup is unnecessarily small. We should make it occupy maximum vertical > space, just like we do elsewhere. > This is a major usability issue with a trivial fix. > > > Diffs > - > > ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js > ea649b8 > ambari-web/app/styles/modal_popups.less e269791 > ambari-web/app/utils/hosts.js 3896325 > > Diff: https://reviews.apache.org/r/57037/diff/ > > > Testing > --- > > 20490 passing (19s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
Review Request 57034: Handle on UI error on services API while trying to start all services with atleast one component in INSTALL_FAILED state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57034/ --- Review request for Ambari and Andrii Tkach. Bugs: ambari-20169 https://issues.apache.org/jira/browse/ambari-20169 Repository: ambari Description --- Handle on UI error on services API while trying to start all services with atleast one component in INSTALL_FAILED state Diffs - ambari-web/app/controllers/main/admin/kerberos/step8_controller.js 3e659b9 ambari-web/app/controllers/main/service.js e434d41 ambari-web/app/mixins/wizard/wizardProgressPageController.js 96eb0ae ambari-web/test/controllers/main/admin/kerberos/step8_controller_test.js 50a705d Diff: https://reviews.apache.org/r/57034/diff/ Testing --- 20423 passing (24s) 153 pending Thanks, Oleg Nechiporenko
Review Request 57022: After disabling security page is not refreshed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57022/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-20163 https://issues.apache.org/jira/browse/ambari-20163 Repository: ambari Description --- When "Disable security popup" is closed, page should be refreshed. Diffs - ambari-web/app/routes/main.js 9730de2 Diff: https://reviews.apache.org/r/57022/diff/ Testing --- 20423 passing (24s) 153 pending Thanks, Oleg Nechiporenko
Re: Review Request 56957: Click feedback/disable toggle is missing for transition buttons in Kerberos Wizard - prone to various failures
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56957/#review166494 --- Ship it! Ship It! - Oleg Nechiporenko On Feb. 23, 2017, 8:50 a.m., Denys Buzhor wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56957/ > --- > > (Updated Feb. 23, 2017, 8:50 a.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-20123 > https://issues.apache.org/jira/browse/AMBARI-20123 > > > Repository: ambari > > > Description > --- > > Following items should be fixed: > > * After the user clicks on "Next", need to disable the button right away and > show the spin animation in the button like we already do for Install Wizard > * While a step is still loading, do not allow the user to click Next (the > button should be disabled until the step has completed loading) > * Download CSV request can take some time, need to show spin animation and > prevent additional clicks during data loading > > > Diffs > - > > ambari-web/app/controllers/main/admin/kerberos/step1_controller.js c0decfc > ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 992fd34 > ambari-web/app/controllers/main/admin/kerberos/step4_controller.js 8e5abd5 > ambari-web/app/controllers/main/admin/kerberos/step5_controller.js 9cb75e0 > ambari-web/app/mixins/wizard/wizardProgressPageController.js d426eda > ambari-web/app/routes/add_kerberos_routes.js fe21dae > ambari-web/app/styles/common.less 94a5cd3 > ambari-web/app/templates/common/button_progress.hbs PRE-CREATION > ambari-web/app/templates/common/progress.hbs fce5641 > ambari-web/app/templates/main/admin/kerberos/step1.hbs 19e5596 > ambari-web/app/templates/main/admin/kerberos/step2.hbs c17347c > ambari-web/app/templates/main/admin/kerberos/step3.hbs 6e2ea57 > ambari-web/app/templates/main/admin/kerberos/step4.hbs 1e6f956 > ambari-web/app/templates/main/admin/kerberos/step5.hbs c0cdc00 > ambari-web/app/views.js 9addd91 > ambari-web/app/views/common/buttons/button_progress_view.js PRE-CREATION > ambari-web/app/views/common/buttons/wizard_buttons.js PRE-CREATION > ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js > 3181fda > ambari-web/test/controllers/main/admin/kerberos/step2_controller_test.js > 2e603da > > Diff: https://reviews.apache.org/r/56957/diff/ > > > Testing > --- > > 20375 passing (25s) > 153 pending > > > Thanks, > > Denys Buzhor > >
Review Request 56923: Add polyfills for Array.includes and String.includes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56923/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-20112 https://issues.apache.org/jira/browse/AMBARI-20112 Repository: ambari Description --- Some tests randomly fail because of undefined (sometimes?!) `Array.includes`. Adding polyfill will fix this. Diffs - ambari-web/app/styles/theme/bootstrap-ambari.css af78310 ambari-web/test/init_test.js df64cbe Diff: https://reviews.apache.org/r/56923/diff/ Testing --- 20421 passing (22s) 153 pending Thanks, Oleg Nechiporenko
Review Request 56891: Password fields are not disabled when should be
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56891/ --- Review request for Ambari. Bugs: AMBARI-20099 https://issues.apache.org/jira/browse/AMBARI-20099 Repository: ambari Description --- * Host configs page * Service configs page. Working with not default config group Diffs - ambari-web/app/utils/ember_reopen.js ef996fc Diff: https://reviews.apache.org/r/56891/diff/ Testing --- 20376 passing (23s) 153 pending Thanks, Oleg Nechiporenko
Review Request 56750: Don't rerender all widgets when on of them is changed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56750/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-20043 https://issues.apache.org/jira/browse/ambari-20043 Repository: ambari Description --- Dashboard widgets are rerendered if some of them is changed. Actually only this one should be updated and not other Diffs - ambari-web/app/assets/test/tests.js d47d558 ambari-web/app/data/dashboard_widgets.js PRE-CREATION ambari-web/app/messages.js 81833f3 ambari-web/app/mixins/common/track_request_mixin.js 4efcecb ambari-web/app/mixins/main/dashboard/widgets/editable.js fcb6bfb ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js ddf2a26 ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 06bcffe ambari-web/app/templates/main/dashboard/edit_widget_popup.hbs 7caf085 ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs 86ffb47 ambari-web/app/views.js 77b5d5a ambari-web/app/views/common/modal_popups/edit_dashboard_widget_popup.js PRE-CREATION ambari-web/app/views/main/dashboard/widget.js e7a626c ambari-web/app/views/main/dashboard/widgets.js 572625d ambari-web/app/views/main/dashboard/widgets/text_widget.js daa354c ambari-web/test/views/common/modal_popups/edit_dashboard_widget_popup_test.js PRE-CREATION ambari-web/test/views/main/dashboard/widget_test.js a504c6d ambari-web/test/views/main/dashboard/widgets_test.js 5d1ddb2 Diff: https://reviews.apache.org/r/56750/diff/ Testing --- 20372 passing (22s) 153 pending Thanks, Oleg Nechiporenko
Re: Review Request 56714: Override property popup: Redundant scrollbars in config groups list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56714/#review165720 --- Ship it! Ship It! - Oleg Nechiporenko On Feb. 15, 2017, 4:02 p.m., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56714/ > --- > > (Updated Feb. 15, 2017, 4:02 p.m.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-20027 > https://issues.apache.org/jira/browse/AMBARI-20027 > > > Repository: ambari > > > Description > --- > > #STR# > 1. Create service config group > 2. Proceed with overriding any property > 3. Open existing config groups combobox in displayed popup. > > #Result# > Displayed list has redundant horizontal and vertical scrollbars. > > > Diffs > - > > ambari-web/app/styles/application.less 612c09c > > Diff: https://reviews.apache.org/r/56714/diff/ > > > Testing > --- > > 20340 passing (20s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
Review Request 56664: JS error in the "Supervisors Live" widget
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56664/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-20011 https://issues.apache.org/jira/browse/AMBARI-20011 Repository: ambari Description --- Widget can't be edited because of JS-error Diffs - ambari-web/app/views/main/dashboard/widgets/supervisor_live.js b8e36ca Diff: https://reviews.apache.org/r/56664/diff/ Testing --- 20345 passing (24s) 153 pending Thanks, Oleg Nechiporenko
Review Request 56653: UI on Admin page-> Auto Start tab is not consistent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56653/ --- Review request for Ambari. Bugs: ambari-20002 https://issues.apache.org/jira/browse/ambari-20002 Repository: ambari Description --- UI on Admin page, Auto Start tab is not consistent. Observing that the Auto Start button on Admin tab is sometimes a checkbox and sometimes a Toggle Button. STR: -> Upgrade ambari from 2.2.2.0 to 2.5.0 -> On Firefox Version 45, go to admin page -> Auto Start Tab It was manually reproduced on Firefox Version 44 Diffs - ambari-web/app/views/main/admin/service_auto_start.js 6f7d644 ambari-web/test/controllers/main/service/info/config_test.js 8ca48b1 Diff: https://reviews.apache.org/r/56653/diff/ Testing --- 20345 passing (21s) 153 pending Thanks, Oleg Nechiporenko
Review Request 56597: Externalize the logic for making navigation bar interactive
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56597/ --- Review request for Ambari and Jaimin Jetly. Bugs: AMBARI-19983 https://issues.apache.org/jira/browse/AMBARI-19983 Repository: ambari Description --- Externalize the logic for making navigation bar interactive Diffs - ambari-web/app/assets/data/clusters/info.json PRE-CREATION ambari-web/app/styles/side_navigation.less 48b8699 ambari-web/app/styles/theme/bootstrap-ambari.css adbddcd ambari-web/app/templates/application.hbs f18d314 ambari-web/app/templates/main/side-menu-item.hbs 27739c8 ambari-web/app/views/application.js f79aad9 ambari-web/app/views/main/menu.js d82d56a ambari-web/brunch-config.js d646fdc ambari-web/vendor/scripts/theme/bootstrap-ambari.js PRE-CREATION Diff: https://reviews.apache.org/r/56597/diff/ Testing --- 20325 passing (22s) 153 pending Thanks, Oleg Nechiporenko
Re: Review Request 56495: Service Config pages load very slowly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56495/#review164918 --- Ship it! Ship It! - Oleg Nechiporenko On Feb. 9, 2017, 1:16 p.m., Denys Buzhor wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56495/ > --- > > (Updated Feb. 9, 2017, 1:16 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-19939 > https://issues.apache.org/jira/browse/AMBARI-19939 > > > Repository: ambari > > > Description > --- > > Reduce configurations loading time by disabling background polling while > configurations loading in progress and enable when finished. > > > Diffs > - > > ambari-web/app/controllers/main/service/info/configs.js 319610c9aa > ambari-web/app/mixins/common/configs/configs_loader.js 666cef8733 > ambari-web/app/mixins/common/track_request_mixin.js 6fcc991ab5 > ambari-web/app/routes/main.js 354198bb7d > ambari-web/test/controllers/main/host/configs_service_test.js deb01ae42d > ambari-web/test/controllers/main/host/details_test.js 7f3fcf74a6 > ambari-web/test/controllers/main/service/info/config_test.js ce98c0ce7a > ambari-web/test/mixins/common/configs/configs_loader_test.js 8f22b444f4 > > Diff: https://reviews.apache.org/r/56495/diff/ > > > Testing > --- > > 20342 passing (23s) > 153 pending > > > Thanks, > > Denys Buzhor > >
Review Request 56485: Confusing Auto Start settings page behavior when loading and API takes a while
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56485/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-19934 https://issues.apache.org/jira/browse/ambari-19934 Repository: ambari Description --- When the Admin > Auto Start settings page gets loaded and the API is taking a while, the behavior is really confusing. It initially shows a checkbox that the user can click on. Upon clicking on it, it shows various Auto Start configs. But when the page fully loads, this whole section disappears, etc. This is consistent with other pages that we have that depend on API results. For example, Admin > Kerberos page does not show any status/button but shows a spinner while the API call is in flight (other pages that follow this pattern are Admin > Stacks and Versions > Versions | Upgrade History, etc). Since this is a new feature we are shipping, this page will receive some attention and the current behavior looks unpolished and confusing - does not inspire confidence. Diffs - ambari-web/app/templates/main/admin/service_auto_start.hbs 87fc915 ambari-web/app/views/main/admin/service_auto_start.js be928ed Diff: https://reviews.apache.org/r/56485/diff/ Testing --- 30312 passing (22s) 157 pending Thanks, Oleg Nechiporenko
Re: Review Request 56445: Ranger Admin HA Wizard should show all configuration changes on Review step
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56445/#review164680 --- Ship it! Ship It! - Oleg Nechiporenko On Feb. 8, 2017, 1:41 p.m., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56445/ > --- > > (Updated Feb. 8, 2017, 1:41 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-19924 > https://issues.apache.org/jira/browse/AMBARI-19924 > > > Repository: ambari > > > Description > --- > > Set of configuration changes to be made by Ranger Admin HA Wizard was added > in scope of AMBARI-19924. None of them are displayed on Review step as of now. > > > Diffs > - > > > ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step3_controller.js > ea77d24 > > ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js > c03c680 > > ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/wizard_controller.js > fbb0692 > ambari-web/app/messages.js cb88fda > ambari-web/app/routes/ra_high_availability_routes.js dbf653b > > ambari-web/test/controllers/main/admin/highAvailability/rangerAdmin/step3_controller_test.js > 649bcbc > > Diff: https://reviews.apache.org/r/56445/diff/ > > > Testing > --- > > 20326 passing (19s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
Review Request 56441: Js errors appear when user try to delete widgets from dashboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56441/
---
Review request for Ambari and Andrii Tkach.
Bugs: AMBARI-19921
https://issues.apache.org/jira/browse/AMBARI-19921
Repository: ambari
Description
---
* Open Dashboard
* Click on "Delete widget links" as fast as you can
* JS-errors appears:
{noformat}
Uncaught Error: could not respond to event
didChangeData in state rootState.loaded.updated.uncommitted.
{noformat}
{noformat}
Uncaught TypeError: Cannot read property 'get' of null
{noformat}
Diffs
-
ambari-web/app/templates/main/dashboard/widgets.hbs 8e04f1c
ambari-web/app/views/main/dashboard/widget.js cacac1a
ambari-web/app/views/main/dashboard/widgets.js 0c6b7aa
ambari-web/test/views/main/dashboard/widget_test.js 8582ad0
ambari-web/test/views/main/dashboard/widgets_test.js b2d154b
Diff: https://reviews.apache.org/r/56441/diff/
Testing
---
20338 passing (22s)
153 pending
Thanks,
Oleg Nechiporenko
Review Request 56381: A lot of warning messages after opening "Upgrade to ..."-popup
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56381/
---
Review request for Ambari and Denys Buzhor.
Bugs: AMBARI-19888
https://issues.apache.org/jira/browse/AMBARI-19888
Repository: ambari
Description
---
* Install ambari
* Register new version
* Install it (install should fail)
* Go to {{#/main/admin/stack/versions}}
* Click "Upgrade" for this version
* Popup with checks appears
* Click on link to see what checks failed
*AR* A lot of warning about undefined variables appear:
{noformat}
WARNING: Watching an undefined global, Ember expects watched globals to be
setup by the time the run loop is flushed, check for typos
{noformat}
Diffs
-
ambari-web/app/templates/common/modal_popups/cluster_check_dialog.hbs 88d8eaf
ambari-web/app/views/common/modal_popups/cluster_check_popup.js a2f6f83
ambari-web/test/models/service_test.js 5bd0cf8
ambari-web/test/views/common/modal_popups/cluster_check_popup_test.js 71e602a
Diff: https://reviews.apache.org/r/56381/diff/
Testing
---
20326 passing (22s)
153 pending
Thanks,
Oleg Nechiporenko
Review Request 56325: Confirmation for deleting services show serviceName and not displayName
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56325/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-19877 https://issues.apache.org/jira/browse/ambari-19877 Repository: ambari Description --- Example: Shown: "Service LOGSEARCH was successfully deleted" Should be: "Service Log Search was successfully deleted" Diffs - ambari-web/app/controllers/main/service/item.js 9758ac3 ambari-web/test/controllers/main/service/item_test.js b582e86 Diff: https://reviews.apache.org/r/56325/diff/ Testing --- 20327 passing (21s) 153 pending Thanks, Oleg Nechiporenko
Review Request 56321: Popup with alerts on the Service summary doesn't have arrows for alerts with state "None"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56321/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-19876 https://issues.apache.org/jira/browse/ambari-19876 Repository: ambari Description --- See screenshot attached to issue Diffs - ambari-web/app/controllers/main/service/info/summary.js 9bdf83a Diff: https://reviews.apache.org/r/56321/diff/ Testing --- 20325 passing (22s) 153 pending Thanks, Oleg Nechiporenko
Review Request 56273: JS error on host configs page
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56273/
---
Review request for Ambari and Denys Buzhor.
Bugs: ambari-19862
https://issues.apache.org/jira/browse/ambari-19862
Repository: ambari
Description
---
{{app.js:193861 Uncaught TypeError: Cannot read property 'someProperty' of
undefined}}
on the
{{return (isCustomPropertiesCategory && this.get('controller.filter') === '' &&
!this.get('mainView.columns').someProperty('selected')) ||}}
Diffs
-
ambari-web/app/views/common/configs/service_configs_by_category_view.js
d9b4409
Diff: https://reviews.apache.org/r/56273/diff/
Testing
---
30313 passing (23s)
157 pending
Thanks,
Oleg Nechiporenko
Review Request 56160: 'num_llap_nodes' should show up as non-editable property when non-ambari managed queue is selected
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56160/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-19814 https://issues.apache.org/jira/browse/ambari-19814 Repository: ambari Description --- - 'num_llap_nodes' as of now is shown as a slider and comes only when we have selected 'llap' named queue and is a child of root level. It is shown because 'num_llap_nodes' visible attribute is set as True by SA. - For any other queue, 'num_llap_nodes' is set as visible=false by SA call and is not shown on UI. *Expected:* A way to show 'num_llap_nodes' node on UI for user, irrespective of the queue selected. Diffs - ambari-web/app/mixins.js ad682d7 ambari-web/app/mixins/common/configs/widgets/unique/num_llap_nodes.js PRE-CREATION ambari-web/app/templates/common/configs/widgets/controls.hbs af5a56a ambari-web/app/views/common/configs/service_config_layout_tab_view.js 30ffadf Diff: https://reviews.apache.org/r/56160/diff/ Testing --- 30311 passing (22s) 157 pending Thanks, Oleg Nechiporenko
Review Request 55979: Wizard modals are closed before confirmation popup appears
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55979/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-19722 https://issues.apache.org/jira/browse/ambari-19722 Repository: ambari Description --- * Open Kerberos Wizard * Proceed to step2 * Press "Esc" * Wizard modal is closed * Confirmation popup appears *ER* Confirmation popup should appears before closing wizard modal This happens because Bootstrap Modal has its own Esc-press handler. It should be disabled Diffs - ambari-web/app/views/common/modal_popup.js 47b7d61 Diff: https://reviews.apache.org/r/55979/diff/ Testing --- 20476 tests complete (32 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Re: Review Request 55918: Move HS2 does not install dependent components on the target host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55918/#review162936 --- Ship it! Ship It! - Oleg Nechiporenko On Jan. 25, 2017, 9:42 a.m., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55918/ > --- > > (Updated Jan. 25, 2017, 9:42 a.m.) > > > Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko. > > > Bugs: AMBARI-19696 > https://issues.apache.org/jira/browse/AMBARI-19696 > > > Repository: ambari > > > Description > --- > > Fix the Move Wizard to install the dependencies automatically as we do in > Install/Add Service Wizards. > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step4_controller.js > b383da7 > > ambari-web/test/controllers/main/alerts/manage_alert_groups_controller_test.js > 2c58017 > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > aac15b8 > > Diff: https://reviews.apache.org/r/55918/diff/ > > > Testing > --- > > 30311 passing (38s) > 157 pending > > > Thanks, > > Andrii Tkach > >
Review Request 55919: "Add Config Property" causes JS-error
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55919/
---
Review request for Ambari and Andrii Tkach.
Bugs: ambari-19703
https://issues.apache.org/jira/browse/ambari-19703
Repository: ambari
Description
---
* Open configs for any service
* Go to any custom category
* Click "Add Property"
* Select not bulk mode (name/value should be separated input-fields)
* Set Key to "abc" and Value to "123"
* Click "Add"
* New config is added
* Click "Add Property" again
* Select not bulk mode (it should be already selected anyway)
* Set Key to "abc"
* Error "This property is already defined in this configuration file" is shown
* "Find property" link is shown too
* Click on it
*ER* "Add Property" modal is closed and configs are filtered with "abc"
*AR* JS-error appears and popup is not hidden
{noformat}
Uncaught TypeError: Cannot read property 'onClose' of null
{noformat}
Diffs
-
ambari-web/app/views/common/configs/service_configs_by_category_view.js
4148197
Diff: https://reviews.apache.org/r/55919/diff/
Testing
---
20474 tests complete (30 seconds)
153 tests pending
Thanks,
Oleg Nechiporenko
Review Request 55838: Alert Popup doesn't execute callback if it's closed without click on "Primary"
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55838/
---
Review request for Ambari and Andrii Tkach.
Bugs: AMBARI-19672
https://issues.apache.org/jira/browse/AMBARI-19672
Repository: ambari
Description
---
{{App.showAlertPopup}} shows popup with some message in the its body and on
button - "Primary". Click on it execute passed callback (if it exists).
Clicking on "x" or "Esc"-press closes modal without callback execution.
Since this modal is not a confirmation-modal (we have
{{App.showConfirmationPopup}}), any interaction with it (click "Ok", press
"Esc", click "x") should execute passed callback.
Diffs
-
ambari-web/app/views/common/modal_popups/alert_popup.js 413d33c
Diff: https://reviews.apache.org/r/55838/diff/
Testing
---
20467 tests complete (31 seconds)
153 tests pending
Thanks,
Oleg Nechiporenko
Review Request 55752: Not completed Upgrade History items show End Time as "Not started"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55752/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-19643 https://issues.apache.org/jira/browse/AMBARI-19643 Repository: ambari Description --- Should be "Not finished" Diffs - ambari-web/app/utils/date/date.js 877b421 ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js e259e3f ambari-web/test/utils/date/date_test.js c82a02e ambari-web/test/views/main/admin/stack_upgrade/upgrade_history_view_test.js cecf98f Diff: https://reviews.apache.org/r/55752/diff/ Testing --- 20460 tests complete (32 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Re: Review Request 55711: Admin View: add spinners for tables in loading state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55711/#review162268 --- Ship it! Ship It! - Oleg Nechiporenko On Jan. 19, 2017, 10:23 a.m., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55711/ > --- > > (Updated Jan. 19, 2017, 10:23 a.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-19625 > https://issues.apache.org/jira/browse/AMBARI-19625 > > > Repository: ambari > > > Description > --- > > Admin View: add spinners for tables in loading state > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js > e98801c > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js > 948b707 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js > dc3a120 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js > 34daa29 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js > bd2cec4 > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css c81b789 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html > e03f035 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html > 82a4dec > ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html > 6be6fdd > > ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html > 7f525e8 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html > 5ac78ca > ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html > 9e93032 > > Diff: https://reviews.apache.org/r/55711/diff/ > > > Testing > --- > > PhantomJS 1.9.8 (Linux): Executed 86 of 86 SUCCESS (0.601 secs / 0.6 secs) > > > Thanks, > > Andrii Tkach > >
Review Request 55673: Add UI UT for alerts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55673/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-19611 https://issues.apache.org/jira/browse/AMBARI-19611 Repository: ambari Description --- Add UI UT for alerts Diffs - ambari-web/app/assets/test/tests.js e42c811 ambari-web/app/controllers/main/alerts/definition_details_controller.js ea9b5b7 ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js a501a34 ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js 8501678 ambari-web/app/mappers/alert_definitions_mapper.js cd4e738 ambari-web/app/models/alerts/alert_config.js 1af02fc ambari-web/app/models/alerts/alert_group.js 4f40ccf ambari-web/app/models/alerts/alert_notification.js e503c6b ambari-web/test/controllers/main/alerts/manage_alert_groups_controller_test.js 45c2a4c ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js d63dcb8 ambari-web/test/models/alerts/alert_config_test.js 74a91f4 ambari-web/test/models/alerts/alert_group_test.js 036a32d ambari-web/test/models/alerts/alert_notification_test.js PRE-CREATION Diff: https://reviews.apache.org/r/55673/diff/ Testing --- 20454 tests complete (32 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Re: Review Request 55618: Ranger Admin HA Wizard should display configs changes explicitly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55618/#review161862 --- Ship it! Ship It! - Oleg Nechiporenko On Jan. 17, 2017, 1:48 p.m., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55618/ > --- > > (Updated Jan. 17, 2017, 1:48 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-19586 > https://issues.apache.org/jira/browse/AMBARI-19586 > > > Repository: ambari > > > Description > --- > > Configs changes in Ranger Admin HA Wizard aren't shown explicitly (just the > message mentioning the affected property is displayed instead). > > > Diffs > - > > ambari-web/app/assets/test/tests.js 604d96b > > ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step3_controller.js > 475cc52 > > ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/step4_controller.js > b7818d9 > > ambari-web/app/controllers/main/admin/highAvailability/rangerAdmin/wizard_controller.js > 2bc6e37 > ambari-web/app/routes/ra_high_availability_routes.js ac975ab > ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/step3.hbs > 3c798c8 > ambari-web/app/views/main/admin/highAvailability/rangerAdmin/step3_view.js > 8aa0125 > > ambari-web/test/controllers/main/admin/highAvailability/rangerAdmin/step3_controller_test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/55618/diff/ > > > Testing > --- > > 20395 tests complete (39 seconds) > 153 tests pending > > > Thanks, > > Andriy Babiichuk > >
Review Request 55560: Timezone for timestamps in Upgrade History not consistent with Background Operations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55560/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-19560 https://issues.apache.org/jira/browse/ambari-19560 Repository: ambari Description --- Looks like the timestamp in Upgrade History are shown as per current machine's timezone; while the timestamp entries in Background Operations Window is in GMT This causes confusion while trying to correlate events that happen after upgrade, as my machine's timezone is GMT+5.30, so the post upgrade events appear to show up few hours before the upgrade time reported in 'Upgrade History' Diffs - ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 8df8349 Diff: https://reviews.apache.org/r/55560/diff/ Testing --- 20389 tests complete (31 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Review Request 55484: Two SelectBoxes don't have class `form-control`
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55484/
---
Review request for Ambari and Denys Buzhor.
Bugs: ambari-19517
https://issues.apache.org/jira/browse/ambari-19517
Repository: ambari
Description
---
{{ambari-web/app/templates/main/service/add_host_popup.hbs}}
{{ambari-web/app/templates/common/modal_popups/select_groups_popup.hbs}}
Diffs
-
ambari-web/app/templates/common/modal_popups/select_groups_popup.hbs c7da8a4
ambari-web/app/templates/main/service/add_host_popup.hbs 7431080
Diff: https://reviews.apache.org/r/55484/diff/
Testing
---
20389 tests complete (32 seconds)
153 tests pending
Thanks,
Oleg Nechiporenko
Review Request 55426: JS error when user click Alert Link in the popup on the service summary page
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55426/
---
Review request for Ambari and Andrii Tkach.
Bugs: AMBARI-19465
https://issues.apache.org/jira/browse/AMBARI-19465
Repository: ambari
Description
---
* Go to HDFS summary
* Open Alerts Popup
* Click on the any Alert-link
*AR:* JS-error appears:
{noformat}
Uncaught TypeError: Cannot read property 'toggle' of undefined
{noformat}
Diffs
-
ambari-web/app/controllers/main/service/info/summary.js fc423fe
Diff: https://reviews.apache.org/r/55426/diff/
Testing
---
20389 tests complete (33 seconds)
153 tests pending
Thanks,
Oleg Nechiporenko
Review Request 55415: Screen stuck when no suitable OS is detected
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55415/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-19460 https://issues.apache.org/jira/browse/AMBARI-19460 Repository: ambari Description --- When the only machine in the cluster is running Ubuntu 16, deployment fails at last step before start Expected behavior: Click on the warning will go back to the review page Actual behavior: User is stuck at "task completed" screen, even though the deployment failed Diffs - ambari-web/app/controllers/wizard/step8_controller.js 6475d49 ambari-web/app/mixins/wizard/wizardDeployProgressController.js 4a5cb84 ambari-web/test/controllers/wizard/step8_test.js 5efb866 Diff: https://reviews.apache.org/r/55415/diff/ Testing --- 20389 tests complete (36 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Review Request 55380: Add macros `existsInByKey` and `notExistsInByKey`
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55380/ --- Review request for Ambari and Andrii Tkach. Bugs: ambari-19445 https://issues.apache.org/jira/browse/ambari-19445 Repository: ambari Description --- ||existsInByKey||notExistsInByKey|| |A computed property that returns true if dependent property exists in the property with needed values|A computed property that returns true if dependent property doesn't exist in the property with needed values| Diffs - ambari-web/app/utils/ember_computed.js e21f4d3 ambari-web/app/views/main/alerts/definition_details_view.js fc80c89 ambari-web/app/views/main/host/details/host_component_view.js b5ea711 ambari-web/app/views/main/service/menu.js 2c9ac5c ambari-web/test/aliases/computed/existsInByKey.js PRE-CREATION ambari-web/test/aliases/computed/notExistsInByKey.js PRE-CREATION ambari-web/test/app_test.js 42789d5 ambari-web/test/init_computed_aliases.js 612d831 ambari-web/test/utils/ember_computed_test.js e5754f5 ambari-web/test/views/main/alerts/definition_details_view_test.js e468968 ambari-web/test/views/main/host/details/host_component_view_test.js 50197bc ambari-web/test/views/main/service/menu_test.js 15f0c15 Diff: https://reviews.apache.org/r/55380/diff/ Testing --- 20378 tests complete (26 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Re: Review Request 55376: Ambari should add warning when LogSearch selected without Ambari-Infra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55376/#review161057
---
Ship it!
Ship It!
- Oleg Nechiporenko
On Jan. 10, 2017, 11:31 a.m., Andrii Tkach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55376/
> ---
>
> (Updated Jan. 10, 2017, 11:31 a.m.)
>
>
> Review request for Ambari and Oleg Nechiporenko.
>
>
> Bugs: AMBARI-19441
> https://issues.apache.org/jira/browse/AMBARI-19441
>
>
> Repository: ambari
>
>
> Description
> ---
>
> That issue demonstrates that is is possible, during a UI cluster deployment,
> to select "LogSearch" as a service, but not select "Ambari-Infra". The UI
> then continues through the wizard, without requiring any additional LogSearch
> configuration.
> LogSearch has been updated to allow for external SolrCloud deployments as
> well as internally-managed SolrCloud deployments, so the original dependency
> in the stack had to be removed to support this deployment mode.
> That being said, the default behavior in the UI deployment should still
> encourage most users to accept the default behavior, meaning that the
> Ambari-Infra service should be included.
> Currently, if Ambari-Infra is not selected, the deployment will fail, since
> the wizard does not require either selecting Ambari-Infra or configuring the
> location of the external SolrCloud instance.
> I ran a test by selecting Atlas without selecting Ambari-Infra (which is a
> similar deployment case, since Atlas can use an internal or external
> SolrCloud deployment), and found that in the Atlas case the UI pops up a
> "Limited Functionality Warning" if Ambari-Infra is not selected.
> We should implement this for LogSearch as well, so that if the user selects
> LogSearch, but does not select Ambari-Infra, then a LogSearch-specific
> limited functionality warning pops up, to let the user know that this is not
> default scenario, and will require further configuration.
> This work would involve two tasks:
> 1. If the user selects LogSearch, then Ambari-Infra should be auto-selected
> by default.
> 2. Adding the "Limited Warning Functionality" popup to the wizard, if
> LogSearch is selected without Ambari-Infra.
> 3. If the user receives this popup and chooses to proceed anyway, the
> configuration wizard should enforce the configuration of the external
> SolrCloud instance.
> I took a quick look at the ambari-web code, and it looks like something
> similar to #2 is implemented in the step4_controller.js:
> var atlasService = this.findProperty('serviceName', 'ATLAS');
> var ambariInfraService = this.findProperty('serviceName', 'AMBARI_INFRA');
> if (atlasService && atlasService.get('isSelected') && ambariInfraService
> && !ambariInfraService.get('isSelected')) {
> this.serviceValidation(callback, 'AMBARI_INFRA', 'ambariInfraCheck');
> }
> It's likely that we can reuse this approach for LogSearch as well.
>
>
> Diffs
> -
>
> ambari-web/app/controllers/wizard.js b4fc8c5
> ambari-web/app/controllers/wizard/step4_controller.js 317c548
> ambari-web/app/controllers/wizard/step7_controller.js 0d30d12
> ambari-web/app/mappers/stack_service_mapper.js c0454b0
> ambari-web/app/messages.js 0c3e10a
> ambari-web/app/utils/configs/theme/theme.js c3b312a
> ambari-web/test/controllers/wizard/step4_test.js b9b21cf
> ambari-web/test/utils/configs/theme/theme_test.js c9abf78
>
> Diff: https://reviews.apache.org/r/55376/diff/
>
>
> Testing
> ---
>
> 20212 passing (36s)
> 153 pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 55212: When deleting services UI shows a lot of configs to be changing but none changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55212/#review160588 --- Ship it! Ship It! - Oleg Nechiporenko On Янв. 5, 2017, 2:49 п.п., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55212/ > --- > > (Updated Янв. 5, 2017, 2:49 п.п.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-19387 > https://issues.apache.org/jira/browse/AMBARI-19387 > > > Repository: ambari > > > Description > --- > > It appears that UI feedback shows the sum total of configs recommended by > stack advisor even if only a subset of the configs are actually applied. > > > Diffs > - > > ambari-web/app/controllers/main/service/info/configs.js b5538e0 > ambari-web/app/controllers/main/service/item.js 8921e22 > ambari-web/app/mixins/common/configs/enhanced_configs.js f92aac1 > ambari-web/test/controllers/main/service/info/config_test.js a06ff8a > ambari-web/test/mixins/common/configs/enhanced_configs_test.js a9c9770 > > Diff: https://reviews.apache.org/r/55212/diff/ > > > Testing > --- > > 20129 tests complete (21 seconds) > 153 tests pending > > > Thanks, > > Andriy Babiichuk > >
Review Request 55210: Config Groups: Save button not enabled while trying to overwrite configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55210/ --- Review request for Ambari and Andrii Tkach. Bugs: ambari-19182 https://issues.apache.org/jira/browse/ambari-19182 Repository: ambari Description --- STR: -> For a service, create a config group -> Go to configs page, select the config group. Now try to overwrite a config, Save button is not enabled here. Diffs - ambari-web/app/models/configs/objects/service_config.js 7d07467 ambari-web/test/controllers/main/admin/highAvailability/journalNode/step4_controller_test.js ba92b54 ambari-web/test/controllers/main/admin/highAvailability/resourceManager/step3_controller_test.js 665d8e6 ambari-web/test/utils/config_test.js 7c2515a Diff: https://reviews.apache.org/r/55210/diff/ Testing --- 20126 tests complete (25 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Re: Review Request 55102: Install Wizard cannot proceed beyond Select Services page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55102/#review160297 --- Ship it! Ship It! - Oleg Nechiporenko On Дек. 30, 2016, 1:49 п.п., Aleksandr Kovalenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55102/ > --- > > (Updated Дек. 30, 2016, 1:49 п.п.) > > > Review request for Ambari, Andriy Babiichuk and Oleg Nechiporenko. > > > Bugs: AMBARI-19329 > https://issues.apache.org/jira/browse/AMBARI-19329 > > > Repository: ambari > > > Description > --- > > Install Wizard cannot proceed beyond Select Services page > > > Diffs > - > > ambari-web/app/controllers/wizard.js 8742546 > ambari-web/app/controllers/wizard/step6_controller.js 745ecc7 > ambari-web/test/controllers/wizard/step6_test.js 851b984 > > Diff: https://reviews.apache.org/r/55102/diff/ > > > Testing > --- > > 19840 passing (20s) > 153 pending > > > Thanks, > > Aleksandr Kovalenko > >
Review Request 55101: Install Wizard needs to scroll back up to top on step transitions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55101/ --- Review request for Ambari and Aleksandr Kovalenko. Bugs: AMBARI-19326 https://issues.apache.org/jira/browse/AMBARI-19326 Repository: ambari Description --- On trunk, I noticed that the new design is requiring a lot of scrolling down for the Next button. Once the transition to the next page is made, I have to scroll all the way to the top every time. This is quite annoying. Diffs - ambari-web/app/routes/installer.js b4aa799 ambari-web/app/utils/ember_reopen.js 4fd7cd4 Diff: https://reviews.apache.org/r/55101/diff/ Testing --- 19991 tests complete (27 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Re: Review Request 55086: Recommended configs changes are displayed twice before adding or deleting Nimbus
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55086/#review160277 --- Ship it! Ship It! - Oleg Nechiporenko On Dec. 29, 2016, 4:11 p.m., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55086/ > --- > > (Updated Dec. 29, 2016, 4:11 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-19318 > https://issues.apache.org/jira/browse/AMBARI-19318 > > > Repository: ambari > > > Description > --- > > If there are any configs changes are recommended before adding or deleting > Nimbus to host, they are displayed twice. > > > Diffs > - > > ambari-web/app/controllers/main/host/details.js cb4a2ad > ambari-web/test/controllers/main/host/details_test.js cb48ae1 > > Diff: https://reviews.apache.org/r/55086/diff/ > > > Testing > --- > > 19991 tests complete (24 seconds) > 153 tests pending > > > Thanks, > > Andriy Babiichuk > >
Review Request 55081: Adding custom property should trim white spaces in the prefix and suffix of the key names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55081/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-19287 https://issues.apache.org/jira/browse/AMBARI-19287 Repository: ambari Description --- *STR:* # Add a custom property by keeping trailing whitespace in the property name *Expected behavior:* white spaces at the end and similar white space in the beginning of the property name should be trimmed and the property should be added and shown in the custom section *Actual behavior:* Validation error is shown users that copy paste property name from some document to the custom property addition dialog often have trailing white spaces and see a validation error that leads to confusion. Note: Scope of this work is for both single property addition and bulk addition of all properties but it is limited to only property name. No logic related to property value needs to be changed as part of this task Diffs - ambari-web/app/utils/validator.js c7248bb ambari-web/app/views/common/configs/service_configs_by_category_view.js 3ebc2cf ambari-web/test/controllers/main/host/details_test.js 859320e ambari-web/test/utils/validator_test.js 4f069e0 Diff: https://reviews.apache.org/r/55081/diff/ Testing --- 19991 tests complete (25 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Review Request 55070: UI should validate Ranger user password be more than 8 chars
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55070/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-19307 https://issues.apache.org/jira/browse/AMBARI-19307 Repository: ambari Description --- During Ranger deploy, on config tab, user should set password for admin user. UI do not validate password to be more than 8 characters. As the result, when we will try to create it in Ranger, this user will not be valid (you can't use this name/password to enter Ranger UI). Related alert will show critical message. So, i think it should be fixed. Diffs - ambari-web/app/messages.js e9d117a ambari-web/app/utils/config.js cd09e14 ambari-web/test/models/configs/objects/service_config_property_test.js ef0bd61 Diff: https://reviews.apache.org/r/55070/diff/ Testing --- 19984 tests complete (27 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Re: Review Request 55015: Background Operations popup: no name for operations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55015/#review160093 --- Ship it! Ship It! - Oleg Nechiporenko On Dec. 23, 2016, 4:46 p.m., Aleksandr Kovalenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55015/ > --- > > (Updated Dec. 23, 2016, 4:46 p.m.) > > > Review request for Ambari, Alexandr Antonenko and Oleg Nechiporenko. > > > Bugs: AMBARI-19294 > https://issues.apache.org/jira/browse/AMBARI-19294 > > > Repository: ambari > > > Description > --- > > Background Operations popup: no name for operations > > > Diffs > - > > ambari-web/app/controllers/global/background_operations_controller.js > 3a011f5 > ambari-web/test/controllers/global/background_operations_test.js 323f090 > > Diff: https://reviews.apache.org/r/55015/diff/ > > > Testing > --- > > 19829 passing (22s) > 153 pending > > > Thanks, > > Aleksandr Kovalenko > >
Review Request 54971: AHW Configurations page looks not like any other wizard page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54971/ --- Review request for Ambari and Aleksandr Kovalenko. Bugs: ambari-19279 https://issues.apache.org/jira/browse/ambari-19279 Repository: ambari Description --- Configurations page on AHW wasn't updated when Ambari Theme was created. Diffs - ambari-web/app/templates/main/host/addHost/step4.hbs 305b5f4 Diff: https://reviews.apache.org/r/54971/diff/ Testing --- 19866 tests complete (30 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Review Request 54934: NN HA Namespace input "jumps" when invalid value provided
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54934/ --- Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Andrii Tkach. Bugs: AMBARI-19267 https://issues.apache.org/jira/browse/AMBARI-19267 Repository: ambari Description --- Namespace input becomes full-width when some invalid value provided. Input should always look the same. Diffs - ambari-web/app/styles/wizard.less 49b6723 ambari-web/app/templates/main/admin/highAvailability/nameNode/step1.hbs f5087f9 ambari-web/test/controllers/main/host/details_test.js 4203644 Diff: https://reviews.apache.org/r/54934/diff/ Testing --- 19866 tests complete (24 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Review Request 54786: DataNodes Live widget can't be edited
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54786/ --- Review request for Ambari and Andrii Tkach. Bugs: ambari-19213 https://issues.apache.org/jira/browse/ambari-19213 Repository: ambari Description --- Click on Edit-button for "DataNodes Live" widget causes JS error. Diffs - ambari-web/app/mixins/main/dashboard/widgets/editable.js 3206229 ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js df1b645 ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 12c7d1a ambari-web/app/styles/modal_popups.less 0c87e63 ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs 982dc9b ambari-web/app/views/main/dashboard/widget.js 563e31d ambari-web/app/views/main/dashboard/widgets/pxf_live.js a002fe3 ambari-web/test/controllers/main/admin/highAvailability_controller_test.js f5a144b Diff: https://reviews.apache.org/r/54786/diff/ Testing --- 19882 tests complete (25 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Re: Review Request 54780: Restore styles of remove repository icon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54780/#review159291 --- Ship it! Ship It! - Oleg Nechiporenko On Dec. 15, 2016, 1:28 p.m., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54780/ > --- > > (Updated Dec. 15, 2016, 1:28 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-19211 > https://issues.apache.org/jira/browse/AMBARI-19211 > > > Repository: ambari > > > Description > --- > > Restore styles of the remove repository icon in Wizard on Select Version step. > > > Diffs > - > > ambari-web/app/styles/wizard.less 9920319 > ambari-web/app/templates/wizard/step1.hbs 8179b41 > > Diff: https://reviews.apache.org/r/54780/diff/ > > > Testing > --- > > 19726 passing (26s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Review Request 54779: SMTP Username and SMTP Password are not highlighted
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54779/ --- Review request for Ambari and Andrii Tkach. Bugs: ambari-19210 https://issues.apache.org/jira/browse/ambari-19210 Repository: ambari Description --- * Proceed to step7 installer * Open Misc tab * Check "SMTP server requires authentication" *AR* SMTP Username and SMTP Password are not highlighted *ER* SMTP Username and SMTP Password are highlighted Diffs - ambari-web/app/templates/common/configs/notifications_configs.hbs 2dd71aa Diff: https://reviews.apache.org/r/54779/diff/ Testing --- 19879 tests complete (33 seconds) 153 tests pending Thanks, Oleg Nechiporenko
Re: Review Request 54742: Turning OFF maintenance mode shows a popup on all hosts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54742/#review159147 --- Ship it! Ship It! - Oleg Nechiporenko On Dec. 14, 2016, 1:02 p.m., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54742/ > --- > > (Updated Dec. 14, 2016, 1:02 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-19200 > https://issues.apache.org/jira/browse/AMBARI-19200 > > > Repository: ambari > > > Description > --- > > STEPS TO REPRODUCE: > Complete upgrade > Pick a random node > Set Maintenance mode ON > Set Maintenance mode OFF > > > Diffs > - > > ambari-web/app/controllers/global/cluster_controller.js edb9a26 > ambari-web/test/controllers/global/cluster_controller_test.js fa95c3e > > Diff: https://reviews.apache.org/r/54742/diff/ > > > Testing > --- > > 19726 passing (28s) > 153 pending > > > Thanks, > > Andrii Tkach > >
Review Request 54734: BG operations modal windows are too small to show the content (in certain scenarios) [Chrome]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54734/ --- Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Andrii Tkach. Bugs: ambari-19196 https://issues.apache.org/jira/browse/ambari-19196 Repository: ambari Description --- 1. Login to Ambari 2. Click on BG operations. 3. Click on some action link which have relatively lesser content, e.g Hosts, with only one host link. 4. Click on the link to get more details 5. Intermittently the details window also have the same dimension of the previous window and as a result the user is not able to view the content BG operations modal window should be resizable as intermittently modal windows are too small to view the content[Chrome]. This behavior is observed when we navigate to the granular details and the previous window was smaller size due to lesser content. Please see the screenshots Intermittently the details window also have the same dimension of the previous window and as a result the user is not able to view the content Diffs - ambari-web/app/views/common/modal_popup.js a643b23 ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js f3f05a4 Diff: https://reviews.apache.org/r/54734/diff/ Testing --- 19878 tests complete (40 seconds) 155 tests pending Thanks, Oleg Nechiporenko
Review Request 54482: Tooltip is not hidden on host alerts page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54482/ --- Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Andrii Tkach. Bugs: AMBARI-19128 https://issues.apache.org/jira/browse/AMBARI-19128 Repository: ambari Description --- * Go to Host Alerts page * Focus in the filter alert-text field * Move pointer to the some alert text * Wait while tooltip appears * Start typing something (focus should be on the alert-text field) * Type until no record will be shown in the table *ER* Tooltip should disappear *AR* Tooltip is shown and not hidden even on move to another page Diffs - ambari-web/app/templates/main/host/host_alerts.hbs 17c8bc3 ambari-web/app/views/main/host/host_alerts_view.js 34a2a3e ambari-web/test/views/main/host/host_alerts_view_test.js 2c0d59a Diff: https://reviews.apache.org/r/54482/diff/ Testing --- 19926 tests complete (26 seconds) 155 tests pending Thanks, Oleg Nechiporenko
Review Request 54369: JS error on "User RedHat Satellite" click on step1 installer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54369/
---
Review request for Ambari and Andrii Tkach.
Bugs: ambari-19081
https://issues.apache.org/jira/browse/ambari-19081
Repository: ambari
Description
---
* Proceed to step1
* Click on "User Local Repo"
* Click on " Use RedHat Satellite/Spacewalk"
JS error appears:
{noformat}
Maximum call stack size exceeded
{noformat}
Diffs
-
ambari-web/app/styles/wizard.less a4dac8c
ambari-web/app/templates/wizard/step1.hbs 5297d12
ambari-web/app/views/wizard/step1_view.js d5cbbb5
ambari-web/test/views/common/configs/widgets/slider_config_widget_view_test.js
a6b25ce
ambari-web/test/views/main/dashboard/widgets_test.js 707087a
Diff: https://reviews.apache.org/r/54369/diff/
Testing
---
19917 tests complete (28 seconds)
155 tests pending
Thanks,
Oleg Nechiporenko
Review Request 54253: Select Versions page: 'Remove' tooltip does not disappear
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54253/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-19047 https://issues.apache.org/jira/browse/AMBARI-19047 Repository: ambari Description --- Select Versions page: 'Remove' tooltip does not disappear Diffs - ambari-web/app/templates/wizard/step1.hbs 312898c ambari-web/app/views/wizard/step1_view.js b7a57ca Diff: https://reviews.apache.org/r/54253/diff/ Testing --- 20020 tests complete (30 seconds) 155 tests pending Thanks, Oleg Nechiporenko
Review Request 54203: Manage JournalNode tweaks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54203/ --- Review request for Ambari and Andrii Tkach. Bugs: ambari-19027 https://issues.apache.org/jira/browse/ambari-19027 Repository: ambari Description --- I reviewed the changes that are in ambari-server-2.5.0.0-340.x86_64. I noticed most of the wording changes are in there, but not all. I've updated the deck to keep only show the changes that still need to be made. Diffs - ambari-web/app/messages.js aa43687 ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs 547d364 Diff: https://reviews.apache.org/r/54203/diff/ Testing --- 20020 tests complete (31 seconds) 155 tests pending Thanks, Oleg Nechiporenko
Review Request 54162: Fix markup for widgets browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54162/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-19011 https://issues.apache.org/jira/browse/AMBARI-19011 Repository: ambari Description --- ~ Diffs - ambari-web/app/messages.js a1d84a3 ambari-web/app/styles/application.less d449ccb ambari-web/app/styles/bootstrap_overrides.less 97c25ab ambari-web/app/styles/enhanced_service_dashboard.less 870e9a8 ambari-web/app/styles/hosts.less 0dde61d ambari-web/app/templates/common/modal_popups/widget_browser_popup.hbs 3f76a0a ambari-web/app/templates/main/service/widgets/create/expression.hbs 5d05b4a ambari-web/app/templates/main/service/widgets/create/step1.hbs 0edc935 ambari-web/app/templates/main/service/widgets/create/step2.hbs aac3726 ambari-web/app/templates/main/service/widgets/create/step2_add_metric.hbs 7d39dfc ambari-web/app/templates/main/service/widgets/create/step2_graph.hbs 4a8638c ambari-web/app/templates/main/service/widgets/create/step2_number.hbs dfd86cd ambari-web/app/templates/main/service/widgets/create/step2_template.hbs a743378 ambari-web/app/templates/main/service/widgets/create/step3.hbs 45d3142 ambari-web/app/templates/main/service/widgets/create/widget_property_threshold.hbs 7196ddb ambari-web/app/views/common/chosen_plugin.js 95f6c1e ambari-web/app/views/common/controls_view.js 37d7165 ambari-web/app/views/main/service/widgets/create/step2_view.js dbc5bc7 Diff: https://reviews.apache.org/r/54162/diff/ Testing --- 19935 tests complete (31 seconds) 154 tests pending Thanks, Oleg Nechiporenko
Re: Review Request 54155: Fix input height in filters with dropdown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54155/#review157225 --- Ship it! Ship It! - Oleg Nechiporenko On Nov. 29, 2016, 11:48 a.m., Andriy Babiichuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54155/ > --- > > (Updated Nov. 29, 2016, 11:48 a.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-19008 > https://issues.apache.org/jira/browse/AMBARI-19008 > > > Repository: ambari > > > Description > --- > > Text input and dropdown toggle button have got different height. > > > Diffs > - > > ambari-web/app/styles/theme/bootstrap-ambari.css f427c0a > > Diff: https://reviews.apache.org/r/54155/diff/ > > > Testing > --- > > 19935 tests complete (21 seconds) > 154 tests pending > > > Thanks, > > Andriy Babiichuk > >
Re: Review Request 54063: typeahead was lost while bootstrap 2 to bootstrap3 mirgation
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54063/
---
(Updated Nov. 24, 2016, 1:52 p.m.)
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-18985
https://issues.apache.org/jira/browse/AMBARI-18985
Repository: ambari
Description
---
{{typeahead}} was a part of bootstrap2. After upgrade to the bootstrap3 it was
deleted. {{typeahead}} is used on the assign master page when there are lot of
hosts in the cluster.
Diffs
-
ambari-web/app/views/common/assign_master_components_view.js 53859f6
ambari-web/brunch-config.js 27a6057
ambari-web/vendor/scripts/jquery.typeahead.js PRE-CREATION
Diff: https://reviews.apache.org/r/54063/diff/
Testing
---
19928 tests complete (32 seconds)
154 tests pending
Thanks,
Oleg Nechiporenko
Re: Review Request 53846: Kerberos wizard: Show recommendation API failure message in a popup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53846/#review156201 --- Ship it! Ship It! - Oleg Nechiporenko On Nov. 17, 2016, 2:47 p.m., Aleksandr Kovalenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53846/ > --- > > (Updated Nov. 17, 2016, 2:47 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-18920 > https://issues.apache.org/jira/browse/AMBARI-18920 > > > Repository: ambari > > > Description > --- > > If recommendation API fails on configure identities page then page keeps on > showing spinner. Instead user should see the failure message > > > Diffs > - > > ambari-web/app/controllers/main/admin/kerberos/step4_controller.js eebe133 > ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 918742d > ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js > 86e126e > > Diff: https://reviews.apache.org/r/53846/diff/ > > > Testing > --- > > 30621 tests complete (36 seconds) > 151 tests pending > > > Thanks, > > Aleksandr Kovalenko > >
Re: Review Request 53650: Stack Versions page: fix styles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53650/#review155604 --- Ship it! Ship It! - Oleg Nechiporenko On Nov. 10, 2016, 4:18 p.m., Andrii Tkach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53650/ > --- > > (Updated Nov. 10, 2016, 4:18 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-18849 > https://issues.apache.org/jira/browse/AMBARI-18849 > > > Repository: ambari > > > Description > --- > > Stack Versions page: fix styles > > > Diffs > - > > ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js > 4429bf4 > > ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js > ae9471c > ambari-web/app/routes/stack_upgrade_routes.js 7cf83b6 > ambari-web/app/styles/application.less df2d054 > ambari-web/app/styles/stack_versions.less b183303 > ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs > 6548ea0 > ambari-web/app/templates/main/admin/stack_upgrade/versions.hbs 6e45868 > ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js > fda0c7e > > Diff: https://reviews.apache.org/r/53650/diff/ > > > Testing > --- > > 30497 tests complete (30 seconds) > 151 tests pending > > > Thanks, > > Andrii Tkach > >
Re: Review Request 48850: Views in Ambari UI don't render when proxied by Knox
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48850/#review138216 --- Ship it! Ship It! - Oleg Nechiporenko On June 17, 2016, 1:44 p.m., Aleksandr Kovalenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48850/ > --- > > (Updated June 17, 2016, 1:44 p.m.) > > > Review request for Ambari, Andrii Tkach, Oleg Nechiporenko, and Sumit Gupta. > > > Bugs: AMBARI-17195 > https://issues.apache.org/jira/browse/AMBARI-17195 > > > Repository: ambari > > > Description > --- > > When using Knox's AMBARIUI service to proxy the Ambari service's UI, the > various 'views' don't render. The rest of the UI around management of > services works correctly. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/index.html 25379c1 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js b658fb0 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewUrlCtrl.js > 4a663c4 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewUrlEditCtrl.js > 93edc69 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js > 7bb4039 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/mainCtrl.js > 2878f88 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js > 8b697f8 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > 6fe46dc > ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js 96bcb4c > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html > f6facb5 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html > 4654147 > ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html > 2649eb0 > ambari-admin/src/main/resources/ui/admin-web/app/views/main.html f9e6e63 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html > 10d4a82 > ambari-web/app/config.js fe970b1 > ambari-web/app/router.js a057215 > ambari-web/app/routes/views.js c50690c > ambari-web/app/views/main/admin/stack_upgrade/versions_view.js bdf8d7d > > Diff: https://reviews.apache.org/r/48850/diff/ > > > Testing > --- > > Manually tested. > > ambari-web unit tests: > 28636 tests complete (34 seconds) > 154 tests pending > ambari-admin unit tests: > PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.347 secs / 0.538 > secs) > > > Thanks, > > Aleksandr Kovalenko > >
