Re: Review Request 64971: AMBARI-22252. Revert Blueprint V2 changes

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64971/#review194982
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 8, 2018, 8:59 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64971/
> ---
> 
> (Updated Jan. 8, 2018, 8:59 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Dmytro Sen, Jayush Luniya, 
> Madhuvanthi Radhakrishnan, Robert Nettleton, and Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A few changes for Blueprint V2 work were initially commited on 
> `branch-feature-AMBARI-14714` before the "private" feature branch 
> `branch-feature-AMBARI-14714-blueprintv2` was forked.  This change mostly 
> reverts those commits.
> 
> It also fixes `ServiceComponentRequest` usage in `AmbariContext` (wrong 
> constructor was used), and expectations for `createServices` and 
> `createComponents` in `AmbariContextTest` (they are no longer `void` methods).
> 
> The only functional change compared to `trunk` blueprint code is that it 
> creates a default service group when provisioning the cluster.  This is 
> allows successful deployment using "old" blueprints.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
>  7171fc79c2d6997c1aa3669a96704e3f35592fa8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  76782d5988364654a5326b5975b1449d7ddea854 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
>  9bbdc37a62cc82e22e3ecb14d016571c63f8943f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/users/ActiveWidgetLayoutService.java
>  2667a0c5d283d2cb2b2e361de833db43d98e144c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java
>  036f1bdb17495dd98ad84c9fed4c2e95d88b4a81 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  c88b23c8af374dd9bd695b70560079871f3366fd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupRequest.java
>  53c3d1e77144458566b49b98d9a8c51381f6ff29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2.java 
> 0b0329c31bb5800eb32ba4b437bd57a41a618dbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackV2Factory.java
>  784b3683ba9d3909bb9e6d900e4175b6a00aec9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  5104354fce7701fe023723c19d56d25e7adf5219 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java
>  a38f478ed05ec88816e6363b31aa102a4a9d353f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  d2f24d9445ea5a33aaf1d286ff40bfc91787c277 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintV2ResourceProvider.java
>  6d2c4f06f5c75fbdf9e81c2d711440862f375bb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  cc0cea377233931bf65943f792f6a7e11b074f06 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationContext.java
>  aa63021b8a5a4e386652b936ceaefe6c2298797e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java
>  565369b08b6eeb1a598575e448ce0c6334b6234b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  f773fc8aac61f74988dd63a7a8b2cc30053023d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  1284c265c150aa03c00b43b364c2163ca4e564a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UnitUpdater.java
>  3a70f8124be3034f29edd51a96e00b8e25dfd661 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintV2DAO.java
>  6a054e8c9038acb63579065e6093193a3735eb90 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
>  8141f070bb40872fea9fae12e72adcf778ba8225 
>   
> ambari-server/src/main/java/org

Re: Review Request 64913: AMBARI-22718. Cannot set security.inter.broker.protocol: SASL_SSL via Blueprint with Kerberos

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64913/#review194699
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 3, 2018, 9:16 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64913/
> ---
> 
> (Updated Jan. 3, 2018, 9:16 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Robert Levas, 
> and Yolanda Davis.
> 
> 
> Bugs: AMBARI-22718
> https://issues.apache.org/jira/browse/AMBARI-22718
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change Kafka stack script `params.py` to accept `SASL_SSL` as a valid 
> `security.inter.broker.protocol` value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  c6b36a1c729e6edb3c26043d2392cc177ad6d220 
>   
> ambari-server/src/test/python/stacks/2.6/KAFKA/test_kafka_broker_other_sasl.py
>  e0bab4017057c25c958f5c93cff65e128cbbf72e 
>   ambari-server/src/test/python/stacks/2.6/configs/secure_kafka_sasl_ssl.json 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64913/diff/1/
> 
> 
> Testing
> ---
> 
> Tested per steps in 
> [AMBARI-22718](https://issues.apache.org/jira/browse/AMBARI-22718)
> 
> Added unit test.  Unit tests are OK:
> 
> ```
> Total run:1201
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 64914: AMBARI-22719. Regenerate Keytabs resets security.inter.broker.protocol to PLAINTEXTSASL

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64914/#review194698
---


Ship it!




Ship It!

- Robert Nettleton


On Jan. 3, 2018, 11:24 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64914/
> ---
> 
> (Updated Jan. 3, 2018, 11:24 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Robert Levas, 
> and Yolanda Davis.
> 
> 
> Bugs: AMBARI-22719
> https://issues.apache.org/jira/browse/AMBARI-22719
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Let stack advisor retain `security.inter.broker.protocol` value if it is a 
> secure one.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 125372011984791db4b1c54ef5874740882a2331 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 4f8eaf2ceb985996b7e3d888e615c3bdc91f7c90 
> 
> 
> Diff: https://reviews.apache.org/r/64914/diff/1/
> 
> 
> Testing
> ---
> 
> Tested according to steps in 
> [AMBARI-22719](https://issues.apache.org/jira/browse/AMBARI-22719).
> 
> Amended existing unit test case.  Unit tests are OK:
> 
> ```
> Total run:1200
> Total errors:0
> Total failures:0
> OK
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 64853: UpgradeUserKerberosDescriptor is not executed during stack upgrade due to missing target stack data

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64853/#review194627
---


Ship it!




Ship It!

- Robert Nettleton


On Dec. 27, 2017, 3:58 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64853/
> ---
> 
> (Updated Dec. 27, 2017, 3:58 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Sandor Molnar.
> 
> 
> Bugs: AMBARI-22693
> https://issues.apache.org/jira/browse/AMBARI-22693
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> UpgradeUserKerberosDescriptor is not executed during stack upgrade due to 
> missing target stack data.
> 
> *Steps to reproduce*
> # Deploy cluster with Ambari version 2.6.0 and HDP version 2.4
> ** Storm should be installed to guarantee an error
> # Do Express upgrade to HDP version 2.6
> # Regenerate Keytabs.
> 
> Upon restarting Storm the following error is encountered
> ```
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at java.lang.Class.forName0(Native Method)
>   at java.lang.Class.forName(Class.java:348)
>   at clojure.lang.RT.classForName(RT.java:2154)
>   at clojure.lang.RT.classForName(RT.java:2163)
>   at clojure.lang.RT.loadClassForName(RT.java:2182)
>   at clojure.lang.RT.load(RT.java:436)
>   at clojure.lang.RT.load(RT.java:412)
>   at clojure.core$load$fn__5448.invoke(core.clj:5866)
>   at clojure.core$load.doInvoke(core.clj:5865)
>   at clojure.lang.RestFn.invoke(RestFn.java:408)
>   at clojure.core$load_one.invoke(core.clj:5671)
>   at clojure.core$load_lib$fn__5397.invoke(core.clj:5711)
>   at clojure.core$load_lib.doInvoke(core.clj:5710)
>   at clojure.lang.RestFn.applyTo(RestFn.java:142)
>   at clojure.core$apply.invoke(core.clj:632)
>   at clojure.core$load_libs.doInvoke(core.clj:5749)
>   at clojure.lang.RestFn.applyTo(RestFn.java:137)
>   at clojure.core$apply.invoke(core.clj:632)
>   at clojure.core$require.doInvoke(core.clj:5832)
>   at clojure.lang.RestFn.invoke(RestFn.java:408)
>   at 
> org.apache.storm.daemon.nimbus$loading__5340__auto982.invoke(nimbus.clj:16)
>   at org.apache.storm.daemon.nimbus__init.load(Unknown Source)
>   at org.apache.storm.daemon.nimbus__init.(Unknown Source)
>   at java.lang.Class.forName0(Native Method)
>   at java.lang.Class.forName(Class.java:348)
>   at clojure.lang.RT.classForName(RT.java:2154)
>   at clojure.lang.RT.classForName(RT.java:2163)
>   at clojure.lang.RT.loadClassForName(RT.java:2182)
>   at clojure.lang.RT.load(RT.java:436)
>   at clojure.lang.RT.load(RT.java:412)
>   at clojure.core$load$fn__5448.invoke(core.clj:5866)
>   at clojure.core$load.doInvoke(core.clj:5865)
>   at clojure.lang.RestFn.invoke(RestFn.java:408)
>   at clojure.lang.Var.invoke(Var.java:379)
>   at org.apache.storm.daemon.nimbus.(Unknown Source)
> Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: 
> backtype.storm.security.auth.KerberosPrincipalToLocal
>   at 
> org.apache.storm.security.auth.AuthUtils.GetPrincipalToLocalPlugin(AuthUtils.java:125)
>   at 
> org.apache.storm.security.auth.authorizer.ImpersonationAuthorizer.prepare(ImpersonationAuthorizer.java:54)
>   at 
> org.apache.storm.daemon.common$mk_authorization_handler.invoke(common.clj:417)
>   at org.apache.storm.ui.core__init.load(Unknown Source)
>   at org.apache.storm.ui.core__init.(Unknown Source)
>   ... 35 more
> Caused by: java.lang.ClassNotFoundException: 
> backtype.storm.security.auth.KerberosPrincipalToLocal
>   at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>   at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>   at java.lang.Class.forName0(Native Method)
>   at java.lang.Class.forName(Class.java:264)
>   at 
> org.apache.storm.security.auth.AuthUtils.GetPrincipalToLocalPlugin(AuthUtils.java:121)
>   ... 39 more
> ```
> 
> #Cause
> In the following code snip, {{targetStackID}} is {null}}:
> *`org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java:103`*:
> ```
> StackId targetStack

Re: Review Request 64568: AMBARI-22638. yarn.timeline-service property enabled overriding preset secure blueprint config for the same

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64568/#review193711
---


Ship it!




Ship It!

- Robert Nettleton


On Dec. 13, 2017, 6:54 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64568/
> ---
> 
> (Updated Dec. 13, 2017, 6:54 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Robert Levas, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22638
> https://issues.apache.org/jira/browse/AMBARI-22638
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed `yarn.timeline-service.enabled` in `kerberos.json` to `false`, to 
> match stack default for HDP 3.0.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
> a3cfaea95918e629f02d2fa9d6eb72a5c77e5987 
> 
> 
> Diff: https://reviews.apache.org/r/64568/diff/1/
> 
> 
> Testing
> ---
> 
> Tested secure cluster deployment with HDP 3.0, verified value of 
> `yarn.timeline-service.enabled` property: `false` if unset or set to `false` 
> in blueprint, `true` if set to `true` in blueprint.
> 
> Unit tests:
> 
> ```
> $ mvn -am -pl ambari-server clean test -Dtest='kerberos/*'
> ...
> Tests run: 205, Failures: 0, Errors: 0, Skipped: 1
> ...
> Total run:1210
> Total errors:0
> Total failures:0
> ...
> BUILD SUCCESS
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 64513: Update the default storm log search configuration (use wildcards)

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64513/#review193574
---


Ship it!




Ship It!

- Robert Nettleton


On Dec. 12, 2017, 4:24 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64513/
> ---
> 
> (Updated Dec. 12, 2017, 4:24 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22630
> https://issues.apache.org/jira/browse/AMBARI-22630
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> set the storm config defaults for logseach as other teams needs it.
> 
> this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can 
> be used in a hotfix
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml
>  d485017 
> 
> 
> Diff: https://reviews.apache.org/r/64513/diff/3/
> 
> 
> Testing
> ---
> 
> not yet.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 64349: LogFeeder: filter objects for wildcard input paths need to be cloned

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64349/#review192996
---


Ship it!




Ship It!

- Robert Nettleton


On Dec. 5, 2017, 8:50 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64349/
> ---
> 
> (Updated Dec. 5, 2017, 8:50 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-22600
> https://issues.apache.org/jira/browse/AMBARI-22600
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Feeder needs to clone filters for different input threads (for wildcard 
> pattern).
> 
> As different threads tried to access the same grok filter object (mutable) 
> that could cause to some docs used the wrong path (or other fields), 
> especially when a grok error happened. (on error, in the code, we checked 
> some objects regarding that what to do, but other threads changed those 
> objects)
> 
> Also some other changes:
> - use sdi_* dynamic fields
> - add new input log files
> - add new config to grok filter: skip_on_error (can be useful for filter 
> chains)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
>  afd903e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  49d7e76 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  7df0b6e 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-storm.json
>  34bdcf0 
>   
> ambari-logsearch/docker/test-logs/storm/worker-logs/streamline-1-TestAgg-2-3/6701/worker.log
>  6a10ad9 
>   
> ambari-logsearch/docker/test-logs/storm/worker-logs/streamline-2-TestAgg2-4-5/6700/worker.log
>  e69de29 
> 
> 
> Diff: https://reviews.apache.org/r/64349/diff/1/
> 
> 
> Testing
> ---
> 
> done, i need to write some unit tests for the filter cloning.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 64147: AMBARI-22539. Cannot add host with host_name in request body

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64147/#review192129
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 29, 2017, 8:38 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64147/
> ---
> 
> (Updated Nov. 29, 2017, 8:38 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22539
> https://issues.apache.org/jira/browse/AMBARI-22539
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support for one kind of `host_name` specification was [inadvertently 
> removed](https://git1-us-west.apache.org/repos/asf?p=ambari.git;a=blobdiff;f=ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java;h=f9604900af1e84756d2aeed3e6cee864b3586c58;hp=2a91bfe07536a4a0f49497f24aafa9108e257f94;hb=48f7fb22ae2ea61d7b05fa24703ccff2941bf8ff;hpb=88d93b92429225e03f46cb739a738b9033d45b84)
>  from `ScaleClusterRequest` in Ambari 2.6.0.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  0df8f13bd922547b5951ad9bc70dd83524c5b442 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
>  ad90a2559b8a644b1855fedca3c6a55dc663f20f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
>  b8395570448b75e74cf075110467a4279051f9ac 
> 
> 
> Diff: https://reviews.apache.org/r/64147/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually per STR.
> Added unit test.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 64156: Log Search: backend should not return with 302 redirect if authentication fails

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64156/#review192121
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 29, 2017, 12:44 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64156/
> ---
> 
> (Updated Nov. 29, 2017, 12:44 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Krisztian Kasa, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-22543
> https://issues.apache.org/jira/browse/AMBARI-22543
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Without proper authentication details rest calls returs with 302 (to /login), 
> that should be changed and get a 401 status
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java
>  2fe5f7b 
> 
> 
> Diff: https://reviews.apache.org/r/64156/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 64091: Log Feeder: handle multiple '=' (split char) in key/value filter

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64091/#review191929
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 27, 2017, 7:38 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64091/
> ---
> 
> (Updated Nov. 27, 2017, 7:38 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-22526
> https://issues.apache.org/jira/browse/AMBARI-22526
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Logfeeder key/value filter cannot handle multiple occurence of split char -> 
> in order to solve that we can limit the number of splits
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
>  b04a439 
> 
> 
> Diff: https://reviews.apache.org/r/64091/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63955: Validate blueprint does not allow lzo enable without setup with license agreement.

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63955/#review191538
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 20, 2017, 5:06 p.m., Myroslav Papirkovskyy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63955/
> ---
> 
> (Updated Nov. 20, 2017, 5:06 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, 
> Robert Nettleton, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22480
> https://issues.apache.org/jira/browse/AMBARI-22480
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Blueprint validation should fail if LZO is enabled and GPL license is not 
> accepted on server setup.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  1c127c080cd33314e47bcfff63e0c1e6d58937bc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> c9dc7281a092ff9f22551c9f8fc64ebca15fda36 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  1d917e0940b1ba5988a740005017c9d228e46f96 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidator.java
>  206d161fc694f67ae982ef668c5057b4bacec59b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  1aaa5ce66d1a5385018e4f29c92441e157c2be02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/GPLLicenseNotAcceptedException.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
>  fdbc0807788377f689e19200be9d6cdc2c992690 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  ea6bee314192f0665d4df652cf0c401e0218026f 
> 
> 
> Diff: https://reviews.apache.org/r/63955/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Myroslav Papirkovskyy
> 
>

Re: Review Request 63832: Reference Log Feeder IDE/maven dev setup in README.md

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63832/#review191065
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 15, 2017, 11:35 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63832/
> ---
> 
> (Updated Nov. 15, 2017, 11:35 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Krisztian Kasa, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22450
> https://issues.apache.org/jira/browse/AMBARI-22450
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> small patch to reference logfeeder reamdme in the parent readme
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 33952a2 
> 
> 
> Diff: https://reviews.apache.org/r/63832/diff/1/
> 
> 
> Testing
> ---
> 
> not required.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63838: ambari-server setup should surface GPL software agreement

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63838/#review191064
---


Fix it, then Ship it!




Overall, the patch looks fine, just a minor javadoc issue that should be 
addressed. 

Thanks.


ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 729 (patched)
<https://reviews.apache.org/r/63838/#comment268650>

Minor issue:  This javadoc comment doesn't reflect the actual property 
being added.  This just looks like a copy and paste error, but is probably 
worth fixing for the sake of clarity.


- Robert Nettleton


On Nov. 15, 2017, 2:34 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63838/
> ---
> 
> (Updated Nov. 15, 2017, 2:34 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-22453
> https://issues.apache.org/jira/browse/AMBARI-22453
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Ask the user if they are okay with installing GPL license software
>   * Surface the license agreement subtext, for now use placeholder
>   * Save the result in ambari.properties
>   * The user selection should be available through API for the client and 
> also stack scripts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  91df506478 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  0bd6af6611 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d8712f2c75 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  0b048ad089 
>   ambari-server/src/main/python/ambari-server.py 60c60052cc 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 
> c7ac13476f 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621 
> 
> 
> Diff: https://reviews.apache.org/r/63838/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63803: Log Feeder: do not try to connect AMS, when it is disabled

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63803/#review190990
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 14, 2017, 6:15 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63803/
> ---
> 
> (Updated Nov. 14, 2017, 6:15 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-22443
> https://issues.apache.org/jira/browse/AMBARI-22443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Set ams client to null if any of their properties are null.
> 
> Its already merged/fixed in 2.6 branch
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java
>  f446446 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java
>  1094852 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetricsManagerTest.java
>  24042a7 
> 
> 
> Diff: https://reviews.apache.org/r/63803/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63793: Log Feeder: cleanup checkpoint files periodically

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63793/#review190965
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 14, 2017, 1:07 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63793/
> ---
> 
> (Updated Nov. 14, 2017, 1:07 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22395
> https://issues.apache.org/jira/browse/AMBARI-22395
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - added new config: "max_age_min" (similar as detach_time_min) to input 
> block. that stored in checkpoint files, during cleanup, based on that the 
> checkpoint file can be deleted.
> - based on "max_age_min" value, during bootstrap, its possible logfeeder wont 
> even monitor a file in the future.
> - created a new thread which periodically run the checkpoint cleanup (now in 
> every 2000 minutes ... its ok to run that rearly)
> - fix metrics sink, as its called if some properties are missing
> - add new input test files (testing wildcard pattern)
> - fix when fatal error thrown if no any files exist based on a wildcard 
> pattern
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
>  8548a20 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  96320e9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
>  8e70850 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/AbstractLogFileMonitor.java
>  3910b9b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/CheckpointCleanupMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFileDetachMonitor.java
>  322a56d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFilePathUpdateMonitor.java
>  cc5d664 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java
>  2d1bf40 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java
>  1432c87 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
>  843ae6b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetrcisManagerTest.java
>  8ee6d00 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 068bc3a 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-storm.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-logs/storm/worker-logs/streamline-1-TestAgg-2-3/6701/worker.log
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63793/diff/3/
> 
> 
> Testing
> ---
> 
> done, manually, added new input file for docker env.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63707: Simplify Ambari configuration tables from AMBARI-21307

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63707/#review190746
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 10, 2017, 11:24 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63707/
> ---
> 
> (Updated Nov. 10, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Nate Cole, Robert Nettleton, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22347
> https://issues.apache.org/jira/browse/AMBARI-22347
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Simplify Ambari configuration tables from AMBARI-21307.
> 
> configuration_base and ambari_configuration tables were introduced in 
> AMBARI-21307; however, these tables are more complex than needed. Future 
> architecture changes will eventually negate the need to have a shard 
> configuration structure as proposed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
>  5e8094e9c7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
>  38ae7669db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/AmbariConfiguration.java
>  b5cc9212da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java
>  13f8835655 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java
>  4f4cc7070d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 0f9ff52147 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariLdapConfigChangedEvent.java
>  48799d793b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java
>  8b26cd3e29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java
>  c88d420e9a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/LdapConnectionTemplateFactory.java
>  8467af08b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAO.java
>  83293efb82 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AmbariConfigurationEntity.java
>  c9f4695469 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AmbariConfigurationEntityPK.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ConfigurationBaseEntity.java
>  9ad30d7d1a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  8812ef5bfc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  d3e924e66c 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7d634941d9 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql af17353ff3 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 89c7971303 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 3d2bd3a107 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> 55a6c61017 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e5e8af59c3 
>   ambari-server/src/main/resources/META-INF/persistence.xml 67eef705af 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProviderTest.java
>  c2a14218e7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAOTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  bd8f5cbd57 
> 
> 
> Diff: https://reviews.apache.org/r/63707/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: 
> 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:56 min
> [INFO] Finished at: 2017-11-09T17:32:37-05:00
> [INFO] Final Memory: 98M/1957M
> [INFO] 
> 
> ```
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 63617: Log Feeder should be able to run locally with dockerized dev env by default

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63617/#review190326
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 7, 2017, 1:38 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63617/
> ---
> 
> (Updated Nov. 7, 2017, 1:38 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22364
> https://issues.apache.org/jira/browse/AMBARI-22364
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Run logfeeder locally, requirements:
> - some changes in run logsearch configs (add --monitor flag, set workspace 
> folder)
> 
> logfeeder.properties work with docker environment
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/README.md 5a64daf 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml b1b6ece 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/.gitignore
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/logs/service_sample.txt
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/global.config.json
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/input.config-sample.json
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/output.config-sample.json
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 
> 8d5174e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
>  74ea0ef 
> 
> 
> Diff: https://reviews.apache.org/r/63617/diff/1/
> 
> 
> Testing
> ---
> 
> done with docker-compose commands
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63525: Log Search server should be able to run locally with dockerized dev env by default

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63525/#review190026
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 2, 2017, 9:35 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63525/
> ---
> 
> (Updated Nov. 2, 2017, 9:35 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22357
> https://issues.apache.org/jira/browse/AMBARI-22357
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> change defaults configs + add more proper descriptions to use / setup log 
> search server local dev env quickly (with maven / IDE)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 43878f2 
>   ambari-logsearch/ambari-logsearch-server/.gitignore 07e0389 
>   ambari-logsearch/ambari-logsearch-server/README.md 126f651 
>   ambari-logsearch/ambari-logsearch-server/run.sh 765fe6c 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/resources/logsearch.properties
>  db8a0a2 
> 
> 
> Diff: https://reviews.apache.org/r/63525/diff/2/
> 
> 
> Testing
> ---
> 
> done, check with 'mvn clean spring-boot:run' and with IntelliJ as well.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63450: Improve KDC integration

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63450/#review189799
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 31, 2017, 9:03 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63450/
> ---
> 
> (Updated Oct. 31, 2017, 9:03 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-22293
> https://issues.apache.org/jira/browse/AMBARI-22293
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Improve KDC integration by making the interfaces more consistent with each 
> other.
> 
> #Notes:
> - When using the MIT KDC or IPA options, the `kerberos-env/admin_server_host` 
> value *must be the fully qualified domain name* (FQDN) of the host were the 
> KDC administrator service is. 
> - When connecting to the MIT KDC and IPA server, a username a password is not 
> used to authenticate using the kadmin utility.  A Kerberos ticket is first 
> acquired and that is used for authentication.
> - When creating Kerberos identities using the MIT KDC and IPA handlers, the 
> Ambari-generated password is not used.  All password's for principals in the 
> MIT KDC and IP server are generated randomly by the KDC.
> - Removed `kerberos-env/set_password_expiry` and 
> `kerberos-env/password_chat_timeout` properties since they are no longer 
> needed
> - Changed `kerberos-env/groups` to `kerberos-env/ipa_user_groups` to be more 
> explicit in how the property is used.
> - The setPassword implementation for the MIT KDC and IPA handlers do nothing 
> except check to see if the relevant principal exists. This is to maintain 
> backward compatibility with previous implementations.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/security/kerberos/kerberos_service.md 65e312b866 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
>  f7d6060710 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  1c0853b98e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java
>  2b3a0ca40d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/IPAKerberosOperationHandler.java
>  9a6a07e4d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCKerberosOperationHandler.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
>  8749f81068 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
>  0997f650f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  bfe2a1346e 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  0a081215ec 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/kerberos-env.xml
>  0a081215ec 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  66e81dbb00 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  7ed52d2782 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java
>  483cc0aed2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/IPAKerberosOperationHandlerTest.java
>  f2a09bafb9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KDCKerberosOperationHandlerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java
>  88c841c3a1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java
>  a43db4d12c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
>  04d03bebb5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  25e9dbf739 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json

Re: Review Request 63362: Fix Log Search configuration dependencies

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63362/#review189449
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 27, 2017, 4:28 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63362/
> ---
> 
> (Updated Oct. 27, 2017, 4:28 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Oliver Szabo, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22328
> https://issues.apache.org/jira/browse/AMBARI-22328
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> logsearch-service_logs-solrconfig and logsearch-audit_logs-solrconfig config 
> groups are specified with .xml, logsearch-common-properties is not present at 
> all as a dependency.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 4a7b3e0 
> 
> 
> Diff: https://reviews.apache.org/r/63362/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 63360: Log Search: Add docker compose file for Solr

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63360/#review189432
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 27, 2017, 1:19 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63360/
> ---
> 
> (Updated Oct. 27, 2017, 1:19 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-22315
> https://issues.apache.org/jira/browse/AMBARI-22315
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> its the next part of https://reviews.apache.org/r/63328/
> 
> contains some renames as well
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/docker/docker-compose-zookeeper.yml a41eaf3 
>   ambari-logsearch/docker/solr.yml PRE-CREATION 
>   ambari-logsearch/docker/solr662.yml PRE-CREATION 
>   ambari-logsearch/docker/zookeeper.yml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63360/diff/1/
> 
> 
> Testing
> ---
> 
> done with docker-compose up -d
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63265: Log Feeder: allow applying grok filter on default fields (like type, path, host etc.)

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63265/#review189195
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 24, 2017, 10:30 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63265/
> ---
> 
> (Updated Oct. 24, 2017, 10:30 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-22300
> https://issues.apache.org/jira/browse/AMBARI-22300
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> add new "init_default_fields" config param to input block. If that option is 
> turned on, then logfeeder will apply  the default fields before any grok 
> filter is applied (right now it should just work with grok filter
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  deff1b2 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  6f6bb6d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
>  8bf6ae3 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
>  73cf449 
> 
> 
> Diff: https://reviews.apache.org/r/63265/diff/1/
> 
> 
> Testing
> ---
> 
> UTs done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63298: Update Solr (Infra Solr + clients) version to 6.6.2 from 6.6.0

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63298/#review189190
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 25, 2017, 1:58 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63298/
> ---
> 
> (Updated Oct. 25, 2017, 1:58 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22305
> https://issues.apache.org/jira/browse/AMBARI-22305
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Solr version to 6.6.2 from 6.6.0 (contains some security fixes)
> 
> 
> Diffs
> -
> 
>   ambari-infra/pom.xml 908abb4 
>   ambari-logsearch/docker/Dockerfile 1e4135e 
>   ambari-logsearch/pom.xml 9434365 
> 
> 
> Diff: https://reviews.apache.org/r/63298/diff/1/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63196: Avoid Log Feeder NPEs for logs of services not present on the node, but present on the cluster

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63196/#review188937
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 21, 2017, 12:58 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63196/
> ---
> 
> (Updated Oct. 21, 2017, 12:58 a.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Oliver Szabo, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22281
> https://issues.apache.org/jira/browse/AMBARI-22281
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Due to a bug Log Feeders throw NPEs while searching for logs of services 
> which are not present on the node, but present on the cluster.
> 
> The problem was caused by the fact that File.listFiles(FileFilter) returns 
> null if the file it's called on is not an existing directory, and 
> Arrays.sort() throws an NPE if it's argument is null.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  e24a7aa 
> 
> 
> Diff: https://reviews.apache.org/r/63196/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 63167: Update Pam Authentication process to work with improved user management facility

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63167/#review188833
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 19, 2017, 8:40 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63167/
> ---
> 
> (Updated Oct. 19, 2017, 8:40 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21221
> https://issues.apache.org/jira/browse/AMBARI-21221
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Pam Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 73d6fd00da 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2b14b4d33a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  bb8e0fe3fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  4a88f46924 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  e651d22e0d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationException.java
>  fb18b9c075 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  d3d5b8821f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariBasicAuthenticationFilter.java
>  f617a602d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  7ef65241b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/InvalidUsernamePasswordCombinationException.java
>  cb1babd40e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/TooManyLoginFailuresException.java
>  b17207991e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/UserNotFoundException.java
>  0760d9b333 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationFilter.java
>  dcaf3e8ca5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/jwt/AmbariJwtAuthenticationProvider.java
>  9a5b825d86 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosAuthenticationFilter.java
>  41275a55f5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/pam/PamAuthenticationFactory.java
>  6f423c1b24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  a88bcab4d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  1588106d3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  a5faea165b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/pam/AmbariPamAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  38f9a9ecdf 
> 
> 
> Diff: https://reviews.apache.org/r/63167/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: PENDING
> 
> # Jenkins test result: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 63162: Disable xmlparser and configEdit API in Infra Solr by default

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63162/#review188737
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 19, 2017, 7:36 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63162/
> ---
> 
> (Updated Oct. 19, 2017, 7:36 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-22273
> https://issues.apache.org/jira/browse/AMBARI-22273
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Due to a vulnerability found in Solr with CVE-2017-12629 
> (https://nvd.nist.gov/vuln/detail/CVE-2017-12629)
> 1.) Disable editing with the Config API by adding the 
> "-Ddisable.configEdit=true" flag to the SOLR_OPTS by default.
> 2.) Update all collections to reroute the xmlparser query parser away from 
> the vulnerable class, but adding this to the Ranger, Atlas, and LogSearch 
> collections:
> 
> 
> That wont affect upgrade as with some manual changes these options can be set 
> properly. This change only for default deployments. (also wont affect 3.0)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/solrconfig.xml
>  7af91df 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/hadoop_logs/conf/solrconfig.xml
>  59f778f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/history/conf/solrconfig.xml
>  8244a08 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-env.sh.j2
>  5cc344e 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/atlas-solrconfig.xml
>  cba4a4e 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/audit_logs-solrconfig.xml.j2
>  63879e7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/service_logs-solrconfig.xml.j2
>  b6a4d1d 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/properties/ranger-solrconfig.xml.j2
>  25dbb7a 
> 
> 
> Diff: https://reviews.apache.org/r/63162/diff/2/
> 
> 
> Testing
> ---
> 
> done, UTs passes, FT: install Solr with these setting, also check what 
> happens if we adding the new xml parser.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63118: Log Search server does not handle proxies properly

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63118/#review188580
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 18, 2017, 6:47 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63118/
> ---
> 
> (Updated Oct. 18, 2017, 6:47 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22266
> https://issues.apache.org/jira/browse/AMBARI-22266
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If logsearch running behind a proxy and the address is not on root, UI cannot 
> be accessed/handled properly.
> 
> (like: localhost:61888 can be accessed through localhost:8080/logsearch/)
> 
> Regarding to that issue, there are some backend changes that required:
> - form login filter needs to be removed, as we have are custom login 
> entripoint already (that form login filter is basically the same, so we had 2 
> different filter on each other, which did the same)
> - add useForward (configurable) to our login entrypoint, to make it possible 
> to send redirects through proxies properly
> - on logout: add useReferer, which can be used if logsearch is behind a 
> proxy, it can use the referer location instead of the root one.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthPropsConfig.java
>  54cc10c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  2f9cba4 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchLogoutSuccessHandler.java
>  c20e383 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java
>  1831697 
> 
> 
> Diff: https://reviews.apache.org/r/63118/diff/1/
> 
> 
> Testing
> ---
> 
> done, works with both proxies and without proxies (for proxies there should 
> be some ui changes as well)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63027: Allow wildcard for log directory folder in the path component of Logfeeder input

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63027/#review188495
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 18, 2017, 9:57 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63027/
> ---
> 
> (Updated Oct. 18, 2017, 9:57 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21145
> https://issues.apache.org/jira/browse/AMBARI-21145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow wildcards for handling log directories. Using ant library for this. (on 
> trunk, the solution will be JDK 8 based, so its a temporal hack for 2.6.1, 
> for trunk some classes have cleaned up, so the implementation there will be 
> different)
> 
> The idea is if we have a folder pattern, we will craete a thread group, and 
> there will be different threads for every matching input (now only for tail 
> file)
> 
> Also there is 2 new thread introduced:
> - one which checks is the monitored file too old, if it is, stop the thread 
> for that (detach)
> - an another one which checks there is any new file available (like log files 
> with date patterns in its name), and if it is, update the monitoring thread 
> with that (log path upgrade)
> 
> Introduced some new configuration as well for inputs:
> - path_update_interval_min: the period in minutes for checking new files 
> (default: 5,  based on detach values, its possible that a new input wont be 
> monitored)
> - detach_interval_min: the period in minutes for checking which files are too 
> old (default: 300)
> - detach_time_min: the period in minutes when we flag a file is too old 
> (default: 2000)
> 
> Also fix an issue which cause that we cannot use grok field names more deeply 
> (use deep_extract param for this one in grok filter) and i updated the docker 
> container as well to make it work with branch-2.6 (and use different version 
> for container in order to keep that)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  7e2da70 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
>  41a1fa5 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  9f54d8a 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  3737839 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/AbstractLogFileMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFileDetachMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFilePathUpdateMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
>  0ece637 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
>  ffd6cec 
>   ambari-logsearch/docker/Dockerfile dfa1462 
>   ambari-logsearch/docker/logsearch-docker.sh a2df90f 
> 
> 
> Diff: https://reviews.apache.org/r/63027/diff/5/
> 
> 
> Testing
> ---
> 
> done, no UTs here, FTs are in progress
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/#review187418
---


Ship it!




Overall, the patch looks fine to me, just a comment below about making sure 
this is tested thoroughly, since this patch does introduce a slight change to 
the Blueprints model for updater registration.  

Thanks.


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
Lines 2812 (patched)
<https://reviews.apache.org/r/62809/#comment264369>

Generally, the model here is to create a new property updater for each 
property.

Off the top of my head, it seems fine to use a singleton for the property 
updater, but please make sure this change is tested thoroughly, since there 
might be un-intended consequences of changing the way these updaters are 
registered.


- Robert Nettleton


On Oct. 9, 2017, 12:43 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62809/
> ---
> 
> (Updated Oct. 9, 2017, 12:43 p.m.)
> 
> 
> Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, Sandor Magyari, 
> Swapan Shridhar, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22159
> https://issues.apache.org/jira/browse/AMBARI-22159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders in `metastore_hostname`, 
> `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` 
> when creating cluster via blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d6349db0207ab6df44b4b0a341c77ecabc46ea 
> 
> 
> Diff: https://reviews.apache.org/r/62809/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.
> 
> Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

[Robert Nettleton]

> On Oct. 7, 2017, noon, Oliver Szabo wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
> > Lines 2783 (patched)
> > 
> >
> > can these variables calculated at params.py in the stack code instead 
> > of putting to the BlueprintConfigurationProcessor? (using jinja2 variables 
> > at configurations - you can get the proper hosts from command.json input). 
> > just because the ambari server java code could be independent from druid. 
> > im not too big fan of this class, we should get rid of it sooner or later
> > 
> > but you can drop this issue if zou do not want to do it, it's just a 
> > reccomendation from me.
> 
> Attila Doroszlai wrote:
> I agree that this class stinks.  However, currently no `%HOSTGROUP::...%` 
> substitution occurs in Python code.  I guess it shouldn't be introduced at 
> this point before 2.6 release.
> 
> Oliver Szabo wrote:
> no need for %HOSTGROUP::.. substitution. It can be a jinja variable like 
> {{ metadata_connector_connect_uri }}.
> like for logsearch and ambari infra solr, there are some refrerences for 
> zookeeper but you cannot find that in the BlueprintConfigurationProcessor 
> class

Hi Oliver, 

I don't think the python substitution you mentioned will totally work.  

While the substitution might work on the agent side, I've seen cases where this 
type of substitution won't show up properly on the UI, meaning that the UI will 
show the jinja variable tokens in the config properties, which is not the 
correct behavior.

I agree that the BlueprintConfigurationProcessor should eventually be removed, 
but the problem is that the stack metadata doesn't hold enough information yet 
about topology data to allow this class to be refactored or removed just yet. 

Thanks, 
Bob


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62809/#review187335
---


On Oct. 9, 2017, 12:43 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62809/
> ---
> 
> (Updated Oct. 9, 2017, 12:43 p.m.)
> 
> 
> Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, Sandor Magyari, 
> Swapan Shridhar, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22159
> https://issues.apache.org/jira/browse/AMBARI-22159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders in `metastore_hostname`, 
> `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` 
> when creating cluster via blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  68d6349db0207ab6df44b4b0a341c77ecabc46ea 
> 
> 
> Diff: https://reviews.apache.org/r/62809/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually on local cluster.
> 
> Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36`
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62757/#review187004
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 3, 2017, 8:23 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62757/
> ---
> 
> (Updated Oct. 3, 2017, 8:23 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21220
> https://issues.apache.org/jira/browse/AMBARI-21220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Local Authentication process to work with improved user management 
> facility
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  3099bc0857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  21ab757e1c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AccountDisabledException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java
>  2a894374d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProvider.java
>  2a2e397439 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  2dedc9e6ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AbstractAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authentication/AmbariLocalAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationProviderDisableUserTest.java
>  fea7fb978e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLocalUserProviderTest.java
>  fb4ebf93e4 
> 
> 
> Diff: https://reviews.apache.org/r/62757/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Local test results: PASSED
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62628: Allow for backward compatibility in how identity references are specified

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62628/#review186565
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 27, 2017, 8:53 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62628/
> ---
> 
> (Updated Sept. 27, 2017, 8:53 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Robert Nettleton, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-22072
> https://issues.apache.org/jira/browse/AMBARI-22072
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow for backward compatibility in how identity references are specified by 
> checking to see of the "name" attribute of an identity descriptor is a path 
> to a referenced identity descriptor. However a warning should be posted to 
> the log.
> 
> Note: Most of the changes here are resurrected code that was removed with 
> patch from https://issues.apache.org/jira/browse/AMBARI-21919.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
>  4255dd12d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  0c7a9a996f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  d0d57d5d23 
> 
> 
> Diff: https://reviews.apache.org/r/62628/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> ---
> Test set: org.apache.ambari.server.stack.KerberosDescriptorTest
> ---
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.033 s - in 
> org.apache.ambari.server.stack.KerberosDescriptorTest
> ```
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 35:23 min
> [INFO] Finished at: 2017-09-27T16:29:47-04:00
> [INFO] Final Memory: 70M/591M
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62618: Use symlinks for Solr Data Manager

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62618/#review186411
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 27, 2017, 2:33 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62618/
> ---
> 
> (Updated Sept. 27, 2017, 2:33 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22075
> https://issues.apache.org/jira/browse/AMBARI-22075
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Put symlinks in /usr/bin for infra-solr-data-manager (same as 
> zookeeper-client and zookeeper-server), to acces 
> /usr/lib/ambari-infra-solr-client/solrDataManager.py more easily
> 
> Create symlinks in the post install scripts, to make it possible to create 
> the rpm packages to be created on Mac
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-assembly/src/main/package/deb/solr-client/postinst 
> c339cd0 
>   
> ambari-infra/ambari-infra-assembly/src/main/package/rpm/solr-client/postinstall.sh
>  c339cd0 
>   ambari-infra/ambari-infra-solr-client/build.xml 25ff0cb 
> 
> 
> Diff: https://reviews.apache.org/r/62618/diff/1/
> 
> 
> Testing
> ---
> 
> tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 62586: Update unit tests to test recursive variable replacements using VariableReplacementHelper

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62586/#review186322
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 26, 2017, 8:12 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62586/
> ---
> 
> (Updated Sept. 26, 2017, 8:12 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22066
> https://issues.apache.org/jira/browse/AMBARI-22066
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update unit tests to test recursive variable replacements using 
> VariableReplacementHelper. For example:
> 
> ```
> ${service-site/suffix_value_${host}}
> ```
> 
> `${host}` needs to be replaced and then the resulting value needs to be 
> replaced to generate the relevant value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
>  e46294a5b6 
> 
> 
> Diff: https://reviews.apache.org/r/62586/diff/1/
> 
> 
> Testing
> ---
> 
> ---
> Test set: 
> org.apache.ambari.server.state.kerberos.VariableReplacementHelperTest
> ---
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.438 s - in 
> org.apache.ambari.server.state.kerberos.VariableReplacementHelperTest
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62584: Remove Database auto configuration from Infra Manager

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62584/#review186321
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 26, 2017, 6:30 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62584/
> ---
> 
> (Updated Sept. 26, 2017, 6:30 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Miklos Gergely, 
> Robert Nettleton, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-22064
> https://issues.apache.org/jira/browse/AMBARI-22064
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spring boot introduced a Database autoconfiguration feature. Becuase of that 
> feature, our initialization script does not work.
> 
> To use that properly we need to set some spring properties 
> ("spring.datasource" prefix) which can use the right database schema script 
> with discovering the datasorce type of the datasource (which sounds fine), 
> but we should not use that feature until we find out how to change the 
> default prefixes of the configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
>  185e344 
> 
> 
> Diff: https://reviews.apache.org/r/62584/diff/1/
> 
> 
> Testing
> ---
> 
> manually, db file created properly
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 62576: Solr Data Manager script should provide non-destructive archive download option

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62576/#review186266
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 26, 2017, 3:05 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62576/
> ---
> 
> (Updated Sept. 26, 2017, 3:05 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22061
> https://issues.apache.org/jira/browse/AMBARI-22061
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow users to save only their data without deleting
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
> e0356bb 
> 
> 
> Diff: https://reviews.apache.org/r/62576/diff/1/
> 
> 
> Testing
> ---
> 
> tested locally
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 62570: Use symlinks for Infra components

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62570/#review186262
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 26, 2017, 1:09 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62570/
> ---
> 
> (Updated Sept. 26, 2017, 1:09 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Miklos Gergely, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22059
> https://issues.apache.org/jira/browse/AMBARI-22059
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Put symlinks in /usr/bin for infra-solr-client (same as zookeeper-client and 
> zookeeper-server), to acces /usr/lib/ambari-infra-solr-client scripts more 
> easily
> 
> Create symlinks in the post install scripts, to make it possible to create 
> the rpm packages to be created on Mac
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-assembly/pom.xml fafef7e 
>   ambari-infra/ambari-infra-assembly/src/main/package/deb/manager/postinst 
> 21a01fa 
>   
> ambari-infra/ambari-infra-assembly/src/main/package/deb/solr-client/postinst 
> 21a01fa 
>   
> ambari-infra/ambari-infra-assembly/src/main/package/rpm/manager/postinstall.sh
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-assembly/src/main/package/rpm/solr-client/postinstall.sh
>  PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/resources/infraManager.sh 
> 65287b2 
>   ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh 
> 1d219d6 
> 
> 
> Diff: https://reviews.apache.org/r/62570/diff/1/
> 
> 
> Testing
> ---
> 
> done manually.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 62562: Solr Data Manager script should use gzip compression type

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62562/#review186261
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 26, 2017, 10:17 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62562/
> ---
> 
> (Updated Sept. 26, 2017, 10:17 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22056
> https://issues.apache.org/jira/browse/AMBARI-22056
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support gzip compression and offer it as default.
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
> 18a4da7 
> 
> 
> Diff: https://reviews.apache.org/r/62562/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 62551: Make Log Search IT work with the new UI

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62551/#review186166
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 25, 2017, 6:56 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62551/
> ---
> 
> (Updated Sept. 25, 2017, 6:56 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, Robert 
> Nettleton, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-22055
> https://issues.apache.org/jira/browse/AMBARI-22055
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As Log Search has a new UI, integration test framework cannot login (with 
> Selenium) anyomore during test run (using X11)
> 
> Fix that to make IT tests work with the new UI
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java
>  b40a2bc 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story
>  543c211 
> 
> 
> Diff: https://reviews.apache.org/r/62551/diff/1/
> 
> 
> Testing
> ---
> 
> done. with maven failsafe plugin and enabling xquartz
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 62526: Infra Solr client cleanup: make infra-solr-client script usable with symlinks

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62526/#review186128
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 23, 2017, 11:20 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62526/
> ---
> 
> (Updated Sept. 23, 2017, 11:20 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Nettleton, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-22045
> https://issues.apache.org/jira/browse/AMBARI-22045
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make it possible for infra solr scripts to used by symlinks.
> 
> Right now if a symlink points to the infra solr scripts -> throws an error as 
> we using the actual directory to calculate the java classpath. The patch 
> fixes that.
> 
> Also added some small cleanups (e.g.: stderrs are duplicated because of 2 
> appenders - i changed the default ones)
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java
>  70bc232 
>   ambari-infra/ambari-infra-solr-client/src/main/resources/log4j.properties 
> e8dca12 
>   ambari-infra/ambari-infra-solr-client/src/main/resources/solrCloudCli.sh 
> 7bfa864 
>   ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh 
> 12e6a77 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/solr-client-log4j.properties.j2
>  0d0adc3 
> 
> 
> Diff: https://reviews.apache.org/r/62526/diff/1/
> 
> 
> Testing
> ---
> 
> tested manually.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 62530: Infra Manager: Integrate with Spring Boot

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62530/#review186127
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 24, 2017, 12:31 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62530/
> ---
> 
> (Updated Sept. 24, 2017, 12:31 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Laszlo Puskas, Miklos Gergely, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-22046
> https://issues.apache.org/jira/browse/AMBARI-22046
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Integrate infra manager with spring boot in order to achive easier dependency 
> and property management.
> 
> Other improvements:
> - in memory swagger description storage
> - log4j2 support
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-manager/.gitignore PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docker/bin/start.sh 076c06f 
>   ambari-infra/ambari-infra-manager/pom.xml b9f2a77 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
>  186f98c 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/common/InfraManagerConstants.java
>  105f20e 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/InfraManagerDataConfig.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/InfraManagerJerseyResourceConfig.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/InfraManagerServletConfig.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/StaticResourceConfiguration.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/doc/InfraManagerApiDocStorage.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java
>  444f0d1 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/ApiDocResource.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 
> fbeac78 
>   ambari-infra/ambari-infra-manager/src/main/resources/log4j.xml 0450454 
>   ambari-infra/ambari-infra-manager/src/main/resources/log4j2.xml 
> PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/resources/static/index.html 
> PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/resources/swagger/swagger.html 
> 8580e1a 
>   ambari-infra/ambari-infra-manager/src/main/resources/webapp/index.html 
> 3e64867 
> 
> 
> Diff: https://reviews.apache.org/r/62530/diff/1/
> 
> 
> Testing
> ---
> 
> done manually.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 62543: Infra Manager jobs should handle their own configuration

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62543/#review186123
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 25, 2017, 12:52 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62543/
> ---
> 
> (Updated Sept. 25, 2017, 12:52 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22050
> https://issues.apache.org/jira/browse/AMBARI-22050
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Dummy job configuration should be extracted from InfraManagerBatchConfig
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
>  98a4901 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyJobConfiguration.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62543/diff/1/
> 
> 
> Testing
> ---
> 
> Tested locally, still works fine
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 62542: Solr Data Manager should use --line-delimited option by default

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62542/#review186122
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 25, 2017, 12:47 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62542/
> ---
> 
> (Updated Sept. 25, 2017, 12:47 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22049
> https://issues.apache.org/jira/browse/AMBARI-22049
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Instead of having an option for creating line delimited json file, that 
> should be the default, and a json file should be created if a flag is set.
> 
> Also the -j short argument form was assigned to the name parameter instead of 
> this.
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
> d17aec7 
> 
> 
> Diff: https://reviews.apache.org/r/62542/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 62460: Enable logsearch-web unit tests and make them skippable

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62460/#review185889
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 21, 2017, 10:47 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62460/
> ---
> 
> (Updated Sept. 21, 2017, 10:47 a.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Attila Magyar, Miklos Gergely, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22019
> https://issues.apache.org/jira/browse/AMBARI-22019
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The new Log Search web UTs are not enabled by default (as earlier it did not 
> run in headless mode), now: enable it and make it skippable
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/pom.xml 7a6b02e 
> 
> 
> Diff: https://reviews.apache.org/r/62460/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests run and passed, skipped if i addeed -DskipTests
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62412/#review185702
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 19, 2017, 3:54 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62412/
> ---
> 
> (Updated Sept. 19, 2017, 3:54 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21997
> https://issues.apache.org/jira/browse/AMBARI-21997
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
> project ambari-server: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: 
> java.lang.UnsupportedClassVersionError: com/networknt/schema/JsonSchema : 
> Unsupported major.minor version 52.0 -> [Help 1]
> ```
> 
> #Cause#
> com.networknt:json-schema-validator:0.1.7 is compiled for Java 1.8, causing 
> unit tests to fail when using Java 1.7
> 
> #Solution#
> Use com.networknt:json-schema-validator:0.1.10, which appears to work when 
> using either Java 1.7 or Java 1.8.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 4a896ad261 
> 
> 
> Diff: https://reviews.apache.org/r/62412/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit tests using Java7 and Java8
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62356: Log Feeder should not support german month names

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62356/#review185486
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 15, 2017, 1:27 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62356/
> ---
> 
> (Updated Sept. 15, 2017, 1:27 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21968
> https://issues.apache.org/jira/browse/AMBARI-21968
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Feeder grok patterns currently support german month names too. This has 
> almost no usefulness at all, as there are no german language logs, and we 
> don't even support german day names, but it may cause errors as the März 
> contains a ä character which may lead to encoding related errors.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/grok-patterns 
> 920f521 
> 
> 
> Diff: https://reviews.apache.org/r/62356/diff/1/
> 
> 
> Testing
> ---
> 
> Done.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62331/#review185415
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 14, 2017, 3:13 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62331/
> ---
> 
> (Updated Sept. 14, 2017, 3:13 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21690
> https://issues.apache.org/jira/browse/AMBARI-21690
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove repository_version and repository_version_id null checks for BP 
> deployments since we want to use the default if-not-specified.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  092339bb7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  8d891b9534 
> 
> 
> Diff: https://reviews.apache.org/r/62331/diff/1/
> 
> 
> Testing
> ---
> 
> Manual cluster deployment.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62224: NullPointerException during blueprint generation

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62224/#review185099
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 11, 2017, 5:51 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62224/
> ---
> 
> (Updated Sept. 11, 2017, 5:51 p.m.)
> 
> 
> Review request for Ambari, Amarnath reddy pappu, Jayush Luniya, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-21865
> https://issues.apache.org/jira/browse/AMBARI-21865
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In an Namenode HA environment, export Blueprint throws NPE/Server Error for 
> some missing configurations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  b4e102737f 
> 
> 
> Diff: https://reviews.apache.org/r/62224/diff/1/
> 
> 
> Testing
> ---
> 
> Installed Ambari-2.4.3 HDP-2.5.3.0.
> 
> Added the properties to "Custom hdfs-site"
> dfs.nameservices=nonha,hacluster
> dfs.namenode.rpc-address.nonha=host-1.openstacklocal:8020
> dfs.ha.namenodes.hacluster=nn1,nn2
> dfs.namenode.rpc-address.hacluster.nn2=host-2.openstacklocal:8020
> dfs.namenode.rpc-address.hacluster.nn1=host-tt-3.openstacklocal:8020
> dfs.namenode.http-address.nonha=host-tt-1.openstacklocal:50070
> dfs.client.failover.proxy.provider.hacluster=org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider
> dfs.nameservices.internal=nonha
> 
> Added the fix/null-check and then exported the blueprint which was successful.
> Some properties will not be exported.
> Here is a snippet of the blueprint hdfs-site section
> "dfs.namenode.rpc-address.hacluster.nn2": "%HOSTGROUP::host_group_2%:8020",
> "dfs.namenode.rpc-address.hacluster.nn1": "%HOSTGROUP::host_group_3%:8020",
> "dfs.nameservices": "nonha,hacluster",
> "dfs.namenode.http-address.nonha": "host-1.openstacklocal:50070",
> "dfs.nameservices.internal": "nonha",
> "dfs.namenode.rpc-address": "%HOSTGROUP::host_group_1%:8020",
> "dfs.namenode.https-address": "%HOSTGROUP::host_group_1%:50470",
> "dfs.namenode.rpc-address.nonha": "host-1.openstacklocal:8020",
> "dfs.http.policy": "HTTP_ONLY",
> "dfs.client.failover.proxy.provider.hacluster": 
> "org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider",
> "dfs.namenode.http-address": "%HOSTGROUP::host_group_1%:50070",
> "dfs.datanode.https.address": "0.0.0.0:50475",
> "dfs.ha.namenodes.hacluster": "nn1,nn2",
> "dfs.namenode.secondary.http-address": "%HOSTGROUP::host_group_2%:50090",
> "dfs.datanode.http.address": "0.0.0.0:50075"
> 
> As you see because dfs.ha.namenodes.nonha does not exist, there will not be 
> any properties like dfs.namenode.rpc-address.nonha.
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review184889
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 7, 2017, 8:33 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61898/
> ---
> 
> (Updated Sept. 7, 2017, 8:33 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21810
> https://issues.apache.org/jira/browse/AMBARI-21810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This script allows the user to set an end date, and save all the previous log 
> entries into HDFS or S3
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
>   ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
>  PRE-CREATION 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61898/diff/5/
> 
> 
> Testing
> ---
> 
> Tested on local cluster with
> - SSL
> - kerberos
> - interrupted, then restarted script
> - HDFS
> - S3
> - the combinations of the above
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 62083: Fix Log Search upgrade to 3.0.0

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62083/#review184569
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 5, 2017, 3:52 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62083/
> ---
> 
> (Updated Sept. 5, 2017, 3:52 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21881
> https://issues.apache.org/jira/browse/AMBARI-21881
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are 3 problems about the Log Search upgrade to 3.0.0
> - *-logsearch-conf attributes were deleted instead of removing the config type
> - logsearch-common-properties must be created explicitly, because the empty 
> config type will not be created by default
> - logsearch-output-config was created instead of overwriting 
> logfeeder-output-config
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  9255163 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  53518dd 
> 
> 
> Diff: https://reviews.apache.org/r/62083/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 62034: Integrate LogSearch new UI with the server and get rid of the old one

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62034/#review184561
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 5, 2017, 3:29 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62034/
> ---
> 
> (Updated Sept. 5, 2017, 3:29 p.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-21870
> https://issues.apache.org/jira/browse/AMBARI-21870
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - get rid of old ui
> - renamve web-new to web
> - add some small changes to authentication (create an abstract filter for jwt 
> and move it somewhere else, those changes will be continued in an other patch)
> - change login/logout authentication mechanism for the new UI (do not 
> redirect to /login.html)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-server/build.xml aadacd7 
>   ambari-logsearch/ambari-logsearch-server/pom.xml e60cc14 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/auth/filter/AbstractJWTFilter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  038ba5c 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchLogoutSuccessHandler.java
>  c20e383 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchJWTFilter.java
>  1bc7231 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/model/JWTAuthenticationToken.java
>  dfac191 
>   ambari-logsearch/ambari-logsearch-web-new/.angular-cli.json  
>   ambari-logsearch/ambari-logsearch-web-new/.editorconfig  
>   ambari-logsearch/ambari-logsearch-web-new/.gitignore 54bfd20 
>   ambari-logsearch/ambari-logsearch-web-new/README.md 2fb07fb 
>   ambari-logsearch/ambari-logsearch-web-new/e2e/app.e2e-spec.ts  
>   ambari-logsearch/ambari-logsearch-web-new/e2e/app.po.ts  
>   ambari-logsearch/ambari-logsearch-web-new/e2e/tsconfig.e2e.json  
>   ambari-logsearch/ambari-logsearch-web-new/karma.conf.js  
>   ambari-logsearch/ambari-logsearch-web-new/package.json 96733eb 
>   ambari-logsearch/ambari-logsearch-web-new/pom.xml 28e1754 
>   ambari-logsearch/ambari-logsearch-web-new/protractor.conf.js  
>   ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts  
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/audit-logs-query-params.class.ts
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/query-params.class.ts
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-histogram-query-params.class.spec.ts
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-histogram-query-params.class.ts
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/classes/queries/service-logs-query-params.class.ts
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.html
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.less
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.spec.ts
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.ts
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.html
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.less
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.spec.ts
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.ts 
>  
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.html
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.less
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dropdown-button.component.spec.ts
>   
>   
> ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-button/dro

Re: Review Request 62015: Ranger should handle external Solr properly

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62015/#review184305
---


Ship it!




Patch looks fine to me.

Can you also include Velmurugan Periasamy, Mugdha Varadkar, Vishal Suvagia, and 
Gautam Borad to this review? 

Thanks.

- Robert Nettleton


On Aug. 31, 2017, 1:59 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62015/
> ---
> 
> (Updated Aug. 31, 2017, 1:59 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21863
> https://issues.apache.org/jira/browse/AMBARI-21863
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger tries to create it's configurations using the local ambari-infra Solr 
> even if it is specified to use an external one.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  bd45558 
> 
> 
> Diff: https://reviews.apache.org/r/62015/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on two clusters, one running the external solr, the other installed 
> Atlas, the config data were created.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 61996: Integrate new Log Search UI with maven

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61996/#review184187
---


Ship it!




Ship It!

- Robert Nettleton


On Aug. 30, 2017, 6:10 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61996/
> ---
> 
> (Updated Aug. 30, 2017, 6:10 p.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-21857
> https://issues.apache.org/jira/browse/AMBARI-21857
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add new pom.xml file for the new logsearch web ui in order to package static 
> resources in jar (which are generated with yarn and angular-cli)
> 
> The resource generation flow is the following:
> - install (download or copy an already downloaded one) node and yarn in 
> target/webapp-build folder
> - copy source files from the ui root folder into target/webapp-build
> - run yarn install, then yarn build-prod
> - copy target/webapp-build/dist to target/classes/dist
> - during package phase target/classes content included in the generated jar
> 
> Next steps from here: 
> Add the new ui dependency to logsearch server, during  the logsearch portal 
> build, the dist static content will be packaged with the server files.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web-new/package.json b4902a3 
>   ambari-logsearch/ambari-logsearch-web-new/pom.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61996/diff/1/
> 
> 
> Testing
> ---
> 
> done, manually, generated jar contains "dist/" folder. anyway, no mvn clean 
> test support yet.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 61993: Atlas should handle external Solr properly

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61993/#review184184
---


Ship it!




The patch looks fine to me, but someone with Atlas expertise should probably 
review as well.  

Can you please add Vishal Suvagia to this review?  

Thanks.

- Robert Nettleton


On Aug. 30, 2017, 4:04 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61993/
> ---
> 
> (Updated Aug. 30, 2017, 4:04 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21855
> https://issues.apache.org/jira/browse/AMBARI-21855
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas tries to create it's collection using the local ambari-infra Solr even 
> if it is specified to use an external one.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  0305b82 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  41be001 
> 
> 
> Diff: https://reviews.apache.org/r/61993/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on two clusters, one running the external solr, the other installed 
> Atlas, the collections were created.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review183924
---


Ship it!




Ship It!

- Robert Nettleton


On Aug. 27, 2017, 3:41 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61898/
> ---
> 
> (Updated Aug. 27, 2017, 3:41 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21810
> https://issues.apache.org/jira/browse/AMBARI-21810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This script allows the user to set an end date, and save all the previous log 
> entries into HDFS or S3
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
>   ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
>  PRE-CREATION 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61898/diff/3/
> 
> 
> Testing
> ---
> 
> Tested on local cluster with
> - SSL
> - kerberos
> - interrupted, then restarted script
> - HDFS
> - S3
> - the combinations of the above
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 61623: Blueprint deployments failing without version string

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61623/#review182911
---


Ship it!




Patch looks fine to me.

Can you please add Sandor Magyari to this review as well? 

Thanks.

- Robert Nettleton


On Aug. 14, 2017, 9:02 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61623/
> ---
> 
> (Updated Aug. 14, 2017, 9:02 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21721
> https://issues.apache.org/jira/browse/AMBARI-21721
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When deploying blueprints without a version specified, try to find a 
> best-matching repository.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  6332fbf169 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java
>  e92a6197f1 
> 
> 
> Diff: https://reviews.apache.org/r/61623/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 61461: Log Search cleanup: all configurations should be spring managed

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61461/#review182305
---


Ship it!




Ship It!

- Robert Nettleton


On Aug. 7, 2017, 4:03 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61461/
> ---
> 
> (Updated Aug. 7, 2017, 4:03 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Robert Nettleton, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21670
> https://issues.apache.org/jira/browse/AMBARI-21670
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some properties (like used port or protocol) for Log Search were not managed 
> by Spring. Those were loaded by PropertiesHelper -> that is not the proper 
> way to do it. To make the whole application managed by Spring, it affects the 
> servlet definitions as well.
> 
> Also the patch contains a lot of cleanups.
> 
> Changes:
> - introduce spring boot in order to get rid of managing glasshish, jakson, 
> spring dependencies togather.
> - use /static/ folder for static web files intead of webapps/apps (also 
> static content will be handled outside of jersey filter)
> - move logsearch-env/logsearch_protocol and logsearch_ui_port to 
> logsearch.properties -> add a new property for SSL port.
> - get rid of SSLUtil, use SSLConfigurer bean instead of it.
> - get rid of Ldap authentication (not used) in Log Search
> - update stack code (protocol + port changes)
> - manage pid file by spring boot application (wont be needed to create the 
> pid file in run.sh script)
> - add some new config objects
> - update to jetty 9.4
> - pom.xml cleanup (get rid of non used profile)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/build.properties 46979e5 
>   ambari-logsearch/ambari-logsearch-server/build.properties 1cd118a 
>   ambari-logsearch/ambari-logsearch-server/pom.xml 4db1f61 
>   ambari-logsearch/ambari-logsearch-server/run.sh ea89947 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  b1517df 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  df00c15 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  a018dda 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
>  3505fe2 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/XMLPropertiesHelper.java
>  690a60f 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  1e61f22 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
>  756252d 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchConfigMapHolder.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchJerseyResourceConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchServletConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSpnegoConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSslConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  5207dd0 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/StaticResourceConfiguration.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogSearchConfigConfigurer.java
>  23b7430 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SslConfigurer.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
>  b0b893f 
>   
> ambari-logsearch/ambar

Re: Review Request 61277: Log Search Config should be separated into a Server and Log Feeder interface

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61277/#review181989
---


Ship it!




Ship It!

- Robert Nettleton


On Aug. 2, 2017, 11:05 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61277/
> ---
> 
> (Updated Aug. 2, 2017, 11:05 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21623
> https://issues.apache.org/jira/browse/AMBARI-21623
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Search Config is getting too complex, it serves too many kind of things. 
> It should be separated into two interfaces, one for the Server and one for 
> the Log Feeders to make it cleaner.
> 
> Also fixed a minor issue about shipper configurations without any post map 
> values.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
>  76be392 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java
>  77b48eb 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigLogFeeder.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigServer.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
>  e308346 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
>  b64dae8 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactoryTest.java
>  f990c5c 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigLogFeederClass1.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigLogFeederClass2.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigServerClass1.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigServerClass2.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigLogFeederZK.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigServerZK.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
>  387d0c6 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  ba3412b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java
>  30b61a1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
>  10642d1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java
>  b370e58 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java
>  ce040f9 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogSearchConfigConfigurer.java
>  3f6df75 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java
>  6de34ce 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  15f59e4 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java
>  8b4c7bf 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java
>  a1181b4 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFilter.java
>  84bddb8 
> 
> 
> Diff: https://reviews.apache.org/r/61277/diff/2/
> 
> 
> Testing
> ---
> 
> Tested on local cluster, still works
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 61197: Log Feeder properties should be handled by one class

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61197/#review181987
---


Ship it!




Ship It!

- Robert Nettleton


On Aug. 2, 2017, 11:11 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61197/
> ---
> 
> (Updated Aug. 2, 2017, 11:11 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21592
> https://issues.apache.org/jira/browse/AMBARI-21592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Feeder properties are scattered all over the code, with their 
> documentation, putting large blocks of codes into several classes. Instead of 
> it they should be handled by one class together with their documentation and 
> default values, having all the rest of the classes asking that one for their 
> value.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  ba3412b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java
>  30b61a1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
>  9535260 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  8050263 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
>  10642d1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
>  091015a 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
>  7c487ba 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java
>  79bf5ea 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java
>  fdad9a6 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
>  2b47a00 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputS3File.java
>  9f41a15 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
>  e3da864 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederPropertiesUtil.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
>  a244a4e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java
>  573bb1c 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java
>  c07035b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetricsManagerTest.java
>  4b4067c 
> 
> 
> Diff: https://reviews.apache.org/r/61197/diff/3/
> 
> 
> Testing
> ---
> 
> Tested on docker. The properties are working fine, and the properties info 
> REST API endpoint still return their description.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 61269: AMBARI-21619. More ResourceManager HA host group placeholders in blueprints

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61269/#review181893
---


Ship it!




Ship It!

- Robert Nettleton


On Aug. 1, 2017, 7:04 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61269/
> ---
> 
> (Updated Aug. 1, 2017, 7:04 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Robert Nettleton, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21619
> https://issues.apache.org/jira/browse/AMBARI-21619
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Replace placeholders for few more properties.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  b0a605be45c540566240bbb032fd220d3d051859 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  c5af0d9962f076d5681b9c9550aef210f75efb10 
> 
> 
> Diff: https://reviews.apache.org/r/61269/diff/1/
> 
> 
> Testing
> ---
> 
> Tested blueprint install of HA cluster.
> Unit tests: changed related test; tests pass.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60943: Log Search Solr output properties should be provided by the Config API

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60943/#review181476
---


Fix it, then Ship it!




Patch looks fine, just a minor comment below.


ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
Lines 67 (patched)
<https://reviews.apache.org/r/60943/#comment257084>

Would it make more sense to have a single "inputConfigExists" method, and 
then have implementations that are specific to the Logfeeder or  the LogSearch 
Server?


- Robert Nettleton


On July 20, 2017, 9:54 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60943/
> ---
> 
> (Updated July 20, 2017, 9:54 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21507
> https://issues.apache.org/jira/browse/AMBARI-21507
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Solr output properties should be persisted into the Config API by the Log 
> Search Server as the output is initialized, and fetched by he Log Feeders 
> from there
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
>  6c5cefd 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/OutputConfigMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/outputconfig/OutputProperties.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/outputconfig/OutputSolrProperties.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
>  28844d5 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
>  5934fa6 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
>  fdd8ed6 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/outputconfig/impl/OutputSolrPropertiesImpl.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  59c2a22 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java
>  5bf074c 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogEntryParseTester.java
>  5356159 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
>  09fc3f5 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java
>  f1002ae 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java
>  65b9e19 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
>  4d6c43b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
>  162a7f8 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java
>  8985110 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
>  c569a27 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrEventHistoryPropsConfig.java
>  975e6a7 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrPropsConfig.java
>  ceddf7e 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrServiceLogPropsConfig.java
>  e5039d5 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogSearchConfigConfigurer.java
>  c34dce6 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java
>  f2d022e 
>   
> ambari-

Re: Review Request 60966: Log Search docker test environment build front/backend only

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60966/#review180923
---


Ship it!




Ship It!

- Robert Nettleton


On July 19, 2017, 12:22 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60966/
> ---
> 
> (Updated July 19, 2017, 12:22 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21516
> https://issues.apache.org/jira/browse/AMBARI-21516
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Building the logsearch project for testing on docker takes some time, while 
> often only the backend / frontend was modified. It should be configurable 
> what to build.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/docker/logsearch-docker.sh 4d53fa1 
> 
> 
> Diff: https://reviews.apache.org/r/60966/diff/2/
> 
> 
> Testing
> ---
> 
> Done.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 60866: AMBARI-21477: Remove Falcon proxy entries from Knox kerberos.json

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60866/#review180557
---


Ship it!




Ship It!

- Robert Nettleton


On July 14, 2017, 1:34 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60866/
> ---
> 
> (Updated July 14, 2017, 1:34 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21477
> https://issues.apache.org/jira/browse/AMBARI-21477
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Bi 4.2 stack Knox kerberos.json has falcon proxy entries that are not needed 
> anymore. remove them.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/KNOX/kerberos.json
>  8ee2acc 
> 
> 
> Diff: https://reviews.apache.org/r/60866/diff/1/
> 
> 
> Testing
> ---
> 
> to be tested in integration tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60813: Add lucene index migration script to infra solr client package

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60813/#review180554
---


Ship it!




Ship It!

- Robert Nettleton


On July 13, 2017, 10:26 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60813/
> ---
> 
> (Updated July 13, 2017, 10:26 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21459
> https://issues.apache.org/jira/browse/AMBARI-21459
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add script to migrate lucene index from version 5.x to lucene 6.x.
> 
> The bash cli tool implemeted without getopts as it has some issues on 
> different evironments.
> 
> Backup files not implemented as solr 6 has already a snapshot tool.
> 
> For more specific runs (e.g. using hdfs directory factory or exorcise corrupt 
> indices from files) check index and upgrade index tool can be run directly as 
> well.
> 
> Note: migration takes about 1 minute per 1 GB
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/build.xml a54e336 
>   ambari-infra/ambari-infra-solr-client/pom.xml d103003 
>   ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60813/diff/4/
> 
> 
> Testing
> ---
> 
> done. run script manually with different use cases
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60798: Log Feeder should support logs without date (time only)

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60798/#review180304
---


Ship it!




Ship It!

- Robert Nettleton


On July 12, 2017, 10:27 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60798/
> ---
> 
> (Updated July 12, 2017, 10:27 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21447
> https://issues.apache.org/jira/browse/AMBARI-21447
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If there is only the time of the day present for a log entry we should handle 
> it similarly as the entries without year component: if the time is already 
> passed, then it is for today, otherwise it is for yesterday.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
>  305688b 
> 
> 
> Diff: https://reviews.apache.org/r/60798/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster with HDF logs (Registry, Streamline)
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 60744: Add python functions to get the Ambari version of the agent

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60744/#review180041
---


Ship it!




Ship It!

- Robert Nettleton


On July 10, 2017, 2:37 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60744/
> ---
> 
> (Updated July 10, 2017, 2:37 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Oliver Szabo, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21435
> https://issues.apache.org/jira/browse/AMBARI-21435
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In the mpacks we may want to know the version of Ambari, for example the Log 
> Search handles it's configuration in different ways depending on it's version
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/get_ambari_version.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60744/diff/3/
> 
> 
> Testing
> ---
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 60695: Add REST end point for the documentation of the Log Feeder shipper properties

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60695/#review179882
---


Ship it!




Ship It!

- Robert Nettleton


On July 7, 2017, 12:30 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60695/
> ---
> 
> (Updated July 7, 2017, 12:30 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21423
> https://issues.apache.org/jira/browse/AMBARI-21423
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a REST API end point similar to the property description endpoint which 
> provides info about the fields of the shipper configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/ShipperConfigElementDescription.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/ShipperConfigTypeDescription.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/ConditionsImpl.java
>  8bbff8f 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FieldsImpl.java
>  68cd0e2 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterDescriptorImpl.java
>  4e11715 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterGrokDescriptorImpl.java
>  995f76b 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterKeyValueDescriptorImpl.java
>  8e89990 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputConfigImpl.java
>  a4eba8e 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputDescriptorImpl.java
>  54b4b9b 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputFileBaseDescriptorImpl.java
>  51c7ec8 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/InputS3FileDescriptorImpl.java
>  277a57c 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapAnonymizeDescriptorImpl.java
>  5fdbbab 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapDateDescriptorImpl.java
>  2e54e7a 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldCopyDescriptorImpl.java
>  4a8d746 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldDescriptorImpl.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldNameDescriptorImpl.java
>  bd32018 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldValueDescriptorImpl.java
>  599e152 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/PostMapValuesAdapter.java
>  3c21fd8 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/filter.md 129279b 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/input.md 661eeb8 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/postMapValues.md 7ec439a 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/filter/FilterJSONTest.java
>  7abf177 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ShipperConfigDescriptionStorage.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-log

Re: Review Request 60689: Upgrade Infra Solr version from 5.5.2 to 6.6.x

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60689/#review179820
---


Ship it!




Ship It!

- Robert Nettleton


On July 6, 2017, 6:41 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60689/
> ---
> 
> (Updated July 6, 2017, 6:41 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21400
> https://issues.apache.org/jira/browse/AMBARI-21400
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - upgrade solr version to 6.6.0
> - update custom solr start script (add 6.6.0 custom changes)
> - add new solr client command (--remove-admin-handlers) -> its required for 
> solr 6, using AdminHandlers class was deprecated in Solr 5, in Solr 6, it 
> does not exists, so throws runtime expection in solr node. This command will 
> run before solr starts.
> - handle ambari upgrade scenario
> 
> (note: this change does not contain index migration changes, there will be a 
> command for that as well, but that should be some manual step)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  1c5432b 
>   ambari-infra/ambari-infra-assembly/src/main/resources/solr bf504d9 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java
>  e3a1e79 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java
>  9479679 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/RemoveAdminHandlersCommand.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/SetClusterPropertyZkCommand.java
>  34597c6 
>   
> ambari-infra/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java
>  ee84969 
>   ambari-infra/pom.xml 4f5c29c 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/configsets/audit_logs/conf/solrconfig.xml
>  7af91df 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/configsets/hadoop_logs/conf/solrconfig.xml
>  59f778f 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/configsets/history/conf/solrconfig.xml
>  8244a08 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
>  d99694b 
>   ambari-logsearch/docker/Dockerfile 2b8fd5d 
>   ambari-logsearch/docker/bin/start.sh 28ebf65 
>   ambari-logsearch/pom.xml 82943e4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  5fdc885 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  5f547f3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  f3dbcf3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/audit_logs-solrconfig.xml.j2
>  63879e7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/service_logs-solrconfig.xml.j2
>  b6a4d1d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  a342baa 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> 87304cd 
> 
> 
> Diff: https://reviews.apache.org/r/60689/diff/1/
> 
> 
> Testing
> ---
> 
> unit tests done. + manual testing, there are some more use cases ...
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60568: Log Feeder input config attribute "tail" should be clearer

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60568/#review179640
---


Ship it!




Ship It!

- Robert Nettleton


On June 30, 2017, 3:13 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60568/
> ---
> 
> (Updated June 30, 2017, 3:13 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21387
> https://issues.apache.org/jira/browse/AMBARI-21387
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> tail = true should mean that only the latest log file is loaded
> tail = false should mean that the previous rolled over log files are loaded 
> too, but not followed
> 
> AbstractInputFile must be prepared for previous rolled over files to check in 
> even when the next part is actively handled, as the checking in is done when 
> the data was moved to solr, so all file related fields were moved to maps, so 
> the checkin can identify which file's status is checked in.
> 
> Log files are sorted alphabetically after identified, thus ensureing that the 
> first one is the active one. In practice they were sorted already, but the 
> File.listFiles function doesn't ensures it according to it's documentation, 
> so it's better to do so explicitly.
> 
> The thread that is responsible for deleting unused checkpoint files should do 
> one more check before deleting a checkpoint file because the file it belongs 
> to is no more there, or it's file key doesn't matches the one in the 
> checkpoint file: first it should look up if there is any other file in the 
> same folder which have the same file key, in which case it is assumed that 
> the file was renamed since. As the code that's looking for a checkpoint file 
> to determine the next line to load does that by the name of the checkpoint 
> file, which is generated from the file key it will successfuly identify it 
> irrelevant of the name of the file.
> 
> I know, it's a bit complicated :) But I couldn't put it into words less 
> complicated.
> 
> 
> Also fixed Log Search Config ZK bug not to handle not node data change 
> related events.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
>  26375e1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
>  ab50eb7 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  c36f96b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  fc40ca4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
>  19894ae 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
>  2b19503 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputManagerTest.java
>  e9bbe7e 
> 
> 
> Diff: https://reviews.apache.org/r/60568/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local vagrant cluster, by loading previous files again and again, 
> and by renaming rolled over files. In both cases no duplicate data were 
> loaded, checkpoints were handled correctly.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 60514: Use JDK 8 maven compiler plugin for Log Search and Infra projects

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60514/#review179259
---


Ship it!




Ship It!

- Robert Nettleton


On June 28, 2017, 7:34 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60514/
> ---
> 
> (Updated June 28, 2017, 7:34 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Miklos Gergely, Robert 
> Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21369
> https://issues.apache.org/jira/browse/AMBARI-21369
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Start to use jdk 8 compiler maven plugin for Log Search and Infra
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-manager/pom.xml b7708c2 
>   ambari-infra/ambari-infra-solr-plugin/pom.xml c890cec 
>   ambari-infra/pom.xml 07adb3e 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml ae2150e 
>   ambari-logsearch/ambari-logsearch-server/pom.xml fc4029b 
>   ambari-logsearch/pom.xml af1dc6a 
> 
> 
> Diff: https://reviews.apache.org/r/60514/diff/1/
> 
> 
> Testing
> ---
> 
> done. (fails with jdk 7)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60501: Create property descriptions for internal Log Search configs

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60501/#review179121
---


Fix it, then Ship it!




Patch looks fine to me, other than the minor issue listed below.


ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchPropertyDescription.java
Lines 47 (patched)
<https://reviews.apache.org/r/60501/#comment253631>

I would recommend making the example value be an array of list (or some 
other Collection) of Strings.  

If the property only accepts an enumerated set of options, it would be a 
good idea to be able to specify these in the markup.  It would also be good to 
be able to distinguish between a property that takes a comma-separated list of 
values, as opposed to a property that lists the possible valid values.  

Check out the following class in ambari-server, which provides a similar 
markdown for config properties:

org.apache.ambari.annotations.Markdown


- Robert Nettleton


On June 28, 2017, 3:51 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60501/
> ---
> 
> (Updated June 28, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-21366
> https://issues.apache.org/jira/browse/AMBARI-21366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - added new annotation to create descrptions for all internal logsearch 
> properties (currently only for logsearch.properties, not logfeeder.properties)
> - create /info endpoints to get access the property descriptions 
> (/api/v1/info/properties)
> - speed up doc generation (for this change and for swagger as well...as it 
> generated every time you hit the rest api call, now it will generated during 
> startup on a thread, from that point you will be able to acces the docs from 
> the memory)
> 
> Also some UI changes:
> - there was a /api/v1/pulbic/config call, instead of it, uses 
> /api/v1/info/auth with returning a simple map json (not that weird name value 
> structure)...use that endpoint in login.html
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchPropertyDescription.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  45281b6 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ApiDocStorage.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
>  a2a7f5e 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertyDescriptionStorage.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  9d4e96e 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/AuthPropsConfig.java
>  54cc10c 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpHeaderConfig.java
>  cb8c097 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  441b628 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
>  5981bcc 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java
>  7d37efd 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrEventHistoryPropsConfig.java
>  a117501 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrKerberosConfig.java
>  7cf79b0 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrServiceLogPropsConfig.java
>  482438a 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  73de0ee 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/InfoManager.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/PublicManager.java
>  cbab65

Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60196/#review178895
---


Ship it!




Ship It!

- Robert Nettleton


On June 26, 2017, 1:46 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60196/
> ---
> 
> (Updated June 26, 2017, 1:46 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21277
> https://issues.apache.org/jira/browse/AMBARI-21277
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Shade org.apache.http package in metrics common, as it causes a runtime error 
> for logsearch/logfeeder when they are using solr client (it requires at least 
> 4.4.x http client)
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml f0d3963 
> 
> 
> Diff: https://reviews.apache.org/r/60196/diff/5/
> 
> 
> Testing
> ---
> 
> done. manually checked the applications.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60389: Extract Log Search part from stack advisor to a separate service advisor

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60389/#review178798
---


Ship it!




The patch looks fine to me.

Can you also please add Alejandro to the reviewer list? 

Thanks.

- Robert Nettleton


On June 23, 2017, 1:54 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60389/
> ---
> 
> (Updated June 23, 2017, 1:54 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21333
> https://issues.apache.org/jira/browse/AMBARI-21333
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Extract Log Search service advisor from the stack advisor.
> Also created an empty Ambari Infra service advisor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/service_advisor.py
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 726514b 
> 
> 
> Diff: https://reviews.apache.org/r/60389/diff/1/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60196/#review178422
---


Ship it!




Ship It!

- Robert Nettleton


On June 20, 2017, 7:46 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60196/
> ---
> 
> (Updated June 20, 2017, 7:46 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21277
> https://issues.apache.org/jira/browse/AMBARI-21277
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> remvoe commons-httpclient dependency from logsearch/logfeeder
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml ce784cb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
>  d37a3bb 
>   ambari-logsearch/ambari-logsearch-server/pom.xml 7cd90eb 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  df00c15 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java
>  f2d022e 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
>  d99694b 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java
>  752a1e1 
> 
> 
> Diff: https://reviews.apache.org/r/60196/diff/3/
> 
> 
> Testing
> ---
> 
> done. manually checked the applications.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59944: Add ability to Log Search to test a log entry if it is parseable

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59944/#review178407
---


Ship it!




Ship It!

- Robert Nettleton


On June 20, 2017, 11:58 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59944/
> ---
> 
> (Updated June 20, 2017, 11:58 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21210
> https://issues.apache.org/jira/browse/AMBARI-21210
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a REST API endpoint to the server, and a command line option to the Log 
> Feeder to check if the provided log entry is parseable.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
>  4cbf21f 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterGrokDescriptor.java
>  e85ce97 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
>  d7e3c0a 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
>  198c133 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
>  4d10a5b 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterGrokDescriptorImpl.java
>  7f40b7f 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml ce784cb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  8d7c69f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederCommandLine.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java
>  726ff27 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogEntryParseTester.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  70aea65 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  27d16c4 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/AliasUtil.java
>  5049b62 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
>  94d6558 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
>  d8a1fbb 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 53cd17f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java
>  4123dad 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetrcisManagerTest.java
>  8ee6d00 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetricsManagerTest.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-server/pom.xml 7cd90eb 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  2ab5f0a 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java
>  a0db92f 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java
>  71da326 
> 
> 
> Diff: https://reviews.apache.org/r/59944/diff/2/
> 
> 
> Testing
> ---
> 
> Tested on local cluster both the REST API endpoint, the command line tool, 
> and also the original system so there aren't any regression.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60196/#review178245
---


Ship it!




Ship It!

- Robert Nettleton


On June 19, 2017, 11:52 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60196/
> ---
> 
> (Updated June 19, 2017, 11:52 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21277
> https://issues.apache.org/jira/browse/AMBARI-21277
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> remvoe commons-httpclient dependency from logsearch/logfeeder
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 49122e8 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml a439266 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  df00c15 
> 
> 
> Diff: https://reviews.apache.org/r/60196/diff/2/
> 
> 
> Testing
> ---
> 
> done. manually checked the applications.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60092: Infra Manager: Use custom serializer for execution contexts of job & steps

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60092/#review177921
---


Ship it!




Ship It!

- Robert Nettleton


On June 14, 2017, 4:42 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60092/
> ---
> 
> (Updated June 14, 2017, 4:42 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21247
> https://issues.apache.org/jira/browse/AMBARI-21247
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Obtaining execution context of jobs/steps is not working as the framework 
> uses an XStreamExecutionContextStringSerializer by default, which cannot be 
> deserialized properly. Use an another serializer for that.
> 
> Also edit execution contexts and the exit desription of the dummy job.
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
>  95f87f5 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java
>  9a78706 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyJobListener.java
>  0bbfb55 
> 
> 
> Diff: https://reviews.apache.org/r/60092/diff/3/
> 
> 
> Testing
> ---
> 
> done, manually
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 60081: Improve error message for Blueprints deployment with incorrect credential type

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60081/#review177907
---


Ship it!




Ship It!

- Robert Nettleton


On June 14, 2017, 12:37 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60081/
> ---
> 
> (Updated June 14, 2017, 12:37 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Laszlo Puskas, 
> Robert Levas, Robert Nettleton, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21242
> https://issues.apache.org/jira/browse/AMBARI-21242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed the exeption text to list valid credential types.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
>  2c95806 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
>  e0735be 
> 
> 
> Diff: https://reviews.apache.org/r/60081/diff/1/
> 
> 
> Testing
> ---
> 
> - Tested the change manually
> - Modified existing unit test for the API
> - Run all unit tests in ambari-server, no errors.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 59948: AMBARI-20853. Service Advisor - Allow Service to define its Advisor Type as Python or Java

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59948/#review177629
---


Fix it, then Ship it!





ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
Line 81 (original), 82 (patched)
<https://reviews.apache.org/r/59948/#comment251323>

Minor issue:

If this commented line is no longer needed, I'd suggest removing it.


- Robert Nettleton


On June 10, 2017, 12:28 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59948/
> ---
> 
> (Updated June 10, 2017, 12:28 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, Swapan 
> Shridhar, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20853
> https://issues.apache.org/jira/browse/AMBARI-20853
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> See Epic AMBARI-20852
> 
> First step is to allow a Service's metainfo.xml file to define what type of 
> Service Advisor it uses, Python or Java.
> For now, continue to call Python for all services since all services are not 
> specifying which type to use (so defaults to Python)
> 
> If set to Java, will eventually call a class to invoke the existing Service 
> Advisor in Python as a way to ensure compatibility.
> If set to Python, continue to call the current script.
> 
> In both cases, we will continue to generate the services.json file.
> 
> Today, we call Stack Advisor on all services even if only one service is 
> modified, so it's ok to hardcode a service name until the UI is able to 
> provide that granularity.
> 
> 
> Diffs
> -
> 
>   ambari-client/groovy-client/pom.xml fa89a73 
>   ambari-funtest/pom.xml 66678c2 
>   ambari-infra/ambari-infra-solr-client/pom.xml 8cb2248 
>   ambari-logsearch/ambari-logsearch-config-api/pom.xml 5355906 
>   ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 7ecda60 
>   ambari-logsearch/ambari-logsearch-it/pom.xml 81af9e8 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml ddef52f 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml f9d7e19 
>   ambari-project/pom.xml 64d1416 
>   ambari-server/checkstyle.xml 6b4824a 
>   ambari-server/pom.xml 669f90f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java
>  3083d9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunner.java
>  a4b7915 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ComponentLayoutRecommendationCommand.java
>  ca1d95f2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ComponentLayoutValidationCommand.java
>  91d8f9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationDependenciesRecommendationCommand.java
>  fae0b16 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationRecommendationCommand.java
>  e25e39b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationValidationCommand.java
>  1892a82 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  ed27697 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> 7dbc639 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 97490e0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelperTest.java
>  e331ddd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunnerTest.java
>  8d104ea 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationRecommendationCommandTest.java
>  17293eb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
>  46552a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java
>  20d2168 
>   ambari-views/examples/weather-view/pom.xml abed017 
>   contrib/views/hawq/pom.xml 0c6591e 
>   contrib/views/hive-next/pom.xml 578a82c 
>   contrib/views/hive20/pom.xml 7ea95ad 
>   contrib/views/pig/pom.xml 5239cc2 
&g

Re: Review Request 60007: Rename userconfig resource to event history in Log Search Portal

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60007/#review177623
---


Ship it!




Ship It!

- Robert Nettleton


On June 12, 2017, 3:17 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60007/
> ---
> 
> (Updated June 12, 2017, 3:17 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21228
> https://issues.apache.org/jira/browse/AMBARI-21228
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Get rid of userconfig name, use history nd eventHistory instead of it. (its 
> valid to do that as filters is now on zookeeper)
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java
>  a7559aa 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  973dc4b 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
>  f00e8c5 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrEventHistoryPropsConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrUserPropsConfig.java
>  c8c96c8 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/global/SolrEventHistoryState.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/global/SolrUserConfigState.java
>  06af14c 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/converter/EventHistoryRequestQueryConverter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/converter/UserConfigRequestQueryConverter.java
>  594f23b 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/EventHistorySolrDao.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
>  01378c1 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  a0e01a3 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  885771d 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/EventHistoryManager.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java
>  1df9f5a 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/request/EventHistoryParamDefinition.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/request/UserConfigParamDefinition.java
>  dd74b6f 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/request/impl/EventHistoryRequest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/request/impl/UserConfigRequest.java
>  cbbc6e6 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/response/EventHistoryData.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/response/EventHistoryDataListResponse.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/response/UserConfigData.java
>  ef4e0be 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/response/UserConfigDataListResponse.java
>  5c445b2 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/EventHistoryResource.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/StatusResource.java
>  8cc6b94 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/UserConfigResource.java
>  00b971a 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/

Re: Review Request 59828: Ability to anonymize data during log processing

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59828/#review177487
---


Ship it!




The patch looks fine.

One thing that may be worth considering for a future patch is the default hide 
character.  It might be good to use * as the default, since password fields in 
UIs are typically replaced with * .  That being said, I wouldn't necessarily 
change this patch to update the default hide character, but perhaps it should 
be changed in a different patch.

- Robert Nettleton


On June 6, 2017, 8:55 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59828/
> ---
> 
> (Updated June 6, 2017, 8:55 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21181
> https://issues.apache.org/jira/browse/AMBARI-21181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Have a new mapper called map_anonymize which accepts a pattern containing 
>  elements. After the mapping if the pattern is found in the field, than 
> the parts matching the  elements are replaced with a configurable 
> hiding character ( default 'X' ).
> 
> Example:
> pattern: the secret is  /  which is confidential
> log message: Bla bla bla the secret is SECRET1 / SECRET2 which is 
> confidential bla bla
> after the mapping: Bla bla bla the secret is XXX / XXX which is 
> confidential bla bla
> 
> This patch also fixes the checkpoint file writing, which wasn't atomic. The 
> checkpoint files are now written under a temporary name first, than 
> atomically renamed to the proper name, thus making it impossible to have a 
> half written file.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapAnonymizeDescriptor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapDateDescriptor.java
>  f88435f 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldDescriptor.java
>  db086c5 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldValueDescriptor.java
>  cf37e62 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapAnonymizeDescriptorImpl.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/PostMapValuesAdapter.java
>  32aded8 
>   ambari-logsearch/ambari-logsearch-logfeeder/docs/postMapValues.md 906359a 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java
>  2bc4e68 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  fba596d 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java
>  8c76785 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
>  4bf162b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperAnonymize.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java
>  ffd6cec 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/alias_config.json
>  e2ed625 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/mapper/MapperAnonymizeTest.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/log4j.xml 
> e641018 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapDate.java
>  dcb0393 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapField.java
>  b18439c 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapFieldAnonymize.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerPost

Re: Review Request 59888: Fix ambari-solr-plugin folder structure

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59888/#review177226
---


Ship it!




Ship It!

- Robert Nettleton


On June 7, 2017, 5:51 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59888/
> ---
> 
> (Updated June 7, 2017, 5:51 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Miklos Gergely, 
> Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21196
> https://issues.apache.org/jira/browse/AMBARI-21196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> move solr plugin files from "org.apache.ambari.infra.security" folder to 
> org/apache/ambari/infra/security
> 
> (funny fact: it worked with that folder name, as the class was generated into 
> the proper place beacase of the package name)
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraKerberosHostValidator.java
>   
>   
> ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraRuleBasedAuthorizationPlugin.java
>   
>   
> ambari-infra/ambari-infra-solr-plugin/src/main/java/org.apache.ambari.infra.security/InfraUserRolesLookupStrategy.java
>   
> 
> 
> Diff: https://reviews.apache.org/r/59888/diff/1/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59846: Get rid deprecated jdk install in the Dockerfile of Log Search

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59846/#review177067
---


Ship it!




Ship It!

- Robert Nettleton


On June 6, 2017, 5:14 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59846/
> ---
> 
> (Updated June 6, 2017, 5:14 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: trunk
> https://issues.apache.org/jira/browse/trunk
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> JDK download location does not exists anymore. (also uses a hash for jdk 
> version, from now, its required)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/docker/Dockerfile d399fc6 
> 
> 
> Diff: https://reviews.apache.org/r/59846/diff/1/
> 
> 
> Testing
> ---
> 
> done, manually.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59689: Fix swagger sytax errors in Log Search REST API doc

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59689/#review176511
---


Ship it!




Ship It!

- Robert Nettleton


On May 31, 2017, 6:53 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59689/
> ---
> 
> (Updated May 31, 2017, 6:53 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21159
> https://issues.apache.org/jira/browse/AMBARI-21159
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix sytax errors regarding to generated swagger.yaml file:
> - info did not contain version
> - getClusterForServiceLog operationId is duplicated
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  630e73a 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java
>  5312da8 
> 
> 
> Diff: https://reviews.apache.org/r/59689/diff/1/
> 
> 
> Testing
> ---
> 
> done. tried out with swagger online editor
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59683: Design Ambari Infra Component & workflows

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59683/#review176485
---


Ship it!




Ship It!

- Robert Nettleton


On May 31, 2017, 1:51 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59683/
> ---
> 
> (Updated May 31, 2017, 1:51 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-21155
> https://issues.apache.org/jira/browse/AMBARI-21155
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Add design overview to README.md of Infra Manager
> - fix one of the rest api endpoint
> - fix swagger.yaml generation (version is missing if Info object is not used)
> - add a static swagger.yaml
> - extend to Dummy Job example: add listeners and write output data into the 
> filesystem
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-manager/README.md d3527c4 
>   ambari-infra/ambari-infra-manager/docs/api/swagger.yaml PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docs/images/batch-1.png PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docs/images/batch-2.png PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docs/images/batch-3.png PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docs/images/batch-4.png PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/common/InfraManagerConstants.java
>  77f7008 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/InfraManagerApiDocConfig.java
>  22e2263 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
>  c3d8db6 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java
>  f495795 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyJobListener.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyStepListener.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java
>  7023957 
> 
> 
> Diff: https://reviews.apache.org/r/59683/diff/2/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59563: Log Search REST API validate input configurations and log level filters

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59563/#review176116
---


Ship it!




Ship It!

- Robert Nettleton


On May 25, 2017, 2:21 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59563/
> ---
> 
> (Updated May 25, 2017, 2:21 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21119
> https://issues.apache.org/jira/browse/AMBARI-21119
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Search server REST API should validate that the received input 
> configuration / log level filter is in the valid format.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldNameDescriptorImpl.java
>  333cb67 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java
>  44d91a9 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerConditions.java
>  9cd9710 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFields.java
>  5f570da 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFilter.java
>  0190c01 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFilterDeserializer.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFilterGrok.java
>  a8c4a7a 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFilterJson.java
>  3c0ed17 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFilterKeyValue.java
>  dcee25d 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInput.java
>  fe83fe4 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInputConfig.java
>  e3dc0d1 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInputDeserializer.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInputFile.java
>  5c547ad 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInputFileBase.java
>  df21d0d 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInputS3File.java
>  8e9acf0 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilter.java
>  2a00802 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilterMap.java
>  3088db1 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapDate.java
>  dcacceb 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapFieldCopy.java
>  b0bea83 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapFieldName.java
>  000b29d 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapFieldValue.java
>  6152de5 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerPostMapValues.java
>  5f361c9 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerPostMapValuesList.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerPostMapValuesListDeserializer.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerPostMapValuesListSerializer.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSS

Re: Review Request 59451: Add Log Feeder input config to HDP 3.0 hooks too

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59451/#review175642
---


Ship it!




Ship It!

- Robert Nettleton


On May 22, 2017, 3:14 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59451/
> ---
> 
> (Updated May 22, 2017, 3:14 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21090
> https://issues.apache.org/jira/browse/AMBARI-21090
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 3.0 clusters need their input configs too
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/after-INSTALL/scripts/params.py
>  5dcd39b 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/after-INSTALL/scripts/shared_initialization.py
>  e9f2283 
> 
> 
> Diff: https://reviews.apache.org/r/59451/diff/1/
> 
> 
> Testing
> ---
> 
> done on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 59448: Infra manger: Add static data folder servlet endpoint

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59448/#review175637
---


Ship it!




Ship It!

- Robert Nettleton


On May 22, 2017, 11:59 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59448/
> ---
> 
> (Updated May 22, 2017, 11:59 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21087
> https://issues.apache.org/jira/browse/AMBARI-21087
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add /files/* endpoint which can be displayed by the browser.
> The folder which is browsed can be configured through start cli parameter.
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
>  227bab4 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/common/InfraManagerConstants.java
>  11714f3 
> 
> 
> Diff: https://reviews.apache.org/r/59448/diff/1/
> 
> 
> Testing
> ---
> 
> done. (manually)
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59232: AMBARI-20984 Be able to include stack repos in blueprint

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59232/#review175568
---


Ship it!




Ship It!

- Robert Nettleton


On May 19, 2017, 4:36 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59232/
> ---
> 
> (Updated May 19, 2017, 4:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Nettleton, Sandor 
> Magyari, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20984
> https://issues.apache.org/jira/browse/AMBARI-20984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, if a user wants to use custom HDP repos during a blueprint 
> deployment, he has to update the repo URLs before hand via a REST API. The 
> JIRA here proposes a way to include stack repos in the blueprint as optional 
> fields so that when the fields exist, Ambari server will use the repos to 
> deploy a cluster. This eliminates the need for user to run a separate rest 
> api call before the actual blueprint deployment.
> Attachments
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  c655c62 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> 139a1ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  826e4e5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/RepositorySetting.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java 
> 555192c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  f5cf498 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithStartOnlyTest.java
>  c8d4d55 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartOnComponentLevelTest.java
>  4c9815c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  1bdeb1b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/SettingTest.java
>  0007acf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  0378753 
> 
> 
> Diff: https://reviews.apache.org/r/59232/diff/3/
> 
> 
> Testing
> ---
> 
> unit tests. patch a trunk cluster with the change and use  blueprint to 
> install a cluster.
> 
> The section to add to the bp for the repos is like the following.
> 
> override_strategy - ALWAYS_APPLY will override the existing repo info stored 
> in the metainfo table in the Ambari db. APPLY_WHEN_MISSING will only insert 
> repo info to the metainfo table if there is no such entries in the table yet.
> 
>   "settings" : [
> {
> "repository_settings" : [
>   {
> "override_strategy":"ALWAYS_APPLY",
> "operating_system":"redhat7",
> "repo_id":"HDP-2.6", 
> 
> "base_url":"http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos7/2.x/BUILDS/2.6.0.3-8;
>   },
>   {
> "override_strategy":"APPLY_WHEN_MISSING",
> "operating_system":"redhat7",
> "repo_id": "HDP-UTILS-1.1.0.21",
> "base_url": 
> "http://public-repo-1.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos7;
>   }
> ]
> }
>   ],
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59396/#review175529
---


Ship it!




Ship It!

- Robert Nettleton


On May 19, 2017, 12:52 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59396/
> ---
> 
> (Updated May 19, 2017, 12:52 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21071
> https://issues.apache.org/jira/browse/AMBARI-21071
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Added new rest endpoints to manage jobs & steps for infra-manager data/job 
> processing
> - Added some wrapper DTO classes to help jakson to serialize objects with 
> cyclic dependency (some models are reimplemented which came from spring-batch 
> admin manager project)
> - Added exception mapper for generating the proper responses codes in case of 
> internal exceptions.
> - TODO: add unit tests for JobManager class
> 
> 
> Diffs
> -
> 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
>  656127e 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
>  7310626 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/ExecutionContextResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobDetailsResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionDetailsResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionInfoResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionStopRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceDetailsResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobInstanceStartRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobOperationParams.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/PageRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionContextResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionInfoResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionProgressResponse.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/StepExecutionRequest.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/JobExecutionData.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/wrapper/StepExecutionData.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobExceptionMapper.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java
>  27fed40 
> 
> 
> Diff: https://reviews.apache.org/r/59396/diff/2/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175524
---


Ship it!




Ship It!

- Robert Nettleton


On May 18, 2017, 6:27 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> ---
> 
> (Updated May 18, 2017, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and 
> Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
> https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exported blueprint should include config-group changes, which should be 
> exported as host-group level configuration. New host-group will be created 
> for host having unique config-group.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> 
> 
> exported blueprint
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59308: Add docker support for infra manager

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59308/#review175267
---


Ship it!




Ship It!

- Robert Nettleton


On May 16, 2017, 12:04 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59308/
> ---
> 
> (Updated May 16, 2017, 12:04 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21031
> https://issues.apache.org/jira/browse/AMBARI-21031
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> add docker support & update readme.md
> 
> run infra-manager-docker.sh in docker folder if docker is installed
> 
> small addition: added infra-manager-env.sh file as well to the rpm
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-assembly/pom.xml 550d97c 
>   ambari-infra/ambari-infra-manager/README.md 033bbb2 
>   ambari-infra/ambari-infra-manager/build.xml c7954d9 
>   ambari-infra/ambari-infra-manager/docker/Dockerfile PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docker/bin/start.sh PRE-CREATION 
>   ambari-infra/ambari-infra-manager/docker/infra-manager-docker.sh 
> PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/resources/infra-manager-env.sh 
> PRE-CREATION 
>   ambari-infra/ambari-infra-manager/src/main/resources/infraManager.sh 
> 9f40d5c 
> 
> 
> Diff: https://reviews.apache.org/r/59308/diff/1/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59281: Integrate BlueprintService and subresources with swagger

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59281/#review175006
---


Ship it!




Ship It!

- Robert Nettleton


On May 15, 2017, 6:35 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59281/
> ---
> 
> (Updated May 15, 2017, 6:35 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21026
> https://issues.apache.org/jira/browse/AMBARI-21026
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Documented the Blueprint API. Kerberos descriptor in Blueprint schema is not 
> elaborated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
>  0b2afd1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BlueprintService.java
>  8159ea4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/BlueprintSwagger.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59281/diff/1/
> 
> 
> Testing
> ---
> 
> All unit tests for ambari-server pass, except 
> ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to 
> AMBARI-20443.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 59271: Support rpm/deb build for ambari-infra-manager

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59271/#review174952
---


Ship it!




Ship It!

- Robert Nettleton


On May 15, 2017, 2:39 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59271/
> ---
> 
> (Updated May 15, 2017, 2:39 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-21024
> https://issues.apache.org/jira/browse/AMBARI-21024
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create rpm/deb build for ambari-infra-manager with 
> /usr/lib/ambari-infra-manager and /etc/ambari-infra-manager/conf mappings
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-assembly/pom.xml 51e5804 
>   ambari-infra/ambari-infra-assembly/src/main/package/deb/manager/control 
> PRE-CREATION 
>   ambari-infra/ambari-infra-assembly/src/main/package/deb/manager/postinst 
> PRE-CREATION 
>   ambari-infra/ambari-infra-assembly/src/main/package/deb/manager/postrm 
> PRE-CREATION 
>   ambari-infra/ambari-infra-assembly/src/main/package/deb/manager/preinst 
> PRE-CREATION 
>   ambari-infra/ambari-infra-assembly/src/main/package/deb/manager/prerm 
> PRE-CREATION 
>   ambari-infra/ambari-infra-manager/build.xml PRE-CREATION 
>   ambari-infra/ambari-infra-manager/pom.xml bd5bf03 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/InfraManager.java
>  227bab4 
>   ambari-infra/ambari-infra-manager/src/main/resources/infraManager.sh 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59271/diff/1/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59266: Support external story locations in Log Search IT framework

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59266/#review174949
---


Ship it!




Ship It!

- Robert Nettleton


On May 15, 2017, 12:17 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59266/
> ---
> 
> (Updated May 15, 2017, 12:17 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21020
> https://issues.apache.org/jira/browse/AMBARI-21020
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, logsearch it framework load story files (JBehave) from the 
> classpath, it would be useful to load story files externally, then we should 
> not manage story files inside the source code. (helps to write business 
> specific tests without code change)
> 
> To achive this, add 2 new properties to the build: backend.stories.location 
> and ui.stories.location properties.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 92b98f9 
>   ambari-logsearch/ambari-logsearch-it/pom.xml 0058c80 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchBackendStories.java
>  46f2928 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStoryLocator.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java
>  217c50f 
> 
> 
> Diff: https://reviews.apache.org/r/59266/diff/2/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59228: Supprt boot2docker & docker-machine in Log Search integration test module

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59228/#review174793
---


Ship it!




Ship It!

- Robert Nettleton


On May 12, 2017, 1:58 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59228/
> ---
> 
> (Updated May 12, 2017, 1:58 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21004
> https://issues.apache.org/jira/browse/AMBARI-21004
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding $docker.host property to it framework, with that we can configure to 
> use specific ip/host for docker (localhost is only works with docker-for-mac 
> or unix docker installation)
> 
> Also remove suffixes from story names
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 4123a52 
>   ambari-logsearch/ambari-logsearch-it/pom.xml cdb76a5 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java
>  a7dd409 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java
>  eb2a180 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story
>  0af00f5 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_tests.story
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story
>  388e624 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_tests.story
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59228/diff/1/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 59175: Ambari infra manager: add batch support

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59175/#review174716
---


Ship it!




Ship It!

- Robert Nettleton


On May 11, 2017, 1:30 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59175/
> ---
> 
> (Updated May 11, 2017, 1:30 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20989
> https://issues.apache.org/jira/browse/AMBARI-20989
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add basic spring batch support with a dummy item writer/reader/processor.
> Also add some rest entripoint to run and gather jobs/execution ids.
> Using sqlite as database -> the whole database is inside in one local file. 
> Later it can be more configurable.
> 
> Added schedule support as well see @EnableScheduling
> 
> 
> Diffs
> -
> 
>   ambari-infra/.gitignore PRE-CREATION 
>   ambari-infra/ambari-infra-manager/pom.xml c3a09ab 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/conf/batch/InfraManagerBatchConfig.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemProcessor.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyItemWriter.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/dummy/DummyObject.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/rest/JobResource.java
>  45b1ca5 
>   ambari-infra/ambari-infra-manager/src/main/resources/dummy/dummy.csv 
> PRE-CREATION 
>   
> ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 
> 13878a1 
> 
> 
> Diff: https://reviews.apache.org/r/59175/diff/1/
> 
> 
> Testing
> ---
> 
> tested manually.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58990/#review174360
---


Ship it!




Ship It!

- Robert Nettleton


On May 9, 2017, 9:38 a.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58990/
> ---
> 
> (Updated May 9, 2017, 9:38 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Robert Levas, Robert Nettleton, 
> and Sandor Magyari.
> 
> 
> Bugs: AMBARI-20872
> https://issues.apache.org/jira/browse/AMBARI-20872
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Validating required properties for services listed in the blueprint can't be 
> accurate as further configurtion can be added in the cluster creation 
> template.
> (Where the configuration is added varies by use cases and usage)
> 
> This patch contains the change that defers this validation till all the 
> configuration is together, namely till the cluster creation template is 
> posted.
> 
> The validation logic is the same as it was before.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  45a8c5c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyValidator.java
>  146b424 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/validators/TopologyValidatorFactory.java
>  0e77301 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
>  0608697 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidatorTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58990/diff/2/
> 
> 
> Testing
> ---
> 
> Tested successfully on local environment.
> Added unit tests.
> 
> Unit tests - success.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Re: Review Request 59051: Integrate Log Search integration test framework with Selenium

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59051/#review174182
---


Ship it!




Ship It!

- Robert Nettleton


On May 8, 2017, 3:40 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59051/
> ---
> 
> (Updated May 8, 2017, 3:40 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Miklos Gergely, Robert Nettleton, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20955
> https://issues.apache.org/jira/browse/AMBARI-20955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Integrate selenium with log search it framework.
> Tests can be run separately for ui and backend. Currently it requires x11 
> forwarding to see the tests itself. (later headless will be added). Also im 
> using localhost as docker hosts right now, which means it currenty works with 
> docker-for-mac or on linux system with an installed docker
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 5c41fcd 
>   ambari-logsearch/ambari-logsearch-it/pom.xml ee97e99 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java
>  cb72376 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java
>  32e8cba 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchUISteps.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchApiQueryStory.java
>  45455bf 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchBackendStories.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStory.java
>  ce6b9cb 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogfeederParsingStory.java
>  c502cc4 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/AbstractPage.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/web/Home.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/log_search_api_query_story.story
>  cfaa359 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/logfeeder_parsing_story.story
>  388e624 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/selenium/login.ui.story
>  PRE-CREATION 
>   ambari-logsearch/docker/Dockerfile 6e8ea3e 
>   ambari-logsearch/docker/bin/start.sh 1efc85c 
>   ambari-logsearch/docker/logsearch-docker.sh eab850e 
> 
> 
> Diff: https://reviews.apache.org/r/59051/diff/1/
> 
> 
> Testing
> ---
> 
> ran with -Dselenium-tests and with -Dbackend-tests as well
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:36 min
> [INFO] Finished at: 2017-05-08T16:27:44+02:00
> [INFO] Final Memory: 51M/499M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 58822: Add Log Level Filter to the Log Search config API

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/#review173495
---


Ship it!




Ship It!

- Robert Nettleton


On April 28, 2017, 4:39 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58822/
> ---
> 
> (Updated April 28, 2017, 4:39 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20881
> https://issues.apache.org/jira/browse/AMBARI-20881
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Level Filters should be handled by the config API too
> 
> Also Log Level Filters should be per cluster, not only one for the Log Search 
> Server. This means that some UI modifications are also necessary in order to 
> query/persist changes of the log level filters for a specific cluster only.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java
>  df26920 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
>  0bb0b78 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
>  969eb30 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
>  664ecc9 
>   ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
>  738fde2 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  074fedb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
>  b70fbd1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java
>  a05a916 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java
>  12c744c 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
>  0ece637 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java
>  60c8ae8 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java
>  9199cd3 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
>  135fb32 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
>  bb2f0a9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java
>  266108f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties
>  59020cc 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java
>  c2d27f9 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  8fb27a7 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  00adb67 
>   
> ambari-logsearch/ambari-logsearch-server