Re: Review Request 53943: Improve remoteIp in audit log

2016-12-02 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157758
---



Pushed to trunk and branch-2.5 - please close this review.

- Jonathan Hurley


On Nov. 29, 2016, 7:16 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated Nov. 29, 2016, 7:16 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> RequestUtilsTest All Tests Passsed ,Process finished with exit code 0
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53943: Improve remoteIp in audit log

2016-12-01 Thread wang yaoxin 


> On 十一月 29, 2016, 3:26 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java,
> >  lines 53-55
> > 
> >
> > This would actually do indexOf twice in cases where there are 2 or more 
> > IPs.
> > 
> > Why not just make a method called something like 
> > normalizeIPAddress(String address) which either returns the string or 
> > returns the indexOf.
> > 
> > This way, you only do it once.

Hi Jonathan, Thanks for  your suggestion, but this method likely requires to be 
invoked twice, unless define a variable


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157255
---


On 十一月 29, 2016, 12:16 p.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated 十一月 29, 2016, 12:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> RequestUtilsTest All Tests Passsed ,Process finished with exit code 0
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157255
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
(lines 53 - 55)


This would actually do indexOf twice in cases where there are 2 or more IPs.

Why not just make a method called something like normalizeIPAddress(String 
address) which either returns the string or returns the indexOf.

This way, you only do it once.


- Jonathan Hurley


On Nov. 29, 2016, 7:16 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated Nov. 29, 2016, 7:16 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> RequestUtilsTest All Tests Passsed ,Process finished with exit code 0
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157239
---


Ship it!




Ship It!

- Attila Doroszlai


On Nov. 29, 2016, 1:16 p.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated Nov. 29, 2016, 1:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> RequestUtilsTest All Tests Passsed ,Process finished with exit code 0
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread Attila Doroszlai 


> On Nov. 29, 2016, 12:55 p.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java,
> >  line 87
> > 
> >
> > unnecessary space before `;`
> 
> wang yaoxin wrote:
> Thanks Attila, I have modified my code

Thanks!


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157224
---


On Nov. 29, 2016, 1:16 p.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated Nov. 29, 2016, 1:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> RequestUtilsTest All Tests Passsed ,Process finished with exit code 0
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread wang yaoxin 


> On 十一月 29, 2016, 11:55 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java,
> >  line 87
> > 
> >
> > unnecessary space before `;`

Thanks Attila, I have modified my code


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157224
---


On 十一月 29, 2016, 12:16 p.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated 十一月 29, 2016, 12:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> RequestUtilsTest All Tests Passsed ,Process finished with exit code 0
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread wang yaoxin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/
---

(Updated 十一月 29, 2016, 12:16 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver Szabo, 
Robert Levas, Robert Nettleton, and Sebastian Toader.


Changes
---

Improve the description


Bugs: AMBARI-18944
https://issues.apache.org/jira/browse/AMBARI-18944


Repository: ambari


Description
---

Mutil-agent were configured in some production environments, RemoteIp therefore 
will obtain mutilple IP addresses, like 
(RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.


Diffs (updated)
-

  ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
0ac782f 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
 595127e 

Diff: https://reviews.apache.org/r/53943/diff/


Testing
---

RequestUtilsTest All Tests Passsed ,Process finished with exit code 0


Thanks,

wang yaoxin

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157224
---




ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
(line 82)


1. typo: "mutilple" -> "multiple"
2. The text could be improved, eg.: "Checks if ip contains 
multiple IP addresses."



ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
(line 83)


Please do not add `@param` without description.  Either provide description 
or remove the tag.



ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
(line 84)


Please do not add `@return` without description.  Either provide 
description or remove the tag.



ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
(line 86)


1. typo: "Muti" -> "Multi"
2. Should begin with "is" by convention (although I think something like 
`containsMultipleRemoteAddresses` would be better)



ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
(line 87)


unnecessary space before `;`


- Attila Doroszlai


On Nov. 29, 2016, 2:04 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated Nov. 29, 2016, 2:04 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> RequestUtilsTest All Tests Passsed ,Process finished with exit code 0
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread wang yaoxin 


> On 十一月 28, 2016, 4:56 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java,
> >  lines 88-90
> > 
> >
> > 255.255.255.255 - 15 characters. But this is still not a very effective 
> > way to determine if the string contains 2 or more IPs. Just do the indexOf 
> > check instead.

Thanks Jonathan ,I have modified my code


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157051
---


On 十一月 29, 2016, 12:57 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated 十一月 29, 2016, 12:57 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> test done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread wang yaoxin 


> On 十一月 28, 2016, 2:34 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java,
> >  lines 88-90
> > 
> >
> > Why is this needed and where the 15 comes from?

Thanks Sebastian ,I have modified my code and run the RequestUtilsTest ,All 
Tests Passsed ,Process finished with exit code 0


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157029
---


On 十一月 29, 2016, 12:57 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated 十一月 29, 2016, 12:57 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> test done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread wang yaoxin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/
---

(Updated 十一月 29, 2016, 1:04 a.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver Szabo, 
Robert Levas, Robert Nettleton, and Sebastian Toader.


Bugs: AMBARI-18944
https://issues.apache.org/jira/browse/AMBARI-18944


Repository: ambari


Description
---

Mutil-agent were configured in some production environments, RemoteIp therefore 
will obtain mutilple IP addresses, like 
(RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
0ac782f 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
 595127e 

Diff: https://reviews.apache.org/r/53943/diff/


Testing (updated)
---

RequestUtilsTest All Tests Passsed ,Process finished with exit code 0


Thanks,

wang yaoxin

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread wang yaoxin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/
---

(Updated 十一月 29, 2016, 12:57 a.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver Szabo, 
Robert Levas, Robert Nettleton, and Sebastian Toader.


Changes
---

Just do the indexOf check instead


Bugs: AMBARI-18944
https://issues.apache.org/jira/browse/AMBARI-18944


Repository: ambari


Description
---

Mutil-agent were configured in some production environments, RemoteIp therefore 
will obtain mutilple IP addresses, like 
(RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.


Diffs (updated)
-

  ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
0ac782f 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
 595127e 

Diff: https://reviews.apache.org/r/53943/diff/


Testing
---

test done!


Thanks,

wang yaoxin

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157051
---




ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
(lines 88 - 90)


255.255.255.255 - 15 characters. But this is still not a very effective way 
to determine if the string contains 2 or more IPs. Just do the indexOf check 
instead.


- Jonathan Hurley


On Nov. 25, 2016, 4:46 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated Nov. 25, 2016, 4:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> test done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157043
---


Ship it!




Ship It!

- Robert Levas


On Nov. 25, 2016, 4:46 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated Nov. 25, 2016, 4:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> test done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157029
---



Please add the results of the unit tests to the reviewboard.


ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
(lines 88 - 90)


Why is this needed and where the 15 comes from?


- Sebastian Toader


On Nov. 25, 2016, 10:46 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated Nov. 25, 2016, 10:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> test done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/#review157027
---


Ship it!




Ship It!

- Oliver Szabo


On Nov. 25, 2016, 9:46 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53943/
> ---
> 
> (Updated Nov. 25, 2016, 9:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Oliver 
> Szabo, Robert Levas, Robert Nettleton, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18944
> https://issues.apache.org/jira/browse/AMBARI-18944
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mutil-agent were configured in some production environments, RemoteIp 
> therefore will obtain mutilple IP addresses, like 
> (RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
> 0ac782f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
>  595127e 
> 
> Diff: https://reviews.apache.org/r/53943/diff/
> 
> 
> Testing
> ---
> 
> test done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Review Request 53943: Improve remoteIp in audit log

2016-11-20 Thread wang yaoxin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53943/
---

Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.


Bugs: AMBARI-18944
https://issues.apache.org/jira/browse/AMBARI-18944


Repository: ambari


Description
---

Mutil-agent were configured in some production environments, RemoteIp therefore 
will obtain mutilple IP addresses, like 
(RemoteIp(172.16.0.66,172.16.193.56),)which causes errors in log output.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
0ac782f 
  
ambari-server/src/test/java/org/apache/ambari/server/utils/RequestUtilsTest.java
 595127e 

Diff: https://reviews.apache.org/r/53943/diff/


Testing
---

test done!


Thanks,

wang yaoxin