Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

[Daniel Gergely]

> On jún. 13, 2016, 4:51 du, Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java,
> >  line 191
> > 
> >
> > I'm a little concerned that this approach could have performance issues 
> > down the road.
> > 
> > I'm wondering if it might be worth considering launching a separate 
> > task thread when the cluster is created by the TopologyManager, that can 
> > monitor the state of the LogicalRequest as the deployment progresses.
> > 
> > I would recommend asking Sumit to review this as well, since it's not 
> > clear to me that this is the approach that should be taken.
> 
> Sebastian Toader wrote:
> This loop simply iterates through the received reports extracts cluster 
> id and publishes an event for further processing. The event is consumed on a 
> separate thread 'ambari-event-bus' which is set up in 
> ```AmbariEventPublisher```. Do you think that the extraction of cluster name 
> and cluster id may slow the the heartbeat handler?
> 
> Robert Nettleton wrote:
> Hi Sebastian, Thanks for this information.
> 
> I guess I'd be concerned about any extraneous additions to the 
> HeartBeatHandler, especially given that it seems like there would be other 
> alternatives.
> 
> Was the possibility of launching a thread in the TopologyManager to 
> monitor a cluster deployment's status considered?  Since the TopologyManager 
> already has access to the LogicalRequest and the underlying physical requests 
> as well, it seems like the most natural fit for monitoring status, and 
> providing a way to log this information.
> 
> My overall concern is that the heartbeat handlers are being modified just 
> to support logging a message when the cluster has completed.  As I mentioned 
> above, it seems like it would be simpler and more straightforward to resolve 
> this with a thread that monitors the progress, using the resource APIs that 
> already exist in Ambari.  
> 
> If the approach I've just detailed was considered, can you post why it 
> was not chosen?  Are there some technical concerns that make using a separate 
> thread not feasible? 
> 
> Thanks.

Hi Bob,
HeartbeatHandler is not modified only to support logging. Now it sends an event 
(which is basically free: a list is created and cluster ids are stored in that. 
Cluster ids are from a cache, so there is no performance issue there either), 
and this event is handled asynchronously (logging part of the code is executed 
by a different thread). So it does not affect HeartbeatHandler.
So it is indeed a separate thread.

However if you still have concerns, let's talk, I am open to any other working 
solution.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48266/#review137326
---


On jún. 11, 2016, 6:43 de, Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48266/
> ---
> 
> (Updated jún. 11, 2016, 6:43 de)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Nettleton, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17053
> https://issues.apache.org/jira/browse/AMBARI-17053
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a log message to see when the cluster is ready to use (cluster creation 
> finishes).
> 
> An event after each heartbeat. At that time cluster provision request is 
> checked if it is finished or not. In case of an ambari server restart, the 
> replayed requests are used to determine which one was the provision request. 
> I could not find a nice way to do it, but I could make a workaround.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  c6036c2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 1079806 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/HeartbeatProcessingFinishedEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedState.java
>  77419d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
>  324a397 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  e3f5b49 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  fd8653c 
> 
> Diff: https://reviews.apache.org/r/48266/diff/
> 
> 
> Testing
> ---
> 
> Succeeded locally
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

[Daniel Gergely]

> On jún. 13, 2016, 9:23 du, Sumit Mohanty wrote:
> > Does this handle UI based cluster deployments?
> > Probably there is no good way for UI based deplyments to know if a specific 
> > request is a cluster create request or not.
> > 
> > What happens after cluster creation is over - does the code continue to 
> > handle Heartbeat processing completed event?
> > Would it have been possible to create an event for Request-Completed and 
> > process that rather than Heartbeat processing completed?

This issue was only about blueprint deployment. UI based deployment is not 
tracked.
If cluster creation is completed, event is still kept sending, however the 
subscribed method does nothing in this case. So it does not affect performance 
or does unnecessary calculations.
I did not think about tracking request completition, because I felt that the 
minimum number of checks can be achieved by tracking only heartbeats.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48266/#review137384
---


On jún. 11, 2016, 6:43 de, Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48266/
> ---
> 
> (Updated jún. 11, 2016, 6:43 de)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Nettleton, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17053
> https://issues.apache.org/jira/browse/AMBARI-17053
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a log message to see when the cluster is ready to use (cluster creation 
> finishes).
> 
> An event after each heartbeat. At that time cluster provision request is 
> checked if it is finished or not. In case of an ambari server restart, the 
> replayed requests are used to determine which one was the provision request. 
> I could not find a nice way to do it, but I could make a workaround.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  c6036c2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 1079806 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/HeartbeatProcessingFinishedEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedState.java
>  77419d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
>  324a397 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  e3f5b49 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  fd8653c 
> 
> Diff: https://reviews.apache.org/r/48266/diff/
> 
> 
> Testing
> ---
> 
> Succeeded locally
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 48490: Last button in the log search pagination panel does not take the user to the last page and few more fixes

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48490/#review137465
---




ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java
 (line 98)


Boolean.parseBoolean never returns null, the return value is false if the 
input is null.



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
 (line 132)


Boolean.parseBoolean never returns null, the return value is false if the 
input is null.



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VUserConfig.java
 (line 35)


Why not using camel case for filter name?


- Miklos Gergely


On June 13, 2016, 6:36 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48490/
> ---
> 
> (Updated June 13, 2016, 6:36 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17140
> https://issues.apache.org/jira/browse/AMBARI-17140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains
> 1) Last button in the log search pagination panel does not take the user to 
> the last page.
> 2) Solr warming feature added.
> 3) Suffix in columns mapping issue fixed.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  917956f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  147e148 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java
>  53e386e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
>  ca63671 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/MgrBase.java
>  1d069d3 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
>  3b23f2a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGeneration.java
>  4647c7b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditREST.java
>  92bfb01 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/DashboardREST.java
>  1e107ed 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/ConfigUtil.java
>  44d184d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VUserConfig.java
>  55ec1c0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/default.properties
>  25b4f1a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/META-INF/applicationContext.xml
>  6a73d60 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collections/BaseCollection.js
>  24b6974 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Intro.js
>  869a1d4 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/audit/AuditTabLayoutView.js
>  5f93c5a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dialog/ApplySearchFilterView.js
>  4babebc 
> 
> Diff: https://reviews.apache.org/r/48490/diff/
> 
> 
> Testing
> ---
> 
> Setup Logsearch on 2 node cluster and tested the above feature.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 48655: ATLAS conf dir needs to be present in all ATLAS hook deployed hosts

[Tom Beerbower]

> On June 13, 2016, 8:29 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml,
> >  line 238
> > 
> >
> > Does this need to change for existing clusters?
> > What about the different stacks?
> > I don't believe ATLAS is even available on HDP 2.2

This export was added earlier for HDP 2.5 so it should not be present in any 
existing clusters.


- Tom


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48655/#review137373
---


On June 13, 2016, 5:51 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48655/
> ---
> 
> (Updated June 13, 2016, 5:51 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Nate Cole.
> 
> 
> Bugs: AMBARI-17203
> https://issues.apache.org/jira/browse/AMBARI-17203
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Atlas atlas-application.properties configuration is required by the Atlas 
> hooks (Falcon, Storm, Sqoop and Hive).
> Currently the atlas configuration is not being pushed to all the hook hosts 
> which could lead to issues if any config is changed. The Atlas configuration 
> changes needs to be pushed to all dependent hosts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  441f0da 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
>  67077c4 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  c20523d 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  fea0635 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_atlas_hive.py
>  e78190f 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
>  c154a16 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/setup_atlas_sqoop.py
>  d18d820 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  eadbd4a 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_atlas_storm.py
>  6c3e91f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/metainfo.xml 
> 1998131 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml 
> ac1f9e7 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SQOOP/metainfo.xml 
> eb67d63 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/metainfo.xml 
> 3faadc0 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 1bcc09e 
> 
> Diff: https://reviews.apache.org/r/48655/diff/
> 
> 
> Testing
> ---
> 
> Manual test deploy Atlas with all hook integration services on multi-host 
> cluster.  Verify Atlas configuration locations.  Update Atlas configuration.  
> Verify dependant service restart suggestion from Ambari.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 48557: Fixed implementation of on-ambari-upgrade support. Patch 2: add logic for ambari-upgrade

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48557/
---

(Updated June 14, 2016, 12:07 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jonathan 
Hurley, Nate Cole, and Sumit Mohanty.


Changes
---

Fixed Jonathan comment, merged with latest trunk


Bugs: AMBARI-17112
https://issues.apache.org/jira/browse/AMBARI-17112


Repository: ambari


Description
---

Patch implements logic for on-ambari-upgrade attributes: add, update, delete


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationModule.java
 de5147d 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
c570ab3 
  
ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
 f6791ee 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 3ee8bba 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml
 6793e4e 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 fd68ae0 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml
 aacf10a 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml
 4e56084 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml
 7f67b8a 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml
 274163e 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
 b0f36e7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml
 444b8b4 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
 cfdd989 
  
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml
 7f474f6 
  
ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml
 f3a6bcf 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
 47c900e 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml
 a309fa4 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml
 2d0047c 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml
 5082277 
  
ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/admin-properties.xml
 121a797 
  
ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-env.xml
 ae56f8b 
  
ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-site.xml
 4317cfa 
  
ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/usersync-properties.xml
 7eb78e5 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-properties.xml
 a747dde 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
 2ba3794 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
 b1fc537 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml
 9870b8b 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.0/configuration/spark-defaults.xml
 633cbda 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.0/configuration/spark-thrift-sparkconf.xml
 daacdee 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-plugin-properties.xml
 21cd096 
  
ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-site.xml
 a8f1584 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-site.xml
 d7c87e9 
  
ambari-server/src/main/resources/common-services/STORM/0.9.3/configuration/ranger-storm-plugin-properties.xml
 7aa18cc 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-audit.xml
 fcaecaa 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml
 85a1eba 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/capacity-scheduler.xml
 b4fedd8 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml
 b1b30aa 
  ambari-server/src/main/resources/configuration-schema.xsd 6716dd5 
  
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
 8dc02c5 
  
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml
 7e746c0 
  
ambari-server/src/

Re: Review Request 48557: Fixed implementation of on-ambari-upgrade support. Patch 2: add logic for ambari-upgrade

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48557/#review137472
---


Ship it!




Ship It!

- Andrew Onischuk


On June 14, 2016, 9:07 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48557/
> ---
> 
> (Updated June 14, 2016, 9:07 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jonathan 
> Hurley, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17112
> https://issues.apache.org/jira/browse/AMBARI-17112
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch implements logic for on-ambari-upgrade attributes: add, update, delete
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationModule.java
>  de5147d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> c570ab3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
>  f6791ee 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  3ee8bba 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml
>  6793e4e 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  fd68ae0 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml
>  aacf10a 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml
>  4e56084 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml
>  7f67b8a 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml
>  274163e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
>  b0f36e7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml
>  444b8b4 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml
>  cfdd989 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml
>  7f474f6 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml
>  f3a6bcf 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml
>  47c900e 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml
>  a309fa4 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml
>  2d0047c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml
>  5082277 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/admin-properties.xml
>  121a797 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-env.xml
>  ae56f8b 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-site.xml
>  4317cfa 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/usersync-properties.xml
>  7eb78e5 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-properties.xml
>  a747dde 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  2ba3794 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml
>  b1fc537 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml
>  9870b8b 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.0/configuration/spark-defaults.xml
>  633cbda 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.0/configuration/spark-thrift-sparkconf.xml
>  daacdee 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-plugin-properties.xml
>  21cd096 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-site.xml
>  a8f1584 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-site.xml
>  d7c87e9 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.3/configuration/ranger-storm-plugin-properties.xml
>  7aa18cc 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-audit.xml
>  fcaecaa 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml
>  85a1eb

Re: Review Request 48480: View Config- views created for 2nd remote cluster points to 1st remote cluster

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48480/#review137475
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On June 9, 2016, 8:43 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48480/
> ---
> 
> (Updated June 9, 2016, 8:43 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17139
> https://issues.apache.org/jira/browse/AMBARI-17139
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change the remoteClusterMap to clusterId from remote ambari cluster name.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java
>  c0c887f 
> 
> Diff: https://reviews.apache.org/r/48480/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 48545: View config- Allows remote cluster creation using a user having no permissions on the cluster

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48545/#review137476
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On June 10, 2016, 12:15 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48545/
> ---
> 
> (Updated June 10, 2016, 12:15 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17162
> https://issues.apache.org/jira/browse/AMBARI-17162
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added permission check for user (ambari/cluster admin) before save/update of 
> remote cluster.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
>  1135424 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java
>  c0c887f 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 90144e2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java
>  2b6e014 
> 
> Diff: https://reviews.apache.org/r/48545/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Review Request 48681: Ambari views logs should be more verbose and should include info/error/debug logs at appropriate places

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48681/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-17214
https://issues.apache.org/jira/browse/AMBARI-17214


Repository: ambari


Description
---

Added logs at various places.


Diffs
-

  
contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
 2198331 
  
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java
 4b8a546 
  
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FilePreviewService.java
 3585516 
  
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/PropertyValidator.java
 2ad779c 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/backgroundjobs/BackgroundJobController.java
 2f5c76c 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalConnection.java
 a86c84f 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/PropertyValidator.java
 cd54690 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java
 40bc9a7 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobService.java
 9ecbd75 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/models/PigJob.java
 6f80d6b 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/scripts/ScriptService.java
 46e6247 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/JSONRequest.java
 39a595b 
  
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/TempletonApi.java
 66568d7 

Diff: https://reviews.apache.org/r/48681/diff/


Testing
---

Manual testing done.


Thanks,

Nitiraj Rathore

Re: Review Request 48460: Ambari Views logs should include information of view instance

[Nitiraj Rathore]

> On June 9, 2016, 12:09 p.m., DIPAYAN BHOWMICK wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  line 773
> > 
> >
> > Why is this changed. Seems like a rebase issue.

probably happend due to code formating. reverted the change.


- Nitiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48460/#review136793
---


On June 9, 2016, 12:38 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48460/
> ---
> 
> (Updated June 9, 2016, 12:38 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17135
> https://issues.apache.org/jira/browse/AMBARI-17135
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added servlet filter and used Logging frameworks MDC feature to insert view 
> related information from URL. Updated view log4j files for the same.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  961b6fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/AmbariViewsMDCLoggingFilter.java
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
> 32903d3 
>   contrib/views/files/src/main/resources/view.log4j.properties 698947e 
>   contrib/views/hive-next/src/main/resources/view.log4j.properties b1bd5f2 
>   contrib/views/hive/src/main/resources/view.log4j.properties 16c2d0e 
>   contrib/views/hueambarimigration/src/main/resources/view.log4j.properties 
> 3e959e7 
>   contrib/views/jobs/src/main/resources/view.log4j.properties 86687d6 
>   contrib/views/pig/src/main/resources/view.log4j.properties 5b23a48 
>   contrib/views/slider/src/main/resources/view.log4j.properties 4737032 
>   contrib/views/storm/src/main/resources/view.log4j.properties 309df8d 
>   contrib/views/tez/src/main/resources/view.log4j.properties 08e00bd 
>   contrib/views/zeppelin/src/main/resources/view.log4j.properties 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48460/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48266/#review137477
---



Hi Bob, Summit!

Using events instead of polling continusly seems to be a better solution, may 
be would be better to listen to already existing events like 
ActionFinalReportReceivedEvent which is fired when a command reaches it's final 
state. Probaly even better would be to fire a new event like RequestCompleted 
in ActionDBAccessorImpl.endRequestIfCompleted(). Later we may use this event to 
not just log the end cluster deployment but to actually set a final status on 
LogicalReuqest in db to avoid calculation of requestr status all the time.

- Sandor Magyari


On June 11, 2016, 6:43 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48266/
> ---
> 
> (Updated June 11, 2016, 6:43 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Nettleton, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17053
> https://issues.apache.org/jira/browse/AMBARI-17053
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a log message to see when the cluster is ready to use (cluster creation 
> finishes).
> 
> An event after each heartbeat. At that time cluster provision request is 
> checked if it is finished or not. In case of an ambari server restart, the 
> replayed requests are used to determine which one was the provision request. 
> I could not find a nice way to do it, but I could make a workaround.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  c6036c2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 1079806 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/HeartbeatProcessingFinishedEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedState.java
>  77419d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
>  324a397 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  e3f5b49 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  fd8653c 
> 
> Diff: https://reviews.apache.org/r/48266/diff/
> 
> 
> Testing
> ---
> 
> Succeeded locally
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 48654: Upgrading Ambari Causes Alert Fields Not To Save Thresholds

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48654/
---

(Updated Червень 14, 2016, 10:41 до полудня)


Review request for Ambari, Dmytro Sen and Jonathan Hurley.


Bugs: AMBARI-17202
https://issues.apache.org/jira/browse/AMBARI-17202


Repository: ambari


Description
---

When upgrading from earlier versions of Ambari, the alert definitions do not 
include some of the new parameters / connection timeout values which were added 
to the alert definitions. This is normally OK since the alert framework has 
sensible defaults of the values are not specified.
However, it was observed on Ambari 2.2.2 that the web client wasn't able to 
properly render/save the values.
STR:
Install Ambari 2.2.0
Upgrade to Ambari 2.2.2
You should now have alert definitions, such as DataNode Web UI, which do not 
have a connection_timeout value.
Navigate to the DataNode Web UI alert definition page and notice that you are 
not able to update and save the "Connection Timeout" property correctly.
Attachments


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java 
c269927 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 f185346 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 7451bbe 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
 e5bb7ca 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 c221138 
  ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json 
9d9f2df 

Diff: https://reviews.apache.org/r/48654/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 48654: Upgrading Ambari Causes Alert Fields Not To Save Thresholds

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48654/#review137478
---


Ship it!




Ship It!

- Dmytro Sen


On Июнь 14, 2016, 10:41 д.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48654/
> ---
> 
> (Updated Июнь 14, 2016, 10:41 д.п.)
> 
> 
> Review request for Ambari, Dmytro Sen and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17202
> https://issues.apache.org/jira/browse/AMBARI-17202
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When upgrading from earlier versions of Ambari, the alert definitions do not 
> include some of the new parameters / connection timeout values which were 
> added to the alert definitions. This is normally OK since the alert framework 
> has sensible defaults of the values are not specified.
> However, it was observed on Ambari 2.2.2 that the web client wasn't able to 
> properly render/save the values.
> STR:
> Install Ambari 2.2.0
> Upgrade to Ambari 2.2.2
> You should now have alert definitions, such as DataNode Web UI, which do not 
> have a connection_timeout value.
> Navigate to the DataNode Web UI alert definition page and notice that you are 
> not able to update and save the "Connection Timeout" property correctly.
> Attachments
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
>  c269927 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  f185346 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  7451bbe 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  e5bb7ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  c221138 
>   ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/alerts.json 
> 9d9f2df 
> 
> Diff: https://reviews.apache.org/r/48654/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 48682: AMBARI-17215: Zeppelin Hive configuration change to JDBC

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48682/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
Luniya, Pallav Kulshreshtha, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.


Bugs: AMBARI-17215
https://issues.apache.org/jira/browse/AMBARI-17215


Repository: ambari


Description
---

Since the merge of 
https://github.com/apache/zeppelin/commit/43baa0af4958341d74014da25b6d10f176233879,
 the Hive Interpreter into JDBC Interpreter.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
 69bb187 

Diff: https://reviews.apache.org/r/48682/diff/


Testing
---

tested on VirtualBox


Thanks,

Prabhjyot Singh

Review Request 48683: One of RM failed to start after ambaru upgrade in secure cluster [Upgrade]

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48683/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17216
https://issues.apache.org/jira/browse/AMBARI-17216


Repository: ambari


Description
---

STR:

  1. Deploy HDP 2.4 on Ambari2.2.2.0
  2. Enable NN and RM HAs
  3. Enable security
  4. Perform ambari upgrade to 2.4.0

Cluster: 172.22.93.94:8080 - os-r6-kdfyi-nat-s-ru242to25rhel6secha - 48h




Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
 line 287, in 
Resourcemanager().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 257, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
 line 124, in start
self.wait_for_dfs_directories_created(params.entity_groupfs_store_dir, 
params.entity_groupfs_active_dir)
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
 line 244, in wait_for_dfs_directories_created
self.wait_for_dfs_directory_created(dir_path, ignored_dfs_dirs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/decorator.py",
 line 55, in wrapper
return function(*args, **kwargs)
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
 line 266, in wait_for_dfs_directory_created
list_status = util.run_command(dir_path, 'GETFILESTATUS', method='GET', 
ignore_status_codes=['404'], assertable_result=False)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 191, in run_command
raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'curl -sS -L -w 
'%{http_code}' -X GET --negotiate -u : 
'http://os-r6-kdfyi-nat-s-ru242to25rhel6secha-12.openstacklocal:50070/webhdfs/v1/ats/done/?op=GETFILESTATUS&user.name=hdfs''
 returned status_code=401. 



Error 401 Authentication required

HTTP ERROR 401
Problem accessing /webhdfs/v1/ats/done/. Reason:
Authentication requiredPowered by 
Jetty://


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 0b80dc6 

Diff: https://reviews.apache.org/r/48683/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48682: AMBARI-17215: Zeppelin Hive configuration change to JDBC

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48682/
---

(Updated June 14, 2016, 10:49 a.m.)


Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
Luniya, Pallav Kulshreshtha, Rohit Choudhary, Renjith Kamath, and Sumit Mohanty.


Bugs: AMBARI-17215
https://issues.apache.org/jira/browse/AMBARI-17215


Repository: ambari


Description (updated)
---

Since the merge of 
https://github.com/apache/zeppelin/commit/43baa0af4958341d74014da25b6d10f176233879,
 the Hive Interpreter is merged into JDBC Interpreter, hence a change is 
required in `zeppelin-config.xml` to incorporate the same.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
 69bb187 

Diff: https://reviews.apache.org/r/48682/diff/


Testing
---

tested on VirtualBox


Thanks,

Prabhjyot Singh

Re: Review Request 48683: One of RM failed to start after ambaru upgrade in secure cluster [Upgrade]

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48683/
---

(Updated June 14, 2016, 10:49 a.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17216
https://issues.apache.org/jira/browse/AMBARI-17216


Repository: ambari


Description (updated)
---

STR:

  1. Deploy HDP 2.4 on Ambari2.2.2.0
  2. Enable NN and RM HAs
  3. Enable security
  4. Perform ambari upgrade to 2.4.0

Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
 line 287, in 
Resourcemanager().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 257, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
 line 124, in start
self.wait_for_dfs_directories_created(params.entity_groupfs_store_dir, 
params.entity_groupfs_active_dir)
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
 line 244, in wait_for_dfs_directories_created
self.wait_for_dfs_directory_created(dir_path, ignored_dfs_dirs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/decorator.py",
 line 55, in wrapper
return function(*args, **kwargs)
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
 line 266, in wait_for_dfs_directory_created
list_status = util.run_command(dir_path, 'GETFILESTATUS', method='GET', 
ignore_status_codes=['404'], assertable_result=False)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 191, in run_command
raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'curl -sS -L -w 
'%{http_code}' -X GET --negotiate -u : 
'http://os-r6-kdfyi-nat-s-ru242to25rhel6secha-12.openstacklocal:50070/webhdfs/v1/ats/done/?op=GETFILESTATUS&user.name=hdfs''
 returned status_code=401. 



Error 401 Authentication required

HTTP ERROR 401
Problem accessing /webhdfs/v1/ats/done/. Reason:
Authentication requiredPowered by 
Jetty://


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 0b80dc6 

Diff: https://reviews.apache.org/r/48683/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48683: One of RM failed to start after ambaru upgrade in secure cluster [Upgrade]

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48683/#review137479
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On June 14, 2016, 1:49 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48683/
> ---
> 
> (Updated June 14, 2016, 1:49 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-17216
> https://issues.apache.org/jira/browse/AMBARI-17216
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
>   1. Deploy HDP 2.4 on Ambari2.2.2.0
>   2. Enable NN and RM HAs
>   3. Enable security
>   4. Perform ambari upgrade to 2.4.0
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
>  line 287, in 
> Resourcemanager().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 257, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
>  line 124, in start
> 
> self.wait_for_dfs_directories_created(params.entity_groupfs_store_dir, 
> params.entity_groupfs_active_dir)
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
>  line 244, in wait_for_dfs_directories_created
> self.wait_for_dfs_directory_created(dir_path, ignored_dfs_dirs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/decorator.py",
>  line 55, in wrapper
> return function(*args, **kwargs)
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
>  line 266, in wait_for_dfs_directory_created
> list_status = util.run_command(dir_path, 'GETFILESTATUS', 
> method='GET', ignore_status_codes=['404'], assertable_result=False)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 191, in run_command
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'curl -sS -L -w 
> '%{http_code}' -X GET --negotiate -u : 
> 'http://os-r6-kdfyi-nat-s-ru242to25rhel6secha-12.openstacklocal:50070/webhdfs/v1/ats/done/?op=GETFILESTATUS&user.name=hdfs''
>  returned status_code=401. 
> 
> 
> 
> Error 401 Authentication required
> 
> HTTP ERROR 401
> Problem accessing /webhdfs/v1/ats/done/. Reason:
> Authentication requiredPowered by 
> Jetty://
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  0b80dc6 
> 
> Diff: https://reviews.apache.org/r/48683/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 48490: Last button in the log search pagination panel does not take the user to the last page and few more fixes

[Dharmesh Makwana]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48490/
---

(Updated June 14, 2016, 10:54 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
Mohanty, and Sebastian Toader.


Changes
---

removed null check.


Bugs: AMBARI-17140
https://issues.apache.org/jira/browse/AMBARI-17140


Repository: ambari


Description
---

Patch contains
1) Last button in the log search pagination panel does not take the user to the 
last page.
2) Solr warming feature added.
3) Suffix in columns mapping issue fixed.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
 917956f 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 147e148 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java
 53e386e 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
 ca63671 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/MgrBase.java
 1d069d3 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
 3b23f2a 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGeneration.java
 4647c7b 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditREST.java
 92bfb01 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/DashboardREST.java
 1e107ed 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/ConfigUtil.java
 44d184d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VUserConfig.java
 55ec1c0 
  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/default.properties 
25b4f1a 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/META-INF/applicationContext.xml
 6a73d60 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collections/BaseCollection.js
 24b6974 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Intro.js 
869a1d4 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/audit/AuditTabLayoutView.js
 5f93c5a 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dialog/ApplySearchFilterView.js
 4babebc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/EventHistoryLayoutView.js
 0f0ce58 

Diff: https://reviews.apache.org/r/48490/diff/


Testing
---

Setup Logsearch on 2 node cluster and tested the above feature.


Thanks,

Dharmesh Makwana

Re: Review Request 48490: Last button in the log search pagination panel does not take the user to the last page and few more fixes

[Dharmesh Makwana]

> On June 14, 2016, 8:18 a.m., Miklos Gergely wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VUserConfig.java,
> >  line 35
> > 
> >
> > Why not using camel case for filter name?

wanted to be consistent with solr field name.


- Dharmesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48490/#review137465
---


On June 14, 2016, 10:54 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48490/
> ---
> 
> (Updated June 14, 2016, 10:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17140
> https://issues.apache.org/jira/browse/AMBARI-17140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains
> 1) Last button in the log search pagination panel does not take the user to 
> the last page.
> 2) Solr warming feature added.
> 3) Suffix in columns mapping issue fixed.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  917956f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  147e148 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java
>  53e386e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
>  ca63671 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/MgrBase.java
>  1d069d3 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
>  3b23f2a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGeneration.java
>  4647c7b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditREST.java
>  92bfb01 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/DashboardREST.java
>  1e107ed 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/ConfigUtil.java
>  44d184d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VUserConfig.java
>  55ec1c0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/default.properties
>  25b4f1a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/META-INF/applicationContext.xml
>  6a73d60 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collections/BaseCollection.js
>  24b6974 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Intro.js
>  869a1d4 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/audit/AuditTabLayoutView.js
>  5f93c5a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dialog/ApplySearchFilterView.js
>  4babebc 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/EventHistoryLayoutView.js
>  0f0ce58 
> 
> Diff: https://reviews.apache.org/r/48490/diff/
> 
> 
> Testing
> ---
> 
> Setup Logsearch on 2 node cluster and tested the above feature.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 48683: One of RM failed to start after ambaru upgrade in secure cluster [Upgrade]

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48683/
---

(Updated June 14, 2016, 10:59 a.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-17216
https://issues.apache.org/jira/browse/AMBARI-17216


Repository: ambari


Description
---

STR:

  1. Deploy HDP 2.4 on Ambari2.2.2.0
  2. Enable NN and RM HAs
  3. Enable security
  4. Perform ambari upgrade to 2.4.0

Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
 line 287, in 
Resourcemanager().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 257, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
 line 124, in start
self.wait_for_dfs_directories_created(params.entity_groupfs_store_dir, 
params.entity_groupfs_active_dir)
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
 line 244, in wait_for_dfs_directories_created
self.wait_for_dfs_directory_created(dir_path, ignored_dfs_dirs)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/decorator.py",
 line 55, in wrapper
return function(*args, **kwargs)
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
 line 266, in wait_for_dfs_directory_created
list_status = util.run_command(dir_path, 'GETFILESTATUS', method='GET', 
ignore_status_codes=['404'], assertable_result=False)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
 line 191, in run_command
raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'curl -sS -L -w 
'%{http_code}' -X GET --negotiate -u : 
'http://os-r6-kdfyi-nat-s-ru242to25rhel6secha-12.openstacklocal:50070/webhdfs/v1/ats/done/?op=GETFILESTATUS&user.name=hdfs''
 returned status_code=401. 



Error 401 Authentication required

HTTP ERROR 401
Problem accessing /webhdfs/v1/ats/done/. Reason:
Authentication requiredPowered by 
Jetty://


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 0b80dc6 

Diff: https://reviews.apache.org/r/48683/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48683: One of RM failed to start after ambaru upgrade in secure cluster [Upgrade]

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48683/#review137482
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On June 14, 2016, 1:59 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48683/
> ---
> 
> (Updated June 14, 2016, 1:59 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-17216
> https://issues.apache.org/jira/browse/AMBARI-17216
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
>   1. Deploy HDP 2.4 on Ambari2.2.2.0
>   2. Enable NN and RM HAs
>   3. Enable security
>   4. Perform ambari upgrade to 2.4.0
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
>  line 287, in 
> Resourcemanager().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 257, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
>  line 124, in start
> 
> self.wait_for_dfs_directories_created(params.entity_groupfs_store_dir, 
> params.entity_groupfs_active_dir)
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
>  line 244, in wait_for_dfs_directories_created
> self.wait_for_dfs_directory_created(dir_path, ignored_dfs_dirs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/decorator.py",
>  line 55, in wrapper
> return function(*args, **kwargs)
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
>  line 266, in wait_for_dfs_directory_created
> list_status = util.run_command(dir_path, 'GETFILESTATUS', 
> method='GET', ignore_status_codes=['404'], assertable_result=False)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 191, in run_command
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'curl -sS -L -w 
> '%{http_code}' -X GET --negotiate -u : 
> 'http://os-r6-kdfyi-nat-s-ru242to25rhel6secha-12.openstacklocal:50070/webhdfs/v1/ats/done/?op=GETFILESTATUS&user.name=hdfs''
>  returned status_code=401. 
> 
> 
> 
> Error 401 Authentication required
> 
> HTTP ERROR 401
> Problem accessing /webhdfs/v1/ats/done/. Reason:
> Authentication requiredPowered by 
> Jetty://
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  0b80dc6 
> 
> Diff: https://reviews.apache.org/r/48683/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 48460: Ambari Views logs should include information of view instance

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48460/#review137485
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On June 9, 2016, 12:38 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48460/
> ---
> 
> (Updated June 9, 2016, 12:38 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17135
> https://issues.apache.org/jira/browse/AMBARI-17135
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added servlet filter and used Logging frameworks MDC feature to insert view 
> related information from URL. Updated view log4j files for the same.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  961b6fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/AmbariViewsMDCLoggingFilter.java
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
> 32903d3 
>   contrib/views/files/src/main/resources/view.log4j.properties 698947e 
>   contrib/views/hive-next/src/main/resources/view.log4j.properties b1bd5f2 
>   contrib/views/hive/src/main/resources/view.log4j.properties 16c2d0e 
>   contrib/views/hueambarimigration/src/main/resources/view.log4j.properties 
> 3e959e7 
>   contrib/views/jobs/src/main/resources/view.log4j.properties 86687d6 
>   contrib/views/pig/src/main/resources/view.log4j.properties 5b23a48 
>   contrib/views/slider/src/main/resources/view.log4j.properties 4737032 
>   contrib/views/storm/src/main/resources/view.log4j.properties 309df8d 
>   contrib/views/tez/src/main/resources/view.log4j.properties 08e00bd 
>   contrib/views/zeppelin/src/main/resources/view.log4j.properties 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48460/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 48682: AMBARI-17215: Zeppelin Hive configuration change to JDBC

[Renjith Kamath]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48682/#review137486
---


Ship it!




Ship It!

- Renjith Kamath


On June 14, 2016, 10:49 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48682/
> ---
> 
> (Updated June 14, 2016, 10:49 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Pallav Kulshreshtha, Rohit Choudhary, Renjith Kamath, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17215
> https://issues.apache.org/jira/browse/AMBARI-17215
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Since the merge of 
> https://github.com/apache/zeppelin/commit/43baa0af4958341d74014da25b6d10f176233879,
>  the Hive Interpreter is merged into JDBC Interpreter, hence a change is 
> required in `zeppelin-config.xml` to incorporate the same.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  69bb187 
> 
> Diff: https://reviews.apache.org/r/48682/diff/
> 
> 
> Testing
> ---
> 
> tested on VirtualBox
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 48490: Last button in the log search pagination panel does not take the user to the last page and few more fixes

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48490/#review137489
---


Ship it!




Ship It!

- Miklos Gergely


On June 14, 2016, 10:54 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48490/
> ---
> 
> (Updated June 14, 2016, 10:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17140
> https://issues.apache.org/jira/browse/AMBARI-17140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains
> 1) Last button in the log search pagination panel does not take the user to 
> the last page.
> 2) Solr warming feature added.
> 3) Suffix in columns mapping issue fixed.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  917956f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  147e148 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java
>  53e386e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
>  ca63671 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/MgrBase.java
>  1d069d3 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
>  3b23f2a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGeneration.java
>  4647c7b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditREST.java
>  92bfb01 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/DashboardREST.java
>  1e107ed 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/ConfigUtil.java
>  44d184d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VUserConfig.java
>  55ec1c0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/default.properties
>  25b4f1a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/META-INF/applicationContext.xml
>  6a73d60 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collections/BaseCollection.js
>  24b6974 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Intro.js
>  869a1d4 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/audit/AuditTabLayoutView.js
>  5f93c5a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dialog/ApplySearchFilterView.js
>  4babebc 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/EventHistoryLayoutView.js
>  0f0ce58 
> 
> Diff: https://reviews.apache.org/r/48490/diff/
> 
> 
> Testing
> ---
> 
> Setup Logsearch on 2 node cluster and tested the above feature.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Review Request 48685: AMBARI-17218 Show message of Audit to DB Removal during upgrade for Ranger

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48685/
---

Review request for Ambari, Gautam Borad, Jonathan Hurley, Srimanth Gunturi, and 
Velmurugan Periasamy.


Bugs: AMBARI-17218
https://issues.apache.org/jira/browse/AMBARI-17218


Repository: ambari


Description
---

Show Warning message before upgrade to stack 2.5


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 850b58a 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 464c444 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
dd04b64 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 27461e8 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
ad1bc34 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/RangerAuditDbCheckTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/48685/diff/


Testing
---

Tested upgrade from 2.4 to 2.5


---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.checks.RangerAuditDbCheckTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.743 sec - in 
org.apache.ambari.server.checks.RangerAuditDbCheckTest

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Mugdha Varadkar

Review Request 48686: Tez View: Improve proxy logging

[Sreenath Somarajapuram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48686/
---

Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.


Bugs: AMBARI-17186
https://issues.apache.org/jira/browse/AMBARI-17186


Repository: ambari


Description
---

More log messages would help us to debug EARs faster.


Diffs
-

  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
 981353b 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/YARNProtocolFetchException.java
 PRE-CREATION 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseProxyResource.java
 619f81e 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseRedirectionResource.java
 97ee01d 

Diff: https://reviews.apache.org/r/48686/diff/


Testing
---

Manual testing.
Verified the presence of debug and error logs in 
/var/log/ambari-server/tez-view/tez-view.log


Thanks,

Sreenath Somarajapuram

Re: Review Request 48589: Fix HA enabled logic in the alerts

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48589/#review137494
---



I don't think we need to special case this. Consider the alert definitions for 
HDFS and YARN:

{code:title=HDFS}
"high_availability": {
  "nameservice": "{{hdfs-site/dfs.internal.nameservices}}",
  "alias_key" : "{{hdfs-site/dfs.ha.namenodes.{{ha-nameservice",
  "http_pattern" : 
"{{hdfs-site/dfs.namenode.http-address.{{ha-nameservice}}.{{alias",
  "https_pattern" : 
"{{hdfs-site/dfs.namenode.https-address.{{ha-nameservice}}.{{alias"
}
{code}

{code:title=YARN}
"high_availability": {
  "alias_key" : "{{yarn-site/yarn.resourcemanager.ha.rm-ids}}",
  "http_pattern" : 
"{{yarn-site/yarn.resourcemanager.webapp.address.{{alias",
  "https_pattern" : 
"{{yarn-site/yarn.resourcemanager.webapp.https.address.{{alias"
}
{code}

HDFS has a {{nameservice}} key as part of the URI and YARN does not. That's the 
way we can tell what to do:

- If {{nameservice}} is defined as a key on the definition _and_ it exists in 
the configuration ({{hdfs-site}} for example) then {{alias_key}} must resolve
- If {{nameservice}} is *NOT* defined on the definition, then only use HA if 
{{alias_key}} resolves.


ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py (lines 397 - 400)


I think this will be the first time that we've ever special-cased anything 
in the alerts framework. There has to be a better way. If you want to check for 
a specific property, then we should extend the alert definition's `uri` element 
to indicate that there is a value which can be checked for HA mode.


- Jonathan Hurley


On June 13, 2016, 10:21 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48589/
> ---
> 
> (Updated June 13, 2016, 10:21 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17180
> https://issues.apache.org/jira/browse/AMBARI-17180
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> base_alert.py puts a warning into the log if there are properties referenced 
> in the HA nameservice or the alias which are not present in the 
> configuration. The absence of these properties is an indicator that the HA is 
> not enabled, it is not a cause for warning.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 6c8ca5a 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py e114daa 
> 
> Diff: https://reviews.apache.org/r/48589/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster works fine. Unit tests are running fine too.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 48685: AMBARI-17218 Show message of Audit to DB Removal during upgrade for Ranger

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48685/#review137496
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 (line 279)


This is a bit confusing. Maybe revise as "Remove the Ranger Audit to 
Database Capability"



ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 (lines 282 - 283)


Hmmm - we're giving instructions here that the admin must run something 
after upgrade. Typically, that's not going to happen and they'll forget. What 
are the consequences? Can this be done by the python code?



ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java
 (line 35)


Maybe make a new UpgradeCheckGroup for this - it's an information warning 
that something is happening during the upgrade. We might want to begin 
organizing these types of messages. Maybe 
UpgradeCheckGroup.INFORMATIONAL_WARNING


- Jonathan Hurley


On June 14, 2016, 8:26 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48685/
> ---
> 
> (Updated June 14, 2016, 8:26 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Srimanth Gunturi, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17218
> https://issues.apache.org/jira/browse/AMBARI-17218
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Show Warning message before upgrade to stack 2.5
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  850b58a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  464c444 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> dd04b64 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  27461e8 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> ad1bc34 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/RangerAuditDbCheckTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48685/diff/
> 
> 
> Testing
> ---
> 
> Tested upgrade from 2.4 to 2.5
> 
> 
> ---
>  T E S T S
> ---
> Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m 
> -Djava.awt.headless=true
> Running org.apache.ambari.server.checks.RangerAuditDbCheckTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.743 sec - 
> in org.apache.ambari.server.checks.RangerAuditDbCheckTest
> 
> Results :
> 
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48516: SPNEGO keytab and principal configuration for HBase web UIs

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48516/#review137497
---



What is the status of this review?

- Nate Cole


On June 9, 2016, 7 p.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48516/
> ---
> 
> (Updated June 9, 2016, 7 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-17129
> https://issues.apache.org/jira/browse/AMBARI-17129
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adds the SPNEGO principal and keytab to hbase-site.xml to make it simple for 
> users to enable SPNEGO authentication for HBase web UIs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  5016325 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/alerts.json 
> 50a7ceb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 8be8bda 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  c221138 
> 
> Diff: https://reviews.apache.org/r/48516/diff/
> 
> 
> Testing
> ---
> 
> Java unit tests and a simple virtual-machine installation of 2.4.0. Verified 
> that expected configuration properties are present.
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Re: Review Request 48629: AMBARI-17189 : Change in Atlas authorization from class based to value based

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48629/#review137500
---


Ship it!




Ship It!

- Jonathan Hurley


On June 13, 2016, 6:47 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48629/
> ---
> 
> (Updated June 13, 2016, 6:47 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Madhan 
> Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17189
> https://issues.apache.org/jira/browse/AMBARI-17189
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Need to update values of atlas.authorizer.impl from ::
>   atlas.authorizer.impl = org.apache.atlas.authorize.SimpleAtlasAuthorizer 
> (Simple Authorization)
>   atlas.authorizer.impl = 
> org.apache.ranger.authorization.atlas.authorizer.RangerAtlasAuthorizer 
> (Ranger Authorization)
>   
> To 
>   
>   atlas.authorizer.impl = simple (Simple Authorization)
>   atlas.authorizer.impl = ranger (Ranger Authorization)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 53cdcfe 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 4e6dcda 
> 
> Diff: https://reviews.apache.org/r/48629/diff/
> 
> 
> Testing
> ---
> 
> Verified enable / disable of Ranger Atlas Plugin.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48494/
---

(Updated Июнь 14, 2016, 1:45 п.п.)


Review request for Ambari, Robert Nettleton, Sebastian Toader, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-17146
https://issues.apache.org/jira/browse/AMBARI-17146


Repository: ambari


Description
---

Implement config values trimming for deployment via blueprint as we do in UI

  trimProperty: function (property) {
var displayType = Em.get(property, 'displayType');
var value = Em.get(property, 'value');
var name = Em.get(property, 'name');
var rez;
switch (displayType) {
  case 'directories':
  case 'directory':
rez = value.replace(/,/g, ' ').trim().split(/\s+/g).join(',');
break;
  case 'host':
rez = value.trim();
break;
  case 'password':
break;
  default:
if (name == 'javax.jdo.option.ConnectionURL' || name == 
'oozie.service.JPAService.jdbc.url') {
  rez = value.trim();
}
rez = (typeof value == 'string') ? value.replace(/(\s+$)/g, '') : value;
}
return ((rez == '') || (rez == undefined)) ? value : rez;
  },


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 9094698 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultTrimmingStrategy.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DeleteSpacesAtTheEndTrimmingStrategy.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DirectoriesTrimmingStrategy.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PasswordTrimmingStrategy.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PropertyValueTrimmingStrategyDefiner.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
 ad8d4f9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TrimmingStrategy.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 cda8fb8 

Diff: https://reviews.apache.org/r/48494/diff/


Testing
---

Unit tests and manual tests passed


Thanks,

Dmytro Sen

Re: Review Request 48516: SPNEGO keytab and principal configuration for HBase web UIs

[Josh Elser]

> On June 14, 2016, 1:03 p.m., Nate Cole wrote:
> > What is the status of this review?

Hi Nate. I had made these changes preemptively -- I'm actually still waiting on 
the corresponding HBase changes to get merged in. I think it best if we wait 
for that one to get in before we make this change in Ambari. I've had a tough 
time getting reviewers this time over in HBase-land for whatever reason. I'll 
send a note here once I get that squared away.

Thanks for checking.


- Josh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48516/#review137497
---


On June 9, 2016, 11 p.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48516/
> ---
> 
> (Updated June 9, 2016, 11 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-17129
> https://issues.apache.org/jira/browse/AMBARI-17129
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adds the SPNEGO principal and keytab to hbase-site.xml to make it simple for 
> users to enable SPNEGO authentication for HBase web UIs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  5016325 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/alerts.json 
> 50a7ceb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 8be8bda 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  c221138 
> 
> Diff: https://reviews.apache.org/r/48516/diff/
> 
> 
> Testing
> ---
> 
> Java unit tests and a simple virtual-machine installation of 2.4.0. Verified 
> that expected configuration properties are present.
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Re: Review Request 48640: Add SERVICE.VIEW_OPERATIONAL_LOGS authorization to SERVICE.ADMINISTRATOR role and above

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48640/#review137503
---


Ship it!




Ship It!

- Eugene Chekanskiy


On June 13, 2016, 6:50 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48640/
> ---
> 
> (Updated June 13, 2016, 6:50 p.m.)
> 
> 
> Review request for Ambari, Eugene Chekanskiy, Jonathan Hurley, Nate Cole, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17177
> https://issues.apache.org/jira/browse/AMBARI-17177
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add SERVICE.VIEW_OPERATIONAL_LOGS authorization to the following roles:
> 
> * AMBARI.ADMINISTRATOR 
> * CLUSTER.ADMINISTRATOR 
> * CLUSTER.OPERATOR 
> * SERVICE.ADMINISTRATOR
> 
> This is a DB change adding an authorization record to the `roleauthorization` 
> table and relevant records for the different roles to the 
> `permission_roleauthorization` table. 
> 
> The description/name of the `SERVICE.VIEW_OPERATIONAL_LOGS` authorization 
> should be
> ```
> View service operational logs
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js 
> 33ed7ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RoleAuthorizationDAO.java
>  aa74224 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
>  ee948fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  3ee8bba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
>  6b038f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  5016325 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql fff1716 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e7eff93 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql b90c7da 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b9181d2 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> c840b9c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 742eaa3 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 87ef7fb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java
>  d7e13ea 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  c221138 
> 
> Diff: https://reviews.apache.org/r/48640/diff/
> 
> 
> Testing
> ---
> 
> Manually tested upgrade and new cluster creation
> 
> # Local test results:
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:16:17.022s
> [INFO] Finished at: Mon Jun 13 09:41:19 EDT 2016
> [INFO] Final Memory: 59M/1881M
> [INFO] 
> 
> 
> # Jenkins test results: 
> 
> Tests run: 4478, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:38 h
> [INFO] Finished at: 2016-06-13T17:03:59+00:00
> [INFO] Final Memory: 152M/527M
> [INFO] 
> 
> 
> 
> {color:green}+1 overall{color}.  Here are the results of testing the latest 
> attachment 
>   
> http://issues.apache.org/jira/secure/attachment/12809853/AMBARI-17177_trunk_01.patch
>   against trunk revision .
> 
> {color:green}+1 @author{color}.  The patch does not contain any @author 
> tags.
> 
> {color:green}+1 tests included{color}.  The patch appears to include 2 
> new or modified test files.
> 
> {color:green}+1 javac{color}.  The applied patch does not increase the 
> total number of javac compiler warnings.
> 
> {color:green}+1 release audit{color}.  The applied patch does not 
> increase the total number of release audit warnings.
> 
> {color:green}+1 core tests{color}.  The patch passed unit tests in 
> ambari-admin ambari-server.
> 
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7322//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7322//console
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 48689: Ability to add "javax.jdo.option.ConnectionPassword" to hive clients from ambari

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48689/
---

Review request for Ambari and Robert Levas.


Bugs: AMBARI-17223
https://issues.apache.org/jira/browse/AMBARI-17223


Repository: ambari


Description
---

Problem is that they need to access the "javax.jdo.option.ConnectionPassword" 
password but Ambari is pushing only to /etc/hive/conf.server/hive-site.xml. I 
have instructed and recommended various workarounds and even suggest modifying 
their app. Even having a static hive-site.xm with the information they did not 
accept and asked to open an enhancement request. The enhancement is to allow 
adding "javax.jdo.option.ConnectionPassword" to hive clients from ambari and 
have a separate hive-site.xml path for clients.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 33c0a1f 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2b7fca0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 ba93d25 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 9a86827 

Diff: https://reviews.apache.org/r/48689/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 48589: Fix HA enabled logic in the alerts

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48589/
---

(Updated June 14, 2016, 2:15 p.m.)


Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.


Bugs: AMBARI-17180
https://issues.apache.org/jira/browse/AMBARI-17180


Repository: ambari


Description
---

base_alert.py puts a warning into the log if there are properties referenced in 
the HA nameservice or the alias which are not present in the configuration. The 
absence of these properties is an indicator that the HA is not enabled, it is 
not a cause for warning.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 6c8ca5a 

Diff: https://reviews.apache.org/r/48589/diff/


Testing
---

Tested on local cluster works fine. Unit tests are running fine too.


Thanks,

Miklos Gergely

Re: Review Request 47954: AMBARI-16907 Ambari web UI does not auto-set all required properties when user toggles on the Yarn CPU isolation feature on the web UI

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47954/#review137506
---


Ship it!




Ship It!

- Andrew Onischuk


On June 13, 2016, 2:39 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47954/
> ---
> 
> (Updated June 13, 2016, 2:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jayush 
> Luniya, and Vinod Kumar Vavilapalli.
> 
> 
> Bugs: AMBARI-16907
> https://issues.apache.org/jira/browse/AMBARI-16907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The document here mentioned five properties that need to be updated when the 
> CGroups with Yarn feature is enabled via Ambari web UI. 
> http://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/NodeManagerCgroups.html
> 
> Right now, however, only one is auto-changed – 
> "yarn.nodemanager.container-executor.class".
> 
> This is due to a mix of yarn-site.xml metainfo change and the properties name 
> used in the stack_advisor.py
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
>  905383a 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 03e8150 
> 
> Diff: https://reviews.apache.org/r/47954/diff/
> 
> 
> Testing
> ---
> 
> manually patch a trunk cluster with changes and tested that with the changes, 
> all CGroup required properties are changed when I enabled CPU isolation on 
> the Yarn config tab.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 48690: org.apache.ambari.server.state.cluster.ClusterTest.testTransitionNonReportableHost fails intermittently on trunk.

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48690/
---

Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-17227
https://issues.apache.org/jira/browse/AMBARI-17227


Repository: ambari


Description
---

Error Message
expected:<1> but was:<2>
Stacktrace
java.lang.AssertionError: expected:<1> but was:<2>
at 
org.apache.ambari.server.state.cluster.ClusterTest.testTransitionNonReportableHost(ClusterTest.java:2375)


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
 9a12a1b 

Diff: https://reviews.apache.org/r/48690/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

[Daniel Gergely]

> On jún. 14, 2016, 10:28 de, Sandor Magyari wrote:
> > Hi Bob, Summit!
> > 
> > Using events instead of polling continusly seems to be a better solution, 
> > may be would be better to listen to already existing events like 
> > ActionFinalReportReceivedEvent which is fired when a command reaches it's 
> > final state. Probaly even better would be to fire a new event like 
> > RequestCompleted in ActionDBAccessorImpl.endRequestIfCompleted(). Later we 
> > may use this event to not just log the end cluster deployment but to 
> > actually set a final status on LogicalReuqest in db to avoid calculation of 
> > requestr status all the time.

We have to use endRequest method there, because abort calls it directly. 
Otherwise if everyone thinks it is a better place to post an event, I think I 
can move the logic there.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48266/#review137477
---


On jún. 11, 2016, 6:43 de, Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48266/
> ---
> 
> (Updated jún. 11, 2016, 6:43 de)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Nettleton, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17053
> https://issues.apache.org/jira/browse/AMBARI-17053
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add a log message to see when the cluster is ready to use (cluster creation 
> finishes).
> 
> An event after each heartbeat. At that time cluster provision request is 
> checked if it is finished or not. In case of an ambari server restart, the 
> replayed requests are used to determine which one was the provision request. 
> I could not find a nice way to do it, but I could make a workaround.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  c6036c2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
> 1079806 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/HeartbeatProcessingFinishedEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedState.java
>  77419d8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
>  324a397 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  e3f5b49 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  fd8653c 
> 
> Diff: https://reviews.apache.org/r/48266/diff/
> 
> 
> Testing
> ---
> 
> Succeeded locally
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 48690: org.apache.ambari.server.state.cluster.ClusterTest.testTransitionNonReportableHost fails intermittently on trunk.

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48690/#review137511
---


Ship it!




Ship It!

- Jonathan Hurley


On June 14, 2016, 10:33 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48690/
> ---
> 
> (Updated June 14, 2016, 10:33 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17227
> https://issues.apache.org/jira/browse/AMBARI-17227
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Error Message
> expected:<1> but was:<2>
> Stacktrace
> java.lang.AssertionError: expected:<1> but was:<2>
> at 
> org.apache.ambari.server.state.cluster.ClusterTest.testTransitionNonReportableHost(ClusterTest.java:2375)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
>  9a12a1b 
> 
> Diff: https://reviews.apache.org/r/48690/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 48689: Ability to add "javax.jdo.option.ConnectionPassword" to hive clients from ambari

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48689/#review137514
---


Ship it!




Ship It!

- Robert Levas


On June 14, 2016, 10:01 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48689/
> ---
> 
> (Updated June 14, 2016, 10:01 a.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-17223
> https://issues.apache.org/jira/browse/AMBARI-17223
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Problem is that they need to access the "javax.jdo.option.ConnectionPassword" 
> password but Ambari is pushing only to /etc/hive/conf.server/hive-site.xml. I 
> have instructed and recommended various workarounds and even suggest 
> modifying their app. Even having a static hive-site.xm with the information 
> they did not accept and asked to open an enhancement request. The enhancement 
> is to allow adding "javax.jdo.option.ConnectionPassword" to hive clients from 
> ambari and have a separate hive-site.xml path for clients.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  33c0a1f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2b7fca0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  ba93d25 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  9a86827 
> 
> Diff: https://reviews.apache.org/r/48689/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 48414: AMBARI-17118 Incorrect formated external url in ranger configuration - causes Namenode startup failure

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48414/#review137515
---


Ship it!




Ship It!

- Gautam Borad


On June 13, 2016, 2:15 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48414/
> ---
> 
> (Updated June 13, 2016, 2:15 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, 
> Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17118
> https://issues.apache.org/jira/browse/AMBARI-17118
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger Admin url when configured with trailing slash causes Namenode startup 
> failure
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions.py
>  48ae225 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  cfdd6f7 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py
>  260f018 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  e5faf4b 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  05bad1c 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  9af87d4 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  fea0635 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  09878ba 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  4d30f55 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  29ac561 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  2ba3794 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
> 6f1460a 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  cbe2a31 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  17f71fb 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  978ad92 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  29fb3c1 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 36fe066 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 53cdcfe 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> c077a9f 
> 
> Diff: https://reviews.apache.org/r/48414/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger Installation on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 48691: Removing and re-adding hosts makes database inconsitent

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48691/
---

Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, 
Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-17219
https://issues.apache.org/jira/browse/AMBARI-17219


Repository: ambari


Description
---

When a host is removed, it is necessary to have all the components stopped and 
removed, before the host itself can be deleted.
If a host component is not stopped, it is not allowed to be removed, so the 
host itself cannot be removed. However if re-adding the host is tried, even if 
it is still in the cluster, a row is inserted to topology_host_info table. 
Multiple lines of the same host in that table is incorrect, so topology 
validation fails.
Expected behaviour: if host is still in the cluster, a duplicate should not be 
able to be persisted in any of the related tables.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 e3f5b49 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
 fd8653c 

Diff: https://reviews.apache.org/r/48691/diff/


Testing
---


Thanks,

Daniel Gergely

Re: Review Request 48686: Tez View: Improve proxy logging

[Hitesh Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48686/#review137513
---



Does logging need to change in any of other classes of the tez view too?


contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
 (line 77)


Fix typo: fetching. 

Error message is not clear. The current message seems to be indicate that 
we failed to fetch data from a particular URL however the function is trying to 
find the location of the timeline server. 

Maybe change to "Failed to find Active ResourceManager location" or "Failed 
to find YARN Timeline Server location". 

Please do not use ATS as users are familiar with YARN Timeline Server and 
not ATS.



contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
 (line 87)


See above comment on typo and message



contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
 (line 97)


See above comment on typo and message

Here, something like "Failed to find YARN http/https protocol configuration 
value"



contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/YARNProtocolFetchException.java
 (line 28)


WebApplicationException(String message, Throwable cause, int status)
or 
WebApplicationException(String message, Throwable cause)

Any reason we are not using the above ctor for the super(). We can then 
inject a custom message here which will be displayed in the stack trace 
returned.  This could be done for all the new exception classes in the tez view 
codebase.



contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseProxyResource.java
 (line 66)


At debug level, we should log the response too. 

i.e. 

if LOG.isDebugEnabled() {
   LOG.error( ... failed to parse, url, response )
}


- Hitesh Shah


On June 14, 2016, 12:28 p.m., Sreenath Somarajapuram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48686/
> ---
> 
> (Updated June 14, 2016, 12:28 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-17186
> https://issues.apache.org/jira/browse/AMBARI-17186
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> More log messages would help us to debug EARs faster.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewControllerImpl.java
>  981353b 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/exceptions/YARNProtocolFetchException.java
>  PRE-CREATION 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseProxyResource.java
>  619f81e 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/rest/BaseRedirectionResource.java
>  97ee01d 
> 
> Diff: https://reviews.apache.org/r/48686/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> Verified the presence of debug and error logs in 
> /var/log/ambari-server/tez-view/tez-view.log
> 
> 
> Thanks,
> 
> Sreenath Somarajapuram
> 
>

Re: Review Request 48691: Removing and re-adding hosts makes database inconsitent

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48691/#review137519
---


Ship it!




Ship It!

- Sandor Magyari


On June 14, 2016, 2:51 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48691/
> ---
> 
> (Updated June 14, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17219
> https://issues.apache.org/jira/browse/AMBARI-17219
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a host is removed, it is necessary to have all the components stopped 
> and removed, before the host itself can be deleted.
> If a host component is not stopped, it is not allowed to be removed, so the 
> host itself cannot be removed. However if re-adding the host is tried, even 
> if it is still in the cluster, a row is inserted to topology_host_info table. 
> Multiple lines of the same host in that table is incorrect, so topology 
> validation fails.
> Expected behaviour: if host is still in the cluster, a duplicate should not 
> be able to be persisted in any of the related tables.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  e3f5b49 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  fd8653c 
> 
> Diff: https://reviews.apache.org/r/48691/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 48691: Removing and re-adding hosts makes database inconsitent

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48691/#review137520
---


Ship it!




Ship It!

- Robert Nettleton


On June 14, 2016, 2:51 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48691/
> ---
> 
> (Updated June 14, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17219
> https://issues.apache.org/jira/browse/AMBARI-17219
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a host is removed, it is necessary to have all the components stopped 
> and removed, before the host itself can be deleted.
> If a host component is not stopped, it is not allowed to be removed, so the 
> host itself cannot be removed. However if re-adding the host is tried, even 
> if it is still in the cluster, a row is inserted to topology_host_info table. 
> Multiple lines of the same host in that table is incorrect, so topology 
> validation fails.
> Expected behaviour: if host is still in the cluster, a duplicate should not 
> be able to be persisted in any of the related tables.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  e3f5b49 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  fd8653c 
> 
> Diff: https://reviews.apache.org/r/48691/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 48691: Removing and re-adding hosts makes database inconsitent

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48691/#review137521
---


Ship it!




Ship It!

- Sebastian Toader


On June 14, 2016, 4:51 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48691/
> ---
> 
> (Updated June 14, 2016, 4:51 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17219
> https://issues.apache.org/jira/browse/AMBARI-17219
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a host is removed, it is necessary to have all the components stopped 
> and removed, before the host itself can be deleted.
> If a host component is not stopped, it is not allowed to be removed, so the 
> host itself cannot be removed. However if re-adding the host is tried, even 
> if it is still in the cluster, a row is inserted to topology_host_info table. 
> Multiple lines of the same host in that table is incorrect, so topology 
> validation fails.
> Expected behaviour: if host is still in the cluster, a duplicate should not 
> be able to be persisted in any of the related tables.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  e3f5b49 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  fd8653c 
> 
> Diff: https://reviews.apache.org/r/48691/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 48691: Removing and re-adding hosts makes database inconsitent

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48691/#review137527
---


Ship it!




Ship It!

- Laszlo Puskas


On June 14, 2016, 2:51 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48691/
> ---
> 
> (Updated June 14, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Nettleton, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17219
> https://issues.apache.org/jira/browse/AMBARI-17219
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a host is removed, it is necessary to have all the components stopped 
> and removed, before the host itself can be deleted.
> If a host component is not stopped, it is not allowed to be removed, so the 
> host itself cannot be removed. However if re-adding the host is tried, even 
> if it is still in the cluster, a row is inserted to topology_host_info table. 
> Multiple lines of the same host in that table is incorrect, so topology 
> validation fails.
> Expected behaviour: if host is still in the cluster, a duplicate should not 
> be able to be persisted in any of the related tables.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  e3f5b49 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  fd8653c 
> 
> Diff: https://reviews.apache.org/r/48691/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Review Request 48698: AMBARI-17230 VDF: when registering version using Default Vers Def, need to set Name

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48698/
---

Review request for Ambari, Jaimin Jetly, Nate Cole, Oleg Nechiporenko, Richard 
Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-17230
https://issues.apache.org/jira/browse/AMBARI-17230


Repository: ambari


Description
---

When Registering a Version (in Admin UI), will need way to set the Name when 
using the Default Version Definition. This is for backwards compat, plus since 
the user might use the Default Version Def multiple times (in cases they don't 
have a VDF).


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
 cc42abb 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddVersionModal.js
 26b3558 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
7e76859 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
 83f54fd 

Diff: https://reviews.apache.org/r/48698/diff/


Testing
---

ambari-admin:
Executed 71 of 71 SUCCESS (0.164 secs / 0.379 secs)
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 48460: Ambari Views logs should include information of view instance

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48460/
---

(Updated June 14, 2016, 5:08 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Changes
---

included changes mentioned in reviews


Bugs: AMBARI-17135
https://issues.apache.org/jira/browse/AMBARI-17135


Repository: ambari


Description
---

added servlet filter and used Logging frameworks MDC feature to insert view 
related information from URL. Updated view log4j files for the same.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 961b6fe 
  
ambari-server/src/main/java/org/apache/ambari/server/view/AmbariViewsMDCLoggingFilter.java
 PRE-CREATION 
  contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
32903d3 
  contrib/views/files/src/main/resources/view.log4j.properties 698947e 
  contrib/views/hive-next/src/main/resources/view.log4j.properties b1bd5f2 
  contrib/views/hive/src/main/resources/view.log4j.properties 16c2d0e 
  contrib/views/hueambarimigration/src/main/resources/view.log4j.properties 
3e959e7 
  contrib/views/jobs/src/main/resources/view.log4j.properties 86687d6 
  contrib/views/pig/src/main/resources/view.log4j.properties 5b23a48 
  contrib/views/slider/src/main/resources/view.log4j.properties 4737032 
  contrib/views/storm/src/main/resources/view.log4j.properties 309df8d 
  contrib/views/tez/src/main/resources/view.log4j.properties 08e00bd 
  contrib/views/zeppelin/src/main/resources/view.log4j.properties PRE-CREATION 

Diff: https://reviews.apache.org/r/48460/diff/


Testing
---

Manual testing done.


Thanks,

Nitiraj Rathore

Re: Review Request 48698: AMBARI-17230 VDF: when registering version using Default Vers Def, need to set Name

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48698/#review137546
---


Ship it!




Ship It!

- Jaimin Jetly


On June 14, 2016, 5:01 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48698/
> ---
> 
> (Updated June 14, 2016, 5:01 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Nate Cole, Oleg Nechiporenko, 
> Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17230
> https://issues.apache.org/jira/browse/AMBARI-17230
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Registering a Version (in Admin UI), will need way to set the Name when 
> using the Default Version Definition. This is for backwards compat, plus 
> since the user might use the Default Version Def multiple times (in cases 
> they don't have a VDF).
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  cc42abb 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddVersionModal.js
>  26b3558 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> 7e76859 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  83f54fd 
> 
> Diff: https://reviews.apache.org/r/48698/diff/
> 
> 
> Testing
> ---
> 
> ambari-admin:
> Executed 71 of 71 SUCCESS (0.164 secs / 0.379 secs)
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47656/
---

(Updated June 14, 2016, 5:47 p.m.)


Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh 
chaudhary, Jayush Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, 
and Yusaku Sako.


Changes
---

This patch contains a few changes to the metainfo.xml of the Extension to 
separate all the prerequisites into its own section.


Bugs: AMBARI-12885
https://issues.apache.org/jira/browse/AMBARI-12885


Repository: ambari


Description
---

The purpose of this proposal is to facilitate adding custom services to an 
existing stack. Ideally this would support adding and upgrading custom services 
separately from the core services defined in the stack. In particular we are 
looking at custom services that need to support several different stacks 
(different distributions of Ambari). The release cycle of the custom services 
may be different from that of the core stack; that is, a custom service may be 
upgraded at a different rate than the core distribution itself and may be 
upgraded multiple times within the lifespan of a single release of the core 
distribution.

One possible approach to handling this would be dynamically extending a stack 
(after install time). It would be best to extend the stack in packages where a 
stack extension package can have one or more custom services.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
fc1b72a 
  ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee 
  ambari-server/conf/unix/ambari.properties a88a025 
  ambari-server/src/main/assemblies/server.xml 1560d8d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionLinkResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionVersionResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 cf7c391 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 f0928cf 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionLinksService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
 557ce98 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2b7fca0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 b488af3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 ba93d25 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionVersionRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionVersionResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 3721113 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Extension.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 99e4ccd 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionDAO.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionLinkEntity.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/stack/BaseModule.java 
ef2438f 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
 cbbdb

Review Request 48702: Add ability to set GET request directives

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48702/
---

Review request for Ambari, Ajit Kumar, Di Li, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-17224
https://issues.apache.org/jira/browse/AMBARI-17224


Repository: ambari


Description
---

Add ability to set GET request directives so that directives may be specified 
in a GET requests. For example, to limit or increase the amount of work needed 
to be performed internally to generate the data being returned.

Most data in GET requests are retrieved but filtered from the response based on 
the predicate. This means that any data the requires significant processing to 
calculate will be calculated regardless of the requested fields. By using a 
directive this can be controlled.

Note: It may be possible the use of a PropertyProvider to control this instead, 
but that may not be desired in all cases.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/ReadHandler.java
 95e45d6 
  ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
fff842a 
  ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 
18fd94b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
 dcc5217 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java
 8df1a02 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java
 394e295 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java
 bf7860b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
 0ebeb19 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
 19fee8e 
  
ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
 5cb601e 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
 f174cb6 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java
 6169ee7 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java
 11568c9 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java
 2642418 

Diff: https://reviews.apache.org/r/48702/diff/


Testing
---

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 48702: Add ability to set GET request directives

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48702/
---

(Updated June 14, 2016, 2:57 p.m.)


Review request for Ambari, Ajit Kumar, Di Li, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-17224
https://issues.apache.org/jira/browse/AMBARI-17224


Repository: ambari


Description
---

Add ability to set GET request directives so that directives may be specified 
in a GET requests. For example, to limit or increase the amount of work needed 
to be performed internally to generate the data being returned.

Most data in GET requests are retrieved but filtered from the response based on 
the predicate. This means that any data the requires significant processing to 
calculate will be calculated regardless of the requested fields. By using a 
directive this can be controlled.

Note: It may be possible the use of a PropertyProvider to control this instead, 
but that may not be desired in all cases.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/ReadHandler.java
 95e45d6 
  ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
fff842a 
  ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 
18fd94b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
 dcc5217 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java
 8df1a02 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java
 394e295 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java
 bf7860b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
 0ebeb19 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
 19fee8e 
  
ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
 5cb601e 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
 f174cb6 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java
 6169ee7 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java
 11568c9 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java
 2642418 

Diff: https://reviews.apache.org/r/48702/diff/


Testing (updated)
---

# Local test results: 

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:25:36.424s
[INFO] Finished at: Tue Jun 14 14:53:08 EDT 2016
[INFO] Final Memory: 59M/1864M
[INFO] 

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47656/
---

(Updated June 14, 2016, 7:05 p.m.)


Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh 
chaudhary, Jayush Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, 
and Yusaku Sako.


Changes
---

Modified patch to use min-stack-version for the extension rather than just 
stack version.


Bugs: AMBARI-12885
https://issues.apache.org/jira/browse/AMBARI-12885


Repository: ambari


Description
---

The purpose of this proposal is to facilitate adding custom services to an 
existing stack. Ideally this would support adding and upgrading custom services 
separately from the core services defined in the stack. In particular we are 
looking at custom services that need to support several different stacks 
(different distributions of Ambari). The release cycle of the custom services 
may be different from that of the core stack; that is, a custom service may be 
upgraded at a different rate than the core distribution itself and may be 
upgraded multiple times within the lifespan of a single release of the core 
distribution.

One possible approach to handling this would be dynamically extending a stack 
(after install time). It would be best to extend the stack in packages where a 
stack extension package can have one or more custom services.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
fc1b72a 
  ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee 
  ambari-server/conf/unix/ambari.properties a88a025 
  ambari-server/src/main/assemblies/server.xml 1560d8d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionLinkResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionVersionResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 cf7c391 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 f0928cf 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionLinksService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
 557ce98 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2b7fca0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 b488af3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 ba93d25 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionVersionRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionVersionResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 3721113 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Extension.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 99e4ccd 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionDAO.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionLinkEntity.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/stack/BaseModule.java 
ef2438f 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
 cbbdb91 
  
ambari-server/src/main/java/or

Re: Review Request 48702: Add ability to set GET request directives

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48702/#review137568
---



Can you give an example of a read directive?


ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
 (line 333)


getReadDirectives() to match verb-to-action (we don't have 
getPostDirectives(), we have getCreateDirectives() )



ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
 (line 69)


createReadRequest() ?


- Nate Cole


On June 14, 2016, 2:57 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48702/
> ---
> 
> (Updated June 14, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Di Li, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17224
> https://issues.apache.org/jira/browse/AMBARI-17224
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add ability to set GET request directives so that directives may be specified 
> in a GET requests. For example, to limit or increase the amount of work 
> needed to be performed internally to generate the data being returned.
> 
> Most data in GET requests are retrieved but filtered from the response based 
> on the predicate. This means that any data the requires significant 
> processing to calculate will be calculated regardless of the requested 
> fields. By using a directive this can be controlled.
> 
> Note: It may be possible the use of a PropertyProvider to control this 
> instead, but that may not be desired in all cases.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/ReadHandler.java
>  95e45d6 
>   ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
> fff842a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 
> 18fd94b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
>  dcc5217 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java
>  8df1a02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java
>  394e295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java
>  bf7860b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
>  0ebeb19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
>  19fee8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
>  5cb601e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
>  f174cb6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java
>  6169ee7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java
>  11568c9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java
>  2642418 
> 
> Diff: https://reviews.apache.org/r/48702/diff/
> 
> 
> Testing
> ---
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:25:36.424s
> [INFO] Finished at: Tue Jun 14 14:53:08 EDT 2016
> [INFO] Final Memory: 59M/1864M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 48706: 'ambari-server --version' command does not show build number

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48706/
---

Review request for Ambari, Dmitro Lisnichenko and Dmytro Sen.


Repository: ambari


Description
---

'ambari-server --version' command does not show build number


Diffs
-

  ambari-server/pom.xml b488971 
  ambari-server/sbin/ambari-server 83a52c6 

Diff: https://reviews.apache.org/r/48706/diff/


Testing
---


Thanks,

Vitalyi Brodetskyi

Review Request 48707: Atlas Server Web UI alert

[Tom Beerbower]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48707/
---

Review request for Ambari and John Speidel.


Bugs: AMBARI-17005
https://issues.apache.org/jira/browse/AMBARI-17005


Repository: ambari


Description
---

Seeing this HTTP 401 response from http://c6401.ambari.apache.org:21000.
Atlas recently added basic authentication.

Updates in ATLAS-774 will allow requests to 
"atlas-server:port/api/atlas/admin/status" without requiring authentication.


Diffs
-

  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json 
e65b5c1 

Diff: https://reviews.apache.org/r/48707/diff/


Testing
---

Manual test install Atlas.  Verify alert not triggered.

mvn clean test


Thanks,

Tom Beerbower

Re: Review Request 48702: Add ability to set GET request directives

[Robert Levas]

> On June 14, 2016, 3:24 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java,
> >  line 69
> > 
> >
> > createReadRequest() ?

This is consistent with `createPutRequest`, `createDeleteRequest`, and 
`createPostRequest`.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48702/#review137568
---


On June 14, 2016, 2:57 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48702/
> ---
> 
> (Updated June 14, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Di Li, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17224
> https://issues.apache.org/jira/browse/AMBARI-17224
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add ability to set GET request directives so that directives may be specified 
> in a GET requests. For example, to limit or increase the amount of work 
> needed to be performed internally to generate the data being returned.
> 
> Most data in GET requests are retrieved but filtered from the response based 
> on the predicate. This means that any data the requires significant 
> processing to calculate will be calculated regardless of the requested 
> fields. By using a directive this can be controlled.
> 
> Note: It may be possible the use of a PropertyProvider to control this 
> instead, but that may not be desired in all cases.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/ReadHandler.java
>  95e45d6 
>   ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
> fff842a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 
> 18fd94b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
>  dcc5217 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java
>  8df1a02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java
>  394e295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java
>  bf7860b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
>  0ebeb19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
>  19fee8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
>  5cb601e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
>  f174cb6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java
>  6169ee7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java
>  11568c9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java
>  2642418 
> 
> Diff: https://reviews.apache.org/r/48702/diff/
> 
> 
> Testing
> ---
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:25:36.424s
> [INFO] Finished at: Tue Jun 14 14:53:08 EDT 2016
> [INFO] Final Memory: 59M/1864M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

[Tim Thorpe]

> On June 3, 2016, 9:46 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 32
> > 
> >
> > Let's be consistent with the name, UQ_*

Just noting that the code was copied and pasted from the stack table which uses 
unq_stack.  Do you want me to change all usages of unq?

cat src/main/resources/Ambari-DDL-Derby-CREATE.sql | grep unq
  CONSTRAINT unq_stack UNIQUE (stack_name, stack_version));
  CONSTRAINT unq_extension UNIQUE(extension_name, extension_version));
  CONSTRAINT unq_extension_link UNIQUE(stack_id, extension_id));
  CONSTRAINT unq_scdesiredstate_name UNIQUE(component_name, service_name, 
cluster_id),
  CONSTRAINT unq_remote_ambari_cluster UNIQUE (name));


> On June 3, 2016, 9:46 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java,
> >  line 3798
> > 
> >
> > Add javadoc to new methods
> > Someone new reading the code should know what an extension is.

I added in some comments to all the methods describing what an extension is 
after I've finished the documentation on the wiki, I will revisit some of these 
changes and reference the wiki.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47656/#review136105
---


On June 14, 2016, 7:05 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47656/
> ---
> 
> (Updated June 14, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh 
> chaudhary, Jayush Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth 
> Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12885
> https://issues.apache.org/jira/browse/AMBARI-12885
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The purpose of this proposal is to facilitate adding custom services to an 
> existing stack. Ideally this would support adding and upgrading custom 
> services separately from the core services defined in the stack. In 
> particular we are looking at custom services that need to support several 
> different stacks (different distributions of Ambari). The release cycle of 
> the custom services may be different from that of the core stack; that is, a 
> custom service may be upgraded at a different rate than the core distribution 
> itself and may be upgraded multiple times within the lifespan of a single 
> release of the core distribution.
> 
> One possible approach to handling this would be dynamically extending a stack 
> (after install time). It would be best to extend the stack in packages where 
> a stack extension package can have one or more custom services.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> fc1b72a 
>   ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee 
>   ambari-server/conf/unix/ambari.properties a88a025 
>   ambari-server/src/main/assemblies/server.xml 1560d8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionLinkResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionVersionResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  cf7c391 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  f0928cf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionLinksService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionsService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  557ce98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2b7fca0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  b488af3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  ba93d25 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/c

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47656/
---

(Updated June 14, 2016, 9:09 p.m.)


Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh 
chaudhary, Jayush Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, 
and Yusaku Sako.


Changes
---

Patch fixes issues pointed out by Alejandro


Bugs: AMBARI-12885
https://issues.apache.org/jira/browse/AMBARI-12885


Repository: ambari


Description
---

The purpose of this proposal is to facilitate adding custom services to an 
existing stack. Ideally this would support adding and upgrading custom services 
separately from the core services defined in the stack. In particular we are 
looking at custom services that need to support several different stacks 
(different distributions of Ambari). The release cycle of the custom services 
may be different from that of the core stack; that is, a custom service may be 
upgraded at a different rate than the core distribution itself and may be 
upgraded multiple times within the lifespan of a single release of the core 
distribution.

One possible approach to handling this would be dynamically extending a stack 
(after install time). It would be best to extend the stack in packages where a 
stack extension package can have one or more custom services.


Diffs (updated)
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
fc1b72a 
  ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee 
  ambari-server/conf/unix/ambari.properties a88a025 
  ambari-server/src/main/assemblies/server.xml 1560d8d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionLinkResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionVersionResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 cf7c391 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 f0928cf 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionLinksService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
 557ce98 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2b7fca0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 b488af3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 ba93d25 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionVersionRequest.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionVersionResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 3721113 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Extension.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 99e4ccd 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionDAO.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionEntity.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionLinkEntity.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/stack/BaseModule.java 
ef2438f 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
 cbbdb91 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.ja

Re: Review Request 48702: Add ability to set GET request directives

[Robert Levas]

> On June 14, 2016, 3:24 p.m., Nate Cole wrote:
> > Can you give an example of a read directive?

This is for a future enhancement I need to make.  With the addition of the 
`when` clause for a Kerberos descriptor identity, we are able to optionally 
include Kerberos identities depending on what services are installed - soon to 
be the ability to specifiy other expressions as well.  These `when` expressions 
are processed when performing Kerberos-releated operations; however, they are 
not performed when obtaining the Kerberos descriptor JSON data from Ambari via 
the API. Front-ends can use this data to display a page allowing a user to 
customize pricinal names and keytab file locations - for example the `Configure 
Identities` page of the `Enable Kerberos Wizard` in the Ambari server web 
client.  

It is desirable to provide the Kerberos descriptor JSON document, both, in its 
complete form and processed to remove the Kerberos identities that should be 
eliminated due to their `when` clauses.  I propose to provide this ability by 
allowing the caller to specify a directive in the GET command for the Kerberos 
descriptor to declare their desired version of the documment.  For example: 
`evaluate_when=true`

# Retrieve the raw JSON document
```
GET /api/v1/clusters/CLUSTER_NAME/kerberos_descriptors/COMPOSITE
```

# Retrieve the processed JSON document
```
GET 
/api/v1/clusters/CLUSTER_NAME/kerberos_descriptors/COMPOSITE?evaluate_when=true
```


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48702/#review137568
---


On June 14, 2016, 2:57 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48702/
> ---
> 
> (Updated June 14, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Di Li, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17224
> https://issues.apache.org/jira/browse/AMBARI-17224
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add ability to set GET request directives so that directives may be specified 
> in a GET requests. For example, to limit or increase the amount of work 
> needed to be performed internally to generate the data being returned.
> 
> Most data in GET requests are retrieved but filtered from the response based 
> on the predicate. This means that any data the requires significant 
> processing to calculate will be calculated regardless of the requested 
> fields. By using a directive this can be controlled.
> 
> Note: It may be possible the use of a PropertyProvider to control this 
> instead, but that may not be desired in all cases.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/ReadHandler.java
>  95e45d6 
>   ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
> fff842a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 
> 18fd94b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
>  dcc5217 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java
>  8df1a02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java
>  394e295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java
>  bf7860b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
>  0ebeb19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
>  19fee8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
>  5cb601e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
>  f174cb6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java
>  6169ee7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java
>  11568c9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java
>  2642418 
> 
> Diff: https://reviews.apache.org/r/48702/diff/
> 
> 
> Testing
> ---
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:25:36.424s
> [INFO] Finished at: Tue Jun 14 14:53:08 EDT 2016
> [INFO] Final Memory: 59M/1864M
> [INFO] 
> 
> 
> # Jenkins test results: PEND

Review Request 48708: Namenode start step failed during EU with RetriableException

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48708/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
Cole.


Bugs: AMBARI-17236
https://issues.apache.org/jira/browse/AMBARI-17236


Repository: ambari


Description
---

When starting NN during an EU, we're hitting this when trying to create HDFS 
directories:
```
{
  "RemoteException": {
"exception": "RetriableException", 
"javaClassName": "org.apache.hadoop.ipc.RetriableException", 
"message": "NameNode still not started"
  }
}
```

So, the heart of this issue is that, depending on topology and upgrade type, we 
might not wait for NN to be out of Safe Mode after starting. However, we are 
always creating directories, regardless of topology/upgrade:

```
# Always run this on non-HA, or active NameNode during HA.
if is_active_namenode:
  create_hdfs_directories()
  create_ranger_audit_hdfs_directories()
```

NameNode, in Safe Mode, is read-only and would forbid this anyway, even if it 
didn't throw a retryable exception:
```
[hdfs@c6403 root]$ hadoop fs -mkdir /foo
mkdir: Cannot create directory /foo. Name node is in safe mode.
```

So, it seems like we need to wait for NN to be out of Safe Mode no matter what.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py
 18e61fb 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
 635f159 

Diff: https://reviews.apache.org/r/48708/diff/


Testing
---

PENDING


Thanks,

Jonathan Hurley

Re: Review Request 48708: Namenode start step failed during EU with RetriableException

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48708/#review137586
---




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
 


`is_action_namenode_cmd` was not used anymore - this was dead code.



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
 (lines 168 - 170)


Because we're writing out directories on startup no matter what, we need to 
ensure NN is out of SafeMode - that's the major logic change.


- Jonathan Hurley


On June 14, 2016, 5:33 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48708/
> ---
> 
> (Updated June 14, 2016, 5:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-17236
> https://issues.apache.org/jira/browse/AMBARI-17236
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When starting NN during an EU, we're hitting this when trying to create HDFS 
> directories:
> ```
> {
>   "RemoteException": {
> "exception": "RetriableException", 
> "javaClassName": "org.apache.hadoop.ipc.RetriableException", 
> "message": "NameNode still not started"
>   }
> }
> ```
> 
> So, the heart of this issue is that, depending on topology and upgrade type, 
> we might not wait for NN to be out of Safe Mode after starting. However, we 
> are always creating directories, regardless of topology/upgrade:
> 
> ```
> # Always run this on non-HA, or active NameNode during HA.
> if is_active_namenode:
>   create_hdfs_directories()
>   create_ranger_audit_hdfs_directories()
> ```
> 
> NameNode, in Safe Mode, is read-only and would forbid this anyway, even if it 
> didn't throw a retryable exception:
> ```
> [hdfs@c6403 root]$ hadoop fs -mkdir /foo
> mkdir: Cannot create directory /foo. Name node is in safe mode.
> ```
> 
> So, it seems like we need to wait for NN to be out of Safe Mode no matter 
> what.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py
>  18e61fb 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  635f159 
> 
> Diff: https://reviews.apache.org/r/48708/diff/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 48707: Atlas Server Web UI alert

[John Speidel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48707/#review137591
---


Ship it!




Ship It!

- John Speidel


On June 14, 2016, 7:58 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48707/
> ---
> 
> (Updated June 14, 2016, 7:58 p.m.)
> 
> 
> Review request for Ambari and John Speidel.
> 
> 
> Bugs: AMBARI-17005
> https://issues.apache.org/jira/browse/AMBARI-17005
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Seeing this HTTP 401 response from http://c6401.ambari.apache.org:21000.
> Atlas recently added basic authentication.
> 
> Updates in ATLAS-774 will allow requests to 
> "atlas-server:port/api/atlas/admin/status" without requiring authentication.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json 
> e65b5c1 
> 
> Diff: https://reviews.apache.org/r/48707/diff/
> 
> 
> Testing
> ---
> 
> Manual test install Atlas.  Verify alert not triggered.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Review Request 48709: Nothing shows on the role section when user has the same role as its group

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48709/
---

Review request for Ambari and Zhe (Joe) Wang.


Bugs: AMBARI-17239
https://issues.apache.org/jira/browse/AMBARI-17239


Repository: ambari


Description
---

Only show highest role. Fix ng-repeat usage to avoid error caused by duplicated 
items.


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js
 69a15bd 
  ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html 
18df5fa 

Diff: https://reviews.apache.org/r/48709/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.

PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.409 secs)


Thanks,

Richard Zang

Re: Review Request 48709: Nothing shows on the role section when user has the same role as its group

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48709/#review137598
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On June 14, 2016, 10:39 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48709/
> ---
> 
> (Updated June 14, 2016, 10:39 p.m.)
> 
> 
> Review request for Ambari and Zhe (Joe) Wang.
> 
> 
> Bugs: AMBARI-17239
> https://issues.apache.org/jira/browse/AMBARI-17239
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Only show highest role. Fix ng-repeat usage to avoid error caused by 
> duplicated items.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js
>  69a15bd 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html 
> 18df5fa 
> 
> Diff: https://reviews.apache.org/r/48709/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
> 
> PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.409 
> secs)
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 48708: Namenode start step failed during EU with RetriableException

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48708/#review137599
---


Ship it!




Ship It!

- Nate Cole


On June 14, 2016, 5:33 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48708/
> ---
> 
> (Updated June 14, 2016, 5:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-17236
> https://issues.apache.org/jira/browse/AMBARI-17236
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When starting NN during an EU, we're hitting this when trying to create HDFS 
> directories:
> ```
> {
>   "RemoteException": {
> "exception": "RetriableException", 
> "javaClassName": "org.apache.hadoop.ipc.RetriableException", 
> "message": "NameNode still not started"
>   }
> }
> ```
> 
> So, the heart of this issue is that, depending on topology and upgrade type, 
> we might not wait for NN to be out of Safe Mode after starting. However, we 
> are always creating directories, regardless of topology/upgrade:
> 
> ```
> # Always run this on non-HA, or active NameNode during HA.
> if is_active_namenode:
>   create_hdfs_directories()
>   create_ranger_audit_hdfs_directories()
> ```
> 
> NameNode, in Safe Mode, is read-only and would forbid this anyway, even if it 
> didn't throw a retryable exception:
> ```
> [hdfs@c6403 root]$ hadoop fs -mkdir /foo
> mkdir: Cannot create directory /foo. Name node is in safe mode.
> ```
> 
> So, it seems like we need to wait for NN to be out of Safe Mode no matter 
> what.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py
>  18e61fb 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  635f159 
> 
> Diff: https://reviews.apache.org/r/48708/diff/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 48702: Add ability to set GET request directives

[Nate Cole]

> On June 14, 2016, 3:24 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java,
> >  line 69
> > 
> >
> > createReadRequest() ?
> 
> Robert Levas wrote:
> This is consistent with `createPutRequest`, `createDeleteRequest`, and 
> `createPostRequest`.

Whoops - I read a little fast I guess :)


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48702/#review137568
---


On June 14, 2016, 2:57 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48702/
> ---
> 
> (Updated June 14, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Di Li, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17224
> https://issues.apache.org/jira/browse/AMBARI-17224
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add ability to set GET request directives so that directives may be specified 
> in a GET requests. For example, to limit or increase the amount of work 
> needed to be performed internally to generate the data being returned.
> 
> Most data in GET requests are retrieved but filtered from the response based 
> on the predicate. This means that any data the requires significant 
> processing to calculate will be calculated regardless of the requested 
> fields. By using a directive this can be controlled.
> 
> Note: It may be possible the use of a PropertyProvider to control this 
> instead, but that may not be desired in all cases.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/ReadHandler.java
>  95e45d6 
>   ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
> fff842a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 
> 18fd94b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
>  dcc5217 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java
>  8df1a02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java
>  394e295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java
>  bf7860b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
>  0ebeb19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
>  19fee8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
>  5cb601e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
>  f174cb6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java
>  6169ee7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java
>  11568c9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java
>  2642418 
> 
> Diff: https://reviews.apache.org/r/48702/diff/
> 
> 
> Testing
> ---
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:25:36.424s
> [INFO] Finished at: Tue Jun 14 14:53:08 EDT 2016
> [INFO] Final Memory: 59M/1864M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 48697: AMBARI-17229. Add config 'tez.lib.uris' in tez_hive2/tez-site's pointing to tez_hive2 path jar.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48697/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17229
https://issues.apache.org/jira/browse/AMBARI-17229


Repository: ambari


Description
---

- tez_hive2/tez-site's config : tez.lib.uris points to : 
/hdp/apps/${hdp.version}/tez_hive2/tez.tar.gz

- Added explanation in hive-interactive-site.xml and tez-interactive-site.xml 
for the inheritance logic. 
- Update Display Name and Decription for config 
"hive.llap.daemon.yarn.container.mb".


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 eb4aa61 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
 93a2073 

Diff: https://reviews.apache.org/r/48697/diff/


Testing
---

Python UT passes.


Thanks,

Swapan Shridhar

Re: Review Request 48697: AMBARI-17229. Add config 'tez.lib.uris' in tez_hive2/tez-site's pointing to tez_hive2 path jar.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48697/
---

(Updated June 14, 2016, 11:12 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17229
https://issues.apache.org/jira/browse/AMBARI-17229


Repository: ambari


Description (updated)
---

- tez_hive2/tez-site's config : tez.lib.uris points to : 
/hdp/apps/${hdp.version}/tez_hive2/tez.tar.gz

- Added explanation in hive-interactive-site.xml and tez-interactive-site.xml 
for the inheritance logic. 
- Updated Display Name and Decription for config 
"hive.llap.daemon.yarn.container.mb".


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 eb4aa61 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
 93a2073 

Diff: https://reviews.apache.org/r/48697/diff/


Testing
---

Python UT passes.


Thanks,

Swapan Shridhar

Re: Review Request 48702: Add ability to set GET request directives

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48702/
---

(Updated June 14, 2016, 7:12 p.m.)


Review request for Ambari, Ajit Kumar, Di Li, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-17224
https://issues.apache.org/jira/browse/AMBARI-17224


Repository: ambari


Description
---

Add ability to set GET request directives so that directives may be specified 
in a GET requests. For example, to limit or increase the amount of work needed 
to be performed internally to generate the data being returned.

Most data in GET requests are retrieved but filtered from the response based on 
the predicate. This means that any data the requires significant processing to 
calculate will be calculated regardless of the requested fields. By using a 
directive this can be controlled.

Note: It may be possible the use of a PropertyProvider to control this instead, 
but that may not be desired in all cases.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/ReadHandler.java
 95e45d6 
  ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
fff842a 
  ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 
18fd94b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
 dcc5217 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java
 8df1a02 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java
 394e295 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java
 bf7860b 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
 0ebeb19 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
 19fee8e 
  
ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
 5cb601e 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
 f174cb6 
  
ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java
 6169ee7 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java
 11568c9 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java
 2642418 

Diff: https://reviews.apache.org/r/48702/diff/


Testing
---

# Local test results: 

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:25:36.424s
[INFO] Finished at: Tue Jun 14 14:53:08 EDT 2016
[INFO] Final Memory: 59M/1864M
[INFO] 

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 48710: atlas.authentication.principal should be set to atlas/_h...@example.com

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48710/#review137613
---


Ship it!




Ship It!

- Robert Levas


On June 14, 2016, 7:03 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48710/
> ---
> 
> (Updated June 14, 2016, 7:03 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-17242
> https://issues.apache.org/jira/browse/AMBARI-17242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In a kerberized env, the value of atlas.authentication.principal should be 
> set to atlas/_h...@example.com. Currently the value is set to atlas which 
> causes Atlas server startup to fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/kerberos.json 
> 78ad6ea 
> 
> Diff: https://reviews.apache.org/r/48710/diff/
> 
> 
> Testing
> ---
> 
> Manual test install Atlas, set Kerberos, verify Atlas configuration.
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Review Request 48710: atlas.authentication.principal should be set to atlas/_h...@example.com

[Tom Beerbower]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48710/
---

Review request for Ambari and Robert Levas.


Bugs: AMBARI-17242
https://issues.apache.org/jira/browse/AMBARI-17242


Repository: ambari


Description
---

In a kerberized env, the value of atlas.authentication.principal should be set 
to atlas/_h...@example.com. Currently the value is set to atlas which causes 
Atlas server startup to fail.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/kerberos.json 
78ad6ea 

Diff: https://reviews.apache.org/r/48710/diff/


Testing
---

Manual test install Atlas, set Kerberos, verify Atlas configuration.


Thanks,

Tom Beerbower

Re: Review Request 48697: AMBARI-17229. Add config 'tez.lib.uris' in tez_hive2/tez-site's pointing to tez_hive2 path jar.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48697/#review137615
---


Ship it!




Ship It!

- Sumit Mohanty


On June 14, 2016, 11:12 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48697/
> ---
> 
> (Updated June 14, 2016, 11:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17229
> https://issues.apache.org/jira/browse/AMBARI-17229
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - tez_hive2/tez-site's config : tez.lib.uris points to : 
> /hdp/apps/${hdp.version}/tez_hive2/tez.tar.gz
> 
> - Added explanation in hive-interactive-site.xml and tez-interactive-site.xml 
> for the inheritance logic.   
> - Updated Display Name and Decription for config 
> "hive.llap.daemon.yarn.container.mb".
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  eb4aa61 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
>  93a2073 
> 
> Diff: https://reviews.apache.org/r/48697/diff/
> 
> 
> Testing
> ---
> 
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 48697: AMBARI-17229. Add config 'tez.lib.uris' in tez_hive2/tez-site's pointing to tez_hive2 path jar.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48697/#review137619
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 14, 2016, 11:12 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48697/
> ---
> 
> (Updated June 14, 2016, 11:12 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17229
> https://issues.apache.org/jira/browse/AMBARI-17229
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - tez_hive2/tez-site's config : tez.lib.uris points to : 
> /hdp/apps/${hdp.version}/tez_hive2/tez.tar.gz
> 
> - Added explanation in hive-interactive-site.xml and tez-interactive-site.xml 
> for the inheritance logic.   
> - Updated Display Name and Decription for config 
> "hive.llap.daemon.yarn.container.mb".
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  eb4aa61 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml
>  93a2073 
> 
> Diff: https://reviews.apache.org/r/48697/diff/
> 
> 
> Testing
> ---
> 
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 48710: atlas.authentication.principal should be set to atlas/_h...@example.com

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48710/#review137620
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 14, 2016, 11:03 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48710/
> ---
> 
> (Updated June 14, 2016, 11:03 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-17242
> https://issues.apache.org/jira/browse/AMBARI-17242
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In a kerberized env, the value of atlas.authentication.principal should be 
> set to atlas/_h...@example.com. Currently the value is set to atlas which 
> causes Atlas server startup to fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/kerberos.json 
> 78ad6ea 
> 
> Diff: https://reviews.apache.org/r/48710/diff/
> 
> 
> Testing
> ---
> 
> Manual test install Atlas, set Kerberos, verify Atlas configuration.
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 48702: Add ability to set GET request directives

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48702/#review137621
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 14, 2016, 11:12 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48702/
> ---
> 
> (Updated June 14, 2016, 11:12 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Di Li, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17224
> https://issues.apache.org/jira/browse/AMBARI-17224
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add ability to set GET request directives so that directives may be specified 
> in a GET requests. For example, to limit or increase the amount of work 
> needed to be performed internally to generate the data being returned.
> 
> Most data in GET requests are retrieved but filtered from the response based 
> on the predicate. This means that any data the requires significant 
> processing to calculate will be calculated regardless of the requested 
> fields. By using a directive this can be controlled.
> 
> Note: It may be possible the use of a PropertyProvider to control this 
> instead, but that may not be desired in all cases.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/ReadHandler.java
>  95e45d6 
>   ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
> fff842a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 
> 18fd94b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
>  dcc5217 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java
>  8df1a02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java
>  394e295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java
>  bf7860b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
>  0ebeb19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
>  19fee8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
>  5cb601e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
>  f174cb6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java
>  6169ee7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java
>  11568c9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java
>  2642418 
> 
> Diff: https://reviews.apache.org/r/48702/diff/
> 
> 
> Testing
> ---
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:25:36.424s
> [INFO] Finished at: Tue Jun 14 14:53:08 EDT 2016
> [INFO] Final Memory: 59M/1864M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 48708: Namenode start step failed during EU with RetriableException

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48708/#review137623
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 14, 2016, 9:33 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48708/
> ---
> 
> (Updated June 14, 2016, 9:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-17236
> https://issues.apache.org/jira/browse/AMBARI-17236
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When starting NN during an EU, we're hitting this when trying to create HDFS 
> directories:
> ```
> {
>   "RemoteException": {
> "exception": "RetriableException", 
> "javaClassName": "org.apache.hadoop.ipc.RetriableException", 
> "message": "NameNode still not started"
>   }
> }
> ```
> 
> So, the heart of this issue is that, depending on topology and upgrade type, 
> we might not wait for NN to be out of Safe Mode after starting. However, we 
> are always creating directories, regardless of topology/upgrade:
> 
> ```
> # Always run this on non-HA, or active NameNode during HA.
> if is_active_namenode:
>   create_hdfs_directories()
>   create_ranger_audit_hdfs_directories()
> ```
> 
> NameNode, in Safe Mode, is read-only and would forbid this anyway, even if it 
> didn't throw a retryable exception:
> ```
> [hdfs@c6403 root]$ hadoop fs -mkdir /foo
> mkdir: Cannot create directory /foo. Name node is in safe mode.
> ```
> 
> So, it seems like we need to wait for NN to be out of Safe Mode no matter 
> what.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py
>  18e61fb 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  635f159 
> 
> Diff: https://reviews.apache.org/r/48708/diff/
> 
> 
> Testing
> ---
> 
> PENDING
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

[Alejandro Fernandez]

> On June 3, 2016, 9:46 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 32
> > 
> >
> > Let's be consistent with the name, UQ_*
> 
> Tim Thorpe wrote:
> Just noting that the code was copied and pasted from the stack table 
> which uses unq_stack.  Do you want me to change all usages of unq?
> 
> cat src/main/resources/Ambari-DDL-Derby-CREATE.sql | grep unq
>   CONSTRAINT unq_stack UNIQUE (stack_name, stack_version));
>   CONSTRAINT unq_extension UNIQUE(extension_name, extension_version));
>   CONSTRAINT unq_extension_link UNIQUE(stack_id, extension_id));
>   CONSTRAINT unq_scdesiredstate_name UNIQUE(component_name, service_name, 
> cluster_id),
>   CONSTRAINT unq_remote_ambari_cluster UNIQUE (name));

Please do, the majority of the other tables use "UQ"


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47656/#review136105
---


On June 14, 2016, 9:09 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47656/
> ---
> 
> (Updated June 14, 2016, 9:09 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh 
> chaudhary, Jayush Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth 
> Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-12885
> https://issues.apache.org/jira/browse/AMBARI-12885
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The purpose of this proposal is to facilitate adding custom services to an 
> existing stack. Ideally this would support adding and upgrading custom 
> services separately from the core services defined in the stack. In 
> particular we are looking at custom services that need to support several 
> different stacks (different distributions of Ambari). The release cycle of 
> the custom services may be different from that of the core stack; that is, a 
> custom service may be upgraded at a different rate than the core distribution 
> itself and may be upgraded multiple times within the lifespan of a single 
> release of the core distribution.
> 
> One possible approach to handling this would be dynamically extending a stack 
> (after install time). It would be best to extend the stack in packages where 
> a stack extension package can have one or more custom services.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> fc1b72a 
>   ambari-agent/src/main/python/ambari_agent/FileCache.py b7c5dee 
>   ambari-server/conf/unix/ambari.properties a88a025 
>   ambari-server/src/main/assemblies/server.xml 1560d8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionLinkResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ExtensionVersionResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  cf7c391 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  f0928cf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionLinksService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionsService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  557ce98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2b7fca0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  b488af3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  ba93d25 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionVersionRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionVersionResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/jav

Re: Review Request 48636: Zeppelin Views are not working with Custom and Remote cluster view configuration

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48636/#review137626
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 13, 2016, 1:22 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48636/
> ---
> 
> (Updated June 13, 2016, 1:22 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17191
> https://issues.apache.org/jira/browse/AMBARI-17191
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Two patches attached in the jira issue
> AMBARI-17191_branch-2.4_v1.patch
> AMBARI-17191_trunk_v1.patch
> 
> 
> - fix zeppelin view
> 
> 
> Diffs
> -
> 
>   
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java
>  e80f884 
>   
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java
>  f497599 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp 493473e 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml 2ca5664 
>   contrib/views/zeppelin/src/main/resources/view.xml 3c5c5cf 
> 
> Diff: https://reviews.apache.org/r/48636/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 48335: Zeppelin service: Update default zeppelin_pid_dir to /var/run/zeppelin

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48335/#review137627
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 7, 2016, 11:45 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48335/
> ---
> 
> (Updated June 7, 2016, 11:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17088
> https://issues.apache.org/jira/browse/AMBARI-17088
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> update dir name from zeppelin-notebook to zeppelin
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  efd31f1 
> 
> Diff: https://reviews.apache.org/r/48335/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 48670: Return well formatted error response while deleting host with clients installed.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48670/#review137629
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 


How is this a fix?
If a host has any masters, we shouldn't allow deleting it. Slaves must be 
stopped. Clients can be in any state.


- Alejandro Fernandez


On June 14, 2016, 12:29 a.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48670/
> ---
> 
> (Updated June 14, 2016, 12:29 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17210
> https://issues.apache.org/jira/browse/AMBARI-17210
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Return well formatted error response while deleting host with clients 
> installed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  46fc65295f72bae39c534cd9684f2d76d1e30224 
> 
> Diff: https://reviews.apache.org/r/48670/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> delete 
> http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/hosts/c6403.ambari.apache.org
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: An 
> internal system exception occurred: Cannot remove host 
> c6403.ambari.apache.org from c1.  The following roles exist, and these 
> components must be stopped if running, and then deleted: HDFS_CLIENT, 
> MAPREDUCE2_CLIENT, YARN_CLIENT, ZOOKEEPER_CLIENT"
> }
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 48670: Return well formatted error response while deleting host with clients installed.

[Ajit Kumar]

> On June 14, 2016, 11:54 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java,
> >  line 930
> > 
> >
> > How is this a fix?
> > If a host has any masters, we shouldn't allow deleting it. Slaves must 
> > be stopped. Clients can be in any state.

I had a discussion with Sumit and we aggreed on failing even for clients.


- Ajit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48670/#review137629
---


On June 14, 2016, 12:29 a.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48670/
> ---
> 
> (Updated June 14, 2016, 12:29 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17210
> https://issues.apache.org/jira/browse/AMBARI-17210
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Return well formatted error response while deleting host with clients 
> installed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  46fc65295f72bae39c534cd9684f2d76d1e30224 
> 
> Diff: https://reviews.apache.org/r/48670/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> delete 
> http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/hosts/c6403.ambari.apache.org
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: An 
> internal system exception occurred: Cannot remove host 
> c6403.ambari.apache.org from c1.  The following roles exist, and these 
> components must be stopped if running, and then deleted: HDFS_CLIENT, 
> MAPREDUCE2_CLIENT, YARN_CLIENT, ZOOKEEPER_CLIENT"
> }
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 48683: One of RM failed to start after ambaru upgrade in secure cluster [Upgrade]

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48683/#review137631
---




ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
 (line 241)


What guarantees that hdfs keytab will be on the RM host?


- Alejandro Fernandez


On June 14, 2016, 10:59 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48683/
> ---
> 
> (Updated June 14, 2016, 10:59 a.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-17216
> https://issues.apache.org/jira/browse/AMBARI-17216
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
>   1. Deploy HDP 2.4 on Ambari2.2.2.0
>   2. Enable NN and RM HAs
>   3. Enable security
>   4. Perform ambari upgrade to 2.4.0
> 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
>  line 287, in 
> Resourcemanager().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 257, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
>  line 124, in start
> 
> self.wait_for_dfs_directories_created(params.entity_groupfs_store_dir, 
> params.entity_groupfs_active_dir)
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
>  line 244, in wait_for_dfs_directories_created
> self.wait_for_dfs_directory_created(dir_path, ignored_dfs_dirs)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/decorator.py",
>  line 55, in wrapper
> return function(*args, **kwargs)
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py",
>  line 266, in wait_for_dfs_directory_created
> list_status = util.run_command(dir_path, 'GETFILESTATUS', 
> method='GET', ignore_status_codes=['404'], assertable_result=False)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
>  line 191, in run_command
> raise Fail(err_msg)
> resource_management.core.exceptions.Fail: Execution of 'curl -sS -L -w 
> '%{http_code}' -X GET --negotiate -u : 
> 'http://os-r6-kdfyi-nat-s-ru242to25rhel6secha-12.openstacklocal:50070/webhdfs/v1/ats/done/?op=GETFILESTATUS&user.name=hdfs''
>  returned status_code=401. 
> 
> 
> 
> Error 401 Authentication required
> 
> HTTP ERROR 401
> Problem accessing /webhdfs/v1/ats/done/. Reason:
> Authentication requiredPowered by 
> Jetty://
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  0b80dc6 
> 
> Diff: https://reviews.apache.org/r/48683/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 48589: Fix HA enabled logic in the alerts

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48589/#review137632
---


Ship it!




Ship It!

- Jonathan Hurley


On June 14, 2016, 10:15 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48589/
> ---
> 
> (Updated June 14, 2016, 10:15 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17180
> https://issues.apache.org/jira/browse/AMBARI-17180
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> base_alert.py puts a warning into the log if there are properties referenced 
> in the HA nameservice or the alias which are not present in the 
> configuration. The absence of these properties is an indicator that the HA is 
> not enabled, it is not a cause for warning.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 6c8ca5a 
> 
> Diff: https://reviews.apache.org/r/48589/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster works fine. Unit tests are running fine too.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 48702: Add ability to set GET request directives

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48702/#review137633
---


Ship it!




Ship It!

- Jonathan Hurley


On June 14, 2016, 7:12 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48702/
> ---
> 
> (Updated June 14, 2016, 7:12 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Di Li, Jonathan Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-17224
> https://issues.apache.org/jira/browse/AMBARI-17224
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add ability to set GET request directives so that directives may be specified 
> in a GET requests. For example, to limit or increase the amount of work 
> needed to be performed internally to generate the data being returned.
> 
> Most data in GET requests are retrieved but filtered from the response based 
> on the predicate. This means that any data the requires significant 
> processing to calculate will be calculated regardless of the requested 
> fields. By using a directive this can be controlled.
> 
> Note: It may be possible the use of a PropertyProvider to control this 
> instead, but that may not be desired in all cases.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/ReadHandler.java
>  95e45d6 
>   ambari-server/src/main/java/org/apache/ambari/server/api/query/Query.java 
> fff842a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java 
> 18fd94b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
>  dcc5217 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java
>  8df1a02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/SimpleResourceDefinition.java
>  394e295 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/UpgradeResourceDefinition.java
>  bf7860b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
>  0ebeb19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
>  19fee8e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/handlers/ReadHandlerTest.java
>  5cb601e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
>  f174cb6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/SimpleResourceDefinitionTest.java
>  6169ee7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java
>  11568c9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java
>  2642418 
> 
> Diff: https://reviews.apache.org/r/48702/diff/
> 
> 
> Testing
> ---
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:25:36.424s
> [INFO] Finished at: Tue Jun 14 14:53:08 EDT 2016
> [INFO] Final Memory: 59M/1864M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 48516: SPNEGO keytab and principal configuration for HBase web UIs

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48516/#review137637
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 9, 2016, 11 p.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48516/
> ---
> 
> (Updated June 9, 2016, 11 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-17129
> https://issues.apache.org/jira/browse/AMBARI-17129
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adds the SPNEGO principal and keytab to hbase-site.xml to make it simple for 
> users to enable SPNEGO authentication for HBase web UIs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  5016325 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/alerts.json 
> 50a7ceb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 8be8bda 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  c221138 
> 
> Diff: https://reviews.apache.org/r/48516/diff/
> 
> 
> Testing
> ---
> 
> Java unit tests and a simple virtual-machine installation of 2.4.0. Verified 
> that expected configuration properties are present.
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Re: Review Request 47954: AMBARI-16907 Ambari web UI does not auto-set all required properties when user toggles on the Yarn CPU isolation feature on the web UI

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47954/#review137638
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 13, 2016, 2:39 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47954/
> ---
> 
> (Updated June 13, 2016, 2:39 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jayush 
> Luniya, and Vinod Kumar Vavilapalli.
> 
> 
> Bugs: AMBARI-16907
> https://issues.apache.org/jira/browse/AMBARI-16907
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The document here mentioned five properties that need to be updated when the 
> CGroups with Yarn feature is enabled via Ambari web UI. 
> http://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/NodeManagerCgroups.html
> 
> Right now, however, only one is auto-changed – 
> "yarn.nodemanager.container-executor.class".
> 
> This is due to a mix of yarn-site.xml metainfo change and the properties name 
> used in the stack_advisor.py
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
>  905383a 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 03e8150 
> 
> Diff: https://reviews.apache.org/r/47954/diff/
> 
> 
> Testing
> ---
> 
> manually patch a trunk cluster with changes and tested that with the changes, 
> all CGroup required properties are changed when I enabled CPU isolation on 
> the Yarn config tab.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

[Jungtaek Lim]

> On 6 10, 2016, 11:56 오후, Aravindan Vijayan wrote:
> > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/AbstractTimelineMetricsSeriesAggregateFunction.java,
> >  line 73
> > 
> >
> > When the data is not timestamp aligned, this will lead to "difficult to 
> > comprehend" graphs.
> > 
> > For example, let's take Sum of Metrics M1,M2,M3 where
> > M1 - t1 - 5.0
> > M1 - t2 - 5.0
> > M2 - t2 - 5.0
> > M3 - t3 - 5.0
> > 
> > The graph will show up like 
> > (t1, 5.0) -> (t2,10.0) -> (t3,5.0)
> > 
> > That is why we do some "interpolation" while we aggregate data.
> 
> Jungtaek Lim wrote:
> Yeah, I agree that output could be odd when data is not timestamp 
> aligned. 
> I didn't think about this side while working, and also I'm not expert on 
> this.
> How AMS interpolate points when aggregating? Does it apply linear 
> interpolation?

I've talked with Aravindan regarding this.
There's no issue unless hostname is not empty & timeRange <= 2hrs since other 
cases are referencing aggregated tables which are already timestamp aligned and 
interpolated.
For that case it refers raw record table so need to apply interpolation. Need 
to discuss and resolve this case before or later this patch.


- Jungtaek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48395/#review137086
---


On 6 10, 2016, 12:50 오전, Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48395/
> ---
> 
> (Updated 6 10, 2016, 12:50 오전)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Prajwal Rao, 
> Sriharsha Chintalapani, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17027
> https://issues.apache.org/jira/browse/AMBARI-17027
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMS doesn't provide tag so metric is identified by appId, metric name, 
> hostname, instanceId. In this situation metric name is normally consist of 
> origin metric name and tag values, like graphite, but unlike Graphite, AMS 
> also doesn't provide series aggregation functions so aggregation should be 
> done from caller side.
> 
> It would be great if Ambari Metrics Collector provides series aggregation 
> functions, like sumSeries / 
> averageSeries / minSeries / maxSeries on Graphite.
> 
> Query outputs: 
> https://gist.github.com/HeartSaVioR/f4f28b5b8b7bf2e5477e59d7fd56090f
> 
> Attached Grafana screenshots to AMBARI-17027. Please refer 
> https://issues.apache.org/jira/browse/AMBARI-17027 for details.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 7390aa8 
>   
> ambari-metrics/ambari-metrics-grafana/ambari-metrics/partials/query.editor.html
>  b034c03 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js 2eb3613 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  1b2d02f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  e37bc4d 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java
>  7d49070 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/AbstractTimelineMetricsSeriesAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/SeriesAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunctionFactory.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAvgAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timelin

Re: Review Request 48706: 'ambari-server --version' command does not show build number

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48706/#review137654
---


Ship it!




Ship It!

- Sumit Mohanty


On June 14, 2016, 7:41 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48706/
> ---
> 
> (Updated June 14, 2016, 7:41 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 'ambari-server --version' command does not show build number
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml b488971 
>   ambari-server/sbin/ambari-server 83a52c6 
> 
> Diff: https://reviews.apache.org/r/48706/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48395/#review137656
---


Ship it!




Backend changes look ok. I would recommend a 'Ship It' from a UI developer as 
well.

- Aravindan Vijayan


On June 10, 2016, 12:50 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48395/
> ---
> 
> (Updated June 10, 2016, 12:50 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Prajwal Rao, 
> Sriharsha Chintalapani, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17027
> https://issues.apache.org/jira/browse/AMBARI-17027
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMS doesn't provide tag so metric is identified by appId, metric name, 
> hostname, instanceId. In this situation metric name is normally consist of 
> origin metric name and tag values, like graphite, but unlike Graphite, AMS 
> also doesn't provide series aggregation functions so aggregation should be 
> done from caller side.
> 
> It would be great if Ambari Metrics Collector provides series aggregation 
> functions, like sumSeries / 
> averageSeries / minSeries / maxSeries on Graphite.
> 
> Query outputs: 
> https://gist.github.com/HeartSaVioR/f4f28b5b8b7bf2e5477e59d7fd56090f
> 
> Attached Grafana screenshots to AMBARI-17027. Please refer 
> https://issues.apache.org/jira/browse/AMBARI-17027 for details.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 7390aa8 
>   
> ambari-metrics/ambari-metrics-grafana/ambari-metrics/partials/query.editor.html
>  b034c03 
>   ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js 2eb3613 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  1b2d02f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  e37bc4d 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java
>  7d49070 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/AbstractTimelineMetricsSeriesAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/SeriesAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunctionFactory.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAvgAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMaxAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMinAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesSumAggregateFunction.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
>  ee3a097 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
>  cfd1f58 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java
>  a94f4c5 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunctionTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48395/diff/
> 
> 
> Te

Re: Review Request 48670: Return well formatted error response while deleting host with clients installed.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48670/#review137660
---




ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 


Basically, the host delete call fails if master and slaves exist (no matter 
whats the state). So it did not make much sense to allow host delete if they 
have just clients. Rather:
- let host delete fail if any host component exist
- allow a bulk delete of host components


- Sumit Mohanty


On June 14, 2016, 12:29 a.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48670/
> ---
> 
> (Updated June 14, 2016, 12:29 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17210
> https://issues.apache.org/jira/browse/AMBARI-17210
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Return well formatted error response while deleting host with clients 
> installed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  46fc65295f72bae39c534cd9684f2d76d1e30224 
> 
> Diff: https://reviews.apache.org/r/48670/diff/
> 
> 
> Testing
> ---
> 
> Manual testing
> 
> delete 
> http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/hosts/c6403.ambari.apache.org
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: An 
> internal system exception occurred: Cannot remove host 
> c6403.ambari.apache.org from c1.  The following roles exist, and these 
> components must be stopped if running, and then deleted: HDFS_CLIENT, 
> MAPREDUCE2_CLIENT, YARN_CLIENT, ZOOKEEPER_CLIENT"
> }
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 48685: AMBARI-17218 Show message of Audit to DB Removal during upgrade for Ranger

[Mugdha Varadkar]

> On June 14, 2016, 1:03 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java,
> >  line 35
> > 
> >
> > Maybe make a new UpgradeCheckGroup for this - it's an information 
> > warning that something is happening during the upgrade. We might want to 
> > begin organizing these types of messages. Maybe 
> > UpgradeCheckGroup.INFORMATIONAL_WARNING

Updated in latest patch


> On June 14, 2016, 1:03 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java,
> >  line 279
> > 
> >
> > This is a bit confusing. Maybe revise as "Remove the Ranger Audit to 
> > Database Capability"

Updated in latest patch


> On June 14, 2016, 1:03 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java,
> >  lines 282-283
> > 
> >
> > Hmmm - we're giving instructions here that the admin must run something 
> > after upgrade. Typically, that's not going to happen and they'll forget. 
> > What are the consequences? Can this be done by the python code?

The instructions are for migration of audits from DB to Solr. If they dont do 
it, they will not see these logs on the Ranger UI, however they will still be 
available in the audit DB.
This was designed not to be done as part of upgrade since the volume of audits 
are generally huge and it might block the entire upgrade.


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48685/#review137496
---


On June 15, 2016, 5:13 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48685/
> ---
> 
> (Updated June 15, 2016, 5:13 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Srimanth Gunturi, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17218
> https://issues.apache.org/jira/browse/AMBARI-17218
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Show Warning message before upgrade to stack 2.5
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  850b58a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java
>  34d016e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  464c444 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> dd04b64 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  27461e8 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> ad1bc34 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/RangerAuditDbCheckTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48685/diff/
> 
> 
> Testing
> ---
> 
> Tested upgrade from 2.4 to 2.5
> 
> 
> ---
>  T E S T S
> ---
> Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m 
> -Djava.awt.headless=true
> Running org.apache.ambari.server.checks.RangerAuditDbCheckTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.743 sec - 
> in org.apache.ambari.server.checks.RangerAuditDbCheckTest
> 
> Results :
> 
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48685: AMBARI-17218 Show message of Audit to DB Removal during upgrade for Ranger

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48685/
---

(Updated June 15, 2016, 5:13 a.m.)


Review request for Ambari, Gautam Borad, Jonathan Hurley, Srimanth Gunturi, and 
Velmurugan Periasamy.


Changes
---

Handle Jonathan Hurley comments


Bugs: AMBARI-17218
https://issues.apache.org/jira/browse/AMBARI-17218


Repository: ambari


Description
---

Show Warning message before upgrade to stack 2.5


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 850b58a 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java
 34d016e 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 464c444 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
dd04b64 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 27461e8 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
ad1bc34 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/RangerAuditDbCheckTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/48685/diff/


Testing
---

Tested upgrade from 2.4 to 2.5


---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.server.checks.RangerAuditDbCheckTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.743 sec - in 
org.apache.ambari.server.checks.RangerAuditDbCheckTest

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Mugdha Varadkar

Re: Review Request 48460: Ambari Views logs should include information of view instance

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48460/#review137668
---


Ship it!




Ship It!

- Gaurav Nagar


On June 14, 2016, 5:08 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48460/
> ---
> 
> (Updated June 14, 2016, 5:08 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17135
> https://issues.apache.org/jira/browse/AMBARI-17135
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> added servlet filter and used Logging frameworks MDC feature to insert view 
> related information from URL. Updated view log4j files for the same.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  961b6fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/AmbariViewsMDCLoggingFilter.java
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
> 32903d3 
>   contrib/views/files/src/main/resources/view.log4j.properties 698947e 
>   contrib/views/hive-next/src/main/resources/view.log4j.properties b1bd5f2 
>   contrib/views/hive/src/main/resources/view.log4j.properties 16c2d0e 
>   contrib/views/hueambarimigration/src/main/resources/view.log4j.properties 
> 3e959e7 
>   contrib/views/jobs/src/main/resources/view.log4j.properties 86687d6 
>   contrib/views/pig/src/main/resources/view.log4j.properties 5b23a48 
>   contrib/views/slider/src/main/resources/view.log4j.properties 4737032 
>   contrib/views/storm/src/main/resources/view.log4j.properties 309df8d 
>   contrib/views/tez/src/main/resources/view.log4j.properties 08e00bd 
>   contrib/views/zeppelin/src/main/resources/view.log4j.properties 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48460/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>