date:20160829

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-29 Thread Santhosh Kumar Shanmugham



> On Aug. 29, 2016, 11:52 a.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 193
> > 
> >
> > Am I missing something? Shouldn't this be a set of `Metadata` structs? 
> > rather than a set of strings which is what this will currently pass?
> 
> Santhosh Kumar Shanmugham wrote:
> You are totally correct. Is there any way to make the python tests do 
> type-checking?
> 
> This however makes the "assert mock_calls" on mock_api to fail. python's 
> assert, TestCase.assertEquals and testfixtures.compare all are unable to deal 
> with Metadata object. Any ideas around this would be welcome.
> 
> Joshua Cohen wrote:
> I think what I would recommend is updating `_job_update_request` to take 
> a dict of metadata key/value pairs and performing the thrift conversion 
> there. That has the benefit of encapsulating knowledge of the thrift API 
> within the API client. It also means you should be able to assert on the dict 
> that's passed in test_supdate?
> 
> That said, simple equality on the generated thrift types should work? E.g.
> 
> $ PEX_INTERPRETER=1 aurora
> >>> from gen.apache.aurora.api.ttypes import Metadata
> >>> a = Metadata('foo', 'bar')
> >>> b = Metadata('foo', 'bar')
> >>> a == b
> True
> >>> c = Metadata('baz', 'qux')
> >>> a == c
> False

Items of a set are not getting deep equality check. Is there an 
assertDeepEquals() ?

$ PEX_INTERPRETER=1 aurora
>>> from gen.apache.aurora.api.ttypes import Metadata
>>> a = Metadata('foo', 'bar')
>>> b = Metadata('foo', 'bar')
>>> a == b
True
>>> {a} == {b}
False
>>> set([a]) == set([b])
False
>>> set([a]) == set([a])
True


- Santhosh Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51384/#review147184
---


On Aug. 27, 2016, 8:58 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51384/
> ---
> 
> (Updated Aug. 27, 2016, 8:58 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Maxim 
> Khutornenko.
> 
> 
> Bugs: AURORA-1711
> https://issues.apache.org/jira/browse/AURORA-1711
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow custom metadata to be stored with the job updates. This feature
> is to help case the reconciliation on job update request on the clients.
> 
> Today when a client's requests are proxied via a middle-man,
> if the middle-man times out before the scheduler responds with success,
> the client is left the only option of retry. In the case of updates,
> since multiple updates are not allowed in parallel, the retries fail,
> with INVALID_REQUEST. Although the original update is already accepted
> by the scheduler and is in-progress.
> 
> With this feature, clients can reconcile the job updates,
> - by marking updates them with a unique id in the metadata field
> - scheduler returns the in-progress job update in its response
> - client can match the client-generated ids to reconcile its state.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 
> d2673e6b328cb1e249fbe91d18e0d9e935636eaa 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
>  a3b04949f1726f110638e4f93ef45947cdb9e7f8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V008_CreateUpdateMetadataTable.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java 
> 78703e92c932cd5e93ff0b70f2a0b6928f6b4003 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  929d021a336c6a3438613c9340c84a1096dc9069 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  594bb6219294dcc77d48dcad14e2a6f9caa0c534 
>   
> src/main/java/org/apache/aurora/scheduler/updater/UpdateInProgressException.java
>  PRE-CREATION 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 9149c3018ae58d405f284fcbd4076d251ccc8192 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 542f165add0f1d01a782fe6d6089bff3e736fb82 
>   
>

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-29 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51513/#review147256
---


Ship it!




Master (c34f78a) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 30, 2016, 1:12 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51513/
> ---
> 
> (Updated Aug. 30, 2016, 1:12 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1757
> https://issues.apache.org/jira/browse/AURORA-1757
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch enhances the Aurora API by producing an `ETag` header for each API
> request. It also consumes etag values in API requests via the `If-None-Match`
> header and produces a HTTP 304 if the request would produce a body with the 
> same
> etag value.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java 
> 1634cb88ac09c778c5bb277ca902f4ca35dd6c9d 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 
> 0a3ff05586c87e0ab2cc20470e99b5dd609f7039 
> 
> Diff: https://reviews.apache.org/r/51513/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-29 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51513/#review147255
---




src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java 
(lines 139 - 142)


Am I reading this correctly: you're buffering the entire response in memory 
so we can calculate the hash for the etag? Do you envision this causing memory 
pressure for larger responses (especially given that the goal here is to 
optimize for the case where responses are large enough that sending them on the 
wire and processing them on the client side is causing a perf problem)?

At the very least, perhaps we should only buffer the response if the 
`If-None-Match` header is set?


- Joshua Cohen


On Aug. 30, 2016, 1:12 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51513/
> ---
> 
> (Updated Aug. 30, 2016, 1:12 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1757
> https://issues.apache.org/jira/browse/AURORA-1757
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch enhances the Aurora API by producing an `ETag` header for each API
> request. It also consumes etag values in API requests via the `If-None-Match`
> header and produces a HTTP 304 if the request would produce a body with the 
> same
> etag value.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java 
> 1634cb88ac09c778c5bb277ca902f4ca35dd6c9d 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 
> 0a3ff05586c87e0ab2cc20470e99b5dd609f7039 
> 
> Diff: https://reviews.apache.org/r/51513/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-29 Thread Joshua Cohen



> On Aug. 29, 2016, 6:52 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 193
> > 
> >
> > Am I missing something? Shouldn't this be a set of `Metadata` structs? 
> > rather than a set of strings which is what this will currently pass?
> 
> Santhosh Kumar Shanmugham wrote:
> You are totally correct. Is there any way to make the python tests do 
> type-checking?
> 
> This however makes the "assert mock_calls" on mock_api to fail. python's 
> assert, TestCase.assertEquals and testfixtures.compare all are unable to deal 
> with Metadata object. Any ideas around this would be welcome.

I think what I would recommend is updating `_job_update_request` to take a dict 
of metadata key/value pairs and performing the thrift conversion there. That 
has the benefit of encapsulating knowledge of the thrift API within the API 
client. It also means you should be able to assert on the dict that's passed in 
test_supdate?

That said, simple equality on the generated thrift types should work? E.g.

$ PEX_INTERPRETER=1 aurora
>>> from gen.apache.aurora.api.ttypes import Metadata
>>> a = Metadata('foo', 'bar')
>>> b = Metadata('foo', 'bar')
>>> a == b
True
>>> c = Metadata('baz', 'qux')
>>> a == c
False


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51384/#review147184
---


On Aug. 28, 2016, 3:58 a.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51384/
> ---
> 
> (Updated Aug. 28, 2016, 3:58 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Maxim 
> Khutornenko.
> 
> 
> Bugs: AURORA-1711
> https://issues.apache.org/jira/browse/AURORA-1711
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow custom metadata to be stored with the job updates. This feature
> is to help case the reconciliation on job update request on the clients.
> 
> Today when a client's requests are proxied via a middle-man,
> if the middle-man times out before the scheduler responds with success,
> the client is left the only option of retry. In the case of updates,
> since multiple updates are not allowed in parallel, the retries fail,
> with INVALID_REQUEST. Although the original update is already accepted
> by the scheduler and is in-progress.
> 
> With this feature, clients can reconcile the job updates,
> - by marking updates them with a unique id in the metadata field
> - scheduler returns the in-progress job update in its response
> - client can match the client-generated ids to reconcile its state.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 
> d2673e6b328cb1e249fbe91d18e0d9e935636eaa 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
>  a3b04949f1726f110638e4f93ef45947cdb9e7f8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V008_CreateUpdateMetadataTable.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java 
> 78703e92c932cd5e93ff0b70f2a0b6928f6b4003 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  929d021a336c6a3438613c9340c84a1096dc9069 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  594bb6219294dcc77d48dcad14e2a6f9caa0c534 
>   
> src/main/java/org/apache/aurora/scheduler/updater/UpdateInProgressException.java
>  PRE-CREATION 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 9149c3018ae58d405f284fcbd4076d251ccc8192 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 542f165add0f1d01a782fe6d6089bff3e736fb82 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  8563630a179cb6d1e3b0e22c730ccbfe1c9291e2 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> a40830fd668aa650c22a48cbc757b45aef27e961 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  08530397ff75081bde6f07f9d53317b5486e0da4 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>

Re: Review Request 51513: Add support for ETags in the Aurora API.

2016-08-29 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51513/#review147253
---



Reviewers: This is a simple implementation, but I think it works well. I'm 
willing to add e2e tests and other changes to validate this works via curl if 
required.

Feel free to comment on the idea in the associated ticket.

- Zameer Manji


On Aug. 29, 2016, 6:12 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51513/
> ---
> 
> (Updated Aug. 29, 2016, 6:12 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1757
> https://issues.apache.org/jira/browse/AURORA-1757
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch enhances the Aurora API by producing an `ETag` header for each API
> request. It also consumes etag values in API requests via the `If-None-Match`
> header and produces a HTTP 304 if the request would produce a body with the 
> same
> etag value.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java 
> 1634cb88ac09c778c5bb277ca902f4ca35dd6c9d 
>   src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 
> 0a3ff05586c87e0ab2cc20470e99b5dd609f7039 
> 
> Diff: https://reviews.apache.org/r/51513/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Review Request 51513: Add support for ETags in the Aurora API.

2016-08-29 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51513/
---

Review request for Aurora, Joshua Cohen and Stephan Erb.


Bugs: AURORA-1757
https://issues.apache.org/jira/browse/AURORA-1757


Repository: aurora


Description
---

This patch enhances the Aurora API by producing an `ETag` header for each API
request. It also consumes etag values in API requests via the `If-None-Match`
header and produces a HTTP 304 if the request would produce a body with the same
etag value.


Diffs
-

  RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
  src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java 
1634cb88ac09c778c5bb277ca902f4ca35dd6c9d 
  src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 
0a3ff05586c87e0ab2cc20470e99b5dd609f7039 

Diff: https://reviews.apache.org/r/51513/diff/


Testing
---


Thanks,

Zameer Manji

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-29 Thread Santhosh Kumar Shanmugham



> On Aug. 29, 2016, 11:52 a.m., Joshua Cohen wrote:
> > src/test/python/apache/aurora/client/cli/test_supdate.py, line 156
> > 
> >
> > since we're mocking this anyway, no real need to generate an actual 
> > uuid, can just have the mock return something like 'some-mocked-uuid'. 
> > That'll make it a little bit more clear, in the event of a failure, that 
> > the value was a mock and not coming from live code.

Done.


> On Aug. 29, 2016, 11:52 a.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 193
> > 
> >
> > Am I missing something? Shouldn't this be a set of `Metadata` structs? 
> > rather than a set of strings which is what this will currently pass?

You are totally correct. Is there any way to make the python tests do 
type-checking?

This however makes the "assert mock_calls" on mock_api to fail. python's 
assert, TestCase.assertEquals and testfixtures.compare all are unable to deal 
with Metadata object. Any ideas around this would be welcome.


- Santhosh Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51384/#review147184
---


On Aug. 27, 2016, 8:58 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51384/
> ---
> 
> (Updated Aug. 27, 2016, 8:58 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Maxim 
> Khutornenko.
> 
> 
> Bugs: AURORA-1711
> https://issues.apache.org/jira/browse/AURORA-1711
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow custom metadata to be stored with the job updates. This feature
> is to help case the reconciliation on job update request on the clients.
> 
> Today when a client's requests are proxied via a middle-man,
> if the middle-man times out before the scheduler responds with success,
> the client is left the only option of retry. In the case of updates,
> since multiple updates are not allowed in parallel, the retries fail,
> with INVALID_REQUEST. Although the original update is already accepted
> by the scheduler and is in-progress.
> 
> With this feature, clients can reconcile the job updates,
> - by marking updates them with a unique id in the metadata field
> - scheduler returns the in-progress job update in its response
> - client can match the client-generated ids to reconcile its state.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 
> d2673e6b328cb1e249fbe91d18e0d9e935636eaa 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
>  a3b04949f1726f110638e4f93ef45947cdb9e7f8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V008_CreateUpdateMetadataTable.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java 
> 78703e92c932cd5e93ff0b70f2a0b6928f6b4003 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  929d021a336c6a3438613c9340c84a1096dc9069 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  594bb6219294dcc77d48dcad14e2a6f9caa0c534 
>   
> src/main/java/org/apache/aurora/scheduler/updater/UpdateInProgressException.java
>  PRE-CREATION 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 9149c3018ae58d405f284fcbd4076d251ccc8192 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 542f165add0f1d01a782fe6d6089bff3e736fb82 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  8563630a179cb6d1e3b0e22c730ccbfe1c9291e2 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> a40830fd668aa650c22a48cbc757b45aef27e961 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  08530397ff75081bde6f07f9d53317b5486e0da4 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  779dc302602ae8842084807ca868a491ea99b676 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 04551f17999d742c53dfb1b36286b119b448550e 
>   src/test/python/apache/aurora/client/cli/test_supdate.py

Re: Review Request 51506: Enable -zk_use_curator by default and deprecate.

2016-08-29 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51506/#review147247
---



Master (c34f78a) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 29, 2016, 11:37 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51506/
> ---
> 
> (Updated Aug. 29, 2016, 11:37 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1669
> https://issues.apache.org/jira/browse/AURORA-1669
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The flag is noted as deprecated for removal in 0.17.0.
> 
>  RELEASE-NOTES.md 
>|  2 ++
>  docs/reference/scheduler-configuration.md
>|  4 ++--
>  examples/vagrant/upstart/aurora-scheduler.conf   
>|  1 -
>  
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>  | 11 +--
>  4 files changed, 13 insertions(+), 5 deletions(-)
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
>   docs/reference/scheduler-configuration.md 
> c0c39442725c970e5f9811cd7b4ab3104364c671 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> dd60981564286e5b25546737fdd0ce08b0168ed4 
>   
> src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java
>  36ad18c49c5693031136440ab163070f9ffa9405 
> 
> Diff: https://reviews.apache.org/r/51506/diff/
> 
> 
> Testing
> ---
> 
> Locally green:
> ```
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Re: Review Request 51499: Update 3dparty Python dependencies

2016-08-29 Thread John Sirois



> On Aug. 29, 2016, 4:04 p.m., Aurora ReviewBot wrote:
> > Master (c34f78a) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 
> > cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 
> > lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7 pathspec-0.3.4 pex-1.1.10 
> > psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 
> > pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 
> > setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.7 
> > twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7 
> > twitter.common.lang-0.3.7 twitter.common.log-0.3.7 
> > twitter.common.options-0.3.7
> > 
> > 22:03:11 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 22:03:11 00:00   [setup]
> > 22:03:11 00:00 [parse][32m
> >Executing tasks in goals: compile[0m
> > 22:03:11 00:00   [compile]
> > 22:03:11 00:00 [compile-prep-command]
> > 22:03:11 00:00 [compile]
> > 22:03:11 00:00 [python-eval]
> > 22:03:11 00:00 [pythonstyle]
> > 22:03:11 00:00   [cache]  [32m
> >No cached artifacts for 42 targets.[0m[32m
> >Invalidated 42 targets.[0m
> > 22:03:34 00:23   [complete][32m
> >SUCCESS[0m
> > + ./pants test.pytest 
> > --junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results
> >  src/main/python:: src/test/python:: -- -v
> > 
> > 22:03:35 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 22:03:35 00:00   [setup]
> > 22:03:35 00:00 [parse][32m
> >Executing tasks in goals: test[0m
> > 22:03:35 00:00   [test]
> > 22:03:35 00:00 [test-prep-command]
> > 22:03:35 00:00 [test]
> > 22:03:35 00:00 [pytest]
> > 22:03:35 00:00   [run]
> >  
> > 22:03:38 00:03 [chroot]INFO] Attempting to fetch thrift binary 
> > from: 
> > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
> >  ...
> > 
  2% .610 KB
  4% ..  1220 KB
  6% ... 1830 KB
  8% 2440 KB
 10% .   3050 KB
 12% ..  3660 KB
 14% ... 4260 KB
 16% 4870 KB
 18% .   5480 KB
 20% ..  6090 KB
 22% ... 6700 KB
 24% 7310 KB
 26% .   7920 KB
 28% ..  8520 KB
 30% ... 9130 KB
 32% 9740 KB
 34% .  10350 KB
 36% .. 10960 KB
 38% ...11570 KB
 40%    12170 KB
 42% .  12780 KB
 44% .. 13390 KB
 46% ...14000 KB
 48%    14610 KB
 50% .  15220 KB
 52% .. 15830 KB
 54% ...16430 KB
 56%    17040 KB
 58% .  17650 KB
 60% .. 18260 KB
 62% ...18870 KB
 64%    19480 KB
 66% .  20090 KB
 68% .. 20690 KB
 70% ...21300 KB
 72%    21910 KB
 74% .  22520 KB
 76% .. 23130 KB
 78% ...23740 KB
 80%    24340 KB
 82% .  24950 KB
 84% .. 25560 KB
 86% ...26170 KB
 88%

Review Request 51506: Enable -zk_use_curator by default and deprecate.

2016-08-29 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51506/
---

Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.


Bugs: AURORA-1669
https://issues.apache.org/jira/browse/AURORA-1669


Repository: aurora


Description
---

The flag is noted as deprecated for removal in 0.17.0.

 RELEASE-NOTES.md   
 |  2 ++
 docs/reference/scheduler-configuration.md  
 |  4 ++--
 examples/vagrant/upstart/aurora-scheduler.conf 
 |  1 -
 
src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java 
| 11 +--
 4 files changed, 13 insertions(+), 5 deletions(-)


Diffs
-

  RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 
  docs/reference/scheduler-configuration.md 
c0c39442725c970e5f9811cd7b4ab3104364c671 
  examples/vagrant/upstart/aurora-scheduler.conf 
dd60981564286e5b25546737fdd0ce08b0168ed4 
  
src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java 
36ad18c49c5693031136440ab163070f9ffa9405 

Diff: https://reviews.apache.org/r/51506/diff/


Testing
---

Locally green:
```
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```


Thanks,

John Sirois

Re: Review Request 51499: Update 3dparty Python dependencies

2016-08-29 Thread John Sirois



> On Aug. 29, 2016, 4:04 p.m., Aurora ReviewBot wrote:
> > Master (c34f78a) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 
> > cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 
> > lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7 pathspec-0.3.4 pex-1.1.10 
> > psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 
> > pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 
> > setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.7 
> > twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7 
> > twitter.common.lang-0.3.7 twitter.common.log-0.3.7 
> > twitter.common.options-0.3.7
> > 
> > 22:03:11 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 22:03:11 00:00   [setup]
> > 22:03:11 00:00 [parse][32m
> >Executing tasks in goals: compile[0m
> > 22:03:11 00:00   [compile]
> > 22:03:11 00:00 [compile-prep-command]
> > 22:03:11 00:00 [compile]
> > 22:03:11 00:00 [python-eval]
> > 22:03:11 00:00 [pythonstyle]
> > 22:03:11 00:00   [cache]  [32m
> >No cached artifacts for 42 targets.[0m[32m
> >Invalidated 42 targets.[0m
> > 22:03:34 00:23   [complete][32m
> >SUCCESS[0m
> > + ./pants test.pytest 
> > --junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results
> >  src/main/python:: src/test/python:: -- -v
> > 
> > 22:03:35 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 22:03:35 00:00   [setup]
> > 22:03:35 00:00 [parse][32m
> >Executing tasks in goals: test[0m
> > 22:03:35 00:00   [test]
> > 22:03:35 00:00 [test-prep-command]
> > 22:03:35 00:00 [test]
> > 22:03:35 00:00 [pytest]
> > 22:03:35 00:00   [run]
> >  
> > 22:03:38 00:03 [chroot]INFO] Attempting to fetch thrift binary 
> > from: 
> > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
> >  ...
> > 
  2% .610 KB
  4% ..  1220 KB
  6% ... 1830 KB
  8% 2440 KB
 10% .   3050 KB
 12% ..  3660 KB
 14% ... 4260 KB
 16% 4870 KB
 18% .   5480 KB
 20% ..  6090 KB
 22% ... 6700 KB
 24% 7310 KB
 26% .   7920 KB
 28% ..  8520 KB
 30% ... 9130 KB
 32% 9740 KB
 34% .  10350 KB
 36% .. 10960 KB
 38% ...11570 KB
 40%    12170 KB
 42% .  12780 KB
 44% .. 13390 KB
 46% ...14000 KB
 48%    14610 KB
 50% .  15220 KB
 52% .. 15830 KB
 54% ...16430 KB
 56%    17040 KB
 58% .  17650 KB
 60% .. 18260 KB
 62% ...18870 KB
 64%    19480 KB
 66% .  20090 KB
 68% .. 20690 KB
 70% ...21300 KB
 72%    21910 KB
 74% .  22520 KB
 76% .. 23130 KB
 78% ...23740 KB
 80%    24340 KB
 82% .  24950 KB
 84% .. 25560 KB
 86% ...26170 KB
 88%

Re: Review Request 51499: Update 3dparty Python dependencies

2016-08-29 Thread John Sirois



> On Aug. 29, 2016, 4:04 p.m., Aurora ReviewBot wrote:
> > Master (c34f78a) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 
> > cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 
> > lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7 pathspec-0.3.4 pex-1.1.10 
> > psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 
> > pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 
> > setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.7 
> > twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7 
> > twitter.common.lang-0.3.7 twitter.common.log-0.3.7 
> > twitter.common.options-0.3.7
> > 
> > 22:03:11 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 22:03:11 00:00   [setup]
> > 22:03:11 00:00 [parse][32m
> >Executing tasks in goals: compile[0m
> > 22:03:11 00:00   [compile]
> > 22:03:11 00:00 [compile-prep-command]
> > 22:03:11 00:00 [compile]
> > 22:03:11 00:00 [python-eval]
> > 22:03:11 00:00 [pythonstyle]
> > 22:03:11 00:00   [cache]  [32m
> >No cached artifacts for 42 targets.[0m[32m
> >Invalidated 42 targets.[0m
> > 22:03:34 00:23   [complete][32m
> >SUCCESS[0m
> > + ./pants test.pytest 
> > --junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results
> >  src/main/python:: src/test/python:: -- -v
> > 
> > 22:03:35 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 22:03:35 00:00   [setup]
> > 22:03:35 00:00 [parse][32m
> >Executing tasks in goals: test[0m
> > 22:03:35 00:00   [test]
> > 22:03:35 00:00 [test-prep-command]
> > 22:03:35 00:00 [test]
> > 22:03:35 00:00 [pytest]
> > 22:03:35 00:00   [run]
> >  
> > 22:03:38 00:03 [chroot]INFO] Attempting to fetch thrift binary 
> > from: 
> > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
> >  ...
> > 
  2% .610 KB
  4% ..  1220 KB
  6% ... 1830 KB
  8% 2440 KB
 10% .   3050 KB
 12% ..  3660 KB
 14% ... 4260 KB
 16% 4870 KB
 18% .   5480 KB
 20% ..  6090 KB
 22% ... 6700 KB
 24% 7310 KB
 26% .   7920 KB
 28% ..  8520 KB
 30% ... 9130 KB
 32% 9740 KB
 34% .  10350 KB
 36% .. 10960 KB
 38% ...11570 KB
 40%    12170 KB
 42% .  12780 KB
 44% .. 13390 KB
 46% ...14000 KB
 48%    14610 KB
 50% .  15220 KB
 52% .. 15830 KB
 54% ...16430 KB
 56%    17040 KB
 58% .  17650 KB
 60% .. 18260 KB
 62% ...18870 KB
 64%    19480 KB
 66% .  20090 KB
 68% .. 20690 KB
 70% ...21300 KB
 72%    21910 KB
 74% .  22520 KB
 76% .. 23130 KB
 78% ...23740 KB
 80%    24340 KB
 82% .  24950 KB
 84% .. 25560 KB
 86% ...26170 KB
 88%

Re: Review Request 51499: Update 3dparty Python dependencies

2016-08-29 Thread John Sirois



> On Aug. 29, 2016, 4:04 p.m., Aurora ReviewBot wrote:
> > Master (c34f78a) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 
> > cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 
> > lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7 pathspec-0.3.4 pex-1.1.10 
> > psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 
> > pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 
> > setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.7 
> > twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7 
> > twitter.common.lang-0.3.7 twitter.common.log-0.3.7 
> > twitter.common.options-0.3.7
> > 
> > 22:03:11 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 22:03:11 00:00   [setup]
> > 22:03:11 00:00 [parse][32m
> >Executing tasks in goals: compile[0m
> > 22:03:11 00:00   [compile]
> > 22:03:11 00:00 [compile-prep-command]
> > 22:03:11 00:00 [compile]
> > 22:03:11 00:00 [python-eval]
> > 22:03:11 00:00 [pythonstyle]
> > 22:03:11 00:00   [cache]  [32m
> >No cached artifacts for 42 targets.[0m[32m
> >Invalidated 42 targets.[0m
> > 22:03:34 00:23   [complete][32m
> >SUCCESS[0m
> > + ./pants test.pytest 
> > --junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results
> >  src/main/python:: src/test/python:: -- -v
> > 
> > 22:03:35 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 22:03:35 00:00   [setup]
> > 22:03:35 00:00 [parse][32m
> >Executing tasks in goals: test[0m
> > 22:03:35 00:00   [test]
> > 22:03:35 00:00 [test-prep-command]
> > 22:03:35 00:00 [test]
> > 22:03:35 00:00 [pytest]
> > 22:03:35 00:00   [run]
> >  
> > 22:03:38 00:03 [chroot]INFO] Attempting to fetch thrift binary 
> > from: 
> > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
> >  ...
> > 
  2% .610 KB
  4% ..  1220 KB
  6% ... 1830 KB
  8% 2440 KB
 10% .   3050 KB
 12% ..  3660 KB
 14% ... 4260 KB
 16% 4870 KB
 18% .   5480 KB
 20% ..  6090 KB
 22% ... 6700 KB
 24% 7310 KB
 26% .   7920 KB
 28% ..  8520 KB
 30% ... 9130 KB
 32% 9740 KB
 34% .  10350 KB
 36% .. 10960 KB
 38% ...11570 KB
 40%    12170 KB
 42% .  12780 KB
 44% .. 13390 KB
 46% ...14000 KB
 48%    14610 KB
 50% .  15220 KB
 52% .. 15830 KB
 54% ...16430 KB
 56%    17040 KB
 58% .  17650 KB
 60% .. 18260 KB
 62% ...18870 KB
 64%    19480 KB
 66% .  20090 KB
 68% .. 20690 KB
 70% ...21300 KB
 72%    21910 KB
 74% .  22520 KB
 76% .. 23130 KB
 78% ...23740 KB
 80%    24340 KB
 82% .  24950 KB
 84% .. 25560 KB
 86% ...26170 KB
 88%

Re: Review Request 51499: Update 3dparty Python dependencies

2016-08-29 Thread Stephan Erb



> On Aug. 30, 2016, 12:04 vorm., Aurora ReviewBot wrote:
> > Master (c34f78a) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 
> > cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 
> > lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7 pathspec-0.3.4 pex-1.1.10 
> > psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 
> > pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 
> > setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.7 
> > twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7 
> > twitter.common.lang-0.3.7 twitter.common.log-0.3.7 
> > twitter.common.options-0.3.7
> > 
> > 22:03:11 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 22:03:11 00:00   [setup]
> > 22:03:11 00:00 [parse][32m
> >Executing tasks in goals: compile[0m
> > 22:03:11 00:00   [compile]
> > 22:03:11 00:00 [compile-prep-command]
> > 22:03:11 00:00 [compile]
> > 22:03:11 00:00 [python-eval]
> > 22:03:11 00:00 [pythonstyle]
> > 22:03:11 00:00   [cache]  [32m
> >No cached artifacts for 42 targets.[0m[32m
> >Invalidated 42 targets.[0m
> > 22:03:34 00:23   [complete][32m
> >SUCCESS[0m
> > + ./pants test.pytest 
> > --junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results
> >  src/main/python:: src/test/python:: -- -v
> > 
> > 22:03:35 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 22:03:35 00:00   [setup]
> > 22:03:35 00:00 [parse][32m
> >Executing tasks in goals: test[0m
> > 22:03:35 00:00   [test]
> > 22:03:35 00:00 [test-prep-command]
> > 22:03:35 00:00 [test]
> > 22:03:35 00:00 [pytest]
> > 22:03:35 00:00   [run]
> >  
> > 22:03:38 00:03 [chroot]INFO] Attempting to fetch thrift binary 
> > from: 
> > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
> >  ...
> > 
  2% .610 KB
  4% ..  1220 KB
  6% ... 1830 KB
  8% 2440 KB
 10% .   3050 KB
 12% ..  3660 KB
 14% ... 4260 KB
 16% 4870 KB
 18% .   5480 KB
 20% ..  6090 KB
 22% ... 6700 KB
 24% 7310 KB
 26% .   7920 KB
 28% ..  8520 KB
 30% ... 9130 KB
 32% 9740 KB
 34% .  10350 KB
 36% .. 10960 KB
 38% ...11570 KB
 40%    12170 KB
 42% .  12780 KB
 44% .. 13390 KB
 46% ...14000 KB
 48%    14610 KB
 50% .  15220 KB
 52% .. 15830 KB
 54% ...16430 KB
 56%    17040 KB
 58% .  17650 KB
 60% .. 18260 KB
 62% ...18870 KB
 64%    19480 KB
 66% .  20090 KB
 68% .. 20690 KB
 70% ...21300 KB
 72%    21910 KB
 74% .  22520 KB
 76% .. 23130 KB
 78% ...23740 KB
 80%    24340 KB
 82% .  24950 KB
 84% .. 25560 KB
 86% ...26170 KB
 88%

Re: Review Request 51499: Update 3dparty Python dependencies

2016-08-29 Thread John Sirois



> On Aug. 29, 2016, 4:04 p.m., Aurora ReviewBot wrote:
> > Master (c34f78a) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 
> > cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 
> > lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7 pathspec-0.3.4 pex-1.1.10 
> > psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 
> > pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 
> > setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.7 
> > twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7 
> > twitter.common.lang-0.3.7 twitter.common.log-0.3.7 
> > twitter.common.options-0.3.7
> > 
> > 22:03:11 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 22:03:11 00:00   [setup]
> > 22:03:11 00:00 [parse][32m
> >Executing tasks in goals: compile[0m
> > 22:03:11 00:00   [compile]
> > 22:03:11 00:00 [compile-prep-command]
> > 22:03:11 00:00 [compile]
> > 22:03:11 00:00 [python-eval]
> > 22:03:11 00:00 [pythonstyle]
> > 22:03:11 00:00   [cache]  [32m
> >No cached artifacts for 42 targets.[0m[32m
> >Invalidated 42 targets.[0m
> > 22:03:34 00:23   [complete][32m
> >SUCCESS[0m
> > + ./pants test.pytest 
> > --junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results
> >  src/main/python:: src/test/python:: -- -v
> > 
> > 22:03:35 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 22:03:35 00:00   [setup]
> > 22:03:35 00:00 [parse][32m
> >Executing tasks in goals: test[0m
> > 22:03:35 00:00   [test]
> > 22:03:35 00:00 [test-prep-command]
> > 22:03:35 00:00 [test]
> > 22:03:35 00:00 [pytest]
> > 22:03:35 00:00   [run]
> >  
> > 22:03:38 00:03 [chroot]INFO] Attempting to fetch thrift binary 
> > from: 
> > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
> >  ...
> > 
  2% .610 KB
  4% ..  1220 KB
  6% ... 1830 KB
  8% 2440 KB
 10% .   3050 KB
 12% ..  3660 KB
 14% ... 4260 KB
 16% 4870 KB
 18% .   5480 KB
 20% ..  6090 KB
 22% ... 6700 KB
 24% 7310 KB
 26% .   7920 KB
 28% ..  8520 KB
 30% ... 9130 KB
 32% 9740 KB
 34% .  10350 KB
 36% .. 10960 KB
 38% ...11570 KB
 40%    12170 KB
 42% .  12780 KB
 44% .. 13390 KB
 46% ...14000 KB
 48%    14610 KB
 50% .  15220 KB
 52% .. 15830 KB
 54% ...16430 KB
 56%    17040 KB
 58% .  17650 KB
 60% .. 18260 KB
 62% ...18870 KB
 64%    19480 KB
 66% .  20090 KB
 68% .. 20690 KB
 70% ...21300 KB
 72%    21910 KB
 74% .  22520 KB
 76% .. 23130 KB
 78% ...23740 KB
 80%    24340 KB
 82% .  24950 KB
 84% .. 25560 KB
 86% ...26170 KB
 88%

Re: Review Request 51499: Update 3dparty Python dependencies

2016-08-29 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51499/#review147224
---



Master (c34f78a) is red with this patch.
  ./build-support/jenkins/build.sh

Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 
cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 
lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7 pathspec-0.3.4 pex-1.1.10 
psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 
pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 
setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.7 
twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7 
twitter.common.lang-0.3.7 twitter.common.log-0.3.7 twitter.common.options-0.3.7

22:03:11 00:00 [main]
   (To run a reporting server: ./pants server)
22:03:11 00:00   [setup]
22:03:11 00:00 [parse][32m
   Executing tasks in goals: compile[0m
22:03:11 00:00   [compile]
22:03:11 00:00 [compile-prep-command]
22:03:11 00:00 [compile]
22:03:11 00:00 [python-eval]
22:03:11 00:00 [pythonstyle]
22:03:11 00:00   [cache]  [32m
   No cached artifacts for 42 targets.[0m[32m
   Invalidated 42 targets.[0m
22:03:34 00:23   [complete][32m
   SUCCESS[0m
+ ./pants test.pytest 
--junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results
 src/main/python:: src/test/python:: -- -v

22:03:35 00:00 [main]
   (To run a reporting server: ./pants server)
22:03:35 00:00   [setup]
22:03:35 00:00 [parse][32m
   Executing tasks in goals: test[0m
22:03:35 00:00   [test]
22:03:35 00:00 [test-prep-command]
22:03:35 00:00 [test]
22:03:35 00:00 [pytest]
22:03:35 00:00   [run]
 
22:03:38 00:03 [chroot]INFO] Attempting to fetch thrift binary from: 
https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
 ...

  2% .610 KB
  4% ..  1220 KB
  6% ... 1830 KB
  8% 2440 KB
 10% .   3050 KB
 12% ..  3660 KB
 14% ... 4260 KB
 16% 4870 KB
 18% .   5480 KB
 20% ..  6090 KB
 22% ... 6700 KB
 24% 7310 KB
 26% .   7920 KB
 28% ..  8520 KB
 30% ... 9130 KB
 32% 9740 KB
 34% .  10350 KB
 36% .. 10960 KB
 38% ...11570 KB
 40%    12170 KB
 42% .  12780 KB
 44% .. 13390 KB
 46% ...14000 KB
 48%    14610 KB
 50% .  15220 KB
 52% .. 15830 KB
 54% ...16430 KB
 56%    17040 KB
 58% .  17650 KB
 60% .. 18260 KB
 62% ...18870 KB
 64%    19480 KB
 66% .  20090 KB
 68% .. 20690 KB
 70% ...21300 KB
 72%    21910 KB
 74% .  22520 KB
 76% .. 23130 KB
 78% ...23740 KB
 80%    24340 KB
 82% .  24950 KB
 84% .. 25560 KB
 86% ...26170 KB
 88%

Re: Review Request 51499: Update 3dparty Python dependencies

2016-08-29 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51499/#review147222
---



@ReviewBot retry

- Stephan Erb


On Aug. 29, 2016, 9:11 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51499/
> ---
> 
> (Updated Aug. 29, 2016, 9:11 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I have skimmed the changelogs and there does not seem to be anything
> worth calling out in particular. Full changelogs:
> 
> * https://github.com/cherrypy/cherrypy/blob/v7.1.0/CHANGES.txt
> * http://docs.makotemplates.org/en/latest/changelog.html
> * https://github.com/pantsbuild/pex/blob/v1.1.14/CHANGES.rst
> * https://github.com/giampaolo/psutil/blob/release-4.3.0/HISTORY.rst
> * https://github.com/requests/requests-kerberos/blob/v0.10.0/HISTORY.rst
> * https://github.com/kennethreitz/requests/blob/v2.11.1/HISTORY.rst
> 
> 
> I have skipped the following updates for now:
> 
> * bottle: has a conflicting requirement in common
> * mock: it leads to some test failures
> * thrift: I didn't date to touch that
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 5cc3cb1edf7dcf30e44ff094e90286df48fa445e 
> 
> Diff: https://reviews.apache.org/r/51499/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 51499: Update 3dparty Python dependencies

2016-08-29 Thread John Sirois



> On Aug. 29, 2016, 2 p.m., Aurora ReviewBot wrote:
> > Master (874625e) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 
> > cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 
> > lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7 pathspec-0.3.4 pex-1.1.10 
> > psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 
> > pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 
> > setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.7 
> > twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7 
> > twitter.common.lang-0.3.7 twitter.common.log-0.3.7 
> > twitter.common.options-0.3.7
> > 
> > 19:59:27 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 19:59:27 00:00   [setup]
> > 19:59:27 00:00 [parse][32m
> >Executing tasks in goals: compile[0m
> > 19:59:28 00:01   [compile]
> > 19:59:28 00:01 [compile-prep-command]
> > 19:59:29 00:02 [compile]
> > 19:59:29 00:02 [python-eval]
> > 19:59:29 00:02 [pythonstyle]
> > 19:59:29 00:02   [cache]  [32m
> >No cached artifacts for 42 targets.[0m[32m
> >Invalidated 42 targets.[0m
> > 19:59:49 00:22   [complete][32m
> >SUCCESS[0m
> > + ./pants test.pytest 
> > --junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results
> >  src/main/python:: src/test/python:: -- -v
> > 
> > 19:59:52 00:00 [main]
> >(To run a reporting server: ./pants server)
> > 19:59:52 00:00   [setup]
> > 19:59:52 00:00 [parse][32m
> >Executing tasks in goals: test[0m
> > 19:59:52 00:00   [test]
> > 19:59:52 00:00 [test-prep-command]
> > 19:59:52 00:00 [test]
> > 19:59:52 00:00 [pytest]
> > 19:59:52 00:00   [run]
> >  
> > 19:59:56 00:04 [chroot]INFO] Attempting to fetch thrift binary 
> > from: 
> > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
> >  ...
> > 
  2% .610 KB
  4% ..  1220 KB
  6% ... 1830 KB
  8% 2440 KB
 10% .   3050 KB
 12% ..  3660 KB
 14% ... 4260 KB
 16% 4870 KB
 18% .   5480 KB
 20% ..  6090 KB
 22% ... 6700 KB
 24% 7310 KB
 26% .   7920 KB
 28% ..  8520 KB
 30% ... 9130 KB
 32% 9740 KB
 34% .  10350 KB
 36% .. 10960 KB
 38% ...11570 KB
 40%    12170 KB
 42% .  12780 KB
 44% .. 13390 KB
 46% ...14000 KB
 48%    14610 KB
 50% .  15220 KB
 52% .. 15830 KB
 54% ...16430 KB
 56%    17040 KB
 58% .  17650 KB
 60% .. 18260 KB
 62% ...18870 KB
 64%    19480 KB
 66% .  20090 KB
 68% .. 20690 KB
 70% ...21300 KB
 72%    21910 KB
 74% .  22520 KB
 76% .. 23130 KB
 78% ...23740 KB
 80%    24340 KB
 82% .  24950 KB
 84% .. 25560 KB
 86% ...26170 KB
 88%

Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.

2016-08-29 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51502/#review147213
---


Ship it!




Master (874625e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 29, 2016, 8:28 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51502/
> ---
> 
> (Updated Aug. 29, 2016, 8:28 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Clean up leaking of mounts into the host's mtab.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/sandbox.py 
> cedcab68f31bb0a514ab42ccebc88ab2c7470d1c 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> 2ba3341273efe54d1a79fe48be50d4253530dcbc 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 7c32c94edf88d6dc0fbd7f838bea2b8077da0235 
> 
> Diff: https://reviews.apache.org/r/51502/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> e2e tests
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.

2016-08-29 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51502/#review147211
---


Ship it!




Ship It!

- Stephan Erb


On Aug. 29, 2016, 10:28 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51502/
> ---
> 
> (Updated Aug. 29, 2016, 10:28 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Clean up leaking of mounts into the host's mtab.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/sandbox.py 
> cedcab68f31bb0a514ab42ccebc88ab2c7470d1c 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> 2ba3341273efe54d1a79fe48be50d4253530dcbc 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 7c32c94edf88d6dc0fbd7f838bea2b8077da0235 
> 
> Diff: https://reviews.apache.org/r/51502/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> e2e tests
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.

2016-08-29 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51502/#review147208
---



@ReviewBot retry

- Joshua Cohen


On Aug. 29, 2016, 8:28 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51502/
> ---
> 
> (Updated Aug. 29, 2016, 8:28 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Clean up leaking of mounts into the host's mtab.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/sandbox.py 
> cedcab68f31bb0a514ab42ccebc88ab2c7470d1c 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> 2ba3341273efe54d1a79fe48be50d4253530dcbc 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 7c32c94edf88d6dc0fbd7f838bea2b8077da0235 
> 
> Diff: https://reviews.apache.org/r/51502/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> e2e tests
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.

2016-08-29 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51502/#review147206
---



Master (874625e) is red with this patch.
  ./build-support/jenkins/build.sh

 [1m@mock.patch.dict(os.environ, {'MESOS_DIRECTORY': 
MOCK_MESOS_DIRECTORY})[0m
 [1mdef 
test_filesystem_sandbox_no_volumes(mock_safe_mkdir, mock_check_call):[0m
 [1m  sandbox_mount_point = '/some/mount/point'[0m
 [1m  sandbox_directory = 
os.path.join(MOCK_MESOS_DIRECTORY, 'sandbox'),[0m
 [1m[0m
 [1m  sandbox = FileSystemImageSandbox([0m
 [1m  sandbox_directory,[0m
 [1m  user='someuser',[0m
 [1m  no_create_user=True,[0m
 [1m  mounted_volume_paths=None,[0m
 [1m  sandbox_mount_point=sandbox_mount_point)[0m
 [1m[0m
 [1m  sandbox._mount_paths()[0m
 [1m[0m
 [1m  task_fs_path = 
os.path.join(MOCK_MESOS_DIRECTORY, 'taskfs')[0m
 [1m[0m
 [1m> assert mock_check_call.mock_calls == [[0m
 [1mmock.call([[0m
 [1m  'mount',[0m
 [1m  '--bind',[0m
 [1m  sandbox_directory,[0m
 [1m  os.path.join(task_fs_path, 
sandbox_mount_point[1:])[0m
 [1m])[0m
 [1m  ][0m
 [1m[31mE assert [call(['mount...ount/point'])] == 
[call(['mount'...ount/point'])][0m
 [1m[31mE   At index 0 diff: call(['mount', '-n', 
'--rbind', ('/some/path/sandbox',), '/some/path/taskfs/some/mount/point']) != 
call(['mount', '--bind', ('/some/path/sandbox',), 
'/some/path/taskfs/some/mount/point'])[0m
 [1m[31mE   Full diff:[0m
 [1m[31mE   - [call(['mount', '-n', '--rbind', 
('/some/path/sandbox',), '/some/path/taskfs/some/mount/point'])][0m
 [1m[31mE   ? --   -[0m
 [1m[31mE   + [call(['mount', '--bind', 
('/some/path/sandbox',), '/some/path/taskfs/some/mount/point'])][0m
 
 
src/test/python/apache/aurora/executor/common/test_sandbox.py:260: 
AssertionError
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
 [1m[31m 1 failed, 696 passed, 6 skipped, 1 warnings in 
286.78 seconds [0m
 
FAILURE


20:32:15 05:07   [complete][31m
   FAILURE[0m


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 29, 2016, 8:28 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51502/
> ---
> 
> (Updated Aug. 29, 2016, 8:28 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Clean up leaking of mounts into the host's mtab.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/sandbox.py 
> cedcab68f31bb0a514ab42ccebc88ab2c7470d1c 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> 2ba3341273efe54d1a79fe48be50d4253530dcbc 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 7c32c94edf88d6dc0fbd7f838bea2b8077da0235 
> 
> Diff: https://reviews.apache.org/r/51502/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> e2e tests
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.

2016-08-29 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51502/
---

(Updated Aug. 29, 2016, 8:28 p.m.)


Review request for Aurora and Stephan Erb.


Changes
---

Fix missed test case.


Repository: aurora


Description
---

Clean up leaking of mounts into the host's mtab.


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/sandbox.py 
cedcab68f31bb0a514ab42ccebc88ab2c7470d1c 
  src/test/python/apache/aurora/executor/common/test_sandbox.py 
2ba3341273efe54d1a79fe48be50d4253530dcbc 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
7c32c94edf88d6dc0fbd7f838bea2b8077da0235 

Diff: https://reviews.apache.org/r/51502/diff/


Testing
---

./build-support/jenkins/build.sh 
e2e tests


Thanks,

Joshua Cohen

Review Request 51502: Clean up leaking of mounts into the host's mtab.

2016-08-29 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51502/
---

Review request for Aurora and Stephan Erb.


Repository: aurora


Description
---

Clean up leaking of mounts into the host's mtab.


Diffs
-

  src/main/python/apache/aurora/executor/common/sandbox.py 
cedcab68f31bb0a514ab42ccebc88ab2c7470d1c 
  src/test/python/apache/aurora/executor/common/test_sandbox.py 
2ba3341273efe54d1a79fe48be50d4253530dcbc 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
7c32c94edf88d6dc0fbd7f838bea2b8077da0235 

Diff: https://reviews.apache.org/r/51502/diff/


Testing
---

./build-support/jenkins/build.sh 
e2e tests


Thanks,

Joshua Cohen

Re: Review Request 51499: Update 3dparty Python dependencies

2016-08-29 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51499/#review147191
---



@ReviewBot retry

- Stephan Erb


On Aug. 29, 2016, 9:11 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51499/
> ---
> 
> (Updated Aug. 29, 2016, 9:11 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I have skimmed the changelogs and there does not seem to be anything
> worth calling out in particular. Full changelogs:
> 
> * https://github.com/cherrypy/cherrypy/blob/v7.1.0/CHANGES.txt
> * http://docs.makotemplates.org/en/latest/changelog.html
> * https://github.com/pantsbuild/pex/blob/v1.1.14/CHANGES.rst
> * https://github.com/giampaolo/psutil/blob/release-4.3.0/HISTORY.rst
> * https://github.com/requests/requests-kerberos/blob/v0.10.0/HISTORY.rst
> * https://github.com/kennethreitz/requests/blob/v2.11.1/HISTORY.rst
> 
> 
> I have skipped the following updates for now:
> 
> * bottle: has a conflicting requirement in common
> * mock: it leads to some test failures
> * thrift: I didn't date to touch that
> 
> 
> Diffs
> -
> 
>   3rdparty/python/requirements.txt 5cc3cb1edf7dcf30e44ff094e90286df48fa445e 
> 
> Diff: https://reviews.apache.org/r/51499/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 51499: Update 3dparty Python dependencies

2016-08-29 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51499/#review147190
---



Master (5c95395) is red with this patch.
  ./build-support/jenkins/build.sh

Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 
cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 
lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7 pathspec-0.3.4 pex-1.1.10 
psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 
pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 
setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.7 
twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7 
twitter.common.lang-0.3.7 twitter.common.log-0.3.7 twitter.common.options-0.3.7

19:42:47 00:00 [main]
   (To run a reporting server: ./pants server)
19:42:47 00:00   [setup]
19:42:47 00:00 [parse][32m
   Executing tasks in goals: compile[0m
19:42:47 00:00   [compile]
19:42:47 00:00 [compile-prep-command]
19:42:47 00:00 [compile]
19:42:47 00:00 [python-eval]
19:42:47 00:00 [pythonstyle]
19:42:48 00:01   [cache]  [32m
   No cached artifacts for 42 targets.[0m[32m
   Invalidated 42 targets.[0m
19:43:09 00:22   [complete][32m
   SUCCESS[0m
+ ./pants test.pytest 
--junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results
 src/main/python:: src/test/python:: -- -v

19:43:14 00:00 [main]
   (To run a reporting server: ./pants server)
19:43:14 00:00   [setup]
19:43:14 00:00 [parse][32m
   Executing tasks in goals: test[0m
19:43:14 00:00   [test]
19:43:14 00:00 [test-prep-command]
19:43:14 00:00 [test]
19:43:14 00:00 [pytest]
19:43:14 00:00   [run]
 
19:43:20 00:06 [chroot]INFO] Attempting to fetch thrift binary from: 
https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
 ...

  2% .610 KB
  4% ..  1220 KB
  6% ... 1830 KB
  8% 2440 KB
 10% .   3050 KB
 12% ..  3660 KB
 14% ... 4260 KB
 16% 4870 KB
 18% .   5480 KB
 20% ..  6090 KB
 22% ... 6700 KB
 24% 7310 KB
 26% .   7920 KB
 28% ..  8520 KB
 30% ... 9130 KB
 32% 9740 KB
 34% .  10350 KB
 36% .. 10960 KB
 38% ...11570 KB
 40%    12170 KB
 42% .  12780 KB
 44% .. 13390 KB
 46% ...14000 KB
 48%    14610 KB
 50% .  15220 KB
 52% .. 15830 KB
 54% ...16430 KB
 56%    17040 KB
 58% .  17650 KB
 60% .. 18260 KB
 62% ...18870 KB
 64%    19480 KB
 66% .  20090 KB
 68% .. 20690 KB
 70% ...21300 KB
 72%    21910 KB
 74% .  22520 KB
 76% .. 23130 KB
 78% ...23740 KB
 80%    24340 KB
 82% .  24950 KB
 84% .. 25560 KB
 86% ...26170 KB
 88%

Re: Review Request 51500: Configure ssh for e2e tests once globally, rather than as part of a specific test case.

2016-08-29 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51500/#review147187
---

Master (5c95395) is red with this patch.
  ./build-support/jenkins/build.sh

 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 ERROR] Could not quitquitquit runner: Cannot take control 
of a task in terminal state.
 E0829 19:30:27.213679 15679 thermos_task_runner.py:238] 
Could not quitquitquit runner: Cannot take control of a task in terminal state.
  generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml

 [1m[31m 2 failed, 695 passed, 6 skipped, 1 warnings in 
340.96 seconds [0m

FAILURE

19:31:47 06:36   [complete][31m
   FAILURE[0m

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot

On Aug. 29, 2016, 7:10 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51500/
> ---
> 
> (Updated Aug. 29, 2016, 7:10 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Configure ssh for e2e tests once globally, rather than as part of a specific 
> test case.
> 
> 
> Diffs
> -
> 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1a668dd9e98472bdf0deda840868813a5c3dcef2 
> 
> Diff:

Re: Review Request 51500: Configure ssh for e2e tests once globally, rather than as part of a specific test case.

2016-08-29 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51500/#review147185
---


Ship it!




Ship It!

- Stephan Erb


On Aug. 29, 2016, 9:10 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51500/
> ---
> 
> (Updated Aug. 29, 2016, 9:10 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Configure ssh for e2e tests once globally, rather than as part of a specific 
> test case.
> 
> 
> Diffs
> -
> 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1a668dd9e98472bdf0deda840868813a5c3dcef2 
> 
> Diff: https://reviews.apache.org/r/51500/diff/
> 
> 
> Testing
> ---
> 
> ran e2e tests on a clean vagrant environment.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Review Request 51499: Update 3dparty Python dependencies

2016-08-29 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51499/
---

Review request for Aurora, John Sirois and Zameer Manji.


Repository: aurora


Description
---

I have skimmed the changelogs and there does not seem to be anything
worth calling out in particular. Full changelogs:

* https://github.com/cherrypy/cherrypy/blob/v7.1.0/CHANGES.txt
* http://docs.makotemplates.org/en/latest/changelog.html
* https://github.com/pantsbuild/pex/blob/v1.1.14/CHANGES.rst
* https://github.com/giampaolo/psutil/blob/release-4.3.0/HISTORY.rst
* https://github.com/requests/requests-kerberos/blob/v0.10.0/HISTORY.rst
* https://github.com/kennethreitz/requests/blob/v2.11.1/HISTORY.rst


I have skipped the following updates for now:

* bottle: has a conflicting requirement in common
* mock: it leads to some test failures
* thrift: I didn't date to touch that


Diffs
-

  3rdparty/python/requirements.txt 5cc3cb1edf7dcf30e44ff094e90286df48fa445e 

Diff: https://reviews.apache.org/r/51499/diff/


Testing
---

./pants test.pytest src/{main,test}/python:: -- -v
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Stephan Erb

Review Request 51500: Configure ssh for e2e tests once globally, rather than as part of a specific test case.

2016-08-29 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51500/
---

Review request for Aurora and Stephan Erb.


Repository: aurora


Description
---

Configure ssh for e2e tests once globally, rather than as part of a specific 
test case.


Diffs
-

  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
1a668dd9e98472bdf0deda840868813a5c3dcef2 

Diff: https://reviews.apache.org/r/51500/diff/


Testing
---

ran e2e tests on a clean vagrant environment.


Thanks,

Joshua Cohen

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-29 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51384/#review147184
---



Looks good to me, only one issue remaining from my perspective.


src/test/python/apache/aurora/client/cli/test_supdate.py (line 153)


since we're mocking this anyway, no real need to generate an actual uuid, 
can just have the mock return something like 'some-mocked-uuid'. That'll make 
it a little bit more clear, in the event of a failure, that the value was a 
mock and not coming from live code.



src/main/python/apache/aurora/client/cli/update.py (line 193)


Am I missing something? Shouldn't this be a set of `Metadata` structs? 
rather than a set of strings which is what this will currently pass?


- Joshua Cohen


On Aug. 28, 2016, 3:58 a.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51384/
> ---
> 
> (Updated Aug. 28, 2016, 3:58 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Maxim 
> Khutornenko.
> 
> 
> Bugs: AURORA-1711
> https://issues.apache.org/jira/browse/AURORA-1711
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow custom metadata to be stored with the job updates. This feature
> is to help case the reconciliation on job update request on the clients.
> 
> Today when a client's requests are proxied via a middle-man,
> if the middle-man times out before the scheduler responds with success,
> the client is left the only option of retry. In the case of updates,
> since multiple updates are not allowed in parallel, the retries fail,
> with INVALID_REQUEST. Although the original update is already accepted
> by the scheduler and is in-progress.
> 
> With this feature, clients can reconcile the job updates,
> - by marking updates them with a unique id in the metadata field
> - scheduler returns the in-progress job update in its response
> - client can match the client-generated ids to reconcile its state.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 
> d2673e6b328cb1e249fbe91d18e0d9e935636eaa 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
>  a3b04949f1726f110638e4f93ef45947cdb9e7f8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V008_CreateUpdateMetadataTable.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java 
> 78703e92c932cd5e93ff0b70f2a0b6928f6b4003 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  929d021a336c6a3438613c9340c84a1096dc9069 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  594bb6219294dcc77d48dcad14e2a6f9caa0c534 
>   
> src/main/java/org/apache/aurora/scheduler/updater/UpdateInProgressException.java
>  PRE-CREATION 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 9149c3018ae58d405f284fcbd4076d251ccc8192 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 542f165add0f1d01a782fe6d6089bff3e736fb82 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  8563630a179cb6d1e3b0e22c730ccbfe1c9291e2 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> a40830fd668aa650c22a48cbc757b45aef27e961 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  08530397ff75081bde6f07f9d53317b5486e0da4 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  779dc302602ae8842084807ca868a491ea99b676 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 04551f17999d742c53dfb1b36286b119b448550e 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416 
>   src/test/python/apache/aurora/client/cli/util.py 
> aac9f9c802e4ad1f06cee8cf3f56749760b33af5 
> 
> Diff: https://reviews.apache.org/r/51384/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./pants test src/test/python/apache/aurora/client/cli:cli
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 50819: Use update_job instead of creating new config object when modifying.

2016-08-29 Thread Mehrdad Nurolahzade



> On Aug. 29, 2016, 11:01 a.m., Stephan Erb wrote:
> > @ReviewBot retry

Seems like this was already merged: 
[https://github.com/apache/aurora/commit/ec3591c812b4f7a063b3f5ee54ac66a9a4c5048b]


- Mehrdad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50819/#review147171
---


On Aug. 4, 2016, 2:10 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50819/
> ---
> 
> (Updated Aug. 4, 2016, 2:10 p.m.)
> 
> 
> Review request for Aurora and Mehrdad Nurolahzade.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use update_job instead of creating new config object when modifying. This 
> avoids losing any state (e.g. metadata) attached to the config.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> 7bbfb5e815b2408b8ddaaeeb9911a5bd1b019a27 
> 
> Diff: https://reviews.apache.org/r/50819/diff/
> 
> 
> Testing
> ---
> 
> $ ./pants test.pytest src/test/python/apache/aurora/client::
> 
> 14:07:19 00:00 [main]
>(To run a reporting server: ./pants server)
> 14:07:19 00:00   [setup]
> 14:07:19 00:00 [parse]
>Executing tasks in goals: test
> 14:07:19 00:00   [test]
> 14:07:19 00:00 [test-prep-command]
> 14:07:19 00:00 [test]
> 14:07:19 00:00 [pytest]
> 14:07:19 00:00   [run]
>  
> 14:07:19 00:00 [chroot]== test session starts 
> ===
>  platform darwin -- Python 2.7.10 -- py-1.4.31 -- 
> pytest-2.6.4
>  plugins: timeout, cov
>  collected 339 items 
>  
>  
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
>  src/test/python/apache/aurora/client/cli/test_context.py 
> 
>  src/test/python/apache/aurora/client/cli/test_version.py 
> .
>  src/test/python/apache/aurora/client/cli/test_quota.py 
> .
>  src/test/python/apache/aurora/client/cli/test_plugins.py 
> .
>  src/test/python/apache/aurora/client/cli/test_client.py 
> ..
>  src/test/python/apache/aurora/client/cli/test_sla.py 
> .
>  src/test/python/apache/aurora/client/cli/test_open.py 
> .
>  src/test/python/apache/aurora/client/cli/test_supdate.py 
> .
>  src/test/python/apache/aurora/client/cli/test_restart.py 
> ..
>  src/test/python/apache/aurora/client/cli/test_status.py 
> .
>  src/test/python/apache/aurora/client/cli/test_add.py 
>  src/test/python/apache/aurora/client/cli/test_diff.py ..
>  src/test/python/apache/aurora/client/cli/test_cron.py 
> ..
>  
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
>  src/test/python/apache/aurora/client/cli/test_options.py 
> ..
>  src/test/python/apache/aurora/client/cli/test_task.py 
> .
>  src/test/python/apache/aurora/client/cli/test_create.py 
> ..
>  src/test/python/apache/aurora/client/cli/test_kill.py 
> .
>  src/test/python/apache/aurora/client/cli/test_inspect.py 
> ...
>  
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
>  
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py .
>  
> src/test/python/apache/aurora/client/api/test_updater_util.py ...
>  
> src/test/python/apache/aurora/client/api/test_job_monitor.py ..
>  src/test/python/apache/aurora/client/api/test_api.py 
> ..
>  
> src/test/python/apache/aurora/client/api/test_task_util.py .
>  
> src/test/python/apache/aurora/client/api/test_restarter.py ..
>  
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ..
>  
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> .
>  src/test/python/apache/aurora/client/api/test_sla.py 
> ..
>  
> src/test/python/apache/aurora/client/api/test_health_check.py ...
>  
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
>

Re: Review Request 50819: Use update_job instead of creating new config object when modifying.

2016-08-29 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50819/#review147181
---



Master (56906a7) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 4, 2016, 9:10 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50819/
> ---
> 
> (Updated Aug. 4, 2016, 9:10 p.m.)
> 
> 
> Review request for Aurora and Mehrdad Nurolahzade.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use update_job instead of creating new config object when modifying. This 
> avoids losing any state (e.g. metadata) attached to the config.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> 7bbfb5e815b2408b8ddaaeeb9911a5bd1b019a27 
> 
> Diff: https://reviews.apache.org/r/50819/diff/
> 
> 
> Testing
> ---
> 
> $ ./pants test.pytest src/test/python/apache/aurora/client::
> 
> 14:07:19 00:00 [main]
>(To run a reporting server: ./pants server)
> 14:07:19 00:00   [setup]
> 14:07:19 00:00 [parse]
>Executing tasks in goals: test
> 14:07:19 00:00   [test]
> 14:07:19 00:00 [test-prep-command]
> 14:07:19 00:00 [test]
> 14:07:19 00:00 [pytest]
> 14:07:19 00:00   [run]
>  
> 14:07:19 00:00 [chroot]== test session starts 
> ===
>  platform darwin -- Python 2.7.10 -- py-1.4.31 -- 
> pytest-2.6.4
>  plugins: timeout, cov
>  collected 339 items 
>  
>  
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
>  src/test/python/apache/aurora/client/cli/test_context.py 
> 
>  src/test/python/apache/aurora/client/cli/test_version.py 
> .
>  src/test/python/apache/aurora/client/cli/test_quota.py 
> .
>  src/test/python/apache/aurora/client/cli/test_plugins.py 
> .
>  src/test/python/apache/aurora/client/cli/test_client.py 
> ..
>  src/test/python/apache/aurora/client/cli/test_sla.py 
> .
>  src/test/python/apache/aurora/client/cli/test_open.py 
> .
>  src/test/python/apache/aurora/client/cli/test_supdate.py 
> .
>  src/test/python/apache/aurora/client/cli/test_restart.py 
> ..
>  src/test/python/apache/aurora/client/cli/test_status.py 
> .
>  src/test/python/apache/aurora/client/cli/test_add.py 
>  src/test/python/apache/aurora/client/cli/test_diff.py ..
>  src/test/python/apache/aurora/client/cli/test_cron.py 
> ..
>  
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
>  src/test/python/apache/aurora/client/cli/test_options.py 
> ..
>  src/test/python/apache/aurora/client/cli/test_task.py 
> .
>  src/test/python/apache/aurora/client/cli/test_create.py 
> ..
>  src/test/python/apache/aurora/client/cli/test_kill.py 
> .
>  src/test/python/apache/aurora/client/cli/test_inspect.py 
> ...
>  
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
>  
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py .
>  
> src/test/python/apache/aurora/client/api/test_updater_util.py ...
>  
> src/test/python/apache/aurora/client/api/test_job_monitor.py ..
>  src/test/python/apache/aurora/client/api/test_api.py 
> ..
>  
> src/test/python/apache/aurora/client/api/test_task_util.py .
>  
> src/test/python/apache/aurora/client/api/test_restarter.py ..
>  
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ..
>  
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> .
>  src/test/python/apache/aurora/client/api/test_sla.py 
> ..
>  
> src/test/python/apache/aurora/client/api/test_health_check.py ...
>  
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py

Re: Review Request 51307: Catch IOError.

2016-08-29 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51307/#review147179
---


Ship it!




Ship It!

- Maxim Khutornenko


On Aug. 23, 2016, 9:12 p.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51307/
> ---
> 
> (Updated Aug. 23, 2016, 9:12 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1752
> https://issues.apache.org/jira/browse/AURORA-1752
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Catch IOError.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> bb7c90206791309772c4bb8e2ccf6e62a3991403 
>   src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51307/diff/
> 
> 
> Testing
> ---
> 
> $ ./pants test src/test/python/apache/thermos/monitoring
> 
> 13:59:36 00:00 [main]
>(To run a reporting server: ./pants server)
> 13:59:36 00:00   [setup]
> 13:59:36 00:00 [parse]
>Executing tasks in goals: test
> 13:59:36 00:00   [test]
> 13:59:36 00:00 [test-prep-command]
> 13:59:36 00:00 [test]
> 13:59:36 00:00 [pytest]
> 13:59:36 00:00   [run]
>  == test session starts ===
>  platform linux2 -- Python 2.7.11 -- py-1.4.31 -- 
> pytest-2.6.4
>  plugins: cov, timeout
>  collected 12 items 
>  
>  src/test/python/apache/thermos/monitoring/test_disk.py .
>  
> src/test/python/apache/thermos/monitoring/test_detector.py .
>  
> src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py .
>  
> src/test/python/apache/thermos/monitoring/test_resource.py .
>  
>  === 12 passed in 0.17 seconds 
>  
> 13:59:37 00:01   [complete]
>SUCCESS
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Re: Review Request 51307: Catch IOError.

2016-08-29 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51307/#review147178
---


Ship it!




Master (56906a7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Aug. 23, 2016, 9:12 p.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51307/
> ---
> 
> (Updated Aug. 23, 2016, 9:12 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1752
> https://issues.apache.org/jira/browse/AURORA-1752
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Catch IOError.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> bb7c90206791309772c4bb8e2ccf6e62a3991403 
>   src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51307/diff/
> 
> 
> Testing
> ---
> 
> $ ./pants test src/test/python/apache/thermos/monitoring
> 
> 13:59:36 00:00 [main]
>(To run a reporting server: ./pants server)
> 13:59:36 00:00   [setup]
> 13:59:36 00:00 [parse]
>Executing tasks in goals: test
> 13:59:36 00:00   [test]
> 13:59:36 00:00 [test-prep-command]
> 13:59:36 00:00 [test]
> 13:59:36 00:00 [pytest]
> 13:59:36 00:00   [run]
>  == test session starts ===
>  platform linux2 -- Python 2.7.11 -- py-1.4.31 -- 
> pytest-2.6.4
>  plugins: cov, timeout
>  collected 12 items 
>  
>  src/test/python/apache/thermos/monitoring/test_disk.py .
>  
> src/test/python/apache/thermos/monitoring/test_detector.py .
>  
> src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py .
>  
> src/test/python/apache/thermos/monitoring/test_resource.py .
>  
>  === 12 passed in 0.17 seconds 
>  
> 13:59:37 00:01   [complete]
>SUCCESS
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Re: Review Request 50819: Use update_job instead of creating new config object when modifying.

2016-08-29 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50819/#review147171
---



@ReviewBot retry

- Stephan Erb


On Aug. 4, 2016, 11:10 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50819/
> ---
> 
> (Updated Aug. 4, 2016, 11:10 p.m.)
> 
> 
> Review request for Aurora and Mehrdad Nurolahzade.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use update_job instead of creating new config object when modifying. This 
> avoids losing any state (e.g. metadata) attached to the config.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> 7bbfb5e815b2408b8ddaaeeb9911a5bd1b019a27 
> 
> Diff: https://reviews.apache.org/r/50819/diff/
> 
> 
> Testing
> ---
> 
> $ ./pants test.pytest src/test/python/apache/aurora/client::
> 
> 14:07:19 00:00 [main]
>(To run a reporting server: ./pants server)
> 14:07:19 00:00   [setup]
> 14:07:19 00:00 [parse]
>Executing tasks in goals: test
> 14:07:19 00:00   [test]
> 14:07:19 00:00 [test-prep-command]
> 14:07:19 00:00 [test]
> 14:07:19 00:00 [pytest]
> 14:07:19 00:00   [run]
>  
> 14:07:19 00:00 [chroot]== test session starts 
> ===
>  platform darwin -- Python 2.7.10 -- py-1.4.31 -- 
> pytest-2.6.4
>  plugins: timeout, cov
>  collected 339 items 
>  
>  
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
>  src/test/python/apache/aurora/client/cli/test_context.py 
> 
>  src/test/python/apache/aurora/client/cli/test_version.py 
> .
>  src/test/python/apache/aurora/client/cli/test_quota.py 
> .
>  src/test/python/apache/aurora/client/cli/test_plugins.py 
> .
>  src/test/python/apache/aurora/client/cli/test_client.py 
> ..
>  src/test/python/apache/aurora/client/cli/test_sla.py 
> .
>  src/test/python/apache/aurora/client/cli/test_open.py 
> .
>  src/test/python/apache/aurora/client/cli/test_supdate.py 
> .
>  src/test/python/apache/aurora/client/cli/test_restart.py 
> ..
>  src/test/python/apache/aurora/client/cli/test_status.py 
> .
>  src/test/python/apache/aurora/client/cli/test_add.py 
>  src/test/python/apache/aurora/client/cli/test_diff.py ..
>  src/test/python/apache/aurora/client/cli/test_cron.py 
> ..
>  
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
>  src/test/python/apache/aurora/client/cli/test_options.py 
> ..
>  src/test/python/apache/aurora/client/cli/test_task.py 
> .
>  src/test/python/apache/aurora/client/cli/test_create.py 
> ..
>  src/test/python/apache/aurora/client/cli/test_kill.py 
> .
>  src/test/python/apache/aurora/client/cli/test_inspect.py 
> ...
>  
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
>  
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py .
>  
> src/test/python/apache/aurora/client/api/test_updater_util.py ...
>  
> src/test/python/apache/aurora/client/api/test_job_monitor.py ..
>  src/test/python/apache/aurora/client/api/test_api.py 
> ..
>  
> src/test/python/apache/aurora/client/api/test_task_util.py .
>  
> src/test/python/apache/aurora/client/api/test_restarter.py ..
>  
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ..
>  
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> .
>  src/test/python/apache/aurora/client/api/test_sla.py 
> ..
>  
> src/test/python/apache/aurora/client/api/test_health_check.py ...
>  
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py 
>  
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ...
>  src/test/python/apache/aurora/client/test_config.py 
> 
>

Re: Review Request 51307: Catch IOError.

2016-08-29 Thread Stephan Erb


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51307/#review147172
---



@ReviewBot retry

- Stephan Erb


On Aug. 23, 2016, 11:12 p.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51307/
> ---
> 
> (Updated Aug. 23, 2016, 11:12 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1752
> https://issues.apache.org/jira/browse/AURORA-1752
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Catch IOError.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
> bb7c90206791309772c4bb8e2ccf6e62a3991403 
>   src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51307/diff/
> 
> 
> Testing
> ---
> 
> $ ./pants test src/test/python/apache/thermos/monitoring
> 
> 13:59:36 00:00 [main]
>(To run a reporting server: ./pants server)
> 13:59:36 00:00   [setup]
> 13:59:36 00:00 [parse]
>Executing tasks in goals: test
> 13:59:36 00:00   [test]
> 13:59:36 00:00 [test-prep-command]
> 13:59:36 00:00 [test]
> 13:59:36 00:00 [pytest]
> 13:59:36 00:00   [run]
>  == test session starts ===
>  platform linux2 -- Python 2.7.11 -- py-1.4.31 -- 
> pytest-2.6.4
>  plugins: cov, timeout
>  collected 12 items 
>  
>  src/test/python/apache/thermos/monitoring/test_disk.py .
>  
> src/test/python/apache/thermos/monitoring/test_detector.py .
>  
> src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py .
>  
> src/test/python/apache/thermos/monitoring/test_resource.py .
>  
>  === 12 passed in 0.17 seconds 
>  
> 13:59:37 00:01   [complete]
>SUCCESS
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-08-29 Thread Zameer Manji



> On Aug. 29, 2016, 9:33 a.m., Maxim Khutornenko wrote:
> > Not against this change but rather curious what your thoughts are wrt the 
> > larger picture here. Are you intending to get rid of all static helps in 
> > `Stats` in favor of the `StatsProvider`?
> 
> Zameer Manji wrote:
> Yes, I think the static dependency on stats is tech debt that we need to 
> fix. There is also lots of unused code in Stats that I will be removing as 
> well.
> 
> Maxim Khutornenko wrote:
> Not sure I agree about eliminating all of `Stats` static helpers. Having 
> methods like `exportLong` have proven to help us reduce friction around 
> adding new stats and generally help quick prototyping and perf investigations.

Agreed, I will carefully consider implications of removing each one.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51469/#review147138
---


On Aug. 26, 2016, 3:11 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51469/
> ---
> 
> (Updated Aug. 26, 2016, 3:11 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove static Stats method `exportSize`.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> 538e8077ba762ec9a8f14f759740bb82144a5dc4 
>   commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
> 6b1fa4b35c54ab3e37a80c91664c6e8cfd4696c2 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
> a83f18307fd8e1d266f3d3ae8682333575eda884 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 
> a1ae7c7231d15d2f9715a7de30dfcde0a2f4d730 
>   src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 
> 6d4934b6b6de5273687041174315c4e3d151ac11 
>   src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 
> e7534c4325afa29b580d890cffdc26bdec7ef938 
> 
> Diff: https://reviews.apache.org/r/51469/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-08-29 Thread Maxim Khutornenko



> On Aug. 29, 2016, 4:33 p.m., Maxim Khutornenko wrote:
> > Not against this change but rather curious what your thoughts are wrt the 
> > larger picture here. Are you intending to get rid of all static helps in 
> > `Stats` in favor of the `StatsProvider`?
> 
> Zameer Manji wrote:
> Yes, I think the static dependency on stats is tech debt that we need to 
> fix. There is also lots of unused code in Stats that I will be removing as 
> well.

Not sure I agree about eliminating all of `Stats` static helpers. Having 
methods like `exportLong` have proven to help us reduce friction around adding 
new stats and generally help quick prototyping and perf investigations.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51469/#review147138
---


On Aug. 26, 2016, 10:11 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51469/
> ---
> 
> (Updated Aug. 26, 2016, 10:11 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove static Stats method `exportSize`.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> 538e8077ba762ec9a8f14f759740bb82144a5dc4 
>   commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
> 6b1fa4b35c54ab3e37a80c91664c6e8cfd4696c2 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
> a83f18307fd8e1d266f3d3ae8682333575eda884 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 
> a1ae7c7231d15d2f9715a7de30dfcde0a2f4d730 
>   src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 
> 6d4934b6b6de5273687041174315c4e3d151ac11 
>   src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 
> e7534c4325afa29b580d890cffdc26bdec7ef938 
> 
> Diff: https://reviews.apache.org/r/51469/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 51484: Re-enable python style check in the integration build.

2016-08-29 Thread Santhosh Kumar Shanmugham

Thanks John.

I have fixed my account details on review board.

On Mon, Aug 29, 2016 at 10:05 AM, John Sirois  wrote:

>
>
> > On Aug. 29, 2016, 10:39 a.m., John Sirois wrote:
> > > I'm taking a look presently.  The seperate script call-out should no
> longer be needed since `./pants test...` implies `./pants compile...` which
> is all the seperate script does.
> >
> > John Sirois wrote:
> > Aha - yes, the compile dependency was historically leeched from the
> jvm stack which is now not installed.  LGTM.
> >
> > John Sirois wrote:
> > Filed pants issue to fix this: https://github.com/pantsbuild/
> pants/issues/3819
> >
> > Joshua Cohen wrote:
> > I was just talking to Stu Hood in pants slack about this. He came to
> the same conclusion (removing the JVM backend caused test to no longer be
> linked to compile). He suggested we might want to install a plugin to
> redirect pythonstyle to the test goal instead.
> >
> > I think that this solution is probably ok for my use cases (checking
> style before posting a review and having ReviewBot catch style issues for
> me so I don't have to call them out myself on other reviews), but wanted to
> raise the option for those who might like to have checkstyle run during the
> local dev flow of edit/test/repeat.
> >
> > John Sirois wrote:
> > Yeah - I'm happy to follow-up with a plugin to shim checkstyle into
> the `./pants test...` workflow, but in the past custom pants plugins for
> Aurora were frowned upon.
> >
> > Joshua Cohen wrote:
> > Yeah, I'm fine to commit this change and only add the plugin if
> someone feels strongly that hooking back into `./pants test ...` is
> critical.
>
> Cool - submitted.
>
> Santhosh - this patch-in took some extra effort since your Review Board
> account does not have a full name and email exposed.  Looks like so:
> ```
> rbt patch --debug -c 51484
> ...
> >>> Making HTTP GET request to https://reviews.apache.org/
> api/users/sshanmugham/
> >>> Cached response for HTTP GET https://reviews.apache.org/
> api/users/sshanmugham/ expired and was not modified
> Traceback (most recent call last):
>   File "/home/jsirois/.pyenv/versions/rbt/bin/rbt", line 11, in 
> sys.exit(main())
>   File "/home/jsirois/.pyenv/versions/2.7.12/envs/rbt/lib/
> python2.7/site-packages/rbtools/commands/main.py", line 133, in main
> command.run_from_argv([RB_MAIN, command_name] + args)
>   File "/home/jsirois/.pyenv/versions/2.7.12/envs/rbt/lib/
> python2.7/site-packages/rbtools/commands/__init__.py", line 629, in
> run_from_argv
> exit_code = self.main(*args) or 0
>   File "/home/jsirois/.pyenv/versions/2.7.12/envs/rbt/lib/
> python2.7/site-packages/rbtools/commands/patch.py", line 206, in main
> not self.options.commit_no_edit)
>   File "/home/jsirois/.pyenv/versions/2.7.12/envs/rbt/lib/
> python2.7/site-packages/rbtools/clients/git.py", line 791, in
> create_commit
> '--author="%s <%s>"' % (author.fullname, author.email)])
>   File "/home/jsirois/.pyenv/versions/2.7.12/envs/rbt/lib/
> python2.7/site-packages/rbtools/api/resource.py", line 301, in __getattr__
> raise AttributeError
> AttributeError
> ```
>
> Your account should show a full name and email below your username in the
> left-hand pane, like this: https://reviews.apache.org/users/jsirois/
>
>
> - John
>
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51484/#review147139
> ---
>
>
> On Aug. 27, 2016, 10:40 p.m., Santhosh Kumar Shanmugham wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/51484/
> > ---
> >
> > (Updated Aug. 27, 2016, 10:40 p.m.)
> >
> >
> > Review request for Aurora, John Sirois and Zameer Manji.
> >
> >
> > Repository: aurora
> >
> >
> > Description
> > ---
> >
> > Re-enable python style check in the integration build.
> >
> > pants test does not appear to invoke the python checkstyle. Re-enable
> > it by explicitly calling in the integration build script. Also fix the
> > few issues that have already been commited.
> >
> >
> > Diffs
> > -
> >
> >   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819b
> ae018a8f37
> >   src/main/python/apache/aurora/client/cli/context.py
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4
> >   src/main/python/apache/aurora/client/cli/update.py
> 23aaa2c1b67599420408633733e4581553f7151b
> >   src/main/python/apache/thermos/core/process.py
> 78e7d788f14a1611031e3c6e255c77768daabac4
> >   src/test/python/apache/aurora/executor/common/test_sandbox.py
> b30a5bc733ac5ccace0b93b68e2ee6f04ce31184
> >   src/test/python/apache/thermos/core/test_process.py
> 49f52d947471c8ea8daae1708f4d26afa4c6ee0a
> >
> > Diff:

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-08-29 Thread Zameer Manji



> On Aug. 29, 2016, 9:33 a.m., Maxim Khutornenko wrote:
> > Not against this change but rather curious what your thoughts are wrt the 
> > larger picture here. Are you intending to get rid of all static helps in 
> > `Stats` in favor of the `StatsProvider`?

Yes, I think the static dependency on stats is tech debt that we need to fix. 
There is also lots of unused code in Stats that I will be removing as well.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51469/#review147138
---


On Aug. 26, 2016, 3:11 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51469/
> ---
> 
> (Updated Aug. 26, 2016, 3:11 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove static Stats method `exportSize`.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> 538e8077ba762ec9a8f14f759740bb82144a5dc4 
>   commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
> 6b1fa4b35c54ab3e37a80c91664c6e8cfd4696c2 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
> a83f18307fd8e1d266f3d3ae8682333575eda884 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 
> a1ae7c7231d15d2f9715a7de30dfcde0a2f4d730 
>   src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 
> 6d4934b6b6de5273687041174315c4e3d151ac11 
>   src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 
> e7534c4325afa29b580d890cffdc26bdec7ef938 
> 
> Diff: https://reviews.apache.org/r/51469/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 51484: Re-enable python style check in the integration build.

2016-08-29 Thread John Sirois



> On Aug. 29, 2016, 10:39 a.m., John Sirois wrote:
> > I'm taking a look presently.  The seperate script call-out should no longer 
> > be needed since `./pants test...` implies `./pants compile...` which is all 
> > the seperate script does.
> 
> John Sirois wrote:
> Aha - yes, the compile dependency was historically leeched from the jvm 
> stack which is now not installed.  LGTM.
> 
> John Sirois wrote:
> Filed pants issue to fix this: 
> https://github.com/pantsbuild/pants/issues/3819
> 
> Joshua Cohen wrote:
> I was just talking to Stu Hood in pants slack about this. He came to the 
> same conclusion (removing the JVM backend caused test to no longer be linked 
> to compile). He suggested we might want to install a plugin to redirect 
> pythonstyle to the test goal instead.
> 
> I think that this solution is probably ok for my use cases (checking 
> style before posting a review and having ReviewBot catch style issues for me 
> so I don't have to call them out myself on other reviews), but wanted to 
> raise the option for those who might like to have checkstyle run during the 
> local dev flow of edit/test/repeat.
> 
> John Sirois wrote:
> Yeah - I'm happy to follow-up with a plugin to shim checkstyle into the 
> `./pants test...` workflow, but in the past custom pants plugins for Aurora 
> were frowned upon.
> 
> Joshua Cohen wrote:
> Yeah, I'm fine to commit this change and only add the plugin if someone 
> feels strongly that hooking back into `./pants test ...` is critical.

Cool - submitted.

Santhosh - this patch-in took some extra effort since your Review Board account 
does not have a full name and email exposed.  Looks like so:
```
rbt patch --debug -c 51484
...
>>> Making HTTP GET request to https://reviews.apache.org/api/users/sshanmugham/
>>> Cached response for HTTP GET 
>>> https://reviews.apache.org/api/users/sshanmugham/ expired and was not 
>>> modified
Traceback (most recent call last):
  File "/home/jsirois/.pyenv/versions/rbt/bin/rbt", line 11, in 
sys.exit(main())
  File 
"/home/jsirois/.pyenv/versions/2.7.12/envs/rbt/lib/python2.7/site-packages/rbtools/commands/main.py",
 line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File 
"/home/jsirois/.pyenv/versions/2.7.12/envs/rbt/lib/python2.7/site-packages/rbtools/commands/__init__.py",
 line 629, in run_from_argv
exit_code = self.main(*args) or 0
  File 
"/home/jsirois/.pyenv/versions/2.7.12/envs/rbt/lib/python2.7/site-packages/rbtools/commands/patch.py",
 line 206, in main
not self.options.commit_no_edit)
  File 
"/home/jsirois/.pyenv/versions/2.7.12/envs/rbt/lib/python2.7/site-packages/rbtools/clients/git.py",
 line 791, in create_commit
'--author="%s <%s>"' % (author.fullname, author.email)])
  File 
"/home/jsirois/.pyenv/versions/2.7.12/envs/rbt/lib/python2.7/site-packages/rbtools/api/resource.py",
 line 301, in __getattr__
raise AttributeError
AttributeError
```

Your account should show a full name and email below your username in the 
left-hand pane, like this: https://reviews.apache.org/users/jsirois/


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51484/#review147139
---


On Aug. 27, 2016, 10:40 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51484/
> ---
> 
> (Updated Aug. 27, 2016, 10:40 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Re-enable python style check in the integration build.
> 
> pants test does not appear to invoke the python checkstyle. Re-enable
> it by explicitly calling in the integration build script. Also fix the
> few issues that have already been commited.
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/thermos/core/process.py 
> 78e7d788f14a1611031e3c6e255c77768daabac4 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> b30a5bc733ac5ccace0b93b68e2ee6f04ce31184 
>   src/test/python/apache/thermos/core/test_process.py 
> 49f52d947471c8ea8daae1708f4d26afa4c6ee0a 
> 
> Diff: https://reviews.apache.org/r/51484/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 51484: Re-enable python style check in the integration build.

2016-08-29 Thread Joshua Cohen



> On Aug. 29, 2016, 4:39 p.m., John Sirois wrote:
> > I'm taking a look presently.  The seperate script call-out should no longer 
> > be needed since `./pants test...` implies `./pants compile...` which is all 
> > the seperate script does.
> 
> John Sirois wrote:
> Aha - yes, the compile dependency was historically leeched from the jvm 
> stack which is now not installed.  LGTM.
> 
> John Sirois wrote:
> Filed pants issue to fix this: 
> https://github.com/pantsbuild/pants/issues/3819
> 
> Joshua Cohen wrote:
> I was just talking to Stu Hood in pants slack about this. He came to the 
> same conclusion (removing the JVM backend caused test to no longer be linked 
> to compile). He suggested we might want to install a plugin to redirect 
> pythonstyle to the test goal instead.
> 
> I think that this solution is probably ok for my use cases (checking 
> style before posting a review and having ReviewBot catch style issues for me 
> so I don't have to call them out myself on other reviews), but wanted to 
> raise the option for those who might like to have checkstyle run during the 
> local dev flow of edit/test/repeat.
> 
> John Sirois wrote:
> Yeah - I'm happy to follow-up with a plugin to shim checkstyle into the 
> `./pants test...` workflow, but in the past custom pants plugins for Aurora 
> were frowned upon.

Yeah, I'm fine to commit this change and only add the plugin if someone feels 
strongly that hooking back into `./pants test ...` is critical.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51484/#review147139
---


On Aug. 28, 2016, 4:40 a.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51484/
> ---
> 
> (Updated Aug. 28, 2016, 4:40 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Re-enable python style check in the integration build.
> 
> pants test does not appear to invoke the python checkstyle. Re-enable
> it by explicitly calling in the integration build script. Also fix the
> few issues that have already been commited.
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/thermos/core/process.py 
> 78e7d788f14a1611031e3c6e255c77768daabac4 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> b30a5bc733ac5ccace0b93b68e2ee6f04ce31184 
>   src/test/python/apache/thermos/core/test_process.py 
> 49f52d947471c8ea8daae1708f4d26afa4c6ee0a 
> 
> Diff: https://reviews.apache.org/r/51484/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 51484: Re-enable python style check in the integration build.

2016-08-29 Thread John Sirois



> On Aug. 29, 2016, 10:39 a.m., John Sirois wrote:
> > I'm taking a look presently.  The seperate script call-out should no longer 
> > be needed since `./pants test...` implies `./pants compile...` which is all 
> > the seperate script does.
> 
> John Sirois wrote:
> Aha - yes, the compile dependency was historically leeched from the jvm 
> stack which is now not installed.  LGTM.
> 
> John Sirois wrote:
> Filed pants issue to fix this: 
> https://github.com/pantsbuild/pants/issues/3819
> 
> Joshua Cohen wrote:
> I was just talking to Stu Hood in pants slack about this. He came to the 
> same conclusion (removing the JVM backend caused test to no longer be linked 
> to compile). He suggested we might want to install a plugin to redirect 
> pythonstyle to the test goal instead.
> 
> I think that this solution is probably ok for my use cases (checking 
> style before posting a review and having ReviewBot catch style issues for me 
> so I don't have to call them out myself on other reviews), but wanted to 
> raise the option for those who might like to have checkstyle run during the 
> local dev flow of edit/test/repeat.

Yeah - I'm happy to follow-up with a plugin to shim checkstyle into the 
`./pants test...` workflow, but in the past custom pants plugins for Aurora 
were frowned upon.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51484/#review147139
---


On Aug. 27, 2016, 10:40 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51484/
> ---
> 
> (Updated Aug. 27, 2016, 10:40 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Re-enable python style check in the integration build.
> 
> pants test does not appear to invoke the python checkstyle. Re-enable
> it by explicitly calling in the integration build script. Also fix the
> few issues that have already been commited.
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/thermos/core/process.py 
> 78e7d788f14a1611031e3c6e255c77768daabac4 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> b30a5bc733ac5ccace0b93b68e2ee6f04ce31184 
>   src/test/python/apache/thermos/core/test_process.py 
> 49f52d947471c8ea8daae1708f4d26afa4c6ee0a 
> 
> Diff: https://reviews.apache.org/r/51484/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 51384: Introduce UpdateMetadata fields in JobUpdateRequest.

2016-08-29 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51384/#review147146
---




api/src/main/thrift/org/apache/aurora/gen/api.thrift (lines 795 - 796)


How about moving this into `JobUpdateSummary` instead? As it stands now, 
the access to update metadata requires exposing a potentially much heavier 
`JobUpdate` struct through our thrift interface. 

Bonus point: if you move it into the `JobUpdateSummary` the metadata will 
be automatically exposed via the existing `getJobUpdateSummaries` RPC.


- Maxim Khutornenko


On Aug. 28, 2016, 3:58 a.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51384/
> ---
> 
> (Updated Aug. 28, 2016, 3:58 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Maxim 
> Khutornenko.
> 
> 
> Bugs: AURORA-1711
> https://issues.apache.org/jira/browse/AURORA-1711
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Allow custom metadata to be stored with the job updates. This feature
> is to help case the reconciliation on job update request on the clients.
> 
> Today when a client's requests are proxied via a middle-man,
> if the middle-man times out before the scheduler responds with success,
> the client is left the only option of retry. In the case of updates,
> since multiple updates are not allowed in parallel, the retries fail,
> with INVALID_REQUEST. Although the original update is already accepted
> by the scheduler and is in-progress.
> 
> With this feature, clients can reconcile the job updates,
> - by marking updates them with a unique id in the metadata field
> - scheduler returns the in-progress job update in its response
> - client can match the client-generated ids to reconcile its state.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> c5765b70501c101f0535b4eed94e9948c36808f9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java 
> d2673e6b328cb1e249fbe91d18e0d9e935636eaa 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
>  a3b04949f1726f110638e4f93ef45947cdb9e7f8 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/migration/V008_CreateUpdateMetadataTable.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java 
> 78703e92c932cd5e93ff0b70f2a0b6928f6b4003 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  929d021a336c6a3438613c9340c84a1096dc9069 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  594bb6219294dcc77d48dcad14e2a6f9caa0c534 
>   
> src/main/java/org/apache/aurora/scheduler/updater/UpdateInProgressException.java
>  PRE-CREATION 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 9149c3018ae58d405f284fcbd4076d251ccc8192 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 
> 542f165add0f1d01a782fe6d6089bff3e736fb82 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  8563630a179cb6d1e3b0e22c730ccbfe1c9291e2 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> a40830fd668aa650c22a48cbc757b45aef27e961 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java
>  08530397ff75081bde6f07f9d53317b5486e0da4 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  779dc302602ae8842084807ca868a491ea99b676 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 04551f17999d742c53dfb1b36286b119b448550e 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 92fb039fb7d3e368d7c0dfa5ebdb465c7f112416 
>   src/test/python/apache/aurora/client/cli/util.py 
> aac9f9c802e4ad1f06cee8cf3f56749760b33af5 
> 
> Diff: https://reviews.apache.org/r/51384/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./pants test src/test/python/apache/aurora/client/cli:cli
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 51484: Re-enable python style check in the integration build.

2016-08-29 Thread Joshua Cohen



> On Aug. 29, 2016, 4:39 p.m., John Sirois wrote:
> > I'm taking a look presently.  The seperate script call-out should no longer 
> > be needed since `./pants test...` implies `./pants compile...` which is all 
> > the seperate script does.
> 
> John Sirois wrote:
> Aha - yes, the compile dependency was historically leeched from the jvm 
> stack which is now not installed.  LGTM.
> 
> John Sirois wrote:
> Filed pants issue to fix this: 
> https://github.com/pantsbuild/pants/issues/3819

I was just talking to Stu Hood in pants slack about this. He came to the same 
conclusion (removing the JVM backend caused test to no longer be linked to 
compile). He suggested we might want to install a plugin to redirect 
pythonstyle to the test goal instead.

I think that this solution is probably ok for my use cases (checking style 
before posting a review and having ReviewBot catch style issues for me so I 
don't have to call them out myself on other reviews), but wanted to raise the 
option for those who might like to have checkstyle run during the local dev 
flow of edit/test/repeat.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51484/#review147139
---


On Aug. 28, 2016, 4:40 a.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51484/
> ---
> 
> (Updated Aug. 28, 2016, 4:40 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Re-enable python style check in the integration build.
> 
> pants test does not appear to invoke the python checkstyle. Re-enable
> it by explicitly calling in the integration build script. Also fix the
> few issues that have already been commited.
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/thermos/core/process.py 
> 78e7d788f14a1611031e3c6e255c77768daabac4 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> b30a5bc733ac5ccace0b93b68e2ee6f04ce31184 
>   src/test/python/apache/thermos/core/test_process.py 
> 49f52d947471c8ea8daae1708f4d26afa4c6ee0a 
> 
> Diff: https://reviews.apache.org/r/51484/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 51484: Re-enable python style check in the integration build.

2016-08-29 Thread John Sirois



> On Aug. 29, 2016, 10:39 a.m., John Sirois wrote:
> > I'm taking a look presently.  The seperate script call-out should no longer 
> > be needed since `./pants test...` implies `./pants compile...` which is all 
> > the seperate script does.
> 
> John Sirois wrote:
> Aha - yes, the compile dependency was historically leeched from the jvm 
> stack which is now not installed.  LGTM.

Filed pants issue to fix this: https://github.com/pantsbuild/pants/issues/3819


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51484/#review147139
---


On Aug. 27, 2016, 10:40 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51484/
> ---
> 
> (Updated Aug. 27, 2016, 10:40 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Re-enable python style check in the integration build.
> 
> pants test does not appear to invoke the python checkstyle. Re-enable
> it by explicitly calling in the integration build script. Also fix the
> few issues that have already been commited.
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/thermos/core/process.py 
> 78e7d788f14a1611031e3c6e255c77768daabac4 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> b30a5bc733ac5ccace0b93b68e2ee6f04ce31184 
>   src/test/python/apache/thermos/core/test_process.py 
> 49f52d947471c8ea8daae1708f4d26afa4c6ee0a 
> 
> Diff: https://reviews.apache.org/r/51484/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 51484: Re-enable python style check in the integration build.

2016-08-29 Thread John Sirois



> On Aug. 29, 2016, 10:44 a.m., John Sirois wrote:
> > Ship It!

Zameer - I'll patch this in directly without your review since its 
straightforward.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51484/#review147142
---


On Aug. 27, 2016, 10:40 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51484/
> ---
> 
> (Updated Aug. 27, 2016, 10:40 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Re-enable python style check in the integration build.
> 
> pants test does not appear to invoke the python checkstyle. Re-enable
> it by explicitly calling in the integration build script. Also fix the
> few issues that have already been commited.
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/thermos/core/process.py 
> 78e7d788f14a1611031e3c6e255c77768daabac4 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> b30a5bc733ac5ccace0b93b68e2ee6f04ce31184 
>   src/test/python/apache/thermos/core/test_process.py 
> 49f52d947471c8ea8daae1708f4d26afa4c6ee0a 
> 
> Diff: https://reviews.apache.org/r/51484/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 51484: Re-enable python style check in the integration build.

2016-08-29 Thread John Sirois



> On Aug. 29, 2016, 10:39 a.m., John Sirois wrote:
> > I'm taking a look presently.  The seperate script call-out should no longer 
> > be needed since `./pants test...` implies `./pants compile...` which is all 
> > the seperate script does.

Aha - yes, the compile dependency was historically leeched from the jvm stack 
which is now not installed.  LGTM.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51484/#review147139
---


On Aug. 27, 2016, 10:40 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51484/
> ---
> 
> (Updated Aug. 27, 2016, 10:40 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Re-enable python style check in the integration build.
> 
> pants test does not appear to invoke the python checkstyle. Re-enable
> it by explicitly calling in the integration build script. Also fix the
> few issues that have already been commited.
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/thermos/core/process.py 
> 78e7d788f14a1611031e3c6e255c77768daabac4 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> b30a5bc733ac5ccace0b93b68e2ee6f04ce31184 
>   src/test/python/apache/thermos/core/test_process.py 
> 49f52d947471c8ea8daae1708f4d26afa4c6ee0a 
> 
> Diff: https://reviews.apache.org/r/51484/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 51484: Re-enable python style check in the integration build.

2016-08-29 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51484/#review147142
---


Ship it!




Ship It!

- John Sirois


On Aug. 27, 2016, 10:40 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51484/
> ---
> 
> (Updated Aug. 27, 2016, 10:40 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Re-enable python style check in the integration build.
> 
> pants test does not appear to invoke the python checkstyle. Re-enable
> it by explicitly calling in the integration build script. Also fix the
> few issues that have already been commited.
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/thermos/core/process.py 
> 78e7d788f14a1611031e3c6e255c77768daabac4 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> b30a5bc733ac5ccace0b93b68e2ee6f04ce31184 
>   src/test/python/apache/thermos/core/test_process.py 
> 49f52d947471c8ea8daae1708f4d26afa4c6ee0a 
> 
> Diff: https://reviews.apache.org/r/51484/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 51484: Re-enable python style check in the integration build.

2016-08-29 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51484/#review147139
---



I'm taking a look presently.  The seperate script call-out should no longer be 
needed since `./pants test...` implies `./pants compile...` which is all the 
seperate script does.

- John Sirois


On Aug. 27, 2016, 10:40 p.m., Santhosh Kumar Shanmugham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51484/
> ---
> 
> (Updated Aug. 27, 2016, 10:40 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Re-enable python style check in the integration build.
> 
> pants test does not appear to invoke the python checkstyle. Re-enable
> it by explicitly calling in the integration build script. Also fix the
> few issues that have already been commited.
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/thermos/core/process.py 
> 78e7d788f14a1611031e3c6e255c77768daabac4 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> b30a5bc733ac5ccace0b93b68e2ee6f04ce31184 
>   src/test/python/apache/thermos/core/test_process.py 
> 49f52d947471c8ea8daae1708f4d26afa4c6ee0a 
> 
> Diff: https://reviews.apache.org/r/51484/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Re: Review Request 51469: Remove static Stats method `exportSize`.

2016-08-29 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51469/#review147138
---



Not against this change but rather curious what your thoughts are wrt the 
larger picture here. Are you intending to get rid of all static helps in 
`Stats` in favor of the `StatsProvider`?

- Maxim Khutornenko


On Aug. 26, 2016, 10:11 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51469/
> ---
> 
> (Updated Aug. 26, 2016, 10:11 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Remove static Stats method `exportSize`.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> 538e8077ba762ec9a8f14f759740bb82144a5dc4 
>   commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
> 6b1fa4b35c54ab3e37a80c91664c6e8cfd4696c2 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
> a83f18307fd8e1d266f3d3ae8682333575eda884 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 
> a1ae7c7231d15d2f9715a7de30dfcde0a2f4d730 
>   src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 
> 6d4934b6b6de5273687041174315c4e3d151ac11 
>   src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 
> e7534c4325afa29b580d890cffdc26bdec7ef938 
> 
> Diff: https://reviews.apache.org/r/51469/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 51474: Uber

2016-08-29 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51474/#review147136
---


Ship it!




Ship It!

- Maxim Khutornenko


On Aug. 27, 2016, 5:53 a.m., Tarun Gogineni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51474/
> ---
> 
> (Updated Aug. 27, 2016, 5:53 a.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added Uber to the relevant user list
> 
> 
> Diffs
> -
> 
>   README.md 77fb77063eb96da9574794f989641c7746d2c35c 
> 
> Diff: https://reviews.apache.org/r/51474/diff/
> 
> 
> Testing
> ---
> 
> Their latest blog post regarding their engineering stack mentioned their use 
> of aurora for long running jobs.
> 
> 
> Thanks,
> 
> Tarun Gogineni
> 
>

53 matches

Mail list logo