subject:"Review Request 34337\: Add Docker Parameters"

Re: Review Request 34337: Add Docker Parameters

2015-07-22 Thread Mauricio Garavaglia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/
---

(Updated July 22, 2015, 10:42 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

Adding relevant issue.


Bugs: AURORA-1396
https://issues.apache.org/jira/browse/AURORA-1396


Repository: aurora


Description
---

Support Arbitrary Docker Parameters in DockerContainer


Diffs
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
d740a90e7732f42b43a79f8cf0afe705c061539c 
  docs/configuration-reference.md dafd306d672d9eb417394dc0cf49c7ac86695454 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 be79e70faa7125eee407fc57e8a297e18a51661f 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
c0d165ad34e46653dad95918e0058ebd3f2ee57f 
  src/main/python/apache/aurora/config/schema/base.py 
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c 
  src/main/python/apache/aurora/config/thrift.py 
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
c0cadfb34ade55bdb38ab2c0f89499bd6e8fa97a 
  src/test/python/apache/aurora/config/test_thrift.py 
f48ac88c076c12541626b497ca4fc47e5941dd31 

Diff: https://reviews.apache.org/r/34337/diff/


Testing
---

Used Docker as the container of a Job. Included volumes and label parameters 
which are correctly picked up by mesos when starting the task. The docker 
container gets the specified label and bind mounts the volumes correctly. I've 
been running multiple PostgreSQL databases docker containers for several weeks 
deploying them as aurora jobs.


Thanks,

Mauricio Garavaglia

Re: Review Request 34337: Add Docker Parameters

2015-07-22 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review92671
---

Ship it!


Ship It!

- Bill Farner


On July 18, 2015, 11:50 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated July 18, 2015, 11:50 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> d740a90e7732f42b43a79f8cf0afe705c061539c 
>   docs/configuration-reference.md dafd306d672d9eb417394dc0cf49c7ac86695454 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  be79e70faa7125eee407fc57e8a297e18a51661f 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> c0d165ad34e46653dad95918e0058ebd3f2ee57f 
>   src/main/python/apache/aurora/config/schema/base.py 
> d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c 
>   src/main/python/apache/aurora/config/thrift.py 
> 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> c0cadfb34ade55bdb38ab2c0f89499bd6e8fa97a 
>   src/test/python/apache/aurora/config/test_thrift.py 
> f48ac88c076c12541626b497ca4fc47e5941dd31 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> ---
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the specified label and bind mounts the volumes correctly. 
> I've been running multiple PostgreSQL databases docker containers for several 
> weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Re: Review Request 34337: Add Docker Parameters

2015-07-18 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review92193
---

Ship it!


Master (4eaacf7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On July 18, 2015, 11:50 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated July 18, 2015, 11:50 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> d740a90e7732f42b43a79f8cf0afe705c061539c 
>   docs/configuration-reference.md dafd306d672d9eb417394dc0cf49c7ac86695454 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  be79e70faa7125eee407fc57e8a297e18a51661f 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> c0d165ad34e46653dad95918e0058ebd3f2ee57f 
>   src/main/python/apache/aurora/config/schema/base.py 
> d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c 
>   src/main/python/apache/aurora/config/thrift.py 
> 88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> c0cadfb34ade55bdb38ab2c0f89499bd6e8fa97a 
>   src/test/python/apache/aurora/config/test_thrift.py 
> f48ac88c076c12541626b497ca4fc47e5941dd31 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> ---
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the specified label and bind mounts the volumes correctly. 
> I've been running multiple PostgreSQL databases docker containers for several 
> weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Re: Review Request 34337: Add Docker Parameters

2015-07-18 Thread Mauricio Garavaglia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/
---

(Updated July 18, 2015, 11:50 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

@ReviewBot retry


Repository: aurora


Description
---

Support Arbitrary Docker Parameters in DockerContainer


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
d740a90e7732f42b43a79f8cf0afe705c061539c 
  docs/configuration-reference.md dafd306d672d9eb417394dc0cf49c7ac86695454 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 be79e70faa7125eee407fc57e8a297e18a51661f 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
c0d165ad34e46653dad95918e0058ebd3f2ee57f 
  src/main/python/apache/aurora/config/schema/base.py 
d1f1e4f8082553f3a773e70a7f5cd0c48181ae8c 
  src/main/python/apache/aurora/config/thrift.py 
88dd1c7cf2e5a9bfbe827bc342d49f7a18bc8558 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
c0cadfb34ade55bdb38ab2c0f89499bd6e8fa97a 
  src/test/python/apache/aurora/config/test_thrift.py 
f48ac88c076c12541626b497ca4fc47e5941dd31 

Diff: https://reviews.apache.org/r/34337/diff/


Testing
---

Used Docker as the container of a Job. Included volumes and label parameters 
which are correctly picked up by mesos when starting the task. The docker 
container gets the specified label and bind mounts the volumes correctly. I've 
been running multiple PostgreSQL databases docker containers for several weeks 
deploying them as aurora jobs.


Thanks,

Mauricio Garavaglia

Re: Review Request 34337: Add Docker Parameters

2015-07-18 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review92192
---


This patch does not apply cleanly on master (4eaacf7), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On July 18, 2015, 11:36 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated July 18, 2015, 11:36 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> d740a90e7732f42b43a79f8cf0afe705c061539c 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
> a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   build-support/packaging/rpm/Makefile PRE-CREATION 
>   build-support/packaging/rpm/README.md PRE-CREATION 
>   build-support/packaging/rpm/aurora.init.sh PRE-CREATION 
>   build-support/packaging/rpm/aurora.service PRE-CREATION 
>   build-support/packaging/rpm/aurora.spec PRE-CREATION 
>   build-support/packaging/rpm/aurora.startup.sh PRE-CREATION 
>   build-support/packaging/rpm/aurora.sysconfig PRE-CREATION 
>   build-support/packaging/rpm/clusters.json PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.service PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION 
>   build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION 
>   build-support/python/isort 44f9659948703c75372cd70643d5631acb116c2e 
>   build-support/python/isort-check 646cbf0bae4ccf8eac044817138ed1a7a59b261b 
>   build.gradle 78159932388046883494dda97b4a86c06772d26d 
>   buildSrc/gradle.properties 3231a7add9e0503f0ee6779ae3c4000143b174ab 
>   config/findbugs/excludeFilter.xml e1c2503e0c6126c098063e0860f36cebbfe567ee 
>   config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
>   config/pmd/custom.xml 8ad62280f69db0fe185be0005225cf2d65d62383 
>   debian/aurora-doc.docs  
>   debian/aurora-doc.examples  
>   debian/aurora-executor.dirs  
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/aurora-executor.links  
>   debian/aurora-executor.thermos.default  
>   debian/aurora-executor.thermos.init  
>   debian/aurora-executor.thermos.upstart  
>   debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
>   debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
>   debian/aurora-scheduler.install  
>   debian/aurora-scheduler.links  
>   debian/aurora-scheduler.postinst  
>   debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
>   debian/aurora-tools.install  
>   debian/aurora-tools.links  
>   debian/changelog  
>   debian/clusters.json  
>   debian/compat  
>   debian/control 260ac8f42f47d604096282585c092e96448beb32 
>   debian/copyright  
>   debian/pants.ini  
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   debian/source/format  
>   docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
>   docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220 
>   docs/sla.md 14e9108fda91200bbf56384c96b9cd926689311f 
>   docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   docs/vagrant.md 7b796b2d70c9adf4a8b88bda625dcf70fdfb0f73 
>   examples/scheduler/scheduler-local.sh 
> 6253d505f9851aea613bc95c15c313b03b57af11 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 414539b1917b5d33c577f1539575934c7f7c8167 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> f4b867cbbcdbcc792518c2f90807834e47dce253 
>   gradle/wrapper/gradle-wrapper.properties 
> e713793f7d63e65ea68e091b959ba6a68352b48f 
>   rbt c082ab4e0f541ff0d8c94719b027902ad1aacb17 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
>   src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
> d3e1295db9b933b5ab60d6446dfea453c6051795 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
> 3413b0a480073f39bc01a60bc93b211660d9e278 
>   src/main/java/org/apache/aurora/GuavaUtils.java 
> 22104e6d005ae6706a06a21ffe4c7

Re: Review Request 34337: Add Docker Parameters

2015-07-18 Thread Mauricio Garavaglia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/
---

(Updated July 18, 2015, 11:36 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

@ReviewBot retry


Repository: aurora


Description
---

Support Arbitrary Docker Parameters in DockerContainer


Diffs (updated)
-

  NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
  api/src/main/thrift/org/apache/aurora/gen/BUILD 
fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
d740a90e7732f42b43a79f8cf0afe705c061539c 
  api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
  build-support/packaging/rpm/Makefile PRE-CREATION 
  build-support/packaging/rpm/README.md PRE-CREATION 
  build-support/packaging/rpm/aurora.init.sh PRE-CREATION 
  build-support/packaging/rpm/aurora.service PRE-CREATION 
  build-support/packaging/rpm/aurora.spec PRE-CREATION 
  build-support/packaging/rpm/aurora.startup.sh PRE-CREATION 
  build-support/packaging/rpm/aurora.sysconfig PRE-CREATION 
  build-support/packaging/rpm/clusters.json PRE-CREATION 
  build-support/packaging/rpm/thermos-observer.init.sh PRE-CREATION 
  build-support/packaging/rpm/thermos-observer.logrotate PRE-CREATION 
  build-support/packaging/rpm/thermos-observer.service PRE-CREATION 
  build-support/packaging/rpm/thermos-observer.startup.sh PRE-CREATION 
  build-support/packaging/rpm/thermos-observer.sysconfig PRE-CREATION 
  build-support/python/isort 44f9659948703c75372cd70643d5631acb116c2e 
  build-support/python/isort-check 646cbf0bae4ccf8eac044817138ed1a7a59b261b 
  build.gradle 78159932388046883494dda97b4a86c06772d26d 
  buildSrc/gradle.properties 3231a7add9e0503f0ee6779ae3c4000143b174ab 
  config/findbugs/excludeFilter.xml e1c2503e0c6126c098063e0860f36cebbfe567ee 
  config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
  config/pmd/custom.xml 8ad62280f69db0fe185be0005225cf2d65d62383 
  debian/aurora-doc.docs  
  debian/aurora-doc.examples  
  debian/aurora-executor.dirs  
  debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
  debian/aurora-executor.links  
  debian/aurora-executor.thermos.default  
  debian/aurora-executor.thermos.init  
  debian/aurora-executor.thermos.upstart  
  debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
  debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
  debian/aurora-scheduler.install  
  debian/aurora-scheduler.links  
  debian/aurora-scheduler.postinst  
  debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
  debian/aurora-tools.install  
  debian/aurora-tools.links  
  debian/changelog  
  debian/clusters.json  
  debian/compat  
  debian/control 260ac8f42f47d604096282585c092e96448beb32 
  debian/copyright  
  debian/pants.ini  
  debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
  debian/source/format  
  docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
  docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220 
  docs/sla.md 14e9108fda91200bbf56384c96b9cd926689311f 
  docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
  docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
  docs/vagrant.md 7b796b2d70c9adf4a8b88bda625dcf70fdfb0f73 
  examples/scheduler/scheduler-local.sh 
6253d505f9851aea613bc95c15c313b03b57af11 
  examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
414539b1917b5d33c577f1539575934c7f7c8167 
  examples/vagrant/upstart/aurora-scheduler.conf 
f4b867cbbcdbcc792518c2f90807834e47dce253 
  gradle/wrapper/gradle-wrapper.properties 
e713793f7d63e65ea68e091b959ba6a68352b48f 
  rbt c082ab4e0f541ff0d8c94719b027902ad1aacb17 
  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
  src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
d3e1295db9b933b5ab60d6446dfea453c6051795 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
3413b0a480073f39bc01a60bc93b211660d9e278 
  src/main/java/org/apache/aurora/GuavaUtils.java 
22104e6d005ae6706a06a21ffe4c730b14ecfe53 
  src/main/java/org/apache/aurora/GuiceUtils.java 
5d0af1ebdccd0d0782f0fbc53d046a338c450167 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
9e1f35a12205065f2f0cc783a49e14384bc4d50a 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
6edec22aba135136c4ce4066b9535f23de077db7 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
cd55a6ee7424873c3e615d95422c9ecab6442f46 
  src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
  src/m

Re: Review Request 34337: Add Docker Parameters

2015-07-18 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review92191
---


This patch does not apply cleanly on master (4eaacf7), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On July 18, 2015, 11:30 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated July 18, 2015, 11:30 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> d740a90e7732f42b43a79f8cf0afe705c061539c 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
> a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
>   debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
>   debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
>   docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220 
>   docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/scheduler/scheduler-local.sh 
> 6253d505f9851aea613bc95c15c313b03b57af11 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 414539b1917b5d33c577f1539575934c7f7c8167 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> f4b867cbbcdbcc792518c2f90807834e47dce253 
>   rbt c082ab4e0f541ff0d8c94719b027902ad1aacb17 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
>   src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
> d3e1295db9b933b5ab60d6446dfea453c6051795 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
> 3413b0a480073f39bc01a60bc93b211660d9e278 
>   src/main/java/org/apache/aurora/GuavaUtils.java 
> 22104e6d005ae6706a06a21ffe4c730b14ecfe53 
>   src/main/java/org/apache/aurora/GuiceUtils.java 
> 5d0af1ebdccd0d0782f0fbc53d046a338c450167 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
> 9e1f35a12205065f2f0cc783a49e14384bc4d50a 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 6edec22aba135136c4ce4066b9535f23de077db7 
>   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
> cd55a6ee7424873c3e615d95422c9ecab6442f46 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> c31446c447c3385a4763b8a516827988e46cc480 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 8bcac6c4f93eaca7250d43ab81a72102b91bf836 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> f2ef70ddc5a859811f0e6c2ade62e115639c1654 
>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
> f0dea48b3df69dedf620a55573731ed9451369c3 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
> f5a18338748da7c443b2fd2ec3a72adf75e7387f 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java
>  cd016af5621be76190ead81921096aae837b59c0 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
>  c1114a411c32c25785adc93e594ee8e291025969 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
> 41591b80ee6d078e1c2beb5d98c7a7584ce173e2 
>   src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
> 7f166e2ec24f66a9ab0c35e3c65af45e461943f9 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b77b0ebbf303778e528b16ff3db1aa4e76f1 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> df180a4f9dff75a04ae104462c219444ef605d9a 
>   
> src/main/java

Re: Review Request 34337: Add Docker Parameters

2015-07-18 Thread Mauricio Garavaglia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/
---

(Updated July 18, 2015, 11:30 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

@ReviewBot retry


Repository: aurora


Description
---

Support Arbitrary Docker Parameters in DockerContainer


Diffs (updated)
-

  NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
  api/src/main/thrift/org/apache/aurora/gen/BUILD 
fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
d740a90e7732f42b43a79f8cf0afe705c061539c 
  api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
  config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
  debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
  debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
  debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
  debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
  debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
  docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
  docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220 
  docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
  docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
  examples/scheduler/scheduler-local.sh 
6253d505f9851aea613bc95c15c313b03b57af11 
  examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
414539b1917b5d33c577f1539575934c7f7c8167 
  examples/vagrant/upstart/aurora-scheduler.conf 
f4b867cbbcdbcc792518c2f90807834e47dce253 
  rbt c082ab4e0f541ff0d8c94719b027902ad1aacb17 
  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
  src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
d3e1295db9b933b5ab60d6446dfea453c6051795 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
3413b0a480073f39bc01a60bc93b211660d9e278 
  src/main/java/org/apache/aurora/GuavaUtils.java 
22104e6d005ae6706a06a21ffe4c730b14ecfe53 
  src/main/java/org/apache/aurora/GuiceUtils.java 
5d0af1ebdccd0d0782f0fbc53d046a338c450167 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
9e1f35a12205065f2f0cc783a49e14384bc4d50a 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
6edec22aba135136c4ce4066b9535f23de077db7 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
cd55a6ee7424873c3e615d95422c9ecab6442f46 
  src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
c31446c447c3385a4763b8a516827988e46cc480 
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
8bcac6c4f93eaca7250d43ab81a72102b91bf836 
  src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
f2ef70ddc5a859811f0e6c2ade62e115639c1654 
  src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
f0dea48b3df69dedf620a55573731ed9451369c3 
  src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
f5a18338748da7c443b2fd2ec3a72adf75e7387f 
  
src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java 
cd016af5621be76190ead81921096aae837b59c0 
  
src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
 c1114a411c32c25785adc93e594ee8e291025969 
  src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
41591b80ee6d078e1c2beb5d98c7a7584ce173e2 
  src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
7f166e2ec24f66a9ab0c35e3c65af45e461943f9 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 b77b0ebbf303778e528b16ff3db1aa4e76f1 
  src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
df180a4f9dff75a04ae104462c219444ef605d9a 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
770672c85c06aaf4356b3b3580428b0323edb9d3 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
0063aea16ff39e95c8d32848fdb3eeec6ab1bee3 
  src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 
bd74f892dde65e957f125a17979ee6c582b3043f 
  src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java 
ecba276f1882162d9578e0829b2139040876c7d0 
  src/main/java/org/apache/aurora/scheduler/http/Cron.java 
fd658e1ac5e73ef0c61c82685f6373c5f0eb6640 
  src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java

Re: Review Request 34337: Add Docker Parameters

2015-07-09 Thread Bill Farner



> On July 8, 2015, 9:38 p.m., Bill Farner wrote:
> > Only nits remaining, and one request for test coverage.
> > 
> > One final disclaimer on the security issue this creates - IIUC, arbitrary 
> > user-specified volume mounts opens up your cluster to privilege escalation.
> > See this discussion for some detail: 
> > https://github.com/docker/docker/issues/3124, specifically this comment:
> > ```
> >  thaJeztah commented on May 23
> > 
> > @JWGmeligMeyling files and folders created in the volume will have the same 
> > uid:gid (numeric) as the user creating them in the container. If you add a 
> > user inside the container having the same uid:gid as outside the container 
> > and run your contsiner as that user, that should be possible
> > ```
> > 
> > More direct coverage of the risk:
> > https://fosterelli.co/privilege-escalation-via-docker.html
> > http://reventlov.com/advisories/using-the-docker-command-to-root-the-host
> > 
> > 
> > I'm happy to be proven wrong on this suspicion, but please confirm for 
> > yourself that this is safe to do.
> 
> Mauricio Garavaglia wrote:
> Hi, I'm aware of the security implications of the patch. Not only using 
> volumes, but also enabling privilege mode, enabling host based networking, or 
> mapping devices can mess up the host. But since this is supported by Mesos, 
> and we disable it by default now, I think is an assumed risk of using docker 
> and its faulty security model.
> 
> I understand this is a huge concern if the use case is that arbitrary 
> task definitions are submitted directly into aurora by users. One spurious 
> job can crash all the tasks in a host. But there are also other use cases in 
> which the interaction with aurora is curated or hidden behind another tool. 
> In those cases having this flexibility enables a lot of posibilities with 
> docker containers.
> 
> Do you think it would be beneficial to raise up the discussion involving 
> more people, or this modification just moves the project in the wrong 
> direction?

> Do you think it would be beneficial to raise up the discussion involving more 
> people, or this modification just moves the project in the wrong direction?

Since the default is to disable this, i'm okay with proceeding.  Just want to 
make sure you're aware of the potential pitfalls if this behavior is opened too 
widely :-)


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review90994
---


On July 5, 2015, 11:58 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated July 5, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90 
>   docs/configuration-reference.md dafd306 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  be79e70 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> c0d165a 
>   src/main/python/apache/aurora/config/schema/base.py d1f1e4f 
>   src/main/python/apache/aurora/config/thrift.py 88dd1c7 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> c0cadfb 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> ---
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the specified label and bind mounts the volumes correctly. 
> I've been running multiple PostgreSQL databases docker containers for several 
> weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Re: Review Request 34337: Add Docker Parameters

2015-07-08 Thread Mauricio Garavaglia



> On July 8, 2015, 9:38 p.m., Bill Farner wrote:
> > Only nits remaining, and one request for test coverage.
> > 
> > One final disclaimer on the security issue this creates - IIUC, arbitrary 
> > user-specified volume mounts opens up your cluster to privilege escalation.
> > See this discussion for some detail: 
> > https://github.com/docker/docker/issues/3124, specifically this comment:
> > ```
> >  thaJeztah commented on May 23
> > 
> > @JWGmeligMeyling files and folders created in the volume will have the same 
> > uid:gid (numeric) as the user creating them in the container. If you add a 
> > user inside the container having the same uid:gid as outside the container 
> > and run your contsiner as that user, that should be possible
> > ```
> > 
> > More direct coverage of the risk:
> > https://fosterelli.co/privilege-escalation-via-docker.html
> > http://reventlov.com/advisories/using-the-docker-command-to-root-the-host
> > 
> > 
> > I'm happy to be proven wrong on this suspicion, but please confirm for 
> > yourself that this is safe to do.

Hi, I'm aware of the security implications of the patch. Not only using 
volumes, but also enabling privilege mode, enabling host based networking, or 
mapping devices can mess up the host. But since this is supported by Mesos, and 
we disable it by default now, I think is an assumed risk of using docker and 
its faulty security model.

I understand this is a huge concern if the use case is that arbitrary task 
definitions are submitted directly into aurora by users. One spurious job can 
crash all the tasks in a host. But there are also other use cases in which the 
interaction with aurora is curated or hidden behind another tool. In those 
cases having this flexibility enables a lot of posibilities with docker 
containers.

Do you think it would be beneficial to raise up the discussion involving more 
people, or this modification just moves the project in the wrong direction?


- Mauricio


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review90994
---


On July 5, 2015, 11:58 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated July 5, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90 
>   docs/configuration-reference.md dafd306 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  be79e70 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> c0d165a 
>   src/main/python/apache/aurora/config/schema/base.py d1f1e4f 
>   src/main/python/apache/aurora/config/thrift.py 88dd1c7 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> c0cadfb 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> ---
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the specified label and bind mounts the volumes correctly. 
> I've been running multiple PostgreSQL databases docker containers for several 
> weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Re: Review Request 34337: Add Docker Parameters

2015-07-08 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review90994
---


Only nits remaining, and one request for test coverage.

One final disclaimer on the security issue this creates - IIUC, arbitrary 
user-specified volume mounts opens up your cluster to privilege escalation.
See this discussion for some detail: 
https://github.com/docker/docker/issues/3124, specifically this comment:
```
 thaJeztah commented on May 23

@JWGmeligMeyling files and folders created in the volume will have the same 
uid:gid (numeric) as the user creating them in the container. If you add a user 
inside the container having the same uid:gid as outside the container and run 
your contsiner as that user, that should be possible
```

More direct coverage of the risk:
https://fosterelli.co/privilege-escalation-via-docker.html
http://reventlov.com/advisories/using-the-docker-command-to-root-the-host


I'm happy to be proven wrong on this suspicion, but please confirm for yourself 
that this is safe to do.


src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 (line 66)


Matching the terminology above, how about s/enable/allow/?



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 186)


I believe this throws an NPE when parameters is not set.  Can you 
confirm/deny in a unit test case?



src/main/python/apache/aurora/config/schema/base.py (line 97)


I believe this should be
```
parameters = Default(List(Parameter), [])
```

to avoid requiring the argument.



src/main/python/apache/aurora/config/thrift.py (lines 133 - 137)


Please add a test case for this in
`src/test/python/apache/aurora/config/test_thrift.py`


- Bill Farner


On July 5, 2015, 11:58 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated July 5, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90 
>   docs/configuration-reference.md dafd306 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  be79e70 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> c0d165a 
>   src/main/python/apache/aurora/config/schema/base.py d1f1e4f 
>   src/main/python/apache/aurora/config/thrift.py 88dd1c7 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> c0cadfb 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> ---
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the specified label and bind mounts the volumes correctly. 
> I've been running multiple PostgreSQL databases docker containers for several 
> weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Re: Review Request 34337: Add Docker Parameters

2015-07-07 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review90855
---


Sorry for the delay in following up, i should have bandwidth to give this 
another look tomorrow!

- Bill Farner


On July 5, 2015, 11:58 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated July 5, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90 
>   docs/configuration-reference.md dafd306 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  be79e70 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> c0d165a 
>   src/main/python/apache/aurora/config/schema/base.py d1f1e4f 
>   src/main/python/apache/aurora/config/thrift.py 88dd1c7 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> c0cadfb 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> ---
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the specified label and bind mounts the volumes correctly. 
> I've been running multiple PostgreSQL databases docker containers for several 
> weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review90416
---

Ship it!


Master (82aa097) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On July 5, 2015, 11:58 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated July 5, 2015, 11:58 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90 
>   docs/configuration-reference.md dafd306 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  be79e70 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> c0d165a 
>   src/main/python/apache/aurora/config/schema/base.py d1f1e4f 
>   src/main/python/apache/aurora/config/thrift.py 88dd1c7 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> c0cadfb 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> ---
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the specified label and bind mounts the volumes correctly. 
> I've been running multiple PostgreSQL databases docker containers for several 
> weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Mauricio Garavaglia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/
---

(Updated July 5, 2015, 11:58 p.m.)


Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Support Arbitrary Docker Parameters in DockerContainer


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90 
  docs/configuration-reference.md dafd306 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 be79e70 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java c0d165a 
  src/main/python/apache/aurora/config/schema/base.py d1f1e4f 
  src/main/python/apache/aurora/config/thrift.py 88dd1c7 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
c0cadfb 

Diff: https://reviews.apache.org/r/34337/diff/


Testing
---

Used Docker as the container of a Job. Included volumes and label parameters 
which are correctly picked up by mesos when starting the task. The docker 
container gets the specified label and bind mounts the volumes correctly. I've 
been running multiple PostgreSQL databases docker containers for several weeks 
deploying them as aurora jobs.


Thanks,

Mauricio Garavaglia

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Mauricio Garavaglia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/
---

(Updated July 5, 2015, 11:55 p.m.)


Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Support Arbitrary Docker Parameters in DockerContainer


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift d740a90 
  docs/configuration-reference.md dafd306 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 be79e70 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java c0d165a 
  src/main/python/apache/aurora/config/schema/base.py d1f1e4f 
  src/main/python/apache/aurora/config/thrift.py 88dd1c7 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
c0cadfb 

Diff: https://reviews.apache.org/r/34337/diff/


Testing
---

Used Docker as the container of a Job. Included volumes and label parameters 
which are correctly picked up by mesos when starting the task. The docker 
container gets the specified label and bind mounts the volumes correctly. I've 
been running multiple PostgreSQL databases docker containers for several weeks 
deploying them as aurora jobs.


Thanks,

Mauricio Garavaglia

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review90415
---


This patch does not apply cleanly on master (82aa097), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On July 5, 2015, 11:32 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated July 5, 2015, 11:32 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
>   api/src/main/thrift/org/apache/aurora/gen/BUILD 
> fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> d740a90e7732f42b43a79f8cf0afe705c061539c 
>   api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
> a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
>   config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
>   debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
>   debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
>   debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
>   debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
>   debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
>   docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
>   docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220 
>   docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
>   docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
>   examples/scheduler/scheduler-local.sh 
> 6253d505f9851aea613bc95c15c313b03b57af11 
>   examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
> 414539b1917b5d33c577f1539575934c7f7c8167 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> f4b867cbbcdbcc792518c2f90807834e47dce253 
>   rbt c082ab4e0f541ff0d8c94719b027902ad1aacb17 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
> 4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
>   src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
> d3e1295db9b933b5ab60d6446dfea453c6051795 
>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
> 3413b0a480073f39bc01a60bc93b211660d9e278 
>   src/main/java/org/apache/aurora/GuavaUtils.java 
> 22104e6d005ae6706a06a21ffe4c730b14ecfe53 
>   src/main/java/org/apache/aurora/GuiceUtils.java 
> 5d0af1ebdccd0d0782f0fbc53d046a338c450167 
>   src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
> 9e1f35a12205065f2f0cc783a49e14384bc4d50a 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 6edec22aba135136c4ce4066b9535f23de077db7 
>   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
> cd55a6ee7424873c3e615d95422c9ecab6442f46 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> c31446c447c3385a4763b8a516827988e46cc480 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> 8bcac6c4f93eaca7250d43ab81a72102b91bf836 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> f2ef70ddc5a859811f0e6c2ade62e115639c1654 
>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
> f0dea48b3df69dedf620a55573731ed9451369c3 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
> f5a18338748da7c443b2fd2ec3a72adf75e7387f 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java
>  cd016af5621be76190ead81921096aae837b59c0 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
>  c1114a411c32c25785adc93e594ee8e291025969 
>   src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
> 41591b80ee6d078e1c2beb5d98c7a7584ce173e2 
>   src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
> 7f166e2ec24f66a9ab0c35e3c65af45e461943f9 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b77b0ebbf303778e528b16ff3db1aa4e76f1 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> df180a4f9dff75a04ae104462c219444ef605d9a 
>   
> src/main/java/o

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Mauricio Garavaglia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/
---

(Updated July 5, 2015, 11:32 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

rebased. @ReviewBot retry


Repository: aurora


Description
---

Support Arbitrary Docker Parameters in DockerContainer


Diffs (updated)
-

  NEWS a17f0e7c08fd30a0b2db6814a1c755111307228b 
  api/src/main/thrift/org/apache/aurora/gen/BUILD 
fe3f83b6a7680985dce01efe2d54ccc4b0c2c482 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
d740a90e7732f42b43a79f8cf0afe705c061539c 
  api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift 
a2c230fa9b5f648c4674042411cbe46fb8bb4faa 
  config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d 
  debian/aurora-executor.install 8efb1308caf64a23bed4b580de4b86e7982539e8 
  debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 
  debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 
  debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba 
  debian/rules 6ba18cef7fbf0989507d630a1041cdf958742617 
  docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
  docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220 
  docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a 
  docs/test-resource-generation.md 335586d64757f1e6293a89f14c1c3d578321eac6 
  examples/scheduler/scheduler-local.sh 
6253d505f9851aea613bc95c15c313b03b57af11 
  examples/vagrant/aurorabuild.sh 5eb171cf45ffee1287f3ac039ab8cf3db6991a97 
  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
414539b1917b5d33c577f1539575934c7f7c8167 
  examples/vagrant/upstart/aurora-scheduler.conf 
f4b867cbbcdbcc792518c2f90807834e47dce253 
  rbt c082ab4e0f541ff0d8c94719b027902ad1aacb17 
  src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 
4c63cc7af2fb5702fa649ce2cd4ee619139223e2 
  src/jmh/java/org/apache/aurora/benchmark/Tasks.java 
d3e1295db9b933b5ab60d6446dfea453c6051795 
  src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java 
3413b0a480073f39bc01a60bc93b211660d9e278 
  src/main/java/org/apache/aurora/GuavaUtils.java 
22104e6d005ae6706a06a21ffe4c730b14ecfe53 
  src/main/java/org/apache/aurora/GuiceUtils.java 
5d0af1ebdccd0d0782f0fbc53d046a338c450167 
  src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java 
9e1f35a12205065f2f0cc783a49e14384bc4d50a 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
6edec22aba135136c4ce4066b9535f23de077db7 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
cd55a6ee7424873c3e615d95422c9ecab6442f46 
  src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
6bfbf0c76399d569ac762a7b433a6c576bf0ee87 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
c31446c447c3385a4763b8a516827988e46cc480 
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
8bcac6c4f93eaca7250d43ab81a72102b91bf836 
  src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
f2ef70ddc5a859811f0e6c2ade62e115639c1654 
  src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
f0dea48b3df69dedf620a55573731ed9451369c3 
  src/main/java/org/apache/aurora/scheduler/async/preemptor/BiCache.java 
f5a18338748da7c443b2fd2ec3a72adf75e7387f 
  
src/main/java/org/apache/aurora/scheduler/async/preemptor/ClusterStateImpl.java 
cd016af5621be76190ead81921096aae837b59c0 
  
src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java
 c1114a411c32c25785adc93e594ee8e291025969 
  src/main/java/org/apache/aurora/scheduler/async/preemptor/Preemptor.java 
41591b80ee6d078e1c2beb5d98c7a7584ce173e2 
  src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java 
7f166e2ec24f66a9ab0c35e3c65af45e461943f9 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 b77b0ebbf303778e528b16ff3db1aa4e76f1 
  src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
673a6909ec1bccbc43b0a3cd913aa48b9b1d90c1 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
df180a4f9dff75a04ae104462c219444ef605d9a 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
770672c85c06aaf4356b3b3580428b0323edb9d3 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
0063aea16ff39e95c8d32848fdb3eeec6ab1bee3 
  src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 
bd74f892dde65e957f125a17979ee6c582b3043f 
  src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java 
ecba276f1882162d9578e0829b2139040876c7d0 
  src/main/java/org/apache/aurora/scheduler/http/Cron.java 
fd658e1ac5e73ef0c61c82685f6373c5f0eb6640 
  src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModu

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review90414
---


This patch does not apply cleanly on master (82aa097), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On July 5, 2015, 10:39 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated July 5, 2015, 10:39 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> d740a90e7732f42b43a79f8cf0afe705c061539c 
>   docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  b77b0ebbf303778e528b16ff3db1aa4e76f1 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   src/main/python/apache/aurora/config/schema/base.py 
> ec9f983564516afe542ab277d987d4d391f87e45 
>   src/main/python/apache/aurora/config/thrift.py 
> 810febb637d168b07c4aea77984e1d1451a39af2 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> ---
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the specified label and bind mounts the volumes correctly. 
> I've been running multiple PostgreSQL databases docker containers for several 
> weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Re: Review Request 34337: Add Docker Parameters

2015-07-05 Thread Mauricio Garavaglia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/
---

(Updated July 5, 2015, 10:39 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

added argument to disable arbitrary docker parameters


Repository: aurora


Description
---

Support Arbitrary Docker Parameters in DockerContainer


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
d740a90e7732f42b43a79f8cf0afe705c061539c 
  docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 b77b0ebbf303778e528b16ff3db1aa4e76f1 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
e934f570e4a728470408970485abe0809487d312 
  src/main/python/apache/aurora/config/schema/base.py 
ec9f983564516afe542ab277d987d4d391f87e45 
  src/main/python/apache/aurora/config/thrift.py 
810febb637d168b07c4aea77984e1d1451a39af2 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 

Diff: https://reviews.apache.org/r/34337/diff/


Testing
---

Used Docker as the container of a Job. Included volumes and label parameters 
which are correctly picked up by mesos when starting the task. The docker 
container gets the specified label and bind mounts the volumes correctly. I've 
been running multiple PostgreSQL databases docker containers for several weeks 
deploying them as aurora jobs.


Thanks,

Mauricio Garavaglia

Re: Review Request 34337: Add Docker Parameters

2015-06-25 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review89383
---


LGTM in general!  Biggest blocker for me is ability to toggle this behavior off.


api/src/main/thrift/org/apache/aurora/gen/api.thrift (lines 207 - 213)


Move this down below `MesosContainer` so it's closer to `DockerContainer`.

I haven't followed the wiring into mesos, but i assume these are docker 
command line args?  If so, it would be handy to call that out explicitly and 
include a link [1] in our docs.

[1] https://docs.docker.com/reference/commandline/cli/



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (lines 
186 - 195)


Similar to the `allowed_container_types` argument used in 
`ConfigurationManager`, we need a command line argument to disable this, as it 
poses a security risk on a shared cluster.



src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
(line 175)


s/final //



src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
(line 177)


Consider asserting on the whole list rather than a single value:
```
assertEquals(
ImmutableList.of(...),
docker.getParametersList());
```


- Bill Farner


On June 20, 2015, 11:42 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated June 20, 2015, 11:42 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> d740a90e7732f42b43a79f8cf0afe705c061539c 
>   docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   src/main/python/apache/aurora/config/schema/base.py 
> ec9f983564516afe542ab277d987d4d391f87e45 
>   src/main/python/apache/aurora/config/thrift.py 
> 810febb637d168b07c4aea77984e1d1451a39af2 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> ---
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the specified label and bind mounts the volumes correctly. 
> I've been running multiple PostgreSQL databases docker containers for several 
> weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Re: Review Request 34337: Add Docker Parameters

2015-06-20 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review88676
---

Ship it!


Master (d240926) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On June 20, 2015, 11:42 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated June 20, 2015, 11:42 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> d740a90e7732f42b43a79f8cf0afe705c061539c 
>   docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   src/main/python/apache/aurora/config/schema/base.py 
> ec9f983564516afe542ab277d987d4d391f87e45 
>   src/main/python/apache/aurora/config/thrift.py 
> 810febb637d168b07c4aea77984e1d1451a39af2 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> ---
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the specified label and bind mounts the volumes correctly. 
> I've been running multiple PostgreSQL databases docker containers for several 
> weeks deploying them as aurora jobs.
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>

Re: Review Request 34337: Add Docker Parameters

2015-06-20 Thread Mauricio Garavaglia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/
---

(Updated June 20, 2015, 11:42 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

fix formatting issues


Repository: aurora


Description
---

Support Arbitrary Docker Parameters in DockerContainer


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
d740a90e7732f42b43a79f8cf0afe705c061539c 
  docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
e934f570e4a728470408970485abe0809487d312 
  src/main/python/apache/aurora/config/schema/base.py 
ec9f983564516afe542ab277d987d4d391f87e45 
  src/main/python/apache/aurora/config/thrift.py 
810febb637d168b07c4aea77984e1d1451a39af2 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 

Diff: https://reviews.apache.org/r/34337/diff/


Testing
---

Used Docker as the container of a Job. Included volumes and label parameters 
which are correctly picked up by mesos when starting the task. The docker 
container gets the specified label and bind mounts the volumes correctly. I've 
been running multiple PostgreSQL databases docker containers for several weeks 
deploying them as aurora jobs.


Thanks,

Mauricio Garavaglia

Re: Review Request 34337: Add Docker Parameters

2015-05-17 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/#review84082
---


Master (07ab0bb) is red with this patch.
  ./build-support/jenkins/build.sh

Collecting twitter.common.util==0.3.0 (from 
twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.util-0.3.0.tar.gz
Collecting twitter.common.collections==0.3.0 (from 
twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.collections-0.3.0.tar.gz
Collecting smmap>=0.8.5 (from 
gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0)
  Using cached smmap-0.9.0.tar.gz
Collecting twitter.common.string==0.3.0 (from 
twitter.common.process==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.string-0.3.0.tar.gz
Collecting twitter.common.options==0.3.0 (from 
twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.options-0.3.0.tar.gz
Collecting twitter.common.dirutil==0.3.0 (from 
twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.dirutil-0.3.0.tar.gz
Collecting twitter.common.contextutil==0.3.0 (from 
twitter.common.util==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.contextutil-0.3.0.tar.gz
Collecting twitter.common.lang==0.3.0 (from 
twitter.common.collections==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
  Using cached twitter.common.lang-0.3.0.tar.gz
Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython, 
twitter.common.lang, twitter.common.string, twitter.common.process, 
twitter.common.options, twitter.common.dirutil, twitter.common.log, 
twitter.common.contextutil, twitter.common.util, twitter.common.collections, 
twitter.common.app, twitter.checkstyle
  Running setup.py install for pyflakes
  Running setup.py install for pep8
  Running setup.py install for smmap
  Running setup.py install for gitdb
  Running setup.py install for GitPython
  Running setup.py install for twitter.common.lang
  Running setup.py install for twitter.common.string
  Running setup.py install for twitter.common.process
  Running setup.py install for twitter.common.options
  Running setup.py install for twitter.common.dirutil
  Running setup.py install for twitter.common.log
  Running setup.py install for twitter.common.contextutil
  Running setup.py install for twitter.common.util
  Running setup.py install for twitter.common.collections
  Running setup.py install for twitter.common.app
  Running setup.py install for twitter.checkstyle
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2 
smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0 
twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0 
twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0 
twitter.common.options-0.3.0 twitter.common.process-0.3.0 
twitter.common.string-0.3.0 twitter.common.util-0.3.0
T100:ERROR   src/main/python/apache/aurora/config/thrift.py:134 Indentation of 
4 instead of 2
 |for p in fully_interpolated(container.docker().parameters()):

T100:ERROR   src/main/python/apache/aurora/config/thrift.py:135 Indentation of 
4 instead of 2
 |params.append(DockerParameter(p['name'], p['value']))



I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 17, 2015, 9:40 p.m., Mauricio Garavaglia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34337/
> ---
> 
> (Updated May 17, 2015, 9:40 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Support Arbitrary Docker Parameters in DockerContainer
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> dd54e5b50050540b8599003786c79e4b033f3739 
>   docs/configuration-reference.md af332f27dfb88325d56a9694a3311eb4fd9c320f 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> e934f570e4a728470408970485abe0809487d312 
>   src/main/python/apache/aurora/config/schema/base.py 
> a87524a8b3ad5aa0e337e0a0028cecb85865b4e6 
>   src/main/python/apache/aurora/config/thrift.py 
> 810febb637d168b07c4aea77984e1d1451a39af2 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 
> 
> Diff: https://reviews.apache.org/r/34337/diff/
> 
> 
> Testing
> ---
> 
> Used Docker as the container of a Job. Included volumes and label parameters 
> which are correctly picked up by mesos when starting the task. The docker 
> container gets the spe

Review Request 34337: Add Docker Parameters

2015-05-17 Thread Mauricio Garavaglia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34337/
---

Review request for Aurora.


Repository: aurora


Description
---

Support Arbitrary Docker Parameters in DockerContainer


Diffs
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
dd54e5b50050540b8599003786c79e4b033f3739 
  docs/configuration-reference.md af332f27dfb88325d56a9694a3311eb4fd9c320f 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
e934f570e4a728470408970485abe0809487d312 
  src/main/python/apache/aurora/config/schema/base.py 
a87524a8b3ad5aa0e337e0a0028cecb85865b4e6 
  src/main/python/apache/aurora/config/thrift.py 
810febb637d168b07c4aea77984e1d1451a39af2 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 

Diff: https://reviews.apache.org/r/34337/diff/


Testing
---

Used Docker as the container of a Job. Included volumes and label parameters 
which are correctly picked up by mesos when starting the task. The docker 
container gets the specified label and bind mounts the volumes correctly. I've 
been running multiple PostgreSQL databases docker containers for several weeks 
deploying them as aurora jobs.


Thanks,

Mauricio Garavaglia

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Re: Review Request 34337: Add Docker Parameters

Review Request 34337: Add Docker Parameters

24 matches

Site Navigation

Mail list logo

Footer information