date:20140218

Review Request 18241: Reworked LogStorage to avoid unnecessary extra calls to write().

2014-02-18 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18241/
---

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-134
https://issues.apache.org/jira/browse/AURORA-134


Repository: aurora


Description
---

Don't unnecessarily invoke write() within LogStorage, and assert that a 
transaction is open when a mutation is performed.

I'm starting to explore a refactor that further cleans this up by extracting 
the *Store implementations out of LogStorage, which should simplify things by 
separating transaction management from delegation.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
36e4082acceb3045ef92a5957b500e407bfc1247 
  
src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 
005bad2c6b9f13e3438f3136e63fe777c6b42507 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
f708ab3c2fa5d50b084e037f9cc0cb998935120a 

Diff: https://reviews.apache.org/r/18241/diff/


Testing
---

./gradlew build


Thanks,

Bill Farner

Re: Review Request 18247: Add kevints CODE SIGNING KEY to KEYS.

2014-02-18 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18247/#review34813
---

Ship it!


Ship It!

- Bill Farner


On Feb. 18, 2014, 10:50 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18247/
> ---
> 
> (Updated Feb. 18, 2014, 10:50 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add kevints CODE SIGNING KEY to KEYS.
> 
> 
> Diffs
> -
> 
>   KEYS 55eec288042426313f67b070b1cc489283ef2bbf 
> 
> Diff: https://reviews.apache.org/r/18247/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 18245: Use user.signingkey for tag-signing.

2014-02-18 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18245/#review34812
---

Ship it!


Ship It!

- Bill Farner


On Feb. 18, 2014, 10:38 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18245/
> ---
> 
> (Updated Feb. 18, 2014, 10:38 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use user.signingkey for tag-signing.
> 
> Rather than use UID require an explicitly-set key ID, following 
> recommendations at [1].
> 
> [1] http://www.apache.org/dev/openpgp.html
> 
> 
> Diffs
> -
> 
>   build-support/release/tag-release 61760aa162bb09aa0725001f878ad2bef3dcfdbd 
> 
> Diff: https://reviews.apache.org/r/18245/diff/
> 
> 
> Testing
> ---
> 
> Tested with user.signingkey set and unset on local merged master.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 18248: fix python tests on master

2014-02-18 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18248/#review34810
---

Ship it!


Ship It!

- Brian Wickman


On Feb. 18, 2014, 11:31 p.m., Jonathan Boulle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18248/
> ---
> 
> (Updated Feb. 18, 2014, 11:31 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> derr
> https://builds.apache.org/job/Aurora/116/changes
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/config/thrift.py 
> e293c92c7a2a6fa4eb165d10b8b1ac08be8e22c1 
> 
> Diff: https://reviews.apache.org/r/18248/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Boulle
> 
>

Review Request 18248: fix python tests on master

2014-02-18 Thread Jonathan Boulle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18248/
---

Review request for Aurora, Kevin Sweeney and Brian Wickman.


Repository: aurora


Description
---

derr
https://builds.apache.org/job/Aurora/116/changes


Diffs
-

  src/main/python/apache/aurora/config/thrift.py 
e293c92c7a2a6fa4eb165d10b8b1ac08be8e22c1 

Diff: https://reviews.apache.org/r/18248/diff/


Testing
---


Thanks,

Jonathan Boulle

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/
---

(Updated Feb. 18, 2014, 11:19 p.m.)


Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Changes
---

CR comments.


Bugs: AURORA-207
https://issues.apache.org/jira/browse/AURORA-207


Repository: aurora


Description
---

Added "sla get_job_uptime" command.

Also, changed from ValueError to ArgumentTypeError in options.py as the former 
is not handled properly by argparser and no custom messages were reported.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/sla.py 
b69d20818836fb6ae87b333e33008b27e013954f 
  src/main/python/apache/aurora/client/cli/options.py 
37f416d563b526cccf3c9cab69a5df15873db250 
  src/main/python/apache/aurora/client/cli/sla.py 
a3973df870567052083b1d5a524438191eb6d812 
  src/test/python/apache/aurora/client/api/test_sla.py 
54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
  src/test/python/apache/aurora/client/cli/test_sla.py 
703d39e4566a30900f1e9bcca5871c4a426cc6c3 

Diff: https://reviews.apache.org/r/18153/diff/


Testing
---

./build-support/jenkins/build.sh 


Thanks,

Maxim Khutornenko

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Maxim Khutornenko



> On Feb. 18, 2014, 10:58 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/api/sla.py, line 61
> > 
> >
> > raise ValueError('Percentile must be within (0, 100), got %r instead.' 
> > % percentile)
> >

Done.


> On Feb. 18, 2014, 10:58 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/cli/options.py, line 77
> > 
> >
> > invert this
> > 
> > return sorted(...) if percentiles else None

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34798
---


On Feb. 18, 2014, 10:52 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18153/
> ---
> 
> (Updated Feb. 18, 2014, 10:52 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-207
> https://issues.apache.org/jira/browse/AURORA-207
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added "sla get_job_uptime" command.
> 
> Also, changed from ValueError to ArgumentTypeError in options.py as the 
> former is not handled properly by argparser and no custom messages were 
> reported.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> b69d20818836fb6ae87b333e33008b27e013954f 
>   src/main/python/apache/aurora/client/cli/options.py 
> 37f416d563b526cccf3c9cab69a5df15873db250 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> 703d39e4566a30900f1e9bcca5871c4a426cc6c3 
> 
> Diff: https://reviews.apache.org/r/18153/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34798
---

Ship it!



src/main/python/apache/aurora/client/api/sla.py


raise ValueError('Percentile must be within (0, 100), got %r instead.' % 
percentile)




src/main/python/apache/aurora/client/cli/options.py


invert this

return sorted(...) if percentiles else None


- Brian Wickman


On Feb. 18, 2014, 10:52 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18153/
> ---
> 
> (Updated Feb. 18, 2014, 10:52 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-207
> https://issues.apache.org/jira/browse/AURORA-207
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added "sla get_job_uptime" command.
> 
> Also, changed from ValueError to ArgumentTypeError in options.py as the 
> former is not handled properly by argparser and no custom messages were 
> reported.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> b69d20818836fb6ae87b333e33008b27e013954f 
>   src/main/python/apache/aurora/client/cli/options.py 
> 37f416d563b526cccf3c9cab69a5df15873db250 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> 703d39e4566a30900f1e9bcca5871c4a426cc6c3 
> 
> Diff: https://reviews.apache.org/r/18153/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Maxim Khutornenko



> On Feb. 18, 2014, 10:15 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/cli/options.py, line 70
> > 
> >
> > is 100 an incorrect percentile?  100th percentile means max() right?
> 
> Brian Wickman wrote:
> derp, nevermind, the internet wins:
> http://en.wikipedia.org/wiki/Percentile

feels like a lack of unit testing here. Added boundary condition testing.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34788
---


On Feb. 18, 2014, 10:52 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18153/
> ---
> 
> (Updated Feb. 18, 2014, 10:52 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-207
> https://issues.apache.org/jira/browse/AURORA-207
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added "sla get_job_uptime" command.
> 
> Also, changed from ValueError to ArgumentTypeError in options.py as the 
> former is not handled properly by argparser and no custom messages were 
> reported.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> b69d20818836fb6ae87b333e33008b27e013954f 
>   src/main/python/apache/aurora/client/cli/options.py 
> 37f416d563b526cccf3c9cab69a5df15873db250 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> 703d39e4566a30900f1e9bcca5871c4a426cc6c3 
> 
> Diff: https://reviews.apache.org/r/18153/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/
---

(Updated Feb. 18, 2014, 10:52 p.m.)


Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Changes
---

CR comments.


Bugs: AURORA-207
https://issues.apache.org/jira/browse/AURORA-207


Repository: aurora


Description
---

Added "sla get_job_uptime" command.

Also, changed from ValueError to ArgumentTypeError in options.py as the former 
is not handled properly by argparser and no custom messages were reported.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/sla.py 
b69d20818836fb6ae87b333e33008b27e013954f 
  src/main/python/apache/aurora/client/cli/options.py 
37f416d563b526cccf3c9cab69a5df15873db250 
  src/main/python/apache/aurora/client/cli/sla.py 
a3973df870567052083b1d5a524438191eb6d812 
  src/test/python/apache/aurora/client/api/test_sla.py 
54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
  src/test/python/apache/aurora/client/cli/test_sla.py 
703d39e4566a30900f1e9bcca5871c4a426cc6c3 

Diff: https://reviews.apache.org/r/18153/diff/


Testing
---

./build-support/jenkins/build.sh 


Thanks,

Maxim Khutornenko

Review Request 18247: Add kevints CODE SIGNING KEY to KEYS.

2014-02-18 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18247/
---

Review request for Aurora, Jake Farrell and Bill Farner.


Repository: aurora


Description
---

Add kevints CODE SIGNING KEY to KEYS.


Diffs
-

  KEYS 55eec288042426313f67b070b1cc489283ef2bbf 

Diff: https://reviews.apache.org/r/18247/diff/


Testing
---


Thanks,

Kevin Sweeney

Review Request 18245: Use user.signingkey for tag-signing.

2014-02-18 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18245/
---

Review request for Aurora, Jake Farrell and Bill Farner.


Repository: aurora


Description
---

Use user.signingkey for tag-signing.

Rather than use UID require an explicitly-set key ID, following recommendations 
at [1].

[1] http://www.apache.org/dev/openpgp.html


Diffs
-

  build-support/release/tag-release 61760aa162bb09aa0725001f878ad2bef3dcfdbd 

Diff: https://reviews.apache.org/r/18245/diff/


Testing
---

Tested with user.signingkey set and unset on local merged master.


Thanks,

Kevin Sweeney

Re: Review Request 18244: Use GMT in generated predictions.

2014-02-18 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18244/#review34790
---

Ship it!


Ship It!

- Bill Farner


On Feb. 18, 2014, 10:15 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18244/
> ---
> 
> (Updated Feb. 18, 2014, 10:15 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use GMT in generated conformance data.
> 
> 
> Diffs
> -
> 
>   
> src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json
>  d4feb1bd8245aa294c3231b141018070fb0d68e5 
> 
> Diff: https://reviews.apache.org/r/18244/diff/
> 
> 
> Testing
> ---
> 
> Manual inspection.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34788
---



src/main/python/apache/aurora/client/cli/options.py


is 100 an incorrect percentile?  100th percentile means max() right?


- Brian Wickman


On Feb. 18, 2014, 8:46 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18153/
> ---
> 
> (Updated Feb. 18, 2014, 8:46 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-207
> https://issues.apache.org/jira/browse/AURORA-207
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added "sla get_job_uptime" command.
> 
> Also, changed from ValueError to ArgumentTypeError in options.py as the 
> former is not handled properly by argparser and no custom messages were 
> reported.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> b69d20818836fb6ae87b333e33008b27e013954f 
>   src/main/python/apache/aurora/client/cli/options.py 
> 37f416d563b526cccf3c9cab69a5df15873db250 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> 703d39e4566a30900f1e9bcca5871c4a426cc6c3 
> 
> Diff: https://reviews.apache.org/r/18153/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Brian Wickman



> On Feb. 18, 2014, 10:15 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/cli/options.py, line 70
> > 
> >
> > is 100 an incorrect percentile?  100th percentile means max() right?

derp, nevermind, the internet wins:
http://en.wikipedia.org/wiki/Percentile


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34788
---


On Feb. 18, 2014, 8:46 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18153/
> ---
> 
> (Updated Feb. 18, 2014, 8:46 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-207
> https://issues.apache.org/jira/browse/AURORA-207
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added "sla get_job_uptime" command.
> 
> Also, changed from ValueError to ArgumentTypeError in options.py as the 
> former is not handled properly by argparser and no custom messages were 
> reported.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> b69d20818836fb6ae87b333e33008b27e013954f 
>   src/main/python/apache/aurora/client/cli/options.py 
> 37f416d563b526cccf3c9cab69a5df15873db250 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> 703d39e4566a30900f1e9bcca5871c4a426cc6c3 
> 
> Diff: https://reviews.apache.org/r/18153/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 18244: Use GMT in generated predictions.

2014-02-18 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18244/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Use GMT in generated conformance data.


Diffs
-

  
src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json
 d4feb1bd8245aa294c3231b141018070fb0d68e5 

Diff: https://reviews.apache.org/r/18244/diff/


Testing
---

Manual inspection.


Thanks,

Kevin Sweeney

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Brian Wickman



> On Feb. 18, 2014, 8:45 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/api/sla.py, lines 61-62
> > 
> >
> > This is handled in the return statement by validating the index range. 
> > Having max() would not hurt though. Added.

except the semantics are different: the previous way would return 0 instead of 
return array[0] which is correct.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34775
---


On Feb. 18, 2014, 8:46 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18153/
> ---
> 
> (Updated Feb. 18, 2014, 8:46 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-207
> https://issues.apache.org/jira/browse/AURORA-207
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added "sla get_job_uptime" command.
> 
> Also, changed from ValueError to ArgumentTypeError in options.py as the 
> former is not handled properly by argparser and no custom messages were 
> reported.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> b69d20818836fb6ae87b333e33008b27e013954f 
>   src/main/python/apache/aurora/client/cli/options.py 
> 37f416d563b526cccf3c9cab69a5df15873db250 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> 703d39e4566a30900f1e9bcca5871c4a426cc6c3 
> 
> Diff: https://reviews.apache.org/r/18153/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.

2014-02-18 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18240/
---

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-135
https://issues.apache.org/jira/browse/AURORA-135


Repository: aurora


Description
---

I've also done some tidying of the storage interfaces here, which make code 
simpler in several places:

- Introduced LockType in ReadWriteLockManager to make parameterized lock/unlock 
possible
- Introduced StorageOperation as a base interface for Work and MutateWork.
- Moved Storage#snapshot() to NonVolatileStorage


Diffs
-

  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 
  src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
a02991453def78bbf6a00c8946d2079fdc4539e9 
  src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
9cc1d1e871bc34fd244565a692215b9657e164a8 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
36e4082acceb3045ef92a5957b500e407bfc1247 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
30d77cc86fba569cfaa35ae69d97726072660aed 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
7f7e34d1cf379168be6fffab0faaf450151a10bc 
  
src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java 
5dc7df18325f9a637ef9009197555e8d53c3b498 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
f708ab3c2fa5d50b084e037f9cc0cb998935120a 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 656e44eb51508c7ab05af8b91e9dcec216d48984 
  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d 

Diff: https://reviews.apache.org/r/18240/diff/


Testing
---

./gradlew build


Thanks,

Bill Farner

Review Request 18239: rename ThermosExecutor to AuroraExecutor, clean up thermos-isms from ExecutorBase

2014-02-18 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18239/
---

Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.


Bugs: AURORA-186
https://issues.apache.org/jira/browse/AURORA-186


Repository: aurora


Description
---

rename ThermosExecutor to AuroraExecutor, clean up thermos-isms from 
ExecutorBase

split all thermos-specific stuff out of thermos_executor.py


Diffs
-

  src/main/python/apache/aurora/executor/BUILD 
667975b8064398b06d24edac1f9e0f6b180b79b1 
  src/main/python/apache/aurora/executor/__init__.py 
d54d88cc91172edbc8f5a35a40f66108fe4b5cfd 
  src/main/python/apache/aurora/executor/bin/BUILD 
2dcc69b35166eefb9fe382798ab61861c6b5f5dd 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
8968e8943fe58c1be472e6e64720d6e9d77d377c 
  src/main/python/apache/aurora/executor/executor_base.py 
a1310cc74209b054a80be48381a5861b1a1a342f 
  src/main/python/apache/aurora/executor/gc_executor.py 
b8b502606ced1ef082f8cb2878e0d2bf23cbd6c1 
  src/main/python/apache/aurora/executor/thermos_executor.py 
252ba5f17050495ee586c92e52f03bde5119a042 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
8e18928eabb8c0a675bbca5b9305b99b89883a41 
  src/test/python/apache/aurora/executor/BUILD 
3f2387fc6aa3d1f946c75189ae3c7e8c05847e50 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
3810ea39a014bc0584b74b5e5f8af87a2fe370df 
  src/test/python/apache/thermos/common/BUILD 
7bbd826de14bad545345fd698baebac602fe5a94 

Diff: https://reviews.apache.org/r/18239/diff/


Testing
---

this adds executor-small and executor-large, the latter of which runs the 
executor tests.  ./pants src/test/python/apache/aurora/executor:executor-large 
-v passes for me locally.  running e2e now.


Thanks,

Brian Wickman

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/
---

(Updated Feb. 18, 2014, 8:46 p.m.)


Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Changes
---

CR comments.


Bugs: AURORA-207
https://issues.apache.org/jira/browse/AURORA-207


Repository: aurora


Description
---

Added "sla get_job_uptime" command.

Also, changed from ValueError to ArgumentTypeError in options.py as the former 
is not handled properly by argparser and no custom messages were reported.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/sla.py 
b69d20818836fb6ae87b333e33008b27e013954f 
  src/main/python/apache/aurora/client/cli/options.py 
37f416d563b526cccf3c9cab69a5df15873db250 
  src/main/python/apache/aurora/client/cli/sla.py 
a3973df870567052083b1d5a524438191eb6d812 
  src/test/python/apache/aurora/client/api/test_sla.py 
54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
  src/test/python/apache/aurora/client/cli/test_sla.py 
703d39e4566a30900f1e9bcca5871c4a426cc6c3 

Diff: https://reviews.apache.org/r/18153/diff/


Testing
---

./build-support/jenkins/build.sh 


Thanks,

Maxim Khutornenko

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34775
---



src/main/python/apache/aurora/client/api/sla.py


This is handled in the return statement by validating the index range. 
Having max() would not hurt though. Added.



src/main/python/apache/aurora/client/api/sla.py


Good idea. Done.



src/main/python/apache/aurora/client/cli/options.py


Done.



src/main/python/apache/aurora/client/cli/options.py


Done.



src/main/python/apache/aurora/client/cli/options.py


Good, as I felt the same way but decided to stay consistent with other 
options here. Dropped empty check to fire an error should this ever happen.


- Maxim Khutornenko


On Feb. 18, 2014, 7:30 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18153/
> ---
> 
> (Updated Feb. 18, 2014, 7:30 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-207
> https://issues.apache.org/jira/browse/AURORA-207
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added "sla get_job_uptime" command.
> 
> Also, changed from ValueError to ArgumentTypeError in options.py as the 
> former is not handled properly by argparser and no custom messages were 
> reported.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> b69d20818836fb6ae87b333e33008b27e013954f 
>   src/main/python/apache/aurora/client/cli/options.py 
> 017f141a605eb6b522fcd7c4fe827eefdc626fca 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> 703d39e4566a30900f1e9bcca5871c4a426cc6c3 
> 
> Diff: https://reviews.apache.org/r/18153/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-18 Thread Mark Chu-Carroll


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17948/
---

(Updated Feb. 18, 2014, 3:31 p.m.)


Review request for Aurora, David Robinson and Brian Wickman.


Changes
---

Rebase.


Bugs: aurora-202
https://issues.apache.org/jira/browse/aurora-202


Repository: aurora


Description
---

Implement help message generation for the noun/verb framework.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
9eb5c52097f0e75567977ba2d4fe10932d227a4b 
  src/main/python/apache/aurora/client/cli/client.py 
604eb444b5f7e8679731b01bc9cef471143e092d 
  src/main/python/apache/aurora/client/cli/context.py 
4d1de48abd571e809221fcf2487761227b212129 
  src/main/python/apache/aurora/client/cli/jobs.py 
199d27f6d320c9d834a140bf5eb64740f41da48f 
  src/main/python/apache/aurora/client/cli/options.py 
37f416d563b526cccf3c9cab69a5df15873db250 
  src/main/python/apache/aurora/client/cli/quota.py 
a7bcfbe0100fe8e400abda3710519e3e5029c477 
  src/main/python/apache/aurora/client/cli/sla.py 
a3973df870567052083b1d5a524438191eb6d812 
  src/main/python/apache/aurora/client/cli/task.py 
d7bf5cd34018f4e3678fa9df6a6a48f640e23e81 
  src/test/python/apache/aurora/client/cli/BUILD 
13a3d09a7e98dcec697346f6496d09efd603f947 
  src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION 

Diff: https://reviews.apache.org/r/17948/diff/


Testing
---

Added unit tests of new functions; verified that all client tests pass.


Thanks,

Mark Chu-Carroll

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34771
---



src/main/python/apache/aurora/client/api/sla.py


this logic breaks when you ask for the 100th percentile.  one option is to 
do max(index, 0).




src/main/python/apache/aurora/client/api/sla.py


'k in range(foo)' is expensive, instead do:

return sorted(self._uptime_map.values())[index] if 0 <= index < total else 0





src/main/python/apache/aurora/client/cli/options.py


do not shadow the 'str' type.  instead do s/str/val/



src/main/python/apache/aurora/client/cli/options.py


percentiles == '' seems like an error case to me.


- Brian Wickman


On Feb. 18, 2014, 7:30 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18153/
> ---
> 
> (Updated Feb. 18, 2014, 7:30 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-207
> https://issues.apache.org/jira/browse/AURORA-207
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added "sla get_job_uptime" command.
> 
> Also, changed from ValueError to ArgumentTypeError in options.py as the 
> former is not handled properly by argparser and no custom messages were 
> reported.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> b69d20818836fb6ae87b333e33008b27e013954f 
>   src/main/python/apache/aurora/client/cli/options.py 
> 017f141a605eb6b522fcd7c4fe827eefdc626fca 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> 703d39e4566a30900f1e9bcca5871c4a426cc6c3 
> 
> Diff: https://reviews.apache.org/r/18153/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18229/#review34772
---

Ship it!


Ship It!

- Kevin Sweeney


On Feb. 18, 2014, 10:52 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18229/
> ---
> 
> (Updated Feb. 18, 2014, 10:52 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-213
> https://issues.apache.org/jira/browse/AURORA-213
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Pin aurora at pants==0.0.14-dev2
> 
> 
> Diffs
> -
> 
>   pants 39803452e0bcc52da361c3074677b91a2b0a9525 
> 
> Diff: https://reviews.apache.org/r/18229/diff/
> 
> 
> Testing
> ---
> 
> git clean -fdx && ./pants py 
> src/main/python/apache/aurora/client/bin:aurora_admin
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Brian Wickman



> On Feb. 18, 2014, 6:57 p.m., Kevin Sweeney wrote:
> > Can you verify this fixes the e2e test?
> 
> Brian Wickman wrote:
> give me an hour and i'll get back to you

***
+ echo 'OK (all tests passed)'
OK (all tests passed)
+ echo '***'
***
+ exit 0


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18229/#review34736
---


On Feb. 18, 2014, 6:52 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18229/
> ---
> 
> (Updated Feb. 18, 2014, 6:52 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-213
> https://issues.apache.org/jira/browse/AURORA-213
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Pin aurora at pants==0.0.14-dev2
> 
> 
> Diffs
> -
> 
>   pants 39803452e0bcc52da361c3074677b91a2b0a9525 
> 
> Diff: https://reviews.apache.org/r/18229/diff/
> 
> 
> Testing
> ---
> 
> git clean -fdx && ./pants py 
> src/main/python/apache/aurora/client/bin:aurora_admin
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Brian Wickman



> On Feb. 18, 2014, 6:57 p.m., Kevin Sweeney wrote:
> > Can you verify this fixes the e2e test?

give me an hour and i'll get back to you


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18229/#review34736
---


On Feb. 18, 2014, 6:52 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18229/
> ---
> 
> (Updated Feb. 18, 2014, 6:52 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-213
> https://issues.apache.org/jira/browse/AURORA-213
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Pin aurora at pants==0.0.14-dev2
> 
> 
> Diffs
> -
> 
>   pants 39803452e0bcc52da361c3074677b91a2b0a9525 
> 
> Diff: https://reviews.apache.org/r/18229/diff/
> 
> 
> Testing
> ---
> 
> git clean -fdx && ./pants py 
> src/main/python/apache/aurora/client/bin:aurora_admin
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/
---

(Updated Feb. 18, 2014, 7:30 p.m.)


Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Changes
---

CR comments.


Bugs: AURORA-207
https://issues.apache.org/jira/browse/AURORA-207


Repository: aurora


Description
---

Added "sla get_job_uptime" command.

Also, changed from ValueError to ArgumentTypeError in options.py as the former 
is not handled properly by argparser and no custom messages were reported.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/sla.py 
b69d20818836fb6ae87b333e33008b27e013954f 
  src/main/python/apache/aurora/client/cli/options.py 
017f141a605eb6b522fcd7c4fe827eefdc626fca 
  src/main/python/apache/aurora/client/cli/sla.py 
a3973df870567052083b1d5a524438191eb6d812 
  src/test/python/apache/aurora/client/api/test_sla.py 
54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
  src/test/python/apache/aurora/client/cli/test_sla.py 
703d39e4566a30900f1e9bcca5871c4a426cc6c3 

Diff: https://reviews.apache.org/r/18153/diff/


Testing
---

./build-support/jenkins/build.sh 


Thanks,

Maxim Khutornenko

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Maxim Khutornenko



> On Feb. 18, 2014, 6:54 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/cli/options.py, line 68
> > 
> >
> > This will throw a ValueError if the user didn't give a numeric value.

Good point. Fixed.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34735
---


On Feb. 15, 2014, 12:01 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18153/
> ---
> 
> (Updated Feb. 15, 2014, 12:01 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-207
> https://issues.apache.org/jira/browse/AURORA-207
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added "sla get_job_uptime" command.
> 
> Also, changed from ValueError to ArgumentTypeError in options.py as the 
> former is not handled properly by argparser and no custom messages were 
> reported.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> b69d20818836fb6ae87b333e33008b27e013954f 
>   src/main/python/apache/aurora/client/cli/options.py 
> 017f141a605eb6b522fcd7c4fe827eefdc626fca 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> 703d39e4566a30900f1e9bcca5871c4a426cc6c3 
> 
> Diff: https://reviews.apache.org/r/18153/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 17752: Add task noun, supporting "run" and "ssh" verbs.

2014-02-18 Thread Mark Chu-Carroll


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17752/
---

(Updated Feb. 18, 2014, 2:30 p.m.)


Review request for Aurora, Bill Farner and Brian Wickman.


Changes
---

merge from master.


Bugs: aurora-124
https://issues.apache.org/jira/browse/aurora-124


Repository: aurora


Description
---

Add task noun, supporting "run" and "ssh" verbs.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/BUILD 
7df9deeca1299db02319219b1c299eb284e2cfc6 
  src/main/python/apache/aurora/client/cli/client.py 
3c07c948a74bb9facb7c58e788624e1a404175d2 
  src/main/python/apache/aurora/client/cli/jobs.py 
632c539083ba50c3115a2bddc92e4bed6bcdc782 
  src/main/python/apache/aurora/client/cli/options.py 
017f141a605eb6b522fcd7c4fe827eefdc626fca 
  src/main/python/apache/aurora/client/cli/task.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
636f407d10e85b1ffc58b72a419d81d854a40ffd 
  src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION 

Diff: https://reviews.apache.org/r/17752/diff/


Testing
---

[sun-wukong incubator-aurora (tasknoun)]$ ./pants 
src/test/python/apache/aurora/client/cli:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 25 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py 
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py .
src/test/python/apache/aurora/client/cli/test_update.py ...

== 25 passed in 1.37 seconds ===
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_task_run.py ..

=== 2 passed in 0.30 seconds ===
src.test.python.apache.aurora.client.cli.job
.   SUCCESS
src.test.python.apache.aurora.client.cli.task   
.   SUCCESS


Thanks,

Mark Chu-Carroll

Re: Review Request 18157: Compute task host attribute aggregates once when scheduling tasks.

2014-02-18 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18157/
---

(Updated Feb. 18, 2014, 7:26 p.m.)


Review request for Aurora, Suman Karumuri and Maxim Khutornenko.


Repository: aurora


Description
---

Addresses TODO from CachedJobState:
  33  * TODO(wfarner): Take this caching one step further and don't store tasks 
here, but instead store
  34  * pre-computed aggregates of host attributes.  For example, translate 
each IScheduledTask into
  35  * the HostAttributes of the machine it resides on, and count the number 
of times each attribute is
  36  * seen.  This could be represented in a Map>, where
  37  * the outer key is the attribute name, and the inner key is attribute 
values.  So, for a job with
  38  * two tasks on the same rack but different hosts, you could have this 
aggregate:
  39  * 
  40  * { "host": {"hostA": 1, "hostB": 1},
  41  *   "rack": {"rack1": 2}
  42  * }
  43  * 

The bulk of this change is with renaming/rewriting CachedJobState (now called 
AttributeAggregate) and consuming from AttributeFilter.  The rest is ripple in 
wiring.

I expect this will make scheduling tasks in large jobs less expensive, since we 
would previously iterate through all tasks multiple times for each offer.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
e7a5a8377f4c8a42012e7ecb118c597a2804da40 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
7893e55f83c3285b37a4e20e88a7bd31728253f3 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
61385c6bbcddc6fd03498190708c9e49892d0859 
  
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 
d2be7ace46ca59612368ef70239877a4a1ee72fb 
  src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 
3e74135b1dcff2c42bd10b558e3699e70fd7c6be 
  src/main/java/org/apache/aurora/scheduler/filter/CachedJobState.java 
337a5e7c045b3338056d17541d6aec0b2d84c9cb 
  src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
c2b9f047b199aa24849c3a9eb1d8176f13fade07 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
ddb34cfc2c476ad6266e2d04a626c391f33d2592 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
93355c3e9a38bb581d9080a492ec786509158d96 
  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
3154ef04e211e0078144e14091e0ceb1470231b1 
  src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
dc371e0b0ef66c254c6db5b274ddf81ccfbd9ff3 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
94647832c01cbf0b2d8d44f7e40fb1b5cc68fd91 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
4112d6133ad26344696237c180f7cc045da4f4f2 
  
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
 4ac059cf0eab2370938dc388dbfd86ffb086a248 
  src/test/java/org/apache/aurora/scheduler/filter/AttributeAggregateTest.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
56de3aae4e08138a66a587e2a43d64a2310079f1 
  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
f0fdd571f273be8dad1f9410b0e70e3a11e8133b 

Diff: https://reviews.apache.org/r/18157/diff/


Testing
---

./gradlew build


Thanks,

Bill Farner

Re: Review Request 18157: Compute task host attribute aggregates once when scheduling tasks.

2014-02-18 Thread Bill Farner



> On Feb. 15, 2014, 1:11 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java, 
> > line 38
> > 
> >
> > Double space.

(insert snarky comment about how double space after periods is superior)

Removed, here and below.


> On Feb. 15, 2014, 1:11 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java, 
> > line 48
> > 
> >
> > Having a comment deciphering key/value here would be helpful.

Good call, done.


> On Feb. 15, 2014, 1:11 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java, 
> > line 51
> > 
> >
> > Typo.

Fixed.


> On Feb. 15, 2014, 1:11 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java, 
> > line 66
> > 
> >
> > Would it make sense to move getHostAttributes() outside of the Supplier 
> > initialization? I find it hard to follow the logic as it is.

Sure, done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18157/#review34561
---


On Feb. 15, 2014, 12:21 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18157/
> ---
> 
> (Updated Feb. 15, 2014, 12:21 a.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Addresses TODO from CachedJobState:
>   33  * TODO(wfarner): Take this caching one step further and don't store 
> tasks here, but instead store
>   34  * pre-computed aggregates of host attributes.  For example, translate 
> each IScheduledTask into
>   35  * the HostAttributes of the machine it resides on, and count the number 
> of times each attribute is
>   36  * seen.  This could be represented in a Map Multiset>, where
>   37  * the outer key is the attribute name, and the inner key is attribute 
> values.  So, for a job with
>   38  * two tasks on the same rack but different hosts, you could have this 
> aggregate:
>   39  * 
>   40  * { "host": {"hostA": 1, "hostB": 1},
>   41  *   "rack": {"rack1": 2}
>   42  * }
>   43  * 
> 
> The bulk of this change is with renaming/rewriting CachedJobState (now called 
> AttributeAggregate) and consuming from AttributeFilter.  The rest is ripple 
> in wiring.
> 
> I expect this will make scheduling tasks in large jobs less expensive, since 
> we would previously iterate through all tasks multiple times for each offer.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> e7a5a8377f4c8a42012e7ecb118c597a2804da40 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 7893e55f83c3285b37a4e20e88a7bd31728253f3 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 61385c6bbcddc6fd03498190708c9e49892d0859 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  d2be7ace46ca59612368ef70239877a4a1ee72fb 
>   src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java 
> 3e74135b1dcff2c42bd10b558e3699e70fd7c6be 
>   src/main/java/org/apache/aurora/scheduler/filter/CachedJobState.java 
> 337a5e7c045b3338056d17541d6aec0b2d84c9cb 
>   src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java 
> c2b9f047b199aa24849c3a9eb1d8176f13fade07 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> ddb34cfc2c476ad6266e2d04a626c391f33d2592 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> 93355c3e9a38bb581d9080a492ec786509158d96 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 3154ef04e211e0078144e14091e0ceb1470231b1 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> dc371e0b0ef66c254c6db5b274ddf81ccfbd9ff3 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 94647832c01cbf0b2d8d44f7e40fb1b5cc68fd91 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 4112d6133ad26344696237c180f7cc045da4f4f2 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4ac059cf0eab2370938dc388dbfd86ffb086a248 
>   
> src/test/java/org/apache/aurora/scheduler/filter/AttributeAggregateTest.java 
> PRE-CREATION

Re: Review Request 18141: Prepare and launch GC executor tasks asynchronously.

2014-02-18 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18141/#review34749
---

Ship it!


Ship It!

- Maxim Khutornenko


On Feb. 18, 2014, 7:16 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18141/
> ---
> 
> (Updated Feb. 18, 2014, 7:16 p.m.)
> 
> 
> Review request for Aurora, Deprecated Use kevints and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-214
> https://issues.apache.org/jira/browse/AURORA-214
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change also alters the signature to and renames TaskLauncher#createTask, 
> since no remaining TaskLaunchers return a task.  The signature change 
> resulted in removing MesosSchedulerImpl#fitsInOffer, which turned out to be 
> redundant in practice (GcExecutorLauncher did this internally).
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
> 70ac62e6ba3566a8789f1c7b2042b8a94f5f3c02 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 92399cc7a38f0ddce8338d127fb7b579606f2571 
>   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
> 96a3adee537aa87402a39dba090c6bbebe6afb1f 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 010776efe1620c13bbcff611f9c1c3272d6c776f 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> e7a5a8377f4c8a42012e7ecb118c597a2804da40 
>   src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java 
> f0d4fbcc411dcb3642c21f51f65c89ad24c3400a 
>   src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 
> 92c77d53f09c39e710bd1bb3277f32d1e144e62f 
>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
> ecf4f90c7d635f912f90fb367dbaa11401048052 
>   
> src/test/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncherTest.java
>  98f5aa141ecca7475274d84f50c750db6f2908b5 
> 
> Diff: https://reviews.apache.org/r/18141/diff/
> 
> 
> Testing
> ---
> 
> $ ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 18141: Prepare and launch GC executor tasks asynchronously.

2014-02-18 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18141/
---

(Updated Feb. 18, 2014, 7:16 p.m.)


Review request for Aurora, Deprecated Use kevints and Maxim Khutornenko.


Bugs: AURORA-214
https://issues.apache.org/jira/browse/AURORA-214


Repository: aurora


Description
---

This change also alters the signature to and renames TaskLauncher#createTask, 
since no remaining TaskLaunchers return a task.  The signature change resulted 
in removing MesosSchedulerImpl#fitsInOffer, which turned out to be redundant in 
practice (GcExecutorLauncher did this internally).


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
70ac62e6ba3566a8789f1c7b2042b8a94f5f3c02 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
92399cc7a38f0ddce8338d127fb7b579606f2571 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
96a3adee537aa87402a39dba090c6bbebe6afb1f 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
010776efe1620c13bbcff611f9c1c3272d6c776f 
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
e7a5a8377f4c8a42012e7ecb118c597a2804da40 
  src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java 
f0d4fbcc411dcb3642c21f51f65c89ad24c3400a 
  src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 
92c77d53f09c39e710bd1bb3277f32d1e144e62f 
  src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
ecf4f90c7d635f912f90fb367dbaa11401048052 
  
src/test/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncherTest.java 
98f5aa141ecca7475274d84f50c750db6f2908b5 

Diff: https://reviews.apache.org/r/18141/diff/


Testing
---

$ ./gradlew build


Thanks,

Bill Farner

Re: Review Request 18141: Prepare and launch GC executor tasks asynchronously.

2014-02-18 Thread Bill Farner



> On Feb. 14, 2014, 8:49 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java, line 168
> > 
> >
> > This comment seems more appropriate for the SchedulerModule where the 
> > list is created.

I agree that it should be moved, but argue that the constructor doc is the most 
appropriate place.  Moved there, let me know if you feel otherwise.


> On Feb. 14, 2014, 8:49 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java, 
> > line 174
> > 
> >
> > Any particular reason you have two makeGcTask overloads? Is it just to 
> > make unit tests easier?

Yes.  This allows me to build expected TaskInfo messages without duplicating 
the ExecutorInfo and TaskInfo building code.


> On Feb. 14, 2014, 8:49 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java, 
> > line 199
> > 
> >
> > With the async execution there is a potential of leaking offers in case 
> > task creation starts failing for any reason. Would it make sense to have a 
> > separate stat counter (e.g. scheduler_gc_offers_used) to help 
> > troubleshooting such cases? Any difference between it and the 
> > scheduler_gc_tasks_created would be a red flag.

Done.


> On Feb. 14, 2014, 8:49 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java, 
> > line 270
> > 
> >
> > s/public//

Done, and i assume you'd like the same for the class.


> On Feb. 14, 2014, 8:49 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java, 
> > line 277
> > 
> >
> > @Override

Thanks, fixed.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18141/#review34542
---


On Feb. 14, 2014, 8:09 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18141/
> ---
> 
> (Updated Feb. 14, 2014, 8:09 p.m.)
> 
> 
> Review request for Aurora, Deprecated Use kevints and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-214
> https://issues.apache.org/jira/browse/AURORA-214
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This change also alters the signature to and renames TaskLauncher#createTask, 
> since no remaining TaskLaunchers return a task.  The signature change 
> resulted in removing MesosSchedulerImpl#fitsInOffer, which turned out to be 
> redundant in practice (GcExecutorLauncher did this internally).
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
> 70ac62e6ba3566a8789f1c7b2042b8a94f5f3c02 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> 92399cc7a38f0ddce8338d127fb7b579606f2571 
>   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
> 96a3adee537aa87402a39dba090c6bbebe6afb1f 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 010776efe1620c13bbcff611f9c1c3272d6c776f 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> e7a5a8377f4c8a42012e7ecb118c597a2804da40 
>   src/main/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncher.java 
> f0d4fbcc411dcb3642c21f51f65c89ad24c3400a 
>   src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 
> 92c77d53f09c39e710bd1bb3277f32d1e144e62f 
>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
> ecf4f90c7d635f912f90fb367dbaa11401048052 
>   
> src/test/java/org/apache/aurora/scheduler/periodic/GcExecutorLauncherTest.java
>  98f5aa141ecca7475274d84f50c750db6f2908b5 
> 
> Diff: https://reviews.apache.org/r/18141/diff/
> 
> 
> Testing
> ---
> 
> $ ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18229/#review34736
---


Can you verify this fixes the e2e test?

- Kevin Sweeney


On Feb. 18, 2014, 10:52 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18229/
> ---
> 
> (Updated Feb. 18, 2014, 10:52 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-213
> https://issues.apache.org/jira/browse/AURORA-213
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Pin aurora at pants==0.0.14-dev2
> 
> 
> Diffs
> -
> 
>   pants 39803452e0bcc52da361c3074677b91a2b0a9525 
> 
> Diff: https://reviews.apache.org/r/18229/diff/
> 
> 
> Testing
> ---
> 
> git clean -fdx && ./pants py 
> src/main/python/apache/aurora/client/bin:aurora_admin
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 18153: Added "sla get_job_uptime" command.

2014-02-18 Thread Mark Chu-Carroll


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18153/#review34735
---



src/main/python/apache/aurora/client/cli/options.py


This will throw a ValueError if the user didn't give a numeric value. 


- Mark Chu-Carroll


On Feb. 14, 2014, 7:01 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18153/
> ---
> 
> (Updated Feb. 14, 2014, 7:01 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-207
> https://issues.apache.org/jira/browse/AURORA-207
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added "sla get_job_uptime" command.
> 
> Also, changed from ValueError to ArgumentTypeError in options.py as the 
> former is not handled properly by argparser and no custom messages were 
> reported.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> b69d20818836fb6ae87b333e33008b27e013954f 
>   src/main/python/apache/aurora/client/cli/options.py 
> 017f141a605eb6b522fcd7c4fe827eefdc626fca 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 54f904c122b9e41d85dc7ad63fe3698cd0bf2923 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> 703d39e4566a30900f1e9bcca5871c4a426cc6c3 
> 
> Diff: https://reviews.apache.org/r/18153/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18229/
---

Review request for Aurora and Kevin Sweeney.


Bugs: AURORA-213
https://issues.apache.org/jira/browse/AURORA-213


Repository: aurora


Description
---

Pin aurora at pants==0.0.14-dev2


Diffs
-

  pants 39803452e0bcc52da361c3074677b91a2b0a9525 

Diff: https://reviews.apache.org/r/18229/diff/


Testing
---

git clean -fdx && ./pants py 
src/main/python/apache/aurora/client/bin:aurora_admin


Thanks,

Brian Wickman

Re: Review Request 18163: Remove appapp references from schema

2014-02-18 Thread Jonathan Boulle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18163/
---

(Updated Feb. 18, 2014, 6:46 p.m.)


Review request for Aurora and Brian Wickman.


Changes
---

missed some deprecation warnings


Repository: aurora


Description
---

Remove appapp references from schema


Diffs (updated)
-

  src/main/python/apache/aurora/client/config.py 
32ac6cc87bae7d82efb2ba6d94c965739ca5b7d1 
  src/main/python/apache/aurora/config/schema/base.py 
0d52b39add9923f7fe114fda6ad90d04be4f03c1 

Diff: https://reviews.apache.org/r/18163/diff/


Testing
---


Thanks,

Jonathan Boulle

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-18 Thread Mark Chu-Carroll


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17948/#review34714
---



src/main/python/apache/aurora/client/cli/sla.py


Yeah, but that'll add a leading CR. I think it's better to just leave it as 
is.


- Mark Chu-Carroll


On Feb. 18, 2014, 10:06 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17948/
> ---
> 
> (Updated Feb. 18, 2014, 10:06 a.m.)
> 
> 
> Review request for Aurora, David Robinson and Brian Wickman.
> 
> 
> Bugs: aurora-202
> https://issues.apache.org/jira/browse/aurora-202
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Implement help message generation for the noun/verb framework.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 9eb5c52097f0e75567977ba2d4fe10932d227a4b 
>   src/main/python/apache/aurora/client/cli/client.py 
> 3c07c948a74bb9facb7c58e788624e1a404175d2 
>   src/main/python/apache/aurora/client/cli/context.py 
> 4d1de48abd571e809221fcf2487761227b212129 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 632c539083ba50c3115a2bddc92e4bed6bcdc782 
>   src/main/python/apache/aurora/client/cli/options.py 
> 017f141a605eb6b522fcd7c4fe827eefdc626fca 
>   src/main/python/apache/aurora/client/cli/quota.py 
> a7bcfbe0100fe8e400abda3710519e3e5029c477 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 636f407d10e85b1ffc58b72a419d81d854a40ffd 
>   src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17948/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests of new functions; verified that all client tests pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-18 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17948/#review34707
---

Ship it!



src/main/python/apache/aurora/client/cli/sla.py


in case you want to keep the indentation flow, the following works:

from textwrap import dedent

help=dedent("""
   foo
   bar
   baz""")



- Brian Wickman


On Feb. 18, 2014, 3:06 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17948/
> ---
> 
> (Updated Feb. 18, 2014, 3:06 p.m.)
> 
> 
> Review request for Aurora, David Robinson and Brian Wickman.
> 
> 
> Bugs: aurora-202
> https://issues.apache.org/jira/browse/aurora-202
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Implement help message generation for the noun/verb framework.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 9eb5c52097f0e75567977ba2d4fe10932d227a4b 
>   src/main/python/apache/aurora/client/cli/client.py 
> 3c07c948a74bb9facb7c58e788624e1a404175d2 
>   src/main/python/apache/aurora/client/cli/context.py 
> 4d1de48abd571e809221fcf2487761227b212129 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 632c539083ba50c3115a2bddc92e4bed6bcdc782 
>   src/main/python/apache/aurora/client/cli/options.py 
> 017f141a605eb6b522fcd7c4fe827eefdc626fca 
>   src/main/python/apache/aurora/client/cli/quota.py 
> a7bcfbe0100fe8e400abda3710519e3e5029c477 
>   src/main/python/apache/aurora/client/cli/sla.py 
> a3973df870567052083b1d5a524438191eb6d812 
>   src/test/python/apache/aurora/client/cli/BUILD 
> 636f407d10e85b1ffc58b72a419d81d854a40ffd 
>   src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17948/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests of new functions; verified that all client tests pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 17752: Add task noun, supporting "run" and "ssh" verbs.

2014-02-18 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17752/#review34706
---

Ship it!


Ship It!

- Brian Wickman


On Feb. 18, 2014, 1:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17752/
> ---
> 
> (Updated Feb. 18, 2014, 1:47 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: aurora-124
> https://issues.apache.org/jira/browse/aurora-124
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add task noun, supporting "run" and "ssh" verbs.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 
>   src/main/python/apache/aurora/client/cli/client.py 
> e416d3879cc5943ec5ab3931a8b1aedb85a379a9 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> caff6d824d9f43cc9eb0c738ea6bb489321d4669 
>   src/main/python/apache/aurora/client/cli/options.py 
> 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 
>   src/main/python/apache/aurora/client/cli/task.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> c106b97a0902da5cd791b18117da3198bfb43b8c 
>   src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17752/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (tasknoun)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
> collected 25 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 25 passed in 1.37 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> === 2 passed in 0.30 seconds 
> ===
> src.test.python.apache.aurora.client.cli.job  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.task 
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-18 Thread Mark Chu-Carroll


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17948/
---

(Updated Feb. 18, 2014, 10:06 a.m.)


Review request for Aurora, David Robinson and Brian Wickman.


Changes
---

addressed wickman's review.


Bugs: aurora-202
https://issues.apache.org/jira/browse/aurora-202


Repository: aurora


Description
---

Implement help message generation for the noun/verb framework.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
9eb5c52097f0e75567977ba2d4fe10932d227a4b 
  src/main/python/apache/aurora/client/cli/client.py 
3c07c948a74bb9facb7c58e788624e1a404175d2 
  src/main/python/apache/aurora/client/cli/context.py 
4d1de48abd571e809221fcf2487761227b212129 
  src/main/python/apache/aurora/client/cli/jobs.py 
632c539083ba50c3115a2bddc92e4bed6bcdc782 
  src/main/python/apache/aurora/client/cli/options.py 
017f141a605eb6b522fcd7c4fe827eefdc626fca 
  src/main/python/apache/aurora/client/cli/quota.py 
a7bcfbe0100fe8e400abda3710519e3e5029c477 
  src/main/python/apache/aurora/client/cli/sla.py 
a3973df870567052083b1d5a524438191eb6d812 
  src/test/python/apache/aurora/client/cli/BUILD 
636f407d10e85b1ffc58b72a419d81d854a40ffd 
  src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION 

Diff: https://reviews.apache.org/r/17948/diff/


Testing
---

Added unit tests of new functions; verified that all client tests pass.


Thanks,

Mark Chu-Carroll

Re: Review Request 17752: Add task noun, supporting "run" and "ssh" verbs.

2014-02-18 Thread Mark Chu-Carroll


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17752/
---

(Updated Feb. 18, 2014, 8:47 a.m.)


Review request for Aurora, Bill Farner and Brian Wickman.


Changes
---

address wickman's review.


Bugs: aurora-124
https://issues.apache.org/jira/browse/aurora-124


Repository: aurora


Description
---

Add task noun, supporting "run" and "ssh" verbs.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/BUILD 
f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 
  src/main/python/apache/aurora/client/cli/client.py 
e416d3879cc5943ec5ab3931a8b1aedb85a379a9 
  src/main/python/apache/aurora/client/cli/jobs.py 
caff6d824d9f43cc9eb0c738ea6bb489321d4669 
  src/main/python/apache/aurora/client/cli/options.py 
5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 
  src/main/python/apache/aurora/client/cli/task.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
c106b97a0902da5cd791b18117da3198bfb43b8c 
  src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION 

Diff: https://reviews.apache.org/r/17752/diff/


Testing
---

[sun-wukong incubator-aurora (tasknoun)]$ ./pants 
src/test/python/apache/aurora/client/cli:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 25 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py 
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py .
src/test/python/apache/aurora/client/cli/test_restart.py ...
src/test/python/apache/aurora/client/cli/test_status.py .
src/test/python/apache/aurora/client/cli/test_update.py ...

== 25 passed in 1.37 seconds ===
= test session starts ==
platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/cli/test_task_run.py ..

=== 2 passed in 0.30 seconds ===
src.test.python.apache.aurora.client.cli.job
.   SUCCESS
src.test.python.apache.aurora.client.cli.task   
.   SUCCESS


Thanks,

Mark Chu-Carroll

Re: Review Request 17752: Add task noun, supporting "run" and "ssh" verbs.

2014-02-18 Thread Mark Chu-Carroll



> On Feb. 14, 2014, 12:56 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/cli/options.py, line 120
> > 
> >
> > Minor nit: I think the original version of this was --user.  Also since 
> > we're mirroring the -L form for creating tunnels, consider adding the '-l' 
> > short form for --ssh_user.

I thought ssh_user was clearer. Since we're changing the command names and 
syntax, I didn't feel obligated to maintain the same option names, if I could 
make them clearer.


> On Feb. 14, 2014, 12:56 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/cli/task.py, lines 91-92
> > 
> >
> > any reason why '-t' short form is removed?  for me '-t50' is almost 
> > muscle memory.

restored.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17752/#review34515
---


On Feb. 11, 2014, 9:16 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17752/
> ---
> 
> (Updated Feb. 11, 2014, 9:16 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: aurora-124
> https://issues.apache.org/jira/browse/aurora-124
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add task noun, supporting "run" and "ssh" verbs.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 
>   src/main/python/apache/aurora/client/cli/client.py 
> e416d3879cc5943ec5ab3931a8b1aedb85a379a9 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> caff6d824d9f43cc9eb0c738ea6bb489321d4669 
>   src/main/python/apache/aurora/client/cli/options.py 
> 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 
>   src/main/python/apache/aurora/client/cli/task.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> c106b97a0902da5cd791b18117da3198bfb43b8c 
>   src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17752/diff/
> 
> 
> Testing
> ---
> 
> [sun-wukong incubator-aurora (tasknoun)]$ ./pants 
> src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
> collected 25 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py 
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> == 25 passed in 1.37 seconds 
> ===
> = test session starts 
> ==
> platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> === 2 passed in 0.30 seconds 
> ===
> src.test.python.apache.aurora.client.cli.job  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.task 
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

44 matches

Mail list logo