Re: Review Request 18546: Renamed Quota to ResourceAggregate.
On Feb. 27, 2014, 2:54 a.m., Maxim Khutornenko wrote: This change needs to be split into at least 3 checkins to ensure proper upgrade story: - thrift changes along with scheduler changes: dual write in storage.thrift and StorageBackfill to ensure smooth deploy rollback - client changes to switch to the new thrift fields - final cleanup of the old quota fields. Let's sync offline to discuss details. Let's sync offline to discuss details. please use the dev@ list or comment on the ticket - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/#review35590 --- On Feb. 27, 2014, 2:44 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/ --- (Updated Feb. 27, 2014, 2:44 a.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-105 https://issues.apache.org/jira/browse/AURORA-105 Repository: aurora Description --- Updated client to use the new struct. The client tests fail on my laptop. So, muted the failing assertion for now and added AURORA-237. Diffs - build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java a2008758f25d33dc000834ff0d77cba2352013ed src/main/java/org/apache/aurora/scheduler/http/Quotas.java 5f7e34ee1b09fc139ae5eb41fc68a716d555721f src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 6ff70af3975eeaf7bd3efd62eac29bc84b411b1d src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java c8985351fb21c010d3ae5fde5d00f25e77076b37 src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 0e286d8d822759169a11d363f09f5322408a103c src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 9868abc2c3d216ccb7d7749df739e0a898df737d src/main/java/org/apache/aurora/scheduler/quota/Quotas.java 9da3c3e9a1bd732633da8afdda89484f5f4475cb src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java e3ab1ddcc13c14e1aeec496748edaf0ecf5f0a8e src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 8855bfb2cd26f610c6ea6d87fb46abf1fd3d9970 src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java e3dffe080e3f46bff8eae23591da7a79b5237564 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java 42c405ac43b6676b737c8e46a4f09bddcbeb9bed src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java cb0ba508605cd2e98da83ef656a516e6c6e2d244 src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java b9bb4bb7a0f2892f29877e070d80cb900365453a src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 043dae68ede0264fad9bbf2b74aa91e9b8b0c9cc src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dccae15a2c529025c9bb6a6f7a0220779ca4f9a1 src/main/python/apache/aurora/client/api/__init__.py 37b7f428677c7f668079373d9a40e3a104c78e3b src/main/python/apache/aurora/client/api/quota_check.py 7de02c43438075629ff9ef93c79d8d7ecfb884c1 src/main/python/apache/aurora/client/api/sla.py 131c357d60fd00740b51055f555d56c599124d15 src/main/python/apache/aurora/client/api/updater.py 924e6d6138b3a192ff42c31588665985f8eb7d13 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/main/thrift/org/apache/aurora/gen/storage.thrift f138c74b2790612d932d330087c6d6d8c24d1570 src/test/java/org/apache/aurora/scheduler/quota/QuotaCheckResultTest.java e366026df7d8d4e1e356889eefaa6fba1aa2e612 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 82e17df016b0f1ad39f8817abe065394edb9f656 src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java c785b1c83ea2b530566050a80214861b3b5b47da src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java a07f3c98a72b3fccb1e1091ffa6bcafedde30247 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 69dadaf08e0c2771a0820406e8ed0c3778a83066 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 4a2d39d8b25c4a6b161c47d6ba7068d74f8a60e0
Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.
On Feb. 27, 2014, 1:38 a.m., Kevin Sweeney wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 364 https://reviews.apache.org/r/18526/diff/1/?file=504721#file504721line364 Mind adding a ticket number (filing one if it doesn't exist)? Added ticket tracking removal. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35589 --- On Feb. 26, 2014, 6:17 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- (Updated Feb. 26, 2014, 6:17 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-232 https://issues.apache.org/jira/browse/AURORA-232 Repository: aurora Description --- The slaveHosts set-based field will eventually replace a string field. All internal queries are converted to use the new field. The old one is still supported for queries coming from the web (until client side is refactored). Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java b9f207c740362fafff0257988f52b6179025d58d src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 7337044bacd052c516e4d78a2993946d472ef91c src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java d1ab503e4edac86afcb8884a074a87b7536de3f7 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 884f589a2cbea918ecbfedf457f42d7cc9254c95 src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/18526/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18546: Renamed Quota to ResourceAggregate.
On Feb. 26, 2014, 6:54 p.m., Maxim Khutornenko wrote: This change needs to be split into at least 3 checkins to ensure proper upgrade story: - thrift changes along with scheduler changes: dual write in storage.thrift and StorageBackfill to ensure smooth deploy rollback - client changes to switch to the new thrift fields - final cleanup of the old quota fields. Let's sync offline to discuss details. Jake Farrell wrote: Let's sync offline to discuss details. please use the dev@ list or comment on the ticket Given that no field numbers have changed there's no loss of wire compatibility here, and therefore this wouldn't require a 3-stage checkin. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/#review35590 --- On Feb. 26, 2014, 6:44 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/ --- (Updated Feb. 26, 2014, 6:44 p.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-105 https://issues.apache.org/jira/browse/AURORA-105 Repository: aurora Description --- Updated client to use the new struct. The client tests fail on my laptop. So, muted the failing assertion for now and added AURORA-237. Diffs - build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java a2008758f25d33dc000834ff0d77cba2352013ed src/main/java/org/apache/aurora/scheduler/http/Quotas.java 5f7e34ee1b09fc139ae5eb41fc68a716d555721f src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 6ff70af3975eeaf7bd3efd62eac29bc84b411b1d src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java c8985351fb21c010d3ae5fde5d00f25e77076b37 src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 0e286d8d822759169a11d363f09f5322408a103c src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 9868abc2c3d216ccb7d7749df739e0a898df737d src/main/java/org/apache/aurora/scheduler/quota/Quotas.java 9da3c3e9a1bd732633da8afdda89484f5f4475cb src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java e3ab1ddcc13c14e1aeec496748edaf0ecf5f0a8e src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 8855bfb2cd26f610c6ea6d87fb46abf1fd3d9970 src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java e3dffe080e3f46bff8eae23591da7a79b5237564 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java 42c405ac43b6676b737c8e46a4f09bddcbeb9bed src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java cb0ba508605cd2e98da83ef656a516e6c6e2d244 src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java b9bb4bb7a0f2892f29877e070d80cb900365453a src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 043dae68ede0264fad9bbf2b74aa91e9b8b0c9cc src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dccae15a2c529025c9bb6a6f7a0220779ca4f9a1 src/main/python/apache/aurora/client/api/__init__.py 37b7f428677c7f668079373d9a40e3a104c78e3b src/main/python/apache/aurora/client/api/quota_check.py 7de02c43438075629ff9ef93c79d8d7ecfb884c1 src/main/python/apache/aurora/client/api/sla.py 131c357d60fd00740b51055f555d56c599124d15 src/main/python/apache/aurora/client/api/updater.py 924e6d6138b3a192ff42c31588665985f8eb7d13 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/main/thrift/org/apache/aurora/gen/storage.thrift f138c74b2790612d932d330087c6d6d8c24d1570 src/test/java/org/apache/aurora/scheduler/quota/QuotaCheckResultTest.java e366026df7d8d4e1e356889eefaa6fba1aa2e612 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 82e17df016b0f1ad39f8817abe065394edb9f656 src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java c785b1c83ea2b530566050a80214861b3b5b47da src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java a07f3c98a72b3fccb1e1091ffa6bcafedde30247 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
Re: Review Request 17347: Added non-prod consumption info to getQuota call.
On Jan. 28, 2014, 3:36 a.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 219 https://reviews.apache.org/r/17347/diff/1/?file=450737#file450737line219 This confirms my fear of the slippery slope of Quota becoming an overloaded term. I'd love to call this something that doesn't already have an implied meaning about production=True. Mind taking a detour to address this TODO? grep -R ResourceAggregate src/main/java/ src/main/java//org/apache/aurora/scheduler/quota/Quotas.java: // TODO(Suman Karumuri): Rename Quota to something more meaningful (ex: ResourceAggregate) It's really important to do this before we cut our first release (in the next few weeks in theory), since we need to adhere to a stable API at that point. Done. https://reviews.apache.org/r/18546/ Will update this review, once the above review is merged. - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17347/#review32946 --- On Jan. 25, 2014, 12:48 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17347/ --- (Updated Jan. 25, 2014, 12:48 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-65 https://issues.apache.org/jira/browse/AURORA-65 Repository: aurora Description --- This call will be used by the role page in the UI. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java cf9099f307efa23ca34634e3512d9cdbebfa82f2 src/main/thrift/org/apache/aurora/gen/api.thrift 74010379baa2e47cefc228943f766c7b3a8b0d97 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 6cefdfad469a9b69a5291ad46be1df14b443472e src/test/resources/org/apache/aurora/gen/api.thrift.md5 42fdca2759f15d007bee058485c237268c57597a Diff: https://reviews.apache.org/r/17347/diff/ Testing --- gradle clean build. Thanks, Suman Karumuri
Re: Review Request 18546: Renamed Quota to ResourceAggregate.
On Feb. 27, 2014, 2:54 a.m., Maxim Khutornenko wrote: This change needs to be split into at least 3 checkins to ensure proper upgrade story: - thrift changes along with scheduler changes: dual write in storage.thrift and StorageBackfill to ensure smooth deploy rollback - client changes to switch to the new thrift fields - final cleanup of the old quota fields. Let's sync offline to discuss details. Jake Farrell wrote: Let's sync offline to discuss details. please use the dev@ list or comment on the ticket Kevin Sweeney wrote: Given that no field numbers have changed there's no loss of wire compatibility here, and therefore this wouldn't require a 3-stage checkin. I have also tested the following scenarios and they work as expected. 1) Start with a DB from scheduler on master, add quotas using the renamed struct, access /quotas from the scheduler on master. 2) Start with a DB from the scheduler with renamed struct, access /quotas from scheduler on master. Thanks for chiming in with the wire format test Kevin. Please let me know if you would like to see any other testing. - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/#review35590 --- On Feb. 27, 2014, 2:44 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/ --- (Updated Feb. 27, 2014, 2:44 a.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-105 https://issues.apache.org/jira/browse/AURORA-105 Repository: aurora Description --- Updated client to use the new struct. The client tests fail on my laptop. So, muted the failing assertion for now and added AURORA-237. Diffs - build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java a2008758f25d33dc000834ff0d77cba2352013ed src/main/java/org/apache/aurora/scheduler/http/Quotas.java 5f7e34ee1b09fc139ae5eb41fc68a716d555721f src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 6ff70af3975eeaf7bd3efd62eac29bc84b411b1d src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java c8985351fb21c010d3ae5fde5d00f25e77076b37 src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 0e286d8d822759169a11d363f09f5322408a103c src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 9868abc2c3d216ccb7d7749df739e0a898df737d src/main/java/org/apache/aurora/scheduler/quota/Quotas.java 9da3c3e9a1bd732633da8afdda89484f5f4475cb src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java e3ab1ddcc13c14e1aeec496748edaf0ecf5f0a8e src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 8855bfb2cd26f610c6ea6d87fb46abf1fd3d9970 src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java e3dffe080e3f46bff8eae23591da7a79b5237564 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java 42c405ac43b6676b737c8e46a4f09bddcbeb9bed src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java cb0ba508605cd2e98da83ef656a516e6c6e2d244 src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java b9bb4bb7a0f2892f29877e070d80cb900365453a src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 043dae68ede0264fad9bbf2b74aa91e9b8b0c9cc src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dccae15a2c529025c9bb6a6f7a0220779ca4f9a1 src/main/python/apache/aurora/client/api/__init__.py 37b7f428677c7f668079373d9a40e3a104c78e3b src/main/python/apache/aurora/client/api/quota_check.py 7de02c43438075629ff9ef93c79d8d7ecfb884c1 src/main/python/apache/aurora/client/api/sla.py 131c357d60fd00740b51055f555d56c599124d15 src/main/python/apache/aurora/client/api/updater.py 924e6d6138b3a192ff42c31588665985f8eb7d13 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/main/thrift/org/apache/aurora/gen/storage.thrift f138c74b2790612d932d330087c6d6d8c24d1570 src/test/java/org/apache/aurora/scheduler/quota/QuotaCheckResultTest.java e366026df7d8d4e1e356889eefaa6fba1aa2e612 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 82e17df016b0f1ad39f8817abe065394edb9f656
Re: Review Request 18580: Upgrade mesos to 0.16.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/#review35685 --- Ship it! Ship It! - Jake Farrell On Feb. 27, 2014, 6:53 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/ --- (Updated Feb. 27, 2014, 6:53 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-240 https://issues.apache.org/jira/browse/AURORA-240 Repository: aurora Description --- Upgrade mesos to 0.16.0 Diffs - 3rdparty/python/BUILD 2c7646ced42a4215267291f566726a46e41575d9 build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 docs/deploying-aurora-scheduler.md 1718f8923ae33e3cac6f88fa54cef582e2f2342c examples/scheduler/scheduler-local.sh e1e394e5259686f30dc14856a455abf6197a26b0 examples/vagrant/provision-aurora-scheduler.sh 894a4d20a9084c7eb6bc3acf70d7c45d0052ca8d examples/vagrant/provision-dev-environment.sh 7fc11bf523a054f6d068cf676e87bb043d854a25 examples/vagrant/provision-mesos-master.sh 6e8a923b829b6665751cf81353d89467fdd28da5 examples/vagrant/provision-mesos-slave.sh ef9180e40ac714d12d412c3e705b2e4dbad42ca2 Diff: https://reviews.apache.org/r/18580/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney
Re: Review Request 18546: Renamed Quota to ResourceAggregate.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/#review35718
---
Mostly minor nits aside from sneaky commenting out of asserts in tests.
build.gradle
https://reviews.apache.org/r/18546/#comment66426
Fix sorting
src/main/java/org/apache/aurora/scheduler/quota/Quotas.java
https://reviews.apache.org/r/18546/#comment66432
Using the type is redundant with the javadoc. The previous doc used
'quota' as a noun.
src/main/java/org/apache/aurora/scheduler/quota/Quotas.java
https://reviews.apache.org/r/18546/#comment66431
How about none()? More concise, just as self-documenting.
src/main/thrift/org/apache/aurora/gen/api.thrift
https://reviews.apache.org/r/18546/#comment66427
Please focus on breaking this habit: this is a red flag for redundancy:
// Resource Aggregate is a struct...
struct ResourceAggregate {
src/test/python/apache/aurora/client/cli/test_diff.py
https://reviews.apache.org/r/18546/#comment66429
This kind of change hidden in a big diff is poor form. Please deal with
this separately.
src/test/python/apache/aurora/client/commands/test_diff.py
https://reviews.apache.org/r/18546/#comment66430
Ditto.
- Bill Farner
On Feb. 27, 2014, 2:44 a.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/
---
(Updated Feb. 27, 2014, 2:44 a.m.)
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim
Khutornenko, and Bill Farner.
Bugs: AURORA-105
https://issues.apache.org/jira/browse/AURORA-105
Repository: aurora
Description
---
Updated client to use the new struct.
The client tests fail on my laptop. So, muted the failing assertion for now
and added AURORA-237.
Diffs
-
build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java
a2008758f25d33dc000834ff0d77cba2352013ed
src/main/java/org/apache/aurora/scheduler/http/Quotas.java
5f7e34ee1b09fc139ae5eb41fc68a716d555721f
src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java
6ff70af3975eeaf7bd3efd62eac29bc84b411b1d
src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java
c8985351fb21c010d3ae5fde5d00f25e77076b37
src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java
0e286d8d822759169a11d363f09f5322408a103c
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
9868abc2c3d216ccb7d7749df739e0a898df737d
src/main/java/org/apache/aurora/scheduler/quota/Quotas.java
9da3c3e9a1bd732633da8afdda89484f5f4475cb
src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java
e3ab1ddcc13c14e1aeec496748edaf0ecf5f0a8e
src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java
8855bfb2cd26f610c6ea6d87fb46abf1fd3d9970
src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java
e3dffe080e3f46bff8eae23591da7a79b5237564
src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java
34d39f2e9064b67ca226c13bb7e330f4daa2a2aa
src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java
42c405ac43b6676b737c8e46a4f09bddcbeb9bed
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java
1842210c91ee3e153f5d142266bc2696960535af
src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java
cb0ba508605cd2e98da83ef656a516e6c6e2d244
src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java
b9bb4bb7a0f2892f29877e070d80cb900365453a
src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
043dae68ede0264fad9bbf2b74aa91e9b8b0c9cc
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
dccae15a2c529025c9bb6a6f7a0220779ca4f9a1
src/main/python/apache/aurora/client/api/__init__.py
37b7f428677c7f668079373d9a40e3a104c78e3b
src/main/python/apache/aurora/client/api/quota_check.py
7de02c43438075629ff9ef93c79d8d7ecfb884c1
src/main/python/apache/aurora/client/api/sla.py
131c357d60fd00740b51055f555d56c599124d15
src/main/python/apache/aurora/client/api/updater.py
924e6d6138b3a192ff42c31588665985f8eb7d13
src/main/thrift/org/apache/aurora/gen/api.thrift
cd60f47bf34b4a634004e2ad9eadad37aa1556bb
src/main/thrift/org/apache/aurora/gen/storage.thrift
f138c74b2790612d932d330087c6d6d8c24d1570
src/test/java/org/apache/aurora/scheduler/quota/QuotaCheckResultTest.java
e366026df7d8d4e1e356889eefaa6fba1aa2e612
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java
82e17df016b0f1ad39f8817abe065394edb9f656
Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/#review35719 --- Ship it! Ship It! - Bill Farner On Feb. 26, 2014, 10:06 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated Feb. 26, 2014, 10:06 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs - build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/#review35721 --- build.gradle https://reviews.apache.org/r/18537/#comment66434 Rather than give up if /usr/bin/python isn't =2.6,3, shouldn't it instead check for python2.7 and python2.6 on PATH (similar to https://github.com/apache/incubator-aurora/blob/master/build-support/virtualenv#L6-L13 ). - Kevin Sweeney On Feb. 26, 2014, 2:06 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated Feb. 26, 2014, 2:06 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs - build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
Re: Review Request 16062: fixed structdump usage message
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16062/ --- (Updated Feb. 27, 2014, 11:17 p.m.) Review request for Aurora and Bill Farner. Changes --- Maxim's feedback. Repository: aurora Description --- fixed structdump usage message Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/StructDump.java b7a33a6e8a3c01a45cdc02b28077523f102f282b Diff: https://reviews.apache.org/r/16062/diff/ Testing --- zilch Thanks, David Robinson
Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.
On Feb. 27, 2014, 11:19 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, line 76 https://reviews.apache.org/r/18526/diff/2/?file=506086#file506086line76 I know why you're doing this here, but mind keeping it out for now? Ignore this comment, i intended to delete it after i saw how the related code changed. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35722 --- On Feb. 27, 2014, 4:42 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- (Updated Feb. 27, 2014, 4:42 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-232 https://issues.apache.org/jira/browse/AURORA-232 Repository: aurora Description --- The slaveHosts set-based field will eventually replace a string field. All internal queries are converted to use the new field. The old one is still supported for queries coming from the web (until client side is refactored). Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java b9f207c740362fafff0257988f52b6179025d58d src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 7337044bacd052c516e4d78a2993946d472ef91c src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java d1ab503e4edac86afcb8884a074a87b7536de3f7 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 884f589a2cbea918ecbfedf457f42d7cc9254c95 src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/18526/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35723 --- src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java https://reviews.apache.org/r/18526/#comment66445 Good point, completely missed the optional meaning there. Question: do we treat an empty value set in a TaskQuery as (1) or (2)? I am leaning towards (1) as a less strict and more intuitive. Any objections? - Maxim Khutornenko On Feb. 27, 2014, 4:42 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- (Updated Feb. 27, 2014, 4:42 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-232 https://issues.apache.org/jira/browse/AURORA-232 Repository: aurora Description --- The slaveHosts set-based field will eventually replace a string field. All internal queries are converted to use the new field. The old one is still supported for queries coming from the web (until client side is refactored). Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java b9f207c740362fafff0257988f52b6179025d58d src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 7337044bacd052c516e4d78a2993946d472ef91c src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java d1ab503e4edac86afcb8884a074a87b7536de3f7 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 884f589a2cbea918ecbfedf457f42d7cc9254c95 src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/18526/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35729 --- src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java https://reviews.apache.org/r/18526/#comment66450 On a second thought, it's easier to reason about all this if we treat set and non-set values the same way, namely non-null empty sets would return empty results. - Maxim Khutornenko On Feb. 27, 2014, 4:42 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- (Updated Feb. 27, 2014, 4:42 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-232 https://issues.apache.org/jira/browse/AURORA-232 Repository: aurora Description --- The slaveHosts set-based field will eventually replace a string field. All internal queries are converted to use the new field. The old one is still supported for queries coming from the web (until client side is refactored). Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java b9f207c740362fafff0257988f52b6179025d58d src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 7337044bacd052c516e4d78a2993946d472ef91c src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java d1ab503e4edac86afcb8884a074a87b7536de3f7 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 884f589a2cbea918ecbfedf457f42d7cc9254c95 src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/18526/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18598: Updated test to use environment variable if it exits.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18598/#review35731 --- Ship it! Ship It! - Kevin Sweeney On Feb. 27, 2014, 4:44 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18598/ --- (Updated Feb. 27, 2014, 4:44 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-101 https://issues.apache.org/jira/browse/AURORA-101 Repository: aurora Description --- Updated test to use environment variable if it exits. Diffs - src/test/python/apache/aurora/client/cli/test_diff.py 9c23a60298024cd0f7626835a90bc821a5ede46e src/test/python/apache/aurora/client/commands/test_diff.py 339459e2f563083ddbf01cadd4e938970d6ea388 Diff: https://reviews.apache.org/r/18598/diff/ Testing --- ./build-support/jenkins/build.sh runs successfully Thanks, Suman Karumuri
Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version
On Feb. 27, 2014, 11:04 p.m., Kevin Sweeney wrote: build.gradle, lines 251-260 https://reviews.apache.org/r/18537/diff/1/?file=504979#file504979line251 Rather than give up if /usr/bin/python isn't =2.6,3, shouldn't it instead check for python2.7 and python2.6 on PATH (similar to https://github.com/apache/incubator-aurora/blob/master/build-support/virtualenv#L6-L13 ). this check appears to only ensure that the python script used in the gradle build (thrift_wrapper_codegen.py) is able to run and that call uses whatever python on the path and does not use the python27 or python26 https://github.com/apache/incubator-aurora/blob/master/build.gradle#L241 thrift_wrapper_codegen.py is only used in the java build right now and probably should be migrated over to a gradle task/plugin so python is not needed, but that should be created and tackled in another ticket if needed - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/#review35721 --- On Feb. 26, 2014, 10:06 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated Feb. 26, 2014, 10:06 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs - build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version
On Feb. 27, 2014, 3:04 p.m., Kevin Sweeney wrote: build.gradle, lines 251-260 https://reviews.apache.org/r/18537/diff/1/?file=504979#file504979line251 Rather than give up if /usr/bin/python isn't =2.6,3, shouldn't it instead check for python2.7 and python2.6 on PATH (similar to https://github.com/apache/incubator-aurora/blob/master/build-support/virtualenv#L6-L13 ). Jake Farrell wrote: this check appears to only ensure that the python script used in the gradle build (thrift_wrapper_codegen.py) is able to run and that call uses whatever python on the path and does not use the python27 or python26 https://github.com/apache/incubator-aurora/blob/master/build.gradle#L241 thrift_wrapper_codegen.py is only used in the java build right now and probably should be migrated over to a gradle task/plugin so python is not needed, but that should be created and tackled in another ticket if needed Yes but the Python side will correctly build even if 'python' is a 2.4 as long as there's a python2.7 or python2.6 on the PATH. I think we should replicate that behavior on the gradle side so that someone running e.g. stock RHEL5 will be able to install python26 from EPEL and have everything work). - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/#review35721 --- On Feb. 26, 2014, 2:06 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated Feb. 26, 2014, 2:06 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs - build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
Re: Review Request 18580: Upgrade mesos to 0.16.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/#review35737 --- Ship it! Ship It! - Bill Farner On Feb. 27, 2014, 6:53 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/ --- (Updated Feb. 27, 2014, 6:53 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-240 https://issues.apache.org/jira/browse/AURORA-240 Repository: aurora Description --- Upgrade mesos to 0.16.0 Diffs - 3rdparty/python/BUILD 2c7646ced42a4215267291f566726a46e41575d9 build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 docs/deploying-aurora-scheduler.md 1718f8923ae33e3cac6f88fa54cef582e2f2342c examples/scheduler/scheduler-local.sh e1e394e5259686f30dc14856a455abf6197a26b0 examples/vagrant/provision-aurora-scheduler.sh 894a4d20a9084c7eb6bc3acf70d7c45d0052ca8d examples/vagrant/provision-dev-environment.sh 7fc11bf523a054f6d068cf676e87bb043d854a25 examples/vagrant/provision-mesos-master.sh 6e8a923b829b6665751cf81353d89467fdd28da5 examples/vagrant/provision-mesos-slave.sh ef9180e40ac714d12d412c3e705b2e4dbad42ca2 Diff: https://reviews.apache.org/r/18580/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney
Review Request 18602: Make http signaler timeout secs configurable via environment variable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602/ --- Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-224 https://issues.apache.org/jira/browse/AURORA-224 Repository: aurora Description --- Make http signaler timeout secs configurable via an environment variable. This is a band-aid for the issue described in AURORA-224. Further improvements would be made possible by refactoring the updater to completely remove client-side health checking (delegating to thermos, which already supports a much richer system of delegated health checks). I'm open to suggestions on how to make this feature more Aurora-y - I know environment variables have typically been discouraged since they can lead to flaky deploys, but I don't think this setting adds unnecessary risk and I see it as a short-term fix for some counter-intuitive behavior on our part. Diffs - src/main/python/apache/aurora/common/http_signaler.py b19b72d6400cef1a2e469b1853a7d49c063d5a25 Diff: https://reviews.apache.org/r/18602/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Kevin Sweeney
Re: Review Request 18546: Renamed Quota to ResourceAggregate.
On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
Mostly minor nits aside from sneaky commenting out of asserts in tests.
Thanks for the comments. Was trying to get the review out. Fixed the flaky test
and merged the fix into this branch.
On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
build.gradle, line 238
https://reviews.apache.org/r/18546/diff/1/?file=505401#file505401line238
Fix sorting
Done.
On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/quota/Quotas.java, line 35
https://reviews.apache.org/r/18546/diff/1/?file=505408#file505408line35
Using the type is redundant with the javadoc. The previous doc used
'quota' as a noun.
Done.
On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/quota/Quotas.java, line 39
https://reviews.apache.org/r/18546/diff/1/?file=505408#file505408line39
How about none()? More concise, just as self-documenting.
Good idea. Changed.
On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 52
https://reviews.apache.org/r/18546/diff/1/?file=505423#file505423line52
Please focus on breaking this habit: this is a red flag for redundancy:
// Resource Aggregate is a struct...
struct ResourceAggregate {
Will try harder. Things like these slip self-review also. Comment is dropped
since the struct name is self explanatory now.
On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:
src/test/python/apache/aurora/client/cli/test_diff.py, line 137
https://reviews.apache.org/r/18546/diff/1/?file=505438#file505438line137
This kind of change hidden in a big diff is poor form. Please deal
with this separately.
Thought this was a broken test. Turned out to be an environment issue. Also,
fixed existing bug AURORA-101, that addresses this.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/#review35718
---
On Feb. 27, 2014, 2:44 a.m., Suman Karumuri wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18546/
---
(Updated Feb. 27, 2014, 2:44 a.m.)
Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim
Khutornenko, and Bill Farner.
Bugs: AURORA-105
https://issues.apache.org/jira/browse/AURORA-105
Repository: aurora
Description
---
Updated client to use the new struct.
The client tests fail on my laptop. So, muted the failing assertion for now
and added AURORA-237.
Diffs
-
build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java
a2008758f25d33dc000834ff0d77cba2352013ed
src/main/java/org/apache/aurora/scheduler/http/Quotas.java
5f7e34ee1b09fc139ae5eb41fc68a716d555721f
src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java
6ff70af3975eeaf7bd3efd62eac29bc84b411b1d
src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java
c8985351fb21c010d3ae5fde5d00f25e77076b37
src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java
0e286d8d822759169a11d363f09f5322408a103c
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
9868abc2c3d216ccb7d7749df739e0a898df737d
src/main/java/org/apache/aurora/scheduler/quota/Quotas.java
9da3c3e9a1bd732633da8afdda89484f5f4475cb
src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java
e3ab1ddcc13c14e1aeec496748edaf0ecf5f0a8e
src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java
8855bfb2cd26f610c6ea6d87fb46abf1fd3d9970
src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java
e3dffe080e3f46bff8eae23591da7a79b5237564
src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java
34d39f2e9064b67ca226c13bb7e330f4daa2a2aa
src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java
42c405ac43b6676b737c8e46a4f09bddcbeb9bed
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java
1842210c91ee3e153f5d142266bc2696960535af
src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java
cb0ba508605cd2e98da83ef656a516e6c6e2d244
src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java
b9bb4bb7a0f2892f29877e070d80cb900365453a
src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
043dae68ede0264fad9bbf2b74aa91e9b8b0c9cc
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
dccae15a2c529025c9bb6a6f7a0220779ca4f9a1
src/main/python/apache/aurora/client/api/__init__.py
Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35738 --- src/main/java/org/apache/aurora/scheduler/base/Query.java https://reviews.apache.org/r/18526/#comment66459 Great suggestion. Done. src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java https://reviews.apache.org/r/18526/#comment66460 Ignored. src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java https://reviews.apache.org/r/18526/#comment66461 I realized there were no users of the TaskQuery.slaveHost anywhere. Dropping this field from thrift. src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java https://reviews.apache.org/r/18526/#comment66462 n/a src/main/thrift/org/apache/aurora/gen/api.thrift https://reviews.apache.org/r/18526/#comment66463 Dropped. - Maxim Khutornenko On Feb. 27, 2014, 4:42 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- (Updated Feb. 27, 2014, 4:42 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-232 https://issues.apache.org/jira/browse/AURORA-232 Repository: aurora Description --- The slaveHosts set-based field will eventually replace a string field. All internal queries are converted to use the new field. The old one is still supported for queries coming from the web (until client side is refactored). Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java b9f207c740362fafff0257988f52b6179025d58d src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 7337044bacd052c516e4d78a2993946d472ef91c src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java d1ab503e4edac86afcb8884a074a87b7536de3f7 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 884f589a2cbea918ecbfedf457f42d7cc9254c95 src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/18526/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- (Updated Feb. 28, 2014, 1:18 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- CR comments. Bugs: AURORA-232 https://issues.apache.org/jira/browse/AURORA-232 Repository: aurora Description --- The slaveHosts set-based field will eventually replace a string field. All internal queries are converted to use the new field. The old one is still supported for queries coming from the web (until client side is refactored). Diffs (updated) - src/main/java/org/apache/aurora/scheduler/base/Query.java b9f207c740362fafff0257988f52b6179025d58d src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 7337044bacd052c516e4d78a2993946d472ef91c src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java d1ab503e4edac86afcb8884a074a87b7536de3f7 src/main/python/apache/aurora/client/api/sla.py 131c357d60fd00740b51055f555d56c599124d15 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 884f589a2cbea918ecbfedf457f42d7cc9254c95 src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/18526/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18546: Renamed Quota to ResourceAggregate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/ --- (Updated Feb. 28, 2014, 1:32 a.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Bill Farner. Changes --- Fixed nits. Rebased with master. Bugs: AURORA-105 https://issues.apache.org/jira/browse/AURORA-105 Repository: aurora Description --- Updated client to use the new struct. The client tests fail on my laptop. So, muted the failing assertion for now and added AURORA-237. Diffs (updated) - build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java a2008758f25d33dc000834ff0d77cba2352013ed src/main/java/org/apache/aurora/scheduler/http/Quotas.java 5f7e34ee1b09fc139ae5eb41fc68a716d555721f src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 6ff70af3975eeaf7bd3efd62eac29bc84b411b1d src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java c8985351fb21c010d3ae5fde5d00f25e77076b37 src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 0e286d8d822759169a11d363f09f5322408a103c src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 9868abc2c3d216ccb7d7749df739e0a898df737d src/main/java/org/apache/aurora/scheduler/quota/Quotas.java 9da3c3e9a1bd732633da8afdda89484f5f4475cb src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java e3ab1ddcc13c14e1aeec496748edaf0ecf5f0a8e src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 8855bfb2cd26f610c6ea6d87fb46abf1fd3d9970 src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java e3dffe080e3f46bff8eae23591da7a79b5237564 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java 42c405ac43b6676b737c8e46a4f09bddcbeb9bed src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java cb0ba508605cd2e98da83ef656a516e6c6e2d244 src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java b9bb4bb7a0f2892f29877e070d80cb900365453a src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 043dae68ede0264fad9bbf2b74aa91e9b8b0c9cc src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dccae15a2c529025c9bb6a6f7a0220779ca4f9a1 src/main/python/apache/aurora/client/api/__init__.py 37b7f428677c7f668079373d9a40e3a104c78e3b src/main/python/apache/aurora/client/api/quota_check.py 7de02c43438075629ff9ef93c79d8d7ecfb884c1 src/main/python/apache/aurora/client/api/sla.py 131c357d60fd00740b51055f555d56c599124d15 src/main/python/apache/aurora/client/api/updater.py 924e6d6138b3a192ff42c31588665985f8eb7d13 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/main/thrift/org/apache/aurora/gen/storage.thrift f138c74b2790612d932d330087c6d6d8c24d1570 src/test/java/org/apache/aurora/scheduler/quota/QuotaCheckResultTest.java e366026df7d8d4e1e356889eefaa6fba1aa2e612 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 82e17df016b0f1ad39f8817abe065394edb9f656 src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java c785b1c83ea2b530566050a80214861b3b5b47da src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java a07f3c98a72b3fccb1e1091ffa6bcafedde30247 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 69dadaf08e0c2771a0820406e8ed0c3778a83066 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 4a2d39d8b25c4a6b161c47d6ba7068d74f8a60e0 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 09a288a8c60b97bc13f72ba54762936eab391899 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 1edc0d7b224cc477ea6e8873e76ee8c70c6b4d50 src/test/python/apache/aurora/client/api/test_quota_check.py 6b1d7bdbce84860c282792a20d15c2229164f465 src/test/python/apache/aurora/client/api/test_scheduler_client.py 49cab1530563862157c85a9d5df38efbeae40777 src/test/python/apache/aurora/client/api/test_sla.py 79ec921cf1cf1180fa4a474aa4767f674fd7767c src/test/python/apache/aurora/client/api/test_updater.py 81406a02e2b71d9db9ba84be26de2728692b102c src/test/python/apache/aurora/client/cli/test_quota.py f7d3585e3f4e412eebadad37ba0f4d698e3e42a0 src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5
Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602/ --- (Updated Feb. 27, 2014, 5:45 p.m.) Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman. Changes --- Maxim's feedback. Bugs: AURORA-224 https://issues.apache.org/jira/browse/AURORA-224 Repository: aurora Description --- Make http signaler timeout secs configurable via an environment variable. This is a band-aid for the issue described in AURORA-224. Further improvements would be made possible by refactoring the updater to completely remove client-side health checking (delegating to thermos, which already supports a much richer system of delegated health checks). I'm open to suggestions on how to make this feature more Aurora-y - I know environment variables have typically been discouraged since they can lead to flaky deploys, but I don't think this setting adds unnecessary risk and I see it as a short-term fix for some counter-intuitive behavior on our part. Diffs (updated) - src/main/python/apache/aurora/common/http_signaler.py b19b72d6400cef1a2e469b1853a7d49c063d5a25 Diff: https://reviews.apache.org/r/18602/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Kevin Sweeney
Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602/#review35748 --- src/main/python/apache/aurora/common/http_signaler.py https://reviews.apache.org/r/18602/#comment66480 Up to you but I'd use inverted IF: if self.timeout_secs: ... else: ... src/main/python/apache/aurora/common/http_signaler.py https://reviews.apache.org/r/18602/#comment66479 Isn't it still the same problem here? Attempt to use %f for a string? - Maxim Khutornenko On Feb. 28, 2014, 1:59 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602/ --- (Updated Feb. 28, 2014, 1:59 a.m.) Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-224 https://issues.apache.org/jira/browse/AURORA-224 Repository: aurora Description --- Make http signaler timeout secs configurable via an environment variable. This is a band-aid for the issue described in AURORA-224. Further improvements would be made possible by refactoring the updater to completely remove client-side health checking (delegating to thermos, which already supports a much richer system of delegated health checks). I'm open to suggestions on how to make this feature more Aurora-y - I know environment variables have typically been discouraged since they can lead to flaky deploys, but I don't think this setting adds unnecessary risk and I see it as a short-term fix for some counter-intuitive behavior on our part. Diffs - src/main/python/apache/aurora/common/http_signaler.py b19b72d6400cef1a2e469b1853a7d49c063d5a25 Diff: https://reviews.apache.org/r/18602/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Kevin Sweeney
Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.
On Feb. 27, 2014, 6:09 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/common/http_signaler.py, line 52 https://reviews.apache.org/r/18602/diff/3/?file=506638#file506638line52 Isn't it still the same problem here? Attempt to use %f for a string? I'll go ahead and change this to %s so there'll be a useful log message right before the stack trace. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602/#review35748 --- On Feb. 27, 2014, 5:59 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602/ --- (Updated Feb. 27, 2014, 5:59 p.m.) Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-224 https://issues.apache.org/jira/browse/AURORA-224 Repository: aurora Description --- Make http signaler timeout secs configurable via an environment variable. This is a band-aid for the issue described in AURORA-224. Further improvements would be made possible by refactoring the updater to completely remove client-side health checking (delegating to thermos, which already supports a much richer system of delegated health checks). I'm open to suggestions on how to make this feature more Aurora-y - I know environment variables have typically been discouraged since they can lead to flaky deploys, but I don't think this setting adds unnecessary risk and I see it as a short-term fix for some counter-intuitive behavior on our part. Diffs - src/main/python/apache/aurora/common/http_signaler.py b19b72d6400cef1a2e469b1853a7d49c063d5a25 Diff: https://reviews.apache.org/r/18602/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Kevin Sweeney
Re: Review Request 18580: Upgrade mesos to 0.17.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/#review35754 --- Since there's a substantial change from the initial subject I'll wait for another shipit. - Kevin Sweeney On Feb. 27, 2014, 6:31 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/ --- (Updated Feb. 27, 2014, 6:31 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-240 https://issues.apache.org/jira/browse/AURORA-240 Repository: aurora Description --- Upgrade mesos to 0.17.0 Moves to using non-deprecated methods and calls the new mesos-log --initialize command before starting up the scheduler. Diffs - 3rdparty/python/BUILD 2c7646ced42a4215267291f566726a46e41575d9 build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 docs/deploying-aurora-scheduler.md 1718f8923ae33e3cac6f88fa54cef582e2f2342c examples/scheduler/scheduler-local.sh e1e394e5259686f30dc14856a455abf6197a26b0 examples/vagrant/provision-aurora-scheduler.sh 894a4d20a9084c7eb6bc3acf70d7c45d0052ca8d examples/vagrant/provision-dev-environment.sh 7fc11bf523a054f6d068cf676e87bb043d854a25 examples/vagrant/provision-mesos-master.sh 6e8a923b829b6665751cf81353d89467fdd28da5 examples/vagrant/provision-mesos-slave.sh ef9180e40ac714d12d412c3e705b2e4dbad42ca2 src/main/java/org/apache/aurora/scheduler/Driver.java 7af8721cc3d9a743605909eba3ada66c0dca592a src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java e5d13e0b2cbcb89cfb24d934e27515fa9a4c885e src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 7a91ab8d9437ba465018fb9dc221d68174178534 Diff: https://reviews.apache.org/r/18580/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney
Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602/ --- (Updated Feb. 27, 2014, 6:37 p.m.) Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman. Changes --- More of Maxim's feedback. Bugs: AURORA-224 https://issues.apache.org/jira/browse/AURORA-224 Repository: aurora Description --- Make http signaler timeout secs configurable via an environment variable. This is a band-aid for the issue described in AURORA-224. Further improvements would be made possible by refactoring the updater to completely remove client-side health checking (delegating to thermos, which already supports a much richer system of delegated health checks). I'm open to suggestions on how to make this feature more Aurora-y - I know environment variables have typically been discouraged since they can lead to flaky deploys, but I don't think this setting adds unnecessary risk and I see it as a short-term fix for some counter-intuitive behavior on our part. Diffs (updated) - src/main/python/apache/aurora/common/http_signaler.py b19b72d6400cef1a2e469b1853a7d49c063d5a25 Diff: https://reviews.apache.org/r/18602/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Kevin Sweeney
Re: Review Request 18546: Renamed Quota to ResourceAggregate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/#review35751 --- Ship it! src/main/java/org/apache/aurora/scheduler/configuration/Resources.java https://reviews.apache.org/r/18546/#comment66484 Mind adding the ticket that tracks collapsing work? AURORA-105? src/main/java/org/apache/aurora/scheduler/quota/Quotas.java https://reviews.apache.org/r/18546/#comment66487 s/quota/ResourceAggregate - Maxim Khutornenko On Feb. 28, 2014, 1:32 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/ --- (Updated Feb. 28, 2014, 1:32 a.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-105 https://issues.apache.org/jira/browse/AURORA-105 Repository: aurora Description --- Updated client to use the new struct. The client tests fail on my laptop. So, muted the failing assertion for now and added AURORA-237. Diffs - build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java a2008758f25d33dc000834ff0d77cba2352013ed src/main/java/org/apache/aurora/scheduler/http/Quotas.java 5f7e34ee1b09fc139ae5eb41fc68a716d555721f src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 6ff70af3975eeaf7bd3efd62eac29bc84b411b1d src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java c8985351fb21c010d3ae5fde5d00f25e77076b37 src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 0e286d8d822759169a11d363f09f5322408a103c src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 9868abc2c3d216ccb7d7749df739e0a898df737d src/main/java/org/apache/aurora/scheduler/quota/Quotas.java 9da3c3e9a1bd732633da8afdda89484f5f4475cb src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java e3ab1ddcc13c14e1aeec496748edaf0ecf5f0a8e src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 8855bfb2cd26f610c6ea6d87fb46abf1fd3d9970 src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java e3dffe080e3f46bff8eae23591da7a79b5237564 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java 42c405ac43b6676b737c8e46a4f09bddcbeb9bed src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java cb0ba508605cd2e98da83ef656a516e6c6e2d244 src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java b9bb4bb7a0f2892f29877e070d80cb900365453a src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 043dae68ede0264fad9bbf2b74aa91e9b8b0c9cc src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dccae15a2c529025c9bb6a6f7a0220779ca4f9a1 src/main/python/apache/aurora/client/api/__init__.py 37b7f428677c7f668079373d9a40e3a104c78e3b src/main/python/apache/aurora/client/api/quota_check.py 7de02c43438075629ff9ef93c79d8d7ecfb884c1 src/main/python/apache/aurora/client/api/sla.py 131c357d60fd00740b51055f555d56c599124d15 src/main/python/apache/aurora/client/api/updater.py 924e6d6138b3a192ff42c31588665985f8eb7d13 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/main/thrift/org/apache/aurora/gen/storage.thrift f138c74b2790612d932d330087c6d6d8c24d1570 src/test/java/org/apache/aurora/scheduler/quota/QuotaCheckResultTest.java e366026df7d8d4e1e356889eefaa6fba1aa2e612 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 82e17df016b0f1ad39f8817abe065394edb9f656 src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java c785b1c83ea2b530566050a80214861b3b5b47da src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java a07f3c98a72b3fccb1e1091ffa6bcafedde30247 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 69dadaf08e0c2771a0820406e8ed0c3778a83066 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 4a2d39d8b25c4a6b161c47d6ba7068d74f8a60e0 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 09a288a8c60b97bc13f72ba54762936eab391899
Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602/#review35755 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 28, 2014, 2:37 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602/ --- (Updated Feb. 28, 2014, 2:37 a.m.) Review request for Aurora, Mark Chu-Carroll, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-224 https://issues.apache.org/jira/browse/AURORA-224 Repository: aurora Description --- Make http signaler timeout secs configurable via an environment variable. This is a band-aid for the issue described in AURORA-224. Further improvements would be made possible by refactoring the updater to completely remove client-side health checking (delegating to thermos, which already supports a much richer system of delegated health checks). I'm open to suggestions on how to make this feature more Aurora-y - I know environment variables have typically been discouraged since they can lead to flaky deploys, but I don't think this setting adds unnecessary risk and I see it as a short-term fix for some counter-intuitive behavior on our part. Diffs - src/main/python/apache/aurora/common/http_signaler.py b19b72d6400cef1a2e469b1853a7d49c063d5a25 Diff: https://reviews.apache.org/r/18602/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Kevin Sweeney
Re: Review Request 18546: Renamed Quota to ResourceAggregate.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/#review35756 --- Ship it! src/main/java/org/apache/aurora/scheduler/quota/Quotas.java https://reviews.apache.org/r/18546/#comment66488 s/quota/resource aggregate/ - Bill Farner On Feb. 28, 2014, 1:32 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/ --- (Updated Feb. 28, 2014, 1:32 a.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-105 https://issues.apache.org/jira/browse/AURORA-105 Repository: aurora Description --- Updated client to use the new struct. The client tests fail on my laptop. So, muted the failing assertion for now and added AURORA-237. Diffs - build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java a2008758f25d33dc000834ff0d77cba2352013ed src/main/java/org/apache/aurora/scheduler/http/Quotas.java 5f7e34ee1b09fc139ae5eb41fc68a716d555721f src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 6ff70af3975eeaf7bd3efd62eac29bc84b411b1d src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java c8985351fb21c010d3ae5fde5d00f25e77076b37 src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 0e286d8d822759169a11d363f09f5322408a103c src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 9868abc2c3d216ccb7d7749df739e0a898df737d src/main/java/org/apache/aurora/scheduler/quota/Quotas.java 9da3c3e9a1bd732633da8afdda89484f5f4475cb src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java e3ab1ddcc13c14e1aeec496748edaf0ecf5f0a8e src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 8855bfb2cd26f610c6ea6d87fb46abf1fd3d9970 src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java e3dffe080e3f46bff8eae23591da7a79b5237564 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java 42c405ac43b6676b737c8e46a4f09bddcbeb9bed src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java cb0ba508605cd2e98da83ef656a516e6c6e2d244 src/main/java/org/apache/aurora/scheduler/storage/mem/MemQuotaStore.java b9bb4bb7a0f2892f29877e070d80cb900365453a src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 043dae68ede0264fad9bbf2b74aa91e9b8b0c9cc src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java dccae15a2c529025c9bb6a6f7a0220779ca4f9a1 src/main/python/apache/aurora/client/api/__init__.py 37b7f428677c7f668079373d9a40e3a104c78e3b src/main/python/apache/aurora/client/api/quota_check.py 7de02c43438075629ff9ef93c79d8d7ecfb884c1 src/main/python/apache/aurora/client/api/sla.py 131c357d60fd00740b51055f555d56c599124d15 src/main/python/apache/aurora/client/api/updater.py 924e6d6138b3a192ff42c31588665985f8eb7d13 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/main/thrift/org/apache/aurora/gen/storage.thrift f138c74b2790612d932d330087c6d6d8c24d1570 src/test/java/org/apache/aurora/scheduler/quota/QuotaCheckResultTest.java e366026df7d8d4e1e356889eefaa6fba1aa2e612 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 82e17df016b0f1ad39f8817abe065394edb9f656 src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java c785b1c83ea2b530566050a80214861b3b5b47da src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java a07f3c98a72b3fccb1e1091ffa6bcafedde30247 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94 src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java 69dadaf08e0c2771a0820406e8ed0c3778a83066 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 4a2d39d8b25c4a6b161c47d6ba7068d74f8a60e0 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 09a288a8c60b97bc13f72ba54762936eab391899 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 1edc0d7b224cc477ea6e8873e76ee8c70c6b4d50 src/test/python/apache/aurora/client/api/test_quota_check.py 6b1d7bdbce84860c282792a20d15c2229164f465
Re: Review Request 18580: Upgrade mesos to 0.17.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/#review35758 --- Ship it! examples/vagrant/provision-aurora-scheduler.sh https://reviews.apache.org/r/18580/#comment66490 Mind elaborating a bit on why this is necessary? src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java https://reviews.apache.org/r/18580/#comment66492 I forget — can this go directly on the deprecated method to limit scope? - Bill Farner On Feb. 28, 2014, 2:31 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/ --- (Updated Feb. 28, 2014, 2:31 a.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-240 https://issues.apache.org/jira/browse/AURORA-240 Repository: aurora Description --- Upgrade mesos to 0.17.0 Moves to using non-deprecated methods and calls the new mesos-log --initialize command before starting up the scheduler. Diffs - 3rdparty/python/BUILD 2c7646ced42a4215267291f566726a46e41575d9 build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 docs/deploying-aurora-scheduler.md 1718f8923ae33e3cac6f88fa54cef582e2f2342c examples/scheduler/scheduler-local.sh e1e394e5259686f30dc14856a455abf6197a26b0 examples/vagrant/provision-aurora-scheduler.sh 894a4d20a9084c7eb6bc3acf70d7c45d0052ca8d examples/vagrant/provision-dev-environment.sh 7fc11bf523a054f6d068cf676e87bb043d854a25 examples/vagrant/provision-mesos-master.sh 6e8a923b829b6665751cf81353d89467fdd28da5 examples/vagrant/provision-mesos-slave.sh ef9180e40ac714d12d412c3e705b2e4dbad42ca2 src/main/java/org/apache/aurora/scheduler/Driver.java 7af8721cc3d9a743605909eba3ada66c0dca592a src/main/java/org/apache/aurora/scheduler/local/FakeDriverFactory.java e5d13e0b2cbcb89cfb24d934e27515fa9a4c885e src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 7a91ab8d9437ba465018fb9dc221d68174178534 Diff: https://reviews.apache.org/r/18580/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney
