Re: Review Request 23949: Make testing of v1 command hooks easier.
Ping, again? David, Joe? This is a really easy one! -Mark On Mon, Jul 28, 2014 at 2:07 PM, Mark Chu-Carroll mchucarr...@apache.org wrote: ping? On Fri, Jul 25, 2014 at 4:50 PM, Mark Chu-Carroll mchucarr...@twopensource.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23949/ Review request for Aurora, David McLaughlin and Joe Smith. By Mark Chu-Carroll. *Updated July 25, 2014, 4:50 p.m.* *Bugs: * aurora-603 https://issues.apache.org/jira/browse/aurora-603 *Repository: * aurora Description Make testing of v1 command hooks easier. In order to be able to test v1 command hooks on real commands, it would be helpful to be able to mock out the body of the commands. In order to do this, I've separated the commands into an invocation frame, and the actual command implementation. Testing ? incubator-aurora git:(extract_killall) ? git commit -a --amend [extract_killall 570bd1e] Make testing of v1 command hooks easier. 2 files changed, 105 insertions(+), 73 deletions(-) ? incubator-aurora git:(extract_killall) ./pants src/test/python/apache/aurora/client:all Build operating on top level addresses: set([BuildFileAddress(src/test/python/apache/aurora/client/BUILD, all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.58 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 3 items src/test/python/apache/aurora/client/cli/test_config_noun.py ... === 3 passed in 0.88 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 28 items src/test/python/apache/aurora/client/api/test_updater.py == 28 passed in 0.94 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.76 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 3 items src/test/python/apache/aurora/client/cli/test_task_run.py ... === 3 passed in 0.72 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 10 items src/test/python/apache/aurora/client/test_config.py .. == 10 passed in 0.51 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/cli/test_cron.py ... === 7 passed in 1.21 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 44 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py .. src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py . src/test/python/apache/aurora/client/cli/test_status.py ... src/test/python/apache/aurora/client/cli/test_update.py ... == 44 passed in 7.74 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 2 items
Re: Review Request 24042: Add test coverage for Mname.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24042/#review48991 --- Ship it! Ship It! - Maxim Khutornenko On July 29, 2014, 5:27 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24042/ --- (Updated July 29, 2014, 5:27 a.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- This brings Mname to 100% instruction and branch coverage. Diffs - src/main/java/org/apache/aurora/scheduler/http/Mname.java dc8967faf9601209d5c0ca627eded02fab908622 src/test/java/org/apache/aurora/scheduler/http/MnameTest.java 6971454efc26da5cca595ed865486630a4720f7d Diff: https://reviews.apache.org/r/24042/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 23471: add support for Mesos masters running with --no-root_submissions, see AURORA-311
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/#review48993 --- wickman, ping? - Bill Farner On July 22, 2014, 11:28 p.m., Bjoern Metzdorf wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/ --- (Updated July 22, 2014, 11:28 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: AURORA-311 https://issues.apache.org/jira/browse/AURORA-311 Repository: aurora Description --- Review board entry for https://issues.apache.org/jira/browse/AURORA-311 Diffs - src/main/java/org/apache/aurora/scheduler/DriverFactory.java db864a0 Diff: https://reviews.apache.org/r/23471/diff/ Testing --- Tested successfully on internal cluster with version 0.5.1. Aurora was able to connect to a mesos master that was running with --no-root_submissions and was able to schedule tasks with a role of EXECUTOR_USER that then were running as the specified executor user. Thanks, Bjoern Metzdorf
Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23348/#review48994 --- Ship it! Ship It! - Bill Farner On July 9, 2014, 7:50 p.m., Dominic Hamon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23348/ --- (Updated July 9, 2014, 7:50 p.m.) Review request for Aurora, Joe Smith, Kevin Sweeney, and Bill Farner. Bugs: AURORA-579 https://issues.apache.org/jira/browse/AURORA-579 Repository: aurora Description --- Upgrading Mesos version from 0.18.0 to 0.19.0 Diffs - 3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 examples/scheduler/scheduler-local.sh 9f77af7365c5f1953166cb50ce3903f0558cb79f examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8 Diff: https://reviews.apache.org/r/23348/diff/ Testing --- ./gradlew build Thanks, Dominic Hamon
Review Request 24059: Replace HttpModule from twitter.common with our own code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-606 https://issues.apache.org/jira/browse/AURORA-606 Repository: aurora Description --- This is somewhat a copy-paste of the original HttpModule [1], as the first step in a general improvement in how we interact with jetty. I've left a TODO for the next step (simplify addition of static assets). The only expected functional changes are the removal of /healthz (long-since deprecated in favor of /health) and /pprof/* which i have not found to produce useful output in practice (at least, not as useful as other standard JVM tools). I've also removed our dependencies on twitter's jar-packaged jquery and bootstrap, which we no longer appear to use anywhere. [1] https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/application/modules/HttpModule.java Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb config/checkstyle/checkstyle.xml 20709896213b56c0dbdeaf790c826839383df20b config/findbugs/excludeFilter.xml d6c1b1681c2d8505a088f9fb082ce11ac400126f src/main/java/org/apache/aurora/scheduler/app/AppModule.java 30b1ba623daa69a1e184cb91a92e58720648caa2 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java f429eda3bc2c9ae80a67dca8da8574eb7f92976b src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 729e0ab035b29dc570a2128266112db5312138ed src/test/java/org/apache/aurora/scheduler/http/ServletModuleTest.java 90a001b38ce35fe4da666febde328c1af30f9663 Diff: https://reviews.apache.org/r/24059/diff/ Testing --- ./gradlew clean build -Pq bash examples/vagrant/test_tutorial.sh Manually clicked around in a local scheduler. Thanks, Bill Farner
Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/#review49002 --- Ship it! src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java https://reviews.apache.org/r/24059/#comment85833 Since this isn't in a library anymore you should be fine replacing this with Runtime.getRuntime().halt(0); (better matches the documented semantics of /abortabortabort). src/main/java/org/apache/aurora/scheduler/http/ServletModule.java https://reviews.apache.org/r/24059/#comment85832 TODO to reevaluate the use of Named here. src/main/java/org/apache/aurora/scheduler/http/ServletModule.java https://reviews.apache.org/r/24059/#comment85831 Drop this comment too? src/main/java/org/apache/aurora/scheduler/http/ServletModule.java https://reviews.apache.org/r/24059/#comment85830 TODO to switch this to guava Service? - Kevin Sweeney On July 29, 2014, 11:05 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- (Updated July 29, 2014, 11:05 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-606 https://issues.apache.org/jira/browse/AURORA-606 Repository: aurora Description --- This is somewhat a copy-paste of the original HttpModule [1], as the first step in a general improvement in how we interact with jetty. I've left a TODO for the next step (simplify addition of static assets). The only expected functional changes are the removal of /healthz (long-since deprecated in favor of /health) and /pprof/* which i have not found to produce useful output in practice (at least, not as useful as other standard JVM tools). I've also removed our dependencies on twitter's jar-packaged jquery and bootstrap, which we no longer appear to use anywhere. [1] https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/application/modules/HttpModule.java Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb config/checkstyle/checkstyle.xml 20709896213b56c0dbdeaf790c826839383df20b config/findbugs/excludeFilter.xml d6c1b1681c2d8505a088f9fb082ce11ac400126f src/main/java/org/apache/aurora/scheduler/app/AppModule.java 30b1ba623daa69a1e184cb91a92e58720648caa2 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java f429eda3bc2c9ae80a67dca8da8574eb7f92976b src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 729e0ab035b29dc570a2128266112db5312138ed src/test/java/org/apache/aurora/scheduler/http/ServletModuleTest.java 90a001b38ce35fe4da666febde328c1af30f9663 Diff: https://reviews.apache.org/r/24059/diff/ Testing --- ./gradlew clean build -Pq bash examples/vagrant/test_tutorial.sh Manually clicked around in a local scheduler. Thanks, Bill Farner
Re: Review Request 23949: Make testing of v1 command hooks easier.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23949/#review49009 --- Ship it! Ship It! - David Robinson On July 25, 2014, 8:50 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23949/ --- (Updated July 25, 2014, 8:50 p.m.) Review request for Aurora, David McLaughlin and Joe Smith. Bugs: aurora-603 https://issues.apache.org/jira/browse/aurora-603 Repository: aurora Description --- Make testing of v1 command hooks easier. In order to be able to test v1 command hooks on real commands, it would be helpful to be able to mock out the body of the commands. In order to do this, I've separated the commands into an invocation frame, and the actual command implementation. Diffs - src/main/python/apache/aurora/client/commands/core.py b4169995e996b17dda3dc09f2e5961d77e045d87 Diff: https://reviews.apache.org/r/23949/diff/ Testing --- ? incubator-aurora git:(extract_killall) ? git commit -a --amend [extract_killall 570bd1e] Make testing of v1 command hooks easier. 2 files changed, 105 insertions(+), 73 deletions(-) ? incubator-aurora git:(extract_killall) ./pants src/test/python/apache/aurora/client:all Build operating on top level addresses: set([BuildFileAddress(src/test/python/apache/aurora/client/BUILD, all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.58 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 3 items src/test/python/apache/aurora/client/cli/test_config_noun.py ... === 3 passed in 0.88 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 28 items src/test/python/apache/aurora/client/api/test_updater.py == 28 passed in 0.94 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.76 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 3 items src/test/python/apache/aurora/client/cli/test_task_run.py ... === 3 passed in 0.72 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 10 items src/test/python/apache/aurora/client/test_config.py .. == 10 passed in 0.51 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/cli/test_cron.py ... === 7 passed in 1.21 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 44 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py .. src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py .
Re: Review Request 22944: Use tasksWithoutConfig on job page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22944/#review49010 --- This already has two ship its. Mark, do you mind removing yourself and adding Bill? - David McLaughlin On June 24, 2014, 9:30 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22944/ --- (Updated June 24, 2014, 9:30 p.m.) Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. Bugs: AURORA-551 https://issues.apache.org/jira/browse/AURORA-551 Repository: aurora Description --- Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 129235f33494f9a97117409374268cf441b976ca src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7 Diff: https://reviews.apache.org/r/22944/diff/ Testing --- ./gradlew build File Attachments Mocked data for groups. https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png Thanks, David McLaughlin
Re: Review Request 23949: Make testing of v1 command hooks easier.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23949/ --- (Updated July 29, 2014, 2:53 p.m.) Review request for Aurora, David McLaughlin and David Robinson. Changes --- Modify people list, since Joe is away. Bugs: aurora-603 https://issues.apache.org/jira/browse/aurora-603 Repository: aurora Description --- Make testing of v1 command hooks easier. In order to be able to test v1 command hooks on real commands, it would be helpful to be able to mock out the body of the commands. In order to do this, I've separated the commands into an invocation frame, and the actual command implementation. Diffs - src/main/python/apache/aurora/client/commands/core.py b4169995e996b17dda3dc09f2e5961d77e045d87 Diff: https://reviews.apache.org/r/23949/diff/ Testing --- ? incubator-aurora git:(extract_killall) ? git commit -a --amend [extract_killall 570bd1e] Make testing of v1 command hooks easier. 2 files changed, 105 insertions(+), 73 deletions(-) ? incubator-aurora git:(extract_killall) ./pants src/test/python/apache/aurora/client:all Build operating on top level addresses: set([BuildFileAddress(src/test/python/apache/aurora/client/BUILD, all)]) = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 4 items src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py === 4 passed in 0.58 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 3 items src/test/python/apache/aurora/client/cli/test_config_noun.py ... === 3 passed in 0.88 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 28 items src/test/python/apache/aurora/client/api/test_updater.py == 28 passed in 0.94 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 5 items src/test/python/apache/aurora/client/cli/test_sla.py . === 5 passed in 0.76 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 4 items src/test/python/apache/aurora/client/cli/test_bridge.py === 4 passed in 0.02 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 3 items src/test/python/apache/aurora/client/cli/test_task_run.py ... === 3 passed in 0.72 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 10 items src/test/python/apache/aurora/client/test_config.py .. == 10 passed in 0.51 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 7 items src/test/python/apache/aurora/client/cli/test_cron.py ... === 7 passed in 1.21 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 44 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py .. src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py . src/test/python/apache/aurora/client/cli/test_status.py ... src/test/python/apache/aurora/client/cli/test_update.py ... == 44 passed in 7.74 seconds === = test session starts == platform darwin -- Python 2.6.8 -- py-1.4.22 -- pytest-2.6.0 plugins: cov, timeout collected 2 items
Re: Review Request 22944: Use tasksWithoutConfig on job page
On July 29, 2014, 6:52 p.m., David McLaughlin wrote: This already has two ship its. Mark, do you mind removing yourself and adding Bill? FYI - i don't believe Mark will have RB permissions to edit the review. You can feel free to do the swap and proceed with the commit. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22944/#review49010 --- On June 24, 2014, 9:30 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22944/ --- (Updated June 24, 2014, 9:30 p.m.) Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. Bugs: AURORA-551 https://issues.apache.org/jira/browse/AURORA-551 Repository: aurora Description --- Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 129235f33494f9a97117409374268cf441b976ca src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7 Diff: https://reviews.apache.org/r/22944/diff/ Testing --- ./gradlew build File Attachments Mocked data for groups. https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png Thanks, David McLaughlin
Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.
On July 29, 2014, 6:18 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java, line 27 https://reviews.apache.org/r/24059/diff/1/?file=644660#file644660line27 Since this isn't in a library anymore you should be fine replacing this with Runtime.getRuntime().halt(0); (better matches the documented semantics of /abortabortabort). Done. On July 29, 2014, 6:18 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 106 https://reviews.apache.org/r/24059/diff/1/?file=644661#file644661line106 TODO to reevaluate the use of Named here. AbortHandler and QuitHandler inject with @Named, so we're stuck if we want to use them. We could replace them with minimal effort, but that won't buy us anything in terms of dependencies, unfortunately. On July 29, 2014, 6:18 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 148 https://reviews.apache.org/r/24059/diff/1/?file=644661#file644661line148 Drop this comment too? Done. On July 29, 2014, 6:18 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 333 https://reviews.apache.org/r/24059/diff/1/?file=644661#file644661line333 TODO to switch this to guava Service? Done. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/#review49002 --- On July 29, 2014, 6:05 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- (Updated July 29, 2014, 6:05 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-606 https://issues.apache.org/jira/browse/AURORA-606 Repository: aurora Description --- This is somewhat a copy-paste of the original HttpModule [1], as the first step in a general improvement in how we interact with jetty. I've left a TODO for the next step (simplify addition of static assets). The only expected functional changes are the removal of /healthz (long-since deprecated in favor of /health) and /pprof/* which i have not found to produce useful output in practice (at least, not as useful as other standard JVM tools). I've also removed our dependencies on twitter's jar-packaged jquery and bootstrap, which we no longer appear to use anywhere. [1] https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/application/modules/HttpModule.java Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb config/checkstyle/checkstyle.xml 20709896213b56c0dbdeaf790c826839383df20b config/findbugs/excludeFilter.xml d6c1b1681c2d8505a088f9fb082ce11ac400126f src/main/java/org/apache/aurora/scheduler/app/AppModule.java 30b1ba623daa69a1e184cb91a92e58720648caa2 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java f429eda3bc2c9ae80a67dca8da8574eb7f92976b src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 729e0ab035b29dc570a2128266112db5312138ed src/test/java/org/apache/aurora/scheduler/http/ServletModuleTest.java 90a001b38ce35fe4da666febde328c1af30f9663 Diff: https://reviews.apache.org/r/24059/diff/ Testing --- ./gradlew clean build -Pq bash examples/vagrant/test_tutorial.sh Manually clicked around in a local scheduler. Thanks, Bill Farner
Review Request 24063: Use JCenter over HTTPS instead of Maven Central
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/ --- Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA-620 https://issues.apache.org/jira/browse/AURORA-620 Repository: aurora Description --- Use JCenter over HTTPS instead of Maven Central Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb Diff: https://reviews.apache.org/r/24063/diff/ Testing --- rm -fr ~/.gradle/caches ./gradlew build Thanks, Kevin Sweeney
Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/#review49014 --- build.gradle https://reviews.apache.org/r/24063/#comment85852 This is per https://twitter.com/bintray/status/494185158493224961 - Kevin Sweeney On July 29, 2014, 12:14 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/ --- (Updated July 29, 2014, 12:14 p.m.) Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA-620 https://issues.apache.org/jira/browse/AURORA-620 Repository: aurora Description --- Use JCenter over HTTPS instead of Maven Central Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb Diff: https://reviews.apache.org/r/24063/diff/ Testing --- rm -fr ~/.gradle/caches ./gradlew build Thanks, Kevin Sweeney
Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/#review49015 --- Ship it! Ship It! - Bill Farner On July 29, 2014, 7:14 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/ --- (Updated July 29, 2014, 7:14 p.m.) Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA-620 https://issues.apache.org/jira/browse/AURORA-620 Repository: aurora Description --- Use JCenter over HTTPS instead of Maven Central Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb Diff: https://reviews.apache.org/r/24063/diff/ Testing --- rm -fr ~/.gradle/caches ./gradlew build Thanks, Kevin Sweeney
Re: Review Request 22944: Use tasksWithoutConfig on job page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22944/ --- (Updated July 29, 2014, 7:19 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Swapped out Mark for Bill. I still don't have commit access, so can either Bill or Kevin commit this? I'll rebase first. Bugs: AURORA-551 https://issues.apache.org/jira/browse/AURORA-551 Repository: aurora Description --- Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances. Diffs - src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 129235f33494f9a97117409374268cf441b976ca src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7 Diff: https://reviews.apache.org/r/22944/diff/ Testing --- ./gradlew build File Attachments Mocked data for groups. https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png Thanks, David McLaughlin
Re: Review Request 22944: Use tasksWithoutConfig on job page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22944/ --- (Updated July 29, 2014, 7:20 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Rebase. Bugs: AURORA-551 https://issues.apache.org/jira/browse/AURORA-551 Repository: aurora Description --- Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances. Diffs (updated) - src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html b3480acacf9073123887a05047bf73a6f7cd34be src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7 Diff: https://reviews.apache.org/r/22944/diff/ Testing --- ./gradlew build File Attachments Mocked data for groups. https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png Thanks, David McLaughlin
Re: Review Request 24062: Improve usability of links in the job page.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24062/ --- (Updated July 29, 2014, 8:11 p.m.) Review request for Aurora and David McLaughlin. Changes --- Hooray, jsHint set me straight in my style-ignorant ways :-) Style corrected, build now passes (i forgot that this was part of the build). Bugs: AURORA-561 https://issues.apache.org/jira/browse/AURORA-561 Repository: aurora Description --- This addresses two usability issues, one of which is detailed in the bug above. The other is general odd behavior for anchors - where the mouse cursor would not switch to a pointer when hovering over links. Diffs (updated) - src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css e7a31c56b795e5ff0ff6dce3b54a303caaaea8be src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 12c7b8cab38202b0e93a1a8ac5fb177544358eef src/main/resources/org/apache/aurora/scheduler/http/ui/taskSandbox.html da801f4aa61362ee0178e038cffcded65a486ad5 src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html bdf15cf021e51fb646d725744f94a4589d7b0761 Diff: https://reviews.apache.org/r/24062/diff/ Testing --- Manually verified Thanks, Bill Farner
Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/#review49022 --- src/main/java/org/apache/aurora/scheduler/http/ServletModule.java https://reviews.apache.org/r/24059/#comment85856 I thought you wanted to drop it? - Maxim Khutornenko On July 29, 2014, 7:06 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- (Updated July 29, 2014, 7:06 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-606 https://issues.apache.org/jira/browse/AURORA-606 Repository: aurora Description --- This is somewhat a copy-paste of the original HttpModule [1], as the first step in a general improvement in how we interact with jetty. I've left a TODO for the next step (simplify addition of static assets). The only expected functional changes are the removal of /healthz (long-since deprecated in favor of /health) and /pprof/* which i have not found to produce useful output in practice (at least, not as useful as other standard JVM tools). I've also removed our dependencies on twitter's jar-packaged jquery and bootstrap, which we no longer appear to use anywhere. [1] https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/application/modules/HttpModule.java Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb src/main/java/org/apache/aurora/scheduler/app/AppModule.java 30b1ba623daa69a1e184cb91a92e58720648caa2 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java f429eda3bc2c9ae80a67dca8da8574eb7f92976b src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 729e0ab035b29dc570a2128266112db5312138ed src/test/java/org/apache/aurora/scheduler/http/ServletModuleTest.java 90a001b38ce35fe4da666febde328c1af30f9663 Diff: https://reviews.apache.org/r/24059/diff/ Testing --- ./gradlew clean build -Pq bash examples/vagrant/test_tutorial.sh Manually clicked around in a local scheduler. Thanks, Bill Farner
Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- (Updated July 29, 2014, 9:44 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-606 https://issues.apache.org/jira/browse/AURORA-606 Repository: aurora Description (updated) --- This is somewhat a copy-paste of the original HttpModule [1], as the first step in a general improvement in how we interact with jetty. I've left a TODO for the next step (simplify addition of static assets). The only expected functional change is the removal of /pprof/*, which i have not found to produce useful output in practice (at least, not as useful as other standard JVM tools). I've also removed our dependencies on twitter's jar-packaged jquery and bootstrap, which we no longer appear to use anywhere. [1] https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/application/modules/HttpModule.java Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb src/main/java/org/apache/aurora/scheduler/app/AppModule.java 30b1ba623daa69a1e184cb91a92e58720648caa2 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java f429eda3bc2c9ae80a67dca8da8574eb7f92976b src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 729e0ab035b29dc570a2128266112db5312138ed src/test/java/org/apache/aurora/scheduler/http/ServletModuleTest.java 90a001b38ce35fe4da666febde328c1af30f9663 Diff: https://reviews.apache.org/r/24059/diff/ Testing --- ./gradlew clean build -Pq bash examples/vagrant/test_tutorial.sh Manually clicked around in a local scheduler. Thanks, Bill Farner
Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.
On July 29, 2014, 8:58 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 124 https://reviews.apache.org/r/24059/diff/2/?file=644918#file644918line124 I thought you wanted to drop it? Hah whoops, that happened in a different branch. Updated the review description to match the diff. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/#review49022 --- On July 29, 2014, 9:44 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- (Updated July 29, 2014, 9:44 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-606 https://issues.apache.org/jira/browse/AURORA-606 Repository: aurora Description --- This is somewhat a copy-paste of the original HttpModule [1], as the first step in a general improvement in how we interact with jetty. I've left a TODO for the next step (simplify addition of static assets). The only expected functional change is the removal of /pprof/*, which i have not found to produce useful output in practice (at least, not as useful as other standard JVM tools). I've also removed our dependencies on twitter's jar-packaged jquery and bootstrap, which we no longer appear to use anywhere. [1] https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/application/modules/HttpModule.java Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb src/main/java/org/apache/aurora/scheduler/app/AppModule.java 30b1ba623daa69a1e184cb91a92e58720648caa2 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java f429eda3bc2c9ae80a67dca8da8574eb7f92976b src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 729e0ab035b29dc570a2128266112db5312138ed src/test/java/org/apache/aurora/scheduler/http/ServletModuleTest.java 90a001b38ce35fe4da666febde328c1af30f9663 Diff: https://reviews.apache.org/r/24059/diff/ Testing --- ./gradlew clean build -Pq bash examples/vagrant/test_tutorial.sh Manually clicked around in a local scheduler. Thanks, Bill Farner
Re: Review Request 23329: remove embedded jquery
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/#review49045 --- Reviewers - ping? - Bill Farner On July 9, 2014, 9:50 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/ --- (Updated July 9, 2014, 9:50 p.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: AURORA-578 https://issues.apache.org/jira/browse/AURORA-578 Repository: aurora Description --- remove embedded jquery Diffs - src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23329/diff/ Testing --- Thanks, David Robinson
Re: Review Request 22457: Improve aurora job diff command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review49046 --- Mark - looks like this was committed, reverted, then re-committed. If it's now in, can you please close the review? - Bill Farner On July 17, 2014, 2:09 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated July 17, 2014, 2:09 p.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: aurora-520 https://issues.apache.org/jira/browse/aurora-520 Repository: aurora Description --- Add a new diff method, which uses field-by-field comparison of JSON trees for comparing running job configurations to potentially updated configs. - Allow exclusion of semantically irrelevant fields. - Provide a clearer list of the differences between configs. - Provide a scripting-friendly alternative JSON syntax for diffs. The old diff behavior is still available under the --use-shell-diff option. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/jobs.py 4fa03a6c9919651551238b0dc211ed69a8dfe565 src/main/python/apache/aurora/client/cli/json_tree_diff.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 3c88ed7cf9f654bbbd80d1d44aa1dd1c8655e378 src/test/python/apache/aurora/client/cli/test_diff.py 38629b63c082cf81cb891dace2a70d9e8f418e18 src/test/python/apache/aurora/client/cli/test_json_diff.py PRE-CREATION Diff: https://reviews.apache.org/r/22457/diff/ Testing --- New unit tests of the JSON tree diff code, plus a bunch of new job diff tests of the new functionality. All tests pass. Thanks, Mark Chu-Carroll
Review Request 24077: Upgrade pants to 0.0.20
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- Upgrade pants to 0.0.20 Diffs - pants e8c3bcf5e3cf28fb3827ead04664914f40a22616 src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 26dee08bb3854b5e80e2046a2a431f41263bec46 Diff: https://reviews.apache.org/r/24077/diff/ Testing --- ./pants Thanks, Brian Wickman
Re: Review Request 23471: add support for Mesos masters running with --no-root_submissions, see AURORA-311
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/#review49047 --- Ship it! Ship It! - Brian Wickman On July 22, 2014, 11:28 p.m., Bjoern Metzdorf wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/ --- (Updated July 22, 2014, 11:28 p.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: AURORA-311 https://issues.apache.org/jira/browse/AURORA-311 Repository: aurora Description --- Review board entry for https://issues.apache.org/jira/browse/AURORA-311 Diffs - src/main/java/org/apache/aurora/scheduler/DriverFactory.java db864a0 Diff: https://reviews.apache.org/r/23471/diff/ Testing --- Tested successfully on internal cluster with version 0.5.1. Aurora was able to connect to a mesos master that was running with --no-root_submissions and was able to schedule tasks with a role of EXECUTOR_USER that then were running as the specified executor user. Thanks, Bjoern Metzdorf
Re: Review Request 24077: Upgrade pants to 0.0.20
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/#review49048 --- Nevermind, I think pants 0.0.20 is actually broken. - Brian Wickman On July 29, 2014, 11:39 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/ --- (Updated July 29, 2014, 11:39 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Upgrade pants to 0.0.20 Diffs - pants e8c3bcf5e3cf28fb3827ead04664914f40a22616 src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 26dee08bb3854b5e80e2046a2a431f41263bec46 Diff: https://reviews.apache.org/r/24077/diff/ Testing --- ./pants Thanks, Brian Wickman
Re: Review Request 22457: Improve aurora job diff command.
On July 29, 2014, 7:36 p.m., Bill Farner wrote: Mark - looks like this was committed, reverted, then re-committed. If it's now in, can you please close the review? Sadly no. It was committed, reverted, recommitted, reverted, rerecommitted, rerereverted. Why it fails in the hudson build is still a mystery. The best guess so far is python version, but I haven't been able to successfully reproduce the test failures. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review49046 --- On July 17, 2014, 10:09 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated July 17, 2014, 10:09 a.m.) Review request for Aurora, Maxim Khutornenko and Brian Wickman. Bugs: aurora-520 https://issues.apache.org/jira/browse/aurora-520 Repository: aurora Description --- Add a new diff method, which uses field-by-field comparison of JSON trees for comparing running job configurations to potentially updated configs. - Allow exclusion of semantically irrelevant fields. - Provide a clearer list of the differences between configs. - Provide a scripting-friendly alternative JSON syntax for diffs. The old diff behavior is still available under the --use-shell-diff option. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/jobs.py 4fa03a6c9919651551238b0dc211ed69a8dfe565 src/main/python/apache/aurora/client/cli/json_tree_diff.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD 3c88ed7cf9f654bbbd80d1d44aa1dd1c8655e378 src/test/python/apache/aurora/client/cli/test_diff.py 38629b63c082cf81cb891dace2a70d9e8f418e18 src/test/python/apache/aurora/client/cli/test_json_diff.py PRE-CREATION Diff: https://reviews.apache.org/r/22457/diff/ Testing --- New unit tests of the JSON tree diff code, plus a bunch of new job diff tests of the new functionality. All tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 24077: Upgrade pants to 0.0.20
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/ --- (Updated July 29, 2014, 11:50 p.m.) Review request for Aurora and Bill Farner. Changes --- Update PyPI index url format which changed. Repository: aurora Description --- Upgrade pants to 0.0.20 Diffs (updated) - pants e8c3bcf5e3cf28fb3827ead04664914f40a22616 pants.ini e65e273b2505fbce41781dc3712af45dd92345ae src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 26dee08bb3854b5e80e2046a2a431f41263bec46 Diff: https://reviews.apache.org/r/24077/diff/ Testing --- ./pants Thanks, Brian Wickman
Re: Review Request 24077: Upgrade pants to 0.0.20
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/#review49057 --- Is there a changelog anywhere? - Kevin Sweeney On July 29, 2014, 4:50 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/ --- (Updated July 29, 2014, 4:50 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Upgrade pants to 0.0.20 Diffs - pants e8c3bcf5e3cf28fb3827ead04664914f40a22616 pants.ini e65e273b2505fbce41781dc3712af45dd92345ae src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 26dee08bb3854b5e80e2046a2a431f41263bec46 Diff: https://reviews.apache.org/r/24077/diff/ Testing --- ./pants Thanks, Brian Wickman
Re: Review Request 24077: Upgrade pants to 0.0.20
On July 29, 2014, 11:54 p.m., Kevin Sweeney wrote: Is there a changelog anywhere? yes, as a matter of fact, they started publishing them just a couple releases ago: https://pypi.python.org/pypi/pantsbuild.pants/0.0.21 - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/#review49057 --- On July 29, 2014, 11:50 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/ --- (Updated July 29, 2014, 11:50 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Upgrade pants to 0.0.20 Diffs - pants e8c3bcf5e3cf28fb3827ead04664914f40a22616 pants.ini e65e273b2505fbce41781dc3712af45dd92345ae src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 26dee08bb3854b5e80e2046a2a431f41263bec46 Diff: https://reviews.apache.org/r/24077/diff/ Testing --- ./pants Thanks, Brian Wickman
Review Request 24078: Add an InstanceUpdater to fit into rolling update coordination in the scheduler.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24078/ --- Review request for Aurora, David McLaughlin, Kevin Sweeney, and Maxim Khutornenko. Bugs: AURORA-621 https://issues.apache.org/jira/browse/AURORA-621 Repository: aurora Description --- Note: this is one part of the epic AURORA-610, and is currently unwired code. This implements the logic to initiate a change from a possibly-absent current task state to a possibly-absent desired state. I worked with Maxim on this, and we started with a state machine approach. After some more careful thought, i pushed for a convergence function, which is implemented here. There are a few invariants assumed/designed here, which i've called out in the javadoc for evaluate(). The caller of this function will be responsible for implementing the TaskController interface. As for integration, this will mean: - maintaining one InstanceUpdater for each in-flight instance update - subscribing to task pubsub events and routing them to the appropriate InstanceUpdater's evaluate() - discarding terminal InstanceUpdaters (those which have called TaskController#updateCompleted()) - scheduling delayed calls to evaluate() based on the job's update parameters My advice for reviewing is to first scan the evaluate() function (without skipping out to helper functions), then dive into handleActualAndDesiredPresent(). Think of evaluate() as something that may be called arbitrarily, and attempts to gracefully move a task from the actual state to the desired state. Next, look at the unit test to see how the calls should look to turn this function into an event-driven convergence function. Diffs - src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/updater/TaskController.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java PRE-CREATION Diff: https://reviews.apache.org/r/24078/diff/ Testing --- ./gradlew build -Pq, 100% instruction and branch test coverage. Thanks, Bill Farner
Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/#review49076 --- +0, I dont really think that this is necessary and will add overhead (especially with AURORA-616), thoughts on opening this up on the dev@ list to a wider discussion? - Jake Farrell On July 29, 2014, 7:14 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/ --- (Updated July 29, 2014, 7:14 p.m.) Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA-620 https://issues.apache.org/jira/browse/AURORA-620 Repository: aurora Description --- Use JCenter over HTTPS instead of Maven Central Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb Diff: https://reviews.apache.org/r/24063/diff/ Testing --- rm -fr ~/.gradle/caches ./gradlew build Thanks, Kevin Sweeney
Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central
On July 30, 2014, 1:55 a.m., Jake Farrell wrote: +0, I dont really think that this is necessary and will add overhead (especially with AURORA-616), thoughts on opening this up on the dev@ list to a wider discussion? +1 to hashing this out in a dev@ discussion. I've had a nervous twitch about traditional maven-style dependencies for a long time, and i'd love to know if i'm just wearing a tinfoil hat :-) - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/#review49076 --- On July 29, 2014, 7:14 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/ --- (Updated July 29, 2014, 7:14 p.m.) Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA-620 https://issues.apache.org/jira/browse/AURORA-620 Repository: aurora Description --- Use JCenter over HTTPS instead of Maven Central Diffs - build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb Diff: https://reviews.apache.org/r/24063/diff/ Testing --- rm -fr ~/.gradle/caches ./gradlew build Thanks, Kevin Sweeney
Re: Review Request 23329: remove embedded jquery
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/#review49084 --- Not sure I understand the motivation here. It's generally best to host your own static assets. - David McLaughlin On July 9, 2014, 9:50 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/ --- (Updated July 9, 2014, 9:50 p.m.) Review request for Aurora, David McLaughlin and Brian Wickman. Bugs: AURORA-578 https://issues.apache.org/jira/browse/AURORA-578 Repository: aurora Description --- remove embedded jquery Diffs - src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23329/diff/ Testing --- Thanks, David Robinson
