Review Request 29940: Paginate when necessary in review bot.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/ --- Review request for Aurora and Steve Niemitz. Bugs: AURORA-1018 https://issues.apache.org/jira/browse/AURORA-1018 Repository: aurora Description --- Paginate when necessary in review bot. Diffs - build-support/jenkins/review_feedback.py 66a887797993e2d2d4301ce95242559bfed22c0d Diff: https://reviews.apache.org/r/29940/diff/ Testing --- Ran locally. Review bot is not currently interested in building https://reviews.apache.org/r/28920/ ``` Inspecting review 28920: Add support for docker containers to aurora Request: https://reviews.apache.org/api/review-requests/28920/reviews/ Fetching next page of reviews. Request: https://reviews.apache.org/api/review-requests/28920/reviews/?start=25max-results=25 Fetching next page of reviews. Request: https://reviews.apache.org/api/review-requests/28920/reviews/?start=50max-results=25 Feedback has been given 39 times Request: https://reviews.apache.org/api/review-requests/28920/diffs/ Latest feedback was given at2015-01-15T17:57:08Z Latest build request from a user at 2015-01-15T17:57:08Z Latest diff was posted at 2015-01-14T20:18:13Z ``` Thanks, Bill Farner
Re: Review Request 29940: Paginate when necessary in review bot.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/#review68291 --- Ship it! Any reason why the times in the output seem to be off by 2 minutes? (i.e. it says last diff was at 20:18, but looking at the review it was actually at 20:20?) - Joshua Cohen On Jan. 15, 2015, 6:38 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/ --- (Updated Jan. 15, 2015, 6:38 p.m.) Review request for Aurora and Steve Niemitz. Bugs: AURORA-1018 https://issues.apache.org/jira/browse/AURORA-1018 Repository: aurora Description --- Paginate when necessary in review bot. Diffs - build-support/jenkins/review_feedback.py 66a887797993e2d2d4301ce95242559bfed22c0d Diff: https://reviews.apache.org/r/29940/diff/ Testing --- Ran locally. Review bot is not currently interested in building https://reviews.apache.org/r/28920/ ``` Inspecting review 28920: Add support for docker containers to aurora Request: https://reviews.apache.org/api/review-requests/28920/reviews/ Fetching next page of reviews. Request: https://reviews.apache.org/api/review-requests/28920/reviews/?start=25max-results=25 Fetching next page of reviews. Request: https://reviews.apache.org/api/review-requests/28920/reviews/?start=50max-results=25 Feedback has been given 39 times Request: https://reviews.apache.org/api/review-requests/28920/diffs/ Latest feedback was given at2015-01-15T17:57:08Z Latest build request from a user at 2015-01-15T17:57:08Z Latest diff was posted at 2015-01-14T20:18:13Z ``` Thanks, Bill Farner
Re: Review Request 28920: Add support for docker containers to aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68267
---
Master (a350982) is red with this patch.
./build-support/jenkins/build.sh
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
line 88, in run
rv = self._run_tests([target], stdout, stderr)
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
line 316, in _run_tests
with self._test_runner(targets, stdout, stderr) as (pex, test_args):
File /usr/lib/python2.7/contextlib.py, line 17, in __enter__
return self.gen.next()
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
line 295, in _test_runner
builder = chroot.dump()
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py,
line 191, in dump
conn_timeout=self._conn_timeout)
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/resolver.py,
line 100, in resolve_multi
platform=platform)
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py,
line 110, in resolve
new_requirements.update(requires(highest_package, requirement))
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py,
line 84, in requires
raise Untranslateable('Package %s is not translateable.' % package)
Untranslateable: Package
WheelPackage(u'https://pypi.python.org/packages/py2.py3/p/pytest-timeout/pytest_timeout-0.4-py2.py3-none-any.whl#md5=84a0fa6b871f0c93b77206ed8840144d')
is not translateable.
Usage:
pants build (options) [spec] (build args)
pants build (options) [spec]... -- (build args)
Options:
--version show program's version number and exit
--no-pantsrc Specifies that pantsrc files should be ignored.
--log-exitLog an exit message on success or failure.
-t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
Number of seconds to wait for http connections.
-i INTERPRETERS, --interpreter=INTERPRETERS
Constrain what Python interpreters to use. Uses
Requirement format from pkg_resources, e.g.
'CPython=2.6,3' or 'PyPy'. By default, no
constraints are used. Multiple constraints may be
added. They will be ORed together.
-v, --verbose Show verbose output.
-f, --fastRun tests in a single chroot.
Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.
I will refresh this build result if you post a review containing @ReviewBot
retry
- Aurora ReviewBot
On Jan. 14, 2015, 8:20 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 14, 2015, 8:20 p.m.)
Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-633
https://issues.apache.org/jira/browse/AURORA-633
Repository: aurora
Description
---
This change adds support for launching docker containers through aurora.
These changes are based off of the discussion in
https://issues.apache.org/jira/browse/AURORA-633
As of now, a special thermos_executor.sh script is needed to launch the
executor inside docker containers. A sample aurora file is in
examples/jobs/docker.
In addition, mesos-slave must be run with `--containerizers=docker,mesos`,
the example upstart config in examples/vagrant/upstart has been updated to
reflect this.
More information is in subsequent review request comments.
Diffs
-
Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc
api/src/main/thrift/org/apache/aurora/gen/api.thrift
08ba1cdf88b712de22c26c04443079282db59ef9
config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5
docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea
docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7
examples/jobs/docker/hello_docker.aurora PRE-CREATION
examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd
examples/vagrant/provision-dev-cluster.sh
7af4b52a6876268a97630279221bb98d9b04efad
examples/vagrant/upstart/aurora-scheduler.conf
Re: Review Request 28920: Add support for docker containers to aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68260 --- Master (a350982) is red with this patch. ./build-support/jenkins/build.sh :licenseTest UP-TO-DATE :license UP-TO-DATE :pmdMain :test :jacocoTestReport Coverage report generated: file:///x1/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :analyzeReport Instruction coverage of 0.893543617545589 exceeds minimum coverage of 0.89. Branch coverage of 0.8391933815925543 exceeds minimum coverage of 0.835. :check :build :api:assemble :api:compileTestJava UP-TO-DATE :api:processTestResources UP-TO-DATE :api:testClasses UP-TO-DATE :api:test UP-TO-DATE :api:check UP-TO-DATE :api:build :buildSrc:compileJava UP-TO-DATE :buildSrc:processResources UP-TO-DATE :buildSrc:classes UP-TO-DATE :buildSrc:jar :buildSrc:assemble :buildSrc:compileTestJava UP-TO-DATE :buildSrc:processTestResources UP-TO-DATE :buildSrc:testClasses UP-TO-DATE :buildSrc:test UP-TO-DATE :buildSrc:check UP-TO-DATE :buildSrc:build BUILD SUCCESSFUL Total time: 3 mins 56.511 secs + export PIP_DEFAULT_TIMEOUT=60 + PIP_DEFAULT_TIMEOUT=60 + mkdir -p third_party + pip install -d third_party -r /dev/fd/63 ++ grep -v mesos.native 3rdparty/python/requirements.txt ./build-support/jenkins/build.sh: line 28: pip: command not found grep: write error: Broken pipe I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 14, 2015, 8:20 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 14, 2015, 8:20 p.m.) Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner. Bugs: AURORA-633 https://issues.apache.org/jira/browse/AURORA-633 Repository: aurora Description --- This change adds support for launching docker containers through aurora. These changes are based off of the discussion in https://issues.apache.org/jira/browse/AURORA-633 As of now, a special thermos_executor.sh script is needed to launch the executor inside docker containers. A sample aurora file is in examples/jobs/docker. In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the example upstart config in examples/vagrant/upstart has been updated to reflect this. More information is in subsequent review request comments. Diffs - Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 08ba1cdf88b712de22c26c04443079282db59ef9 config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5 docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 examples/jobs/docker/hello_docker.aurora PRE-CREATION examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 examples/vagrant/upstart/mesos-slave.conf 512ce7ecf34042ed68dda55efb2dd0415f8469db src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 5226e3d1b303b1773a057078f2911c5ec2aa97f5 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 01b03508afac37b5a8f0ec5c3da1460695e1ef59 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 5bf283062c9d119ff91ed45da8b236e36d0fc9aa src/main/python/apache/aurora/config/thrift.py ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c src/main/python/apache/aurora/executor/aurora_executor.py 636b23d30a897b557eb8c3f8733c90b23cb807ef src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f7d8977e42aa56188799400bf8e12a6886fb4a8f src/main/python/apache/aurora/executor/common/sandbox.py f47a32b3fefb4a89940b1ddc473b8316ac00df12 src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448 src/main/python/apache/thermos/config/schema_base.py f9143cc1b83143d6147f59d90c79435d055d0518 src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3 src/main/resources/scheduler/assets/configSummary.html 28878908b0c9381e366b71a3135dfc28c542a890 src/main/resources/scheduler/assets/js/services.js
Re: Review Request 28920: Add support for docker containers to aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68247 --- Master (a350982) is red with this patch. ./build-support/jenkins/build.sh Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.string-0.3.1-py2.7-nspkg.pth Running setup.py install for twitter.common.threading Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package) Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package) Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.threading-0.3.1-py2.7-nspkg.pth Running setup.py install for twitter.common.util Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package) Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package) Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.util-0.3.1-py2.7-nspkg.pth Found existing installation: setuptools 3.6 Uninstalling setuptools: Successfully uninstalled setuptools Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon requests twitter.common.collections twitter.common.config twitter.common.confluence twitter.common.contextutil twitter.common.decorators twitter.common.dirutil twitter.common.lang twitter.common.log twitter.common.options twitter.common.process twitter.common.string twitter.common.threading twitter.common.util setuptools Cleaning up... Unable to detect suitable interpreter. Usage: pants build (options) [spec] (build args) pants build (options) [spec]... -- (build args) Options: --version show program's version number and exit --no-pantsrc Specifies that pantsrc files should be ignored. --log-exitLog an exit message on success or failure. -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT Number of seconds to wait for http connections. -i INTERPRETERS, --interpreter=INTERPRETERS Constrain what Python interpreters to use. Uses Requirement format from pkg_resources, e.g. 'CPython=2.6,3' or 'PyPy'. By default, no constraints are used. Multiple constraints may be added. They will be ORed together. -v, --verbose Show verbose output. -f, --fastRun tests in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 14, 2015, 8:20 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 14, 2015, 8:20 p.m.) Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner. Bugs: AURORA-633 https://issues.apache.org/jira/browse/AURORA-633 Repository: aurora Description --- This change adds support for launching docker containers through aurora. These changes are based off of the discussion in https://issues.apache.org/jira/browse/AURORA-633 As of now, a special thermos_executor.sh script is needed to launch the executor inside docker containers. A sample aurora file is in examples/jobs/docker. In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the example upstart config in examples/vagrant/upstart has been updated to reflect this. More information is in subsequent review request comments. Diffs - Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 08ba1cdf88b712de22c26c04443079282db59ef9 config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5 docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 examples/jobs/docker/hello_docker.aurora PRE-CREATION examples/vagrant/aurorabuild.sh
Re: Review Request 29940: Paginate when necessary in review bot.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/#review68298 --- Ship it! Master (a350982) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 15, 2015, 7:21 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/ --- (Updated Jan. 15, 2015, 7:21 p.m.) Review request for Aurora, Steve Niemitz and Zameer Manji. Bugs: AURORA-1018 https://issues.apache.org/jira/browse/AURORA-1018 Repository: aurora Description --- Paginate when necessary in review bot. Diffs - build-support/jenkins/review_feedback.py 66a887797993e2d2d4301ce95242559bfed22c0d Diff: https://reviews.apache.org/r/29940/diff/ Testing --- Ran locally. Review bot is not currently interested in building https://reviews.apache.org/r/28920/ ``` Inspecting review 28920: Add support for docker containers to aurora Request: https://reviews.apache.org/api/review-requests/28920/reviews/ Fetching next page of reviews. Request: https://reviews.apache.org/api/review-requests/28920/reviews/?start=25max-results=25 Fetching next page of reviews. Request: https://reviews.apache.org/api/review-requests/28920/reviews/?start=50max-results=25 Feedback has been given 39 times Request: https://reviews.apache.org/api/review-requests/28920/diffs/ Latest feedback was given at2015-01-15T17:57:08Z Latest build request from a user at 2015-01-15T17:57:08Z Latest diff was posted at 2015-01-14T20:18:13Z ``` Thanks, Bill Farner
Re: Review Request 29873: Fixing batched kill task filtering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/ --- (Updated Jan. 15, 2015, 7:44 p.m.) Review request for Aurora and Bill Farner. Changes --- Bill's comments. Bugs: AURORA-996 https://issues.apache.org/jira/browse/AURORA-996 Repository: aurora Description --- Fixed job status quering in client context to return active tasks where needed. Also, dropped active instance validation from both updater calls as it was hiding a legitimate feature: add new job instances with instance_spec. Diffs (updated) - src/main/python/apache/aurora/client/api/__init__.py 64f08046f6aca112a9f51c3f250ba6102d297216 src/main/python/apache/aurora/client/cli/context.py 93587c616afb0b7493a509197361cd76af2e2c97 src/main/python/apache/aurora/client/cli/jobs.py 508c9be556998e47bddcec8dee43f1595497b354 src/main/python/apache/aurora/client/cli/task.py 21548984f6f5cd894733220c6508458cc1318391 src/main/python/apache/aurora/client/cli/update.py a1617325f08ca252bdba38618aef141504ba7272 src/test/python/apache/aurora/client/cli/test_command_hooks.py e8432a1f3475e7e48a092526998d15cbf7e92e10 src/test/python/apache/aurora/client/cli/test_create.py 18b58383d209a50bd09fbdfa5a600e49d1d848f7 src/test/python/apache/aurora/client/cli/test_kill.py b475d737ede8ff0a669a9a9229196a76b43b46b6 src/test/python/apache/aurora/client/cli/test_plugins.py aa45851bd26f78583e0c16d0c3699c12f8a58697 src/test/python/apache/aurora/client/cli/test_restart.py a532ead256869c620e6bd96886ce9681b3423d0c src/test/python/apache/aurora/client/cli/test_supdate.py 9378b49ec5e4bb8189b00d9fd1d80558a731d668 src/test/python/apache/aurora/client/cli/test_update.py c12b32e3327af8c014fdad72d63ab4e68dc541c8 src/test/python/apache/aurora/client/cli/util.py 147d418ea1de679674dd93eaf648d84686b95d37 Diff: https://reviews.apache.org/r/29873/diff/ Testing --- ./pants src/test/python:all vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall devcluster/www-data/prod/hello INFO] Checking status of devcluster/www-data/prod/hello INFO] No tasks to kill found for job devcluster/www-data/prod/hello Job killall succeeded Thanks, Maxim Khutornenko
Re: Review Request 29940: Paginate when necessary in review bot.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/#review68299 --- Ship it! Ship It! - Zameer Manji On Jan. 15, 2015, 11:21 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/ --- (Updated Jan. 15, 2015, 11:21 a.m.) Review request for Aurora, Steve Niemitz and Zameer Manji. Bugs: AURORA-1018 https://issues.apache.org/jira/browse/AURORA-1018 Repository: aurora Description --- Paginate when necessary in review bot. Diffs - build-support/jenkins/review_feedback.py 66a887797993e2d2d4301ce95242559bfed22c0d Diff: https://reviews.apache.org/r/29940/diff/ Testing --- Ran locally. Review bot is not currently interested in building https://reviews.apache.org/r/28920/ ``` Inspecting review 28920: Add support for docker containers to aurora Request: https://reviews.apache.org/api/review-requests/28920/reviews/ Fetching next page of reviews. Request: https://reviews.apache.org/api/review-requests/28920/reviews/?start=25max-results=25 Fetching next page of reviews. Request: https://reviews.apache.org/api/review-requests/28920/reviews/?start=50max-results=25 Feedback has been given 39 times Request: https://reviews.apache.org/api/review-requests/28920/diffs/ Latest feedback was given at2015-01-15T17:57:08Z Latest build request from a user at 2015-01-15T17:57:08Z Latest diff was posted at 2015-01-14T20:18:13Z ``` Thanks, Bill Farner
Re: Review Request 29873: Fixing batched kill task filtering.
On Jan. 14, 2015, 7:27 p.m., Bill Farner wrote: src/test/python/apache/aurora/client/cli/test_kill.py, line 146 https://reviews.apache.org/r/29873/diff/1/?file=820323#file820323line146 While you're in here, can you take a stab at renaming `create_mock_task` to `create_task`, and not using mocks (ditto for `create_scheduled_tasks`)? This aligns with the desired pattern of avoiding unnecessary use of mocks. You can borrow from `test_inspect.py` for an example: https://reviews.apache.org/r/29696 Maxim Khutornenko wrote: Sure, will do. Refactored as much as I could find. There is still plenty of refactoring left but I have to stop here to avoid a larger yak shave. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/#review68083 --- On Jan. 14, 2015, 1:16 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/ --- (Updated Jan. 14, 2015, 1:16 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-996 https://issues.apache.org/jira/browse/AURORA-996 Repository: aurora Description --- Fixed job status quering in client context to return active tasks where needed. Also, dropped active instance validation from both updater calls as it was hiding a legitimate feature: add new job instances with instance_spec. Diffs - src/main/python/apache/aurora/client/cli/context.py 93587c616afb0b7493a509197361cd76af2e2c97 src/main/python/apache/aurora/client/cli/jobs.py 508c9be556998e47bddcec8dee43f1595497b354 src/main/python/apache/aurora/client/cli/update.py a1617325f08ca252bdba38618aef141504ba7272 src/test/python/apache/aurora/client/cli/test_kill.py b475d737ede8ff0a669a9a9229196a76b43b46b6 src/test/python/apache/aurora/client/cli/test_restart.py a532ead256869c620e6bd96886ce9681b3423d0c Diff: https://reviews.apache.org/r/29873/diff/ Testing --- ./pants src/test/python:all vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall devcluster/www-data/prod/hello INFO] Checking status of devcluster/www-data/prod/hello INFO] No tasks to kill found for job devcluster/www-data/prod/hello Job killall succeeded Thanks, Maxim Khutornenko
Re: Review Request 29915: Ensure TaskStateChange event emitted by StateManagerImpl has valid data.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29915/ --- (Updated Jan. 15, 2015, 1:32 p.m.) Review request for Aurora and Bill Farner. Changes --- Revise patch based on offline conversation with wfarner. Summary (updated) - Ensure TaskStateChange event emitted by StateManagerImpl has valid data. Bugs: AURORA-1016 https://issues.apache.org/jira/browse/AURORA-1016 Repository: aurora Description (updated) --- The `StateManagerImpl` class emits a pubsub event when a task transitions to the ASSIGNED state but before it attaches the associated slave id and host. This patch ensures that the pubsub event has the associated slave id and host when emitted. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 085454c63a3023e28ae1d148c64d25cfed99c4f1 src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42 Diff: https://reviews.apache.org/r/29915/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 29940: Paginate when necessary in review bot.
On Jan. 15, 2015, 6:55 p.m., Joshua Cohen wrote:
Any reason why the times in the output seem to be off by 2 minutes? (i.e.
it says last diff was at 20:18, but looking at the review it was actually
at 20:20?)
Great question. These are two different timestamps. One is for the diff
(which you see in the output of the script), and one is for the change made to
the review (displayed on RB). You can see both of these here:
```
$ curl -s https://reviews.apache.org/api/review-requests/28920/changes/ |
python -mjson.tool | head -n54
{
changes: [
{
fields_changed: {
commit_id: {
new: [
35da9b53c5fc15e246e4f3dd651c4e5330a26f29
],
old: [
3e4809f9854f8c20b158a722ac14c9e570fa4b7f
]
},
diff: {
added: {
base_commit_id:
a350982ee63b70eefdb182274946c2c3c8789509,
basedir: ,
extra_data: {},
id: 55807,
links: {
files: {
href:
https://reviews.apache.org/api/review-requests/28920/diffs/16/files/;,
method: GET
},
repository: {
href:
https://reviews.apache.org/api/repositories/133/;,
method: GET,
title: aurora
},
self: {
href:
https://reviews.apache.org/api/review-requests/28920/diffs/16/;,
method: GET
},
update: {
href:
https://reviews.apache.org/api/review-requests/28920/diffs/16/;,
method: PUT
}
},
name: diff,
revision: 16,
timestamp: 2015-01-14T20:18:13Z
}
}
},
id: 46089,
links: {
self: {
href:
https://reviews.apache.org/api/review-requests/28920/changes/46089/;,
method: GET
}
},
text: ,
text_type: markdown,
timestamp: 2015-01-14T20:20:15Z
},
```
I believe the delta is caused by the delay between when the diff was posted and
the publish button was clicked.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29940/#review68291
---
On Jan. 15, 2015, 6:38 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29940/
---
(Updated Jan. 15, 2015, 6:38 p.m.)
Review request for Aurora and Steve Niemitz.
Bugs: AURORA-1018
https://issues.apache.org/jira/browse/AURORA-1018
Repository: aurora
Description
---
Paginate when necessary in review bot.
Diffs
-
build-support/jenkins/review_feedback.py
66a887797993e2d2d4301ce95242559bfed22c0d
Diff: https://reviews.apache.org/r/29940/diff/
Testing
---
Ran locally. Review bot is not currently interested in building
https://reviews.apache.org/r/28920/
```
Inspecting review 28920: Add support for docker containers to aurora
Request: https://reviews.apache.org/api/review-requests/28920/reviews/
Fetching next page of reviews.
Request:
https://reviews.apache.org/api/review-requests/28920/reviews/?start=25max-results=25
Fetching next page of reviews.
Request:
https://reviews.apache.org/api/review-requests/28920/reviews/?start=50max-results=25
Feedback has been given 39 times
Request: https://reviews.apache.org/api/review-requests/28920/diffs/
Latest feedback was given at2015-01-15T17:57:08Z
Latest build request from a user at 2015-01-15T17:57:08Z
Latest diff was posted at 2015-01-14T20:18:13Z
```
Thanks,
Bill Farner
Re: Review Request 28920: Add support for docker containers to aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 15, 2015, 8:24 p.m.) Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner. Changes --- Added -allowed_container_types to scheduler and decoupled Aurora config schema from Mesos for container configuration. Bugs: AURORA-633 https://issues.apache.org/jira/browse/AURORA-633 Repository: aurora Description --- This change adds support for launching docker containers through aurora. These changes are based off of the discussion in https://issues.apache.org/jira/browse/AURORA-633 As of now, a special thermos_executor.sh script is needed to launch the executor inside docker containers. A sample aurora file is in examples/jobs/docker. In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the example upstart config in examples/vagrant/upstart has been updated to reflect this. More information is in subsequent review request comments. Diffs (updated) - Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 08ba1cdf88b712de22c26c04443079282db59ef9 config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5 docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 examples/jobs/docker/hello_docker.aurora PRE-CREATION examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 examples/vagrant/upstart/mesos-slave.conf 512ce7ecf34042ed68dda55efb2dd0415f8469db src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 5226e3d1b303b1773a057078f2911c5ec2aa97f5 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 01b03508afac37b5a8f0ec5c3da1460695e1ef59 src/main/java/org/apache/aurora/scheduler/configuration/ContainerType.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 5bf283062c9d119ff91ed45da8b236e36d0fc9aa src/main/python/apache/aurora/config/thrift.py ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c src/main/python/apache/aurora/executor/aurora_executor.py 636b23d30a897b557eb8c3f8733c90b23cb807ef src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f7d8977e42aa56188799400bf8e12a6886fb4a8f src/main/python/apache/aurora/executor/common/sandbox.py f47a32b3fefb4a89940b1ddc473b8316ac00df12 src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448 src/main/python/apache/thermos/config/schema_base.py f9143cc1b83143d6147f59d90c79435d055d0518 src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3 src/main/resources/scheduler/assets/configSummary.html 28878908b0c9381e366b71a3135dfc28c542a890 src/main/resources/scheduler/assets/js/services.js b744f375411e09b7f776e4a05ee5961227143439 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 5e54364a49a208bd5f19b9649633dc8feca591e9 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java dc2cb37adf32df0a6e4c7ee2ba776ba9f1f3c2f8 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 7eafe074b686d55ad96018006cf4acfa823513c3 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java ad9126c32893080e128d086ea3bfd7ad23d27b89 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68328 --- Ship it! Since git maintenance is currently underway, i cannot commit this yet. Please bug me tomorrow if i have not yet committed (providing maintenance completes). - Bill Farner On Jan. 15, 2015, 7:56 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 7:56 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 29940: Paginate when necessary in review bot.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/ --- (Updated Jan. 15, 2015, 7:21 p.m.) Review request for Aurora, Steve Niemitz and Zameer Manji. Bugs: AURORA-1018 https://issues.apache.org/jira/browse/AURORA-1018 Repository: aurora Description --- Paginate when necessary in review bot. Diffs - build-support/jenkins/review_feedback.py 66a887797993e2d2d4301ce95242559bfed22c0d Diff: https://reviews.apache.org/r/29940/diff/ Testing --- Ran locally. Review bot is not currently interested in building https://reviews.apache.org/r/28920/ ``` Inspecting review 28920: Add support for docker containers to aurora Request: https://reviews.apache.org/api/review-requests/28920/reviews/ Fetching next page of reviews. Request: https://reviews.apache.org/api/review-requests/28920/reviews/?start=25max-results=25 Fetching next page of reviews. Request: https://reviews.apache.org/api/review-requests/28920/reviews/?start=50max-results=25 Feedback has been given 39 times Request: https://reviews.apache.org/api/review-requests/28920/diffs/ Latest feedback was given at2015-01-15T17:57:08Z Latest build request from a user at 2015-01-15T17:57:08Z Latest diff was posted at 2015-01-14T20:18:13Z ``` Thanks, Bill Farner
Re: Review Request 28920: Add support for docker containers to aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68301 --- Ship it! Master (a350982) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 14, 2015, 8:20 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 14, 2015, 8:20 p.m.) Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner. Bugs: AURORA-633 https://issues.apache.org/jira/browse/AURORA-633 Repository: aurora Description --- This change adds support for launching docker containers through aurora. These changes are based off of the discussion in https://issues.apache.org/jira/browse/AURORA-633 As of now, a special thermos_executor.sh script is needed to launch the executor inside docker containers. A sample aurora file is in examples/jobs/docker. In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the example upstart config in examples/vagrant/upstart has been updated to reflect this. More information is in subsequent review request comments. Diffs - Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 08ba1cdf88b712de22c26c04443079282db59ef9 config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5 docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 examples/jobs/docker/hello_docker.aurora PRE-CREATION examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 examples/vagrant/upstart/mesos-slave.conf 512ce7ecf34042ed68dda55efb2dd0415f8469db src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 5226e3d1b303b1773a057078f2911c5ec2aa97f5 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 01b03508afac37b5a8f0ec5c3da1460695e1ef59 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 5bf283062c9d119ff91ed45da8b236e36d0fc9aa src/main/python/apache/aurora/config/thrift.py ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c src/main/python/apache/aurora/executor/aurora_executor.py 636b23d30a897b557eb8c3f8733c90b23cb807ef src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f7d8977e42aa56188799400bf8e12a6886fb4a8f src/main/python/apache/aurora/executor/common/sandbox.py f47a32b3fefb4a89940b1ddc473b8316ac00df12 src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448 src/main/python/apache/thermos/config/schema_base.py f9143cc1b83143d6147f59d90c79435d055d0518 src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3 src/main/resources/scheduler/assets/configSummary.html 28878908b0c9381e366b71a3135dfc28c542a890 src/main/resources/scheduler/assets/js/services.js b744f375411e09b7f776e4a05ee5961227143439 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 5e54364a49a208bd5f19b9649633dc8feca591e9 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java dc2cb37adf32df0a6e4c7ee2ba776ba9f1f3c2f8 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29915: Ensure TaskStateChange event emitted by StateManagerImpl has valid data.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29915/#review68349 --- Ship it! Master (1acb428) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 15, 2015, 9:32 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29915/ --- (Updated Jan. 15, 2015, 9:32 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-1016 https://issues.apache.org/jira/browse/AURORA-1016 Repository: aurora Description --- The `StateManagerImpl` class emits a pubsub event when a task transitions to the ASSIGNED state but before it attaches the associated slave id and host. This patch ensures that the pubsub event has the associated slave id and host when emitted. Diffs - src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 085454c63a3023e28ae1d148c64d25cfed99c4f1 src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42 Diff: https://reviews.apache.org/r/29915/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 29901: De-flakify resource_manager_integration test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/ --- (Updated Jan. 15, 2015, 11:36 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- Make flaky test less bad (it's still bad -- but this code is destined for the trash can once we have feature parity from mesos.) Repository: aurora Description --- De-flakify ResourceManager integration test. Diffs (updated) - src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/main/python/apache/thermos/monitoring/resource.py 7b5bbe01810008c4d39b9dfee6521af01021a7ca src/test/python/apache/aurora/executor/common/BUILD 395ced27998def18eace2cbd46c736404c3d6411 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a Diff: https://reviews.apache.org/r/29901/diff/ Testing --- ./pants goal test --no-test-pytest-fast src/test/python/apache/aurora/executor/common:: Thanks, Brian Wickman
Re: Review Request 29873: Fixing batched kill task filtering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/#review68344 --- Ship it! Master (1acb428) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 15, 2015, 7:44 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/ --- (Updated Jan. 15, 2015, 7:44 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-996 https://issues.apache.org/jira/browse/AURORA-996 Repository: aurora Description --- Fixed job status quering in client context to return active tasks where needed. Also, dropped active instance validation from both updater calls as it was hiding a legitimate feature: add new job instances with instance_spec. Diffs - src/main/python/apache/aurora/client/api/__init__.py 64f08046f6aca112a9f51c3f250ba6102d297216 src/main/python/apache/aurora/client/cli/context.py 93587c616afb0b7493a509197361cd76af2e2c97 src/main/python/apache/aurora/client/cli/jobs.py 508c9be556998e47bddcec8dee43f1595497b354 src/main/python/apache/aurora/client/cli/task.py 21548984f6f5cd894733220c6508458cc1318391 src/main/python/apache/aurora/client/cli/update.py a1617325f08ca252bdba38618aef141504ba7272 src/test/python/apache/aurora/client/cli/test_command_hooks.py e8432a1f3475e7e48a092526998d15cbf7e92e10 src/test/python/apache/aurora/client/cli/test_create.py 18b58383d209a50bd09fbdfa5a600e49d1d848f7 src/test/python/apache/aurora/client/cli/test_kill.py b475d737ede8ff0a669a9a9229196a76b43b46b6 src/test/python/apache/aurora/client/cli/test_plugins.py aa45851bd26f78583e0c16d0c3699c12f8a58697 src/test/python/apache/aurora/client/cli/test_restart.py a532ead256869c620e6bd96886ce9681b3423d0c src/test/python/apache/aurora/client/cli/test_supdate.py 9378b49ec5e4bb8189b00d9fd1d80558a731d668 src/test/python/apache/aurora/client/cli/test_update.py c12b32e3327af8c014fdad72d63ab4e68dc541c8 src/test/python/apache/aurora/client/cli/util.py 147d418ea1de679674dd93eaf648d84686b95d37 Diff: https://reviews.apache.org/r/29873/diff/ Testing --- ./pants src/test/python:all vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall devcluster/www-data/prod/hello INFO] Checking status of devcluster/www-data/prod/hello INFO] No tasks to kill found for job devcluster/www-data/prod/hello Job killall succeeded Thanks, Maxim Khutornenko
Re: Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68345 --- This patch does not apply cleanly on master (1acb428), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 15, 2015, 7:56 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 7:56 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 29942: Updates so client will run in PyCharm.
On Jan. 15, 2015, 11:59 p.m., Aurora ReviewBot wrote: This patch does not apply cleanly on master (b75ed0f), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry I don't know what your deal is ReviewBot, it applied cleanly for me! - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68365 --- On Jan. 15, 2015, 11:58 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 11:58 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 29901: De-flakify resource_manager_integration test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/ --- (Updated Jan. 16, 2015, 12:11 a.m.) Review request for Aurora and Kevin Sweeney. Changes --- Switch to using autospec, also allowing us to remove the factory stuff. Repository: aurora Description --- De-flakify ResourceManager integration test. Diffs (updated) - src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/main/python/apache/thermos/monitoring/resource.py 7b5bbe01810008c4d39b9dfee6521af01021a7ca src/test/python/apache/aurora/executor/common/BUILD 395ced27998def18eace2cbd46c736404c3d6411 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a Diff: https://reviews.apache.org/r/29901/diff/ Testing --- ./pants goal test --no-test-pytest-fast src/test/python/apache/aurora/executor/common:: Thanks, Brian Wickman
Re: Review Request 29901: De-flakify resource_manager_integration test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/#review68368 --- Mind adding another committer with more recent mock experience to this review? I suggest jcohen. src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py https://reviews.apache.org/r/29901/#comment112554 unused import src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py https://reviews.apache.org/r/29901/#comment112555 unused import src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py https://reviews.apache.org/r/29901/#comment112559 spec_set=True. This lets the spec define the interface and prevents you from setting mock properties that don't exist on the spec like ```py mock_disk_collector.valu = 1234 ``` src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py https://reviews.apache.org/r/29901/#comment112557 is the use of PropertyMock required here or can you do ```py mock_disk_collector.value = 4197 ``` same below src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py https://reviews.apache.org/r/29901/#comment112556 Can you assert that the mocks are actually used below here (e.g. by checking expected calls were made)? A common issue with the client tests is the configuration of mocks that were later found to be unused. - Kevin Sweeney On Jan. 15, 2015, 4:11 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/ --- (Updated Jan. 15, 2015, 4:11 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- De-flakify ResourceManager integration test. Diffs - src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/main/python/apache/thermos/monitoring/resource.py 7b5bbe01810008c4d39b9dfee6521af01021a7ca src/test/python/apache/aurora/executor/common/BUILD 395ced27998def18eace2cbd46c736404c3d6411 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a Diff: https://reviews.apache.org/r/29901/diff/ Testing --- ./pants goal test --no-test-pytest-fast src/test/python/apache/aurora/executor/common:: Thanks, Brian Wickman
Re: Review Request 29873: Fixing batched kill task filtering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/#review68329 --- Ship it! src/main/python/apache/aurora/client/cli/context.py https://reviews.apache.org/r/29873/#comment112506 why convert an empty list to `None`? src/test/python/apache/aurora/client/cli/util.py https://reviews.apache.org/r/29873/#comment112507 Your call, but i'd prefer this be a single statement, `return ScheduledTask(...)`. - Bill Farner On Jan. 15, 2015, 7:44 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29873/ --- (Updated Jan. 15, 2015, 7:44 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-996 https://issues.apache.org/jira/browse/AURORA-996 Repository: aurora Description --- Fixed job status quering in client context to return active tasks where needed. Also, dropped active instance validation from both updater calls as it was hiding a legitimate feature: add new job instances with instance_spec. Diffs - src/main/python/apache/aurora/client/api/__init__.py 64f08046f6aca112a9f51c3f250ba6102d297216 src/main/python/apache/aurora/client/cli/context.py 93587c616afb0b7493a509197361cd76af2e2c97 src/main/python/apache/aurora/client/cli/jobs.py 508c9be556998e47bddcec8dee43f1595497b354 src/main/python/apache/aurora/client/cli/task.py 21548984f6f5cd894733220c6508458cc1318391 src/main/python/apache/aurora/client/cli/update.py a1617325f08ca252bdba38618aef141504ba7272 src/test/python/apache/aurora/client/cli/test_command_hooks.py e8432a1f3475e7e48a092526998d15cbf7e92e10 src/test/python/apache/aurora/client/cli/test_create.py 18b58383d209a50bd09fbdfa5a600e49d1d848f7 src/test/python/apache/aurora/client/cli/test_kill.py b475d737ede8ff0a669a9a9229196a76b43b46b6 src/test/python/apache/aurora/client/cli/test_plugins.py aa45851bd26f78583e0c16d0c3699c12f8a58697 src/test/python/apache/aurora/client/cli/test_restart.py a532ead256869c620e6bd96886ce9681b3423d0c src/test/python/apache/aurora/client/cli/test_supdate.py 9378b49ec5e4bb8189b00d9fd1d80558a731d668 src/test/python/apache/aurora/client/cli/test_update.py c12b32e3327af8c014fdad72d63ab4e68dc541c8 src/test/python/apache/aurora/client/cli/util.py 147d418ea1de679674dd93eaf648d84686b95d37 Diff: https://reviews.apache.org/r/29873/diff/ Testing --- ./pants src/test/python:all vagrant@vagrant-ubuntu-trusty-64:~$ aurora job killall devcluster/www-data/prod/hello INFO] Checking status of devcluster/www-data/prod/hello INFO] No tasks to kill found for job devcluster/www-data/prod/hello Job killall succeeded Thanks, Maxim Khutornenko
Re: Review Request 28920: Add support for docker containers to aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68350 --- Master (1acb428) is red with this patch. ./build-support/jenkins/build.sh Note: Recompile with -Xlint:unchecked for details. :api:checkPython :api:generateThriftEntitiesJava :api:classesThriftEntities :api:compileJava UP-TO-DATE :api:generateThriftResources :api:processResources UP-TO-DATE :api:classes :api:jar :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2 :processResources :classes :jar :assemble :compileJmhJavawarning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source '1.7' 1 warning :processJmhResources UP-TO-DATE :jmhClasses :checkstyleJmh :jsHint 'Mode' is defined but never used. (/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/resources/scheduler/assets/js/services.js:18:51) JobUpdateStatus: false, Mode: false */ :jsHint FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':jsHint'. Process 'command '/home/jenkins/tools/java/jdk1.7.0_25-32/bin/java'' finished with non-zero exit value 2 * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 1 mins 31.514 secs I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 15, 2015, 8:24 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 15, 2015, 8:24 p.m.) Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner. Bugs: AURORA-633 https://issues.apache.org/jira/browse/AURORA-633 Repository: aurora Description --- This change adds support for launching docker containers through aurora. These changes are based off of the discussion in https://issues.apache.org/jira/browse/AURORA-633 As of now, a special thermos_executor.sh script is needed to launch the executor inside docker containers. A sample aurora file is in examples/jobs/docker. In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the example upstart config in examples/vagrant/upstart has been updated to reflect this. More information is in subsequent review request comments. Diffs - Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 08ba1cdf88b712de22c26c04443079282db59ef9 config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5 docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 examples/jobs/docker/hello_docker.aurora PRE-CREATION examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 examples/vagrant/upstart/mesos-slave.conf 512ce7ecf34042ed68dda55efb2dd0415f8469db src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 5226e3d1b303b1773a057078f2911c5ec2aa97f5 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 01b03508afac37b5a8f0ec5c3da1460695e1ef59 src/main/java/org/apache/aurora/scheduler/configuration/ContainerType.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 5bf283062c9d119ff91ed45da8b236e36d0fc9aa src/main/python/apache/aurora/config/thrift.py ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c src/main/python/apache/aurora/executor/aurora_executor.py 636b23d30a897b557eb8c3f8733c90b23cb807ef src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f7d8977e42aa56188799400bf8e12a6886fb4a8f src/main/python/apache/aurora/executor/common/sandbox.py f47a32b3fefb4a89940b1ddc473b8316ac00df12 src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448 src/main/python/apache/thermos/config/schema_base.py f9143cc1b83143d6147f59d90c79435d055d0518 src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3
Re: Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 11:58 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- rebase Repository: aurora Description --- Updates so client will run in PyCharm. Diffs (updated) - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 29901: De-flakify resource_manager_integration test
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29901/#review68364
---
Master (b75ed0f) is red with this patch.
./build-support/jenkins/build.sh
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_builder.py,
line 43, in build
debug=debug).run()
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
line 88, in run
rv = self._run_tests([target], stdout, stderr)
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
line 316, in _run_tests
with self._test_runner(targets, stdout, stderr) as (pex, test_args):
File /usr/lib/python2.7/contextlib.py, line 17, in __enter__
return self.gen.next()
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
line 295, in _test_runner
builder = chroot.dump()
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py,
line 191, in dump
conn_timeout=self._conn_timeout)
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/resolver.py,
line 100, in resolve_multi
platform=platform)
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py,
line 101, in resolve
raise Unsatisfiable('Cannot satisfy requirements: %s' %
requirement_set[requirement.key])
Unsatisfiable: Cannot satisfy requirements:
[Requirement.parse('coverage=3.7.1,4.0a1')]
Usage:
pants build (options) [spec] (build args)
pants build (options) [spec]... -- (build args)
Options:
--version show program's version number and exit
--no-pantsrc Specifies that pantsrc files should be ignored.
--log-exitLog an exit message on success or failure.
-t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
Number of seconds to wait for http connections.
-i INTERPRETERS, --interpreter=INTERPRETERS
Constrain what Python interpreters to use. Uses
Requirement format from pkg_resources, e.g.
'CPython=2.6,3' or 'PyPy'. By default, no
constraints are used. Multiple constraints may be
added. They will be ORed together.
-v, --verbose Show verbose output.
-f, --fastRun tests in a single chroot.
Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.
I will refresh this build result if you post a review containing @ReviewBot
retry
- Aurora ReviewBot
On Jan. 15, 2015, 11:36 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29901/
---
(Updated Jan. 15, 2015, 11:36 p.m.)
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
---
De-flakify ResourceManager integration test.
Diffs
-
src/main/python/apache/aurora/executor/common/resource_manager.py
bf69e7e60ae4dd857243d8b040a70daca008ea28
src/main/python/apache/thermos/monitoring/resource.py
7b5bbe01810008c4d39b9dfee6521af01021a7ca
src/test/python/apache/aurora/executor/common/BUILD
395ced27998def18eace2cbd46c736404c3d6411
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
e3c766f9b7bf989c0790281231957947d2cda52a
Diff: https://reviews.apache.org/r/29901/diff/
Testing
---
./pants goal test --no-test-pytest-fast
src/test/python/apache/aurora/executor/common::
Thanks,
Brian Wickman
Re: Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68365 --- This patch does not apply cleanly on master (b75ed0f), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 15, 2015, 11:58 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 11:58 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 28920: Add support for docker containers to aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 16, 2015, 12:08 a.m.) Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner. Bugs: AURORA-633 https://issues.apache.org/jira/browse/AURORA-633 Repository: aurora Description --- This change adds support for launching docker containers through aurora. These changes are based off of the discussion in https://issues.apache.org/jira/browse/AURORA-633 As of now, a special thermos_executor.sh script is needed to launch the executor inside docker containers. A sample aurora file is in examples/jobs/docker. In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the example upstart config in examples/vagrant/upstart has been updated to reflect this. More information is in subsequent review request comments. Diffs (updated) - Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 08ba1cdf88b712de22c26c04443079282db59ef9 config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5 docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 examples/jobs/docker/hello_docker.aurora PRE-CREATION examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 examples/vagrant/upstart/mesos-slave.conf 512ce7ecf34042ed68dda55efb2dd0415f8469db src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 5226e3d1b303b1773a057078f2911c5ec2aa97f5 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 01b03508afac37b5a8f0ec5c3da1460695e1ef59 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 5bf283062c9d119ff91ed45da8b236e36d0fc9aa src/main/python/apache/aurora/config/thrift.py ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c src/main/python/apache/aurora/executor/aurora_executor.py 636b23d30a897b557eb8c3f8733c90b23cb807ef src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f7d8977e42aa56188799400bf8e12a6886fb4a8f src/main/python/apache/aurora/executor/common/sandbox.py f47a32b3fefb4a89940b1ddc473b8316ac00df12 src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448 src/main/python/apache/thermos/config/schema_base.py f9143cc1b83143d6147f59d90c79435d055d0518 src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3 src/main/resources/scheduler/assets/configSummary.html 28878908b0c9381e366b71a3135dfc28c542a890 src/main/resources/scheduler/assets/js/services.js b744f375411e09b7f776e4a05ee5961227143439 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 5e54364a49a208bd5f19b9649633dc8feca591e9 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java dc2cb37adf32df0a6e4c7ee2ba776ba9f1f3c2f8 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 7eafe074b686d55ad96018006cf4acfa823513c3 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java ad9126c32893080e128d086ea3bfd7ad23d27b89 src/test/python/apache/aurora/client/cli/test_status.py e531fa06e508d9792af51c62e67120c21baa7a81 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz
Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 29901: De-flakify resource_manager_integration test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/ --- (Updated Jan. 16, 2015, 12:51 a.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Changes --- Address Kevin's feedback. Repository: aurora Description --- De-flakify ResourceManager integration test. Diffs (updated) - src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/main/python/apache/thermos/monitoring/resource.py 7b5bbe01810008c4d39b9dfee6521af01021a7ca src/test/python/apache/aurora/executor/common/BUILD 395ced27998def18eace2cbd46c736404c3d6411 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a Diff: https://reviews.apache.org/r/29901/diff/ Testing --- ./pants goal test --no-test-pytest-fast src/test/python/apache/aurora/executor/common:: Thanks, Brian Wickman
Re: Review Request 29901: De-flakify resource_manager_integration test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/#review68378 --- Ship it! Master (b75ed0f) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 16, 2015, 12:51 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29901/ --- (Updated Jan. 16, 2015, 12:51 a.m.) Review request for Aurora, Joshua Cohen and Kevin Sweeney. Repository: aurora Description --- De-flakify ResourceManager integration test. Diffs - src/main/python/apache/aurora/executor/common/resource_manager.py bf69e7e60ae4dd857243d8b040a70daca008ea28 src/main/python/apache/thermos/monitoring/resource.py 7b5bbe01810008c4d39b9dfee6521af01021a7ca src/test/python/apache/aurora/executor/common/BUILD 395ced27998def18eace2cbd46c736404c3d6411 src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py e3c766f9b7bf989c0790281231957947d2cda52a Diff: https://reviews.apache.org/r/29901/diff/ Testing --- ./pants goal test --no-test-pytest-fast src/test/python/apache/aurora/executor/common:: Thanks, Brian Wickman
Re: Review Request 28920: Add support for docker containers to aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68237 --- Ship it! Master (a350982) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 14, 2015, 8:20 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 14, 2015, 8:20 p.m.) Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner. Bugs: AURORA-633 https://issues.apache.org/jira/browse/AURORA-633 Repository: aurora Description --- This change adds support for launching docker containers through aurora. These changes are based off of the discussion in https://issues.apache.org/jira/browse/AURORA-633 As of now, a special thermos_executor.sh script is needed to launch the executor inside docker containers. A sample aurora file is in examples/jobs/docker. In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the example upstart config in examples/vagrant/upstart has been updated to reflect this. More information is in subsequent review request comments. Diffs - Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 08ba1cdf88b712de22c26c04443079282db59ef9 config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5 docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 examples/jobs/docker/hello_docker.aurora PRE-CREATION examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 examples/vagrant/upstart/mesos-slave.conf 512ce7ecf34042ed68dda55efb2dd0415f8469db src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 5226e3d1b303b1773a057078f2911c5ec2aa97f5 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 01b03508afac37b5a8f0ec5c3da1460695e1ef59 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 5bf283062c9d119ff91ed45da8b236e36d0fc9aa src/main/python/apache/aurora/config/thrift.py ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c src/main/python/apache/aurora/executor/aurora_executor.py 636b23d30a897b557eb8c3f8733c90b23cb807ef src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f7d8977e42aa56188799400bf8e12a6886fb4a8f src/main/python/apache/aurora/executor/common/sandbox.py f47a32b3fefb4a89940b1ddc473b8316ac00df12 src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448 src/main/python/apache/thermos/config/schema_base.py f9143cc1b83143d6147f59d90c79435d055d0518 src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3 src/main/resources/scheduler/assets/configSummary.html 28878908b0c9381e366b71a3135dfc28c542a890 src/main/resources/scheduler/assets/js/services.js b744f375411e09b7f776e4a05ee5961227143439 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 5e54364a49a208bd5f19b9649633dc8feca591e9 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java dc2cb37adf32df0a6e4c7ee2ba776ba9f1f3c2f8 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 28920: Add support for docker containers to aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68232 --- Ship it! Master (a350982) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 14, 2015, 8:20 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 14, 2015, 8:20 p.m.) Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner. Bugs: AURORA-633 https://issues.apache.org/jira/browse/AURORA-633 Repository: aurora Description --- This change adds support for launching docker containers through aurora. These changes are based off of the discussion in https://issues.apache.org/jira/browse/AURORA-633 As of now, a special thermos_executor.sh script is needed to launch the executor inside docker containers. A sample aurora file is in examples/jobs/docker. In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the example upstart config in examples/vagrant/upstart has been updated to reflect this. More information is in subsequent review request comments. Diffs - Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 08ba1cdf88b712de22c26c04443079282db59ef9 config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5 docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 examples/jobs/docker/hello_docker.aurora PRE-CREATION examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 examples/vagrant/upstart/mesos-slave.conf 512ce7ecf34042ed68dda55efb2dd0415f8469db src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 5226e3d1b303b1773a057078f2911c5ec2aa97f5 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 01b03508afac37b5a8f0ec5c3da1460695e1ef59 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 5bf283062c9d119ff91ed45da8b236e36d0fc9aa src/main/python/apache/aurora/config/thrift.py ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c src/main/python/apache/aurora/executor/aurora_executor.py 636b23d30a897b557eb8c3f8733c90b23cb807ef src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f7d8977e42aa56188799400bf8e12a6886fb4a8f src/main/python/apache/aurora/executor/common/sandbox.py f47a32b3fefb4a89940b1ddc473b8316ac00df12 src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448 src/main/python/apache/thermos/config/schema_base.py f9143cc1b83143d6147f59d90c79435d055d0518 src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3 src/main/resources/scheduler/assets/configSummary.html 28878908b0c9381e366b71a3135dfc28c542a890 src/main/resources/scheduler/assets/js/services.js b744f375411e09b7f776e4a05ee5961227143439 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 5e54364a49a208bd5f19b9649633dc8feca591e9 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java dc2cb37adf32df0a6e4c7ee2ba776ba9f1f3c2f8 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 28920: Add support for docker containers to aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68223
---
Master (a350982) is red with this patch.
./build-support/jenkins/build.sh
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_builder.py,
line 43, in build
debug=debug).run()
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
line 88, in run
rv = self._run_tests([target], stdout, stderr)
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
line 316, in _run_tests
with self._test_runner(targets, stdout, stderr) as (pex, test_args):
File /usr/lib/python2.7/contextlib.py, line 17, in __enter__
return self.gen.next()
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
line 295, in _test_runner
builder = chroot.dump()
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py,
line 191, in dump
conn_timeout=self._conn_timeout)
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/resolver.py,
line 100, in resolve_multi
platform=platform)
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py,
line 101, in resolve
raise Unsatisfiable('Cannot satisfy requirements: %s' %
requirement_set[requirement.key])
Unsatisfiable: Cannot satisfy requirements:
[Requirement.parse('coverage=3.7.1,4.0a1')]
Usage:
pants build (options) [spec] (build args)
pants build (options) [spec]... -- (build args)
Options:
--version show program's version number and exit
--no-pantsrc Specifies that pantsrc files should be ignored.
--log-exitLog an exit message on success or failure.
-t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
Number of seconds to wait for http connections.
-i INTERPRETERS, --interpreter=INTERPRETERS
Constrain what Python interpreters to use. Uses
Requirement format from pkg_resources, e.g.
'CPython=2.6,3' or 'PyPy'. By default, no
constraints are used. Multiple constraints may be
added. They will be ORed together.
-v, --verbose Show verbose output.
-f, --fastRun tests in a single chroot.
Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.
I will refresh this build result if you post a review containing @ReviewBot
retry
- Aurora ReviewBot
On Jan. 14, 2015, 8:20 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 14, 2015, 8:20 p.m.)
Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-633
https://issues.apache.org/jira/browse/AURORA-633
Repository: aurora
Description
---
This change adds support for launching docker containers through aurora.
These changes are based off of the discussion in
https://issues.apache.org/jira/browse/AURORA-633
As of now, a special thermos_executor.sh script is needed to launch the
executor inside docker containers. A sample aurora file is in
examples/jobs/docker.
In addition, mesos-slave must be run with `--containerizers=docker,mesos`,
the example upstart config in examples/vagrant/upstart has been updated to
reflect this.
More information is in subsequent review request comments.
Diffs
-
Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc
api/src/main/thrift/org/apache/aurora/gen/api.thrift
08ba1cdf88b712de22c26c04443079282db59ef9
config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5
docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea
docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7
examples/jobs/docker/hello_docker.aurora PRE-CREATION
examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd
examples/vagrant/provision-dev-cluster.sh
7af4b52a6876268a97630279221bb98d9b04efad
examples/vagrant/upstart/aurora-scheduler.conf
788ec254270bca074dae91829c7f4fccdc8f8bb0
examples/vagrant/upstart/mesos-slave.conf
Re: Review Request 28920: Add support for docker containers to aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68239
---
Master (a350982) is red with this patch.
./build-support/jenkins/build.sh
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
line 88, in run
rv = self._run_tests([target], stdout, stderr)
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
line 316, in _run_tests
with self._test_runner(targets, stdout, stderr) as (pex, test_args):
File /usr/lib/python2.7/contextlib.py, line 17, in __enter__
return self.gen.next()
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py,
line 295, in _test_runner
builder = chroot.dump()
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py,
line 191, in dump
conn_timeout=self._conn_timeout)
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/resolver.py,
line 100, in resolve_multi
platform=platform)
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py,
line 110, in resolve
new_requirements.update(requires(highest_package, requirement))
File
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py,
line 84, in requires
raise Untranslateable('Package %s is not translateable.' % package)
Untranslateable: Package
SourcePackage(u'https://pypi.python.org/packages/source/t/twitter.common.rpc/twitter.common.rpc-0.3.2.tar.gz#md5=acf6d28f63bbdfdf9c4ddb1423883da2')
is not translateable.
Usage:
pants build (options) [spec] (build args)
pants build (options) [spec]... -- (build args)
Options:
--version show program's version number and exit
--no-pantsrc Specifies that pantsrc files should be ignored.
--log-exitLog an exit message on success or failure.
-t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
Number of seconds to wait for http connections.
-i INTERPRETERS, --interpreter=INTERPRETERS
Constrain what Python interpreters to use. Uses
Requirement format from pkg_resources, e.g.
'CPython=2.6,3' or 'PyPy'. By default, no
constraints are used. Multiple constraints may be
added. They will be ORed together.
-v, --verbose Show verbose output.
-f, --fastRun tests in a single chroot.
Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.
I will refresh this build result if you post a review containing @ReviewBot
retry
- Aurora ReviewBot
On Jan. 14, 2015, 8:20 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/
---
(Updated Jan. 14, 2015, 8:20 p.m.)
Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-633
https://issues.apache.org/jira/browse/AURORA-633
Repository: aurora
Description
---
This change adds support for launching docker containers through aurora.
These changes are based off of the discussion in
https://issues.apache.org/jira/browse/AURORA-633
As of now, a special thermos_executor.sh script is needed to launch the
executor inside docker containers. A sample aurora file is in
examples/jobs/docker.
In addition, mesos-slave must be run with `--containerizers=docker,mesos`,
the example upstart config in examples/vagrant/upstart has been updated to
reflect this.
More information is in subsequent review request comments.
Diffs
-
Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc
api/src/main/thrift/org/apache/aurora/gen/api.thrift
08ba1cdf88b712de22c26c04443079282db59ef9
config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5
docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea
docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7
examples/jobs/docker/hello_docker.aurora PRE-CREATION
examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd
examples/vagrant/provision-dev-cluster.sh
7af4b52a6876268a97630279221bb98d9b04efad
examples/vagrant/upstart/aurora-scheduler.conf
Re: Review Request 28920: Add support for docker containers to aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68241 --- Ship it! Master (a350982) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 14, 2015, 8:20 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 14, 2015, 8:20 p.m.) Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner. Bugs: AURORA-633 https://issues.apache.org/jira/browse/AURORA-633 Repository: aurora Description --- This change adds support for launching docker containers through aurora. These changes are based off of the discussion in https://issues.apache.org/jira/browse/AURORA-633 As of now, a special thermos_executor.sh script is needed to launch the executor inside docker containers. A sample aurora file is in examples/jobs/docker. In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the example upstart config in examples/vagrant/upstart has been updated to reflect this. More information is in subsequent review request comments. Diffs - Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 08ba1cdf88b712de22c26c04443079282db59ef9 config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5 docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 examples/jobs/docker/hello_docker.aurora PRE-CREATION examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 examples/vagrant/upstart/mesos-slave.conf 512ce7ecf34042ed68dda55efb2dd0415f8469db src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 5226e3d1b303b1773a057078f2911c5ec2aa97f5 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 01b03508afac37b5a8f0ec5c3da1460695e1ef59 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 5bf283062c9d119ff91ed45da8b236e36d0fc9aa src/main/python/apache/aurora/config/thrift.py ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c src/main/python/apache/aurora/executor/aurora_executor.py 636b23d30a897b557eb8c3f8733c90b23cb807ef src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f7d8977e42aa56188799400bf8e12a6886fb4a8f src/main/python/apache/aurora/executor/common/sandbox.py f47a32b3fefb4a89940b1ddc473b8316ac00df12 src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448 src/main/python/apache/thermos/config/schema_base.py f9143cc1b83143d6147f59d90c79435d055d0518 src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3 src/main/resources/scheduler/assets/configSummary.html 28878908b0c9381e366b71a3135dfc28c542a890 src/main/resources/scheduler/assets/js/services.js b744f375411e09b7f776e4a05ee5961227143439 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 5e54364a49a208bd5f19b9649633dc8feca591e9 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java dc2cb37adf32df0a6e4c7ee2ba776ba9f1f3c2f8 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 28920: Add support for docker containers to aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68245 --- Ship it! Master (a350982) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 14, 2015, 8:20 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 14, 2015, 8:20 p.m.) Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner. Bugs: AURORA-633 https://issues.apache.org/jira/browse/AURORA-633 Repository: aurora Description --- This change adds support for launching docker containers through aurora. These changes are based off of the discussion in https://issues.apache.org/jira/browse/AURORA-633 As of now, a special thermos_executor.sh script is needed to launch the executor inside docker containers. A sample aurora file is in examples/jobs/docker. In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the example upstart config in examples/vagrant/upstart has been updated to reflect this. More information is in subsequent review request comments. Diffs - Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 08ba1cdf88b712de22c26c04443079282db59ef9 config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5 docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 examples/jobs/docker/hello_docker.aurora PRE-CREATION examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 examples/vagrant/upstart/mesos-slave.conf 512ce7ecf34042ed68dda55efb2dd0415f8469db src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 5226e3d1b303b1773a057078f2911c5ec2aa97f5 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 01b03508afac37b5a8f0ec5c3da1460695e1ef59 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 5bf283062c9d119ff91ed45da8b236e36d0fc9aa src/main/python/apache/aurora/config/thrift.py ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c src/main/python/apache/aurora/executor/aurora_executor.py 636b23d30a897b557eb8c3f8733c90b23cb807ef src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f7d8977e42aa56188799400bf8e12a6886fb4a8f src/main/python/apache/aurora/executor/common/sandbox.py f47a32b3fefb4a89940b1ddc473b8316ac00df12 src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448 src/main/python/apache/thermos/config/schema_base.py f9143cc1b83143d6147f59d90c79435d055d0518 src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3 src/main/resources/scheduler/assets/configSummary.html 28878908b0c9381e366b71a3135dfc28c542a890 src/main/resources/scheduler/assets/js/services.js b744f375411e09b7f776e4a05ee5961227143439 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 5e54364a49a208bd5f19b9649633dc8feca591e9 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java dc2cb37adf32df0a6e4c7ee2ba776ba9f1f3c2f8 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz
Re: Review Request 29942: Updates so client will run in PyCharm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68307 --- Ship it! Ship It! - Kevin Sweeney On Jan. 15, 2015, 11:56 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/ --- (Updated Jan. 15, 2015, 11:56 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Updates so client will run in PyCharm. Diffs - docs/developing-aurora-client.md a7253d2beba61f7aca94bab944f544b969f507fd docs/images/debug-client-test.png PRE-CREATION docs/images/debugging-client-test.png PRE-CREATION examples/vagrant/clusters.json PRE-CREATION examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad src/main/python/apache/aurora/client/cli/__init__.py a59594855bb82c1b4d1d28dfa2e1ac2d66aeb569 Diff: https://reviews.apache.org/r/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen
Re: Review Request 28920: Add support for docker containers to aurora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68377 --- Ship it! Master (b75ed0f) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Jan. 16, 2015, 12:08 a.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 16, 2015, 12:08 a.m.) Review request for Aurora, Jay Buffington, Kevin Sweeney, and Bill Farner. Bugs: AURORA-633 https://issues.apache.org/jira/browse/AURORA-633 Repository: aurora Description --- This change adds support for launching docker containers through aurora. These changes are based off of the discussion in https://issues.apache.org/jira/browse/AURORA-633 As of now, a special thermos_executor.sh script is needed to launch the executor inside docker containers. A sample aurora file is in examples/jobs/docker. In addition, mesos-slave must be run with `--containerizers=docker,mesos`, the example upstart config in examples/vagrant/upstart has been updated to reflect this. More information is in subsequent review request comments. Diffs - Vagrantfile f8b7db8eebdc6a10989de3bc9a2c3e89ce17f5fc api/src/main/thrift/org/apache/aurora/gen/api.thrift 08ba1cdf88b712de22c26c04443079282db59ef9 config/legacy_untested_classes.txt 33c1d6eb4ea02e01b7002c2c2bae5a3858c8b0e5 docs/configuration-reference.md f3cb257206a194b82fd2045dc20456ee832dbcea docs/deploying-aurora-scheduler.md 711ae7eda07c2c1735601c265c06a88c1862cce7 examples/jobs/docker/hello_docker.aurora PRE-CREATION examples/vagrant/aurorabuild.sh 1e31f21998d02fd69ce0db88e6adb3d32cff67fd examples/vagrant/provision-dev-cluster.sh 7af4b52a6876268a97630279221bb98d9b04efad examples/vagrant/upstart/aurora-scheduler.conf 788ec254270bca074dae91829c7f4fccdc8f8bb0 examples/vagrant/upstart/mesos-slave.conf 512ce7ecf34042ed68dda55efb2dd0415f8469db src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 5226e3d1b303b1773a057078f2911c5ec2aa97f5 src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java d885b224ec5a1d529347d84e03ba98ab6734a126 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 01b03508afac37b5a8f0ec5c3da1460695e1ef59 src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 5bf283062c9d119ff91ed45da8b236e36d0fc9aa src/main/python/apache/aurora/config/thrift.py ba94ac3c0cbaf3c91eb1a1d86a244ed6fa3b649c src/main/python/apache/aurora/executor/aurora_executor.py 636b23d30a897b557eb8c3f8733c90b23cb807ef src/main/python/apache/aurora/executor/bin/thermos_executor_main.py f7d8977e42aa56188799400bf8e12a6886fb4a8f src/main/python/apache/aurora/executor/common/sandbox.py f47a32b3fefb4a89940b1ddc473b8316ac00df12 src/main/python/apache/aurora/executor/thermos_task_runner.py 5e4bd65537d186459003c0b9434f1b769e04f448 src/main/python/apache/thermos/config/schema_base.py f9143cc1b83143d6147f59d90c79435d055d0518 src/main/python/apache/thermos/core/runner.py 8aac6b50c66080abbb5308b367e9f74c487f42e3 src/main/resources/scheduler/assets/configSummary.html 28878908b0c9381e366b71a3135dfc28c542a890 src/main/resources/scheduler/assets/js/services.js b744f375411e09b7f776e4a05ee5961227143439 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 5e54364a49a208bd5f19b9649633dc8feca591e9 src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java dc2cb37adf32df0a6e4c7ee2ba776ba9f1f3c2f8 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 7eafe074b686d55ad96018006cf4acfa823513c3 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java ad9126c32893080e128d086ea3bfd7ad23d27b89 src/test/python/apache/aurora/client/cli/test_status.py e531fa06e508d9792af51c62e67120c21baa7a81 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz
