date:20150227

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/
---

(Updated Feb. 27, 2015, 4:49 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Updated javascript API usages.


Bugs: AURORA-1093
https://issues.apache.org/jira/browse/AURORA-1093


Repository: aurora


Description (updated)
---

Update thrift API and internal code to use JobUpdateSummary.key rather than job 
key and id.

Note: This change will leave the client in a broken state w.r.t. the scheduler. 
 I will hold commiting this change until i have another review ready to go that 
updates the client.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
6a00ce2c30ce24851560c4d499c395194dbeed16 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
8444d225e91c75e9a571049d28af7264b6d2d017 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
6ade817284b4c0607fe1ff09ad61ea47768f7297 
  src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
  src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
06de5384182f84f973a28e312c0dc4329f593dad 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
b9dce16fa705fc14b5af394f8edb6301c789aff4 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
56398f33206cfa1fa45601a21760c7e23e2616bf 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
d1bd3c975b2057b46597f38555c2a73d14835600 
  src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
b8c919585307e27f154782ee179153165458bed7 
  src/main/python/apache/aurora/client/api/__init__.py 
07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
  src/main/python/apache/aurora/client/cli/context.py 
ea64010ab20c1292fb3fd1f5eb71394b7c965743 
  src/main/python/apache/aurora/client/cli/update.py 
bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
 c08f09a511e1fc631abdae50630b8b7ab10a440b 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
  src/main/resources/scheduler/assets/breadcrumb.html 
b5f82ca120d3b76b63a61628437525cec8870015 
  src/main/resources/scheduler/assets/job.html 
4a00a8863d676f168fbfce9f45ec4bad0244199f 
  src/main/resources/scheduler/assets/js/controllers.js 
092e7d5df2121f45f99f5a788187d52bebb7e5dd 
  src/main/resources/scheduler/assets/js/services.js 
87eef8c689ac2c2e8b6aae5c91ba7b0e3b353efd 
  src/main/resources/scheduler/assets/latestUpdates.html 
9844edadbdea1c123b1c0afea87dd94664f93f37 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
b79b07c23e00fab524aef21481070c5f09c9fa18 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 
81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
e969b972806bef9aa67729c8a35283df6145e687 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
2405bb8ad379e355a7987e9bb4163e1693f18777 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
3ba6274b97393ac2228d3eac8ba1615cb57014f8 
  src/test/python/apache/aurora/client/api/test_api.py 
ff1aff2eac391f219bc7c2483a16e35f916a224c 
  src/test/python/apache/aurora/client/cli/test_status.py 
1f39aa1c50a41e174804751b4cce25b96b6aebed 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
6413c0db20db5914c7b1537da2bbc6e110705dc2 

Diff: https://reviews.apache.org/r/31388/diff/


Testing (updated)
---

Manually :-( verified javascript changes by performing an async update in 
vagrant and viewing relevant pages.


Thanks,

Bill Farner

Re: Review Request 31334: Fixing cron update quota checking.

2015-02-27 Thread Bill Farner



> On Feb. 24, 2015, 1:48 a.m., Aurora ReviewBot wrote:
> > This patch does not apply cleanly on master (19378c1), do you need to 
> > rebase?
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"

Maxim, can you rebase?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/#review73739
---


On Feb. 24, 2015, 1:18 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31334/
> ---
> 
> (Updated Feb. 24, 2015, 1:18 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-1134
> https://issues.apache.org/jira/browse/AURORA-1134
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cron schedule updates were treated as template addition rather than 
> differential update, requiring extra quota capacity to clear the check.
> 
> Adding a new `checkCronUpdate()` QuotaManager interface method to correctly 
> handle cron job updates.
> 
> This will no apply cleanly, diffed against https://reviews.apache.org/r/31241/
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 934b92021d08ca23d95888683e9527ce37a8690a 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  2d21a976379631d11a498e7fcfd7cb6b800f3c15 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> b0772f73f1a21da5828660bfd7d2b1f6b15cbf74 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  06c8faa9de4d0ac8389dbf07d4e81934b503761b 
> 
> Diff: https://reviews.apache.org/r/31334/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74508
---

Ship it!


Ship It!

- Maxim Khutornenko


On Feb. 27, 2015, 4:49 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31388/
> ---
> 
> (Updated Feb. 27, 2015, 4:49 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Update thrift API and internal code to use JobUpdateSummary.key rather than 
> job key and id.
> 
> Note: This change will leave the client in a broken state w.r.t. the 
> scheduler.  I will hold commiting this change until i have another review 
> ready to go that updates the client.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 6a00ce2c30ce24851560c4d499c395194dbeed16 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8444d225e91c75e9a571049d28af7264b6d2d017 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> 6ade817284b4c0607fe1ff09ad61ea47768f7297 
>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
> 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
> d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 06de5384182f84f973a28e312c0dc4329f593dad 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> b9dce16fa705fc14b5af394f8edb6301c789aff4 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  56398f33206cfa1fa45601a21760c7e23e2616bf 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  d1bd3c975b2057b46597f38555c2a73d14835600 
>   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
> b8c919585307e27f154782ee179153165458bed7 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
>   src/main/python/apache/aurora/client/cli/context.py 
> ea64010ab20c1292fb3fd1f5eb71394b7c965743 
>   src/main/python/apache/aurora/client/cli/update.py 
> bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  c08f09a511e1fc631abdae50630b8b7ab10a440b 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
>   src/main/resources/scheduler/assets/breadcrumb.html 
> b5f82ca120d3b76b63a61628437525cec8870015 
>   src/main/resources/scheduler/assets/job.html 
> 4a00a8863d676f168fbfce9f45ec4bad0244199f 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 092e7d5df2121f45f99f5a788187d52bebb7e5dd 
>   src/main/resources/scheduler/assets/js/services.js 
> 87eef8c689ac2c2e8b6aae5c91ba7b0e3b353efd 
>   src/main/resources/scheduler/assets/latestUpdates.html 
> 9844edadbdea1c123b1c0afea87dd94664f93f37 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> b79b07c23e00fab524aef21481070c5f09c9fa18 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  e969b972806bef9aa67729c8a35283df6145e687 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 2405bb8ad379e355a7987e9bb4163e1693f18777 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 3ba6274b97393ac2228d3eac8ba1615cb57014f8 
>   src/test/python/apache/aurora/client/api/test_api.py 
> ff1aff2eac391f219bc7c2483a16e35f916a224c 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 1f39aa1c50a41e174804751b4cce25b96b6aebed 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 6413c0db20db5914c7b1537da2bbc6e110705dc2 
> 
> Diff: https://reviews.apache.org/r/31388/diff/
> 
> 
> Testing
> ---
> 
> Manually :-( verified javascript changes by performing an async update in 
> vagrant and viewing relevant pages.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74509
---


Master (766d1c9) is red with this patch.
  ./build-support/jenkins/build.sh

Note: Recompile with -Xlint:unchecked for details.

:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:compileJmhJavawarning: Supported source version 'RELEASE_6' from annotation 
processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source 
'1.7'
1 warning

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
'JobUpdateKey' is not defined. 
(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/resources/scheduler/assets/js/controllers.js:270:27)
> var updateKey = new JobUpdateKey();

:jsHint FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':jsHint'.
> Process 'command '/home/jenkins/tools/java/jdk1.7.0_25-32/bin/java'' finished 
> with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 33.519 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 4:49 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31388/
> ---
> 
> (Updated Feb. 27, 2015, 4:49 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Update thrift API and internal code to use JobUpdateSummary.key rather than 
> job key and id.
> 
> Note: This change will leave the client in a broken state w.r.t. the 
> scheduler.  I will hold commiting this change until i have another review 
> ready to go that updates the client.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 6a00ce2c30ce24851560c4d499c395194dbeed16 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8444d225e91c75e9a571049d28af7264b6d2d017 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> 6ade817284b4c0607fe1ff09ad61ea47768f7297 
>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
> 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
> d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 06de5384182f84f973a28e312c0dc4329f593dad 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> b9dce16fa705fc14b5af394f8edb6301c789aff4 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  56398f33206cfa1fa45601a21760c7e23e2616bf 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  d1bd3c975b2057b46597f38555c2a73d14835600 
>   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
> b8c919585307e27f154782ee179153165458bed7 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
>   src/main/python/apache/aurora/client/cli/context.py 
> ea64010ab20c1292fb3fd1f5eb71394b7c965743 
>   src/main/python/apache/aurora/client/cli/update.py 
> bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  c08f09a511e1fc631abdae50630b8b7ab10a440b 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
>   src/main/resources/scheduler/assets/breadcrumb.html 
> b5f82ca120d3b76b63a61628437525cec8870015 
>   src/main/resources/scheduler/assets/job.html 
> 4a00a8863d676f168fbfce9f45ec4bad0244199f 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 092e7d5df2121f45f99f5a788187d52bebb7e5dd 
>   src/main/resources/scheduler/assets/js/services.js 
> 87eef8c689ac2c2e8b6aae5c91ba7b0e3b353efd 
>   src/main/resources/scheduler/assets/latestUpdates.html 
> 9844edadbdea1c123b1c0afea87dd94664f93f37 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> b79b07c23e00fab524aef21481070c5f09c9fa18 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  81c8be7685854c47ed4a7c6d

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74507
---


Overall LGTM, all minor issues.


api/src/main/thrift/org/apache/aurora/gen/api.thrift


"The mode for a volume mount"



api/src/main/thrift/org/apache/aurora/gen/api.thrift


s/Describes a/A/



api/src/main/thrift/org/apache/aurora/gen/api.thrift


s/required //



src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java


Thanks!  This reads much better.



src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java


Consider making the 'empty' values defaults in the builder.



src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java



EnumSet.allOf(Mode.class)
```



src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java


should this be private?



src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java


remove extra newline



src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java


s/vp/parser/



src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java


Consider inlining.

```
assertEquals(
  new Volume(...),
  parser.doParse(...));
```



src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java


Can this instead be an exact comparison of List?  Presumably we 
should fail if other volumes show up.

```
assertEquals(
ImmutableList.of(expected),
taskInfo.getExecutor().getContainer().getVolumesList());
```


- Bill Farner


On Feb. 25, 2015, 10:35 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31338/
> ---
> 
> (Updated Feb. 25, 2015, 10:35 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington and Bill Farner.
> 
> 
> Bugs: AURORA-1107
> https://issues.apache.org/jira/browse/AURORA-1107
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added a command line flag, -global_container_mounts, to allow mounting paths 
> from the slaves into the (docker) containers they run.
> 
> This is the first portion of allowing per-job mounts, however, I wanted to 
> get this out first since more people want it.  I'll implement per-job mounts 
> in a future review.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 6f6124a4c844a1abcf07401d80c3e50eb8b4 
>   config/checkstyle/checkstyle.xml 580d9d3737c0f52da2d33f5b99ef9406b55c5807 
>   docs/deploying-aurora-scheduler.md d1123359961fd59ddb8c1a07f80f293bdd46019f 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> bacfbfeb237ecddf82f58679e05be012c5214e61 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 24b61c1e4f615295acf28d904588e1512972d3f4 
>   src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 
> baacb71403d55c5b90fc11cb2a23f552a32e8ba5 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 5340d651b298ec8aa079e73d6d2f652fdf876293 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 6575b7d420f17ec68d6e2a83e7b380f684577d4f 
>   src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 444d6d3fdaf86eb84612f846eaa326eb75c49898 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 
> efe62ceb502ead88a2f0cd6d09a76664e465d9bc 
> 
> Diff: https://reviews.apache.org/r/31338/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 31334: Fixing cron update quota checking.

2015-02-27 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/
---

(Updated Feb. 27, 2015, 5:14 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Rebased.


Bugs: AURORA-1134
https://issues.apache.org/jira/browse/AURORA-1134


Repository: aurora


Description
---

Cron schedule updates were treated as template addition rather than 
differential update, requiring extra quota capacity to clear the check.

Adding a new `checkCronUpdate()` QuotaManager interface method to correctly 
handle cron job updates.

This will no apply cleanly, diffed against https://reviews.apache.org/r/31241/


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
8444d225e91c75e9a571049d28af7264b6d2d017 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
56398f33206cfa1fa45601a21760c7e23e2616bf 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
b79b07c23e00fab524aef21481070c5f09c9fa18 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 d36418807ace4f61e8709a2827cea0e7bb8ac6b7 

Diff: https://reviews.apache.org/r/31334/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/
---

(Updated Feb. 27, 2015, 5:11 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

TIL how strict mode works.


Bugs: AURORA-1093
https://issues.apache.org/jira/browse/AURORA-1093


Repository: aurora


Description
---

Update thrift API and internal code to use JobUpdateSummary.key rather than job 
key and id.

Note: This change will leave the client in a broken state w.r.t. the scheduler. 
 I will hold commiting this change until i have another review ready to go that 
updates the client.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
6a00ce2c30ce24851560c4d499c395194dbeed16 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
8444d225e91c75e9a571049d28af7264b6d2d017 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
6ade817284b4c0607fe1ff09ad61ea47768f7297 
  src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
  src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
06de5384182f84f973a28e312c0dc4329f593dad 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
b9dce16fa705fc14b5af394f8edb6301c789aff4 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
56398f33206cfa1fa45601a21760c7e23e2616bf 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
d1bd3c975b2057b46597f38555c2a73d14835600 
  src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
b8c919585307e27f154782ee179153165458bed7 
  src/main/python/apache/aurora/client/api/__init__.py 
07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
  src/main/python/apache/aurora/client/cli/context.py 
ea64010ab20c1292fb3fd1f5eb71394b7c965743 
  src/main/python/apache/aurora/client/cli/update.py 
bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
 c08f09a511e1fc631abdae50630b8b7ab10a440b 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
  src/main/resources/scheduler/assets/breadcrumb.html 
b5f82ca120d3b76b63a61628437525cec8870015 
  src/main/resources/scheduler/assets/job.html 
4a00a8863d676f168fbfce9f45ec4bad0244199f 
  src/main/resources/scheduler/assets/js/controllers.js 
092e7d5df2121f45f99f5a788187d52bebb7e5dd 
  src/main/resources/scheduler/assets/js/services.js 
87eef8c689ac2c2e8b6aae5c91ba7b0e3b353efd 
  src/main/resources/scheduler/assets/latestUpdates.html 
9844edadbdea1c123b1c0afea87dd94664f93f37 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
b79b07c23e00fab524aef21481070c5f09c9fa18 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 
81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
e969b972806bef9aa67729c8a35283df6145e687 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
2405bb8ad379e355a7987e9bb4163e1693f18777 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
3ba6274b97393ac2228d3eac8ba1615cb57014f8 
  src/test/python/apache/aurora/client/api/test_api.py 
ff1aff2eac391f219bc7c2483a16e35f916a224c 
  src/test/python/apache/aurora/client/cli/test_status.py 
1f39aa1c50a41e174804751b4cce25b96b6aebed 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
6413c0db20db5914c7b1537da2bbc6e110705dc2 

Diff: https://reviews.apache.org/r/31388/diff/


Testing
---

Manually :-( verified javascript changes by performing an async update in 
vagrant and viewing relevant pages.


Thanks,

Bill Farner

Re: Review Request 31334: Fixing cron update quota checking.

2015-02-27 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/
---

(Updated Feb. 27, 2015, 5:15 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Updated description.


Bugs: AURORA-1134
https://issues.apache.org/jira/browse/AURORA-1134


Repository: aurora


Description (updated)
---

Cron schedule updates were treated as template addition rather than 
differential update, requiring extra quota capacity to clear the check.

Adding a new `checkCronUpdate()` QuotaManager interface method to correctly 
handle cron job updates.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
8444d225e91c75e9a571049d28af7264b6d2d017 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
56398f33206cfa1fa45601a21760c7e23e2616bf 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
b79b07c23e00fab524aef21481070c5f09c9fa18 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 d36418807ace4f61e8709a2827cea0e7bb8ac6b7 

Diff: https://reviews.apache.org/r/31334/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 31334: Fixing cron update quota checking.

2015-02-27 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/#review74512
---

Ship it!


Ship It!

- Bill Farner


On Feb. 27, 2015, 5:18 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31334/
> ---
> 
> (Updated Feb. 27, 2015, 5:18 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-1134
> https://issues.apache.org/jira/browse/AURORA-1134
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cron schedule updates were treated as template addition rather than 
> differential update, requiring extra quota capacity to clear the check.
> 
> Adding a new `checkCronUpdate()` QuotaManager interface method to correctly 
> handle cron job updates.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8444d225e91c75e9a571049d28af7264b6d2d017 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  56398f33206cfa1fa45601a21760c7e23e2616bf 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> b79b07c23e00fab524aef21481070c5f09c9fa18 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
> 
> Diff: https://reviews.apache.org/r/31334/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74513
---

Ship it!


Master (766d1c9) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 5:11 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31388/
> ---
> 
> (Updated Feb. 27, 2015, 5:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Update thrift API and internal code to use JobUpdateSummary.key rather than 
> job key and id.
> 
> Note: This change will leave the client in a broken state w.r.t. the 
> scheduler.  I will hold commiting this change until i have another review 
> ready to go that updates the client.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 6a00ce2c30ce24851560c4d499c395194dbeed16 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8444d225e91c75e9a571049d28af7264b6d2d017 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> 6ade817284b4c0607fe1ff09ad61ea47768f7297 
>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
> 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
> d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 06de5384182f84f973a28e312c0dc4329f593dad 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> b9dce16fa705fc14b5af394f8edb6301c789aff4 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  56398f33206cfa1fa45601a21760c7e23e2616bf 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  d1bd3c975b2057b46597f38555c2a73d14835600 
>   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
> b8c919585307e27f154782ee179153165458bed7 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
>   src/main/python/apache/aurora/client/cli/context.py 
> ea64010ab20c1292fb3fd1f5eb71394b7c965743 
>   src/main/python/apache/aurora/client/cli/update.py 
> bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  c08f09a511e1fc631abdae50630b8b7ab10a440b 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
>   src/main/resources/scheduler/assets/breadcrumb.html 
> b5f82ca120d3b76b63a61628437525cec8870015 
>   src/main/resources/scheduler/assets/job.html 
> 4a00a8863d676f168fbfce9f45ec4bad0244199f 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 092e7d5df2121f45f99f5a788187d52bebb7e5dd 
>   src/main/resources/scheduler/assets/js/services.js 
> 87eef8c689ac2c2e8b6aae5c91ba7b0e3b353efd 
>   src/main/resources/scheduler/assets/latestUpdates.html 
> 9844edadbdea1c123b1c0afea87dd94664f93f37 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> b79b07c23e00fab524aef21481070c5f09c9fa18 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  e969b972806bef9aa67729c8a35283df6145e687 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 2405bb8ad379e355a7987e9bb4163e1693f18777 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 3ba6274b97393ac2228d3eac8ba1615cb57014f8 
>   src/test/python/apache/aurora/client/api/test_api.py 
> ff1aff2eac391f219bc7c2483a16e35f916a224c 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 1f39aa1c50a41e174804751b4cce25b96b6aebed 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 6413c0db20db5914c7b1537da2bbc6e110705dc2 
> 
> Diff: https://reviews.apache.org/r/31388/diff/
> 
> 
> Testing
> ---
> 
> Manually :-( verified javascript changes by performing an async update in 
> vagrant and viewing relevant pages.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31508: Removing redundant scheduling loop in preemptor.

2015-02-27 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31508/#review74514
---

Ship it!


Context is that the removed code was attempting to mitigate a race where we 
preempt a task unnecessarily because new offers have arrived.  Given that 
preemption begins immediately after we have passed over the offers, this 
additional pass is redundant.  Additionally, the race still exists (an offer 
could arrive _right after_ we preempt), so the mitigation is of dubious value.

- Bill Farner


On Feb. 27, 2015, 12:04 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31508/
> ---
> 
> (Updated Feb. 27, 2015, 12:04 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1156
> https://issues.apache.org/jira/browse/AURORA-1156
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is #1 from the attached ticket. Brings anywhere between 2% and 18% 
> better perf in bechmark scenarios.
> 
> BEFORE:
> ```
> Benchmark 
>   Mode  Samples Score Error  Units
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
>   avgt  100909677.646 Â±   10103.466  ns/op
> o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100   1332768.205 Â±   16664.386  ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
>  avgt  100  69304405.590 Â± 1536571.317  ns/op
> o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100870348.707 Â±   16815.495  ns/op
> ```
> 
> AFTER:
> ```
> Benchmark 
>   Mode  Samples Score Error  Units
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
>   avgt  100749864.522 Â±6568.372  ns/op
> o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100   1125995.085 Â±   19241.796  ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
>  avgt  100  68028627.539 Â± 1412569.919  ns/op
> o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100766747.584 Â±   13310.142  ns/op
> ```
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 
> a4e8dd3b9b58dac2d8507042500b7a479d46ebc0 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  44cd8f79493f0f247cd876ef78b30b4f813314c4 
> 
> Diff: https://reviews.apache.org/r/31508/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jmh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31334: Fixing cron update quota checking.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/#review74515
---

Ship it!


Master (766d1c9) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 5:18 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31334/
> ---
> 
> (Updated Feb. 27, 2015, 5:18 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-1134
> https://issues.apache.org/jira/browse/AURORA-1134
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cron schedule updates were treated as template addition rather than 
> differential update, requiring extra quota capacity to clear the check.
> 
> Adding a new `checkCronUpdate()` QuotaManager interface method to correctly 
> handle cron job updates.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8444d225e91c75e9a571049d28af7264b6d2d017 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  56398f33206cfa1fa45601a21760c7e23e2616bf 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> b79b07c23e00fab524aef21481070c5f09c9fa18 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
> 
> Diff: https://reviews.apache.org/r/31334/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31493: Upgrading JMH plugin and framework versions.

2015-02-27 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31493/#review74516
---

Ship it!


Ship It!

- Bill Farner


On Feb. 26, 2015, 8:33 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31493/
> ---
> 
> (Updated Feb. 26, 2015, 8:33 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updating jmh plugin to 0.2.0: 
> https://github.com/melix/jmh-gradle-plugin/blob/master/CHANGELOG.txt
> 
> The most notable is the fix to support `jmhVersion` attribute that allowed to 
> bump up jmh version from 1.3.2 to current 1.6.1.
> 
> 
> JMH changelog: http://hg.openjdk.java.net/code-tools/jmh/
> 
> Among multiple improvements and stability fixes there is also 
> https://bugs.openjdk.java.net/browse/CODETOOLS-7901127 fix that gets rid of:  
> ```
> warning: Supported source version 'RELEASE_6' from annotation processor 
> 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source '1.7' 
> ```
> 
> Also, bumping up max heap size as some of bechmarks OOM occasionally (noticed 
> peak usage of 600Mb).
> 
> 
> Diffs
> -
> 
>   build.gradle 158d47ac273e75deb8cb1460281c84e85db4f248 
> 
> Diff: https://reviews.apache.org/r/31493/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jmh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 31546: Revert TARGET_PEOPLE change, this was applying to updates as well as new reviews.

2015-02-27 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31546/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

Revert TARGET_PEOPLE change, this was applying to updates as well as new 
reviews.


Diffs
-

  .reviewboardrc 415e2455660a14681f6fedde30f339f9f211e7f5 

Diff: https://reviews.apache.org/r/31546/diff/


Testing
---

Posted this review.


Thanks,

Joshua Cohen

Re: Review Request 31546: Revert TARGET_PEOPLE change, this was applying to updates as well as new reviews.

2015-02-27 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31546/#review74521
---

Ship it!


Ship It!

- Bill Farner


On Feb. 27, 2015, 5:57 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31546/
> ---
> 
> (Updated Feb. 27, 2015, 5:57 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Revert TARGET_PEOPLE change, this was applying to updates as well as new 
> reviews.
> 
> 
> Diffs
> -
> 
>   .reviewboardrc 415e2455660a14681f6fedde30f339f9f211e7f5 
> 
> Diff: https://reviews.apache.org/r/31546/diff/
> 
> 
> Testing
> ---
> 
> Posted this review.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 31547: Revert "Set default people for reviews."

2015-02-27 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31547/#review74522
---

Ship it!


Ship It!

- Bill Farner


On Feb. 27, 2015, 6:02 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31547/
> ---
> 
> (Updated Feb. 27, 2015, 6:02 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This reverts commit 766d1c9e3d52537be6985ab5eac32fcbe3df1ee2.
> 
> The TARGET_PEOPLE was applying on updates as well as new reviews. It looks 
> like from a reviewboard perspective the only way to accomplish default people 
> on new reviews is to use this functionality: 
> https://www.reviewboard.org/docs/manual/2.0/admin/configuration/default-reviewers/.
> 
> 
> Diffs
> -
> 
>   .reviewboardrc 415e2455660a14681f6fedde30f339f9f211e7f5 
> 
> Diff: https://reviews.apache.org/r/31547/diff/
> 
> 
> Testing
> ---
> 
> Posted this review.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Review Request 31547: Revert "Set default people for reviews."

2015-02-27 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31547/
---

Review request for Aurora.


Repository: aurora


Description
---

This reverts commit 766d1c9e3d52537be6985ab5eac32fcbe3df1ee2.

The TARGET_PEOPLE was applying on updates as well as new reviews. It looks like 
from a reviewboard perspective the only way to accomplish default people on new 
reviews is to use this functionality: 
https://www.reviewboard.org/docs/manual/2.0/admin/configuration/default-reviewers/.


Diffs
-

  .reviewboardrc 415e2455660a14681f6fedde30f339f9f211e7f5 

Diff: https://reviews.apache.org/r/31547/diff/


Testing
---

Posted this review.


Thanks,

Joshua Cohen

Re: Review Request 31546: Revert TARGET_PEOPLE change, this was applying to updates as well as new reviews.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31546/#review74526
---

Ship it!


Master (766d1c9) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 5:57 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31546/
> ---
> 
> (Updated Feb. 27, 2015, 5:57 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Revert TARGET_PEOPLE change, this was applying to updates as well as new 
> reviews.
> 
> 
> Diffs
> -
> 
>   .reviewboardrc 415e2455660a14681f6fedde30f339f9f211e7f5 
> 
> Diff: https://reviews.apache.org/r/31546/diff/
> 
> 
> Testing
> ---
> 
> Posted this review.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 31445: Expose more details about the tasks the preemptor is working for.

2015-02-27 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31445/#review74528
---

Ship it!


Ship It!

- Kevin Sweeney


On Feb. 25, 2015, 2:45 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31445/
> ---
> 
> (Updated Feb. 25, 2015, 2:45 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
> 
> 
> Bugs: AURORA-524
> https://issues.apache.org/jira/browse/AURORA-524
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Expose more details about the tasks the preemptor is working for.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 
> 42af883721e4e5c0ae23ff65a5fb7dc285e48faa 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  44cd8f79493f0f247cd876ef78b30b4f813314c4 
>   src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 
> 768e78424268513742ecea22b2f5395dcb46da8c 
> 
> Diff: https://reviews.apache.org/r/31445/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 31550: Add test coverage for MesosSchedulerImpl.

2015-02-27 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31550/
---

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

This brings MesosSchedulerImpl to 100% line and branch coverage.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
aa8aaad975bac513ce7734b4807a2f736b493e69 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
d621586abc8b0e20ffa6bd2c39aa92bd5512c3dd 

Diff: https://reviews.apache.org/r/31550/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 31550: Add test coverage for MesosSchedulerImpl.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31550/#review74536
---


Master (d1a1296) is red with this patch.
  ./build-support/jenkins/build.sh

 src.test.python.apache.aurora.client.cli.cron  
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.inspect   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.job   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.plugins   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.quota 
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.sla   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.supdate   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.task  
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.update
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.version   
 .   SUCCESS
 src.test.python.apache.aurora.client.config
 .   SUCCESS
 src.test.python.apache.aurora.client.factory   
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_aurora_job_key   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster_option   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_clusters 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 src.test.python.apache.aurora.common.test_pex_version  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_shellify 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_transport
 .   SUCCESS
 src.test.python.apache.aurora.config.test_base 
 .   SUCCESS
 
src.test.python.apache.aurora.config.test_constraint_parsing
.   SUCCESS
 src.test.python.apache.aurora.config.test_loader   
 .   SUCCESS
 src.test.python.apache.aurora.config.test_thrift   
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.path_detector 
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_base   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_vars   
 .   SUCCESS
 src.test.python.apache.aurora.executor.status_manager  
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_task_runner 
 .   FAILURE
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE

[31m
   FAILURE[0m


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 6:30 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31550/
> ---
> 
> (Updated Feb. 27, 2015, 6:30 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repos

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74543
---

Ship it!


Ship It!

- Zameer Manji


On Feb. 27, 2015, 9:54 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31388/
> ---
> 
> (Updated Feb. 27, 2015, 9:54 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Update thrift API and internal code to use JobUpdateSummary.key rather than 
> job key and id.
> 
> Note: This change will leave the client in a broken state w.r.t. the 
> scheduler.  I will hold commiting this change until i have another review 
> ready to go that updates the client.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 6a00ce2c30ce24851560c4d499c395194dbeed16 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8444d225e91c75e9a571049d28af7264b6d2d017 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> 6ade817284b4c0607fe1ff09ad61ea47768f7297 
>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
> 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
> d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 06de5384182f84f973a28e312c0dc4329f593dad 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> b9dce16fa705fc14b5af394f8edb6301c789aff4 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  56398f33206cfa1fa45601a21760c7e23e2616bf 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  d1bd3c975b2057b46597f38555c2a73d14835600 
>   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
> b8c919585307e27f154782ee179153165458bed7 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
>   src/main/python/apache/aurora/client/cli/context.py 
> ea64010ab20c1292fb3fd1f5eb71394b7c965743 
>   src/main/python/apache/aurora/client/cli/update.py 
> bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  c08f09a511e1fc631abdae50630b8b7ab10a440b 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
>   src/main/resources/scheduler/assets/breadcrumb.html 
> b5f82ca120d3b76b63a61628437525cec8870015 
>   src/main/resources/scheduler/assets/job.html 
> 4a00a8863d676f168fbfce9f45ec4bad0244199f 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 092e7d5df2121f45f99f5a788187d52bebb7e5dd 
>   src/main/resources/scheduler/assets/js/services.js 
> 87eef8c689ac2c2e8b6aae5c91ba7b0e3b353efd 
>   src/main/resources/scheduler/assets/latestUpdates.html 
> 9844edadbdea1c123b1c0afea87dd94664f93f37 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> b79b07c23e00fab524aef21481070c5f09c9fa18 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  e969b972806bef9aa67729c8a35283df6145e687 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 2405bb8ad379e355a7987e9bb4163e1693f18777 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> 3ba6274b97393ac2228d3eac8ba1615cb57014f8 
>   src/test/python/apache/aurora/client/api/test_api.py 
> ff1aff2eac391f219bc7c2483a16e35f916a224c 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 1f39aa1c50a41e174804751b4cce25b96b6aebed 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 6413c0db20db5914c7b1537da2bbc6e110705dc2 
> 
> Diff: https://reviews.apache.org/r/31388/diff/
> 
> 
> Testing
> ---
> 
> Manually :-( verified javascript changes by performing an async update in 
> vagrant and viewing relevant pages.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31508: Removing redundant scheduling loop in preemptor.

2015-02-27 Thread Zameer Manji



> On Feb. 27, 2015, 9:32 a.m., Bill Farner wrote:
> > Context is that the removed code was attempting to mitigate a race where we 
> > preempt a task unnecessarily because new offers have arrived.  Given that 
> > preemption begins immediately after we have passed over the offers, this 
> > additional pass is redundant.  Additionally, the race still exists (an 
> > offer could arrive _right after_ we preempt), so the mitigation is of 
> > dubious value.

Maxim, can you put this additional context in the commit message?


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31508/#review74514
---


On Feb. 26, 2015, 4:04 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31508/
> ---
> 
> (Updated Feb. 26, 2015, 4:04 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1156
> https://issues.apache.org/jira/browse/AURORA-1156
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is #1 from the attached ticket. Brings anywhere between 2% and 18% 
> better perf in bechmark scenarios.
> 
> BEFORE:
> ```
> Benchmark 
>   Mode  Samples Score Error  Units
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
>   avgt  100909677.646 Â±   10103.466  ns/op
> o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100   1332768.205 Â±   16664.386  ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
>  avgt  100  69304405.590 Â± 1536571.317  ns/op
> o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100870348.707 Â±   16815.495  ns/op
> ```
> 
> AFTER:
> ```
> Benchmark 
>   Mode  Samples Score Error  Units
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
>   avgt  100749864.522 Â±6568.372  ns/op
> o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100   1125995.085 Â±   19241.796  ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
>  avgt  100  68028627.539 Â± 1412569.919  ns/op
> o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100766747.584 Â±   13310.142  ns/op
> ```
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 
> a4e8dd3b9b58dac2d8507042500b7a479d46ebc0 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  44cd8f79493f0f247cd876ef78b30b4f813314c4 
> 
> Diff: https://reviews.apache.org/r/31508/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jmh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31508: Removing redundant scheduling loop in preemptor.

2015-02-27 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31508/#review74546
---

Ship it!


Ship It!

- Zameer Manji


On Feb. 26, 2015, 4:04 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31508/
> ---
> 
> (Updated Feb. 26, 2015, 4:04 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1156
> https://issues.apache.org/jira/browse/AURORA-1156
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is #1 from the attached ticket. Brings anywhere between 2% and 18% 
> better perf in bechmark scenarios.
> 
> BEFORE:
> ```
> Benchmark 
>   Mode  Samples Score Error  Units
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
>   avgt  100909677.646 Â±   10103.466  ns/op
> o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100   1332768.205 Â±   16664.386  ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
>  avgt  100  69304405.590 Â± 1536571.317  ns/op
> o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100870348.707 Â±   16815.495  ns/op
> ```
> 
> AFTER:
> ```
> Benchmark 
>   Mode  Samples Score Error  Units
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
>   avgt  100749864.522 Â±6568.372  ns/op
> o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100   1125995.085 Â±   19241.796  ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
>  avgt  100  68028627.539 Â± 1412569.919  ns/op
> o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100766747.584 Â±   13310.142  ns/op
> ```
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 
> a4e8dd3b9b58dac2d8507042500b7a479d46ebc0 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  44cd8f79493f0f247cd876ef78b30b4f813314c4 
> 
> Diff: https://reviews.apache.org/r/31508/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jmh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-27 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31525/#review74554
---



src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java


How about making score an EnumSet so that you can do a typesafe 
bitwise OR?


- Kevin Sweeney


On Feb. 26, 2015, 7:19 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31525/
> ---
> 
> (Updated Feb. 26, 2015, 7:19 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-1148
> https://issues.apache.org/jira/browse/AURORA-1148
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instead of relying on a fixed MAX_SCORE, vetoes are now graded by their 
> relative weight (severity) with a dedicated constraint mismatch ranked higest 
> and an insufficient resource mismatch - lowest. Together with "break early" 
> rule in SchedulingFilter, this ensures "heavier" vetoes are given proper 
> attention in the NearestFit. This simplifies `NearestFit` logic while also 
> improving pending reason reporting accuracy and scheduling performance.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 3313bd2f9ed5a88375d88715dea5da1e9ad8b963 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> a020ce50d578fba7f32b370f448a49eb1c284147 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> c3097e49c0f6588ea765aa4fab69dd35e3d90e8b 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  b00668423a53a8cf6f4da3456bce3354f1fd2424 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> 78a236c0f9074692b67ce18e6e03f18fe4529e02 
> 
> Diff: https://reviews.apache.org/r/31525/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31550: Add test coverage for MesosSchedulerImpl.

2015-02-27 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31550/#review74564
---


@ReviewBot retry

Flaky test is tracked at AURORA-1054

- Bill Farner


On Feb. 27, 2015, 6:30 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31550/
> ---
> 
> (Updated Feb. 27, 2015, 6:30 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings MesosSchedulerImpl to 100% line and branch coverage.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> aa8aaad975bac513ce7734b4807a2f736b493e69 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> d621586abc8b0e20ffa6bd2c39aa92bd5512c3dd 
> 
> Diff: https://reviews.apache.org/r/31550/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31550: Add test coverage for MesosSchedulerImpl.

2015-02-27 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31550/#review74566
---

Ship it!


Ship It!

- Maxim Khutornenko


On Feb. 27, 2015, 6:30 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31550/
> ---
> 
> (Updated Feb. 27, 2015, 6:30 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings MesosSchedulerImpl to 100% line and branch coverage.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> aa8aaad975bac513ce7734b4807a2f736b493e69 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> d621586abc8b0e20ffa6bd2c39aa92bd5512c3dd 
> 
> Diff: https://reviews.apache.org/r/31550/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31508: Removing redundant scheduling loop in preemptor.

2015-02-27 Thread Maxim Khutornenko



> On Feb. 27, 2015, 5:32 p.m., Bill Farner wrote:
> > Context is that the removed code was attempting to mitigate a race where we 
> > preempt a task unnecessarily because new offers have arrived.  Given that 
> > preemption begins immediately after we have passed over the offers, this 
> > additional pass is redundant.  Additionally, the race still exists (an 
> > offer could arrive _right after_ we preempt), so the mitigation is of 
> > dubious value.
> 
> Zameer Manji wrote:
> Maxim, can you put this additional context in the commit message?

Sure, will do.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31508/#review74514
---


On Feb. 27, 2015, 12:04 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31508/
> ---
> 
> (Updated Feb. 27, 2015, 12:04 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1156
> https://issues.apache.org/jira/browse/AURORA-1156
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is #1 from the attached ticket. Brings anywhere between 2% and 18% 
> better perf in bechmark scenarios.
> 
> BEFORE:
> ```
> Benchmark 
>   Mode  Samples Score Error  Units
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
>   avgt  100909677.646 Â±   10103.466  ns/op
> o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100   1332768.205 Â±   16664.386  ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
>  avgt  100  69304405.590 Â± 1536571.317  ns/op
> o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100870348.707 Â±   16815.495  ns/op
> ```
> 
> AFTER:
> ```
> Benchmark 
>   Mode  Samples Score Error  Units
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
>   avgt  100749864.522 Â±6568.372  ns/op
> o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100   1125995.085 Â±   19241.796  ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
>  avgt  100  68028627.539 Â± 1412569.919  ns/op
> o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100766747.584 Â±   13310.142  ns/op
> ```
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 
> a4e8dd3b9b58dac2d8507042500b7a479d46ebc0 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  44cd8f79493f0f247cd876ef78b30b4f813314c4 
> 
> Diff: https://reviews.apache.org/r/31508/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jmh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/
---

Review request for Aurora and Zameer Manji.


Bugs: AURORA-1020
https://issues.apache.org/jira/browse/AURORA-1020


Repository: aurora


Description
---

Removing --rollback-on-failure from aurora restart.


Diffs
-

  src/main/python/apache/aurora/client/cli/jobs.py 
4485675190b1b69cf78e042e9888d26fb924ea92 
  src/test/python/apache/aurora/client/cli/test_restart.py 
aa389b48fe03a186bfa51dab4560b65a7334be51 

Diff: https://reviews.apache.org/r/31558/diff/


Testing
---

./pants test.pytest --no-fast src/test/python/apache/aurora/client:all


Thanks,

Maxim Khutornenko

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74571
---

Ship it!


Ship It!

- Bill Farner


On Feb. 27, 2015, 8:13 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> ---
> 
> (Updated Feb. 27, 2015, 8:13 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1020
> https://issues.apache.org/jira/browse/AURORA-1020
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Removing --rollback-on-failure from aurora restart.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 4485675190b1b69cf78e042e9888d26fb924ea92 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> aa389b48fe03a186bfa51dab4560b65a7334be51 
> 
> Diff: https://reviews.apache.org/r/31558/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Steve Niemitz



> On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java, line 
> > 36
> > 
> >
> > should this be private?

I wanted it to be, but got style checker violations when making it private.  
Same reason the Builder ctor is public as well.


> On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java,
> >  lines 215-227
> > 
> >
> > Can this instead be an exact comparison of List?  Presumably we 
> > should fail if other volumes show up.
> > 
> > ```
> > assertEquals(
> > ImmutableList.of(expected),
> > taskInfo.getExecutor().getContainer().getVolumesList());
> > ```

I think checking only this specifically is a more robust test.  There are other 
things we may want to mount in by default in the future (for example, we 
already mount the thermos run directory), and testing for all of them here 
would make the test to broad.


- Steve


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74507
---


On Feb. 25, 2015, 10:35 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31338/
> ---
> 
> (Updated Feb. 25, 2015, 10:35 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington and Bill Farner.
> 
> 
> Bugs: AURORA-1107
> https://issues.apache.org/jira/browse/AURORA-1107
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added a command line flag, -global_container_mounts, to allow mounting paths 
> from the slaves into the (docker) containers they run.
> 
> This is the first portion of allowing per-job mounts, however, I wanted to 
> get this out first since more people want it.  I'll implement per-job mounts 
> in a future review.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 6f6124a4c844a1abcf07401d80c3e50eb8b4 
>   config/checkstyle/checkstyle.xml 580d9d3737c0f52da2d33f5b99ef9406b55c5807 
>   docs/deploying-aurora-scheduler.md d1123359961fd59ddb8c1a07f80f293bdd46019f 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> bacfbfeb237ecddf82f58679e05be012c5214e61 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 24b61c1e4f615295acf28d904588e1512972d3f4 
>   src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 
> baacb71403d55c5b90fc11cb2a23f552a32e8ba5 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 5340d651b298ec8aa079e73d6d2f652fdf876293 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 6575b7d420f17ec68d6e2a83e7b380f684577d4f 
>   src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 444d6d3fdaf86eb84612f846eaa326eb75c49898 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 
> efe62ceb502ead88a2f0cd6d09a76664e465d9bc 
> 
> Diff: https://reviews.apache.org/r/31338/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 31550: Add test coverage for MesosSchedulerImpl.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31550/#review74572
---

Ship it!


Master (d1a1296) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 6:30 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31550/
> ---
> 
> (Updated Feb. 27, 2015, 6:30 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings MesosSchedulerImpl to 100% line and branch coverage.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> aa8aaad975bac513ce7734b4807a2f736b493e69 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> d621586abc8b0e20ffa6bd2c39aa92bd5512c3dd 
> 
> Diff: https://reviews.apache.org/r/31550/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Steve Niemitz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/
---

(Updated Feb. 27, 2015, 8:19 p.m.)


Review request for Aurora, Jay Buffington and Bill Farner.


Bugs: AURORA-1107
https://issues.apache.org/jira/browse/AURORA-1107


Repository: aurora


Description
---

Added a command line flag, -global_container_mounts, to allow mounting paths 
from the slaves into the (docker) containers they run.

This is the first portion of allowing per-job mounts, however, I wanted to get 
this out first since more people want it.  I'll implement per-job mounts in a 
future review.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
6f6124a4c844a1abcf07401d80c3e50eb8b4 
  config/checkstyle/checkstyle.xml 580d9d3737c0f52da2d33f5b99ef9406b55c5807 
  docs/deploying-aurora-scheduler.md d1123359961fd59ddb8c1a07f80f293bdd46019f 
  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
bacfbfeb237ecddf82f58679e05be012c5214e61 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
24b61c1e4f615295acf28d904588e1512972d3f4 
  src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 
baacb71403d55c5b90fc11cb2a23f552a32e8ba5 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
5340d651b298ec8aa079e73d6d2f652fdf876293 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
6575b7d420f17ec68d6e2a83e7b380f684577d4f 
  src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
444d6d3fdaf86eb84612f846eaa326eb75c49898 
  src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 
efe62ceb502ead88a2f0cd6d09a76664e465d9bc 

Diff: https://reviews.apache.org/r/31338/diff/


Testing
---


Thanks,

Steve Niemitz

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74573
---

Ship it!


Just to be clear, this is because it doesn't make sense to have rollback with 
restarts right?

- Zameer Manji


On Feb. 27, 2015, 12:13 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> ---
> 
> (Updated Feb. 27, 2015, 12:13 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1020
> https://issues.apache.org/jira/browse/AURORA-1020
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Removing --rollback-on-failure from aurora restart.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 4485675190b1b69cf78e042e9888d26fb924ea92 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> aa389b48fe03a186bfa51dab4560b65a7334be51 
> 
> Diff: https://reviews.apache.org/r/31558/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Maxim Khutornenko



> On Feb. 27, 2015, 8:20 p.m., Zameer Manji wrote:
> > Just to be clear, this is because it doesn't make sense to have rollback 
> > with restarts right?

Yeah, there is nothing to rollback to in case of restarts that by definition 
use the same task config.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74573
---


On Feb. 27, 2015, 8:13 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> ---
> 
> (Updated Feb. 27, 2015, 8:13 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1020
> https://issues.apache.org/jira/browse/AURORA-1020
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Removing --rollback-on-failure from aurora restart.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 4485675190b1b69cf78e042e9888d26fb924ea92 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> aa389b48fe03a186bfa51dab4560b65a7334be51 
> 
> Diff: https://reviews.apache.org/r/31558/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31508: Removing redundant scheduling loop in preemptor.

2015-02-27 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31508/
---

(Updated Feb. 27, 2015, 8:23 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Rebased.


Bugs: AURORA-1156
https://issues.apache.org/jira/browse/AURORA-1156


Repository: aurora


Description
---

This is #1 from the attached ticket. Brings anywhere between 2% and 18% better 
perf in bechmark scenarios.

BEFORE:
```
Benchmark   
Mode  Samples Score Error  Units
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
  avgt  100909677.646 Â±   10103.466  ns/op
o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
avgt  100   1332768.205 Â±   16664.386  ns/op
o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
 avgt  100  69304405.590 Â± 1536571.317  ns/op
o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
avgt  100870348.707 Â±   16815.495  ns/op
```

AFTER:
```
Benchmark   
Mode  Samples Score Error  Units
o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
  avgt  100749864.522 Â±6568.372  ns/op
o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
avgt  100   1125995.085 Â±   19241.796  ns/op
o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
 avgt  100  68028627.539 Â± 1412569.919  ns/op
o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
avgt  100766747.584 Â±   13310.142  ns/op
```


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 
833a3e0b088780e21f5f16434327c96447a25115 
  
src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
 2845b3f72fca5c329a8b81ce796370ad95d94f02 

Diff: https://reviews.apache.org/r/31508/diff/


Testing
---

./gradlew jmh


Thanks,

Maxim Khutornenko

Re: Review Request 31508: Removing redundant scheduling loop in preemptor.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31508/#review74577
---

Ship it!


Master (443f668) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 8:23 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31508/
> ---
> 
> (Updated Feb. 27, 2015, 8:23 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1156
> https://issues.apache.org/jira/browse/AURORA-1156
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is #1 from the attached ticket. Brings anywhere between 2% and 18% 
> better perf in bechmark scenarios.
> 
> BEFORE:
> ```
> Benchmark 
>   Mode  Samples Score Error  Units
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
>   avgt  100909677.646 Â±   10103.466  ns/op
> o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100   1332768.205 Â±   16664.386  ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
>  avgt  100  69304405.590 Â± 1536571.317  ns/op
> o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100870348.707 Â±   16815.495  ns/op
> ```
> 
> AFTER:
> ```
> Benchmark 
>   Mode  Samples Score Error  Units
> o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark
>   avgt  100749864.522 Â±6568.372  ns/op
> o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100   1125995.085 Â±   19241.796  ns/op
> o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark
>  avgt  100  68028627.539 Â± 1412569.919  ns/op
> o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark
> avgt  100766747.584 Â±   13310.142  ns/op
> ```
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java 
> 833a3e0b088780e21f5f16434327c96447a25115 
>   
> src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
>  2845b3f72fca5c329a8b81ce796370ad95d94f02 
> 
> Diff: https://reviews.apache.org/r/31508/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew jmh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74581
---


Master (443f668) is red with this patch.
  ./build-support/jenkins/build.sh

 src.test.python.apache.aurora.client.cli.cron  
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.inspect   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.job   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.plugins   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.quota 
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.sla   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.supdate   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.task  
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.update
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.version   
 .   SUCCESS
 src.test.python.apache.aurora.client.config
 .   SUCCESS
 src.test.python.apache.aurora.client.factory   
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_aurora_job_key   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster_option   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_clusters 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 src.test.python.apache.aurora.common.test_pex_version  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_shellify 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_transport
 .   SUCCESS
 src.test.python.apache.aurora.config.test_base 
 .   SUCCESS
 
src.test.python.apache.aurora.config.test_constraint_parsing
.   SUCCESS
 src.test.python.apache.aurora.config.test_loader   
 .   SUCCESS
 src.test.python.apache.aurora.config.test_thrift   
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.path_detector 
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_base   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_vars   
 .   SUCCESS
 src.test.python.apache.aurora.executor.status_manager  
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_task_runner 
 .   FAILURE
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE

[31m
   FAILURE[0m


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 8:13 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> ---
> 
> (Updated Feb. 27, 2015, 8:13 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74582
---

Master (443f668) is red with this patch.
  ./build-support/jenkins/build.sh

make[2]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
make[1]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thrift-0.9.1'
make: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
:api:classesThriftNote: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java:22:8:
 Unused import - com.google.common.base.Optional.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java:23:8:
 Unused import - com.google.common.collect.ImmutableList.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java:42:8:
 Unused import - org.apache.aurora.gen.Volume.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleJmh'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/jmh.xml

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 26.652 secs

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot

On Feb. 27, 2015, 8:19 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31338/
> ---
> 
> (Updated Feb. 27, 2015, 8:19 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington and Bill Farner.
> 
> 
> Bugs: AURORA-1107
> https://issues.apache.org/jira/browse/AURORA-1107
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added a command line flag, -global_container_mounts, to allow mounting paths 
> from the slaves into the (docker) containers they run.
> 
> This is the first portion of allowing per-job mounts, however, I wanted to 
> get this out first since more people want it.  I'll implement per-job mounts 
> in a future review.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 6f6124a4c844a1abcf07401d80c3e50eb8b4 
>   config/checkstyle/checkstyle.xml 580d9d3737c0f52da2d33f5b99ef9406b55c5807 
>   docs/deploying-aurora-scheduler.md d1123359961fd59ddb8c1a07f80f293bdd46019f 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> bacfbfeb237ecddf82f58679e05be012c5214e61 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 24b61c1e4f615295acf28d904588e1512972d3f4 
>   src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 
> baacb71403d55c5b90fc11cb2a23f552a32e8ba5 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 5340d651b298ec8aa079e73d6d2f652fdf876293 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 6575b7d420f17ec68d6e2a83e7b380f684577d4f 
>   src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 444d6d3fdaf86eb84612f846eaa326eb75c49898 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 
> efe62ceb502ead88a2f0cd6d09a76664e465d9bc 
> 
> Diff: https://reviews.apache.org/r/31338/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
---

Review request for Aurora, Joe Smith and Zameer Manji.


Bugs: AURORA-1027
https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
---

This splits src/main/python/apache/thermos/bin/thermos.py into 
src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we 
can easily add a customized aurora entry point for thermos that is capable of 
finding checkpoint roots in executor sandboxes.  Added said entry point in 
src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
this should live (possibly under aurora/executor/bin?)  This is a drop-in 
replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in 
gc, status and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not 
go with full coverage, instead opting to ship AURORA-1027 for now.


Diffs
-

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 
1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
---

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-27 Thread Maxim Khutornenko



> On Feb. 27, 2015, 7:30 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, 
> > lines 110-113
> > 
> >
> > How about making score an EnumSet so that you can do a 
> > typesafe bitwise OR?

These scores did not match directly to VetoType. However, your comment got me 
thinking it's quite easy to fix that. Created a new 
DEDICATED_CONSTRAINT_MISMATCH and moved all scores definitions into the 
VetoType enum.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31525/#review74554
---


On Feb. 27, 2015, 3:19 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31525/
> ---
> 
> (Updated Feb. 27, 2015, 3:19 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-1148
> https://issues.apache.org/jira/browse/AURORA-1148
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instead of relying on a fixed MAX_SCORE, vetoes are now graded by their 
> relative weight (severity) with a dedicated constraint mismatch ranked higest 
> and an insufficient resource mismatch - lowest. Together with "break early" 
> rule in SchedulingFilter, this ensures "heavier" vetoes are given proper 
> attention in the NearestFit. This simplifies `NearestFit` logic while also 
> improving pending reason reporting accuracy and scheduling performance.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 3313bd2f9ed5a88375d88715dea5da1e9ad8b963 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> a020ce50d578fba7f32b370f448a49eb1c284147 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> c3097e49c0f6588ea765aa4fab69dd35e3d90e8b 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  b00668423a53a8cf6f4da3456bce3354f1fd2424 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> 78a236c0f9074692b67ce18e6e03f18fe4529e02 
> 
> Diff: https://reviews.apache.org/r/31525/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74586
---


@ReviewBot retry

- Maxim Khutornenko


On Feb. 27, 2015, 8:13 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> ---
> 
> (Updated Feb. 27, 2015, 8:13 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1020
> https://issues.apache.org/jira/browse/AURORA-1020
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Removing --rollback-on-failure from aurora restart.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 4485675190b1b69cf78e042e9888d26fb924ea92 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> aa389b48fe03a186bfa51dab4560b65a7334be51 
> 
> Diff: https://reviews.apache.org/r/31558/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-27 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31525/
---

(Updated Feb. 27, 2015, 9:05 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Kevin's comments.


Bugs: AURORA-1148
https://issues.apache.org/jira/browse/AURORA-1148


Repository: aurora


Description
---

Instead of relying on a fixed MAX_SCORE, vetoes are now graded by their 
relative weight (severity) with a dedicated constraint mismatch ranked higest 
and an insufficient resource mismatch - lowest. Together with "break early" 
rule in SchedulingFilter, this ensures "heavier" vetoes are given proper 
attention in the NearestFit. This simplifies `NearestFit` logic while also 
improving pending reason reporting accuracy and scheduling performance.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
3313bd2f9ed5a88375d88715dea5da1e9ad8b963 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
a020ce50d578fba7f32b370f448a49eb1c284147 
  src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
c3097e49c0f6588ea765aa4fab69dd35e3d90e8b 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
b00668423a53a8cf6f4da3456bce3354f1fd2424 
  src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
78a236c0f9074692b67ce18e6e03f18fe4529e02 

Diff: https://reviews.apache.org/r/31525/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 31558: Removing --rollback-on-failure from aurora restart.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31558/#review74593
---

Ship it!


Master (e8a0a9f) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 8:13 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31558/
> ---
> 
> (Updated Feb. 27, 2015, 8:13 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1020
> https://issues.apache.org/jira/browse/AURORA-1020
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Removing --rollback-on-failure from aurora restart.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 4485675190b1b69cf78e042e9888d26fb924ea92 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> aa389b48fe03a186bfa51dab4560b65a7334be51 
> 
> Diff: https://reviews.apache.org/r/31558/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/client:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31525/#review74594
---

Ship it!


Master (e8a0a9f) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 9:05 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31525/
> ---
> 
> (Updated Feb. 27, 2015, 9:05 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-1148
> https://issues.apache.org/jira/browse/AURORA-1148
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instead of relying on a fixed MAX_SCORE, vetoes are now graded by their 
> relative weight (severity) with a dedicated constraint mismatch ranked higest 
> and an insufficient resource mismatch - lowest. Together with "break early" 
> rule in SchedulingFilter, this ensures "heavier" vetoes are given proper 
> attention in the NearestFit. This simplifies `NearestFit` logic while also 
> improving pending reason reporting accuracy and scheduling performance.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 3313bd2f9ed5a88375d88715dea5da1e9ad8b963 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> a020ce50d578fba7f32b370f448a49eb1c284147 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> c3097e49c0f6588ea765aa4fab69dd35e3d90e8b 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  b00668423a53a8cf6f4da3456bce3354f1fd2424 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> 78a236c0f9074692b67ce18e6e03f18fe4529e02 
> 
> Diff: https://reviews.apache.org/r/31525/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74596
---


Master (e8a0a9f) is red with this patch.
  ./build-support/jenkins/build.sh

 src.test.python.apache.aurora.client.factory   
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_aurora_job_key   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster_option   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_clusters 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 src.test.python.apache.aurora.common.test_pex_version  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_shellify 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_transport
 .   SUCCESS
 src.test.python.apache.aurora.config.test_base 
 .   SUCCESS
 
src.test.python.apache.aurora.config.test_constraint_parsing
.   SUCCESS
 src.test.python.apache.aurora.config.test_loader   
 .   SUCCESS
 src.test.python.apache.aurora.config.test_thrift   
 .   SUCCESS
 src.test.python.apache.aurora.executor.common.announcer
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.executor_detector 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
 src.test.python.apache.aurora.executor.common.kill_manager 
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.path_detector 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_base   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_vars   
 .   SUCCESS
 src.test.python.apache.aurora.executor.gc_executor 
 .   SUCCESS
 src.test.python.apache.aurora.executor.status_manager  
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_executor
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_task_runner 
 .   SUCCESS
 src.test.python.apache.thermos.bin.test_thermos
 .   FAILURE
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 src.test.python.apache.thermos.core.test_process   
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE

[31m
   FAILURE[0m


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 8:58 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 8:58 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.

Re: Review Request 31334: Fixing cron update quota checking.

2015-02-27 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/#review74605
---

Ship it!


Ship It!

- Kevin Sweeney


On Feb. 27, 2015, 9:18 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31334/
> ---
> 
> (Updated Feb. 27, 2015, 9:18 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-1134
> https://issues.apache.org/jira/browse/AURORA-1134
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cron schedule updates were treated as template addition rather than 
> differential update, requiring extra quota capacity to clear the check.
> 
> Adding a new `checkCronUpdate()` QuotaManager interface method to correctly 
> handle cron job updates.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 8444d225e91c75e9a571049d28af7264b6d2d017 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  56398f33206cfa1fa45601a21760c7e23e2616bf 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> b79b07c23e00fab524aef21481070c5f09c9fa18 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
> 
> Diff: https://reviews.apache.org/r/31334/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-02-27 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/
---

(Updated Feb. 27, 2015, 10 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
---

Add missing test dependency that was causing --no-fast builds to break.


Bugs: AURORA-1026
https://issues.apache.org/jira/browse/AURORA-1026


Repository: aurora


Description
---

This creates a new abstraction, the ObserverTaskDetector, which is responsible 
for managing state transitions for tasks for the observer.  Adds some tests and 
better debug logging.


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/BUILD 
8cef41d04aff9edc7da7053e05341274a9bd0834 
  src/main/python/apache/aurora/executor/common/resource_manager.py 
08e02e41b581f275f070228bb23c4cf2a0489f9a 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
7a28e3255842e3e13a0866d6ad1bfc4cb64781e1 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/common/path.py 
846f507e2e097fc04fe0098a7250b40fefcfc6e2 
  src/main/python/apache/thermos/monitoring/disk.py 
175ed3af6515e6107e297d91d4e30cbb3034faf7 
  src/main/python/apache/thermos/monitoring/monitor.py 
11423bc1764c8380d8de4ad095c1e2748ebb78f8 
  src/main/python/apache/thermos/monitoring/resource.py 
b4cb881c87a09bb90a740f369a7a5fc5d75dbf04 
  src/main/python/apache/thermos/observer/BUILD 
ee65f3a46e1d339620e76cadae92c6678fc3510f 
  src/main/python/apache/thermos/observer/bin/BUILD 
15a03f74f204f58856f0843b9db05e83b89d1138 
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
effa8c19f963bf2792497f4a06049214ae30dfa5 
  src/main/python/apache/thermos/observer/detector.py PRE-CREATION 
  src/main/python/apache/thermos/observer/http/file_browser.py 
87ef9c8a29689c78a5e39a46cc53e4675e36a381 
  src/main/python/apache/thermos/observer/observed_task.py 
f33aecbc8f3c0a461ae3dba66fbd4986f544dc04 
  src/main/python/apache/thermos/observer/task_observer.py 
cd528dcca3f5a330359cf38005f3a1a0329a4886 
  src/test/python/apache/aurora/executor/BUILD 
2ee9b1233e9db47455ddffbc48691d379222 
  src/test/python/apache/aurora/executor/common/BUILD 
7b73f693d161cfd205435e4acb398f553b92389f 
  
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
 8f288f6115ab52265dfada3f41d81271c55a 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28 
  src/test/python/apache/thermos/bin/test_thermos.py 
2d9d33397ae01b31ab011d958f5457311ef7ef20 
  src/test/python/apache/thermos/core/test_staged_kill.py 
faa23ae6afcaa443d23c65e5e027902961a0e52b 
  src/test/python/apache/thermos/monitoring/test_resource.py 
52d813946379bdc70c40ad079c74b54f60bd4b41 
  src/test/python/apache/thermos/observer/BUILD PRE-CREATION 
  src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31451/diff/


Testing
---

Manually launched observer and ran some thermos tasks.
+
mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::


Thanks,

Brian Wickman

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74604
---


I think moving the binary entry point to aurora/executor/bin is a good idea


src/main/python/apache/thermos/cli/common.py


Unrelated to your change, why have the strict option at al? Shouldn't the 
default behaviour validate the data?



src/main/python/apache/thermos/cli/common.py


Could you leverage the daemonize code in t.c.process instead?



src/test/python/apache/thermos/cli/commands/test_simplerun.py


Instead of creating a Mock like this here, could you grab the options from 
the simplerun command? If you do that then you can create a Mock with a 
spec_set.


- Zameer Manji


On Feb. 27, 2015, 12:58 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 12:58 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74606
---


Master (388a5b3) is red with this patch.
  ./build-support/jenkins/build.sh

:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java:865:
 error: cannot find symbol
return expect(storageUtil.jobStore.fetchJob(anyObject(IJobKey.class)))
  ^
  symbol:   class IJobKey
  location: class QuotaManagerImplTest
1 error
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 41.054 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 10 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> ---
> 
> (Updated Feb. 27, 2015, 10 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This creates a new abstraction, the ObserverTaskDetector, which is 
> responsible for managing state transitions for tasks for the observer.  Adds 
> some tests and better debug logging.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/BUILD 
> 8cef41d04aff9edc7da7053e05341274a9bd0834 
>   src/main/python/apache/aurora/executor/common/resource_manager.py 
> 08e02e41b581f275f070228bb23c4cf2a0489f9a 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/common/path.py 
> 846f507e2e097fc04fe0098a7250b40fefcfc6e2 
>   src/main/python/apache/thermos/monitoring/disk.py 
> 175ed3af6515e6107e297d91d4e30cbb3034faf7 
>   src/main/python/apache/thermos/monitoring/monitor.py 
> 11423bc1764c8380d8de4ad095c1e2748ebb78f8 
>   src/main/python/apache/thermos/monitoring/resource.py 
> b4cb881c87a09bb90a740f369a7a5fc5d75dbf04 
>   src/main/python/apache/thermos/observer/BUILD 
> ee65f3a46e1d339620e76cadae92c6678fc3510f 
>   src/main/python/apache/thermos/observer/bin/BUILD 
> 15a03f74f204f58856f0843b9db05e83b89d1138 
>   src/main/python/apache/thermos/observer/bin/thermos_observer.py 
> effa8c19f963bf2792497f4a06049214ae30dfa5 
>   src/main/python/apache/thermos/observer/detector.py PRE-CREATION 
>   src/main/python/apache/thermos/observer/http/file_browser.py 
> 87ef9c8a29689c78a5e39a46cc53e4675e36a381 
>   src/main/python/apache/thermos/observer/observed_task.py 
> f33aecbc8f3c0a461ae3dba66fbd4986f544dc04 
>   src/main/python/apache/thermos/observer/task_observer.py 
> cd528dcca3f5a330359cf38005f3a1a0329a4886 
>   src/test/python/apache/aurora/executor/BUILD 
> 2ee9b1233e9db47455ddffbc48691d379222 
>   src/test/python/apache/aurora/executor/common/BUILD 
> 7b73f693d161cfd205435e4acb398f553b92389f 
>   
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
>  8f288f6115ab52265dfada3f41d81271c55a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/core/test_staged_kill.py 
> faa23ae6afcaa443d23c65e5e027902961a0e52b 
>   src/test/python/apache/thermos/monitoring/test_resource.py 
> 52d813946379bdc70c40ad079c74b54f60bd4b41 
>   src/test/python/apache/thermos/observer/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31451/diff/
> 
> 
> Testing
> ---
> 
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
> 
> 
> Thanks,
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
---

(Updated Feb. 27, 2015, 10:11 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
---

Fix BUILD targets, remove old test_thermos.py


Bugs: AURORA-1027
https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
---

This splits src/main/python/apache/thermos/bin/thermos.py into 
src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we 
can easily add a customized aurora entry point for thermos that is capable of 
finding checkpoint roots in executor sandboxes.  Added said entry point in 
src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
this should live (possibly under aurora/executor/bin?)  This is a drop-in 
replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in 
gc, status and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not 
go with full coverage, instead opting to ship AURORA-1027 for now.


Diffs (updated)
-

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 
1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/BUILD df50964851c6be89c646015edf91d07992743497 
  src/test/python/apache/thermos/bin/BUILD 
596aeb200dc55b077ed73fc342b9187045732890 
  src/test/python/apache/thermos/bin/test_thermos.py 
2d9d33397ae01b31ab011d958f5457311ef7ef20 
  src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
---

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74610
---


Master (388a5b3) is red with this patch.
  ./build-support/jenkins/build.sh

:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:compileJmhJava
Download 
https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-core/1.6.1/jmh-core-1.6.1.pom
Download 
https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-parent/1.6.1/jmh-parent-1.6.1.pom
Download 
https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-generator-annprocess/1.6.1/jmh-generator-annprocess-1.6.1.pom
Download 
https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-core/1.6.1/jmh-core-1.6.1.jar
Download 
https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-generator-annprocess/1.6.1/jmh-generator-annprocess-1.6.1.jar
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java:865:
 error: cannot find symbol
return expect(storageUtil.jobStore.fetchJob(anyObject(IJobKey.class)))
  ^
  symbol:   class IJobKey
  location: class QuotaManagerImplTest
1 error
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 2 mins 20.306 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 10:11 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 10:11 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef2

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Brian Wickman



> On Feb. 27, 2015, 10:03 p.m., Zameer Manji wrote:
> > src/main/python/apache/thermos/cli/common.py, line 40
> > 
> >
> > Unrelated to your change, why have the strict option at al? Shouldn't 
> > the default behaviour validate the data?

No idea what this is for.  Removing.


> On Feb. 27, 2015, 10:03 p.m., Zameer Manji wrote:
> > src/main/python/apache/thermos/cli/common.py, line 47
> > 
> >
> > Could you leverage the daemonize code in t.c.process instead?

Tried this -- doesn't actually appear to work.


> On Feb. 27, 2015, 10:03 p.m., Zameer Manji wrote:
> > src/test/python/apache/thermos/cli/commands/test_simplerun.py, line 19
> > 
> >
> > Instead of creating a Mock like this here, could you grab the options 
> > from the simplerun command? If you do that then you can create a Mock with 
> > a spec_set.

How do you mean grab the options from the simplerun command?  One of the major 
flaws of twitter.common.app is that I can't easily invoke a configured 
application from test, so the easiest thing to do is call an app.command 
directly, but it means we have to construct our own options object :-\


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74604
---


On Feb. 27, 2015, 10:11 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 10:11 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_main.py PRE-CREATI

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
---

(Updated Feb. 27, 2015, 10:29 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
---

Address feedback and merge master.


Bugs: AURORA-1027
https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
---

This splits src/main/python/apache/thermos/bin/thermos.py into 
src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we 
can easily add a customized aurora entry point for thermos that is capable of 
finding checkpoint roots in executor sandboxes.  Added said entry point in 
src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
this should live (possibly under aurora/executor/bin?)  This is a drop-in 
replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in 
gc, status and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not 
go with full coverage, instead opting to ship AURORA-1027 for now.


Diffs (updated)
-

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 
1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/BUILD df50964851c6be89c646015edf91d07992743497 
  src/test/python/apache/thermos/bin/BUILD 
596aeb200dc55b077ed73fc342b9187045732890 
  src/test/python/apache/thermos/bin/test_thermos.py 
2d9d33397ae01b31ab011d958f5457311ef7ef20 
  src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
---

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Zameer Manji



> On Feb. 27, 2015, 2:03 p.m., Zameer Manji wrote:
> > src/test/python/apache/thermos/cli/commands/test_simplerun.py, line 19
> > 
> >
> > Instead of creating a Mock like this here, could you grab the options 
> > from the simplerun command? If you do that then you can create a Mock with 
> > a spec_set.
> 
> Brian Wickman wrote:
> How do you mean grab the options from the simplerun command?  One of the 
> major flaws of twitter.common.app is that I can't easily invoke a configured 
> application from test, so the easiest thing to do is call an app.command 
> directly, but it means we have to construct our own options object :-\

I was hoping there was a way to get the options for a command given a command. 
If we cannot do that then I suggest giving this mock a spec_set with your 
desired options. This way if we add or remove options our tests won't silently 
pass and will throw an exception if we access an options attribute that is not 
defined.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74604
---


On Feb. 27, 2015, 2:29 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 2:29 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74613
---


Master (388a5b3) is red with this patch.
  ./build-support/jenkins/build.sh

:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java:865:
 error: cannot find symbol
return expect(storageUtil.jobStore.fetchJob(anyObject(IJobKey.class)))
  ^
  symbol:   class IJobKey
  location: class QuotaManagerImplTest
1 error
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 47.958 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 10:29 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 10:29 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
---

(Updated Feb. 27, 2015, 10:48 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
---

Add a spec_set on the options_mock for cli/commands/test_simplerun.


Bugs: AURORA-1027
https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
---

This splits src/main/python/apache/thermos/bin/thermos.py into 
src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we 
can easily add a customized aurora entry point for thermos that is capable of 
finding checkpoint roots in executor sandboxes.  Added said entry point in 
src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
this should live (possibly under aurora/executor/bin?)  This is a drop-in 
replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in 
gc, status and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not 
go with full coverage, instead opting to ship AURORA-1027 for now.


Diffs (updated)
-

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 
1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/BUILD df50964851c6be89c646015edf91d07992743497 
  src/test/python/apache/thermos/bin/BUILD 
596aeb200dc55b077ed73fc342b9187045732890 
  src/test/python/apache/thermos/bin/test_thermos.py 
2d9d33397ae01b31ab011d958f5457311ef7ef20 
  src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
---

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74616
---


Master (388a5b3) is red with this patch.
  ./build-support/jenkins/build.sh

:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java:865:
 error: cannot find symbol
return expect(storageUtil.jobStore.fetchJob(anyObject(IJobKey.class)))
  ^
  symbol:   class IJobKey
  location: class QuotaManagerImplTest
1 error
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 33.823 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 10:48 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 10:48 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

2015-02-27 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31423/#review74618
---

Ship it!


Ship It!

- Brian Wickman


On Feb. 26, 2015, 3:20 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31423/
> ---
> 
> (Updated Feb. 26, 2015, 3:20 p.m.)
> 
> 
> Review request for Aurora, Brian Wickman and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stop the announcer and status checkers before starting to kill the runners.
> 
> This allows the task to be removed from the ZK ensemble before it begins 
> getting killed.  The delay can be significant if the task takes some time to 
> shutdown, and during the time it stops responding to requests.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 9c0282392dbb9cca308baf47adc1750c1f5cacc6 
>   src/test/python/apache/aurora/executor/BUILD 
> 2ee9b1233e9db47455ddffbc48691d379222 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28 
> 
> Diff: https://reviews.apache.org/r/31423/diff/
> 
> 
> Testing
> ---
> 
> We're now running this in our production environments.  Watching ZK, I can 
> confirm that the nodes are removed before process shutdown begins.  Watching 
> the executor log also confirms this.
> 
> I couldn't observe any other side effects either.
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Zameer Manji



> On Feb. 27, 2015, 2:03 p.m., Zameer Manji wrote:
> > src/main/python/apache/thermos/cli/common.py, line 40
> > 
> >
> > Unrelated to your change, why have the strict option at al? Shouldn't 
> > the default behaviour validate the data?
> 
> Brian Wickman wrote:
> No idea what this is for.  Removing.

You did not actually remove this in the diff from what I can see.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74604
---


On Feb. 27, 2015, 2:48 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 2:48 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

2015-02-27 Thread Joe Smith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31423/#review74620
---

Ship it!


Thought this over- the benefits to overall reliability are significant and 
applications should still be motivated to be resilient to the edge case of 'ZK 
registration but application unresponsive'.

Thanks Steve!


src/test/python/apache/aurora/executor/test_thermos_executor.py


good idea


- Joe Smith


On Feb. 26, 2015, 7:20 a.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31423/
> ---
> 
> (Updated Feb. 26, 2015, 7:20 a.m.)
> 
> 
> Review request for Aurora, Brian Wickman and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stop the announcer and status checkers before starting to kill the runners.
> 
> This allows the task to be removed from the ZK ensemble before it begins 
> getting killed.  The delay can be significant if the task takes some time to 
> shutdown, and during the time it stops responding to requests.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 9c0282392dbb9cca308baf47adc1750c1f5cacc6 
>   src/test/python/apache/aurora/executor/BUILD 
> 2ee9b1233e9db47455ddffbc48691d379222 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28 
> 
> Diff: https://reviews.apache.org/r/31423/diff/
> 
> 
> Testing
> ---
> 
> We're now running this in our production environments.  Watching ZK, I can 
> confirm that the nodes are removed before process shutdown begins.  Watching 
> the executor log also confirms this.
> 
> I couldn't observe any other side effects either.
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Review Request 31565: Build fix.

2015-02-27 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31565/
---

Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

This is a commit race. 
The https://reviews.apache.org/r/31388 removed import statement which 
https://reviews.apache.org/r/31334 relies on.


Diffs
-

  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
0480aca721decb3eae230c878499d13d19d3de16 

Diff: https://reviews.apache.org/r/31565/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Re: Review Request 31565: Build fix.

2015-02-27 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31565/#review74621
---

Ship it!


Ship It!

- Bill Farner


On Feb. 27, 2015, 11:11 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31565/
> ---
> 
> (Updated Feb. 27, 2015, 11:11 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is a commit race. 
> The https://reviews.apache.org/r/31388 removed import statement which 
> https://reviews.apache.org/r/31334 relies on.
> 
> 
> Diffs
> -
> 
>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
> 0480aca721decb3eae230c878499d13d19d3de16 
> 
> Diff: https://reviews.apache.org/r/31565/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Steve Niemitz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/
---

(Updated Feb. 27, 2015, 11:16 p.m.)


Review request for Aurora, Jay Buffington and Bill Farner.


Bugs: AURORA-1107
https://issues.apache.org/jira/browse/AURORA-1107


Repository: aurora


Description
---

Added a command line flag, -global_container_mounts, to allow mounting paths 
from the slaves into the (docker) containers they run.

This is the first portion of allowing per-job mounts, however, I wanted to get 
this out first since more people want it.  I'll implement per-job mounts in a 
future review.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
6f6124a4c844a1abcf07401d80c3e50eb8b4 
  config/checkstyle/checkstyle.xml 580d9d3737c0f52da2d33f5b99ef9406b55c5807 
  docs/deploying-aurora-scheduler.md d1123359961fd59ddb8c1a07f80f293bdd46019f 
  src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
bacfbfeb237ecddf82f58679e05be012c5214e61 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
24b61c1e4f615295acf28d904588e1512972d3f4 
  src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 
baacb71403d55c5b90fc11cb2a23f552a32e8ba5 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
5340d651b298ec8aa079e73d6d2f652fdf876293 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
6575b7d420f17ec68d6e2a83e7b380f684577d4f 
  src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
444d6d3fdaf86eb84612f846eaa326eb75c49898 
  src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 
efe62ceb502ead88a2f0cd6d09a76664e465d9bc 

Diff: https://reviews.apache.org/r/31338/diff/


Testing
---


Thanks,

Steve Niemitz

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

2015-02-27 Thread Steve Niemitz



> On Feb. 27, 2015, 11:05 p.m., Joe Smith wrote:
> > Thought this over- the benefits to overall reliability are significant and 
> > applications should still be motivated to be resilient to the edge case of 
> > 'ZK registration but application unresponsive'.
> > 
> > Thanks Steve!

:D


- Steve


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31423/#review74620
---


On Feb. 26, 2015, 3:20 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31423/
> ---
> 
> (Updated Feb. 26, 2015, 3:20 p.m.)
> 
> 
> Review request for Aurora, Brian Wickman and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Stop the announcer and status checkers before starting to kill the runners.
> 
> This allows the task to be removed from the ZK ensemble before it begins 
> getting killed.  The delay can be significant if the task takes some time to 
> shutdown, and during the time it stops responding to requests.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 9c0282392dbb9cca308baf47adc1750c1f5cacc6 
>   src/test/python/apache/aurora/executor/BUILD 
> 2ee9b1233e9db47455ddffbc48691d379222 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28 
> 
> Diff: https://reviews.apache.org/r/31423/diff/
> 
> 
> Testing
> ---
> 
> We're now running this in our production environments.  Watching ZK, I can 
> confirm that the nodes are removed before process shutdown begins.  Watching 
> the executor log also confirms this.
> 
> I couldn't observe any other side effects either.
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74627
---


Master (4cca6a6) is red with this patch.
  ./build-support/jenkins/build.sh

make: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
:api:classesThriftNote: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java:16:8:
 Unused import - java.util.ArrayList.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java:17:8:
 Unused import - java.util.List.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java:21:
 'org.apache.aurora.gen.Volume' should be separated from previous imports.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 38.789 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 11:16 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31338/
> ---
> 
> (Updated Feb. 27, 2015, 11:16 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington and Bill Farner.
> 
> 
> Bugs: AURORA-1107
> https://issues.apache.org/jira/browse/AURORA-1107
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added a command line flag, -global_container_mounts, to allow mounting paths 
> from the slaves into the (docker) containers they run.
> 
> This is the first portion of allowing per-job mounts, however, I wanted to 
> get this out first since more people want it.  I'll implement per-job mounts 
> in a future review.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 6f6124a4c844a1abcf07401d80c3e50eb8b4 
>   config/checkstyle/checkstyle.xml 580d9d3737c0f52da2d33f5b99ef9406b55c5807 
>   docs/deploying-aurora-scheduler.md d1123359961fd59ddb8c1a07f80f293bdd46019f 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> bacfbfeb237ecddf82f58679e05be012c5214e61 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 24b61c1e4f615295acf28d904588e1512972d3f4 
>   src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 
> baacb71403d55c5b90fc11cb2a23f552a32e8ba5 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 5340d651b298ec8aa079e73d6d2f652fdf876293 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 6575b7d420f17ec68d6e2a83e7b380f684577d4f 
>   src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 444d6d3fdaf86eb84612f846eaa326eb75c49898 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 
> efe62ceb502ead88a2f0cd6d09a76664e465d9bc 
> 
> Diff: https://reviews.apache.org/r/31338/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-02-27 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/
---

(Updated Feb. 27, 2015, 11:36 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
---

Merge master build fix.


Bugs: AURORA-1026
https://issues.apache.org/jira/browse/AURORA-1026


Repository: aurora


Description
---

This creates a new abstraction, the ObserverTaskDetector, which is responsible 
for managing state transitions for tasks for the observer.  Adds some tests and 
better debug logging.


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/BUILD 
8cef41d04aff9edc7da7053e05341274a9bd0834 
  src/main/python/apache/aurora/executor/common/resource_manager.py 
08e02e41b581f275f070228bb23c4cf2a0489f9a 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
7a28e3255842e3e13a0866d6ad1bfc4cb64781e1 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/common/path.py 
846f507e2e097fc04fe0098a7250b40fefcfc6e2 
  src/main/python/apache/thermos/monitoring/disk.py 
175ed3af6515e6107e297d91d4e30cbb3034faf7 
  src/main/python/apache/thermos/monitoring/monitor.py 
11423bc1764c8380d8de4ad095c1e2748ebb78f8 
  src/main/python/apache/thermos/monitoring/resource.py 
b4cb881c87a09bb90a740f369a7a5fc5d75dbf04 
  src/main/python/apache/thermos/observer/BUILD 
ee65f3a46e1d339620e76cadae92c6678fc3510f 
  src/main/python/apache/thermos/observer/bin/BUILD 
15a03f74f204f58856f0843b9db05e83b89d1138 
  src/main/python/apache/thermos/observer/bin/thermos_observer.py 
effa8c19f963bf2792497f4a06049214ae30dfa5 
  src/main/python/apache/thermos/observer/detector.py PRE-CREATION 
  src/main/python/apache/thermos/observer/http/file_browser.py 
87ef9c8a29689c78a5e39a46cc53e4675e36a381 
  src/main/python/apache/thermos/observer/observed_task.py 
f33aecbc8f3c0a461ae3dba66fbd4986f544dc04 
  src/main/python/apache/thermos/observer/task_observer.py 
cd528dcca3f5a330359cf38005f3a1a0329a4886 
  src/test/python/apache/aurora/executor/BUILD 
2ee9b1233e9db47455ddffbc48691d379222 
  src/test/python/apache/aurora/executor/common/BUILD 
7b73f693d161cfd205435e4acb398f553b92389f 
  
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
 8f288f6115ab52265dfada3f41d81271c55a 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28 
  src/test/python/apache/thermos/bin/test_thermos.py 
2d9d33397ae01b31ab011d958f5457311ef7ef20 
  src/test/python/apache/thermos/core/test_staged_kill.py 
faa23ae6afcaa443d23c65e5e027902961a0e52b 
  src/test/python/apache/thermos/monitoring/test_resource.py 
52d813946379bdc70c40ad079c74b54f60bd4b41 
  src/test/python/apache/thermos/observer/BUILD PRE-CREATION 
  src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31451/diff/


Testing
---

Manually launched observer and ran some thermos tasks.
+
mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::


Thanks,

Brian Wickman

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
---

(Updated Feb. 27, 2015, 11:37 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
---

Merge master build fix.


Bugs: AURORA-1027
https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
---

This splits src/main/python/apache/thermos/bin/thermos.py into 
src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we 
can easily add a customized aurora entry point for thermos that is capable of 
finding checkpoint roots in executor sandboxes.  Added said entry point in 
src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
this should live (possibly under aurora/executor/bin?)  This is a drop-in 
replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in 
gc, status and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not 
go with full coverage, instead opting to ship AURORA-1027 for now.


Diffs (updated)
-

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 
1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/BUILD df50964851c6be89c646015edf91d07992743497 
  src/test/python/apache/thermos/bin/BUILD 
596aeb200dc55b077ed73fc342b9187045732890 
  src/test/python/apache/thermos/bin/test_thermos.py 
2d9d33397ae01b31ab011d958f5457311ef7ef20 
  src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
---

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74631
---

Ship it!


Master (4cca6a6) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 11:37 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 11:37 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74633
---

Ship it!


Master (4cca6a6) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 11:36 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> ---
> 
> (Updated Feb. 27, 2015, 11:36 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This creates a new abstraction, the ObserverTaskDetector, which is 
> responsible for managing state transitions for tasks for the observer.  Adds 
> some tests and better debug logging.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/BUILD 
> 8cef41d04aff9edc7da7053e05341274a9bd0834 
>   src/main/python/apache/aurora/executor/common/resource_manager.py 
> 08e02e41b581f275f070228bb23c4cf2a0489f9a 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/common/path.py 
> 846f507e2e097fc04fe0098a7250b40fefcfc6e2 
>   src/main/python/apache/thermos/monitoring/disk.py 
> 175ed3af6515e6107e297d91d4e30cbb3034faf7 
>   src/main/python/apache/thermos/monitoring/monitor.py 
> 11423bc1764c8380d8de4ad095c1e2748ebb78f8 
>   src/main/python/apache/thermos/monitoring/resource.py 
> b4cb881c87a09bb90a740f369a7a5fc5d75dbf04 
>   src/main/python/apache/thermos/observer/BUILD 
> ee65f3a46e1d339620e76cadae92c6678fc3510f 
>   src/main/python/apache/thermos/observer/bin/BUILD 
> 15a03f74f204f58856f0843b9db05e83b89d1138 
>   src/main/python/apache/thermos/observer/bin/thermos_observer.py 
> effa8c19f963bf2792497f4a06049214ae30dfa5 
>   src/main/python/apache/thermos/observer/detector.py PRE-CREATION 
>   src/main/python/apache/thermos/observer/http/file_browser.py 
> 87ef9c8a29689c78a5e39a46cc53e4675e36a381 
>   src/main/python/apache/thermos/observer/observed_task.py 
> f33aecbc8f3c0a461ae3dba66fbd4986f544dc04 
>   src/main/python/apache/thermos/observer/task_observer.py 
> cd528dcca3f5a330359cf38005f3a1a0329a4886 
>   src/test/python/apache/aurora/executor/BUILD 
> 2ee9b1233e9db47455ddffbc48691d379222 
>   src/test/python/apache/aurora/executor/common/BUILD 
> 7b73f693d161cfd205435e4acb398f553b92389f 
>   
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
>  8f288f6115ab52265dfada3f41d81271c55a 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/core/test_staged_kill.py 
> faa23ae6afcaa443d23c65e5e027902961a0e52b 
>   src/test/python/apache/thermos/monitoring/test_resource.py 
> 52d813946379bdc70c40ad079c74b54f60bd4b41 
>   src/test/python/apache/thermos/observer/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31451/diff/
> 
> 
> Testing
> ---
> 
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Bill Farner



> On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java,
> >  lines 215-227
> > 
> >
> > Can this instead be an exact comparison of List?  Presumably we 
> > should fail if other volumes show up.
> > 
> > ```
> > assertEquals(
> > ImmutableList.of(expected),
> > taskInfo.getExecutor().getContainer().getVolumesList());
> > ```
> 
> Steve Niemitz wrote:
> I think checking only this specifically is a more robust test.  There are 
> other things we may want to mount in by default in the future (for example, 
> we already mount the thermos run directory), and testing for all of them here 
> would make the test to broad.

Hmm...i see your point, but i don't entirely buy it :-)

For example, if the code behind this erroneously inserts two `Protos.Volume` 
entries for each global mount, the test case should trip.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74507
---


On Feb. 27, 2015, 11:16 p.m., Steve Niemitz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31338/
> ---
> 
> (Updated Feb. 27, 2015, 11:16 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington and Bill Farner.
> 
> 
> Bugs: AURORA-1107
> https://issues.apache.org/jira/browse/AURORA-1107
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added a command line flag, -global_container_mounts, to allow mounting paths 
> from the slaves into the (docker) containers they run.
> 
> This is the first portion of allowing per-job mounts, however, I wanted to 
> get this out first since more people want it.  I'll implement per-job mounts 
> in a future review.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 6f6124a4c844a1abcf07401d80c3e50eb8b4 
>   config/checkstyle/checkstyle.xml 580d9d3737c0f52da2d33f5b99ef9406b55c5807 
>   docs/deploying-aurora-scheduler.md d1123359961fd59ddb8c1a07f80f293bdd46019f 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> bacfbfeb237ecddf82f58679e05be012c5214e61 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 24b61c1e4f615295acf28d904588e1512972d3f4 
>   src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 
> baacb71403d55c5b90fc11cb2a23f552a32e8ba5 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 5340d651b298ec8aa079e73d6d2f652fdf876293 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 6575b7d420f17ec68d6e2a83e7b380f684577d4f 
>   src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 444d6d3fdaf86eb84612f846eaa326eb75c49898 
>   src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 
> efe62ceb502ead88a2f0cd6d09a76664e465d9bc 
> 
> Diff: https://reviews.apache.org/r/31338/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>

Review Request 31570: Suppressing duplicate update instance events.

2015-02-27 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31570/
---

Review request for Aurora, David McLaughlin and Bill Farner.


Bugs: AURORA-1097
https://issues.apache.org/jira/browse/AURORA-1097


Repository: aurora


Description
---

All instance update actions are supposed to be unique. Suppressing duplicats 
due to pause/resume cycle.


Diffs
-

  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
acdade3dca807a221b4da975d0310c91884ee752 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
e24d6bde5f3479a75522e825cce4ec6c30c117aa 

Diff: https://reviews.apache.org/r/31570/diff/


Testing
---

./gradlew -Pq build
Manual testing in vagrant.


Thanks,

Maxim Khutornenko

Re: Review Request 31570: Suppressing duplicate update instance events.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31570/#review74646
---


Master (4cca6a6) is red with this patch.
  ./build-support/jenkins/build.sh

 src.test.python.apache.aurora.client.cli.update
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.version   
 .   SUCCESS
 src.test.python.apache.aurora.client.config
 .   SUCCESS
 src.test.python.apache.aurora.client.factory   
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_aurora_job_key   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster_option   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_clusters 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 src.test.python.apache.aurora.common.test_pex_version  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_shellify 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_transport
 .   SUCCESS
 src.test.python.apache.aurora.config.test_base 
 .   SUCCESS
 
src.test.python.apache.aurora.config.test_constraint_parsing
.   SUCCESS
 src.test.python.apache.aurora.config.test_loader   
 .   SUCCESS
 src.test.python.apache.aurora.config.test_thrift   
 .   SUCCESS
 src.test.python.apache.aurora.executor.common.announcer
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.executor_detector 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
 src.test.python.apache.aurora.executor.common.kill_manager 
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.path_detector 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_base   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_vars   
 .   SUCCESS
 src.test.python.apache.aurora.executor.gc_executor 
 .   FAILURE
 src.test.python.apache.aurora.executor.status_manager  
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_task_runner 
 .   SUCCESS
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE

[31m
   FAILURE[0m


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 28, 2015, 1:37 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31570/
> ---
> 
> (Updated Feb. 28, 2015, 1:37 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bil

Re: Review Request 31570: Suppressing duplicate update instance events.

2015-02-27 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31570/#review74649
---


@ReviewBot retry

- Maxim Khutornenko


On Feb. 28, 2015, 1:37 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31570/
> ---
> 
> (Updated Feb. 28, 2015, 1:37 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-1097
> https://issues.apache.org/jira/browse/AURORA-1097
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> All instance update actions are supposed to be unique. Suppressing duplicats 
> due to pause/resume cycle.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  acdade3dca807a221b4da975d0310c91884ee752 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e24d6bde5f3479a75522e825cce4ec6c30c117aa 
> 
> Diff: https://reviews.apache.org/r/31570/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Manual testing in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 31570: Suppressing duplicate update instance events.

2015-02-27 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31570/#review74650
---

Ship it!


Master (4cca6a6) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 28, 2015, 1:37 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31570/
> ---
> 
> (Updated Feb. 28, 2015, 1:37 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-1097
> https://issues.apache.org/jira/browse/AURORA-1097
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> All instance update actions are supposed to be unique. Suppressing duplicats 
> due to pause/resume cycle.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  acdade3dca807a221b4da975d0310c91884ee752 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e24d6bde5f3479a75522e825cce4ec6c30c117aa 
> 
> Diff: https://reviews.apache.org/r/31570/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> Manual testing in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

75 matches

Mail list logo