[Impala-ASF-CR] [DOCS] Removed old files no longer in use
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9938 ) Change subject: [DOCS] Removed old files no longer in use .. Patch Set 1: Code-Review+2 I verified the changes and did a clean test build. -- To view, visit http://gerrit.cloudera.org:8080/9938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0aaa756bf0fc0092186ebc293543408b403aa5e Gerrit-Change-Number: 9938 Gerrit-PatchSet: 1 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Comment-Date: Thu, 05 Apr 2018 23:41:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6779: [DOCS] Improve the REPLICA PREFERENCE doc
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9877 ) Change subject: IMPALA-6779: [DOCS] Improve the REPLICA_PREFERENCE doc .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If38f9c881f553568c2516ecc23ec501f23ee1f28 Gerrit-Change-Number: 9877 Gerrit-PatchSet: 2 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Fri, 30 Mar 2018 22:58:42 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9869 ) Change subject: [DOCS] Updates to the load balancing algorithms section .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9869/3/docs/topics/impala_proxy.xml File docs/topics/impala_proxy.xml: http://gerrit.cloudera.org:8080/#/c/9869/3/docs/topics/impala_proxy.xml@129 PS3, Line 129: .S Sorry, didn't catch it before, one more missing space. -- To view, visit http://gerrit.cloudera.org:8080/9869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317 Gerrit-Change-Number: 9869 Gerrit-PatchSet: 3 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 30 Mar 2018 22:57:43 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6779: [DOCS] Improve the REPLICA PREFERENCE doc
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9877 ) Change subject: IMPALA-6779: [DOCS] Improve the REPLICA_PREFERENCE doc .. Patch Set 1: (2 comments) Just a couple of editorial nitpicks. I can +2 it again if you do another patch set. http://gerrit.cloudera.org:8080/#/c/9877/1/docs/topics/impala_replica_preference.xml File docs/topics/impala_replica_preference.xml: http://gerrit.cloudera.org:8080/#/c/9877/1/docs/topics/impala_replica_preference.xml@80 PS1, Line 80: ,a Missing space. http://gerrit.cloudera.org:8080/#/c/9877/1/docs/topics/impala_replica_preference.xml@81 PS1, Line 81: the Remove word. -- To view, visit http://gerrit.cloudera.org:8080/9877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If38f9c881f553568c2516ecc23ec501f23ee1f28 Gerrit-Change-Number: 9877 Gerrit-PatchSet: 1 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Fri, 30 Mar 2018 22:38:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Updates to the load balancing algorithms section
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9869 ) Change subject: [DOCS] Updates to the load balancing algorithms section .. Patch Set 2: Code-Review+1 (2 comments) Just a couple of minor touchups and it'll be ready for +2. http://gerrit.cloudera.org:8080/#/c/9869/2/docs/topics/impala_proxy.xml File docs/topics/impala_proxy.xml: http://gerrit.cloudera.org:8080/#/c/9869/2/docs/topics/impala_proxy.xml@187 PS2, Line 187: Having the start with plain text causes weird wrapping like this when you add a paragraph later. Wrap a tag around the text immediately following the , "Sessions from the... in this case." It often produces better source formatting and better line spacing in the HTML output to include a inside tags where it's optional, such as and . That's why you'll often see the extra layer of tags in the Impala doc source code - to allow the addition of a 2nd, 3rd, etc. paragraph without causing any source or output glitches. http://gerrit.cloudera.org:8080/#/c/9869/2/docs/topics/impala_proxy.xml@209 PS2, Line 209: setup 'set up' as a verb. (You might 'choose a setup' to use it as a noun, but probably simpler just to use 2 words.) -- To view, visit http://gerrit.cloudera.org:8080/9869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia697aafc799b2a3414a208aa85e1de4bf0214317 Gerrit-Change-Number: 9869 Gerrit-PatchSet: 2 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 30 Mar 2018 22:31:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 ) Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect .. Patch Set 1: Code-Review+1 LGTM subject to Tim's comment about the merging business. -- To view, visit http://gerrit.cloudera.org:8080/9813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bd49cb32a952362dcefc230d8feb1a7d6c13ea0 Gerrit-Change-Number: 9813 Gerrit-PatchSet: 1 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Anonymous Coward #381 Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 27 Mar 2018 18:08:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9030 ) Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9030/2/docs/topics/impala_upsert.xml File docs/topics/impala_upsert.xml: http://gerrit.cloudera.org:8080/#/c/9030/2/docs/topics/impala_upsert.xml@71 PS2, Line 71: [hint_clause] Just to confirm: unlike with INSERT, is it correct that the hint for UPSERT can _only_ appear ahead of the table ref? -- To view, visit http://gerrit.cloudera.org:8080/9030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43e0a782087c2e67f2e012424fb9261be445efc9 Gerrit-Change-Number: 9030 Gerrit-PatchSet: 2 Gerrit-Owner: Kim Jin ChulGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 22 Mar 2018 21:24:03 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9030 ) Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 2: I added Vuk, Dimitris, and Alex as reviewers - the people who did tech review for the code updates, at https://gerrit.cloudera.org/#/c/8676/ -- To view, visit http://gerrit.cloudera.org:8080/9030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43e0a782087c2e67f2e012424fb9261be445efc9 Gerrit-Change-Number: 9030 Gerrit-PatchSet: 2 Gerrit-Owner: Kim Jin ChulGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 22 Mar 2018 21:17:31 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fixed a typo at line #120
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9742 ) Change subject: [DOCS] Fixed a typo at line #120 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f726889071950bc7025079ba9be90fd5d71bc9c Gerrit-Change-Number: 9742 Gerrit-PatchSet: 1 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Comment-Date: Wed, 21 Mar 2018 20:27:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6415: [DOCS] fix invalid
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9731 ) Change subject: IMPALA-6415: [DOCS] fix invalid .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9731/1/docs/topics/impala_aliases.xml File docs/topics/impala_aliases.xml: http://gerrit.cloudera.org:8080/#/c/9731/1/docs/topics/impala_aliases.xml@86 PS1, Line 86: : : > This one does not get an error or warning - for some reason. cannot be inside , but can be inside . is what's known as a container tag, while is what's known as an inline tag (must always go inside some container). When a single tag like ends with />, that is shorthand notation for the start tag and end tag all in one. I.e. instead of , you have . -- To view, visit http://gerrit.cloudera.org:8080/9731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6768f336559eeac41f7f32f989d106740eccdc88 Gerrit-Change-Number: 9731 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-NagyGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Wed, 21 Mar 2018 19:24:32 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6523: [DOCS] Allowed values for PARQUET FALLBACK SCHEMA RESOLUTION
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9536 ) Change subject: IMPALA-6523: [DOCS] Allowed values for PARQUET_FALLBACK_SCHEMA_RESOLUTION .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ade6a30c62f4899b6801d03430b5fe15e713474 Gerrit-Change-Number: 9536 Gerrit-PatchSet: 5 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 09 Mar 2018 00:44:26 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 ) Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic .. Patch Set 4: (1 comment) Ready for +2 after incorporating Alan's final suggestion. http://gerrit.cloudera.org:8080/#/c/9515/4/docs/topics/impala_proxy.xml File docs/topics/impala_proxy.xml: http://gerrit.cloudera.org:8080/#/c/9515/4/docs/topics/impala_proxy.xml@204 PS4, Line 204: Recommended > Maybe a even stronger word like "Hue must use sticky session." I agree, strengthening the wording will probably head off some more support calls. -- To view, visit http://gerrit.cloudera.org:8080/9515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c29ddac53c0fb4cc6a29701e50280b95167 Gerrit-Change-Number: 9515 Gerrit-PatchSet: 4 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alan Choi Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: John Russell Gerrit-Comment-Date: Thu, 08 Mar 2018 23:15:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6523: [DOCS] Allowed values for PARQUET FALLBACK SCHEMA RESOLUTION
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9536 ) Change subject: IMPALA-6523: [DOCS] Allowed values for PARQUET_FALLBACK_SCHEMA_RESOLUTION .. Patch Set 4: (1 comment) Ready for a +2 after one little tagging addition. http://gerrit.cloudera.org:8080/#/c/9536/4/docs/topics/impala_parquet_fallback_schema_resolution.xml File docs/topics/impala_parquet_fallback_schema_resolution.xml: http://gerrit.cloudera.org:8080/#/c/9536/4/docs/topics/impala_parquet_fallback_schema_resolution.xml@40 PS4, Line 40: PARQUET_FALLBACK_SCHEMA_RESOLUTION Enclose the query option name in tags. -- To view, visit http://gerrit.cloudera.org:8080/9536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ade6a30c62f4899b6801d03430b5fe15e713474 Gerrit-Change-Number: 9536 Gerrit-PatchSet: 4 Gerrit-Owner: Alex RodoniGerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 08 Mar 2018 23:11:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 ) Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic .. Patch Set 1: (1 comment) Just an FYI to Alex's response on Alan's question. http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml File docs/topics/impala_proxy.xml: http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml@162 PS1, Line 162: > John Russel was waiting for reviews. Yes, it slipped through the cracks while moving doc development to upstream. Especially because if we started going into a lot of detail about using Impala with , that could arguably be inappropriate to include in upstream docs. -- To view, visit http://gerrit.cloudera.org:8080/9515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c29ddac53c0fb4cc6a29701e50280b95167 Gerrit-Change-Number: 9515 Gerrit-PatchSet: 1 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alan Choi Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: John Russell Gerrit-Comment-Date: Wed, 07 Mar 2018 00:23:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [DOCS] Removed the obsolete Llama options files .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c2b8160af9c95ec1e1b744b558d9537dd2550d Gerrit-Change-Number: 9219 Gerrit-PatchSet: 5 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 05 Mar 2018 21:13:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6553: [DOCS] load catalog in background default change
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9389 ) Change subject: IMPALA-6553: [DOCS] load_catalog_in_background default change .. Patch Set 4: (4 comments) A couple of comments inline, plus one for another file that I'm not sure how to mark in the source code: In impala_invalidate_metadata.xml, there's another reference to load_catalog_in_background: table. (This checking does not apply if you have set the catalogd configuration option --load_catalog_in_background=false.) Impala reports any lack of write permissions as an Since the user no longer needs to explicitly set a value of false, perhaps soften this wording a bit and say it doesn't apply when the setting is false, which it is by default. http://gerrit.cloudera.org:8080/#/c/9389/4/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/9389/4/docs/shared/impala_common.xml@3448 PS4, Line 3448: id="ul_h2v_pjf_ycb" Remove this unneeded id= attribute. There is an Oxygen setting that controls which elements automatically get id= added - please make to remove and from that setting on your machine. http://gerrit.cloudera.org:8080/#/c/9389/4/docs/shared/impala_common.xml@3450 PS4, Line 3450: will be General style tip: avoid future tense where possible. In this case, say the metadata _is_ loaded when... http://gerrit.cloudera.org:8080/#/c/9389/4/docs/shared/impala_common.xml@3458 PS4, Line 3458: will aim to Remove future tense again, plus "aim to" is a little bit colloquial. Either "the catalog service loads metadata..." if it always happens, or "the catalog service attemps to load metadata..." if it might or might not happen. http://gerrit.cloudera.org:8080/#/c/9389/4/docs/shared/impala_common.xml@3463 PS4, Line 3463: id="ul_fx4_hlf_ycb" Another unnecessary id= to remove. The presence of IDs suggests that these specific lists might be conref'ed someplace else, but actually only the enclosing paragraph is conref'ed. Therefore only that paragraph needs an ID. (If someone in future wants to remove these lists or change them into some different kind of element, it's helpful to know, based on the lack of id= attribute, that there are no conrefs pointing to the and elements.) -- To view, visit http://gerrit.cloudera.org:8080/9389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I548b2d1532c12f8d3c795a940b7f980482ecf09b Gerrit-Change-Number: 9389 Gerrit-PatchSet: 4 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 05 Mar 2018 20:01:53 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [DOCS] Removed the obsolete Llama options files .. Patch Set 4: There are still tags referencing the removed files, which causes problems in the DITA-OT builds. If you remove these 2 lines, the HTML and PDF will build cleanly: $ grep impala_reservation_request_timeout.xml ../*.ditamap ../impala_keydefs.ditamap: $ grep impala_v_cpu_cores.xml ../*.ditamap ../impala_keydefs.ditamap: -- To view, visit http://gerrit.cloudera.org:8080/9219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c2b8160af9c95ec1e1b744b558d9537dd2550d Gerrit-Change-Number: 9219 Gerrit-PatchSet: 4 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 05 Mar 2018 19:48:11 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Removed the obsolete Llama options files
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [DOCS] Removed the obsolete Llama options files .. Patch Set 4: For structural changes, it's a good idea to run a DITA-OT build in addition to the normal XML validation steps (validating the map in Oxygen, pre-commit hook running xmllint, etc.). Here's what I get when I run 'make' from the docs/ directory (only showing the first few lines): $ make dita -i impala.ditamap -f html5 -o build/html/ -filter impala_html.ditaval [gen-list] [DOTX008E][ERROR] File 'file:/Users/jrussell/Documents/homework/apache_impala/docs/topics/impala_reservation_request_timeout.xml' does not exist or cannot be loaded. [gen-list] [DOTX008E][ERROR] File 'file:/Users/jrussell/Documents/homework/apache_impala/docs/topics/impala_v_cpu_cores.xml' does not exist or cannot be loaded. [move-meta] File /var/folders/4h/fq2d6grs4s5746pc6hh9x2t0gp/T/temp20180305114138982/topics/impala_v_cpu_cores.xml was not found. [move-meta] File /var/folders/4h/fq2d6grs4s5746pc6hh9x2t0gp/T/temp20180305114138982/topics/impala_reservation_request_timeout.xml was not found. There must be some more references to these files left behind, in tags or other DITA maps. I'll dig a little further. -- To view, visit http://gerrit.cloudera.org:8080/9219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c2b8160af9c95ec1e1b744b558d9537dd2550d Gerrit-Change-Number: 9219 Gerrit-PatchSet: 4 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 05 Mar 2018 19:44:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [DOCS] HAproxy with sticky session requires the check option .. Patch Set 3: (3 comments) Just a couple of minor nits from me. But I would like for Alan or someone more familiar with the HAProxy stuff to be the one who actually gives the +2 from the technical side. http://gerrit.cloudera.org:8080/#/c/9293/4/docs/topics/impala_proxy.xml File docs/topics/impala_proxy.xml: http://gerrit.cloudera.org:8080/#/c/9293/4/docs/topics/impala_proxy.xml@489 PS4, Line 489: attention type="important" is the value we typically use for calling any extra attention to elements. http://gerrit.cloudera.org:8080/#/c/9293/4/docs/topics/impala_proxy.xml@493 PS4, Line 493: that Hue tries to connect Grammar: "to which Hue tries to connect". http://gerrit.cloudera.org:8080/#/c/9293/4/docs/topics/impala_proxy.xml@493 PS4, Line 493: the Impalad server The way this is typically worded elsewhere is "the impalad daemon" to be clear about what has to be running. -- To view, visit http://gerrit.cloudera.org:8080/9293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8 Gerrit-Change-Number: 9293 Gerrit-PatchSet: 3 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alan Choi Gerrit-Reviewer: John Russell Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 05 Mar 2018 19:34:36 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 ) Change subject: IMPALA-6509: [DOCS] Note for haproxy for Kerberized clusters .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9286 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c Gerrit-Change-Number: 9286 Gerrit-PatchSet: 6 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 05 Mar 2018 18:35:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6499: [DOCS] Fixed formatting errors in split part function
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9275 ) Change subject: IMPALA-6499: [DOCS] Fixed formatting errors in split_part function .. Patch Set 6: Code-Review+2 I downloaded the patch and did an extra round of validation, just in case any XML tags got misplaced among the patch sets. Everything looks clean. Alex, thanks for weathering the iterations! -- To view, visit http://gerrit.cloudera.org:8080/9275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a Gerrit-Change-Number: 9275 Gerrit-PatchSet: 6 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 20 Feb 2018 21:51:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6499: [DOCS] Fixed formatting errors in split part function
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9275 ) Change subject: IMPALA-6499: [DOCS] Fixed formatting errors in split_part function .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1079 PS4, Line 1079: Don't indent the line. http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1102 PS4, Line 1102: : These examples show what happens for out-of-range field : positions. Specifying a value less than 1 produces an error. : Specifying a value greater than the number of fields returns a : zero-length string (which is not the same as : NULL). : Put back some extra leading spaces to keep the indentation the same as it was originally. http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1126 PS4, Line 1126: This whole paragraph lost several spaces of indentation. Please keep the same indentation as in the original. http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1128 PS4, Line 1128:
[Impala-ASF-CR] IMPALA-6499: [docs] Fixed formatting errors in split part function
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9275 ) Change subject: IMPALA-6499: [docs] Fixed formatting errors in split_part function .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/9275/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9275/3//COMMIT_MSG@7 PS3, Line 7: docs Uppercase "DOCS" http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml@1067 PS3, Line 1067: : Return type: This looks like the whole paragraph was reformatted by accident. The line shouldn't be wrapped at the end of another line containing text. Was there any change to the actual text in this paragraph? http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml@1075 PS3, Line 1075: Remove trailing space. http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml@1129 PS3, Line 1129:
[Impala-ASF-CR] IMPALA-6509: [docs] Note for haproxy for Kerberized clusters
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 ) Change subject: IMPALA-6509: [docs] Note for haproxy for Kerberized clusters .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/9286/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9286/5//COMMIT_MSG@7 PS5, Line 7: docs Uppercase "DOCS" http://gerrit.cloudera.org:8080/#/c/9286/5/docs/topics/impala_proxy.xml File docs/topics/impala_proxy.xml: http://gerrit.cloudera.org:8080/#/c/9286/5/docs/topics/impala_proxy.xml@244 PS5, Line 244: k Uppercase "Kerberized" is the convention we use elsewhere. You'll only see it lowercase in user-entered text like some JIRA titles. http://gerrit.cloudera.org:8080/#/c/9286/5/docs/topics/impala_proxy.xml@247 PS5, Line 247: : Please put the note outside the paragraph, i.e. ... ... It makes the output more predictable in terms of indentation and spacing, and is also friendlier from a maintenance perspective because there's less indentation within the actual source file (i.e. leaves more space on each line for actual text, leading to less line wrapping). -- To view, visit http://gerrit.cloudera.org:8080/9286 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ce9930e3f658c52502a2ba95f93647e2706d58c Gerrit-Change-Number: 9286 Gerrit-PatchSet: 5 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Fri, 16 Feb 2018 23:56:06 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6515: [docs] HAproxy with sticky session requires the check option
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9293 ) Change subject: IMPALA-6515: [docs] HAproxy with sticky session requires the check option .. Patch Set 3: Different people from various field organizations have requested / suggested all sorts of combinations of HAProxy settings. There has never been a consistent set that worked the best for everyone. I suggest tagging in Alan Choi since he was the first one who verified the HAProxy instructions. -- To view, visit http://gerrit.cloudera.org:8080/9293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47165df6624f958c2e0542e2627d4f5377789ab8 Gerrit-Change-Number: 9293 Gerrit-PatchSet: 3 Gerrit-Owner: Alex RodoniGerrit-Reviewer: John Russell Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Fri, 16 Feb 2018 23:51:29 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Fix in REPLICA PREFERENCE numeric options
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9341 ) Change subject: [DOCS] Fix in REPLICA_PREFERENCE numeric options .. Patch Set 3: I'm not familiar with whatever error condition is indicated in the console output from the verification job, i.e. https://jenkins.impala.io/job/gerrit-docs-submit/195/console I'm going to try the verification job again with the hope that it's a transient error. If not, something might be going wrong with the commit flow (incorrect rebase, or review created from master instead of a private branch); if that's the case, the solution would be to abandon and re-do. -- To view, visit http://gerrit.cloudera.org:8080/9341 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia10e69ac38229e0969db11b7edbcf08c2444602b Gerrit-Change-Number: 9341 Gerrit-PatchSet: 3 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Juan Yu Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Fri, 16 Feb 2018 23:48:30 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Typos fixed in Impala Analytic Functions doc
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9347 ) Change subject: [DOCS] Typos fixed in Impala Analytic Functions doc .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec4a2822f5e066574e64bf025d300e4cde7a7d29 Gerrit-Change-Number: 9347 Gerrit-PatchSet: 1 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 16 Feb 2018 23:43:58 + Gerrit-HasComments: No
[Impala-ASF-CR] [docs] Removed the obsolete Llama options files
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [docs] Removed the obsolete Llama options files .. Patch Set 2: (1 comment) Now the question is, how do we make sure on the doc side that this change stays only in the 3.x (master?) branch and doesn't get applied to Impala 2.x branches? (I presume the stub files with their warnings should stay in place for any 2.12, 2.13, etc. releases that are done. http://gerrit.cloudera.org:8080/#/c/9219/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9219/2//COMMIT_MSG@7 PS2, Line 7: docs Uppercase "DOCS" -- To view, visit http://gerrit.cloudera.org:8080/9219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0c2b8160af9c95ec1e1b744b558d9537dd2550d Gerrit-Change-Number: 9219 Gerrit-PatchSet: 2 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 16 Feb 2018 23:42:37 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9211 ) Change subject: IMPALA-5191, IMPALA-6415: [DOCS] Document breaking change of alias and ordinal substitution .. Patch Set 1: Looping in Alex for her information, because changes like this will require additional updates in downstream-only docs too. -- To view, visit http://gerrit.cloudera.org:8080/9211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I558230d07212da62d2cd12e07a52ceba03e980a8 Gerrit-Change-Number: 9211 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-NagyGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: John Russell Gerrit-Comment-Date: Mon, 05 Feb 2018 17:56:05 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Doc for MURMUR HASH() function
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9031/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9031/1//COMMIT_MSG@7 PS1, Line 7: [DOCS] Let's include a reference to the code JIRA: IMPALA-3651: [DOCS] ... http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml File docs/topics/impala_math_functions.xml: http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml@862 PS1, Line 862: 2.12.0 rev="IMPALA-3651 2.12.0" The rev= field is free-form and can take multiple space-separated values. When practical, we record both the the code JIRA and the associated release. -- To view, visit http://gerrit.cloudera.org:8080/9031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b Gerrit-Change-Number: 9031 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin ChulGerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 24 Jan 2018 19:55:14 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] IMPALA-6105 unix timestamp returns a number of seconds
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9084 ) Change subject: [DOCS] IMPALA-6105 unix_timestamp returns a number of seconds .. Patch Set 2: Code-Review+1 LGTM. I'll let Tim give the +2. -- To view, visit http://gerrit.cloudera.org:8080/9084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie502322368c0052d4767191cf8f7ecb7ac5e7a16 Gerrit-Change-Number: 9084 Gerrit-PatchSet: 2 Gerrit-Owner: Alex RodoniGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 23 Jan 2018 21:58:26 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] IMPALA-6105 unix timestamp returns a number of seconds
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9084 ) Change subject: [DOCS] IMPALA-6105 unix_timestamp returns a number of seconds .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9084/1/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/9084/1/docs/topics/impala_datetime_functions.xml@2531 PS1, Line 2531: date time date and time http://gerrit.cloudera.org:8080/#/c/9084/1/docs/topics/impala_datetime_functions.xml@2532 PS1, Line 2532: Remove trailing space. http://gerrit.cloudera.org:8080/#/c/9084/1/docs/topics/impala_datetime_functions.xml@2532 PS1, Line 2532: called with arguments, the first argument represented as a the -- To view, visit http://gerrit.cloudera.org:8080/9084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie502322368c0052d4767191cf8f7ecb7ac5e7a16 Gerrit-Change-Number: 9084 Gerrit-PatchSet: 1 Gerrit-Owner: Alex RodoniGerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 23 Jan 2018 21:41:15 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9066 to look at the new patch set (#2). Change subject: IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause .. IMPALA-5310: [DOCS] Reserve 'repeatable' keyword from TABLESAMPLE clause Overlooked the new keyword when the clause was originally introduced. Change-Id: Ie8e6713fb97ced279f0aedfe8f42c09a7e6edae9 --- M docs/topics/impala_reserved_words.xml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/9066/2 -- To view, visit http://gerrit.cloudera.org:8080/9066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie8e6713fb97ced279f0aedfe8f42c09a7e6edae9 Gerrit-Change-Number: 9066 Gerrit-PatchSet: 2 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm
[Impala-ASF-CR] [DOCS] Minor editorial change
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9064 ) Change subject: [DOCS] Minor editorial change .. Patch Set 1: Code-Review+2 Full steam ahead! -- To view, visit http://gerrit.cloudera.org:8080/9064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib78e851761796a1751e6adaaffa049b1fbb58b88 Gerrit-Change-Number: 9064 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: John Russell Gerrit-Comment-Date: Thu, 18 Jan 2018 21:35:38 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Minor editorial change
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9064 ) Change subject: [DOCS] Minor editorial change .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9064/1/docs/topics/impala_union.xml File docs/topics/impala_union.xml: http://gerrit.cloudera.org:8080/#/c/9064/1/docs/topics/impala_union.xml@70 PS1, Line 70: First, set up some sample data, including duplicate 1 values: > Test comment Done -- To view, visit http://gerrit.cloudera.org:8080/9064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib78e851761796a1751e6adaaffa049b1fbb58b88 Gerrit-Change-Number: 9064 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: John Russell Gerrit-Comment-Date: Thu, 18 Jan 2018 21:28:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Minor editorial change
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9064 ) Change subject: [DOCS] Minor editorial change .. Patch Set 1: This is a small review for arodoni to practice with gerrit. -- To view, visit http://gerrit.cloudera.org:8080/9064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib78e851761796a1751e6adaaffa049b1fbb58b88 Gerrit-Change-Number: 9064 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: John Russell Gerrit-Comment-Date: Thu, 18 Jan 2018 21:22:06 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) [DOCS] Update Apache site for Impala 2.11 docs
John Russell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9028 ) Change subject: [DOCS] Update Apache site for Impala 2.11 docs .. [DOCS] Update Apache site for Impala 2.11 docs Adding docs from master branch. SHA = ceeb130c5dba12dc37f69b01ec4cca4b577c0549 Change-Id: Ib7b0d6884ea9e532b142f40366092a362ae7ab62 Reviewed-on: http://gerrit.cloudera.org:8080/9028 Reviewed-by: Thomas Tauber-MarshallReviewed-by: Michael Brown Tested-by: John Russell --- M docs/build/html/index.html M docs/build/html/topics/impala_abort_on_default_limit_exceeded.html M docs/build/html/topics/impala_abort_on_error.html M docs/build/html/topics/impala_adls.html M docs/build/html/topics/impala_admin.html M docs/build/html/topics/impala_admission.html M docs/build/html/topics/impala_aggregate_functions.html M docs/build/html/topics/impala_aliases.html M docs/build/html/topics/impala_allow_unsupported_formats.html M docs/build/html/topics/impala_alter_table.html M docs/build/html/topics/impala_alter_view.html M docs/build/html/topics/impala_analytic_functions.html M docs/build/html/topics/impala_appx_count_distinct.html M docs/build/html/topics/impala_appx_median.html M docs/build/html/topics/impala_array.html M docs/build/html/topics/impala_auditing.html M docs/build/html/topics/impala_authentication.html M docs/build/html/topics/impala_authorization.html M docs/build/html/topics/impala_avg.html M docs/build/html/topics/impala_avro.html M docs/build/html/topics/impala_batch_size.html M docs/build/html/topics/impala_bigint.html M docs/build/html/topics/impala_bit_functions.html M docs/build/html/topics/impala_boolean.html M docs/build/html/topics/impala_breakpad.html M docs/build/html/topics/impala_buffer_pool_limit.html M docs/build/html/topics/impala_char.html M docs/build/html/topics/impala_cluster_sizing.html M docs/build/html/topics/impala_comments.html M docs/build/html/topics/impala_complex_types.html M docs/build/html/topics/impala_components.html M docs/build/html/topics/impala_compression_codec.html M docs/build/html/topics/impala_compute_stats.html M docs/build/html/topics/impala_concepts.html M docs/build/html/topics/impala_conditional_functions.html M docs/build/html/topics/impala_config.html M docs/build/html/topics/impala_config_options.html M docs/build/html/topics/impala_config_performance.html M docs/build/html/topics/impala_connecting.html M docs/build/html/topics/impala_conversion_functions.html M docs/build/html/topics/impala_count.html M docs/build/html/topics/impala_create_database.html M docs/build/html/topics/impala_create_function.html M docs/build/html/topics/impala_create_role.html M docs/build/html/topics/impala_create_table.html M docs/build/html/topics/impala_create_view.html M docs/build/html/topics/impala_databases.html M docs/build/html/topics/impala_datatypes.html M docs/build/html/topics/impala_datetime_functions.html M docs/build/html/topics/impala_ddl.html M docs/build/html/topics/impala_debug_action.html M docs/build/html/topics/impala_decimal.html M docs/build/html/topics/impala_decimal_v2.html M docs/build/html/topics/impala_default_join_distribution_mode.html M docs/build/html/topics/impala_default_order_by_limit.html M docs/build/html/topics/impala_default_spillable_buffer_size.html M docs/build/html/topics/impala_delegation.html M docs/build/html/topics/impala_delete.html M docs/build/html/topics/impala_describe.html M docs/build/html/topics/impala_development.html M docs/build/html/topics/impala_disable_codegen.html M docs/build/html/topics/impala_disable_row_runtime_filtering.html M docs/build/html/topics/impala_disable_streaming_preaggregations.html M docs/build/html/topics/impala_disable_unsafe_spills.html M docs/build/html/topics/impala_disk_space.html M docs/build/html/topics/impala_distinct.html M docs/build/html/topics/impala_dml.html M docs/build/html/topics/impala_double.html M docs/build/html/topics/impala_drop_database.html M docs/build/html/topics/impala_drop_function.html M docs/build/html/topics/impala_drop_role.html M docs/build/html/topics/impala_drop_stats.html M docs/build/html/topics/impala_drop_table.html M docs/build/html/topics/impala_drop_view.html M docs/build/html/topics/impala_exec_single_node_rows_threshold.html M docs/build/html/topics/impala_explain.html M docs/build/html/topics/impala_explain_level.html M docs/build/html/topics/impala_explain_plan.html M docs/build/html/topics/impala_faq.html M docs/build/html/topics/impala_file_formats.html M docs/build/html/topics/impala_fixed_issues.html M docs/build/html/topics/impala_float.html M docs/build/html/topics/impala_functions.html M docs/build/html/topics/impala_functions_overview.html M docs/build/html/topics/impala_grant.html M docs/build/html/topics/impala_group_by.html M docs/build/html/topics/impala_group_concat.html M
[Impala-ASF-CR](asf-site) [DOCS] Update Apache site for Impala 2.11 docs
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9028 ) Change subject: [DOCS] Update Apache site for Impala 2.11 docs .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Ib7b0d6884ea9e532b142f40366092a362ae7ab62 Gerrit-Change-Number: 9028 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 17 Jan 2018 07:03:31 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) [DOCS] Update Apache site for Impala 2.11 docs
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9028 ) Change subject: [DOCS] Update Apache site for Impala 2.11 docs .. Patch Set 1: Thomas, is making a changelog-2.11.html file on your release to-do list? I thought normally it would be available at the same time or even before the bits were posted. But I'm not familiar with the mechanics of that part of the process. -- To view, visit http://gerrit.cloudera.org:8080/9028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Ib7b0d6884ea9e532b142f40366092a362ae7ab62 Gerrit-Change-Number: 9028 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 16 Jan 2018 19:36:25 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) [DOCS] Update Apache site for Impala 2.11 docs
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9028 ) Change subject: [DOCS] Update Apache site for Impala 2.11 docs .. Patch Set 1: I am rewriting the "push" instructions on the Apache wiki as I go. I think the instructions did not take into account a recent decision to always use a number for the PDF file, so there was already an impala-2.10.pdf file and fewer rename/copy steps were needed to get impala-2.11.pdf into place. -- To view, visit http://gerrit.cloudera.org:8080/9028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-MessageType: comment Gerrit-Change-Id: Ib7b0d6884ea9e532b142f40366092a362ae7ab62 Gerrit-Change-Number: 9028 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 16 Jan 2018 07:06:52 + Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) [DOCS] Update Apache site for Impala 2.11 docs
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9028 Change subject: [DOCS] Update Apache site for Impala 2.11 docs .. [DOCS] Update Apache site for Impala 2.11 docs Adding docs from master branch. SHA = ceeb130c5dba12dc37f69b01ec4cca4b577c0549 Change-Id: Ib7b0d6884ea9e532b142f40366092a362ae7ab62 --- M docs/build/html/index.html M docs/build/html/topics/impala_abort_on_default_limit_exceeded.html M docs/build/html/topics/impala_abort_on_error.html M docs/build/html/topics/impala_adls.html M docs/build/html/topics/impala_admin.html M docs/build/html/topics/impala_admission.html M docs/build/html/topics/impala_aggregate_functions.html M docs/build/html/topics/impala_aliases.html M docs/build/html/topics/impala_allow_unsupported_formats.html M docs/build/html/topics/impala_alter_table.html M docs/build/html/topics/impala_alter_view.html M docs/build/html/topics/impala_analytic_functions.html M docs/build/html/topics/impala_appx_count_distinct.html M docs/build/html/topics/impala_appx_median.html M docs/build/html/topics/impala_array.html M docs/build/html/topics/impala_auditing.html M docs/build/html/topics/impala_authentication.html M docs/build/html/topics/impala_authorization.html M docs/build/html/topics/impala_avg.html M docs/build/html/topics/impala_avro.html M docs/build/html/topics/impala_batch_size.html M docs/build/html/topics/impala_bigint.html M docs/build/html/topics/impala_bit_functions.html M docs/build/html/topics/impala_boolean.html M docs/build/html/topics/impala_breakpad.html M docs/build/html/topics/impala_buffer_pool_limit.html M docs/build/html/topics/impala_char.html M docs/build/html/topics/impala_cluster_sizing.html M docs/build/html/topics/impala_comments.html M docs/build/html/topics/impala_complex_types.html M docs/build/html/topics/impala_components.html M docs/build/html/topics/impala_compression_codec.html M docs/build/html/topics/impala_compute_stats.html M docs/build/html/topics/impala_concepts.html M docs/build/html/topics/impala_conditional_functions.html M docs/build/html/topics/impala_config.html M docs/build/html/topics/impala_config_options.html M docs/build/html/topics/impala_config_performance.html M docs/build/html/topics/impala_connecting.html M docs/build/html/topics/impala_conversion_functions.html M docs/build/html/topics/impala_count.html M docs/build/html/topics/impala_create_database.html M docs/build/html/topics/impala_create_function.html M docs/build/html/topics/impala_create_role.html M docs/build/html/topics/impala_create_table.html M docs/build/html/topics/impala_create_view.html M docs/build/html/topics/impala_databases.html M docs/build/html/topics/impala_datatypes.html M docs/build/html/topics/impala_datetime_functions.html M docs/build/html/topics/impala_ddl.html M docs/build/html/topics/impala_debug_action.html M docs/build/html/topics/impala_decimal.html M docs/build/html/topics/impala_decimal_v2.html M docs/build/html/topics/impala_default_join_distribution_mode.html M docs/build/html/topics/impala_default_order_by_limit.html M docs/build/html/topics/impala_default_spillable_buffer_size.html M docs/build/html/topics/impala_delegation.html M docs/build/html/topics/impala_delete.html M docs/build/html/topics/impala_describe.html M docs/build/html/topics/impala_development.html M docs/build/html/topics/impala_disable_codegen.html M docs/build/html/topics/impala_disable_row_runtime_filtering.html M docs/build/html/topics/impala_disable_streaming_preaggregations.html M docs/build/html/topics/impala_disable_unsafe_spills.html M docs/build/html/topics/impala_disk_space.html M docs/build/html/topics/impala_distinct.html M docs/build/html/topics/impala_dml.html M docs/build/html/topics/impala_double.html M docs/build/html/topics/impala_drop_database.html M docs/build/html/topics/impala_drop_function.html M docs/build/html/topics/impala_drop_role.html M docs/build/html/topics/impala_drop_stats.html M docs/build/html/topics/impala_drop_table.html M docs/build/html/topics/impala_drop_view.html M docs/build/html/topics/impala_exec_single_node_rows_threshold.html M docs/build/html/topics/impala_explain.html M docs/build/html/topics/impala_explain_level.html M docs/build/html/topics/impala_explain_plan.html M docs/build/html/topics/impala_faq.html M docs/build/html/topics/impala_file_formats.html M docs/build/html/topics/impala_fixed_issues.html M docs/build/html/topics/impala_float.html M docs/build/html/topics/impala_functions.html M docs/build/html/topics/impala_functions_overview.html M docs/build/html/topics/impala_grant.html M docs/build/html/topics/impala_group_by.html M docs/build/html/topics/impala_group_concat.html M docs/build/html/topics/impala_hadoop.html M docs/build/html/topics/impala_having.html M docs/build/html/topics/impala_hbase.html M docs/build/html/topics/impala_hbase_cache_blocks.html M
[Impala-ASF-CR] IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char length() from length()
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9014 ) Change subject: IMPALA-2172, IMPALA-6391: [DOCS] Distinguish char_length() from length() .. Patch Set 1: Agree with having Greg look it over. If we can +2 it today though, it can make it into the 2.11 docs. Greg won't be back until next week. How about we +2 this review today and take a longer-term action item to fill in more examples for the string functions, so we can turn up any other examples of STRING / CHAR differences? -- To view, visit http://gerrit.cloudera.org:8080/9014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18cabfce66351bb890bfbfc26b93466204a82625 Gerrit-Change-Number: 9014 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Juan Yu Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 12 Jan 2018 20:23:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 3: (2 comments) I didn't make any change due to LIVE_PROGRESS and LIVE_SUMMARY not working, on the assumption that the fix will arrive relatively soon. Since all requests for doc changes are addressed, please bring on the +2s :-) http://gerrit.cloudera.org:8080/#/c/8771/3/docs/topics/impala_shell_options.xml File docs/topics/impala_shell_options.xml: http://gerrit.cloudera.org:8080/#/c/8771/3/docs/topics/impala_shell_options.xml@627 PS3, Line 627: > > It is mentioned alongside --query_option / -Q Done http://gerrit.cloudera.org:8080/#/c/8771/4/docs/topics/impala_shell_options.xml File docs/topics/impala_shell_options.xml: http://gerrit.cloudera.org:8080/#/c/8771/4/docs/topics/impala_shell_options.xml@623 PS4, Line 623: > Nit: trailing white space. Done -- To view, visit http://gerrit.cloudera.org:8080/8771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fa4fc27d6566e87fdabe57edc176133d586a84b Gerrit-Change-Number: 8771 Gerrit-PatchSet: 3 Gerrit-Owner: John RussellGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: David Knupp Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Fri, 12 Jan 2018 20:20:58 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell
Hello Lars Volker, Michael Brown, David Knupp, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8771 to look at the new patch set (#5). Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. IMPALA-5736: [DOCS] Document --query_option for impala-shell Change-Id: I5fa4fc27d6566e87fdabe57edc176133d586a84b --- M docs/impala_keydefs.ditamap M docs/topics/impala_query_options.xml M docs/topics/impala_set.xml M docs/topics/impala_shell_options.xml 4 files changed, 49 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/8771/5 -- To view, visit http://gerrit.cloudera.org:8080/8771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5fa4fc27d6566e87fdabe57edc176133d586a84b Gerrit-Change-Number: 8771 Gerrit-PatchSet: 5 Gerrit-Owner: John RussellGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: David Knupp Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. Patch Set 4: Code-Review+2 (2 comments) Carrying forward +2 after minor update. http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml File docs/topics/impala_set.xml: http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml@54 PS3, Line 54: In and higher, the output of the SET > nit: I'm not sure how you treat trailing spaces in docs. Would you mind dro Done http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml@69 PS3, Line 69: related to internal development of Impala or features that are not yet finalized; > Is it worth explicitly saying something like "Development query options may Done -- To view, visit http://gerrit.cloudera.org:8080/8865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61 Gerrit-Change-Number: 8865 Gerrit-PatchSet: 4 Gerrit-Owner: John RussellGerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 12 Jan 2018 20:00:09 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell
Hello Lars Volker, Michael Brown, David Knupp, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8771 to look at the new patch set (#4). Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. IMPALA-5736: [DOCS] Document --query_option for impala-shell Change-Id: I5fa4fc27d6566e87fdabe57edc176133d586a84b --- M docs/impala_keydefs.ditamap M docs/topics/impala_query_options.xml M docs/topics/impala_set.xml M docs/topics/impala_shell_options.xml 4 files changed, 49 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/8771/4 -- To view, visit http://gerrit.cloudera.org:8080/8771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5fa4fc27d6566e87fdabe57edc176133d586a84b Gerrit-Change-Number: 8771 Gerrit-PatchSet: 4 Gerrit-Owner: John RussellGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: David Knupp Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 5: Adding Alex, who reviewed the code gerrit. Looking for a +2. -- To view, visit http://gerrit.cloudera.org:8080/8942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Change-Number: 8942 Gerrit-PatchSet: 5 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 11 Jan 2018 20:25:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8986 ) Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8986/2/docs/topics/impala_runtime_filtering.xml File docs/topics/impala_runtime_filtering.xml: http://gerrit.cloudera.org:8080/#/c/8986/2/docs/topics/impala_runtime_filtering.xml@181 PS2, Line 181: ture representing a minimum and ma > This is the only part I see that doesn't make sense for min-max filters, as Done http://gerrit.cloudera.org:8080/#/c/8986/2/docs/topics/impala_runtime_filtering.xml@203 PS2, Line 203: gher, the default for runtime filtering is the GLOBAL setting. : > I find this sentence confusing, as Kudu isn't identifying the matching rows Done -- To view, visit http://gerrit.cloudera.org:8080/8986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2 Gerrit-Change-Number: 8986 Gerrit-PatchSet: 3 Gerrit-Owner: John RussellGerrit-Reviewer: John Russell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 11 Jan 2018 20:16:51 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
Hello Thomas Tauber-Marshall, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8986 to look at the new patch set (#3). Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables .. IMPALA-4252: [DOCS] Document min/max filters for Kudu tables Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2 --- M docs/shared/impala_common.xml M docs/topics/impala_disable_row_runtime_filtering.xml M docs/topics/impala_kudu.xml M docs/topics/impala_max_num_runtime_filters.xml M docs/topics/impala_runtime_bloom_filter_size.xml M docs/topics/impala_runtime_filter_max_size.xml M docs/topics/impala_runtime_filter_min_size.xml M docs/topics/impala_runtime_filtering.xml 8 files changed, 71 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/8986/3 -- To view, visit http://gerrit.cloudera.org:8080/8986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2 Gerrit-Change-Number: 8986 Gerrit-PatchSet: 3 Gerrit-Owner: John RussellGerrit-Reviewer: John Russell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8865/2/docs/topics/impala_set.xml File docs/topics/impala_set.xml: http://gerrit.cloudera.org:8080/#/c/8865/2/docs/topics/impala_set.xml@214 PS2, Line 214: Shell Options : LIVE_PROGRESS: False : LIVE_SUMMARY: False : > I think this part should be dropped. Done. Also there were a couple of references to "SET with no arguments" where I introduced the ALL keyword. -- To view, visit http://gerrit.cloudera.org:8080/8865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61 Gerrit-Change-Number: 8865 Gerrit-PatchSet: 3 Gerrit-Owner: John RussellGerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 11 Jan 2018 04:45:55 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Hello Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8865 to look at the new patch set (#3). Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. IMPALA-2181: [DOCS] Document changes to SET output Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61 --- M docs/topics/impala_set.xml 1 file changed, 77 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8865/3 -- To view, visit http://gerrit.cloudera.org:8080/8865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61 Gerrit-Change-Number: 8865 Gerrit-PatchSet: 3 Gerrit-Owner: John RussellGerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8942/3/docs/topics/impala_operators.xml File docs/topics/impala_operators.xml: http://gerrit.cloudera.org:8080/#/c/8942/3/docs/topics/impala_operators.xml@1245 PS3, Line 1245: In and higher, you can use : the operators IS [NOT] TRUE and : IS [NOT] FALSE to perform null-safe : tests against Boolean expressions. These operators always : return TRUE or FALSE, : even if the other side of the expression evaluates to : NULL. These operators let you simplify : Boolean comparisons that must also check for NULL, : for example X != 10 AND X IS NOT NULL is equivalent : to (X != 10) IS TRUE. : > why is this explained here for IS UNKNOWN ? its a repeat of the content for Yes, I was looking for a place to explain all 3 of the new operators in context, but I think the results would look contrived. Since similar details and the example are under IS TRUE, let me remove the text here. http://gerrit.cloudera.org:8080/#/c/8942/3/docs/topics/impala_operators.xml@1260 PS3, Line 1260: IS [NOT] NULL > same thing twice. perhaps the first one should be IS [NOT] UNKNOWN ? Done http://gerrit.cloudera.org:8080/#/c/8942/3/docs/topics/impala_operators.xml@1332 PS3, Line 1332: UNKNOWN > TRUE ? (UNKNOWN is handled in the prev section) Done -- To view, visit http://gerrit.cloudera.org:8080/8942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Change-Number: 8942 Gerrit-PatchSet: 3 Gerrit-Owner: John RussellGerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 11 Jan 2018 04:36:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 4: Patch set 4 was just to fix a looming merge conflict. -- To view, visit http://gerrit.cloudera.org:8080/8942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Change-Number: 8942 Gerrit-PatchSet: 4 Gerrit-Owner: John RussellGerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 10 Jan 2018 20:57:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators
Hello Greg Rahn, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8942 to look at the new patch set (#4). Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. IMPALA-1767: [DOCS] Document new Boolean operators In a new subtopic: IS [NOT] TRUE IS [NOT] FALSE Folded into IS [NOT] NULL: IS [NOT] UNKNOWN Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala_conditional_functions.xml M docs/topics/impala_operators.xml 4 files changed, 123 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/8942/4 -- To view, visit http://gerrit.cloudera.org:8080/8942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Change-Number: 8942 Gerrit-PatchSet: 4 Gerrit-Owner: John RussellGerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] [DOCS] Add phony doc build targets 'html' and 'pdf'
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8994 Change subject: [DOCS] Add phony doc build targets 'html' and 'pdf' .. [DOCS] Add phony doc build targets 'html' and 'pdf' The better to do a quick verification using one format or the other, by issuing 'make html' or 'make pdf'. 'make all' still builds both. Change-Id: Ic096259a773966871b09a023bf12eb6c362167af --- M docs/Makefile 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/8994/1 -- To view, visit http://gerrit.cloudera.org:8080/8994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic096259a773966871b09a023bf12eb6c362167af Gerrit-Change-Number: 8994 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8986 ) Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8986/1/docs/topics/impala_runtime_filtering.xml File docs/topics/impala_runtime_filtering.xml: http://gerrit.cloudera.org:8080/#/c/8986/1/docs/topics/impala_runtime_filtering.xml@173 PS1, Line 173: . (The probability-based aspects means that the : filter > Maybe note here that bloom filters are only for HDFS target scans, and that Done. Because this paragraph is followed by info that's only relevant for Bloom filters, I stated up front that the Bloom filters only apply to HDFS-based tables, then I added info about Kudu tables and min-max filters after the stuff about broadcast and partitioned filters. http://gerrit.cloudera.org:8080/#/c/8986/1/docs/topics/impala_runtime_filtering.xml@335 PS1, Line 335: > Note here: setting EXPLAIN_LEVEL=2 will display the type of filter in the f Done -- To view, visit http://gerrit.cloudera.org:8080/8986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2 Gerrit-Change-Number: 8986 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: John Russell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 10 Jan 2018 20:09:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
Hello Thomas Tauber-Marshall, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8986 to look at the new patch set (#2). Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables .. IMPALA-4252: [DOCS] Document min/max filters for Kudu tables Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2 --- M docs/shared/impala_common.xml M docs/topics/impala_disable_row_runtime_filtering.xml M docs/topics/impala_kudu.xml M docs/topics/impala_max_num_runtime_filters.xml M docs/topics/impala_runtime_bloom_filter_size.xml M docs/topics/impala_runtime_filter_max_size.xml M docs/topics/impala_runtime_filter_min_size.xml M docs/topics/impala_runtime_filtering.xml 8 files changed, 69 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/8986/2 -- To view, visit http://gerrit.cloudera.org:8080/8986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2 Gerrit-Change-Number: 8986 Gerrit-PatchSet: 2 Gerrit-Owner: John RussellGerrit-Reviewer: John Russell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Todd Lipcon
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 ) Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8865/1/docs/topics/impala_set.xml File docs/topics/impala_set.xml: http://gerrit.cloudera.org:8080/#/c/8865/1/docs/topics/impala_set.xml@60 PS1, Line 60: Regular Query > You can call these "Regular query options" Done http://gerrit.cloudera.org:8080/#/c/8865/1/docs/topics/impala_set.xml@90 PS1, Line 90: JDBC or ODBC > On these interfaces besides adding the 'level' column, this "SET" vs "SET A Done -- To view, visit http://gerrit.cloudera.org:8080/8865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61 Gerrit-Change-Number: 8865 Gerrit-PatchSet: 2 Gerrit-Owner: John RussellGerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 10 Jan 2018 05:48:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Hello Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8865 to look at the new patch set (#2). Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. IMPALA-2181: [DOCS] Document changes to SET output Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61 --- M docs/topics/impala_set.xml 1 file changed, 75 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8865/2 -- To view, visit http://gerrit.cloudera.org:8080/8865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61 Gerrit-Change-Number: 8865 Gerrit-PatchSet: 2 Gerrit-Owner: John RussellGerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/8942/2/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/8942/2/docs/shared/impala_common.xml@779 PS2, Line 779: IS [NOT] FALSE as equivalents for the functions > "builtin functions" instead of "functions" to match the blurb in the detail Done http://gerrit.cloudera.org:8080/#/c/8942/2/docs/topics/impala_operators.xml File docs/topics/impala_operators.xml: http://gerrit.cloudera.org:8080/#/c/8942/2/docs/topics/impala_operators.xml@1251 PS2, Line 1251: lets > nit: let Done http://gerrit.cloudera.org:8080/#/c/8942/2/docs/topics/impala_operators.xml@1320 PS2, Line 1320: lets > nit: let Done http://gerrit.cloudera.org:8080/#/c/8942/2/docs/topics/impala_operators.xml@1327 PS2, Line 1327: These operators are equivalent to the built-in conditional functions > sync this blurb with the one in the index (see comment there). Done. I'll reuse the wording verbatim with a conref= attribute. http://gerrit.cloudera.org:8080/#/c/8942/2/docs/topics/impala_operators.xml@1337 PS2, Line 1337: query error > must be same error as for "IS [NOT] NULL" for complex types? perhaps its le Done http://gerrit.cloudera.org:8080/#/c/8942/2/docs/topics/impala_operators.xml@1345 PS2, Line 1345: select assertion, b, b is true, b is false, b is unknown : from boolean_test; > just for my own info, but why is this lower-case whereas sql inlined in tex I usually save the strict uppercase-keyword style for the detailed syntax blocks. Especially for built-in functions, I use mostly lowercase to be modern-looking like C code. -- To view, visit http://gerrit.cloudera.org:8080/8942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Change-Number: 8942 Gerrit-PatchSet: 2 Gerrit-Owner: John RussellGerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Wed, 10 Jan 2018 05:42:25 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators
Hello Greg Rahn, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8942 to look at the new patch set (#3). Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. IMPALA-1767: [DOCS] Document new Boolean operators In a new subtopic: IS [NOT] TRUE IS [NOT] FALSE Folded into IS [NOT] NULL: IS [NOT] UNKNOWN Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala_conditional_functions.xml M docs/topics/impala_operators.xml 4 files changed, 129 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/8942/3 -- To view, visit http://gerrit.cloudera.org:8080/8942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Change-Number: 8942 Gerrit-PatchSet: 3 Gerrit-Owner: John RussellGerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] [DOCS] Recommend using Kudu Java API for rapid DMLs
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8976 ) Change subject: [DOCS] Recommend using Kudu Java API for rapid DMLs .. Patch Set 1: JD are you an Impala committer or should I hit up someone else for a +2? -- To view, visit http://gerrit.cloudera.org:8080/8976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0098f0c3d5d07c89e6bb589c4c04edce300c1ad3 Gerrit-Change-Number: 8976 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: John Russell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 10 Jan 2018 05:19:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell
Hello Lars Volker, David Knupp, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8771 to look at the new patch set (#3). Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. IMPALA-5736: [DOCS] Document --query_option for impala-shell Change-Id: I5fa4fc27d6566e87fdabe57edc176133d586a84b --- M docs/impala_keydefs.ditamap M docs/topics/impala_query_options.xml M docs/topics/impala_set.xml M docs/topics/impala_shell_options.xml 4 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/8771/3 -- To view, visit http://gerrit.cloudera.org:8080/8771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5fa4fc27d6566e87fdabe57edc176133d586a84b Gerrit-Change-Number: 8771 Gerrit-PatchSet: 3 Gerrit-Owner: John RussellGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: David Knupp Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker
[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8771/2/docs/topics/impala_shell_options.xml File docs/topics/impala_shell_options.xml: http://gerrit.cloudera.org:8080/#/c/8771/2/docs/topics/impala_shell_options.xml@284 PS2, Line 284: --query_option="option=value" > Maybe the short form -Q should be also mentioned here - as I see, both form Done -- To view, visit http://gerrit.cloudera.org:8080/8771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fa4fc27d6566e87fdabe57edc176133d586a84b Gerrit-Change-Number: 8771 Gerrit-PatchSet: 3 Gerrit-Owner: John RussellGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: David Knupp Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Wed, 10 Jan 2018 05:14:27 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 5: Tagging in Tim who reviewed the code. Some other committers not available to +2. -- To view, visit http://gerrit.cloudera.org:8080/8768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 Gerrit-Change-Number: 8768 Gerrit-PatchSet: 5 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: sandeep akinapelli Gerrit-Comment-Date: Wed, 10 Jan 2018 04:47:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6278: [DOCS] Add release note subtopics
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8992 ) Change subject: IMPALA-6278: [DOCS] Add release note subtopics .. Patch Set 1: I would tag in Greg but he's away until the 15th. -- To view, visit http://gerrit.cloudera.org:8080/8992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I968f53c6652197774cdec364c47bc10277e6877a Gerrit-Change-Number: 8992 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Wed, 10 Jan 2018 04:39:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6278: [DOCS] Add release note subtopics
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8992 Change subject: IMPALA-6278: [DOCS] Add release note subtopics .. IMPALA-6278: [DOCS] Add release note subtopics Primarily placeholders that link to the 2.11 CHANGELOG file on the web. Change-Id: I968f53c6652197774cdec364c47bc10277e6877a --- M docs/impala_keydefs.ditamap M docs/topics/impala_fixed_issues.xml M docs/topics/impala_incompatible_changes.xml M docs/topics/impala_new_features.xml 4 files changed, 50 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/8992/1 -- To view, visit http://gerrit.cloudera.org:8080/8992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I968f53c6652197774cdec364c47bc10277e6877a Gerrit-Change-Number: 8992 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page
John Russell has abandoned this change. ( http://gerrit.cloudera.org:8080/8648 ) Change subject: [DOCS] Include the current Impala version number on PDF title page .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/8648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2 Gerrit-Change-Number: 8648 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown
[Impala-ASF-CR] IMPALA-4252: [DOCS] Document min/max filters for Kudu tables
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8986 Change subject: IMPALA-4252: [DOCS] Document min/max filters for Kudu tables .. IMPALA-4252: [DOCS] Document min/max filters for Kudu tables Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2 --- M docs/shared/impala_common.xml M docs/topics/impala_disable_row_runtime_filtering.xml M docs/topics/impala_kudu.xml M docs/topics/impala_max_num_runtime_filters.xml M docs/topics/impala_runtime_bloom_filter_size.xml M docs/topics/impala_runtime_filter_max_size.xml M docs/topics/impala_runtime_filter_min_size.xml M docs/topics/impala_runtime_filtering.xml 8 files changed, 55 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/8986/1 -- To view, visit http://gerrit.cloudera.org:8080/8986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I15d8c952ab5b90e89fdd57640dfb4da882f7ecb2 Gerrit-Change-Number: 8986 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function
Hello Greg Rahn, sandeep akinapelli, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8768 to look at the new patch set (#5). Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala_datetime_functions.xml 3 files changed, 104 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/8768/5 -- To view, visit http://gerrit.cloudera.org:8080/8768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 Gerrit-Change-Number: 8768 Gerrit-PatchSet: 5 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: sandeep akinapelli
[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml@403 PS4, Line 403: values > TIMESTAMP value or values? 'values' is grammatically correct here. http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml@422 PS4, Line 422: TS > caps on TS and small TS mentioned earlier?? Sure. I follow a consistent pattern of capitalization for discussions in a pure SQL context - identifiers are lowercase in a statement like 'CREATE TABLE foo', but if I'm referring to the identifier itself I'll capitalize it, as in 'the table named FOO'. But in the discussions of built-in functions I use lowercase more frequently, more of a C-like style. http://gerrit.cloudera.org:8080/#/c/8768/4/docs/topics/impala_datetime_functions.xml@430 PS4, Line 430: one secon > what do you think about "one second" vs "second" Grammatically there would need to be one other word there, either "a second" or "one second". Let's leave it as-is. -- To view, visit http://gerrit.cloudera.org:8080/8768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 Gerrit-Change-Number: 8768 Gerrit-PatchSet: 4 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: sandeep akinapelli Gerrit-Comment-Date: Tue, 09 Jan 2018 20:04:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Recommend using Kudu Java API for rapid DMLs
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8976 Change subject: [DOCS] Recommend using Kudu Java API for rapid DMLs .. [DOCS] Recommend using Kudu Java API for rapid DMLs Change-Id: I0098f0c3d5d07c89e6bb589c4c04edce300c1ad3 --- M docs/topics/impala_jdbc.xml 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/8976/1 -- To view, visit http://gerrit.cloudera.org:8080/8976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0098f0c3d5d07c89e6bb589c4c04edce300c1ad3 Gerrit-Change-Number: 8976 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8942/1/docs/topics/impala_operators.xml File docs/topics/impala_operators.xml: http://gerrit.cloudera.org:8080/#/c/8942/1/docs/topics/impala_operators.xml@1345 PS1, Line 1345: b is true, b is false > Include IS_UNKNOWN in this example so it's shown somewhere. Then consider i Done -- To view, visit http://gerrit.cloudera.org:8080/8942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Change-Number: 8942 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 04 Jan 2018 19:58:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8942/1/docs/topics/impala_operators.xml File docs/topics/impala_operators.xml: http://gerrit.cloudera.org:8080/#/c/8942/1/docs/topics/impala_operators.xml@1345 PS1, Line 1345: b is true, b is false Include IS_UNKNOWN in this example so it's shown somewhere. Then consider if it makes sense to reuse or trim down this same example under IS NULL. -- To view, visit http://gerrit.cloudera.org:8080/8942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Change-Number: 8942 Gerrit-PatchSet: 2 Gerrit-Owner: John RussellGerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 04 Jan 2018 19:57:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators
Hello Greg Rahn, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8942 to look at the new patch set (#2). Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. IMPALA-1767: [DOCS] Document new Boolean operators Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala_conditional_functions.xml M docs/topics/impala_operators.xml 4 files changed, 129 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/8942/2 -- To view, visit http://gerrit.cloudera.org:8080/8942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Change-Number: 8942 Gerrit-PatchSet: 2 Gerrit-Owner: John RussellGerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 1: I put IS [NOT] UNKNOWN under the existing heading for IS [NOT] NULL since those forms are so similar. Then a separate new heading for IS TRUE / IS FALSE. -- To view, visit http://gerrit.cloudera.org:8080/8942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Change-Number: 8942 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 04 Jan 2018 19:40:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8942 Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. IMPALA-1767: [DOCS] Document new Boolean operators Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala_conditional_functions.xml M docs/topics/impala_operators.xml 4 files changed, 128 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/8942/1 -- To view, visit http://gerrit.cloudera.org:8080/8942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iefebf210418ec2d47b154bd37166b76720f085bb Gerrit-Change-Number: 8942 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8865 Change subject: IMPALA-2181: [DOCS] Document changes to SET output .. IMPALA-2181: [DOCS] Document changes to SET output Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61 --- M docs/topics/impala_set.xml 1 file changed, 73 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8865/1 -- To view, visit http://gerrit.cloudera.org:8080/8865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61 Gerrit-Change-Number: 8865 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 3: (1 comment) Serves me right for editing the output. (Had to fiddle with the query to get the exact same timestamp as before.) http://gerrit.cloudera.org:8080/#/c/8768/3/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/8768/3/docs/topics/impala_datetime_functions.xml@463 PS3, Line 463: select now(), date_trunc('microseconds', now()); : +---+---+ : | now() | date_trunc('second', now()) | > The query and 2nd column heading do not match Done -- To view, visit http://gerrit.cloudera.org:8080/8768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 Gerrit-Change-Number: 8768 Gerrit-PatchSet: 3 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: sandeep akinapelli Gerrit-Comment-Date: Mon, 11 Dec 2017 23:20:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 2: The details about 0/1 <=> Booleans and bad Booleans now being an error, I'm going to cover in downstream docs only, under "Incompatible Changes". -- To view, visit http://gerrit.cloudera.org:8080/8771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fa4fc27d6566e87fdabe57edc176133d586a84b Gerrit-Change-Number: 8771 Gerrit-PatchSet: 2 Gerrit-Owner: John RussellGerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: David Knupp Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Comment-Date: Mon, 11 Dec 2017 20:01:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function
Hello Greg Rahn, sandeep akinapelli, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8768 to look at the new patch set (#3). Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala_datetime_functions.xml 3 files changed, 104 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/8768/3 -- To view, visit http://gerrit.cloudera.org:8080/8768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 Gerrit-Change-Number: 8768 Gerrit-PatchSet: 3 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: sandeep akinapelli
[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml@400 PS2, Line 400: Strips off fields from a TIMESTAMP value > Can we use "truncates" not "strips off"? Done http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml@406 PS2, Line 406: Tabs! Don't know how those got in there. http://gerrit.cloudera.org:8080/#/c/8768/2/docs/topics/impala_datetime_functions.xml@455 PS2, Line 455: select now(), date_trunc('microseconds', now()); : +---+---+ : | now() | date_trunc('microseconds', now()) | : +---+---+ : | 2017-12-05 13:58:04.565403000 | 2017-12-05 13:58:04.565403000 | : +---+---+ > now() never returns any nanosecond values so probably not a great example Wow, even after I added the Note: above, I was fooled by the singular/plural business. I.e. thinking that 'microseconds' must set microseconds to zero rather setting everything _below_ a microsecond to zero. I'll add a little wording earlier on to reinforce where the precision boundary is. -- To view, visit http://gerrit.cloudera.org:8080/8768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 Gerrit-Change-Number: 8768 Gerrit-PatchSet: 2 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: sandeep akinapelli Gerrit-Comment-Date: Mon, 11 Dec 2017 19:46:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function
Hello Greg Rahn, sandeep akinapelli, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8768 to look at the new patch set (#2). Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala_datetime_functions.xml 3 files changed, 96 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/8768/2 -- To view, visit http://gerrit.cloudera.org:8080/8768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 Gerrit-Change-Number: 8768 Gerrit-PatchSet: 2 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: sandeep akinapelli
[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 2: Patch set 2 has 'nanoseconds' and 'quarter' removed. -- To view, visit http://gerrit.cloudera.org:8080/8768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 Gerrit-Change-Number: 8768 Gerrit-PatchSet: 2 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: sandeep akinapelli Gerrit-Comment-Date: Thu, 07 Dec 2017 22:08:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 1: Tagging in Alex for ability to +2 after Sandeep and Greg have taken a look. -- To view, visit http://gerrit.cloudera.org:8080/8768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 Gerrit-Change-Number: 8768 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: sandeep akinapelli Gerrit-Comment-Date: Tue, 05 Dec 2017 22:25:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 1: See my note in https://issues.apache.org/jira/browse/IMPALA-5317. I couldn't get date_trunc() to recognize 'nanoseconds' or 'quarter' as unit arguments. I left them in the doc for the moment on the assumption that that's a code bug. -- To view, visit http://gerrit.cloudera.org:8080/8768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 Gerrit-Change-Number: 8768 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: Greg Rahn Gerrit-Reviewer: John Russell Gerrit-Reviewer: sandeep akinapelli Gerrit-Comment-Date: Tue, 05 Dec 2017 22:23:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8768 Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 --- M docs/impala_keydefs.ditamap M docs/shared/impala_common.xml M docs/topics/impala_datetime_functions.xml 3 files changed, 98 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/8768/1 -- To view, visit http://gerrit.cloudera.org:8080/8768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifcf38903bb10db12cbb8d73a2dc875aef29cd359 Gerrit-Change-Number: 8768 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT .. Patch Set 1: Sure, if you would like to try editing the doc files. Please do that as a separate gerrit, and add me as a reviewer. -- To view, visit http://gerrit.cloudera.org:8080/8676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied7629d70197a0270cdc0853e00cc021fdb4dc20 Gerrit-Change-Number: 8676 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin ChulGerrit-Reviewer: Alex Behm Gerrit-Reviewer: John Russell Gerrit-Reviewer: Kim Jin Chul Gerrit-Comment-Date: Mon, 04 Dec 2017 07:50:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/7388 ) Change subject: IMPALA-4978 / IMPALA-5631: [DOCS] Add FQDN known issue .. Patch Set 4: OK, I loosened the wording to avoid promising a comprehensive fix. I see IMPALA-4978 is still open, so I presume nobody currently has a system with fixes for both IMPALA-4978 and IMPALA-5253. -- To view, visit http://gerrit.cloudera.org:8080/7388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib039d0102878f1c05470371f581cb258287b9bc0 Gerrit-Change-Number: 7388 Gerrit-PatchSet: 4 Gerrit-Owner: John RussellGerrit-Reviewer: Alex Behm Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: John Russell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Thu, 30 Nov 2017 20:56:22 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Include the current Impala version number on PDF title page
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8648 ) Change subject: [DOCS] Include the current Impala version number on PDF title page .. Patch Set 1: I wonder though do we need the ability to let the docs run at a slightly different schedule than the code. For example, today or tomorrow I want to republish the 2.10 docs to account for the removal of "incubating". Regardless of whether some part of the code in master is labelled with a version number of 2.11. -- To view, visit http://gerrit.cloudera.org:8080/8648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I66d6669769d2aa22602057bfcf5b29307e2a0fa2 Gerrit-Change-Number: 8648 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Michael Brown Gerrit-Comment-Date: Mon, 27 Nov 2017 21:15:30 + Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Modernize reference to the Incubator
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8647 Change subject: [DOCS] Modernize reference to the Incubator .. [DOCS] Modernize reference to the Incubator Instead of "accepted into", say when Impala "graduated from". Change-Id: I9681414b0e2031c62d522c98a9bcb5f74b4a3480 --- M docs/topics/impala_intro.xml 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/8647/1 -- To view, visit http://gerrit.cloudera.org:8080/8647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9681414b0e2031c62d522c98a9bcb5f74b4a3480 Gerrit-Change-Number: 8647 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell
[Impala-ASF-CR] IMPALA-6203: [DOCS] Take "incubating" out of documentation
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8578 ) Change subject: IMPALA-6203: [DOCS] Take "incubating" out of documentation .. Patch Set 1: Jim, is the official graduation date Nov. 15 (yesterday), not Nov. 16 (today)? I used Nov. 15 in my doc edit. -- To view, visit http://gerrit.cloudera.org:8080/8578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2b456076e9193b6364aec5083368b594fb51423 Gerrit-Change-Number: 8578 Gerrit-PatchSet: 1 Gerrit-Owner: John RussellGerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Comment-Date: Thu, 16 Nov 2017 21:19:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6203: [DOCS] Take "incubating" out of documentation
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8578 Change subject: IMPALA-6203: [DOCS] Take "incubating" out of documentation .. IMPALA-6203: [DOCS] Take "incubating" out of documentation This change removes all instances of 'incubating'. It also changes the wording around "entered the incubator" to reflect that Impala is now a TLP. Change-Id: Ib2b456076e9193b6364aec5083368b594fb51423 --- M docs/shared/impala_common.xml M docs/topics/impala.xml M docs/topics/impala_faq.xml M docs/topics/impala_fixed_issues.xml M docs/topics/impala_incompatible_changes.xml M docs/topics/impala_intro.xml M docs/topics/impala_known_issues.xml M docs/topics/impala_new_features.xml 8 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/8578/1 -- To view, visit http://gerrit.cloudera.org:8080/8578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2b456076e9193b6364aec5083368b594fb51423 Gerrit-Change-Number: 8578 Gerrit-PatchSet: 1 Gerrit-Owner: John Russell