[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2021-04-14 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has abandoned this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Abandoned

I don't think this patch is actively being worked upon anymore.
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 18
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-11-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has removed Anurag Mantripragada from this change.  ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Removed reviewer Anurag Mantripragada.
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 15
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-08-10 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has removed Tim Armstrong from this change.  ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Removed reviewer Tim Armstrong.
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 13
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-04-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 13: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5643/


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 13
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Mon, 13 Apr 2020 06:57:32 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 13:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/5791/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 13
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Mon, 13 Apr 2020 03:09:06 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-04-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 13:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5643/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 13
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Mon, 13 Apr 2020 02:25:05 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-04-12 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 13:

A couple of important events processor patches have landed in master. I will 
try another dry-run of this patch.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 13
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Mon, 13 Apr 2020 02:24:44 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-04-12 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#13). ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..

IMPALA-8795 : Enable event polling by default in dockerized tests.

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing [WIP]:
1. Ran core tests with USE_CDP_HIVE=true
2. Running exhaustive tests with USE_CDP_HIVE=false

Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
---
M docker/catalogd/Dockerfile
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_event_processing.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
M tests/util/event_processor_utils.py
12 files changed, 202 insertions(+), 133 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/14272/13
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 13
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 12: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5295/


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 12
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Fri, 07 Feb 2020 01:56:15 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 12:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/5143/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 12
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 06 Feb 2020 21:53:36 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-02-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#12). ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..

IMPALA-8795 : Enable event polling by default in dockerized tests.

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing [WIP]:
1. Ran core tests with USE_CDP_HIVE=true
2. Running exhaustive tests with USE_CDP_HIVE=false

Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
---
M docker/catalogd/Dockerfile
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_event_processing.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
M tests/util/event_processor_utils.py
12 files changed, 204 insertions(+), 140 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/14272/12
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 12
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 10: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5143/


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 10
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Tue, 29 Oct 2019 02:04:05 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 10:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4895/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 10
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Mon, 28 Oct 2019 22:19:09 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5143/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 10
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Mon, 28 Oct 2019 21:34:02 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-28 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 10:

Added miscellaneous logging changes. Will do a dry-run again.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 10
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Mon, 28 Oct 2019 21:33:28 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-28 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#10). ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..

IMPALA-8795 : Enable event polling by default in dockerized tests.

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
---
M docker/catalogd/Dockerfile
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_event_processing.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
M tests/util/event_processor_utils.py
12 files changed, 240 insertions(+), 223 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/14272/10
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 10
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 9: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5116/


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 9
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Mon, 21 Oct 2019 02:08:37 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 9:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4838/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 9
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Sun, 20 Oct 2019 22:33:05 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5116/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 9
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Sun, 20 Oct 2019 21:48:32 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#9). ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..

IMPALA-8795 : Enable event polling by default in dockerized tests.

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
---
M docker/catalogd/Dockerfile
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
M 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_event_processing.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
M tests/util/event_processor_utils.py
12 files changed, 193 insertions(+), 192 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/14272/9
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 9
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5075/


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 8
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 09 Oct 2019 04:33:14 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 8:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4755/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 8
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 09 Oct 2019 00:49:11 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5075/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 8
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 09 Oct 2019 00:09:18 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-10-08 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#8). ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..

IMPALA-8795 : Enable event polling by default in dockerized tests.

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
---
M docker/catalogd/Dockerfile
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_event_processing.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
M tests/util/event_processor_utils.py
9 files changed, 170 insertions(+), 168 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/14272/8
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 8
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5026/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 7
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 30 Sep 2019 14:19:54 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 7: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5025/


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 7
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 30 Sep 2019 09:36:59 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 7:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4677/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 7
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 30 Sep 2019 06:01:36 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5025/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 7
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 30 Sep 2019 05:21:34 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-29 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#7). ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..

IMPALA-8795 : Enable event polling by default in dockerized tests.

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
---
M docker/catalogd/Dockerfile
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_event_processing.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
M tests/util/event_processor_utils.py
9 files changed, 170 insertions(+), 168 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/14272/7
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 7
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4991/


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 6
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 24 Sep 2019 08:19:59 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4991/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 6
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 24 Sep 2019 04:12:34 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 6:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4619/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 6
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 24 Sep 2019 00:21:28 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 5:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4618/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 5
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 24 Sep 2019 00:19:25 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 6:

(2 comments)

Thanks for the pointers Tim. As discussed offline, I removed the unnecessary 
code and bumped up timeout to 10 seconds from 6 seconds. Will try to run the 
tests again and see if that helps.

http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py
File tests/util/event_processor_utils.py:

http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py@45
PS4, Line 45:
> nit: "is True" is not needed.
Done


http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py@69
PS4, Line 69:  return dict(pairs)
> My understanding was that the above function was checking the notification
What you said makes sense, this is probably not a delay of events generated 
from Hive. The flakiness maybe because of insufficient wait time for catalog 
update propagation in L68.



--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 6
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 23 Sep 2019 23:44:19 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#6). ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..

IMPALA-8795 : Enable event polling by default in dockerized tests.

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
---
M docker/catalogd/Dockerfile
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_event_processing.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
M tests/util/event_processor_utils.py
9 files changed, 165 insertions(+), 169 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/14272/6
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 6
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Anurag Mantripragada (Code Review)
Hello Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14272

to look at the new patch set (#5).

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..

IMPALA-8795 : Enable event polling by default in dockerized tests.

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
---
M docker/catalogd/Dockerfile
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_event_processing.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
M tests/util/event_processor_utils.py
9 files changed, 167 insertions(+), 169 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/14272/5
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 5
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4989/


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 23 Sep 2019 21:31:30 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py
File tests/util/event_processor_utils.py:

http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py@45
PS4, Line 45: is True
nit: "is True" is not needed.


http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py@69
PS4, Line 69:   time.sleep(total_timeout)
> The flakiness is coming from the logic in the above function. During parall
My understanding was that the above function was checking the notification ID 
from Hive at the time it was called and waiting until the event processors 
catch up. This seems like it should work fine, regardless of concurrency, so 
long as it's called after the notification is generated.

I'm not understanding why that isn't sufficient - is there some delay between 
the hive statement finishing and get_current_notificationEventId() returning 
the event ID from that Hive statement?

Actually I don't understand why the is_hive_insert bit is necessary, either, 
since I would have expected all the notifications to be incremented on the hive 
side after the insert statement finishes.



--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 23 Sep 2019 21:25:15 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py
File tests/util/event_processor_utils.py:

http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py@69
PS4, Line 69:   time.sleep(total_timeout)
> Sleeps in tests are really not a good practice unless you're actually direc
The flakiness is coming from the logic in the above function. During parallel 
runs events are generated by deferent tests and thus changing the event_id 
counter resulting in the above function to return for incorrect reasons.

This function, however waits for sufficient amount observed to have the update 
propagated. I agree that this is brittle.

I will try to change this to wait till actual catalog update propagation, if it 
is possible.



--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 23 Sep 2019 20:52:10 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py
File tests/util/event_processor_utils.py:

http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py@69
PS4, Line 69:   time.sleep(total_timeout)
Sleeps in tests are really not a good practice unless you're actually directly 
testing something timing-related, things end up being slow and brittle.

Why is this less flaky than the above function? Can we deflake the above 
function?

Is the flakiness coming from the logic around the notification ids, or waiting 
for the catalog update to propagate?

It seems like we could directly check for the catalog update by checking when 
the catalog version gets propagated. I guess the catalog doesn't actually 
expose its latest version, but that seems like an oversight.



--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 23 Sep 2019 19:08:01 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4614/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 23 Sep 2019 17:36:42 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4989/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 23 Sep 2019 17:19:29 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 4:

If test are run in parallel, EventProcessorUtils.wait_for_event_processing() 
should be avoided as it is flaky. Added an alternative method 
EventProcessorUtils.wait_for_refresh() for parallel runs.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 23 Sep 2019 16:57:44 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-23 Thread Anurag Mantripragada (Code Review)
Hello Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14272

to look at the new patch set (#4).

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..

IMPALA-8795 : Enable event polling by default in dockerized tests.

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
---
M docker/catalogd/Dockerfile
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_event_processing.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
M tests/util/event_processor_utils.py
9 files changed, 184 insertions(+), 172 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/14272/4
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 4
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 3:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4986/


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 21 Sep 2019 20:07:01 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4986/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 21 Sep 2019 15:55:05 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 3:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4985/


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 21 Sep 2019 04:14:35 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4985/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Sat, 21 Sep 2019 00:03:55 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4984/


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 20 Sep 2019 23:33:44 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4984/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 20 Sep 2019 23:16:44 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 20 Sep 2019 23:16:43 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4608/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 20 Sep 2019 22:13:52 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 20 Sep 2019 21:39:47 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14272 )

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14272/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14272/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-8795 : Enable event polling by default in dockerized tests.
> Should be "in dockerized tests" - this makes it sound like it's enabled for
Done


http://gerrit.cloudera.org:8080/#/c/14272/1//COMMIT_MSG@13
PS1, Line 13: Testing:
> Can update this now?
Done


http://gerrit.cloudera.org:8080/#/c/14272/1/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/14272/1/tests/custom_cluster/test_event_processing.py@a43
PS1, Line 43:
> It doesn't really make sense to remove thse execute_serially markers for cu
Done


http://gerrit.cloudera.org:8080/#/c/14272/1/tests/util/event_processor_utils.py
File tests/util/event_processor_utils.py:

http://gerrit.cloudera.org:8080/#/c/14272/1/tests/util/event_processor_utils.py@45
PS1, Line 45: is_hive_inse
> should be is_hive_insert
Done



--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 20 Sep 2019 21:33:30 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2019-09-20 Thread Anurag Mantripragada (Code Review)
Hello Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14272

to look at the new patch set (#2).

Change subject: IMPALA-8795 : Enable event polling by default in dockerized 
tests.
..

IMPALA-8795 : Enable event polling by default in dockerized tests.

Most of the fixes for event processing are committed. This change
enables the feature by default for all the tests so that eventually we
can turn it on out of the box.

Testing:
1. Ran all the tests with the patch and confirmed that there are no test
failures
2. Ran all the tests with CDP build.

Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
---
M docker/catalogd/Dockerfile
M tests/common/environ.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_event_processing.py
M tests/custom_cluster/test_hive_parquet_codec_interop.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_refresh_partition.py
M tests/util/event_processor_utils.py
9 files changed, 175 insertions(+), 172 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/14272/2
--
To view, visit http://gerrit.cloudera.org:8080/14272
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972
Gerrit-Change-Number: 14272
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong