[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. IMPALA-9028: impala-shell should not try to reconnect if quitting When the impala-shell is disconnected, it will try to reconnect for any command that a user runs (as part of ImpalaShell's precmd()). This doesn't make sense when the user is trying to quit the shell (i.e. by typing 'quit' or 'exit' or hitting Ctrl-D). This skips the attempt to reconnect when quitting the shell. Testing: - Added test in test_shell_interactive.py - Verified by hand Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Reviewed-on: http://gerrit.cloudera.org:8080/14391 Reviewed-by: Thomas Tauber-Marshall Tested-by: Impala Public Jenkins --- M shell/impala_shell.py M tests/shell/test_shell_interactive.py 2 files changed, 23 insertions(+), 1 deletion(-) Approvals: Thomas Tauber-Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 16 Oct 2019 01:46:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 16 Oct 2019 00:38:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4801/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 15 Oct 2019 22:08:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5093/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 15 Oct 2019 21:26:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 15 Oct 2019 21:25:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14391 to look at the new patch set (#3). Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. IMPALA-9028: impala-shell should not try to reconnect if quitting When the impala-shell is disconnected, it will try to reconnect for any command that a user runs (as part of ImpalaShell's precmd()). This doesn't make sense when the user is trying to quit the shell (i.e. by typing 'quit' or 'exit' or hitting Ctrl-D). This skips the attempt to reconnect when quitting the shell. Testing: - Added test in test_shell_interactive.py - Verified by hand Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e --- M shell/impala_shell.py M tests/shell/test_shell_interactive.py 2 files changed, 23 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/14391/3 -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14391/2/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/14391/2/tests/shell/test_shell_interactive.py@243 PS2, Line 243: result = run_impala_shell_interactive(vector, 'quit;', shell_args=['-ifoo'], > Maybe add a case with a different command that does result in a "reconnect" Good point, added a case that does reconnect -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 15 Oct 2019 21:22:26 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14391/2/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/14391/2/tests/shell/test_shell_interactive.py@243 PS2, Line 243: result = run_impala_shell_interactive(vector, 'quit;', shell_args=['-ifoo'], Maybe add a case with a different command that does result in a "reconnect"? -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 15 Oct 2019 21:07:04 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4799/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 15 Oct 2019 21:03:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 2: Added test and rebased -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 15 Oct 2019 20:20:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5092/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 15 Oct 2019 20:20:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14391 to look at the new patch set (#2). Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. IMPALA-9028: impala-shell should not try to reconnect if quitting When the impala-shell is disconnected, it will try to reconnect for any command that a user runs (as part of ImpalaShell's precmd()). This doesn't make sense when the user is trying to quit the shell (i.e. by typing 'quit' or 'exit' or hitting Ctrl-D). This skips the attempt to reconnect when quitting the shell. Testing: - Added test in test_shell_interactive.py - Verified by hand Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e --- M shell/impala_shell.py M tests/shell/test_shell_interactive.py 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/14391/2 -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14391/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14391/1//COMMIT_MSG@16 PS1, Line 16: Testing: Hmm, I wonder how difficult it would be to write an automated test for this, eg. in test_shell_interactive by specifying an invalid impalad hostname, running a "quit", and checking for "reconnecting" in the output. Not a big deal if its too complicated. -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Mon, 14 Oct 2019 19:45:21 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 09 Oct 2019 02:39:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4754/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 08 Oct 2019 23:02:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 ) Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5073/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 08 Oct 2019 22:24:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9028: impala-shell should not try to reconnect if quitting
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14391 Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting .. IMPALA-9028: impala-shell should not try to reconnect if quitting When the impala-shell is disconnected, it will try to reconnect for any command that a user runs (as part of ImpalaShell's precmd()). This doesn't make sense when the user is trying to quit the shell (i.e. by typing 'quit' or 'exit' or hitting Ctrl-D). This skips the attempt to reconnect when quitting the shell. Testing: - Ran shell end to end tests - Verified by hand Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e --- M shell/impala_shell.py 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/14391/1 -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
