[kudu-CR] [CMakeLists.txt] dot is mandatory for doxygen
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3855 Change subject: [CMakeLists.txt] dot is mandatory for doxygen .. [CMakeLists.txt] dot is mandatory for doxygen Require dot (graphviz) support for doxygen since the dot is needed when generating Kudu C++ client API documentation. This addresses the following JIRA issue(s): KUDU-1543: doxygen: graphviz dependency not documented Change-Id: I3466a587f98a528d9aa57edd4f4e96684b6922a2 --- M CMakeLists.txt 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/3855/1 -- To view, visit http://gerrit.cloudera.org:8080/3855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3466a587f98a528d9aa57edd4f4e96684b6922a2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin
[kudu-CR] [CMakeLists.txt] dot is mandatory for doxygen
Kudu Jenkins has posted comments on this change. Change subject: [CMakeLists.txt] dot is mandatory for doxygen .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2729/ -- To view, visit http://gerrit.cloudera.org:8080/3855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3466a587f98a528d9aa57edd4f4e96684b6922a2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3668 to look at the new patch set (#5). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode Implemented AUTO_FLUSH_BACKGROUND for C++ client library. KuduSession instance starts a dedicated background flusher thread to perform flush in background. In AUTO_FLUSH_BACKGROUND mode, the KuduSession::Apply() method blocks if running out of space in 'virtual buffer': there isn't a single buffer as is, there is a set of buffered write operations used by multiple batchers. The limit on the buffer size can be set by KuduSession::SetMutationBufferSpace(). The background flusher uses high-watermark approach for its flush criterion: it counts buffer size used by not-yet-flushed write operations. The data flow control implemented by KuduSession::Apply() combines high-/low-watermark approach for its pause/continue criterion: it counts total buffer size used by write operations. This change also addresses the following JIRA issue(s): KUDU-1376 KuduSession::SetMutationBufferSpace is not defined Change-Id: Idfde05bef342db24990c6e3da3b0270c3bb37a9d --- M src/kudu/client/batcher.cc M src/kudu/client/batcher.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h M src/kudu/util/monotime.cc M src/kudu/util/monotime.h 9 files changed, 876 insertions(+), 116 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/3668/5 -- To view, visit http://gerrit.cloudera.org:8080/3668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idfde05bef342db24990c6e3da3b0270c3bb37a9d Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2728/ -- To view, visit http://gerrit.cloudera.org:8080/3668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfde05bef342db24990c6e3da3b0270c3bb37a9d Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Rename Remote Bootstrap: some manual changes
Mike Percy has posted comments on this change. Change subject: Rename Remote Bootstrap: some manual changes .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Rename Remote Bootstrap: some manual changes
Kudu Jenkins has posted comments on this change. Change subject: Rename Remote Bootstrap: some manual changes .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2727/ -- To view, visit http://gerrit.cloudera.org:8080/3852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Rename Remote Bootstrap: some manual changes
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3852 to look at the new patch set (#2). Change subject: Rename Remote Bootstrap: some manual changes .. Rename Remote Bootstrap: some manual changes This patch has a bunch more manual fixes to replace "Remote Bootstrap" terminology with "Tablet Copy". I looked through the previous (automatic) diff and tried to clean up comments and variable names to be more clear, as well as find other abbreviated cases like the term 'bootstrap' or 'rb' which needed to be updated. This still doesn't do the file renames. That's yet to come. Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce --- M docs/design-docs/README.md M docs/design-docs/raft-config-change.md M docs/design-docs/raft-remote-bootstrap.md M docs/whitepaper/kudu.tex M src/kudu/consensus/consensus.proto M src/kudu/consensus/consensus_peers.cc M src/kudu/consensus/consensus_peers.h M src/kudu/consensus/consensus_queue-test.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/consensus_queue.h M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/delete_table-test.cc M src/kudu/integration-tests/remote_bootstrap-itest.cc M src/kudu/integration-tests/tablet_replacement-itest.cc M src/kudu/tablet/metadata.proto M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tserver/remote_bootstrap_client.cc M src/kudu/tserver/remote_bootstrap_client.h M src/kudu/tserver/remote_bootstrap_service.cc M src/kudu/tserver/ts_tablet_manager.cc 21 files changed, 167 insertions(+), 167 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/3852/2 -- To view, visit http://gerrit.cloudera.org:8080/3852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] Rename remote bootstrap files to 'tablet copy'
Mike Percy has posted comments on this change. Change subject: Rename remote bootstrap files to 'tablet copy' .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f31fb72d11d16ee05bf90be3a7c77a82e5db6f7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Rename Remote Bootstrap: some manual changes
Mike Percy has posted comments on this change. Change subject: Rename Remote Bootstrap: some manual changes .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3852/1/docs/design-docs/raft-remote-bootstrap.md File docs/design-docs/raft-remote-bootstrap.md: Line 58: ## Design & implementation of tablet Tablet Copy nit: tablet Tablet Copy. If this is too painful to rebase from then we can fix after -- To view, visit http://gerrit.cloudera.org:8080/3852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] [C++ client] doxygenized all C++ client API
Adar Dembo has posted comments on this change.
Change subject: [C++ client] doxygenized all C++ client API
..
Patch Set 2:
(86 comments)
Looks like client_samples-test failed, btw.
http://gerrit.cloudera.org:8080/#/c/3840/2/src/kudu/client/callbacks.h
File src/kudu/client/callbacks.h:
Line 60: /// The absolute time when the loggin event is generated.
"when the log event was"
Line 62: /// The message to log. It's not terminated with an endline.
Nit: you have two spaces here after the period.
http://gerrit.cloudera.org:8080/#/c/3840/2/src/kudu/client/client.h
File src/kudu/client/client.h:
Line 309: /// Result parameter @c tables is appended only on success.
Maybe "The placeholder for the result. Appended only on success"?
http://gerrit.cloudera.org:8080/#/c/3840/2/src/kudu/client/resource_metrics.h
File src/kudu/client/resource_metrics.h:
Line 45: /// The increment/decrement to aggregate.
Maybe "The amount to increment/decrement", with some mention of how amount can
be negative for decrement?
Line 48: /// Get current count for the specified metrics.
"specified metric" since it's just one metric.
http://gerrit.cloudera.org:8080/#/c/3840/2/src/kudu/client/scan_batch.h
File src/kudu/client/scan_batch.h:
Line 44: /// As a result of a scan operation, KuduScanner object returns batch
of
Maybe something like "Every call to KuduScanner::NextBatch() returns a batch of
zero or more rows."
Line 105: /// The returned object is only valid for as long as this
KuduScanBatch.
Nit: "for as long as this KuduScanBatch is valid"
Line 127: class KUDU_EXPORT KuduScanBatch::RowPtr {
A @brief for this?
Line 136: bool IsNull(const Slice& col_name) const;
No summarizing sentences for the two IsNull() methods?
Line 155: ///@{
Clever.
Line 172: /// since using indices avoid a hashmap lookup, so index-based
getters
Nit: avoids. Below too.
PS2, Line 179: /// Note that the method does not copy the value. Callers
should copy
: /// the resulting Slice if necessary.
Doesn't seem right for these getters.
Line 201: /// @name Getters for string/binary column by column name
Nit: missing terminating period. Below too.
PS2, Line 255: -- useful
: /// for outputting information into the log.
Nit: just drop the addendum; "string representation..." is sufficient.
Line 281: class KUDU_EXPORT KuduScanBatch::const_iterator
No @brief?
Line 311: /// of the same batch row.
Nit: "of the same batch"
Line 312: bool operator==(const const_iterator& other) const {
No summarizing sentence for this or operator!= ?
PS2, Line 318: different row
: /// of or associated with a different batch row.
Maybe "different row in the same batch, or to a row belonging to a different
batch altogether?"
http://gerrit.cloudera.org:8080/#/c/3840/2/src/kudu/client/schema.h
File src/kudu/client/schema.h:
Line 151: /// Column attributes.
Nit: Column storage attributes.
Line 158: /// Construct KuduColumnSchema object as a copy of other object.
Nit: "as a copy from another object".
Alternatively, do we even need to document the copy constructor and assignment
operator? We don't document the destructor, and these two methods behave as any
copy constructor and assignment operator behave, right?
Line 172: /// Make this object an identical copy of other one.
Nit: "of the other one."
Line 178: /// Check whether the object is identical to the other.
Nit: "identical to the other one."
PS2, Line 229: When inserting a new row with no value for this column,
: /// the default value will also be used.
Nit: "The default value will also be used when inserting a new row with no
value for this column." Maybe merge with the previous paragraph to better
connect.
Line 233: /// The value to use as the default. The KuduColumnSpec takes
ownership
Got two spaces after the period here.
Line 239: /// Set the preferred compression for the column.
Nit: "compression type"
Line 242: /// The compression to use.
Nit: "compression type"
Line 279: /// Set this column to be the primary key of the table.
Nit: "Set the column" to be consistent.
Line 304: /// Set the type of the column.
Nit: "data type". Below too.
Line 317: /// Remove the default value for this column.
Nit: "for the column"
Line 380: KuduColumnSpec* AddColumn(const std::string& name);
Nit: summarizing sentence?
Line 394: /// The placeholder for the result schema. Upon successful
completion,
Nit: two spaces.
Line 408: /// @brief A representation of schema.
Nit: perhaps "of a table's schema"?
Line 413: /// Create a KuduSchema object as a copy of the other one.
As I wrote in an earlier comment, do we have to document constructors/operators
whose behavior is basically the default?
Line 446: bool Equals(const KuduSchema& other) const;
Missing summarizing senten
[kudu-CR] KUDU-1500: Fix the data race during RaftConsensusITest.TestCorruptReplicaMetadata
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Fix the data race during RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 2: (2 comments) TFTR Dan, please see responses inline, I would like to follow up on this discussion on JIRA page, adding todd and mpercy in the loop there. http://gerrit.cloudera.org:8080/#/c/3823/2//COMMIT_MSG Commit Message: Line 11: the partition schema is accessed in an unguarded manner from another > This is pretty confusing to me, because once a tablet is created, the parti This follows the remote bootstrap(now tablet copy) path and there are at least couple of use cases which fall under this. In the current situation, the leader detects a failed tablet replica(perhaps via reporting? me not sure) and tries to resurrect the on disk tablet metadata for that replica which is followed by in-memory updates too. The attributes partition and schema are hanging off the tablet metadata structure and hence inevitably become part of resurrection path. We took an easier approach to this problem, although I agree with you that it may need some more thoughts to elegantly solve this. I would like to take the discussion in JIRA because it's easier to see the history of these discusssions on JIRA page than on gerritt review page IMO. http://gerrit.cloudera.org:8080/#/c/3823/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 177: attrs["partition"] = metadata_->partition_schema().PartitionDebugString( > if this is just a formatting change, please leave it the way it was. Sounds good, it looks like I touched some of these lines, but forgot to revert them back to original format when I reverted them later. -- To view, visit http://gerrit.cloudera.org:8080/3823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If57617e22b41296b8d4e8ad131220f1ebb235019 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] WIP [java client] Support add/remove partition
Dan Burkert has abandoned this change. Change subject: WIP [java client] Support add/remove partition .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/3731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iba18cbaf87bb738af7f108311ecc5738129ae092 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP: add to JD's WIP add/drop range partition work for java client
Dan Burkert has abandoned this change. Change subject: WIP: add to JD's WIP add/drop range partition work for java client .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/3735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id0e7763c03a13e4fb80417dc897f0e28c1d40e70 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] Support add/remove partition
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3854 to review the following change. Change subject: [java client] Support add/remove partition .. [java client] Support add/remove partition This also sneaks a fix into catalog manager to change the status type when rejecting invalid alter table partitioning operations. Change-Id: If5da5f0d3e677e62256a8a6d2107093bbda44cde --- M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableLocationsRequest.java D java/kudu-client/src/main/java/org/apache/kudu/client/NonCoveredRangeCache.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java A java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java M src/kudu/master/catalog_manager.cc 13 files changed, 830 insertions(+), 276 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/3854/1 -- To view, visit http://gerrit.cloudera.org:8080/3854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If5da5f0d3e677e62256a8a6d2107093bbda44cde Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [java client] Support add/remove partition
Kudu Jenkins has posted comments on this change. Change subject: [java client] Support add/remove partition .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2726/ -- To view, visit http://gerrit.cloudera.org:8080/3854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5da5f0d3e677e62256a8a6d2107093bbda44cde Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java-client] Re-enable multi-master tests
Adar Dembo has submitted this change and it was merged. Change subject: [java-client] Re-enable multi-master tests .. [java-client] Re-enable multi-master tests This patch makes TestMasterFailover useful again. It also adds the killing of masters to ITClient. Finally, it sets the raft heartbeat lower so that we don't wait 1.5s for leader elections. TestGetMasterRegistrationReceived was added since a previous version of this patch encountered a bug that such a simple unit test can detect. Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Reviewed-on: http://gerrit.cloudera.org:8080/3654 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationReceived.java M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestGetMasterRegistrationReceived.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java 6 files changed, 252 insertions(+), 34 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [java-client] Re-enable multi-master tests
Todd Lipcon has posted comments on this change. Change subject: [java-client] Re-enable multi-master tests .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Rename Remote Bootstrap: some manual changes
Kudu Jenkins has posted comments on this change. Change subject: Rename Remote Bootstrap: some manual changes .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2724/ -- To view, visit http://gerrit.cloudera.org:8080/3852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Rename remote bootstrap files to 'tablet copy'
Kudu Jenkins has posted comments on this change. Change subject: Rename remote bootstrap files to 'tablet copy' .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2725/ -- To view, visit http://gerrit.cloudera.org:8080/3853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f31fb72d11d16ee05bf90be3a7c77a82e5db6f7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Rename remote bootstrap files to 'tablet copy'
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3853 to review the following change. Change subject: Rename remote bootstrap files to 'tablet copy' .. Rename remote bootstrap files to 'tablet copy' Change-Id: I3f31fb72d11d16ee05bf90be3a7c77a82e5db6f7 --- M src/kudu/integration-tests/CMakeLists.txt R src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/tserver/CMakeLists.txt R src/kudu/tserver/tablet_copy-test-base.h R src/kudu/tserver/tablet_copy.proto R src/kudu/tserver/tablet_copy_client-test.cc R src/kudu/tserver/tablet_copy_client.cc R src/kudu/tserver/tablet_copy_client.h R src/kudu/tserver/tablet_copy_service-test.cc R src/kudu/tserver/tablet_copy_service.cc R src/kudu/tserver/tablet_copy_service.h R src/kudu/tserver/tablet_copy_session-test.cc R src/kudu/tserver/tablet_copy_session.cc R src/kudu/tserver/tablet_copy_session.h M src/kudu/tserver/tablet_server-test-base.h M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc 18 files changed, 31 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/3853/1 -- To view, visit http://gerrit.cloudera.org:8080/3853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3f31fb72d11d16ee05bf90be3a7c77a82e5db6f7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mike Percy
[kudu-CR] Rename Remote Bootstrap: some manual changes
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3852 to review the following change. Change subject: Rename Remote Bootstrap: some manual changes .. Rename Remote Bootstrap: some manual changes This patch has a bunch more manual fixes to replace "Remote Bootstrap" terminology with "Tablet Copy". I looked through the previous (automatic) diff and tried to clean up comments and variable names to be more clear, as well as find other abbreviated cases like the term 'bootstrap' or 'rb' which needed to be updated. This still doesn't do the file renames. That's yet to come. Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce --- M docs/design-docs/README.md M docs/design-docs/raft-config-change.md M docs/design-docs/raft-remote-bootstrap.md M docs/whitepaper/kudu.tex M src/kudu/consensus/consensus.proto M src/kudu/consensus/consensus_peers.cc M src/kudu/consensus/consensus_peers.h M src/kudu/consensus/consensus_queue-test.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/consensus_queue.h M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/delete_table-test.cc M src/kudu/integration-tests/remote_bootstrap-itest.cc M src/kudu/integration-tests/tablet_replacement-itest.cc M src/kudu/tablet/metadata.proto M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tserver/remote_bootstrap_client.cc M src/kudu/tserver/remote_bootstrap_client.h M src/kudu/tserver/remote_bootstrap_service.cc M src/kudu/tserver/ts_tablet_manager.cc 21 files changed, 167 insertions(+), 167 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/3852/1 -- To view, visit http://gerrit.cloudera.org:8080/3852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e2860b64e46c5cc021cb8574e6845d7bcb27cce Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mike Percy
[kudu-CR] [java client] Upgrade hadoop-client to 2.7.2
Adar Dembo has submitted this change and it was merged. Change subject: [java client] Upgrade hadoop-client to 2.7.2 .. [java client] Upgrade hadoop-client to 2.7.2 With the old version, I was hitting HADOOP-10961 when running kudu-mapreduce:TestOutputFormatJob locally. Now, the test passes. Strange that this isn't happening in gerrit builds though. Now we depend on upstream hadoop artifacts now instead of CDH artifacts. Change-Id: I06ccff7acbd0286f2bd11c41474bf754e9eb5f56 Reviewed-on: http://gerrit.cloudera.org:8080/3849 Reviewed-by: Dan Burkert Tested-by: Kudu Jenkins --- M java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06ccff7acbd0286f2bd11c41474bf754e9eb5f56 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)
Todd Lipcon has submitted this change and it was merged. Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Rename Remote Bootstrap to Tablet Copy (part 1) This does a bunch of automated substitutions of the terminology, renaming "remote bootstrap" to "tablet copy". This commit does not rename the files yet, so that it's easier to review without combining a file name change with the file content change. This is an incompatible change since some flag and metric names are changed. Another follow-up will have to add release notes. Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6 Reviewed-on: http://gerrit.cloudera.org:8080/3848 Reviewed-by: Alexey Serbin Tested-by: Kudu Jenkins Reviewed-by: Mike Percy --- M docs/contributing.adoc M docs/design-docs/README.md M docs/design-docs/raft-config-change.md M docs/design-docs/raft-remote-bootstrap.md M docs/whitepaper/kudu.tex M src/kudu/consensus/consensus.proto M src/kudu/consensus/consensus_peers.cc M src/kudu/consensus/consensus_peers.h M src/kudu/consensus/consensus_queue-test.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/consensus_queue.h M src/kudu/consensus/log_util.cc M src/kudu/consensus/raft_consensus-test.cc M src/kudu/integration-tests/client_failover-itest.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/delete_table-test.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/remote_bootstrap-itest.cc M src/kudu/integration-tests/tablet_replacement-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/tablet/metadata.proto M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_metadata.h M src/kudu/tablet/tablet_peer.cc M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/remote_bootstrap-test-base.h M src/kudu/tserver/remote_bootstrap.proto M src/kudu/tserver/remote_bootstrap_client-test.cc M src/kudu/tserver/remote_bootstrap_client.cc M src/kudu/tserver/remote_bootstrap_client.h M src/kudu/tserver/remote_bootstrap_service-test.cc M src/kudu/tserver/remote_bootstrap_service.cc M src/kudu/tserver/remote_bootstrap_service.h M src/kudu/tserver/remote_bootstrap_session-test.cc M src/kudu/tserver/remote_bootstrap_session.cc M src/kudu/tserver/remote_bootstrap_session.h M src/kudu/tserver/tablet_peer_lookup.h M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/tserver/tserver.proto 46 files changed, 640 insertions(+), 640 deletions(-) Approvals: Mike Percy: Looks good to me, approved Alexey Serbin: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)
Mike Percy has posted comments on this change. Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java client] Upgrade hadoop-client to 2.7.2
Dan Burkert has posted comments on this change. Change subject: [java client] Upgrade hadoop-client to 2.7.2 .. Patch Set 1: Code-Review+2 Thanks, I was hitting this as well. -- To view, visit http://gerrit.cloudera.org:8080/3849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06ccff7acbd0286f2bd11c41474bf754e9eb5f56 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2723/ -- To view, visit http://gerrit.cloudera.org:8080/3668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfde05bef342db24990c6e3da3b0270c3bb37a9d Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3668 to look at the new patch set (#4). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode Implemented AUTO_FLUSH_BACKGROUND for C++ client library. KuduSession instance starts a dedicated background flusher thread to perform flush in background. In AUTO_FLUSH_BACKGROUND mode, the KuduSession::Apply() method blocks if running out of space in 'virtual buffer': there isn't a single buffer as is, there is a set of buffered write operations used by multiple batchers. The limit on the buffer size can be set by KuduSession::SetMutationBufferSpace(). The background flusher uses high-watermark approach for its flush criterion: it counts buffer size used by not-yet-flushed write operations. The data flow control implemented by KuduSession::Apply() combines high-/low-watermark approach for its pause/continue criterion: it counts total buffer size used by write operations. This change also addresses the following JIRA issue(s): KUDU-1376 KuduSession::SetMutationBufferSpace is not defined Change-Id: Idfde05bef342db24990c6e3da3b0270c3bb37a9d --- M src/kudu/client/batcher.cc M src/kudu/client/batcher.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h M src/kudu/util/monotime.cc M src/kudu/util/monotime.h 9 files changed, 869 insertions(+), 114 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/3668/4 -- To view, visit http://gerrit.cloudera.org:8080/3668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idfde05bef342db24990c6e3da3b0270c3bb37a9d Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [java client] Upgrade hadoop-client to 2.7.2
Kudu Jenkins has posted comments on this change. Change subject: [java client] Upgrade hadoop-client to 2.7.2 .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2722/ -- To view, visit http://gerrit.cloudera.org:8080/3849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06ccff7acbd0286f2bd11c41474bf754e9eb5f56 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] Re-enable multi-master tests
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3654 to look at the new patch set (#5). Change subject: [java-client] Re-enable multi-master tests .. [java-client] Re-enable multi-master tests This patch makes TestMasterFailover useful again. It also adds the killing of masters to ITClient. Finally, it sets the raft heartbeat lower so that we don't wait 1.5s for leader elections. TestGetMasterRegistrationReceived was added since a previous version of this patch encountered a bug that such a simple unit test can detect. Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 --- M java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationReceived.java M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestGetMasterRegistrationReceived.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java 6 files changed, 252 insertions(+), 34 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/3654/5 -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [java-client] Re-enable multi-master tests
Kudu Jenkins has posted comments on this change. Change subject: [java-client] Re-enable multi-master tests .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2721/ -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java client] Upgrade hadoop-client to 2.7.2
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3849 to review the following change. Change subject: [java client] Upgrade hadoop-client to 2.7.2 .. [java client] Upgrade hadoop-client to 2.7.2 With the old version, I was hitting HADOOP-10961 when running kudu-mapreduce:TestOutputFormatJob locally. Now, the test passes. Strange that this isn't happening in gerrit builds though. Now we depend on upstream hadoop artifacts now instead of CDH artifacts. Change-Id: I06ccff7acbd0286f2bd11c41474bf754e9eb5f56 --- M java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/3849/1 -- To view, visit http://gerrit.cloudera.org:8080/3849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I06ccff7acbd0286f2bd11c41474bf754e9eb5f56 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert
[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)
Todd Lipcon has posted comments on this change. Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Patch Set 1: yea, I'm also currently going through and doing a bunch of manual cleanup/edits for things that my find-replace missed. Was planning on doing that in a second patch, and then the file renames in a third. -- To view, visit http://gerrit.cloudera.org:8080/3848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)
Alexey Serbin has posted comments on this change. Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Patch Set 2: Code-Review+1 > Build Started http://104.196.14.100/job/kudu-gerrit/2720/ The renaming of files like remote_bootstrap_xxx --> tablet_copy_xxx is scheduled for Part2, isn't it? -- To view, visit http://gerrit.cloudera.org:8080/3848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)
Kudu Jenkins has posted comments on this change. Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2720/ -- To view, visit http://gerrit.cloudera.org:8080/3848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)
Hello Mike Percy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3848 to look at the new patch set (#2). Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Rename Remote Bootstrap to Tablet Copy (part 1) This does a bunch of automated substitutions of the terminology, renaming "remote bootstrap" to "tablet copy". This commit does not rename the files yet, so that it's easier to review without combining a file name change with the file content change. This is an incompatible change since some flag and metric names are changed. Another follow-up will have to add release notes. Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6 --- M docs/contributing.adoc M docs/design-docs/README.md M docs/design-docs/raft-config-change.md M docs/design-docs/raft-remote-bootstrap.md M docs/whitepaper/kudu.tex M src/kudu/consensus/consensus.proto M src/kudu/consensus/consensus_peers.cc M src/kudu/consensus/consensus_peers.h M src/kudu/consensus/consensus_queue-test.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/consensus_queue.h M src/kudu/consensus/log_util.cc M src/kudu/consensus/raft_consensus-test.cc M src/kudu/integration-tests/client_failover-itest.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/delete_table-test.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/remote_bootstrap-itest.cc M src/kudu/integration-tests/tablet_replacement-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/tablet/metadata.proto M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_metadata.h M src/kudu/tablet/tablet_peer.cc M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/remote_bootstrap-test-base.h M src/kudu/tserver/remote_bootstrap.proto M src/kudu/tserver/remote_bootstrap_client-test.cc M src/kudu/tserver/remote_bootstrap_client.cc M src/kudu/tserver/remote_bootstrap_client.h M src/kudu/tserver/remote_bootstrap_service-test.cc M src/kudu/tserver/remote_bootstrap_service.cc M src/kudu/tserver/remote_bootstrap_service.h M src/kudu/tserver/remote_bootstrap_session-test.cc M src/kudu/tserver/remote_bootstrap_session.cc M src/kudu/tserver/remote_bootstrap_session.h M src/kudu/tserver/tablet_peer_lookup.h M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/tserver/tserver.proto 46 files changed, 640 insertions(+), 640 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/3848/2 -- To view, visit http://gerrit.cloudera.org:8080/3848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3848 to review the following change. Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Rename Remote Bootstrap to Tablet Copy (part 1) This does a bunch of automated substitutions of the terminology, renaming "remote bootstrap" to "tablet copy". This commit does not rename the files yet, so that it's easier to review without combining a file name change with the file content change. This is an incompatible change since some flag and metric names are changed. Another follow-up will have to add release notes. Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6 --- M docs/contributing.adoc M docs/design-docs/README.md M docs/design-docs/raft-config-change.md M docs/design-docs/raft-remote-bootstrap.md M docs/whitepaper/kudu.tex M src/kudu/consensus/consensus.proto M src/kudu/consensus/consensus_peers.cc M src/kudu/consensus/consensus_peers.h M src/kudu/consensus/consensus_queue-test.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/consensus_queue.h M src/kudu/consensus/log_util.cc M src/kudu/consensus/raft_consensus-test.cc M src/kudu/integration-tests/CMakeLists.txt M src/kudu/integration-tests/client_failover-itest.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/delete_table-test.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/remote_bootstrap-itest.cc M src/kudu/integration-tests/tablet_replacement-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/tablet/metadata.proto M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_metadata.h M src/kudu/tablet/tablet_peer.cc M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/remote_bootstrap-test-base.h M src/kudu/tserver/remote_bootstrap.proto M src/kudu/tserver/remote_bootstrap_client-test.cc M src/kudu/tserver/remote_bootstrap_client.cc M src/kudu/tserver/remote_bootstrap_client.h M src/kudu/tserver/remote_bootstrap_service-test.cc M src/kudu/tserver/remote_bootstrap_service.cc M src/kudu/tserver/remote_bootstrap_service.h M src/kudu/tserver/remote_bootstrap_session-test.cc M src/kudu/tserver/remote_bootstrap_session.cc M src/kudu/tserver/remote_bootstrap_session.h M src/kudu/tserver/tablet_peer_lookup.h M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/tserver/tserver.proto 47 files changed, 641 insertions(+), 641 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/3848/1 -- To view, visit http://gerrit.cloudera.org:8080/3848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mike Percy
[kudu-CR] Rename Remote Bootstrap to Tablet Copy (part 1)
Kudu Jenkins has posted comments on this change. Change subject: Rename Remote Bootstrap to Tablet Copy (part 1) .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2719/ -- To view, visit http://gerrit.cloudera.org:8080/3848 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic017e9121ed365cb3d9c9c81430915bf5b295bf6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] heartbeater: slight fixes to backoff behavior
Kudu Jenkins has posted comments on this change. Change subject: heartbeater: slight fixes to backoff behavior .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2718/ -- To view, visit http://gerrit.cloudera.org:8080/3847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f1dbc0a8b2d052eeb39277e0b8d76e612e9b747 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] heartbeater: slight fixes to backoff behavior
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3847 to review the following change. Change subject: heartbeater: slight fixes to backoff behavior .. heartbeater: slight fixes to backoff behavior 1. There was an off-by-one error when deciding how many failed heartbeats should lead to back off. 2. We only reset the connection to the master when transitioning to back off behavior, but I think the original intent was to reset it on every failed heartbeat thereafter. These changes shouldn't have any real impact, but I think they make the back off behavior more intuitive. Change-Id: I8f1dbc0a8b2d052eeb39277e0b8d76e612e9b747 --- M src/kudu/tserver/heartbeater.cc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/3847/1 -- To view, visit http://gerrit.cloudera.org:8080/3847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8f1dbc0a8b2d052eeb39277e0b8d76e612e9b747 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Todd Lipcon
[kudu-CR] docs: fix links to MR examples in developing
Dan Burkert has abandoned this change. Change subject: docs: fix links to MR examples in developing .. Abandoned This got pulled into a fix that renamed the last few remaining instances of 'kududb': https://gerrit.cloudera.org/#/c/3844/ -- To view, visit http://gerrit.cloudera.org:8080/3821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0b98d0ac25d75fc18ff694ca9c47ad1b9720570b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Fix remaining instance of kududb package in docs
Dan Burkert has submitted this change and it was merged. Change subject: Fix remaining instance of kududb package in docs .. Fix remaining instance of kududb package in docs Change-Id: Ia829fa9a2b8de7621ccf40ab3b6aef1ff14f4c61 Reviewed-on: http://gerrit.cloudera.org:8080/3844 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M LICENSE.txt M build-support/release/rat_exclude_files.txt M docs/design-docs/scan-tokens.md M docs/developing.adoc 4 files changed, 20 insertions(+), 19 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia829fa9a2b8de7621ccf40ab3b6aef1ff14f4c61 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [flume] fix import of shaded guava class
Dan Burkert has posted comments on this change. Change subject: [flume] fix import of shaded guava class .. Patch Set 1: It caused a compilation failure on a completely unrelated change. I'm not sure why. -- To view, visit http://gerrit.cloudera.org:8080/3845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5e290446e8d67e1899d36e68d45c413fdb08cff Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] [flume] fix import of shaded guava class
Dan Burkert has submitted this change and it was merged. Change subject: [flume] fix import of shaded guava class .. [flume] fix import of shaded guava class Change-Id: Id5e290446e8d67e1899d36e68d45c413fdb08cff Reviewed-on: http://gerrit.cloudera.org:8080/3845 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduEventProducerTest.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5e290446e8d67e1899d36e68d45c413fdb08cff Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [flume] fix import of shaded guava class
Adar Dembo has posted comments on this change. Change subject: [flume] fix import of shaded guava class .. Patch Set 1: Code-Review+2 How did you spot this? -- To view, visit http://gerrit.cloudera.org:8080/3845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5e290446e8d67e1899d36e68d45c413fdb08cff Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Fix remaining instance of kududb package in docs
Adar Dembo has posted comments on this change. Change subject: Fix remaining instance of kududb package in docs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia829fa9a2b8de7621ccf40ab3b6aef1ff14f4c61 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [flume] fix import of shaded guava class
Kudu Jenkins has posted comments on this change. Change subject: [flume] fix import of shaded guava class .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2717/ -- To view, visit http://gerrit.cloudera.org:8080/3845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5e290446e8d67e1899d36e68d45c413fdb08cff Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] [flume] fix import of shaded guava class
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3845 to review the following change. Change subject: [flume] fix import of shaded guava class .. [flume] fix import of shaded guava class Change-Id: Id5e290446e8d67e1899d36e68d45c413fdb08cff --- M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/KeyedKuduEventProducerTest.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/3845/1 -- To view, visit http://gerrit.cloudera.org:8080/3845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id5e290446e8d67e1899d36e68d45c413fdb08cff Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Mike Percy
[kudu-CR] docs: Add missing DISTRIBUTE to quickstart
Dan Burkert has submitted this change and it was merged. Change subject: docs: Add missing DISTRIBUTE to quickstart .. docs: Add missing DISTRIBUTE to quickstart Change-Id: I6a010bf90901bd98bf2c8e33396edb0d152c1d67 Reviewed-on: http://gerrit.cloudera.org:8080/3820 Reviewed-by: Dan Burkert Tested-by: Kudu Jenkins --- M docs/quickstart.adoc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a010bf90901bd98bf2c8e33396edb0d152c1d67 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Fix remaining instance of kududb package in docs
Kudu Jenkins has posted comments on this change. Change subject: Fix remaining instance of kududb package in docs .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2716/ -- To view, visit http://gerrit.cloudera.org:8080/3844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia829fa9a2b8de7621ccf40ab3b6aef1ff14f4c61 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Fix remaining instance of kududb package in docs
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3844 to review the following change. Change subject: Fix remaining instance of kududb package in docs .. Fix remaining instance of kududb package in docs Change-Id: Ia829fa9a2b8de7621ccf40ab3b6aef1ff14f4c61 --- M LICENSE.txt M build-support/release/rat_exclude_files.txt M docs/design-docs/scan-tokens.md M docs/developing.adoc 4 files changed, 20 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/3844/1 -- To view, visit http://gerrit.cloudera.org:8080/3844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia829fa9a2b8de7621ccf40ab3b6aef1ff14f4c61 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] docs: Add missing DISTRIBUTE to quickstart
Dan Burkert has posted comments on this change. Change subject: docs: Add missing DISTRIBUTE to quickstart .. Patch Set 1: Code-Review+2 LGTM. The DISTRIBUTE BY does go before the table properties (https://kudu.apache.org/docs/kudu_impala_integration.html#kudu_impala_create_table). The test failure looks unrelated; I've retried it. -- To view, visit http://gerrit.cloudera.org:8080/3820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a010bf90901bd98bf2c8e33396edb0d152c1d67 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] docs: Add missing DISTRIBUTE to quickstart
Kudu Jenkins has posted comments on this change. Change subject: docs: Add missing DISTRIBUTE to quickstart .. Patch Set 1: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2715/ -- To view, visit http://gerrit.cloudera.org:8080/3820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a010bf90901bd98bf2c8e33396edb0d152c1d67 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Attila Bukor Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1500: Fix the data race during RaftConsensusITest.TestCorruptReplicaMetadata
Dan Burkert has posted comments on this change. Change subject: KUDU-1500: Fix the data race during RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3823/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 177: attrs["partition"] = metadata_->partition_schema().PartitionDebugString( > if this is just a formatting change, please leave it the way it was. By the way, the rule for this particular case is here: https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions, but more generally we try not to do formatting-only changes as part of other commits. -- To view, visit http://gerrit.cloudera.org:8080/3823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If57617e22b41296b8d4e8ad131220f1ebb235019 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-1500: Fix the data race during RaftConsensusITest.TestCorruptReplicaMetadata
Dan Burkert has posted comments on this change. Change subject: KUDU-1500: Fix the data race during RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3823/2//COMMIT_MSG Commit Message: Line 11: the partition schema is accessed in an unguarded manner from another This is pretty confusing to me, because once a tablet is created, the partition schema and partition are locked; they can not be altered. It sounds like during tablet bootstrap, the in-memory version of these objects is changing, though? Perhaps we shouldn't be doing that. What are the partition and partition schema before they are overwritten? http://gerrit.cloudera.org:8080/#/c/3823/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 177: attrs["partition"] = metadata_->partition_schema().PartitionDebugString( if this is just a formatting change, please leave it the way it was. http://gerrit.cloudera.org:8080/#/c/3823/2/src/kudu/tserver/tserver-path-handlers.cc File src/kudu/tserver/tserver-path-handlers.cc: Line 207: n_bytes = HumanReadableNumBytes::ToString( same here with only formatting changes. -- To view, visit http://gerrit.cloudera.org:8080/3823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If57617e22b41296b8d4e8ad131220f1ebb235019 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Add docs for non-covering range partitioning
Dan Burkert has posted comments on this change. Change subject: Add docs for non-covering range partitioning .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/3796/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc: Line 799: Starting with Kudu 0.10, Kudu supports the use of non-covering range partitions, which I don't think this feature (specifically the RANGE BOUND syntax) will be ready in Impala for the 0.10 release. I'm not sure if we should document this in the impala integration until its done. Line 830: range should be added. APIs `AlterTableRequestPB::ADD_RANGE_PARTITION` and This keyword is the specific Protobuf identifier that Kudu uses internally; when add/drop range partition is added to impala it will hopefully look significantly different. Perhaps say more generally an alter table [add|drop] range partition operation. http://gerrit.cloudera.org:8080/#/c/3796/1/docs/schema_design.adoc File docs/schema_design.adoc: Line 49: across tablet servers. This is most impacted by the primary key design and the This is only influenced by the partition schema; the primary key only influences how data is stored/accessed within an individual tablet. Line 53: - Only important data would be transmitted to clients, by means of encoding, compression, I think what this is trying to get at is that an efficient schema will be designed such that scans will read the minimum amount of data necessary to fulfill a query. The biggest tool here is primary key design, but partition design also plays into it via partition pruning. Line 147: Kudu 0.10 introduces non-covering range partitions, to mitigate some limitations of This doesn't explain what non-covering range partitions are. Line 165: Caveats of Non-Covering Range Partitions These caveats look like they were taken right from the design doc? I think they are too low level, and don't really fit with the rest of this guide. They mention some features which likely will never be implemented, and some of them require expert-level knowledge of partitioning to understand. I think the most important caveat when using non-covered range partitions are: * Writes into non-covered ranges will fail with a tablet not found error. * When adding a range partition to an existing table through an alter table operation, the new range partition may not become visible to other existing clients of the table until waiting for an entire 'table_locations_ttl' period, as configured on the master (default 1 hour). Line 288: [[column-design]] Are there changes in here, or just a straight move? -- To view, visit http://gerrit.cloudera.org:8080/3796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b0fd7500c5399db9dcad617ae67fea247307353 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Misty Stanley-Jones Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
