[kudu-CR] KUDU-3371 Fix the crash bug when run binaries on older CPU machines
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21287 Change subject: KUDU-3371 Fix the crash bug when run binaries on older CPU machines .. KUDU-3371 Fix the crash bug when run binaries on older CPU machines After Kudu linking rocksdb, the Kudu binaries may crash with error "Illegal instruction" when running on the machines which don't support newer CPU instruction (e.g. AVX512) but were built on the machine which supports. This patch enable the WITH_SNAPPY option when build librocksdb to fix the issue. Change-Id: Id30ae995c41a592fccbdb822bc1f457c5e6878ac --- M thirdparty/build-definitions.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/21287/1 -- To view, visit http://gerrit.cloudera.org:8080/21287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id30ae995c41a592fccbdb822bc1f457c5e6878ac Gerrit-Change-Number: 21287 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai
[kudu-CR] [CMakeLists] Make kudu test main static
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21282 ) Change subject: [CMakeLists] Make kudu_test_main static .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21282/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21282/1//COMMIT_MSG@14 PS1, Line 14: This happens in ubuntu 22.04 test runs Could you provide a set of instructions to reproduce the issue? I could not see it happening on my tests, and I'm curious whether this change will make the binaries now failing elsewhere due to the modification of the loading chain. Frankly, this manual intervention into the loader's realm seems a bit strange, so I'm hesitant to give +1 or +2 to this patch without higher level of confidence that it's fixing a real issue, and fixing it the correct way. -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 10 Apr 2024 18:39:08 + Gerrit-HasComments: Yes
[kudu-CR] [rpc-test] make RpcPendingConnectionsMetric more stable
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21251 ) Change subject: [rpc-test] make RpcPendingConnectionsMetric more stable .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/21251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8e66c471452b1e04c84cf2d5c979578c287b4fa Gerrit-Change-Number: 21251 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Mahesh Reddy Gerrit-Reviewer: Marton Greber Gerrit-Comment-Date: Wed, 10 Apr 2024 14:31:46 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3326 correct error messages in tool usage instructions
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21273 ) Change subject: KUDU-3326 correct error messages in tool usage instructions .. KUDU-3326 correct error messages in tool usage instructions This patch mainly fixes the error messages in the recall tool as follows: ` Usage: kudu table recall [-new_table_name=] ` We expect to recall tables in soft delete state using the table ID, not the tablet ID. The correct output is as follows: ` Usage: kudu table recall [-new_table_name=] ` This is just about correcting the errors in the prompts and does not involve any related recall logic. Therefore, there are no additional unit tests added. Change-Id: Ib1c6df0806eee78280b00f6a528d42d434a63e2f Reviewed-on: http://gerrit.cloudera.org:8080/21266 Reviewed-by: Alexey Serbin Tested-by: Alexey Serbin (cherry picked from commit d06f35db2e5a0e93a3dcab0d3b26e4443914df89) Reviewed-on: http://gerrit.cloudera.org:8080/21273 Reviewed-by: Yingchun Lai --- M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_table.cc 3 files changed, 4 insertions(+), 2 deletions(-) Approvals: Yingchun Lai: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/21273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: Ib1c6df0806eee78280b00f6a528d42d434a63e2f Gerrit-Change-Number: 21273 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai
[kudu-CR](branch-1.17.x) KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21272 ) Change subject: KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks .. KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks The reason for the flakiness of the unit test is that we did not consider corner cases, namely, the time reserved from detecting a table in soft-deleted state until the execution of deletion, during which some operations may occur. We need to reserve more time. However, in order to verify that FLAGS_table_reserve_seconds is indeed effective, the additional time cannot be too long. Taking these two factors into consideration, I added one second of waiting time and performed multiple tests locally using the gtest_repeat parameter to ensure that this modification is effective. Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d Reviewed-on: http://gerrit.cloudera.org:8080/21268 Tested-by: Alexey Serbin Reviewed-by: Alexey Serbin (cherry picked from commit e5f3d2b19e7a210f64e76584fbe53454886668cb) Reviewed-on: http://gerrit.cloudera.org:8080/21272 Reviewed-by: Yingchun Lai --- M src/kudu/client/client-test.cc 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Yingchun Lai: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/21272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d Gerrit-Change-Number: 21272 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai
[kudu-CR](branch-1.17.x) KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21272 ) Change subject: KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d Gerrit-Change-Number: 21272 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Wed, 10 Apr 2024 14:05:28 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3326 correct error messages in tool usage instructions
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21273 ) Change subject: KUDU-3326 correct error messages in tool usage instructions .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c6df0806eee78280b00f6a528d42d434a63e2f Gerrit-Change-Number: 21273 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Wed, 10 Apr 2024 14:05:15 + Gerrit-HasComments: No
[kudu-CR] [tablet] one less memory allocation in CBTree::count()
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21276 ) Change subject: [tablet] one less memory allocation in CBTree::count() .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01a68e0427b399db92b33c910185654d195150a5 Gerrit-Change-Number: 21276 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 10 Apr 2024 14:04:20 + Gerrit-HasComments: No
[kudu-CR] [tablet] one less memory allocation in CBTree::count()
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21276 ) Change subject: [tablet] one less memory allocation in CBTree::count() .. [tablet] one less memory allocation in CBTree::count() While reviewing [1], I noticed there is room for improvement in CBTree. One trivial one is avoiding calls to 'new' when an object might be allocated on the stack. This makes sense since in some intensive Kudu workloads we might see significant lock contention in tcmalloc, and removing needless calls to 'new' helps to relieve that, even if it's not in the hot path. [1] https://gerrit.cloudera.org/#/c/21127/ Change-Id: I01a68e0427b399db92b33c910185654d195150a5 Reviewed-on: http://gerrit.cloudera.org:8080/21276 Reviewed-by: Yingchun Lai Reviewed-by: Yifan Zhang Tested-by: Alexey Serbin --- M src/kudu/tablet/concurrent_btree.h 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Yingchun Lai: Looks good to me, approved Yifan Zhang: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/21276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I01a68e0427b399db92b33c910185654d195150a5 Gerrit-Change-Number: 21276 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka
[kudu-CR] [tablet] one less memory allocation in CBTree::count()
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21276 ) Change subject: [tablet] one less memory allocation in CBTree::count() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01a68e0427b399db92b33c910185654d195150a5 Gerrit-Change-Number: 21276 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 10 Apr 2024 13:01:04 + Gerrit-HasComments: No
[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/21127/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21127/6//COMMIT_MSG@46 PS6, Line 46: would resolve the issue > Have you actually tried that or this is just a hypothesis? I actually tried it out. Wanted to ship it originally. It is version 2 of this review (compare version 2 with base). -- To view, visit http://gerrit.cloudera.org:8080/21127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c02dc3b9444599ef680fa9b29ae7a4d39dd382 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Martonka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: Ashwani Raina Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 10 Apr 2024 12:37:27 + Gerrit-HasComments: Yes
[kudu-CR] [CMakeLists] Make kudu test main static
Ádám Bakai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21282 Change subject: [CMakeLists] Make kudu_test_main static .. [CMakeLists] Make kudu_test_main static This change makes sure that kudu_util.so is loaded at the beginning of the loading chain. This is needed because in unwind_safeness.cc there is a dlsym execution in the constructor function, and it looks for the next declaration of the functions called "dlopen" and "dlclose" in shared object files. If kudu_util is loaded too late, then it won't find these functions and throws an error. This happens in ubuntu 22.04 test runs. To solve this issue, the kudu_test_main was changed to a static library and kudu_util was moved to the front of the library list. Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea --- M src/kudu/util/CMakeLists.txt 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/21282/1 -- To view, visit http://gerrit.cloudera.org:8080/21282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0dfeb1fa04ed91e95fd1f8d789f020dd44289fea Gerrit-Change-Number: 21282 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai
[kudu-CR] [debug] Fallback to load from libc
Ádám Bakai has abandoned this change. ( http://gerrit.cloudera.org:8080/21204 ) Change subject: [debug] Fallback to load from libc .. Abandoned abandoned, because it doesn't fix the problem. -- To view, visit http://gerrit.cloudera.org:8080/21204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I83ccb92a32bf431fc5bdae27264969e0e131a475 Gerrit-Change-Number: 21204 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Martonka
[kudu-CR](branch-1.17.x) KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21272 ) Change subject: KUDU-3433 Fix flakiness in ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: Iab3a6a5f54701470e368c043133f4646aa71126d Gerrit-Change-Number: 21272 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Wed, 10 Apr 2024 07:04:45 + Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3326 correct error messages in tool usage instructions
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21273 ) Change subject: KUDU-3326 correct error messages in tool usage instructions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c6df0806eee78280b00f6a528d42d434a63e2f Gerrit-Change-Number: 21273 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: KeDeng Gerrit-Reviewer: Yifan Zhang Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Wed, 10 Apr 2024 07:03:41 + Gerrit-HasComments: No
[kudu-CR] [tablet] one less memory allocation in CBTree::count()
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21276 ) Change subject: [tablet] one less memory allocation in CBTree::count() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01a68e0427b399db92b33c910185654d195150a5 Gerrit-Change-Number: 21276 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Yingchun Lai Gerrit-Reviewer: Zoltan Martonka Gerrit-Comment-Date: Wed, 10 Apr 2024 06:44:44 + Gerrit-HasComments: No
