[kudu-CR] [java] address warnings from the SonarLint tool
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16969 ) Change subject: [java] address warnings from the SonarLint tool .. [java] address warnings from the SonarLint tool This patch addresses some warnings (mostly "low-hanging fruits") reported by the SonarLint tool. This patch does not contain any functional modifications. Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Reviewed-on: http://gerrit.cloudera.org:8080/16969 Tested-by: Alexey Serbin Reviewed-by: Grant Henke --- M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/AuthzTokenCache.java M java/kudu-client/src/main/java/org/apache/kudu/client/ColumnarRowResultIterator.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/IPCUtil.java M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java M java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResultIterator.java M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java M java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java M java/kudu-client/src/main/java/org/apache/kudu/client/Statistics.java M java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java M java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/DecimalUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/HybridTimeUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java M java/kudu-client/src/main/java/org/apache/kudu/util/StringUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java 30 files changed, 200 insertions(+), 170 deletions(-) Approvals: Alexey Serbin: Verified Grant Henke: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Gerrit-Change-Number: 16969 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] address warnings from the SonarLint tool
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16969 ) Change subject: [java] address warnings from the SonarLint tool .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Gerrit-Change-Number: 16969 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 01 Feb 2021 14:26:16 + Gerrit-HasComments: No
[kudu-CR] [java] address warnings from the SonarLint tool
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16969 ) Change subject: [java] address warnings from the SonarLint tool .. Patch Set 2: Verified+1 Unrelated test failures in FaultFlags/BadTabletCopyITest.TestBadCopy/1 TabletCopyITest.TestConcurrentTabletCopys -- To view, visit http://gerrit.cloudera.org:8080/16969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Gerrit-Change-Number: 16969 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 29 Jan 2021 23:47:28 + Gerrit-HasComments: No
[kudu-CR] [java] address warnings from the SonarLint tool
Alexey Serbin has removed a vote on this change. Change subject: [java] address warnings from the SonarLint tool .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Gerrit-Change-Number: 16969 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] address warnings from the SonarLint tool
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16969 ) Change subject: [java] address warnings from the SonarLint tool .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java: http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java@75 PS1, Line 75: return ((Deferred) deferred).addBothDeferring(callback); > I generally expect to see constructors, if there are any, at the top of the OK, I moved constructors to the top. -- To view, visit http://gerrit.cloudera.org:8080/16969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Gerrit-Change-Number: 16969 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 29 Jan 2021 06:19:45 + Gerrit-HasComments: Yes
[kudu-CR] [java] address warnings from the SonarLint tool
Hello Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16969 to look at the new patch set (#2). Change subject: [java] address warnings from the SonarLint tool .. [java] address warnings from the SonarLint tool This patch addresses some warnings (mostly "low-hanging fruits") reported by the SonarLint tool. This patch does not contain any functional modifications. Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 --- M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/AuthzTokenCache.java M java/kudu-client/src/main/java/org/apache/kudu/client/ColumnarRowResultIterator.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/IPCUtil.java M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java M java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResultIterator.java M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java M java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java M java/kudu-client/src/main/java/org/apache/kudu/client/Statistics.java M java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java M java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/DecimalUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/HybridTimeUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java M java/kudu-client/src/main/java/org/apache/kudu/util/StringUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java 30 files changed, 200 insertions(+), 170 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/16969/2 -- To view, visit http://gerrit.cloudera.org:8080/16969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Gerrit-Change-Number: 16969 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke
[kudu-CR] [java] address warnings from the SonarLint tool
Grant Henke has posted comments on this change. (
http://gerrit.cloudera.org:8080/16969 )
Change subject: [java] address warnings from the SonarLint tool
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java
File
java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java:
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java@51
PS1, Line 51: int numRows) {
> Thank you for pointing at this.
That makes sense. It looks like this is okay to change. Thanks for looking into
it.
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java:
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java@75
PS1, Line 75: private AsyncUtil() {
> I put this in the very end of the file to match what we already have in the
I generally expect to see constructors, if there are any, at the top of the
class. Ultimately this is a nit, and I am okay with it either way.
The google style guide isn't as concrete on this, but the oracle guide suggests
that constructors should come before methods.
https://google.github.io/styleguide/javaguide.html#s3.4.2-ordering-class-contents
https://www.oracle.com/java/technologies/javase/codeconventions-fileorganization.html#1852
--
To view, visit http://gerrit.cloudera.org:8080/16969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7
Gerrit-Change-Number: 16969
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Grant Henke
Gerrit-Comment-Date: Thu, 28 Jan 2021 16:07:17 +
Gerrit-HasComments: Yes
[kudu-CR] [java] address warnings from the SonarLint tool
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/16969 )
Change subject: [java] address warnings from the SonarLint tool
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java
File java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java:
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java@118
PS1, Line 118: return length == that.length;
> I am not sure I prefer this syntax to the existing syntax. Do you think it'
SonarLint for prefers this form, I guess because of less code generated? I
haven't checked how it looks like from the JVM point, but I guess the benefits
are non-material practically.
I agree we should keep the original version if thinking about better
readability.
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java
File
java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java:
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java@51
PS1, Line 51: int numRows) {
> I think reuseRowResult was kept around for compatibility concerns. It would
Thank you for pointing at this.
One related change I found was: https://gerrit.cloudera.org/#/c/15983/
By the time of that change, it was a private constructor, so compatibility
issues were not in play, as I understand.
Then the constructor was made protected in
https://gerrit.cloudera.org/#/c/15983/ It's now called from package private
constructors of ColumnarRowResultIterator and RowwiseRowResultIterator (both
are marked with @InterfaceAudience.Private).
As of now, even if this class is marked with InterfaceAudience.Public, it's not
possible to call this protected constructor outside of the package, right? As
per https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html and
https://stackoverflow.com/questions/5150748/protected-constructor-and-accessibility
With that, I don't see compatibility concerns here. Please let me know if I'm
missing something.
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java:
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java@75
PS1, Line 75: private AsyncUtil() {
> Should this go at the top of the class? Here and elsewhere.
I put this in the very end of the file to match what we already have in the
StringUtil.java file:
https://github.com/apache/kudu/blob/202bcae7f12ca0d7ac43e0a07e57f3236c8f968d/java/kudu-client/src/main/java/org/apache/kudu/util/StringUtil.java#L88-L90
I guess the idea is to put not-so-relevant methods into the end of the file.
--
To view, visit http://gerrit.cloudera.org:8080/16969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7
Gerrit-Change-Number: 16969
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Grant Henke
Gerrit-Comment-Date: Tue, 26 Jan 2021 23:29:42 +
Gerrit-HasComments: Yes
[kudu-CR] [java] address warnings from the SonarLint tool
Grant Henke has posted comments on this change. (
http://gerrit.cloudera.org:8080/16969 )
Change subject: [java] address warnings from the SonarLint tool
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java
File java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java:
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java@118
PS1, Line 118: return length == that.length;
I am not sure I prefer this syntax to the existing syntax. Do you think it's
better? If so why?
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java
File
java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java:
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java@51
PS1, Line 51: int numRows) {
I think reuseRowResult was kept around for compatibility concerns. It would be
good to go back and validate.
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java:
http://gerrit.cloudera.org:8080/#/c/16969/1/java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java@75
PS1, Line 75: private AsyncUtil() {
Should this go at the top of the class? Here and elsewhere.
--
To view, visit http://gerrit.cloudera.org:8080/16969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7
Gerrit-Change-Number: 16969
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Grant Henke
Gerrit-Comment-Date: Mon, 25 Jan 2021 16:35:45 +
Gerrit-HasComments: Yes
[kudu-CR] [java] address warnings from the SonarLint tool
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16969 ) Change subject: [java] address warnings from the SonarLint tool .. Patch Set 1: Verified+1 unrelated test failure in RaftConsensusITest.MultiThreadedInsertWithFailovers -- To view, visit http://gerrit.cloudera.org:8080/16969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Gerrit-Change-Number: 16969 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Comment-Date: Fri, 22 Jan 2021 06:40:03 + Gerrit-HasComments: No
[kudu-CR] [java] address warnings from the SonarLint tool
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/16969 ) Change subject: [java] address warnings from the SonarLint tool .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/16969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Gerrit-Change-Number: 16969 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Grant Henke
[kudu-CR] [java] address warnings from the SonarLint tool
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16969 Change subject: [java] address warnings from the SonarLint tool .. [java] address warnings from the SonarLint tool This patch addresses some warnings reported by the SonarLint tool. This patch does not contain any functional modifications. Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 --- M java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/AuthzTokenCache.java M java/kudu-client/src/main/java/org/apache/kudu/client/ColumnarRowResultIterator.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/IPCUtil.java M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java M java/kudu-client/src/main/java/org/apache/kudu/client/RowResultIterator.java M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResultIterator.java M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java M java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java M java/kudu-client/src/main/java/org/apache/kudu/client/Statistics.java M java/kudu-client/src/main/java/org/apache/kudu/util/AsyncUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java M java/kudu-client/src/main/java/org/apache/kudu/util/DateUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/DecimalUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/HybridTimeUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java M java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java 30 files changed, 193 insertions(+), 166 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/16969/1 -- To view, visit http://gerrit.cloudera.org:8080/16969 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I306575b370fb69a54fdc24b9d770a99291828ef7 Gerrit-Change-Number: 16969 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
