[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Patch Set 2:

> > Patch Set 1:
 > >
 > > > > Patch Set 1: Code-Review+2
 > >  > >
 > >  > > I was able to build thirdparty on macOS 10.15.7 and CentOS
 > 7.3 --
 > >  > not SLES, but at least it doesn't break other environments.
 > Would
 > >  > be good to wait for others who may be testing on SLES to
 > review.
 > >  >
 > >  > Actually running cmake, I hit this error:
 > >  >
 > >  > Checking for C++17 compiler support ...
 > >  > *** Unable to compile a simple c++17 program. Please use g++
 > 7.0 or
 > >  > higher (or CLANG 6.0 or higher). On CentOS 7 or RHEL 7 you
 > must use
 > >  > the devtoolset. See docs/installation.adoc for more info.
 > >  > Compilation failed: In file included from :2:
 > >  > In file included from 
 > > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/optional:150:
 > >  > In file included from 
 > > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__debug:14:
 > >  > In file included from 
 > > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:95:
 > >  > 
 > > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/wchar.h:118:15:
 > >  > fatal error: 'wchar.h' file not found
 > >  > #include_next 
 > >  > ^
 > >  > 1 error generated.
 > >  >
 > >  > Will investigate further tomorrow.
 > >
 > > Of course, it's necessary to have GCC8 at least to build -- see
 > the commit description.
 >
 > It seems the issue was that I switched branches after building
 > thirdparty. I rebuilt and successfully ran cmake.

Ah, cool -- thank you for the update!


--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 20:57:47 +
Gerrit-HasComments: No


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Patch Set 2: Code-Review+2

> Patch Set 1:
>
> > > Patch Set 1: Code-Review+2
>  > >
>  > > I was able to build thirdparty on macOS 10.15.7 and CentOS 7.3 --
>  > not SLES, but at least it doesn't break other environments. Would
>  > be good to wait for others who may be testing on SLES to review.
>  >
>  > Actually running cmake, I hit this error:
>  >
>  > Checking for C++17 compiler support ...
>  > *** Unable to compile a simple c++17 program. Please use g++ 7.0 or
>  > higher (or CLANG 6.0 or higher). On CentOS 7 or RHEL 7 you must use
>  > the devtoolset. See docs/installation.adoc for more info.
>  > Compilation failed: In file included from :2:
>  > In file included from 
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/optional:150:
>  > In file included from 
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__debug:14:
>  > In file included from 
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:95:
>  > 
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/wchar.h:118:15:
>  > fatal error: 'wchar.h' file not found
>  > #include_next 
>  > ^
>  > 1 error generated.
>  >
>  > Will investigate further tomorrow.
>
> Of course, it's necessary to have GCC8 at least to build -- see the commit 
> description.

It seems the issue was that I switched branches after building thirdparty. I 
rebuilt and successfully ran cmake.


--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 19:04:05 +
Gerrit-HasComments: No


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..

[thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

This patch updates build-definitions.sh to allow building on SLES 12.5
(SUSE Linux Enterprise Server 12 SP5) with GCC 8.

The stock C/C++ compiler on SLES 12 doesn't support C++17 features now
required to build Kudu, so one option is to use gcc/g++-8.

Another option might be building with Development Tools Module [1],
but I guess it's nice to be able to build Kudu with just other/newer
C++ compiler at first.

I used the following script to build all thirdparty components from
Kudu workspace root:

---

CC=/usr/bin/gcc-8
CXX=/usr/bin/g++-8

env CC=$CC CXX=$CXX \
  ./build-support/enable_devtoolset.sh thirdparty/build-if-necessary.sh all
---

[1] 
https://www.suse.com/c/suse-linux-essentials-where-are-the-compilers-understanding-the-development-tools-module/

Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Reviewed-on: http://gerrit.cloudera.org:8080/16878
Tested-by: Alexey Serbin 
Reviewed-by: Grant Henke 
---
M thirdparty/build-definitions.sh
1 file changed, 17 insertions(+), 10 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16878/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16878/1//COMMIT_MSG@7
PS1, Line 7: fix building 3rd-party
> nit: maybe more specifically, fix building boost?
Yep, that's a good point.

It started with an issue of configuring curl, and when it was cleared, I found 
that boost build isn't working as expected.  Also, I verified that all 
components of the 3rd-party were successfully built (even in TSAN 
configuration).  That's why to me it looked like fixing 3rd-party :)

I got +2 from Grant as well, so I guess it's OK if we leave this the comment as 
is just to speed up the things.



--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 16:44:22 +
Gerrit-HasComments: Yes


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 16:12:30 +
Gerrit-HasComments: No


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Patch Set 1:

> > Patch Set 1: Code-Review+2
 > >
 > > I was able to build thirdparty on macOS 10.15.7 and CentOS 7.3 --
 > not SLES, but at least it doesn't break other environments. Would
 > be good to wait for others who may be testing on SLES to review.
 >
 > Actually running cmake, I hit this error:
 >
 > Checking for C++17 compiler support ...
 > *** Unable to compile a simple c++17 program. Please use g++ 7.0 or
 > higher (or CLANG 6.0 or higher). On CentOS 7 or RHEL 7 you must use
 > the devtoolset. See docs/installation.adoc for more info.
 > Compilation failed: In file included from :2:
 > In file included from 
 > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/optional:150:
 > In file included from 
 > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__debug:14:
 > In file included from 
 > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:95:
 > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/wchar.h:118:15:
 > fatal error: 'wchar.h' file not found
 > #include_next 
 > ^
 > 1 error generated.
 >
 > Will investigate further tomorrow.

Of course, it's necessary to have GCC8 at least to build -- see the commit 
description.


--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 16:01:27 +
Gerrit-HasComments: No


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Patch Set 1: Code-Review+1

I built successfully on OSX and SLES12


--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 15:36:20 +
Gerrit-HasComments: No


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Patch Set 1:

> Patch Set 1: Code-Review+2
>
> I was able to build thirdparty on macOS 10.15.7 and CentOS 7.3 -- not SLES, 
> but at least it doesn't break other environments. Would be good to wait for 
> others who may be testing on SLES to review.

Actually running cmake, I hit this error:

Checking for C++17 compiler support ...
*** Unable to compile a simple c++17 program. Please use g++ 7.0 or higher (or 
CLANG 6.0 or higher). On CentOS 7 or RHEL 7 you must use the devtoolset. See 
docs/installation.adoc for more info.
Compilation failed: In file included from :2:
In file included from 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/optional:150:
In file included from 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__debug:14:
In file included from 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:95:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/wchar.h:118:15:
 fatal error: 'wchar.h' file not found
#include_next 
  ^
1 error generated.

Will investigate further tomorrow.


--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 09:09:51 +
Gerrit-HasComments: No


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-15 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change.

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Removed -Code-Review by Andrew Wong 
--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-15 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change.

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Removed Code-Review+2 by Andrew Wong 
--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Patch Set 1: Code-Review+2

I was able to build thirdparty on macOS 10.15.7 and CentOS 7.3 -- not SLES, but 
at least it doesn't break other environments. Would be good to wait for others 
who may be testing on SLES to review.


--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 07:57:49 +
Gerrit-HasComments: No


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Patch Set 1: Code-Review+1

(2 comments)

I'm building on a couple of my build environments (Mac and CentOS 7) just for 
coverage.

http://gerrit.cloudera.org:8080/#/c/16878/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16878/1//COMMIT_MSG@7
PS1, Line 7: fix building 3rd-party
nit: maybe more specifically, fix building boost?


http://gerrit.cloudera.org:8080/#/c/16878/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

http://gerrit.cloudera.org:8080/#/c/16878/1/thirdparty/build-definitions.sh@850
PS1, Line 850: $CC -v
Wow, nice. I assumed the output was the same as --version. Neat!



--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 07:06:08 +
Gerrit-HasComments: Yes


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16878 )

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Patch Set 1: Verified+1

unrelated failure in ClientTest.TestFailedDnsResolution, see 
https://issues.apache.org/jira/browse/KUDU-1466


--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Dec 2020 06:49:00 +
Gerrit-HasComments: No


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change.

Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

2020-12-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16878


Change subject: [thirdparty] fix building 3rd-party on SLES 12.5 with GCC8
..

[thirdparty] fix building 3rd-party on SLES 12.5 with GCC8

This patch updates build-definitions.sh to allow building on SLES 12.5
(SUSE Linux Enterprise Server 12 SP5) with GCC 8.

The stock C/C++ compiler on SLES 12 doesn't support C++17 features now
required to build Kudu, so one option is to use gcc/g++-8.

Another option might be building with Development Tools Module [1],
but I guess it's nice to be able to build Kudu with just other/newer
C++ compiler at first.

I used the following script to build all thirdparty components from
Kudu workspace root:

---

CC=/usr/bin/gcc-8
CXX=/usr/bin/g++-8

env CC=$CC CXX=$CXX \
  ./build-support/enable_devtoolset.sh thirdparty/build-if-necessary.sh all
---

[1] 
https://www.suse.com/c/suse-linux-essentials-where-are-the-compilers-understanding-the-development-tools-module/

Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
---
M thirdparty/build-definitions.sh
1 file changed, 17 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/16878/1
--
To view, visit http://gerrit.cloudera.org:8080/16878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5ad79e1a3582a64015bb34a8b615b1cbeab49f7
Gerrit-Change-Number: 16878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin