[kudu-CR] [tools] update schema if needed when rebuild master
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18496 ) Change subject: [tools] update schema if needed when rebuild master .. Patch Set 5: Code-Review+1 (4 comments) Thank you for working on this! Looks good overall! Just a few nits in the commit message and in the test scenario. http://gerrit.cloudera.org:8080/#/c/18496/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18496/5//COMMIT_MSG@7 PS5, Line 7: rebuild nit: rebuilding http://gerrit.cloudera.org:8080/#/c/18496/5//COMMIT_MSG@9 PS5, Line 9: When use 'kudu master unsafe_rebuild' tool to rebuild : master, if the cluster is not health, for example, : some tservers holds outdated schemas (with lower schema : version), we may build tables with outdated schemas. nit: how about Before this patch, if tservers had outdated schemas with lower version for some tables (e.g. when the cluster wasn't healthy), the 'kudu master unsafe_rebuild' tool might rebuild the system catalog with outdated schemas for the unhealthy tables. http://gerrit.cloudera.org:8080/#/c/18496/5//COMMIT_MSG@14 PS5, Line 14: This patch optmizes the rebuild logic, will use newer : schema (with higher version) to replace schema with : lower version. nit: how about This patch optimizes the rebuild logic, so the tool now picks up schema of the highest version for an unhealthy table when rebuilding the system catalog. http://gerrit.cloudera.org:8080/#/c/18496/5/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18496/5/src/kudu/tools/kudu-admin-test.cc@3244 PS5, Line 3244: nit: does it make sense to check that the client sees the right number of columns in the KuduSchema object before writing/reading into the table? That something about calling KuduClient::GetTableSchema() and then KuduSchema::num_columns(), correspondingly. -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 16 May 2022 18:07:12 + Gerrit-HasComments: Yes
[kudu-CR] [tools] update schema if needed when rebuild master
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18496 ) Change subject: [tools] update schema if needed when rebuild master .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/18496/4/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18496/4/src/kudu/tools/kudu-admin-test.cc@3219 PS4, Line 3219: to become he > nit: 'to become healthy' or 'to be in a good health' Done http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@230 PS3, Line 230: > I guess Andrew meant that it's enough to have this auto-commit guard just r CommitMutation will reset 'metadata' which is obtained by 'SysTablesEntryPB* metadata = &table->mutable_metadata()->mutable_dirty()->pb', but we will use 'metadata' to compare schemas after L246. Anyway, I adjusted the code to make it more readability. http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@253 PS3, Line 253: > +1 Done -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Tue, 10 May 2022 02:16:51 + Gerrit-HasComments: Yes
[kudu-CR] [tools] update schema if needed when rebuild master
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18496 to look at the new patch set (#5). Change subject: [tools] update schema if needed when rebuild master .. [tools] update schema if needed when rebuild master When use 'kudu master unsafe_rebuild' tool to rebuild master, if the cluster is not health, for example, some tservers holds outdated schemas (with lower schema version), we may build tables with outdated schemas. This patch optmizes the rebuild logic, will use newer schema (with higher version) to replace schema with lower version. Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d --- M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/master_rebuilder.cc 2 files changed, 115 insertions(+), 44 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/18496/5 -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [tools] update schema if needed when rebuild master
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18496 ) Change subject: [tools] update schema if needed when rebuild master .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 09 May 2022 14:48:35 + Gerrit-HasComments: No
[kudu-CR] [tools] update schema if needed when rebuild master
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18496 ) Change subject: [tools] update schema if needed when rebuild master .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18496/4/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18496/4/src/kudu/tools/kudu-admin-test.cc@3219 PS4, Line 3219: to be health nit: 'to become healthy' or 'to be in a good health' http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@230 PS3, Line 230: // Return with non-OK status is not fatal, s > Since 'mutable_dirty' is obtained in L232, it is referenced and will be use I guess Andrew meant that it's enough to have this auto-commit guard just right before first return from this function -- having it anywhere before that doesn't change anything, right? -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 09 May 2022 14:48:13 + Gerrit-HasComments: Yes
[kudu-CR] [tools] update schema if needed when rebuild master
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18496 ) Change subject: [tools] update schema if needed when rebuild master .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@253 PS3, Line 253: > nit: maybe log a message saying something like "ignoring mismatched schema +1 That would also help to clarify why the current metadata mutation is to be committed anyways. -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Mon, 09 May 2022 14:40:37 + Gerrit-HasComments: Yes
[kudu-CR] [tools] update schema if needed when rebuild master
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18496 ) Change subject: [tools] update schema if needed when rebuild master .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/kudu-admin-test.cc@3245 PS3, Line 3245: // Check the altered table is writable and readable. > nit: could we explicitly also check that the table has the right number of Done http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@230 PS3, Line 230: // Return with non-OK status is not fatal, s > nit: maybe just put this after L246? Since 'mutable_dirty' is obtained in L232, it is referenced and will be used after L246, and CommitMutation will reset 'mutable_dirty', so I intend to CommitMutation in the last. http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@253 PS3, Line 253: > nit: maybe log a message saying something like "ignoring mismatched schema Done -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Sun, 08 May 2022 16:45:22 + Gerrit-HasComments: Yes
[kudu-CR] [tools] update schema if needed when rebuild master
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18496 to look at the new patch set (#4). Change subject: [tools] update schema if needed when rebuild master .. [tools] update schema if needed when rebuild master When use 'kudu master unsafe_rebuild' tool to rebuild master, if the cluster is not health, for example, some tservers holds outdated schemas (with lower schema version), we may build tables with outdated schemas. This patch optmizes the rebuild logic, will use newer schema (with higher version) to replace schema with lower version. Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d --- M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/master_rebuilder.cc 2 files changed, 112 insertions(+), 42 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/18496/4 -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai
[kudu-CR] [tools] update schema if needed when rebuild master
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18496 ) Change subject: [tools] update schema if needed when rebuild master .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/kudu-admin-test.cc@3245 PS3, Line 3245: ScanTableToStrings(table.get(), &rows); nit: could we explicitly also check that the table has the right number of columns? http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@230 PS3, Line 230: table->mutable_metadata()->CommitMutation(); nit: maybe just put this after L246? http://gerrit.cloudera.org:8080/#/c/18496/3/src/kudu/tools/master_rebuilder.cc@253 PS3, Line 253: nit: maybe log a message saying something like "ignoring mismatched schema since it has a lower version" or somesuch? -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai Gerrit-Comment-Date: Sat, 07 May 2022 07:07:00 + Gerrit-HasComments: Yes
[kudu-CR] [tools] update schema if needed when rebuild master
Yingchun Lai has posted comments on this change. (
http://gerrit.cloudera.org:8080/18496 )
Change subject: [tools] update schema if needed when rebuild master
..
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/kudu-admin-test.cc@3040
PS2, Line 3040: int tserver_num,
> What if passing just the number of tablet servers here to be used for the u
Done
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/kudu-admin-test.cc@3205
PS2, Line 3205: ut;
> newer
Done
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/master_rebuilder.cc
File src/kudu/tools/master_rebuilder.cc:
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/master_rebuilder.cc@228
PS2, Line 228: auto cleanup = MakeScopedCleanup([&]() {
: // Return with non-OK status is not fatal, so still
CommitMutation.
: t
> So, we want to commit the mutation even if returning with an error from thi
Yes, since return with non-OK status is not fatal, so still CommitMutation.
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/master_rebuilder.cc@248
PS2, Line 248:
> Check for the consistency.
Done
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/master_rebuilder.cc@250
PS2, Line 250: // Only matched when they have the same version.
: if (replica.has_schema_version() &&
> For better readability, add early return here if the condition isn't true.
Done
--
To view, visit http://gerrit.cloudera.org:8080/18496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d
Gerrit-Change-Number: 18496
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai
Gerrit-Reviewer: Abhishek Chennaka
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai
Gerrit-Comment-Date: Sat, 07 May 2022 04:15:14 +
Gerrit-HasComments: Yes
[kudu-CR] [tools] update schema if needed when rebuild master
Hello Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18496 to look at the new patch set (#3). Change subject: [tools] update schema if needed when rebuild master .. [tools] update schema if needed when rebuild master When use 'kudu master unsafe_rebuild' tool to rebuild master, if the cluster is not health, for example, some tservers holds outdated schemas (with lower schema version), we may build tables with outdated schemas. This patch optmizes the rebuild logic, will use newer schema (with higher version) to replace schema with lower version. Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d --- M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/master_rebuilder.cc 2 files changed, 77 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/18496/3 -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tools] update schema if needed when rebuild master
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/18496 )
Change subject: [tools] update schema if needed when rebuild master
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/kudu-admin-test.cc@3040
PS2, Line 3040: const vector& tserver_idxs,
What if passing just the number of tablet servers here to be used for the
unsafe_rebuild command, not indices? So far all the use cases for this method
use indices from 0 to N, so passing just one number would satisfy the
requirements.
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/kudu-admin-test.cc@3205
PS2, Line 3205: normal
newer
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/master_rebuilder.cc
File src/kudu/tools/master_rebuilder.cc:
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/master_rebuilder.cc@228
PS2, Line 228: auto cleanup = MakeScopedCleanup([&]() {
: table->mutable_metadata()->CommitMutation();
: });
So, we want to commit the mutation even if returning with an error from this
method? Is it intended?
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/master_rebuilder.cc@248
PS2, Line 248: Check consistency
Check for the consistency.
http://gerrit.cloudera.org:8080/#/c/18496/2/src/kudu/tools/master_rebuilder.cc@250
PS2, Line 250: if (!replica.has_schema_version() ||
: replica.schema_version() == metadata->version())
For better readability, add early return here if the condition isn't true.
--
To view, visit http://gerrit.cloudera.org:8080/18496
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d
Gerrit-Change-Number: 18496
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai
Gerrit-Reviewer: Abhishek Chennaka
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 May 2022 19:09:27 +
Gerrit-HasComments: Yes
[kudu-CR] [tools] update schema if needed when rebuild master
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18496 ) Change subject: [tools] update schema if needed when rebuild master .. Patch Set 2: Do you think it makes sense to add a test to cover partition schema change too? -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 06 May 2022 17:42:23 + Gerrit-HasComments: No
[kudu-CR] [tools] update schema if needed when rebuild master
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18496 to look at the new patch set (#2). Change subject: [tools] update schema if needed when rebuild master .. [tools] update schema if needed when rebuild master When use 'kudu master unsafe_rebuild' tool to rebuild master, if the cluster is not health, for example, some tservers holds outdated schemas (with lower schema version), we may build tables with outdated schemas. This patch optmizes the rebuild logic, will use newer schema (with higher version) to replace schema with lower version. Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d --- M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/master_rebuilder.cc 2 files changed, 89 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/18496/2 -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tools] update schema if needed when rebuild master
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18496 Change subject: [tools] update schema if needed when rebuild master .. [tools] update schema if needed when rebuild master Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d --- M src/kudu/tools/master_rebuilder.cc 1 file changed, 37 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/18496/1 -- To view, visit http://gerrit.cloudera.org:8080/18496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iec99d57115228b521ba645b8e19c7057a4bb5d3d Gerrit-Change-Number: 18496 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai
