[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-23 Thread Attila Bukor (Code Review) 
Attila Bukor has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..

KUDU-1938 [java] Add support for VARCHAR pt 4

Adds support for VARCHAR type to the Java and Spark clients. The
kudu-client only changes would break tests in kudu-spark and kudu-backup
so this patch also incorporates changes in these subprojects.

Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Reviewed-on: http://gerrit.cloudera.org:8080/14050
Reviewed-by: Grant Henke 
Tested-by: Kudu Jenkins
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M 
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
29 files changed, 500 insertions(+), 33 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 28
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-22 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 27: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 27
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 22 Oct 2019 23:17:02 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-22 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 26: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 26
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 22 Oct 2019 17:01:17 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-22 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 26: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 26
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 22 Oct 2019 16:20:20 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-04 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 24: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 24
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Fri, 04 Oct 2019 16:57:59 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-04 Thread Attila Bukor (Code Review) 
Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 24:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14050/23/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
File java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java:

http://gerrit.cloudera.org:8080/#/c/14050/23/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java@1
PS23, Line 1: // Licensed to the Apache Software Foundation (ASF) under one
> Extra / ?
Done


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@403
PS20, Line 403:   }
> Yeah, I think that is okay as long as we are consistent. Users can always u
Done


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala@151
PS20, Line 151:
> You can still use the Kudu Schema based table creation to create a VARCHAR
Ah ok, thanks for clarifying.


http://gerrit.cloudera.org:8080/#/c/14050/23/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala:

http://gerrit.cloudera.org:8080/#/c/14050/23/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala@139
PS23, Line 139: // Add ColumnTypeAttributesBuilder to DECIMAL columns
> Remove  "and VARCHAR"
Done



--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 24
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Fri, 04 Oct 2019 16:49:20 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-04 Thread Attila Bukor (Code Review) 
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14050

to look at the new patch set (#24).

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..

KUDU-1938 [java] Add support for VARCHAR pt 4

Adds support for VARCHAR type to the Java and Spark clients. The
kudu-client only changes would break tests in kudu-spark and kudu-backup
so this patch also incorporates changes in these subprojects.

Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M 
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
30 files changed, 504 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/14050/24
--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 24
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-04 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 23:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14050/23/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
File java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java:

http://gerrit.cloudera.org:8080/#/c/14050/23/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java@1
PS23, Line 1: /// Licensed to the Apache Software Foundation (ASF) under one
Extra / ?


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@403
PS20, Line 403:   }
> C++ API specifically doesn't allow implicit casting at this point so GetVar
Yeah, I think that is okay as long as we are consistent. Users can always use 
getObject if they don't want to handle each getter explicitly.


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala@151
PS20, Line 151:
> fair enough, removing it. Does this mean it's not possible to create a VARC
You can still use the Kudu Schema based table creation to create a VARCHAR 
column as opposed to the Spark StructType.


http://gerrit.cloudera.org:8080/#/c/14050/23/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala:

http://gerrit.cloudera.org:8080/#/c/14050/23/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala@139
PS23, Line 139: // Add ColumnTypeAttributesBuilder to DECIMAL and VARCHAR 
columns
Remove  "and VARCHAR"



--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 23
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Fri, 04 Oct 2019 15:52:37 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-04 Thread Attila Bukor (Code Review) 
Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 23:

(11 comments)

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java@41
PS20, Line 41: import org.apache.kudu.util.Pair;
> Use the standard java charset here and anywhere else.
Done


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@43
PS20, Line 43: /**
> Nit: All the other types use `Type.x` where they are used. Remove these and
Done


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@659
PS20, Line 659:   /**
> nit: To match all the addString methods should this call `addStringUtf8`?
addString calls addStringUtf8 which calls addVarLengthData, not sure what you 
mean.


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@403
PS20, Line 403:   }
> We don't allow VARCHAR on getString in the PartialRow API. We probably shou
C++ API specifically doesn't allow implicit casting at this point so 
GetVarchar() can't be used for STRING columns and vice versa.

I think it would be best to match this behavior here as well, so I changed it 
to disallow using getString() to be used for VARCHAR and vice versa. Is that ok?


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
File java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java@22
PS20, Line 22: import org.junit.Rule;
> Nit: put with the kudu imports
Done


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java@29
PS20, Line 29: import org.apache.kudu.util.DecimalUtil;
> nit: put with the junit imports
Done


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java@28
PS20, Line 28: import org.junit.Before;
> nit: put with the other kudu imports?
Done


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@24
PS20, Line 24: import static 
org.apache.kudu.test.ClientTestUtil.countRowsInScan;
> Nit: Avoid * imports
Done


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
File 
java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java@33
PS20, Line 33: import org.junit.Assert;
> Nit: put with Kudu imports
Done


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
File 
java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java@28
PS20, Line 28: import org.junit.Assert;
> Nit: Put with other kudu imports
Done


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala@151
PS20, Line 151:
> Is there a test for this? I wonder if Spark will actually create a varchar
fair enough, removing it. Does this mean it's not possible to create a VARCHAR 
columns in Kudu using Spark?



--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-04 Thread Attila Bukor (Code Review) 
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14050

to look at the new patch set (#23).

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..

KUDU-1938 [java] Add support for VARCHAR pt 4

Adds support for VARCHAR type to the Java and Spark clients. The
kudu-client only changes would break tests in kudu-spark and kudu-backup
so this patch also incorporates changes in these subprojects.

Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M 
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
30 files changed, 506 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/14050/23
--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 23
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-02 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 20:

(11 comments)

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java@41
PS20, Line 41: import org.jboss.netty.util.CharsetUtil;
Use the standard java charset here and anywhere else.
   java.nio.charset.StandardCharsets


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@43
PS20, Line 43: import static org.apache.kudu.Type.STRING;
Nit: All the other types use `Type.x` where they are used. Remove these and use 
fully qualified `Type.x` where needed below.


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@659
PS20, Line 659: addVarLengthData(columnIndex, bytes);
nit: To match all the addString methods should this call `addStringUtf8`?


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@403
PS20, Line 403: checkType(columnIndex, Type.STRING, Type.VARCHAR);
We don't allow VARCHAR on getString in the PartialRow API. We probably should.

Either way both PartialRow and RowResult behavior should be consistent.


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
File java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java@22
PS20, Line 22: import org.apache.kudu.util.CharUtil;
Nit: put with the kudu imports


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java@29
PS20, Line 29: import org.junit.rules.ExpectedException;
nit: put with the junit imports


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java@28
PS20, Line 28: import org.apache.kudu.util.CharUtil;
nit: put with the other kudu imports?


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@24
PS20, Line 24: import static org.apache.kudu.test.ClientTestUtil.*;
Nit: Avoid * imports


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
File 
java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java@33
PS20, Line 33: import org.apache.kudu.util.CharUtil;
Nit: put with Kudu imports


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
File 
java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java@28
PS20, Line 28: import org.apache.kudu.util.CharUtil;
Nit: Put with other kudu imports


http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala:

http://gerrit.cloudera.org:8080/#/c/14050/20/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala@151
PS20, Line 151:   val dt = field.dataType.asInstanceOf[VarcharType]
Is there a test for this? I wonder if Spark will actually create a varchar 
schema given VarcharType in spark is only mean for internal parsing.
https://spark.apache.org/docs/latest/api/java/org/apache/spark/sql/types/VarcharType.html

Currently I don't think this code can be hit because `sparkTypeToKuduType` 
won't ever return VARCHAR.

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 20: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 20
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 01 Oct 2019 21:04:24 +
Gerrit-HasComments: No

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Attila Bukor (Code Review) 
Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 18:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14050/17/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:

http://gerrit.cloudera.org:8080/#/c/14050/17/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@707
PS17, Line 707:* or if the type doesn't match the column's type
> Nit: indent (below too).
Done



--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 18
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 01 Oct 2019 20:32:17 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Attila Bukor (Code Review) 
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14050

to look at the new patch set (#18).

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..

KUDU-1938 [java] Add support for VARCHAR pt 4

Adds support for VARCHAR type to the Java and Spark clients. The
kudu-client only changes would break tests in kudu-spark and kudu-backup
so this patch also incorporates changes in these subprojects.

Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M 
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
29 files changed, 507 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/14050/18
--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 18
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 17: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14050/17/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:

http://gerrit.cloudera.org:8080/#/c/14050/17/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@707
PS17, Line 707:* or if the type doesn't match the column's type
Nit: indent (below too).



--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 17
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 01 Oct 2019 20:18:52 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Attila Bukor (Code Review) 
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14050

to look at the new patch set (#17).

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..

KUDU-1938 [java] Add support for VARCHAR pt 4

Adds support for VARCHAR type to the Java and Spark clients. The
kudu-client only changes would break tests in kudu-spark and kudu-backup
so this patch also incorporates changes in these subprojects.

Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M 
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
29 files changed, 507 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/14050/17
--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 17
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Attila Bukor (Code Review) 
Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 17:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
File java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java:

http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java@423
PS16, Line 423:   if (type == Type.VARCHAR) {
> Too long (here and elsewhere).
Done


http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:

http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@45
PS16, Line 45:
> Let's omit wildcard imports in production code.
Done


http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@647
PS16, Line 647:* or the string is not UTF-8
> This line (and others) is too long; please wrap.
Done


http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:

http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@419
PS16, Line 419:* or if the type doesn't match the column's type
> Nit: in situations like these, could you indent the continuation line so it
Done



--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 17
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 01 Oct 2019 19:43:51 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-10-01 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14050 )

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..


Patch Set 16: Code-Review+1

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
File java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java:

http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java@423
PS16, Line 423: if (typeAttributes == null || 
!typeAttributes.hasLength() || typeAttributes.getLength() < 
CharUtil.MIN_VARCHAR_LENGTH
Too long (here and elsewhere).


http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:

http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@45
PS16, Line 45: import static org.apache.kudu.Type.*;
Let's omit wildcard imports in production code.


http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@647
PS16, Line 647:* @throws IllegalArgumentException if the column doesn't 
exist, is the wrong type or the string is not UTF-8
This line (and others) is too long; please wrap.


http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:

http://gerrit.cloudera.org:8080/#/c/14050/16/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@419
PS16, Line 419:* or if the type doesn't match the column's type
Nit: in situations like these, could you indent the continuation line so it's 
clearer that it belongs to the line before it? For example:

   * @throws IllegalArgumentException if the column is null
   * or if the type doesn't match the column's type
   * @throws IndexOutOfBoundsException if the column doesn't exist



--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 16
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 01 Oct 2019 19:11:16 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-09-24 Thread Attila Bukor (Code Review) 
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14050

to look at the new patch set (#16).

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..

KUDU-1938 [java] Add support for VARCHAR pt 4

Adds support for VARCHAR type to the Java and Spark clients. The
kudu-client only changes would break tests in kudu-spark and kudu-backup
so this patch also incorporates changes in these subprojects.

Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M 
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
29 files changed, 502 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/14050/16
--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 16
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-09-24 Thread Attila Bukor (Code Review) 
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14050

to look at the new patch set (#14).

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..

KUDU-1938 [java] Add support for VARCHAR pt 4

Adds support for VARCHAR type to the Java and Spark clients. The
kudu-client only changes would break tests in kudu-spark and kudu-backup
so this patch also incorporates changes in these subprojects.

Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M 
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
29 files changed, 502 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/14050/14
--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 14
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] KUDU-1938 [java] Add support for VARCHAR pt 4

2019-09-24 Thread Attila Bukor (Code Review) 
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14050

to look at the new patch set (#13).

Change subject: KUDU-1938 [java] Add support for VARCHAR pt 4
..

KUDU-1938 [java] Add support for VARCHAR pt 4

Adds support for VARCHAR type to the Java and Spark clients. The
kudu-client only changes would break tests in kudu-spark and kudu-backup
so this patch also incorporates changes in these subprojects.

Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
---
M java/kudu-backup-common/src/main/protobuf/backup.proto
M 
java/kudu-backup-common/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
M java/kudu-client/src/main/java/org/apache/kudu/ColumnTypeAttributes.java
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M 
java/kudu-client/src/main/java/org/apache/kudu/client/ColumnRangePredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/CharUtil.java
M java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
M java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPredicate.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanPredicate.java
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/DistributedDataGenerator.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/RowConverter.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
29 files changed, 502 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/14050/13
--
To view, visit http://gerrit.cloudera.org:8080/14050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03edf5e65409e895512d5cd81a607180632e8995
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 13
Gerrit-Owner: Attila Bukor 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon