[kudu-CR](gh-pages) Hotfix the 0.9.0 release notes to add UPSERT

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3363

Change subject: Hotfix the 0.9.0 release notes to add UPSERT
..

Hotfix the 0.9.0 release notes to add UPSERT

Change-Id: I0eee88dc83096677205695aca9c6aa99a8d590e3
---
M docs/release_notes.html
M releases/0.9.0/docs/release_notes.html
2 files changed, 14 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/3363/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0eee88dc83096677205695aca9c6aa99a8d590e3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans

[kudu-CR] RaftConsensus: Trigger election at startup if single node

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: RaftConsensus: Trigger election at startup if single node
..


Patch Set 2:

(1 comment)

can you add a test for this? something simple like setting the election timeout 
really high and then making sure we get a leader immediately?

http://gerrit.cloudera.org:8080/#/c/3344/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

Line 312:   bool only_voter = false;
pull this out to a method. something like IsSingleNodeConfig() or 
IsSingleVoterConfig


-- 
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] Add WaitUntilLeader() to Consensus interface

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Add WaitUntilLeader() to Consensus interface
..


Patch Set 2:

where is this used?

-- 
To view, visit http://gerrit.cloudera.org:8080/3345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6d8e0dd63e58c8ccdcf6497f0eb25be68b238ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR](gh-pages) Hotfix the 0.9.0 release notes to add UPSERT

[Misty Stanley-Jones (Code Review)]

Misty Stanley-Jones has posted comments on this change.

Change subject: Hotfix the 0.9.0 release notes to add UPSERT
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3363
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eee88dc83096677205695aca9c6aa99a8d590e3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Misty Stanley-Jones 
Gerrit-HasComments: No

[kudu-CR] Add WaitUntilLeader() to Consensus interface

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change.

Change subject: Add WaitUntilLeader() to Consensus interface
..


Patch Set 2:

It's used in the following patch. Maybe I should just squash it.

-- 
To view, visit http://gerrit.cloudera.org:8080/3345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6d8e0dd63e58c8ccdcf6497f0eb25be68b238ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] RaftConsensus: Trigger election at startup if single node

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change.

Change subject: RaftConsensus: Trigger election at startup if single node
..


Patch Set 2:

> (1 comment)
 > 
 > can you add a test for this? something simple like setting the
 > election timeout really high and then making sure we get a leader
 > immediately?

Good idea. I had a test but it I removed it since I didn't want to add an 
additional gflag just for this.

-- 
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Remove the LocalConsensus implementation

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Remove the LocalConsensus implementation
..


Patch Set 3:

general wondering. Should we just kill the consensus.h interface and refactor 
RaftConsensus->Consensus or use RaftConsensus directly? Seems unlikely that 
we'll ever want another consensus impl, so one less indirection layer and less 
virtual methods. Any roadblocks on the way to do this?

-- 
To view, visit http://gerrit.cloudera.org:8080/3350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24e671dc732a1cdf4c453dfec61cefa0c573252c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Do not run (g)addr2line translator on MacOS X

[Alexey Serbin (Code Review)]

Hello Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3360

to look at the new patch set (#2).

Change subject: Do not run (g)addr2line translator on MacOS X
..

Do not run (g)addr2line translator on MacOS X

When running tests on MacOS X, omit using the
stacktrace_addr2line.pl utility to translate addresses to line numbers.
For current builds on MacOS X, neither (g)addr2line nor atos
translate stack address into line number without extra-hassle.
This is so even for binaries linked without PIE
(see the -no_pie linker's option).

As for the extra-hassle part: there are at least two ways
to address that, but neither looks like a good candidate
in the context of the script.

  Option A:
Provide the atos utility with reference to running test process
using '-p ' option.  This, however, triggers a pop-up
requesting for password if it's run the very first time.

  Option B:
Take a snapshot of running test process using MacOS X tools
and provide the atos utility with the load address
using '-l ' option.

Change-Id: Idf8a81ae7f2e1b938734a4b66bec82cb731d90cc
---
M build-support/run-test.sh
1 file changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/3360/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idf8a81ae7f2e1b938734a4b66bec82cb731d90cc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [java client] Fix a race in TabletClient cleanup

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: [java client] Fix a race in TabletClient cleanup
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [java client] Fix a race in TabletClient cleanup

[Adar Dembo (Code Review)]

Adar Dembo has submitted this change and it was merged.

Change subject: [java client] Fix a race in TabletClient cleanup
..


[java client] Fix a race in TabletClient cleanup

Dan noticed some weird things going on after fixing 
TestAsyncKuduClient#testDisconnect,
we're either not handling some RPCs or doing it twice.

The reason is that we add to rpcs_inflight directly without caring for the 
state of
TabletClient (if it's connected or not). Later, we try to detect if we got 
disconnected
but there was no easy way to tell if our RPC was already retried for us or not.

This patch tries to make it clear whether the RPC at the end of 
TabletClient#sendRpc
is already handled or not: if the TabletClient is dead, and the rpcs_inflight 
list is
empty, then it got taken care of. If it's not empty, then it means the RPC 
needs to
be sent back to the AsyncKuduClient.

This patch fixes flakiness in the test mentioned above.

Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
Reviewed-on: http://gerrit.cloudera.org:8080/3340
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
---
M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java
1 file changed, 32 insertions(+), 21 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic87425bd54e01a50c3fc11f2862a3e5f737f2bf7
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Remove the LocalConsensus implementation

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Remove the LocalConsensus implementation
..


Patch Set 3:

yeah was not saying that we needed to do it here. Not sure there is much to 
discuss though, since you already discussed the removal of local consensus and 
it since there is a single implementation its simple cleaning.

-- 
To view, visit http://gerrit.cloudera.org:8080/3350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24e671dc732a1cdf4c453dfec61cefa0c573252c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Do not run (g)addr2line translator on MacOS X

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Do not run (g)addr2line translator on MacOS X
..


Patch Set 2: Code-Review+2

Ran the tests in my mac. When running on ctest all tests that injected failures 
were failing due to this. now they pass. lgtm (if jenkins agrees)

-- 
To view, visit http://gerrit.cloudera.org:8080/3360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf8a81ae7f2e1b938734a4b66bec82cb731d90cc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Do not run (g)addr2line translator on MacOS X

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Do not run (g)addr2line translator on MacOS X
..


Patch Set 2: Code-Review+1

Thanks for making those changes. Looks good to me, though ultimately I'll defer 
to someone who actually uses Mac OS.

If you do have some time, I'd love to know whether translation works in 
sanitizer builds on Mac OS. No worries if you've got other thing to look at, 
though.

-- 
To view, visit http://gerrit.cloudera.org:8080/3360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf8a81ae7f2e1b938734a4b66bec82cb731d90cc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Do not run (g)addr2line translator on MacOS X

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: Do not run (g)addr2line translator on MacOS X
..


Patch Set 1:

(2 comments)

> (2 comments)
 > 
 > My understanding is that sanitizer-enabled Kudu builds on Mac OS
 > will report correct line numbers since they use LLVM's built-in
 > symbolizer, so translation is only actually missing on the
 > addresses emitted by a CHECK() or equivalent crash. Is this
 > correct?

Thank you for review!

I haven't tried to run sanitizer-enabled builds.  Yes, as I understand the 
translation is needed for crash-related stacktrace printouts.  Anyways, it 
seems safe to remove addr2line translator since it does no do much on MacOS X 
anyways, just takes some to run.

http://gerrit.cloudera.org:8080/#/c/3360/1/build-support/run-test.sh
File build-support/run-test.sh:

PS1, Line 139: UNAME=$(uname -s)
 :   if [ "$UNAME" = "Darwin" ]; then
> How about using the bash built-in $OSTYPE? I think we typically use that in
Done


Line 143: # into line number.  The atos utility is able to do that only if
> Nit: can you fix this line's formatting a bit? Looks like you can squeeze a
Sure -- actually, I found these lines were too long (more than 80 chars).  I'll 
make them shorter and more uniformly filled.


-- 
To view, visit http://gerrit.cloudera.org:8080/3360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf8a81ae7f2e1b938734a4b66bec82cb731d90cc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] Do not run (g)addr2line translator on MacOS X

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: Do not run (g)addr2line translator on MacOS X
..


Patch Set 2:

> Thanks for making those changes. Looks good to me, though
 > ultimately I'll defer to someone who actually uses Mac OS.
 > 
 > If you do have some time, I'd love to know whether translation
 > works in sanitizer builds on Mac OS. No worries if you've got other
 > thing to look at, though.

Yep, sure -- I would like to get some feedback from Dan Burkert.  Yes, I'll try 
those sanitizer builds: I'm also curious how that works for those builds.

-- 
To view, visit http://gerrit.cloudera.org:8080/3360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf8a81ae7f2e1b938734a4b66bec82cb731d90cc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Remove the LocalConsensus implementation

[Mike Percy (Code Review)]

Mike Percy has uploaded a new patch set (#4).

Change subject: Remove the LocalConsensus implementation
..

Remove the LocalConsensus implementation

This implementation was intended as scaffolding while we built a true
consensus implementation. Now that we have a full implementation of Raft
consensus, it is no longer needed.

Also update ConsensusMetadata validation and remove the use of the
RaftConfigPB.local field (marked as obsolete).

Additionally, convert alter_table-test to use RaftConsensus:

1. Wait for tablet to be elected leader before proceeding.
2. All of the timestamps must be incremented due to the initial no-op
   written to the WAL by the Raft leader.

Finally, update the following tests to specify themselves as voters when
creating a single-node config:

* consensus_meta-test
* raft_consensus_state-test
* tablet_bootstrap-test

Change-Id: I24e671dc732a1cdf4c453dfec61cefa0c573252c
---
M docs/design-docs/consensus.md
M src/kudu/consensus/CMakeLists.txt
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus_meta-test.cc
D src/kudu/consensus/local_consensus.cc
D src/kudu/consensus/local_consensus.h
M src/kudu/consensus/log.h
M src/kudu/consensus/metadata.proto
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/raft_consensus_state-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_peer-test.cc
M src/kudu/tablet/tablet_peer.cc
M src/kudu/tserver/mini_tablet_server.cc
M src/kudu/tserver/remote_bootstrap_session-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
20 files changed, 31 insertions(+), 403 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/3350/4
-- 
To view, visit http://gerrit.cloudera.org:8080/3350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24e671dc732a1cdf4c453dfec61cefa0c573252c
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy 

[kudu-CR] RaftConsensus: Trigger election at startup if single node

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: RaftConsensus: Trigger election at startup if single node
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/1813/

-- 
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Remove the LocalConsensus implementation

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Remove the LocalConsensus implementation
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/1814/

-- 
To view, visit http://gerrit.cloudera.org:8080/3350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24e671dc732a1cdf4c453dfec61cefa0c573252c
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] RaftConsensus: Trigger election at startup if single node

[Mike Percy (Code Review)]

Mike Percy has uploaded a new patch set (#3).

Change subject: RaftConsensus: Trigger election at startup if single node
..

RaftConsensus: Trigger election at startup if single node

If a tablet's replication factor is 1 then don't wait for the failure
detector to kick in. Simply kick off an election immediately.

Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/raft_consensus-itest.cc
3 files changed, 28 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/3344/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy 

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Use RaftConsensus instead of LocalConsensus in tests
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/1812/

-- 
To view, visit http://gerrit.cloudera.org:8080/3346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72e94d7e78e3428a8d9696737e07b8e8f7489d49
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

[Mike Percy (Code Review)]

Mike Percy has uploaded a new patch set (#3).

Change subject: Use RaftConsensus instead of LocalConsensus in tests
..

Use RaftConsensus instead of LocalConsensus in tests

This paves the way to remove the LocalConsensus implementation.

Also add WaitUntilLeader() to Consensus interface for use by tests.

Changes the following tests to use RaftConsensus:

* tablet_peer-test
* remote_bootstrap_client-test
* remote_bootstrap_session-test
* tablet_server-test
* ts_tablet_manager-test

Change-Id: I72e94d7e78e3428a8d9696737e07b8e8f7489d49
---
M src/kudu/consensus/consensus.h
M src/kudu/consensus/local_consensus.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/tablet/tablet_peer-test.cc
M src/kudu/tserver/mini_tablet_server.cc
M src/kudu/tserver/remote_bootstrap-test-base.h
M src/kudu/tserver/remote_bootstrap_client-test.cc
M src/kudu/tserver/remote_bootstrap_session-test.cc
M src/kudu/tserver/tablet_server-stress-test.cc
M src/kudu/tserver/tablet_server-test-base.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
13 files changed, 70 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/3346/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I72e94d7e78e3428a8d9696737e07b8e8f7489d49
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy 

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Use RaftConsensus instead of LocalConsensus in tests
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/1815/

-- 
To view, visit http://gerrit.cloudera.org:8080/3346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72e94d7e78e3428a8d9696737e07b8e8f7489d49
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] RaftConsensus: Trigger election at startup if single node

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: RaftConsensus: Trigger election at startup if single node
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/1816/

-- 
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Remove the LocalConsensus implementation

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Remove the LocalConsensus implementation
..


Patch Set 5:

Build Started http://104.196.14.100/job/kudu-gerrit/1817/

-- 
To view, visit http://gerrit.cloudera.org:8080/3350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24e671dc732a1cdf4c453dfec61cefa0c573252c
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Add WaitUntilLeader() to Consensus interface

[Mike Percy (Code Review)]

Mike Percy has abandoned this change.

Change subject: Add WaitUntilLeader() to Consensus interface
..


Abandoned

Squashing this into the following commit.

-- 
To view, visit http://gerrit.cloudera.org:8080/3345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic6d8e0dd63e58c8ccdcf6497f0eb25be68b238ea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy 

[kudu-CR] RaftConsensus: Trigger election at startup if single node

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change.

Change subject: RaftConsensus: Trigger election at startup if single node
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3344/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

Line 312:   bool only_voter = false;
> pull this out to a method. something like IsSingleNodeConfig() or IsSingleV
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] Remove the LocalConsensus implementation

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change.

Change subject: Remove the LocalConsensus implementation
..


Patch Set 3:

OK, still let's do it a bit later.

-- 
To view, visit http://gerrit.cloudera.org:8080/3350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24e671dc732a1cdf4c453dfec61cefa0c573252c
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] RaftConsensus: Trigger election at startup if single node

[Mike Percy (Code Review)]

Mike Percy has uploaded a new patch set (#4).

Change subject: RaftConsensus: Trigger election at startup if single node
..

RaftConsensus: Trigger election at startup if single node

If a tablet's replication factor is 1 then don't wait for the failure
detector to kick in. Simply kick off an election immediately.

Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/raft_consensus-itest.cc
3 files changed, 28 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/3344/4
-- 
To view, visit http://gerrit.cloudera.org:8080/3344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief51ab20c051db83bea51c146b24a11036d9f953
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] Fix variable name typo in ITBLL

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Fix variable name typo in ITBLL
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1819/

-- 
To view, visit http://gerrit.cloudera.org:8080/3367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I606d0e2eb931fb355d58cb43ef7f0e471371326e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] create-demo-table must specify parition columns

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: create-demo-table must specify parition columns
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3368/1//COMMIT_MSG
Commit Message:

PS1, Line 7: parition
Nit: partition


-- 
To view, visit http://gerrit.cloudera.org:8080/3368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I894214bbd9f8198909344c249780711058d5398d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] create-demo-table must specify partition columns

[Mike Percy (Code Review)]

Mike Percy has uploaded a new patch set (#2).

Change subject: create-demo-table must specify partition columns
..

create-demo-table must specify partition columns

This is a recent API change that didn't make it into this dev tool.

Change-Id: I894214bbd9f8198909344c249780711058d5398d
---
M src/kudu/tools/create-demo-table.cc
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/3368/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I894214bbd9f8198909344c249780711058d5398d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] create-demo-table must specify partition columns

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: create-demo-table must specify partition columns
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/1821/

-- 
To view, visit http://gerrit.cloudera.org:8080/3368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I894214bbd9f8198909344c249780711058d5398d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] create-demo-table must specify partition columns

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: create-demo-table must specify partition columns
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I894214bbd9f8198909344c249780711058d5398d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Fix variable name typo in ITBLL

[Mike Percy (Code Review)]

Mike Percy has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3367

Change subject: Fix variable name typo in ITBLL
..

Fix variable name typo in ITBLL

Change-Id: I606d0e2eb931fb355d58cb43ef7f0e471371326e
---
M 
java/kudu-client-tools/src/main/java/org/kududb/mapreduce/tools/IntegrationTestBigLinkedList.java
1 file changed, 13 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/3367/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I606d0e2eb931fb355d58cb43ef7f0e471371326e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 

[kudu-CR](gh-pages) Blog post for 0.9.0 release

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: Blog post for 0.9.0 release
..


Blog post for 0.9.0 release

Change-Id: I70b4be74e350232110e580844d4f71e012fa813f
Reviewed-on: http://gerrit.cloudera.org:8080/3357
Reviewed-by: Jean-Daniel Cryans
Tested-by: Jean-Daniel Cryans
---
A _posts/2016-06-10-apache-kudu-0-9-0-released.md
1 file changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I70b4be74e350232110e580844d4f71e012fa813f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Misty Stanley-Jones 

[kudu-CR](gh-pages) Blog post for 0.9.0 release

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change.

Change subject: Blog post for 0.9.0 release
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3357/2/_posts/2016-06-10-apache-kudu-0-9-0-released.md
File _posts/2016-06-10-apache-kudu-0-9-0-released.md:

Line 9: This latest version adds basic UPSERT functionality and a new Spark 
Data Source
> How about "a new high-performance Spark Data Source"
I'll go with "improved"


-- 
To view, visit http://gerrit.cloudera.org:8080/3357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70b4be74e350232110e580844d4f71e012fa813f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Misty Stanley-Jones 
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) Blog post for 0.9.0 release

[Jean-Daniel Cryans (Code Review)]

Hello Adar Dembo,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3357

to look at the new patch set (#3).

Change subject: Blog post for 0.9.0 release
..

Blog post for 0.9.0 release

Change-Id: I70b4be74e350232110e580844d4f71e012fa813f
---
A _posts/2016-06-10-apache-kudu-0-9-0-released.md
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/3357/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70b4be74e350232110e580844d4f71e012fa813f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Misty Stanley-Jones 

[kudu-CR](gh-pages) Add 0.9.0 release and refresh docs

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change.

Change subject: Add 0.9.0 release and refresh docs
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib04c111bd40181f6cbe3978dc87d65a63b01b3ba
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Misty Stanley-Jones 
Gerrit-HasComments: No