[kudu-CR] Update docs on how to run gcovr
Mike Percy has submitted this change and it was merged. Change subject: Update docs on how to run gcovr .. Update docs on how to run gcovr Change-Id: I494136e20452b76572d753b54fc7a095aa54a69b Reviewed-on: http://gerrit.cloudera.org:8080/3508 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M README.adoc 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I494136e20452b76572d753b54fc7a095aa54a69b Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] barrier.h: Add missing thread restrictions.h include
Mike Percy has submitted this change and it was merged. Change subject: barrier.h: Add missing thread_restrictions.h include .. barrier.h: Add missing thread_restrictions.h include This is required for ThreadRestrictions::AssertWaitAllowed(). Change-Id: I6eab8e9e9d69cea44eb62d01137040fe02043537 Reviewed-on: http://gerrit.cloudera.org:8080/3620 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M src/kudu/util/barrier.h 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6eab8e9e9d69cea44eb62d01137040fe02043537 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Add weekly update for 07/11
Jean-Daniel Cryans has posted comments on this change. Change subject: Add weekly update for 07/11 .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c60067b9e548ff1f75b1cd940646ad6debf462d Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Add weekly update for 07/11
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add weekly update for 07/11 .. Add weekly update for 07/11 Change-Id: I5c60067b9e548ff1f75b1cd940646ad6debf462d Reviewed-on: http://gerrit.cloudera.org:8080/3616 Reviewed-by: Mike Percy Reviewed-by: Adar Dembo Tested-by: Jean-Daniel Cryans --- A _posts/2016-07-11-weekly-update.md 1 file changed, 59 insertions(+), 0 deletions(-) Approvals: Jean-Daniel Cryans: Verified Mike Percy: Looks good to me, approved Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c60067b9e548ff1f75b1cd940646ad6debf462d Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon
[kudu-CR] master: fix corruption when AlterTable() races with CreateTable()
Dan Burkert has posted comments on this change. Change subject: master: fix corruption when AlterTable() races with CreateTable() .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c9e4214c09bc47a5a10b12d6ffe8b35906708c9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] rw mutex: add configurable priority
Dan Burkert has posted comments on this change. Change subject: rw_mutex: add configurable priority .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ba6cd041f126c94e63fa07a1e84c88db6778d7 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: add read-write lock to serialize operations around elections
Dan Burkert has posted comments on this change. Change subject: master: add read-write lock to serialize operations around elections .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5084c09f1a77ccf620fb6cd621094c4778d636f8 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the ResultTracker into the rpc subsystem
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 19: (7 comments) http://gerrit.cloudera.org:8080/#/c/3192/19//COMMIT_MSG Commit Message: PS19, Line 11: specificed > typo Done http://gerrit.cloudera.org:8080/#/c/3192/19/src/kudu/rpc/CMakeLists.txt File src/kudu/rpc/CMakeLists.txt: Line 111: kudu_common > is this still needed? this back-dependency strikes me as evil dom't think so, good catch. removed http://gerrit.cloudera.org:8080/#/c/3192/19/src/kudu/rpc/protoc-gen-krpc.cc File src/kudu/rpc/protoc-gen-krpc.cc: Line 189: (*map)["result_tracker"] = "result_tracker"; > how about: (*map)["result_tracker"] = track_result ? "result_tracker" : "nu Done http://gerrit.cloudera.org:8080/#/c/3192/19/src/kudu/rpc/rpc_context.h File src/kudu/rpc/rpc_context.h: Line 23: #include "kudu/rpc/result_tracker.h" > forward decl Done Line 181: // If this returns true, both GetResultTracker() request_id() should return non > - missing word "and" Done PS19, Line 186: Get > style: no "Get" Done http://gerrit.cloudera.org:8080/#/c/3192/19/src/kudu/rpc/service_if.h File src/kudu/rpc/service_if.h: Line 58: scoped_refptr result_tracker; > now that the result tracker is service-wide, does it really make sense to h made the result tracker a member of the GeneratedServiceIf class and made the RpcMethodInfo field a bool. -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-1487 Add instructions for cutting a release
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1487 Add instructions for cutting a release .. Patch Set 1: (4 comments) Thanks a lot Misty for taking my original document to the finish line. http://gerrit.cloudera.org:8080/#/c/3614/1/RELEASING.adoc File RELEASING.adoc: Line 1: = RELEASING KUDU I think we need a license header here. Line 55: + Missing a line here? PS1, Line 90: #might not be necessary? Yeah this might not be since we rely on that repo only for gerrit, and we don't push patches to tags. Line 149: . Push the tag to the ASF’s git. I guess we should add a command line example here, since we do it almost everywhere else. -- To view, visit http://gerrit.cloudera.org:8080/3614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b52edb68d35d07ee50bb3c373bf866560f5bc93 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Misty Stanley-Jones Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] Add a ResultTracker class that will track server side results
David Ribeiro Alves has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 25: Todd: As we discussed I also changed the TrackRpc/ChangeDriver methods. I added a new TrackRpcUnlocked and a TrackRpcOrChangeDriver methods. The latter tracks the RPC or changes the driver, atomically. -- To view, visit http://gerrit.cloudera.org:8080/3190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6718951a9998a6c9b0db35e8f09ff8304591e8b1 Gerrit-PatchSet: 25 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
David Ribeiro Alves has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/3506/8//COMMIT_MSG Commit Message: Line 14: Note that the flag was added to env.cc as it had to be added somwhere that would > hrmmm... I'm not a fan of this. changed the flag to be enabled server side and changed this too. http://gerrit.cloudera.org:8080/#/c/3506/8/src/kudu/rpc/retriable_rpc.h File src/kudu/rpc/retriable_rpc.h: Line 193: if (FLAGS_enable_exactly_once) { > I think having the kill switch on the server side is preferable Done http://gerrit.cloudera.org:8080/#/c/3506/8/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: Line 86: FLAGS_enable_exactly_once = true; > I don't think this is quite sufficient, because it won't enable it on exter it was sufficient, since the flag was client side, but it isn't anymore. so added the flag where appropriate. -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] [java client] Redo how we manage exceptions
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3055 to look at the new patch set (#5). Change subject: [java client] Redo how we manage exceptions .. [java client] Redo how we manage exceptions Right now the exceptions are hard to handle in the Java client. They're all generic and you need to do a lot of introspection. For example, if you try to create a table that already exists, you need to start searching the exception's message to know if it's that or some other problem that gave you the error. With this patch we now only one main kind of public exception: KuduException. We still have Recoverable/NonRecoverableException but those are now package-private and only used internally. PleaseThrottleException is kept public for the async API. KuduException has a new field, `status`, which is your regular Kudu Status object. Wherever we can we try to recreate the Status objects that are sent to us from the servers, else we create our own. Now for the example above we can just query the exception's status with `isNotFound()`. The sync APIs is also modified to only throw KuduExceptions instead of plain Exceptions. Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java D java/kudu-client/src/main/java/org/kududb/client/ConnectionResetException.java M java/kudu-client/src/main/java/org/kududb/client/GetMasterRegistrationReceived.java D java/kudu-client/src/main/java/org/kududb/client/InvalidResponseException.java M java/kudu-client/src/main/java/org/kududb/client/KuduClient.java M java/kudu-client/src/main/java/org/kududb/client/KuduException.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/KuduScanner.java D java/kudu-client/src/main/java/org/kududb/client/KuduServerException.java M java/kudu-client/src/main/java/org/kududb/client/KuduSession.java D java/kudu-client/src/main/java/org/kududb/client/MasterErrorException.java M java/kudu-client/src/main/java/org/kududb/client/NoLeaderMasterFoundException.java M java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeException.java M java/kudu-client/src/main/java/org/kududb/client/NonRecoverableException.java M java/kudu-client/src/main/java/org/kududb/client/PleaseThrottleException.java M java/kudu-client/src/main/java/org/kududb/client/RecoverableException.java M java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java M java/kudu-client/src/main/java/org/kududb/client/Status.java M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java D java/kudu-client/src/main/java/org/kududb/client/TabletServerErrorException.java M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduSession.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduSession.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduTable.java M java/kudu-client/src/test/java/org/kududb/client/TestTimeouts.java 26 files changed, 324 insertions(+), 447 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/3055/5 -- To view, visit http://gerrit.cloudera.org:8080/3055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [java client] Redo how we manage exceptions
Kudu Jenkins has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2333/ -- To view, visit http://gerrit.cloudera.org:8080/3055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the request tracker with the client
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/3080/17/src/kudu/rpc/retriable_rpc.h File src/kudu/rpc/retriable_rpc.h: Line 212: // failure. > something funny happened to a comment here Done http://gerrit.cloudera.org:8080/#/c/3080/17/src/kudu/rpc/rpc_controller.h File src/kudu/rpc/rpc_controller.h: Line 119: // calling this method. > I think this is more simply stated: REQUIRES: the controller has a request Done -- To view, visit http://gerrit.cloudera.org:8080/3080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Add a ResultTracker class that will track server side results
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#26). Change subject: Add a ResultTracker class that will track server side results .. Add a ResultTracker class that will track server side results This adds the initial version of the ResultTracker class that will be responsible for tracking responses when we want exactly once call semantics. While this is minimally working, i.e it's able to track responses and can be used for exactly once semantics, it's not complete. Future patches will address the missing functionality. Still missing are: - Time based client state cleaning. - Watermark based per client state cleaning. I initially had a unit test for this class, but it relied on templating out the RpcContext (since it's not easy to build one for a unit test and it's not clear what it would do) which became problematic as the class grew. So I decided to add a new rpc-stress-tess that will test this class within the rpc framework. I feel it's easier to do it that way and that, since the client is not being used, the test can still be very straight forward. This test is in a followup patch as it can only run after the integration with the rest of the rpc subsystem. Change-Id: I6718951a9998a6c9b0db35e8f09ff8304591e8b1 --- M src/kudu/rpc/CMakeLists.txt A src/kudu/rpc/result_tracker.cc A src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc_context.h 4 files changed, 599 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/3190/26 -- To view, visit http://gerrit.cloudera.org:8080/3190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6718951a9998a6c9b0db35e8f09ff8304591e8b1 Gerrit-PatchSet: 26 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add a RpcContext::RespondFailure() method
Kudu Jenkins has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 21: Build Started http://104.196.14.100/job/kudu-gerrit/2337/ -- To view, visit http://gerrit.cloudera.org:8080/3191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f1387ba0f837046a8056e77f73a3982f06c73a2 Gerrit-PatchSet: 21 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a ToString() method to Proxy
Kudu Jenkins has posted comments on this change. Change subject: Add a ToString() method to Proxy .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2339/ -- To view, visit http://gerrit.cloudera.org:8080/3502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1e158db09e6e3c188b2725424681187a4b8c72e Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the ResultTracker into the rpc subsystem
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#23). Change subject: Integrate the ResultTracker into the rpc subsystem .. Integrate the ResultTracker into the rpc subsystem This integrates the ResultTracker into the rpc subsystem by allowing to specify a new method option when defining rpc service methods. When this method option is specified _and_ the call's rpc header has a RequestIdPB the results for the call will be tracked and the call may have exactly once semantics. This allows to have the simplest form of exactly once semantics for single server calls. Of course limitations apply, like response persistence across restarts is not supported, neither is propagating/rebuilding responses to/on replicas for replicated calls. If support for this is needed it will have to be done ad-hoc, case by case. This adds a tests that has multiple threads trying to execute the same rpc, and makes sure each one was executed exactly once. Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 --- M src/kudu/master/master.cc M src/kudu/master/master_service.cc M src/kudu/rpc/CMakeLists.txt M src/kudu/rpc/inbound_call.cc M src/kudu/rpc/protoc-gen-krpc.cc A src/kudu/rpc/rpc-stress-test.cc M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc_context.cc M src/kudu/rpc/rpc_context.h M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/rtest.proto M src/kudu/rpc/service_if.cc M src/kudu/rpc/service_if.h M src/kudu/server/generic_service.cc M src/kudu/server/server_base.cc M src/kudu/server/server_base.h M src/kudu/tserver/remote_bootstrap_service.cc M src/kudu/tserver/remote_bootstrap_service.h M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h 21 files changed, 388 insertions(+), 60 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/3192/23 -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 Gerrit-PatchSet: 23 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Integrate the request tracker with the client
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3080 to look at the new patch set (#22). Change subject: Integrate the request tracker with the client .. Integrate the request tracker with the client This integrates the request tracker with the client, making sure that write requests sent by the client are tracked in the RequestTracker and contain the information necessary for exactly once semantics. This adds to rpc-stress-test a test that uses RetriableRpc, instead of using the proxy directly. Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee --- M src/kudu/client/batcher.cc M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client.cc M src/kudu/rpc/retriable_rpc.h M src/kudu/rpc/rpc-stress-test.cc M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc_controller.cc M src/kudu/rpc/rpc_controller.h M src/kudu/rpc/rtest.proto 10 files changed, 245 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/3080/22 -- To view, visit http://gerrit.cloudera.org:8080/3080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee Gerrit-PatchSet: 22 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Integrate the ResultTracker into the rpc subsystem
Kudu Jenkins has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 23: Build Started http://104.196.14.100/job/kudu-gerrit/2336/ -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 Gerrit-PatchSet: 23 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()
Kudu Jenkins has posted comments on this change. Change subject: Make RequestTracker not return Status on FirstIncomplete() .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2335/ -- To view, visit http://gerrit.cloudera.org:8080/3504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a ResultTracker class that will track server side results
Kudu Jenkins has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 26: Build Started http://104.196.14.100/job/kudu-gerrit/2338/ -- To view, visit http://gerrit.cloudera.org:8080/3190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6718951a9998a6c9b0db35e8f09ff8304591e8b1 Gerrit-PatchSet: 26 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the request tracker with the client
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 22: Build Started http://104.196.14.100/job/kudu-gerrit/2334/ -- To view, visit http://gerrit.cloudera.org:8080/3080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee Gerrit-PatchSet: 22 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 17: (18 comments) http://gerrit.cloudera.org:8080/#/c/3449/17/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: Line 51: #include "kudu/rpc/rpc_header.pb.h" > unused? Done http://gerrit.cloudera.org:8080/#/c/3449/17/src/kudu/consensus/consensus.proto File src/kudu/consensus/consensus.proto: Line 182: optional rpc.RequestIdPB request_id = 100; > why using such a high id here? seems like it wastes a byte the idea was that we could keep adding request types (like the optional below). changed this to be in sequence. http://gerrit.cloudera.org:8080/#/c/3449/17/src/kudu/rpc/result_tracker.h File src/kudu/rpc/result_tracker.h: Line 226: bool final_driver = false; > doc this removed this (scaffolding code) http://gerrit.cloudera.org:8080/#/c/3449/17/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: Line 251: WriteResponsePB* response); > mentioned on rev 1, but I dont like the side effect here without an accompa Done Line 1243: if (tracking_results) { > any way to extract this new bit of code to a separate function? this is way simpler now with the atomic bit. please take a new look. Line 1279: LOG(FATAL) << "Couldn't change bootstrapping txn to driver after 10 attempts for request: " > this seems like a kind of arbitrary thing... should this be a DFATAL and ke removed http://gerrit.cloudera.org:8080/#/c/3449/17/src/kudu/tablet/tablet_peer.cc File src/kudu/tablet/tablet_peer.cc: Line 130: const scoped_refptr result_tracker, > reference Done http://gerrit.cloudera.org:8080/#/c/3449/17/src/kudu/tablet/transactions/transaction_driver.cc File src/kudu/tablet/transactions/transaction_driver.cc: Line 212: if (state()->are_results_tracked()) { > change to if (!...) return Done Line 314: case REPLICATING: > some spurious changes here Done http://gerrit.cloudera.org:8080/#/c/3449/17/src/kudu/tablet/transactions/transaction_driver.h File src/kudu/tablet/transactions/transaction_driver.h: PS17, Line 117: // 1 - When becoming leader, a replica has already prepared all the requests that it received : // from the previous leader that it will try to replicate/commit itself. : / > not quite understanding this sentence Done PS17, Line 122: Requests originated on other replicas > not sure quite what you mean here. Do you mean operations which were starte Done PS17, Line 158: FailAndRespond() > hrm, is this FailAndRespond here actually responding to any RPCs in the cur the design changed and the docs were not updated. change this to reflect the new state of affairs. http://gerrit.cloudera.org:8080/#/c/3449/17/src/kudu/tablet/transactions/write_transaction.h File src/kudu/tablet/transactions/write_transaction.h: PS17, Line 196: c_ > typo Done http://gerrit.cloudera.org:8080/#/c/3449/17/src/kudu/tserver/remote_bootstrap_session-test.cc File src/kudu/tserver/remote_bootstrap_session-test.cc: Line 137: dummy, > can just use scoped_refptr(), no? Done http://gerrit.cloudera.org:8080/#/c/3449/17/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: Line 280: const char* ALREADY_PRESENT_ERROR = "There's already an attempt at the same operation " > is this used? Done Line 295: //LOG(INFO) << "Responding error to: " << context_->request_pb()->DebugString(); > remove Done Line 764: // attempted elsewhere. > this probably needs to be moved into tablet_peer this now is done on the replicate message for all txns. removed http://gerrit.cloudera.org:8080/#/c/3449/17/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 123: const char* WRITE_METHOD_NAME = "Write"; > what's this used for? dont see it referenced elsewhere Done -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
David Ribeiro Alves has uploaded a new patch set (#10). Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Disable exactly once semantics by default and add a flag to enable it for tests Since exactly once semantics is still missing some pieces, like garbage collection this disables it by default on the server, but adds a flag to allow enabling it and enables it in all tablet server tests, by default. Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 --- M src/kudu/integration-tests/ts_itest-base.h M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/service_if.cc M src/kudu/tserver/tablet_server-test-base.h 4 files changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/3506/10 -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add integration tests for replay cache with writes
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3519 to look at the new patch set (#25). Change subject: Add integration tests for replay cache with writes .. Add integration tests for replay cache with writes This adds a couple of new integration tests for replay cache with writes. Both tests start multiple threads writing, independently, to tablet servers simulaneously. The tests leverage the fact that followers are also able to answer requests, once they are cached, and stores all responses, which are compared at the end of the test. Some of the requests (1/3) are "empty" writes, so that we stress the serialization point in transaction_driver.cc without relying on row lock serialization. This adds two different tests, one that stresses a lot of elections and one that crashes nodes. This is inline with other tests we already had in raft_consensus-itest. This also adds a new fault injection point right after the leader sends a request. We currently have one right _before_ the leader sends a request, but having one for after the request is sent encourages stressing the path where a newly elected leader as both incoming client request and ongoing replica transactions, which can possibly race with each other if they correspond to the same write. I looped this about 1000 times, without related failures. Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f --- M src/kudu/consensus/consensus_peers.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/rpc/rpc_header.proto 3 files changed, 246 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3519/25 -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 25 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add a way to dump ResultTracker state
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3569 to look at the new patch set (#7). Change subject: Add a way to dump ResultTracker state .. Add a way to dump ResultTracker state This adds a way to dump result tracker state and makes sure we use it when FATAling out on CHECK failures. Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1 --- M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h 2 files changed, 69 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/3569/7 -- To view, visit http://gerrit.cloudera.org:8080/3569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Integrate the result tracker with writes
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3449 to look at the new patch set (#21). Change subject: Integrate the result tracker with writes .. Integrate the result tracker with writes This patch integrates the result tracker with write transactions, including: - Support for caching responses on tablet bootstrap. - Support for caching responses for follower transactions. - Handling of races between client originated and (previous?) leader originated transactions. - An explanation of the interaction between the result tracker and the transaction driver in transaction_driver.h. For integration tests, this patch removes the check that allowed Status::AlreadyPresent() that we added as we didn't have support for exactly once semantics. Without this check, in slow mode, some tests like raft_consensus-itest would fail 100% of the time, due to rows being inserted multiple times. Because we'd have 100% failure rate without replay cache for writes and because testing it specifically is involved, this patch doesn't include additional tests, these will be pushed as a follow up. Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 --- M src/kudu/client/batcher.cc M src/kudu/consensus/consensus.proto M src/kudu/integration-tests/test_workload.cc M src/kudu/integration-tests/test_workload.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer-test.cc M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tools/insert-generated-rows.cc M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/remote_bootstrap_session-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/tserver/tserver_service.proto 23 files changed, 374 insertions(+), 37 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/3449/21 -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 21 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add a way to dump ResultTracker state
Kudu Jenkins has posted comments on this change. Change subject: Add a way to dump ResultTracker state .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2342/ -- To view, visit http://gerrit.cloudera.org:8080/3569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add integration tests for replay cache with writes
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 25: Build Started http://104.196.14.100/job/kudu-gerrit/2344/ -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 25 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 21: Build Started http://104.196.14.100/job/kudu-gerrit/2341/ -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 21 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
Kudu Jenkins has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2340/ -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md
Kudu Jenkins has posted comments on this change. Change subject: Add information about Exactly Once RPC semantics to rpc.md .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2343/ -- To view, visit http://gerrit.cloudera.org:8080/3503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java client] Redo how we manage exceptions
Adar Dembo has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 5: (16 comments) Definitely make a pass over the Javadoc for: 1. Adding @throws where necessary, and 2. Updating public-facing docs to avoid mentioning private exception classes. Also, what value does the separation between RecoverableException and NonRecoverableException bring, for internal client use that is? http://gerrit.cloudera.org:8080/#/c/3055/5/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 1029: Status statusTimedOut = Status.TimedOut(message + request); Perhaps unrelated, but in the C++ client we try to preserve the last "real" error so that in the event of a timeout, we can provide that to the user too. Line 1280: return new NonRecoverableException(status); Ugh. Can we use an errback instead of using the callback for exceptions too? http://gerrit.cloudera.org:8080/#/c/3055/5/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java: Line 843: Status statusCorruption = Status.Corruption("Scan RPC response was for scanner" I think we typically reserve "corruption" for scrambled data and equivalent. Maybe IllegalState or InvalidArgument here? http://gerrit.cloudera.org:8080/#/c/3055/5/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java: Line 491: public Deferred apply(final Operation operation) throws KuduException { Update Javadoc. Make a pass over the other changed methods too, to make sure they have a @throws. Line 536: Status.ConfigurationError("MANUAL_FLUSH is enabled but the buffer is too big"); Maybe IllegalState instead? http://gerrit.cloudera.org:8080/#/c/3055/5/java/kudu-client/src/main/java/org/kududb/client/GetMasterRegistrationReceived.java File java/kudu-client/src/main/java/org/kududb/client/GetMasterRegistrationReceived.java: Line 127: Status statusConfigurationError = Status.ConfigurationError( Why not NotFound? http://gerrit.cloudera.org:8080/#/c/3055/5/java/kudu-client/src/main/java/org/kududb/client/KuduClient.java File java/kudu-client/src/main/java/org/kududb/client/KuduClient.java: Line 92:* @throws NonRecoverableException for any error returned by sending RPCs to the master Nope, NonRecoverableException isn't public. Line 107: } catch (Exception ex) { Isn't it only d.join() that needs to be surrounded in the try/catch? http://gerrit.cloudera.org:8080/#/c/3055/5/java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java File java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java: Why RuntimeExceptions from this file and not some kind of KuduException? http://gerrit.cloudera.org:8080/#/c/3055/5/java/kudu-client/src/main/java/org/kududb/client/KuduSession.java File java/kudu-client/src/main/java/org/kududb/client/KuduSession.java: Line 52:* Blocking call with a different behavior based on the flush mode. PleaseThrottleException is Should update this to avoid mentioning private exception types. PS5, Line 99: DeferredGroupException. We shouldn't mention this; it's not a public exception any more. http://gerrit.cloudera.org:8080/#/c/3055/5/java/kudu-client/src/main/java/org/kududb/client/NoLeaderMasterFoundException.java File java/kudu-client/src/main/java/org/kududb/client/NoLeaderMasterFoundException.java: Line 42:* Factory method that creates a NoLeaderException given a message and a list Nit: NoLeaderMasterFoundException Line 53: static NoLeaderMasterFoundException create(String msg, List causes) { What value does this factory method add? I think all other exceptions are constructed directly; can we do the same here? I think it'd make more sense that way, because then the caller is responsible for constructing the Status, and the caller is best positioned to know exactly what kind of Status to use. http://gerrit.cloudera.org:8080/#/c/3055/5/java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java File java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java: PS5, Line 71: throw new RuntimeException("RowResult block has " + bs.length() + : " bytes of data but expected " + expectedSize + " for " + numRows + " rows"); Maybe we can move this check into a method where it'd be more natural to throw a checked exception? http://gerrit.cloudera.org:8080/#/c/3055/5/java/kudu-client/src/main/java/org/kududb/client/Status.java File java/kudu-client/src/main/java/org/kududb/client/Status.java: PS5, Line 26: Wraps {@link org.kududb.WireProtocol.AppStatusPB}. : * See also {@code src/kudu/util/status.h} in the C+
[kudu-CR] Add integration tests for replay cache with writes
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 26: Build Started http://104.196.14.100/job/kudu-gerrit/2349/ -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 26 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] WIP: Memory tracking for result tracker
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3627 Change subject: WIP: Memory tracking for result tracker .. WIP: Memory tracking for result tracker Missing directed test Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 --- M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc-test-base.h M src/kudu/server/server_base.cc 4 files changed, 53 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/3627/1 -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves
[kudu-CR] WIP: Memory tracking for result tracker
Kudu Jenkins has posted comments on this change. Change subject: WIP: Memory tracking for result tracker .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2350/ -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP: Add garbage collection to ResultTracker
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3628 Change subject: WIP: Add garbage collection to ResultTracker .. WIP: Add garbage collection to ResultTracker This still needs testing and hooking up to the mm. Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 --- M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc-stress-test.cc M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/service_if.cc 5 files changed, 155 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/3628/1 -- To view, visit http://gerrit.cloudera.org:8080/3628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
Kudu Jenkins has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2346/ -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 22: Build Started http://104.196.14.100/job/kudu-gerrit/2347/ -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 22 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] WIP: Add garbage collection to ResultTracker
Kudu Jenkins has posted comments on this change. Change subject: WIP: Add garbage collection to ResultTracker .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2351/ -- To view, visit http://gerrit.cloudera.org:8080/3628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3506 to look at the new patch set (#11). Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Disable exactly once semantics by default and add a flag to enable it for tests Since exactly once semantics is still missing some pieces, like garbage collection this disables it by default on the server, but adds a flag to allow enabling it and enables it in all tablet server tests, by default. Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 --- M src/kudu/integration-tests/ts_itest-base.h M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/service_if.cc M src/kudu/tserver/tablet_server-test-base.h 4 files changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/3506/11 -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add a way to include request ids in log-dump
Kudu Jenkins has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2345/ -- To view, visit http://gerrit.cloudera.org:8080/3612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88d7c65887a98544ee83b5b4bc0817bea7222131 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Add a way to dump ResultTracker state
Kudu Jenkins has posted comments on this change. Change subject: Add a way to dump ResultTracker state .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2348/ -- To view, visit http://gerrit.cloudera.org:8080/3569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] client.h: doxygen comments for C++ API
Adar Dembo has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 5: (9 comments) I didn't review the changes in client.h in detail yet, wanted to figure out the infrastructure first. Did you look into lint-style checkers that will warn (and, more importantly, fail a precommit build) if the doxygen syntax is malformed in the whitelisted files where it's expected? I think such a checker is important; without it, the syntax will gradually bitrot as people make mistakes, or code reviewers will have to look for syntactic mistakes. http://gerrit.cloudera.org:8080/#/c/3619/5/CMakeLists.txt File CMakeLists.txt: Line 963: find_package(Doxygen REQUIRED) Doesn't this mean that any invocation of cmake will require doxygen? That seems unnecessarily harsh to developers who don't want to build the docs. Line 966: WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/docs) Shouldn't this be CMAKE_CURRENT_BINARY_DIR? Otherwise we're polluting the source directory with "build output". Line 977: DEPENDS doxydocs) Does this work? The cmake docs say that DEPENDS should reference files and outputs of add_custom_command(), which suggests that the right way to enforce dependencies is via add_dependencies(). http://gerrit.cloudera.org:8080/#/c/3619/5/cmake_modules/FindDoxygen.cmake File cmake_modules/FindDoxygen.cmake: FindDoxygen.cmake is already in the cmake we distribute as part of thirdparty. Why duplicate it here? http://gerrit.cloudera.org:8080/#/c/3619/5/docs/.gitignore File docs/.gitignore: Line 19: /doxygen/ This file should no longer be necessary; we shouldn't be putting any doc output in the source directory. It all goes into the build directory. http://gerrit.cloudera.org:8080/#/c/3619/5/docs/support/doxygen/client.doxy File docs/support/doxygen/client.doxy: Line 21: # Doxyfile 1.8.10 What's the significance of the version? If there is some significance, perhaps explain in a comment? Otherwise, remove this comment? Line 26: These are all the parameters with non-default values, right? Could you add a comment to each justifying the non-default value choice? Line 29: INPUT = ../src/kudu/client/client.h The client API surface is more than just this one file. It made sense to start with client.h to prove the concept, but having done that, I think we should roll this out for the entire public-facing client API. The file set is defined in src/kudu/client/CMakeLists.txt, in the 'install' target. Ideally we wouldn't have to duplicate the list of files here; I was thinking the doxygen target could run 'make install' to some temporary directory, then invoke doxygen recursively on all of the headers within. http://gerrit.cloudera.org:8080/#/c/3619/5/src/kudu/client/client.h File src/kudu/client/client.h: Line 124: /// Signal number to use for internal Gerrit has flagged the trailing whitespace here, and below in the file. Could you trim? -- To view, visit http://gerrit.cloudera.org:8080/3619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] WIP: Add garbage collection to ResultTracker
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: WIP: Add garbage collection to ResultTracker .. WIP: Add garbage collection to ResultTracker This still needs testing and hooking up to the mm. Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 --- M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc-stress-test.cc M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/service_if.cc 5 files changed, 155 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/3628/2 -- To view, visit http://gerrit.cloudera.org:8080/3628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP: Add garbage collection to ResultTracker
Kudu Jenkins has posted comments on this change. Change subject: WIP: Add garbage collection to ResultTracker .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2352/ -- To view, visit http://gerrit.cloudera.org:8080/3628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP: Memory tracking for result tracker
Kudu Jenkins has posted comments on this change. Change subject: WIP: Memory tracking for result tracker .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2353/ -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP: Memory tracking for result tracker
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#2). Change subject: WIP: Memory tracking for result tracker .. WIP: Memory tracking for result tracker Missing directed test Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 --- M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc-test-base.h M src/kudu/server/server_base.cc 4 files changed, 54 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/3627/2 -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md
David Ribeiro Alves has posted comments on this change. Change subject: Add information about Exactly Once RPC semantics to rpc.md .. Patch Set 6: Verified+1 unrelated failure. -- To view, visit http://gerrit.cloudera.org:8080/3503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] client.h: doxygen comments for C++ API
Anonymous Coward #206 has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 5: (1 comment) Hi Alexey, This is not a review, only testing my review subscription via this. Also pointing a typo I noticed in client.h. ~Dinesh. http://gerrit.cloudera.org:8080/#/c/3619/5/src/kudu/client/client.h File src/kudu/client/client.h: PS5, Line 197: is "returned." is omitted here. -- To view, visit http://gerrit.cloudera.org:8080/3619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Anonymous Coward #206 Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] Integrate the result tracker with writes
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 22: seems like I missed enabling exactly once for remote bootstrap tests. -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 22 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3506 to look at the new patch set (#12). Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Disable exactly once semantics by default and add a flag to enable it for tests Since exactly once semantics is still missing some pieces, like garbage collection this disables it by default on the server, but adds a flag to allow enabling it and enables it in all tablet server tests, by default. Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 --- M src/kudu/integration-tests/remote_bootstrap-itest.cc M src/kudu/integration-tests/ts_itest-base.h M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/service_if.cc M src/kudu/tserver/tablet_server-test-base.h 5 files changed, 22 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/3506/12 -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] WIP: Memory tracking for result tracker
Kudu Jenkins has posted comments on this change. Change subject: WIP: Memory tracking for result tracker .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2359/ -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Integrate the request tracker with the client
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 23: Build Started http://104.196.14.100/job/kudu-gerrit/2354/ -- To view, visit http://gerrit.cloudera.org:8080/3080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee Gerrit-PatchSet: 23 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 23: Build Started http://104.196.14.100/job/kudu-gerrit/2358/ -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 23 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
Kudu Jenkins has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/2357/ -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add integration tests for replay cache with writes
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 27: Build Started http://104.196.14.100/job/kudu-gerrit/2363/ -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 27 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a way to dump ResultTracker state
Kudu Jenkins has posted comments on this change. Change subject: Add a way to dump ResultTracker state .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2360/ -- To view, visit http://gerrit.cloudera.org:8080/3569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a way to include request ids in log-dump
Kudu Jenkins has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2355/ -- To view, visit http://gerrit.cloudera.org:8080/3612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88d7c65887a98544ee83b5b4bc0817bea7222131 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md
Kudu Jenkins has posted comments on this change. Change subject: Add information about Exactly Once RPC semantics to rpc.md .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2361/ -- To view, visit http://gerrit.cloudera.org:8080/3503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the ResultTracker into the rpc subsystem
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#24). Change subject: Integrate the ResultTracker into the rpc subsystem .. Integrate the ResultTracker into the rpc subsystem This integrates the ResultTracker into the rpc subsystem by allowing to specify a new method option when defining rpc service methods. When this method option is specified _and_ the call's rpc header has a RequestIdPB the results for the call will be tracked and the call may have exactly once semantics. This allows to have the simplest form of exactly once semantics for single server calls. Of course limitations apply, like response persistence across restarts is not supported, neither is propagating/rebuilding responses to/on replicas for replicated calls. If support for this is needed it will have to be done ad-hoc, case by case. This adds a tests that has multiple threads trying to execute the same rpc, and makes sure each one was executed exactly once. Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 --- M src/kudu/master/master.cc M src/kudu/master/master_service.cc M src/kudu/rpc/CMakeLists.txt M src/kudu/rpc/inbound_call.cc M src/kudu/rpc/protoc-gen-krpc.cc A src/kudu/rpc/rpc-stress-test.cc M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc_context.cc M src/kudu/rpc/rpc_context.h M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/rtest.proto M src/kudu/rpc/service_if.cc M src/kudu/rpc/service_if.h M src/kudu/server/generic_service.cc M src/kudu/server/server_base.cc M src/kudu/server/server_base.h M src/kudu/tserver/remote_bootstrap_service.cc M src/kudu/tserver/remote_bootstrap_service.h M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h 21 files changed, 390 insertions(+), 60 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/3192/24 -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 Gerrit-PatchSet: 24 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] WIP: Add garbage collection to ResultTracker
Kudu Jenkins has posted comments on this change. Change subject: WIP: Add garbage collection to ResultTracker .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2356/ -- To view, visit http://gerrit.cloudera.org:8080/3628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Integrate the ResultTracker into the rpc subsystem
Kudu Jenkins has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 24: Build Started http://104.196.14.100/job/kudu-gerrit/2362/ -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 Gerrit-PatchSet: 24 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the request tracker with the client
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 24: Build Started http://104.196.14.100/job/kudu-gerrit/2364/ -- To view, visit http://gerrit.cloudera.org:8080/3080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee Gerrit-PatchSet: 24 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the request tracker with the client
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3080 to look at the new patch set (#24). Change subject: Integrate the request tracker with the client .. Integrate the request tracker with the client This integrates the request tracker with the client, making sure that write requests sent by the client are tracked in the RequestTracker and contain the information necessary for exactly once semantics. This adds to rpc-stress-test a test that uses RetriableRpc, instead of using the proxy directly. Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee --- M src/kudu/client/batcher.cc M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client.cc M src/kudu/rpc/retriable_rpc.h M src/kudu/rpc/rpc-stress-test.cc M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc_controller.cc M src/kudu/rpc/rpc_controller.h M src/kudu/rpc/rtest.proto 10 files changed, 243 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/3080/24 -- To view, visit http://gerrit.cloudera.org:8080/3080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee Gerrit-PatchSet: 24 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add integration tests for replay cache with writes
David Ribeiro Alves has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 27: Verified+1 unrelated flakyness, addressed that in another patch -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 27 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 23: Verified+1 unrelated flakyness, addressed that on a previous patch -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 23 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] rw mutex: add configurable priority
Todd Lipcon has posted comments on this change. Change subject: rw_mutex: add configurable priority .. Patch Set 3: I have experienced in the past an issue where the fairness policy causes a deadlock. See https://issues.apache.org/jira/browse/HDFS-2223?focusedCommentId=13097647&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13097647 for example. I think the issue only happens when you recursively acquire the read lock, or if you are holding the read lock while waiting on another thread which needs to acquire the read lock. I'm not sure if we have cases of either, but we should probably document this danger. -- To view, visit http://gerrit.cloudera.org:8080/3603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16ba6cd041f126c94e63fa07a1e84c88db6778d7 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: add read-write lock to serialize operations around elections
Todd Lipcon has posted comments on this change. Change subject: master: add read-write lock to serialize operations around elections .. Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3550/6//COMMIT_MSG Commit Message: Line 30: RPCs won't fill up its service queue and can still process heartbeats. ah yes, we had basically this problem with the original HDFS HA implementation! -- To view, visit http://gerrit.cloudera.org:8080/3550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5084c09f1a77ccf620fb6cd621094c4778d636f8 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Make site tool.py support Python 2.6 and Centos 6
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3629 to review the following change. Change subject: Make site_tool.py support Python 2.6 and Centos 6 .. Make site_tool.py support Python 2.6 and Centos 6 This pulls in kudu_util.py from the Kudu master branch to get the check_output() function. Additional notes have been added to README.adoc indicating how to run site_tool on Centos 6. Change-Id: I971045e24000b5824a378909a4b28b2e9ac2a45a --- M .gitignore M README.adoc A _tools/kudu_util.py M site_tool 4 files changed, 105 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/3629/1 -- To view, visit http://gerrit.cloudera.org:8080/3629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I971045e24000b5824a378909a4b28b2e9ac2a45a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
Kudu Jenkins has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 12: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2365/ -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Make site tool.py support Python 2.6 and Centos 6
Mike Percy has uploaded a new patch set (#2). Change subject: Make site_tool.py support Python 2.6 and Centos 6 .. Make site_tool.py support Python 2.6 and Centos 6 This pulls in kudu_util.py from the Kudu master branch to get the check_output() function. Additional notes have been added to README.adoc indicating how to run site_tool on Centos 6. Change-Id: I971045e24000b5824a378909a4b28b2e9ac2a45a --- M .gitignore M README.adoc A _tools/kudu_util.py M site_tool 4 files changed, 102 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/3629/2 -- To view, visit http://gerrit.cloudera.org:8080/3629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I971045e24000b5824a378909a4b28b2e9ac2a45a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR] Integrate the request tracker with the client
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 24: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2366/ -- To view, visit http://gerrit.cloudera.org:8080/3080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee Gerrit-PatchSet: 24 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a ResultTracker class that will track server side results
Todd Lipcon has submitted this change and it was merged. Change subject: Add a ResultTracker class that will track server side results .. Add a ResultTracker class that will track server side results This adds the initial version of the ResultTracker class that will be responsible for tracking responses when we want exactly once call semantics. While this is minimally working, i.e it's able to track responses and can be used for exactly once semantics, it's not complete. Future patches will address the missing functionality. Still missing are: - Time based client state cleaning. - Watermark based per client state cleaning. I initially had a unit test for this class, but it relied on templating out the RpcContext (since it's not easy to build one for a unit test and it's not clear what it would do) which became problematic as the class grew. So I decided to add a new rpc-stress-tess that will test this class within the rpc framework. I feel it's easier to do it that way and that, since the client is not being used, the test can still be very straight forward. This test is in a followup patch as it can only run after the integration with the rest of the rpc subsystem. Change-Id: I6718951a9998a6c9b0db35e8f09ff8304591e8b1 Reviewed-on: http://gerrit.cloudera.org:8080/3190 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M src/kudu/rpc/CMakeLists.txt A src/kudu/rpc/result_tracker.cc A src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc_context.h 4 files changed, 599 insertions(+), 0 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6718951a9998a6c9b0db35e8f09ff8304591e8b1 Gerrit-PatchSet: 27 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add a ResultTracker class that will track server side results
Todd Lipcon has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 26: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3190/26/src/kudu/rpc/result_tracker.cc File src/kudu/rpc/result_tracker.cc: Line 244: // CompletionRecords. OK, I still think this iteration order thing is fragile, but I've made a note to come back to it. http://gerrit.cloudera.org:8080/#/c/3190/26/src/kudu/rpc/result_tracker.h File src/kudu/rpc/result_tracker.h: Line 131: // result_tracker_->TrackRpcOrChangeDriver(request_id); woohoo, I like this much better. thanks for taking the time to re-work it -- To view, visit http://gerrit.cloudera.org:8080/3190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6718951a9998a6c9b0db35e8f09ff8304591e8b1 Gerrit-PatchSet: 26 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Add a ToString() method to Proxy
Todd Lipcon has submitted this change and it was merged. Change subject: Add a ToString() method to Proxy .. Add a ToString() method to Proxy ReplicatedRpc takes the server proxy type as a template argument and uses its ToString() method to print out details in case of error. Usually this is RemoteTablet, which has a ToString() method, but that might not always be the case. In fact, in a test in a follow up patch ReplicatedRpc takes Proxy as the server proxy type and compilation would fail due to a missing ToString(). We could make ReplicatedRpc not use the ToString() method, but it seems very helpful to have it so this patch adds it to Proxy instead. Change-Id: Ia1e158db09e6e3c188b2725424681187a4b8c72e Reviewed-on: http://gerrit.cloudera.org:8080/3502 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M src/kudu/rpc/proxy.cc M src/kudu/rpc/proxy.h M src/kudu/rpc/rpc-test.cc 3 files changed, 12 insertions(+), 0 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1e158db09e6e3c188b2725424681187a4b8c72e Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add a ToString() method to Proxy
Todd Lipcon has posted comments on this change. Change subject: Add a ToString() method to Proxy .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1e158db09e6e3c188b2725424681187a4b8c72e Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
David Ribeiro Alves has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 12: Verified+1 two different unrelated flakes one on the java side one on an unrelated test -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a RpcContext::RespondFailure() method
Todd Lipcon has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/3191/15/src/kudu/rpc/rpc_context.h File src/kudu/rpc/rpc_context.h: Line 91: void RespondFailure(); > the problem is that results are not always being cached and for most RPCs t On the other hand, the issue now is that a service implementor can call 'RespondFailure()' but the caller on the other side gets no indication that the response was not successful. If we want to use this consistently for any "failures indicated by an error field in the response' then we'd have a much bigger job to go through all RPCs to do the replacement. Right now we're only using this new method for writes, so in my mind it makes sense to explicitly say 'NoCache' because the implementor of writes is being careful to understand caching behavior. Also, we have TODOs elsewhere to rename 'RespondSuccess' to just 'Respond', in which case 'RespondNoCache' fits well (it's the same as respond, minus the caching of it) -- To view, visit http://gerrit.cloudera.org:8080/3191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f1387ba0f837046a8056e77f73a3982f06c73a2 Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md
Todd Lipcon has submitted this change and it was merged. Change subject: Add information about Exactly Once RPC semantics to rpc.md .. Add information about Exactly Once RPC semantics to rpc.md This patch adds some info about exactly one rpc semantics to rpc.md, mostly from a usage perspective. Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e Reviewed-on: http://gerrit.cloudera.org:8080/3503 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M docs/design-docs/rpc.md 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md
Todd Lipcon has posted comments on this change. Change subject: Add information about Exactly Once RPC semantics to rpc.md .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a RpcContext::RespondFailure() method
David Ribeiro Alves has abandoned this change. Change subject: Add a RpcContext::RespondFailure() method .. Abandoned ok, abandoning this and opting for a RespondNoCache method. Will add it in the first patch where it's used. -- To view, visit http://gerrit.cloudera.org:8080/3191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I9f1387ba0f837046a8056e77f73a3982f06c73a2 Gerrit-PatchSet: 21 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add a fault injection point after the leader sends a request
David Ribeiro Alves has abandoned this change. Change subject: Add a fault injection point _after_ the leader sends a request .. Abandoned squashed this a couple of days ago -- To view, visit http://gerrit.cloudera.org:8080/3568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I504d74ac3ab3a8cb120d4e5ecee308d9846f3829 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()
Kudu Jenkins has posted comments on this change. Change subject: Make RequestTracker not return Status on FirstIncomplete() .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2368/ -- To view, visit http://gerrit.cloudera.org:8080/3504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 24: Build Started http://104.196.14.100/job/kudu-gerrit/2371/ -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 24 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
David Ribeiro Alves has uploaded a new patch set (#24). Change subject: Integrate the result tracker with writes .. Integrate the result tracker with writes This patch integrates the result tracker with write transactions, including: - Support for caching responses on tablet bootstrap. - Support for caching responses for follower transactions. - Handling of races between client originated and (previous?) leader originated transactions. - An explanation of the interaction between the result tracker and the transaction driver in transaction_driver.h. For integration tests, this patch removes the check that allowed Status::AlreadyPresent() that we added as we didn't have support for exactly once semantics. Without this check, in slow mode, some tests like raft_consensus-itest would fail 100% of the time, due to rows being inserted multiple times. Because we'd have 100% failure rate without replay cache for writes and because testing it specifically is involved, this patch doesn't include additional tests, these will be pushed as a follow up. Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 --- M src/kudu/client/batcher.cc M src/kudu/consensus/consensus.proto M src/kudu/integration-tests/test_workload.cc M src/kudu/integration-tests/test_workload.h M src/kudu/master/sys_catalog.cc M src/kudu/rpc/rpc_context.cc M src/kudu/rpc/rpc_context.h M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer-test.cc M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tools/insert-generated-rows.cc M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/remote_bootstrap_session-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/tserver/tserver_service.proto 25 files changed, 397 insertions(+), 40 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/3449/24 -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 24 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Integrate the ResultTracker into the rpc subsystem
Kudu Jenkins has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 25: Build Started http://104.196.14.100/job/kudu-gerrit/2374/ -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 Gerrit-PatchSet: 25 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
Kudu Jenkins has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 13: Build Started http://104.196.14.100/job/kudu-gerrit/2370/ -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] WIP: Memory tracking for result tracker
Kudu Jenkins has posted comments on this change. Change subject: WIP: Memory tracking for result tracker .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2372/ -- To view, visit http://gerrit.cloudera.org:8080/3627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b81dda41c8bc7f70380ce426142c34afe6f1625 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Add a way to dump ResultTracker state
Kudu Jenkins has posted comments on this change. Change subject: Add a way to dump ResultTracker state .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2373/ -- To view, visit http://gerrit.cloudera.org:8080/3569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the ResultTracker into the rpc subsystem
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#25). Change subject: Integrate the ResultTracker into the rpc subsystem .. Integrate the ResultTracker into the rpc subsystem This integrates the ResultTracker into the rpc subsystem by allowing to specify a new method option when defining rpc service methods. When this method option is specified _and_ the call's rpc header has a RequestIdPB the results for the call will be tracked and the call may have exactly once semantics. This allows to have the simplest form of exactly once semantics for single server calls. Of course limitations apply, like response persistence across restarts is not supported, neither is propagating/rebuilding responses to/on replicas for replicated calls. If support for this is needed it will have to be done ad-hoc, case by case. This adds a tests that has multiple threads trying to execute the same rpc, and makes sure each one was executed exactly once. Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 --- M src/kudu/master/master.cc M src/kudu/master/master_service.cc M src/kudu/rpc/CMakeLists.txt M src/kudu/rpc/inbound_call.cc M src/kudu/rpc/protoc-gen-krpc.cc A src/kudu/rpc/rpc-stress-test.cc M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc_context.cc M src/kudu/rpc/rpc_context.h M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/rtest.proto M src/kudu/rpc/service_if.cc M src/kudu/rpc/service_if.h M src/kudu/server/generic_service.cc M src/kudu/server/server_base.cc M src/kudu/server/server_base.h M src/kudu/tserver/remote_bootstrap_service.cc M src/kudu/tserver/remote_bootstrap_service.h M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h 21 files changed, 376 insertions(+), 53 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/3192/25 -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 Gerrit-PatchSet: 25 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Integrate the request tracker with the client
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 25: Build Started http://104.196.14.100/job/kudu-gerrit/2367/ -- To view, visit http://gerrit.cloudera.org:8080/3080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee Gerrit-PatchSet: 25 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add integration tests for replay cache with writes
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 28: Build Started http://104.196.14.100/job/kudu-gerrit/2375/ -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 28 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a way to include request ids in log-dump
Kudu Jenkins has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2369/ -- To view, visit http://gerrit.cloudera.org:8080/3612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88d7c65887a98544ee83b5b4bc0817bea7222131 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Add a way to include request ids in log-dump
David Ribeiro Alves has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 4: Code-Review+2 just rebases, keeping todd's earlier +2 -- To view, visit http://gerrit.cloudera.org:8080/3612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88d7c65887a98544ee83b5b4bc0817bea7222131 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Integrate the ResultTracker into the rpc subsystem
Todd Lipcon has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 24: (7 comments) http://gerrit.cloudera.org:8080/#/c/3192/24/src/kudu/rpc/protoc-gen-krpc.cc File src/kudu/rpc/protoc-gen-krpc.cc: Line 456: "result_tracker_ = result_tracker;" this can use an initializer list, right? http://gerrit.cloudera.org:8080/#/c/3192/24/src/kudu/rpc/rpc-stress-test.cc File src/kudu/rpc/rpc-stress-test.cc: PS24, Line 59: We don't use CalculatorServiceRpc not sure what class this is referring to. I guess this is coming in a later patch? Line 68: atomic_int* attempt_nos) { not following why this is atomic. you're fetch_add()ing to it from the main thread in the constructor, and then it's not accessed from the started threads. Why not just take an int attempt_num here? Line 70: client_sleep_for_ms = client_sleep; above two lines can be from an initializer list PS24, Line 83: a the typo Line 91: uint64_t client_sleep_for_ms; make these above two const Line 100: string client_id_; this is just a constant, right? can you just make it a const char* kClientId? -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 Gerrit-PatchSet: 24 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()
Todd Lipcon has posted comments on this change. Change subject: Make RequestTracker not return Status on FirstIncomplete() .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()
David Ribeiro Alves has submitted this change and it was merged. Change subject: Make RequestTracker not return Status on FirstIncomplete() .. Make RequestTracker not return Status on FirstIncomplete() This addresses Todd's post-commit comment on the fact that RequestTracker::FirstIncomplete() shouldn't return a Status and should return NO_SEQ_NO instead. Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e Reviewed-on: http://gerrit.cloudera.org:8080/3504 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M src/kudu/rpc/request_tracker-test.cc M src/kudu/rpc/request_tracker.cc M src/kudu/rpc/request_tracker.h 3 files changed, 16 insertions(+), 20 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Integrate the request tracker with the client
Todd Lipcon has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 25: (3 comments) http://gerrit.cloudera.org:8080/#/c/3080/25/src/kudu/rpc/rpc-stress-test.cc File src/kudu/rpc/rpc-stress-test.cc: PS25, Line 278: attempted multiple times i think worth saying that it's attempted multiple times because the server side is instructed to spuriously fail attempts, right? PS25, Line 283: nu nit: capital 'n' http://gerrit.cloudera.org:8080/#/c/3080/25/src/kudu/rpc/rtest.proto File src/kudu/rpc/rtest.proto: Line 113: optional bool may_fail = 3 [default = false]; nit: I think a better name would be 'randomly_fail' or 'inject_failures' -- To view, visit http://gerrit.cloudera.org:8080/3080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee Gerrit-PatchSet: 25 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes