Re: Review Request 47711: Added more verbose message when mesos command encouter error.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47711/#review135158
---


Ship it!




Ship It!

- Vinod Kone


On May 27, 2016, 5:50 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47711/
> ---
> 
> (Updated May 27, 2016, 5:50 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5438
> https://issues.apache.org/jira/browse/MESOS-5438
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added more verbose message when mesos command encouter error.
> This is mainly for adding exception info to error log
> when using to mesos-xx get state info.
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-cat ddc5a26d0a4618e9e032b4fcc75a230e49b7a2c5 
>   src/cli/mesos-ps 40dfbec5bab71d0b3c38d05ecd56a19bbcbda535 
>   src/cli/mesos-scp f305abdc3bc0e4f357a5df90764a39ab55f46e86 
>   src/cli/mesos-tail 031ee251fde3b230c14d9ee0f0de68caa04d6595 
> 
> Diff: https://reviews.apache.org/r/47711/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47935: Added test for provisioner to handle whiteout files.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47935/#review135157
---


Ship it!




Ship It!

- Jie Yu


On May 27, 2016, 12:56 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47935/
> ---
> 
> (Updated May 27, 2016, 12:56 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-5277
> https://issues.apache.org/jira/browse/MESOS-5277
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for provisioner to handle whiteout files.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47935/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo /bin/mesos-test.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 47805: Add authorization to GET /weights.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47805/
---

(Updated 五月 27, 2016, 5:45 a.m.)


Review request for mesos and Adam B.


Changes
---

update code per Adam's comments


Bugs: mesos-5335
https://issues.apache.org/jira/browse/mesos-5335


Repository: mesos


Description
---

Add 'GET_WEIGHTS_WITH_ROLE' for the authorization of GET /weights.


Diffs (updated)
-

  docs/endpoints/master/weights.md 1e540795c5fb90c8ea957dd444b9e564e0b1ac23 
  include/mesos/authorizer/acls.proto ace9b698f46e143795c82324a87a0d7827fb 
  include/mesos/authorizer/authorizer.proto 
02d1a01d57cf34b38524f4368187878b03343537 
  src/authorizer/local/authorizer.cpp 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029 
  src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
  src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
  src/master/weights_handler.cpp 4bc060fdb015df6658194eef92fe11b14aa15c79 
  src/tests/dynamic_weights_tests.cpp 362c59aae7b305710d5985bfec28f881be3b64b8 

Diff: https://reviews.apache.org/r/47805/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 47805: Add authorization to GET /weights.

[zhou xing]

> On 五月 26, 2016, 10:30 a.m., Adam B wrote:
> > src/master/weights_handler.cpp, line 85
> > 
> >
> > s/=/request, weightInfos/
> > s/list/list&/

Adam, this function also requires to capture 'this', which will be used in the 
invocation of '_get()', can we keep using '=' here?


> On 五月 26, 2016, 10:30 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, lines 492-494
> > 
> >
> > Seems like `checkWithGetRequest` should take the credential as a 
> > parameter, rather than hiding that credential-selection logic inside the 
> > check method.

as in checkWithGetRequest, we are using the constant strings to identify the 
result of get weights, so for 'get weights' specific test cases, I suggest keep 
these two new constant strings. I will add a new credential parameter to 
checkWithGetRequest method and remove the credential-selection logic in it.


> On 五月 26, 2016, 10:30 a.m., Adam B wrote:
> > src/tests/dynamic_weights_tests.cpp, line 512
> > 
> >
> > Since this test already uses a principal, why not only allow that 
> > principal to get the weights?
> > Then you can also test that a get request without a principal (or with 
> > CREDENTIAL_2) will see no roles.

Adam, yes, I will only allow DEFAULT_CREDENTIAL in these test cases, but for 
the get check, as I already added a new test case to test "get weights with 
role" only, I suggest not to add a new get request test in this test case. Or 
we can merge the get weights test and update weights test together into one, 
please let me know your comments, thanks.


- zhou


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47805/#review134954
---


On 五月 27, 2016, 5:45 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47805/
> ---
> 
> (Updated 五月 27, 2016, 5:45 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: mesos-5335
> https://issues.apache.org/jira/browse/mesos-5335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add 'GET_WEIGHTS_WITH_ROLE' for the authorization of GET /weights.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/weights.md 1e540795c5fb90c8ea957dd444b9e564e0b1ac23 
>   include/mesos/authorizer/acls.proto 
> ace9b698f46e143795c82324a87a0d7827fb 
>   include/mesos/authorizer/authorizer.proto 
> 02d1a01d57cf34b38524f4368187878b03343537 
>   src/authorizer/local/authorizer.cpp 
> 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029 
>   src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
>   src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
>   src/master/weights_handler.cpp 4bc060fdb015df6658194eef92fe11b14aa15c79 
>   src/tests/dynamic_weights_tests.cpp 
> 362c59aae7b305710d5985bfec28f881be3b64b8 
> 
> Diff: https://reviews.apache.org/r/47805/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 47940: Consistent name for UpdateWeights ACL message name.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47940/
---

(Updated May 27, 2016, 5:45 a.m.)


Review request for mesos and Adam B.


Changes
---

Rebased


Repository: mesos


Description
---

We use singular for the message where applicable.
Note that `UpdateWeights` is not yet included in any release
and hence does not require a deprecation cycle.


Diffs (updated)
-

  include/mesos/authorizer/acls.proto ace9b698f46e143795c82324a87a0d7827fb 
  src/authorizer/local/authorizer.cpp 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029 
  src/tests/dynamic_weights_tests.cpp 362c59aae7b305710d5985bfec28f881be3b64b8 

Diff: https://reviews.apache.org/r/47940/diff/


Testing
---

make check (OSX)


Thanks,

Joerg Schad

Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47469/
---

(Updated May 27, 2016, 5:42 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3624
https://issues.apache.org/jira/browse/MESOS-3624


Repository: mesos


Description
---

Agent: Added `launch.cpp` to Windows build.


Diffs (updated)
-

  src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
  src/slave/containerizer/mesos/launch.cpp 
e22106b014c871e2184a15c2ab154a0674874e47 

Diff: https://reviews.apache.org/r/47469/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47943/
---

(Updated May 27, 2016, 5:39 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout: Implemented `shell.hpp` on Windows.


Diffs
-

  3rdparty/stout/include/stout/os/windows/shell.hpp 
ea6ae5ab981f422993085e63543d184a8e41524d 

Diff: https://reviews.apache.org/r/47943/diff/


Testing (updated)
---

Windows: buil/run


Thanks,

Alex Clemmer

Review Request 47943: Stout: Implemented `shell.hpp` on Windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47943/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Stout: Implemented `shell.hpp` on Windows.


Diffs
-

  3rdparty/stout/include/stout/os/windows/shell.hpp 
ea6ae5ab981f422993085e63543d184a8e41524d 

Diff: https://reviews.apache.org/r/47943/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47603: Agent:[2/2] Added Windows support for folder `launcher/`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47603/
---

(Updated May 27, 2016, 5:38 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Agent:[2/2] Added Windows support for folder `launcher/`.


Diffs (updated)
-

  src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/launcher/executor.hpp PRE-CREATION 
  src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
  src/launcher/posix/executor.hpp PRE-CREATION 
  src/launcher/windows/executor.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/47603/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/
---

(Updated May 27, 2016, 5:37 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
MESOS-3681, MESOS-3682, and MESOS-3684
https://issues.apache.org/jira/browse/MESOS-3617
https://issues.apache.org/jira/browse/MESOS-3618
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3622
https://issues.apache.org/jira/browse/MESOS-3623
https://issues.apache.org/jira/browse/MESOS-3624
https://issues.apache.org/jira/browse/MESOS-3681
https://issues.apache.org/jira/browse/MESOS-3682
https://issues.apache.org/jira/browse/MESOS-3684


Repository: mesos


Description
---

Agent: Add Windows support to the containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/mesos/containerizer.cpp 
75e5a32a3e70ec60a6800e21a621673184ea0956 
  src/slave/containerizer/mesos/launcher.hpp 
5977c30c0aacc569019f7b34bb0c6577823ec887 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 

Diff: https://reviews.apache.org/r/47576/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47521: Added creator principal to '/create-volumes' tests.

[Greg Mann]

> On May 26, 2016, 9:40 p.m., Greg Mann wrote:
> > src/tests/persistent_volume_endpoints_tests.cpp, line 1597
> > 
> >
> > perhaps use a variable for the principal in a subsequent patch?

Added a TODO for this.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47521/#review135079
---


On May 27, 2016, 5:37 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47521/
> ---
> 
> (Updated May 27, 2016, 5:37 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A creator principal is added to the persistent volumes
> used in the PersistentVolumeEndpointsTests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> a57461d881b2bf0175f83b50b0a46167acd5bd3e 
> 
> Diff: https://reviews.apache.org/r/47521/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47521: Added creator principal to '/create-volumes' tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47521/
---

(Updated May 27, 2016, 5:37 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.


Changes
---

Addressed comments.


Bugs: MESOS-5005
https://issues.apache.org/jira/browse/MESOS-5005


Repository: mesos


Description
---

A creator principal is added to the persistent volumes
used in the PersistentVolumeEndpointsTests.


Diffs (updated)
-

  src/tests/persistent_volume_endpoints_tests.cpp 
a57461d881b2bf0175f83b50b0a46167acd5bd3e 

Diff: https://reviews.apache.org/r/47521/diff/


Testing
---

`make check` was used to test on OSX.


Thanks,

Greg Mann

Re: Review Request 47940: Consistent name for UpdateWeights ACL message name.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47940/#review135152
---



Bad patch!

Reviews applied: [47940]

Failed command: ./support/apply-review.sh -n -r 47940

Error:
2016-05-27 05:03:03 URL:https://reviews.apache.org/r/47940/diff/raw/ 
[2832/2832] -> "47940.patch" [1]
error: patch failed: include/mesos/authorizer/acls.proto:221
error: include/mesos/authorizer/acls.proto: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13360/console

- Mesos ReviewBot


On May 27, 2016, 2:44 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47940/
> ---
> 
> (Updated May 27, 2016, 2:44 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We use singular for the message where applicable.
> Note that `UpdateWeights` is not yet included in any release
> and hence does not require a deprecation cycle.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> b178f53a299a2941afc073af963f6aff26af1ca8 
>   src/authorizer/local/authorizer.cpp 
> dc53bc4374aea98b5ed41ade5617374d2447229b 
>   src/tests/dynamic_weights_tests.cpp 
> 362c59aae7b305710d5985bfec28f881be3b64b8 
> 
> Diff: https://reviews.apache.org/r/47940/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47520: Updated test helpers with creator principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47520/
---

(Updated May 27, 2016, 4:58 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.


Changes
---

Addressed comment.


Bugs: MESOS-5005
https://issues.apache.org/jira/browse/MESOS-5005


Repository: mesos


Description
---

This patch updates the `createPersistentVolume` and
`createDiskInfo` test helper functions to accept an
argument specifying the creator principal to be included
in `DiskInfo.Persistence`.


Diffs (updated)
-

  src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 

Diff: https://reviews.apache.org/r/47520/diff/


Testing
---

`make check` was done on OSX at the end of this review chain.


Thanks,

Greg Mann

Re: Review Request 47711: Added more verbose message when mesos command encouter error.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47711/#review135151
---




src/cli/mesos-cat (line 120)


why did you pull this into a 'exception' variable? why not just do 
`fatal(Failed to get the master: %s' % str(e))` ?

here and everywhere else


- Vinod Kone


On May 23, 2016, 5:34 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47711/
> ---
> 
> (Updated May 23, 2016, 5:34 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5438
> https://issues.apache.org/jira/browse/MESOS-5438
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added more verbose message when mesos command encouter error.
> This is mainly for adding exception info to error log
> when using to mesos-xx get state info.
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-cat ddc5a26d0a4618e9e032b4fcc75a230e49b7a2c5 
>   src/cli/mesos-scp f305abdc3bc0e4f357a5df90764a39ab55f46e86 
>   src/cli/mesos-tail 031ee251fde3b230c14d9ee0f0de68caa04d6595 
> 
> Diff: https://reviews.apache.org/r/47711/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47907: Slave/Agent rename in diagrams.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47907/#review135150
---



Can you discard this review and send it through github instead? It's tricky to 
upload binary files to review board.

- Vinod Kone


On May 26, 2016, 5:11 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47907/
> ---
> 
> (Updated May 26, 2016, 5:11 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5407
> https://issues.apache.org/jira/browse/MESOS-5407
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Diagrams under docs/images are renamed.
> 
> 
> Diffs
> -
> 
>   docs/images/architecture-example.jpg 
> e93e027af679c7e422b9d5c768648d4b2e8db2fb 
>   docs/images/architecture3.jpg e962af6c906362fd24c6dd77b0c464a03ecc5763 
>   docs/images/containerizer_isolator_api.png 
> 0e15b91544e7379d0e343bebff2947c85bac74f9 
>   docs/images/ec_orphan_seqdiag.png 670f872e3e17bc899a0a5c99bd6b5fde80813f4d 
>   docs/images/ec_recover_seqdiag.png 18dabcc143b36cf46210103817a759758d31d4dd 
>   docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725 
>   docs/images/networking-architecture.png 
> 58838cfddd78fcb9bcbe9548fe9c386f2b7d4847 
>   docs/images/oversubscription-overview.jpg 
> 2d3109777d09c9053b27f8f77e32d7e3eb56496c 
> 
> Diff: https://reviews.apache.org/r/47907/diff/
> 
> 
> Testing
> ---
> 
> View images under docs/images to see the changes
> 
> 
> File Attachments
> 
> 
> ec_recover_seqdiag.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/f69a32cc-7034-4170-816c-48020ee282dc__ec_recover_seqdiag.png
> ec_orphan_seqdiag.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/cd2479ef-1b4e-46e3-8c6a-ed46b9f6d008__ec_orphan_seqdiag.png
> networking-architecture.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/6a467aed-a846-42aa-8cfa-032d37c9c8bf__networking-architecture.png
> architecture-example.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/32d6763a-0857-4b43-9e84-3f63f5c53f51__architecture-example.jpg
> oversubscription-overview.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/63054974-f1ef-4047-8ea0-d5bcf4b9b8af__oversubscription-overview.jpg
> containerizer_isolator_api.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/3e4dc321-2ae3-4cea-9783-b046ea330634__containerizer_isolator_api.png
> fetch_components.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/888429b7-9859-456a-aca2-06206644a765__fetch_components.jpg
> architecture3.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/2b20335b-53fe-40a1-93ac-70efa7a20266__architecture3.jpg
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Review Request 47942: Windows: Added pipe support functions.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47942/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: Added pipe support functions.


Diffs
-

  src/slave/containerizer/mesos/pipe.hpp PRE-CREATION 
  src/slave/containerizer/mesos/posix_pipe.hpp PRE-CREATION 
  src/slave/containerizer/mesos/windows_pipe.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/47942/diff/


Testing
---

OSX: make check
Windows: build/run


Thanks,

Alex Clemmer

Re: Review Request 47528: Updated validation tests with creator principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47528/
---

(Updated May 27, 2016, 4:50 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.


Changes
---

Addressed comments.


Bugs: MESOS-5005
https://issues.apache.org/jira/browse/MESOS-5005


Repository: mesos


Description
---

The master validation tests are updated to include the
new `validate()` signature, and a new test is added,
`CreateOperationValidationTest.NonMatchingPrincipal`,
to ensure that a non-matching creator principal will
be invalidated.


Diffs (updated)
-

  src/tests/master_validation_tests.cpp 
ca4442aa1ef0087a7d058d1b3aa430a1dbc16960 

Diff: https://reviews.apache.org/r/47528/diff/


Testing
---

`make check` was used to test on OSX at the end of this review chain.


Thanks,

Greg Mann

Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

[Greg Mann]

> On May 26, 2016, 9:12 p.m., Greg Mann wrote:
> > src/master/master.cpp, line 3742
> > 
> >
> > What about just `None()` here?

We actually can't use `None()` here, since the second operand of the `?` 
operator is a `std::string`. One of the second and third operands must be 
convertible into the other, so we use an `Option` here.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47515/#review135064
---


On May 27, 2016, 4:32 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47515/
> ---
> 
> (Updated May 27, 2016, 4:32 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enforces the constraint that the principal
> found in `DiskInfo.Persistence` should equal that of
> the framework or operator responsible for creating
> the volume.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
>   src/master/master.cpp 0005a29caabcc6a3776037cf86a2b12660e6377b 
>   src/master/validation.hpp f29f9753c75e5abc3402ed23381edcea26517ab3 
>   src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 
> 
> Diff: https://reviews.apache.org/r/47515/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47794: Added authorization support for mesos::internal::Files.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47794/
---

(Updated May 27, 2016, 6:32 a.m.)


Review request for mesos, Adam B, Benjamin Mahler, Joerg Schad, Michael Park, 
and Vinod Kone.


Bugs: MESOS-5153
https://issues.apache.org/jira/browse/MESOS-5153


Repository: mesos


Description
---

Adds an optional parameter to the `mesos::internal::Files::attach()`
method. The type of this parameter is a callable object which returns
a future to a boolean and takes as parameter an optional string
representing a principal name.

The parameter is called, if set, whenever one of the routed endpoints
of the `Files` object is accessed through HTTP. If the callable object
returns a false boolean, then processing of the request is aborted
and a `403 Forbidden` response is returned.


Diffs (updated)
-

  src/files/files.hpp 90acb3406c46c164108deb559af71fb109a5773b 
  src/files/files.cpp e4b0ada00aabba6553810391f4015a896f8a69a5 
  src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 

Diff: https://reviews.apache.org/r/47794/diff/


Testing
---

On OSX:
`make check`


Thanks,

Alexander Rojas

Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47515/
---

(Updated May 27, 2016, 4:32 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.


Changes
---

Addressed comments.


Bugs: MESOS-5005
https://issues.apache.org/jira/browse/MESOS-5005


Repository: mesos


Description
---

This patch enforces the constraint that the principal
found in `DiskInfo.Persistence` should equal that of
the framework or operator responsible for creating
the volume.


Diffs (updated)
-

  src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
  src/master/master.cpp 0005a29caabcc6a3776037cf86a2b12660e6377b 
  src/master/validation.hpp f29f9753c75e5abc3402ed23381edcea26517ab3 
  src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 

Diff: https://reviews.apache.org/r/47515/diff/


Testing
---

`make check` was used to test on OSX at the end of this review chain.


Thanks,

Greg Mann

Re: Review Request 47907: Slave/Agent rename in diagrams.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47907/#review135148
---



Bad patch!

Reviews applied: [47907]

Failed command: ./support/apply-review.sh -n -r 47907

Error:
2016-05-27 04:32:41 URL:https://reviews.apache.org/r/47907/diff/raw/ 
[2288/2288] -> "47907.patch" [1]
error: missing binary patch data for 'docs/images/architecture-example.jpg'
error: binary patch does not apply to 'docs/images/architecture-example.jpg'
error: docs/images/architecture-example.jpg: patch does not apply
error: missing binary patch data for 'docs/images/architecture3.jpg'
error: binary patch does not apply to 'docs/images/architecture3.jpg'
error: docs/images/architecture3.jpg: patch does not apply
error: missing binary patch data for 
'docs/images/containerizer_isolator_api.png'
error: binary patch does not apply to 
'docs/images/containerizer_isolator_api.png'
error: docs/images/containerizer_isolator_api.png: patch does not apply
error: missing binary patch data for 'docs/images/ec_orphan_seqdiag.png'
error: binary patch does not apply to 'docs/images/ec_orphan_seqdiag.png'
error: docs/images/ec_orphan_seqdiag.png: patch does not apply
error: missing binary patch data for 'docs/images/ec_recover_seqdiag.png'
error: binary patch does not apply to 'docs/images/ec_recover_seqdiag.png'
error: docs/images/ec_recover_seqdiag.png: patch does not apply
error: missing binary patch data for 'docs/images/fetch_components.jpg'
error: binary patch does not apply to 'docs/images/fetch_components.jpg'
error: docs/images/fetch_components.jpg: patch does not apply
error: missing binary patch data for 'docs/images/networking-architecture.png'
error: binary patch does not apply to 'docs/images/networking-architecture.png'
error: docs/images/networking-architecture.png: patch does not apply
error: missing binary patch data for 'docs/images/oversubscription-overview.jpg'
error: binary patch does not apply to 
'docs/images/oversubscription-overview.jpg'
error: docs/images/oversubscription-overview.jpg: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13359/console

- Mesos ReviewBot


On May 26, 2016, 5:11 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47907/
> ---
> 
> (Updated May 26, 2016, 5:11 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5407
> https://issues.apache.org/jira/browse/MESOS-5407
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Diagrams under docs/images are renamed.
> 
> 
> Diffs
> -
> 
>   docs/images/architecture-example.jpg 
> e93e027af679c7e422b9d5c768648d4b2e8db2fb 
>   docs/images/architecture3.jpg e962af6c906362fd24c6dd77b0c464a03ecc5763 
>   docs/images/containerizer_isolator_api.png 
> 0e15b91544e7379d0e343bebff2947c85bac74f9 
>   docs/images/ec_orphan_seqdiag.png 670f872e3e17bc899a0a5c99bd6b5fde80813f4d 
>   docs/images/ec_recover_seqdiag.png 18dabcc143b36cf46210103817a759758d31d4dd 
>   docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725 
>   docs/images/networking-architecture.png 
> 58838cfddd78fcb9bcbe9548fe9c386f2b7d4847 
>   docs/images/oversubscription-overview.jpg 
> 2d3109777d09c9053b27f8f77e32d7e3eb56496c 
> 
> Diff: https://reviews.apache.org/r/47907/diff/
> 
> 
> Testing
> ---
> 
> View images under docs/images to see the changes
> 
> 
> File Attachments
> 
> 
> ec_recover_seqdiag.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/f69a32cc-7034-4170-816c-48020ee282dc__ec_recover_seqdiag.png
> ec_orphan_seqdiag.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/cd2479ef-1b4e-46e3-8c6a-ed46b9f6d008__ec_orphan_seqdiag.png
> networking-architecture.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/6a467aed-a846-42aa-8cfa-032d37c9c8bf__networking-architecture.png
> architecture-example.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/32d6763a-0857-4b43-9e84-3f63f5c53f51__architecture-example.jpg
> oversubscription-overview.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/63054974-f1ef-4047-8ea0-d5bcf4b9b8af__oversubscription-overview.jpg
> containerizer_isolator_api.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/3e4dc321-2ae3-4cea-9783-b046ea330634__containerizer_isolator_api.png
> fetch_components.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/888429b7-9859-456a-aca2-06206644a765__fetch_components.jpg
> architecture3.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/2b20335b-53fe-40a1-93ac-70efa7a20266__architecture3.jpg
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 47794: Added authorization support for mesos::internal::Files.

[Alexander Rojas]

> On May 27, 2016, 3:45 a.m., Adam B wrote:
> > src/files/files.cpp, lines 305-317
> > 
> >
> > The loop body is quite simple, so I'd rather we duplicate it outside 
> > the loop instead of special-casing the dirname "accumulator" logic.
> > Wouldn't the following work just as well?
> > ```
> >   if (authorizations.count(requestedPath) > 0) {
> > return authorizations[requestedPath](principal);
> >   }
> >   while (Path(requestedPath).dirname() != requestedPath) {
> > requestedPath = Path(requestedPath).dirname();
> > if (authorizations.count(requestedPath) > 0) {
> >   return authorizations[requestedPath](principal);
> > }
> >   }
> > ```

I will still use the do/while, because it just looks weird that we check for a 
path and then immidiatly change it, but I'm ok with the changes.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47794/#review135131
---


On May 26, 2016, 6:05 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47794/
> ---
> 
> (Updated May 26, 2016, 6:05 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Mahler, Joerg Schad, Michael Park, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-5153
> https://issues.apache.org/jira/browse/MESOS-5153
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds an optional parameter to the `mesos::internal::Files::attach()`
> method. The type of this parameter is a callable object which returns
> a future to a boolean and takes as parameter an optional string
> representing a principal name.
> 
> The parameter is called, if set, whenever one of the routed endpoints
> of the `Files` object is accessed through HTTP. If the callable object
> returns a false boolean, then processing of the request is aborted
> and a `403 Forbidden` response is returned.
> 
> 
> Diffs
> -
> 
>   src/files/files.hpp 90acb3406c46c164108deb559af71fb109a5773b 
>   src/files/files.cpp e4b0ada00aabba6553810391f4015a896f8a69a5 
>   src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 
> 
> Diff: https://reviews.apache.org/r/47794/diff/
> 
> 
> Testing
> ---
> 
> On OSX:
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 47909: Slave/Agent Rename Phase I - Updated terms in the website.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47909/#review135145
---



Bad review!

Reviews applied: [47909, 47904, 47903]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On May 26, 2016, 5:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47909/
> ---
> 
> (Updated May 26, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, zhou xing and Vinod Kone.
> 
> 
> Bugs: MESOS-5397
> https://issues.apache.org/jira/browse/MESOS-5397
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Slave/Agent Rename Phase I - Updated terms in the website.
> 
> 
> Diffs
> -
> 
>   site/source/index.html.erb 67f38ac29904bb4853c7fbae51ef9d82396c170e 
> 
> Diff: https://reviews.apache.org/r/47909/diff/
> 
> 
> Testing
> ---
> 
> Because we updated site/README.md before, only need to update 
> `site/source/index.html.erb` here.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47704: Used TaskObjectAllower to filter /state endpoint.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47704/
---

(Updated May 27, 2016, 3:48 a.m.)


Review request for mesos and Michael Park.


Summary (updated)
-

Used TaskObjectAllower to filter /state endpoint.


Repository: mesos


Description (updated)
---

Used TaskObjectAllower to filter /state endpoint.


Diffs (updated)
-

  src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 

Diff: https://reviews.apache.org/r/47704/diff/


Testing
---

Make check (OSX)


Thanks,

Joerg Schad

Re: Review Request 47559: Added authorization based filtering to /state-summary.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47559/
---

(Updated May 27, 2016, 3:48 a.m.)


Review request for mesos, Adam B and Michael Park.


Bugs: MESOS-5170
https://issues.apache.org/jira/browse/MESOS-5170


Repository: mesos


Description
---

Added authorization based filtering to /state-summary.


Diffs (updated)
-

  src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 

Diff: https://reviews.apache.org/r/47559/diff/


Testing
---

make check + (sudo) make check on various linux systems


Thanks,

Joerg Schad

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/
---

(Updated May 27, 2016, 3:48 a.m.)


Review request for mesos, Adam B and Michael Park.


Bugs: MESOS-5403
https://issues.apache.org/jira/browse/MESOS-5403


Repository: mesos


Description
---

With to goal to provide more efficient authorization
for multiple, potentially large objects we extend the
authorizer interface to support `ObjectAllower`.
Retrieving an ObjectAllower for a given action is an
asynchronous operation but following authorization
of multiple objects can be done synchronously without
copying the object.
NOTE: This implies that Authorizer Module writers
need to ensure an ObjectAllower will behave nicely
and especially not block.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
ed5f9e73661e25a83722cf1e408ae61023cd4a21 
  src/authorizer/local/authorizer.hpp 61388454025211fd7d53e71a86983fd8479950b6 
  src/authorizer/local/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b 
  src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
  src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
  src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e 

Diff: https://reviews.apache.org/r/47558/diff/


Testing
---

tested entire chain.


Thanks,

Joerg Schad

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/#review135102
---




include/mesos/authorizer/authorizer.hpp (line 40)


ObjectAuthorization ()



include/mesos/authorizer/authorizer.hpp (line 45)


: next line



include/mesos/authorizer/authorizer.hpp (lines 59 - 62)


+1 indent



include/mesos/authorizer/authorizer.hpp (line 61)


is/it



include/mesos/authorizer/authorizer.hpp (line 73)


Duplicate and remove here



include/mesos/authorizer/authorizer.hpp (line 146)


Add comment.



src/authorizer/local/authorizer.cpp (line 59)


Move out



src/authorizer/local/authorizer.cpp (line 175)


individual lines



src/authorizer/local/authorizer.cpp (line 180)


2 indent.



src/authorizer/local/authorizer.cpp (line 205)


TaskInfo
ExecutorInfo not



src/authorizer/local/authorizer.cpp (line 217)


format



src/authorizer/local/authorizer.cpp (line 218)


-2



src/authorizer/local/authorizer.cpp (line 246)


Move before view
Authorization



src/authorizer/local/authorizer.cpp (line 247)


ANY



src/authorizer/local/authorizer.cpp (line 274)


return false;
unknown



src/authorizer/local/authorizer.cpp (line 339)


static private
Resulthttps://reviews.apache.org/r/47558/#comment200132>

each on line



src/authorizer/local/authorizer.cpp (line 556)


No log.



src/authorizer/local/authorizer.cpp (line 558)


Update comment:
return None()



src/authorizer/local/authorizer.cpp (line 571)


do not save future



src/authorizer/local/authorizer.cpp (line 576)


other fields



src/authorizer/local/authorizer.cpp (line 597)


if genericAcls.isNone -> return falseObjectAllower



src/authorizer/local/authorizer.cpp (line 599)


Individual lines



src/master/http.cpp (line 157)


allowViewFrameworkInfo


- Joerg Schad


On May 26, 2016, 8:38 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47558/
> ---
> 
> (Updated May 26, 2016, 8:38 p.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-5403
> https://issues.apache.org/jira/browse/MESOS-5403
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With to goal to provide more efficient authorization
> for multiple, potentially large objects we extend the
> authorizer interface to support `ObjectAllower`.
> Retrieving an ObjectAllower for a given action is an
> asynchronous operation but following authorization
> of multiple objects can be done synchronously without
> copying the object.
> NOTE: This implies that Authorizer Module writers
> need to ensure an ObjectAllower will behave nicely
> and especially not block.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> ed5f9e73661e25a83722cf1e408ae61023cd4a21 
>   src/authorizer/local/authorizer.hpp 
> 61388454025211fd7d53e71a86983fd8479950b6 
>   src/authorizer/local/authorizer.cpp 
> dc53bc4374aea98b5ed41ade5617374d2447229b 
>   src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
>   src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e 
> 
> Diff: https://reviews.apache.org/r/47558/diff/
> 
> 
> Testing
> ---
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47935: Added test for provisioner to handle whiteout files.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47935/#review135144
---



Patch looks great!

Reviews applied: [47265, 47266, 47935]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On May 27, 2016, 12:56 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47935/
> ---
> 
> (Updated May 27, 2016, 12:56 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-5277
> https://issues.apache.org/jira/browse/MESOS-5277
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for provisioner to handle whiteout files.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47935/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo /bin/mesos-test.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 47940: Consistent name for UpdateWeights ACL message name.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47940/
---

Review request for mesos and Adam B.


Repository: mesos


Description
---

We use singular for the message where applicable.
Note that `UpdateWeights` is not yet included in any release
and hence does not require a deprecation cycle.


Diffs
-

  include/mesos/authorizer/acls.proto b178f53a299a2941afc073af963f6aff26af1ca8 
  src/authorizer/local/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b 
  src/tests/dynamic_weights_tests.cpp 362c59aae7b305710d5985bfec28f881be3b64b8 

Diff: https://reviews.apache.org/r/47940/diff/


Testing
---

make check (OSX)


Thanks,

Joerg Schad

Re: Review Request 47907: Slave/Agent rename in diagrams.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47907/#review135140
---


Ship it!




Love it. Thanks!

- Vinod Kone


On May 26, 2016, 5:11 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47907/
> ---
> 
> (Updated May 26, 2016, 5:11 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5407
> https://issues.apache.org/jira/browse/MESOS-5407
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Diagrams under docs/images are renamed.
> 
> 
> Diffs
> -
> 
>   docs/images/architecture-example.jpg 
> e93e027af679c7e422b9d5c768648d4b2e8db2fb 
>   docs/images/architecture3.jpg e962af6c906362fd24c6dd77b0c464a03ecc5763 
>   docs/images/containerizer_isolator_api.png 
> 0e15b91544e7379d0e343bebff2947c85bac74f9 
>   docs/images/ec_orphan_seqdiag.png 670f872e3e17bc899a0a5c99bd6b5fde80813f4d 
>   docs/images/ec_recover_seqdiag.png 18dabcc143b36cf46210103817a759758d31d4dd 
>   docs/images/fetch_components.jpg 58387eb70006fb3b0f8d4aa018b6d2b7c9581725 
>   docs/images/networking-architecture.png 
> 58838cfddd78fcb9bcbe9548fe9c386f2b7d4847 
>   docs/images/oversubscription-overview.jpg 
> 2d3109777d09c9053b27f8f77e32d7e3eb56496c 
> 
> Diff: https://reviews.apache.org/r/47907/diff/
> 
> 
> Testing
> ---
> 
> View images under docs/images to see the changes
> 
> 
> File Attachments
> 
> 
> ec_recover_seqdiag.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/f69a32cc-7034-4170-816c-48020ee282dc__ec_recover_seqdiag.png
> ec_orphan_seqdiag.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/cd2479ef-1b4e-46e3-8c6a-ed46b9f6d008__ec_orphan_seqdiag.png
> networking-architecture.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/6a467aed-a846-42aa-8cfa-032d37c9c8bf__networking-architecture.png
> architecture-example.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/32d6763a-0857-4b43-9e84-3f63f5c53f51__architecture-example.jpg
> oversubscription-overview.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/63054974-f1ef-4047-8ea0-d5bcf4b9b8af__oversubscription-overview.jpg
> containerizer_isolator_api.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/3e4dc321-2ae3-4cea-9783-b046ea330634__containerizer_isolator_api.png
> fetch_components.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/888429b7-9859-456a-aca2-06206644a765__fetch_components.jpg
> architecture3.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/05/26/2b20335b-53fe-40a1-93ac-70efa7a20266__architecture3.jpg
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 47660: Fixed slave switch user logic in 'getExecutorInfo'.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47660/#review135139
---


Ship it!




The commit message should be `Fixed agent`?

- haosdent huang


On May 26, 2016, 8:55 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47660/
> ---
> 
> (Updated May 26, 2016, 8:55 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin 
> Klues, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed slave switch user logic in 'getExecutorInfo'.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 470b5c82ea6ff01d799b06245609725853300ef1 
> 
> Diff: https://reviews.apache.org/r/47660/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 47909: Slave/Agent Rename Phase I - Updated terms in the website.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47909/#review135138
---


Ship it!




Ship It!

- Vinod Kone


On May 26, 2016, 5:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47909/
> ---
> 
> (Updated May 26, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, zhou xing and Vinod Kone.
> 
> 
> Bugs: MESOS-5397
> https://issues.apache.org/jira/browse/MESOS-5397
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Slave/Agent Rename Phase I - Updated terms in the website.
> 
> 
> Diffs
> -
> 
>   site/source/index.html.erb 67f38ac29904bb4853c7fbae51ef9d82396c170e 
> 
> Diff: https://reviews.apache.org/r/47909/diff/
> 
> 
> Testing
> ---
> 
> Because we updated site/README.md before, only need to update 
> `site/source/index.html.erb` here.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47904: Added missing periods for blog titles.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47904/#review135137
---


Ship it!




Ship It!

- Vinod Kone


On May 26, 2016, 5:08 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47904/
> ---
> 
> (Updated May 26, 2016, 5:08 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski and Vinod Kone.
> 
> 
> Bugs: MESOS-5424
> https://issues.apache.org/jira/browse/MESOS-5424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added missing periods for blog titles.
> 
> 
> Diffs
> -
> 
>   site/data/releases.yml f72e8864fa68f41bb069b298798ea29a2ee28432 
> 
> Diff: https://reviews.apache.org/r/47904/diff/
> 
> 
> Testing
> ---
> 
> ![website_pc](https://issues.apache.org/jira/secure/attachment/12806428/website_pc.gif)
> ![website_mobile](https://issues.apache.org/jira/secure/attachment/12806427/website_mobile.gif)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47903: Removed the unnecessary space in middleman config.rb.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47903/#review135136
---


Ship it!




Ship It!

- Vinod Kone


On May 26, 2016, 5:06 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47903/
> ---
> 
> (Updated May 26, 2016, 5:06 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski and Vinod Kone.
> 
> 
> Bugs: MESOS-5424
> https://issues.apache.org/jira/browse/MESOS-5424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the unnecessary space in middleman config.rb.
> 
> 
> Diffs
> -
> 
>   site/config.rb 89179f9eaad1d972b082997afba5ad6102466829 
> 
> Diff: https://reviews.apache.org/r/47903/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47903: Removed the unnecessary space in middleman config.rb.

[haosdent huang]

> On May 26, 2016, 6:57 p.m., Tomasz Janiszewski wrote:
> > site/config.rb, line 39
> > 
> >
> > I'm not sure if this change improve anything. Personally I prefer to 
> > fix minor typos like this when there are other changes in file.

Yes, sometimes we sweep update the code which the style is incorrect.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47903/#review135045
---


On May 26, 2016, 5:06 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47903/
> ---
> 
> (Updated May 26, 2016, 5:06 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski and Vinod Kone.
> 
> 
> Bugs: MESOS-5424
> https://issues.apache.org/jira/browse/MESOS-5424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the unnecessary space in middleman config.rb.
> 
> 
> Diffs
> -
> 
>   site/config.rb 89179f9eaad1d972b082997afba5ad6102466829 
> 
> Diff: https://reviews.apache.org/r/47903/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47901: Clean up the code style of website css.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47901/
---

(Updated May 27, 2016, 2:36 a.m.)


Review request for mesos, Tomasz Janiszewski and Vinod Kone.


Changes
---

Address @vinodkone's comments.


Bugs: MESOS-5424
https://issues.apache.org/jira/browse/MESOS-5424


Repository: mesos


Description
---

Clean up the code style of website css.


Diffs (updated)
-

  site/source/assets/css/main.css 685957218f59e377c4ca1ee5c7f3f4001371dd74 

Diff: https://reviews.apache.org/r/47901/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 47902: Clean up the code style or website erb templates.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47902/#review135134
---


Ship it!




Ship It!

- Vinod Kone


On May 26, 2016, 5:06 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47902/
> ---
> 
> (Updated May 26, 2016, 5:06 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clean up the code style or website erb templates.
> 
> 
> Diffs
> -
> 
>   site/source/blog.html.erb 04cfa793af29f36842386eb41c3fedc9f24a12d9 
>   site/source/community.html.md 8675577fe69a7ead2d146fe8df7180ca23553493 
>   site/source/index.html.erb 67f38ac29904bb4853c7fbae51ef9d82396c170e 
>   site/source/layouts/community_section.erb 
> b53c0e34964564432259b0086a7067818e96acb7 
>   site/source/layouts/documentation.erb 
> a2f5361247d6adf079f0e334d679cc2bfe7fe1bd 
>   site/source/layouts/layout.erb a732c7487b5989f166f67fa8dd9219ad434a637d 
>   site/source/layouts/post.erb 89b2b70bbb87c69b3ace6a77b09c9439a81b005c 
> 
> Diff: https://reviews.apache.org/r/47902/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47901: Clean up the code style of website css.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47901/#review135133
---


Fix it, then Ship it!





site/source/assets/css/main.css (line 27)


s/to be fill/to fill/


- Vinod Kone


On May 26, 2016, 5:06 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47901/
> ---
> 
> (Updated May 26, 2016, 5:06 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski and Vinod Kone.
> 
> 
> Bugs: MESOS-5424
> https://issues.apache.org/jira/browse/MESOS-5424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clean up the code style of website css.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 685957218f59e377c4ca1ee5c7f3f4001371dd74 
> 
> Diff: https://reviews.apache.org/r/47901/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47082/#review135132
---



Patch looks great!

Reviews applied: [47082]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On May 26, 2016, 11:56 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47082/
> ---
> 
> (Updated May 26, 2016, 11:56 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5143
> https://issues.apache.org/jira/browse/MESOS-5143
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a slave is removed, master sends a LostSlaveMessage to affected
> frameworks only (instead of all registered frameworks). An affected
> framework is a framework which satisfied one or more conditions of
> the following:
> 
> 1. There are running tasks on this slave belonging to the framework.
> 2. There are pending tasks on this slave belonging to the framework.
> 3. Reserved resources on the slave have a matching role with the
>role of the framework.
> 4. There are pending offers or pending inverse offers from this slave
>for the framework.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
>   src/master/master.cpp 0005a29caabcc6a3776037cf86a2b12660e6377b 
>   src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 
> 
> Diff: https://reviews.apache.org/r/47082/diff/
> 
> 
> Testing
> ---
> 
> All existing and modified tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 47794: Added authorization support for mesos::internal::Files.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47794/#review135131
---




src/files/files.cpp (lines 305 - 317)


The loop body is quite simple, so I'd rather we duplicate it outside the 
loop instead of special-casing the dirname "accumulator" logic.
Wouldn't the following work just as well?
```
  if (authorizations.count(requestedPath) > 0) {
return authorizations[requestedPath](principal);
  }
  while (Path(requestedPath).dirname() != requestedPath) {
requestedPath = Path(requestedPath).dirname();
if (authorizations.count(requestedPath) > 0) {
  return authorizations[requestedPath](principal);
}
  }
```


- Adam B


On May 26, 2016, 9:05 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47794/
> ---
> 
> (Updated May 26, 2016, 9:05 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Mahler, Joerg Schad, Michael Park, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-5153
> https://issues.apache.org/jira/browse/MESOS-5153
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds an optional parameter to the `mesos::internal::Files::attach()`
> method. The type of this parameter is a callable object which returns
> a future to a boolean and takes as parameter an optional string
> representing a principal name.
> 
> The parameter is called, if set, whenever one of the routed endpoints
> of the `Files` object is accessed through HTTP. If the callable object
> returns a false boolean, then processing of the request is aborted
> and a `403 Forbidden` response is returned.
> 
> 
> Diffs
> -
> 
>   src/files/files.hpp 90acb3406c46c164108deb559af71fb109a5773b 
>   src/files/files.cpp e4b0ada00aabba6553810391f4015a896f8a69a5 
>   src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 
> 
> Diff: https://reviews.apache.org/r/47794/diff/
> 
> 
> Testing
> ---
> 
> On OSX:
> `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 47932: Stout: made standalone build work again.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47932/#review135129
---



Bad patch!

Reviews applied: [47932, 47931, 47930, 47929, 47928, 47927, 47925, 47924, 
47786, 47756, 47755, 47754, 47753, 47752]

Failed command: ./support/apply-review.sh -n -r 47927

Error:
2016-05-27 01:29:20 URL:https://reviews.apache.org/r/47927/diff/raw/ [542/542] 
-> "47927.patch" [1]
error: patch failed: 3rdparty/libprocess/configure.ac:339
error: 3rdparty/libprocess/configure.ac: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13355/console

- Mesos ReviewBot


On May 26, 2016, 11:30 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47932/
> ---
> 
> (Updated May 26, 2016, 11:30 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-5416
> https://issues.apache.org/jira/browse/MESOS-5416
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: made standalone build work again.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/3rdparty/Makefile.am PRE-CREATION 
>   3rdparty/stout/3rdparty/gmock_sources.cc.in PRE-CREATION 
>   3rdparty/stout/Makefile.am eeaca480872b97d60891376b8c21fda7b65a6f00 
>   3rdparty/stout/configure.ac 52b4a05e9b27518144e4382d107c9c7834a41015 
> 
> Diff: https://reviews.apache.org/r/47932/diff/
> 
> 
> Testing
> ---
> 
> The following passes from within 3rdparty/stout:
> ./bootstrap && mkdir build && cd build && ../configure && make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 47909: Slave/Agent Rename Phase I - Updated terms in the website.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47909/#review135125
---


Ship it!




ok to me

- zhou xing


On 五月 26, 2016, 5:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47909/
> ---
> 
> (Updated 五月 26, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, zhou xing and Vinod Kone.
> 
> 
> Bugs: MESOS-5397
> https://issues.apache.org/jira/browse/MESOS-5397
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Slave/Agent Rename Phase I - Updated terms in the website.
> 
> 
> Diffs
> -
> 
>   site/source/index.html.erb 67f38ac29904bb4853c7fbae51ef9d82396c170e 
> 
> Diff: https://reviews.apache.org/r/47909/diff/
> 
> 
> Testing
> ---
> 
> Because we updated site/README.md before, only need to update 
> `site/source/index.html.erb` here.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47212: Removed duplicate call to containerizer::executorEnvironment.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47212/#review135123
---


Ship it!




Ship It!

- Jie Yu


On May 11, 2016, 2:13 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47212/
> ---
> 
> (Updated May 11, 2016, 2:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this code path, where the task uses the default command executor, 
> and the agent is not dockerized
> (i.e. `taskInfo.isSome() && flags.docker_mesos_image.isNone()`), 
> the `executorEnvironment` function is called twice.
> 
> The first call is inside the `Container*` constructor called by 
> `Container::create`.  Since `Container::create` gives passes `None` 
> for the `environment` field, the constructor will call 
> `executorEnvironment` to populate the `environment` field.  
> The populated field is then accessible by `launchExecutorProcess`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
> 
> Diff: https://reviews.apache.org/r/47212/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47921: Enabled authorization for Mesos log access.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47921/#review135122
---



Patch looks great!

Reviews applied: [47794, 47795, 47921]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On May 26, 2016, 10:45 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47921/
> ---
> 
> (Updated May 26, 2016, 10:45 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-5153
> https://issues.apache.org/jira/browse/MESOS-5153
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Uses the authorization primitives in `mesos::internal::Files` to add
> protection of the Mesos logs on both master and agents.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> ace9b698f46e143795c82324a87a0d7827fb 
>   include/mesos/authorizer/authorizer.proto 
> 02d1a01d57cf34b38524f4368187878b03343537 
>   src/authorizer/local/authorizer.cpp 
> 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029 
>   src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
>   src/master/master.cpp 0005a29caabcc6a3776037cf86a2b12660e6377b 
>   src/slave/slave.hpp 0de6a570e8b4699771048295ec3fcedf84593495 
>   src/slave/slave.cpp 470b5c82ea6ff01d799b06245609725853300ef1 
> 
> Diff: https://reviews.apache.org/r/47921/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> and the script
> 
> ```bash
> #! /usr/bin/env bash
> 
> rm -rf /tmp/mesos/*
> 
> cat < /tmp/credentials.txt
> foo bar
> baz bar
> EOF
> 
> cat < /tmp/acls.json
> {
>   "permissive": false,
>   "access_mesos_log" : [
> {
>   "principals" : { "values" : ["foo"] },
>   "logs" : { "type" : "ANY" }
> }
>   ]
> }
> EOF
> 
> ./bin/mesos-master.sh --work_dir=/tmp/mesos/master \
>   --authenticate_http \
>   --credentials=file:///tmp/credentials.txt \
>   --acls=file:///tmp/acls.json \
>   --log_dir=/tmp/mesos/logs/master &
> ./bin/mesos-slave.sh --work_dir=/tmp/mesos/agent \
>  --master=127.0.0.1:5050 \
>  --authenticate_http \
>  --http_credentials=file:///tmp/credentials.txt \
>  --acls=file:///tmp/acls.json \
>  --log_dir=/tmp/mesos/logs/agent &
> 
> # This should yield a 200 OK response
> http GET http://127.0.0.1:5051/files/download?path=/slave/log -a foo:bar
> 
> # This should yield a 200 OK response
> http GET http://127.0.0.1:5050/files/download?path=/master/log/ -a foo:bar
> 
> 
> # This shold yield a 403 Forbidden response
> http GET http://127.0.0.1:5051/files/download?path=/slave/log -a baz:bar
> 
> # This shold yield a 403 Forbidden response
> http GET http://127.0.0.1:5050/files/download?path=/master/log/ -a baz:bar
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Review Request 47935: Added test for provisioner to handle whiteout files.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47935/
---

Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, and 
Timothy Chen.


Bugs: MESOS-5277
https://issues.apache.org/jira/browse/MESOS-5277


Repository: mesos


Description
---

Added test for provisioner to handle whiteout files.


Diffs
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
69505c922617273effc2eb52b0c567a3c01bf640 

Diff: https://reviews.apache.org/r/47935/diff/


Testing
---

make check

sudo /bin/mesos-test.sh


Thanks,

Gilbert Song

Re: Review Request 47266: Implemented provisioner removing docker whiteout files.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47266/
---

(Updated May 26, 2016, 5:54 p.m.)


Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, and 
Timothy Chen.


Summary (updated)
-

Implemented provisioner removing docker whiteout files.


Bugs: MESOS-5277
https://issues.apache.org/jira/browse/MESOS-5277


Repository: mesos


Description (updated)
---

Implemented provisioner removing docker whiteout files.


Diffs (updated)
-

  include/mesos/docker/spec.hpp 2ebacc70d92a593c8dd006b34519c3a2a5225481 
  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 

Diff: https://reviews.apache.org/r/47266/diff/


Testing
---

make check

Tested with docker image containing `.wh.` files.


Thanks,

Gilbert Song

Re: Review Request 47265: Fixed provisioner parameter naming.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47265/
---

(Updated May 26, 2016, 5:54 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Fixed provisioner parameter naming.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
5c96e9f6603d39889e6bc807874d35d0cb3556be 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 

Diff: https://reviews.apache.org/r/47265/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 47216: Wired up the new docker environment hook.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47216/#review135120
---




src/slave/containerizer/docker.cpp (lines 1055 - 1057)


Hum, so we don't support custom executor? what's the expection of this hook 
for custom executor? Will the environment variables returned here be included 
in the custome executor's environment?


- Jie Yu


On May 26, 2016, 2:21 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47216/
> ---
> 
> (Updated May 26, 2016, 2:21 a.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Modifies the code path for docker command executors. (Custom 
> executors are not supported because they may break if exposed to an
> unfamiliar flag.)
> 
> Docker command executors are now launched with an additional flag
> that is filled in by a hook.  The --task_environment flag tells the
> command executor to pass some specified mapping of environment
> variables to the task.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp fac26a239e9981e5b1c2f2f90b52785819492c2a 
>   src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
> 
> Diff: https://reviews.apache.org/r/47216/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47150: Implemented new asynchronous docker pre-launch hook.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47150/#review135119
---


Fix it, then Ship it!





include/mesos/hook.hpp (line 95)


It's not part of the executor's environment, right? For the command task 
case, it's the environment for the task, not the executor, right?



src/tests/hook_tests.cpp (lines 667 - 671)


Can you use createTask instead?


- Jie Yu


On May 24, 2016, 9:04 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47150/
> ---
> 
> (Updated May 24, 2016, 9:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduces, but does not fully wire up a new hook.
> 
> The new hook, "slavePreLaunchDockerEnvironmentDecoratorAndValidator",
> has divergent semantics compared with existing hooks:
> 
> * The hook is asynchronous,
> * can prevent a task from launching if it errors,
> * can overwrite environment variables.
> 
> The new hook is a strictly-superior replacement for 
> the existing hook "slavePreLaunchDockerHook".  
> The arguments to both hooks are identical.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 210ffba09f5acae34ca49b888a781f683777f9ca 
>   src/examples/test_hook_module.cpp 4b97f84204934d0e678786fd6cde38b89a6f8f48 
>   src/hook/manager.hpp 528674e36639fe78137ba0a4bb004c99730e7a22 
>   src/hook/manager.cpp 381807d582998043d73e9b8c9d3c1fddbcf73cf1 
>   src/tests/hook_tests.cpp c6b4e8a50534e455cf44f427b09f74eef71177b2 
> 
> Diff: https://reviews.apache.org/r/47150/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47215: Changed the dockerized docker command executor CommandInfo usage.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47215/#review135115
---


Ship it!




Ship It!

- Jie Yu


On May 26, 2016, 2:21 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47215/
> ---
> 
> (Updated May 26, 2016, 2:21 a.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This changes how we override the `CommandInfo` when launching a 
> dockerized executor; from `shell == true` to `shell = false`.  
> This means that flags are now passed directly rather than as 
> a long string.
> 
> i.e. 
> From: 'mesos-docker-executor --foo="bar" --some="thing"'
> To: [ 'mesos-docker-executor', '--foo=bar', '--some=thing' ]
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
> 
> Diff: https://reviews.apache.org/r/47215/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

[Anindya Sinha]

> On May 25, 2016, 6:27 p.m., Jiang Yan Xu wrote:
> > src/master/master.cpp, line 6551
> > 
> >
> > I don't feel that this boolean is necessary, we can easily check if a 
> > framework is added by checking if it's in the set (O(1) if hashset), right?

For a std::set, we needed this bool. I think we can avoid this if we use a 
hashset.


> On May 25, 2016, 6:27 p.m., Jiang Yan Xu wrote:
> > src/master/master.cpp, lines 6576-6579
> > 
> >
> > From `slave->checkpointedResource.reservations()` we can get the list 
> > of roles and from `activeRoles` we can get the list of frameworks for each 
> > role.

Moved this to use activeRoles.


> On May 25, 2016, 6:27 p.m., Jiang Yan Xu wrote:
> > src/tests/master_authorization_tests.cpp, lines 338-339
> > 
> >
> > If we don't expect it to be call, we should do
> > 
> > ```
> > EXPECT_CALL(sched, slaveLost(, _))
> >   .Times(0);
> > ```
> > 
> > Here and elsewhere.
> > 
> > But here I think we should fix this to have the framework receive the 
> > slave lost messsage. See the comment below.

Reinstated the original version, since we expect SlaveLostMessage to be sent 
for pending tasks.


> On May 25, 2016, 6:27 p.m., Jiang Yan Xu wrote:
> > src/tests/master_authorization_tests.cpp, lines 346-348
> > 
> >
> > So if the task is stuck in the `pendingTasks` a slave lost message is 
> > not sent but later a TASK_LOST is sent with reason 
> > `REASON_SLAVE_REMOVED`... We should handle this case the same way as the 
> > other cases where we do send slave lost IMO.
> > 
> > We probably need to add a `pendingTasks` hashmap in the slave as well 
> > and check against that map during `removeSlave()`, thoughts?

Good catch. Yes, added a slave->pendingTasks and use this to send out 
SlaveLostMessage to frameworks with pending tasks.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47082/#review134535
---


On May 26, 2016, 11:56 p.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47082/
> ---
> 
> (Updated May 26, 2016, 11:56 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5143
> https://issues.apache.org/jira/browse/MESOS-5143
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a slave is removed, master sends a LostSlaveMessage to affected
> frameworks only (instead of all registered frameworks). An affected
> framework is a framework which satisfied one or more conditions of
> the following:
> 
> 1. There are running tasks on this slave belonging to the framework.
> 2. There are pending tasks on this slave belonging to the framework.
> 3. Reserved resources on the slave have a matching role with the
>role of the framework.
> 4. There are pending offers or pending inverse offers from this slave
>for the framework.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
>   src/master/master.cpp 0005a29caabcc6a3776037cf86a2b12660e6377b 
>   src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 
> 
> Diff: https://reviews.apache.org/r/47082/diff/
> 
> 
> Testing
> ---
> 
> All existing and modified tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47082/
---

(Updated May 26, 2016, 11:56 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
---

Updated based on review comments.


Bugs: MESOS-5143
https://issues.apache.org/jira/browse/MESOS-5143


Repository: mesos


Description (updated)
---

When a slave is removed, master sends a LostSlaveMessage to affected
frameworks only (instead of all registered frameworks). An affected
framework is a framework which satisfied one or more conditions of
the following:

1. There are running tasks on this slave belonging to the framework.
2. There are pending tasks on this slave belonging to the framework.
3. Reserved resources on the slave have a matching role with the
   role of the framework.
4. There are pending offers or pending inverse offers from this slave
   for the framework.


Diffs (updated)
-

  src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
  src/master/master.cpp 0005a29caabcc6a3776037cf86a2b12660e6377b 
  src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 

Diff: https://reviews.apache.org/r/47082/diff/


Testing
---

All existing and modified tests passed.


Thanks,

Anindya Sinha

Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47515/#review135076
---




src/master/http.cpp (line 50)


add stout/option.hpp and stout/none.hpp?


- Greg Mann


On May 23, 2016, 4:37 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47515/
> ---
> 
> (Updated May 23, 2016, 4:37 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enforces the constraint that the principal
> found in `DiskInfo.Persistence` should equal that of
> the framework or operator responsible for creating
> the volume.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
>   src/master/master.cpp 0c05938de3e4eaeea2187559e81559f85318fa73 
>   src/master/validation.hpp f29f9753c75e5abc3402ed23381edcea26517ab3 
>   src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 
> 
> Diff: https://reviews.apache.org/r/47515/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47360/#review135114
---



Also, note the dependency on this patch; it's a really small fix.

- Greg Mann


On May 26, 2016, 5:02 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47360/
> ---
> 
> (Updated May 26, 2016, 5:02 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Neil Conway.
> 
> 
> Bugs: MESOS-5215
> https://issues.apache.org/jira/browse/MESOS-5215
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the documentation of RESERVE and
> CREATE operations, both via offer operations and
> operator endpoints. Specifically, we clarify the
> Mesos master's expectations for the values of the
> `principal` fields found in `ReservationInfo` and
> `DiskInfo.Persistence`.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md c13d79124f0b5ea2a715b4d2990fda4e06b2fb02 
>   docs/reservation.md a400d19aec7a48d122ba1c9c23d38d792b8dbe6f 
> 
> Diff: https://reviews.apache.org/r/47360/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47668: Obtained uid/gids before changing filesystem root.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47668/#review135113
---



Patch looks great!

Reviews applied: [47660, 47661, 47662, 47663, 47664, 47665, 47666, 47667, 47668]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On May 26, 2016, 8:55 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47668/
> ---
> 
> (Updated May 26, 2016, 8:55 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin 
> Klues, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Obtained uid/gids before changing filesystem root.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
>   src/slave/containerizer/mesos/launch.cpp 
> e22106b014c871e2184a15c2ab154a0674874e47 
> 
> Diff: https://reviews.apache.org/r/47668/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 47924: Added AM_CONDITIONALS: STANDALONE_{LIBPROCES, STOUT}.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47924/
---

(Updated May 26, 2016, 7:30 p.m.)


Review request for mesos and Till Toenshoff.


Bugs: MESOS-5415
https://issues.apache.org/jira/browse/MESOS-5415


Repository: mesos


Description
---

Added AM_CONDITIONALS: STANDALONG_{LIBPROCES,STOUT}.


Diffs
-

  configure.ac 875c7d1b13b3739a7abb55f0d16dbcfd17f3defc 

Diff: https://reviews.apache.org/r/47924/diff/


Testing
---


Thanks,

Kapil Arya

Review Request 47924: Added AM_CONDITIONALS: STANDALONE_{LIBPROCES, STOUT}.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47924/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-5414
https://issues.apache.org/jira/browse/MESOS-5414


Repository: mesos


Description
---

Added AM_CONDITIONALS: STANDALONG_{LIBPROCES,STOUT}.


Diffs
-

  configure.ac 875c7d1b13b3739a7abb55f0d16dbcfd17f3defc 

Diff: https://reviews.apache.org/r/47924/diff/


Testing
---


Thanks,

Kapil Arya

Review Request 47932: Stout: made standalone build work again.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47932/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-5416
https://issues.apache.org/jira/browse/MESOS-5416


Repository: mesos


Description
---

Stout: made standalone build work again.


Diffs
-

  3rdparty/stout/3rdparty/Makefile.am PRE-CREATION 
  3rdparty/stout/3rdparty/gmock_sources.cc.in PRE-CREATION 
  3rdparty/stout/Makefile.am eeaca480872b97d60891376b8c21fda7b65a6f00 
  3rdparty/stout/configure.ac 52b4a05e9b27518144e4382d107c9c7834a41015 

Diff: https://reviews.apache.org/r/47932/diff/


Testing
---

The following passes from within 3rdparty/stout:
./bootstrap && mkdir build && cd build && ../configure && make check


Thanks,

Kapil Arya

Review Request 47929: Libprocess: made standalone build work again.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47929/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-5415
https://issues.apache.org/jira/browse/MESOS-5415


Repository: mesos


Description
---

Libprocess: made standalone build work again.


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am PRE-CREATION 
  3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 
  3rdparty/libprocess/Makefile.am 3c3249fe9799ba919ac7bd13e2ddb07a306737f0 
  3rdparty/libprocess/configure.ac 2daded51122ab97d71ec57109b85c2473460eeda 

Diff: https://reviews.apache.org/r/47929/diff/


Testing
---

The following passes from within 3rdparty/libprocess:
./bootstrap && mkdir build && cd build && ../configure && make check


Thanks,

Kapil Arya

Review Request 47927: Libprocess: Fixed broken libelf dependency.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47927/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-5415
https://issues.apache.org/jira/browse/MESOS-5415


Repository: mesos


Description
---

Corresponding Mesos fix: 3ec2aa17fc62be9364105c8d3ed3bf11869acec0


Diffs
-

  3rdparty/libprocess/configure.ac 2daded51122ab97d71ec57109b85c2473460eeda 

Diff: https://reviews.apache.org/r/47927/diff/


Testing
---


Thanks,

Kapil Arya

Review Request 47931: Stout: Prepare for standalone compilation.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47931/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-5416
https://issues.apache.org/jira/browse/MESOS-5416


Repository: mesos


Description
---

Stout: Prepare for standalone compilation.


Diffs
-

  3rdparty/stout/Makefile.am eeaca480872b97d60891376b8c21fda7b65a6f00 

Diff: https://reviews.apache.org/r/47931/diff/


Testing
---


Thanks,

Kapil Arya

Review Request 47930: Stout: Fixed broken libelf dependency.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47930/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-5416
https://issues.apache.org/jira/browse/MESOS-5416


Repository: mesos


Description
---

Corresponding Mesos fix: 3ec2aa17fc62be9364105c8d3ed3bf11869acec0


Diffs
-

  3rdparty/stout/configure.ac 52b4a05e9b27518144e4382d107c9c7834a41015 

Diff: https://reviews.apache.org/r/47930/diff/


Testing
---


Thanks,

Kapil Arya

Review Request 47925: Libprocess: Fixed a typo in Makefile.am.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47925/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-5415
https://issues.apache.org/jira/browse/MESOS-5415


Repository: mesos


Description
---

Libprocess: Fixed a typo in Makefile.am.


Diffs
-

  3rdparty/libprocess/Makefile.am 3c3249fe9799ba919ac7bd13e2ddb07a306737f0 

Diff: https://reviews.apache.org/r/47925/diff/


Testing
---


Thanks,

Kapil Arya

Review Request 47928: Libprocess: Prepare for standalone compilation.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47928/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-5415
https://issues.apache.org/jira/browse/MESOS-5415


Repository: mesos


Description
---

Libprocess: Prepare for standalone compilation.


Diffs
-

  3rdparty/libprocess/Makefile.am 3c3249fe9799ba919ac7bd13e2ddb07a306737f0 

Diff: https://reviews.apache.org/r/47928/diff/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 47212: Removed duplicate call to containerizer::executorEnvironment.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47212/#review135106
---




src/slave/containerizer/docker.cpp (line 1195)


There is a subtle difference here. If 'directory' contains a semicolon, 
before this change, `MESOS_DIRECTORY` will be the original sandbox directory, 
and after this change, it'll become the symlink path. See here:

https://github.com/apache/mesos/blob/master/src/slave/containerizer/docker.cpp#L268

I don't know if that matters, but better to keep consistent.


- Jie Yu


On May 11, 2016, 2:13 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47212/
> ---
> 
> (Updated May 11, 2016, 2:13 a.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this code path, where the task uses the default command executor, 
> and the agent is not dockerized
> (i.e. `taskInfo.isSome() && flags.docker_mesos_image.isNone()`), 
> the `executorEnvironment` function is called twice.
> 
> The first call is inside the `Container*` constructor called by 
> `Container::create`.  Since `Container::create` gives passes `None` 
> for the `environment` field, the constructor will call 
> `executorEnvironment` to populate the `environment` field.  
> The populated field is then accessible by `launchExecutorProcess`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
> 
> Diff: https://reviews.apache.org/r/47212/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 47921: Enabled authorization for Mesos log access.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47921/
---

Review request for mesos, Adam B, Joerg Schad, and Michael Park.


Bugs: MESOS-5153
https://issues.apache.org/jira/browse/MESOS-5153


Repository: mesos


Description
---

Uses the authorization primitives in `mesos::internal::Files` to add
protection of the Mesos logs on both master and agents.


Diffs
-

  include/mesos/authorizer/acls.proto ace9b698f46e143795c82324a87a0d7827fb 
  include/mesos/authorizer/authorizer.proto 
02d1a01d57cf34b38524f4368187878b03343537 
  src/authorizer/local/authorizer.cpp 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029 
  src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
  src/master/master.cpp 0005a29caabcc6a3776037cf86a2b12660e6377b 
  src/slave/slave.hpp 0de6a570e8b4699771048295ec3fcedf84593495 
  src/slave/slave.cpp 470b5c82ea6ff01d799b06245609725853300ef1 

Diff: https://reviews.apache.org/r/47921/diff/


Testing
---

`make check`

and the script

```bash
#! /usr/bin/env bash

rm -rf /tmp/mesos/*

cat < /tmp/credentials.txt
foo bar
baz bar
EOF

cat < /tmp/acls.json
{
  "permissive": false,
  "access_mesos_log" : [
{
  "principals" : { "values" : ["foo"] },
  "logs" : { "type" : "ANY" }
}
  ]
}
EOF

./bin/mesos-master.sh --work_dir=/tmp/mesos/master \
  --authenticate_http \
  --credentials=file:///tmp/credentials.txt \
  --acls=file:///tmp/acls.json \
  --log_dir=/tmp/mesos/logs/master &
./bin/mesos-slave.sh --work_dir=/tmp/mesos/agent \
 --master=127.0.0.1:5050 \
 --authenticate_http \
 --http_credentials=file:///tmp/credentials.txt \
 --acls=file:///tmp/acls.json \
 --log_dir=/tmp/mesos/logs/agent &

# This should yield a 200 OK response
http GET http://127.0.0.1:5051/files/download?path=/slave/log -a foo:bar

# This should yield a 200 OK response
http GET http://127.0.0.1:5050/files/download?path=/master/log/ -a foo:bar


# This shold yield a 403 Forbidden response
http GET http://127.0.0.1:5051/files/download?path=/slave/log -a baz:bar

# This shold yield a 403 Forbidden response
http GET http://127.0.0.1:5050/files/download?path=/master/log/ -a baz:bar
```


Thanks,

Alexander Rojas

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47205/#review135101
---


Ship it!




Ship It!

- Jie Yu


On May 26, 2016, 2:02 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47205/
> ---
> 
> (Updated May 26, 2016, 2:02 a.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This flag opens up a way for hooks to specify environment variables for
> docker tasks.  Existing hooks can only affect the environment variables
> of docker executors.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 
>   src/docker/executor.cpp 04f44044a80e1b355580ee3d1d8d301ac3baf565 
> 
> Diff: https://reviews.apache.org/r/47205/diff/
> 
> 
> Testing
> ---
> 
> See later reviews in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47149: Split DockerContainerizerProcess::launch into two functions.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47149/#review135100
---


Ship it!




Ship It!

- Jie Yu


On May 26, 2016, 2:02 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47149/
> ---
> 
> (Updated May 26, 2016, 2:02 a.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
> https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This prepares the `::launch` method for an asynchronous hook.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp fac26a239e9981e5b1c2f2f90b52785819492c2a 
>   src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
> 
> Diff: https://reviews.apache.org/r/47149/diff/
> 
> 
> Testing
> ---
> 
> sudo make check (CentOS 7)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 47266: Implemented provisioner removing docker whitelist files.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47266/#review135070
---


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 312)


is _currently_ docker image specific.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 324)


No need for this check



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 330)


Remove space before 'rootfs' and after 'dockerManifest'



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 333)


Ditto. No spaces around `{` and `}`



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 337)


Can you include the errno? os::strerror(errno)?



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 340)


s/whitelist/whiteout/



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 345)


Can you make `.wh.` a constant in spec.hpp? E.g. `WHITEOUT_PREFIX`



src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 348 - 349)


Do you need this temp variable?



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 349)


please use strlen(WHILEOUT_PREFIX) here.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 370)


Can you include the errno? Ditto above.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 378)


please use whiteout consistently



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 391)


Ditto on extra spaces.


- Jie Yu


On May 13, 2016, 10:16 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47266/
> ---
> 
> (Updated May 13, 2016, 10:16 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-5277
> https://issues.apache.org/jira/browse/MESOS-5277
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented provisioner removing docker whitelist files.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 5c96e9f6603d39889e6bc807874d35d0cb3556be 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 
> 
> Diff: https://reviews.apache.org/r/47266/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Tested with docker image containing `.wh.` files.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 47516: Added creator principal to tests.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47516/#review135096
---


Ship it!




Ship It!

- Till Toenshoff


On May 18, 2016, 8:06 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47516/
> ---
> 
> (Updated May 18, 2016, 8:06 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a creator principal to the persistent
> volumes used in various tests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> f43165388f29513ab8be6594ab6647e8f9eb5a93 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 4293416ac8434e9eb7e80724480a54936a2fe24a 
>   src/tests/disk_quota_tests.cpp 1564f70854ff5630da1d7348a034f726d67b1757 
>   src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
>   src/tests/role_tests.cpp 24959d6e0f83ef7b62b0586be18661aa3cac91dd 
> 
> Diff: https://reviews.apache.org/r/47516/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47522: Added creator principal to persistent volume tests.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47522/#review135095
---


Ship it!




This ship-it is barring your comments. Thanks so much Greg for taking the time 
and typing in the comments as discussed verbally - much appreciated :).

- Till Toenshoff


On May 18, 2016, 8:06 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47522/
> ---
> 
> (Updated May 18, 2016, 8:06 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a creator principal to the
> persistent volumes used in the PersistentVolumeTests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> d246f35046fff469b847c908de2b305ae629212f 
> 
> Diff: https://reviews.apache.org/r/47522/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47521: Added creator principal to '/create-volumes' tests.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47521/#review135094
---


Ship it!




This ship-it is barring your comments. Thanks so much Greg for taking the time 
and typing in the comments as discussed verbally - much appreciated :).

- Till Toenshoff


On May 18, 2016, 8:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47521/
> ---
> 
> (Updated May 18, 2016, 8:05 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A creator principal is added to the persistent volumes
> used in the PersistentVolumeEndpointsTests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> a57461d881b2bf0175f83b50b0a46167acd5bd3e 
> 
> Diff: https://reviews.apache.org/r/47521/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47520: Updated test helpers with creator principal.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47520/#review135092
---


Ship it!




This ship-it is barring your comments. Thanks so much Greg for taking the time 
and typing in the comments as discussed verbally - much appreciated :).

- Till Toenshoff


On May 18, 2016, 8:04 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47520/
> ---
> 
> (Updated May 18, 2016, 8:04 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the `createPersistentVolume` and
> `createDiskInfo` test helper functions to accept an
> argument specifying the creator principal to be included
> in `DiskInfo.Persistence`.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
> 
> Diff: https://reviews.apache.org/r/47520/diff/
> 
> 
> Testing
> ---
> 
> `make check` was done on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47519: Updated an example framework to specify its principal.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47519/#review135091
---


Ship it!




Ship It!

- Till Toenshoff


On May 18, 2016, 8:04 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47519/
> ---
> 
> (Updated May 18, 2016, 8:04 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds the creator principal into the
> persistent volumes created by the persistent volume
> example framework.
> 
> 
> Diffs
> -
> 
>   src/examples/persistent_volume_framework.cpp 
> 53a6f6f82101ebb75abdc8f586fb23ab13298979 
> 
> Diff: https://reviews.apache.org/r/47519/diff/
> 
> 
> Testing
> ---
> 
> Tested manually with the following commands:
> `bin/mesos-master.sh --ip=127.0.0.1 --work_dir="$HOME/var/mesos1" 
> --authenticate=false`
> `bin/mesos-slave.sh --master=127.0.0.1:5050 --work_dir="$HOME/var/mesos2" 
> --"resources=disk(test):2048;mem(test):2048;cpu(test):4"`
> `src/persistent-volume-framework --master=127.0.0.1:5050`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47528: Updated validation tests with creator principal.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47528/#review135090
---


Ship it!




This ship-it is barring your comments. Thanks so much Greg for taking the time 
and typing in the comments as discussed verbally - much appreciated :).

- Till Toenshoff


On May 25, 2016, 6:08 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47528/
> ---
> 
> (Updated May 25, 2016, 6:08 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master validation tests are updated to include the
> new `validate()` signature, and a new test is added,
> `CreateOperationValidationTest.NonMatchingPrincipal`,
> to ensure that a non-matching creator principal will
> be invalidated.
> 
> 
> Diffs
> -
> 
>   src/tests/master_validation_tests.cpp 
> ca4442aa1ef0087a7d058d1b3aa430a1dbc16960 
> 
> Diff: https://reviews.apache.org/r/47528/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47515/#review135088
---


Ship it!




This ship-it is barring your comments. Thanks so much Greg for taking the time 
and typing in the comments as discussed verbally - much appreciated :).

- Till Toenshoff


On May 23, 2016, 4:37 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47515/
> ---
> 
> (Updated May 23, 2016, 4:37 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enforces the constraint that the principal
> found in `DiskInfo.Persistence` should equal that of
> the framework or operator responsible for creating
> the volume.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
>   src/master/master.cpp 0c05938de3e4eaeea2187559e81559f85318fa73 
>   src/master/validation.hpp f29f9753c75e5abc3402ed23381edcea26517ab3 
>   src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 
> 
> Diff: https://reviews.apache.org/r/47515/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47516: Added creator principal to tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47516/#review135086
---




src/tests/disk_quota_tests.cpp (line 32)


add stout/try.hpp


- Greg Mann


On May 18, 2016, 8:06 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47516/
> ---
> 
> (Updated May 18, 2016, 8:06 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a creator principal to the persistent
> volumes used in various tests.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> f43165388f29513ab8be6594ab6647e8f9eb5a93 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 4293416ac8434e9eb7e80724480a54936a2fe24a 
>   src/tests/disk_quota_tests.cpp 1564f70854ff5630da1d7348a034f726d67b1757 
>   src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
>   src/tests/role_tests.cpp 24959d6e0f83ef7b62b0586be18661aa3cac91dd 
> 
> Diff: https://reviews.apache.org/r/47516/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47521: Added creator principal to '/create-volumes' tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47521/#review135079
---




src/tests/persistent_volume_endpoints_tests.cpp (line 32)


add stout/none.hpp



src/tests/persistent_volume_endpoints_tests.cpp (line 1596)


perhaps use a variable for the principal in a subsequent patch?


- Greg Mann


On May 18, 2016, 8:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47521/
> ---
> 
> (Updated May 18, 2016, 8:05 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A creator principal is added to the persistent volumes
> used in the PersistentVolumeEndpointsTests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> a57461d881b2bf0175f83b50b0a46167acd5bd3e 
> 
> Diff: https://reviews.apache.org/r/47521/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47520: Updated test helpers with creator principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47520/#review135078
---




src/tests/mesos.hpp (line 522)


s/creatorPrincipal/principal/


- Greg Mann


On May 18, 2016, 8:04 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47520/
> ---
> 
> (Updated May 18, 2016, 8:04 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the `createPersistentVolume` and
> `createDiskInfo` test helper functions to accept an
> argument specifying the creator principal to be included
> in `DiskInfo.Persistence`.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
> 
> Diff: https://reviews.apache.org/r/47520/diff/
> 
> 
> Testing
> ---
> 
> `make check` was done on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47528: Updated validation tests with creator principal.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47528/#review135077
---




src/tests/master_validation_tests.cpp (line 36)


add stout/none.hpp


- Greg Mann


On May 25, 2016, 6:08 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47528/
> ---
> 
> (Updated May 25, 2016, 6:08 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The master validation tests are updated to include the
> new `validate()` signature, and a new test is added,
> `CreateOperationValidationTest.NonMatchingPrincipal`,
> to ensure that a non-matching creator principal will
> be invalidated.
> 
> 
> Diffs
> -
> 
>   src/tests/master_validation_tests.cpp 
> ca4442aa1ef0087a7d058d1b3aa430a1dbc16960 
> 
> Diff: https://reviews.apache.org/r/47528/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47906: Added/updated documentation for --modules and --modules_dir flags.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47906/#review135075
---



Patch looks great!

Reviews applied: [47123, 47905, 47906]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On May 26, 2016, 5:04 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47906/
> ---
> 
> (Updated May 26, 2016, 5:04 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/modules.md cf80e1cd0eb86a2652bb99884989ecffdbba4778 
> 
> Diff: https://reviews.apache.org/r/47906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47515/#review135064
---




src/master/master.cpp (line 3742)


What about just `None()` here?



src/master/validation.cpp (line 823)


Drop the "A" at the beginning?



src/master/validation.cpp (line 824)


s/request/operation/

and below



src/master/validation.cpp (line 825)


Either remove backticks or replace with single quotes?


- Greg Mann


On May 23, 2016, 4:37 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47515/
> ---
> 
> (Updated May 23, 2016, 4:37 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
> https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enforces the constraint that the principal
> found in `DiskInfo.Persistence` should equal that of
> the framework or operator responsible for creating
> the volume.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
>   src/master/master.cpp 0c05938de3e4eaeea2187559e81559f85318fa73 
>   src/master/validation.hpp f29f9753c75e5abc3402ed23381edcea26517ab3 
>   src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 
> 
> Diff: https://reviews.apache.org/r/47515/diff/
> 
> 
> Testing
> ---
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47667: Added stout functions to get and set supplementary groud ids.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47667/
---

(Updated May 26, 2016, 1:55 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, 
and Timothy Chen.


Repository: mesos


Description
---

Added stout functions to get and set supplementary groud ids.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/posix/su.hpp 
43e91d6baca9b5e0bb7d6661c4d8002b07d22452 

Diff: https://reviews.apache.org/r/47667/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 47661: Improved the mesos containerizer windows related logic.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47661/
---

(Updated May 26, 2016, 1:55 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, 
and Timothy Chen.


Repository: mesos


Description
---

Improved the mesos containerizer windows related logic.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
75e5a32a3e70ec60a6800e21a621673184ea0956 

Diff: https://reviews.apache.org/r/47661/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 47665: Passed image user to mesos containerizer launch.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47665/
---

(Updated May 26, 2016, 1:55 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, 
and Timothy Chen.


Repository: mesos


Description
---

Passed image user to mesos containerizer launch.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
75e5a32a3e70ec60a6800e21a621673184ea0956 
  src/slave/containerizer/mesos/launch.hpp 
c716e0396736d1f2f60ec31540f12f4f7597d081 
  src/slave/containerizer/mesos/launch.cpp 
e22106b014c871e2184a15c2ab154a0674874e47 

Diff: https://reviews.apache.org/r/47665/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 47663: Added image user to 'ContainerLaunchInfo'.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47663/
---

(Updated May 26, 2016, 1:55 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, 
and Timothy Chen.


Repository: mesos


Description
---

Added image user to 'ContainerLaunchInfo'.


Diffs (updated)
-

  include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 

Diff: https://reviews.apache.org/r/47663/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 47666: Added stout functions to set uid and gid.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47666/
---

(Updated May 26, 2016, 1:55 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, 
and Timothy Chen.


Repository: mesos


Description
---

Added stout functions to set uid and gid.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/posix/su.hpp 
43e91d6baca9b5e0bb7d6661c4d8002b07d22452 

Diff: https://reviews.apache.org/r/47666/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 47664: Implemented image user support in docker runtime isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47664/
---

(Updated May 26, 2016, 1:55 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, 
and Timothy Chen.


Repository: mesos


Description
---

Implemented image user support in docker runtime isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/runtime.hpp 
272636fcf12c865b31a11364f23d7aee9c6225db 
  src/slave/containerizer/mesos/isolators/docker/runtime.cpp 
eb2790d44ee08c81d31fbe28e7a8ffe88edba870 

Diff: https://reviews.apache.org/r/47664/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 47662: Added image user to command executor.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47662/
---

(Updated May 26, 2016, 1:55 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, 
and Timothy Chen.


Repository: mesos


Description
---

Added image user to command executor.


Diffs (updated)
-

  src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 

Diff: https://reviews.apache.org/r/47662/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 47668: Obtained uid/gids before changing filesystem root.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47668/
---

(Updated May 26, 2016, 1:55 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, 
and Timothy Chen.


Repository: mesos


Description
---

Obtained uid/gids before changing filesystem root.


Diffs (updated)
-

  src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 
  src/slave/containerizer/mesos/launch.cpp 
e22106b014c871e2184a15c2ab154a0674874e47 

Diff: https://reviews.apache.org/r/47668/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 47704: Used Tasked ObjectAllower to filter /state endpoint.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47704/
---

(Updated May 26, 2016, 8:42 p.m.)


Review request for mesos and Michael Park.


Repository: mesos


Description
---

Used Tasked ObjectAllower to filter /state endpoint.


Diffs (updated)
-

  src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 

Diff: https://reviews.apache.org/r/47704/diff/


Testing
---

Make check (OSX)


Thanks,

Joerg Schad

Re: Review Request 47559: Added authorization based filtering to /state-summary.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47559/
---

(Updated May 26, 2016, 8:39 p.m.)


Review request for mesos, Adam B and Michael Park.


Bugs: MESOS-5170
https://issues.apache.org/jira/browse/MESOS-5170


Repository: mesos


Description
---

Added authorization based filtering to /state-summary.


Diffs (updated)
-

  src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 

Diff: https://reviews.apache.org/r/47559/diff/


Testing
---

make check + (sudo) make check on various linux systems


Thanks,

Joerg Schad

Re: Review Request 47558: Added ObjectAllower interface to authorizer.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/
---

(Updated May 26, 2016, 8:38 p.m.)


Review request for mesos, Adam B and Michael Park.


Bugs: MESOS-5403
https://issues.apache.org/jira/browse/MESOS-5403


Repository: mesos


Description (updated)
---

With to goal to provide more efficient authorization
for multiple, potentially large objects we extend the
authorizer interface to support `ObjectAllower`.
Retrieving an ObjectAllower for a given action is an
asynchronous operation but following authorization
of multiple objects can be done synchronously without
copying the object.
NOTE: This implies that Authorizer Module writers
need to ensure an ObjectAllower will behave nicely
and especially not block.


Diffs (updated)
-

  include/mesos/authorizer/authorizer.hpp 
ed5f9e73661e25a83722cf1e408ae61023cd4a21 
  src/authorizer/local/authorizer.hpp 61388454025211fd7d53e71a86983fd8479950b6 
  src/authorizer/local/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b 
  src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
  src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
  src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e 

Diff: https://reviews.apache.org/r/47558/diff/


Testing
---

tested entire chain.


Thanks,

Joerg Schad

Re: Review Request 45377: Made "driver" as optional for DockerVolume.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45377/
---

(Updated May 26, 2016, 8:33 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5354
https://issues.apache.org/jira/browse/MESOS-5354


Repository: mesos


Description
---

Made "driver" as optional for DockerVolume.


Diffs (updated)
-

  include/mesos/mesos.proto cddfa250e3155966eee4c761e164a5749dd7fc33 
  include/mesos/v1/mesos.proto ce187e71003f82852a8addadfdbc7c6f82dfaa2b 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
8ab2cf39a6bc3dd841b51639942b3e5258b7292e 

Diff: https://reviews.apache.org/r/45377/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47360/#review135053
---



Patch looks great!

Reviews applied: [47359, 47360]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On May 26, 2016, 5:02 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47360/
> ---
> 
> (Updated May 26, 2016, 5:02 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Neil Conway.
> 
> 
> Bugs: MESOS-5215
> https://issues.apache.org/jira/browse/MESOS-5215
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch updates the documentation of RESERVE and
> CREATE operations, both via offer operations and
> operator endpoints. Specifically, we clarify the
> Mesos master's expectations for the values of the
> `principal` fields found in `ReservationInfo` and
> `DiskInfo.Persistence`.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md c13d79124f0b5ea2a715b4d2990fda4e06b2fb02 
>   docs/reservation.md a400d19aec7a48d122ba1c9c23d38d792b8dbe6f 
> 
> Diff: https://reviews.apache.org/r/47360/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47901: Clean up the code style of website css.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47901/#review135048
---


Ship it!




Ship It!

- Tomasz Janiszewski


On Maj 26, 2016, 5:06 po południu, haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47901/
> ---
> 
> (Updated Maj 26, 2016, 5:06 po południu)
> 
> 
> Review request for mesos, Tomasz Janiszewski and Vinod Kone.
> 
> 
> Bugs: MESOS-5424
> https://issues.apache.org/jira/browse/MESOS-5424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clean up the code style of website css.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 685957218f59e377c4ca1ee5c7f3f4001371dd74 
> 
> Diff: https://reviews.apache.org/r/47901/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47903: Removed the unnecessary space in middleman config.rb.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47903/#review135045
---




site/config.rb (line 39)


I'm not sure if this change improve anything. Personally I prefer to fix 
minor typos like this when there are other changes in file.


- Tomasz Janiszewski


On Maj 26, 2016, 5:06 po południu, haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47903/
> ---
> 
> (Updated Maj 26, 2016, 5:06 po południu)
> 
> 
> Review request for mesos, Tomasz Janiszewski and Vinod Kone.
> 
> 
> Bugs: MESOS-5424
> https://issues.apache.org/jira/browse/MESOS-5424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the unnecessary space in middleman config.rb.
> 
> 
> Diffs
> -
> 
>   site/config.rb 89179f9eaad1d972b082997afba5ad6102466829 
> 
> Diff: https://reviews.apache.org/r/47903/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47903: Removed the unnecessary space in middleman config.rb.

[Tomasz Janiszewski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47903/#review135043
---


Ship it!




Ship It!

- Tomasz Janiszewski


On Maj 26, 2016, 5:06 po południu, haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47903/
> ---
> 
> (Updated Maj 26, 2016, 5:06 po południu)
> 
> 
> Review request for mesos, Tomasz Janiszewski and Vinod Kone.
> 
> 
> Bugs: MESOS-5424
> https://issues.apache.org/jira/browse/MESOS-5424
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the unnecessary space in middleman config.rb.
> 
> 
> Diffs
> -
> 
>   site/config.rb 89179f9eaad1d972b082997afba5ad6102466829 
> 
> Diff: https://reviews.apache.org/r/47903/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 47892: Re-ordered initialization for Agent `Anonymous` modules.

[Kapil Arya]

> On May 26, 2016, 11:52 a.m., Kapil Arya wrote:
> > src/slave/main.cpp, lines 309-323
> > 
> >
> > I am wondering if we should move it right next to the 
> > `ModuleManager::load()` call above. Is there a reason for not doing so?
> 
> Avinash sridharan wrote:
> We wanted to initialize the `Anonymous` module only after the Firewall is 
> initialized. Reason being that the module might also expoe endpoints that 
> need to be fiewalled ?

Okay, that a reasonable dependency. Can you please document it in the comments 
around the code? In any case, can we initialize firewall *before* initializing 
ModuleManager? That way, we can keep ModuleManager/AnonModules close together.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47892/#review134994
---


On May 26, 2016, 10:38 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47892/
> ---
> 
> (Updated May 26, 2016, 10:38 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Kapil Arya.
> 
> 
> Bugs: MESOS-5452
> https://issues.apache.org/jira/browse/MESOS-5452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Re-ordered initialization for Agent `Anonymous` modules.
> 
> We are initializing the Anonymous modules right after the `Firewall` since 
> Anonymous modules might have endpoints on which firewall rules might need to 
> be enforced.
> 
> 
> Diffs
> -
> 
>   src/slave/main.cpp ecaa7826798e43244e69315cf0a64e486054cafb 
> 
> Diff: https://reviews.apache.org/r/47892/diff/
> 
> 
> Testing
> ---
> 
> make check
> sudo ./build/bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>