Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179215
---




src/master/http.cpp
Line 3840 (original), 3845 (patched)


update the comment.



src/master/http.cpp
Line 3853 (original), 3860 (patched)


ditto.



src/master/http.cpp
Line 3862 (original), 3872 (patched)


ditto.



src/master/http.cpp
Line 3871 (original), 3882 (patched)


ditto.



src/tests/master_tests.cpp
Lines 3510 (patched)


is the order not determinisitc in our tests?



src/tests/master_tests.cpp
Lines 3576 (patched)


hmm. why is framework id present here but not above?


- Vinod Kone


On June 29, 2017, 12:47 a.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> ---
> 
> (Updated June 29, 2017, 12:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering to the '/tasks' endpoint.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
>   src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 
> 
> 
> Diff: https://reviews.apache.org/r/60107/diff/9/
> 
> 
> Testing
> ---
> 
> Passed "make check"
> Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
> Passed "GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 
> --gtest_break_on_failure"
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179212
---


Fix it, then Ship it!





src/common/http.hpp
Lines 218 (patched)


s/Filter/Filters/

s/framework ID, when/framework ID. When/



src/common/http.hpp
Lines 233 (patched)


s/Filter/Filters/

s/task ID, when/task ID. When/


- Greg Mann


On June 29, 2017, 12:47 a.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> ---
> 
> (Updated June 29, 2017, 12:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering to the '/tasks' endpoint.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
>   src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 
> 
> 
> Diff: https://reviews.apache.org/r/60107/diff/9/
> 
> 
> Testing
> ---
> 
> Passed "make check"
> Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
> Passed "GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 
> --gtest_break_on_failure"
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Quinn Leng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/
---

(Updated June 29, 2017, 12:47 a.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod 
Kone.


Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description
---

Added filtering to the '/tasks' endpoint.


Diffs (updated)
-

  src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
  src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
  src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
  src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 


Diff: https://reviews.apache.org/r/60107/diff/9/

Changes: https://reviews.apache.org/r/60107/diff/8-9/


Testing
---

Passed "make check"
Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" 
--gtest_repeat=1000 --gtest_break_on_failure"


Thanks,

Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Quinn Leng]

> On June 28, 2017, 11:31 p.m., Greg Mann wrote:
> > src/tests/master_tests.cpp
> > Lines 3545-3547 (patched)
> > 
> >
> > We want to assert that both of these tasks are there. Should do
> > 
> > ```
> > ASSERT_TRUE(value->contains(expected1.get()));
> > ASSERT_TRUE(value->contains(expected2.get()));
> > ```

In this case, expected1 and expected2 are not two tasks, they are two possible 
ordering of tasks, each of them contains two tasks, you can see that from the 
content they contain


> On June 28, 2017, 11:31 p.m., Greg Mann wrote:
> > src/tests/master_tests.cpp
> > Lines 3569-3571 (patched)
> > 
> >
> > You already assert that `taskArray.isSome()` above, so no need for this 
> > conditional.
> > 
> > Also, you can use the `->` operator:
> > 
> > ```
> > EXPECT_TRUE(taskArray->values.size() == 1);
> > ```

taskArray.isSome() is to avoid it's null, but the EXPECT_TRUE check it's size 
is 1, does that make sense?


- Quinn


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179195
---


On June 29, 2017, 12:39 a.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> ---
> 
> (Updated June 29, 2017, 12:39 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering to the '/tasks' endpoint.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
>   src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 
> 
> 
> Diff: https://reviews.apache.org/r/60107/diff/8/
> 
> 
> Testing
> ---
> 
> Passed "make check"
> Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
> Passed "GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 
> --gtest_break_on_failure"
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Quinn Leng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/
---

(Updated June 29, 2017, 12:39 a.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod 
Kone.


Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description
---

Added filtering to the '/tasks' endpoint.


Diffs (updated)
-

  src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
  src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
  src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
  src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 


Diff: https://reviews.apache.org/r/60107/diff/8/

Changes: https://reviews.apache.org/r/60107/diff/7-8/


Testing
---

Passed "make check"
Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" 
--gtest_repeat=1000 --gtest_break_on_failure"


Thanks,

Quinn Leng

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179195
---




src/common/http.hpp
Lines 165 (patched)


s/criterias/criteria/



src/common/http.hpp
Lines 166 (patched)


newline before "*/"



src/common/http.hpp
Lines 216-217 (patched)


Let's add a comment here that the default behavior of this acceptor when no 
ID is specified is to accept all inputs. For the TaskIDAcceptor as well.



src/common/http.hpp
Lines 220-227 (patched)


Could you move the constructor definition into the implementation file? 
Also for the `TaskIDAcceptor`.



src/common/http.cpp
Lines 1136-1137 (patched)


Indented too far.



src/common/http.cpp
Lines 1141 (patched)


Indented too far.



src/common/http.cpp
Lines 1154 (patched)


Newline in between the function arguments



src/common/http.cpp
Lines 1158-1159 (patched)


Indented too far.



src/common/http.cpp
Lines 1184 (patched)


You can eliminate these comments.



src/common/http.cpp
Lines 1192 (patched)


Newline after `(`



src/master/http.cpp
Lines 3817-3877 (original), 3811-3887 (patched)


Could you update this section to match the indentation we were discussing?



src/master/http.cpp
Lines 3822-3823 (original), 3820-3821 (patched)


These would fit together on one line.



src/master/http.cpp
Line 3823 (original), 3821 (patched)


Space before `{`



src/master/http.cpp
Lines 3826-3830 (patched)


Since the identation is aligned, you don't need the newline after `(`:

```
  tie(authorizeFrameworkInfo,
  authorizeTask,
  selectFrameworkId,
  selectTaskId) = acceptors;
```



src/tests/master_tests.cpp
Lines 3440 (patched)


Indented too far.



src/tests/master_tests.cpp
Lines 3495 (patched)


"the '/master/tasks' endpoint"



src/tests/master_tests.cpp
Lines 3525-3526 (patched)


Newline here



src/tests/master_tests.cpp
Lines 3545-3547 (patched)


We want to assert that both of these tasks are there. Should do

```
ASSERT_TRUE(value->contains(expected1.get()));
ASSERT_TRUE(value->contains(expected2.get()));
```



src/tests/master_tests.cpp
Lines 3550 (patched)


Period at the end of the comment.



src/tests/master_tests.cpp
Lines 3554 (patched)


Can use the `->` operator:

```
frameworkId->value()
```



src/tests/master_tests.cpp
Lines 3564 (patched)


Let's use the name `object` instead of abbreviating `obj`.



src/tests/master_tests.cpp
Lines 3568 (patched)


Can eliminate this comment, since the code is clear enough.



src/tests/master_tests.cpp
Lines 3569-3571 (patched)


You already assert that `taskArray.isSome()` above, so no need for this 
conditional.

Also, you can use the `->` operator:

```
EXPECT_TRUE(taskArray->values.size() == 1);
```


- Greg Mann


On June 28, 2017, 10:05 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> ---
> 
> (Updated June 28, 2017, 10:05 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering to the '/tasks' endpoint.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
>   src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
>   

Review Request 60525: Fixed the default filter used by the allocator.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60525/
---

Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and 
Vinod Kone.


Bugs: MESOS-7660
https://issues.apache.org/jira/browse/MESOS-7660


Repository: mesos


Description
---

If a framework accepts/refuses an offer using a very long filter, the
`HierarchicalAllocator` will use the default filter instead. Meaning
that it will filter the resources for only 5 seconds. This can happen
when a framework sets `Filter::refuse_seconds` to a number of seconds
larger than what fits in `Duration`.

This patch makes the allocator use the largest possible filter duration
in this case.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
eb01d8e6b1108866ebc049f9f4a46157823a3541 


Diff: https://reviews.apache.org/r/60525/diff/1/


Testing
---

`make check`


Thanks,

Gastón Kleiman

Review Request 60524: Stout: Made the `Duration` operators handle int overflows explicitly.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60524/
---

Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and 
Vinod Kone.


Bugs: MESOS-7661
https://issues.apache.org/jira/browse/MESOS-7661


Repository: mesos


Description
---

Made the `Duration` arithmetic operators return `Duration::max()` if the
operation would result in an integer overflow, and `Duration::min()` if
it would result in an underflow.


Diffs
-

  3rdparty/stout/include/stout/duration.hpp 
b0cd77b833f6fbf752b4db820fd43b87e1d1e476 
  3rdparty/stout/tests/duration_tests.cpp 
59b08f14849a8db31f11fbd0b2e1248c99afd9dd 


Diff: https://reviews.apache.org/r/60524/diff/1/


Testing
---

Added new Stout tests and confirmed that the Mesos test suite still passes.


Thanks,

Gastón Kleiman

Review Request 60520: Remove posix/subprocess.hpp dependencies.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60520/
---

Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jiang Yan 
Xu.


Repository: mesos


Description
---

Fix a number of places where we were depending on symbols made
visible by . In most cases, this is
just tweaking the includes, but in the Checker we just duplicate
the trivial fork(2) helper since that is easer than trying to
export it as a libprocess API.


Diffs
-

  docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3 
  src/checks/checker_process.cpp 66f5452bb5f9c7f45819c221be7b098e5999b7a7 
  src/slave/containerizer/mesos/isolators/volume/image.cpp 
c89af3e0a16f769c45f2846d1e76baedb8248d4d 
  src/uri/fetchers/docker.cpp 7f3e4e73d1dc5d15f875e2890acbe5369fb59d78 


Diff: https://reviews.apache.org/r/60520/diff/1/


Testing
---

make check (Fedora 26).


Thanks,

James Peach

Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/#review179197
---



Bad patch!

Reviews applied: [60511, 56722, 60471, 56721, 59705, 55727, 59687, 55335, 55334]

Failed command: python support/apply-reviews.py -n -r 55334

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in 
main()
  File "support/apply-reviews.py", line 412, in main
reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
fetch_patch(options)
  File "support/apply-reviews.py", line 194, in fetch_patch
patch.write(patch.read())
IOError: File not open for reading

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/124/console

- Mesos Reviewbot Windows


On June 28, 2017, 6:48 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60511/
> ---
> 
> (Updated June 28, 2017, 6:48 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added MockMetadataManager and test concurrent prune and pull.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 
> 954da1681778878c8aff6150002e52ecb648d1bb 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> d86afd2a6ff0bf87e624db1c99255c85068bf6ab 
>   src/slave/containerizer/mesos/provisioner/docker/store.hpp 
> 1cf68665d33bd40a7605d26c96fb7b618407fdd0 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 8058dcb31b9de59fa8d3638b553632235542 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 920be77b16178a4458d72145020c015130799ec4 
> 
> 
> Diff: https://reviews.apache.org/r/60511/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179192
---



Bad patch!

Reviews applied: [60107]

Failed command: python support/apply-reviews.py -n -r 60107

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in 
main()
  File "support/apply-reviews.py", line 412, in main
reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
fetch_patch(options)
  File "support/apply-reviews.py", line 194, in fetch_patch
patch.write(patch.read())
IOError: File not open for reading

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/124/console

- Mesos Reviewbot Windows


On June 28, 2017, 10:05 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> ---
> 
> (Updated June 28, 2017, 10:05 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering to the '/tasks' endpoint.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
>   src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 
> 
> 
> Diff: https://reviews.apache.org/r/60107/diff/7/
> 
> 
> Testing
> ---
> 
> Passed "make check"
> Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
> Passed "GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 
> --gtest_break_on_failure"
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review179189
---



Bad patch!

Reviews applied: [60370, 60369]

Failed command: python support/apply-reviews.py -n -r 60369

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in 
main()
  File "support/apply-reviews.py", line 412, in main
reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
fetch_patch(options)
  File "support/apply-reviews.py", line 194, in fetch_patch
patch.write(patch.read())
IOError: File not open for reading

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/124/console

- Mesos Reviewbot Windows


On June 28, 2017, 4:52 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60370/
> ---
> 
> (Updated June 28, 2017, 4:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated agent webui page to display allocated resources per each role.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
>   src/webui/master/static/js/controllers.js 
> 67bfd030649dd21840c16188a4964f814aa232d7 
> 
> 
> Diff: https://reviews.apache.org/r/60370/diff/3/
> 
> 
> Testing
> ---
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> agent.html
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
> ui_bug
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/1b7755e3-0b11-46ab-9ae4-71f19bce0cd6__ui_bug.png
> ui_bug2
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/b89990c9-9aa5-432a-a0da-3f90c9428127__ui_bug2.png
> ui_bug3
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/51553e9d-7fb9-40c0-b47c-b62fc6c37393__ui_bug3.png
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Quinn Leng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/
---

(Updated June 28, 2017, 10:05 p.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod 
Kone.


Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description
---

Added filtering to the '/tasks' endpoint.


Diffs (updated)
-

  src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
  src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
  src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
  src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 


Diff: https://reviews.apache.org/r/60107/diff/7/

Changes: https://reviews.apache.org/r/60107/diff/6-7/


Testing
---

Passed "make check"
Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" 
--gtest_repeat=1000 --gtest_break_on_failure"


Thanks,

Quinn Leng

Re: Review Request 60496: WIP: Add socket checking to the network ports isolator.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60496/#review179187
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot Windows


On June 28, 2017, 7:46 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60496/
> ---
> 
> (Updated June 28, 2017, 7:46 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implement ports resource restrictions in the network ports isolator.
> Periodically, scan for listening sockets and match them up to all
> the open sockets in the containers we are tracking in the network.
> Check any sockets we find against the ports resource and trigger a
> resource limitation if the port has not been allocated.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION 
>   src/tests/containerizer/network_ports_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60496/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179184
---




src/common/http.hpp
Lines 40-42 (patched)


We always fully qualify all namespaces in headers (i.e., no `using` 
statements). It will make some of the lines really long, but that's OK.


- Greg Mann


On June 28, 2017, 9:38 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> ---
> 
> (Updated June 28, 2017, 9:38 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added filtering to the '/tasks' endpoint.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
>   src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 
> 
> 
> Diff: https://reviews.apache.org/r/60107/diff/6/
> 
> 
> Testing
> ---
> 
> Passed "make check"
> Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
> Passed "GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 
> --gtest_break_on_failure"
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58394/#review179185
---



Bad patch!

Reviews applied: [58394]

Failed command: python support/apply-reviews.py -n -r 58394

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in 
main()
  File "support/apply-reviews.py", line 412, in main
reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
fetch_patch(options)
  File "support/apply-reviews.py", line 194, in fetch_patch
patch.write(patch.read())
IOError: File not open for reading

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/124/console

- Mesos Reviewbot Windows


On June 28, 2017, 6:56 p.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58394/
> ---
> 
> (Updated June 28, 2017, 6:56 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, Joseph Wu, and Kevin 
> Klues.
> 
> 
> Bugs: MESOS-7310
> https://issues.apache.org/jira/browse/MESOS-7310
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/58394
> 
> 
> Diffs
> -
> 
>   src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443 
>   src/python/.gitignore PRE-CREATION 
>   src/python/lib/mesos/__init__.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58394/diff/3/
> 
> 
> Testing
> ---
> 
> Under src/cli_new:
> 1\. ./bootstrap
> 2\. . ./activate
> 3\. python
> 4\. >>> import mesos
> 5\. >>> mesos.\_\_path\_\_
> 6\. verify that the path printed out is indeed at src/python/lib/mesos
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/#review179182
---



Bad patch!

Reviews applied: [60511, 56722, 60471, 56721, 59705, 55727, 59687, 55335, 55334]

Failed command: python support/apply-reviews.py -n -r 55334

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in 
main()
  File "support/apply-reviews.py", line 412, in main
reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
fetch_patch(options)
  File "support/apply-reviews.py", line 194, in fetch_patch
patch.write(patch.read())
IOError: File not open for reading

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/124/console

- Mesos Reviewbot Windows


On June 28, 2017, 6:48 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60511/
> ---
> 
> (Updated June 28, 2017, 6:48 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added MockMetadataManager and test concurrent prune and pull.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 
> 954da1681778878c8aff6150002e52ecb648d1bb 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> d86afd2a6ff0bf87e624db1c99255c85068bf6ab 
>   src/slave/containerizer/mesos/provisioner/docker/store.hpp 
> 1cf68665d33bd40a7605d26c96fb7b618407fdd0 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 8058dcb31b9de59fa8d3638b553632235542 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 920be77b16178a4458d72145020c015130799ec4 
> 
> 
> Diff: https://reviews.apache.org/r/60511/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 60008: Fixed bug causing FUTURE_DISPATCH to react on irrelevant dispatch.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60008/
---

(Updated June 28, 2017, 9:44 p.m.)


Review request for mesos, Alexander Rukletsov, Michael Park, and Neil Conway.


Bugs: MESOS-5886
https://issues.apache.org/jira/browse/MESOS-5886


Repository: mesos


Description
---

FUTURE_DISPATCH uses DispatchMatcher to figure out whether a processed
DispatchEvent is the same the user is waiting for. Currently, we
compare std::type_info of function pointers, which is not enough:
different class methods with same signatures will be matched (see
MESOS-5886 for an example).
This patch adds value of pointer-to-member function in addition to
std::type_info in DispatchEvent to uniquely identify class methods.


Diffs
-

  3rdparty/libprocess/include/process/dispatch.hpp 
3a0793888dc0df5e3ec31b06f47cd920c71e0db9 
  3rdparty/libprocess/include/process/event.hpp 
8afe6266eb0dc5a17af35d79efb6bfdf9e6a0ee9 
  3rdparty/libprocess/include/process/gmock.hpp 
e9af943b39436f365fe687301febb5c7fbefffc4 
  3rdparty/libprocess/src/process.cpp 8ff37d1b5781c42f96be2da391ed000158eea7b8 
  3rdparty/libprocess/src/tests/process_tests.cpp 
38d787a083a5eb31e922d283f4b4bed2bd62eb0a 


Diff: https://reviews.apache.org/r/60008/diff/2/


Testing (updated)
---

1. make check (mac os x 10.12, fedora 25)
2. internal CI


Thanks,

Andrei Budnik

Re: Review Request 60508: Fixed Attributes comparison.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60508/#review179181
---



Bad patch!

Reviews applied: [60508]

Failed command: python support/apply-reviews.py -n -r 60508

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in 
main()
  File "support/apply-reviews.py", line 412, in main
reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
fetch_patch(options)
  File "support/apply-reviews.py", line 194, in fetch_patch
patch.write(patch.read())
IOError: File not open for reading

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/124/console

- Mesos Reviewbot Windows


On June 28, 2017, 5:36 p.m., Ilya Pronin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60508/
> ---
> 
> (Updated June 28, 2017, 5:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1216
> https://issues.apache.org/jira/browse/MESOS-1216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently we don't enforce attribute name uniqueness. But the comparison
> operator for `Attributes` expects that attribute name and type are
> unique. This causes causes agent recovery failure.
> 
> This fixes the issue by allowing multiple attributes of same name and
> type.
> 
> 
> Diffs
> -
> 
>   include/mesos/attributes.hpp 641febbd3bc3700b2c088f4388d8e6f18e6b078a 
>   include/mesos/v1/attributes.hpp 022bfde430c618708843a4d790f3f8a118ae082b 
>   src/common/attributes.cpp ac683c7fe5b67fb8a73599230a3eb47911293a7e 
>   src/tests/attributes_tests.cpp cb71be5ecead322d90943146f54f8a0c915eba1c 
>   src/v1/attributes.cpp 409d66453c492a329adc4e16312924e21a6d4709 
> 
> 
> Diff: https://reviews.apache.org/r/60508/diff/1/
> 
> 
> Testing
> ---
> 
> Added a test to `AttributesTest.Equality`. Ran `make check`. Verified 
> manually by failing over the agent with multiple attributes with the same 
> name.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

[Quinn Leng]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/
---

(Updated June 28, 2017, 9:38 p.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod 
Kone.


Summary (updated)
-

Added filtering to the '/tasks' endpoint.


Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description (updated)
---

Added filtering to the '/tasks' endpoint.


Diffs (updated)
-

  src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
  src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
  src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
  src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 


Diff: https://reviews.apache.org/r/60107/diff/6/

Changes: https://reviews.apache.org/r/60107/diff/5-6/


Testing
---

Passed "make check"
Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" 
--gtest_repeat=1000 --gtest_break_on_failure"


Thanks,

Quinn Leng

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60500/#review179178
---



Bad patch!

Reviews applied: [60500]

Failed command: python support/apply-reviews.py -n -r 60500

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in 
main()
  File "support/apply-reviews.py", line 412, in main
reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
fetch_patch(options)
  File "support/apply-reviews.py", line 194, in fetch_patch
patch.write(patch.read())
IOError: File not open for reading

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/124/console

- Mesos Reviewbot Windows


On June 28, 2017, 2:57 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60500/
> ---
> 
> (Updated June 28, 2017, 2:57 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-7709
> https://issues.apache.org/jira/browse/MESOS-7709
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced `--default_container_dns` agent flag.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 0eb696a949003ff11831aed5e4f4ab384cf9992e 
>   src/messages/flags.hpp 70ad58c33067a0b058deafdcc4ffc5f554b6ca72 
>   src/messages/flags.proto e87075f19714739b93d9f4aa33ea8686a1bb5613 
>   src/slave/flags.hpp e75c1b4227b443aedf445921b3f2108d930c112c 
>   src/slave/flags.cpp c84aa6724170bba46bbe8410b71d42a1626e 
> 
> 
> Diff: https://reviews.apache.org/r/60500/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 60107: Finished object acceptor for tasks endpoint.

[Quinn Leng]

> On June 28, 2017, 7:05 p.m., Greg Mann wrote:
> > src/common/http.hpp
> > Lines 205-218 (patched)
> > 
> >
> > It doesn't look like this class is used at all in this patch, can we 
> > remove it?

I am creating AuthorizeAcceptors according to these functions 
"approveViewXXX()", it seems that the TaskInfo function is not used in the 
endpoint handler. I'll remvoe it.


> On June 28, 2017, 7:05 p.m., Greg Mann wrote:
> > src/common/http.hpp
> > Lines 228-229 (patched)
> > 
> >
> > Should break after parentheses:
> > 
> > ```
> > bool accept(
> > const Task& task,
> > ```

Even if there are only two parameters?


- Quinn


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179132
---


On June 27, 2017, 10:30 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60107/
> ---
> 
> (Updated June 27, 2017, 10:30 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Finished object acceptor for "/tasks" endpoint.
> 
> Added the query parameter support for that endpoint.
> To query a task, you have to specify both framework_id
> and task_id. Thus the query would look like
> "/tasks?framework_id=[framework id];task_id=[task id]"
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
>   src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 
> 
> 
> Diff: https://reviews.apache.org/r/60107/diff/5/
> 
> 
> Testing
> ---
> 
> Passed "make check"
> Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
> Passed "GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="MasterTest.TasksEndpoint" --gtest_repeat=1000 
> --gtest_break_on_failure"
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60008: Fixed bug causing FUTURE_DISPATCH to react on irrelevant dispatch.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60008/#review179176
---



Bad patch!

Reviews applied: [60008]

Failed command: python support/apply-reviews.py -n -r 60008

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in 
main()
  File "support/apply-reviews.py", line 412, in main
reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
fetch_patch(options)
  File "support/apply-reviews.py", line 194, in fetch_patch
patch.write(patch.read())
IOError: File not open for reading

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/124/console

- Mesos Reviewbot Windows


On June 28, 2017, 2:56 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60008/
> ---
> 
> (Updated June 28, 2017, 2:56 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-5886
> https://issues.apache.org/jira/browse/MESOS-5886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> FUTURE_DISPATCH uses DispatchMatcher to figure out whether a processed
> DispatchEvent is the same the user is waiting for. Currently, we
> compare std::type_info of function pointers, which is not enough:
> different class methods with same signatures will be matched (see
> MESOS-5886 for an example).
> This patch adds value of pointer-to-member function in addition to
> std::type_info in DispatchEvent to uniquely identify class methods.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/dispatch.hpp 
> 3a0793888dc0df5e3ec31b06f47cd920c71e0db9 
>   3rdparty/libprocess/include/process/event.hpp 
> 8afe6266eb0dc5a17af35d79efb6bfdf9e6a0ee9 
>   3rdparty/libprocess/include/process/gmock.hpp 
> e9af943b39436f365fe687301febb5c7fbefffc4 
>   3rdparty/libprocess/src/process.cpp 
> 8ff37d1b5781c42f96be2da391ed000158eea7b8 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 38d787a083a5eb31e922d283f4b4bed2bd62eb0a 
> 
> 
> Diff: https://reviews.apache.org/r/60008/diff/2/
> 
> 
> Testing
> ---
> 
> 1. make check (mac os x 10.12, fedora 25)
> 2. internal CI
> 
> NOTE: Test GroupTest.ConnectTimer is broken, because it uses FUTURE_DISPATCH 
> on a wrong method (GroupProcess::expired),
> which has the same signature as a private method (GroupProcess::timedout). 
> The later method is actually called,
> thus causing the error after applying this patch.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60497: Update mesos-execute capabilities options.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60497/#review179175
---



Bad patch!

Reviews applied: [60497, 60414, 60413, 60412, 60411, 60410, 60409]

Failed command: python support/apply-reviews.py -n -r 60409

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in 
main()
  File "support/apply-reviews.py", line 412, in main
reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
fetch_patch(options)
  File "support/apply-reviews.py", line 194, in fetch_patch
patch.write(patch.read())
IOError: File not open for reading

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/124/console

- Mesos Reviewbot Windows


On June 28, 2017, 7:54 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60497/
> ---
> 
> (Updated June 28, 2017, 7:54 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7671
> https://issues.apache.org/jira/browse/MESOS-7671
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update mesos-execute capabilities options to match the
> framework capabilities fields. Rename `--capabilities`
> to `--effective_capabilities`, and add a new
> `--bounding_capabilities` option.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 6e153446efe63700606ff33df1fb681438673084 
> 
> 
> Diff: https://reviews.apache.org/r/60497/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 26)
> light manual testing
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

[Andrei Budnik]

> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 184 (patched)
> > 
> >
> > Is `|| 0` necessary here?
> 
> Andrei Budnik wrote:
> I think yes, because we might miss information about a specific role in 
> state.reserved_resources_allocated. E.g., we have both statically reserved 
> resources for both "ads" and "dyn" roles, but only one role is actually 
> allocated. Let's assume that resources from "dyn" role are used to launch 
> some task, while "ads" role isn't used, hence no item for "ads" in 
> state.reserved_resources_allocated exists. In the latter case 0 is used as a 
> default value.
> 
> haosdent huang wrote:
> Hmm, but
> 
> ```
> state.unreserved_resources_allocated.cpus | number
> ```
> 
> above would show `/0` as well.
> 
> Should we keep consistency since almost part use this pattern
> 
> ```
>   
> {{monitor.frameworks[framework.id].statistics.cpus_total_usage | number}} 
> / {{framework.cpus | number}}
> ```
> 
> Andrei Budnik wrote:
> `unreserved_resources_allocated` is always defined.
> 
> If I change this:
> ```html
>   {{reservation.role}}
>   
> {{(state.reserved_resources_allocated[reservation.role].cpus | number) || 
> 0}} / {{reservation.cpus | number}}
>   
> {{(state.reserved_resources_allocated[reservation.role].gpus | number) || 
> 0}} / {{reservation.gpus | number}}
>   {{(state.reserved_resources_allocated[reservation.role].mem 
> * (1024 * 1024) | dataSize) || 0}} / {{reservation.mem * (1024 * 1024) | 
> dataSize}}
>   
> {{(state.reserved_resources_allocated[reservation.role].disk * (1024 * 
> 1024) | dataSize) || 0}} / {{reservation.disk * (1024 * 1024) | 
> dataSize}}
> ```
> to that:
> ```html
>   {{reservation.role}}
>   {{state.reserved_resources_allocated[reservation.role].cpus 
> | number}} / {{reservation.cpus | number}}
>   {{state.reserved_resources_allocated[reservation.role].gpus 
> | number}} / {{reservation.gpus | number}}
>   {{state.reserved_resources_allocated[reservation.role].mem 
> * (1024 * 1024) | dataSize}} / {{reservation.mem * (1024 * 1024) | 
> dataSize}}
>   {{state.reserved_resources_allocated[reservation.role].disk 
> * (1024 * 1024) | dataSize}} / {{reservation.disk * (1024 * 1024) | 
> dataSize}}
> ```
> Then it will look like in the 
> [picture](https://reviews.apache.org/r/60370/file/1507/).
> 
> haosdent huang wrote:
> Let's put filter at the end. e.g.
> 
> ```
> {{(state.reserved_resources_allocated[reservation.role].cpus || 0) | 
> number}}
> ```

Fixed.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178801
---


On June 28, 2017, 8:52 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60370/
> ---
> 
> (Updated June 28, 2017, 8:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated agent webui page to display allocated resources per each role.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
>   src/webui/master/static/js/controllers.js 
> 67bfd030649dd21840c16188a4964f814aa232d7 
> 
> 
> Diff: https://reviews.apache.org/r/60370/diff/3/
> 
> 
> Testing
> ---
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> agent.html
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
> ui_bug
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/1b7755e3-0b11-46ab-9ae4-71f19bce0cd6__ui_bug.png
> ui_bug2
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/b89990c9-9aa5-432a-a0da-3f90c9428127__ui_bug2.png
> ui_bug3
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/51553e9d-7fb9-40c0-b47c-b62fc6c37393__ui_bug3.png
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/
---

(Updated June 28, 2017, 8:52 p.m.)


Review request for mesos, Benjamin Mahler and haosdent huang.


Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441


Repository: mesos


Description
---

Updated agent webui page to display allocated resources per each role.


Diffs (updated)
-

  src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
  src/webui/master/static/js/controllers.js 
67bfd030649dd21840c16188a4964f814aa232d7 


Diff: https://reviews.apache.org/r/60370/diff/3/

Changes: https://reviews.apache.org/r/60370/diff/2-3/


Testing
---

See screenshot.


File Attachments (updated)


agent.html
  
https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
ui_bug
  
https://reviews.apache.org/media/uploaded/files/2017/06/28/1b7755e3-0b11-46ab-9ae4-71f19bce0cd6__ui_bug.png
ui_bug2
  
https://reviews.apache.org/media/uploaded/files/2017/06/28/b89990c9-9aa5-432a-a0da-3f90c9428127__ui_bug2.png
ui_bug3
  
https://reviews.apache.org/media/uploaded/files/2017/06/28/51553e9d-7fb9-40c0-b47c-b62fc6c37393__ui_bug3.png


Thanks,

Andrei Budnik

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

[Andrei Budnik]

> On June 27, 2017, 5:33 p.m., haosdent huang wrote:
> > src/webui/master/static/js/controllers.js
> > Lines 604 (patched)
> > 
> >
> > `ng-repeat` support map, have you try
> > 
> > ```
> > ng-repeat="(role, reservation) in $data"
> > ```
> 
> Andrei Budnik wrote:
> If I change this:
> ```html
> 
>   {{reservation.role}}
>   
> {{(state.reserved_resources_allocated[reservation.role].cpus | number) || 
> 0}} / {{reservation.cpus | number}}
>   
> {{(state.reserved_resources_allocated[reservation.role].gpus | number) || 
> 0}} / {{reservation.gpus | number}}
>   {{(state.reserved_resources_allocated[reservation.role].mem 
> * (1024 * 1024) | dataSize) || 0}} / {{reservation.mem * (1024 * 1024) | 
> dataSize}}
>   
> {{(state.reserved_resources_allocated[reservation.role].disk * (1024 * 
> 1024) | dataSize) || 0}} / {{reservation.disk * (1024 * 1024) | 
> dataSize}}
> 
> ```
> to that:
> ```html
> 
>   {{role}}
>   
> {{(state.reserved_resources_allocated[reservation.role].cpus | number) || 
> 0}} / {{reservation.cpus | number}}
>   
> {{(state.reserved_resources_allocated[reservation.role].gpus | number) || 
> 0}} / {{reservation.gpus | number}}
>   {{(state.reserved_resources_allocated[reservation.role].mem 
> * (1024 * 1024) | dataSize) || 0}} / {{reservation.mem * (1024 * 1024) | 
> dataSize}}
>   
> {{(state.reserved_resources_allocated[reservation.role].disk * (1024 * 
> 1024) | dataSize) || 0}} / {{reservation.disk * (1024 * 1024) | 
> dataSize}}
> 
> ```
> Then it will look like in the 
> [picture](https://reviews.apache.org/r/60370/file/1508/).
> 
> haosdent huang wrote:
> It is because you convert it from map to arrary at
> 
> ```
> $scope.agent.resource_reservations = roles.map
> ```
> 
> Have you remove it?
> 
> I test with 
> 
> ```
>   
> {{role}}
>   
> ```
> 
> and work for me.

Yeah, I can use this code:
```html

  {{role}}
  {{(state.reserved_resources_allocated[role].cpus || 0) | number}} 
/ {{reservation.cpus | number}}
  {{(state.reserved_resources_allocated[role].gpus || 0) | number}} 
/ {{reservation.gpus | number}}
  {{(state.reserved_resources_allocated[role].mem * (1024 * 1024) 
|| 0) | dataSize}} / {{reservation.mem * (1024 * 1024) | dataSize}}
  {{(state.reserved_resources_allocated[role].disk * (1024 * 1024) 
|| 0) | dataSize}} / {{reservation.disk * (1024 * 1024) | dataSize}}

```
but filter becomes missing, see 
[picture](https://reviews.apache.org/r/60370/file/1509/).


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178996
---


On June 28, 2017, 12:37 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60370/
> ---
> 
> (Updated June 28, 2017, 12:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated agent webui page to display allocated resources per each role.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
>   src/webui/master/static/js/controllers.js 
> 67bfd030649dd21840c16188a4964f814aa232d7 
> 
> 
> Diff: https://reviews.apache.org/r/60370/diff/2/
> 
> 
> Testing
> ---
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> agent.html
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
> ui_bug
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/1b7755e3-0b11-46ab-9ae4-71f19bce0cd6__ui_bug.png
> ui_bug2
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/b89990c9-9aa5-432a-a0da-3f90c9428127__ui_bug2.png
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60107: Finished object acceptor for tasks endpoint.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/#review179132
---



Could you change the commit title to something like "Added filtering to the 
'/tasks' endpoint." ?


src/common/http.hpp
Lines 168 (patched)


Maybe something like: "Determines which objects will be accepted when 
filtering results based on authorization or other criteria."



src/common/http.hpp
Lines 180 (patched)


Let's call this `AuthorizationAcceptor` instead. Other names are OK I think.



src/common/http.hpp
Lines 184 (patched)


Insert a space before the `{}`, here and elsewhere.



src/common/http.hpp
Lines 205-218 (patched)


It doesn't look like this class is used at all in this patch, can we remove 
it?



src/common/http.hpp
Lines 228-229 (patched)


Should break after parentheses:

```
bool accept(
const Task& task,
```



src/common/http.hpp
Lines 242 (patched)


For conditionals, insert spaces like:

```
if (_frameworkId.isSome()) {
```

here and elsewhere.



src/common/http.cpp
Lines 1129-1132 (patched)


Let's do:

```
Future
  AuthorizeFrameworkInfoAcceptor::create(
  const Option& principal,
  const Option& authorizer)
```



src/common/http.cpp
Lines 1135-1138 (patched)


You should be able to return just an 
`Owned` here, and the conversion to `Future` 
will happen implicitly:

```
return Owned(
new AuthorizeFrameworkInfoAcceptor(
Owned(new AcceptingObjectApprover(;
```

here and elsewhere.



src/common/http.cpp
Lines 1141-1142 (patched)


You could probably just add a `using authorization::createSubject` 
statement to the beginning of this file to avoid always qualifying the 
namespace.

Also, add a linebreak after this, here and elsewhere.



src/common/http.cpp
Lines 1143-1144 (patched)


Would prefer linebreaks like:

```
return authorizer.get()->getObjectApprover(
subject,
authorization::VIEW_FRAMEWORK)
```

here and elsewhere.



src/common/http.cpp
Lines 1145 (patched)


For lambdas, insert a space before the `{`, here and elsewhere.



src/common/http.cpp
Lines 1148 (patched)


The indentation of the lambda's closing `}` should match that of the line 
with the opening `{`, so indent this two more spaces.



src/common/http.cpp
Lines 1206 (patched)


Newline before this; here and elsewhere.



src/master/http.cpp
Line 3801 (original), 3801 (patched)


Can eliminate this comment.



src/master/http.cpp
Line 3806 (original), 3806 (patched)


How about `selectFrameworkId` instead of `acceptorFrameworkId`.



src/master/http.cpp
Line 3808 (original), 3808 (patched)


Indent two more spaces.



src/master/http.cpp
Line 3809 (original), 3809 (patched)


`selectTaskId` instead of `acceptorTaskId`



src/master/http.cpp
Line 3824 (original), 3823 (patched)


We can eliminate this comment.



src/master/http.cpp
Lines 3828-3832 (patched)


In this case, since `tie(` is 4 spaces long, you can do:

```
  tie(authorizeFrameworkInfo,
  authorizeTask,
  acceptorFrameworkId,
  acceptorTaskId) = acceptors;
```



src/master/http.cpp
Line 3831 (original), 3838 (patched)


The Framework struct has an `id()` method; let's use that here instead: 
`framework->id()`



src/master/http.cpp
Lines 3839 (patched)


Indent two more spaces, here and below.



src/master/http.cpp
Line 3848 (original), 3857 (patched)


This comment should mention unreachable tasks as well.



src/tests/master_tests.cpp
Line 3446 (original), 3448 

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

[Eric Chung]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58394/
---

(Updated June 28, 2017, 6:55 p.m.)


Review request for mesos, Jason Lai, Joseph Wu, and Kevin Klues.


Bugs: MESOS-7310
https://issues.apache.org/jira/browse/MESOS-7310


Repository: mesos


Description
---

Review: https://reviews.apache.org/r/58394


Diffs (updated)
-

  src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443 
  src/python/.gitignore PRE-CREATION 
  src/python/lib/mesos/__init__.py PRE-CREATION 


Diff: https://reviews.apache.org/r/58394/diff/3/

Changes: https://reviews.apache.org/r/58394/diff/2-3/


Testing
---

Under src/cli_new:
1\. ./bootstrap
2\. . ./activate
3\. python
4\. >>> import mesos
5\. >>> mesos.\_\_path\_\_
6\. verify that the path printed out is indeed at src/python/lib/mesos


Thanks,

Eric Chung

Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945


Repository: mesos


Description
---

Added MockMetadataManager and test concurrent prune and pull.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 
954da1681778878c8aff6150002e52ecb648d1bb 
  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
d86afd2a6ff0bf87e624db1c99255c85068bf6ab 
  src/slave/containerizer/mesos/provisioner/docker/store.hpp 
1cf68665d33bd40a7605d26c96fb7b618407fdd0 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
8058dcb31b9de59fa8d3638b553632235542 
  src/tests/containerizer/provisioner_docker_tests.cpp 
920be77b16178a4458d72145020c015130799ec4 


Diff: https://reviews.apache.org/r/60511/diff/1/


Testing
---


Thanks,

Zhitao Li

Review Request 60508: Fixed Attributes comparison.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60508/
---

Review request for mesos, Benjamin Mahler and Vinod Kone.


Bugs: MESOS-1216
https://issues.apache.org/jira/browse/MESOS-1216


Repository: mesos


Description
---

Currently we don't enforce attribute name uniqueness. But the comparison
operator for `Attributes` expects that attribute name and type are
unique. This causes causes agent recovery failure.

This fixes the issue by allowing multiple attributes of same name and
type.


Diffs
-

  include/mesos/attributes.hpp 641febbd3bc3700b2c088f4388d8e6f18e6b078a 
  include/mesos/v1/attributes.hpp 022bfde430c618708843a4d790f3f8a118ae082b 
  src/common/attributes.cpp ac683c7fe5b67fb8a73599230a3eb47911293a7e 
  src/tests/attributes_tests.cpp cb71be5ecead322d90943146f54f8a0c915eba1c 
  src/v1/attributes.cpp 409d66453c492a329adc4e16312924e21a6d4709 


Diff: https://reviews.apache.org/r/60508/diff/1/


Testing
---

Added a test to `AttributesTest.Equality`. Ran `make check`. Verified manually 
by failing over the agent with multiple attributes with the same name.


Thanks,

Ilya Pronin

Re: Review Request 60438: Updated endpoint help generator script to work inside Docker.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60438/#review179124
---


Ship it!




Ship It!

- haosdent huang


On June 26, 2017, 5:54 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60438/
> ---
> 
> (Updated June 26, 2017, 5:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-7625
> https://issues.apache.org/jira/browse/MESOS-7625
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed agent flags to make this script work inside Docker container.
> This is needed because this script will be run as part of website
> publishing process which runs on ASF CI inside Docker.
> 
> 
> Diffs
> -
> 
>   support/generate-endpoint-help.py 6eb2d41b35c5f064839c29a0ba8326c590a33213 
> 
> 
> Diff: https://reviews.apache.org/r/60438/diff/1/
> 
> 
> Testing
> ---
> 
> Tested by running a CI job pointing to a branch containing this patch.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

[haosdent huang]

> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 184 (patched)
> > 
> >
> > Is `|| 0` necessary here?
> 
> Andrei Budnik wrote:
> I think yes, because we might miss information about a specific role in 
> state.reserved_resources_allocated. E.g., we have both statically reserved 
> resources for both "ads" and "dyn" roles, but only one role is actually 
> allocated. Let's assume that resources from "dyn" role are used to launch 
> some task, while "ads" role isn't used, hence no item for "ads" in 
> state.reserved_resources_allocated exists. In the latter case 0 is used as a 
> default value.
> 
> haosdent huang wrote:
> Hmm, but
> 
> ```
> state.unreserved_resources_allocated.cpus | number
> ```
> 
> above would show `/0` as well.
> 
> Should we keep consistency since almost part use this pattern
> 
> ```
>   
> {{monitor.frameworks[framework.id].statistics.cpus_total_usage | number}} 
> / {{framework.cpus | number}}
> ```
> 
> Andrei Budnik wrote:
> `unreserved_resources_allocated` is always defined.
> 
> If I change this:
> ```html
>   {{reservation.role}}
>   
> {{(state.reserved_resources_allocated[reservation.role].cpus | number) || 
> 0}} / {{reservation.cpus | number}}
>   
> {{(state.reserved_resources_allocated[reservation.role].gpus | number) || 
> 0}} / {{reservation.gpus | number}}
>   {{(state.reserved_resources_allocated[reservation.role].mem 
> * (1024 * 1024) | dataSize) || 0}} / {{reservation.mem * (1024 * 1024) | 
> dataSize}}
>   
> {{(state.reserved_resources_allocated[reservation.role].disk * (1024 * 
> 1024) | dataSize) || 0}} / {{reservation.disk * (1024 * 1024) | 
> dataSize}}
> ```
> to that:
> ```html
>   {{reservation.role}}
>   {{state.reserved_resources_allocated[reservation.role].cpus 
> | number}} / {{reservation.cpus | number}}
>   {{state.reserved_resources_allocated[reservation.role].gpus 
> | number}} / {{reservation.gpus | number}}
>   {{state.reserved_resources_allocated[reservation.role].mem 
> * (1024 * 1024) | dataSize}} / {{reservation.mem * (1024 * 1024) | 
> dataSize}}
>   {{state.reserved_resources_allocated[reservation.role].disk 
> * (1024 * 1024) | dataSize}} / {{reservation.disk * (1024 * 1024) | 
> dataSize}}
> ```
> Then it will look like in the 
> [picture](https://reviews.apache.org/r/60370/file/1507/).

Let's put filter at the end. e.g.

```
{{(state.reserved_resources_allocated[reservation.role].cpus || 0) | number}}
```


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178801
---


On June 28, 2017, 12:37 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60370/
> ---
> 
> (Updated June 28, 2017, 12:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated agent webui page to display allocated resources per each role.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
>   src/webui/master/static/js/controllers.js 
> 67bfd030649dd21840c16188a4964f814aa232d7 
> 
> 
> Diff: https://reviews.apache.org/r/60370/diff/2/
> 
> 
> Testing
> ---
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> agent.html
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
> ui_bug
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/1b7755e3-0b11-46ab-9ae4-71f19bce0cd6__ui_bug.png
> ui_bug2
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/b89990c9-9aa5-432a-a0da-3f90c9428127__ui_bug2.png
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

[haosdent huang]

> On June 27, 2017, 5:33 p.m., haosdent huang wrote:
> > src/webui/master/static/js/controllers.js
> > Lines 604 (patched)
> > 
> >
> > `ng-repeat` support map, have you try
> > 
> > ```
> > ng-repeat="(role, reservation) in $data"
> > ```
> 
> Andrei Budnik wrote:
> If I change this:
> ```html
> 
>   {{reservation.role}}
>   
> {{(state.reserved_resources_allocated[reservation.role].cpus | number) || 
> 0}} / {{reservation.cpus | number}}
>   
> {{(state.reserved_resources_allocated[reservation.role].gpus | number) || 
> 0}} / {{reservation.gpus | number}}
>   {{(state.reserved_resources_allocated[reservation.role].mem 
> * (1024 * 1024) | dataSize) || 0}} / {{reservation.mem * (1024 * 1024) | 
> dataSize}}
>   
> {{(state.reserved_resources_allocated[reservation.role].disk * (1024 * 
> 1024) | dataSize) || 0}} / {{reservation.disk * (1024 * 1024) | 
> dataSize}}
> 
> ```
> to that:
> ```html
> 
>   {{role}}
>   
> {{(state.reserved_resources_allocated[reservation.role].cpus | number) || 
> 0}} / {{reservation.cpus | number}}
>   
> {{(state.reserved_resources_allocated[reservation.role].gpus | number) || 
> 0}} / {{reservation.gpus | number}}
>   {{(state.reserved_resources_allocated[reservation.role].mem 
> * (1024 * 1024) | dataSize) || 0}} / {{reservation.mem * (1024 * 1024) | 
> dataSize}}
>   
> {{(state.reserved_resources_allocated[reservation.role].disk * (1024 * 
> 1024) | dataSize) || 0}} / {{reservation.disk * (1024 * 1024) | 
> dataSize}}
> 
> ```
> Then it will look like in the 
> [picture](https://reviews.apache.org/r/60370/file/1508/).

It is because you convert it from map to arrary at

```
$scope.agent.resource_reservations = roles.map
```

Have you remove it?

I test with 

```
  
{{role}}
  
```

and work for me.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178996
---


On June 28, 2017, 12:37 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60370/
> ---
> 
> (Updated June 28, 2017, 12:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated agent webui page to display allocated resources per each role.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
>   src/webui/master/static/js/controllers.js 
> 67bfd030649dd21840c16188a4964f814aa232d7 
> 
> 
> Diff: https://reviews.apache.org/r/60370/diff/2/
> 
> 
> Testing
> ---
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> agent.html
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
> ui_bug
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/1b7755e3-0b11-46ab-9ae4-71f19bce0cd6__ui_bug.png
> ui_bug2
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/b89990c9-9aa5-432a-a0da-3f90c9428127__ui_bug2.png
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 60500: Introduced `--default_container_dns` agent flag.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60500/
---

Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-7709
https://issues.apache.org/jira/browse/MESOS-7709


Repository: mesos


Description
---

Introduced `--default_container_dns` agent flag.


Diffs
-

  docs/configuration.md 0eb696a949003ff11831aed5e4f4ab384cf9992e 
  src/messages/flags.hpp 70ad58c33067a0b058deafdcc4ffc5f554b6ca72 
  src/messages/flags.proto e87075f19714739b93d9f4aa33ea8686a1bb5613 
  src/slave/flags.hpp e75c1b4227b443aedf445921b3f2108d930c112c 
  src/slave/flags.cpp c84aa6724170bba46bbe8410b71d42a1626e 


Diff: https://reviews.apache.org/r/60500/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 60008: Fixed bug causing FUTURE_DISPATCH to react on irrelevant dispatch.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60008/
---

(Updated June 28, 2017, 2:56 p.m.)


Review request for mesos, Alexander Rukletsov, Michael Park, and Neil Conway.


Summary (updated)
-

Fixed bug causing FUTURE_DISPATCH to react on irrelevant dispatch.


Bugs: MESOS-5886
https://issues.apache.org/jira/browse/MESOS-5886


Repository: mesos


Description
---

FUTURE_DISPATCH uses DispatchMatcher to figure out whether a processed
DispatchEvent is the same the user is waiting for. Currently, we
compare std::type_info of function pointers, which is not enough:
different class methods with same signatures will be matched (see
MESOS-5886 for an example).
This patch adds value of pointer-to-member function in addition to
std::type_info in DispatchEvent to uniquely identify class methods.


Diffs (updated)
-

  3rdparty/libprocess/include/process/dispatch.hpp 
3a0793888dc0df5e3ec31b06f47cd920c71e0db9 
  3rdparty/libprocess/include/process/event.hpp 
8afe6266eb0dc5a17af35d79efb6bfdf9e6a0ee9 
  3rdparty/libprocess/include/process/gmock.hpp 
e9af943b39436f365fe687301febb5c7fbefffc4 
  3rdparty/libprocess/src/process.cpp 8ff37d1b5781c42f96be2da391ed000158eea7b8 
  3rdparty/libprocess/src/tests/process_tests.cpp 
38d787a083a5eb31e922d283f4b4bed2bd62eb0a 


Diff: https://reviews.apache.org/r/60008/diff/2/

Changes: https://reviews.apache.org/r/60008/diff/1-2/


Testing
---

1. make check (mac os x 10.12, fedora 25)
2. internal CI

NOTE: Test GroupTest.ConnectTimer is broken, because it uses FUTURE_DISPATCH on 
a wrong method (GroupProcess::expired),
which has the same signature as a private method (GroupProcess::timedout). The 
later method is actually called,
thus causing the error after applying this patch.


Thanks,

Andrei Budnik

Re: Review Request 60008: Fixed bug causing FUTURE_DISPATCH to react on irrelevant dispatch.

[Andrei Budnik]

> On June 26, 2017, 2:15 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/include/process/dispatch.hpp
> > Lines 68 (patched)
> > 
> >
> > Why don't you use `Option<>`?

Fixed.


> On June 26, 2017, 2:15 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/include/process/event.hpp
> > Lines 178-179 (patched)
> > 
> >
> > Please a blank line here, i.e.,
> > ```
> > // Any society that would give up a little liberty to gain
> > // a little security will deserve neither and lose both.
> > //
> > // TODO(abudnik): Add a source link for the quote above.
> > ```

Fixed.


> On June 26, 2017, 2:15 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp
> > Line 189 (original), 190-192 (patched)
> > 
> >
> > We strive to add a descriptive comment for each test. Even though it is 
> > not an easy to go and add comments to existing tests, we do want to have a 
> > proper description for every newly added test.

Done.


> On June 26, 2017, 2:15 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp
> > Lines 204-205 (patched)
> > 
> >
> > Why do you need this statement?

This declares expectations about test behaviour. See next test 
THREADSAFE_Defer1 which uses EXPECT_CALL as well.


> On June 26, 2017, 2:15 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp
> > Lines 208-209 (patched)
> > 
> >
> > Additionally to (or actually instead of) `EXPECT` here, 
> > `AWAIT_READY(f);` would carry your intent better, I think. I would actually 
> > get rid of call expectations all together and simply focus on future states.

Fixed.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60008/#review17
---


On June 28, 2017, 2:56 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60008/
> ---
> 
> (Updated June 28, 2017, 2:56 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-5886
> https://issues.apache.org/jira/browse/MESOS-5886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> FUTURE_DISPATCH uses DispatchMatcher to figure out whether a processed
> DispatchEvent is the same the user is waiting for. Currently, we
> compare std::type_info of function pointers, which is not enough:
> different class methods with same signatures will be matched (see
> MESOS-5886 for an example).
> This patch adds value of pointer-to-member function in addition to
> std::type_info in DispatchEvent to uniquely identify class methods.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/dispatch.hpp 
> 3a0793888dc0df5e3ec31b06f47cd920c71e0db9 
>   3rdparty/libprocess/include/process/event.hpp 
> 8afe6266eb0dc5a17af35d79efb6bfdf9e6a0ee9 
>   3rdparty/libprocess/include/process/gmock.hpp 
> e9af943b39436f365fe687301febb5c7fbefffc4 
>   3rdparty/libprocess/src/process.cpp 
> 8ff37d1b5781c42f96be2da391ed000158eea7b8 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 38d787a083a5eb31e922d283f4b4bed2bd62eb0a 
> 
> 
> Diff: https://reviews.apache.org/r/60008/diff/2/
> 
> 
> Testing
> ---
> 
> 1. make check (mac os x 10.12, fedora 25)
> 2. internal CI
> 
> NOTE: Test GroupTest.ConnectTimer is broken, because it uses FUTURE_DISPATCH 
> on a wrong method (GroupProcess::expired),
> which has the same signature as a private method (GroupProcess::timedout). 
> The later method is actually called,
> thus causing the error after applying this patch.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 59937: Added agent `--resource_provider_config_dir` flag.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59937/#review179100
---




docs/configuration.md
Lines 1900 (patched)


... representing _a_ ...



docs/configuration.md
Lines 1903 (patched)


... handling operations _on_ the resources ...



docs/configuration.md
Lines 1907-1908 (patched)


Could we call out why we do not expose `resources` here? I imagine this is 
due to us wanted to determine them automatically on RP startup? To call it out 
here instead of e.g., the proto definition probably does make sense, since the 
proto definition could be used differently in different contexts.



src/slave/flags.cpp
Lines 98-109 (patched)


See comments in `configuration.md`.


- Benjamin Bannier


On June 26, 2017, 6:31 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59937/
> ---
> 
> (Updated June 26, 2017, 6:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.
> 
> 
> Bugs: MESOS-7571
> https://issues.apache.org/jira/browse/MESOS-7571
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent `--resource_provider_config_dir` flag.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 0eb696a949003ff11831aed5e4f4ab384cf9992e 
>   src/slave/flags.hpp e75c1b4227b443aedf445921b3f2108d930c112c 
>   src/slave/flags.cpp c84aa6724170bba46bbe8410b71d42a1626e 
> 
> 
> Diff: https://reviews.apache.org/r/59937/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

[Andrei Budnik]

> On June 27, 2017, 5:33 p.m., haosdent huang wrote:
> > src/webui/master/static/js/controllers.js
> > Lines 604 (patched)
> > 
> >
> > `ng-repeat` support map, have you try
> > 
> > ```
> > ng-repeat="(role, reservation) in $data"
> > ```

If I change this:
```html

  {{reservation.role}}
  {{(state.reserved_resources_allocated[reservation.role].cpus | 
number) || 0}} / {{reservation.cpus | number}}
  {{(state.reserved_resources_allocated[reservation.role].gpus | 
number) || 0}} / {{reservation.gpus | number}}
  {{(state.reserved_resources_allocated[reservation.role].mem * 
(1024 * 1024) | dataSize) || 0}} / {{reservation.mem * (1024 * 1024) | 
dataSize}}
  {{(state.reserved_resources_allocated[reservation.role].disk * 
(1024 * 1024) | dataSize) || 0}} / {{reservation.disk * (1024 * 1024) | 
dataSize}}

```
to that:
```html

  {{role}}
  {{(state.reserved_resources_allocated[reservation.role].cpus | 
number) || 0}} / {{reservation.cpus | number}}
  {{(state.reserved_resources_allocated[reservation.role].gpus | 
number) || 0}} / {{reservation.gpus | number}}
  {{(state.reserved_resources_allocated[reservation.role].mem * 
(1024 * 1024) | dataSize) || 0}} / {{reservation.mem * (1024 * 1024) | 
dataSize}}
  {{(state.reserved_resources_allocated[reservation.role].disk * 
(1024 * 1024) | dataSize) || 0}} / {{reservation.disk * (1024 * 1024) | 
dataSize}}

```
Then it will look like in the 
[picture](https://reviews.apache.org/r/60370/file/1508/).


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178996
---


On June 28, 2017, 12:37 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60370/
> ---
> 
> (Updated June 28, 2017, 12:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated agent webui page to display allocated resources per each role.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
>   src/webui/master/static/js/controllers.js 
> 67bfd030649dd21840c16188a4964f814aa232d7 
> 
> 
> Diff: https://reviews.apache.org/r/60370/diff/2/
> 
> 
> Testing
> ---
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> agent.html
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
> ui_bug
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/1b7755e3-0b11-46ab-9ae4-71f19bce0cd6__ui_bug.png
> ui_bug2
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/b89990c9-9aa5-432a-a0da-3f90c9428127__ui_bug2.png
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/
---

(Updated June 28, 2017, 12:37 p.m.)


Review request for mesos, Benjamin Mahler and haosdent huang.


Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441


Repository: mesos


Description
---

Updated agent webui page to display allocated resources per each role.


Diffs
-

  src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
  src/webui/master/static/js/controllers.js 
67bfd030649dd21840c16188a4964f814aa232d7 


Diff: https://reviews.apache.org/r/60370/diff/2/


Testing
---

See screenshot.


File Attachments (updated)


agent.html
  
https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
ui_bug
  
https://reviews.apache.org/media/uploaded/files/2017/06/28/1b7755e3-0b11-46ab-9ae4-71f19bce0cd6__ui_bug.png
ui_bug2
  
https://reviews.apache.org/media/uploaded/files/2017/06/28/b89990c9-9aa5-432a-a0da-3f90c9428127__ui_bug2.png


Thanks,

Andrei Budnik

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

[Andrei Budnik]

> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 184 (patched)
> > 
> >
> > Is `|| 0` necessary here?
> 
> Andrei Budnik wrote:
> I think yes, because we might miss information about a specific role in 
> state.reserved_resources_allocated. E.g., we have both statically reserved 
> resources for both "ads" and "dyn" roles, but only one role is actually 
> allocated. Let's assume that resources from "dyn" role are used to launch 
> some task, while "ads" role isn't used, hence no item for "ads" in 
> state.reserved_resources_allocated exists. In the latter case 0 is used as a 
> default value.
> 
> haosdent huang wrote:
> Hmm, but
> 
> ```
> state.unreserved_resources_allocated.cpus | number
> ```
> 
> above would show `/0` as well.
> 
> Should we keep consistency since almost part use this pattern
> 
> ```
>   
> {{monitor.frameworks[framework.id].statistics.cpus_total_usage | number}} 
> / {{framework.cpus | number}}
> ```

`unreserved_resources_allocated` is always defined.

If I change this:
```html
  {{reservation.role}}
  {{(state.reserved_resources_allocated[reservation.role].cpus | 
number) || 0}} / {{reservation.cpus | number}}
  {{(state.reserved_resources_allocated[reservation.role].gpus | 
number) || 0}} / {{reservation.gpus | number}}
  {{(state.reserved_resources_allocated[reservation.role].mem * 
(1024 * 1024) | dataSize) || 0}} / {{reservation.mem * (1024 * 1024) | 
dataSize}}
  {{(state.reserved_resources_allocated[reservation.role].disk * 
(1024 * 1024) | dataSize) || 0}} / {{reservation.disk * (1024 * 1024) | 
dataSize}}
```
to that:
```html
  {{reservation.role}}
  {{state.reserved_resources_allocated[reservation.role].cpus | 
number}} / {{reservation.cpus | number}}
  {{state.reserved_resources_allocated[reservation.role].gpus | 
number}} / {{reservation.gpus | number}}
  {{state.reserved_resources_allocated[reservation.role].mem * 
(1024 * 1024) | dataSize}} / {{reservation.mem * (1024 * 1024) | dataSize}}
  {{state.reserved_resources_allocated[reservation.role].disk * 
(1024 * 1024) | dataSize}} / {{reservation.disk * (1024 * 1024) | 
dataSize}}
```
Then it will look like in the 
[picture](https://reviews.apache.org/r/60370/file/1507/).


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178801
---


On June 28, 2017, 12:29 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60370/
> ---
> 
> (Updated June 28, 2017, 12:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated agent webui page to display allocated resources per each role.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
>   src/webui/master/static/js/controllers.js 
> 67bfd030649dd21840c16188a4964f814aa232d7 
> 
> 
> Diff: https://reviews.apache.org/r/60370/diff/2/
> 
> 
> Testing
> ---
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> agent.html
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
> ui_bug
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/28/1b7755e3-0b11-46ab-9ae4-71f19bce0cd6__ui_bug.png
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/
---

(Updated June 28, 2017, 12:29 p.m.)


Review request for mesos, Benjamin Mahler and haosdent huang.


Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441


Repository: mesos


Description
---

Updated agent webui page to display allocated resources per each role.


Diffs
-

  src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
  src/webui/master/static/js/controllers.js 
67bfd030649dd21840c16188a4964f814aa232d7 


Diff: https://reviews.apache.org/r/60370/diff/2/


Testing
---

See screenshot.


File Attachments (updated)


agent.html
  
https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
ui_bug
  
https://reviews.apache.org/media/uploaded/files/2017/06/28/1b7755e3-0b11-46ab-9ae4-71f19bce0cd6__ui_bug.png


Thanks,

Andrei Budnik

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

[Andrei Budnik]

> On June 27, 2017, 5:58 p.m., haosdent huang wrote:
> > src/slave/http.cpp
> > Lines 1334-1344 (patched)
> > 
> >
> > Should we follow this pattern?
> > 
> > 
> > ```
> > writer->field(
> > "reserved_resources_full",
> > [](JSON::ObjectWriter* writer) {
> >   foreachpair (const string& role,
> >const Resources& resources,
> >totalResources.reservations()) {
> > 
> > ```

Yeah, sure. Fixed.


> On June 27, 2017, 5:58 p.m., haosdent huang wrote:
> > src/slave/http.cpp
> > Lines 1344 (patched)
> > 
> >
> > Nit: Add one blank line below.

Fixed.


> On June 27, 2017, 5:58 p.m., haosdent huang wrote:
> > src/tests/reservation_endpoints_tests.cpp
> > Line 1739 (original), 1739 (patched)
> > 
> >
> > Nit: Add one blank line below.

Fixed.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179000
---


On June 28, 2017, 12:08 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> ---
> 
> (Updated June 28, 2017, 12:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
>   src/tests/reservation_endpoints_tests.cpp 
> f710a188a7875c1cb847e39276b4b65332703ca5 
> 
> 
> Diff: https://reviews.apache.org/r/60369/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/
---

(Updated June 28, 2017, 12:08 p.m.)


Review request for mesos, Benjamin Mahler and haosdent huang.


Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441


Repository: mesos


Description
---

The JSON key for this information is "reserved_resources_allocated"
and "unreserved_resources_allocated".


Diffs (updated)
-

  src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
  src/tests/reservation_endpoints_tests.cpp 
f710a188a7875c1cb847e39276b4b65332703ca5 


Diff: https://reviews.apache.org/r/60369/diff/3/

Changes: https://reviews.apache.org/r/60369/diff/2-3/


Testing
---

make check


Thanks,

Andrei Budnik

Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60216/#review179082
---


Ship it!




Ship It!

- Alexander Rukletsov


On June 27, 2017, 8:07 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60216/
> ---
> 
> (Updated June 27, 2017, 8:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-4331
> https://issues.apache.org/jira/browse/MESOS-4331
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The capitalization check caused rebases to fail for commits made with
> `--fixup` and `--squash`. This change ignores the check for these cases.
> 
> 
> Diffs
> -
> 
>   support/hooks/commit-msg 755309e70581835d01f53c1910b37b6cd3ea98ca 
> 
> 
> Diff: https://reviews.apache.org/r/60216/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 60497: Update mesos-execute capabilities options.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60497/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-7671
https://issues.apache.org/jira/browse/MESOS-7671


Repository: mesos


Description
---

Update mesos-execute capabilities options to match the
framework capabilities fields. Rename `--capabilities`
to `--effective_capabilities`, and add a new
`--bounding_capabilities` option.


Diffs
-

  src/cli/execute.cpp 6e153446efe63700606ff33df1fb681438673084 


Diff: https://reviews.apache.org/r/60497/diff/1/


Testing
---

make check (Fedora 26)
light manual testing


Thanks,

James Peach

Review Request 60496: WIP: Add socket checking to the network ports isolator.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60496/
---

Review request for mesos.


Bugs: MESOS-7675
https://issues.apache.org/jira/browse/MESOS-7675


Repository: mesos


Description
---

Implement ports resource restrictions in the network ports isolator.
Periodically, scan for listening sockets and match them up to all
the open sockets in the containers we are tracking in the network.
Check any sockets we find against the ports resource and trigger a
resource limitation if the port has not been allocated.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION 
  src/tests/containerizer/network_ports_isolator_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/60496/diff/1/


Testing
---

make check (Fedora 26)


Thanks,

James Peach

Review Request 60493: Remove diagnostic socket IPv4 assumptions.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60493/
---

Review request for mesos.


Bugs: MESOS-7675
https://issues.apache.org/jira/browse/MESOS-7675


Repository: mesos


Description
---

Don't assume the diagnostic socket only returns IPv4 addresses.


Diffs
-

  src/linux/routing/diagnosis/diagnosis.cpp 
aa2d020fc009040410ef557d10d386d04d71d16e 


Diff: https://reviews.apache.org/r/60493/diff/1/


Testing
---

make check (Fedora 26)


Thanks,

James Peach

Review Request 60494: Expose LinuxLauncher cgroups helper.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60494/
---

Review request for mesos.


Bugs: MESOS-7675
https://issues.apache.org/jira/browse/MESOS-7675


Repository: mesos


Description
---

Expose the LinuxLauncher cgroups helper to generate the cgroups
path from a container ID. This is needed by the `network/ports`
isolator.


Diffs
-

  src/slave/containerizer/mesos/linux_launcher.hpp 
e1525231e0a374bc044e929e82b8d051732e97cb 
  src/slave/containerizer/mesos/linux_launcher.cpp 
1cea04edac8e0c4aea8c1c7d946b5065f3eac931 


Diff: https://reviews.apache.org/r/60494/diff/1/


Testing
---

make check (Fedora 26)


Thanks,

James Peach

Review Request 60491: Capture the inode when scanning for sockets.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60491/
---

Review request for mesos.


Bugs: MESOS-7675
https://issues.apache.org/jira/browse/MESOS-7675


Repository: mesos


Description
---

Capture the socket inode in the diagnosis Info when we use netlink
to enumerate the open sockets. This can be used to indentify which
process(es) have the socket open.


Diffs
-

  src/linux/routing/diagnosis/diagnosis.hpp 
7722fd2843614c3869cc6c3d06bc4c82ed282381 
  src/linux/routing/diagnosis/diagnosis.cpp 
aa2d020fc009040410ef557d10d386d04d71d16e 


Diff: https://reviews.apache.org/r/60491/diff/1/


Testing
---

make check (Fedora 26)


Thanks,

James Peach