date:20171006

Re: Review Request 62820: Added first class profile for disk resources.

2017-10-06 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187333
---



Patch looks great!

Reviews applied: [62818, 62819, 62820]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 6, 2017, 9:42 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62820/
> ---
> 
> (Updated Oct. 6, 2017, 9:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
> 
> 
> Bugs: MESOS-8060
> https://issues.apache.org/jira/browse/MESOS-8060
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is similar to storage classes. Instead of adding a bunch of
> storage backend specific parameters (e.g., rotational, type, speed,
> etc.) into the disk resources, and asking the frameworks to make
> scheduling decisions based on those vendor specific parameters. We
> propose to use a level of indirection here.
> 
> The operator will setup mappings between a profile name to a set of
> vendor specific disk parameters. The framework will do disk selection
> based on profile names.
> 
> The storage resource provider will provide a hook allowing operators
> to customize the profile name assignment for disk resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec 
>   include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5 
>   src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246 
>   src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c 
>   src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a 
>   src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10 
> 
> 
> Diff: https://reviews.apache.org/r/62820/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-06 Thread Greg Mann


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62594/#review187325
---




src/scheduler/flags.hpp
Lines 22-25 (patched)


Are these really necessary?



src/scheduler/flags.hpp
Lines 48 (patched)


s/http_authenticatee/httpAuthenticatee/

Here and in the variable declaration below.



src/scheduler/flags.hpp
Lines 112 (patched)


Newline before the closing curly brace.



src/scheduler/scheduler.cpp
Lines 226-231 (patched)


Nit: would prefer if this change went into a separate patch.



src/scheduler/scheduler.cpp
Lines 331 (patched)


Should probably indent this line another 4 spaces?


- Greg Mann


On Oct. 2, 2017, 10:29 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62594/
> ---
> 
> (Updated Oct. 2, 2017, 10:29 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, 
> Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8021
> https://issues.apache.org/jira/browse/MESOS-8021
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated scheduler library for modularized HTTP authenticatee use.
> 
> 
> Diffs
> -
> 
>   src/scheduler/flags.hpp 1e8efc06b40b17d6fa9d9516a83893485804fc72 
>   src/scheduler/scheduler.cpp 78f53707364ab988bcc53ec2c95490df04cd9a6c 
> 
> 
> Diff: https://reviews.apache.org/r/62594/diff/3/
> 
> 
> Testing
> ---
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62587: Added HTTP authenticatee interface definition.

2017-10-06 Thread Till Toenshoff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62587/
---

(Updated Oct. 7, 2017, 1:06 a.m.)


Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and 
Kapil Arya.


Changes
---

comment.


Bugs: MESOS-8016
https://issues.apache.org/jira/browse/MESOS-8016


Repository: mesos


Description
---

Added HTTP authenticatee interface definition.


Diffs (updated)
-

  include/mesos/authentication/http/authenticatee.hpp PRE-CREATION 
  src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 


Diff: https://reviews.apache.org/r/62587/diff/6/

Changes: https://reviews.apache.org/r/62587/diff/5-6/


Testing
---

Integration test in external project. Further tests upcoming.


Thanks,

Till Toenshoff

Re: Review Request 62592: Added basic HTTP authenticatee implementation.

2017-10-06 Thread Greg Mann


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62592/#review187320
---




src/authentication/http/basic_authenticatee.cpp
Lines 87-88 (patched)


Fits on one line.


- Greg Mann


On Oct. 2, 2017, 10:12 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62592/
> ---
> 
> (Updated Oct. 2, 2017, 10:12 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and 
> Kapil Arya.
> 
> 
> Bugs: MESOS-8017
> https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added basic HTTP authenticatee implementation.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 1a0dff3604c288d2af8ecc23f1ec73f5a350bc31 
>   src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
>   src/authentication/http/basic_authenticatee.hpp PRE-CREATION 
>   src/authentication/http/basic_authenticatee.cpp PRE-CREATION 
>   src/common/http.hpp 0e6b1c59860e75c04e2e3be2520ed2b39c84ac90 
> 
> 
> Diff: https://reviews.apache.org/r/62592/diff/3/
> 
> 
> Testing
> ---
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

2017-10-06 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review187324
---



Patch looks great!

Reviews applied: [62587, 62591, 62592, 62594, 62595]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Sept. 26, 2017, 10:54 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62595/
> ---
> 
> (Updated Sept. 26, 2017, 10:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, 
> Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8017
> https://issues.apache.org/jira/browse/MESOS-8017
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test module wrapping the basic HTTP authenticatee.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_http_authenticator_module.cpp 
> a2fdc282e741f36a429923a7d6082750a89b7b13 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/module.cpp 5b83fd6358ddea4c9d849b8992e1a6040ef74505 
> 
> 
> Diff: https://reviews.apache.org/r/62595/diff/2/
> 
> 
> Testing
> ---
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62800: Created cgroups under systemd hierarchy in LinuxLauncher.

2017-10-06 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62800/#review187308
---




src/linux/systemd.hpp
Lines 29 (patched)


Should be a comment here?



src/linux/systemd.hpp
Lines 30 (patched)


Do we even need this constant? It's used once and doesn't seem to add any 
value over just using `"systemd"`.



src/slave/containerizer/mesos/linux_launcher.cpp
Lines 189 (patched)


This is racy, but we can fix it by ensuring that `os::mkdir` checks for 
`EEXIST` even when it is non-recursive.



src/slave/containerizer/mesos/linux_launcher.cpp
Lines 402 (patched)


Would we really exit? I'm not sure we should expect users to be able to 
manually deal with that case.



src/slave/containerizer/mesos/linux_launcher.cpp
Lines 426 (patched)


Log the `cgroup.error()`?



src/slave/containerizer/mesos/linux_launcher.cpp
Line 369 (original), 440 (patched)


I dunno, maybe a `;` rather than a `.` since it is weird to not end with a 
`.` when we have full sentences :)


- James Peach


On Oct. 6, 2017, 10:04 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62800/
> ---
> 
> (Updated Oct. 6, 2017, 10:04 p.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-7990
> https://issues.apache.org/jira/browse/MESOS-7990
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added the support for systemd hierarchy in LinuxLauncher.
> It created the same cgroup layout under the systemd hierarchy (if
> systemd is enabled) as that in the freezer hierarchy.
> 
> This can give us a bunch of benefits:
> 1) systemd-cgls can list mesos container processes.
> 2) systemd-cgtop can show stats for mesos containers.
> 3) Avoid the pid migration issue described in MESOS-3352.
> 
> For example:
> 
> ```
> |[jie@core-dev ~]$ systemd-cgls
> |-1 /usr/lib/systemd/systemd --system --deserialize 20
> |-mesos
> |  |-8282b91a-5724-4964-a623-7c6bd68ff4ad
> | |-31737 /usr/libexec/mesos/mesos-containerizer launch
> | |-31739 mesos-default-executor --launcher_dir=/usr/libexec/mesos
> | |-mesos
> ||-8555f4af-fa4f-4c9c-aeb3-0c9f72e6a2de
> |   |-31791 /usr/libexec/mesos/mesos-containerizer launch
> |   |-31793 sleep 1000
> ```
> 
> 
> Diffs
> -
> 
>   src/linux/systemd.hpp f760e2c02683f0169ba5d3b0a3da53f66a7f3d91 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 554c598e2a7a53aede9d8761740d8efceb4a7e39 
> 
> 
> Diff: https://reviews.apache.org/r/62800/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> I also use the steps describe in MESOS-3352 to repo the systemd pid migration 
> issue. Didn't observe it after applying the patch.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62798: Added named cgroup hierarchy support.

2017-10-06 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62798/#review187322
---


Ship it!




Ship It!

- James Peach


On Oct. 6, 2017, 4:32 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62798/
> ---
> 
> (Updated Oct. 6, 2017, 4:32 a.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-7990
> https://issues.apache.org/jira/browse/MESOS-7990
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch add a helper to get the cgroup associated with the given
> pid for a named cgroup hierarchy.
> 
> 
> Diffs
> -
> 
>   src/linux/cgroups.hpp 154e5b6c1adef4f4e77f1747c56dfd83a9967ed4 
>   src/linux/cgroups.cpp 0a7bb89567d4b3ecee7c4f9a259368fb4eae7f34 
> 
> 
> Diff: https://reviews.apache.org/r/62798/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62820: Added first class profile for disk resources.

2017-10-06 Thread James DeFelice


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187318
---



- James DeFelice


On Oct. 6, 2017, 9:42 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62820/
> ---
> 
> (Updated Oct. 6, 2017, 9:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
> 
> 
> Bugs: MESOS-8060
> https://issues.apache.org/jira/browse/MESOS-8060
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is similar to storage classes. Instead of adding a bunch of
> storage backend specific parameters (e.g., rotational, type, speed,
> etc.) into the disk resources, and asking the frameworks to make
> scheduling decisions based on those vendor specific parameters. We
> propose to use a level of indirection here.
> 
> The operator will setup mappings between a profile name to a set of
> vendor specific disk parameters. The framework will do disk selection
> based on profile names.
> 
> The storage resource provider will provide a hook allowing operators
> to customize the profile name assignment for disk resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec 
>   include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5 
>   src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246 
>   src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c 
>   src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a 
>   src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10 
> 
> 
> Diff: https://reviews.apache.org/r/62820/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62820: Added first class profile for disk resources.

2017-10-06 Thread James DeFelice


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187316
---


Ship it!




Ship It!

- James DeFelice


On Oct. 6, 2017, 9:42 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62820/
> ---
> 
> (Updated Oct. 6, 2017, 9:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
> 
> 
> Bugs: MESOS-8060
> https://issues.apache.org/jira/browse/MESOS-8060
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is similar to storage classes. Instead of adding a bunch of
> storage backend specific parameters (e.g., rotational, type, speed,
> etc.) into the disk resources, and asking the frameworks to make
> scheduling decisions based on those vendor specific parameters. We
> propose to use a level of indirection here.
> 
> The operator will setup mappings between a profile name to a set of
> vendor specific disk parameters. The framework will do disk selection
> based on profile names.
> 
> The storage resource provider will provide a hook allowing operators
> to customize the profile name assignment for disk resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec 
>   include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5 
>   src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246 
>   src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c 
>   src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a 
>   src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10 
> 
> 
> Diff: https://reviews.apache.org/r/62820/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62587: Added HTTP authenticatee interface definition.

2017-10-06 Thread Greg Mann


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62587/#review187315
---


Fix it, then Ship it!





include/mesos/authentication/http/authenticatee.hpp
Lines 56 (patched)


s/a HTTP/an HTTP/


- Greg Mann


On Oct. 2, 2017, 6:55 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62587/
> ---
> 
> (Updated Oct. 2, 2017, 6:55 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and 
> Kapil Arya.
> 
> 
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP authenticatee interface definition.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/authenticatee.hpp PRE-CREATION 
>   src/Makefile.am da8af916652a80303f37b65056920676726f8dfe 
> 
> 
> Diff: https://reviews.apache.org/r/62587/diff/5/
> 
> 
> Testing
> ---
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 61855: Removed a stray trailing parenthesis from a validation error.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61855/#review187313
---



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):

```
[ RUN  ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[   OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[   OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[   OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN  ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[   OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN  ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[   OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[   OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage 
(941 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[   OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage 
(1060 ms)
[ RUN  ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[   OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN  ] FaultToleranceTest.SchedulerExit
[   OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN  ] FaultToleranceTest.SlaveReliableRegistration
[   OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN  ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[   OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN  ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[   OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN  ] FaultToleranceTest.SplitBrainMasters
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):

```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 
60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:13.007899 39284 master.cpp:1303] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 
8c8fa538-3ba3-4608-8e12-2ba9b5151087 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 
10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" 
--agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" 
--allocation_interval="1secs" --allocator="HierarchicalDRF" 
--authenticate_agents="true"

Re: Review Request 61855: Removed a stray trailing parenthesis from a validation error.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61855/#review187314
---



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):

```
[ RUN  ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[   OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[   OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[   OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN  ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[   OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN  ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[   OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[   OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage 
(941 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[   OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage 
(1060 ms)
[ RUN  ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[   OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN  ] FaultToleranceTest.SchedulerExit
[   OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN  ] FaultToleranceTest.SlaveReliableRegistration
[   OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN  ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[   OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN  ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[   OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN  ] FaultToleranceTest.SplitBrainMasters
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):

```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 
60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:13.007899 39284 master.cpp:1303] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 
8c8fa538-3ba3-4608-8e12-2ba9b5151087 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 
10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" 
--agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" 
--allocation_interval="1secs" --allocator="HierarchicalDRF" 
--authenticate_agents="true"

Re: Review Request 61855: Removed a stray trailing parenthesis from a validation error.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61855/#review187311
---



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

- Mesos Reviewbot Windows


On Oct. 6, 2017, 3:29 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61855/
> ---
> 
> (Updated Oct. 6, 2017, 3:29 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed a stray trailing parenthesis from a validation error.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 7c3247d407c9e6aa8cce457d6c6be0c39f4b532f 
> 
> 
> Diff: https://reviews.apache.org/r/61855/diff/1/
> 
> 
> Testing
> ---
> 
> None, but it passed all the commit hooks. YOLO =).
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 61855: Removed a stray trailing parenthesis from a validation error.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61855/#review187310
---



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

- Mesos Reviewbot Windows


On Oct. 6, 2017, 10:29 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61855/
> ---
> 
> (Updated Oct. 6, 2017, 10:29 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed a stray trailing parenthesis from a validation error.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 7c3247d407c9e6aa8cce457d6c6be0c39f4b532f 
> 
> 
> Diff: https://reviews.apache.org/r/61855/diff/1/
> 
> 
> Testing
> ---
> 
> None, but it passed all the commit hooks. YOLO =).
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 62819: Fixed some consistency issue in disk source equality check.

2017-10-06 Thread Joseph Wu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62819/#review187309
---


Ship it!




- Joseph Wu


On Oct. 6, 2017, 2:42 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62819/
> ---
> 
> (Updated Oct. 6, 2017, 2:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed some consistency issue in disk source equality check.
> 
> 
> Diffs
> -
> 
>   src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10 
> 
> 
> Diff: https://reviews.apache.org/r/62819/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62800: Created cgroups under systemd hierarchy in LinuxLauncher.

2017-10-06 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62800/
---

(Updated Oct. 6, 2017, 10:04 p.m.)


Review request for mesos, James Peach, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-7990
https://issues.apache.org/jira/browse/MESOS-7990


Repository: mesos


Description (updated)
---

This patch added the support for systemd hierarchy in LinuxLauncher.
It created the same cgroup layout under the systemd hierarchy (if
systemd is enabled) as that in the freezer hierarchy.

This can give us a bunch of benefits:
1) systemd-cgls can list mesos container processes.
2) systemd-cgtop can show stats for mesos containers.
3) Avoid the pid migration issue described in MESOS-3352.

For example:

```
|[jie@core-dev ~]$ systemd-cgls
|-1 /usr/lib/systemd/systemd --system --deserialize 20
|-mesos
|  |-8282b91a-5724-4964-a623-7c6bd68ff4ad
| |-31737 /usr/libexec/mesos/mesos-containerizer launch
| |-31739 mesos-default-executor --launcher_dir=/usr/libexec/mesos
| |-mesos
||-8555f4af-fa4f-4c9c-aeb3-0c9f72e6a2de
|   |-31791 /usr/libexec/mesos/mesos-containerizer launch
|   |-31793 sleep 1000
```


Diffs
-

  src/linux/systemd.hpp f760e2c02683f0169ba5d3b0a3da53f66a7f3d91 
  src/slave/containerizer/mesos/linux_launcher.cpp 
554c598e2a7a53aede9d8761740d8efceb4a7e39 


Diff: https://reviews.apache.org/r/62800/diff/1/


Testing
---

sudo make check

I also use the steps describe in MESOS-3352 to repo the systemd pid migration 
issue. Didn't observe it after applying the patch.


Thanks,

Jie Yu

Re: Review Request 62818: Removed a redundant equality check for Mount disk source.

2017-10-06 Thread Joseph Wu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62818/#review187307
---


Ship it!




LGTM.

- Joseph Wu


On Oct. 6, 2017, 2:41 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62818/
> ---
> 
> (Updated Oct. 6, 2017, 2:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed a redundant equality check for Mount disk source.
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246 
> 
> 
> Diff: https://reviews.apache.org/r/62818/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62820: Added first class profile for disk resources.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187305
---



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):

```
[ RUN  ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[   OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[   OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[   OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN  ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[   OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN  ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[   OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[   OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage 
(941 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[   OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage 
(1060 ms)
[ RUN  ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[   OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN  ] FaultToleranceTest.SchedulerExit
[   OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN  ] FaultToleranceTest.SlaveReliableRegistration
[   OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN  ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[   OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN  ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[   OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN  ] FaultToleranceTest.SplitBrainMasters
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):

```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 
60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:13.007899 39284 master.cpp:1303] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 
8c8fa538-3ba3-4608-8e12-2ba9b5151087 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 
10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" 
--agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" 
--allocation_interval="1secs" --allocator="HierarchicalDRF" 
--authenticate_agents="true"

Re: Review Request 62820: Added first class profile for disk resources.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187306
---



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

- Mesos Reviewbot Windows


On Oct. 6, 2017, 9:42 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62820/
> ---
> 
> (Updated Oct. 6, 2017, 9:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.
> 
> 
> Bugs: MESOS-8060
> https://issues.apache.org/jira/browse/MESOS-8060
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is similar to storage classes. Instead of adding a bunch of
> storage backend specific parameters (e.g., rotational, type, speed,
> etc.) into the disk resources, and asking the frameworks to make
> scheduling decisions based on those vendor specific parameters. We
> propose to use a level of indirection here.
> 
> The operator will setup mappings between a profile name to a set of
> vendor specific disk parameters. The framework will do disk selection
> based on profile names.
> 
> The storage resource provider will provide a hook allowing operators
> to customize the profile name assignment for disk resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec 
>   include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5 
>   src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246 
>   src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c 
>   src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a 
>   src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10 
> 
> 
> Diff: https://reviews.apache.org/r/62820/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 62820: Added first class profile for disk resources.

2017-10-06 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/
---

Review request for mesos, Benjamin Bannier, James DeFelice, and Joseph Wu.


Bugs: MESOS-8060
https://issues.apache.org/jira/browse/MESOS-8060


Repository: mesos


Description
---

This is similar to storage classes. Instead of adding a bunch of
storage backend specific parameters (e.g., rotational, type, speed,
etc.) into the disk resources, and asking the frameworks to make
scheduling decisions based on those vendor specific parameters. We
propose to use a level of indirection here.

The operator will setup mappings between a profile name to a set of
vendor specific disk parameters. The framework will do disk selection
based on profile names.

The storage resource provider will provide a hook allowing operators
to customize the profile name assignment for disk resources.


Diffs
-

  include/mesos/mesos.proto 1bfcc5bb9091075c6fa1bc36e2cd23afe2e0e0ec 
  include/mesos/v1/mesos.proto d742adbbf24692d2d82aad51316d767af93942d5 
  src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246 
  src/tests/mesos.hpp b0749db273c91692b91d7ca87f975694b18e422c 
  src/tests/resources_tests.cpp 7f0150ff04b2c5a9a0c47b29a107bad5e363285a 
  src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10 


Diff: https://reviews.apache.org/r/62820/diff/1/


Testing
---

make check


Thanks,

Jie Yu

Review Request 62819: Fixed some consistency issue in disk source equality check.

2017-10-06 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62819/
---

Review request for mesos, Benjamin Bannier and Joseph Wu.


Repository: mesos


Description
---

Fixed some consistency issue in disk source equality check.


Diffs
-

  src/v1/resources.cpp a64180bad1d782dd270e06217a389002155c2e10 


Diff: https://reviews.apache.org/r/62819/diff/1/


Testing
---

make check


Thanks,

Jie Yu

Review Request 62818: Removed a redundant equality check for Mount disk source.

2017-10-06 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62818/
---

Review request for mesos, Benjamin Bannier and Joseph Wu.


Repository: mesos


Description
---

Removed a redundant equality check for Mount disk source.


Diffs
-

  src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246 


Diff: https://reviews.apache.org/r/62818/diff/1/


Testing
---


Thanks,

Jie Yu

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62781/#review187304
---



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):

```
[ RUN  ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[   OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[   OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[   OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN  ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[   OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN  ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[   OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[   OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage 
(941 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[   OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage 
(1060 ms)
[ RUN  ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[   OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN  ] FaultToleranceTest.SchedulerExit
[   OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN  ] FaultToleranceTest.SlaveReliableRegistration
[   OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN  ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[   OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN  ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[   OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN  ] FaultToleranceTest.SplitBrainMasters
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):

```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 
60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:13.007899 39284 master.cpp:1303] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 
8c8fa538-3ba3-4608-8e12-2ba9b5151087 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 
10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" 
--agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" 
--allocation_interval="1secs" --allocator="HierarchicalDRF" 
--authenticate_agents="true"

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Gaston Kleiman



> On Oct. 6, 2017, 12:55 p.m., Benjamin Mahler wrote:
> > src/webui/master/static/js/controllers.js
> > Lines 30-31 (original), 43-44 (patched)
> > 
> >
> > Stale?

Good catch! =)


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62781/#review187294
---


On Oct. 6, 2017, 2:05 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62781/
> ---
> 
> (Updated Oct. 6, 2017, 2:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This path extracts the generation of URLs of agent endpoints to a single
> function.
> 
> Having this logic in just one place makes it easier to modify it, e.g.,
> to make it possible to use the UI via a reverse proxy.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/browse.html 
> c586b9050e14697ca89fabfe636c2d18a4ecf6f5 
>   src/webui/master/static/js/controllers.js 
> cb1f093ea21864eadd0ae32f3c33a7ff88b6fc27 
>   src/webui/master/static/js/services.js 
> b99ad685e9614ef77586efb5fa52345fc173e51e 
> 
> 
> Diff: https://reviews.apache.org/r/62781/diff/5/
> 
> 
> Testing
> ---
> 
> Verified that the UI still works when running a master and an agent.
> 
> I tried:
> 
>   * Clicking all the tabs.
>   * Viewing the master/agent logs.
>   * Browsing a task sandbox and reading a file using the pailer.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Gaston Kleiman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62781/
---

(Updated Oct. 6, 2017, 2:05 p.m.)


Review request for mesos, Benjamin Mahler and James Peach.


Changes
---

Added some documentation/comments.


Repository: mesos


Description
---

This path extracts the generation of URLs of agent endpoints to a single
function.

Having this logic in just one place makes it easier to modify it, e.g.,
to make it possible to use the UI via a reverse proxy.


Diffs (updated)
-

  src/webui/master/static/browse.html c586b9050e14697ca89fabfe636c2d18a4ecf6f5 
  src/webui/master/static/js/controllers.js 
cb1f093ea21864eadd0ae32f3c33a7ff88b6fc27 
  src/webui/master/static/js/services.js 
b99ad685e9614ef77586efb5fa52345fc173e51e 


Diff: https://reviews.apache.org/r/62781/diff/5/

Changes: https://reviews.apache.org/r/62781/diff/4-5/


Testing
---

Verified that the UI still works when running a master and an agent.

I tried:

  * Clicking all the tabs.
  * Viewing the master/agent logs.
  * Browsing a task sandbox and reading a file using the pailer.


Thanks,

Gaston Kleiman

Re: Review Request 62214: Added JavaScript linter.

2017-10-06 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review187300
---



Patch looks great!

Reviews applied: [62333, 62214]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 6, 2017, 9 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Oct. 6, 2017, 9 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/6/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62781/#review187294
---

Fix it, then Ship it!

Thanks for taking this on! Just a few minor comments and we can get this 
committed.

src/webui/master/static/js/controllers.js
Lines 30-41 (patched)

Some documentation would be great, not sure people will get what 
'includeId' is for.

E.g.

```
// Returns the URL prefix for an agent, there are two cases
// to consider:
//
//   (1) Some endpoints for the agent process itself require
//   the agent PID.name in the path, this is to ensure
//   that the webui works correctly when running against
//   mesos-local or other instances of multiple agents
//   running within the same host:port:
// //hostname:port/slave(1)
// //hostname:port/slave(2)
// ...
//
//   (2) Some endpoints for other components in the agent
//   do not require the agent PID.name in the path, since
//   a single endpoint serves multiple agents withint the
//   same process. In this case we just return:
// //hostname:port
//
// Note that there are some clashing issues in mesos-local
// (e.g. hosting '/slave/log' for each slave log, we don't
// namespace metrics within '/metrics/snapshot', etc).
```

src/webui/master/static/js/controllers.js
Lines 30-31 (original), 43-44 (patched)

Stale?

src/webui/master/static/js/controllers.js
Line 1096 (original), 1100 (patched)

Let's say we set false here because this is used for generating /files 
links?

- Benjamin Mahler

On Oct. 6, 2017, 6:42 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62781/
> ---
> 
> (Updated Oct. 6, 2017, 6:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This path extracts the generation of URLs of agent endpoints to a single
> function.
> 
> Having this logic in just one place makes it easier to modify it, e.g.,
> to make it possible to use the UI via a reverse proxy.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/browse.html 
> c586b9050e14697ca89fabfe636c2d18a4ecf6f5 
>   src/webui/master/static/js/controllers.js 
> cb1f093ea21864eadd0ae32f3c33a7ff88b6fc27 
>   src/webui/master/static/js/services.js 
> b99ad685e9614ef77586efb5fa52345fc173e51e 
> 
> 
> Diff: https://reviews.apache.org/r/62781/diff/4/
> 
> 
> Testing
> ---
> 
> Verified that the UI still works when running a master and an agent.
> 
> I tried:
> 
>   * Clicking all the tabs.
>   * Viewing the master/agent logs.
>   * Browsing a task sandbox and reading a file using the pailer.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review187292
---



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):

```
[ RUN  ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[   OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[   OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[   OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN  ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[   OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN  ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[   OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[   OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage 
(941 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[   OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage 
(1060 ms)
[ RUN  ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[   OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN  ] FaultToleranceTest.SchedulerExit
[   OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN  ] FaultToleranceTest.SlaveReliableRegistration
[   OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN  ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[   OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN  ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[   OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN  ] FaultToleranceTest.SplitBrainMasters
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):

```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 
60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:13.007899 39284 master.cpp:1303] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 
8c8fa538-3ba3-4608-8e12-2ba9b5151087 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 
10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" 
--agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" 
--allocation_interval="1secs" --allocator="HierarchicalDRF" 
--authenticate_agents="true"

Re: Review Request 62595: Added test module wrapping the basic HTTP authenticatee.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62595/#review187291
---



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):

```
[ RUN  ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[   OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[   OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[   OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN  ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[   OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN  ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[   OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[   OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage 
(941 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[   OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage 
(1060 ms)
[ RUN  ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[   OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN  ] FaultToleranceTest.SchedulerExit
[   OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN  ] FaultToleranceTest.SlaveReliableRegistration
[   OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN  ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[   OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN  ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[   OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN  ] FaultToleranceTest.SplitBrainMasters
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):

```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 
60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:13.007899 39284 master.cpp:1303] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 
8c8fa538-3ba3-4608-8e12-2ba9b5151087 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 
10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" 
--agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" 
--allocation_interval="1secs" --allocator="HierarchicalDRF" 
--authenticate_agents="true"

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62781/#review187293
---



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):

```
[ RUN  ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[   OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[   OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[   OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN  ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[   OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN  ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[   OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[   OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage 
(941 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[   OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage 
(1060 ms)
[ RUN  ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[   OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN  ] FaultToleranceTest.SchedulerExit
[   OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN  ] FaultToleranceTest.SlaveReliableRegistration
[   OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN  ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[   OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN  ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[   OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN  ] FaultToleranceTest.SplitBrainMasters
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):

```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 
60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:13.007899 39284 master.cpp:1303] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 
8c8fa538-3ba3-4608-8e12-2ba9b5151087 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 
10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" 
--agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" 
--allocation_interval="1secs" --allocator="HierarchicalDRF" 
--authenticate_agents="true"

Re: Review Request 62775: Added a test `ROOT_INTERNET_CURL_NoTransitionFromKillingToFinished`.

2017-10-06 Thread Gaston Kleiman



> On Oct. 4, 2017, 1:40 p.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 1273-1277 (patched)
> > 
> >
> > You could use the `KillPolicyTestHelper` with `--sleep_duration=0` 
> > instead of this.
> > 
> > If you do that, you don't need to mark the test as `ROOT_INTERNET_CURL` 
> > and it will be run more often.
> 
> Qian Zhang wrote:
> Thanks, I have tried it, and found an issue about this test: When I use 
> the `nginx:alpine` image and ran this test, I found:
> ```
> [ RUN  ] 
> MesosContainerizer/DefaultExecutorTest.ROOT_INTERNET_CURL_NoTransitionFromKillingToFinished/0
> ...
> I1006 06:32:32.615941 29160 default_executor.cpp:1004] Killing task 
> 6eacb18a-69f6-48ca-8ffd-4134b75c8525 running in child container 
> 10f2af6b-232d-485e-86a0-9bbdd419a280.f6c078ba-9c08-4cb0-80fc-18bc154477be 
> with SIGTERM signal
> I1006 06:32:32.616163 29160 default_executor.cpp:1026] Scheduling 
> escalation to SIGKILL in 3secs from now
> I1006 06:32:32.664510 29177 default_executor.cpp:185] Received 
> ACKNOWLEDGED event
> I1006 06:32:32.700647 29180 default_executor.cpp:842] Child container 
> 10f2af6b-232d-485e-86a0-9bbdd419a280.f6c078ba-9c08-4cb0-80fc-18bc154477be of 
> task '6eacb18a-69f6-48ca-8ffd-4134b75c8525' in state TASK_KILLED terminated 
> with signal Terminated
> ...
> ```
> 
> And when I use `KillPolicyTestHelper` with `--sleep_duration=0` and run 
> this test, I found:
> ```
> [ RUN  ] 
> MesosContainerizer/DefaultExecutorTest.ROOT_NoTransitionFromKillingToFinished/0
> I1006 06:38:32.138226 30407 default_executor.cpp:1004] Killing task 
> 636f6b03-b083-4522-813e-aa2122e60915 running in child container 
> c9af5166-6aee-4cb3-890e-2846fcb1179e.0994b090-5e88-4a36-a63a-3eacbbbabf89 
> with SIGTERM signal
> I1006 06:38:32.138247 30407 default_executor.cpp:1026] Scheduling 
> escalation to SIGKILL in 3secs from now
> I1006 06:38:32.187152 30421 default_executor.cpp:185] Received 
> ACKNOWLEDGED event
> I1006 06:38:32.225972 30423 default_executor.cpp:842] Child container 
> c9af5166-6aee-4cb3-890e-2846fcb1179e.0994b090-5e88-4a36-a63a-3eacbbbabf89 of 
> task '636f6b03-b083-4522-813e-aa2122e60915' in state TASK_KILLED terminated 
> with signal Killed
> ```
> 
> So as you see, the child container was terminated with either `signal 
> Terminated` (SIGTERM) or `signal Killed` (SIGKILL), this seems not correct, 
> because when I run the same task group (`nginx:alpine` or 
> `KillPolicyTestHelper`) with `mesos-execute`, I see:
> ```
> I1006 01:35:42.375380 12666 default_executor.cpp:1004] Killing task test1 
> running in child container 
> 814d48e9-4776-420a-8194-e61c820315be.921436e3-238e-4b86-a644-189c40d44da8 
> with SIGTERM signal
> I1006 01:35:42.375432 12666 default_executor.cpp:1026] Scheduling 
> escalation to SIGKILL in 3secs from now
> I1006 01:35:42.530655 12635 default_executor.cpp:842] Child container 
> 814d48e9-4776-420a-8194-e61c820315be.921436e3-238e-4b86-a644-189c40d44da8 of 
> task 'test1' in state TASK_KILLED exited with status 0
> ```
> This time the child container exited with status 0 rather than terminated 
> with any signal, I think this is correct behavior. So it seems as long as I 
> run the test, the task (child container) never exits with 0, this is not what 
> we expect. I am not sure what's wrong with test, any comments?

Have you tried setting `CommandInfo.shell` to `false` and adding 
`--sleep_duration=0` to `CommandInfo.arguments`? If `CommandInfo.shell` is set 
to `true`, `sh` will receive the SIGTERM signal and exit instead of propagating 
it to the helper.


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62775/#review187126
---


On Oct. 4, 2017, 8:48 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62775/
> ---
> 
> (Updated Oct. 4, 2017, 8:48 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_INTERNET_CURL_NoTransitionFromKillingToFinished`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1 
> 
> 
> Diff: https://reviews.apache.org/r/62775/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 62806: Added `--disable-libtool-wrappers` to reviewbot.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62806/#review187288
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62806']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):

```
[ RUN  ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[   OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[   OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[   OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN  ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[   OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN  ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[   OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[   OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage 
(941 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[   OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage 
(1060 ms)
[ RUN  ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[   OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN  ] FaultToleranceTest.SchedulerExit
[   OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN  ] FaultToleranceTest.SlaveReliableRegistration
[   OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN  ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[   OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN  ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[   OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN  ] FaultToleranceTest.SplitBrainMasters
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):

```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 
60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:13.007899 39284 master.cpp:1303] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 
8c8fa538-3ba3-4608-8e12-2ba9b5151087 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 
10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" 
--agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" 
--allocation_interval="1secs" --allocator="HierarchicalDRF" 
--authenticate_agents="true"

Re: Review Request 62806: Added `--disable-libtool-wrappers` to reviewbot.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62806/#review187289
---



FAIL: The system cannot find the file specified.

Reviews applied: `['62806']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stdout.log):

```
[ RUN  ] FaultToleranceTest.SchedulerReregisterAfterUnregistration
[   OK ] FaultToleranceTest.SchedulerReregisterAfterUnregistration (389 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverRetriedReregistration
[   OK ] FaultToleranceTest.SchedulerFailoverRetriedReregistration (389 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchLost
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchLost (609 ms)
[ RUN  ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped
[   OK ] FaultToleranceTest.DisconnectedSchedulerLaunchDropped (596 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverStatusUpdate
[   OK ] FaultToleranceTest.SchedulerFailoverStatusUpdate (923 ms)
[ RUN  ] FaultToleranceTest.ReregisterFrameworkExitedExecutor
[   OK ] FaultToleranceTest.ReregisterFrameworkExitedExecutor (1249 ms)
[ RUN  ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor
[   OK ] FaultToleranceTest.ForwardStatusUpdateUnknownExecutor (822 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage
[   OK ] FaultToleranceTest.SchedulerFailoverExecutorToFrameworkMessage 
(941 ms)
[ RUN  ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage
[   OK ] FaultToleranceTest.SchedulerFailoverFrameworkToExecutorMessage 
(1060 ms)
[ RUN  ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework
[   OK ] FaultToleranceTest.IgnoreKillTaskFromUnregisteredFramework (939 ms)
[ RUN  ] FaultToleranceTest.SchedulerExit
[   OK ] FaultToleranceTest.SchedulerExit (841 ms)
[ RUN  ] FaultToleranceTest.SlaveReliableRegistration
[   OK ] FaultToleranceTest.SlaveReliableRegistration (788 ms)
[ RUN  ] FaultToleranceTest.SlaveReregisterOnZKExpiration
[   OK ] FaultToleranceTest.SlaveReregisterOnZKExpiration (778 ms)
[ RUN  ] FaultToleranceTest.FrameworkReregisterEmptyExecutor
[   OK ] FaultToleranceTest.FrameworkReregisterEmptyExecutor (1130 ms)
[ RUN  ] FaultToleranceTest.SplitBrainMasters
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806/logs/mesos-tests-stderr.log):

```
I1006 17:26:12.991288 43216 master.cpp:8459] Removing framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.991288 43216 master.cpp:3299] Deactivating framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7- (default) at 
scheduler-3a38ff4a-a81c-4c5b-9c40-38d63a94afd2@10.3.1.5:61771
I1006 17:26:12.992297 46984 hierarchical.cpp:412] Deactivated framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:12.995283 43216 master.cpp:9389] Removing offer 
60f5153f-ffdc-4156-8383-39cf5a6b25f8-O0
I1006 17:26:12.998283 46248 slave.cpp:869] Agent terminating
I1006 17:26:13.004289 21464 hierarchical.cpp:355] Removed framework 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-
I1006 17:26:13.007899 39284 master.cpp:1303] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1006 17:26:13.008906 39284 master.cpp:3336] Disconnecting agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.008906 39284 master.cpp:3355] Deactivating agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 at slave(37)@10.3.1.5:61771 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 17:26:13.009905 46484 hierarchical.cpp:690] Agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0 deactivated
I1006 17:26:13.038906 46248 master.cpp:1145] Master terminating
I1006 17:26:13.040907 21464 hierarchical.cpp:626] Removed agent 
ede9e20a-4e06-46fb-a22c-7e8013f03fa7-S0
I1006 17:26:13.151911 46248 cluster.cpp:162] Creating default 'local' authorizer
I1006 17:26:13.184912 44660 master.cpp:445] Master 
8c8fa538-3ba3-4608-8e12-2ba9b5151087 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 
10.3.1.5:61771
I1006 17:26:13.184912 44660 master.cpp:447] Flags at startup: --acls="" 
--agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" 
--allocation_interval="1secs" --allocator="HierarchicalDRF" 
--authenticate_agents="true"

Re: Review Request 62814: Added `--disable-libtool-wrappers` to support scripts.

2017-10-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62814/#review187287
---


Ship it!




Ship It!

- Vinod Kone


On Oct. 6, 2017, 7:03 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62814/
> ---
> 
> (Updated Oct. 6, 2017, 7:03 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `--disable-libtool-wrappers` to support scripts.
> 
> 
> Diffs
> -
> 
>   support/coverage.sh 95d6b8e3bfb345a61ae764b0be2d841ed49c243d 
>   support/jenkins/reviewbot.sh a9d0b41fcab038ece7cafaac05d349a3dd4e4dcb 
> 
> 
> Diff: https://reviews.apache.org/r/62814/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62814: Added `--disable-libtool-wrappers` to support scripts.

2017-10-06 Thread Andrei Budnik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62814/
---

(Updated Oct. 6, 2017, 7:03 p.m.)


Review request for mesos and Vinod Kone.


Summary (updated)
-

Added `--disable-libtool-wrappers` to support scripts.


Repository: mesos


Description (updated)
---

Added `--disable-libtool-wrappers` to support scripts.


Diffs (updated)
-

  support/coverage.sh 95d6b8e3bfb345a61ae764b0be2d841ed49c243d 
  support/jenkins/reviewbot.sh a9d0b41fcab038ece7cafaac05d349a3dd4e4dcb 


Diff: https://reviews.apache.org/r/62814/diff/2/

Changes: https://reviews.apache.org/r/62814/diff/1-2/


Testing
---


Thanks,

Andrei Budnik

Re: Review Request 62814: Added `--disable-libtool-wrappers` to coverage script.

2017-10-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62814/#review187285
---


Ship it!




Ship It!

- Vinod Kone


On Oct. 6, 2017, 6:44 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62814/
> ---
> 
> (Updated Oct. 6, 2017, 6:44 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `--disable-libtool-wrappers` to coverage script.
> 
> 
> Diffs
> -
> 
>   support/coverage.sh 95d6b8e3bfb345a61ae764b0be2d841ed49c243d 
> 
> 
> Diff: https://reviews.apache.org/r/62814/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 62814: Added `--disable-libtool-wrappers` to coverage script.

2017-10-06 Thread Andrei Budnik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62814/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Added `--disable-libtool-wrappers` to coverage script.


Diffs
-

  support/coverage.sh 95d6b8e3bfb345a61ae764b0be2d841ed49c243d 


Diff: https://reviews.apache.org/r/62814/diff/1/


Testing
---


Thanks,

Andrei Budnik

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Gaston Kleiman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62781/
---

(Updated Oct. 6, 2017, 11:42 a.m.)


Review request for mesos, Benjamin Mahler and James Peach.


Changes
---

Fixed the master's log pailer.


Repository: mesos


Description
---

This path extracts the generation of URLs of agent endpoints to a single
function.

Having this logic in just one place makes it easier to modify it, e.g.,
to make it possible to use the UI via a reverse proxy.


Diffs (updated)
-

  src/webui/master/static/browse.html c586b9050e14697ca89fabfe636c2d18a4ecf6f5 
  src/webui/master/static/js/controllers.js 
cb1f093ea21864eadd0ae32f3c33a7ff88b6fc27 
  src/webui/master/static/js/services.js 
b99ad685e9614ef77586efb5fa52345fc173e51e 


Diff: https://reviews.apache.org/r/62781/diff/4/

Changes: https://reviews.apache.org/r/62781/diff/3-4/


Testing
---

Verified that the UI still works when running a master and an agent.

I tried:

  * Clicking all the tabs.
  * Viewing the master/agent logs.
  * Browsing a task sandbox and reading a file using the pailer.


Thanks,

Gaston Kleiman

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Gaston Kleiman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62781/
---

(Updated Oct. 6, 2017, 11:37 a.m.)


Review request for mesos, Benjamin Mahler and James Peach.


Changes
---

Made the agent's process id optional.


Repository: mesos


Description
---

This path extracts the generation of URLs of agent endpoints to a single
function.

Having this logic in just one place makes it easier to modify it, e.g.,
to make it possible to use the UI via a reverse proxy.


Diffs (updated)
-

  src/webui/master/static/browse.html c586b9050e14697ca89fabfe636c2d18a4ecf6f5 
  src/webui/master/static/js/controllers.js 
cb1f093ea21864eadd0ae32f3c33a7ff88b6fc27 
  src/webui/master/static/js/services.js 
b99ad685e9614ef77586efb5fa52345fc173e51e 


Diff: https://reviews.apache.org/r/62781/diff/3/

Changes: https://reviews.apache.org/r/62781/diff/2-3/


Testing (updated)
---

Verified that the UI still works when running a master and an agent.

I tried:

  * Clicking all the tabs.
  * Viewing the master/agent logs.
  * Browsing a task sandbox and reading a file using the pailer.


Thanks,

Gaston Kleiman

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-06 Thread Benno Evers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review187282
---

In general, I would like to +1 Jie's comments, it would be really nice to have 
the ability to create a .deb/.rpm package from a local working directory and to 
have only very minimal logic in docker, so we don't get into a situation where 
we effectively depend on docker to build mesos.

support/packaging/centos/6/Dockerfile
Lines 90 (patched)

This seems to install much more than just the  `BuildRequires` listed in 
the spec file below.

support/packaging/centos/6/Dockerfile
Lines 99 (patched)

Do we reuse the generated container anywhere? If not, it doesn't seem like 
ccache could have any cache hits.

Also, does the yum package automatically set ccache as the default 
compiler? On debian, some manual work is still required after installing the 
package to either set up the appropriate symlinks or to manually set 
`CXX="ccache g++"`

support/packaging/common/mesos-master.service
Lines 7 (patched)

If this is to be common for all packaging, probably it should be 
`mesos-master.service.in` and use `@BINDIR@` instead of `/usr/bin`. (same 
comment applies for the other files under `packaging/common/`)

support/packaging/common/mesos-slave
Lines 1 (patched)

Should this be `ZK` instead of `MASTER`? And do we need a check here if 
mesos was compiled with support for zookeeper?

- Benno Evers

On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> ---
> 
> (Updated Sept. 27, 2017, 9:50 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Binary packaging for Centos 7.
> 
> 
> Diffs
> -
> 
>   support/packaging/Jenkinsfile PRE-CREATION 
>   support/packaging/centos/6/Dockerfile PRE-CREATION 
>   support/packaging/centos/6/mesos.spec PRE-CREATION 
>   support/packaging/centos/7/Dockerfile PRE-CREATION 
>   support/packaging/centos/7/mesos.spec PRE-CREATION 
>   support/packaging/common/mesos PRE-CREATION 
>   support/packaging/common/mesos-init-wrapper PRE-CREATION 
>   support/packaging/common/mesos-master PRE-CREATION 
>   support/packaging/common/mesos-master.service PRE-CREATION 
>   support/packaging/common/mesos-master.upstart PRE-CREATION 
>   support/packaging/common/mesos-slave PRE-CREATION 
>   support/packaging/common/mesos-slave.service PRE-CREATION 
>   support/packaging/common/mesos-slave.upstart PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62616/diff/2/
> 
> 
> Testing
> ---
> 
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF 
> Jenkins CI is available at 
> https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 62806: Added `--disable-libtool-wrappers` to reviewbot.

2017-10-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62806/#review187283
---


Ship it!




Ship It!

- Vinod Kone


On Oct. 6, 2017, 3:34 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62806/
> ---
> 
> (Updated Oct. 6, 2017, 3:34 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `--disable-libtool-wrappers` to reviewbot.
> 
> 
> Diffs
> -
> 
>   support/verify-reviews.py 1077b085cdfd7772cbe0defd8dbcb4952dbfb695 
> 
> 
> Diff: https://reviews.apache.org/r/62806/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62775: Added a test `ROOT_INTERNET_CURL_NoTransitionFromKillingToFinished`.

2017-10-06 Thread Qian Zhang

> On Oct. 5, 2017, 4:40 a.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 1273-1277 (patched)
> > 
> >
> > You could use the `KillPolicyTestHelper` with `--sleep_duration=0` 
> > instead of this.
> > 
> > If you do that, you don't need to mark the test as `ROOT_INTERNET_CURL` 
> > and it will be run more often.

Thanks, I have tried it, and found an issue about this test: When I use the 
`nginx:alpine` image and ran this test, I found:
```
[ RUN  ] 
MesosContainerizer/DefaultExecutorTest.ROOT_INTERNET_CURL_NoTransitionFromKillingToFinished/0
...
I1006 06:32:32.615941 29160 default_executor.cpp:1004] Killing task 
6eacb18a-69f6-48ca-8ffd-4134b75c8525 running in child container 
10f2af6b-232d-485e-86a0-9bbdd419a280.f6c078ba-9c08-4cb0-80fc-18bc154477be with 
SIGTERM signal
I1006 06:32:32.616163 29160 default_executor.cpp:1026] Scheduling escalation to 
SIGKILL in 3secs from now
I1006 06:32:32.664510 29177 default_executor.cpp:185] Received ACKNOWLEDGED 
event
I1006 06:32:32.700647 29180 default_executor.cpp:842] Child container 
10f2af6b-232d-485e-86a0-9bbdd419a280.f6c078ba-9c08-4cb0-80fc-18bc154477be of 
task '6eacb18a-69f6-48ca-8ffd-4134b75c8525' in state TASK_KILLED terminated 
with signal Terminated
...
```

And when I use `KillPolicyTestHelper` with `--sleep_duration=0` and run this 
test, I found:
```
[ RUN  ] 
MesosContainerizer/DefaultExecutorTest.ROOT_NoTransitionFromKillingToFinished/0
I1006 06:38:32.138226 30407 default_executor.cpp:1004] Killing task 
636f6b03-b083-4522-813e-aa2122e60915 running in child container 
c9af5166-6aee-4cb3-890e-2846fcb1179e.0994b090-5e88-4a36-a63a-3eacbbbabf89 with 
SIGTERM signal
I1006 06:38:32.138247 30407 default_executor.cpp:1026] Scheduling escalation to 
SIGKILL in 3secs from now
I1006 06:38:32.187152 30421 default_executor.cpp:185] Received ACKNOWLEDGED 
event
I1006 06:38:32.225972 30423 default_executor.cpp:842] Child container 
c9af5166-6aee-4cb3-890e-2846fcb1179e.0994b090-5e88-4a36-a63a-3eacbbbabf89 of 
task '636f6b03-b083-4522-813e-aa2122e60915' in state TASK_KILLED terminated 
with signal Killed
```

So as you see, the child container was terminated with either `signal 
Terminated` (SIGTERM) or `signal Killed` (SIGKILL), this seems not correct, 
because when I run the same task group (`nginx:alpine` or 
`KillPolicyTestHelper`) with `mesos-execute`, I see:
```
I1006 01:35:42.375380 12666 default_executor.cpp:1004] Killing task test1 
running in child container 
814d48e9-4776-420a-8194-e61c820315be.921436e3-238e-4b86-a644-189c40d44da8 with 
SIGTERM signal
I1006 01:35:42.375432 12666 default_executor.cpp:1026] Scheduling escalation to 
SIGKILL in 3secs from now
I1006 01:35:42.530655 12635 default_executor.cpp:842] Child container 
814d48e9-4776-420a-8194-e61c820315be.921436e3-238e-4b86-a644-189c40d44da8 of 
task 'test1' in state TASK_KILLED exited with status 0
```
This time the child container exited with status 0 rather than terminated with 
any signal, I think this is correct behavior. So it seems as long as I run the 
test, the task (child container) never exits with 0, this is not what we 
expect. I am not sure what's wrong with test, any comments?

- Qian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62775/#review187126
---

On Oct. 4, 2017, 11:48 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62775/
> ---
> 
> (Updated Oct. 4, 2017, 11:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_INTERNET_CURL_NoTransitionFromKillingToFinished`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1 
> 
> 
> Diff: https://reviews.apache.org/r/62775/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 62418: Removed unneeded configure step in mesos-tidy Docker image.

2017-10-06 Thread Michael Park


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62418/#review187276
---


Ship it!




Ship It!

- Michael Park


On Sept. 19, 2017, 1:42 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62418/
> ---
> 
> (Updated Sept. 19, 2017, 1:42 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The mesos-tidy Docker image uses the cmake build to prepare Mesos for
> linting. The cmake build does not require running of 'bootstrap'.
> 
> 
> Diffs
> -
> 
>   support/mesos-tidy/entrypoint.sh 68026f4a00abbca7fc80688b9d16718440596632 
> 
> 
> Diff: https://reviews.apache.org/r/62418/diff/1/
> 
> 
> Testing
> ---
> 
> Ran the built image with a modified `support/mesos-tidy.sh` that does not 
> force-download the image.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62417: Installed newer cmake version in mesos-tidy Docker image.

2017-10-06 Thread Michael Park


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62417/#review187275
---


Fix it, then Ship it!





support/mesos-tidy/Dockerfile
Line 27 (original), 27 (patched)


Do we want to skip this for now then?



support/mesos-tidy/Dockerfile
Lines 66-67 (patched)


Do we need either of these steps?
Can we just do this instead?
```
bash /tmp/install-cmake.sh --skip-license --prefix=/usr/local
```


- Michael Park


On Sept. 19, 2017, 1:42 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62417/
> ---
> 
> (Updated Sept. 19, 2017, 1:42 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As of '85bc58196fc2bcb94e8e3193dacf5cc8a2af4301' the Mesos cmake setup
> requires at least cmake-3.7.0. This patch install cmake-3.8.2 in the
> mesos-tidy Docker image so we can build Mesos in that image as well.
> 
> 
> Diffs
> -
> 
>   support/mesos-tidy/Dockerfile 1cf582ece03335c8db92a242c5870f11249a4f26 
> 
> 
> Diff: https://reviews.apache.org/r/62417/diff/1/
> 
> 
> Testing
> ---
> 
> Built and ran the image with a modified `support/mesos-tidy.sh` that does not 
> force-download the image.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62804: Formatted 'synchronized' like loop instead of function.

2017-10-06 Thread Michael Park


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62804/#review187274
---


Ship it!




Ship It!

- Michael Park


On Oct. 6, 2017, 1:55 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62804/
> ---
> 
> (Updated Oct. 6, 2017, 1:55 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We typically format 'synchronized' like a loop, i.e., we prefer
> 
> // Loop-like formatting.
> synchronized (lock) {
>   // Body.
> }
> 
> over e.g.,
> 
> // Function-like formatting.
> synchronized(lock)
> {
>   // Body.
> }
> 
> This patch updates the clang-format configuration to treat
> 'synchronized' blocks like loops instead of functions. This just
> codifies the existing convention in the code, so that this is a NFC.
> 
> 
> Diffs
> -
> 
>   support/clang-format bb587027a6c5b3660552a654ec06766c3ed0f6fe 
> 
> 
> Diff: https://reviews.apache.org/r/62804/diff/1/
> 
> 
> Testing
> ---
> 
> Confirmed that this formats like advertized.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62743: Synced the MTU for container eth0 in port mapping isolator.

2017-10-06 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62743/#review187273
---


Ship it!




Ship It!

- James Peach


On Oct. 3, 2017, 4:19 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62743/
> ---
> 
> (Updated Oct. 3, 2017, 4:19 a.m.)
> 
> 
> Review request for mesos, Ian Downes, James Peach, and Pierre Cheynier.
> 
> 
> Bugs: MESOS-7130
> https://issues.apache.org/jira/browse/MESOS-7130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Synced the MTU for container eth0 in port mapping isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 7ee4dbee7f2181cfb961e967913644acfa05eaba 
> 
> 
> Diff: https://reviews.apache.org/r/62743/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62806: Added `--disable-libtool-wrappers` to reviewbot.

2017-10-06 Thread Andrei Budnik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62806/
---

(Updated Oct. 6, 2017, 3:34 p.m.)


Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Added `--disable-libtool-wrappers` to reviewbot.


Diffs (updated)
-

  support/verify-reviews.py 1077b085cdfd7772cbe0defd8dbcb4952dbfb695 


Diff: https://reviews.apache.org/r/62806/diff/2/

Changes: https://reviews.apache.org/r/62806/diff/1-2/


Testing
---


Thanks,

Andrei Budnik

Re: Review Request 62806: Added `--disable-libtool-wrappers` to reviewbot.

2017-10-06 Thread Andrei Budnik



> On Oct. 6, 2017, 3:27 p.m., Vinod Kone wrote:
> > Looks like this doesn't pass the python linter. I thought this should've 
> > been caught by the pre-commit hook?
> > 
> > ?  mesos git:(master) ./support/apply-reviews.py -r 62806
> > 2017-10-06 08:26:28 URL:https://reviews.apache.org/r/62806/diff/raw/ 
> > [726/726] -> "62806.patch" [1]
> > No C++ files to lint
> > Checking 1 Python file
> > * Module verify-reviews
> > C:192, 0: Line too long (84/80) (line-too-long)
> > Total errors found: 1

I'm thinking about how to split this long line. That's not easy :)


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62806/#review187269
---


On Oct. 6, 2017, 10:43 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62806/
> ---
> 
> (Updated Oct. 6, 2017, 10:43 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `--disable-libtool-wrappers` to reviewbot.
> 
> 
> Diffs
> -
> 
>   support/verify-reviews.py 1077b085cdfd7772cbe0defd8dbcb4952dbfb695 
> 
> 
> Diff: https://reviews.apache.org/r/62806/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62793: Updated list of excluded files by Python linter.

2017-10-06 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62793/#review187270
---



Patch looks great!

Reviews applied: [62793]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 6, 2017, 3:12 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62793/
> ---
> 
> (Updated Oct. 6, 2017, 3:12 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This make sure that only our Python files and
> no third party libraries are being linted.
> 
> 
> Diffs
> -
> 
>   support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62793/diff/2/
> 
> 
> Testing
> ---
> 
> After this commit I have modified 'support/cpplint.py' and checked that it 
> was not linted.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62806: Added `--disable-libtool-wrappers` to reviewbot.

2017-10-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62806/#review187269
---



Looks like this doesn't pass the python linter. I thought this should've been 
caught by the pre-commit hook?

?  mesos git:(master) ./support/apply-reviews.py -r 62806
2017-10-06 08:26:28 URL:https://reviews.apache.org/r/62806/diff/raw/ [726/726] 
-> "62806.patch" [1]
No C++ files to lint
Checking 1 Python file
* Module verify-reviews
C:192, 0: Line too long (84/80) (line-too-long)
Total errors found: 1

- Vinod Kone


On Oct. 6, 2017, 10:43 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62806/
> ---
> 
> (Updated Oct. 6, 2017, 10:43 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `--disable-libtool-wrappers` to reviewbot.
> 
> 
> Diffs
> -
> 
>   support/verify-reviews.py 1077b085cdfd7772cbe0defd8dbcb4952dbfb695 
> 
> 
> Diff: https://reviews.apache.org/r/62806/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62806: Added `--disable-libtool-wrappers` to reviewbot.

2017-10-06 Thread Vinod Kone


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62806/#review187268
---


Ship it!




Ship It!

- Vinod Kone


On Oct. 6, 2017, 10:43 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62806/
> ---
> 
> (Updated Oct. 6, 2017, 10:43 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `--disable-libtool-wrappers` to reviewbot.
> 
> 
> Diffs
> -
> 
>   support/verify-reviews.py 1077b085cdfd7772cbe0defd8dbcb4952dbfb695 
> 
> 
> Diff: https://reviews.apache.org/r/62806/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62806: Added `--disable-libtool-wrappers` to reviewbot.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62806/#review187266
---



FAIL: /usr/bin/rm: cannot remove 'C:mesos/3rdparty': Directory not empty

Reviews applied: `['62806']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

- Mesos Reviewbot Windows


On Oct. 6, 2017, 6:43 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62806/
> ---
> 
> (Updated Oct. 6, 2017, 6:43 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `--disable-libtool-wrappers` to reviewbot.
> 
> 
> Diffs
> -
> 
>   support/verify-reviews.py 1077b085cdfd7772cbe0defd8dbcb4952dbfb695 
> 
> 
> Diff: https://reviews.apache.org/r/62806/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62161: Update boost version.

2017-10-06 Thread Benno Evers


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62161/
---

(Updated Oct. 6, 2017, 2:02 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Repository: mesos


Description
---

Update boost version.


Diffs (updated)
-

  3rdparty/boost-1.53.0.tar.gz 175f373c330ff69bdb0d44fc75a29982e68554ab 
  3rdparty/boost-1.65.0.tar.gz PRE-CREATION 
  3rdparty/cmake/Versions.cmake 958629642 
  3rdparty/versions.am 82d66be7d 


Diff: https://reviews.apache.org/r/62161/diff/4/

Changes: https://reviews.apache.org/r/62161/diff/3-4/


Testing
---


File Attachments (updated)


0001-Update-boost-version.patch
  
https://reviews.apache.org/media/uploaded/files/2017/10/06/6101ab66-98c3-45f3-a91b-dc046e24dca5__0001-Update-boost-version.patch


Thanks,

Benno Evers

Re: Review Request 62587: Added HTTP authenticatee interface definition.

2017-10-06 Thread Till Toenshoff



> On Oct. 6, 2017, 10:22 a.m., Alexander Rojas wrote:
> > include/mesos/authentication/http/authenticatee.hpp
> > Lines 34 (patched)
> > 
> >
> > In order to keep it consistent with the `Authenticator`, could you add 
> > a method which returns the authentication scheme used?
> > 
> > i.e.
> > 
> > ```c++
> > /**
> >   * Returns the name of the authentication scheme implemented.
> >   */
> >  virtual std::string scheme() const = 0;
> > ```
> > 
> > If basic is used, it will return Basic, and so fort.

Good point, will add that.


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62587/#review187246
---


On Oct. 2, 2017, 6:55 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62587/
> ---
> 
> (Updated Oct. 2, 2017, 6:55 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and 
> Kapil Arya.
> 
> 
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP authenticatee interface definition.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/authenticatee.hpp PRE-CREATION 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
> 
> 
> Diff: https://reviews.apache.org/r/62587/diff/4/
> 
> 
> Testing
> ---
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62587: Added HTTP authenticatee interface definition.

2017-10-06 Thread Till Toenshoff



> On Oct. 6, 2017, 9:56 a.m., Alexander Rojas wrote:
> > include/mesos/authentication/http/authenticatee.hpp
> > Lines 46 (patched)
> > 
> >
> > Any reason not to make it pure virtual?

The implementation may or may not need it - e.g. basic authentication wont hold 
any internal state.


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62587/#review187244
---


On Oct. 2, 2017, 6:55 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62587/
> ---
> 
> (Updated Oct. 2, 2017, 6:55 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and 
> Kapil Arya.
> 
> 
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP authenticatee interface definition.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/authenticatee.hpp PRE-CREATION 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
> 
> 
> Diff: https://reviews.apache.org/r/62587/diff/4/
> 
> 
> Testing
> ---
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62806: Added `--disable-libtool-wrappers` to reviewbot.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62806/#review187259
---



PASS: Mesos patch 62806 was successfully built and tested.

Reviews applied: `['62806']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62806

- Mesos Reviewbot Windows


On Oct. 6, 2017, 10:43 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62806/
> ---
> 
> (Updated Oct. 6, 2017, 10:43 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `--disable-libtool-wrappers` to reviewbot.
> 
> 
> Diffs
> -
> 
>   support/verify-reviews.py 1077b085cdfd7772cbe0defd8dbcb4952dbfb695 
> 
> 
> Diff: https://reviews.apache.org/r/62806/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-06 Thread Alexander Rojas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62594/#review187254
---




src/scheduler/scheduler.cpp
Line 257 (original), 269 (patched)


Let's replace this TODO with one sayin something like:

_add support for multi-step authentication protocols_.


- Alexander Rojas


On Oct. 2, 2017, 12:29 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62594/
> ---
> 
> (Updated Oct. 2, 2017, 12:29 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, 
> Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8021
> https://issues.apache.org/jira/browse/MESOS-8021
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated scheduler library for modularized HTTP authenticatee use.
> 
> 
> Diffs
> -
> 
>   src/scheduler/flags.hpp 1e8efc06b40b17d6fa9d9516a83893485804fc72 
>   src/scheduler/scheduler.cpp 78f53707364ab988bcc53ec2c95490df04cd9a6c 
> 
> 
> Diff: https://reviews.apache.org/r/62594/diff/2/
> 
> 
> Testing
> ---
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62594: Updated scheduler library for modularized HTTP authenticatee use.

2017-10-06 Thread Alexander Rojas



> On Sept. 28, 2017, 12:07 a.m., Greg Mann wrote:
> > src/scheduler/scheduler.cpp
> > Line 527 (original), 594 (patched)
> > 
> >
> > Hmmm... is this CHECK correct? Since this continuation is registered as 
> > an `onAny` callback, couldn't the future be in DISCARDED state? You do 
> > handle the discarded case in your new continuation.
> 
> Till Toenshoff wrote:
> We do need to validate how this invariant is guaranteed.

Interesting point you raise here, moreover because the same argument could be 
done before Till's patches (If I understand the old code right). I wonder how 
did anand ensure that the future won't be discarded. My only assumption is that 
the future is not hold by anybody before the continuation call nor afterwards.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62594/#review186483
---


On Oct. 2, 2017, 12:29 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62594/
> ---
> 
> (Updated Oct. 2, 2017, 12:29 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Armand Grillet, Benjamin Bannier, 
> Greg Mann, Kapil Arya, and Vinod Kone.
> 
> 
> Bugs: MESOS-8021
> https://issues.apache.org/jira/browse/MESOS-8021
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated scheduler library for modularized HTTP authenticatee use.
> 
> 
> Diffs
> -
> 
>   src/scheduler/flags.hpp 1e8efc06b40b17d6fa9d9516a83893485804fc72 
>   src/scheduler/scheduler.cpp 78f53707364ab988bcc53ec2c95490df04cd9a6c 
> 
> 
> Diff: https://reviews.apache.org/r/62594/diff/2/
> 
> 
> Testing
> ---
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62804: Formatted 'synchronized' like loop instead of function.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62804/#review187253
---



PASS: Mesos patch 62804 was successfully built and tested.

Reviews applied: `['62804']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62804

- Mesos Reviewbot Windows


On Oct. 6, 2017, 8:55 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62804/
> ---
> 
> (Updated Oct. 6, 2017, 8:55 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We typically format 'synchronized' like a loop, i.e., we prefer
> 
> // Loop-like formatting.
> synchronized (lock) {
>   // Body.
> }
> 
> over e.g.,
> 
> // Function-like formatting.
> synchronized(lock)
> {
>   // Body.
> }
> 
> This patch updates the clang-format configuration to treat
> 'synchronized' blocks like loops instead of functions. This just
> codifies the existing convention in the code, so that this is a NFC.
> 
> 
> Diffs
> -
> 
>   support/clang-format bb587027a6c5b3660552a654ec06766c3ed0f6fe 
> 
> 
> Diff: https://reviews.apache.org/r/62804/diff/1/
> 
> 
> Testing
> ---
> 
> Confirmed that this formats like advertized.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review187252
---



FAIL: Failed to apply the dependent review: 62333.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62333`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214

Relevant logs:

- 
[apply-review-62333-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214/logs/apply-review-62333-stdout.log):

```
error: patch failed: support/mesos-style.py:153
error: support/mesos-style.py: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 6, 2017, 9 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Oct. 6, 2017, 9 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/6/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review187251
---



FAIL: Failed to apply the dependent review: 62333.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62333`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214

Relevant logs:

- 
[apply-review-62333-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214/logs/apply-review-62333-stdout.log):

```
error: patch failed: support/mesos-style.py:153
error: support/mesos-style.py: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 6, 2017, 9 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Oct. 6, 2017, 9 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/6/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62804: Formatted 'synchronized' like loop instead of function.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62804/#review187250
---



FAIL: /usr/bin/rm: cannot remove 'C:mesos': Directory not empty

Reviews applied: `['62804']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62804

- Mesos Reviewbot Windows


On Oct. 6, 2017, 8:55 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62804/
> ---
> 
> (Updated Oct. 6, 2017, 8:55 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We typically format 'synchronized' like a loop, i.e., we prefer
> 
> // Loop-like formatting.
> synchronized (lock) {
>   // Body.
> }
> 
> over e.g.,
> 
> // Function-like formatting.
> synchronized(lock)
> {
>   // Body.
> }
> 
> This patch updates the clang-format configuration to treat
> 'synchronized' blocks like loops instead of functions. This just
> codifies the existing convention in the code, so that this is a NFC.
> 
> 
> Diffs
> -
> 
>   support/clang-format bb587027a6c5b3660552a654ec06766c3ed0f6fe 
> 
> 
> Diff: https://reviews.apache.org/r/62804/diff/1/
> 
> 
> Testing
> ---
> 
> Confirmed that this formats like advertized.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62800: Created cgroups under systemd hierarchy in LinuxLauncher.

2017-10-06 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62800/#review187249
---



Patch looks great!

Reviews applied: [62798, 62799, 62800]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 6, 2017, 6:33 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62800/
> ---
> 
> (Updated Oct. 6, 2017, 6:33 a.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-7990
> https://issues.apache.org/jira/browse/MESOS-7990
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added the support for systemd hierarchy in LinuxLauncher.
> It created the same cgroup layout under the systemd hierarchy (if
> systemd is enabled) as that in the freezer hierarchy.
> 
> This can give us a bunch of benefits:
> 1) systemd-cgls can list mesos container processes.
> 2) systemd-cgtop can show stats for mesos containers.
> 3) Avoid the pid migration issue described in MESOS-3352.
> 
> For example:
> 
> ```
> [jie@core-dev ~]$ systemd-cgls
> |-1 /usr/lib/systemd/systemd --system --deserialize 20
> |-mesos
> |  |-8282b91a-5724-4964-a623-7c6bd68ff4ad
> |  |-31737 /usr/libexec/mesos/mesos-containerizer launch
> |  |-31739 mesos-default-executor --launcher_dir=/usr/libexec/mesos
> |  |-mesos
> | |-8555f4af-fa4f-4c9c-aeb3-0c9f72e6a2de
> |   |-31791 /usr/libexec/mesos/mesos-containerizer launch
> |   |-31793 sleep 1000
> ```
> 
> 
> Diffs
> -
> 
>   src/linux/systemd.hpp f760e2c02683f0169ba5d3b0a3da53f66a7f3d91 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 554c598e2a7a53aede9d8761740d8efceb4a7e39 
> 
> 
> Diff: https://reviews.apache.org/r/62800/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> I also use the steps describe in MESOS-3352 to repo the systemd pid migration 
> issue. Didn't observe it after applying the patch.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 62806: Added `--disable-libtool-wrappers` to reviewbot.

2017-10-06 Thread Andrei Budnik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62806/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Added `--disable-libtool-wrappers` to reviewbot.


Diffs
-

  support/verify-reviews.py 1077b085cdfd7772cbe0defd8dbcb4952dbfb695 


Diff: https://reviews.apache.org/r/62806/diff/1/


Testing
---


Thanks,

Andrei Budnik

Re: Review Request 62587: Added HTTP authenticatee interface definition.

2017-10-06 Thread Alexander Rojas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62587/#review187246
---




include/mesos/authentication/http/authenticatee.hpp
Lines 34 (patched)


In order to keep it consistent with the `Authenticator`, could you add a 
method which returns the authentication scheme used?

i.e.

```c++
/**
  * Returns the name of the authentication scheme implemented.
  */
 virtual std::string scheme() const = 0;
```

If basic is used, it will return Basic, and so fort.


- Alexander Rojas


On Oct. 2, 2017, 8:55 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62587/
> ---
> 
> (Updated Oct. 2, 2017, 8:55 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and 
> Kapil Arya.
> 
> 
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP authenticatee interface definition.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/authenticatee.hpp PRE-CREATION 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
> 
> 
> Diff: https://reviews.apache.org/r/62587/diff/4/
> 
> 
> Testing
> ---
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62591: Modularized HTTP authenticatee.

2017-10-06 Thread Alexander Rojas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62591/#review187245
---


Ship it!




Ship It!

- Alexander Rojas


On Sept. 27, 2017, 12:54 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62591/
> ---
> 
> (Updated Sept. 27, 2017, 12:54 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and 
> Kapil Arya.
> 
> 
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/module/http_authenticatee.hpp PRE-CREATION 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
>   src/module/manager.cpp ec5614a6d2e9555fd8c8e35309ef05ad5c312638 
> 
> 
> Diff: https://reviews.apache.org/r/62591/diff/1/
> 
> 
> Testing
> ---
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62587: Added HTTP authenticatee interface definition.

2017-10-06 Thread Alexander Rojas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62587/#review187244
---




include/mesos/authentication/http/authenticatee.hpp
Lines 46 (patched)


Any reason not to make it pure virtual?


- Alexander Rojas


On Oct. 2, 2017, 8:55 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62587/
> ---
> 
> (Updated Oct. 2, 2017, 8:55 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, Greg Mann, and 
> Kapil Arya.
> 
> 
> Bugs: MESOS-8016
> https://issues.apache.org/jira/browse/MESOS-8016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP authenticatee interface definition.
> 
> 
> Diffs
> -
> 
>   include/mesos/authentication/http/authenticatee.hpp PRE-CREATION 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
> 
> 
> Diff: https://reviews.apache.org/r/62587/diff/4/
> 
> 
> Testing
> ---
> 
> Integration test in external project. Further tests upcoming.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 62793: Updated list of excluded files by Python linter.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62793/#review187243
---



PASS: Mesos patch 62793 was successfully built and tested.

Reviews applied: `['62793']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62793

- Mesos Reviewbot Windows


On Oct. 6, 2017, 7:12 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62793/
> ---
> 
> (Updated Oct. 6, 2017, 7:12 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This make sure that only our Python files and
> no third party libraries are being linted.
> 
> 
> Diffs
> -
> 
>   support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62793/diff/2/
> 
> 
> Testing
> ---
> 
> After this commit I have modified 'support/cpplint.py' and checked that it 
> was not linted.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62793: Updated list of excluded files by Python linter.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62793/#review187242
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62793']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62793

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62793/logs/mesos-tests-stdout.log):

```
[   OK ] ContentType/SchedulerHttpApiTest.TeardownWithoutStreamId/1 (255 ms)
[ RUN  ] ContentType/SchedulerHttpApiTest.TeardownWrongStreamId/0
[   OK ] ContentType/SchedulerHttpApiTest.TeardownWrongStreamId/0 (316 ms)
[ RUN  ] ContentType/SchedulerHttpApiTest.TeardownWrongStreamId/1
[   OK ] ContentType/SchedulerHttpApiTest.TeardownWrongStreamId/1 (360 ms)
[ RUN  ] ContentType/SchedulerHttpApiTest.MalformedUUID/0
[   OK ] ContentType/SchedulerHttpApiTest.MalformedUUID/0 (253 ms)
[ RUN  ] ContentType/SchedulerHttpApiTest.MalformedUUID/1
[   OK ] ContentType/SchedulerHttpApiTest.MalformedUUID/1 (267 ms)
[--] 28 tests from ContentType/SchedulerHttpApiTest (7888 ms total)

[--] 30 tests from ContentType/SchedulerTest
[ RUN  ] ContentType/SchedulerTest.Subscribe/0
[   OK ] ContentType/SchedulerTest.Subscribe/0 (293 ms)
[ RUN  ] ContentType/SchedulerTest.Subscribe/1
[   OK ] ContentType/SchedulerTest.Subscribe/1 (294 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerFailover/0
[   OK ] ContentType/SchedulerTest.SchedulerFailover/0 (408 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerFailover/1
[   OK ] ContentType/SchedulerTest.SchedulerFailover/1 (398 ms)
[ RUN  ] ContentType/SchedulerTest.MetricsEndpoint/0
[   OK ] ContentType/SchedulerTest.MetricsEndpoint/0 (466 ms)
[ RUN  ] ContentType/SchedulerTest.MetricsEndpoint/1
[   OK ] ContentType/SchedulerTest.MetricsEndpoint/1 (498 ms)
[ RUN  ] ContentType/SchedulerTest.TaskRunning/0
[   OK ] ContentType/SchedulerTest.TaskRunning/0 (942 ms)
[ RUN  ] ContentType/SchedulerTest.TaskRunning/1
[   OK ] ContentType/SchedulerTest.TaskRunning/1 (1007 ms)
[ RUN  ] ContentType/SchedulerTest.TaskGroupRunning/0
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62793/logs/mesos-tests-stderr.log):

```
I1006 09:11:43.996176 38896 master.cpp:9157] Updating the state of task 1 of 
framework 3b801587-9693-45b0-8f1e-05ed08cb7996- (latest state: 
TASK_FINISHED, status update state: TASK_FINISHED)
I1006 09:11:44.018175 38896 containerizer.cpp:2651] Container 
2be08d4c-fa40-4bd0-808e-d05856614a53.7dca6a4b-3e1d-4e90-a2d5-b2d1663a4bba has 
exited
I1006 09:11:44.018175 38896 containerizer.cpp:2205] Destroying container 
2be08d4c-fa40-4bd0-808e-d05856614a53.7dca6a4b-3e1d-4e90-a2d5-b2d1663a4bba in 
RUNNING state
I1006 09:11:44.019176 38896 containerizer.cpp:2751] Transitioning the state of 
container 
2be08d4c-fa40-4bd0-808e-d05856614a53.7dca6a4b-3e1d-4e90-a2d5-b2d1663a4bba from 
RUNNING to DESTROYING
I1006 09:11:44.051182 38768 master.cpp:7766] Sending 1 offers to framework 
3b801587-9693-45b0-8f1e-05ed08cb7996- (default)
I1006 09:11:44.063177 38896 launcher.cpp:156] Asked to destroy container 
2be08d4c-fa40-4bd0-808e-d05856614a53.7dca6a4b-3e1d-4e90-a2d5-b2d1663a4bba
I1006 09:11:44.070176 38896 containerizer.cpp:2489] Checkpointing termination 
state to nested container's runtime directory 
'C:\Users\mesos\AppData\Local\Temp\2\KZNq2p\containers\2be08d4c-fa40-4bd0-808e-d05856614a53\containers\7dca6a4b-3e1d-4e90-a2d5-b2d1663a4bba\termination'
I1006 09:11:44.204181 28348 http.cpp:1185] HTTP POST for 
/slave(244)/api/v1/executor from 10.3.1.7:57912
I1006 09:11:44.206181 28348 slave.cpp:4411] Handling status update 
TASK_FINISHED (UUID: b560f9c5-3e51-4adf-9e0a-3049d83d15a5) for task 2 of 
framework 3b801587-9693-45b0-8f1e-05ed08cb7996-
I1006 09:11:44.217181 30940 status_update_manager.cpp:323] Received status 
update TASK_FINISHED (UUID: b560f9c5-3e51-4adf-9e0a-3049d83d15a5) for task 2 of 
framework 3b801587-9693-45b0-8f1e-05ed08cb7996-
I1006 09:11:44.230180 38120 slave.cpp:4892] Forwarding the update TASK_FINISHED 
(UUID: b560f9c5-3e51-4adf-9e0a-3049d83d15a5) for task 2 of framework 
3b801587-9693-45b0-8f1e-05ed08cb7996- to master@10.3.1.7:57066
I1006 09:11:44.232180 34100 master.cpp:6993] Status update TASK_FINISHED (UUID: 
b560f9c5-3e51-4adf-9e0a-3049d83d15a5) for task 2 of framework 
3b801587-9693-45b0-8f1e-05ed08cb7996- from agent 
3b801587-9693-45b0-8f1e-05ed08cb7996-S0 at slave(244)@10.3.1.7:57066 
(mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1006 09:11:44.233181 34100 master.cpp:7055] Forwarding status update

Re: Review Request 62214: Added JavaScript linter.

2017-10-06 Thread Armand Grillet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/
---

(Updated Oct. 6, 2017, 9 a.m.)


Review request for mesos, Benjamin Mahler and Kevin Klues.


Changes
---

Resolved issues.


Bugs: MESOS-7924
https://issues.apache.org/jira/browse/MESOS-7924


Repository: mesos


Description
---

This linter runs when changes on a JavaScript file are being committed.
The linter used is ESLint with a configuration based on our current JS
code base. The linter and its dependencies (i.e. Node.js) are installed
in a environment using Virtualenv and then Nodeenv.


Diffs (updated)
-

  src/webui/.eslintrc.js PRE-CREATION 
  src/webui/.gitignore PRE-CREATION 
  src/webui/bootstrap PRE-CREATION 
  src/webui/pip-requirements.txt PRE-CREATION 
  support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 


Diff: https://reviews.apache.org/r/62214/diff/6/

Changes: https://reviews.apache.org/r/62214/diff/5-6/


Testing
---

Following this commit, I have tried to commit a change on a JavaScript file and 
checked that ESLinter was correctly running.


Thanks,

Armand Grillet

Review Request 62804: Formatted 'synchronized' like loop instead of function.

2017-10-06 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62804/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

We typically format 'synchronized' like a loop, i.e., we prefer

// Loop-like formatting.
synchronized (lock) {
  // Body.
}

over e.g.,

// Function-like formatting.
synchronized(lock)
{
  // Body.
}

This patch updates the clang-format configuration to treat
'synchronized' blocks like loops instead of functions. This just
codifies the existing convention in the code, so that this is a NFC.


Diffs
-

  support/clang-format bb587027a6c5b3660552a654ec06766c3ed0f6fe 


Diff: https://reviews.apache.org/r/62804/diff/1/


Testing
---

Confirmed that this formats like advertized.


Thanks,

Benjamin Bannier

Re: Review Request 60628: Enable fetcher_tests.cpp unit test module on Windows platform.

2017-10-06 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60628/#review187238
---



Patch looks great!

Reviews applied: [60291, 60292, 60293, 60294, 60295, 60296, 60297, 60298, 
60299, 60300, 60302, 60304, 60305, 60307, 60308, 60310, 60311, 60313, 60314, 
60315, 60316, 60317, 60318, 60319, 60320, 60321, 60322, 60323, 60324, 60325, 
60326, 60327, 60328, 60329, 60330, 60331, 60332, 60333, 60334, 60335, 60336, 
60337, 60338, 60339, 60340, 60341, 60342, 60343, 60344, 60345, 60620, 60621, 
60622, 60623, 60624, 60625, 60626, 60628]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 6, 2017, 4:04 a.m., Jeff Coffler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60628/
> ---
> 
> (Updated Oct. 6, 2017, 4:04 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and 
> Li Li.
> 
> 
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Document that some FetcherTest tests won't work on Windows platform.
>   Tests for tar, gzip, and such won't be working on Windows for
>   the time being. Thoughts are to provide this capability to the
>   Fetcher in a cross-platform manner via a programmatic code library
>   rather than Linux-specific command line tools (tar, gzip, etc).
> 
>   In the short term, zip and unzip will work since PowerShell can
>   support that natively.
> 
> Fix FetcherTest.AbsoluteCustomSubdirectoryFails on Windows platform.
> Test FetcherTest.InvalidUser can't work on Windows for now.
> Fix test FetcherTest.NonExistingFile on Windows platform.
> Fix test FetcherTest.AbsolutePath on Windows platform.
> Fix test FetcherTest.RelativeFilePath on Windows platform.
> Fix test FetcherTest.OSNetUriTest on Windows platform.
> Fix test FetcherTest.OSNetUriSpaceTest on Windows platform.
> Fix test FetcherTest.FileLocalhostURI on Windows platform.
> Fix test FetcherTest.Unzip_ExtractFile on Windows platform.
> Fix test FetcherTest.Unzip_ExtractInvalidFile on Windows platform.
> Fix test Unzip_ExtractFileWithDuplicatedEntries on Windows platform.
> Fix test FetcherTest.UseCustomOutputFile on Windows platform.
> 
> 
> Diffs
> -
> 
>   src/launcher/CMakeLists.txt c7a83d476efe13d65fa529e7676b6488eb48f44b 
>   src/launcher/fetcher.cpp 5a9e93adbf2e4f0b8ff64a69e62fea5f6a0b8f2d 
>   src/slave/containerizer/fetcher.cpp 
> ba5b0979aa427c5b3dbacf39661d6027da13e0d6 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/fetcher_tests.cpp df9d2d9586a6457004506c4e2a972ccfc912c7c5 
> 
> 
> Diff: https://reviews.apache.org/r/60628/diff/2/
> 
> 
> Testing
> ---
> 
> See upstream.
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>

Re: Review Request 62793: Updated list of excluded files by Python linter.

2017-10-06 Thread Armand Grillet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62793/
---

(Updated Oct. 6, 2017, 7:12 a.m.)


Review request for mesos, Alexander Rukletsov and Kevin Klues.


Changes
---

Rebased.


Summary (updated)
-

Updated list of excluded files by Python linter.


Repository: mesos


Description (updated)
---

This make sure that only our Python files and
no third party libraries are being linted.


Diffs (updated)
-

  support/cpplint.py d8f93cf51bdc0a547f12cc3aee60313a384317dd 
  support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 


Diff: https://reviews.apache.org/r/62793/diff/2/

Changes: https://reviews.apache.org/r/62793/diff/1-2/


Testing
---

After this commit I have modified 'support/cpplint.py' and checked that it was 
not linted.


Thanks,

Armand Grillet

Re: Review Request 62800: Created cgroups under systemd hierarchy in LinuxLauncher.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62800/#review187236
---



PASS: Mesos patch 62800 was successfully built and tested.

Reviews applied: `['62798', '62799', '62800']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62800

- Mesos Reviewbot Windows


On Oct. 6, 2017, 4:33 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62800/
> ---
> 
> (Updated Oct. 6, 2017, 4:33 a.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-7990
> https://issues.apache.org/jira/browse/MESOS-7990
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added the support for systemd hierarchy in LinuxLauncher.
> It created the same cgroup layout under the systemd hierarchy (if
> systemd is enabled) as that in the freezer hierarchy.
> 
> This can give us a bunch of benefits:
> 1) systemd-cgls can list mesos container processes.
> 2) systemd-cgtop can show stats for mesos containers.
> 3) Avoid the pid migration issue described in MESOS-3352.
> 
> For example:
> 
> ```
> [jie@core-dev ~]$ systemd-cgls
> |-1 /usr/lib/systemd/systemd --system --deserialize 20
> |-mesos
> |  |-8282b91a-5724-4964-a623-7c6bd68ff4ad
> |  |-31737 /usr/libexec/mesos/mesos-containerizer launch
> |  |-31739 mesos-default-executor --launcher_dir=/usr/libexec/mesos
> |  |-mesos
> | |-8555f4af-fa4f-4c9c-aeb3-0c9f72e6a2de
> |   |-31791 /usr/libexec/mesos/mesos-containerizer launch
> |   |-31793 sleep 1000
> ```
> 
> 
> Diffs
> -
> 
>   src/linux/systemd.hpp f760e2c02683f0169ba5d3b0a3da53f66a7f3d91 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 554c598e2a7a53aede9d8761740d8efceb4a7e39 
> 
> 
> Diff: https://reviews.apache.org/r/62800/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> I also use the steps describe in MESOS-3352 to repo the systemd pid migration 
> issue. Didn't observe it after applying the patch.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62800: Created cgroups under systemd hierarchy in LinuxLauncher.

2017-10-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62800/#review187237
---



PASS: Mesos patch 62800 was successfully built and tested.

Reviews applied: `['62798', '62799', '62800']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62800

- Mesos Reviewbot Windows


On Oct. 6, 2017, 4:33 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62800/
> ---
> 
> (Updated Oct. 6, 2017, 4:33 a.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-7990
> https://issues.apache.org/jira/browse/MESOS-7990
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added the support for systemd hierarchy in LinuxLauncher.
> It created the same cgroup layout under the systemd hierarchy (if
> systemd is enabled) as that in the freezer hierarchy.
> 
> This can give us a bunch of benefits:
> 1) systemd-cgls can list mesos container processes.
> 2) systemd-cgtop can show stats for mesos containers.
> 3) Avoid the pid migration issue described in MESOS-3352.
> 
> For example:
> 
> ```
> [jie@core-dev ~]$ systemd-cgls
> |-1 /usr/lib/systemd/systemd --system --deserialize 20
> |-mesos
> |  |-8282b91a-5724-4964-a623-7c6bd68ff4ad
> |  |-31737 /usr/libexec/mesos/mesos-containerizer launch
> |  |-31739 mesos-default-executor --launcher_dir=/usr/libexec/mesos
> |  |-mesos
> | |-8555f4af-fa4f-4c9c-aeb3-0c9f72e6a2de
> |   |-31791 /usr/libexec/mesos/mesos-containerizer launch
> |   |-31793 sleep 1000
> ```
> 
> 
> Diffs
> -
> 
>   src/linux/systemd.hpp f760e2c02683f0169ba5d3b0a3da53f66a7f3d91 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> 554c598e2a7a53aede9d8761740d8efceb4a7e39 
> 
> 
> Diff: https://reviews.apache.org/r/62800/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> I also use the steps describe in MESOS-3352 to repo the systemd pid migration 
> issue. Didn't observe it after applying the patch.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

75 matches

Mail list logo