Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189882
---



Who is hausdorff and why is this their TODO?

- Andrew Schwartzmeyer


On Nov. 1, 2017, 10:27 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> ---
> 
> (Updated Nov. 1, 2017, 10:27 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 63499: Fixed the unit test that broke Windows build.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/
---

Review request for mesos, Andrew Schwartzmeyer and Vinod Kone.


Repository: mesos


Description
---

Fixed the unit test that broke Windows build.


Diffs
-

  src/tests/default_executor_tests.cpp 21950f57e9eae741ac219d930fe9c4fc94d4f47f 


Diff: https://reviews.apache.org/r/63499/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 63389: WIP: Added a mock resource provider manager.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63389/
---

(Updated Nov. 2, 2017, 4:44 a.m.)


Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.


Bugs: MESOS-8144
https://issues.apache.org/jira/browse/MESOS-8144


Repository: mesos


Description
---

This patch adds a `ResourceProviderManager*` parameter to the slave
constructor, so we can pass in a mock resource provider manager. The
mock manager can be used to test against either the agent or the
resource provider.

The declaration of `ResourceProviderManagerProcess` is moved to a
separated `manager_process.hpp` header file so we can mock the internal
process.


Diffs (updated)
-

  src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 
  src/local/local.cpp 99c1b087d75a1759ed61a4e6178e15919bee1e77 
  src/resource_provider/manager.hpp 3b70e75c6b6721864ae0ee9c4a593b5035d8388f 
  src/resource_provider/manager.cpp 11f890156f0fd099f8a97b07cdc458a0726ee78e 
  src/resource_provider/manager_process.hpp PRE-CREATION 
  src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7 
  src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 
  src/tests/cluster.hpp 65634121b7fe076a7cd9a1c5aa6101a96b1c009d 
  src/tests/cluster.cpp d657da6d84e5ea28e0dad180dce069de569c5d38 
  src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 
  src/tests/mesos.cpp 9185b5bf2175be5b0f6b6a03a04e9e5445bf22fd 
  src/tests/mock_slave.hpp 57189cee20511d145ae6b47a4dc2c66a14638dad 
  src/tests/mock_slave.cpp db24f9e5b71f558d2f811f0da8a9cc9c7c2dd341 
  src/tests/resource_provider/mock_manager.hpp PRE-CREATION 
  src/tests/resource_provider/mock_manager.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63389/diff/4/

Changes: https://reviews.apache.org/r/63389/diff/3-4/


Testing
---

make


Thanks,

Chun-Hung Hsiao

Re: Review Request 63496: Added tests for agent resource version transmission.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63496/#review189879
---



FAIL: Mesos tests failed to build.

Reviews applied: `['61183', '63491', '63492', '63493', '63494', '63495', 
'63496']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63496

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63496/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2072): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
'argument': conversion from 'double' to 'float', possible loss of data 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
'argument': truncation from 'double' to 'float' 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2072): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2072): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  

Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/#review189878
---


Ship it!




Mind splitting the folder level readme from the concurrent queue into separate 
patches? Also, a ticket about the repo bloat issue would be great.

Is it compressed with maximum compression?

- Benjamin Mahler


On Nov. 1, 2017, 9:45 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63472/
> ---
> 
> (Updated Nov. 1, 2017, 9:45 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Our upstreamed PR to the `concurrentqueue` project was merged,
> (https://github.com/cameron314/concurrentqueue/commit/420509b)
> which fixes the Clang / libstdc++ configuration. Since there are
> a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
> we bundle the latest SHA on `master` here.
> 
> 
> Diffs
> -
> 
>   3rdparty/README.md PRE-CREATION 
>   3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
>   3rdparty/concurrentqueue-1.0.0-beta.tar.gz 
> 1bf4a88362e7d60cd22474f20fff62f788539308 
>   3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
>   3rdparty/concurrentqueue.md PRE-CREATION 
>   3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 
> 
> 
> Diff: https://reviews.apache.org/r/63472/diff/1/
> 
> 
> Testing
> ---
> 
> With Clang-3.9.0
> ```bash
> CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl 
> --enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue 
> --disable-java --disable-python
> make distcheck
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/#review189876
---



Bad patch!

Reviews applied: [63472]

Failed command: python support/apply-reviews.py -n -r 63472

Error:
2017-11-02 04:03:28 URL:https://reviews.apache.org/r/63472/diff/raw/ 
[3272/3272] -> "63472.patch" [1]
error: missing binary patch data for '3rdparty/concurrentqueue-7b69a8f.tar.gz'
error: binary patch does not apply to '3rdparty/concurrentqueue-7b69a8f.tar.gz'
error: 3rdparty/concurrentqueue-7b69a8f.tar.gz: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19967/console

- Mesos Reviewbot


On Nov. 1, 2017, 2:45 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63472/
> ---
> 
> (Updated Nov. 1, 2017, 2:45 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Our upstreamed PR to the `concurrentqueue` project was merged,
> (https://github.com/cameron314/concurrentqueue/commit/420509b)
> which fixes the Clang / libstdc++ configuration. Since there are
> a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
> we bundle the latest SHA on `master` here.
> 
> 
> Diffs
> -
> 
>   3rdparty/README.md PRE-CREATION 
>   3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
>   3rdparty/concurrentqueue-1.0.0-beta.tar.gz 
> 1bf4a88362e7d60cd22474f20fff62f788539308 
>   3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
>   3rdparty/concurrentqueue.md PRE-CREATION 
>   3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 
> 
> 
> Diff: https://reviews.apache.org/r/63472/diff/1/
> 
> 
> Testing
> ---
> 
> With Clang-3.9.0
> ```bash
> CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl 
> --enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue 
> --disable-java --disable-python
> make distcheck
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 63389: WIP: Added a mock resource provider manager.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63389/
---

(Updated Nov. 2, 2017, 3:28 a.m.)


Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
---

Rebased.


Summary (updated)
-

WIP: Added a mock resource provider manager.


Bugs: MESOS-8144
https://issues.apache.org/jira/browse/MESOS-8144


Repository: mesos


Description
---

This patch adds a `ResourceProviderManager*` parameter to the slave
constructor, so we can pass in a mock resource provider manager. The
mock manager can be used to test against either the agent or the
resource provider.

The declaration of `ResourceProviderManagerProcess` is moved to a
separated `manager_process.hpp` header file so we can mock the internal
process.


Diffs (updated)
-

  src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 
  src/local/local.cpp 99c1b087d75a1759ed61a4e6178e15919bee1e77 
  src/resource_provider/manager.hpp 3b70e75c6b6721864ae0ee9c4a593b5035d8388f 
  src/resource_provider/manager.cpp 11f890156f0fd099f8a97b07cdc458a0726ee78e 
  src/resource_provider/manager_process.hpp PRE-CREATION 
  src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7 
  src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 
  src/tests/cluster.hpp 65634121b7fe076a7cd9a1c5aa6101a96b1c009d 
  src/tests/cluster.cpp d657da6d84e5ea28e0dad180dce069de569c5d38 
  src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 
  src/tests/mesos.cpp 9185b5bf2175be5b0f6b6a03a04e9e5445bf22fd 
  src/tests/mock_slave.hpp 57189cee20511d145ae6b47a4dc2c66a14638dad 
  src/tests/mock_slave.cpp db24f9e5b71f558d2f811f0da8a9cc9c7c2dd341 
  src/tests/resource_provider/mock_manager.hpp PRE-CREATION 
  src/tests/resource_provider/mock_manager.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63389/diff/3/

Changes: https://reviews.apache.org/r/63389/diff/2-3/


Testing
---

make


Thanks,

Chun-Hung Hsiao

Re: Review Request 62774: Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`.

[Qian Zhang]

> On Nov. 2, 2017, 12:47 a.m., Gaston Kleiman wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 4168-4169 (patched)
> > 
> >
> > I don't think this test passes now that the built-in executors send 
> > `TASK_STARTING` updates.

Sorry my bad, I have posted a patch (https://reviews.apache.org/r/63497/) to 
fix it.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62774/#review189811
---


On Oct. 4, 2017, 11:48 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62774/
> ---
> 
> (Updated Oct. 4, 2017, 11:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 45f0d1dbc5b21b174cd9974664299d466129df01 
> 
> 
> Diff: https://reviews.apache.org/r/62774/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 63497: Fixed the unit test that missed to check the TASK_STARTING update.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63497/
---

Review request for mesos, Alexander Rukletsov, Gaston Kleiman, and Vinod Kone.


Repository: mesos


Description
---

Fixed the unit test that missed to check the TASK_STARTING update.


Diffs
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
ad05da6c227cdc5f6bc3ea8b8e6207cea0569e36 


Diff: https://reviews.apache.org/r/63497/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 63485: Added initial code for offer operation status update in master.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63485/#review189868
---



FAIL: Failed to apply the dependent review: 59988.

Failed command: `python.exe .\support\apply-reviews.py -n -r 59988`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63485

Relevant logs:

- 
[apply-review-59988-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63485/logs/apply-review-59988-stdout.log):

```
error: patch failed: 3rdparty/stout/tests/protobuf_tests.proto:24
error: 3rdparty/stout/tests/protobuf_tests.proto: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 1, 2017, 4:18 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63485/
> ---
> 
> (Updated Nov. 1, 2017, 4:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, 
> Greg Mann, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added initial code for offer operation status update in master.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3 
>   src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28 
> 
> 
> Diff: https://reviews.apache.org/r/63485/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63174/#review189867
---



FAIL: Mesos tests failed to build.

Reviews applied: `['63174']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63174

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63174/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
'argument': conversion from 'double' to 'float', possible loss of data 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
'argument': truncation from 'double' to 'float' 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning 

Review Request 63493: Transmitted agent resource versions in (re)registration.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63493/
---

Review request for mesos, Gaston Kleiman, Greg Mann, Jie Yu, and Jan Schlicht.


Repository: mesos


Description
---

This commit introduces resource version fields into agent registration
and reregistration message. The agent is changed to set these fields
when needed; the master in turn stores the versions for use in to be
added speculated offer operations.


Diffs
-

  src/messages/messages.proto 2fbca22e1285aa25900f5420bb4370bda6a1bb12 
  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 


Diff: https://reviews.apache.org/r/63493/diff/1/


Testing
---

`make check`, additional testing as part of https://reviews.apache.org/r/63496/.


Thanks,

Benjamin Bannier

Review Request 63494: Removed unused declaration.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63494/
---

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
---

The declaration of this operator was not needed here. It was also
done in a surprising namespace as the 'Task' equality operator lives
in the 'mesos' namespace while this declaration was in
'mesos::internal'.


Diffs
-

  src/messages/messages.hpp 59e670532c8eb1ab1ec6cb063ace03481cd6a33d 


Diff: https://reviews.apache.org/r/63494/diff/1/


Testing
---

`make check`, additional testing as part of https://reviews.apache.org/r/63496/.


Thanks,

Benjamin Bannier

Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63491/
---

Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.


Repository: mesos


Description
---

This patch surfaces this information to resource provider manager
users like the agent. In a later patch we will modify the agent to
forward this information to the master.


Diffs
-

  src/resource_provider/manager.cpp 11f890156f0fd099f8a97b07cdc458a0726ee78e 
  src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521 


Diff: https://reviews.apache.org/r/63491/diff/1/


Testing
---

`make check`, additional testing as part of https://reviews.apache.org/r/63496/.


Thanks,

Benjamin Bannier

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61183/
---

(Updated Nov. 2, 2017, 2:57 a.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
---

Reopened and rebased as patch was reverted in 
`a3faf6cf854cd64271bff7246ace13acfa37e731`.


Repository: mesos


Description
---

The agent's resource provider manager sends a
'ResourceProviderMessage' when its managed resources change. This
commit adds handling in the agent so that an 'UpdateSlaveMessage' is
sent to the master to update the total resource available on the
agent.

In order to provide push-like handling of the resource provider
manager's message queue, we chain recursive calls to the handler for
continuous processing. Initially, processing is kicked off from
'Slave::initialize'. In this simple implementation we e.g., provide no
direct way to stop processing of messages, yet, but it can be achieved
by e.g., replacing the manager with a new instance (this would also
require updating routes).

Since the agent can only send an 'UpdateSlaveMessage' when it is
registered with a master, a simple back-off of 5 s is implemented which
will defer processing of a ready message should the agent not yet have
registered.

To facilitate logging we add a stringification function for
'ResourceProviderMessage's.

This patch also adjusts a number of tests to no expect two
'UpdateSlaveMessage's.


Diffs (updated)
-

  src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521 
  src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 
  src/tests/oversubscription_tests.cpp d262bbe06787f70427f4f7820e64891c7d1b5552 
  src/tests/slave_tests.cpp aae5e6021b46793fa2b871aaa738f61c8cfb88ce 


Diff: https://reviews.apache.org/r/61183/diff/18/

Changes: https://reviews.apache.org/r/61183/diff/17-18/


Testing
---

Tested on a number of platforms on internal CI.


Thanks,

Benjamin Bannier

Review Request 63495: Added comparison operators for 'ResourceVerionUUID'.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63495/
---

Review request for mesos, Jie Yu and Jan Schlicht.


Repository: mesos


Description
---

Added comparison operators for 'ResourceVerionUUID'.


Diffs
-

  src/messages/messages.hpp 59e670532c8eb1ab1ec6cb063ace03481cd6a33d 
  src/messages/messages.cpp 7f1da63ae67b3918851c2c1dd225bfd2d0044387 


Diff: https://reviews.apache.org/r/63495/diff/1/


Testing
---

`make check`, additional testing as part of https://reviews.apache.org/r/63496/.


Thanks,

Benjamin Bannier

Review Request 63492: Synchronized agent clock with master via 'UpdateSlaveMessage'.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63492/
---

Review request for mesos, Gaston Kleiman, Greg Mann, Jie Yu, and Jan Schlicht.


Repository: mesos


Description
---

This commit introduces agent clocks to the master and agents. Agents
are responsible for maintaining their clock. The clocks are
synchronized with the master via 'UpdateSlaveMessage'.


Diffs
-

  src/master/master.hpp afcc2e46882e4c610e9047ab3db7b6f100d47e17 
  src/master/master.cpp 49bc50ead75adba82a7d8de23a87b06ccd269c48 
  src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 


Diff: https://reviews.apache.org/r/63492/diff/1/


Testing
---

`make check`, additional testing as part of https://reviews.apache.org/r/63496/.


Thanks,

Benjamin Bannier

Review Request 63496: Added tests for agent resource version transmission.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63496/
---

Review request for mesos, Jie Yu and Jan Schlicht.


Repository: mesos


Description
---

This patch introduces separate tests for clock values communicated
from resource providers and from agents to masters.


Diffs
-

  src/tests/slave_tests.cpp aae5e6021b46793fa2b871aaa738f61c8cfb88ce 


Diff: https://reviews.apache.org/r/63496/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 63468: Added TERMINATED state to processes.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63468/#review189865
---


Ship it!




Could we avoid the shared pointer per the discussion? By performing the state 
change before calling `SocketManager::exited`?

- Benjamin Mahler


On Nov. 1, 2017, 3:17 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63468/
> ---
> 
> (Updated Nov. 1, 2017, 3:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added TERMINATED state to processes.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/process.hpp 
> dc3375ce62556322eb2bc60ade61f313ade123b8 
>   3rdparty/libprocess/src/process.cpp 
> 71ae7129ffbd0e22eda2863b17bbcf588298c37b 
> 
> 
> Diff: https://reviews.apache.org/r/63468/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63353/#review189861
---



Per offline discussion, looks like we don't actually need to be clearing it?

- Benjamin Mahler


On Nov. 1, 2017, 8:53 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63353/
> ---
> 
> (Updated Nov. 1, 2017, 8:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
> https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the agent would sometimes clear the executor ID of
> non-command executors before sending the `ReregisterSlaveMessage`
> message.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 
> 
> 
> Diff: https://reviews.apache.org/r/63353/diff/2/
> 
> 
> Testing
> ---
> 
> Verified that the new test fails on GNU/Linux without the rest of the patch, 
> but passes with it.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 63476: Revert "Added a test `ROOT_NoTransitionFromKillingToFinished`".

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63476/#review189859
---



PASS: Mesos patch 63476 was successfully built and tested.

Reviews applied: `['63476']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63476

- Mesos Reviewbot Windows


On Nov. 1, 2017, 9:04 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63476/
> ---
> 
> (Updated Nov. 1, 2017, 9:04 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Vinod Kone.
> 
> 
> Bugs: MESOS-8157
> https://issues.apache.org/jira/browse/MESOS-8157
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This reverts commit 815263ead42f64fd0ff320614cfada30b2e8f899.
> 
> The commit being reverted introduced a build break on Windows.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
>   src/tests/kill_policy_test_helper.cpp 
> 28768a3fc02e3e6b2a0f531e6b6b2865aab51f3d 
> 
> 
> Diff: https://reviews.apache.org/r/63476/diff/1/
> 
> 
> Testing
> ---
> 
> Successfully built on Windows after failing to build before the revert.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 63485: Added initial code for offer operation status update in master.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63485/
---

Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, 
Greg Mann, and Jan Schlicht.


Repository: mesos


Description
---

Added initial code for offer operation status update in master.


Diffs
-

  src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3 
  src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28 


Diff: https://reviews.apache.org/r/63485/diff/1/


Testing
---

make check


Thanks,

Jie Yu

Review Request 63484: Changed slave_id field to be optional in OfferOperationStatusUpdate.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63484/
---

Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, 
Greg Mann, and Jan Schlicht.


Repository: mesos


Description
---

We plan to reuse this message for communication between resource
provider manager in the master to master as well.


Diffs
-

  src/messages/messages.proto 9dfe7f07c2e1171be17f1bd7b6a54a80410c44f6 


Diff: https://reviews.apache.org/r/63484/diff/1/


Testing
---

make check


Thanks,

Jie Yu

Review Request 63483: Added some protobuf helper for offer operations.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63483/
---

Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, 
Greg Mann, and Jan Schlicht.


Repository: mesos


Description
---

Added some protobuf helper for offer operations.


Diffs
-

  src/common/protobuf_utils.hpp da0a84eb828e2fb064ba466d9e525cd3a85fc43a 
  src/common/protobuf_utils.cpp 4ce7021b01b9fb52ae1a8d95aa686c5b79164d67 


Diff: https://reviews.apache.org/r/63483/diff/1/


Testing
---

make check


Thanks,

Jie Yu

Review Request 63482: Added streaming function for OfferOperationState.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63482/
---

Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, 
Greg Mann, and Jan Schlicht.


Repository: mesos


Description
---

Added streaming function for OfferOperationState.


Diffs
-

  include/mesos/type_utils.hpp 290b0aa48c20d4f73d0573934dfc8cd022798477 
  include/mesos/v1/mesos.hpp 1b08d7a48e7d51e0a10c91c52347985198539c8c 
  src/common/type_utils.cpp e40d87c962e1a4ad25ec2368a904254cb28f2738 
  src/v1/mesos.cpp 306f7e497e74fe9e377ae98efcdf7a9a67863445 


Diff: https://reviews.apache.org/r/63482/diff/1/


Testing
---

make check


Thanks,

Jie Yu

Review Request 63481: Added latest_status field to OfferOperation protobuf.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63481/
---

Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, 
Greg Mann, and Jan Schlicht.


Repository: mesos


Description
---

Added latest_status field to OfferOperation protobuf.


Diffs
-

  include/mesos/mesos.proto 4966cd259d5c804b835f79325c197f0b68080291 
  include/mesos/v1/mesos.proto e18ac00d6161f1e763b4134cbf7c67501f352048 


Diff: https://reviews.apache.org/r/63481/diff/1/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 63432: Updated the comment about slaves.removed in master.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63432/
---

(Updated Nov. 1, 2017, 11:14 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Changes
---

Rebased.


Repository: mesos


Description
---

Updated the comment about slaves.removed in master.


Diffs (updated)
-

  src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3 


Diff: https://reviews.apache.org/r/63432/diff/2/

Changes: https://reviews.apache.org/r/63432/diff/1-2/


Testing
---

trivial


Thanks,

Jie Yu

Review Request 63480: Added the initial implementation for applying offer operations.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63480/
---

Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, 
Greg Mann, and Jan Schlicht.


Repository: mesos


Description
---

The resource provider manager provides an `applyOfferOperation` method
for offer operation affecting resource providers. The resources on
which the operation should be applied contains a resource provider ID.
This will be extracted and an event will be sent to the respective
resource provider.

(This is based on https://reviews.apache.org/r/61810)


Diffs
-

  src/messages/messages.proto 9dfe7f07c2e1171be17f1bd7b6a54a80410c44f6 
  src/resource_provider/manager.hpp 3b70e75c6b6721864ae0ee9c4a593b5035d8388f 
  src/resource_provider/manager.cpp 11f890156f0fd099f8a97b07cdc458a0726ee78e 
  src/slave/slave.cpp 817dca4fc3e1028ccc13b8a1bb1ee783afb77166 


Diff: https://reviews.apache.org/r/63480/diff/1/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 63414: Added a helper to get the resoruce provider ID from an offer operation.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63414/
---

(Updated Nov. 1, 2017, 11:11 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
---

Addressed comments.


Bugs: MESOS-7235
https://issues.apache.org/jira/browse/MESOS-7235


Repository: mesos


Description
---

Added a helper to get the resoruce provider ID from an offer operation.


Diffs (updated)
-

  src/common/resources_utils.hpp 18e3d9d4baad23669d00542594f5c15a989b7b9e 
  src/common/resources_utils.cpp e34cd8a3c9046a6f12c12a275a7b3a852b492f4c 


Diff: https://reviews.apache.org/r/63414/diff/2/

Changes: https://reviews.apache.org/r/63414/diff/1-2/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 63414: Added a helper to get the resoruce provider ID from an offer operation.

[Jie Yu]

> On Oct. 30, 2017, 3:44 p.m., Benjamin Bannier wrote:
> > src/common/resources_utils.cpp
> > Lines 97 (patched)
> > 
> >
> > We should try to prevent the initialization and copy assignement of 
> > `resource`, e.g.,
> > 
> > 
> > Resource* resource = nullptr;
> > 
> > switch (operation.type()) {
> >   // Possibly assign to `resource`.
> > }
> > 
> > CHECK_NOT_NULL(resource);
> > 
> > if (resource->has_provider_id()) {
> >   return resource->provider_id();
> > }
> > 
> > return None();

I used `Option` here. Using pointer is tricky because the parameter 
we passed in is const.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63414/#review189597
---


On Oct. 30, 2017, 3:33 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63414/
> ---
> 
> (Updated Oct. 30, 2017, 3:33 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-7235
> https://issues.apache.org/jira/browse/MESOS-7235
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a helper to get the resoruce provider ID from an offer operation.
> 
> 
> Diffs
> -
> 
>   src/common/resources_utils.hpp 18e3d9d4baad23669d00542594f5c15a989b7b9e 
>   src/common/resources_utils.cpp e34cd8a3c9046a6f12c12a275a7b3a852b492f4c 
> 
> 
> Diff: https://reviews.apache.org/r/63414/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 63479: Migrated `3rdparty/mesos-3rdparty` to `mesos/3rdparty`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63479/#review189855
---



FAIL: Mesos stdout-tests failed to build.

Reviews applied: `['63479']`

Failed command: `cmake.exe --build . --target stout-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63479

Relevant logs:

- 
[stout-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63479/logs/stout-tests-build-cmake-stdout.log):

```
  CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/libapr-1.5.2.tar.gz' failed 
[C:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
  CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[C:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
  CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/libapr-1.5.2.tar.gz' failed 
[C:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
  CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[C:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
  CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/libapr-1.5.2.tar.gz' failed 
[C:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
  CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[C:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
  CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/libapr-1.5.2.tar.gz' failed 
[C:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]
  CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[C:\DCOS\mesos\3rdparty\libapr-1.5.2.vcxproj]


"C:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
"C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj" (default target) (11) ->
  CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/zlib-1.2.8.tar.gz' failed 
[C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]
  CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]
  CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/zlib-1.2.8.tar.gz' failed 
[C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]
  CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]
  CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/zlib-1.2.8.tar.gz' failed 
[C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]
  CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]
  CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/zlib-1.2.8.tar.gz' failed 
[C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]
  CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]
  CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/zlib-1.2.8.tar.gz' failed 
[C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]
  CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]
  CUSTOMBUILD : error : downloading 
'https://github.com/mesos/3rdparty/raw/master/zlib-1.2.8.tar.gz' failed 
[C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]
  CUSTOMBUILD : The requested URL returned error : 404 Not Found 
[C:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]

26 Warning(s)
48 Error(s)

Time Elapsed 00:11:59.66
```

- 
[stdout-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63479/logs/stdout-tests-CMakeOutput.log):

```
  Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_445b6.dir\Debug\cmTC_445b6.tlog\".

InitializeBuildStatus:

  Creating "cmTC_445b6.dir\Debug\cmTC_445b6.tlog\unsuccessfulbuild" because 
"AlwaysCreate" was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi 
/W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D 
COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 
/MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR 
/Fo"cmTC_445b6.dir\Debug\" /Fd"cmTC_445b6.dir\Debug\vc141.pdb" /Gd /TP 
/errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D 
COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 
/MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR 
/Fo"cmTC_445b6.dir\Debug\" /Fd"cmTC_445b6.dir\Debug\vc141.pdb" /Gd /TP 
/errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual 

Re: Review Request 63413: Added streaming functions for offer operation ID.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63413/
---

(Updated Nov. 1, 2017, 11:10 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
---

Rebased.


Bugs: MESOS-7235
https://issues.apache.org/jira/browse/MESOS-7235


Repository: mesos


Description
---

Added streaming functions for offer operation ID.


Diffs (updated)
-

  include/mesos/type_utils.hpp 290b0aa48c20d4f73d0573934dfc8cd022798477 
  include/mesos/v1/mesos.hpp 1b08d7a48e7d51e0a10c91c52347985198539c8c 
  src/common/type_utils.cpp e40d87c962e1a4ad25ec2368a904254cb28f2738 
  src/v1/mesos.cpp 306f7e497e74fe9e377ae98efcdf7a9a67863445 


Diff: https://reviews.apache.org/r/63413/diff/2/

Changes: https://reviews.apache.org/r/63413/diff/1-2/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 63474: Added a regression test for MESOS-8135.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/#review189854
---



Patch looks great!

Reviews applied: [63353, 63474]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 1, 2017, 8:54 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63474/
> ---
> 
> (Updated Nov. 1, 2017, 8:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
> https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a regression test for MESOS-8135.
> 
> 
> Diffs
> -
> 
>   src/tests/master_slave_reconciliation_tests.cpp 
> d5eb7ba68c5308338236879e7cb1e970a01e48e6 
> 
> 
> Diff: https://reviews.apache.org/r/63474/diff/1/
> 
> 
> Testing
> ---
> 
> Test passes on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/#review189853
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 63472`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63472

Relevant logs:

- 
[apply-review-63472-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63472/logs/apply-review-63472-stdout.log):

```
error: missing binary patch data for '3rdparty/concurrentqueue-7b69a8f.tar.gz'
error: binary patch does not apply to '3rdparty/concurrentqueue-7b69a8f.tar.gz'
error: 3rdparty/concurrentqueue-7b69a8f.tar.gz: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 1, 2017, 9:45 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63472/
> ---
> 
> (Updated Nov. 1, 2017, 9:45 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Our upstreamed PR to the `concurrentqueue` project was merged,
> (https://github.com/cameron314/concurrentqueue/commit/420509b)
> which fixes the Clang / libstdc++ configuration. Since there are
> a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
> we bundle the latest SHA on `master` here.
> 
> 
> Diffs
> -
> 
>   3rdparty/README.md PRE-CREATION 
>   3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
>   3rdparty/concurrentqueue-1.0.0-beta.tar.gz 
> 1bf4a88362e7d60cd22474f20fff62f788539308 
>   3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
>   3rdparty/concurrentqueue.md PRE-CREATION 
>   3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 
> 
> 
> Diff: https://reviews.apache.org/r/63472/diff/1/
> 
> 
> Testing
> ---
> 
> With Clang-3.9.0
> ```bash
> CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl 
> --enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue 
> --disable-java --disable-python
> make distcheck
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 63474: Added a regression test for MESOS-8135.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/#review189851
---



FAIL: Mesos tests failed to build.

Reviews applied: `['63353', '63474']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63474

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63474/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\sorter_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\status_update_manager_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
'argument': conversion from 'double' to 'float', possible loss of data 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
'argument': truncation from 'double' to 'float' 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63174/
---

(Updated Nov. 1, 2017, 3:06 p.m.)


Review request for mesos, Benjamin Mahler, Dmitry Zhuk, and Ilya Pronin.


Changes
---

Addressed review comments, reduces benchmark overhead by 10secs (10%).

```
[--] 3 tests from AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test
[ RUN  ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay0
Starting reregistration for all agents
Reregistered 2000 agents with a total of 10 running tasks and 10 
completed tasks in 10.387637507secs
[   OK ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
 (17506ms)
[ RUN  ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
Starting reregistration for all agents
Reregistered 2000 agents with a total of 20 running tasks and 0 completed 
tasks in 21.918619408secs
[   OK ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
 (41810 ms)
[ RUN  ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
Starting reregistration for all agents
Reregistered 2 agents with a total of 10 running tasks and 0 completed 
tasks in 14.680627873secs
[   OK ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
 (24801 ms)
[--] 3 tests from AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test 
(84117 ms total)

...

[--] 3 tests from AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test
[ RUN  ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
Starting reregistration for all agents
Reregistered 2000 agents with a total of 10 running tasks and 10 
completed tasks in 10.434383702secs
[   OK ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
 (17788 ms)
[ RUN  ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
Starting reregistration for all agents
Reregistered 2000 agents with a total of 20 running tasks and 0 completed 
tasks in 21.597951218secs
[   OK ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
 (36953 ms)
[ RUN  ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
Starting reregistration for all agents
Reregistered 2 agents with a total of 10 running tasks and 0 completed 
tasks in 14.982351549secs
[   OK ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
 (25360 ms)
[--] 3 tests from AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test 
(80101 ms total)
```


Bugs: MESOS-8098
https://issues.apache.org/jira/browse/MESOS-8098


Repository: mesos


Description
---

The current benchmark is very simple: without framework involvement and without 
agent retries but it's possible to add a number of others so I am creating a 
new file for them.


Diffs (updated)
-

  src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 
  src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
  src/tests/master_benchmarks.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63174/diff/3/

Changes: https://reviews.apache.org/r/63174/diff/2-3/


Testing
---

Benchmark based off 
https://github.com/apache/mesos/commit/41193181d6b75eeecae2729bf98007d9318e351a 
(close to current HEAD).

```
[ RUN  ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
Starting reregistration for all agents
Reregistered 2000 agents with a total of 10 running tasks and 10 
completed tasks in 11.188008209secs
[   OK ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
 (22404 ms)
[ RUN  ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
Starting reregistration for all agents
Reregistered 2000 agents with a total of 20 running tasks and 0 completed 
tasks in 20.868372615secs
[   OK ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
 (37981 ms)
[ RUN  ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
Starting reregistration for all agents
Reregistered 2 agents with a total of 10 running tasks and 0 completed 
tasks in 15.354579251secs
[   OK ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
 (33766 ms)
[--] 3 tests from AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test 
(94151 ms total)


[ RUN  ] 
AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
Starting reregistration for all agents
Reregistered 2000 agents with a total of 10 running tasks and 10 
completed tasks in 

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

[Jiang Yan Xu]

> On Oct. 24, 2017, 2:55 p.m., Benjamin Mahler wrote:
> > A couple of suggestions for speeding up the benchmark overhead:
> > 
> > (1) Upgrade protobuf to 3.4.x, this comes with move support and rvalue 
> > setters for fields. Which will avoid some copies in the benchmark code and 
> > improve performance elsewhere too :) In the interim, you could manually use 
> > `Swap(T*)` but it means we'd probably want to re-write the code once move 
> > support is available (so that doesn't seem like a good option).
> > 
> > (2) You could try using an arena for the test fixture, although I don't 
> > know if it's worth the complexity. Probably just reducing copying is 
> > simpler.
> > 
> > (3) We can avoid re-parsing resources for each task and agent.

Using `Swap` for now and will clean up after proto 3.4.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63174/#review189093
---


On Nov. 1, 2017, 3:06 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63174/
> ---
> 
> (Updated Nov. 1, 2017, 3:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Dmitry Zhuk, and Ilya Pronin.
> 
> 
> Bugs: MESOS-8098
> https://issues.apache.org/jira/browse/MESOS-8098
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current benchmark is very simple: without framework involvement and 
> without agent retries but it's possible to add a number of others so I am 
> creating a new file for them.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/master_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63174/diff/3/
> 
> 
> Testing
> ---
> 
> Benchmark based off 
> https://github.com/apache/mesos/commit/41193181d6b75eeecae2729bf98007d9318e351a
>  (close to current HEAD).
> 
> ```
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 10 running tasks and 10 
> completed tasks in 11.188008209secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
>  (22404 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 20 running tasks and 0 completed 
> tasks in 20.868372615secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
>  (37981 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
> Starting reregistration for all agents
> Reregistered 2 agents with a total of 10 running tasks and 0 
> completed tasks in 15.354579251secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
>  (33766 ms)
> [--] 3 tests from 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test (94151 ms total)
> 
> 
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 10 running tasks and 10 
> completed tasks in 11.045441129secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
>  (19959 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 20 running tasks and 0 completed 
> tasks in 21.324309077secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
>  (38490 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
> Starting reregistration for all agents
> Reregistered 2 agents with a total of 10 running tasks and 0 
> completed tasks in 14.68607521secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
>  (32073 ms)
> [--] 3 tests from 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test (90523 ms total)
> 
> ```
> 
> Benchmark based off 
> https://github.com/apache/mesos/commit/d9c90bf1d9c8b3a7dcc47be0cb773efff57cfb9d
>  (before https://issues.apache.org/jira/browse/MESOS-7713 was merged)
> 
> ```
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 10 

Re: Review Request 63476: Revert "Added a test `ROOT_NoTransitionFromKillingToFinished`".

[Andrew Schwartzmeyer]

> On Nov. 1, 2017, 2:58 p.m., Andrew Schwartzmeyer wrote:
> > Emoji test: 
> 
> Andrew Schwartzmeyer wrote:
> :no_entry_sign: :double_vertical_bar: :heavy_check_mark:
> 
> Andrew Schwartzmeyer wrote:
> 
> 
> Andrew Schwartzmeyer wrote:
> ??
> 
> Andrew Schwartzmeyer wrote:
> ??

Testing:  ?? ??


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63476/#review189842
---


On Nov. 1, 2017, 2:04 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63476/
> ---
> 
> (Updated Nov. 1, 2017, 2:04 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Vinod Kone.
> 
> 
> Bugs: MESOS-8157
> https://issues.apache.org/jira/browse/MESOS-8157
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This reverts commit 815263ead42f64fd0ff320614cfada30b2e8f899.
> 
> The commit being reverted introduced a build break on Windows.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
>   src/tests/kill_policy_test_helper.cpp 
> 28768a3fc02e3e6b2a0f531e6b6b2865aab51f3d 
> 
> 
> Diff: https://reviews.apache.org/r/63476/diff/1/
> 
> 
> Testing
> ---
> 
> Successfully built on Windows after failing to build before the revert.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 63476: Revert "Added a test `ROOT_NoTransitionFromKillingToFinished`".

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63476/#review189842
---



Emoji test: 

- Andrew Schwartzmeyer


On Nov. 1, 2017, 2:04 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63476/
> ---
> 
> (Updated Nov. 1, 2017, 2:04 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Vinod Kone.
> 
> 
> Bugs: MESOS-8157
> https://issues.apache.org/jira/browse/MESOS-8157
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This reverts commit 815263ead42f64fd0ff320614cfada30b2e8f899.
> 
> The commit being reverted introduced a build break on Windows.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
>   src/tests/kill_policy_test_helper.cpp 
> 28768a3fc02e3e6b2a0f531e6b6b2865aab51f3d 
> 
> 
> Diff: https://reviews.apache.org/r/63476/diff/1/
> 
> 
> Testing
> ---
> 
> Successfully built on Windows after failing to build before the revert.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 63479: Migrated `3rdparty/mesos-3rdparty` to `mesos/3rdparty`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63479/#review189839
---



This will fail until it's been migrated, so we need to be careful about 
committing it.

I _think_ that GitHub transparently redirects migrated repos (if you use the 
transfer option), so we may be safe to migrate, then let CI pass, then commit.

- Andrew Schwartzmeyer


On Nov. 1, 2017, 2:52 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63479/
> ---
> 
> (Updated Nov. 1, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We currently keep some of our 3rdparty bundled dependencies in
> an external repository in order to reduce the tarball churn in
> the Mesos repository which would bloat the git repository.
> 
> The intent is for `github.com/3rdparty/mesos-3rdparty` to be
> migrated to `github.com/mesos/3rdparty` along with this patch.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 929e45bd810c99e036d433a8f0a0bc978c9841a2 
>   docs/cmake.md 1e1a27ef67d256eb892a5eb455928c2424bb3fed 
>   docs/configuration/cmake.md 68757d30400da06935b17650727f4e2b92a3997c 
> 
> 
> Diff: https://reviews.apache.org/r/63479/diff/1/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 63479: Migrated `3rdparty/mesos-3rdparty` to `mesos/3rdparty`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63479/#review189838
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Nov. 1, 2017, 2:52 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63479/
> ---
> 
> (Updated Nov. 1, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We currently keep some of our 3rdparty bundled dependencies in
> an external repository in order to reduce the tarball churn in
> the Mesos repository which would bloat the git repository.
> 
> The intent is for `github.com/3rdparty/mesos-3rdparty` to be
> migrated to `github.com/mesos/3rdparty` along with this patch.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 929e45bd810c99e036d433a8f0a0bc978c9841a2 
>   docs/cmake.md 1e1a27ef67d256eb892a5eb455928c2424bb3fed 
>   docs/configuration/cmake.md 68757d30400da06935b17650727f4e2b92a3997c 
> 
> 
> Diff: https://reviews.apache.org/r/63479/diff/1/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 63479: Migrated `3rdparty/mesos-3rdparty` to `mesos/3rdparty`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63479/
---

Review request for mesos and Andrew Schwartzmeyer.


Repository: mesos


Description
---

We currently keep some of our 3rdparty bundled dependencies in
an external repository in order to reduce the tarball churn in
the Mesos repository which would bloat the git repository.

The intent is for `github.com/3rdparty/mesos-3rdparty` to be
migrated to `github.com/mesos/3rdparty` along with this patch.


Diffs
-

  cmake/CompilationConfigure.cmake 929e45bd810c99e036d433a8f0a0bc978c9841a2 
  docs/cmake.md 1e1a27ef67d256eb892a5eb455928c2424bb3fed 
  docs/configuration/cmake.md 68757d30400da06935b17650727f4e2b92a3997c 


Diff: https://reviews.apache.org/r/63479/diff/1/


Testing
---

N/A


Thanks,

Michael Park

Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Our upstreamed PR to the `concurrentqueue` project was merged,
(https://github.com/cameron314/concurrentqueue/commit/420509b)
which fixes the Clang / libstdc++ configuration. Since there are
a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
we bundle the latest SHA on `master` here.


Diffs
-

  3rdparty/README.md PRE-CREATION 
  3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
  3rdparty/concurrentqueue-1.0.0-beta.tar.gz 
1bf4a88362e7d60cd22474f20fff62f788539308 
  3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
  3rdparty/concurrentqueue.md PRE-CREATION 
  3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 


Diff: https://reviews.apache.org/r/63472/diff/1/


Testing
---

With Clang-3.9.0
```bash
CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl 
--enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue 
--disable-java --disable-python
make distcheck
```


Thanks,

Michael Park

Review Request 63476: Revert "Added a test `ROOT_NoTransitionFromKillingToFinished`".

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63476/
---

Review request for mesos, Qian Zhang and Vinod Kone.


Bugs: MESOS-8157
https://issues.apache.org/jira/browse/MESOS-8157


Repository: mesos


Description
---

This reverts commit 815263ead42f64fd0ff320614cfada30b2e8f899.

The commit to be reverted caused introduced a build break on Windows.


Diffs
-

  src/tests/default_executor_tests.cpp 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
  src/tests/kill_policy_test_helper.cpp 
28768a3fc02e3e6b2a0f531e6b6b2865aab51f3d 


Diff: https://reviews.apache.org/r/63476/diff/1/


Testing
---

Successfully built on Windows after failing to build before the revert.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

[Gaston Kleiman]

> On Oct. 31, 2017, 3:43 p.m., Benjamin Mahler wrote:
> > src/tests/master_slave_reconciliation_tests.cpp
> > Lines 721 (patched)
> > 
> >
> > TaskExecutorIds?

Renamed in RR 63474.


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63353/#review189761
---


On Nov. 1, 2017, 1:53 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63353/
> ---
> 
> (Updated Nov. 1, 2017, 1:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
> https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the agent would sometimes clear the executor ID of
> non-command executors before sending the `ReregisterSlaveMessage`
> message.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 
> 
> 
> Diff: https://reviews.apache.org/r/63353/diff/2/
> 
> 
> Testing
> ---
> 
> Verified that the new test fails on GNU/Linux without the rest of the patch, 
> but passes with it.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63353/
---

(Updated Nov. 1, 2017, 1:53 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.


Changes
---

Moved the test to a new patch.


Bugs: MESOS-8135
https://issues.apache.org/jira/browse/MESOS-8135


Repository: mesos


Description
---

Previously the agent would sometimes clear the executor ID of
non-command executors before sending the `ReregisterSlaveMessage`
message.


Diffs (updated)
-

  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 


Diff: https://reviews.apache.org/r/63353/diff/2/

Changes: https://reviews.apache.org/r/63353/diff/1-2/


Testing
---

Verified that the new test fails on GNU/Linux without the rest of the patch, 
but passes with it.


Thanks,

Gaston Kleiman

Review Request 63474: Added a regression test for MESOS-8135.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/
---

Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.


Bugs: MESOS-8135
https://issues.apache.org/jira/browse/MESOS-8135


Repository: mesos


Description
---

Added a regression test for MESOS-8135.


Diffs
-

  src/tests/master_slave_reconciliation_tests.cpp 
d5eb7ba68c5308338236879e7cb1e970a01e48e6 


Diff: https://reviews.apache.org/r/63474/diff/1/


Testing
---

Test passes on GNU/Linux.


Thanks,

Gaston Kleiman

Re: Review Request 62616: Binary packaging for Centos 7.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review189824
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62616`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62616

Relevant logs:

- 
[apply-review-62616-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62616/logs/apply-review-62616-stdout.log):

```
error: support/packaging/Jenkinsfile: already exists in index
error: support/packaging/centos/build_rpm.sh: already exists in index
error: support/packaging/centos/centos6.dockerfile: already exists in index
error: support/packaging/centos/centos7.dockerfile: already exists in index
error: support/packaging/centos/mesos.spec: already exists in index
error: support/packaging/common/mesos: already exists in index
error: support/packaging/common/mesos-init-wrapper: already exists in index
error: support/packaging/common/mesos-master: already exists in index
error: support/packaging/common/mesos-master.service: already exists in index
error: support/packaging/common/mesos-master.upstart: already exists in index
error: support/packaging/common/mesos-slave: already exists in index
error: support/packaging/common/mesos-slave.service: already exists in index
error: support/packaging/common/mesos-slave.upstart: already exists in index
```

- Mesos Reviewbot Windows


On Oct. 30, 2017, 5:49 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> ---
> 
> (Updated Oct. 30, 2017, 5:49 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Binary packaging for Centos 7.
> 
> 
> Diffs
> -
> 
>   support/packaging/Jenkinsfile PRE-CREATION 
>   support/packaging/centos/build_rpm.sh PRE-CREATION 
>   support/packaging/centos/centos6.dockerfile PRE-CREATION 
>   support/packaging/centos/centos7.dockerfile PRE-CREATION 
>   support/packaging/centos/mesos.spec PRE-CREATION 
>   support/packaging/common/mesos PRE-CREATION 
>   support/packaging/common/mesos-init-wrapper PRE-CREATION 
>   support/packaging/common/mesos-master PRE-CREATION 
>   support/packaging/common/mesos-master.service PRE-CREATION 
>   support/packaging/common/mesos-master.upstart PRE-CREATION 
>   support/packaging/common/mesos-slave PRE-CREATION 
>   support/packaging/common/mesos-slave.service PRE-CREATION 
>   support/packaging/common/mesos-slave.upstart PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62616/diff/4/
> 
> 
> Testing
> ---
> 
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF 
> Jenkins CI is available at 
> https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
> 
> Building a package locally:
> 
> 1. cd 
> 2.  (Or use 
> mesos/packaging:centos7). 
>docker build -t mesos-centos7 -f 
> support/packaging/centos/centos7.dockerfile support/packaging/centos
> 3. mkdir .m2
> 4. docker run -u `id -u':`id -g` -e MESOS_TAG=1.4.0 -e MESOS_RELEASE=1 
> -v=/etc/passwd:/etc/passwd -v=/etc/group:/etc/group 
> -v=`pwd`/.m2:$HOME/.m2:rw,z -v `pwd`:/mesos:rw,z mesos/packaging:centos7 
> /mesos/support/packaging/centos/build_rpm
> 
> RPMs will be placed inside /centos7/rpmbuild/RPMs/x86_64 directory.
> 
> If `MESOS_TAG` environment variable is not supplied, it builds the package 
> from the local mesos tree.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 63468: Added TERMINATED state to processes.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63468/#review189821
---



FAIL: Mesos tests failed to build.

Reviews applied: `['63468']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63468

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63468/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\status_update_manager_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\sorter_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
'argument': conversion from 'double' to 'float', possible loss of data 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
'argument': truncation from 'double' to 'float' 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  

Re: Review Request 63468: Added TERMINATED state to processes.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63468/#review189820
---



Patch looks great!

Reviews applied: [63468]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 1, 2017, 3:17 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63468/
> ---
> 
> (Updated Nov. 1, 2017, 3:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added TERMINATED state to processes.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/process.hpp 
> dc3375ce62556322eb2bc60ade61f313ade123b8 
>   3rdparty/libprocess/src/process.cpp 
> 71ae7129ffbd0e22eda2863b17bbcf588298c37b 
> 
> 
> Diff: https://reviews.apache.org/r/63468/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

[Alexander Rukletsov]

> On Nov. 1, 2017, 3 p.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 538-548 (patched)
> > 
> >
> > This is racy; there's no guarantee that the first `TASK_RUNNING` status 
> > update will come after the second `TASK_STARTING` update.
> > 
> > The following ordering would also be possible: [`TASK_STARTING`, 
> > `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]
> 
> Alexander Rukletsov wrote:
> To simplify the logic here, let's introduce a matcher in our tests, 
> something like
> ```
> MATCHER_P(TaskStateEq, state, "") { return arg.state() == state; }
> ```
> which we then can use like
> ```
> Future status;
>   EXPECT_CALL(sched, statusUpdate(, TaskStateEq(TASK_RUNNING)))
> .WillOnce(FutureArg<1>());
> ```
> Then you can combine both task state and task id matchers to get an exact 
> status update.
> 
> Gaston Kleiman wrote:
> AlexR suggested something like this:
> 
> ```
>   Sequence task1;
>   EXPECT_CALL(
>   *scheduler,
>   update(_, AllOf(TaskStatusEq(TASK_STARTING), 
> TaskStateEq(taskInfo1
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
> 
>   EXPECT_CALL(
>   *scheduler,
>   update(_, AllOf(TaskStatusEq(TASK_RUNNING), 
> TaskStateEq(taskInfo1
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
> 
>   Sequence task2;
>   EXPECT_CALL(
>   *scheduler,
>   update(_, AllOf(TaskStatusEq(TASK_STARTING), 
> TaskStateEq(taskInfo2
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
> 
>   EXPECT_CALL(
>   *scheduler,
>   update(_, AllOf(TaskStatusEq(TASK_RUNNING), 
> TaskStateEq(taskInfo2
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>   
>   AWAIT_READY(startingUpdate1);
>   AWAIT_READY(runningUpdate1);
> 
>   AWAIT_READY(startingUpdate2);
>   AWAIT_READY(runningUpdate2);
> ```

Parameters are mixed up : )
`AllOf(TaskStatusEq(), TaskStateEq())`
Also feel free to refactor `TaskStatusEq` to take an id if you think it is 
simpler.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
---


On Oct. 31, 2017, 4:53 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> ---
> 
> (Updated Oct. 31, 2017, 4:53 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 5078bd4d70698f5cbd14c971fcecfd58f8467a04 
> 
> 
> Diff: https://reviews.apache.org/r/62837/diff/2/
> 
> 
> Testing
> ---
> 
> [ RUN  ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED 
> event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on 
> core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP 
> event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 
> 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched 
> tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 
> 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child 
> container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of 
> task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

[Gaston Kleiman]

> On Nov. 1, 2017, 8 a.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 538-548 (patched)
> > 
> >
> > This is racy; there's no guarantee that the first `TASK_RUNNING` status 
> > update will come after the second `TASK_STARTING` update.
> > 
> > The following ordering would also be possible: [`TASK_STARTING`, 
> > `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]
> 
> Alexander Rukletsov wrote:
> To simplify the logic here, let's introduce a matcher in our tests, 
> something like
> ```
> MATCHER_P(TaskStateEq, state, "") { return arg.state() == state; }
> ```
> which we then can use like
> ```
> Future status;
>   EXPECT_CALL(sched, statusUpdate(, TaskStateEq(TASK_RUNNING)))
> .WillOnce(FutureArg<1>());
> ```
> Then you can combine both task state and task id matchers to get an exact 
> status update.

AlexR suggested something like this:

```
  Sequence task1;
  EXPECT_CALL(
  *scheduler,
  update(_, AllOf(TaskStatusEq(TASK_STARTING), TaskStateEq(taskInfo1
.InSequence(task1)
.WillOnce(
DoAll(
FutureArg<1>(),
v1::scheduler::SendAcknowledge(frameworkId, agentId)));

  EXPECT_CALL(
  *scheduler,
  update(_, AllOf(TaskStatusEq(TASK_RUNNING), TaskStateEq(taskInfo1
.InSequence(task1)
.WillOnce(
DoAll(
FutureArg<1>(),
v1::scheduler::SendAcknowledge(frameworkId, agentId)));

  Sequence task2;
  EXPECT_CALL(
  *scheduler,
  update(_, AllOf(TaskStatusEq(TASK_STARTING), TaskStateEq(taskInfo2
.InSequence(task2)
.WillOnce(
DoAll(
FutureArg<1>(),
v1::scheduler::SendAcknowledge(frameworkId, agentId)));

  EXPECT_CALL(
  *scheduler,
  update(_, AllOf(TaskStatusEq(TASK_RUNNING), TaskStateEq(taskInfo2
.InSequence(task2)
.WillOnce(
DoAll(
FutureArg<1>(),
v1::scheduler::SendAcknowledge(frameworkId, agentId)));
  
  AWAIT_READY(startingUpdate1);
  AWAIT_READY(runningUpdate1);

  AWAIT_READY(startingUpdate2);
  AWAIT_READY(runningUpdate2);
```


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
---


On Oct. 30, 2017, 9:53 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> ---
> 
> (Updated Oct. 30, 2017, 9:53 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 5078bd4d70698f5cbd14c971fcecfd58f8467a04 
> 
> 
> Diff: https://reviews.apache.org/r/62837/diff/2/
> 
> 
> Testing
> ---
> 
> [ RUN  ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED 
> event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on 
> core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP 
> event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 
> 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched 
> tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 
> 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child 
> container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of 
> task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child 
> container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of 
> task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.354730 22365 

Re: Review Request 62774: Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62774/#review189811
---




src/tests/containerizer/docker_containerizer_tests.cpp
Lines 4168-4169 (patched)


I don't think this test passes now that the built-in executors send 
`TASK_STARTING` updates.


- Gaston Kleiman


On Oct. 4, 2017, 8:48 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62774/
> ---
> 
> (Updated Oct. 4, 2017, 8:48 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 45f0d1dbc5b21b174cd9974664299d466129df01 
> 
> 
> Diff: https://reviews.apache.org/r/62774/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 63463: Added support for credential secret to test-http-framework.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63463/#review189805
---



Patch looks great!

Reviews applied: [63463]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 1, 2017, 2:39 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63463/
> ---
> 
> (Updated Nov. 1, 2017, 2:39 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Alexander Rojas.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds the ability to authenticate against the master to the 
> test-http-framework.
> 
> 
> Diffs
> -
> 
>   src/examples/test_http_framework.cpp 
> 693dd47694678e7439f9d4ab0ff77b93950edf6e 
> 
> 
> Diff: https://reviews.apache.org/r/63463/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Review Request 63468: Added TERMINATED state to processes.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63468/
---

Review request for mesos, Alexander Rukletsov and Benjamin Mahler.


Repository: mesos


Description
---

Added TERMINATED state to processes.


Diffs
-

  3rdparty/libprocess/include/process/process.hpp 
dc3375ce62556322eb2bc60ade61f313ade123b8 
  3rdparty/libprocess/src/process.cpp 71ae7129ffbd0e22eda2863b17bbcf588298c37b 


Diff: https://reviews.apache.org/r/63468/diff/1/


Testing
---

make check


Thanks,

Benjamin Hindman

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

[Alexander Rukletsov]

> On Nov. 1, 2017, 3 p.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 538-548 (patched)
> > 
> >
> > This is racy; there's no guarantee that the first `TASK_RUNNING` status 
> > update will come after the second `TASK_STARTING` update.
> > 
> > The following ordering would also be possible: [`TASK_STARTING`, 
> > `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]

To simplify the logic here, let's introduce a matcher in our tests, something 
like
```
MATCHER_P(TaskStateEq, state, "") { return arg.state() == state; }
```
which we then can use like
```
Future status;
  EXPECT_CALL(sched, statusUpdate(, TaskStateEq(TASK_RUNNING)))
.WillOnce(FutureArg<1>());
```
Then you can combine both task state and task id matchers to get an exact 
status update.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
---


On Oct. 31, 2017, 4:53 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> ---
> 
> (Updated Oct. 31, 2017, 4:53 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 5078bd4d70698f5cbd14c971fcecfd58f8467a04 
> 
> 
> Diff: https://reviews.apache.org/r/62837/diff/2/
> 
> 
> Testing
> ---
> 
> [ RUN  ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED 
> event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on 
> core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP 
> event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 
> 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched 
> tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 
> 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child 
> container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of 
> task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child 
> container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of 
> task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.354730 22365 default_executor.cpp:1172] Received kill for task 
> '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.354787 22365 default_executor.cpp:1057] Killing task 
> 4fee2fec-12b5-4af6-bd70-e67b4da26c00 running in child container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 
> with SIGTERM signal
> I1030 21:47:58.354825 22365 default_executor.cpp:1079] Scheduling escalation 
> to SIGKILL in 3secs from now
> I1030 21:47:58.355772 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.355819 22365 default_executor.cpp:1172] Received kill for task 
> '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.355947 22365 default_executor.cpp:1057] Killing task 
> 24695aee-aa59-4295-8ad9-19f17ad9d52b running in child container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 
> with SIGTERM signal
> I1030 21:47:58.355980 22365 default_executor.cpp:1079] Scheduling escalation 
> to SIGKILL in 3secs from now
> I1030 21:47:58.467401 22380 default_executor.cpp:888] Child container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of 
> task '4fee2fec-12b5-4af6-bd70-e67b4da26c00' completed in state TASK_KILLED: 
> Command terminated with signal Terminated
> I1030 21:47:58.467478 22380 default_executor.cpp:924] Killing task group 
> containing tasks [ 

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
---




src/tests/default_executor_tests.cpp
Lines 538-548 (patched)


This is racy; there's no guarantee that the first `TASK_RUNNING` status 
update will come after the second `TASK_STARTING` update.

The following ordering would also be possible: [`TASK_STARTING`, 
`TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]


- Gaston Kleiman


On Oct. 30, 2017, 9:53 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> ---
> 
> (Updated Oct. 30, 2017, 9:53 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 5078bd4d70698f5cbd14c971fcecfd58f8467a04 
> 
> 
> Diff: https://reviews.apache.org/r/62837/diff/2/
> 
> 
> Testing
> ---
> 
> [ RUN  ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED 
> event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on 
> core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP 
> event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 
> 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched 
> tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 
> 24695aee-aa59-4295-8ad9-19f17ad9d52b ] in child containers [ 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18, 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 ]
> I1030 21:47:58.263293 22385 default_executor.cpp:713] Waiting for child 
> container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of 
> task '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.263546 22385 default_executor.cpp:713] Waiting for child 
> container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of 
> task '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.307412 22351 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.307924 22358 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.354656 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.354730 22365 default_executor.cpp:1172] Received kill for task 
> '4fee2fec-12b5-4af6-bd70-e67b4da26c00'
> I1030 21:47:58.354787 22365 default_executor.cpp:1057] Killing task 
> 4fee2fec-12b5-4af6-bd70-e67b4da26c00 running in child container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 
> with SIGTERM signal
> I1030 21:47:58.354825 22365 default_executor.cpp:1079] Scheduling escalation 
> to SIGKILL in 3secs from now
> I1030 21:47:58.355772 22365 default_executor.cpp:191] Received KILL event
> I1030 21:47:58.355819 22365 default_executor.cpp:1172] Received kill for task 
> '24695aee-aa59-4295-8ad9-19f17ad9d52b'
> I1030 21:47:58.355947 22365 default_executor.cpp:1057] Killing task 
> 24695aee-aa59-4295-8ad9-19f17ad9d52b running in child container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 
> with SIGTERM signal
> I1030 21:47:58.355980 22365 default_executor.cpp:1079] Scheduling escalation 
> to SIGKILL in 3secs from now
> I1030 21:47:58.467401 22380 default_executor.cpp:888] Child container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.a14cf886-fccd-431e-be3b-432a59f85f18 of 
> task '4fee2fec-12b5-4af6-bd70-e67b4da26c00' completed in state TASK_KILLED: 
> Command terminated with signal Terminated
> I1030 21:47:58.467478 22380 default_executor.cpp:924] Killing task group 
> containing tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 
> 24695aee-aa59-4295-8ad9-19f17ad9d52b ]
> I1030 21:47:58.467888 22380 default_executor.cpp:888] Child container 
> 94d8e76a-2215-41f9-8a27-c7ff12e96418.2fd5de24-fbed-490b-9914-de45902a8b47 of 
> task '24695aee-aa59-4295-8ad9-19f17ad9d52b' completed in state TASK_KILLED: 
> Command terminated with signal Terminated
> I1030 21:47:58.467934 22380 default_executor.cpp:1017] Terminating after 1secs
> [   OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (922 
> 

Review Request 63463: Added support for credential secret to test-http-framework.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63463/
---

Review request for mesos, Armand Grillet and Alexander Rojas.


Repository: mesos


Description
---

Adds the ability to authenticate against the master to the test-http-framework.


Diffs
-

  src/examples/test_http_framework.cpp 693dd47694678e7439f9d4ab0ff77b93950edf6e 


Diff: https://reviews.apache.org/r/63463/diff/1/


Testing
---

make check


Thanks,

Till Toenshoff

Re: Review Request 63414: Added a helper to get the resoruce provider ID from an offer operation.

[Jie Yu]

> On Oct. 30, 2017, 3:44 p.m., Benjamin Bannier wrote:
> > src/common/resources_utils.cpp
> > Lines 104-121 (patched)
> > 
> >
> > It would be great if we could explicitly `break` for any case not 
> > containing an explicit `return`.

Yeah, it's a bug. I'll add some tests.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63414/#review189597
---


On Oct. 30, 2017, 3:33 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63414/
> ---
> 
> (Updated Oct. 30, 2017, 3:33 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-7235
> https://issues.apache.org/jira/browse/MESOS-7235
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a helper to get the resoruce provider ID from an offer operation.
> 
> 
> Diffs
> -
> 
>   src/common/resources_utils.hpp 18e3d9d4baad23669d00542594f5c15a989b7b9e 
>   src/common/resources_utils.cpp e34cd8a3c9046a6f12c12a275a7b3a852b492f4c 
> 
> 
> Diff: https://reviews.apache.org/r/63414/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62775/#review189796
---



FAIL: Mesos tests failed to build.

Reviews applied: `['62685', '62326', '62327', '62774', '62775']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62775

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62775/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\status_update_manager_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\sorter_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
'argument': conversion from 'double' to 'float', possible loss of data 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
'argument': truncation from 'double' to 'float' 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 

Re: Review Request 63331: Added documentation for the `network/ports` isolator.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63331/#review189793
---


Ship it!




Ship It!

- Qian Zhang


On Nov. 1, 2017, 12:57 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63331/
> ---
> 
> (Updated Nov. 1, 2017, 12:57 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-7675
> https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for the `network/ports` isolator to the Mesos
> containerizer documentation. Updated the agent flags documentation with
> the new isolator flags. Added changelog information to note the new
> isolator, the new agent flags and new fields in the TaskStatus message.
> 
> 
> Diffs
> -
> 
>   docs/configuration/agent.md 5c1b469f28d4a7af0aebad5da65a00dd0e6c2a6c 
>   docs/isolators/network-ports.md PRE-CREATION 
>   docs/mesos-containerizer.md 9cb071273a5ce42784457ea01b363911fdb7773d 
>   docs/upgrades.md 6370c06a497161317884f61f376308423b744fe1 
> 
> 
> Diff: https://reviews.apache.org/r/63331/diff/2/
> 
> 
> Testing
> ---
> 
> Manually checked rendered website.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`.

[Qian Zhang]

> On Nov. 1, 2017, 8:02 a.m., Gaston Kleiman wrote:
> > LGTM, just two small comments:
> > 
> > 1) The `TASK_STARTING` changes have landed, so we'll have to update the 
> > test.
> > 2) There's a new helper method that we should use to create the `KILL` call.

Thanks for the review comments! I have addressed them in the latest patch.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62775/#review189774
---


On Nov. 1, 2017, 7:45 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62775/
> ---
> 
> (Updated Nov. 1, 2017, 7:45 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_NoTransitionFromKillingToFinished`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> f485b613084331c18781c2f0070d049061179050 
>   src/tests/kill_policy_test_helper.cpp 
> a1880595ff015475f1ba49437d49f7397da19422 
> 
> 
> Diff: https://reviews.apache.org/r/62775/diff/3/
> 
> 
> Testing
> ---
> 
> [ RUN  ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1101 19:07:49.244680 24316 executor.cpp:192] Version: 1.5.0
> I1101 19:07:49.277947 24336 default_executor.cpp:191] Received SUBSCRIBED 
> event
> I1101 19:07:49.281920 24336 default_executor.cpp:195] Subscribed executor on 
> workstation
> I1101 19:07:49.282701 24336 default_executor.cpp:191] Received LAUNCH_GROUP 
> event
> I1101 19:07:49.286540 24330 default_executor.cpp:402] Setting 
> 'MESOS_CONTAINER_IP' to: 10.0.2.5
> I1101 19:07:49.313779 24336 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1101 19:07:49.342092 24331 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1101 19:07:49.374323 24334 default_executor.cpp:640] Successfully launched 
> tasks [ aebaff2e-92fd-47e6-8423-48ceeb21f231, 
> e7db282a-dc45-4a52-a48d-58e58c27f556 ] in child containers [ 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675, 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 ]
> I1101 19:07:49.386710 24337 default_executor.cpp:713] Waiting for child 
> container 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675 of 
> task 'aebaff2e-92fd-47e6-8423-48ceeb21f231'
> I1101 19:07:49.387315 24337 default_executor.cpp:713] Waiting for child 
> container 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 of 
> task 'e7db282a-dc45-4a52-a48d-58e58c27f556'
> I1101 19:07:49.446444 24331 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1101 19:07:49.458606 24335 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1101 19:07:49.499390 24332 default_executor.cpp:191] Received KILL event
> I1101 19:07:49.499712 24332 default_executor.cpp:1172] Received kill for task 
> 'aebaff2e-92fd-47e6-8423-48ceeb21f231'
> I1101 19:07:49.500016 24332 default_executor.cpp:1057] Killing task 
> aebaff2e-92fd-47e6-8423-48ceeb21f231 running in child container 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675 
> with SIGTERM signal
> I1101 19:07:49.500139 24332 default_executor.cpp:1079] Scheduling escalation 
> to SIGKILL in 3secs from now
> I1101 19:07:49.501317 24332 default_executor.cpp:191] Received KILL event
> I1101 19:07:49.501617 24332 default_executor.cpp:1172] Received kill for task 
> 'e7db282a-dc45-4a52-a48d-58e58c27f556'
> I1101 19:07:49.501972 24332 default_executor.cpp:1057] Killing task 
> e7db282a-dc45-4a52-a48d-58e58c27f556 running in child container 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 
> with SIGTERM signal
> I1101 19:07:49.502081 24332 default_executor.cpp:1079] Scheduling escalation 
> to SIGKILL in 3secs from now
> I1101 19:07:49.577337 24332 default_executor.cpp:888] Child container 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675 of 
> task 'aebaff2e-92fd-47e6-8423-48ceeb21f231' completed in state TASK_KILLED: 
> Command terminated with signal Killed
> I1101 19:07:49.577422 24332 default_executor.cpp:924] Killing task group 
> containing tasks [ aebaff2e-92fd-47e6-8423-48ceeb21f231, 
> e7db282a-dc45-4a52-a48d-58e58c27f556 ]
> I1101 19:07:49.588505 24332 default_executor.cpp:888] Child container 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 of 
> task 'e7db282a-dc45-4a52-a48d-58e58c27f556' completed in state TASK_KILLED: 
> Command terminated with signal Killed
> I1101 19:07:49.588593 24332 default_executor.cpp:1017] Terminating after 1secs
> [   OK ] 

Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`.

[Qian Zhang]

> On Nov. 1, 2017, 6:33 a.m., Vinod Kone wrote:
> > Can you update the testing section. Ran it in a loop I hope?

Updated the testing section, and yes, I ran it in a loop (100 times) and it 
works well.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62775/#review189764
---


On Nov. 1, 2017, 7:45 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62775/
> ---
> 
> (Updated Nov. 1, 2017, 7:45 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-7975
> https://issues.apache.org/jira/browse/MESOS-7975
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `ROOT_NoTransitionFromKillingToFinished`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> f485b613084331c18781c2f0070d049061179050 
>   src/tests/kill_policy_test_helper.cpp 
> a1880595ff015475f1ba49437d49f7397da19422 
> 
> 
> Diff: https://reviews.apache.org/r/62775/diff/3/
> 
> 
> Testing
> ---
> 
> [ RUN  ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1101 19:07:49.244680 24316 executor.cpp:192] Version: 1.5.0
> I1101 19:07:49.277947 24336 default_executor.cpp:191] Received SUBSCRIBED 
> event
> I1101 19:07:49.281920 24336 default_executor.cpp:195] Subscribed executor on 
> workstation
> I1101 19:07:49.282701 24336 default_executor.cpp:191] Received LAUNCH_GROUP 
> event
> I1101 19:07:49.286540 24330 default_executor.cpp:402] Setting 
> 'MESOS_CONTAINER_IP' to: 10.0.2.5
> I1101 19:07:49.313779 24336 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1101 19:07:49.342092 24331 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1101 19:07:49.374323 24334 default_executor.cpp:640] Successfully launched 
> tasks [ aebaff2e-92fd-47e6-8423-48ceeb21f231, 
> e7db282a-dc45-4a52-a48d-58e58c27f556 ] in child containers [ 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675, 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 ]
> I1101 19:07:49.386710 24337 default_executor.cpp:713] Waiting for child 
> container 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675 of 
> task 'aebaff2e-92fd-47e6-8423-48ceeb21f231'
> I1101 19:07:49.387315 24337 default_executor.cpp:713] Waiting for child 
> container 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 of 
> task 'e7db282a-dc45-4a52-a48d-58e58c27f556'
> I1101 19:07:49.446444 24331 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1101 19:07:49.458606 24335 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1101 19:07:49.499390 24332 default_executor.cpp:191] Received KILL event
> I1101 19:07:49.499712 24332 default_executor.cpp:1172] Received kill for task 
> 'aebaff2e-92fd-47e6-8423-48ceeb21f231'
> I1101 19:07:49.500016 24332 default_executor.cpp:1057] Killing task 
> aebaff2e-92fd-47e6-8423-48ceeb21f231 running in child container 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675 
> with SIGTERM signal
> I1101 19:07:49.500139 24332 default_executor.cpp:1079] Scheduling escalation 
> to SIGKILL in 3secs from now
> I1101 19:07:49.501317 24332 default_executor.cpp:191] Received KILL event
> I1101 19:07:49.501617 24332 default_executor.cpp:1172] Received kill for task 
> 'e7db282a-dc45-4a52-a48d-58e58c27f556'
> I1101 19:07:49.501972 24332 default_executor.cpp:1057] Killing task 
> e7db282a-dc45-4a52-a48d-58e58c27f556 running in child container 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 
> with SIGTERM signal
> I1101 19:07:49.502081 24332 default_executor.cpp:1079] Scheduling escalation 
> to SIGKILL in 3secs from now
> I1101 19:07:49.577337 24332 default_executor.cpp:888] Child container 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675 of 
> task 'aebaff2e-92fd-47e6-8423-48ceeb21f231' completed in state TASK_KILLED: 
> Command terminated with signal Killed
> I1101 19:07:49.577422 24332 default_executor.cpp:924] Killing task group 
> containing tasks [ aebaff2e-92fd-47e6-8423-48ceeb21f231, 
> e7db282a-dc45-4a52-a48d-58e58c27f556 ]
> I1101 19:07:49.588505 24332 default_executor.cpp:888] Child container 
> dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 of 
> task 'e7db282a-dc45-4a52-a48d-58e58c27f556' completed in state TASK_KILLED: 
> Command terminated with signal Killed
> I1101 19:07:49.588593 24332 default_executor.cpp:1017] Terminating after 1secs
> [   OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (1013 
> ms)
> 
> 
> [ RUN  ] 
> 

Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62775/
---

(Updated Nov. 1, 2017, 7:45 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Addressed review comments and updated testing section.


Bugs: MESOS-7975
https://issues.apache.org/jira/browse/MESOS-7975


Repository: mesos


Description
---

Added a test `ROOT_NoTransitionFromKillingToFinished`.


Diffs (updated)
-

  src/tests/default_executor_tests.cpp f485b613084331c18781c2f0070d049061179050 
  src/tests/kill_policy_test_helper.cpp 
a1880595ff015475f1ba49437d49f7397da19422 


Diff: https://reviews.apache.org/r/62775/diff/3/

Changes: https://reviews.apache.org/r/62775/diff/2-3/


Testing (updated)
---

[ RUN  ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
I1101 19:07:49.244680 24316 executor.cpp:192] Version: 1.5.0
I1101 19:07:49.277947 24336 default_executor.cpp:191] Received SUBSCRIBED event
I1101 19:07:49.281920 24336 default_executor.cpp:195] Subscribed executor on 
workstation
I1101 19:07:49.282701 24336 default_executor.cpp:191] Received LAUNCH_GROUP 
event
I1101 19:07:49.286540 24330 default_executor.cpp:402] Setting 
'MESOS_CONTAINER_IP' to: 10.0.2.5
I1101 19:07:49.313779 24336 default_executor.cpp:191] Received ACKNOWLEDGED 
event
I1101 19:07:49.342092 24331 default_executor.cpp:191] Received ACKNOWLEDGED 
event
I1101 19:07:49.374323 24334 default_executor.cpp:640] Successfully launched 
tasks [ aebaff2e-92fd-47e6-8423-48ceeb21f231, 
e7db282a-dc45-4a52-a48d-58e58c27f556 ] in child containers [ 
dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675, 
dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 ]
I1101 19:07:49.386710 24337 default_executor.cpp:713] Waiting for child 
container 
dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675 of 
task 'aebaff2e-92fd-47e6-8423-48ceeb21f231'
I1101 19:07:49.387315 24337 default_executor.cpp:713] Waiting for child 
container 
dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 of 
task 'e7db282a-dc45-4a52-a48d-58e58c27f556'
I1101 19:07:49.446444 24331 default_executor.cpp:191] Received ACKNOWLEDGED 
event
I1101 19:07:49.458606 24335 default_executor.cpp:191] Received ACKNOWLEDGED 
event
I1101 19:07:49.499390 24332 default_executor.cpp:191] Received KILL event
I1101 19:07:49.499712 24332 default_executor.cpp:1172] Received kill for task 
'aebaff2e-92fd-47e6-8423-48ceeb21f231'
I1101 19:07:49.500016 24332 default_executor.cpp:1057] Killing task 
aebaff2e-92fd-47e6-8423-48ceeb21f231 running in child container 
dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675 with 
SIGTERM signal
I1101 19:07:49.500139 24332 default_executor.cpp:1079] Scheduling escalation to 
SIGKILL in 3secs from now
I1101 19:07:49.501317 24332 default_executor.cpp:191] Received KILL event
I1101 19:07:49.501617 24332 default_executor.cpp:1172] Received kill for task 
'e7db282a-dc45-4a52-a48d-58e58c27f556'
I1101 19:07:49.501972 24332 default_executor.cpp:1057] Killing task 
e7db282a-dc45-4a52-a48d-58e58c27f556 running in child container 
dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 with 
SIGTERM signal
I1101 19:07:49.502081 24332 default_executor.cpp:1079] Scheduling escalation to 
SIGKILL in 3secs from now
I1101 19:07:49.577337 24332 default_executor.cpp:888] Child container 
dcceb657-8f81-4486-8a08-e7fa9651fdac.cb2c9a1a-d8ce-440b-a5d5-311ac527f675 of 
task 'aebaff2e-92fd-47e6-8423-48ceeb21f231' completed in state TASK_KILLED: 
Command terminated with signal Killed
I1101 19:07:49.577422 24332 default_executor.cpp:924] Killing task group 
containing tasks [ aebaff2e-92fd-47e6-8423-48ceeb21f231, 
e7db282a-dc45-4a52-a48d-58e58c27f556 ]
I1101 19:07:49.588505 24332 default_executor.cpp:888] Child container 
dcceb657-8f81-4486-8a08-e7fa9651fdac.a3b934a2-5cb6-4612-a369-2fa26897e9b6 of 
task 'e7db282a-dc45-4a52-a48d-58e58c27f556' completed in state TASK_KILLED: 
Command terminated with signal Killed
I1101 19:07:49.588593 24332 default_executor.cpp:1017] Terminating after 1secs
[   OK ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0 (1013 
ms)


[ RUN  ] 
ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillMultipleTasks/0
I1101 19:44:45.021219 24574 executor.cpp:192] Version: 1.5.0
I1101 19:44:45.062325 24591 default_executor.cpp:191] Received SUBSCRIBED event
I1101 19:44:45.066876 24591 default_executor.cpp:195] Subscribed executor on 
workstation
I1101 19:44:45.067586 24591 default_executor.cpp:191] Received LAUNCH_GROUP 
event
I1101 19:44:45.070425 24590 default_executor.cpp:402] Setting 
'MESOS_CONTAINER_IP' to: 10.0.2.5
I1101 19:44:45.101138 24588 default_executor.cpp:191] Received ACKNOWLEDGED 
event
I1101 19:44:45.120609 24588 

Re: Review Request 63453: Patched concurrentqueue to check for libstdc++ instead of GCC.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63453/#review189787
---



Patch looks great!

Reviews applied: [63453]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 31, 2017, 10:47 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63453/
> ---
> 
> (Updated Oct. 31, 2017, 10:47 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upstream PR available here: 
> https://github.com/cameron314/concurrentqueue/pull/97
> 
> 
> Diffs
> -
> 
>   3rdparty/concurrentqueue-1.0.0-beta.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63453/diff/1/
> 
> 
> Testing
> ---
> 
> ```bash
> CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl 
> --enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue 
> --disable-java --disable-python
> make check
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 63453: Patched concurrentqueue to check for libstdc++ instead of GCC.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63453/#review189785
---



PASS: Mesos patch 63453 was successfully built and tested.

Reviews applied: `['63453']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63453

- Mesos Reviewbot Windows


On Oct. 31, 2017, 10:47 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63453/
> ---
> 
> (Updated Oct. 31, 2017, 10:47 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upstream PR available here: 
> https://github.com/cameron314/concurrentqueue/pull/97
> 
> 
> Diffs
> -
> 
>   3rdparty/concurrentqueue-1.0.0-beta.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63453/diff/1/
> 
> 
> Testing
> ---
> 
> ```bash
> CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl 
> --enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue 
> --disable-java --disable-python
> make check
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>