Re: Review Request 63389: WIP: Added a mock resource provider manager.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63389/
---

(Updated Nov. 3, 2017, 3:28 a.m.)


Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.


Summary (updated)
-

WIP: Added a mock resource provider manager.


Bugs: MESOS-8144
https://issues.apache.org/jira/browse/MESOS-8144


Repository: mesos


Description
---

This patch adds a `ResourceProviderManager*` parameter to the slave
constructor, so we can pass in a mock resource provider manager. The
mock manager can be used to test against either the agent or the
resource provider.

The declaration of `ResourceProviderManagerProcess` is moved to a
separated `manager_process.hpp` header file so we can mock the internal
process.


Diffs (updated)
-

  src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 
  src/local/local.cpp 99c1b087d75a1759ed61a4e6178e15919bee1e77 
  src/resource_provider/manager.hpp 3b70e75c6b6721864ae0ee9c4a593b5035d8388f 
  src/resource_provider/manager.cpp 11f890156f0fd099f8a97b07cdc458a0726ee78e 
  src/resource_provider/manager_process.hpp PRE-CREATION 
  src/slave/main.cpp 94431b036524ef4db16a594c80f45b64a45728f7 
  src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 
  src/tests/cluster.hpp 65634121b7fe076a7cd9a1c5aa6101a96b1c009d 
  src/tests/cluster.cpp d657da6d84e5ea28e0dad180dce069de569c5d38 
  src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 
  src/tests/mesos.cpp 9185b5bf2175be5b0f6b6a03a04e9e5445bf22fd 
  src/tests/mock_slave.hpp 57189cee20511d145ae6b47a4dc2c66a14638dad 
  src/tests/mock_slave.cpp db24f9e5b71f558d2f811f0da8a9cc9c7c2dd341 
  src/tests/resource_provider/mock_manager.hpp PRE-CREATION 
  src/tests/resource_provider/mock_manager.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63389/diff/5/

Changes: https://reviews.apache.org/r/63389/diff/4-5/


Testing
---

make


Thanks,

Chun-Hung Hsiao

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review190004
---



PASS: Mesos patch 63434 was successfully built and tested.

Reviews applied: `['63434']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63434

- Mesos Reviewbot Windows


On Nov. 3, 2017, 12:38 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> ---
> 
> (Updated Nov. 3, 2017, 12:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added IPv6 capabilities for TCP and HTTP healthchecks.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b 
>   include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b 
> 
> 
> Diff: https://reviews.apache.org/r/63434/diff/2/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 63474: Added a regression test for MESOS-8135.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/#review190007
---



Bad patch!

Reviews applied: [63474, 63353]

Failed command: python support/apply-reviews.py -n -r 63353

Error:
2017-11-03 05:03:18 URL:https://reviews.apache.org/r/63353/diff/raw/ 
[1009/1009] -> "63353.patch" [1]
error: patch failed: src/slave/slave.cpp:1537
error: src/slave/slave.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19978/console

- Mesos Reviewbot


On Nov. 2, 2017, 12:51 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63474/
> ---
> 
> (Updated Nov. 2, 2017, 12:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
> https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a regression test for MESOS-8135.
> 
> 
> Diffs
> -
> 
>   src/tests/master_slave_reconciliation_tests.cpp 
> d5eb7ba68c5308338236879e7cb1e970a01e48e6 
> 
> 
> Diff: https://reviews.apache.org/r/63474/diff/2/
> 
> 
> Testing
> ---
> 
> Test passes on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 63522: Removed unused variable `DefaultExecutorTest.CommitSuicideOnKillTask`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63522/#review190005
---



Patch looks great!

Reviews applied: [63522]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 2, 2017, 7:36 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63522/
> ---
> 
> (Updated Nov. 2, 2017, 7:36 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused variable `DefaultExecutorTest.CommitSuicideOnKillTask`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63522/diff/1/
> 
> 
> Testing
> ---
> 
> Tests still compile =).
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

[Ilya Pronin]

> On Nov. 2, 2017, 6:14 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Mesos tests failed to build.
> > 
> > Reviews applied: `['63526', '63527']`
> > 
> > Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
> > 
> > All the build artifacts available at: 
> > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63527
> > 
> > Relevant logs:
> > 
> > - 
> > [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63527/logs/mesos-tests-build-cmake-stdout.log):
> > 
> > ```
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
> > conversion from 'unsigned __int64' to 'double', possible loss of data 
> > (compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
> > 'argument': conversion from 'double' to 'float', possible loss of data 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
> > 'argument': truncation from 'double' to 'float' 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
> > conversion from 'unsigned __int64' to 'double', possible loss of data 
> > (compiling source file 
> > C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): 
> > warning C4996: 'GetVersionExW': was declared deprecated (compiling source 
> > file C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
> > [C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
> >   C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
> > conversion from 'unsigned __int64' to 'double', possible loss of data 
> > (compiling source file 
> > 

Re: Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63523/#review190003
---



Bad patch!

Reviews applied: [63523, 63511, 63485, 63484, 63483, 63482, 63481, 63432, 
63480, 63414, 63413, 63213, 63212, 63211, 63210, 63200, 63017, 59989, 59988, 
59987, 60109]

Failed command: python support/apply-reviews.py -n -r 59988

Error:
2017-11-03 01:37:31 URL:https://reviews.apache.org/r/59988/diff/raw/ 
[1148/1148] -> "59988.patch" [1]
error: patch failed: 3rdparty/stout/tests/protobuf_tests.proto:24
error: 3rdparty/stout/tests/protobuf_tests.proto: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19976/console

- Mesos Reviewbot


On Nov. 2, 2017, 7:36 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63523/
> ---
> 
> (Updated Nov. 2, 2017, 7:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman, 
> Greg Mann, Jan Schlicht, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of taking offer operations, it's more clear to make allocator
> not aware of offer operations. This patch changes the interface of the
> `updateAllocation` call to take `ResourceConversion`s.
> 
> 
> Diffs
> -
> 
>   include/mesos/allocator/allocator.hpp 
> 537658bf4e68ac7f271248af0e1e35df2b19aef8 
>   src/master/allocator/mesos/allocator.hpp 
> 903edf68e812e022cddedd40a2cb51726b2a181b 
>   src/master/allocator/mesos/hierarchical.hpp 
> c2346054b2c98516f15ab8ce2dc798224ff4def4 
>   src/master/allocator/mesos/hierarchical.cpp 
> 848e9da1b61f411449c0cd2409e98ec733ac10ee 
>   src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28 
>   src/tests/allocator.hpp f1c0d148886b7b2936918b7d7c77c03ee766ee4a 
>   src/tests/hierarchical_allocator_tests.cpp 
> 48b48ad70f44cc2232c2a29699267027f9937b8a 
> 
> 
> Diff: https://reviews.apache.org/r/63523/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 63474: Added a regression test for MESOS-8135.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/#review190002
---



FAIL: Failed to apply the dependent review: 63353.

Failed command: `python.exe .\support\apply-reviews.py -n -r 63353`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63474

Relevant logs:

- 
[apply-review-63353-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63474/logs/apply-review-63353-stdout.log):

```
error: patch failed: src/slave/slave.cpp:1537
error: src/slave/slave.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 3, 2017, 3:51 a.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63474/
> ---
> 
> (Updated Nov. 3, 2017, 3:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
> https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a regression test for MESOS-8135.
> 
> 
> Diffs
> -
> 
>   src/tests/master_slave_reconciliation_tests.cpp 
> d5eb7ba68c5308338236879e7cb1e970a01e48e6 
> 
> 
> Diff: https://reviews.apache.org/r/63474/diff/2/
> 
> 
> Testing
> ---
> 
> Test passes on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63527/#review190001
---



FAIL: Mesos tests failed to build.

Reviews applied: `['63526', '63527']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63527

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63527/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
'argument': conversion from 'double' to 'float', possible loss of data 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
'argument': truncation from 'double' to 'float' 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): 

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/
---

(Updated Nov. 3, 2017, 12:38 a.m.)


Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.


Changes
---

Addressed Vinod's and AlexR's comments.


Bugs: MESOS-8050
https://issues.apache.org/jira/browse/MESOS-8050


Repository: mesos


Description
---

Added IPv6 capabilities for TCP and HTTP healthchecks.


Diffs (updated)
-

  include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b 
  include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b 


Diff: https://reviews.apache.org/r/63434/diff/2/

Changes: https://reviews.apache.org/r/63434/diff/1-2/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189997
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Nov. 2, 2017, 4:54 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> ---
> 
> (Updated Nov. 2, 2017, 4:54 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also updated an out-of-date comment in command_executor_tests.cpp.
> 
> 
> Diffs
> -
> 
>   src/tests/command_executor_tests.cpp 
> 6d6f9160db8232df39cdf1fc403ed4dc4633ecc8 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/2/
> 
> 
> Testing
> ---
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 63278: Windows: Documented the `cpuset` and `mem` isolators.

[Andrew Schwartzmeyer]

> On Nov. 2, 2017, 4:48 p.m., Benjamin Mahler wrote:
> > docs/isolators/windows.md
> > Lines 8 (patched)
> > 
> >
> > Hm.. why is it called cpuset? That word comes from the cgroup subsystem 
> > that lets you restrict which cores can be used by a cgroup, but the windows 
> > mechanisms don't sound the same at all?
> > 
> > Would just `windows/cpu` be more appropriate?

Jie and Joe argued for `cpuset` because it's a hard cap, and so more like 
cgroup's `cpuset` than just the `cpu` isolator.

But if in fact `cpuset` means:
> that lets you restrict which cores can be used by a cgroup

Then yeah, this should be `cpu`.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63278/#review189992
---


On Nov. 2, 2017, 1:40 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63278/
> ---
> 
> (Updated Nov. 2, 2017, 1:40 p.m.)
> 
> 
> Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John 
> Kordich, Joseph Wu, Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6690
> https://issues.apache.org/jira/browse/MESOS-6690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds documentation on the usage of the job object isolators, which
> enable task limits, as well as the statistics they report.
> 
> 
> Diffs
> -
> 
>   docs/isolators/windows.md PRE-CREATION 
>   docs/mesos-containerizer.md 9cb071273a5ce42784457ea01b363911fdb7773d 
> 
> 
> Diff: https://reviews.apache.org/r/63278/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/
---

(Updated Nov. 3, 2017, 7:54 a.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
Kleiman, and Vinod Kone.


Changes
---

Addressed review comment.


Repository: mesos


Description (updated)
---

Also updated an out-of-date comment in command_executor_tests.cpp.


Diffs (updated)
-

  src/tests/command_executor_tests.cpp 6d6f9160db8232df39cdf1fc403ed4dc4633ecc8 
  src/tests/default_executor_tests.cpp 21950f57e9eae741ac219d930fe9c4fc94d4f47f 


Diff: https://reviews.apache.org/r/63499/diff/2/

Changes: https://reviews.apache.org/r/63499/diff/1-2/


Testing
---

No need to run test since this patch is only for disable a test on Windows.


Thanks,

Qian Zhang

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

[Andrew Schwartzmeyer]

> On Nov. 2, 2017, 1:51 p.m., Aaron Wood wrote:
> > 3rdparty/stout/include/stout/windows/os.hpp
> > Line 669 (original), 670 (patched)
> > 
> >
> > How about doing `if (job_handle.get_handle()) {` instead?

Loosely, because of 
[this](https://blogs.msdn.microsoft.com/oldnewthing/20040302-00/?p=40443). The 
invalidness of the underlying `HANDLE` value is inconsistent. You're right, I 
could do `if (!job_handle.get_handle())` for job object handles, but I'm trying 
to be explicit about what is or is not invalid, since other `HANDLE` checks 
will compare to `INVALID_HANDLE_VALUE`. Heck, there should probably be a note 
here that _this_ API represents invalid by `nullptr`.


> On Nov. 2, 2017, 1:51 p.m., Aaron Wood wrote:
> > 3rdparty/stout/include/stout/windows/os.hpp
> > Line 715 (original), 716 (patched)
> > 
> >
> > Might be a bit cleaner to do `if (!result) {`

Yeah, I'm not the hugest fan of the Windows `FALSE` value either. In new code, 
I've tried to avoid it be doing exactly that, just using `!`. We should 
probably write down some guidelines...


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63268/#review189962
---


On Nov. 2, 2017, 1:39 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63268/
> ---
> 
> (Updated Nov. 2, 2017, 1:39 p.m.)
> 
> 
> Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John 
> Kordich, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This changes the CamelCase to snake_case per the style guide for stout.
> It also adds `::` to uses of `::GetLastError` where it was missing, and
> includes `` because it was used but missing.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 09ddec6d69472cd13b453fe1a77fdbe343fc23c8 
> 
> 
> Diff: https://reviews.apache.org/r/63268/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Qian Zhang]

> On Nov. 3, 2017, 1:57 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 1413-1414 (patched)
> > 
> >
> > Re: Alex's comment above:
> > 
> > > MESOS-6698 is resolved. We probably should reopen it or file a new 
> > ticket and update the comment. Or maybe make kill helpers work on windows ; 
> > )?
> > 
> > I second this; this comment is inaccurate as (a) hausdorff no longer 
> > works on Mesos, and (b) the mentioned issue is closed. We need at minimum a 
> > new issue for enabling kill policy helperps on Windows. You can put the 
> > TODO and issue assignee as me.

Agree, I have created a [new 
ticket](https://issues.apache.org/jira/browse/MESOS-8168) for it, and also 
updated this comment and also the comment in command_executor_tests.cpp.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189939
---


On Nov. 2, 2017, 4:27 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> ---
> 
> (Updated Nov. 2, 2017, 4:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> ---
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 63278: Windows: Documented the `cpuset` and `mem` isolators.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63278/#review189992
---




docs/isolators/windows.md
Lines 8 (patched)


Hm.. why is it called cpuset? That word comes from the cgroup subsystem 
that lets you restrict which cores can be used by a cgroup, but the windows 
mechanisms don't sound the same at all?

Would just `windows/cpu` be more appropriate?


- Benjamin Mahler


On Nov. 2, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63278/
> ---
> 
> (Updated Nov. 2, 2017, 8:40 p.m.)
> 
> 
> Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John 
> Kordich, Joseph Wu, Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6690
> https://issues.apache.org/jira/browse/MESOS-6690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds documentation on the usage of the job object isolators, which
> enable task limits, as well as the statistics they report.
> 
> 
> Diffs
> -
> 
>   docs/isolators/windows.md PRE-CREATION 
>   docs/mesos-containerizer.md 9cb071273a5ce42784457ea01b363911fdb7773d 
> 
> 
> Diff: https://reviews.apache.org/r/63278/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 63279: Increased check tests task resources for Windows.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63279/#review189987
---



FAIL: Failed to apply the dependent review: 63275.

Failed command: `python.exe .\support\apply-reviews.py -n -r 63275`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63279

Relevant logs:

- 
[apply-review-63275-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63279/logs/apply-review-63275-stdout.log):

```
error: patch failed: 3rdparty/stout/include/stout/windows/os.hpp:732
error: 3rdparty/stout/include/stout/windows/os.hpp: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 2, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63279/
> ---
> 
> (Updated Nov. 2, 2017, 8:40 p.m.)
> 
> 
> Review request for mesos, Aaron Wood, Akash Gupta, Alexander Rukletsov, Jeff 
> Coffler, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, Li Li, and Michael 
> Park.
> 
> 
> Bugs: MESOS-6690
> https://issues.apache.org/jira/browse/MESOS-6690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unfortunately, due to PowerShell's resource usage as a .NET program, on
> Windows 32 MB is not enough memory to run these tests. One instance of
> PowerShell takes > 128 MB, and two instances take > 256 MB.
> Realistically, the safe minimum is 512 MB of memory.
> 
> 
> Diffs
> -
> 
>   src/tests/check_tests.cpp d3ffc0b0204d021f1ed734ece189d0e3a3fd8844 
> 
> 
> Diff: https://reviews.apache.org/r/63279/diff/1/
> 
> 
> Testing
> ---
> 
> Built and ran `mesos-tests.exe` on Windows repeatedly, verified all tests 
> still pass consistently (likewise for `stout` and `libprocess` tests.
> 
> ~~Currently verifying no breaks on Linux.~~ Built and ran tests on Linux.
> 
> NOTE: There are more check tests that are currently disabled for Windows, 
> that I think should be enabled, but did immediately work for me, so I've left 
> them disabled to unblock myself. Similarly, I would ideally like to port the 
> balloon example framework, and use that to prove the effectiveness of the job 
> object memory hard-cap. Having not yet ported it though, I manually verified 
> the effectiveness of the new isolators by launching test CPU and memory test 
> tasks on a deployed cluster my these changes (and the fact that PowerShell 
> OOM'ed was a nice verification too).
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 63522: Removed unused variable `DefaultExecutorTest.CommitSuicideOnKillTask`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63522/#review189986
---



FAIL: Mesos tests failed to build.

Reviews applied: `['63522']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63522

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63522/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
'argument': conversion from 'double' to 'float', possible loss of data 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
'argument': truncation from 'double' to 'float' 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning 

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56721/#review189977
---




src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 489 (patched)


Pull into a lambda! Or worse case scenario do the following:

.then(defer(self(), [this]() {
  return provisionInLock(containerId, image);
});



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Lines 490 (patched)


.onAny([rwLock]() {
  rwLock.read_unlock();
});


- Gilbert Song


On Oct. 30, 2017, 4:59 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56721/
> ---
> 
> (Updated Oct. 30, 2017, 4:59 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This includes the following changes:
> - add a `pruneImages()` function on the chain of relevant classes;
> - implement prune in docker store;
> - fix mock interface to keep existing tests pass.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.hpp 
> 06d68eef5de7745e32f0e808f11016bcc285dd8f 
>   src/slave/containerizer/composing.cpp 
> 587f009384f0c7ef87482686578dc822d3d5b208 
>   src/slave/containerizer/containerizer.hpp 
> 449bb5d0902936faae7bf9bae9c703b219aed842 
>   src/slave/containerizer/docker.hpp b602a5698cae12686f51c4b9370a06042cda6270 
>   src/slave/containerizer/docker.cpp 292eecbca246edf068ec8c262aff4f3ce9cd8c67 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 6d356ccf82f36df8c6f558fb0ace7d9f982a3d6b 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 100e3bbda543d87808da9ff6bea42da5099ea8c5 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 
> 954da1681778878c8aff6150002e52ecb648d1bb 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> d86afd2a6ff0bf87e624db1c99255c85068bf6ab 
>   src/slave/containerizer/mesos/provisioner/docker/paths.hpp 
> 232c027f8f96da0cb30b957bce4607d3695050d2 
>   src/slave/containerizer/mesos/provisioner/docker/paths.cpp 
> cd684b33eb308ce1eeb4539a5b2d51985d835db7 
>   src/slave/containerizer/mesos/provisioner/docker/store.hpp 
> 1cf68665d33bd40a7605d26c96fb7b618407fdd0 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> f357710cb19aec3654b0604f7909d068eaf20095 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 7cba54ce490d1e6e17081cd7e04fd6759ceddb8e 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 450a3b32d69d2882973a6ed4e94e169a0256056b 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 01ab83dca79e51b8c96d18ee65705912b0ac8324 
>   src/slave/containerizer/mesos/provisioner/store.cpp 
> cc5cc81e05f29bb0e11ffa13cdb8d63d4397114f 
>   src/tests/containerizer.hpp a778b8581904bacea9eec3ff50c3c009959b5dac 
>   src/tests/containerizer.cpp cd140f4263621a0a33a34b7e062a9ca6cf426e7a 
>   src/tests/containerizer/mock_containerizer.hpp 
> 0adcb01e6c12d6cc4abed1f14fa2df833ffc6569 
> 
> 
> Diff: https://reviews.apache.org/r/56721/diff/14/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 63520: Added building the `stout-tests` target to `mesos-tidy`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63520/
---

(Updated Nov. 2, 2017, 4:10 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
---

Added a comment.


Repository: mesos


Description
---

This patch adds `stout-tests` as a build target for `mesos-tidy`
in order to force the generation of `protobuf-tests.pb.h`.


Diffs (updated)
-

  support/mesos-tidy/entrypoint.sh adb554f24ae4ae5f3959c93669b44e40ccb3c77c 


Diff: https://reviews.apache.org/r/63520/diff/2/

Changes: https://reviews.apache.org/r/63520/diff/1-2/


Testing
---


Thanks,

Michael Park

Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189982
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Nov. 2, 2017, 1:27 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> ---
> 
> (Updated Nov. 2, 2017, 1:27 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> ---
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 63529: Added missing lock free event queue and LIFO CMake options.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63529/#review189981
---


Ship it!




Ship It!

- Michael Park


On Nov. 2, 2017, 3:54 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63529/
> ---
> 
> (Updated Nov. 2, 2017, 3:54 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These are used correctly in libprocess, but the options weren't added,
> and so didn't show up in the CMake cache.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 83ccfd2c6d818dbdd13aeba6d024fa5b2edb2bc2 
> 
> 
> Diff: https://reviews.apache.org/r/63529/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 63529: Added missing lock free event queue and LIFO CMake options.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63529/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

These are used correctly in libprocess, but the options weren't added,
and so didn't show up in the CMake cache.


Diffs
-

  cmake/CompilationConfigure.cmake 83ccfd2c6d818dbdd13aeba6d024fa5b2edb2bc2 


Diff: https://reviews.apache.org/r/63529/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189980
---



Patch looks great!

Reviews applied: [63499]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 2, 2017, 4:27 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> ---
> 
> (Updated Nov. 2, 2017, 4:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> ---
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63174/#review189978
---


Ship it!




Are you able to also upload some flame graphs to MESOS-8098 for posterity? To 
avoid including unnecessary data, I guess you could temporarily tweak the 
benchmark to test sleep before and after the timed section so that you can 
start/stop profiling for just the parts we care about.


src/tests/master_benchmarks.cpp
Lines 65-66 (patched)


Can you say we use a static here to avoid the cost of re-parsing?



src/tests/master_benchmarks.cpp
Lines 88 (patched)


Ditto here



src/tests/master_benchmarks.cpp
Lines 316 (patched)


Do you need to print this?


- Benjamin Mahler


On Nov. 1, 2017, 10:06 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63174/
> ---
> 
> (Updated Nov. 1, 2017, 10:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Dmitry Zhuk, and Ilya Pronin.
> 
> 
> Bugs: MESOS-8098
> https://issues.apache.org/jira/browse/MESOS-8098
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current benchmark is very simple: without framework involvement and 
> without agent retries but it's possible to add a number of others so I am 
> creating a new file for them.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/master_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63174/diff/3/
> 
> 
> Testing
> ---
> 
> Benchmark based off 
> https://github.com/apache/mesos/commit/41193181d6b75eeecae2729bf98007d9318e351a
>  (close to current HEAD).
> 
> ```
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 10 running tasks and 10 
> completed tasks in 11.188008209secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
>  (22404 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 20 running tasks and 0 completed 
> tasks in 20.868372615secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
>  (37981 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
> Starting reregistration for all agents
> Reregistered 2 agents with a total of 10 running tasks and 0 
> completed tasks in 15.354579251secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
>  (33766 ms)
> [--] 3 tests from 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test (94151 ms total)
> 
> 
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 10 running tasks and 10 
> completed tasks in 11.045441129secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
>  (19959 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 20 running tasks and 0 completed 
> tasks in 21.324309077secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
>  (38490 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
> Starting reregistration for all agents
> Reregistered 2 agents with a total of 10 running tasks and 0 
> completed tasks in 14.68607521secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
>  (32073 ms)
> [--] 3 tests from 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test (90523 ms total)
> 
> ```
> 
> Benchmark based off 
> https://github.com/apache/mesos/commit/d9c90bf1d9c8b3a7dcc47be0cb773efff57cfb9d
>  (before https://issues.apache.org/jira/browse/MESOS-7713 was merged)
> 
> ```
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 10 running tasks and 10 
> completed tasks in 23.217901878secs
> [   

Re: Review Request 63520: Added building the `stout-tests` target to `mesos-tidy`.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63520/#review189976
---


Fix it, then Ship it!





support/mesos-tidy/entrypoint.sh
Lines 33 (patched)


Let's add a comment here that we do this to generate 
`3rdparty/stout/tests/protobuf_tests.pb.h` (in addition to the commit message).

Ideally we would just generate that file instead of compiling and linking 
the complete test executable, but I wasn't able to get that work when 
generating make build files like we do here.


- Benjamin Bannier


On Nov. 2, 2017, 7:47 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63520/
> ---
> 
> (Updated Nov. 2, 2017, 7:47 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds `stout-tests` as a build target for `mesos-tidy`
> in order to force the generation of `protobuf-tests.pb.h`.
> 
> 
> Diffs
> -
> 
>   support/mesos-tidy/entrypoint.sh adb554f24ae4ae5f3959c93669b44e40ccb3c77c 
> 
> 
> Diff: https://reviews.apache.org/r/63520/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 63474: Added a regression test for MESOS-8135.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/#review189975
---


Fix it, then Ship it!




Would be great to have some better testing abstractions to clean up this test!


src/tests/master_slave_reconciliation_tests.cpp
Lines 718-720 (patched)


Let's maybe adjust this to reflect that we're testing the API as well?



src/tests/master_slave_reconciliation_tests.cpp
Lines 852-854 (patched)


In general, I think wrapping for less jaggedness is more readable:

```
  EXPECT_FALSE(task.has_executor_id())
<< "The command executor ID is present, but it"
<< " shouldn't be sent to the master";
```



src/tests/master_slave_reconciliation_tests.cpp
Lines 898 (patched)


default



src/tests/master_slave_reconciliation_tests.cpp
Lines 899-901 (patched)


The following looks a little more readable?

```
EXPECT_EQ(defaultExecutorInfo.executor_id().value(),
  defaultExecutorTaskExecutorId);
```


- Benjamin Mahler


On Nov. 2, 2017, 7:51 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63474/
> ---
> 
> (Updated Nov. 2, 2017, 7:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
> https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a regression test for MESOS-8135.
> 
> 
> Diffs
> -
> 
>   src/tests/master_slave_reconciliation_tests.cpp 
> d5eb7ba68c5308338236879e7cb1e970a01e48e6 
> 
> 
> Diff: https://reviews.apache.org/r/63474/diff/2/
> 
> 
> Testing
> ---
> 
> Test passes on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 63353: Don't clear the executor ID of executors on re-registration.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63353/#review189974
---


Ship it!




How about the following?

```
Fixed an issue where task executor IDs are missing in the master.

Due to a bug, the agent was erroneously clearing the executor ID
of non-command executor's tasks before sending the
`ReregisterSlaveMessage` message. This leads to the master having
tasks with missing executor IDs (see MESOS-8135).

Also, it turns out that the clearing of executor ID's is actually
unnecessary altogether, as command executor tasks already do not
have an executor ID set.

Review: https://reviews.apache.org/r/63353/
```

I think it's nice for bug fixes to clearly state what they're fixing in the 
summary (that's what people will see in the short log).

- Benjamin Mahler


On Nov. 2, 2017, 7:52 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63353/
> ---
> 
> (Updated Nov. 2, 2017, 7:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
> https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the agent would sometimes clear the executor ID of
> non-command executors before sending the `ReregisterSlaveMessage`
> message.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 
> 
> 
> Diff: https://reviews.apache.org/r/63353/diff/4/
> 
> 
> Testing
> ---
> 
> Verified that the new test fails on GNU/Linux without the rest of the patch, 
> but passes with it.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Review Request 63526: Fixed TASK_UNKNOWN status ambiguity.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63526/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-8165
https://issues.apache.org/jira/browse/MESOS-8165


Repository: mesos


Description
---

Currently, TASK_UNKNOWN status covers 2 different cases: task is
unknown, but the agent is registered; task is unknown and the agent is
unknown. This makes it ambiguous to frameworks. In the first case the
framework may elect to wait for some time to see if the agent with the
task comes back. In the second case the task is definitely in a terminal
state and should be reported as TASK_GONE.


Diffs
-

  src/master/master.cpp 49bc50ead75adba82a7d8de23a87b06ccd269c48 
  src/tests/partition_tests.cpp 7b11264718b1ab7edbe594335a1f8130bef0236d 
  src/tests/reconciliation_tests.cpp 8ae2860591afc8eec04b7c23322cd7dd964bbcb3 


Diff: https://reviews.apache.org/r/63526/diff/1/


Testing
---

Adjusted existing tests. Ran `make check`.


Thanks,

Ilya Pronin

Review Request 63527: Added MESOS-8165 to the 1.5.0 CHANGELOG.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63527/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-8165
https://issues.apache.org/jira/browse/MESOS-8165


Repository: mesos


Description
---

Added MESOS-8165 to the 1.5.0 CHANGELOG.


Diffs
-

  CHANGELOG b7bcc98de51b7bcd0c2f5b2e703a5c51af10c2fb 


Diff: https://reviews.apache.org/r/63527/diff/1/


Testing
---

N/A


Thanks,

Ilya Pronin

Re: Review Request 63279: Increased check tests task resources for Windows.

[Aaron Wood via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63279/#review189972
---


Ship it!




Ship It!

- Aaron Wood


On Nov. 2, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63279/
> ---
> 
> (Updated Nov. 2, 2017, 8:40 p.m.)
> 
> 
> Review request for mesos, Aaron Wood, Akash Gupta, Alexander Rukletsov, Jeff 
> Coffler, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, Li Li, and Michael 
> Park.
> 
> 
> Bugs: MESOS-6690
> https://issues.apache.org/jira/browse/MESOS-6690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Unfortunately, due to PowerShell's resource usage as a .NET program, on
> Windows 32 MB is not enough memory to run these tests. One instance of
> PowerShell takes > 128 MB, and two instances take > 256 MB.
> Realistically, the safe minimum is 512 MB of memory.
> 
> 
> Diffs
> -
> 
>   src/tests/check_tests.cpp d3ffc0b0204d021f1ed734ece189d0e3a3fd8844 
> 
> 
> Diff: https://reviews.apache.org/r/63279/diff/1/
> 
> 
> Testing
> ---
> 
> Built and ran `mesos-tests.exe` on Windows repeatedly, verified all tests 
> still pass consistently (likewise for `stout` and `libprocess` tests.
> 
> ~~Currently verifying no breaks on Linux.~~ Built and ran tests on Linux.
> 
> NOTE: There are more check tests that are currently disabled for Windows, 
> that I think should be enabled, but did immediately work for me, so I've left 
> them disabled to unblock myself. Similarly, I would ideally like to port the 
> balloon example framework, and use that to prove the effectiveness of the job 
> object memory hard-cap. Having not yet ported it though, I manually verified 
> the effectiveness of the new isolators by launching test CPU and memory test 
> tasks on a deployed cluster my these changes (and the fact that PowerShell 
> OOM'ed was a nice verification too).
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 63278: Windows: Documented the `cpuset` and `mem` isolators.

[Aaron Wood via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63278/#review189971
---


Ship it!




Ship It!

- Aaron Wood


On Nov. 2, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63278/
> ---
> 
> (Updated Nov. 2, 2017, 8:40 p.m.)
> 
> 
> Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John 
> Kordich, Joseph Wu, Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6690
> https://issues.apache.org/jira/browse/MESOS-6690
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds documentation on the usage of the job object isolators, which
> enable task limits, as well as the statistics they report.
> 
> 
> Diffs
> -
> 
>   docs/isolators/windows.md PRE-CREATION 
>   docs/mesos-containerizer.md 9cb071273a5ce42784457ea01b363911fdb7773d 
> 
> 
> Diff: https://reviews.apache.org/r/63278/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63523/#review189969
---



FAIL: Failed to apply the dependent review: 59988.

Failed command: `python.exe .\support\apply-reviews.py -n -r 59988`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63523

Relevant logs:

- 
[apply-review-59988-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63523/logs/apply-review-59988-stdout.log):

```
error: patch failed: 3rdparty/stout/tests/protobuf_tests.proto:24
error: 3rdparty/stout/tests/protobuf_tests.proto: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 2, 2017, 7:36 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63523/
> ---
> 
> (Updated Nov. 2, 2017, 7:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman, 
> Greg Mann, Jan Schlicht, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of taking offer operations, it's more clear to make allocator
> not aware of offer operations. This patch changes the interface of the
> `updateAllocation` call to take `ResourceConversion`s.
> 
> 
> Diffs
> -
> 
>   include/mesos/allocator/allocator.hpp 
> 537658bf4e68ac7f271248af0e1e35df2b19aef8 
>   src/master/allocator/mesos/allocator.hpp 
> 903edf68e812e022cddedd40a2cb51726b2a181b 
>   src/master/allocator/mesos/hierarchical.hpp 
> c2346054b2c98516f15ab8ce2dc798224ff4def4 
>   src/master/allocator/mesos/hierarchical.cpp 
> 848e9da1b61f411449c0cd2409e98ec733ac10ee 
>   src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28 
>   src/tests/allocator.hpp f1c0d148886b7b2936918b7d7c77c03ee766ee4a 
>   src/tests/hierarchical_allocator_tests.cpp 
> 48b48ad70f44cc2232c2a29699267027f9937b8a 
> 
> 
> Diff: https://reviews.apache.org/r/63523/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 63520: Added building the `stout-tests` target to `mesos-tidy`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63520/#review189968
---



FAIL: Mesos tests failed to build.

Reviews applied: `['62844', '63520']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63520

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63520/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
'argument': conversion from 'double' to 'float', possible loss of data 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
'argument': truncation from 'double' to 'float' 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): 

Re: Review Request 63273: Windows: Added `os::get_job_processes` to stout.

[Aaron Wood via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63273/#review189966
---




3rdparty/stout/include/stout/windows/os.hpp
Lines 793 (patched)


Do you want to start at 4 here instead? It looks like PID 0 on Windows is 
the `Idle` process and PID 4 is the `System` process. You could cut down on 
iteration too by incrementing in multiples of 4. It seems that both thread IDs 
and process IDs are multiples of 4 
https://blogs.msdn.microsoft.com/oldnewthing/20080228-00/?p=23283/

They do mention that you should not rely on this behavior which is too bad. 
If you could always assume this you could reduce your cycles here.


- Aaron Wood


On Nov. 2, 2017, 8:40 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63273/
> ---
> 
> (Updated Nov. 2, 2017, 8:40 p.m.)
> 
> 
> Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John 
> Kordich, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Returns a `set` for all the processes in a job object.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 09ddec6d69472cd13b453fe1a77fdbe343fc23c8 
> 
> 
> Diff: https://reviews.apache.org/r/63273/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 63422: Updated os::unsetenv to clear the old environment value.

[James Peach]

> On Nov. 2, 2017, 8:23 p.m., Greg Mann wrote:
> > 3rdparty/stout/include/stout/posix/os.hpp
> > Lines 175 (patched)
> > 
> >
> > I'm curious: is there a reason you use `memset()` instead of `setenv()` 
> > here?

`setenv` will make the element in the environment array point to a different 
value but won't actually nuke an existing value.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63422/#review189954
---


On Oct. 30, 2017, 6:14 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63422/
> ---
> 
> (Updated Oct. 30, 2017, 6:14 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8140
> https://issues.apache.org/jira/browse/MESOS-8140
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> On Linux, updating the environment with unsetenv(3) does not
> change the value that other processes can inspect (e.g. through
> `/proc/$pid/environ`). Overwrite the existing value (if any) prior
> to calling unsetenv(3) so we can know it is really gone.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/posix/os.hpp 
> 8511dfd419a646df17eb687d732bb975f4c23d53 
> 
> 
> Diff: https://reviews.apache.org/r/63422/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

[Aaron Wood via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63268/#review189963
---


Ship it!




Ship It!

- Aaron Wood


On Nov. 2, 2017, 8:39 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63268/
> ---
> 
> (Updated Nov. 2, 2017, 8:39 p.m.)
> 
> 
> Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John 
> Kordich, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This changes the CamelCase to snake_case per the style guide for stout.
> It also adds `::` to uses of `::GetLastError` where it was missing, and
> includes `` because it was used but missing.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 09ddec6d69472cd13b453fe1a77fdbe343fc23c8 
> 
> 
> Diff: https://reviews.apache.org/r/63268/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

[Aaron Wood via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63268/#review189962
---




3rdparty/stout/include/stout/windows/os.hpp
Line 669 (original), 670 (patched)


How about doing `if (job_handle.get_handle()) {` instead?



3rdparty/stout/include/stout/windows/os.hpp
Line 715 (original), 716 (patched)


Might be a bit cleaner to do `if (!result) {`


- Aaron Wood


On Nov. 2, 2017, 8:39 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63268/
> ---
> 
> (Updated Nov. 2, 2017, 8:39 p.m.)
> 
> 
> Review request for mesos, Aaron Wood, Akash Gupta, Jeff Coffler, Jie Yu, John 
> Kordich, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This changes the CamelCase to snake_case per the style guide for stout.
> It also adds `::` to uses of `::GetLastError` where it was missing, and
> includes `` because it was used but missing.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 09ddec6d69472cd13b453fe1a77fdbe343fc23c8 
> 
> 
> Diff: https://reviews.apache.org/r/63268/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 63422: Updated os::unsetenv to clear the old environment value.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63422/#review189954
---




3rdparty/stout/include/stout/posix/os.hpp
Lines 175 (patched)


I'm curious: is there a reason you use `memset()` instead of `setenv()` 
here?


- Greg Mann


On Oct. 30, 2017, 6:14 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63422/
> ---
> 
> (Updated Oct. 30, 2017, 6:14 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8140
> https://issues.apache.org/jira/browse/MESOS-8140
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> On Linux, updating the environment with unsetenv(3) does not
> change the value that other processes can inspect (e.g. through
> `/proc/$pid/environ`). Overwrite the existing value (if any) prior
> to calling unsetenv(3) so we can know it is really gone.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/posix/os.hpp 
> 8511dfd419a646df17eb687d732bb975f4c23d53 
> 
> 
> Diff: https://reviews.apache.org/r/63422/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63353/
---

(Updated Nov. 2, 2017, 12:52 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.


Changes
---

We found out that there's actually no need to clear executor IDs at any point.


Bugs: MESOS-8135
https://issues.apache.org/jira/browse/MESOS-8135


Repository: mesos


Description
---

Previously the agent would sometimes clear the executor ID of
non-command executors before sending the `ReregisterSlaveMessage`
message.


Diffs (updated)
-

  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 


Diff: https://reviews.apache.org/r/63353/diff/3/

Changes: https://reviews.apache.org/r/63353/diff/2-3/


Testing
---

Verified that the new test fails on GNU/Linux without the rest of the patch, 
but passes with it.


Thanks,

Gaston Kleiman

Re: Review Request 63474: Added a regression test for MESOS-8135.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/
---

(Updated Nov. 2, 2017, 12:51 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.


Changes
---

Check the master's `/state` endpoint response.


Bugs: MESOS-8135
https://issues.apache.org/jira/browse/MESOS-8135


Repository: mesos


Description
---

Added a regression test for MESOS-8135.


Diffs (updated)
-

  src/tests/master_slave_reconciliation_tests.cpp 
d5eb7ba68c5308338236879e7cb1e970a01e48e6 


Diff: https://reviews.apache.org/r/63474/diff/2/

Changes: https://reviews.apache.org/r/63474/diff/1-2/


Testing
---

Test passes on GNU/Linux.


Thanks,

Gaston Kleiman

Re: Review Request 63496: Added tests for agent resource version transmission.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63496/#review189952
---



FAIL: Mesos tests failed to build.

Reviews applied: `['63519', '61183', '63491', '63492', '63493', '63494', 
'63495', '63496']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63496

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63496/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2072): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
'argument': conversion from 'double' to 'float', possible loss of data 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
'argument': truncation from 'double' to 'float' 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2072): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2072): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 

Re: Review Request 63522: Removed unused variable `DefaultExecutorTest.CommitSuicideOnKillTask`.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63522/
---

(Updated Nov. 2, 2017, 12:36 p.m.)


Review request for mesos and Greg Mann.


Repository: mesos


Description
---

Removed unused variable `DefaultExecutorTest.CommitSuicideOnKillTask`.


Diffs
-

  src/tests/default_executor_tests.cpp 21950f57e9eae741ac219d930fe9c4fc94d4f47f 


Diff: https://reviews.apache.org/r/63522/diff/1/


Testing (updated)
---

Tests still compile =).


Thanks,

Gaston Kleiman

Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63523/
---

Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman, 
Greg Mann, Jan Schlicht, Vinod Kone, and Jiang Yan Xu.


Repository: mesos


Description
---

Instead of taking offer operations, it's more clear to make allocator
not aware of offer operations. This patch changes the interface of the
`updateAllocation` call to take `ResourceConversion`s.


Diffs
-

  include/mesos/allocator/allocator.hpp 
537658bf4e68ac7f271248af0e1e35df2b19aef8 
  src/master/allocator/mesos/allocator.hpp 
903edf68e812e022cddedd40a2cb51726b2a181b 
  src/master/allocator/mesos/hierarchical.hpp 
c2346054b2c98516f15ab8ce2dc798224ff4def4 
  src/master/allocator/mesos/hierarchical.cpp 
848e9da1b61f411449c0cd2409e98ec733ac10ee 
  src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28 
  src/tests/allocator.hpp f1c0d148886b7b2936918b7d7c77c03ee766ee4a 
  src/tests/hierarchical_allocator_tests.cpp 
48b48ad70f44cc2232c2a29699267027f9937b8a 


Diff: https://reviews.apache.org/r/63523/diff/1/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 63511: Introduced ResourceConversion to represent conversion to Resources.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63511/#review189949
---



Bad patch!

Reviews applied: [63511, 63485, 63484, 63483, 63482, 63481, 63432, 63480, 
63414, 63413, 63213, 63212, 63211, 63210, 63200, 63017, 59989, 59988, 59987, 
60109]

Failed command: python support/apply-reviews.py -n -r 59988

Error:
2017-11-02 19:12:00 URL:https://reviews.apache.org/r/59988/diff/raw/ 
[1148/1148] -> "59988.patch" [1]
error: patch failed: 3rdparty/stout/tests/protobuf_tests.proto:24
error: 3rdparty/stout/tests/protobuf_tests.proto: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19972/console

- Mesos Reviewbot


On Nov. 2, 2017, 1:54 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63511/
> ---
> 
> (Updated Nov. 2, 2017, 1:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman, 
> Greg Mann, Jan Schlicht, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, we couple offer operations with resource conversions. For
> instance, we have interfaces like `Resources::apply` that takes an
> offer operation. This becomes less ideal because an offer operation
> might not represent a `conversion` anymore with new offer operation
> like `CREATE_VOLUME` being introduced.
> 
> This patch decoupled resource conversions from offer operations.
> `Resources::apply` will now take a `ResourceConversion` object. We
> also provide some helpers to get a `ResourceConversion` from an offer
> operation (if supported).
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 53152b393ec38ca2fc2e2a66c18a29a4418fe59e 
>   include/mesos/v1/resources.hpp 6c2191c044c52607618283891f82401c4861c441 
>   src/common/resources.cpp 914d3e2b1e8fe55ecab9c71643954addd6a81244 
>   src/common/resources_utils.hpp 18e3d9d4baad23669d00542594f5c15a989b7b9e 
>   src/common/resources_utils.cpp e34cd8a3c9046a6f12c12a275a7b3a852b492f4c 
>   src/v1/resources.cpp 58568b8d25cb1402a875d3975d2decb4270d2725 
> 
> 
> Diff: https://reviews.apache.org/r/63511/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

[Vinod Kone]

> On Nov. 2, 2017, 6:48 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto
> > Lines 512-516 (patched)
> > 
> >
> > When I see this enum, I have several questions, for example, "how this 
> > fits into overall IPv6 story?", "shall this enum be global?", "what about 
> > `CheckInfo` message?". Since we are going to deprecate `HealchCheck` at 
> > some point, I'm fine with adding an ad-hoc solution here, but I would like 
> > to have a note here about what our long-term plan is (and that provides 
> > some sorts of answers to the questions above).

Yea, one option is to directly use "NetworkInfo::Protocol" instead of 
re-declaring it here.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review189946
---


On Oct. 30, 2017, 11:57 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> ---
> 
> (Updated Oct. 30, 2017, 11:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added IPv6 capabilities for TCP and HTTP healthchecks.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b 
>   include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b 
> 
> 
> Diff: https://reviews.apache.org/r/63434/diff/1/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63434/#review189946
---




include/mesos/mesos.proto
Lines 512-516 (patched)


When I see this enum, I have several questions, for example, "how this fits 
into overall IPv6 story?", "shall this enum be global?", "what about 
`CheckInfo` message?". Since we are going to deprecate `HealchCheck` at some 
point, I'm fine with adding an ad-hoc solution here, but I would like to have a 
note here about what our long-term plan is (and that provides some sorts of 
answers to the questions above).



include/mesos/mesos.proto
Lines 523 (patched)


Let's call it `protocol` to avoid confusion


- Alexander Rukletsov


On Oct. 30, 2017, 11:57 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63434/
> ---
> 
> (Updated Oct. 30, 2017, 11:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8050
> https://issues.apache.org/jira/browse/MESOS-8050
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added IPv6 capabilities for TCP and HTTP healthchecks.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 12652fe2804efdd2228c8e8c95b88e1f4b762f7b 
>   include/mesos/v1/mesos.proto e0797aea6ffe200aab5b0bde5450dbd7c332618b 
> 
> 
> Diff: https://reviews.apache.org/r/63434/diff/1/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Review Request 63520: Added building the `stout-tests` target to `mesos-tidy`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63520/
---

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
---

This patch adds `stout-tests` as a build target for `mesos-tidy`
in order to force the generation of `protobuf-tests.pb.h`.


Diffs
-

  support/mesos-tidy/entrypoint.sh adb554f24ae4ae5f3959c93669b44e40ccb3c77c 


Diff: https://reviews.apache.org/r/63520/diff/1/


Testing
---


Thanks,

Michael Park

Re: Review Request 63023: WIP: Added a test CSI plugin.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63023/#review189943
---




src/examples/test_csi_plugin.cpp
Lines 664 (patched)


`NodePublishVolume` and `NodeUnpublishVolume` should be idempotent.


- Chun-Hung Hsiao


On Oct. 28, 2017, 12:08 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63023/
> ---
> 
> (Updated Oct. 28, 2017, 12:08 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8102
> https://issues.apache.org/jira/browse/MESOS-8102
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test CSI plugin would just create subdirectories under its working
> directories to mimic the behavior of creating volumes, then bind-mount
> those volumes to mimic publish.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b60a54a031260de6f1fb43584ae5083df2dc7e31 
>   src/examples/test_csi_plugin.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63023/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Review Request 63522: Removed unused variable `DefaultExecutorTest.CommitSuicideOnKillTask`.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63522/
---

Review request for mesos.


Repository: mesos


Description
---

Removed unused variable `DefaultExecutorTest.CommitSuicideOnKillTask`.


Diffs
-

  src/tests/default_executor_tests.cpp 21950f57e9eae741ac219d930fe9c4fc94d4f47f 


Diff: https://reviews.apache.org/r/63522/diff/1/


Testing
---


Thanks,

Gaston Kleiman

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

[Gaston Kleiman]

> On Nov. 1, 2017, 8 a.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 538-548 (patched)
> > 
> >
> > This is racy; there's no guarantee that the first `TASK_RUNNING` status 
> > update will come after the second `TASK_STARTING` update.
> > 
> > The following ordering would also be possible: [`TASK_STARTING`, 
> > `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]
> 
> Alexander Rukletsov wrote:
> To simplify the logic here, let's introduce a matcher in our tests, 
> something like
> ```
> MATCHER_P(TaskStateEq, state, "") { return arg.state() == state; }
> ```
> which we then can use like
> ```
> Future status;
>   EXPECT_CALL(sched, statusUpdate(, TaskStateEq(TASK_RUNNING)))
> .WillOnce(FutureArg<1>());
> ```
> Then you can combine both task state and task id matchers to get an exact 
> status update.
> 
> Gaston Kleiman wrote:
> AlexR suggested something like this:
> 
> ```
>   Sequence task1;
>   EXPECT_CALL(
>   *scheduler,
>   update(_, AllOf(TaskStatusEq(TASK_STARTING), 
> TaskStateEq(taskInfo1
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
> 
>   EXPECT_CALL(
>   *scheduler,
>   update(_, AllOf(TaskStatusEq(TASK_RUNNING), 
> TaskStateEq(taskInfo1
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
> 
>   Sequence task2;
>   EXPECT_CALL(
>   *scheduler,
>   update(_, AllOf(TaskStatusEq(TASK_STARTING), 
> TaskStateEq(taskInfo2
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
> 
>   EXPECT_CALL(
>   *scheduler,
>   update(_, AllOf(TaskStatusEq(TASK_RUNNING), 
> TaskStateEq(taskInfo2
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>   
>   AWAIT_READY(startingUpdate1);
>   AWAIT_READY(runningUpdate1);
> 
>   AWAIT_READY(startingUpdate2);
>   AWAIT_READY(runningUpdate2);
> ```
> 
> Alexander Rukletsov wrote:
> Parameters are mixed up : )
> `AllOf(TaskStatusEq(), TaskStateEq())`
> Also feel free to refactor `TaskStatusEq` to take an id if you think it 
> is simpler.
> 
> Qian Zhang wrote:
> So I think we also have this race for the test 
> `DefaultExecutorTest.KillTaskGroupOnTaskFailure`? See the code here: 
> https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L649:L670
> 
> And it seems the test `DefaultExecutorTest.KillTask` 
> (https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L301:L355)
>  handles such race, so what about we follow that way?

The `TASK_STARTING` handling in 
https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L301:L355
 is a recent change, and I must say that I am not very happy with it.

It has the following flaws:

  - It doesn't check the task IDs of the updates.
  - It only checks two of the four expected updates, so it doesn't ensure that 
tasks correctly transition from `TASK_STARTING` to `TASK_RUNNING`.

I'd prefer to follow AlexR's suggestion or what we do in 
`DefaultExecutorTest.CommitSuicideOnKillTask`: 
https://github.com/apache/mesos/blob/11538e4179217f0cd891f848b1221ad13b88a50a/src/tests/default_executor_tests.cpp#L1124-L1175


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
---


On Oct. 30, 2017, 9:53 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> ---
> 
> (Updated Oct. 30, 2017, 9:53 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 5078bd4d70698f5cbd14c971fcecfd58f8467a04 
> 
> 
> Diff: https://reviews.apache.org/r/62837/diff/2/
> 
> 
> Testing
> ---
> 
> [ RUN  ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 

Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189939
---




src/tests/default_executor_tests.cpp
Lines 1413-1414 (patched)


Re: Alex's comment above:

> MESOS-6698 is resolved. We probably should reopen it or file a new ticket 
and update the comment. Or maybe make kill helpers work on windows ; )?

I second this; this comment is inaccurate as (a) hausdorff no longer works 
on Mesos, and (b) the mentioned issue is closed. We need at minimum a new issue 
for enabling kill policy helperps on Windows. You can put the TODO and issue 
assignee as me.


- Andrew Schwartzmeyer


On Nov. 2, 2017, 1:27 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> ---
> 
> (Updated Nov. 2, 2017, 1:27 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> ---
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 63515: Updated xfs/disk, gpu, and cgroups isolators' prepare function.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63515/#review189938
---



FAIL: Mesos tests failed to build.

Reviews applied: `['60888', '60889', '60890', '60891', '62142', '62143', 
'62144', '62145', '63054', '63056', '63057', '63058', '63063', '63514', 
'63515']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63515

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63515/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\status_update_manager_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
'argument': conversion from 'double' to 'float', possible loss of data 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
'argument': truncation from 'double' to 'float' 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 

Re: Review Request 63493: Transmitted agent resource versions in (re)registration.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63493/
---

(Updated Nov. 2, 2017, 6:48 p.m.)


Review request for mesos, Gaston Kleiman, Greg Mann, Jie Yu, and Jan Schlicht.


Changes
---

Rebased.


Repository: mesos


Description
---

This commit introduces resource version fields into agent registration
and reregistration message. The agent is changed to set these fields
when needed; the master in turn stores the versions for use in to be
added speculated offer operations.


Diffs (updated)
-

  src/messages/messages.proto 2fbca22e1285aa25900f5420bb4370bda6a1bb12 
  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 


Diff: https://reviews.apache.org/r/63493/diff/2/

Changes: https://reviews.apache.org/r/63493/diff/1-2/


Testing
---

`make check`, additional testing as part of https://reviews.apache.org/r/63496/.


Thanks,

Benjamin Bannier

Re: Review Request 63492: Synchronized agent clock with master via 'UpdateSlaveMessage'.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63492/
---

(Updated Nov. 2, 2017, 6:48 p.m.)


Review request for mesos, Gaston Kleiman, Greg Mann, Jie Yu, and Jan Schlicht.


Changes
---

Rebased, made conditional on agent capability now.


Repository: mesos


Description
---

This commit introduces agent clocks to the master and agents. Agents
are responsible for maintaining their clock. The clocks are
synchronized with the master via 'UpdateSlaveMessage'.


Diffs (updated)
-

  src/master/master.hpp afcc2e46882e4c610e9047ab3db7b6f100d47e17 
  src/master/master.cpp 49bc50ead75adba82a7d8de23a87b06ccd269c48 
  src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 


Diff: https://reviews.apache.org/r/63492/diff/2/

Changes: https://reviews.apache.org/r/63492/diff/1-2/


Testing
---

`make check`, additional testing as part of https://reviews.apache.org/r/63496/.


Thanks,

Benjamin Bannier

Re: Review Request 63496: Added tests for agent resource version transmission.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63496/
---

(Updated Nov. 2, 2017, 6:48 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
---

Rebased.


Repository: mesos


Description
---

This patch introduces separate tests for clock values communicated
from resource providers and from agents to masters.


Diffs (updated)
-

  src/tests/slave_tests.cpp aae5e6021b46793fa2b871aaa738f61c8cfb88ce 


Diff: https://reviews.apache.org/r/63496/diff/2/

Changes: https://reviews.apache.org/r/63496/diff/1-2/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61183/
---

(Updated Nov. 2, 2017, 6:47 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
---

Only send updates when agent is marked resource provider capable.


Repository: mesos


Description
---

The agent's resource provider manager sends a
'ResourceProviderMessage' when its managed resources change. This
commit adds handling in the agent so that an 'UpdateSlaveMessage' is
sent to the master to update the total resource available on the
agent.

In order to provide push-like handling of the resource provider
manager's message queue, we chain recursive calls to the handler for
continuous processing. Initially, processing is kicked off from
'Slave::initialize'. In this simple implementation we e.g., provide no
direct way to stop processing of messages, yet, but it can be achieved
by e.g., replacing the manager with a new instance (this would also
require updating routes).

Since the agent can only send an 'UpdateSlaveMessage' when it is
registered with a master, a simple back-off of 5 s is implemented which
will defer processing of a ready message should the agent not yet have
registered.

To facilitate logging we add a stringification function for
'ResourceProviderMessage's.

This patch also adjusts a number of tests to no expect two
'UpdateSlaveMessage's.


Diffs (updated)
-

  src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521 
  src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 
  src/tests/slave_tests.cpp aae5e6021b46793fa2b871aaa738f61c8cfb88ce 


Diff: https://reviews.apache.org/r/61183/diff/19/

Changes: https://reviews.apache.org/r/61183/diff/18-19/


Testing
---

Tested on a number of platforms on internal CI.


Thanks,

Benjamin Bannier

Review Request 63519: Allowed toggling of agent capabilities via command line flags.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/
---

Review request for mesos, Jie Yu and Jan Schlicht.


Repository: mesos


Description
---

This patch introduces a new agent command line flags
'--agent_features' which can be used to whitelist capabilities to
enable. This flag is intended to enable introducing feature flags in
the future so experimental features can be added while still reducing
the risk of breaking existing functionality. Currently only the
'RESOURCE_PROVIDER' capability can be toggled.


Diffs
-

  docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c 
  src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba 
  src/slave/flags.cpp 789b45b8d84fc01733a885754204fe2fdd6d6807 
  src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 


Diff: https://reviews.apache.org/r/63519/diff/1/


Testing
---

`make check`, tested as part of https://reviews.apache.org/r/63496/


Thanks,

Benjamin Bannier

Review Request 63515: Updated xfs/disk, gpu, and cgroups isolators' prepare function.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63515/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
---

These three isolators refered to the ExecutorInfo field of the given
ContainerConfig to determine the total resources to isolate.  This
changes these isolators to refer instead to the Resources field of the
given ContainerConfig because the resource amounts should be identical
(enforced by the caller to Containerizer::launch, such as the agent)
and in order to support standalone containers, which specify resources
but no ExecutorInfo.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
549a4551736d1b88a79f275a2d6e19c586c49f26 
  src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
25636b50314cb4ea53d1931c97c87c65ecb658a8 
  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
2113f8665e4e84bdf12868f605b480522816a9ba 


Diff: https://reviews.apache.org/r/63515/diff/1/


Testing
---

make check
sudo src/mesos-tests

On... 
OSX and Ubuntu 16


Thanks,

Joseph Wu

Review Request 63514: Updated tests with Containerizer::launch interface change.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63514/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
---

This commit contains the test changes required due to the interface
change in https://reviews.apache.org/r/63063 .

Instead of `AWAIT_ASSERT_TRUE(...)`, the affected test lines now use
`AWAIT_ASSERT_EQ(Containerizer::LaunchResult::SUCCESS, ...)`.


Diffs
-

  src/tests/containerizer.hpp a778b8581904bacea9eec3ff50c3c009959b5dac 
  src/tests/containerizer.cpp cd140f4263621a0a33a34b7e062a9ca6cf426e7a 
  src/tests/containerizer/composing_containerizer_tests.cpp 
61e47e9cffb565e4621babb28e9bf8736945c386 
  src/tests/containerizer/io_switchboard_tests.cpp 
c3410cdbb21b974455d443a18e4af09eddea59ca 
  src/tests/containerizer/isolator_tests.cpp 
4ad42bc427acebc7fe7e4d8d0d346537db23c9b1 
  src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
4dfd90bee600f3b91183c60a0216d3990f0fba10 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
e61a85df6ec5308ccd2832e66df803b0ad7b53ee 
  src/tests/containerizer/mock_containerizer.hpp 
0adcb01e6c12d6cc4abed1f14fa2df833ffc6569 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
fbd2887800ccfd64c8628c5d6fd77a511c8f91d5 
  src/tests/containerizer/volume_host_path_isolator_tests.cpp 
1d006727e5bf76cc659e862cb64fe3facd608c8c 
  src/tests/containerizer/volume_image_isolator_tests.cpp 
2f91730075c0eca455be84bc1f1b01b4395fb382 
  src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 
b36c8df4df346096ed3f0ca3411b3ab5d9a8c74e 
  src/tests/containerizer/volume_secret_isolator_tests.cpp 
a55af954bdacfcc7b629fe6e5c47759dc0e8a709 
  src/tests/hook_tests.cpp 542878210d0d335f504220ac21284a3239f419ee 
  src/tests/mock_docker.hpp 59873646be494c8fe6aebf5ede595d77e3ac4cae 
  src/tests/slave_recovery_tests.cpp db337ba4e213820e7ad0c3f1b480388a2e456556 
  src/tests/slave_tests.cpp aae5e6021b46793fa2b871aaa738f61c8cfb88ce 


Diff: https://reviews.apache.org/r/63514/diff/1/


Testing
---

make check

On... 
OSX and Ubuntu 16


Thanks,

Joseph Wu

Re: Review Request 63063: Modified Containerizer::launch interface to allow repeated launch.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63063/
---

(Updated Nov. 2, 2017, 9:02 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Rebase, polish, and propagate test changes.


Summary (updated)
-

Modified Containerizer::launch interface to allow repeated launch.


Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
---

There is some existing tech debt around requiring the caller of
`Containerizer::launch` to call `Containerizer::destroy` if the launch
fails (see MESOS-6214).  For nested and standalone containers, the
side effect of this results in accidentally destroying running
containers if you make the same call an even number of times.

For example, suppose the user launches a valid nested container
with an ID of 'parent.child'. If the user issues the same call to
launch 'parent.child' again, this second call will fail *and* will
also destroy the first container.

This commit prevents repeated launch calls from destroying containers
by changing the return value of `Containerizer::launch`.  There are
now four possible return values:
  * The launch succeeded.
  * The standalone/nested container already exists.
  * The given ContainerConfig is not supported.
  * The launch failed.


Diffs (updated)
-

  src/slave/containerizer/composing.hpp 
06d68eef5de7745e32f0e808f11016bcc285dd8f 
  src/slave/containerizer/composing.cpp 
587f009384f0c7ef87482686578dc822d3d5b208 
  src/slave/containerizer/containerizer.hpp 
449bb5d0902936faae7bf9bae9c703b219aed842 
  src/slave/containerizer/docker.hpp b602a5698cae12686f51c4b9370a06042cda6270 
  src/slave/containerizer/docker.cpp 292eecbca246edf068ec8c262aff4f3ce9cd8c67 
  src/slave/containerizer/mesos/containerizer.hpp 
6d356ccf82f36df8c6f558fb0ace7d9f982a3d6b 
  src/slave/containerizer/mesos/containerizer.cpp 
100e3bbda543d87808da9ff6bea42da5099ea8c5 
  src/slave/http.cpp f2e06aff95e0628624b6ed25de222fd3f3577a0b 
  src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 
  src/tests/agent_container_api_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63063/diff/2/

Changes: https://reviews.apache.org/r/63063/diff/1-2/


Testing (updated)
---

Requires the next review in the chain (test changes).


Thanks,

Joseph Wu

Re: Review Request 63058: Changed failure response of LAUNCH containers API.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63058/
---

(Updated Nov. 2, 2017, 9:01 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Rebase and propagate fixes from prior review.


Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
---

By default, the HTTP handlers in libprocess will translate failures
(of returned Futures) into '500 Internal Server Error'.  This commit
only changes the `LAUNCH_NESTED_CONTAINER` and `LAUNCH_CONTAINER` APIs
to return '400 Bad Request' instead when the container launch fails,
as it is more likely for the failure to be a user-input error.


Diffs (updated)
-

  src/slave/http.cpp f2e06aff95e0628624b6ed25de222fd3f3577a0b 
  src/tests/agent_container_api_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/63058/diff/2/

Changes: https://reviews.apache.org/r/63058/diff/1-2/


Testing (updated)
---

make check

On... 
OSX and Ubuntu 16


Thanks,

Joseph Wu

Re: Review Request 63057: Moved and refactored some nested container tests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63057/
---

(Updated Nov. 2, 2017, 9 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Rebase and propagate fixes from prior review.


Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
---

This moves tests for the Nested container API found in `api_tests.cpp`
into `agent_container_api_tests.cpp` and refactors the moved tests to:
  * Exercise the MesosContainerizer, rather than mocks.
  * Parameterize tests to use the Standalone container API or Nested
container API.
  * Parameterize tests to exercise different isolator combinations.

Additionally, the  `NestedContainerWaitNotFound` and
`NestedContainerKillNotFound` tests are now combined into
`NestedContainerNotFound`.

>From the `nested_mesos_containerizer_tests.cpp`, the `WaitAfterDestroy`
and `LaunchNestedThreeLevels` were deleted as the same codepaths are now
covered by `NestedContainerLaunch` and `TwoLevelNestedContainerLaunch`
respectively.


Diffs (updated)
-

  src/tests/agent_container_api_tests.cpp PRE-CREATION 
  src/tests/api_tests.cpp b3efac942f538bcf2594a397d54042028a7aa7a5 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp 
fbd2887800ccfd64c8628c5d6fd77a511c8f91d5 


Diff: https://reviews.apache.org/r/63057/diff/2/

Changes: https://reviews.apache.org/r/63057/diff/1-2/


Testing (updated)
---

make check

On... 
OSX and Ubuntu 16


Thanks,

Joseph Wu

Re: Review Request 63056: Parameterized test for nested container launch.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63056/
---

(Updated Nov. 2, 2017, 9 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Fixed a few issues:

* Test parameterization needs to specify the launcher along with isolators.
* Was missing a default command value for the normal nested container case.
* Reaping to speed up WaitContainer calls was racy, and thus removed.
* The FrameworkInfo for normal parent containers needed to enable checkpointing.


Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
---

This introduces a new test class that is parameterized based
on the type of API used to launch (1) the parent container,
(2) the nested container, and (3) the content type (like all
other API tests).  The test is also parameterized based
on the enabled set of isolators.

Because this change overlaps with existing nested container
API tests, those test(s) will be removed.


Diffs (updated)
-

  src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 
  src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
  src/tests/agent_container_api_tests.cpp PRE-CREATION 
  src/tests/api_tests.cpp b3efac942f538bcf2594a397d54042028a7aa7a5 


Diff: https://reviews.apache.org/r/63056/diff/2/

Changes: https://reviews.apache.org/r/63056/diff/1-2/


Testing (updated)
---

make check

On... 
OSX and Ubuntu 16


Thanks,

Joseph Wu

Re: Review Request 62145: Implemented Standalone Container API.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62145/
---

(Updated Nov. 2, 2017, 8:57 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Updated implementation of `WaitContainer` to match `WaitNestedContainer`.


Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
---

The Standalone and Nested Container APIs are very similar.
This commit combines the two API implementations by adding a
translation function (i.e. `launchNestedContainer` and 
`launchContainer`) which unpacks the V1 protobuf into fields
which can be passed into a common function (i.e. `_launchContainer`).

The common functions authorize based on the type of container being
launched and it is possible to use both Standalone and Nested
Container APIs interchangably for nested containers.

This approach is somewhat messy for for the `WAIT_(NESTED_)CONTAINER`
calls, as these methods require different return protobufs based on
the original call.


Diffs (updated)
-

  src/slave/http.hpp 44a95dec4c9b8bb65d712c5538bbd7afffe2cf7b 
  src/slave/http.cpp f2e06aff95e0628624b6ed25de222fd3f3577a0b 


Diff: https://reviews.apache.org/r/62145/diff/4/

Changes: https://reviews.apache.org/r/62145/diff/3-4/


Testing
---

See later in chain.


Thanks,

Joseph Wu

Re: Review Request 60890: Defined API for launching standalone containers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60890/#review189922
---




include/mesos/agent/agent.proto
Lines 253-255 (patched)


Leaving this up for discussion:

The existing call (`RemoveNestedContainer`) either returns 200 or 500, so 
for backwards compatibility, `RemoveContainer` does the same.

On the other hand, returning a 404 may be somewhat difficult as 
`Containerizer::remove` returns a `Future`.  Other methods like 
`::launch`, `::wait`, or `::kill` all a magic value if the container doesn't 
exist.


- Joseph Wu


On Nov. 2, 2017, 8:50 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60890/
> ---
> 
> (Updated Nov. 2, 2017, 8:50 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7305
> https://issues.apache.org/jira/browse/MESOS-7305
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Launching a standalone container is very similar to launching a
> nested container, except that the caller must specify some Resources.
> As such, this patch deprecates some nested container APIs
> and replaces them with more generically named APIs.
> 
> This applies to the Launch, Wait, Kill, and Remove
> (nested) container APIs.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 4df3dcef4bd1d42cb8b4955e290bd38038355e46 
>   include/mesos/v1/agent/agent.proto e99d23d55a0951f2ed728360e103d83ea5a1ad7f 
> 
> 
> Diff: https://reviews.apache.org/r/60890/diff/5/
> 
> 
> Testing
> ---
> 
> make
> 
> See later patches in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 60890: Defined API for launching standalone containers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60890/
---

(Updated Nov. 2, 2017, 8:50 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Added HTTP response codes to the comments.  Also copy-pasted a missing comment 
from the unversioned proto of WaitNestedContainer to the versioned proto.


Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
---

Launching a standalone container is very similar to launching a
nested container, except that the caller must specify some Resources.
As such, this patch deprecates some nested container APIs
and replaces them with more generically named APIs.

This applies to the Launch, Wait, Kill, and Remove
(nested) container APIs.


Diffs (updated)
-

  include/mesos/agent/agent.proto 4df3dcef4bd1d42cb8b4955e290bd38038355e46 
  include/mesos/v1/agent/agent.proto e99d23d55a0951f2ed728360e103d83ea5a1ad7f 


Diff: https://reviews.apache.org/r/60890/diff/5/

Changes: https://reviews.apache.org/r/60890/diff/4-5/


Testing
---

make

See later patches in chain.


Thanks,

Joseph Wu

Re: Review Request 60888: Added recovery logic for standalone containers.

[Joseph Wu]

> On Oct. 17, 2017, 10:39 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Line 757 (original), 758 (patched)
> > 
> >
> > not yours, can you add a comment here saying that parent containerid 
> > will be guaranteed to appear first in the vector. This is important for the 
> > following code to always be able to find the parent container information 
> > for a nested container.

The ordering did not appear to matter for nested containers in the past, but 
now it does.  The note I added explains why.


> On Oct. 17, 2017, 10:39 a.m., Jie Yu wrote:
> > src/slave/paths.hpp
> > Lines 53-54 (patched)
> > 
> >
> > Putting this path here is a bit wierd because this directory is kind of 
> > containerizer specific.
> > 
> > I'd suggest we create a `src/slave/containerizer/paths.hpp` to put 
> > those path helper functions.
> > 
> > `src/slave/paths.hpp` should probably only have paths that are related 
> > to slave, but not containers. In the future, the sandbox for executors can 
> > be a symlink to the actual container sandbox.

Leaving this open as I didn't change the directory structure...

Sandbox directories (for normal and standalone containers) are currently 
specified by the agent, so it makes sense to have this directory in the agent's 
helper.  The containerizer only specifies sandboxes for nested containers by 
appending onto an existing sandbox (which itself is directly or indirectly (for 
multi-level nested containers) specified by the agent).


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60888/#review188334
---


On Nov. 2, 2017, 8:43 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60888/
> ---
> 
> (Updated Nov. 2, 2017, 8:43 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7305
> https://issues.apache.org/jira/browse/MESOS-7305
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Although there is no way to launch standalone containers yet,
> this commit outlines the expected layout of container metadata
> which should be populated when launching standalone containers.
> 
> The layout is fairly simple, as standalone containers have no
> framework, executor, or tasks to worry about.  The sandbox directory
> will live under a new top-level directory `containers` and there is
> no metadata to checkpoint at the moment.
> 
> The containerizer will checkpoint a marker file (in the runtime
> directory) so that it knows to recover all standalone containers.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 100e3bbda543d87808da9ff6bea42da5099ea8c5 
>   src/slave/containerizer/mesos/paths.hpp 
> a03f15e01e8eb8a1326baad8d7db96a79d785482 
>   src/slave/containerizer/mesos/paths.cpp 
> 0c61c20c345a327ec469b382558aaeed0280e754 
>   src/slave/paths.hpp f000508d414daf9f943561f89c7105503a8a98b3 
>   src/slave/paths.cpp fd546525b900cb6524fb9196d19616ef18de0f30 
> 
> 
> Diff: https://reviews.apache.org/r/60888/diff/4/
> 
> 
> Testing
> ---
> 
> See next patch and later ones too.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 60889: Added basic tests for launching standalone containers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60889/
---

(Updated Nov. 2, 2017, 8:45 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Rebase and specify isolators in the test.


Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
---

Within the containerizer, standalone containers are treated like
any other container (such as those with executors/tasks), so the
MesosContainerizerTests focus on the difference in arguments passed
for standalone containers.


Diffs (updated)
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
e61a85df6ec5308ccd2832e66df803b0ad7b53ee 
  src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 


Diff: https://reviews.apache.org/r/60889/diff/3/

Changes: https://reviews.apache.org/r/60889/diff/2-3/


Testing
---

make check

NOTE: This test is rather basic because there must be an API in order
to launch standalone containers via the agent (to test recovery of said 
containers during agent recovery).  The API will be added in subsequent patches.


Thanks,

Joseph Wu

Re: Review Request 60888: Added recovery logic for standalone containers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60888/
---

(Updated Nov. 2, 2017, 8:43 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Fixed recovery for nested containers launched underneath standalone containers. 
 These nested containers were not being marked as `isRecoverableNestedContainer 
= true` because the set of "alive" containers is determined from the 
`SlaveState`, which does not include standalone containers.  To fix this, the 
`alive` hashset was removed, because, for the purpose of finding the top-level 
container, the existing `containers_` hashmap is sufficient.


Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305


Repository: mesos


Description
---

Although there is no way to launch standalone containers yet,
this commit outlines the expected layout of container metadata
which should be populated when launching standalone containers.

The layout is fairly simple, as standalone containers have no
framework, executor, or tasks to worry about.  The sandbox directory
will live under a new top-level directory `containers` and there is
no metadata to checkpoint at the moment.

The containerizer will checkpoint a marker file (in the runtime
directory) so that it knows to recover all standalone containers.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
100e3bbda543d87808da9ff6bea42da5099ea8c5 
  src/slave/containerizer/mesos/paths.hpp 
a03f15e01e8eb8a1326baad8d7db96a79d785482 
  src/slave/containerizer/mesos/paths.cpp 
0c61c20c345a327ec469b382558aaeed0280e754 
  src/slave/paths.hpp f000508d414daf9f943561f89c7105503a8a98b3 
  src/slave/paths.cpp fd546525b900cb6524fb9196d19616ef18de0f30 


Diff: https://reviews.apache.org/r/60888/diff/4/

Changes: https://reviews.apache.org/r/60888/diff/3-4/


Testing
---

See next patch and later ones too.


Thanks,

Joseph Wu

Re: Review Request 63511: Introduced ResourceConversion to represent conversion to Resources.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63511/#review189914
---



FAIL: Failed to apply the dependent review: 59988.

Failed command: `python.exe .\support\apply-reviews.py -n -r 59988`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63511

Relevant logs:

- 
[apply-review-59988-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63511/logs/apply-review-59988-stdout.log):

```
error: patch failed: 3rdparty/stout/tests/protobuf_tests.proto:24
error: 3rdparty/stout/tests/protobuf_tests.proto: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 2, 2017, 6:54 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63511/
> ---
> 
> (Updated Nov. 2, 2017, 6:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman, 
> Greg Mann, Jan Schlicht, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently, we couple offer operations with resource conversions. For
> instance, we have interfaces like `Resources::apply` that takes an
> offer operation. This becomes less ideal because an offer operation
> might not represent a `conversion` anymore with new offer operation
> like `CREATE_VOLUME` being introduced.
> 
> This patch decoupled resource conversions from offer operations.
> `Resources::apply` will now take a `ResourceConversion` object. We
> also provide some helpers to get a `ResourceConversion` from an offer
> operation (if supported).
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp 53152b393ec38ca2fc2e2a66c18a29a4418fe59e 
>   include/mesos/v1/resources.hpp 6c2191c044c52607618283891f82401c4861c441 
>   src/common/resources.cpp 914d3e2b1e8fe55ecab9c71643954addd6a81244 
>   src/common/resources_utils.hpp 18e3d9d4baad23669d00542594f5c15a989b7b9e 
>   src/common/resources_utils.cpp e34cd8a3c9046a6f12c12a275a7b3a852b492f4c 
>   src/v1/resources.cpp 58568b8d25cb1402a875d3975d2decb4270d2725 
> 
> 
> Diff: https://reviews.apache.org/r/63511/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 63511: Introduced ResourceConversion to represent conversion to Resources.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63511/
---

Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman, 
Greg Mann, Jan Schlicht, and Vinod Kone.


Repository: mesos


Description
---

Currently, we couple offer operations with resource conversions. For
instance, we have interfaces like `Resources::apply` that takes an
offer operation. This becomes less ideal because an offer operation
might not represent a `conversion` anymore with new offer operation
like `CREATE_VOLUME` being introduced.

This patch decoupled resource conversions from offer operations.
`Resources::apply` will now take a `ResourceConversion` object. We
also provide some helpers to get a `ResourceConversion` from an offer
operation (if supported).


Diffs
-

  include/mesos/resources.hpp 53152b393ec38ca2fc2e2a66c18a29a4418fe59e 
  include/mesos/v1/resources.hpp 6c2191c044c52607618283891f82401c4861c441 
  src/common/resources.cpp 914d3e2b1e8fe55ecab9c71643954addd6a81244 
  src/common/resources_utils.hpp 18e3d9d4baad23669d00542594f5c15a989b7b9e 
  src/common/resources_utils.cpp e34cd8a3c9046a6f12c12a275a7b3a852b492f4c 
  src/v1/resources.cpp 58568b8d25cb1402a875d3975d2decb4270d2725 


Diff: https://reviews.apache.org/r/63511/diff/1/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189904
---



PASS: Mesos patch 63499 was successfully built and tested.

Reviews applied: `['63499']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63499

- Mesos Reviewbot Windows


On Nov. 2, 2017, 4:27 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> ---
> 
> (Updated Nov. 2, 2017, 4:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> ---
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Alexander Rukletsov]

> On Nov. 2, 2017, 11:23 a.m., Alexander Rukletsov wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 1413-1416 (original), 1413-1419 (patched)
> > 
> >
> > Pease use `TEST_P_TEMP_DISABLED_ON_WINDOWS` instead

Qian pointed that it is a build failure, hence my comment does not make sense. 
Dropping.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189900
---


On Nov. 2, 2017, 8:27 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> ---
> 
> (Updated Nov. 2, 2017, 8:27 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> ---
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Alexander Rukletsov]

> On Nov. 2, 2017, 5:51 a.m., Andrew Schwartzmeyer wrote:
> > Who is hausdorff and why is this their TODO?
> 
> Qian Zhang wrote:
> hausdorff is Alex Clemmer's Github account, I think he was working on 
> Windows porting. Actually I found this comment 
> [here](https://github.com/apache/mesos/blob/1.4.0/src/tests/command_executor_tests.cpp#L226),
>  we had the similar issue when using kill policy helper in command executor 
> test, I think it's better to keep this comment unchanged since it's 
> originally from hausdorff.

MESOS-6698 is resolved. We probably should reopen it or file a new ticket and 
update the comment. Or maybe make kill helpers work on windows ; )?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189882
---


On Nov. 2, 2017, 8:27 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> ---
> 
> (Updated Nov. 2, 2017, 8:27 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> ---
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 63497: Fixed the unit test that missed to check the TASK_STARTING update.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63497/#review189901
---


Ship it!




Ship It!

- Alexander Rukletsov


On Nov. 2, 2017, 8:12 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63497/
> ---
> 
> (Updated Nov. 2, 2017, 8:12 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gaston Kleiman, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the unit test that missed to check the TASK_STARTING update.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> ad05da6c227cdc5f6bc3ea8b8e6207cea0569e36 
> 
> 
> Diff: https://reviews.apache.org/r/63497/diff/1/
> 
> 
> Testing
> ---
> 
> I run this test in a loop for 20 times, it works well.
> 
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from DockerContainerizerTest
> [ RUN  ] 
> DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToFinished
> [   OK ] 
> DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToFinished (2696 
> ms)
> [--] 1 test from DockerContainerizerTest (2698 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (2737 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189900
---




src/tests/default_executor_tests.cpp
Lines 1413-1416 (original), 1413-1419 (patched)


Pease use `TEST_P_TEMP_DISABLED_ON_WINDOWS` instead


- Alexander Rukletsov


On Nov. 2, 2017, 8:27 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> ---
> 
> (Updated Nov. 2, 2017, 8:27 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> ---
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 63463: Added support for credential secret to test-http-framework.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63463/#review189899
---


Ship it!




Ship It!

- Armand Grillet


On Nov. 1, 2017, 2:39 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63463/
> ---
> 
> (Updated Nov. 1, 2017, 2:39 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Alexander Rojas.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds the ability to authenticate against the master to the 
> test-http-framework.
> 
> 
> Diffs
> -
> 
>   src/examples/test_http_framework.cpp 
> 693dd47694678e7439f9d4ab0ff77b93950edf6e 
> 
> 
> Diff: https://reviews.apache.org/r/63463/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 63501: Initial `3rdparty/README.md`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63501/#review189898
---



FAIL: Mesos tests failed to build.

Reviews applied: `['63501']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63501

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63501/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
'argument': conversion from 'double' to 'float', possible loss of data 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
'argument': truncation from 'double' to 'float' 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning 

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

[Qian Zhang]

> On Nov. 1, 2017, 11 p.m., Gaston Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 538-548 (patched)
> > 
> >
> > This is racy; there's no guarantee that the first `TASK_RUNNING` status 
> > update will come after the second `TASK_STARTING` update.
> > 
> > The following ordering would also be possible: [`TASK_STARTING`, 
> > `TASK_RUNNING`, `TASK_STARTING`, `TASK_RUNNING`, ...]
> 
> Alexander Rukletsov wrote:
> To simplify the logic here, let's introduce a matcher in our tests, 
> something like
> ```
> MATCHER_P(TaskStateEq, state, "") { return arg.state() == state; }
> ```
> which we then can use like
> ```
> Future status;
>   EXPECT_CALL(sched, statusUpdate(, TaskStateEq(TASK_RUNNING)))
> .WillOnce(FutureArg<1>());
> ```
> Then you can combine both task state and task id matchers to get an exact 
> status update.
> 
> Gaston Kleiman wrote:
> AlexR suggested something like this:
> 
> ```
>   Sequence task1;
>   EXPECT_CALL(
>   *scheduler,
>   update(_, AllOf(TaskStatusEq(TASK_STARTING), 
> TaskStateEq(taskInfo1
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
> 
>   EXPECT_CALL(
>   *scheduler,
>   update(_, AllOf(TaskStatusEq(TASK_RUNNING), 
> TaskStateEq(taskInfo1
> .InSequence(task1)
> .WillOnce(
> DoAll(
> FutureArg<1>(),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
> 
>   Sequence task2;
>   EXPECT_CALL(
>   *scheduler,
>   update(_, AllOf(TaskStatusEq(TASK_STARTING), 
> TaskStateEq(taskInfo2
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
> 
>   EXPECT_CALL(
>   *scheduler,
>   update(_, AllOf(TaskStatusEq(TASK_RUNNING), 
> TaskStateEq(taskInfo2
> .InSequence(task2)
> .WillOnce(
> DoAll(
> FutureArg<1>(),
> v1::scheduler::SendAcknowledge(frameworkId, agentId)));
>   
>   AWAIT_READY(startingUpdate1);
>   AWAIT_READY(runningUpdate1);
> 
>   AWAIT_READY(startingUpdate2);
>   AWAIT_READY(runningUpdate2);
> ```
> 
> Alexander Rukletsov wrote:
> Parameters are mixed up : )
> `AllOf(TaskStatusEq(), TaskStateEq())`
> Also feel free to refactor `TaskStatusEq` to take an id if you think it 
> is simpler.

So I think we also have this race for the test 
`DefaultExecutorTest.KillTaskGroupOnTaskFailure`? See the code here: 
https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L649:L670

And it seems the test `DefaultExecutorTest.KillTask` 
(https://github.com/apache/mesos/blob/master/src/tests/default_executor_tests.cpp#L301:L355)
 handles such race, so what about we follow that way?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62837/#review189800
---


On Oct. 31, 2017, 12:53 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62837/
> ---
> 
> (Updated Oct. 31, 2017, 12:53 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8051
> https://issues.apache.org/jira/browse/MESOS-8051
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `DefaultExecutorTest.KillMultipleTasks`.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 5078bd4d70698f5cbd14c971fcecfd58f8467a04 
> 
> 
> Diff: https://reviews.apache.org/r/62837/diff/2/
> 
> 
> Testing
> ---
> 
> [ RUN  ] MesosContainerizer/DefaultExecutorTest.KillMultipleTasks/0
> I1030 21:47:58.181413 22360 executor.cpp:192] Version: 1.5.0
> I1030 21:47:58.201525 22382 default_executor.cpp:191] Received SUBSCRIBED 
> event
> I1030 21:47:58.203812 22382 default_executor.cpp:195] Subscribed executor on 
> core-dev
> I1030 21:47:58.204406 22382 default_executor.cpp:191] Received LAUNCH_GROUP 
> event
> I1030 21:47:58.205346 22390 default_executor.cpp:402] Setting 
> 'MESOS_CONTAINER_IP' to: 10.0.49.2
> I1030 21:47:58.220854 22356 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.221959 22367 default_executor.cpp:191] Received ACKNOWLEDGED 
> event
> I1030 21:47:58.261060 22370 default_executor.cpp:640] Successfully launched 
> tasks [ 4fee2fec-12b5-4af6-bd70-e67b4da26c00, 
> 

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63174/#review189892
---



Patch looks great!

Reviews applied: [63174]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 1, 2017, 10:06 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63174/
> ---
> 
> (Updated Nov. 1, 2017, 10:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Dmitry Zhuk, and Ilya Pronin.
> 
> 
> Bugs: MESOS-8098
> https://issues.apache.org/jira/browse/MESOS-8098
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current benchmark is very simple: without framework involvement and 
> without agent retries but it's possible to add a number of others so I am 
> creating a new file for them.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 1c97b1fd8151f87c4e9e6d62884b0ef7d582c312 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/master_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63174/diff/3/
> 
> 
> Testing
> ---
> 
> Benchmark based off 
> https://github.com/apache/mesos/commit/41193181d6b75eeecae2729bf98007d9318e351a
>  (close to current HEAD).
> 
> ```
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 10 running tasks and 10 
> completed tasks in 11.188008209secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
>  (22404 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 20 running tasks and 0 completed 
> tasks in 20.868372615secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
>  (37981 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
> Starting reregistration for all agents
> Reregistered 2 agents with a total of 10 running tasks and 0 
> completed tasks in 15.354579251secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
>  (33766 ms)
> [--] 3 tests from 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test (94151 ms total)
> 
> 
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 10 running tasks and 10 
> completed tasks in 11.045441129secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
>  (19959 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 20 running tasks and 0 completed 
> tasks in 21.324309077secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
>  (38490 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
> Starting reregistration for all agents
> Reregistered 2 agents with a total of 10 running tasks and 0 
> completed tasks in 14.68607521secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/2
>  (32073 ms)
> [--] 3 tests from 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test (90523 ms total)
> 
> ```
> 
> Benchmark based off 
> https://github.com/apache/mesos/commit/d9c90bf1d9c8b3a7dcc47be0cb773efff57cfb9d
>  (before https://issues.apache.org/jira/browse/MESOS-7713 was merged)
> 
> ```
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 10 running tasks and 10 
> completed tasks in 23.217901878secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/0
>  (38327 ms)
> [ RUN  ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
> Starting reregistration for all agents
> Reregistered 2000 agents with a total of 20 running tasks and 0 completed 
> tasks in 46.158610597secs
> [   OK ] 
> AgentFrameworkTaskCount/MasterFailover_BENCHMARK_Test.AgentReregistrationDelay/1
>  (75280 ms)
> [ RUN  ] 
> 

Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/
---

(Updated Nov. 2, 2017, 4:21 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Vinod Kone.


Repository: mesos


Description
---

Fixed the unit test that broke Windows build.


Diffs
-

  src/tests/default_executor_tests.cpp 21950f57e9eae741ac219d930fe9c4fc94d4f47f 


Diff: https://reviews.apache.org/r/63499/diff/1/


Testing (updated)
---

No need to run test since this patch is only for disable a test on Windows.


Thanks,

Qian Zhang

Re: Review Request 63497: Fixed the unit test that missed to check the TASK_STARTING update.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63497/
---

(Updated Nov. 2, 2017, 4:12 p.m.)


Review request for mesos, Alexander Rukletsov, Gaston Kleiman, and Vinod Kone.


Repository: mesos


Description
---

Fixed the unit test that missed to check the TASK_STARTING update.


Diffs
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
ad05da6c227cdc5f6bc3ea8b8e6207cea0569e36 


Diff: https://reviews.apache.org/r/63497/diff/1/


Testing (updated)
---

I run this test in a loop for 20 times, it works well.

[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from DockerContainerizerTest
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToFinished
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToFinished (2696 ms)
[--] 1 test from DockerContainerizerTest (2698 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (2737 ms total)
[  PASSED  ] 1 test.


Thanks,

Qian Zhang

Re: Review Request 63497: Fixed the unit test that missed to check the TASK_STARTING update.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63497/#review189888
---



FAIL: Mesos tests failed to build.

Reviews applied: `['63497']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63497

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63497/logs/mesos-tests-build-cmake-stdout.log):

```
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\uri_fetcher_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\http_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\recordio_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file C:\DCOS\mesos\mesos\src\tests\values_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4244: 
'argument': conversion from 'double' to 'float', possible loss of data 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\tests\values_tests.cpp(51): warning C4305: 
'argument': truncation from 'double' to 'float' 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\common\type_utils_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(59): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(448): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\docker_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file 
C:\DCOS\mesos\mesos\src\tests\containerizer\containerizer_tests.cpp) 
[C:\DCOS\mesos\src\tests\mesos-tests.vcxproj]
  C:\DCOS\mesos\mesos\src\master/master.hpp(2070): warning 

Re: Review Request 63499: Fixed the unit test that broke Windows build.

[Qian Zhang]

> On Nov. 2, 2017, 1:51 p.m., Andrew Schwartzmeyer wrote:
> > Who is hausdorff and why is this their TODO?

hausdorff is Alex Clemmer's Github account, I think he was working on Windows 
porting. Actually I found this comment 
[here](https://github.com/apache/mesos/blob/1.4.0/src/tests/command_executor_tests.cpp#L226),
 we had the similar issue when using kill policy helper in command executor 
test, I think it's better to keep this comment unchanged since it's originally 
from hausdorff.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189882
---


On Nov. 2, 2017, 1:27 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> ---
> 
> (Updated Nov. 2, 2017, 1:27 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 63501: Initial `3rdparty/README.md`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63501/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

A start of a `README.md` for the 3rdparty dependencies.


Diffs
-

  3rdparty/README.md PRE-CREATION 


Diff: https://reviews.apache.org/r/63501/diff/1/


Testing
---


Thanks,

Michael Park

Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/
---

(Updated Nov. 2, 2017, 12:45 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Took the `3rdparty/README.md` out.


Repository: mesos


Description
---

Our upstreamed PR to the `concurrentqueue` project was merged,
(https://github.com/cameron314/concurrentqueue/commit/420509b)
which fixes the Clang / libstdc++ configuration. Since there are
a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
we bundle the latest SHA on `master` here.


Diffs (updated)
-

  3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
  3rdparty/concurrentqueue-1.0.0-beta.tar.gz 
1bf4a88362e7d60cd22474f20fff62f788539308 
  3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
  3rdparty/concurrentqueue.md PRE-CREATION 
  3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 


Diff: https://reviews.apache.org/r/63472/diff/2/

Changes: https://reviews.apache.org/r/63472/diff/1-2/


Testing
---

With Clang-3.9.0
```bash
CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl 
--enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue 
--disable-java --disable-python
make distcheck
```
```bash
CC=clang CXX=clang++ cmake -DCMAKE_BUILD_TYPE=Release 
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DENABLE_LIBEVENT=ON -DENABLE_SSL=ON 
-DENABLE_LOCK_FREE_RUN_QUEUE=ON ..
cmake --build --target tests
ctest -V
```


Thanks,

Michael Park

Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/
---

(Updated Nov. 2, 2017, 12:44 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Tested with CMake as well.


Repository: mesos


Description
---

Our upstreamed PR to the `concurrentqueue` project was merged,
(https://github.com/cameron314/concurrentqueue/commit/420509b)
which fixes the Clang / libstdc++ configuration. Since there are
a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
we bundle the latest SHA on `master` here.


Diffs
-

  3rdparty/README.md PRE-CREATION 
  3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
  3rdparty/concurrentqueue-1.0.0-beta.tar.gz 
1bf4a88362e7d60cd22474f20fff62f788539308 
  3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
  3rdparty/concurrentqueue.md PRE-CREATION 
  3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 


Diff: https://reviews.apache.org/r/63472/diff/1/


Testing (updated)
---

With Clang-3.9.0
```bash
CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl 
--enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue 
--disable-java --disable-python
make distcheck
```
```bash
CC=clang CXX=clang++ cmake -DCMAKE_BUILD_TYPE=Release 
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DENABLE_LIBEVENT=ON -DENABLE_SSL=ON 
-DENABLE_LOCK_FREE_RUN_QUEUE=ON ..
cmake --build --target tests
ctest -V
```


Thanks,

Michael Park

Re: Review Request 63476: Revert "Added a test `ROOT_NoTransitionFromKillingToFinished`".

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63476/#review189885
---



Patch looks great!

Reviews applied: [63476]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 2, 2017, 5:04 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63476/
> ---
> 
> (Updated Nov. 2, 2017, 5:04 a.m.)
> 
> 
> Review request for mesos, Qian Zhang and Vinod Kone.
> 
> 
> Bugs: MESOS-8157
> https://issues.apache.org/jira/browse/MESOS-8157
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This reverts commit 815263ead42f64fd0ff320614cfada30b2e8f899.
> 
> The commit being reverted introduced a build break on Windows.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
>   src/tests/kill_policy_test_helper.cpp 
> 28768a3fc02e3e6b2a0f531e6b6b2865aab51f3d 
> 
> 
> Diff: https://reviews.apache.org/r/63476/diff/1/
> 
> 
> Testing
> ---
> 
> Successfully built on Windows after failing to build before the revert.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>