Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

[Eric Chung]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64970/
---

(Updated Feb. 23, 2018, 7:58 a.m.)


Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Summary (updated)
-

Replace ad hoc venv under support/ with tox.


Repository: mesos


Description
---

Use tox for linting and testing code living uder src/python.

At the moment, all linting is done through the same `pylint`
installation under support/.virtualenv, which requires ALL dependencies
(i.e. pip-requirements.txt, requirements.in scattered in various
directories) to be installed in the same virtualenv, making things
really messy -- e.g. when I've changed some code under `src/python/lib`,
but don't have the dev virtualenv activated, linting will fail since
none of the dependencies under `src/python/lib` have been installed.

Using tox, we can solve this problem by distributing a "test spec"
(tox.ini) in each of the python source directories which are aware of
its local dependencies only. To test or lint the code there would be as
simple as running `tox -e py27-lint `, and the corresponding
virtualenv and test dependencies would automatically be setup.

This patch modifies `support/mesos-style.py` to install `tox` in
`support/.virtualenv` and delegates linting to a `tox` call when it sees
python directories that have tox setup for it. Linting for all other
languages will not be effected.

Testing Done:
1. intentionally create a lint error, such as extra spaces before a
parens in a python file
2. run the pre-commit hook and see tox in action

Reviewed at https://reviews.apache.org/r/64970/


Diffs (updated)
-

  src/python/cli_new/tox.ini PRE-CREATION 
  src/python/lib/requirements-test.in b2b73aab65377d9310797203ea84c5150ae60805 
  src/python/lib/tox.ini fd5e89c77c8608fea21e9caad814c6e111ad57db 
  support/mesos-style.py 47ec36949010fa511d1b3974739c5ad5c03f6f7f 


Diff: https://reviews.apache.org/r/64970/diff/4/

Changes: https://reviews.apache.org/r/64970/diff/3-4/


Testing
---

1. intentionally create a lint error, such as extra spaces before a parens in a 
python file
2. run the pre-commit hook and see tox in action


Thanks,

Eric Chung

Re: Review Request 65683: Updated discard handling in Docker library functions.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/
---

(Updated Feb. 23, 2018, 7:46 a.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, Michael Park, and Vinod 
Kone.


Changes
---

Avoided potential memory leak with repeated `.onDiscard()`


Bugs: MESOS-8575
https://issues.apache.org/jira/browse/MESOS-8575


Repository: mesos


Description
---

Updated discard handling in Docker library functions.


Diffs (updated)
-

  src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61 
  src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28 


Diff: https://reviews.apache.org/r/65683/diff/5/

Changes: https://reviews.apache.org/r/65683/diff/4-5/


Testing
---


Thanks,

Greg Mann

Re: Review Request 65728: Add test to check quotes in docker executor health check.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review198157
---



Patch looks great!

Reviews applied: [65393, 65394, 65395, 65396, 65419, 65127, 65615, 64387, 
65727, 65733, 64604, 65728]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 22, 2018, 1:51 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> ---
> 
> (Updated Feb. 22, 2018, 1:51 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-4812 and MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
> 
> 
> Diffs
> -
> 
>   src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab 
> 
> 
> Diff: https://reviews.apache.org/r/65728/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 65728: Add test to check quotes in docker executor health check.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/#review198156
---



PASS: Mesos patch 65728 was successfully built and tested.

Reviews applied: `['65393', '65394', '65395', '65396', '65419', '65127', 
'65615', '64387', '65727', '65733', '64604', '65728']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65728

- Mesos Reviewbot Windows


On Feb. 22, 2018, 1:51 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65728/
> ---
> 
> (Updated Feb. 22, 2018, 1:51 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-4812 and MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
> the docker executor properly deals with quotes in the command health
> check to ensure that MESOS-4812 is fixed.
> 
> 
> Diffs
> -
> 
>   src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab 
> 
> 
> Diff: https://reviews.apache.org/r/65728/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 65718: Allowed empty resource provider selector in `UriDiskProfileAdaptor`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65718/#review198155
---



PASS: Mesos patch 65718 was successfully built and tested.

Reviews applied: `['65718']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65718

- Mesos Reviewbot Windows


On Feb. 23, 2018, 8:12 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65718/
> ---
> 
> (Updated Feb. 23, 2018, 8:12 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8598
> https://issues.apache.org/jira/browse/MESOS-8598
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed empty resource provider selector in `UriDiskProfileAdaptor`.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/disk_profile_utils.cpp 
> a243bd6f89919c69c2fe0a94c60f8251e35e23a0 
>   src/tests/disk_profile_tests.cpp 1bbbde0d026e8e7388d341746587913926002144 
> 
> 
> Diff: https://reviews.apache.org/r/65718/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65683: Updated discard handling in Docker library functions.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review198154
---




src/docker/docker.cpp
Lines 1314-1315 (patched)


I'm thinking I need to do something different to clean these things up, 
since `_inspect()` is invoked repeatedly by the retry logic.

Probably better to register a single `onDiscard` callback in `inspect()`, 
which will perform this cleanup on a couple of persistent containers which we 
reassign in the body of `_inspect()`.


- Greg Mann


On Feb. 22, 2018, 12:36 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65683/
> ---
> 
> (Updated Feb. 22, 2018, 12:36 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Michael Park, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-8575
> https://issues.apache.org/jira/browse/MESOS-8575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated discard handling in Docker library functions.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28 
> 
> 
> Diff: https://reviews.apache.org/r/65683/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 65718: Allowed empty resource provider selector in `UriDiskProfileAdaptor`.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65718/
---

(Updated Feb. 23, 2018, 12:12 a.m.)


Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.


Changes
---

Added the missing change to the test.


Bugs: MESOS-8598
https://issues.apache.org/jira/browse/MESOS-8598


Repository: mesos


Description
---

Allowed empty resource provider selector in `UriDiskProfileAdaptor`.


Diffs (updated)
-

  src/resource_provider/storage/disk_profile_utils.cpp 
a243bd6f89919c69c2fe0a94c60f8251e35e23a0 
  src/tests/disk_profile_tests.cpp 1bbbde0d026e8e7388d341746587913926002144 


Diff: https://reviews.apache.org/r/65718/diff/2/

Changes: https://reviews.apache.org/r/65718/diff/1-2/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/#review198152
---



Bad patch!

Reviews applied: [65750, 65751, 65743, 65683]

Failed command: python support/apply-reviews.py -n -r 65683

Error:
2018-02-22 23:50:16 URL:https://reviews.apache.org/r/65683/diff/raw/ 
[2168/2168] -> "65683.patch" [1]
error: patch failed: src/docker/docker.cpp:1308
error: src/docker/docker.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/21736/console

- Mesos Reviewbot


On Feb. 22, 2018, 3:10 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65750/
> ---
> 
> (Updated Feb. 22, 2018, 3:10 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new test 'HungDockerTest.ROOT_DOCKER_InspectDuringPull'
> verifies that the Mesos agent will send a TASK_FAILED
> update for a Docker task which fails because the executor
> registration timeout elapses while the container is stuck
> in the PULLING state due to a hung 'docker inspect' call.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> d1e657050d623ad0412208b3aa3e3101e3654e99 
> 
> 
> Diff: https://reviews.apache.org/r/65750/diff/2/
> 
> 
> Testing
> ---
> 
> sudo bin/mesos-tests.sh 
> --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 65718: Allowed empty resource provider selector in `UriDiskProfileAdaptor`.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65718/#review198149
---


Ship it!




Ship It!

- Jie Yu


On Feb. 20, 2018, 6:43 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65718/
> ---
> 
> (Updated Feb. 20, 2018, 6:43 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8598
> https://issues.apache.org/jira/browse/MESOS-8598
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed empty resource provider selector in `UriDiskProfileAdaptor`.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/disk_profile_utils.cpp 
> a243bd6f89919c69c2fe0a94c60f8251e35e23a0 
> 
> 
> Diff: https://reviews.apache.org/r/65718/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65713/
---

(Updated Feb. 22, 2018, 11:28 p.m.)


Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and 
Vinod Kone.


Bugs: MESOS-8574
https://issues.apache.org/jira/browse/MESOS-8574


Repository: mesos


Description
---

Previosly, if `docker inspect` command hanged, the docker container
ended up in an unkillable state. This patch adds a timeout for inspect
command after receiving `killTask` analogically to `reaped` handler.
In addition we've added a timeout for `docker stop` command. If docker
`stop` or `inspect` command times out, we discard the related future,
thus the docker library kills previously spawned docker cli subprocess.
As a result, a scheduler can retry `killTask` operation to handle
nasty docker bugs that lead to hanging docker cli.


Diffs
-

  src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 


Diff: https://reviews.apache.org/r/65713/diff/2/


Testing
---

internal CI

Manual testing:
1. Build docker from sources: 
http://oyvindsk.com/writing/docker-build-from-source
2. Modify `ContainerInspect` function from `docker/inspect.go`:
```
 func (daemon *Daemon) ContainerInspect(name string, size bool, version string) 
(interface{}, error) {
+   time.Sleep(10 * time.Second)
```
3. Modify `ContainerStop` function from `docker/stop.go`:
```
 func (daemon *Daemon) ContainerStop(name string, seconds *int) error {
+   rand.Seed(time.Now().UTC().UnixNano())
+   if rand.Intn(2) == 0 {
+   time.Sleep(20 * time.Second)
+   }
```
4. Rebuild docker: `sudo make build && sudo make binary`
5. Stop system docker daemon: `sudo service docker stop`
6. Start modified docker daemon: `sudo ./bundles/binary-daemon/dockerd-dev`
7. Modify `src/cli/execute.cpp`:
  a) Add `delay(Seconds(15), self(), ::retryKill, task->task_id(), 
offer.agent_id());` after 
https://github.com/apache/mesos/blob/072ea2787ffca6f2a6dcb2d636f68c51823d6665/src/cli/execute.cpp#L606
  b) Add a new method `retryKill` to `CommandScheduler`:
```
  void retryKill(const TaskID& taskId, const AgentID& agentId)
  {
killTask(taskId, agentId);
delay(Seconds(6), self(), ::retryKill, taskId, agentId);
  }
```
8. Rebuild mesos
9. Run mesos master: `./bin/mesos-master.sh --work_dir='var/master-1'`
10. Run mesos agent: `GLOG_v=1 ./bin/mesos-agent.sh 
--resources="cpus:1;mem:100" 
--work_dir='/home/abudnik/mesos/build/var/agent-1' 
--containerizers="docker,mesos" --master="127.0.1.1:5050"`
11. Submit a task for the docker executor: `./src/mesos-execute 
--master="127.0.1.1:5050" --name="a" --containerizer=docker 
--docker_image="ubuntu:xenial" --command="sleep "`


Thanks,

Andrei Budnik

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65751/
---

(Updated Feb. 22, 2018, 11:28 p.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.


Bugs: MESOS-8591
https://issues.apache.org/jira/browse/MESOS-8591


Repository: mesos


Description
---

The new `HungDockerTest` class allows test authors to force
certain Docker daemon calls to be delayed for a specified
duration.


Diffs
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
d1e657050d623ad0412208b3aa3e3101e3654e99 


Diff: https://reviews.apache.org/r/65751/diff/3/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 65748: Added inspect retries to the Docker executor.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65748/
---

(Updated Feb. 22, 2018, 11:28 p.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.


Repository: mesos


Description
---

Added inspect retries to the Docker executor.


Diffs
-

  src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 


Diff: https://reviews.apache.org/r/65748/diff/1/


Testing
---

This patch has not yet been tested.


Thanks,

Greg Mann

Re: Review Request 65749: Added a new binary to test a hung Docker daemon.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65749/
---

(Updated Feb. 22, 2018, 11:24 p.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.


Bugs: MESOS-8591
https://issues.apache.org/jira/browse/MESOS-8591


Repository: mesos


Description
---

This binary is meant to be used in concert with the
test fixture added by the next patch in this chain.
These patches allow a test author to specify that
particular calls to the Docker daemon should be
delayed for a specified duration.


Diffs
-

  src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
  src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
  src/tests/test_docker.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/65749/diff/1/


Testing
---


Thanks,

Greg Mann

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65713/
---

(Updated Feb. 22, 2018, 11:19 p.m.)


Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and 
Vinod Kone.


Bugs: MESOS-8574
https://issues.apache.org/jira/browse/MESOS-8574


Repository: mesos


Description
---

Previosly, if `docker inspect` command hanged, the docker container
ended up in an unkillable state. This patch adds a timeout for inspect
command after receiving `killTask` analogically to `reaped` handler.
In addition we've added a timeout for `docker stop` command. If docker
`stop` or `inspect` command times out, we discard the related future,
thus the docker library kills previously spawned docker cli subprocess.
As a result, a scheduler can retry `killTask` operation to handle
nasty docker bugs that lead to hanging docker cli.


Diffs
-

  src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 


Diff: https://reviews.apache.org/r/65713/diff/2/


Testing
---

internal CI

Manual testing:
1. Build docker from sources: 
http://oyvindsk.com/writing/docker-build-from-source
2. Modify `ContainerInspect` function from `docker/inspect.go`:
```
 func (daemon *Daemon) ContainerInspect(name string, size bool, version string) 
(interface{}, error) {
+   time.Sleep(10 * time.Second)
```
3. Modify `ContainerStop` function from `docker/stop.go`:
```
 func (daemon *Daemon) ContainerStop(name string, seconds *int) error {
+   rand.Seed(time.Now().UTC().UnixNano())
+   if rand.Intn(2) == 0 {
+   time.Sleep(20 * time.Second)
+   }
```
4. Rebuild docker: `sudo make build && sudo make binary`
5. Stop system docker daemon: `sudo service docker stop`
6. Start modified docker daemon: `sudo ./bundles/binary-daemon/dockerd-dev`
7. Modify `src/cli/execute.cpp`:
  a) Add `delay(Seconds(15), self(), ::retryKill, task->task_id(), 
offer.agent_id());` after 
https://github.com/apache/mesos/blob/072ea2787ffca6f2a6dcb2d636f68c51823d6665/src/cli/execute.cpp#L606
  b) Add a new method `retryKill` to `CommandScheduler`:
```
  void retryKill(const TaskID& taskId, const AgentID& agentId)
  {
killTask(taskId, agentId);
delay(Seconds(6), self(), ::retryKill, taskId, agentId);
  }
```
8. Rebuild mesos
9. Run mesos master: `./bin/mesos-master.sh --work_dir='var/master-1'`
10. Run mesos agent: `GLOG_v=1 ./bin/mesos-agent.sh 
--resources="cpus:1;mem:100" 
--work_dir='/home/abudnik/mesos/build/var/agent-1' 
--containerizers="docker,mesos" --master="127.0.1.1:5050"`
11. Submit a task for the docker executor: `./src/mesos-execute 
--master="127.0.1.1:5050" --name="a" --containerizer=docker 
--docker_image="ubuntu:xenial" --command="sleep "`


Thanks,

Andrei Budnik

Re: Review Request 64387: Windows: Ported docker health check tests.

[Akash Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64387/
---

(Updated Feb. 22, 2018, 11:18 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
Kleiman, Jie Yu, Joseph Wu, and Michael Park.


Changes
---

Addressed Alex's feedback.


Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
---

The `HealthCheckTest.ROOT_DOCKER_*` and
`DockerContainerizerHealthCheckTest.*` tests now work on Windows.


Diffs (updated)
-

  src/tests/containerizer/docker_common.hpp PRE-CREATION 
  src/tests/environment.cpp e1aa020f53dfce03261234edf15553c087b4edff 
  src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab 


Diff: https://reviews.apache.org/r/64387/diff/14/

Changes: https://reviews.apache.org/r/64387/diff/13-14/


Testing
---

Windows Server:
[==] Running 5 tests from 2 test cases.
[--] Global test environment set-up.
[--] 2 tests from HealthCheckTest
[ RUN  ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
[   OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask (21263 ms)
[ RUN  ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
[   OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange (23512 ms)
[--] 2 tests from HealthCheckTest (44835 ms total)

[--] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest
[ RUN  ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
[   OK ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
 (28487 ms)
[ RUN  ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
[   OK ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
 (26447 ms)
[ RUN  ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
[   OK ] 
NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
 (26264 ms)
[--] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest 
(81268 ms total)

[--] Global test environment tear-down
[==] 5 tests from 2 test cases ran. (126559 ms total)
[  PASSED  ] 5 tests

Rest of tests pass.

Windows Client (Disabled network health checks):
Proof that network health checks are skipped on Windows Client.
C:\Program Files\Docker\Docker\Resources\bin\docker.exe: Error response from 
daemon: sharing of hyperv containers network is not supported.
356b087e7fa640f83fe27ebeb3396bfc7b2bbebd917aeaec0508b887b41d31f4
-
We cannot run any Docker health checks tests because:
Running in another container's namespace is not supported on this version of 
Windows.

Rest rests pass.

Linux:
make check passes


Thanks,

Akash Gupta

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/
---

(Updated Feb. 22, 2018, 11:10 p.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.


Repository: mesos


Description (updated)
---

The new test 'HungDockerTest.ROOT_DOCKER_InspectDuringPull'
verifies that the Mesos agent will send a TASK_FAILED
update for a Docker task which fails because the executor
registration timeout elapses while the container is stuck
in the PULLING state due to a hung 'docker inspect' call.


Diffs
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
d1e657050d623ad0412208b3aa3e3101e3654e99 


Diff: https://reviews.apache.org/r/65750/diff/2/


Testing
---

sudo bin/mesos-tests.sh 
--gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"


Thanks,

Greg Mann

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/#review198146
---



FAIL: Failed to apply the dependent review: 65683.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65683`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65750

Relevant logs:

- 
[apply-review-65683-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65750/logs/apply-review-65683-stdout.log):

```
error: patch failed: src/docker/docker.cpp:1308
error: src/docker/docker.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 22, 2018, 10:57 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65750/
> ---
> 
> (Updated Feb. 22, 2018, 10:57 p.m.)
> 
> 
> Review request for mesos and Andrei Budnik.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for a hung 'docker inspect' during container pull.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> d1e657050d623ad0412208b3aa3e3101e3654e99 
> 
> 
> Diff: https://reviews.apache.org/r/65750/diff/2/
> 
> 
> Testing
> ---
> 
> sudo bin/mesos-tests.sh 
> --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/
---

(Updated Feb. 22, 2018, 10:57 p.m.)


Review request for mesos and Andrei Budnik.


Summary (updated)
-

Added test for a hung 'docker inspect' during container pull.


Repository: mesos


Description (updated)
---

Added test for a hung 'docker inspect' during container pull.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
d1e657050d623ad0412208b3aa3e3101e3654e99 


Diff: https://reviews.apache.org/r/65750/diff/2/

Changes: https://reviews.apache.org/r/65750/diff/1-2/


Testing (updated)
---

sudo bin/mesos-tests.sh 
--gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"


Thanks,

Greg Mann

Re: Review Request 65759: Added inspect retries to the Docker executor.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65759/#review198145
---



Patch looks great!

Reviews applied: [65713, 65759]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 22, 2018, 12:32 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65759/
> ---
> 
> (Updated Feb. 22, 2018, 12:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and 
> Michael Park.
> 
> 
> Bugs: MESOS-8574
> https://issues.apache.org/jira/browse/MESOS-8574
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds retries for `inspect` command to workaround docker
> daemon hangs. We assume that the docker daemon can be temporarily
> unresponsive. If it's unresponsive, then any started docker cli
> command hangs. To address the issue, we retry `inspect` in the loop.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 
> 
> 
> Diff: https://reviews.apache.org/r/65759/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> Manually, described in /r/65713
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65751/
---

(Updated Feb. 22, 2018, 10:56 p.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.


Bugs: MESOS-8591
https://issues.apache.org/jira/browse/MESOS-8591


Repository: mesos


Description (updated)
---

The new `HungDockerTest` class allows test authors to force
certain Docker daemon calls to be delayed for a specified
duration.


Diffs
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
d1e657050d623ad0412208b3aa3e3101e3654e99 


Diff: https://reviews.apache.org/r/65751/diff/3/


Testing (updated)
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65751/
---

(Updated Feb. 22, 2018, 10:55 p.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.


Bugs: MESOS-8591
https://issues.apache.org/jira/browse/MESOS-8591


Repository: mesos


Description
---

Added test fixture for a hung Docker daemon.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
d1e657050d623ad0412208b3aa3e3101e3654e99 


Diff: https://reviews.apache.org/r/65751/diff/3/

Changes: https://reviews.apache.org/r/65751/diff/2-3/


Testing
---


Thanks,

Greg Mann

Re: Review Request 65749: Added a new binary to test a hung Docker daemon.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65749/#review198144
---



FAIL: Failed to apply the dependent review: 65683.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65683`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65749

Relevant logs:

- 
[apply-review-65683-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65749/logs/apply-review-65683-stdout.log):

```
error: patch failed: src/docker/docker.cpp:1308
error: src/docker/docker.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 22, 2018, 2:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65749/
> ---
> 
> (Updated Feb. 22, 2018, 2:05 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
> 
> 
> Bugs: MESOS-8591
> https://issues.apache.org/jira/browse/MESOS-8591
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This binary is meant to be used in concert with the
> test fixture added by the next patch in this chain.
> These patches allow a test author to specify that
> particular calls to the Docker daemon should be
> delayed for a specified duration.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
>   src/tests/test_docker.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65749/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65751/
---

(Updated Feb. 22, 2018, 10:46 p.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.


Bugs: MESOS-8591
https://issues.apache.org/jira/browse/MESOS-8591


Repository: mesos


Description (updated)
---

Added test fixture for a hung Docker daemon.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
d1e657050d623ad0412208b3aa3e3101e3654e99 


Diff: https://reviews.apache.org/r/65751/diff/2/

Changes: https://reviews.apache.org/r/65751/diff/1-2/


Testing
---


Thanks,

Greg Mann

Re: Review Request 65759: Added inspect retries to the Docker executor.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65759/#review198139
---



PASS: Mesos patch 65759 was successfully built and tested.

Reviews applied: `['65713', '65759']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65759

- Mesos Reviewbot Windows


On Feb. 22, 2018, 8:32 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65759/
> ---
> 
> (Updated Feb. 22, 2018, 8:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and 
> Michael Park.
> 
> 
> Bugs: MESOS-8574
> https://issues.apache.org/jira/browse/MESOS-8574
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds retries for `inspect` command to workaround docker
> daemon hangs. We assume that the docker daemon can be temporarily
> unresponsive. If it's unresponsive, then any started docker cli
> command hangs. To address the issue, we retry `inspect` in the loop.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 
> 
> 
> Diff: https://reviews.apache.org/r/65759/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> Manually, described in /r/65713
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 65759: Added inspect retries to the Docker executor.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65759/
---

Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and 
Michael Park.


Bugs: MESOS-8574
https://issues.apache.org/jira/browse/MESOS-8574


Repository: mesos


Description
---

This patch adds retries for `inspect` command to workaround docker
daemon hangs. We assume that the docker daemon can be temporarily
unresponsive. If it's unresponsive, then any started docker cli
command hangs. To address the issue, we retry `inspect` in the loop.


Diffs
-

  src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 


Diff: https://reviews.apache.org/r/65759/diff/1/


Testing
---

internal CI

Manually, described in /r/65713


Thanks,

Andrei Budnik

Re: Review Request 65758: Fix flakyness in MasterTests.RegistryUpdateAfterReconfiguration.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65758/#review198132
---



Patch looks great!

Reviews applied: [65758]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 22, 2018, 4:25 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65758/
> ---
> 
> (Updated Feb. 22, 2018, 4:25 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8336
> https://issues.apache.org/jira/browse/MESOS-8336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It could happen that an agent re-sends its `RegisterSlaveMessage`
> and with the correct timing, the master would assume that it
> comes from a new agent with the same pid and store its information
> in the registry. See MESOS-8336.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 3705fa7cc3c81a77dc431d5337a7d4a061fa84b9 
> 
> 
> Diff: https://reviews.apache.org/r/65758/diff/1/
> 
> 
> Testing
> ---
> 
> `./mesos-tests --gtest_filter="*AfterReconfiguration*" --gtest_repeat=1000 
> --gtest_throw_on_failure`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65758: Fix flakyness in MasterTests.RegistryUpdateAfterReconfiguration.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65758/#review198128
---



PASS: Mesos patch 65758 was successfully built and tested.

Reviews applied: `['65758']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65758

- Mesos Reviewbot Windows


On Feb. 22, 2018, 4:25 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65758/
> ---
> 
> (Updated Feb. 22, 2018, 4:25 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8336
> https://issues.apache.org/jira/browse/MESOS-8336
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> It could happen that an agent re-sends its `RegisterSlaveMessage`
> and with the correct timing, the master would assume that it
> comes from a new agent with the same pid and store its information
> in the registry. See MESOS-8336.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 3705fa7cc3c81a77dc431d5337a7d4a061fa84b9 
> 
> 
> Diff: https://reviews.apache.org/r/65758/diff/1/
> 
> 
> Testing
> ---
> 
> `./mesos-tests --gtest_filter="*AfterReconfiguration*" --gtest_repeat=1000 
> --gtest_throw_on_failure`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65615: Added docker constants and common functions file.

[Andrew Schwartzmeyer]

> On Feb. 22, 2018, 3:25 a.m., Alexander Rukletsov wrote:
> > src/Makefile.am
> > Lines 1276 (patched)
> > 
> >
> > What about CMake?

Headers are free in CMake.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/#review198108
---


On Feb. 21, 2018, 5:47 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65615/
> ---
> 
> (Updated Feb. 21, 2018, 5:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch is in preparation of porting docker tests to Windows. There
> were a few hardcoded values that were used throughout the codebase,
> such as the `alpine` image, that are defined as a constant in a single
> file.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
>   src/tests/containerizer/docker_common.hpp PRE-CREATION 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 97335e197fb0fcb5caa06d8cea4a57277d2cf1f3 
>   src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab 
>   src/tests/mesos.hpp 1416682fc8b51d38adc02d549a81fd0b09c83fa9 
> 
> 
> Diff: https://reviews.apache.org/r/65615/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Review Request 65758: Fix flakyness in MasterTests.RegistryUpdateAfterReconfiguration.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65758/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-8336
https://issues.apache.org/jira/browse/MESOS-8336


Repository: mesos


Description
---

It could happen that an agent re-sends its `RegisterSlaveMessage`
and with the correct timing, the master would assume that it
comes from a new agent with the same pid and store its information
in the registry. See MESOS-8336.


Diffs
-

  src/tests/master_tests.cpp 3705fa7cc3c81a77dc431d5337a7d4a061fa84b9 


Diff: https://reviews.apache.org/r/65758/diff/1/


Testing
---

`./mesos-tests --gtest_filter="*AfterReconfiguration*" --gtest_repeat=1000 
--gtest_throw_on_failure`


Thanks,

Benno Evers

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65713/#review198122
---



Patch looks great!

Reviews applied: [65713]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 20, 2018, 5:11 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65713/
> ---
> 
> (Updated Feb. 20, 2018, 5:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-8574
> https://issues.apache.org/jira/browse/MESOS-8574
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previosly, if `docker inspect` command hanged, the docker container
> ended up in an unkillable state. This patch adds a timeout for inspect
> command after receiving `killTask` analogically to `reaped` handler.
> In addition we've added a timeout for `docker stop` command. If docker
> `stop` or `inspect` command times out, we discard the related future,
> thus the docker library kills previously spawned docker cli subprocess.
> As a result, a scheduler can retry `killTask` operation to handle
> nasty docker bugs that lead to hanging docker cli.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 
> 
> 
> Diff: https://reviews.apache.org/r/65713/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> Manual testing:
> 1. Build docker from sources: 
> http://oyvindsk.com/writing/docker-build-from-source
> 2. Modify `ContainerInspect` function from `docker/inspect.go`:
> ```
>  func (daemon *Daemon) ContainerInspect(name string, size bool, version 
> string) (interface{}, error) {
> +   time.Sleep(10 * time.Second)
> ```
> 3. Modify `ContainerStop` function from `docker/stop.go`:
> ```
>  func (daemon *Daemon) ContainerStop(name string, seconds *int) error {
> +   rand.Seed(time.Now().UTC().UnixNano())
> +   if rand.Intn(2) == 0 {
> +   time.Sleep(20 * time.Second)
> +   }
> ```
> 4. Rebuild docker: `sudo make build && sudo make binary`
> 5. Stop system docker daemon: `sudo service docker stop`
> 6. Start modified docker daemon: `sudo ./bundles/binary-daemon/dockerd-dev`
> 7. Modify `src/cli/execute.cpp`:
>   a) Add `delay(Seconds(15), self(), ::retryKill, task->task_id(), 
> offer.agent_id());` after 
> https://github.com/apache/mesos/blob/072ea2787ffca6f2a6dcb2d636f68c51823d6665/src/cli/execute.cpp#L606
>   b) Add a new method `retryKill` to `CommandScheduler`:
> ```
>   void retryKill(const TaskID& taskId, const AgentID& agentId)
>   {
> killTask(taskId, agentId);
> delay(Seconds(6), self(), ::retryKill, taskId, agentId);
>   }
> ```
> 8. Rebuild mesos
> 9. Run mesos master: `./bin/mesos-master.sh --work_dir='var/master-1'`
> 10. Run mesos agent: `GLOG_v=1 ./bin/mesos-agent.sh 
> --resources="cpus:1;mem:100" 
> --work_dir='/home/abudnik/mesos/build/var/agent-1' 
> --containerizers="docker,mesos" --master="127.0.1.1:5050"`
> 11. Submit a task for the docker executor: `./src/mesos-execute 
> --master="127.0.1.1:5050" --name="a" --containerizer=docker 
> --docker_image="ubuntu:xenial" --command="sleep "`
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 65532: Add jemalloc release tarball and build rules.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65532/
---

Review request for mesos.


Repository: mesos


Description
---

Add jemalloc release tarball and build rules.


Testing
---


Thanks,

Benno Evers

Re: Review Request 65307: Cleaned up interface defintion in duration header.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65307/
---

(Updated Feb. 22, 2018, 3:14 p.m.)


Review request for mesos.


Repository: mesos


Description
---

Moved a function definition out of the class to not clutter
the class definition.


Diffs
-

  3rdparty/stout/include/stout/duration.hpp 
930e4819c206ede7a41725bfae9360b17e69bf7a 


Diff: https://reviews.apache.org/r/65307/diff/1/


Testing
---


Thanks,

Benno Evers

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65713/#review198120
---



PASS: Mesos patch 65713 was successfully built and tested.

Reviews applied: `['65713']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65713

- Mesos Reviewbot Windows


On Feb. 20, 2018, 7:11 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65713/
> ---
> 
> (Updated Feb. 20, 2018, 7:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-8574
> https://issues.apache.org/jira/browse/MESOS-8574
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previosly, if `docker inspect` command hanged, the docker container
> ended up in an unkillable state. This patch adds a timeout for inspect
> command after receiving `killTask` analogically to `reaped` handler.
> In addition we've added a timeout for `docker stop` command. If docker
> `stop` or `inspect` command times out, we discard the related future,
> thus the docker library kills previously spawned docker cli subprocess.
> As a result, a scheduler can retry `killTask` operation to handle
> nasty docker bugs that lead to hanging docker cli.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 
> 
> 
> Diff: https://reviews.apache.org/r/65713/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> Manual testing:
> 1. Build docker from sources: 
> http://oyvindsk.com/writing/docker-build-from-source
> 2. Modify `ContainerInspect` function from `docker/inspect.go`:
> ```
>  func (daemon *Daemon) ContainerInspect(name string, size bool, version 
> string) (interface{}, error) {
> +   time.Sleep(10 * time.Second)
> ```
> 3. Modify `ContainerStop` function from `docker/stop.go`:
> ```
>  func (daemon *Daemon) ContainerStop(name string, seconds *int) error {
> +   rand.Seed(time.Now().UTC().UnixNano())
> +   if rand.Intn(2) == 0 {
> +   time.Sleep(20 * time.Second)
> +   }
> ```
> 4. Rebuild docker: `sudo make build && sudo make binary`
> 5. Stop system docker daemon: `sudo service docker stop`
> 6. Start modified docker daemon: `sudo ./bundles/binary-daemon/dockerd-dev`
> 7. Modify `src/cli/execute.cpp`:
>   a) Add `delay(Seconds(15), self(), ::retryKill, task->task_id(), 
> offer.agent_id());` after 
> https://github.com/apache/mesos/blob/072ea2787ffca6f2a6dcb2d636f68c51823d6665/src/cli/execute.cpp#L606
>   b) Add a new method `retryKill` to `CommandScheduler`:
> ```
>   void retryKill(const TaskID& taskId, const AgentID& agentId)
>   {
> killTask(taskId, agentId);
> delay(Seconds(6), self(), ::retryKill, taskId, agentId);
>   }
> ```
> 8. Rebuild mesos
> 9. Run mesos master: `./bin/mesos-master.sh --work_dir='var/master-1'`
> 10. Run mesos agent: `GLOG_v=1 ./bin/mesos-agent.sh 
> --resources="cpus:1;mem:100" 
> --work_dir='/home/abudnik/mesos/build/var/agent-1' 
> --containerizers="docker,mesos" --master="127.0.1.1:5050"`
> 11. Submit a task for the docker executor: `./src/mesos-execute 
> --master="127.0.1.1:5050" --name="a" --containerizer=docker 
> --docker_image="ubuntu:xenial" --command="sleep "`
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65674/#review198119
---


Ship it!




Ship It!

- Jan Schlicht


On Feb. 15, 2018, 3:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65674/
> ---
> 
> (Updated Feb. 15, 2018, 3:54 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced helper for creating Mesos UUIDs.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/slave/slave.cpp c5ec62c0e55e7416d9cd2a49c13459b85e315150 
>   src/tests/operation_status_update_manager_tests.cpp 
> c4429f40e1d7226be59d8ba4283bd91e16799d5a 
>   src/tests/resource_provider_manager_tests.cpp 
> c8997ec41fe0c3e02b0f6ab205c9009205c992da 
>   src/tests/resource_provider_validation_tests.cpp 
> 9f34c459e24396815f4a785815f83923e276874f 
>   src/tests/slave_tests.cpp d2c242eae3169bff3b0197a36f171cd668ba 
> 
> 
> Diff: https://reviews.apache.org/r/65674/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65673: Added evolve function for mesos UUID.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65673/#review198118
---


Ship it!




Ship It!

- Jan Schlicht


On Feb. 15, 2018, 3:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65673/
> ---
> 
> (Updated Feb. 15, 2018, 3:54 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added evolve function for mesos UUID.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.hpp 77b7172b8ba51a236647334337be6749a03ae021 
>   src/internal/evolve.cpp 7758c9b93ad41b45b941c0de8c2b1008fbc4e50d 
> 
> 
> Diff: https://reviews.apache.org/r/65673/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65590: Added helper function to determine provider ID of a conversion.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65590/#review198117
---


Ship it!




Ship It!

- Jan Schlicht


On Feb. 14, 2018, 4:11 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65590/
> ---
> 
> (Updated Feb. 14, 2018, 4:11 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8382
> https://issues.apache.org/jira/browse/MESOS-8382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper function to determine provider ID of a conversion.
> 
> 
> Diffs
> -
> 
>   src/common/resources_utils.hpp 73d070d48eedf30468305e96fc4ad0005584fc79 
>   src/common/resources_utils.cpp 99b16e0d17b224eefa1e28f5f66c4284069c0e57 
> 
> 
> Diff: https://reviews.apache.org/r/65590/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65588: Used proto UUID instead stout UUID internally for operation IDs.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65588/#review198116
---


Ship it!




Ship It!

- Jan Schlicht


On Feb. 15, 2018, 3:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65588/
> ---
> 
> (Updated Feb. 15, 2018, 3:54 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8382
> https://issues.apache.org/jira/browse/MESOS-8382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used proto UUID instead stout UUID internally for operation IDs.
> 
> 
> Diffs
> -
> 
>   include/mesos/resource_provider/resource_provider.proto 
> e96a40493c351a7242465c8591cae981abc92f24 
>   src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 
>   src/common/protobuf_utils.cpp f516091e9208552488c154f34adde6f20d3413bf 
>   src/master/master.hpp 6569c9ea0677f193ec56c276e6deea3f2fe86514 
>   src/master/master.cpp e7d5ac67a94f927bb747bd283a3bf9671b2b8f44 
>   src/resource_provider/manager.cpp cc195a3d35b93dd6493951de1ff8a1cb8a886377 
>   src/resource_provider/message.hpp 2511af611edc94e3e3a78fce475bc8cd85ffc3f9 
>   src/slave/slave.hpp 42c3ebcf52b608e40e26ca85f5efb054dad2d2a1 
>   src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70 
> 
> 
> Diff: https://reviews.apache.org/r/65588/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64604/#review198110
---


Fix it, then Ship it!





docs/health-checks.md
Lines 384-386 (original), 384-387 (patched)


You need the same change for HTTP checks.



docs/health-checks.md
Lines 425-426 (original), 426-429 (patched)


You need the same for TCP checks


- Alexander Rukletsov


On Feb. 22, 2018, 1:50 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64604/
> ---
> 
> (Updated Feb. 22, 2018, 1:50 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated health-checks.md with details of the Windows health check
> implementations for the mesos and docker executors.
> 
> 
> Diffs
> -
> 
>   docs/health-checks.md 119d149f29f2f2d3178da6ef63a7ce97a4dbc952 
> 
> 
> Diff: https://reviews.apache.org/r/64604/diff/7/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 64387: Windows: Ported docker health check tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64387/#review198109
---




src/tests/environment.cpp
Line 80 (original), 85-87 (patched)


alphabetic order please


- Alexander Rukletsov


On Feb. 22, 2018, 1:48 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64387/
> ---
> 
> (Updated Feb. 22, 2018, 1:48 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, Jie Yu, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `HealthCheckTest.ROOT_DOCKER_*` and
> `DockerContainerizerHealthCheckTest.*` tests now work on Windows.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_common.hpp PRE-CREATION 
>   src/tests/environment.cpp e1aa020f53dfce03261234edf15553c087b4edff 
>   src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab 
> 
> 
> Diff: https://reviews.apache.org/r/64387/diff/13/
> 
> 
> Testing
> ---
> 
> Windows Server:
> [==] Running 5 tests from 2 test cases.
> [--] Global test environment set-up.
> [--] 2 tests from HealthCheckTest
> [ RUN  ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
> [   OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthyTask (21263 ms)
> [ RUN  ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
> [   OK ] HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange (23512 ms)
> [--] 2 tests from HealthCheckTest (44835 ms total)
> 
> [--] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest
> [ RUN  ] 
> NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
> [   OK ] 
> NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTP/0
>  (28487 ms)
> [ RUN  ] 
> NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
> [   OK ] 
> NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaHTTPS/0
>  (26447 ms)
> [ RUN  ] 
> NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
> [   OK ] 
> NetworkProtocol/DockerContainerizerHealthCheckTest.ROOT_DOCKER_USERNETWORK_NETNAMESPACE_HealthyTaskViaTCP/0
>  (26264 ms)
> [--] 3 tests from NetworkProtocol/DockerContainerizerHealthCheckTest 
> (81268 ms total)
> 
> [--] Global test environment tear-down
> [==] 5 tests from 2 test cases ran. (126559 ms total)
> [  PASSED  ] 5 tests
> 
> Rest of tests pass.
> 
> Windows Client (Disabled network health checks):
> Proof that network health checks are skipped on Windows Client.
> C:\Program Files\Docker\Docker\Resources\bin\docker.exe: Error response from 
> daemon: sharing of hyperv containers network is not supported.
> 356b087e7fa640f83fe27ebeb3396bfc7b2bbebd917aeaec0508b887b41d31f4
> -
> We cannot run any Docker health checks tests because:
> Running in another container's namespace is not supported on this version of 
> Windows.
> 
> Rest rests pass.
> 
> Linux:
> make check passes
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 65615: Added docker constants and common functions file.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/#review198108
---



To simplify reviewing, in the future please separate refactoring and moving 
stuff around from actual changes.


src/Makefile.am
Lines 1276 (patched)


What about CMake?


- Alexander Rukletsov


On Feb. 22, 2018, 1:47 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65615/
> ---
> 
> (Updated Feb. 22, 2018, 1:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, and Joseph Wu.
> 
> 
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch is in preparation of porting docker tests to Windows. There
> were a few hardcoded values that were used throughout the codebase,
> such as the `alpine` image, that are defined as a constant in a single
> file.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
>   src/tests/containerizer/docker_common.hpp PRE-CREATION 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 97335e197fb0fcb5caa06d8cea4a57277d2cf1f3 
>   src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab 
>   src/tests/mesos.hpp 1416682fc8b51d38adc02d549a81fd0b09c83fa9 
> 
> 
> Diff: https://reviews.apache.org/r/65615/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 65127: Windows: Enabled docker health checks.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65127/#review198107
---


Fix it, then Ship it!





src/checks/checker_process.cpp
Lines 1157 (patched)


maybe `dockerNetworkRunArgs` or `dockerNetworkRunCommand`?



src/checks/checker_process.cpp
Lines 1153-1154 (original), 1179-1181 (patched)


I'd move this explanation in front of the function declaration and here 
leave a shorter note.



src/checks/checker_process.cpp
Lines 1187 (patched)


`toAdd` is vague. Maybe `httpCheckCommandParameters`?



src/checks/checker_process.cpp
Lines 1202 (patched)


`cbegin() / cend()` please



src/checks/checker_process.cpp
Lines 1367 (patched)


`cbegin / cend`


- Alexander Rukletsov


On Feb. 22, 2018, 1:46 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65127/
> ---
> 
> (Updated Feb. 22, 2018, 1:46 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The network health checks called curl and then executed setns to
> enter to container network namespace, which did not work on Windows.
> To do the equivalent, Windows nows calls docker run with powershell's
> curl equivalent (Invoke-WebRequest) and uses the
> network=container: flag to enter the container's namespace. The
> command health check was trivially fixed by replacing the hardcoded
> `sh -c`.
> 
> 
> Diffs
> -
> 
>   src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 
>   src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f 
> 
> 
> Diff: https://reviews.apache.org/r/65127/diff/11/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 65749: Added a new binary to test a hung Docker daemon.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65749/#review198104
---



Just realized this binary is not necessary - it would be simpler if I just do 
this logic in the shell script which is written to disk in 
https://reviews.apache.org/r/65751/

- Greg Mann


On Feb. 22, 2018, 10:05 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65749/
> ---
> 
> (Updated Feb. 22, 2018, 10:05 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
> 
> 
> Bugs: MESOS-8591
> https://issues.apache.org/jira/browse/MESOS-8591
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This binary is meant to be used in concert with the
> test fixture added by the next patch in this chain.
> These patches allow a test author to specify that
> particular calls to the Docker daemon should be
> delayed for a specified duration.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
>   src/tests/test_docker.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65749/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 65748: Added inspect retries to the Docker executor.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65748/
---

(Updated Feb. 22, 2018, 10:20 a.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.


Repository: mesos


Description
---

Added inspect retries to the Docker executor.


Diffs
-

  src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 


Diff: https://reviews.apache.org/r/65748/diff/1/


Testing (updated)
---

This patch has not yet been tested.


Thanks,

Greg Mann

Review Request 65751: Added test fixture for a hung Docker daemon.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65751/
---

Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.


Bugs: MESOS-8591
https://issues.apache.org/jira/browse/MESOS-8591


Repository: mesos


Description
---

The new `HungDockerTest` class allows test authors to force
certain Docker daemon calls to be delayed for a specified
duration.


Diffs
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
d1e657050d623ad0412208b3aa3e3101e3654e99 


Diff: https://reviews.apache.org/r/65751/diff/1/


Testing
---


Thanks,

Greg Mann

Review Request 65749: Added a new binary to test a hung Docker daemon.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65749/
---

Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.


Bugs: MESOS-8591
https://issues.apache.org/jira/browse/MESOS-8591


Repository: mesos


Description
---

This binary is meant to be used in concert with the
test fixture added by the next patch in this chain.
These patches allow a test author to specify that
particular calls to the Docker daemon should be
delayed for a specified duration.


Diffs
-

  src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
  src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
  src/tests/test_docker.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/65749/diff/1/


Testing
---


Thanks,

Greg Mann

Re: Review Request 65748: Added inspect retries to the Docker executor.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65748/#review198100
---



FAIL: Failed to apply the dependent review: 65683.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65683`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65748

Relevant logs:

- 
[apply-review-65683-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65748/logs/apply-review-65683-stdout.log):

```
error: patch failed: src/docker/docker.cpp:1308
error: src/docker/docker.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 22, 2018, 9:37 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65748/
> ---
> 
> (Updated Feb. 22, 2018, 9:37 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added inspect retries to the Docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 
> 
> 
> Diff: https://reviews.apache.org/r/65748/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 65748: Added inspect retries to the Docker executor.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65748/
---

Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.


Repository: mesos


Description
---

Added inspect retries to the Docker executor.


Diffs
-

  src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 


Diff: https://reviews.apache.org/r/65748/diff/1/


Testing
---


Thanks,

Greg Mann