Re: Review Request 65800: Added Anurag Bihani to the contributors list.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65800/#review198272
---



Patch looks great!

Reviews applied: [65797, 65798, 65799, 65800]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 25, 2018, 3:13 a.m., Sachin Paryani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65800/
> ---
> 
> (Updated Feb. 25, 2018, 3:13 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 73f4d08a84f46966abac6a0e384aaa0c6cd3c5ad 
> 
> 
> Diff: https://reviews.apache.org/r/65800/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sachin Paryani
> 
>

Re: Review Request 65707: Enabled docker containerizer in Mesos mini container.

[Jie Yu]

> On Feb. 19, 2018, 3:14 p.m., Benjamin Bannier wrote:
> > support/mesos-mini/mesos_agent_environment
> > Lines 5 (patched)
> > 
> >
> > Might as well put these in alphabetic order.

I want Mesos containerizer to be queried first.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65707/#review197756
---


On Feb. 19, 2018, 6:31 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65707/
> ---
> 
> (Updated Feb. 19, 2018, 6:31 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled docker containerizer in Mesos mini container.
> 
> 
> Diffs
> -
> 
>   support/mesos-mini/mesos_agent_environment 
> 8390f15e8d300e8076da92e7a157021bcfab74dc 
> 
> 
> Diff: https://reviews.apache.org/r/65707/diff/1/
> 
> 
> Testing
> ---
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 65800: Added Anurag Bihani to the contributors list.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65800/#review198270
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65797', '65798', '65799', '65800']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65800

Relevant logs:

- 
[stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65800/logs/stout-tests-stdout.log):

```
[ RUN  ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile
[   OK ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile (4 ms)
[ RUN  ] RmdirTest.RemoveDirectoryButPreserveRoot
[   OK ] RmdirTest.RemoveDirectoryButPreserveRoot (5 ms)
[--] 11 tests from RmdirTest (52 ms total)

[--] 1 test from SocketTests
[ RUN  ] SocketTests.InitSocket
[   OK ] SocketTests.InitSocket (1 ms)
[--] 1 test from SocketTests (2 ms total)

[--] 2 tests from StrerrorTest
[ RUN  ] StrerrorTest.ValidErrno
[   OK ] StrerrorTest.ValidErrno (0 ms)
[ RUN  ] StrerrorTest.InvalidErrno
[   OK ] StrerrorTest.InvalidErrno (0 ms)
[--] 2 tests from StrerrorTest (1 ms total)

[--] Global test environment tear-down
[==] 273 tests from 46 test cases ran. (4221 ms total)
[  PASSED  ] 270 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] OsTest.SYMLINK_Realpath
[  FAILED  ] FsTest.CreateDirectoryAtMaxPath
[  FAILED  ] FsTest.CreateDirectoryLongerThanMaxPath

 3 FAILED TESTS
  YOU HAVE 7 DISABLED TESTS

```

- 
[stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65800/logs/stout-tests-stderr.log):

```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command  [OPTIONS]

Available subcommands:
help
subcommand2

Multiple subcommands have name 'subcommand'
```

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65800/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (97 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (901 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (70 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2198 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2218 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2256 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (2282 ms total)

[--] Global test environment tear-down
[==] 914 tests from 90 test cases ran. (414913 ms total)
[  PASSED  ] 913 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] FilesTest.DebugTest

 1 FAILED TEST
  YOU HAVE 211 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65800/logs/mesos-tests-stderr.log):

```
I0225 04:53:59.985405  1888 slave.cpp:3879] Shutting down framework 
dc30b1a6-ce1b-415c-95a0-fe6a7173e765-
I0225 04:53:59.985405  7668 hierarchical.cpp:405] Deactivated framework 
dc30b1a6-ce1b-415c-95a0-fe6a7173e765-
I0225 04:53:59.985405  1888 slave.cpp:6586] Shutting down executor 
'0cd56a80-731a-4827-8a27-c21c724d25f5' of framework 
dc30b1a6-ce1b-415c-95a0-fe6a7173e765- at executor(1)@1I0225 04:53:59.337406 
 1164 exec.cpp:162] Version: 1.6.0
I0225 04:53:59.361402  1156 exec.cpp:236] Executor registered on agent 
dc30b1a6-ce1b-415c-95a0-fe6a7173e765-S0
I0225 04:53:59.366406  4380 executor.cpp:174] Received SUBSCRIBED event
I0225 04:53:59.370406  4380 executor.cpp:178] Subscribed executor on 
build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0225 04:53:59.370406  4380 executor.cpp:174] Received LAUNCH event
I0225 04:53:59.374405  4380 executor.cpp:646] Starting task 
0cd56a80-731a-4827-8a27-c21c724d25f5
I0225 04:53:59.450407  4380 executor.cpp:481] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0225 04:53:59.958410  4380 executor.cpp:659] Forked command at 3176
I0225 04:53:59.987404  1156 exec.cpp:445] Executor asked to shutdown

Re: Review Request 65797: Added Sachin Paryani to contributors list.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65797/#review198268
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65797']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65797

Relevant logs:

- 
[stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65797/logs/stout-tests-stdout.log):

```
[ RUN  ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile
[   OK ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile (4 ms)
[ RUN  ] RmdirTest.RemoveDirectoryButPreserveRoot
[   OK ] RmdirTest.RemoveDirectoryButPreserveRoot (5 ms)
[--] 11 tests from RmdirTest (53 ms total)

[--] 1 test from SocketTests
[ RUN  ] SocketTests.InitSocket
[   OK ] SocketTests.InitSocket (1 ms)
[--] 1 test from SocketTests (2 ms total)

[--] 2 tests from StrerrorTest
[ RUN  ] StrerrorTest.ValidErrno
[   OK ] StrerrorTest.ValidErrno (0 ms)
[ RUN  ] StrerrorTest.InvalidErrno
[   OK ] StrerrorTest.InvalidErrno (0 ms)
[--] 2 tests from StrerrorTest (2 ms total)

[--] Global test environment tear-down
[==] 273 tests from 46 test cases ran. (4170 ms total)
[  PASSED  ] 270 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] OsTest.SYMLINK_Realpath
[  FAILED  ] FsTest.CreateDirectoryAtMaxPath
[  FAILED  ] FsTest.CreateDirectoryLongerThanMaxPath

 3 FAILED TESTS
  YOU HAVE 7 DISABLED TESTS

```

- 
[stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65797/logs/stout-tests-stderr.log):

```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command  [OPTIONS]

Available subcommands:
help
subcommand2

Multiple subcommands have name 'subcommand'
```

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65797/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (97 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (929 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (69 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2263 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2285 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2247 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (2269 ms total)

[--] Global test environment tear-down
[==] 914 tests from 90 test cases ran. (410200 ms total)
[  PASSED  ] 913 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] FilesTest.DebugTest

 1 FAILED TEST
  YOU HAVE 211 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65797/logs/mesos-tests-stderr.log):

```
I0225 04:07:02.471891  8140 executor.cpp:174] Received SUBSCRIBED event
I0225 04:07:02.475914  8140 executor.cpp:178] Subscribed executor on 
build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0225 04:07:02.475914  8140 executor.cpp:174] Received LAUNCH event
I0225 04:07:02.480914  8140 executor.cpp:646] Starting task 
19126e0d-1e93-4408-932e-44b7ebbcd3b5
I0225 04:07:02.553913  8140 executor.cpp:481] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0225 04:07:03.064975  8140 executor.cpp:659] Forked command at 7468
I0225 04:07:03.092895   524 exec.cpp:445] Executor asked to shutdown
I0225 04:07:03.093895  8140 executor.cpp:174] Received SHUTDOWN event
I0225 04:07:03.094897  8140 executor.cpp:756] Shutting down
I0225 04:07:03.094897  8140 executor.cpp:866] Sending SIGTERM to process tree 
at pid 74:07:03.089900  5108 master.cpp:3239] Deactivating framework 
d4887f66-c758-46b3-9440-d22d1479565d- (default) at 
scheduler-58ee79ed-c822-49d8-b510-7bc44d226ce9@10.3.1.5:55812
I0225 04:07:03.090896  7644 hierarchical.cpp:405] Deactivated framework 
d4887f66-c758-46b3-9440-d22d1479565d-
I0225 04:07:03.091894  8244 slave.cpp:3879] Shutting down framework 
d4887f66-c758-46b3-94

Re: Review Request 65795: Adding warning to `apply-reviews.py` for previously submitted patches.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65795/#review198267
---



Patch looks great!

Reviews applied: [65795]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 25, 2018, 9:36 a.m., Shubham Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65795/
> ---
> 
> (Updated Feb. 25, 2018, 9:36 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8586
> https://issues.apache.org/jira/browse/MESOS-8586
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit emits a warning when a chain skips submitted patches so
> that the user is aware they were ignored.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py 9fc1579f732609dac1b19ff5862f374e71e6cb53 
> 
> 
> Diff: https://reviews.apache.org/r/65795/diff/1/
> 
> 
> Testing
> ---
> 
> Test done.
> 
> command: ./support/apply-reviews.py -c -r 65397
> output: Warning: Review 65397 has already been applied
> 
> 
> Thanks,
> 
> Shubham Kumar
> 
>

Re: Review Request 65800: Added Anurag Bihani to the contributors list.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65800/#review198266
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Feb. 24, 2018, 7:13 p.m., Sachin Paryani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65800/
> ---
> 
> (Updated Feb. 24, 2018, 7:13 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 73f4d08a84f46966abac6a0e384aaa0c6cd3c5ad 
> 
> 
> Diff: https://reviews.apache.org/r/65800/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sachin Paryani
> 
>

Re: Review Request 65799: Ported mesos-master to Windows.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65799/#review198265
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Feb. 24, 2018, 7:19 p.m., Sachin Paryani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65799/
> ---
> 
> (Updated Feb. 24, 2018, 7:19 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-5820
> https://issues.apache.org/jira/browse/MESOS-5820
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The change allows for the mesos-master executable to work on Windows.
> The change was to remove the part of the code for that utilizes the
> ip_discovery_command flag if the build is Windows and replaced with
> an appropriate error message.
> 
> 
> Diffs
> -
> 
>   src/master/CMakeLists.txt ec552110509d17628107f4ad98f2d04675ed3ce3 
>   src/master/main.cpp 8cb52d0c452ab3c328eea80aa56f1c984de372e9 
> 
> 
> Diff: https://reviews.apache.org/r/65799/diff/1/
> 
> 
> Testing
> ---
> 
> Successfully built the master and then started the mesos-master executable.  
> The following command was used:
> ./src/mesos-master --registry='in_memory' --webui_dir=../src/webui
> 
> 
> Thanks,
> 
> Sachin Paryani
> 
>

Re: Review Request 65799: Ported mesos-master to Windows.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65799/#review198264
---




src/master/CMakeLists.txt
Lines 19-20 (original), 17-18 (patched)


Reminder for myself: I might add a comment noting that the master is not 
for production use on Windows, just for testing.



src/master/main.cpp
Lines 210 (patched)


Hm, we had a `NOTE: Because of os::shell` here, must have overwritten the 
file when playing with Git earlier. I'll fix it.


- Andrew Schwartzmeyer


On Feb. 24, 2018, 7:19 p.m., Sachin Paryani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65799/
> ---
> 
> (Updated Feb. 24, 2018, 7:19 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-5820
> https://issues.apache.org/jira/browse/MESOS-5820
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The change allows for the mesos-master executable to work on Windows.
> The change was to remove the part of the code for that utilizes the
> ip_discovery_command flag if the build is Windows and replaced with
> an appropriate error message.
> 
> 
> Diffs
> -
> 
>   src/master/CMakeLists.txt ec552110509d17628107f4ad98f2d04675ed3ce3 
>   src/master/main.cpp 8cb52d0c452ab3c328eea80aa56f1c984de372e9 
> 
> 
> Diff: https://reviews.apache.org/r/65799/diff/1/
> 
> 
> Testing
> ---
> 
> Successfully built the master and then started the mesos-master executable.  
> The following command was used:
> ./src/mesos-master --registry='in_memory' --webui_dir=../src/webui
> 
> 
> Thanks,
> 
> Sachin Paryani
> 
>

Re: Review Request 65797: Added Sachin Paryani to contributors list.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65797/#review198263
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On Feb. 24, 2018, 7:13 p.m., Sachin Paryani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65797/
> ---
> 
> (Updated Feb. 24, 2018, 7:13 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Sachin Paryani to contributors list.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 73f4d08a84f46966abac6a0e384aaa0c6cd3c5ad 
> 
> 
> Diff: https://reviews.apache.org/r/65797/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sachin Paryani
> 
>

Re: Review Request 65798: Ported mesos-execute to Windows

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65798/#review198262
---


Ship it!




I'll fix the remaining stuff.


src/cli/CMakeLists.txt
Line 17 (original), 17 (patched)


Hm, I thought we'd deleted this. I'll fix it.



src/cli/execute.cpp
Lines 982 (patched)


Nit: Comments should end with a period.

(I'll fix it when I commit.)


- Andrew Schwartzmeyer


On Feb. 24, 2018, 7:22 p.m., Sachin Paryani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65798/
> ---
> 
> (Updated Feb. 24, 2018, 7:22 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8607
> https://issues.apache.org/jira/browse/MESOS-8607
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change allows for the mesos-execute cli framework to work on Windows.
> The change was to print an appropriate error message without the calling
> getuid which doesn't exist in Windows.
> 
> 
> Diffs
> -
> 
>   src/cli/CMakeLists.txt 06d9e62bc28bf82d594d9deda0b7e1d962b1dbef 
>   src/cli/execute.cpp 221d65f4b498c4831e24ff34bd54b18a7364457a 
> 
> 
> Diff: https://reviews.apache.org/r/65798/diff/1/
> 
> 
> Testing
> ---
> 
> Successfully built the mesos-execute cli from source and executed on Windows 
> environment using the following command:
> ./src/mesos-execute --master=192.168.56.1:5050 --name="simple-test" 
> --command=notepad
> 
> 
> Thanks,
> 
> Sachin Paryani
> 
>

Review Request 65798: Ported mesos-execute to Windows

[Sachin Paryani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65798/
---

Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-8607
https://issues.apache.org/jira/browse/MESOS-8607


Repository: mesos


Description
---

This change allows for the mesos-execute cli framework to work on Windows.
The change was to print an appropriate error message without the calling
getuid which doesn't exist in Windows.


Diffs
-

  src/cli/CMakeLists.txt 06d9e62bc28bf82d594d9deda0b7e1d962b1dbef 
  src/cli/execute.cpp 221d65f4b498c4831e24ff34bd54b18a7364457a 


Diff: https://reviews.apache.org/r/65798/diff/1/


Testing
---

Successfully built the mesos-execute cli from source and executed on Windows 
environment using the following command:
./src/mesos-execute --master=192.168.56.1:5050 --name="simple-test" 
--command=notepad


Thanks,

Sachin Paryani

Review Request 65799: Ported mesos-master to Windows.

[Sachin Paryani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65799/
---

Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-5820
https://issues.apache.org/jira/browse/MESOS-5820


Repository: mesos


Description
---

The change allows for the mesos-master executable to work on Windows.
The change was to remove the part of the code for that utilizes the
ip_discovery_command flag if the build is Windows and replaced with
an appropriate error message.


Diffs
-

  src/master/CMakeLists.txt ec552110509d17628107f4ad98f2d04675ed3ce3 
  src/master/main.cpp 8cb52d0c452ab3c328eea80aa56f1c984de372e9 


Diff: https://reviews.apache.org/r/65799/diff/1/


Testing
---

Successfully built the master and then started the mesos-master executable.  
The following command was used:
./src/mesos-master --registry='in_memory' --webui_dir=../src/webui


Thanks,

Sachin Paryani

Review Request 65800: Added Anurag Bihani to the contributors list

[Sachin Paryani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65800/
---

Review request for mesos and Andrew Schwartzmeyer.


Repository: mesos


Description
---

Added Anurag Bihani to the contributors list


Diffs
-

  docs/contributors.yaml 73f4d08a84f46966abac6a0e384aaa0c6cd3c5ad 


Diff: https://reviews.apache.org/r/65800/diff/1/


Testing
---


Thanks,

Sachin Paryani

Review Request 65797: Added Sachin Paryani to contributors list.

[Sachin Paryani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65797/
---

Review request for mesos and Andrew Schwartzmeyer.


Repository: mesos


Description
---

Added Sachin Paryani to contributors list.


Diffs
-

  docs/contributors.yaml 73f4d08a84f46966abac6a0e384aaa0c6cd3c5ad 


Diff: https://reviews.apache.org/r/65797/diff/1/


Testing
---


Thanks,

Sachin Paryani

Re: Review Request 65795: Adding warning to `apply-reviews.py` for previously submitted patches.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65795/#review198261
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65795']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65795

Relevant logs:

- 
[stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65795/logs/stout-tests-stdout.log):

```
[ RUN  ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile
[   OK ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile (5 ms)
[ RUN  ] RmdirTest.RemoveDirectoryButPreserveRoot
[   OK ] RmdirTest.RemoveDirectoryButPreserveRoot (5 ms)
[--] 11 tests from RmdirTest (54 ms total)

[--] 1 test from SocketTests
[ RUN  ] SocketTests.InitSocket
[   OK ] SocketTests.InitSocket (1 ms)
[--] 1 test from SocketTests (2 ms total)

[--] 2 tests from StrerrorTest
[ RUN  ] StrerrorTest.ValidErrno
[   OK ] StrerrorTest.ValidErrno (1 ms)
[ RUN  ] StrerrorTest.InvalidErrno
[   OK ] StrerrorTest.InvalidErrno (0 ms)
[--] 2 tests from StrerrorTest (2 ms total)

[--] Global test environment tear-down
[==] 273 tests from 46 test cases ran. (4146 ms total)
[  PASSED  ] 270 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] OsTest.SYMLINK_Realpath
[  FAILED  ] FsTest.CreateDirectoryAtMaxPath
[  FAILED  ] FsTest.CreateDirectoryLongerThanMaxPath

 3 FAILED TESTS
  YOU HAVE 7 DISABLED TESTS

```

- 
[stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65795/logs/stout-tests-stderr.log):

```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command  [OPTIONS]

Available subcommands:
help
subcommand2

Multiple subcommands have name 'subcommand'
```

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65795/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (115 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (985 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (49 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (83 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2300 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2322 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2273 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (2299 ms total)

[--] Global test environment tear-down
[==] 914 tests from 90 test cases ran. (419646 ms total)
[  PASSED  ] 913 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] FilesTest.DebugTest

 1 FAILED TEST
  YOU HAVE 211 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65795/logs/mesos-tests-stderr.log):

```
I0225 03:10:23.642463  3596 master.cpp:10258] Updating the state of task 
29ccdf9a-a775-4c98-a206-f1d9513f0877 of framework 
eeebbcc1-f807-47af-90cc-d9217e1a835f- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0225 03:10:23.642463  1020 slave.cpp:3879] Shutting down framework 
eeebbcc1-f807-47af-90cc-d9217e1a835f-
I0225 03:10:23.642463  1020 slave.cpp:6586] ShI0225 03:10:23.005475  6672 
exec.cpp:162] Version: 1.6.0
I0225 03:10:23.029477  5100 exec.cpp:236] Executor registered on agent 
eeebbcc1-f807-47af-90cc-d9217e1a835f-S0
I0225 03:10:23.033478  7472 executor.cpp:174] Received SUBSCRIBED event
I0225 03:10:23.037477  7472 executor.cpp:178] Subscribed executor on 
build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0225 03:10:23.037477  7472 executor.cpp:174] Received LAUNCH event
I0225 03:10:23.042454  7472 executor.cpp:646] Starting task 
29ccdf9a-a775-4c98-a206-f1d9513f0877
I0225 03:10:23.116479  7472 executor.cpp:481] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0225 03:10:23.617491  7472 executor.cpp:659] Forked command at 7036
I0225 03:10:23.644464  1348 exec.cpp:445] Executor asked to shutdown
I0225 03:10:23.645464  7472 executor.cpp:174

Re: Review Request 65795: Adding warning to `apply-reviews.py` for previously submitted patches.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65795/#review198259
---


Ship it!




This address the first point of MESOS-8586 by warning the user that a patch (or 
patches) were skipped when applying a review chain if they were already 
submitted.

Note that the second point is left purposefully unaddressed, as the user will 
be warned it was already submitted, and then can use `git cherry-pick` to 
backport the patch.

- Andrew Schwartzmeyer


On Feb. 24, 2018, 5:36 p.m., Shubham Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65795/
> ---
> 
> (Updated Feb. 24, 2018, 5:36 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8586
> https://issues.apache.org/jira/browse/MESOS-8586
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit emits a warning when a chain skips submitted patches so
> that the user is aware they were ignored.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py 9fc1579f732609dac1b19ff5862f374e71e6cb53 
> 
> 
> Diff: https://reviews.apache.org/r/65795/diff/1/
> 
> 
> Testing
> ---
> 
> Test done.
> 
> command: ./support/apply-reviews.py -c -r 65397
> output: Warning: Review 65397 has already been applied
> 
> 
> Thanks,
> 
> Shubham Kumar
> 
>

Review Request 65795: Adding warning to `apply-reviews.py` for previously submitted patches.

[Shubham Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65795/
---

Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-8586
https://issues.apache.org/jira/browse/MESOS-8586


Repository: mesos


Description
---

This commit emits a warning when a chain skips submitted patches so
that the user is aware they were ignored.


Diffs
-

  support/apply-reviews.py 9fc1579f732609dac1b19ff5862f374e71e6cb53 


Diff: https://reviews.apache.org/r/65795/diff/1/


Testing
---

Test done.

command: ./support/apply-reviews.py -c -r 65397
output: Warning: Review 65397 has already been applied


Thanks,

Shubham Kumar

Re: Review Request 65441: Deleted deprecated Windows build script.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65441/#review198257
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On Jan. 31, 2018, 6:59 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65441/
> ---
> 
> (Updated Jan. 31, 2018, 6:59 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This script has been unmaintained and is no longer used. The build
> process for Windows has improved to the point that scripting it has
> become unnecessary. So we delete it to avoid confusion over a likely
> broken script.
> 
> 
> Diffs
> -
> 
>   support/windows-build.bat 49732c4baae3bdcdf8254ded03e7dab961b74b2e 
> 
> 
> Diff: https://reviews.apache.org/r/65441/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 65441: Deleted deprecated Windows build script.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65441/#review198256
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65441']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441

Relevant logs:

- 
[stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441/logs/stout-tests-stdout.log):

```
[ RUN  ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile
[   OK ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile (4 ms)
[ RUN  ] RmdirTest.RemoveDirectoryButPreserveRoot
[   OK ] RmdirTest.RemoveDirectoryButPreserveRoot (5 ms)
[--] 11 tests from RmdirTest (59 ms total)

[--] 1 test from SocketTests
[ RUN  ] SocketTests.InitSocket
[   OK ] SocketTests.InitSocket (2 ms)
[--] 1 test from SocketTests (2 ms total)

[--] 2 tests from StrerrorTest
[ RUN  ] StrerrorTest.ValidErrno
[   OK ] StrerrorTest.ValidErrno (0 ms)
[ RUN  ] StrerrorTest.InvalidErrno
[   OK ] StrerrorTest.InvalidErrno (0 ms)
[--] 2 tests from StrerrorTest (1 ms total)

[--] Global test environment tear-down
[==] 273 tests from 46 test cases ran. (4132 ms total)
[  PASSED  ] 270 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] OsTest.SYMLINK_Realpath
[  FAILED  ] FsTest.CreateDirectoryAtMaxPath
[  FAILED  ] FsTest.CreateDirectoryLongerThanMaxPath

 3 FAILED TESTS
  YOU HAVE 7 DISABLED TESTS

```

- 
[stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441/logs/stout-tests-stderr.log):

```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command  [OPTIONS]

Available subcommands:
help
subcommand2

Multiple subcommands have name 'subcommand'
```

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (96 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (917 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (71 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2281 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2304 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2154 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (2175 ms total)

[--] Global test environment tear-down
[==] 914 tests from 90 test cases ran. (412002 ms total)
[  PASSED  ] 913 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] FilesTest.DebugTest

 1 FAILED TEST
  YOU HAVE 211 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441/logs/mesos-tests-stderr.log):

```
I0225 00:18:02.365806  1744 master.cpp:10258] Updating the state of task 
d07debe9-02a1-43d7-8763-04a842fe98cb of framework 
cf9e5aa6-58cc-4234-9d5e-0806158f4477- (latest state: TASK_KILLED, status 
I0225 00:18:01.730516  2764 exec.cpp:162] Version: 1.6.0
I0225 00:18:01.752516  3652 exec.cpp:236] Executor registered on agent 
cf9e5aa6-58cc-4234-9d5e-0806158f4477-S0
I0225 00:18:01.756512  5872 executor.cpp:174] Received SUBSCRIBED event
I0225 00:18:01.761513  5872 executor.cpp:178] Subscribed executor on 
build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0225 00:18:01.761513  5872 executor.cpp:174] Received LAUNCH event
I0225 00:18:01.765516  5872 executor.cpp:646] Starting task 
d07debe9-02a1-43d7-8763-04a842fe98cb
I0225 00:18:01.838516  5872 executor.cpp:481] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0225 00:18:02.339804  5872 executor.cpp:659] Forked command at 9816
I0225 00:18:02.367802  8096 exec.cpp:445] Executor asked to shutdown
I0225 00:18:02.367802  5872 executor.cpp:174] Received SHUTDOWN event
I0225 00:18:02.367802  5872 executor.cpp:756] Shutting down
I0225 00:18:02.367802  5872 executor.cpp:866] Sending SIGTERM to process tree 
at pid 9update state:

Re: Review Request 52064: Support for multiple versions of docs.

[Tim Anderegg]

> On Feb. 24, 2018, 12:50 a.m., Benjamin Mahler wrote:
> > Vinod and I went over this, a couple of issues:
> > 
> > * The [endpoint 
> > documentation](http://mesos.apache.org/documentation/latest/endpoints/) is 
> > only being generated for latest (see 
> > https://github.com/apache/mesos/blob/master/support/mesos-website/build.sh),
> >  this needs to be generated for each version.
> > * The C++ and Java API documentation is only being generated for latest 
> > (not sure how easy this is to fix, maybe if you also tackle this do so in a 
> > seperate patch). Also note that home.md linked directly to 
> > "/api/latest/c++" and "/api/latest/java" which means that the old versions 
> > would send users to latest c++ and java docs.
> > * We had a hard time figuring why some of the code changes were needed or 
> > what they were doing (e.g. some of the new regexes, or why the version 
> > selector drop-down has an empty value for the first entry), some comments 
> > would be helpful for the reader.
> > 
> > We were thinking the following approach would be good alternative:
> > 
> > * In order to ensure that we generate the HTTP help endpoint documentation 
> > correctly for each version, the 
> > [build.sh](https://github.com/apache/mesos/blob/master/support/mesos-website/build.sh)
> >  script would loop over each 1.x.y tag (excluding -rc#'s) and checkout the 
> > tag into a sub-directory. Within this sub-directory, we would build mesos 
> > and generate the help endpoints documentation. This sub-directory would 
> > probably be named directly as the version (e.g. "1.0.0", "1.4.1", etc).
> > * Note that for efficiency reasons (it's very expensive to build mesos for 
> > so many tags), the build.sh script would skip a tag if it finds that the 
> > publish directory already exists for the version in the mesos-site 
> > repository.
> > * The Rakefile would be updated to look at each version checkout 
> > subdirectory, and would generate the docs using the documentation folder 
> > within that specific version subdirectory.
> > * Not sure if the releases YAML still needs the docs tag, it seems so since 
> > it's used in the javascript. This would at least need to be updated so that 
> > everything before 1.0.0 is "false".
> > * Is it possible to put the version selector on the right side of the blue 
> > banner?

Sounds good.  I had initially avoided the C++ and Java API documentation since 
it would take a very long time to generate, as you mention, but I'm happy to 
tackle that as well. Limiting to 1.0.0+ will alleviate that a bit.

For the regex, the first change was just a simplification since the two lines 
were redundant once I updated the code to use "{{ version }}" instead of 
"latest" (I will verify that however, in case I am remembering incorrectly). 
The second change was to account for older versions of the Mesos code where 
"latest" was hardcoded into the HTML templates themselves, which would mess up 
the links.  That one is already commented, but I will go through and add 
comments wherever there may be ambiguity.  Since we are now doing only 1.0.0+, 
this work around can probably be removed.

For the version selector, happy to move it and remove the empty option, since 
the value should always be the currently displayed version of the 
documentation.  I'm also not sure why I did that, it was a while ago...

For the docs tag, we could either keep it or if we want the logic to just be 
"all versions from 1.0.0 onwards", that can be hard coded into the build.sh and 
the HTML template, and we could remove the docs tag.  Let me know what you 
prefer.

For the updated approach, just to make sure I'm clear:

1) In build.sh, iterate over all tags and checkout the code into a folder with 
the tag name, (perhaps in $WORKSPACE/mesos/_build/x.y.z/) if the primary 
$WORKSPACE/mesos/site/publish/documentation/x.y.z folder doesn't already exist.
2) Then the Rakefile (from $WORKSPACE/mesos, i.e. the HEAD version) is used to 
build the docs for each version folder into the primary 
$WORKSPACE/mesos/site/publish/documentation/x.y.z folder, as before, but only 
if it doesn't already exist.

A few questions:

1) I'm assuming that this build occurs in a Jenkins job that retains its 
workspace between runs, which is why we are checking whether or not the folder 
exists?  Or is the mesos-website publish folder the only thing that persists 
between runs?  Just want to make sure my conception of the build environment is 
correct, if the later is true question 2 can be ignored.
2) Should the script remove the checked-out code after the build runs for each 
version that needed it?  Otherwise over time many copies of the Mesos code 
would persist (one for each tagged version), which would be GB's in size.

Thanks!  I should be able to find time to do this over the next week or so.

Tim


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://rev

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65674/#review198253
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65587', '65588', '65589', '65590', '65591', '65673', 
'65674']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674

Relevant logs:

- 
[stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674/logs/stout-tests-stdout.log):

```
[ RUN  ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile
[   OK ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile (5 ms)
[ RUN  ] RmdirTest.RemoveDirectoryButPreserveRoot
[   OK ] RmdirTest.RemoveDirectoryButPreserveRoot (7 ms)
[--] 11 tests from RmdirTest (63 ms total)

[--] 1 test from SocketTests
[ RUN  ] SocketTests.InitSocket
[   OK ] SocketTests.InitSocket (2 ms)
[--] 1 test from SocketTests (2 ms total)

[--] 2 tests from StrerrorTest
[ RUN  ] StrerrorTest.ValidErrno
[   OK ] StrerrorTest.ValidErrno (1 ms)
[ RUN  ] StrerrorTest.InvalidErrno
[   OK ] StrerrorTest.InvalidErrno (0 ms)
[--] 2 tests from StrerrorTest (2 ms total)

[--] Global test environment tear-down
[==] 273 tests from 46 test cases ran. (5313 ms total)
[  PASSED  ] 270 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] OsTest.SYMLINK_Realpath
[  FAILED  ] FsTest.CreateDirectoryAtMaxPath
[  FAILED  ] FsTest.CreateDirectoryLongerThanMaxPath

 3 FAILED TESTS
  YOU HAVE 7 DISABLED TESTS

```

- 
[stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674/logs/stout-tests-stderr.log):

```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command  [OPTIONS]

Available subcommands:
help
subcommand2

Multiple subcommands have name 'subcommand'
```

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (125 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1220 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (43 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (83 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2407 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2431 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2601 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (2626 ms total)

[--] Global test environment tear-down
[==] 914 tests from 90 test cases ran. (466657 ms total)
[  PASSED  ] 913 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] FilesTest.DebugTest

 1 FAILED TEST
  YOU HAVE 211 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65674/logs/mesos-tests-stderr.log):

```
I0224 11:52:18.096415  8992 slave.cpp:3876] Shutting down framework 
91b15ae2-7689-4f99-8efc-205e18ed6cb1-
I0224 11:52:18.096415  8320 master.cpp:10168] Updating the state of task 
9f6627de-11ea-4026-b319-7820a28354a9 of framework 
91b15ae2-7689-4f99-8efc-205e18ed6cb1- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0224 11:52:18.097440  8992 slave.cpp:6569] Shutting down executor 
'9f6627de-11ea-4026-b319-7820a28354a9' of framework 
91b15ae2-7689-4f99-8efc-205e18ed6cb1- at executor(1)@10.3.1.11:61952
I0224 11:52:18.098415  8992 slave.cpp:922] Agent terminating
W0224 11:52:18.098415  8992 slave.cpp:3872] Ignoring shutdown framework 
91b15ae2-7689-4f99-8efc-205e18ed6cb1- because it is terminating
I0224 11:52:18.100414  8320 master.cpp:10267] Removing task 
9f6627de-11ea-4026-b319-7820a28354a9 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 91b15ae2-7689-4f99-8efc-205e18ed6cb1- on 
agent 91b15ae2-7689-4f9I0224 11:52:17.346493  8824 exec.cpp:162] Version: 1.6.0
I0224 11:52:17.384498  2668 exec.cpp:236] Executor registered on ag

Re: Review Request 65791: Removed stale generated HTTP endpoint documentation.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65791/#review198252
---



I think a sticky issue which would have been great to resolve here is to make 
sure that we enable building of endpoint documentation generation for 
non-dockerized site builds as well (i.e., `cd site/ && bundle install && bundle 
exec rake` should produce output similar to what the dockerized version running 
in CI produces; this probably requires adding a dedicated rake targe). Granted, 
this was already slightly broken, and we now make that more apparent.

- Benjamin Bannier


On Feb. 24, 2018, 1:29 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65791/
> ---
> 
> (Updated Feb. 24, 2018, 1:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Bugs: MESOS-8442
> https://issues.apache.org/jira/browse/MESOS-8442
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is now generated by the website CI bot, rather than having
> to be checked in and kept up to date within the docs/ folder.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json.md 
> 6b21e50bb0c0098babedcd612a5acfd0e6ae0aab 
>   docs/endpoints/files/browse.md 0fa204a85fc62aa4b43dacc07aec6951b618a015 
>   docs/endpoints/files/debug.json.md 2806a5844f49a3c051e58db0723879c9627e18e1 
>   docs/endpoints/files/debug.md 33380663eab59c704c610bd392676aee99528f77 
>   docs/endpoints/files/download.json.md 
> 31d442a7e1e3d4c6e32986ec85e42f3364f37de9 
>   docs/endpoints/files/download.md 202d015484b22e63c9d24610808a43d091786844 
>   docs/endpoints/files/read.json.md 64f348e76d61d3d0ad364f4712d3c1d90818d6d1 
>   docs/endpoints/files/read.md ef95c80739eeb09f52658470429c6ffb9b41fb8c 
>   docs/endpoints/index.md 871153774c4b21cdca4afec9bc2ce2bd955b17c4 
>   docs/endpoints/logging/toggle.md 014a1969a7efb709e06c0c90ca023f2fa747414e 
>   docs/endpoints/master/api/v1.md 2d778f33c830caccb0254cf15adc46a86b5db48a 
>   docs/endpoints/master/api/v1/scheduler.md 
> f029d8e6e90bc7d974d60ad4a71d63807f0e901a 
>   docs/endpoints/master/create-volumes.md 
> c9ce39ead8041f249ee6f85d1afdd8f90b38ce9b 
>   docs/endpoints/master/destroy-volumes.md 
> ff82e96a6ee1e9f6e1bbc565ab40c98b758c1227 
>   docs/endpoints/master/flags.md 6b3de41d45278cc34a4f4f0e52b76407ab96b790 
>   docs/endpoints/master/frameworks.md 
> 7aa22130dfa8702d8b93690cb75f1323ea3c2223 
>   docs/endpoints/master/health.md 3752a1bb4a9a7c2cc5cbf25b021592280c174a80 
>   docs/endpoints/master/machine/down.md 
> 05abd155e693163eb50f675d2724534a6f87dfba 
>   docs/endpoints/master/machine/up.md 
> 8a3488bb3f96bc7470aaea5114559cb593cbb3a8 
>   docs/endpoints/master/maintenance/schedule.md 
> 86ae30b06118f13593e91b70dbec97945b1d9bd8 
>   docs/endpoints/master/maintenance/status.md 
> f8e1c7eed44e14a8324b582a2db91e523b2fbc15 
>   docs/endpoints/master/quota.md 6ce7811136ac1c4ae00a3011dca17cbde948f14e 
>   docs/endpoints/master/redirect.md 3c568e3eef658f9a489008f4f84745827f8002f0 
>   docs/endpoints/master/reserve.md 8174027f0e66dc4e9ae7bca951ed9ca38033008d 
>   docs/endpoints/master/roles.json.md 
> 9acba2cfed120918b2571d7336651d125cbe 
>   docs/endpoints/master/roles.md de58120172c390ef1f084031077fd9b865b817db 
>   docs/endpoints/master/slaves.md 9365cdb9e5b17cdf26ed38a0ab1fff8afef38f00 
>   docs/endpoints/master/state-summary.md 
> 21b8703bb011daf5cc560550e6c2ce36ba615bba 
>   docs/endpoints/master/state.json.md 
> 62a723051270ab24591b956805aee5455848201b 
>   docs/endpoints/master/state.md 09a478263d4cd015040f47619b0aa94341c3bba2 
>   docs/endpoints/master/tasks.json.md 
> f9553d7bde7de33b02795ba9088a88e68cb2a0cc 
>   docs/endpoints/master/tasks.md 019a14bb6c8d8acd3aab4a1f7ba6893f4bad835b 
>   docs/endpoints/master/teardown.md b017084e3d195363615a59011671fdbd76182a1a 
>   docs/endpoints/master/unreserve.md 324dcded2013aeb6c167a695bbad1da69340cd57 
>   docs/endpoints/master/weights.md 3c9019e74867cbd931dc5c68a0d8de3ea269e5b2 
>   docs/endpoints/metrics/snapshot.md 0912fa939b38fd1d8335e165c7aeddf1f076 
>   docs/endpoints/profiler/start.md a25f0d0468f2ad9f8d1ff41f6c50ea0bbe87d316 
>   docs/endpoints/profiler/stop.md 5028d13f8a3f9aa3d41b60959a9cc3d6b03fb7d9 
>   docs/endpoints/registrar/registry.md 
> e347db269839d60fac6de0777b245e830279661e 
>   docs/endpoints/slave/api/v1.md b394f7fac2c4600b7e11f5c7f4def44edc22e7db 
>   docs/endpoints/slave/api/v1/executor.md 
> 5ef40e3ca5ad072b5bbfd480d4e0b56d9530a17f 
>   docs/endpoints/slave/api/v1/resource_provider.md 
> c721c6d005224807bdb4fbfcf4fd7c30edb82e6c 
>   docs/endpoints/slave/containers.md f8bcb3847a6e29dc98d424cdfeacfce26ad98d67 
>   docs/endpoints/slave/flags.md 4a8a0361124078342887c291acaa73c9f