Re: Review Request 65665: Added operation state metrics in SLRP.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65665/
---

(Updated April 12, 2018, 5:15 a.m.)


Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.


Changes
---

Addressed Jan's comments.


Bugs: MESOS-8383
https://issues.apache.org/jira/browse/MESOS-8383


Repository: mesos


Description
---

This patch adds `operations_pending`, `operations_finished`,
`operations_failed`, `operations_error` (currently unused), and
`operations_dropped` metrics to count the occurances of these operation
states.

Additionally, An error log in `_applyOperation()` is removed because the
error is already logged at the call site.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
a07620d1c4bf618f669575b3e183bf598da905a6 


Diff: https://reviews.apache.org/r/65665/diff/4/

Changes: https://reviews.apache.org/r/65665/diff/3-4/


Testing
---

sudo make check
A unit test is added in the next patch in chain.


Thanks,

Chun-Hung Hsiao

Re: Review Request 66163: Built storage local resource provider with CMake.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66163/
---

(Updated April 12, 2018, 5:15 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and 
Joseph Wu.


Changes
---

Rebased and addressed Jan's comments.


Bugs: MESOS-8698
https://issues.apache.org/jira/browse/MESOS-8698


Repository: mesos


Description
---

This patch adds CMake rules for compiling necessary source code for
building storage local resource provider and related tests.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
  src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
  src/examples/CMakeLists.txt e85eed607715d2b3ee596c3c0b51f16682491900 
  src/resource_provider/storage/CMakeLists.txt PRE-CREATION 
  src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 


Diff: https://reviews.apache.org/r/66163/diff/3/

Changes: https://reviews.apache.org/r/66163/diff/2-3/


Testing
---

`sudo make check` with CMake


Thanks,

Chun-Hung Hsiao

Re: Review Request 66493: Made FreeBSD default to non-GNU ld.

[David Forsythe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66493/
---

(Updated April 12, 2018, 5:13 a.m.)


Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.


Bugs: MESOS-8761
https://issues.apache.org/jira/browse/MESOS-8761


Repository: mesos


Description
---

Made FreeBSD default to non-GNU ld.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 


Diff: https://reviews.apache.org/r/66493/diff/3/

Changes: https://reviews.apache.org/r/66493/diff/2-3/


Testing
---

make on FreeBSD, with both lld and gold.


Thanks,

David Forsythe

Re: Review Request 65665: Added operation state metrics in SLRP.

[Chun-Hung Hsiao]

> On March 21, 2018, 1:12 p.m., Jan Schlicht wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 503 (patched)
> > 
> >
> > As this is only used as a helper in the constructor of `Metrics`, how 
> > about introducing a small helper function instead of leaking this 
> > implementation detail?

I'll revert to the original style and pass the prefix to the `Metrics` 
constructor, which follows the pattern we used in `src/log/metrics.cpp`.


> On March 21, 2018, 1:12 p.m., Jan Schlicht wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 2713 (patched)
> > 
> >
> > `statusUpdateManager.update` below might still fail to drop the 
> > message. In that case we would count the operation as dropped in metrics 
> > when we increment here. Increment in an `onReady` handler instead.

If the `update()` call fails, the SLRP will immediately die anyway, so at least 
there will be no double counting. But your suggestion makes sense so I'll do 
the change, and also change where we increment the `operations_finished` or 
`operations_failed` metrics.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65665/#review199657
---


On March 20, 2018, 3:24 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65665/
> ---
> 
> (Updated March 20, 2018, 3:24 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan 
> Schlicht.
> 
> 
> Bugs: MESOS-8383
> https://issues.apache.org/jira/browse/MESOS-8383
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds `operations_pending`, `operations_finished`,
> `operations_failed`, `operations_error` (currently unused), and
> `operations_dropped` metrics to count the occurances of these operation
> states.
> 
> Additionally, An error log in `_applyOperation()` is removed because the
> error is already logged at the call site.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> bb19ed4b6b1b8f5f6b327461a737517497c8c38e 
> 
> 
> Diff: https://reviews.apache.org/r/65665/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> A unit test is added in the next patch in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 66554: Updated Web UI controllers to have one file per controller.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66554/#review200969
---



Patch looks great!

Reviews applied: [66553, 66554]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 11, 2018, 3:23 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66554/
> ---
> 
> (Updated April 11, 2018, 3:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-8503
> https://issues.apache.org/jira/browse/MESOS-8503
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removes `controllers.js` and adds one file per controller. The shared
> functions are now in a file called `utils.js` and the linter has been
> updated to know about it. This gives more freedom to add or update
> each controller while making the structure of the UI more visible.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/webui/app/agents/agent-browse-controller.js PRE-CREATION 
>   src/webui/app/agents/agent-controller.js PRE-CREATION 
>   src/webui/app/agents/agent-executor-controller.js PRE-CREATION 
>   src/webui/app/agents/agent-framework-controller.js PRE-CREATION 
>   src/webui/app/agents/agent-task-and-executor-rerouter-controller.js 
> PRE-CREATION 
>   src/webui/app/agents/agents-controller.js PRE-CREATION 
>   src/webui/app/app.js 7de0899c2071c5127881fb725d0dd0246b10f849 
>   src/webui/app/controllers.js 66a4f2955a88fa44c3e5c717e9ce6b680050cc34 
>   src/webui/app/frameworks/framework-controller.js PRE-CREATION 
>   src/webui/app/frameworks/frameworks-controller.js PRE-CREATION 
>   src/webui/app/home.html  
>   src/webui/app/home/home-controller.js PRE-CREATION 
>   src/webui/app/maintenance/maintenance-controller.js PRE-CREATION 
>   src/webui/app/offers/offers-controller.js PRE-CREATION 
>   src/webui/app/roles/roles-controller.js PRE-CREATION 
>   src/webui/app/services.js  
>   src/webui/app/shared/main-controller.js PRE-CREATION 
>   src/webui/app/shared/utils.js PRE-CREATION 
>   src/webui/index.html 149d765429dc2211875783129da6c6b101f38ecf 
>   support/.eslintrc.js cd23ddebd2b40f795fa297e6decacada356a01f8 
> 
> 
> Diff: https://reviews.apache.org/r/66554/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> GTEST_FILTER="" make check -j4
> ```
> And tested manually.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileAdaptorTests`.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65640/
---

(Updated April 12, 2018, 3:37 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Jie Yu, and 
Joseph Wu.


Changes
---

Rebased.


Bugs: MESOS-8567
https://issues.apache.org/jira/browse/MESOS-8567


Repository: mesos


Description
---

There was a race between `Clock::advance()` in the `FetchFromHTTP` test
and `delay()` in `UriDiskProfileAdaptorProcess::_poll`. This patch
avoids the race by enforcing an order between the dispatch of the
`__poll` function (previously `_poll`) and the clock manipulation
in the test. It also fixed two memory leaks in the test.


Diffs (updated)
-

  src/Makefile.am 257ff0e8d21e5240c27a123ed0cd563214e24fce 
  src/resource_provider/storage/uri_disk_profile_adaptor.hpp 
0484933b42d0bd66c689b06cb48f492eef7bc606 
  src/resource_provider/storage/uri_disk_profile_adaptor.cpp 
300ea12687de487737ce91066ab4e74d9b3430e6 
  src/tests/disk_profile_adaptor_tests.cpp 
948f6efc916d6fad0703944ad9acb77d85e4c25e 


Diff: https://reviews.apache.org/r/65640/diff/4/

Changes: https://reviews.apache.org/r/65640/diff/3-4/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65976/
---

(Updated April 12, 2018, 3:37 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu.


Changes
---

Rebased.


Bugs: MESOS-8492
https://issues.apache.org/jira/browse/MESOS-8492


Repository: mesos


Description
---

Allowed profiles to be missing from `DiskProfileAdaptor`.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
a07620d1c4bf618f669575b3e183bf598da905a6 
  src/resource_provider/storage/uri_disk_profile_adaptor.cpp 
300ea12687de487737ce91066ab4e74d9b3430e6 


Diff: https://reviews.apache.org/r/65976/diff/3/

Changes: https://reviews.apache.org/r/65976/diff/2-3/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65975/
---

(Updated April 12, 2018, 3:36 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Rebased and adopted CSI v0.2.


Bugs: MESOS-8492
https://issues.apache.org/jira/browse/MESOS-8492


Repository: mesos


Description
---

The storage pools needs to be reconciled in the following two scenarios:

1. When there is a change in the set of known profiles.
2. When a volume/block of an unknown profile is destroyed, because the
   disk space being freed up may belong to a known profile.

This patch adds a sequence to coordinate the reconciliations for the
above two cases.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
a07620d1c4bf618f669575b3e183bf598da905a6 


Diff: https://reviews.apache.org/r/65975/diff/3/

Changes: https://reviews.apache.org/r/65975/diff/2-3/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65594/
---

(Updated April 12, 2018, 3:35 a.m.)


Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Joseph 
Wu.


Changes
---

Rebased and adopted CSI v0.2.


Bugs: MESOS-8492
https://issues.apache.org/jira/browse/MESOS-8492


Repository: mesos


Description
---

SLRP now checkpoints profiles associated with storage pools, and does
not depend on the `DiskProfileAdaptor` module to return the set of
previously-known profiles during recovery.


Diffs (updated)
-

  src/resource_provider/state.proto 8577b58b8cdb63b3daddf06ea5d12f80f9d42f2b 
  src/resource_provider/storage/provider.cpp 
a07620d1c4bf618f669575b3e183bf598da905a6 


Diff: https://reviews.apache.org/r/65594/diff/8/

Changes: https://reviews.apache.org/r/65594/diff/7-8/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65974: Added comments and made some renaming in SLRP.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65974/
---

(Updated April 12, 2018, 3:33 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Rebased.


Repository: mesos


Description
---

Added comments and made some renaming in SLRP.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
a07620d1c4bf618f669575b3e183bf598da905a6 


Diff: https://reviews.apache.org/r/65974/diff/3/

Changes: https://reviews.apache.org/r/65974/diff/2-3/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65995/
---

(Updated April 12, 2018, 3:31 a.m.)


Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8492
https://issues.apache.org/jira/browse/MESOS-8492


Repository: mesos


Description
---

The two SLRP tests assume that SLRP will send out a RAW resource in its
first `UPDATE_STATE` message, and expect that the test framework would
receive an offer containing the RAW resource in its first offer. However
this behavior is not guaranteed and should not be relied on. This patch
makes the tests decline unwanted offers by default so they no longer
rely on SLRP's internal behavior.


Diffs (updated)
-

  src/tests/storage_local_resource_provider_tests.cpp 
2872f1aec1a7b94fc302a533f5ae9e1be9658087 


Diff: https://reviews.apache.org/r/65995/diff/5/

Changes: https://reviews.apache.org/r/65995/diff/4-5/


Testing
---

sudo make check
Ran the two tests in repitition.


Thanks,

Chun-Hung Hsiao

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66578/#review200965
---



PASS: Mesos patch 66578 was successfully built and tested.

Reviews applied: `['66423', '66424', '66425', '66426', '66427', '66428', 
'66455', '66429', '66430', '66431', '66432', '66434', '66435', '66436', 
'66437', '66433', '66438', '66439', '66440', '66442', '66443', '66444', 
'66445', '66578']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66578

- Mesos Reviewbot Windows


On April 12, 2018, 2:06 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66578/
> ---
> 
> (Updated April 12, 2018, 2:06 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed `os::sleep()` to return an invalid parameter error if given a
> negative value.
> 
> Fixed tests around the `cloexec` and `nonblock` stubs.
> 
> Extended the `bootid` test to use `std::chrono` to assert the boot
> id (which is the system boot time) is a reasonable value.
> 
> Permanently disabled `OsTest.Libraries` because there is no
> equivalent.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/bootid.hpp 
> d24e115b97ebcabfa808a9437fb41512f25a5271 
>   3rdparty/stout/include/stout/windows/os.hpp 
> 900baf9be4e3089cb43e444b14b155a80bcd1591 
>   3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 
> 
> 
> Diff: https://reviews.apache.org/r/66578/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 61096: Building gRPC with CMake.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61096/
---

(Updated April 12, 2018, 3:22 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and 
Joseph Wu.


Changes
---

Rebased.


Bugs: MESOS-7881
https://issues.apache.org/jira/browse/MESOS-7881


Repository: mesos


Description
---

This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC
3rdparty library in CMake.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99 
  3rdparty/cmake/Versions.cmake 93f0322c1ac926bcfdcd4c1cfd9ba9f22bcf7099 
  cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
  src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc 


Diff: https://reviews.apache.org/r/61096/diff/6/

Changes: https://reviews.apache.org/r/61096/diff/5-6/


Testing
---

`sudo make check` with CMake

NOTE: Testing on Windowns is not done yet.


Thanks,

Chun-Hung Hsiao

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

[Benjamin Mahler]

> On April 10, 2018, 8:45 p.m., Benjamin Mahler wrote:
> > include/mesos/v1/scheduler.hpp
> > Lines 102-114 (patched)
> > 
> >
> > Hm.. why does this return an `Option`?
> > 
> > If this is mesos Response rather than http::Response, aren't we losing 
> > information about which http code came back? (e.g. 400, 401, etc).
> 
> Gaston Kleiman wrote:
> If the request is not successful and the http code is neither 200 nor 
> 202, the method will return an error that includes the http code and the body 
> of the HTTP response.
> 
> It returns a `scheduler::Response` in order to abstract the consumer from 
> the transport layer and prevent it from having to understand and deserialize 
> HTTP responses.
> 
> Benjamin Mahler wrote:
> How do I program against that? Parse the failure.message() into an 
> http::Response?
> 
> It looks like we need: `Future master::Response>>` where master::Response is returned for 200 OK? (If we 
> want to handle parsing into master::Response for them.
> 
> Gaston Kleiman wrote:
> Most scheduler API calls don't return a `scheduler::Response`, so we'd 
> need to use `Future>`.
> 
> However that would only give the consumer access to the `http::Response` 
> if the request fails. We might want to return an enum that always contains 
> the `http::Response` and that also includes an `Option`.
> 
> Note that the current call `send()` is a `void` method, so we've been 
> able to avoid using the `http::Response` sent by the master.
> 
> Greg Mann wrote:
> This library does not expose the transport layer to the client at all, 
> and the current patch maintains that convention.
> 
> If we're going to expose the HTTP response, I think Gastón's suggestion 
> of including it unconditionally makes sense.
> 
> Without the HTTP response, yes I think the client would have to parse the 
> failure message to deduce the error. Perhaps this is a suitable time to start 
> exposing HTTP here? I would be fine with that.
> 
> Benjamin Mahler wrote:
> > `Future>`
> 
> Are you sure you need the option? I think the client can always decode a 
> scheduler::Response, because when the master sends nothing back, the client 
> can successfully decode an empty `scheduler::Response`, it just won't have 
> `Response::type` set? In any case, the inconsistency here seems a bit 
> confusing?
> 
> > This library does not expose the transport layer to the client at all, 
> and the current patch maintains that convention.
> 
> HTTP is in the application layer rather than tranport layer (to be 
> pendantic :)), and that makes sense here since it encodes some of the 
> application level responses from the master rather than all application 
> behavior being inside `master::Response`. E.g. 400 Bad Request
> 
> > Perhaps this is a suitable time to start exposing HTTP here? I would be 
> fine with that.
> 
> It's either that, or we "abstract" response codes / bodies out into some 
> other structure, but it doesn't seem maintainable as more http response codes 
> get returned by the master?
> 
> Anyway, sorry to throw a wrench in here :) I just want to avoid parsing 
> strings to program against the master. (I'm assuming there will be some 
> response codes that the scheduler will react differently to: e.g. 400 
> shouldn't be retried, whereas 503 should?)
> 
> Gaston Kleiman wrote:
> > > `Future>`
> 
> > Are you sure you need the option? I think the client can always decode 
> a scheduler::Response, because when the master sends nothing back, the client 
> can successfully decode an empty scheduler::Response, it just won't have 
> Response::type set? In any case, the inconsistency here seems a bit confusing?
> 
> I think that using an option makes it semantically clearer that the 
> master might not respond to a scheduler API call with a 
> `scheduler::Response`. I also find checking whether an option is set or not 
> less awkward and more readable than checking whether 
> `scheduler::Response::type` is set.
> 
> An HTTP will always be returned if the future didn't fail, but a 
> `scheduler::Response` is optional and the master in most cases doesn't 
> respond with one. I don't think that we need symmetry/consistency in the 
> method signature. 
> 
> 
> > > Perhaps this is a suitable time to start exposing HTTP here? I would 
> be fine with that.
> 
> > It's either that, or we "abstract" response codes / bodies out into 
> some other structure, but it doesn't seem maintainable as more http response 
> codes get returned by the master?
> 
> I think that ideally we'd like "abstract" response codes such as (or 
> maybe exactly) [the ones used by 
> 

Re: Review Request 66457: WIP: Made resource provider API aware of workloads.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66457/#review200959
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66457']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66457

Relevant logs:

- 
[mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66457/logs/mesos-tests-cmake-stdout.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
 warning C4716: 'pthread_cond_wait': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]


   "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
   "D:\DCOS\mesos\src\java\mesos-java.vcxproj" (default target) (15) ->
   (ClCompile target) -> 
 
d:\dcos\mesos\mesos\include\mesos\resource_provider\resource_provider.hpp(30): 
error C3083: 'UpdatePublishResourcesStatus': the symbol to the left of a '::' 
must be a type (compiling source file 
D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp) 
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
 
d:\dcos\mesos\mesos\include\mesos\resource_provider\resource_provider.hpp(30): 

Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66578/
---

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441


Repository: mesos


Description
---

Fixed `os::sleep()` to return an invalid parameter error if given a
negative value.

Fixed tests around the `cloexec` and `nonblock` stubs.

Extended the `bootid` test to use `std::chrono` to assert the boot
id (which is the system boot time) is a reasonable value.

Permanently disabled `OsTest.Libraries` because there is no
equivalent.


Diffs
-

  3rdparty/stout/include/stout/os/windows/bootid.hpp 
d24e115b97ebcabfa808a9437fb41512f25a5271 
  3rdparty/stout/include/stout/windows/os.hpp 
900baf9be4e3089cb43e444b14b155a80bcd1591 
  3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 


Diff: https://reviews.apache.org/r/66578/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66462: Added new operation states to be used for status reconciliation.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66462/#review200957
---



Are all of these necessary for now?


src/slave/slave.cpp
Lines 8034-8038 (patched)


Move these outside the block.


- Chun-Hung Hsiao


On April 11, 2018, 5:58 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66462/
> ---
> 
> (Updated April 11, 2018, 5:58 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added new operation states to be used for status reconciliation.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907 
>   include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95 
>   src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080 
>   src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 
>   src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 
> 
> 
> Diff: https://reviews.apache.org/r/66462/diff/3/
> 
> 
> Testing
> ---
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66437/
---

(Updated April 11, 2018, 7:06 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

Added unit tests and fixed comparing `int_fd(INVALID_SOCKET)` to `int_fd(-1)`.


Bugs: MESOS-8675 and MESOS-8683
https://issues.apache.org/jira/browse/MESOS-8675
https://issues.apache.org/jira/browse/MESOS-8683


Repository: mesos


Description
---

After all the CRT APIs were replaced with Windows APIs, we no longer
needed to support the semantics of an `int` file descriptor in
general (in the sense of opening a CRT handle that's associated with
the actual kernel object for the given `HANDLE`). There are specific
use cases (usually third-party code) which still require a CRT
int-like file descriptor, which the `crt()` function explicitly
allocates (this allocation used to be done in the constructor).

Thus the entire `FD_CRT` type was removed from the `WindowsFD`
abstraction. It still acts like an `int` in the sense that it can be
constructed from one and compared to one. However, construction via
`int` only supports the standard file descriptors 0, 1, and 2 for
`stdin`, `stdout`, and `stderr`. Any other construction creates an
`int_fd` which holds an `INVALID_HANDLE_VALUE`. When being compared to
an `int`, the abstraction simply returns -1 if it is invalid (based on
the result of the `is_valid()` method) or 0 if it is valid. This is to
support the semantics of checking validity by something like
`if (fd < 0)` or `if (fd == -1)`.

With the deletion of the `FD_CRT` type from `WindowsFD`, all the Stout
APIs that switched on the type were simplified, with the last of the
CRT code deleted.

Thanks to the introduction of the private `int get_valid()` function,
and the removal of the `FD_CRT` type, the comparison operators became
much simpler.

Several unit tests in the `FsTest` suite became cross-platform, with
the `Close` test being simplified to test against an `int_fd`.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/windows/close.hpp 
ff635e44235d63888a210cd68d49f6678a851e31 
  3rdparty/stout/include/stout/os/windows/dup.hpp 
265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 
  3rdparty/stout/include/stout/os/windows/fcntl.hpp 
bf8c38acad60f9b0eb752053dcd53a9fda7b8bfa 
  3rdparty/stout/include/stout/os/windows/fd.hpp 
d7f8cdf1ad877eb55589bf5a9e75d295f91990a7 
  3rdparty/stout/include/stout/os/windows/read.hpp 
8047ad590fcc46d3ec46b551472d8c518ae49cc1 
  3rdparty/stout/include/stout/os/windows/write.hpp 
71006489918d9495d37d2fdfdca08b40b419481a 
  3rdparty/stout/tests/os/filesystem_tests.cpp 
c190baa2230298e428d4034b90dccffb59b4e710 
  3rdparty/stout/tests/os/socket_tests.cpp 
8ea0f1238e4293a5cd313b4ee38a920b381f4022 


Diff: https://reviews.apache.org/r/66437/diff/5/

Changes: https://reviews.apache.org/r/66437/diff/4-5/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66577: Enabled CSI proto compilation by default.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66577/#review200955
---



FAIL: Failed to apply the dependent review: 66398.

Failed command: `python.exe .\support\apply-reviews.py -n -r 66398`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66577

Relevant logs:

- 
[apply-review-66398-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66577/logs/apply-review-66398-stdout.log):

```
error: missing binary patch data for '3rdparty/csi-0.2.0.tar.gz'
error: binary patch does not apply to '3rdparty/csi-0.2.0.tar.gz'
error: 3rdparty/csi-0.2.0.tar.gz: patch does not apply
```

- Mesos Reviewbot Windows


On April 12, 2018, 1:39 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66577/
> ---
> 
> (Updated April 12, 2018, 1:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, and Jie Yu.
> 
> 
> Bugs: MESOS-8724
> https://issues.apache.org/jira/browse/MESOS-8724
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CSI proto compilation is disabled due to MESOS-8724, which is resolved
> by bumping CSI to v0.2. This patch enables the compilation again.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
>   src/Makefile.am 257ff0e8d21e5240c27a123ed0cd563214e24fce 
>   src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4 
>   src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 
> 
> 
> Diff: https://reviews.apache.org/r/66577/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Review Request 66577: Enabled CSI proto compilation by default.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66577/
---

Review request for mesos, Benjamin Bannier, Benno Evers, and Jie Yu.


Bugs: MESOS-8724
https://issues.apache.org/jira/browse/MESOS-8724


Repository: mesos


Description
---

CSI proto compilation is disabled due to MESOS-8724, which is resolved
by bumping CSI to v0.2. This patch enables the compilation again.


Diffs
-

  src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
  src/Makefile.am 257ff0e8d21e5240c27a123ed0cd563214e24fce 
  src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4 
  src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 


Diff: https://reviews.apache.org/r/66577/diff/1/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Review Request 66576: Added `STAGE_UNSTAGE_VOLUME` capability to the test CSI plugin.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66576/
---

Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717


Repository: mesos


Description
---

Now it is required to call `NodeStageVolume` before `NodePublishVolume`
for the test CSI plugin. `NodeStageVolume` would bind-mount the volume
directory to the specified staging path, and then `NodePublishVolume`
would bind-mount the staging path to the target path.


Diffs
-

  src/examples/test_csi_plugin.cpp aed22623b6dadb791eeaac2ecde4c31236a5fc19 


Diff: https://reviews.apache.org/r/66576/diff/1/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Review Request 66575: Supported `STAGE_UNSTAGE_VOLUME` CSI node capability in SLRP.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66575/
---

Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717


Repository: mesos


Description
---

The storage local resource provider now properly calls `NodeStageVolume`
or `NodeUnstageVolume` when publishing or deleting volumes for CSI
plugins support the `STAGE_UNSTAGE_VOLUME` capability.


Diffs
-

  src/csi/state.proto 0373c8ad217998a54b06d483f94052bcf4293677 
  src/resource_provider/storage/provider.cpp 
a07620d1c4bf618f669575b3e183bf598da905a6 


Diff: https://reviews.apache.org/r/66575/diff/1/


Testing
---

sudo make check

`STAGE_UNSTAGE_VOLUME` is tested later in the chain.


Thanks,

Chun-Hung Hsiao

Re: Review Request 63295: Update glog-0.3.3.patch to build on ARM.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63295/#review200953
---



Is this being upstreamed into glog?

- Benjamin Mahler


On Oct. 25, 2017, 1:14 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63295/
> ---
> 
> (Updated Oct. 25, 2017, 1:14 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> glog has an old version of config.guess this
> change updates it to the recent version that properly
> detects ARM architecture.
> 
> 
> Diffs
> -
> 
>   3rdparty/glog-0.3.3.patch f1ed584cf12181307552c3c9429d31759be5de65 
> 
> 
> Diff: https://reviews.apache.org/r/63295/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Review Request 66574: Updated filesystem layout for staging and mounting CSI volumes.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66574/
---

Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717


Repository: mesos


Description
---

To support the `STAGE_UNSTAGE_VOLUME` in CSI v0.2, a CSI volume is now
staged at `/csi///mounts//staging` and
mounted at `/csi///mounts//target`.

The `DiskInfo.Source.Path.root` and `DiskInfo.Source.Mount.root` fields
now stores `./csi///mounts` for PATH and MOUNT disk
resources respectively, and the actual mount point is carved out from
the `root` and `id` fields. In the future, the `SharedInfo` might also
be used to construct the mount point for shared volumes.


Diffs
-

  src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
  src/Makefile.am 257ff0e8d21e5240c27a123ed0cd563214e24fce 
  src/csi/paths.hpp 7892e5ed8d333be5e61e2148860789786db31925 
  src/csi/paths.cpp 0d42db249c8c27b1089e91e8d068fb7fa81a46b3 
  src/resource_provider/storage/provider.cpp 
a07620d1c4bf618f669575b3e183bf598da905a6 
  src/slave/paths.cpp 8a7e162ad41f5e7cc73eda660c6adc365a73edba 


Diff: https://reviews.apache.org/r/66574/diff/1/


Testing
---

This patch cannot be compiled standalone. Tests done later in the chain.


Thanks,

Chun-Hung Hsiao

Re: Review Request 66493: Made FreeBSD default to non-GNU ld.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66493/#review200945
---


Fix it, then Ship it!





cmake/CompilationConfigure.cmake
Lines 322 (patched)


(Nit: I wouldn't even bother with this doc string. "Linker path." is 
pointless, but so is explaining it, especially considering the comment above 
and the error message below, and the variable name itself.)



cmake/CompilationConfigure.cmake
Lines 330-332 (patched)


Nit: No real reason to set `USE_LD_FLAG` since it's used once. 
`string(APPEND CMAKE_${type}_LINKER_FLAGS " -fuse-ld=${LD_PROGRAM}")` should be 
just fine.


- Andrew Schwartzmeyer


On April 9, 2018, 11:36 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66493/
> ---
> 
> (Updated April 9, 2018, 11:36 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8761
> https://issues.apache.org/jira/browse/MESOS-8761
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made FreeBSD default to non-GNU ld.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
> 
> 
> Diff: https://reviews.apache.org/r/66493/diff/2/
> 
> 
> Testing
> ---
> 
> make on FreeBSD, with both lld and gold.
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review200943
---



PASS: Mesos patch 66532 was successfully built and tested.

Reviews applied: `['66218', '66049', '66050', '66568', '66219', '66220', 
'66569', '66052', '66051', '66227', '66531', '66532']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66532

- Mesos Reviewbot Windows


On April 10, 2018, 7:24 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66532/
> ---
> 
> (Updated April 10, 2018, 7:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8748
> https://issues.apache.org/jira/browse/MESOS-8748
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for authorization actions for `UPDATE_VOLUME`.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c 
> 
> 
> Diff: https://reviews.apache.org/r/66532/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66511: Updated tests due to change of containerizer's `destroy()` return type.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66511/#review200942
---



Patch looks great!

Reviews applied: [66510, 66511]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 9, 2018, 3:45 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66511/
> ---
> 
> (Updated April 9, 2018, 3:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian 
> Zhang.
> 
> 
> Bugs: MESOS-8710
> https://issues.apache.org/jira/browse/MESOS-8710
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As the return type of `destroy()` method has been changed, we need to
> update tests accordingly. This patch fixes all tests affected by the
> change.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp 97dde00bbd32d763c961e6ad2b323fb0ca3d774f 
>   src/tests/containerizer.hpp d6a69d6327018065453f8a6cb275d921d10c9198 
>   src/tests/containerizer.cpp 13a290ff60e359ceced95b20cb9db8c25cd59dbc 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> 09f7ea42dd833c36aefdb073517d809431c4f328 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> c198ecbac50ef4eb7ea243bebc17b65db7ce5cb7 
>   src/tests/containerizer/io_switchboard_tests.cpp 
> 8fdaa7ffb11d3cc48e1a2f4eaa086adda2837106 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 4fce8af7c89fd3b9166e1784203f99853624faef 
>   src/tests/containerizer/mock_containerizer.hpp 
> 01c617a55899a7125ca1dc80091aef5603419ee8 
> 
> 
> Diff: https://reviews.apache.org/r/66511/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66554: Updated Web UI controllers to have one file per controller.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66554/#review200941
---




src/webui/app/agents/agent-browse-controller.js
Lines 35 (patched)


I noticed these .js files just assume the right js files are already 
"imported" and there is a globals table in the linter? Is this how it's 
normally done or do files explicitly import other files? It struck me as 
tedious that we would have to keep a globals table up-to-date for the linter.


- Benjamin Mahler


On April 11, 2018, 3:23 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66554/
> ---
> 
> (Updated April 11, 2018, 3:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-8503
> https://issues.apache.org/jira/browse/MESOS-8503
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removes `controllers.js` and adds one file per controller. The shared
> functions are now in a file called `utils.js` and the linter has been
> updated to know about it. This gives more freedom to add or update
> each controller while making the structure of the UI more visible.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/webui/app/agents/agent-browse-controller.js PRE-CREATION 
>   src/webui/app/agents/agent-controller.js PRE-CREATION 
>   src/webui/app/agents/agent-executor-controller.js PRE-CREATION 
>   src/webui/app/agents/agent-framework-controller.js PRE-CREATION 
>   src/webui/app/agents/agent-task-and-executor-rerouter-controller.js 
> PRE-CREATION 
>   src/webui/app/agents/agents-controller.js PRE-CREATION 
>   src/webui/app/app.js 7de0899c2071c5127881fb725d0dd0246b10f849 
>   src/webui/app/controllers.js 66a4f2955a88fa44c3e5c717e9ce6b680050cc34 
>   src/webui/app/frameworks/framework-controller.js PRE-CREATION 
>   src/webui/app/frameworks/frameworks-controller.js PRE-CREATION 
>   src/webui/app/home.html  
>   src/webui/app/home/home-controller.js PRE-CREATION 
>   src/webui/app/maintenance/maintenance-controller.js PRE-CREATION 
>   src/webui/app/offers/offers-controller.js PRE-CREATION 
>   src/webui/app/roles/roles-controller.js PRE-CREATION 
>   src/webui/app/services.js  
>   src/webui/app/shared/main-controller.js PRE-CREATION 
>   src/webui/app/shared/utils.js PRE-CREATION 
>   src/webui/index.html 149d765429dc2211875783129da6c6b101f38ecf 
>   support/.eslintrc.js cd23ddebd2b40f795fa297e6decacada356a01f8 
> 
> 
> Diff: https://reviews.apache.org/r/66554/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> GTEST_FILTER="" make check -j4
> ```
> And tested manually.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 66553: Restructured Web UI.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66553/#review200940
---


Ship it!




A little bit of history, "master" was there because the agent used to serve its 
own UI and the master would link to that :)

- Benjamin Mahler


On April 11, 2018, 3:21 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66553/
> ---
> 
> (Updated April 11, 2018, 3:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-8503
> https://issues.apache.org/jira/browse/MESOS-8503
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Does not change the logic of the Web UI, only updates the structure
> to have fewer nested directories and a more logical grouping of files.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 
>   src/webui/master/static/agent.html  
>   src/webui/master/static/agent_executor.html  
>   src/webui/master/static/agent_framework.html  
>   src/webui/master/static/agents.html  
>   src/webui/master/static/browse.html  
>   src/webui/master/static/css/bootstrap-3.3.6.min.css  
>   src/webui/master/static/css/bootstrap-table-1.11.1.min.css  
>   src/webui/master/static/css/mesos.css  
>   src/webui/master/static/directives/pagination.html  
>   src/webui/master/static/directives/tableHeader.html  
>   src/webui/master/static/directives/timestamp.html  
>   src/webui/master/static/fonts/glyphicons-halflings-regular.eot  
>   src/webui/master/static/fonts/glyphicons-halflings-regular.svg 
> 94fb5490a2ed10b2c69a4a567a4fd2e4f706d841 
>   src/webui/master/static/fonts/glyphicons-halflings-regular.ttf  
>   src/webui/master/static/fonts/glyphicons-halflings-regular.woff  
>   src/webui/master/static/fonts/glyphicons-halflings-regular.woff2  
>   src/webui/master/static/framework.html  
>   src/webui/master/static/frameworks.html  
>   src/webui/master/static/home.html  
>   src/webui/master/static/ico/favicon.ico  
>   src/webui/master/static/img/loading.gif  
>   src/webui/master/static/img/mesos_logo.png  
>   src/webui/master/static/index.html 149d765429dc2211875783129da6c6b101f38ecf 
>   src/webui/master/static/js/angular-1.2.32.min.js  
>   src/webui/master/static/js/angular-route-1.2.32.min.js  
>   src/webui/master/static/js/app.js 7de0899c2071c5127881fb725d0dd0246b10f849 
>   src/webui/master/static/js/bootstrap-table-1.11.1.min.js  
>   src/webui/master/static/js/clipboard-1.5.16.min.js  
>   src/webui/master/static/js/controllers.js 
> 66a4f2955a88fa44c3e5c717e9ce6b680050cc34 
>   src/webui/master/static/js/jquery-3.2.1.min.js  
>   src/webui/master/static/js/jquery.pailer.js  
>   src/webui/master/static/js/relative-date.js  
>   src/webui/master/static/js/services.js  
>   src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js  
>   src/webui/master/static/js/underscore-1.4.3.min.js  
>   src/webui/master/static/maintenance.html  
>   src/webui/master/static/offers.html  
>   src/webui/master/static/pailer.html 
> 6710b7d4405d66171d07e88112c71bb4a30b29d4 
>   src/webui/master/static/roles.html  
> 
> 
> Diff: https://reviews.apache.org/r/66553/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> GTEST_FILTER="" make check -j4
> ```
> And tested manually.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 66511: Updated tests due to change of containerizer's `destroy()` return type.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66511/#review200938
---


Ship it!





src/tests/containerizer.cpp
Lines 533-540 (original), 534-542 (patched)


clang 3.9 was able to compile this successfully when I did the following:
```
  return process::dispatch(
  process.get(),
  ::destroy,
  containerId);
```
I'm guessing the disambiguation is needed on other compilers; I'm just 
leaving a note here for posterity. If we discover this disambiguation is no 
longer necessary, we should remove it.


- Greg Mann


On April 9, 2018, 3:45 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66511/
> ---
> 
> (Updated April 9, 2018, 3:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian 
> Zhang.
> 
> 
> Bugs: MESOS-8710
> https://issues.apache.org/jira/browse/MESOS-8710
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As the return type of `destroy()` method has been changed, we need to
> update tests accordingly. This patch fixes all tests affected by the
> change.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp 97dde00bbd32d763c961e6ad2b323fb0ca3d774f 
>   src/tests/containerizer.hpp d6a69d6327018065453f8a6cb275d921d10c9198 
>   src/tests/containerizer.cpp 13a290ff60e359ceced95b20cb9db8c25cd59dbc 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> 09f7ea42dd833c36aefdb073517d809431c4f328 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> c198ecbac50ef4eb7ea243bebc17b65db7ce5cb7 
>   src/tests/containerizer/io_switchboard_tests.cpp 
> 8fdaa7ffb11d3cc48e1a2f4eaa086adda2837106 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 4fce8af7c89fd3b9166e1784203f99853624faef 
>   src/tests/containerizer/mock_containerizer.hpp 
> 01c617a55899a7125ca1dc80091aef5603419ee8 
> 
> 
> Diff: https://reviews.apache.org/r/66511/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66510: Unified return type of `wait` and `destroy` containerizer methods.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66510/#review200937
---


Ship it!




Ship It!

- Greg Mann


On April 9, 2018, 3:44 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66510/
> ---
> 
> (Updated April 9, 2018, 3:44 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian 
> Zhang.
> 
> 
> Bugs: MESOS-8706
> https://issues.apache.org/jira/browse/MESOS-8706
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch changes the return type of `destroy()` method for all
> containerizers. As a result, `destroy()` and `wait()` methods have
> got the same signature and return type. In fact, all these methods
> depend on the same container termination promise, so this unification
> makes both containerizer interface and internal logic more consistent.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.hpp 
> 1221d9b61b7cfbdbaa560dbafb0158225331ed6d 
>   src/slave/containerizer/composing.cpp 
> cd840a5409023d32701329bf37806f2e7ed6ffd2 
>   src/slave/containerizer/containerizer.hpp 
> 836283aa8aa827459558d567e090a230c32351ed 
>   src/slave/containerizer/docker.hpp f1b56c8edced17e9786c86adb9b92c829ed81635 
>   src/slave/containerizer/docker.cpp 31d64a7ea2a331a084c0f1707b82e938dfe6390f 
>   src/slave/containerizer/mesos/containerizer.hpp 
> cba4ed2e20622070b46071f35907d8b32c25b2fc 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 7473a871e626833733f39375b778aff70529dc63 
>   src/slave/http.cpp d500fde22d01d2c66104b72ff39d9de4e3a411cd 
> 
> 
> Diff: https://reviews.apache.org/r/66510/diff/2/
> 
> 
> Testing
> ---
> 
> Tests can't be compiled after this change.
> See the next patch in the chain.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66227/
---

(Updated April 11, 2018, 2:21 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.


Changes
---

Fix macro so it will skip on windows.


Bugs: MESOS-8747
https://issues.apache.org/jira/browse/MESOS-8747


Repository: mesos


Description
---

Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.


Diffs (updated)
-

  src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 


Diff: https://reviews.apache.org/r/66227/diff/4/

Changes: https://reviews.apache.org/r/66227/diff/3-4/


Testing
---


Thanks,

Zhitao Li

Review Request 66569: Added a test to verify that grow and shrink cannot be combined.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66569/
---

Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Bugs: MESOS-4965
https://issues.apache.org/jira/browse/MESOS-4965


Repository: mesos


Description
---

Added a test to verify that grow and shrink cannot be combined.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
4edf781711d9efdb994114aeb6289b6af750b87a 


Diff: https://reviews.apache.org/r/66569/diff/1/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/
---

(Updated April 11, 2018, 2:19 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.


Changes
---

Use proper test macros.


Bugs: MESOS-4965
https://issues.apache.org/jira/browse/MESOS-4965


Repository: mesos


Description
---

Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
4edf781711d9efdb994114aeb6289b6af750b87a 


Diff: https://reviews.apache.org/r/66220/diff/4/

Changes: https://reviews.apache.org/r/66220/diff/3-4/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66219: Added helper functions to create grow and shrink volume in test.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66219/
---

(Updated April 11, 2018, 2:18 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.


Changes
---

Fix proper macros.


Bugs: MESOS-4965
https://issues.apache.org/jira/browse/MESOS-4965


Repository: mesos


Description
---

Added helper functions to create grow and shrink volume in test.


Diffs (updated)
-

  src/tests/mesos.hpp 6f4e0c5567b99891f6d0eceb7e6917d25083db0e 


Diff: https://reviews.apache.org/r/66219/diff/5/

Changes: https://reviews.apache.org/r/66219/diff/4-5/


Testing
---


Thanks,

Zhitao Li

Review Request 66568: Dropped GROW and SHRINK volume if combined with other operations.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66568/
---

Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Bugs: MESOS-4965
https://issues.apache.org/jira/browse/MESOS-4965


Repository: mesos


Description
---

These two operations are intended to be non-speculative eventually but
are implemented as speculative right now. To avoid frameworks opt-in to
dangerous behavior, we require that accept can only container one
`GROW_VOLUME` or `SHRINK_VOLUME` and no other operations.


Diffs
-

  src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 


Diff: https://reviews.apache.org/r/66568/diff/1/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66173/#review200931
---



I'm getting a test failure on `ROOT_XFS_QuotaTest.RecoverOldContainers` with 
these patches enabled. When we restart the agent with the XFS isolator enabled, 
we skip the running task because there isn't a project ID on the sandbox. Then 
the containerizer tells us to watch that container ID but we return a failure 
because we don't know anything about it. That failure causes the containerizer 
to kill the task. So we need to update `XfsDiskIsolatorProcess::recover` to 
store a placeholder to handle this case.

- James Peach


On April 4, 2018, 5:41 p.m., Harold Dost wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66173/
> ---
> 
> (Updated April 4, 2018, 5:41 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-6575
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe 
> 
> 
> Diff: https://reviews.apache.org/r/66173/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harold Dost
> 
>

Re: Review Request 66541: Added default executor test for agent recovery without metadata.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66541/#review200930
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66538', '66539', '66540', '66541']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66541

Relevant logs:

- 
[mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66541/logs/mesos-tests-cmake-stdout.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3426):
 warning C4996: 'strerror': This function or variable may be unsafe. Consider 
using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500):
 warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define 
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170):
 warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496):
 warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256):
 warning C4090: 'function': different 'const' qualifiers 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166):
 warning C4716: 'pthread_cond_broadcast': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
 warning C4716: 'pthread_cond_wait': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66538/
---

(Updated April 11, 2018, 1:40 p.m.)


Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.


Bugs: MESOS-8772
https://issues.apache.org/jira/browse/MESOS-8772


Repository: mesos


Description
---

Added unit test slave recovery for default executor tests.


Diffs (updated)
-

  src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 


Diff: https://reviews.apache.org/r/66538/diff/4/

Changes: https://reviews.apache.org/r/66538/diff/3-4/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 66541: Added default executor test for agent recovery without metadata.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66541/
---

(Updated April 11, 2018, 1:40 p.m.)


Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.


Bugs: MESOS-8416
https://issues.apache.org/jira/browse/MESOS-8416


Repository: mesos


Description
---

Added default executor test for agent recovery without metadata.


Diffs (updated)
-

  src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 


Diff: https://reviews.apache.org/r/66541/diff/3/

Changes: https://reviews.apache.org/r/66541/diff/2-3/


Testing
---

make check

Verified that the test crashes without the fix in r/66539.


Thanks,

Gilbert Song

Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66562/#review200928
---



PASS: Mesos patch 66562 was successfully built and tested.

Reviews applied: `['66559', '66560', '66561', '66562']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66562

- Mesos Reviewbot Windows


On April 11, 2018, 6:31 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66562/
> ---
> 
> (Updated April 11, 2018, 6:31 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for local puller hdfs uri fetcher plugin.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c664ff807583d587d94b0ab797330d5d3daf7657 
> 
> 
> Diff: https://reviews.apache.org/r/66562/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64211/#review200926
---



Patch looks great!

Reviews applied: [65585, 65705, 64211]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 24, 2018, 11:39 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64211/
> ---
> 
> (Updated March 24, 2018, 11:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> An update of the discarded review /r/52543.
> 
> Works with Autotools and CMake.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6702f02245e3867c06bbd9efbbf4e3b961a7d9aa 
>   cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
>   configure.ac f0f901f2e565352c2804cae7b2ac255da81ce45d 
>   docs/configuration/cmake.md 1e34657ea55fa324f65f865f7d0a67084c6719d9 
>   src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/python/cli_new/CMakeLists.txt PRE-CREATION 
>   src/python/cli_new/tests/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64211/diff/17/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25.
> 
> For Autotools:
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ ../configure --enable-new-cli --disable-java --disable-python
> $ make check
> ```
> 
> For CMake:
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> `build/src/cli` was as expected, and that `build/src/mesos` was correctly 
> running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 66541: Added default executor test for agent recovery without metadata.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66541/
---

(Updated April 11, 2018, 12:02 p.m.)


Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.


Bugs: MESOS-8416
https://issues.apache.org/jira/browse/MESOS-8416


Repository: mesos


Description
---

Added default executor test for agent recovery without metadata.


Diffs (updated)
-

  src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 


Diff: https://reviews.apache.org/r/66541/diff/2/

Changes: https://reviews.apache.org/r/66541/diff/1-2/


Testing
---

make check

Verified that the test crashes without the fix in r/66539.


Thanks,

Gilbert Song

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66538/
---

(Updated April 11, 2018, 12:01 p.m.)


Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.


Bugs: MESOS-8772
https://issues.apache.org/jira/browse/MESOS-8772


Repository: mesos


Description
---

Added unit test slave recovery for default executor tests.


Diffs (updated)
-

  src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 


Diff: https://reviews.apache.org/r/66538/diff/3/

Changes: https://reviews.apache.org/r/66538/diff/2-3/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66538/
---

(Updated April 11, 2018, 11:53 a.m.)


Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.


Bugs: MESOS-8772
https://issues.apache.org/jira/browse/MESOS-8772


Repository: mesos


Description
---

Added unit test slave recovery for default executor tests.


Diffs (updated)
-

  src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b 


Diff: https://reviews.apache.org/r/66538/diff/2/

Changes: https://reviews.apache.org/r/66538/diff/1-2/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

[Gilbert Song]

> On April 11, 2018, 7:14 a.m., Qian Zhang wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 1427-1430 (patched)
> > 
> >
> > Why do we need to launch the executor using reserved resources? This 
> > seems not relevant to the target of this test. I think we can just launch 
> > both the executor and the task with unreserved resources.

Ah, my mistake by copying from the test above. Thanks!


> On April 11, 2018, 7:14 a.m., Qian Zhang wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 1481-1485 (patched)
> > 
> >
> > So we use this as a signal that the default executor has re-registered 
> > with the agent, right? But I think this `TASK_RUNNING` status update will 
> > actually be resent by the agent (rather than the executor) after the agent 
> > re-registered with the master and even before the executor re-registered 
> > with the agent. So I think it might not be used as such signal.

Ah, good catch. we could not verified the executor reregistration due to 
MESOS-6623


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66538/#review200891
---


On April 10, 2018, 4:41 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66538/
> ---
> 
> (Updated April 10, 2018, 4:41 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8772
> https://issues.apache.org/jira/browse/MESOS-8772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test slave recovery for default executor tests.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66538/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 66230: Added test for adding/removing framework roles.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66230/#review200923
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66228', '66229', '66230']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230/logs/mesos-tests-stdout.log):

```
[   OK ] 
ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/0 
(220 ms)
[ RUN  ] 
ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1
[   OK ] 
ContentType/SchedulerTest.OperationFeedbackValidationSchedulerDriverFramework/1 
(215 ms)
[ RUN  ] ContentType/SchedulerTest.ShutdownExecutor/0
[   OK ] ContentType/SchedulerTest.ShutdownExecutor/0 (340 ms)
[ RUN  ] ContentType/SchedulerTest.ShutdownExecutor/1
[   OK ] ContentType/SchedulerTest.ShutdownExecutor/1 (369 ms)
[ RUN  ] ContentType/SchedulerTest.Decline/0
[   OK ] ContentType/SchedulerTest.Decline/0 (243 ms)
[ RUN  ] ContentType/SchedulerTest.Decline/1
[   OK ] ContentType/SchedulerTest.Decline/1 (265 ms)
[ RUN  ] ContentType/SchedulerTest.Revive/0
[   OK ] ContentType/SchedulerTest.Revive/0 (266 ms)
[ RUN  ] ContentType/SchedulerTest.Revive/1
[   OK ] ContentType/SchedulerTest.Revive/1 (267 ms)
[ RUN  ] ContentType/SchedulerTest.Suppress/0
[   OK ] ContentType/SchedulerTest.Suppress/0 (285 ms)
[ RUN  ] ContentType/SchedulerTest.Suppress/1
[   OK ] ContentType/SchedulerTest.Suppress/1 (264 ms)
[ RUN  ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0
[   OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0 (293 ms)
[ RUN  ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1
[   OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1 (279 ms)
[ RUN  ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0
[   OK ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0 (325 
ms)
[ RUN  ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1
[   OK ] 
ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1 (320 
ms)
[ RUN  ] ContentType/SchedulerTest.AddRoles/0
d:\dcos\mesos\mesos\src\tests\scheduler_tests.cpp(2018): error: Failed to wait 
15secs for offers1
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66230/logs/mesos-tests-stderr.log):

```
@   7FF6DC5E0ED2  
std::invoke<,mesos::internal::master::Framework
 * 
__ptr64,mesos::FrameworkInfo,std::set,std::less,std::less,std::less,mesos::internal::master::Framework
 * 
__ptr64,mesos::FrameworkInfo,std::set,std::less,std::less::CallableFn::operator(
@   7FF6DE4E6BB9  process::ProcessBase::consume
@   7FF6DE662E2A  process::DispatchEvent::consume
@   7FF6DA891F37  process::ProcessBase::serve
@   7FF6DE4F4BD0  process::ProcessManager::resume
@   7FF6DE5FFD11   ?? 
@   7FF6DE53CD40  
std::_Invoker_functor::_Call< >
@   7FF6DE593170  std::invoke< 
>
@   7FF6DE54B9EC  
std::_LaunchPad,std::default_delete > 
> >::_Execute<0>
@   7FF6DE64B0EA  
std::_LaunchPad,std::default_delete > 
> >::_Run
@   7FF6DE637B48  
std::_LaunchPad,std::default_delete > 
> >::_Go
@   7FF6DE61FD8D  std::_Pad::_Call_func
@   7FFBB5B511E8  _register_onexit_function
@   7FFBB5B50E01  _register_onexit_function
@   7FFBCFD71FE4  

Re: Review Request 66510: Unified return type of `wait` and `destroy` containerizer methods.

[Greg Mann]

> On April 10, 2018, 6:15 p.m., Greg Mann wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Line 2335 (original), 2336 (patched)
> > 
> >
> > Hmm I think it might be a bit more readable here and elsewhere to 
> > continue using a trivial lambda which returns a default-constructed 
> > `ContainerTermination`, WDYT?
> > 
> > ```
> > .then([]() { return ContainerTermination(); });
> > ```
> 
> Andrei Budnik wrote:
> `Option::some` is a wrapper for 
> `ContainerTermination` type: 
> https://github.com/apache/mesos/blob/3dcd225dbb817da676ae57f4f8871650ece5a0b8/3rdparty/stout/include/stout/option.hpp#L36-L39
> So, this code returns a wrapped termination variable instead of 
> constructing a new one.
> 
> BTW, the shortest equivalent code would be:
> ```
> .then([](const Future& termination) -> 
> Option {
>   return termination.get();
> });
> ```
> which doesn't look simpler to me.

Ah OK sorry, makes sense.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66510/#review200828
---


On April 9, 2018, 3:44 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66510/
> ---
> 
> (Updated April 9, 2018, 3:44 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian 
> Zhang.
> 
> 
> Bugs: MESOS-8706
> https://issues.apache.org/jira/browse/MESOS-8706
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch changes the return type of `destroy()` method for all
> containerizers. As a result, `destroy()` and `wait()` methods have
> got the same signature and return type. In fact, all these methods
> depend on the same container termination promise, so this unification
> makes both containerizer interface and internal logic more consistent.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.hpp 
> 1221d9b61b7cfbdbaa560dbafb0158225331ed6d 
>   src/slave/containerizer/composing.cpp 
> cd840a5409023d32701329bf37806f2e7ed6ffd2 
>   src/slave/containerizer/containerizer.hpp 
> 836283aa8aa827459558d567e090a230c32351ed 
>   src/slave/containerizer/docker.hpp f1b56c8edced17e9786c86adb9b92c829ed81635 
>   src/slave/containerizer/docker.cpp 31d64a7ea2a331a084c0f1707b82e938dfe6390f 
>   src/slave/containerizer/mesos/containerizer.hpp 
> cba4ed2e20622070b46071f35907d8b32c25b2fc 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 7473a871e626833733f39375b778aff70529dc63 
>   src/slave/http.cpp d500fde22d01d2c66104b72ff39d9de4e3a411cd 
> 
> 
> Diff: https://reviews.apache.org/r/66510/diff/2/
> 
> 
> Testing
> ---
> 
> Tests can't be compiled after this change.
> See the next patch in the chain.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66464: Implemented operation status reconciliation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66464/#review200921
---




src/master/http.cpp
Line 1115 (original), -1113 (patched)


For the master operator API, we keep the `master->someMethod()` calls 
inside the call-specific handlers. See `Master::Http::listFiles()`, for example.

It's a small change, but I would suggest moving the 
`master->reconcileOperations()` call into `Master::Http::reconcileOperations()` 
for consistency.


- Greg Mann


On April 9, 2018, 9:30 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66464/
> ---
> 
> (Updated April 9, 2018, 9:30 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented operation status reconciliation.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 
> 
> 
> Diff: https://reviews.apache.org/r/66464/diff/3/
> 
> 
> Testing
> ---
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> https://reviews.apache.org/r/66468/ adds new tests.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Review Request 66561: Supported hdfs fetching in local puller.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66561/
---

Review request for mesos, Jie Yu and Qian Zhang.


Repository: mesos


Description
---

Supported hdfs fetching in local puller.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
4d2e4973a0d6c99dd3447a158003b4b09e2ba477 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
5ce49ac396b03e8b6d87601ecaa0691d88de21e3 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
d7d8987d493a37d20f32ddd254dc0c3b15159951 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
8b3f07f5027cb90d4b4ed401960494709d3eda5f 


Diff: https://reviews.apache.org/r/66561/diff/1/


Testing
---

make check


Thanks,

Gilbert Song

Review Request 66559: Made agent flag '--hadoop_home' as optional.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66559/
---

Review request for mesos, Jie Yu and Qian Zhang.


Repository: mesos


Description
---

Made agent flag '--hadoop_home' as optional.


Diffs
-

  docs/configuration/agent.md 962211a54177a54b3e38a93aad9af3c7a0f94ecb 
  docs/operator-http-api.md 10dcac83fa70da5760a5c231665d7498cc168622 
  src/slave/containerizer/fetcher.cpp 7de57c21c55bc145a78d401bb4224322501c040b 
  src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841 
  src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4 
  src/slave/http.cpp d500fde22d01d2c66104b72ff39d9de4e3a411cd 


Diff: https://reviews.apache.org/r/66559/diff/1/


Testing
---

make check


Thanks,

Gilbert Song

Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66562/
---

Review request for mesos, Jie Yu and Qian Zhang.


Repository: mesos


Description
---

Added test for local puller hdfs uri fetcher plugin.


Diffs
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
c664ff807583d587d94b0ab797330d5d3daf7657 


Diff: https://reviews.apache.org/r/66562/diff/1/


Testing
---

make check


Thanks,

Gilbert Song

Review Request 66560: Added a new agent flag .

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66560/
---

Review request for mesos, Jie Yu and Qian Zhang.


Repository: mesos


Description
---

Added a new agent flag .


Diffs
-

  docs/configuration/agent.md 962211a54177a54b3e38a93aad9af3c7a0f94ecb 
  src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841 
  src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4 


Diff: https://reviews.apache.org/r/66560/diff/1/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 66462: Added new operation states to be used for status reconciliation.

[Gaston Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66462/
---

(Updated April 11, 2018, 10:58 a.m.)


Review request for mesos and Greg Mann.


Changes
---

Improved comments.


Repository: mesos


Description
---

Added new operation states to be used for status reconciliation.


Diffs (updated)
-

  include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907 
  include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95 
  src/common/protobuf_utils.cpp 141a444534b776a2c90e2a0daf9727cd21e39080 
  src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 
  src/slave/slave.cpp e5d6c3fac5054a6b0a0b5b77abd850a35be6ccc5 


Diff: https://reviews.apache.org/r/66462/diff/3/

Changes: https://reviews.apache.org/r/66462/diff/2-3/


Testing
---

`sudo bin/mesos-tests` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 66554: Updated Web UI controllers to have one file per controller.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66554/#review200919
---



PASS: Mesos patch 66554 was successfully built and tested.

Reviews applied: `['66553', '66554']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66554

- Mesos Reviewbot Windows


On April 11, 2018, 8:23 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66554/
> ---
> 
> (Updated April 11, 2018, 8:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-8503
> https://issues.apache.org/jira/browse/MESOS-8503
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removes `controllers.js` and adds one file per controller. The shared
> functions are now in a file called `utils.js` and the linter has been
> updated to know about it. This gives more freedom to add or update
> each controller while making the structure of the UI more visible.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/webui/app/agents/agent-browse-controller.js PRE-CREATION 
>   src/webui/app/agents/agent-controller.js PRE-CREATION 
>   src/webui/app/agents/agent-executor-controller.js PRE-CREATION 
>   src/webui/app/agents/agent-framework-controller.js PRE-CREATION 
>   src/webui/app/agents/agent-task-and-executor-rerouter-controller.js 
> PRE-CREATION 
>   src/webui/app/agents/agents-controller.js PRE-CREATION 
>   src/webui/app/app.js 7de0899c2071c5127881fb725d0dd0246b10f849 
>   src/webui/app/controllers.js 66a4f2955a88fa44c3e5c717e9ce6b680050cc34 
>   src/webui/app/frameworks/framework-controller.js PRE-CREATION 
>   src/webui/app/frameworks/frameworks-controller.js PRE-CREATION 
>   src/webui/app/home.html  
>   src/webui/app/home/home-controller.js PRE-CREATION 
>   src/webui/app/maintenance/maintenance-controller.js PRE-CREATION 
>   src/webui/app/offers/offers-controller.js PRE-CREATION 
>   src/webui/app/roles/roles-controller.js PRE-CREATION 
>   src/webui/app/services.js  
>   src/webui/app/shared/main-controller.js PRE-CREATION 
>   src/webui/app/shared/utils.js PRE-CREATION 
>   src/webui/index.html 149d765429dc2211875783129da6c6b101f38ecf 
>   support/.eslintrc.js cd23ddebd2b40f795fa297e6decacada356a01f8 
> 
> 
> Diff: https://reviews.apache.org/r/66554/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> GTEST_FILTER="" make check -j4
> ```
> And tested manually.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 66468: Added tests for operation status reconciliation.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66468/#review200918
---


Ship it!




Ship It!

- Greg Mann


On April 10, 2018, 9:56 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66468/
> ---
> 
> (Updated April 10, 2018, 9:56 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for operation status reconciliation.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/tests/CMakeLists.txt ade5180f6e072112ad4836aa436e8545260d2ae6 
>   src/tests/operation_reconciliation_tests.cpp PRE-CREATION 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 2872f1aec1a7b94fc302a533f5ae9e1be9658087 
> 
> 
> Diff: https://reviews.apache.org/r/66468/diff/4/
> 
> 
> Testing
> ---
> 
> The new tests passed 1000 iterations on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66229/
---

(Updated April 11, 2018, 1:28 p.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
---

Implemented UPDATE_FRAMEWORK call.


Diffs (updated)
-

  src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 
  src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
  src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 
  src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 
  src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb 
  src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
  src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 


Diff: https://reviews.apache.org/r/66229/diff/4/

Changes: https://reviews.apache.org/r/66229/diff/3-4/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 66228: Added Call for updating framework info.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/
---

(Updated April 11, 2018, 1:28 p.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
---

Added Call for updating framework info.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
f6a780a7b75878b9e74402a28a25bb868f7ac36f 
  include/mesos/v1/scheduler/scheduler.proto 
25ebcfcb07cb4fb928dcfdc242bb6509c9080491 


Diff: https://reviews.apache.org/r/66228/diff/4/

Changes: https://reviews.apache.org/r/66228/diff/3-4/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 66511: Updated tests due to change of containerizer's `destroy()` return type.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66511/#review200913
---



PASS: Mesos patch 66511 was successfully built and tested.

Reviews applied: `['66510', '66511']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66511

- Mesos Reviewbot Windows


On April 9, 2018, 3:45 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66511/
> ---
> 
> (Updated April 9, 2018, 3:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian 
> Zhang.
> 
> 
> Bugs: MESOS-8710
> https://issues.apache.org/jira/browse/MESOS-8710
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As the return type of `destroy()` method has been changed, we need to
> update tests accordingly. This patch fixes all tests affected by the
> change.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp 97dde00bbd32d763c961e6ad2b323fb0ca3d774f 
>   src/tests/containerizer.hpp d6a69d6327018065453f8a6cb275d921d10c9198 
>   src/tests/containerizer.cpp 13a290ff60e359ceced95b20cb9db8c25cd59dbc 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> 09f7ea42dd833c36aefdb073517d809431c4f328 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> c198ecbac50ef4eb7ea243bebc17b65db7ce5cb7 
>   src/tests/containerizer/io_switchboard_tests.cpp 
> 8fdaa7ffb11d3cc48e1a2f4eaa086adda2837106 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 4fce8af7c89fd3b9166e1784203f99853624faef 
>   src/tests/containerizer/mock_containerizer.hpp 
> 01c617a55899a7125ca1dc80091aef5603419ee8 
> 
> 
> Diff: https://reviews.apache.org/r/66511/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 65334: Added quota limit to the master API protos.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65334/#review200912
---


Ship it!




- Meng Zhu


On March 9, 2018, 5:46 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65334/
> ---
> 
> (Updated March 9, 2018, 5:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Meng Zhu.
> 
> 
> Bugs: MESOS-8487
> https://issues.apache.org/jira/browse/MESOS-8487
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This introduces a `limit` in `QuotaInfo` and `QuotaRequest`.
> 
> A new `UPDATE_QUOTA` master call is added as a replacement of
> `SET_QUOTA` and `REMOVE_QUOTA`, which provides the new semantics
> of unset limit meaning "no limit" and unset guarantee meaning
> "no guarantee".
> 
> The new APIs are marked as experimental for now.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 6622e1b82861f380346f505eca326f7174dd8bd6 
>   include/mesos/quota/quota.proto f2ed6f555e1e7b0290fefa3e301c9bdbf550bd11 
>   include/mesos/v1/master/master.proto 
> 6034bd5af8ad764f625f9fe80be08b48707bbadb 
>   include/mesos/v1/quota/quota.proto 5dd772fee46f740b062827ed7c9704c26187cb12 
>   src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f 
>   src/master/validation.cpp 9254cd22e67d9aca53135701575fb0857ff6f7d6 
> 
> 
> Diff: https://reviews.apache.org/r/65334/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

[James Peach]

> On April 2, 2018, 8:30 p.m., Ilya Pronin wrote:
> > src/slave/containerizer/mesos/isolators/xfs/disk.cpp
> > Lines 393 (patched)
> > 
> >
> > This should be configurable.
> 
> Harold Dost wrote:
> So I had this configurable previously if you look at previous diff 
> revisions. I was asked to remove it.

Yep, I argued that we don't need it to be configurable in the first iteration. 
If we have a use case for configuring this, we can address it separately.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66001/#review200296
---


On April 4, 2018, 5:41 p.m., Harold Dost wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66001/
> ---
> 
> (Updated April 4, 2018, 5:41 p.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-6575
> https://issues.apache.org/jira/browse/MESOS-6575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> New Flags for disk/xfs isolator:
> - xfs_kill_containers - This will create a 10 MB buffer between the soft
>   and hard limits, and when the soft limit is exceeded it will
>   subsequently be killed.
> 
> Functionality
> - This by default disabled behavior allows for the `disk/xfs` isolator
>   to kill containers which surpass their limit.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.hpp 
> 07e68a777aefba4dd35066f2eb207bba7f199d83 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 
> 8d9f8f846866f9de377c59cb7fb311041283ba70 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp 
> e034133629a9c1cf58b776f8da2a93421332cee0 
>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp 
> 2708524add1ff693b616d4fb241c4a0a3070520b 
>   src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841 
>   src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 64c3e1c3f0bc435897626cb0a13bc19c7cb1a4fe 
> 
> 
> Diff: https://reviews.apache.org/r/66001/diff/12/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Harold Dost
> 
>

Review Request 66554: Updated Web UI controllers to have one file per controller.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66554/
---

Review request for mesos, Benjamin Mahler and Till Toenshoff.


Bugs: MESOS-8503
https://issues.apache.org/jira/browse/MESOS-8503


Repository: mesos


Description
---

Removes `controllers.js` and adds one file per controller. The shared
functions are now in a file called `utils.js` and the linter has been
updated to know about it. This gives more freedom to add or update
each controller while making the structure of the UI more visible.


Diffs
-

  src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
  src/webui/app/agents/agent-browse-controller.js PRE-CREATION 
  src/webui/app/agents/agent-controller.js PRE-CREATION 
  src/webui/app/agents/agent-executor-controller.js PRE-CREATION 
  src/webui/app/agents/agent-framework-controller.js PRE-CREATION 
  src/webui/app/agents/agent-task-and-executor-rerouter-controller.js 
PRE-CREATION 
  src/webui/app/agents/agents-controller.js PRE-CREATION 
  src/webui/app/app.js 7de0899c2071c5127881fb725d0dd0246b10f849 
  src/webui/app/controllers.js 66a4f2955a88fa44c3e5c717e9ce6b680050cc34 
  src/webui/app/frameworks/framework-controller.js PRE-CREATION 
  src/webui/app/frameworks/frameworks-controller.js PRE-CREATION 
  src/webui/app/home.html  
  src/webui/app/home/home-controller.js PRE-CREATION 
  src/webui/app/maintenance/maintenance-controller.js PRE-CREATION 
  src/webui/app/offers/offers-controller.js PRE-CREATION 
  src/webui/app/roles/roles-controller.js PRE-CREATION 
  src/webui/app/services.js  
  src/webui/app/shared/main-controller.js PRE-CREATION 
  src/webui/app/shared/utils.js PRE-CREATION 
  src/webui/index.html 149d765429dc2211875783129da6c6b101f38ecf 
  support/.eslintrc.js cd23ddebd2b40f795fa297e6decacada356a01f8 


Diff: https://reviews.apache.org/r/66554/diff/1/


Testing
---

```
GTEST_FILTER="" make check -j4
```
And tested manually.


Thanks,

Armand Grillet

Review Request 66553: Restructured Web UI.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66553/
---

Review request for mesos, Benjamin Mahler and Till Toenshoff.


Bugs: MESOS-8503
https://issues.apache.org/jira/browse/MESOS-8503


Repository: mesos


Description
---

Does not change the logic of the Web UI, only updates the structure
to have fewer nested directories and a more logical grouping of files.


Diffs
-

  src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
  src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 
  src/webui/master/static/agent.html  
  src/webui/master/static/agent_executor.html  
  src/webui/master/static/agent_framework.html  
  src/webui/master/static/agents.html  
  src/webui/master/static/browse.html  
  src/webui/master/static/css/bootstrap-3.3.6.min.css  
  src/webui/master/static/css/bootstrap-table-1.11.1.min.css  
  src/webui/master/static/css/mesos.css  
  src/webui/master/static/directives/pagination.html  
  src/webui/master/static/directives/tableHeader.html  
  src/webui/master/static/directives/timestamp.html  
  src/webui/master/static/fonts/glyphicons-halflings-regular.eot  
  src/webui/master/static/fonts/glyphicons-halflings-regular.svg 
94fb5490a2ed10b2c69a4a567a4fd2e4f706d841 
  src/webui/master/static/fonts/glyphicons-halflings-regular.ttf  
  src/webui/master/static/fonts/glyphicons-halflings-regular.woff  
  src/webui/master/static/fonts/glyphicons-halflings-regular.woff2  
  src/webui/master/static/framework.html  
  src/webui/master/static/frameworks.html  
  src/webui/master/static/home.html  
  src/webui/master/static/ico/favicon.ico  
  src/webui/master/static/img/loading.gif  
  src/webui/master/static/img/mesos_logo.png  
  src/webui/master/static/index.html 149d765429dc2211875783129da6c6b101f38ecf 
  src/webui/master/static/js/angular-1.2.32.min.js  
  src/webui/master/static/js/angular-route-1.2.32.min.js  
  src/webui/master/static/js/app.js 7de0899c2071c5127881fb725d0dd0246b10f849 
  src/webui/master/static/js/bootstrap-table-1.11.1.min.js  
  src/webui/master/static/js/clipboard-1.5.16.min.js  
  src/webui/master/static/js/controllers.js 
66a4f2955a88fa44c3e5c717e9ce6b680050cc34 
  src/webui/master/static/js/jquery-3.2.1.min.js  
  src/webui/master/static/js/jquery.pailer.js  
  src/webui/master/static/js/relative-date.js  
  src/webui/master/static/js/services.js  
  src/webui/master/static/js/ui-bootstrap-tpls-0.9.0.min.js  
  src/webui/master/static/js/underscore-1.4.3.min.js  
  src/webui/master/static/maintenance.html  
  src/webui/master/static/offers.html  
  src/webui/master/static/pailer.html 6710b7d4405d66171d07e88112c71bb4a30b29d4 
  src/webui/master/static/roles.html  


Diff: https://reviews.apache.org/r/66553/diff/1/


Testing
---

```
GTEST_FILTER="" make check -j4
```
And tested manually.


Thanks,

Armand Grillet

Re: Review Request 66511: Updated tests due to change of containerizer's `destroy()` return type.

[Andrei Budnik]

> On April 10, 2018, 6:28 p.m., Greg Mann wrote:
> > src/tests/containerizer.cpp
> > Lines 534-535 (original), 535-537 (patched)
> > 
> >
> > Indentation, here and elsewhere:
> > ```
> >   Future (
> >   TestContainerizerProcess::*destroy)(const ContainerID&) =
> > ::destroy;
> > ```

Fixed.


> On April 10, 2018, 6:28 p.m., Greg Mann wrote:
> > src/tests/containerizer/composing_containerizer_tests.cpp
> > Line 118 (original), 119 (patched)
> > 
> >
> > Is it not possible to simply use `None()` here and elsewhere?

Unfortunately, no. See https://reviews.apache.org/r/66510/#comment281728


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66511/#review200830
---


On April 9, 2018, 3:45 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66511/
> ---
> 
> (Updated April 9, 2018, 3:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian 
> Zhang.
> 
> 
> Bugs: MESOS-8710
> https://issues.apache.org/jira/browse/MESOS-8710
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As the return type of `destroy()` method has been changed, we need to
> update tests accordingly. This patch fixes all tests affected by the
> change.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp 97dde00bbd32d763c961e6ad2b323fb0ca3d774f 
>   src/tests/containerizer.hpp d6a69d6327018065453f8a6cb275d921d10c9198 
>   src/tests/containerizer.cpp 13a290ff60e359ceced95b20cb9db8c25cd59dbc 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> 09f7ea42dd833c36aefdb073517d809431c4f328 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> c198ecbac50ef4eb7ea243bebc17b65db7ce5cb7 
>   src/tests/containerizer/io_switchboard_tests.cpp 
> 8fdaa7ffb11d3cc48e1a2f4eaa086adda2837106 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 4fce8af7c89fd3b9166e1784203f99853624faef 
>   src/tests/containerizer/mock_containerizer.hpp 
> 01c617a55899a7125ca1dc80091aef5603419ee8 
> 
> 
> Diff: https://reviews.apache.org/r/66511/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66538: Added unit test slave recovery for default executor tests.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66538/#review200891
---




src/tests/default_executor_tests.cpp
Lines 1427-1430 (patched)


Why do we need to launch the executor using reserved resources? This seems 
not relevant to the target of this test. I think we can just launch both the 
executor and the task with unreserved resources.



src/tests/default_executor_tests.cpp
Lines 1481-1485 (patched)


So we use this as a signal that the default executor has re-registered with 
the agent, right? But I think this `TASK_RUNNING` status update will actually 
be resent by the agent (rather than the executor) after the agent re-registered 
with the master and even before the executor re-registered with the agent. So I 
think it might not be used as such signal.


- Qian Zhang


On April 11, 2018, 7:41 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66538/
> ---
> 
> (Updated April 11, 2018, 7:41 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: MESOS-8772
> https://issues.apache.org/jira/browse/MESOS-8772
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added unit test slave recovery for default executor tests.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 293dd20d882447401572835bd31e197faf76861b 
> 
> 
> Diff: https://reviews.apache.org/r/66538/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66546/#review200906
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66308', '66309', '66526', '66310', '66311', '66544', 
'66545', '66546']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66546

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66546/logs/mesos-tests-stdout.log):

```
[ RUN  ] ProtobufIOTest.RepeatedPtrField
[   OK ] ProtobufIOTest.RepeatedPtrField (5 ms)
[--] 3 tests from ProtobufIOTest (66 ms total)

[--] 4 tests from ResourceOffersTest
[ RUN  ] ResourceOffersTest.ResourcesGetReofferedAfterFrameworkStops
[   OK ] ResourceOffersTest.ResourcesGetReofferedAfterFrameworkStops (219 
ms)
[ RUN  ] ResourceOffersTest.ResourcesGetReofferedWhenUnused
[   OK ] ResourceOffersTest.ResourcesGetReofferedWhenUnused (217 ms)
[ RUN  ] ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError
[   OK ] ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError (228 ms)
[ RUN  ] ResourceOffersTest.Request
[   OK ] ResourceOffersTest.Request (88 ms)
[--] 4 tests from ResourceOffersTest (786 ms total)

[--] 4 tests from ResourceProviderManagerHttpApiTest
[ RUN  ] ResourceProviderManagerHttpApiTest.NoContentType
[   OK ] ResourceProviderManagerHttpApiTest.NoContentType (6 ms)
[ RUN  ] ResourceProviderManagerHttpApiTest.ValidJsonButInvalidProtobuf
[   OK ] ResourceProviderManagerHttpApiTest.ValidJsonButInvalidProtobuf (9 
ms)
[ RUN  ] 
ResourceProviderManagerHttpApiTest.ResourceProviderSubscribeDisconnect
[   OK ] 
ResourceProviderManagerHttpApiTest.ResourceProviderSubscribeDisconnect (240 ms)
[ RUN  ] ResourceProviderManagerHttpApiTest.Metrics
[   OK ] ResourceProviderManagerHttpApiTest.Metrics (283 ms)
[--] 4 tests from ResourceProviderManagerHttpApiTest (565 ms total)

[--] 2 tests from ResourceProviderRegistrarTest
[ RUN  ] ResourceProviderRegistrarTest.AgentRegistrar
d:\dcos\mesos\mesos\src\tests\resource_provider_manager_tests.cpp(846): error: 
Failed to wait 15secs for admitResourceProvider1
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66546/logs/mesos-tests-stderr.log):

```
I0411 13:35:46.470496 22996 master.cpp:1295] Agent 
b06ec2bf-76ea-4418-ad7b-a3e511926895-S0 at slave(95)@10.3.1.8:61057 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0411 13:35:46.470496 22996 master.cpp:3286] Disconnecting agent 
b06ec2bf-76ea-4418-ad7b-a3e511926895-S0 at slave(95)@10.3.1.8:61057 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0411 13:35:46.470496 22996 master.cpp:3305] Deactivating agent 
b06ec2bf-76ea-4418-ad7b-a3e511926895-S0 at slave(95)@10.3.1.8:61057 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0411 13:35:46.470496 14112 hierarchical.cpp:766] Agent 
b06ec2bf-76ea-4418-ad7b-a3e511926895-S0 deactivated
I0411 13:35:46.492497 16128 master.cpp:1137] Master terminating
I0411 13:35:46.495492  9888 hierarchical.cpp:609] Removed agent 
b06ec2bf-76ea-4418-ad7b-a3e511926895-S0
[libprotobuf FATAL 
d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\message_lite.cc:281]
 CHECK failed: IsInitialized(): Can't serialize message of type 
"mesos.resource_provider.registry.Registry" because it is missing required 
fields: resource_providers[0].info.type, resource_providers[0].info.name
*** Check failure stack trace: ***
@   7FF642FF0DEB  google::LogMessage::Fail
@   7FF642FF0CF1  google::LogMessage::SendToLog
@   7FF642FF04D7  google::LogMessage::Flush
@   7FF642FF2011  google::LogMessageFatal::~LogMessageFatal
@   7FF6444BE95E  `process::ProcessManager::resume'::`1'::catch$11
@   7FFBC01D14F0  __C_specific_handler
@   7FFBC01D53FA  __BuildCatchObjectHelper
@   7FFBCFEE4203  RtlCaptureContext
@   7FF6429B1C20  process::ProcessManager::resume
@   7FF642ABCD61   ?? 
@   7FF6429F9D90  
std::_Invoker_functor::_Call< >
@   7FF642A501C0  std::invoke< 
>
@   7FF642A08A3C  
std::_LaunchPad,std::default_delete > 
> >::_Execute<0>
@   7FF642B0813A  
std::_LaunchPad,std::default_delete > 
> >::_Run
@   7FF642AF4B98  
std::_LaunchPad,std::default_delete > 
> >::_Go
@   7FF642ADCDDD  std::_Pad::_Call_func
@   7FFBB65F11E8  _register_onexit_function
@   7FFBB65F0E01  _register_onexit_function

Re: Review Request 66510: Unified return type of `wait` and `destroy` containerizer methods.

[Andrei Budnik]

> On April 10, 2018, 6:15 p.m., Greg Mann wrote:
> > src/slave/containerizer/composing.cpp
> > Line 376 (original), 378 (patched)
> > 
> >
> > Is it not possible to use `None()` here instead of 
> > `Option::none()`? Here and elsewhere.

I'm getting compilation error with `None()`. Moreover, I can't find 
`set(None())` pattern, but I found one place where we use 
`set(Option::none())`: 
https://github.com/apache/mesos/blob/3dcd225dbb817da676ae57f4f8871650ece5a0b8/3rdparty/libprocess/src/reap.cpp#L122


> On April 10, 2018, 6:15 p.m., Greg Mann wrote:
> > src/slave/containerizer/mesos/containerizer.cpp
> > Line 2335 (original), 2336 (patched)
> > 
> >
> > Hmm I think it might be a bit more readable here and elsewhere to 
> > continue using a trivial lambda which returns a default-constructed 
> > `ContainerTermination`, WDYT?
> > 
> > ```
> > .then([]() { return ContainerTermination(); });
> > ```

`Option::some` is a wrapper for `ContainerTermination` 
type: 
https://github.com/apache/mesos/blob/3dcd225dbb817da676ae57f4f8871650ece5a0b8/3rdparty/stout/include/stout/option.hpp#L36-L39
So, this code returns a wrapped termination variable instead of constructing a 
new one.

BTW, the shortest equivalent code would be:
```
.then([](const Future& termination) -> 
Option {
  return termination.get();
});
```
which doesn't look simpler to me.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66510/#review200828
---


On April 9, 2018, 3:44 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66510/
> ---
> 
> (Updated April 9, 2018, 3:44 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian 
> Zhang.
> 
> 
> Bugs: MESOS-8706
> https://issues.apache.org/jira/browse/MESOS-8706
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch changes the return type of `destroy()` method for all
> containerizers. As a result, `destroy()` and `wait()` methods have
> got the same signature and return type. In fact, all these methods
> depend on the same container termination promise, so this unification
> makes both containerizer interface and internal logic more consistent.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.hpp 
> 1221d9b61b7cfbdbaa560dbafb0158225331ed6d 
>   src/slave/containerizer/composing.cpp 
> cd840a5409023d32701329bf37806f2e7ed6ffd2 
>   src/slave/containerizer/containerizer.hpp 
> 836283aa8aa827459558d567e090a230c32351ed 
>   src/slave/containerizer/docker.hpp f1b56c8edced17e9786c86adb9b92c829ed81635 
>   src/slave/containerizer/docker.cpp 31d64a7ea2a331a084c0f1707b82e938dfe6390f 
>   src/slave/containerizer/mesos/containerizer.hpp 
> cba4ed2e20622070b46071f35907d8b32c25b2fc 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 7473a871e626833733f39375b778aff70529dc63 
>   src/slave/http.cpp d500fde22d01d2c66104b72ff39d9de4e3a411cd 
> 
> 
> Diff: https://reviews.apache.org/r/66510/diff/1/
> 
> 
> Testing
> ---
> 
> Tests can't be compiled after this change.
> See the next patch in the chain.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66545/#review200903
---




src/resource_provider/manager.cpp
Lines 668 (patched)


Shouldn't this be `false` here? If there's no registrar to admit a resource 
provider to, a resource provider cannot be admitted.



src/resource_provider/manager.cpp
Lines 679-683 (patched)


We should set this event handler before setting `admitResourceProvider` to 
any value, i.e. set this directly after instanciation.



src/resource_provider/manager.cpp
Line 662 (original), 691-697 (patched)


This is only checking the `FAILED` state, but not other failure states, 
e.g. `DISCARDED`. How about checking for `!admitResourceProvider.isReady()` 
here?


- Jan Schlicht


On April 11, 2018, 11:23 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66545/
> ---
> 
> (Updated April 11, 2018, 11:23 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8402
> https://issues.apache.org/jira/browse/MESOS-8402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added admitted resource providers to the manager's registry.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
>   src/resource_provider/registrar.hpp 
> 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 
>   src/resource_provider/registrar.cpp 
> 92ef9aecb1e93d10f46e53984391558f9901a60b 
>   src/resource_provider/registry.proto 
> 14bd433ef056f8891e9a38153fdb06c39cee8f62 
>   src/tests/resource_provider_manager_tests.cpp 
> c52541bf130ccf4795b989b53331176a64a097ea 
> 
> 
> Diff: https://reviews.apache.org/r/66545/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review200901
---



Bad patch!

Reviews applied: [63370, 63368, 63366, 65462, 65461, 63367]

Failed command: python support/apply-reviews.py -n -r 63366

Error:
2018-04-11 11:25:47 URL:https://reviews.apache.org/r/63366/diff/raw/ 
[14586/14586] -> "63366.patch" [1]
error: missing binary patch data for '3rdparty/jemalloc-5.0.1.tar.bz2'
error: binary patch does not apply to '3rdparty/jemalloc-5.0.1.tar.bz2'
error: 3rdparty/jemalloc-5.0.1.tar.bz2: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/22158/console

- Mesos Reviewbot


On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> ---
> 
> (Updated Feb. 21, 2018, 10:41 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
> 
> 
> Diffs
> -
> 
>   src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d 
>   src/master/flags.cpp dbb35befd612f4be1019293c1889d19296118d07 
>   src/master/main.cpp 3def0f29e4d580306d2ecef033a37aad5333c8ea 
>   src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841 
>   src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4 
>   src/slave/main.cpp dcc944840d4e4e611e8ed1b0110b8f1bb189bde9 
> 
> 
> Diff: https://reviews.apache.org/r/63370/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64211/#review200900
---



PASS: Mesos patch 64211 was successfully built and tested.

Reviews applied: `['65585', '65705', '64211']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64211

- Mesos Reviewbot Windows


On March 24, 2018, 11:39 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64211/
> ---
> 
> (Updated March 24, 2018, 11:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> An update of the discarded review /r/52543.
> 
> Works with Autotools and CMake.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6702f02245e3867c06bbd9efbbf4e3b961a7d9aa 
>   cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c 
>   configure.ac f0f901f2e565352c2804cae7b2ac255da81ce45d 
>   docs/configuration/cmake.md 1e34657ea55fa324f65f865f7d0a67084c6719d9 
>   src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
>   src/Makefile.am 9f4b6d369a23af337e2384e52e3e41f4017df38a 
>   src/python/cli_new/CMakeLists.txt PRE-CREATION 
>   src/python/cli_new/tests/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64211/diff/17/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25.
> 
> For Autotools:
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ ../configure --enable-new-cli --disable-java --disable-python
> $ make check
> ```
> 
> For CMake:
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> `build/src/cli` was as expected, and that `build/src/mesos` was correctly 
> running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66546/
---

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-7558
https://issues.apache.org/jira/browse/MESOS-7558


Repository: mesos


Description
---

This patch adds a check to the resource provider manager's subscribe
functionality making sure that any the ID sent by a resubscribing
resource provider corresponds to some previously known resource
provider.

This not only serves as convenient validation of user-provided data,
but also makes sure that the internal state of the resource provider
manager remains consistent.


Diffs
-

  src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
  src/tests/resource_provider_manager_tests.cpp 
c52541bf130ccf4795b989b53331176a64a097ea 


Diff: https://reviews.apache.org/r/66546/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Review Request 66544: Remembered recovered and subscribed providers in ephemeral state.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66544/
---

Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht.


Bugs: MESOS-8402
https://issues.apache.org/jira/browse/MESOS-8402


Repository: mesos


Description
---

This patch adds a data structure to bookkeep subscribed and recovered
resource providers in the ephemeral state of the resource provider
manager.


Diffs
-

  src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 


Diff: https://reviews.apache.org/r/66544/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Review Request 66545: Added admitted resource providers to the manager's registry.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66545/
---

Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht.


Bugs: MESOS-8402
https://issues.apache.org/jira/browse/MESOS-8402


Repository: mesos


Description
---

Added admitted resource providers to the manager's registry.


Diffs
-

  src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
  src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 
  src/resource_provider/registrar.cpp 92ef9aecb1e93d10f46e53984391558f9901a60b 
  src/resource_provider/registry.proto 14bd433ef056f8891e9a38153fdb06c39cee8f62 
  src/tests/resource_provider_manager_tests.cpp 
c52541bf130ccf4795b989b53331176a64a097ea 


Diff: https://reviews.apache.org/r/66545/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 66311: Implement recovery of resource provider manager.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66311/#review200898
---



PASS: Mesos patch 66311 was successfully built and tested.

Reviews applied: `['66308', '66309', '66526', '66310', '66311']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66311

- Mesos Reviewbot Windows


On April 11, 2018, 7:30 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66311/
> ---
> 
> (Updated April 11, 2018, 7:30 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8735
> https://issues.apache.org/jira/browse/MESOS-8735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adjusts the control flow of the resource provider manager
> so that we can in the future make use of persisted resource provider
> information.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
>   src/resource_provider/registrar.hpp 
> 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 
>   src/resource_provider/registrar.cpp 
> 92ef9aecb1e93d10f46e53984391558f9901a60b 
>   src/tests/resource_provider_manager_tests.cpp 
> c52541bf130ccf4795b989b53331176a64a097ea 
> 
> 
> Diff: https://reviews.apache.org/r/66311/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 66311: Implement recovery of resource provider manager.

[Benjamin Bannier]

> On April 10, 2018, 3:05 nachm., Jan Schlicht wrote:
> > src/resource_provider/registrar.cpp
> > Lines 97 (patched)
> > 
> >
> > `Registry` is in scope here and used without the namespace in other 
> > parts of this unit. Let's be consistent and drop the namespace here and 
> > below.
> 
> Benjamin Bannier wrote:
> See above. Dropping.
> 
> Benjamin Bannier wrote:
> Misread, reopening.

Fixed for a number `recover`s below as well.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66311/#review200734
---


On April 11, 2018, 9:30 vorm., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66311/
> ---
> 
> (Updated April 11, 2018, 9:30 vorm.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8735
> https://issues.apache.org/jira/browse/MESOS-8735
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adjusts the control flow of the resource provider manager
> so that we can in the future make use of persisted resource provider
> information.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
>   src/resource_provider/registrar.hpp 
> 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 
>   src/resource_provider/registrar.cpp 
> 92ef9aecb1e93d10f46e53984391558f9901a60b 
>   src/tests/resource_provider_manager_tests.cpp 
> c52541bf130ccf4795b989b53331176a64a097ea 
> 
> 
> Diff: https://reviews.apache.org/r/66311/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63370/#review200894
---



FAIL: Failed to apply the dependent review: 63366.

Failed command: `python.exe .\support\apply-reviews.py -n -r 63366`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63370

Relevant logs:

- 
[apply-review-63366-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63370/logs/apply-review-63366-stdout.log):

```
error: missing binary patch data for '3rdparty/jemalloc-5.0.1.tar.bz2'
error: binary patch does not apply to '3rdparty/jemalloc-5.0.1.tar.bz2'
error: 3rdparty/jemalloc-5.0.1.tar.bz2: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 21, 2018, 10:41 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63370/
> ---
> 
> (Updated Feb. 21, 2018, 10:41 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This flag allows explicit disabling of the memory profiler
> endpoint in the master and agent binaries.
> 
> 
> Diffs
> -
> 
>   src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d 
>   src/master/flags.cpp dbb35befd612f4be1019293c1889d19296118d07 
>   src/master/main.cpp 3def0f29e4d580306d2ecef033a37aad5333c8ea 
>   src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841 
>   src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4 
>   src/slave/main.cpp dcc944840d4e4e611e8ed1b0110b8f1bb189bde9 
> 
> 
> Diff: https://reviews.apache.org/r/63370/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 66311: Implement recovery of resource provider manager.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66311/
---

(Updated April 11, 2018, 9:30 a.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Changes
---

Addressed issues raised by Jan.


Bugs: MESOS-8735
https://issues.apache.org/jira/browse/MESOS-8735


Repository: mesos


Description
---

This patch adjusts the control flow of the resource provider manager
so that we can in the future make use of persisted resource provider
information.


Diffs (updated)
-

  src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
  src/resource_provider/registrar.hpp 39f45b0a2a7c35bfe72a9305f5248409e4a3ef45 
  src/resource_provider/registrar.cpp 92ef9aecb1e93d10f46e53984391558f9901a60b 
  src/tests/resource_provider_manager_tests.cpp 
c52541bf130ccf4795b989b53331176a64a097ea 


Diff: https://reviews.apache.org/r/66311/diff/4/

Changes: https://reviews.apache.org/r/66311/diff/3-4/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 66474: Updated minimum supported Linux kernel version.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66474/#review200890
---


Ship it!




Ship It!

- Gilbert Song


On April 5, 2018, 5:21 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66474/
> ---
> 
> (Updated April 5, 2018, 5:21 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Gilbert 
> Song, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implementation of `freezer` cgroup, which supports nested containers,
> was introduced in 2.6.28. This patch updates documentation.
> 
> 
> Diffs
> -
> 
>   docs/building.md 909d3ca265ff176cfc5201bd552e2e0fdb378b28 
> 
> 
> Diff: https://reviews.apache.org/r/66474/diff/1/
> 
> 
> Testing
> ---
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>