Review Request 67872: Added a stout helper to percent-encode strings.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67872/
---

Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Gastón Kleiman.


Repository: mesos


Description
---

Added a stout helper to percent-encode strings.


Diffs
-

  3rdparty/stout/Makefile.am 44710c21d3c5a2bc2309b0fe10419712523d3187 
  3rdparty/stout/include/stout/percent_encode.hpp PRE-CREATION 
  3rdparty/stout/tests/percent_encode_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/67872/diff/1/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67813: Added per-framework metrics for task states.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67813/
---

(Updated July 10, 2018, 6:29 a.m.)


Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, 
Gilbert Song, and Vinod Kone.


Bugs: MESOS-8847
https://issues.apache.org/jira/browse/MESOS-8847


Repository: mesos


Description
---

Added per-framework metrics for task states.


Diffs (updated)
-

  src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
  src/master/master.cpp 0c0d6ca375b806a02625261f7e272a126bc4debe 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/67813/diff/4/

Changes: https://reviews.apache.org/r/67813/diff/3-4/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 67871: Optimized the generation of metrics snapshots.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67871/#review205896
---



FAIL: Failed to apply the dependent review: 67813.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67813`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1894/mesos-review-67871

Relevant logs:

- 
[apply-review-67813-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1894/mesos-review-67871/logs/apply-review-67813-stdout.log):

```
error: patch failed: src/master/metrics.cpp:630
error: src/master/metrics.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On July 10, 2018, 6:21 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67871/
> ---
> 
> (Updated July 10, 2018, 6:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Optimized the generation of metrics snapshots.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp 
> f9b72029b2c85826c91b1d7656b0af94dc87010c 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> 4883c9acaa0cc568e27944661a8208f7b2a356a1 
> 
> 
> Diff: https://reviews.apache.org/r/67871/diff/1/
> 
> 
> Testing
> ---
> 
> WITH per-framework metrics, BEFORE optimizations:
> ```
> [ RUN  ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/0
> Test setup: 1 agents with a total of 105 frameworks
> unversioned /metrics/snapshot' response took 157.1449ms
> v1 'master::call::GetMetrics' application/x-protobuf response took 
> 152.599692ms
> v1 'master::call::GetMetrics' application/json response took 198.918334ms
> [   OK ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/0
>  (835 ms)
> [ RUN  ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/1
> Test setup: 1 agents with a total of 1005 frameworks
> unversioned /metrics/snapshot' response took 1.319444199secs
> v1 'master::call::GetMetrics' application/x-protobuf response took 
> 1.257644596secs
> v1 'master::call::GetMetrics' application/json response took 1.527225235secs
> [   OK ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/1
>  (6553 ms)
> [ RUN  ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/2
> Test setup: 1 agents with a total of 10005 frameworks
> unversioned /metrics/snapshot' response took 15.479365874secs
> v1 'master::call::GetMetrics' application/x-protobuf response took 
> 14.542866983secs
> v1 'master::call::GetMetrics' application/json response took 18.05492789secs
> [   OK ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/2
>  (75455 ms)
> [ RUN  ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/3
> Test setup: 1 agents with a total of 20005 frameworks
> unversioned /metrics/snapshot' response took 31.908301664secs
> v1 'master::call::GetMetrics' application/x-protobuf response took 
> 32.128689785secs
> v1 'master::call::GetMetrics' application/json response took 33.669376185secs
> [   OK ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/3
>  (150440 ms)
> ```
> 
> WITH per-framework metrics, AFTER optimizations:
> ```
> [ RUN  ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/0
> Test setup: 1 agents with a total of 105 frameworks
> unversioned /metrics/snapshot' response took 104.577895ms
> v1 'master::call::GetMetrics' application/x-protobuf response took 74.262533ms
> v1 'master::call::GetMetrics' application/json response took 100.218618ms
> [   OK ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/0
>  (562 ms)
> [ RUN  ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/1
> Test setup: 1 agents with a total of 1005 frameworks
> unversioned /metrics/snapshot' response took 921.175877ms
> v1 'master::call::GetMetrics' application/x-protobuf response took 
> 780.277639ms
> v1 'master::call::GetMetrics' application/json response took 1.16865secs
> [   OK ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/1
>  (5424 ms)
> [ RUN  ] 
> AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/2
> Test setup: 1 agents with a total of 10005 frameworks
> unversioned /metrics/snapshot' response took 10.2413387secs
> v1 'master::call::GetMetrics' application/x-proto

Re: Review Request 67870: Fixed an incorrect type in the master's metrics code.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/
---

(Updated July 10, 2018, 6:23 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.


Repository: mesos


Description
---

Fixed an incorrect type in the master's metrics code.


Diffs (updated)
-

  src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 


Diff: https://reviews.apache.org/r/67870/diff/2/

Changes: https://reviews.apache.org/r/67870/diff/1-2/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67871: Optimized the generation of metrics snapshots.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67871/
---

(Updated July 10, 2018, 6:21 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.


Repository: mesos


Description
---

Optimized the generation of metrics snapshots.


Diffs
-

  3rdparty/libprocess/include/process/metrics/metrics.hpp 
f9b72029b2c85826c91b1d7656b0af94dc87010c 
  3rdparty/libprocess/src/metrics/metrics.cpp 
4883c9acaa0cc568e27944661a8208f7b2a356a1 


Diff: https://reviews.apache.org/r/67871/diff/1/


Testing (updated)
---

WITH per-framework metrics, BEFORE optimizations:
```
[ RUN  ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/0
Test setup: 1 agents with a total of 105 frameworks
unversioned /metrics/snapshot' response took 157.1449ms
v1 'master::call::GetMetrics' application/x-protobuf response took 152.599692ms
v1 'master::call::GetMetrics' application/json response took 198.918334ms
[   OK ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/0
 (835 ms)
[ RUN  ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/1
Test setup: 1 agents with a total of 1005 frameworks
unversioned /metrics/snapshot' response took 1.319444199secs
v1 'master::call::GetMetrics' application/x-protobuf response took 
1.257644596secs
v1 'master::call::GetMetrics' application/json response took 1.527225235secs
[   OK ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/1
 (6553 ms)
[ RUN  ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/2
Test setup: 1 agents with a total of 10005 frameworks
unversioned /metrics/snapshot' response took 15.479365874secs
v1 'master::call::GetMetrics' application/x-protobuf response took 
14.542866983secs
v1 'master::call::GetMetrics' application/json response took 18.05492789secs
[   OK ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/2
 (75455 ms)
[ RUN  ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/3
Test setup: 1 agents with a total of 20005 frameworks
unversioned /metrics/snapshot' response took 31.908301664secs
v1 'master::call::GetMetrics' application/x-protobuf response took 
32.128689785secs
v1 'master::call::GetMetrics' application/json response took 33.669376185secs
[   OK ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/3
 (150440 ms)
```

WITH per-framework metrics, AFTER optimizations:
```
[ RUN  ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/0
Test setup: 1 agents with a total of 105 frameworks
unversioned /metrics/snapshot' response took 104.577895ms
v1 'master::call::GetMetrics' application/x-protobuf response took 74.262533ms
v1 'master::call::GetMetrics' application/json response took 100.218618ms
[   OK ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/0
 (562 ms)
[ RUN  ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/1
Test setup: 1 agents with a total of 1005 frameworks
unversioned /metrics/snapshot' response took 921.175877ms
v1 'master::call::GetMetrics' application/x-protobuf response took 780.277639ms
v1 'master::call::GetMetrics' application/json response took 1.16865secs
[   OK ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/1
 (5424 ms)
[ RUN  ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/2
Test setup: 1 agents with a total of 10005 frameworks
unversioned /metrics/snapshot' response took 10.2413387secs
v1 'master::call::GetMetrics' application/x-protobuf response took 
9.407992945secs
v1 'master::call::GetMetrics' application/json response took 10.582584848secs
[   OK ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/2
 (57206 ms)
[ RUN  ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/3
Test setup: 1 agents with a total of 20005 frameworks
unversioned /metrics/snapshot' response took 19.930542079secs
v1 'master::call::GetMetrics' application/x-protobuf response took 
20.318739763secs
v1 'master::call::GetMetrics' application/json response took 22.853630899secs
[   OK ] 
AgentFrameworkTaskCountContentType/MasterMetricsQuery_BENCHMARK_Test.GetMetrics/3
 (116363 ms)
```


Thanks,

Greg Mann

Review Request 67871: Optimized the generation of metrics snapshots.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67871/
---

Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.


Repository: mesos


Description
---

Optimized the generation of metrics snapshots.


Diffs
-

  3rdparty/libprocess/include/process/metrics/metrics.hpp 
f9b72029b2c85826c91b1d7656b0af94dc87010c 
  3rdparty/libprocess/src/metrics/metrics.cpp 
4883c9acaa0cc568e27944661a8208f7b2a356a1 


Diff: https://reviews.apache.org/r/67871/diff/1/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67870: Fixed an incorrect type in the master's metrics code.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/#review205895
---



FAIL: Failed to apply the dependent review: 67813.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67813`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1893/mesos-review-67870

Relevant logs:

- 
[apply-review-67813-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1893/mesos-review-67870/logs/apply-review-67813-stdout.log):

```
error: patch failed: src/master/metrics.cpp:630
error: src/master/metrics.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On July 10, 2018, 6:01 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67870/
> ---
> 
> (Updated July 10, 2018, 6:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed an incorrect type in the master's metrics code.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 
> 
> 
> Diff: https://reviews.apache.org/r/67870/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 67870: Fixed an incorrect type in the master's metrics code.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67870/
---

Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.


Repository: mesos


Description
---

Fixed an incorrect type in the master's metrics code.


Diffs
-

  src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 


Diff: https://reviews.apache.org/r/67870/diff/1/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67861: Updated json parsing to avoid copying between picojson and stout JSON.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67861/#review205893
---




3rdparty/stout/include/stout/json.hpp
Lines 343-347 (original), 352-377 (patched)


While we're here, we could also replace these with the pointer versions of 
`boost::get`. We might get some better performance: https://godbolt.org/g/B84cLb


- Michael Park


On July 9, 2018, 6:40 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67861/
> ---
> 
> (Updated July 9, 2018, 6:40 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When looking at some profiling data, it looks as though we approximately
> double the cost of JSON parsing due to having to convert from
> `picojson::value` to `JSON::Value`.
> 
> Michael Park pointed me to the parsing "context" that's customizable in
> picojson. This patch replaces our conversion with a parsing context in
> order to parse directly into JSON::Value and avoid copying.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/json.hpp 
> c374e29829e4ea02ab3a8494b6ab28c166579516 
> 
> 
> Diff: https://reviews.apache.org/r/67861/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 67869: Add use of `override` to the Mesos C++ style guide.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67869/#review205892
---



PASS: Mesos patch 67869 was successfully built and tested.

Reviews applied: `['67866', '67867', '67868', '67869']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1892/mesos-review-67869

- Mesos Reviewbot Windows


On July 9, 2018, 8:36 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67869/
> ---
> 
> (Updated July 9, 2018, 8:36 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, 
> Mesos Reviewbot, Till Toenshoff, and Zhitao Li.
> 
> 
> Bugs: MESOS-9065
> https://issues.apache.org/jira/browse/MESOS-9065
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add an explicit guideline to the Mesos C++ style guide that the use of
> `override` keyword is required. Update cpplint and clang-tidy tooling
> to encourage this.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 80a1af318984d47bdfa641aa12e28963d3183fea 
>   support/clang-tidy fcffb39089573a708dc3f2052f639a1a3621040d 
>   support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 
> 
> 
> Diff: https://reviews.apache.org/r/67869/diff/1/
> 
> 
> Testing
> ---
> 
> Manual. The `cpplint` change doesn't appear to enforce the use of `override`.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67861: Updated json parsing to avoid copying between picojson and stout JSON.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67861/#review205891
---




3rdparty/stout/include/stout/json.hpp
Line 855 (original), 892 (patched)


Perhaps leave a small comment + a pointer to 
https://github.com/kazuho/picojson/blob/v1.3.0/picojson.h#L820-L870 here.


- Michael Park


On July 9, 2018, 6:40 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67861/
> ---
> 
> (Updated July 9, 2018, 6:40 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When looking at some profiling data, it looks as though we approximately
> double the cost of JSON parsing due to having to convert from
> `picojson::value` to `JSON::Value`.
> 
> Michael Park pointed me to the parsing "context" that's customizable in
> picojson. This patch replaces our conversion with a parsing context in
> order to parse directly into JSON::Value and avoid copying.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/json.hpp 
> c374e29829e4ea02ab3a8494b6ab28c166579516 
> 
> 
> Diff: https://reviews.apache.org/r/67861/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 67861: Updated json parsing to avoid copying between picojson and stout JSON.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67861/#review205890
---


Ship it!




Ship It!

- Michael Park


On July 9, 2018, 6:40 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67861/
> ---
> 
> (Updated July 9, 2018, 6:40 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When looking at some profiling data, it looks as though we approximately
> double the cost of JSON parsing due to having to convert from
> `picojson::value` to `JSON::Value`.
> 
> Michael Park pointed me to the parsing "context" that's customizable in
> picojson. This patch replaces our conversion with a parsing context in
> order to parse directly into JSON::Value and avoid copying.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/json.hpp 
> c374e29829e4ea02ab3a8494b6ab28c166579516 
> 
> 
> Diff: https://reviews.apache.org/r/67861/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 67864: Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/#review205889
---



PASS: Mesos patch 67864 was successfully built and tested.

Reviews applied: `['65995', '65975', '65976', '65640', '67663', '67664', 
'67665', '67666', '67667', '67668', '67669', '67670', '67779', '67863', 
'67864']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1891/mesos-review-67864

- Mesos Reviewbot Windows


On July 10, 2018, 3:12 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67864/
> ---
> 
> (Updated July 10, 2018, 3:12 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9066
> https://issues.apache.org/jira/browse/MESOS-9066
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.
> 
> 
> Diffs
> -
> 
>   src/examples/test_csi_user_framework.cpp 
> 91212e990af711633f7b890b0c9e10587f9efe7c 
>   src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692 
>   src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb 
>   src/tests/master_validation_tests.cpp 
> 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd 
>   src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe 
>   src/tests/operation_reconciliation_tests.cpp 
> d0bc73bfbf304833cebb76c538cb2c5552813838 
>   src/tests/persistent_volume_tests.cpp 
> 43f31b2e613666a989c205b8543ef1cde484d93c 
>   src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6 
>   src/tests/resource_provider_manager_tests.cpp 
> cf15e5a1f26f0895865b53931298f61ce5cfccff 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 1afe8a8e0413ef225e952cd9cd6376e5d82774e5 
> 
> 
> Diff: https://reviews.apache.org/r/67864/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 67861: Updated json parsing to avoid copying between picojson and stout JSON.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67861/#review205887
---



PASS: Mesos patch 67861 was successfully built and tested.

Reviews applied: `['67861']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1890/mesos-review-67861

- Mesos Reviewbot Windows


On July 10, 2018, 1:40 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67861/
> ---
> 
> (Updated July 10, 2018, 1:40 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When looking at some profiling data, it looks as though we approximately
> double the cost of JSON parsing due to having to convert from
> `picojson::value` to `JSON::Value`.
> 
> Michael Park pointed me to the parsing "context" that's customizable in
> picojson. This patch replaces our conversion with a parsing context in
> order to parse directly into JSON::Value and avoid copying.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/json.hpp 
> c374e29829e4ea02ab3a8494b6ab28c166579516 
> 
> 
> Diff: https://reviews.apache.org/r/67861/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 67669: Allow resources to be removed when updating the sorter.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67669/
---

(Updated July 10, 2018, 3:39 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Meng 
Zhu.


Changes
---

Fixed a bug in the test.


Bugs: MESOS-8995
https://issues.apache.org/jira/browse/MESOS-8995


Repository: mesos


Description
---

This patch allows the allocator to remove resources when calling
`Sorter::update`, so Mesos can remove resources that are no longer
available through resource conversions.

An example usage is that we can make `DESTROY_VOLUME` to convert a
volume with a stale profile to an empty resource, so the disk space
will disappear instead of being offered out to other frameworks.


Diffs (updated)
-

  CHANGELOG 4aef45a28c2127587b003dc0a5e2855ac108e6ff 
  docs/upgrades.md ef89a7250fba002b0b41030f19c78268190d2671 
  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/sorter/drf/sorter.cpp 
755a36ead42a91053c881fc46dc6acb39c819cac 
  src/master/allocator/sorter/sorter.hpp 
e5e86513dc4023d9c471753897635923c6c9203f 
  src/tests/sorter_tests.cpp 266a9e72597b3aadc9756f61736c0adf0b1a5831 


Diff: https://reviews.apache.org/r/67669/diff/4/

Changes: https://reviews.apache.org/r/67669/diff/3-4/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Review Request 67869: Add use of `override` to the Mesos C++ style guide.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67869/
---

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, 
Mesos Reviewbot, Till Toenshoff, and Zhitao Li.


Bugs: MESOS-9065
https://issues.apache.org/jira/browse/MESOS-9065


Repository: mesos


Description
---

Add an explicit guideline to the Mesos C++ style guide that the use of
`override` keyword is required. Update cpplint and clang-tidy tooling
to encourage this.


Diffs
-

  docs/c++-style-guide.md 80a1af318984d47bdfa641aa12e28963d3183fea 
  support/clang-tidy fcffb39089573a708dc3f2052f639a1a3621040d 
  support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 


Diff: https://reviews.apache.org/r/67869/diff/1/


Testing
---

Manual. The `cpplint` change doesn't appear to enforce the use of `override`.


Thanks,

James Peach

Review Request 67868: Apply the `override` keyword to Mesos.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67868/
---

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, 
Mesos Reviewbot, Till Toenshoff, and Zhitao Li.


Bugs: MESOS-9065
https://issues.apache.org/jira/browse/MESOS-9065


Repository: mesos


Description
---

Apply the `override` keyword to Mesos.


Diffs
-

  include/mesos/executor.hpp 6a9e6fc6b1ab94be2ade9a96de4fb11364b46a13 
  include/mesos/scheduler.hpp d4cc96e86b27cfe2e3a3de448fd0f5e06b1564df 
  include/mesos/state/in_memory.hpp 3fcf4620b7252c632ca9416d06a5bd1b9ed5a35a 
  include/mesos/state/leveldb.hpp 265e08b58ea4a50458587f884a98e24cdc5d1aa2 
  include/mesos/state/log.hpp 54cbdc8d67ef9dfc47b321d5837e09dd56920c94 
  include/mesos/state/protobuf.hpp c15696ab79b61f5487ee4a849d62b34b91ca1614 
  include/mesos/state/zookeeper.hpp fee93989c74db031ff2343e06eb25c5a7b88510f 
  include/mesos/v1/executor.hpp 9a2eb454b0d5d5dce7af03e3100dfd7ae078b5a1 
  include/mesos/v1/scheduler.hpp b1dfbb1454b550c8a2cd018b1ca9e3533b9171f7 
  include/mesos/zookeeper/group.hpp 7983e50ba9d240f19a2b3ae02d7fa8339e77f2fa 
  include/mesos/zookeeper/watcher.hpp b2961a54eae74c5810df5d085a39652991685930 
  src/authentication/cram_md5/authenticatee.hpp 
d77b2108c83951f0495b67f6494fb7410592e848 
  src/authentication/cram_md5/authenticatee.cpp 
d43dedf1ec86d3f25811718101ff273a7c0d7333 
  src/authentication/cram_md5/authenticator.hpp 
a68b2cf43fb5e45bdc2073a9031b72b6f7a1c1bc 
  src/authentication/cram_md5/authenticator.cpp 
0aad3aa9a6a2c70a6e98fc75a3443ea340d0404d 
  src/authorizer/local/authorizer.hpp 794443ae9e0ec66845bf611d45d6a037ec96ddf4 
  src/authorizer/local/authorizer.cpp 056b1723f5ec34271f1afe3ad810bc498db8f28e 
  src/checks/checker_process.hpp 6364af8f0bfbdf7f6596dc0bf32049806bd2ba83 
  src/cli/execute.cpp 89e5130784e6f18850a743c4e0219245f7658ff3 
  src/common/http.hpp 76e8f71b5687031344612e1742d3bb50040db758 
  src/common/recordio.hpp 88e789c7f65c7ac2a97473d656ab15b3803cc886 
  src/docker/executor.cpp d9f5a736c1cb28a55db1b4fdc793bc706c7cb1fe 
  src/examples/balloon_executor.cpp 5281db1718f3db462d40d65dfa9ce0e3d9adcc34 
  src/examples/balloon_framework.cpp cbc25e45258b05a645363d4229c0a701baa5481c 
  src/examples/disk_full_framework.cpp dfbdddae7f50d314e67db59300e5140b0476f807 
  src/examples/docker_no_executor_framework.cpp 
0cbda07872fcf7db091c17ef49f5bcea6d80e660 
  src/examples/dynamic_reservation_framework.cpp 
e8d8d09dbda95f77e4b7dbbc8e031cd962e3a45f 
  src/examples/example_module_impl.cpp b84ff73ba96999072a03461f46717c2f104ae9ff 
  src/examples/load_generator_framework.cpp 
3ae25b221185ec6bd4bd84c478be9a511d763162 
  src/examples/long_lived_executor.cpp 21b511d1d6d0793569ebdb2ecc5c9bc37f3de632 
  src/examples/long_lived_framework.cpp 
0e4e3d00f86ce810ecc273baa4c7d5d124a1a29d 
  src/examples/no_executor_framework.cpp 
dc75d7802e43164293c5d68ae78eb7fba6deba64 
  src/examples/persistent_volume_framework.cpp 
43375503f1bdb74fba7994f73beb5b5486026e73 
  src/examples/test_anonymous_module.cpp 
c41b7fc6d5feb7760603df1cda8cc0697a815324 
  src/examples/test_csi_user_framework.cpp 
91212e990af711633f7b890b0c9e10587f9efe7c 
  src/examples/test_executor.cpp d9b7cdd7dbaf61bc54d7490ab9e7f188ea45f571 
  src/examples/test_framework.cpp aaf952c20cd3d722d00504228c297c053079bf50 
  src/examples/test_hook_module.cpp 9b9d75c2bb81bf80e8edb919a04e0854e858f49d 
  src/examples/test_http_executor.cpp fb9209f630c9c0fa6c1e866eeaf178c560372edc 
  src/examples/test_http_framework.cpp 9ea3c6f35bf6464b4c6cfa7ba2eaf4febc168396 
  src/exec/exec.cpp ca4f065af18934a59161ad0ee63daba59beeb115 
  src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17 
  src/executor/v0_v1executor.hpp ef9bae6ab75279814a5ba9081aa663107195d8e6 
  src/executor/v0_v1executor.cpp 086cfc74c820657cb3dd7d531f2de44a97832782 
  src/files/files.cpp 4b8713a2783ec4c4205af071b6cfff3397ec4c1d 
  src/launcher/default_executor.cpp a70ba062ac14c851e8e276975b46ba4cc0868243 
  src/launcher/executor.cpp 9fb43c0b741c64f7ad9f3e35b4d81aa627e693dd 
  src/linux/cgroups.cpp b12e63c112a7aa7a6f7150359ff5409f8214067e 
  src/linux/perf.cpp f5ac21df3c2dbaeac0b72444d6e6ef4b3bfe78ca 
  src/log/catchup.cpp ed2e79bff50927e1f5849e8e62662526cac5df1a 
  src/log/consensus.cpp 76ed3e8e8061ea4ca52fe7cae38cbd81b02d5b3d 
  src/log/coordinator.cpp 01d2179f88abf0988192fe1a46640c9e8a0605b4 
  src/log/leveldb.hpp ce93fdc6160fd1947178546660db7ea3c4a1aa1f 
  src/log/leveldb.cpp 50d7fe576463e017cffd362d649f795261496dda 
  src/log/log.hpp 7cba0b1c8c84e4f7c1c592da94b74486e68a97e1 
  src/log/network.hpp 317ae14f754329b2e6e8521f5488107deb2d2c81 
  src/log/recover.cpp 2167d41098b3bd0fa22807ea9f5616ff79de6d9c 
  src/log/replica.cpp bb5aa8c7b4df6b6e4f5422a5cbc49d5f7b7d6878 
  src/log/tool/benchmark.hpp b58a6598f630fc2b26f776bb2eebae04d719d672 
  src/log/tool/initialize.hpp 8d4

Review Request 67867: Apply the `override` keyword to libprocess.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67867/
---

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, 
Mesos Reviewbot, Till Toenshoff, and Zhitao Li.


Bugs: MESOS-9065
https://issues.apache.org/jira/browse/MESOS-9065


Repository: mesos


Description
---

Apply the `override` keyword to libprocess.


Diffs
-

  3rdparty/libprocess/include/process/async.hpp 
116c90c01655cd1df67616d9c927f6769f5c92da 
  3rdparty/libprocess/include/process/collect.hpp 
5263f0134808a0161b16b3b45871f711b0f5cb45 
  3rdparty/libprocess/include/process/event.hpp 
ec64eb786b6cf30bf03ba07a30c6e44d2db9173a 
  3rdparty/libprocess/include/process/filter.hpp 
3f4a8272c451e333ebf9ff79c5f0fee329a8450a 
  3rdparty/libprocess/include/process/firewall.hpp 
0a7b985380893820d0193f7b2eb657ee8c07430e 
  3rdparty/libprocess/include/process/gmock.hpp 
b5ead1c2ecacdb468a319c98edd2ffc831a9f74c 
  3rdparty/libprocess/include/process/gtest.hpp 
79ea2b1f6a2a16ff9c5aae281c900e50940877bf 
  3rdparty/libprocess/include/process/help.hpp 
3393b71c484bb8c55c6a4cd2a27dcb798e841a80 
  3rdparty/libprocess/include/process/limiter.hpp 
b4b6a7bb48aa19fa40c0ea9f8759b8f553f43ca6 
  3rdparty/libprocess/include/process/logging.hpp 
aad7ce8caa193e6aff1a295fef899b49fcfce7b0 
  3rdparty/libprocess/include/process/metrics/counter.hpp 
15aeeb5710636d4e11b862faee50fd6ea4d1cb07 
  3rdparty/libprocess/include/process/metrics/metrics.hpp 
f9b72029b2c85826c91b1d7656b0af94dc87010c 
  3rdparty/libprocess/include/process/metrics/pull_gauge.hpp 
5c2a227425f31c439bd48b58171d4038a7f04e5f 
  3rdparty/libprocess/include/process/metrics/timer.hpp 
0a9c0227c457c6c81a59f65f901a5464ee00983d 
  3rdparty/libprocess/include/process/process.hpp 
c36df991b6a2c120ab0562e8ff907f9fbf8630d1 
  3rdparty/libprocess/include/process/protobuf.hpp 
5a75a83d294e2d14f81503b113724893c0e140f3 
  3rdparty/libprocess/include/process/reap.hpp 
628bc0a6ec59bfe6bfa7c54906ea266ac31a71a7 
  3rdparty/libprocess/include/process/sequence.hpp 
24712b16953347eb05a28ad50fbdfad17bf64f19 


Diff: https://reviews.apache.org/r/67867/diff/1/


Testing
---

make check (Fedora 28)


Thanks,

James Peach

Review Request 67866: Apply the `override` keyword to stout.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67866/
---

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, 
Mesos Reviewbot, Till Toenshoff, and Zhitao Li.


Bugs: MESOS-9065
https://issues.apache.org/jira/browse/MESOS-9065


Repository: mesos


Description
---

Apply the `override` keyword to stout.


Diffs
-

  3rdparty/stout/include/stout/lambda.hpp 
252de895ac679715ef20015d8887b1a78f264fe8 
  3rdparty/stout/include/stout/tests/utils.hpp 
e7336a586cc3ad4147cfe963604059026fc1e3f1 


Diff: https://reviews.apache.org/r/67866/diff/1/


Testing
---

make check (Fedora 28)


Thanks,

James Peach

Review Request 67864: Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67864/
---

Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Repository: mesos


Description
---

Updated tests to adapt `CREATE_DISK` and `DESTROY_DISK` operations.


Diffs
-

  src/examples/test_csi_user_framework.cpp 
91212e990af711633f7b890b0c9e10587f9efe7c 
  src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692 
  src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb 
  src/tests/master_validation_tests.cpp 
6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd 
  src/tests/mesos.hpp a23b02ceed135a0225fb504d755cd7dc97aa0cbe 
  src/tests/operation_reconciliation_tests.cpp 
d0bc73bfbf304833cebb76c538cb2c5552813838 
  src/tests/persistent_volume_tests.cpp 
43f31b2e613666a989c205b8543ef1cde484d93c 
  src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6 
  src/tests/resource_provider_manager_tests.cpp 
cf15e5a1f26f0895865b53931298f61ce5cfccff 
  src/tests/storage_local_resource_provider_tests.cpp 
1afe8a8e0413ef225e952cd9cd6376e5d82774e5 


Diff: https://reviews.apache.org/r/67864/diff/1/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Review Request 67863: Updated Mesos implementation to process `CREATE_DISK` & `DESTROY_DISK`.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67863/
---

Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Repository: mesos


Description
---

This patch removes the code for `CREATE_VOLUME`, `DESTROY_VOLUME`,
`CREATE_BLOCK` and `DESTROY_BLOCK` to adapt the new `CREATE_DISK` and
`DESTROY_DISK` operations.

Note that in SLRP we made CHECKs against disk types instead of returning
failures, Since the disk types should have been validated by the master.


Diffs
-

  src/common/protobuf_utils.cpp 82ba141fca86f5926dc519060c35308026c6048f 
  src/common/resources_utils.cpp eb7299583c197dd0e44c1c63417206b5c59ab853 
  src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
  src/master/master.cpp 0c0d6ca375b806a02625261f7e272a126bc4debe 
  src/master/validation.hpp 1ba6d6530d916b5c06762ee2b0bc91b819cd10e5 
  src/master/validation.cpp 79c67c3c409f03e94f1b5956fd035cd388ab0c3b 
  src/resource_provider/storage/provider.cpp 
b90a4b81838fec410a97a10ce44a811bb81c87eb 


Diff: https://reviews.apache.org/r/67863/diff/1/


Testing
---

make

Tests done later in chain.


Thanks,

Chun-Hung Hsiao

Re: Review Request 67779: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67779/
---

(Updated July 10, 2018, 3:10 a.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, James 
DeFelice, and Jie Yu.


Changes
---

Removed WIP.


Summary (updated)
-

Introduced `CREATE_DISK` and `DESTROY_DISK` operations.


Repository: mesos


Description
---

This patch introduces `CREATE_DISK` and `DESTROY_DISK` operations for
conversion between RAW disk resaurces and MOUNT/BLOCK disk resources to
replace `CREATE_VOLUME`/`DESTROY_VOLUME`/`CREATE_BLOCK`/`DESTROY_BLOCK`.

This replacement involves two aspects:

1. Renaming: The term "volume" is overloaded and created name conflicts
   in mesos. This renaming would lead to cleaner names in ACL and other
   places, and is more consistent with CSI.

2. Removing PATH support. PATH disks are used to split a disk resource
   into smaller chunks for concurrent independent uses. However, this
   concept does not quite fit CSI well.


Diffs (updated)
-

  include/mesos/mesos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3 
  include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1 


Diff: https://reviews.apache.org/r/67779/diff/2/

Changes: https://reviews.apache.org/r/67779/diff/1-2/


Testing (updated)
---

Test done later in chain.


Thanks,

Chun-Hung Hsiao

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/#review205884
---



PASS: Mesos patch 67791 was successfully built and tested.

Reviews applied: `['67791']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1889/mesos-review-67791

- Mesos Reviewbot Windows


On July 10, 2018, 12:20 a.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67791/
> ---
> 
> (Updated July 10, 2018, 12:20 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Greg Mann, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8987
> https://issues.apache.org/jira/browse/MESOS-8987
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Mesos master sends a `ShutdownMessage` to an agent if there is an
> authentication or an authorization error during agent (re)registration.
> 
> Upon receipt of this message, the agent kills alls its tasks and commits
> suicide. This means that transient auth errors can lead to whole agents
> being killed along with it's tasks.
> 
> This patch prevents the master from sending a `ShutdownMessage` in these
> cases.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 0c0d6ca375b806a02625261f7e272a126bc4debe 
>   src/tests/authentication_tests.cpp bd46cbc6d565ea8f2f6956c0424a76ad58607017 
>   src/tests/master_authorization_tests.cpp 
> 80b9d49ba334b915461ff5d6df6c9f922d7593e3 
> 
> 
> Diff: https://reviews.apache.org/r/67791/diff/6/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh` on GNU/Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205883
---



Patch looks great!

Reviews applied: [67693]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 6, 2018, 7:37 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> ---
> 
> (Updated July 6, 2018, 7:37 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 
>   src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c 
>   src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692 
> 
> 
> Diff: https://reviews.apache.org/r/67693/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> The added tests fails without the corresponding changes to the master and 
> agent code.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 67861: Updated json parsing to avoid copying between picojson and stout JSON.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67861/
---

Review request for mesos, Greg Mann and Michael Park.


Repository: mesos


Description
---

When looking at some profiling data, it looks as though we approximately
double the cost of JSON parsing due to having to convert from
`picojson::value` to `JSON::Value`.

Michael Park pointed me to the parsing "context" that's customizable in
picojson. This patch replaces our conversion with a parsing context in
order to parse directly into JSON::Value and avoid copying.


Diffs
-

  3rdparty/stout/include/stout/json.hpp 
c374e29829e4ea02ab3a8494b6ab28c166579516 


Diff: https://reviews.apache.org/r/67861/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler

Re: Review Request 67859: Updated apply-reviews.py messaging for submitted reviews.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67859/#review205882
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67859']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1888/mesos-review-67859

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1888/mesos-review-67859/logs/mesos-tests-stdout.log):

```
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (680 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (705 ms total)

[--] Global test environment tear-down
d:\dcos\mesos\mesos\src\tests\environment.cpp(997): error: Failed
Tests completed with child processes remaining:
-+- 21704 0052C60FE75C
 |-+- 18916 0052C60FE75C
 | --- 22880 0052C60FE75C
 |-+- 19644 0052C60FE75C
 | --- 17692 0052C60FE75C
 |-+- 20224 0052C60FE75C
 | --- 21040 0052C60FE75C
 |-+- 20896 0052C60FE75C
 | --- 23416 0052C60FE75C
 |-+- 21640 0052C60FE75C
 | --- 23424 0052C60FE75C
 |-+- 21980 0052C60FE75C
 | --- 21516 0052C60FE75C
 -+- 23192 0052C60FE75C
   --- 16544 0052C60FE75C
[==] 1010 tests from 98 test cases ran. (510545 ms total)
[  PASSED  ] 1010 tests.
[  FAILED  ] 0 tests, listed below:

 0 FAILED TESTS

  YOU HAVE 222 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1888/mesos-review-67859/logs/mesos-tests-stderr.log):

```
I0710 00:49:25.516950 21580 slave.cpp:3939] Shutting down framework 
7f0892a0-5ead-49b1-9d76-e767d98c886f-
I0710 00:49:25.516950  3512 master.cpp:11033] Updating the state of task 
e80d238b-f6ce-43f2-84cb-f102cb0e20b2 of framework 
7f0892a0-5ead-49b1-9d76-e767d98c886f- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0710 00:49:25.516950 21580 slave.cpp:6660] Shutting down executor 
'e80d238b-f6ce-43f2-84cb-f102cb0e20b2' of framework 
7f0892a0-5ead-49b1-9d76-e767d98c886f- at executor(1)@192.10.1.6:63205
I0710 00:49:25.518962 21580 slave.cpp:931] Agent terminating
W0710 00:49:25.518962 21580 slave.cpp:3935] Ignoring shutdown framework 
7f0892a0-5ead-49b1-9d76-e767d98c886f- because it is terminating
I0710 00:49:25.519950  3512 master.cpp:11132] Removing task 
e80d238b-f6ce-43f2-84cb-f102cb0e20b2 with resources cpus(allocated: *):4; 
mI0710 00:49:25.356082 13252 exec.cpp:162] Version: 1.7.0
I0710 00:49:25.382966 22736 exec.cpp:236] Executor registered on agent 
7f0892a0-5ead-49b1-9d76-e767d98c886f-S0
I0710 00:49:25.386948 18340 executor.cpp:182] Received SUBSCRIBED event
I0710 00:49:25.391954 18340 executor.cpp:186] Subscribed executor on 
windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0710 00:49:25.391954 18340 executor.cpp:182] Received LAUNCH event
I0710 00:49:25.395943 18340 executor.cpp:679] Starting task 
e80d238b-f6ce-43f2-84cb-f102cb0e20b2
I0710 00:49:25.477941 18340 executor.cpp:499] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0710 00:49:25.489941 18340 executor.cpp:693] Forked command at 18452
I0710 00:49:25.518962 23292 exec.cpp:445] Executor asked to shutdown
I0710 00:49:25.519950 18340 executor.cpp:182] Received SHUTDOWN event
I0710 00:49:25.519950 18340 executor.cpp:796] Shutting down
I0710 00:49:25.519950 18340 executor.cpp:909] Sending SIGTERM to process tree 
at pid 18em(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 7f0892a0-5ead-49b1-9d76-e767d98c886f- on 
agent 7f0892a0-5ead-49b1-9d76-e767d98c886f-S0 at slave(462)@192.10.1.6:61500 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0710 00:49:25.522969  3512 master.cpp:1330] Agent 
7f0892a0-5ead-49b1-9d76-e767d98c886f-S0 at slave(462)@192.10.1.6:61500 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0710 00:49:25.522969  3512 master.cpp:3340] Disconnecting agent 
7f0892a0-5ead-49b1-9d76-e767d98c886f-S0 at slave(462)@192.10.1.6:61500 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0710 00:49:25.522969  3512 master.cpp:3359] Deactivating agent 
7f0892a0-5ead-49b1-9d76-e767d98c886f-S0 at slave(462)@192.10.1.6:61500 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0710 00:49:25.523941 20420 containerizer.cpp:2407] Destroying container 
aa0b40a2-760d-4c3c-becd-15a1eb5b85fd in RUNNING state
I0710 00:49:25.523941 20420 containerizer.cpp:3021] Transitioning the state of 
container aa0b40a2-760d-4c3c-becd-15a1eb5b85fd from RUNNING to DESTROYING
I0710 00:49:25.524947 20420 launcher.cpp:155] Asked to destroy container 
aa0b40a2-760d-4c3c-becd-15a1eb5b85fd
I0710 00:49:25.524947 20692 hierarchical.cpp:346] Remo

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/
---

(Updated July 9, 2018, 5:20 p.m.)


Review request for mesos, Alexander Rojas, Greg Mann, and Jiang Yan Xu.


Bugs: MESOS-8987
https://issues.apache.org/jira/browse/MESOS-8987


Repository: mesos


Description
---

The Mesos master sends a `ShutdownMessage` to an agent if there is an
authentication or an authorization error during agent (re)registration.

Upon receipt of this message, the agent kills alls its tasks and commits
suicide. This means that transient auth errors can lead to whole agents
being killed along with it's tasks.

This patch prevents the master from sending a `ShutdownMessage` in these
cases.


Diffs (updated)
-

  src/master/master.cpp 0c0d6ca375b806a02625261f7e272a126bc4debe 
  src/tests/authentication_tests.cpp bd46cbc6d565ea8f2f6956c0424a76ad58607017 
  src/tests/master_authorization_tests.cpp 
80b9d49ba334b915461ff5d6df6c9f922d7593e3 


Diff: https://reviews.apache.org/r/67791/diff/6/

Changes: https://reviews.apache.org/r/67791/diff/5-6/


Testing
---

`bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gastón Kleiman

Re: Review Request 67488: Updated CLI to Python 3.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205881
---



Patch looks great!

Reviews applied: [67853, 67855, 67856, 67488]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 6, 2018, 1:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 1:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/10/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Review Request 67859: Updated apply-reviews.py messaging for submitted reviews.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67859/
---

Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-7397
https://issues.apache.org/jira/browse/MESOS-7397


Repository: mesos


Description
---

Updated apply-reviews.py messaging for submitted reviews.


Diffs
-

  support/apply-reviews.py edddefb75b1acca90378e79b3533c7a565110542 
  support/python3/apply-reviews.py bf72c809020b976b401413b994608280068dcfd2 


Diff: https://reviews.apache.org/r/67859/diff/1/


Testing
---

Manually tested on an already submitted review-request.


Thanks,

Till Toenshoff

Re: Review Request 67823: Added a master benchmark test for metrics.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/#review205876
---



FAIL: Failed to apply the dependent review: 67813.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67813`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1887/mesos-review-67823

Relevant logs:

- 
[apply-review-67813-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1887/mesos-review-67823/logs/apply-review-67813-stdout.log):

```
error: patch failed: src/master/metrics.cpp:630
error: src/master/metrics.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On July 9, 2018, 9:08 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67823/
> ---
> 
> (Updated July 9, 2018, 9:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.
> 
> 
> Bugs: MESOS-8911
> https://issues.apache.org/jira/browse/MESOS-8911
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a master benchmark test for metrics.
> 
> 
> Diffs
> -
> 
>   src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 
> 
> 
> Diff: https://reviews.apache.org/r/67823/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 67857: Improved release policy documentation visibility.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67857/#review205875
---



PASS: Mesos patch 67857 was successfully built and tested.

Reviews applied: `['67857']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1886/mesos-review-67857

- Mesos Reviewbot Windows


On July 9, 2018, 1:29 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67857/
> ---
> 
> (Updated July 9, 2018, 1:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the release policy can be a very important document for Mesos
> operators, add a top-level link to it. Update the HTTP API version
> link to point to the section that discusses that policy.
> 
> 
> Diffs
> -
> 
>   docs/home.md 68b1c74c60b21c573ffcc1e36c744d48dc769193 
>   docs/versioning.md a5e55ce87772bd12fead36460fd42cb2ad1f3428 
> 
> 
> Diff: https://reviews.apache.org/r/67857/diff/1/
> 
> 
> Testing
> ---
> 
> Manually viewed docs and verified that the links work.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 67832: Changed docker subprocess calls to use exec form.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67832/#review205873
---


Fix it, then Ship it!





src/docker/docker.cpp
Lines 196-198 (original), 198-201 (patched)


Nit: for here and below, if `cmd` is only being used in the information and 
error messages, do it inline to (a) avoid constructing the string if there was 
no error and (b) avoid a future programmer going and using `cmd` again in the 
`subprocess` call because they thought it was silly.



src/tests/containerizer/docker_tests.cpp
Lines 401 (patched)


Is the test fixture's sandbox not available?


- Andrew Schwartzmeyer


On July 5, 2018, 2:16 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67832/
> ---
> 
> (Updated July 5, 2018, 2:16 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The docker executor used the command line subprocess form even it only
> ever called the docker executable. The command line form made the
> executor fail if the `--docker=` path contained spaces.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 25d9ca662fa5d99b32c668a5fdfc75584132cc38 
>   src/docker/docker.cpp baac70f25ef3f944541341822aacb6a395853113 
>   src/tests/containerizer/docker_tests.cpp 
> 7097efc716ab0e1f34d5a1a35d8e0e173b113c91 
> 
> 
> Diff: https://reviews.apache.org/r/67832/diff/1/
> 
> 
> Testing
> ---
> 
> Tested by running `HungDockerTest` on a path with a space. Waiting for 
> Windows CI for verification.
> On Linux, ran mesos-tests.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 67817: Improved logging for offers and inverse offers.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67817/#review205874
---


Ship it!




Ship It!

- Greg Mann


On July 3, 2018, 8:56 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67817/
> ---
> 
> (Updated July 3, 2018, 8:56 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Log offer IDs and inverse offer IDs when sending out offers and
> inverse offers so it is easier to match them to their ACCEPT or DECLINE
> calls and removals.
> 
> Also log at `VLOG(2)` level which resources are offered.
> 
> NOTE: It is possible to enable `VLOG(2)` logs just for `master.cpp` by
> setting the following env variable when starting the master:
> `GLOG_vmodule=master=2`.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
> 
> 
> Diff: https://reviews.apache.org/r/67817/diff/2/
> 
> 
> Testing
> ---
> 
> Manual testing =).
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 67823: Added a master benchmark test for metrics.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67823/
---

(Updated July 9, 2018, 9:08 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach.


Bugs: MESOS-8911
https://issues.apache.org/jira/browse/MESOS-8911


Repository: mesos


Description
---

Added a master benchmark test for metrics.


Diffs (updated)
-

  src/tests/master_benchmarks.cpp fbfffb69930c30b038f74e0b831fc0ae41c820f0 


Diff: https://reviews.apache.org/r/67823/diff/3/

Changes: https://reviews.apache.org/r/67823/diff/2-3/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67857: Improved release policy documentation visibility.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67857/#review205871
---


Ship it!




Ship It!

- Vinod Kone


On July 9, 2018, 8:29 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67857/
> ---
> 
> (Updated July 9, 2018, 8:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since the release policy can be a very important document for Mesos
> operators, add a top-level link to it. Update the HTTP API version
> link to point to the section that discusses that policy.
> 
> 
> Diffs
> -
> 
>   docs/home.md 68b1c74c60b21c573ffcc1e36c744d48dc769193 
>   docs/versioning.md a5e55ce87772bd12fead36460fd42cb2ad1f3428 
> 
> 
> Diff: https://reviews.apache.org/r/67857/diff/1/
> 
> 
> Testing
> ---
> 
> Manually viewed docs and verified that the links work.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 67857: Improved release policy documentation visibility.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67857/
---

Review request for mesos, Benjamin Bannier and Vinod Kone.


Repository: mesos


Description
---

Since the release policy can be a very important document for Mesos
operators, add a top-level link to it. Update the HTTP API version
link to point to the section that discusses that policy.


Diffs
-

  docs/home.md 68b1c74c60b21c573ffcc1e36c744d48dc769193 
  docs/versioning.md a5e55ce87772bd12fead36460fd42cb2ad1f3428 


Diff: https://reviews.apache.org/r/67857/diff/1/


Testing
---

Manually viewed docs and verified that the links work.


Thanks,

James Peach

Re: Review Request 67847: Fixed installation of storage disk profile adaptor header.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67847/#review205869
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On July 6, 2018, 8:50 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67847/
> ---
> 
> (Updated July 6, 2018, 8:50 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Automake does not care about the source directory of headers it
> installs, but instead either installs into `$(pkgincludedir)` or some
> `COMPONENTdir`. When doing in-tree builds on the other hand the
> header source directories matter since the build is performed against
> a source tree, not an installed tree.
> 
> This patch fixes installation of the `disk_profile_adaptor.hpp` header
> which while it resided in the source directory
> `mesos/resource_provider/storage` was installed into
> `mesos/resource_provider`. This made e.g., other headers relying on
> the disk profile adaptor header unusable when building against
> installed Mesos headers. We now make sure to install to the `storage/`
> subdirectory.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
> 
> 
> Diff: https://reviews.apache.org/r/67847/diff/1/
> 
> 
> Testing
> ---
> 
> `make distcheck`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67776: Added per-framework metrics for scheduler calls.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/
---

(Updated July 9, 2018, 6:34 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.


Bugs: MESOS-8843
https://issues.apache.org/jira/browse/MESOS-8843


Repository: mesos


Description
---

Added per-framework metrics for scheduler calls.


Diffs (updated)
-

  src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 
  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/67776/diff/4/

Changes: https://reviews.apache.org/r/67776/diff/3-4/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/#review205865
---



Patch looks great!

Reviews applied: [67791]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 7, 2018, 12:26 a.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67791/
> ---
> 
> (Updated July 7, 2018, 12:26 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Greg Mann, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8987
> https://issues.apache.org/jira/browse/MESOS-8987
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Mesos master sends a `ShutdownMessage` to an agent if there is an
> authentication or an authorization error during agent (re)registration.
> 
> Upon receipt of this message, the agent kills alls its tasks and commits
> suicide. This means that transient auth errors can lead to whole agents
> being killed along with it's tasks.
> 
> This patch prevents the master from sending a `ShutdownMessage` in these
> cases.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
>   src/tests/authentication_tests.cpp bd46cbc6d565ea8f2f6956c0424a76ad58607017 
>   src/tests/master_authorization_tests.cpp 
> 80b9d49ba334b915461ff5d6df6c9f922d7593e3 
> 
> 
> Diff: https://reviews.apache.org/r/67791/diff/5/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh` on GNU/Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 67812: Added per-framework offer metrics.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67812/
---

(Updated July 9, 2018, 6:18 p.m.)


Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, 
Gilbert Song, and Vinod Kone.


Bugs: MESOS-8848
https://issues.apache.org/jira/browse/MESOS-8848


Repository: mesos


Description
---

Added per-framework offer metrics.


Diffs (updated)
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/67812/diff/4/

Changes: https://reviews.apache.org/r/67812/diff/3-4/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 67809: Added per-framework metrics for scheduler events.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67809/
---

(Updated July 9, 2018, 6:17 p.m.)


Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, 
Gilbert Song, and Vinod Kone.


Bugs: MESOS-8844
https://issues.apache.org/jira/browse/MESOS-8844


Repository: mesos


Description
---

Added per-framework metrics for scheduler events.


Diffs (updated)
-

  src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/67809/diff/2/

Changes: https://reviews.apache.org/r/67809/diff/1-2/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205864
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On July 6, 2018, 7:37 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> ---
> 
> (Updated July 6, 2018, 7:37 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 
>   src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c 
>   src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692 
> 
> 
> Diff: https://reviews.apache.org/r/67693/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> The added tests fails without the corresponding changes to the master and 
> agent code.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67814: Added per-framework metrics for offer operations.

[Greg Mann]

> On July 6, 2018, 9:48 p.m., Gastón Kleiman wrote:
> > src/master/master.cpp
> > Lines 4738-4740 (patched)
> > 
> >
> > As discussed offline, it would be better to increment these counters 
> > after having validated the operations. That means that we would probably 
> > have to call `FrameworkMetrics::incrementOperation` in each `case` 
> > statement.
> > 
> > We shoud also add an `invalidOperations` counter and increase it 
> > accordingly.

Sounds good. I created a ticket to add invalid/unauthorized operation counters 
here: https://issues.apache.org/jira/browse/MESOS-9059


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67814/#review205825
---


On July 9, 2018, 6:03 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67814/
> ---
> 
> (Updated July 9, 2018, 6:03 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, 
> Gilbert Song, and Vinod Kone.
> 
> 
> Bugs: MESOS-8845
> https://issues.apache.org/jira/browse/MESOS-8845
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added per-framework metrics for offer operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/67814/diff/2/
> 
> 
> Testing
> ---
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 67814: Added per-framework metrics for offer operations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67814/
---

(Updated July 9, 2018, 6:03 p.m.)


Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, 
Gilbert Song, and Vinod Kone.


Bugs: MESOS-8845
https://issues.apache.org/jira/browse/MESOS-8845


Repository: mesos


Description
---

Added per-framework metrics for offer operations.


Diffs (updated)
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/67814/diff/2/

Changes: https://reviews.apache.org/r/67814/diff/1-2/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 67693: Added filtering for `GET_OPERATIONS` calls.

[Chun-Hung Hsiao]

> On July 5, 2018, 9:55 p.m., Chun-Hung Hsiao wrote:
> > src/master/http.cpp
> > Lines 3821 (patched)
> > 
> >
> > Do we want to:
> > 1. Simply skip such operations, as suggested in the code here, or
> > 2. Return an `InternalServerError` eventually, or
> > 3. Just `CHECK` that this shouldn't happen?
> > Ditto below.
> > 
> > Please feel free to drop this if you think skipping is good enough.
> 
> Benjamin Bannier wrote:
> Thanks for bringing this up.
> 
> Since we here only are concerned with authorizing operations, I still 
> think that skipping is a fair solution (we cannot show the operation without 
> authorizing, but also do not need to render the response not useful with 
> `InternalServerError`; we do not need to `CHECK` either I believe as that 
> would introduce very hard coupling).
> 
> I added a `WARNING` log with some details. Does that work?

Sounds good.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67693/#review205755
---


On July 6, 2018, 7:37 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67693/
> ---
> 
> (Updated July 6, 2018, 7:37 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8473
> https://issues.apache.org/jira/browse/MESOS-8473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds filtering of operations reported for `GET_OPERATIONS`
> calls. A principal is allowed to view see all operations for which it
> is allowed to see the role of the underlying resources.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 
>   src/slave/http.cpp aa9cdc5f58f73323958a6872e2721c83317f354c 
>   src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692 
> 
> 
> Diff: https://reviews.apache.org/r/67693/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> The added tests fails without the corresponding changes to the master and 
> agent code.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205858
---



PASS: Mesos patch 67488 was successfully built and tested.

Reviews applied: `['67853', '67855', '67856', '67488']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1885/mesos-review-67488

- Mesos Reviewbot Windows


On July 6, 2018, 1:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 1:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/10/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67853: Updated build-virtualenv to use Python 3 features.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67853/#review205856
---


Ship it!




Ship It!

- Kevin Klues


On July 9, 2018, 3:54 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67853/
> ---
> 
> (Updated July 9, 2018, 3:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9058
> https://issues.apache.org/jira/browse/MESOS-9058
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With Python 3, virtualenv is built-in. We thus remove the error
> messages if the script is run using Python 3 without virtualenv
> installed on the machine. We also use `python` instead of
> `virtualenv` to build the virtual environment.
> 
> This change also fixes an issue on my computer where running
> `build-virtualenv` with Python 3 displayed an error message:
> `ModuleNotFoundError: No module named 'nodeenv'`.
> 
> 
> Diffs
> -
> 
>   support/build-virtualenv 5fda08187bb92847dba459550313edff756c9e7f 
> 
> 
> Diff: https://reviews.apache.org/r/67853/diff/4/
> 
> 
> Testing
> ---
> 
> Ran `build-virtualenv` with python 2 and 3.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67853: Updated build-virtualenv to use Python 3 features.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67853/#review205855
---




support/build-virtualenv
Line 52 (original), 41 (patched)


Can we replace `` with `${0}` both here and below?


- Kevin Klues


On July 9, 2018, 3:54 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67853/
> ---
> 
> (Updated July 9, 2018, 3:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff.
> 
> 
> Bugs: MESOS-8882
> https://issues.apache.org/jira/browse/MESOS-8882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With Python 3, virtualenv is built-in. We thus remove the error
> messages if the script is run using Python 3 without virtualenv
> installed on the machine. We also use `python` instead of
> `virtualenv` to build the virtual environment.
> 
> This change also fixes an issue on my computer where running
> `build-virtualenv` with Python 3 displayed an error message:
> `ModuleNotFoundError: No module named 'nodeenv'`.
> 
> 
> Diffs
> -
> 
>   support/build-virtualenv 5fda08187bb92847dba459550313edff756c9e7f 
> 
> 
> Diff: https://reviews.apache.org/r/67853/diff/2/
> 
> 
> Testing
> ---
> 
> Ran `build-virtualenv` with python 2 and 3.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 66842: Added per-framework metrics for offer filter durations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66842/
---

(Updated July 9, 2018, 3:56 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

These per-framework metrics provide counts of the numbers
of filters set by each framework, bucketed according to
the 'refuse_seconds' duration.


Diffs (updated)
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/66842/diff/10/

Changes: https://reviews.apache.org/r/66842/diff/9-10/


Testing
---


Thanks,

Greg Mann

Re: Review Request 67853: Updated build-virtualenv to use Python 3 features.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67853/
---

(Updated July 9, 2018, 3:54 p.m.)


Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff.


Bugs: MESOS-8882
https://issues.apache.org/jira/browse/MESOS-8882


Repository: mesos


Description
---

With Python 3, virtualenv is built-in. We thus remove the error
messages if the script is run using Python 3 without virtualenv
installed on the machine. We also use `python` instead of
`virtualenv` to build the virtual environment.

This change also fixes an issue on my computer where running
`build-virtualenv` with Python 3 displayed an error message:
`ModuleNotFoundError: No module named 'nodeenv'`.


Diffs (updated)
-

  support/build-virtualenv 5fda08187bb92847dba459550313edff756c9e7f 


Diff: https://reviews.apache.org/r/67853/diff/2/

Changes: https://reviews.apache.org/r/67853/diff/1-2/


Testing
---

Ran `build-virtualenv` with python 2 and 3.


Thanks,

Armand Grillet

Re: Review Request 67853: Updated build-virtualenv to use Python 3 features.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67853/#review205854
---




support/build-virtualenv
Line 49 (original), 38 (patched)


I don't think we need this check in here. We should make this script usable 
for *both* python2 and python 3 environments and depending on what the 
environment is that it is invoked in, it will build an appropriate virtualenv.


- Kevin Klues


On July 9, 2018, 10:33 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67853/
> ---
> 
> (Updated July 9, 2018, 10:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff.
> 
> 
> Bugs: MESOS-8882
> https://issues.apache.org/jira/browse/MESOS-8882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> With Python 3, virtualenv is built-in. We thus remove the error
> messages if the script is run using Python 3 without virtualenv
> installed on the machine. We also use `python` instead of
> `virtualenv` to build the virtual environment.
> 
> This change also fixes an issue on my computer where running
> `build-virtualenv` with Python 3 displayed an error message:
> `ModuleNotFoundError: No module named 'nodeenv'`.
> 
> 
> Diffs
> -
> 
>   support/build-virtualenv 5fda08187bb92847dba459550313edff756c9e7f 
> 
> 
> Diff: https://reviews.apache.org/r/67853/diff/1/
> 
> 
> Testing
> ---
> 
> Ran `build-virtualenv` with python 2 and 3.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 66842: Added per-framework metrics for offer filter durations.

[Greg Mann]

> On May 1, 2018, 12:42 a.m., Benjamin Mahler wrote:
> > src/master/metrics.cpp
> > Lines 571-573 (patched)
> > 
> >
> > Could we make this consistent with the others instead of having a 
> > special variable by leveraging Duration::max()?
> 
> Greg Mann wrote:
> Yep that's certainly possible. I elected to use a separate object for the 
> infinite case to make it clearer to the reader (especially in 
> incrementOfferFilterBuckets() that the infinite case is a total counter of 
> offer filters. If you don't see that as providing much benefit, then perhaps 
> I should just put that case in the map as well. WDYT?

I'm gonna drop this one - the two options are functionally equivalent, and I 
think the current code does improve readability slightly.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66842/#review202172
---


On July 6, 2018, 9:50 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66842/
> ---
> 
> (Updated July 6, 2018, 9:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These per-framework metrics provide counts of the numbers
> of filters set by each framework, bucketed according to
> the 'refuse_seconds' duration.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/66842/diff/9/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66844/
---

(Updated July 9, 2018, 3:49 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Bugs: MESOS-8849
https://issues.apache.org/jira/browse/MESOS-8849


Repository: mesos


Description
---

These metrics count the number of times that the allocator has
filtered resources out of this framework's offer stream,
with separate metrics for different types of filtering.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/mesos/metrics.hpp 
6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 
82990b2dc0b827a43a392d898667eaf58c77ea36 


Diff: https://reviews.apache.org/r/66844/diff/8/

Changes: https://reviews.apache.org/r/66844/diff/7-8/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 66861: Added per-framework DRF position metrics to the allocator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66861/
---

(Updated July 9, 2018, 3:46 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

During each allocation cycle, the allocator re-sorts roles and
frameworks for each agent in the cluster. This means that for each
agent there exists a total order of (role, framework) tuples.

This patch adds per-framework, per-role metrics which track the
minimum and maximum positions attained by the framework in this
sorting process, from the most recent allocation cycle.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/mesos/metrics.hpp 
6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 
82990b2dc0b827a43a392d898667eaf58c77ea36 


Diff: https://reviews.apache.org/r/66861/diff/5/

Changes: https://reviews.apache.org/r/66861/diff/4-5/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 66856: Tracked completed framework metrics in the allocator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66856/
---

(Updated July 9, 2018, 3:45 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

This ensures that per-framework metrics which are tracked in the
allocator will be retained as long as the per-framework metrics
which are tracked in the master.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
c19ab64ff1422a68cfb6eecea7e2cc4132da8dcc 
  src/master/allocator/mesos/allocator.hpp 
900c8ee405da6e44532dee598edaa42373ebd4e5 
  src/master/allocator/mesos/hierarchical.hpp 
0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/tests/allocator.hpp 73fc06043746a0498d0dd1846fae9433db136d49 
  src/tests/api_tests.cpp f343991a5d23ac665429456471ac06a5315fc692 
  src/tests/master_allocator_tests.cpp 824a7554858fb8356751f34699607505bd98 
  src/tests/master_quota_tests.cpp d836482f5593b462ad235620741148678ac2651d 
  src/tests/reservation_tests.cpp 058a66d7914c7a84f0ba86dfd3ff2e3c0bbcb5c6 
  src/tests/resource_offers_tests.cpp 6e24cddce65e7f5a0ce8ea4fde8397a19236d8b8 
  src/tests/slave_recovery_tests.cpp e8333402d8524a4bf302872d246fe5f5c006bdc5 


Diff: https://reviews.apache.org/r/66856/diff/5/

Changes: https://reviews.apache.org/r/66856/diff/4-5/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 66870: Added per-framework metrics for suppressed roles.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66870/
---

(Updated July 9, 2018, 3:43 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

Added per-framework metrics for suppressed roles.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/mesos/metrics.hpp 
6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 
82990b2dc0b827a43a392d898667eaf58c77ea36 


Diff: https://reviews.apache.org/r/66870/diff/4/

Changes: https://reviews.apache.org/r/66870/diff/3-4/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 66843: Added 'FrameworkMetrics' to the allocator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66843/
---

(Updated July 9, 2018, 3:40 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

This struct will hold per-framework metrics tracked
by the allocator.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
  src/master/allocator/mesos/hierarchical.cpp 
5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/mesos/metrics.hpp 
6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 
82990b2dc0b827a43a392d898667eaf58c77ea36 


Diff: https://reviews.apache.org/r/66843/diff/9/

Changes: https://reviews.apache.org/r/66843/diff/8-9/


Testing
---

Testing details can be found at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 67722: Fixed unproperly guarded future.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67722/
---

(Updated July 9, 2018, 5:12 p.m.)


Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.


Repository: mesos


Description
---

This patch fixes a bug where the code path could cause a crash because
of calling `Fture::get()` on a future which is failed.


Diffs (updated)
-

  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 


Diff: https://reviews.apache.org/r/67722/diff/4/

Changes: https://reviews.apache.org/r/67722/diff/3-4/


Testing
---

```sh
make check
```


Thanks,

Alexander Rojas

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67791/#review205852
---




src/tests/master_authorization_tests.cpp
Lines 2431 (patched)


I think we also want to add a `settle()` after this `AWAIT_READY`, and 
other similar ones in this patch?


- Greg Mann


On July 7, 2018, 12:26 a.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67791/
> ---
> 
> (Updated July 7, 2018, 12:26 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Greg Mann, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8987
> https://issues.apache.org/jira/browse/MESOS-8987
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Mesos master sends a `ShutdownMessage` to an agent if there is an
> authentication or an authorization error during agent (re)registration.
> 
> Upon receipt of this message, the agent kills alls its tasks and commits
> suicide. This means that transient auth errors can lead to whole agents
> being killed along with it's tasks.
> 
> This patch prevents the master from sending a `ShutdownMessage` in these
> cases.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
>   src/tests/authentication_tests.cpp bd46cbc6d565ea8f2f6956c0424a76ad58607017 
>   src/tests/master_authorization_tests.cpp 
> 80b9d49ba334b915461ff5d6df6c9f922d7593e3 
> 
> 
> Diff: https://reviews.apache.org/r/67791/diff/5/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh` on GNU/Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 67722: Fixed unproperly guarded future.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67722/#review205851
---


Fix it, then Ship it!





src/master/master.cpp
Lines 9799 (patched)


Can we use `isNone` instead of `!isSome` here?


- Greg Mann


On July 6, 2018, 1:06 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67722/
> ---
> 
> (Updated July 6, 2018, 1:06 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch fixes a bug where the code path could cause a crash because
> of calling `Fture::get()` on a future which is failed.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
> 
> 
> Diff: https://reviews.apache.org/r/67722/diff/3/
> 
> 
> Testing
> ---
> 
> ```sh
> make check
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 67856: Updated Python virtual environment dependencies.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67856/#review205848
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67853', '67855', '67856']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67856

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67856/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (798 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (600 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1330 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (800 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (800 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1013 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (598 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5358 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5172 ms)
[--] 24 tests from DockerContainerizerTest (92152 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @0061273BBF90.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @0061273BC1F0.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @01B629FDDFC8.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01B62B2EA620.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01B62B7DA230.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67856/logs/mesos-tests-stderr.log):

```
I0709 11:38:12.860503  3312 authenticatee.cpp:299] Authentication success
I0709 11:38:12.860503 19324 master.cpp:9802] Successfully authenticated 
principal 'test-principal' at 
scheduler-74fbfd35-fbde-4f9c-ae07-973da6055e21@192.10.1.6:52230
I0709 11:38:12.861498 15836 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:52230
I0709 11:38:12.862481 20524 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-74fbfd35-fbde-4f9c-ae07-973da6055e21@192.10.1.6:52230
I0709 11:38:12.862481 20524 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0709 11:38:12.863489 19324 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0709 11:38:12.864485 19324 master.cpp:9993] Adding framework 
30f35234-cfd2-43b3-b8ef-a18278d75fee- (default) at 
scheduler-74fbfd35-fbde-4f9c-ae07-973da6055e21@192.10.1.6:52230 with roles {  } 
suppressed
I0709 11:38:12.865495 20264 sched.cpp:749] Framework registered with 
30f35234-cfd2-43b3-b8ef-a18278d75fee-
I0709 11:38:12.866482 20180 hierarchical.cpp:299] Added framework 
30f35234-cfd2-43b3-b8ef-a18278d75fee-
E0709 11:38:12.943490 19324 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is 

Review Request 67856: Updated Python virtual environment dependencies.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67856/
---

Review request for mesos, Benjamin Bannier, Kevin Klues, and Till Toenshoff.


Bugs: MESOS-8882
https://issues.apache.org/jira/browse/MESOS-8882


Repository: mesos


Description
---

Fixes the error message when running support/build-virtualenv:
`npm WARN ajv-keywords@3.2.0 requires a peer of ajv@^6.0.0 but none
is installed. You must install peer dependencies yourself.`.

Updates the PyInstaller dependency due to issues with PyInstaller
3.1.1 and Python 3.6.


Diffs
-

  src/python/cli_new/pip-requirements.txt 
aeb023325e838aa42f8d7418bb7f8293c3fa5614 
  support/build-virtualenv 5fda08187bb92847dba459550313edff756c9e7f 
  support/pip-requirements.txt 5877ad283d3b2cbb5fc46cf712ebaf7a6bccc66d 


Diff: https://reviews.apache.org/r/67856/diff/1/


Testing
---

Ran `support/build-virtualenv` successfully.


Thanks,

Armand Grillet

Review Request 67855: Added virtualenv requirements watcher to Python 3 mesos-style.py.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67855/
---

Review request for mesos, Benjamin Bannier and Till Toenshoff.


Bugs: MESOS-8882
https://issues.apache.org/jira/browse/MESOS-8882


Repository: mesos


Description
---

Added virtualenv requirements watcher to Python 3 mesos-style.py.


Diffs
-

  support/python3/mesos-style.py 0a4b1b1a0287011faf4488522f88587e07b3c874 


Diff: https://reviews.apache.org/r/67855/diff/1/


Testing
---

Checked that this commit trigerred the script (I am using Python 3 by default).


Thanks,

Armand Grillet

Review Request 67853: Updated build-virtualenv to use Python 3 features.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67853/
---

Review request for mesos, Benjamin Bannier and Till Toenshoff.


Bugs: MESOS-8882
https://issues.apache.org/jira/browse/MESOS-8882


Repository: mesos


Description
---

With Python 3, virtualenv is built-in. We thus remove the error
messages if the script is run using Python 3 without virtualenv
installed on the machine. We also use `python` instead of
`virtualenv` to build the virtual environment.

This change also fixes an issue on my computer where running
`build-virtualenv` with Python 3 displayed an error message:
`ModuleNotFoundError: No module named 'nodeenv'`.


Diffs
-

  support/build-virtualenv 5fda08187bb92847dba459550313edff756c9e7f 


Diff: https://reviews.apache.org/r/67853/diff/1/


Testing
---

Ran `build-virtualenv` with python 2 and 3.


Thanks,

Armand Grillet

Re: Review Request 66822: Added per Framework Calls to metrics.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66822/#review205845
---



Bad patch!

Reviews applied: [66822]

Failed command: python support/apply-reviews.py -n -r 66822

Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-07-09 09:40:39 URL:https://reviews.apache.org/r/66822/diff/raw/ 
[4009/4009] -> "66822.patch" [1]
error: patch failed: src/master/metrics.hpp:222
error: src/master/metrics.hpp: patch does not apply
error: patch failed: src/master/metrics.cpp:549
error: src/master/metrics.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/22870/console

- Mesos Reviewbot


On July 6, 2018, 6:05 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66822/
> ---
> 
> (Updated July 6, 2018, 6:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-8843
> https://issues.apache.org/jira/browse/MESOS-8843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added per Framework Calls to metrics.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 
>   src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/66822/diff/11/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>