date:20180802

Re: Review Request 68175: Windows: Change strings in Windows os code to `wstring`.

2018-08-02 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68175/#review206832
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68174', '68175']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2034/mesos-review-68175

Relevant logs:

- 
[stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2034/mesos-review-68175/logs/stout-tests-stdout.log):

```
[ RUN  ] SocketTests.InitSocket
[   OK ] SocketTests.InitSocket (1 ms)
[ RUN  ] SocketTests.IntFD
[   OK ] SocketTests.IntFD (1 ms)
[--] 2 tests from SocketTests (5 ms total)

[--] 2 tests from StrerrorTest
[ RUN  ] StrerrorTest.ValidErrno
[   OK ] StrerrorTest.ValidErrno (0 ms)
[ RUN  ] StrerrorTest.InvalidErrno
[   OK ] StrerrorTest.InvalidErrno (0 ms)
[--] 2 tests from StrerrorTest (2 ms total)

[--] 2 tests from OsSendfileTest
[ RUN  ] OsSendfileTest.Sendfile
[   OK ] OsSendfileTest.Sendfile (1256 ms)
[ RUN  ] OsSendfileTest.SendfileAsync
[   OK ] OsSendfileTest.SendfileAsync (22 ms)
[--] 2 tests from OsSendfileTest (1280 ms total)

[--] Global test environment tear-down
[==] 333 tests from 52 test cases ran. (6185 ms total)
[  PASSED  ] 332 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OsTest.SYMLINK_Size

 1 FAILED TEST
  YOU HAVE 1 DISABLED TEST

```

- 
[stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2034/mesos-review-68175/logs/stout-tests-stderr.log):

```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command  [OPTIONS]

Available subcommands:
help
subcommand2

Multiple subcommands have name 'subcommand'
```

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2034/mesos-review-68175/logs/mesos-tests-stdout.log):

```
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (30 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (69 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (1667 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (1688 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (1393 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (1413 ms total)

[--] Global test environment tear-down
[==] 1013 tests from 98 test cases ran. (854525 ms total)
[  PASSED  ] 1009 tests.
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout
[  FAILED  ] DockerTest.ROOT_DOCKER_interface
[  FAILED  ] DockerTest.ROOT_DOCKER_CheckPortResource
[  FAILED  ] DockerTest.ROOT_DOCKER_MountRelativeHostPath

 4 FAILED TESTS
  YOU HAVE 222 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2034/mesos-review-68175/logs/mesos-tests-stderr.log):

```
I0803 01:43:29.282469  9860 slave.cpp:3939] Shutting down framework 
6f97b4e3-1042-4667-8920-566a098d0e00-
I0803 01:43:29.282469 12008 master.cpp:10906] Updating the state of task 
c45bbcf8-62d4-44d1-a22f-a459416377fc of framework 
6f97b4e3-1042-4667-8920-566a098d0e00- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0803 01:43:29.282469  9860 slave.cpp:6658] Shutting down executor 
'c45bbcf8-62d4-44d1-a22f-a459416377fc' of framework 
6f97b4e3-1042-4667-8920-566a098d0e00- at executor(1)@192.10.1.6:55084
I0803 01:43:29.284461  9860 slave.cpp:931] Agent terminating
W0803 01:43:29.284461  9860 slave.cpp:3935] Ignoring shutdown framework 
6f97b4e3-1042-4667-8920-566a098d0e00- because it is terminating
I0803 01:43:29.285466 12008 master.cpp:11004] Removing task 
c45bbcf8-62d4-44d1-a22f-a459416377fc with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 6f97bI0803 01:43:28.857455  8312 exec.cpp:162] 
Version: 1.7.0
I0803 01:43:28.883463 15688 exec.cpp:236] Executor registered on agent

Re: Review Request 68176: Fixed gRPC release build on Windows.

2018-08-02 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68176/#review206831
---



PASS: Mesos patch 68176 was successfully built and tested.

Reviews applied: `['68114', '68154', '68091', '68074', '68176']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2036/mesos-review-68176

- Mesos Reviewbot Windows


On Aug. 2, 2018, 4:06 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68176/
> ---
> 
> (Updated Aug. 2, 2018, 4:06 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-8395
> https://issues.apache.org/jira/browse/MESOS-8395
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The gRPC library was by default built by CMake with the "Debug"
> configuration on Windows, even if Mesos is built with the "Release"
> configuration. As a result, gRPC would try to link to the "Debug"
> protobuf library and end up with a failure. This patch fixes this
> problem by explicitly specifying the configuration in gRPC's build
> command.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 8300088aaec5afd5ea92268757235d8561cda916 
> 
> 
> Diff: https://reviews.apache.org/r/68176/diff/1/
> 
> 
> Testing
> ---
> 
> Built and tested using VS on Windows
> Built and tested using VS on Windows with `--config Release`
> Built and tested using Ninja on Linux
> Built and tested using Makefile on Linux
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 68149: Replace exchange in MpscLinkedQueue::dequeue with load/store.

2018-08-02 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68149/#review206830
---



PASS: Mesos patch 68149 was successfully built and tested.

Reviews applied: `['68149']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2035/mesos-review-68149

- Mesos Reviewbot Windows


On Aug. 2, 2018, 9:44 p.m., Dario Rexin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68149/
> ---
> 
> (Updated Aug. 2, 2018, 9:44 p.m.)
> 
> 
> Review request for James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There's only a single consumer, so we don't need to exchange
> in dequeue. Testing shows that a load/store pair is much
> more efficient, as it needs fewer CPU cycles. Especially
> in the empty queue case, where the store does not have to
> be executed at all.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/mpsc_linked_queue.hpp fc55d4389 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 0b94aaf4e 
> 
> 
> Diff: https://reviews.apache.org/r/68149/diff/2/
> 
> 
> Testing
> ---
> 
> Make check and benchmarks.
> 
> Benchmark results:
> 
> Exchange (before):
> 
> [===] Running 3 tests from 1 test case.
> [---] Global test environment set-up.
> [---] 3 tests from ProcessTest
> [ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueue
> Estimated producer throughput (7 threads): 38741698.929628 op/s
> Estimated consumer throughput: 15783395.811778 op/s
> Estimated total throughput: 54525094.741406 op/s
> [OK ] ProcessTest.Process_BENCHMARK_MpscLinkedQueue (4435 ms)
> [ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueEmpty
> Estimated consumer throughput: 182175973.774530 op/s
> [OK ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueEmpty (5489 ms)
> [ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueNonContendedRead
> Estimated producer throughput (7 threads): 41807291.688699 op/s
> Estimated consumer throughput: 21925675.985841 op/s
> Estimated total throughput: 63732967.674541 op/s
> 
> 
> Load/Store (after):
> 
> [===] Running 3 tests from 1 test case.
> [---] Global test environment set-up.
> [---] 3 tests from ProcessTest
> [ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueue
> Estimated producer throughput (7 threads): 39972854.982381 op/s
> Estimated consumer throughput: 18090177.075559 op/s
> Estimated total throughput: 58063032.057939 op/s
> [OK ] ProcessTest.Process_BENCHMARK_MpscLinkedQueue (3870 ms)
> [ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueEmpty
> Estimated consumer throughput: 1457824631.198832 op/s
> [OK ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueEmpty (686 ms)
> [ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueNonContendedRead
> Estimated producer throughput (7 threads): 48031578.693516 op/s
> Estimated consumer throughput: 25242881.515617 op/s
> Estimated total throughput: 73274460.209133 op/s
> 
> 
> File Attachments
> 
> 
> mpsc-load-store.patch
>   
> https://reviews.apache.org/media/uploaded/files/2018/08/02/b8bd71a1-a1c7-47b1-beae-dc9f522ae192__mpsc-load-store.patch
> 
> 
> Thanks,
> 
> Dario Rexin
> 
>

Re: Review Request 68174: Support for `wstring` in stout.

2018-08-02 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68174/#review206828
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68174']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2033/mesos-review-68174

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2033/mesos-review-68174/logs/mesos-tests-stdout.log):

```

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (70 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2065 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2088 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (1790 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (1813 ms total)

[--] Global test environment tear-down
[==] 1013 tests from 98 test cases ran. (835151 ms total)
[  PASSED  ] 1010 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerTest.ROOT_DOCKER_interface
[  FAILED  ] DockerTest.ROOT_DOCKER_CheckPortResource
[  FAILED  ] DockerTest.ROOT_DOCKER_MountRelativeHostPath

 3 FAILED TESTS
  YOU HAVE 222 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2033/mesos-review-68174/logs/mesos-tests-stderr.log):

```
I0802 23:33:28.547227 13112 slave.cpp:3939] Shutting down framework 
dee36f06-6962-4741-9c5a-4e94373ff704-
I0802 23:33:28.547227 13112 slave.cpp:6658] Shutting down executor 'bab3I0802 
23:33:28.149184 15088 exec.cpp:162] Version: 1.7.0
I0802 23:33:28.175191 12256 exec.cpp:236] Executor registered on agent 
dee36f06-6962-4741-9c5a-4e94373ff704-S0
I0802 23:33:28.179196 11072 executor.cpp:182] Received SUBSCRIBED event
I0802 23:33:28.185207 11072 executor.cpp:186] Subscribed executor on 
windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0802 23:33:28.185207 11072 executor.cpp:182] Received LAUNCH event
I0802 23:33:28.190205 11072 executor.cpp:679] Starting task 
bab39778-b2d6-40f5-99e7-71a691ffb26c
I0802 23:33:28.273203 11072 executor.cpp:499] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0802 23:33:28.520193 11072 executor.cpp:693] Forked command at 9368
I0802 23:33:28.550194 12256 exec.cpp:445] Executor asked to shutdown
I0802 23:33:28.551195 15088 executor.cpp:182] Received SHUTDOWN event
I0802 23:33:28.551195 15088 executor.cpp:796] Shutting down
I0802 23:33:28.551195 15088 executor.cpp:909] Sending SIGTERM to process tree 
at pid 9369778-b2d6-40f5-99e7-71a691ffb26c' of framework 
dee36f06-6962-4741-9c5a-4e94373ff704- at executor(1)@192.10.1.6:53038
I0802 23:33:28.547227 15220 master.cpp:10906] Updating the state of task 
bab39778-b2d6-40f5-99e7-71a691ffb26c of framework 
dee36f06-6962-4741-9c5a-4e94373ff704- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0802 23:33:28.550194 13112 slave.cpp:931] Agent terminating
W0802 23:33:28.550194 13112 slave.cpp:3935] Ignoring shutdown framework 
dee36f06-6962-4741-9c5a-4e94373ff704- because it is terminating
I0802 23:33:28.550194 15220 master.cpp:11004] Removing task 
bab39778-b2d6-40f5-99e7-71a691ffb26c with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework dee36f06-6962-4741-9c5a-4e94373ff704- on 
agent dee36f06-6962-4741-9c5a-4e94373ff704-S0 at slave(462)@192.10.1.6:51324 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0802 23:33:28.553192 15220 master.cpp:1281] Agent 
dee36f06-6962-4741-9c5a-4e94373ff704-S0 at slave(462)@192.10.1.6:51324 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0802 23:33:28.554203 15220 master.cpp:3297] Disconnecting agent 
dee36f06-6962-4741-9c5a-4e94373ff704-S0 at slave(462)@192.10.1.6:51324 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0802 23:33:28.554203 15220 master.cpp:3316] Deactivating agent 
dee36f06-6962-4741-9c5a-4e94373ff704-S0 at slave(462)@192.10.1.6:51324

Review Request 68176: Fixed gRPC release build on Windows.

2018-08-02 Thread Chun-Hung Hsiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68176/
---

Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.


Repository: mesos


Description
---

The gRPC library was by default built by CMake with the "Debug"
configuration on Windows, even if Mesos is built with the "Release"
configuration. As a result, gRPC would try to link to the "Debug"
protobuf library and end up with a failure. This patch fixes this
problem by explicitly specifying the configuration in gRPC's build
command.


Diffs
-

  3rdparty/CMakeLists.txt 8300088aaec5afd5ea92268757235d8561cda916 


Diff: https://reviews.apache.org/r/68176/diff/1/


Testing
---

Built and tested using VS on Windows
Built and tested using VS on Windows with `--config Release`
Built and tested using Ninja on Linux
Built and tested using Makefile on Linux


Thanks,

Chun-Hung Hsiao

Re: Review Request 68149: Replace exchange in MpscLinkedQueue::dequeue with load/store.

2018-08-02 Thread Dario Rexin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68149/
---

(Updated Aug. 2, 2018, 9:44 p.m.)


Review request for James Peach.


Repository: mesos


Description
---

There's only a single consumer, so we don't need to exchange
in dequeue. Testing shows that a load/store pair is much
more efficient, as it needs fewer CPU cycles. Especially
in the empty queue case, where the store does not have to
be executed at all.


Diffs (updated)
-

  3rdparty/libprocess/src/mpsc_linked_queue.hpp fc55d4389 
  3rdparty/libprocess/src/tests/benchmarks.cpp 0b94aaf4e 


Diff: https://reviews.apache.org/r/68149/diff/2/

Changes: https://reviews.apache.org/r/68149/diff/1-2/


Testing
---

Make check and benchmarks.

Benchmark results:

Exchange (before):

[===] Running 3 tests from 1 test case.
[---] Global test environment set-up.
[---] 3 tests from ProcessTest
[ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueue
Estimated producer throughput (7 threads): 38741698.929628 op/s
Estimated consumer throughput: 15783395.811778 op/s
Estimated total throughput: 54525094.741406 op/s
[OK ] ProcessTest.Process_BENCHMARK_MpscLinkedQueue (4435 ms)
[ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueEmpty
Estimated consumer throughput: 182175973.774530 op/s
[OK ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueEmpty (5489 ms)
[ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueNonContendedRead
Estimated producer throughput (7 threads): 41807291.688699 op/s
Estimated consumer throughput: 21925675.985841 op/s
Estimated total throughput: 63732967.674541 op/s


Load/Store (after):

[===] Running 3 tests from 1 test case.
[---] Global test environment set-up.
[---] 3 tests from ProcessTest
[ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueue
Estimated producer throughput (7 threads): 39972854.982381 op/s
Estimated consumer throughput: 18090177.075559 op/s
Estimated total throughput: 58063032.057939 op/s
[OK ] ProcessTest.Process_BENCHMARK_MpscLinkedQueue (3870 ms)
[ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueEmpty
Estimated consumer throughput: 1457824631.198832 op/s
[OK ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueEmpty (686 ms)
[ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueNonContendedRead
Estimated producer throughput (7 threads): 48031578.693516 op/s
Estimated consumer throughput: 25242881.515617 op/s
Estimated total throughput: 73274460.209133 op/s


File Attachments


mpsc-load-store.patch
  
https://reviews.apache.org/media/uploaded/files/2018/08/02/b8bd71a1-a1c7-47b1-beae-dc9f522ae192__mpsc-load-store.patch


Thanks,

Dario Rexin

Re: Review Request 68074: Always build gRPC in Mesos.

2018-08-02 Thread Chun-Hung Hsiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68074/
---

(Updated Aug. 2, 2018, 9:44 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
---

Rebased.


Bugs: MESOS-8395
https://issues.apache.org/jira/browse/MESOS-8395


Repository: mesos


Description
---

Always build gRPC in Mesos.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 8300088aaec5afd5ea92268757235d8561cda916 
  3rdparty/Makefile.am e7005fb71b6f4ec06706d26b92c086be077a2925 
  cmake/CompilationConfigure.cmake 50c4c5d3f34499b98aeea28ae430fdacae8b55eb 
  configure.ac 58003b6e823c8457f4b5a8c8d670be43bf96de8d 
  include/csi/spec.hpp 2e9b870617a6604e5d3e93eedce119ec029eea05 
  src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e 
  src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66 
  src/cmake/MesosProtobuf.cmake 9fadc9f0616a00f3c30c1fa81a44e0023ccf865f 
  src/examples/CMakeLists.txt 6a6ee7c3029552ef12726d1c36ccabd8c79ba1f8 
  src/python/native_common/ext_modules.py.in 
dc4d91a8b8e3640e2191a53e657a5e4588fa911e 
  src/resource_provider/local.cpp ae23c2000b7941aad92d3b83e4e905bdf042ebe8 
  src/tests/CMakeLists.txt d4ddd13b35592bca7d56b5a7a1f307e0d3299cbf 


Diff: https://reviews.apache.org/r/68074/diff/4/

Changes: https://reviews.apache.org/r/68074/diff/3-4/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 68149: Replace exchange in MpscLinkedQueue::dequeue with load/store.

2018-08-02 Thread Dario Rexin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68149/
---

(Updated Aug. 2, 2018, 9:43 p.m.)


Review request for James Peach.


Repository: mesos


Description
---

There's only a single consumer, so we don't need to exchange
in dequeue. Testing shows that a load/store pair is much
more efficient, as it needs fewer CPU cycles. Especially
in the empty queue case, where the store does not have to
be executed at all.


Diffs
-

  3rdparty/libprocess/src/mpsc_linked_queue.hpp fc55d4389 
  3rdparty/libprocess/src/tests/benchmarks.cpp 0b94aaf4e 


Diff: https://reviews.apache.org/r/68149/diff/1/


Testing
---

Make check and benchmarks.

Benchmark results:

Exchange (before):

[===] Running 3 tests from 1 test case.
[---] Global test environment set-up.
[---] 3 tests from ProcessTest
[ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueue
Estimated producer throughput (7 threads): 38741698.929628 op/s
Estimated consumer throughput: 15783395.811778 op/s
Estimated total throughput: 54525094.741406 op/s
[OK ] ProcessTest.Process_BENCHMARK_MpscLinkedQueue (4435 ms)
[ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueEmpty
Estimated consumer throughput: 182175973.774530 op/s
[OK ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueEmpty (5489 ms)
[ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueNonContendedRead
Estimated producer throughput (7 threads): 41807291.688699 op/s
Estimated consumer throughput: 21925675.985841 op/s
Estimated total throughput: 63732967.674541 op/s


Load/Store (after):

[===] Running 3 tests from 1 test case.
[---] Global test environment set-up.
[---] 3 tests from ProcessTest
[ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueue
Estimated producer throughput (7 threads): 39972854.982381 op/s
Estimated consumer throughput: 18090177.075559 op/s
Estimated total throughput: 58063032.057939 op/s
[OK ] ProcessTest.Process_BENCHMARK_MpscLinkedQueue (3870 ms)
[ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueEmpty
Estimated consumer throughput: 1457824631.198832 op/s
[OK ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueEmpty (686 ms)
[ RUN   ] ProcessTest.Process_BENCHMARK_MpscLinkedQueueNonContendedRead
Estimated producer throughput (7 threads): 48031578.693516 op/s
Estimated consumer throughput: 25242881.515617 op/s
Estimated total throughput: 73274460.209133 op/s


File Attachments (updated)


mpsc-load-store.patch
  
https://reviews.apache.org/media/uploaded/files/2018/08/02/b8bd71a1-a1c7-47b1-beae-dc9f522ae192__mpsc-load-store.patch


Thanks,

Dario Rexin

Review Request 68175: Windows: Change strings in Windows os code to `wstring`.

2018-08-02 Thread Liangyu Zhao via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68175/
---

Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.


Repository: mesos


Description
---

Functions in `stout/internal/windows` and `stout/os/windows` now use
`std::wstring` instead of `std::string`. Narrow string is still
supported, but will converted to wide string for process. The return
values for functions are unchanged.


Diffs
-

  3rdparty/stout/include/stout/internal/windows/attributes.hpp 
673b744588fee32aa4c462199be0675c392636fb 
  3rdparty/stout/include/stout/internal/windows/longpath.hpp 
499eef30a3d16ac1f6c2e3334ef773e91e987a45 
  3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
280956ff9cfb0efcc5b0aa7ef35473122d9dd8c0 
  3rdparty/stout/include/stout/internal/windows/symlink.hpp 
def5515656a5a454655d6a484c7e52ea12be8a55 
  3rdparty/stout/include/stout/os/constants.hpp 
f81dbb3b7dcd929475324047f32cbabd873bea81 
  3rdparty/stout/include/stout/os/windows/chdir.hpp 
523c7f75bd120b00f815c4c4aac946fdb5dbaaa5 
  3rdparty/stout/include/stout/os/windows/copyfile.hpp 
34723bce9a151582de481d63a865509d4d29c02c 
  3rdparty/stout/include/stout/os/windows/exists.hpp 
50bb92a1e4100a89a346d6bafc6d4133e6e40589 
  3rdparty/stout/include/stout/os/windows/getcwd.hpp 
daf131ac1da705724e85cd236c68685422d2f3c8 
  3rdparty/stout/include/stout/os/windows/getenv.hpp 
034510cff3701f1063c4fa7ff5c0acb63b421717 
  3rdparty/stout/include/stout/os/windows/ls.hpp 
68d5a6037c4c73d6233829259e4fceb4db613a0c 
  3rdparty/stout/include/stout/os/windows/mkdir.hpp 
2aef22a47a80eddc9db0cd4e4ae3daf77c52c05b 
  3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
f742f0838cdc5132286f55775ca042ce8057c166 
  3rdparty/stout/include/stout/os/windows/mktemp.hpp 
b4f5279a58274f02b260bdb3b94c284547842a0f 
  3rdparty/stout/include/stout/os/windows/open.hpp 
b2f033c19027144083dc02cf3d4081b1fb26b501 
  3rdparty/stout/include/stout/os/windows/realpath.hpp 
6bfaaf63f849129793b5b3e2d501623ec83e9d4f 
  3rdparty/stout/include/stout/os/windows/rename.hpp 
523912ac3bf315f70f542e8eab7d2d02249909b4 
  3rdparty/stout/include/stout/os/windows/rm.hpp 
2cacb28ec534e0f3e213d04ddf56168bc2061901 
  3rdparty/stout/include/stout/os/windows/rmdir.hpp 
00821cdb62a02824e26ddb125eca66694165ce1f 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
b9e06d667159d2fb5e266ce7f7e633deb1237a78 
  3rdparty/stout/include/stout/os/windows/stat.hpp 
62256094b9a58779e28dd78f1281a7d8bd7955d0 
  3rdparty/stout/include/stout/os/windows/su.hpp 
ac3a8968f7b9fe6889e13aa47595ae45a094c891 
  3rdparty/stout/include/stout/os/windows/temp.hpp 
4e8543ee6b67f0c2b50a858826e19eed211452bc 
  3rdparty/stout/include/stout/windows/net.hpp 
74398637fe830af0655b1358d4ea52d259a97e9e 
  3rdparty/stout/include/stout/windows/os.hpp 
4f26806e4e027c090c6e7ce07b1bb8d2dabfb531 


Diff: https://reviews.apache.org/r/68175/diff/1/


Testing
---


Thanks,

Liangyu Zhao

Review Request 68174: Support for `wstring` in stout.

2018-08-02 Thread Liangyu Zhao via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68174/
---

Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.


Repository: mesos


Description
---

Use template to extend string support to wstring, mainly for Windows
environment. More information on this can be found in
`developer-guide.md`.


Diffs
-

  3rdparty/stout/include/stout/internal/windows/attributes.hpp 
673b744588fee32aa4c462199be0675c392636fb 
  3rdparty/stout/include/stout/internal/windows/longpath.hpp 
499eef30a3d16ac1f6c2e3334ef773e91e987a45 
  3rdparty/stout/include/stout/internal/windows/symlink.hpp 
def5515656a5a454655d6a484c7e52ea12be8a55 
  3rdparty/stout/include/stout/os/windows/environment.hpp 
40eee59ac0b73ebe71b120e540ba7eace672ff4c 
  3rdparty/stout/include/stout/os/windows/getcwd.hpp 
daf131ac1da705724e85cd236c68685422d2f3c8 
  3rdparty/stout/include/stout/os/windows/getenv.hpp 
034510cff3701f1063c4fa7ff5c0acb63b421717 
  3rdparty/stout/include/stout/os/windows/jobobject.hpp 
7d6678ddedff5732698007fb4d745c37648b964c 
  3rdparty/stout/include/stout/os/windows/ls.hpp 
68d5a6037c4c73d6233829259e4fceb4db613a0c 
  3rdparty/stout/include/stout/os/windows/mktemp.hpp 
b4f5279a58274f02b260bdb3b94c284547842a0f 
  3rdparty/stout/include/stout/os/windows/realpath.hpp 
6bfaaf63f849129793b5b3e2d501623ec83e9d4f 
  3rdparty/stout/include/stout/os/windows/rmdir.hpp 
00821cdb62a02824e26ddb125eca66694165ce1f 
  3rdparty/stout/include/stout/os/windows/shell.hpp 
b9e06d667159d2fb5e266ce7f7e633deb1237a78 
  3rdparty/stout/include/stout/os/windows/su.hpp 
ac3a8968f7b9fe6889e13aa47595ae45a094c891 
  3rdparty/stout/include/stout/os/windows/temp.hpp 
4e8543ee6b67f0c2b50a858826e19eed211452bc 
  3rdparty/stout/include/stout/path.hpp 
ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7 
  3rdparty/stout/include/stout/stringify.hpp 
ef7b26fd30aff2e2554162bdd0370523306b5930 
  3rdparty/stout/include/stout/strings.hpp 
1af3818dd9f906115cf067ca1eb2fb30f85a139d 
  3rdparty/stout/include/stout/windows/fs.hpp 
cc9a56012bd17cf962c8bc6d59ae221fcf19ecba 
  3rdparty/stout/include/stout/windows/net.hpp 
74398637fe830af0655b1358d4ea52d259a97e9e 
  3rdparty/stout/include/stout/windows/os.hpp 
4f26806e4e027c090c6e7ce07b1bb8d2dabfb531 
  3rdparty/stout/tests/recordio_tests.cpp 
177939427a7ef5f15cac318a98e40cf77b0b0ada 
  docs/developer-guide.md 3906275e18801853bd21da18073c9f0e44aba2cd 
  src/docker/executor.cpp f461af91c65fad904bdf7a9f0e6d95763b2b936c 
  src/slave/containerizer/mesos/launch.cpp 
7193da0a094df3e441e185c62b3a0379a0bdc4a2 
  src/tests/common/recordio_tests.cpp 5dd68802ed385c3f7df39e2060bd1f087dbe8ef6 


Diff: https://reviews.apache.org/r/68174/diff/1/


Testing
---


Thanks,

Liangyu Zhao

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

2018-08-02 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68158/
---

(Updated Aug. 2, 2018, 7:17 p.m.)


Review request for mesos, Avinash sridharan, Chun-Hung Hsiao, and Greg Mann.


Changes
---

Fixed a stupid bug.


Bugs: MESOS-9127
https://issues.apache.org/jira/browse/MESOS-9127


Repository: mesos


Description (updated)
---

It is possible that the port mapping cleanup command will cause iptables
to deadlock if there are a lot of entires in the iptables, because the
`sed` won't process the next line while executing 'iptables -w -t nat -D
...'. But the executing of 'iptables -w -t nat -D ...' might get stuck
if the first command 'iptables -w -t nat -S %s' didn't finish (because
the xtables lock is not released). The first command might not finish if
it has a lot of output, filling the pipe that `sed` hasn't had a chance
to process yet. See more details in MESOS-9127.

This patch fixed the issue by writing the commands to a file and then
executing them.


Diffs (updated)
-

  
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
 c40b57f78193520f9f0b901201b5c4c855cde8b3 


Diff: https://reviews.apache.org/r/68158/diff/2/

Changes: https://reviews.apache.org/r/68158/diff/1-2/


Testing
---

sudo make check
```
[   OK ] CniIsolatorPortMapperTest.ROOT_INTERNET_CURL_PortMapper (8827 ms)
```


Thanks,

Jie Yu

Re: Review Request 68167: Avoided hostname lookups in the CNI port mapper.

2018-08-02 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68167/#review206817
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68158', '68167']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2032/mesos-review-68167

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2032/mesos-review-68167/logs/mesos-tests-stdout.log):

```

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (70 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2011 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2033 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (1779 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (1806 ms total)

[--] Global test environment tear-down
[==] 1013 tests from 98 test cases ran. (799762 ms total)
[  PASSED  ] 1010 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout
[  FAILED  ] DockerTest.ROOT_DOCKER_interface
[  FAILED  ] DockerTest.ROOT_DOCKER_CheckPortResource

 3 FAILED TESTS
  YOU HAVE 222 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2032/mesos-review-68167/logs/mesos-tests-stderr.log):

```
I0802 18:32:12.731986 12504 master.cpp:10906] Updating the state of task 
cd7d2bc7-2973-434f-989e-f067e41d57e1 of framework 
65cbebef-ae96-47ce-a4b1-9a26d7b085ae- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0802 18:32:12.731986 14728 slave.cpp:3939] Shutting down framework 
65cbebef-ae96-47ce-a4b1-9a26d7b085ae-
I0802 18:32:12.731986 14728 slave.cpp:6658] Shutting down executor 
'cd7d2bc7-2973-434f-989e-f067e41d57e1' of framework 
65cbebef-ae96-47ce-a4b1-9a26d7b085ae- at executor(1)@192.10.1.6:50974
I0802 18:32:12.732987 14728 slave.cpp:931] Agent terminating
W0802 18:32:12.734993 14728 slave.cpp:3935] Ignoring shutdown framework 65I0802 
18:32:12.343991  9552 exec.cpp:162] Version: 1.7.0
I0802 18:32:12.369982  2088 exec.cpp:236] Executor registered on agent 
65cbebef-ae96-47ce-a4b1-9a26d7b085ae-S0
I0802 18:32:12.373984  9828 executor.cpp:182] Received SUBSCRIBED event
I0802 18:32:12.378980  9828 executor.cpp:186] Subscribed executor on 
windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0802 18:32:12.378980  9828 executor.cpp:182] Received LAUNCH event
I0802 18:32:12.383980  9828 executor.cpp:679] Starting task 
cd7d2bc7-2973-434f-989e-f067e41d57e1
I0802 18:32:12.470983  9828 executor.cpp:499] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0802 18:32:12.703992  9828 executor.cpp:693] Forked command at 3452
I0802 18:32:12.734823  3712 exec.cpp:445] Executor asked to shutdown
I0802 18:32:12.734993  9828 executor.cpp:182] Received SHUTDOWN event
I0802 18:32:12.734993  9828 executor.cpp:796] Shutting down
I0802 18:32:12.734993  9828 executor.cpp:909] Sending SIGTERM to process tree 
at pid 345cbebef-ae96-47ce-a4b1-9a26d7b085ae- because it is terminating
I0802 18:32:12.734993 12504 master.cpp:11004] Removing task 
cd7d2bc7-2973-434f-989e-f067e41d57e1 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 65cbebef-ae96-47ce-a4b1-9a26d7b085ae- on 
agent 65cbebef-ae96-47ce-a4b1-9a26d7b085ae-S0 at slave(462)@192.10.1.6:49249 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0802 18:32:12.737992 12504 master.cpp:1281] Agent 
65cbebef-ae96-47ce-a4b1-9a26d7b085ae-S0 at slave(462)@192.10.1.6:49249 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0802 18:32:12.737992 12504 master.cpp:3297] Disconnecting agent 
65cbebef-ae96-47ce-a4b1-9a26d7b085ae-S0 at slave(462)@192.10.1.6:49249 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0802 18:32:12.738987 12504 master.cpp:3316] Deactivating agent 
65cbebef-ae96-47ce-a4b1-9a26d7b085ae-S0 at slave(462)@192.10.1.6:49249

Re: Review Request 68167: Avoided hostname lookups in the CNI port mapper.

2018-08-02 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68167/#review206806
---


Ship it!




Ship It!

- Jie Yu


On Aug. 2, 2018, 4:30 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68167/
> ---
> 
> (Updated Aug. 2, 2018, 4:30 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-9129
> https://issues.apache.org/jira/browse/MESOS-9129
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using the `-n` option with `iptables --list` prevents potentially
> costly reverse hostname lookups. This patch adds this option to the
> relevant invocation of `iptables` in the CNI port mapper.
> 
> 
> Diffs
> -
> 
>   
> src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
>  c40b57f78193520f9f0b901201b5c4c855cde8b3 
> 
> 
> Diff: https://reviews.apache.org/r/68167/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 68167: Avoided hostname lookups in the CNI port mapper.

2018-08-02 Thread Greg Mann


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68167/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-9129
https://issues.apache.org/jira/browse/MESOS-9129


Repository: mesos


Description
---

Using the `-n` option with `iptables --list` prevents potentially
costly reverse hostname lookups. This patch adds this option to the
relevant invocation of `iptables` in the CNI port mapper.


Diffs
-

  
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
 c40b57f78193520f9f0b901201b5c4c855cde8b3 


Diff: https://reviews.apache.org/r/68167/diff/1/


Testing
---


Thanks,

Greg Mann

Re: Review Request 68166: Moved around some functions definitions between files.

2018-08-02 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68166/#review206801
---



PASS: Mesos patch 68166 was successfully built and tested.

Reviews applied: `['68141', '68166']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2031/mesos-review-68166

- Mesos Reviewbot Windows


On Aug. 2, 2018, 6:23 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68166/
> ---
> 
> (Updated Aug. 2, 2018, 6:23 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit contains some fixups to the movement of the Framework
> implementation code to a separate file in the previous commit.
> 
>  * Changed Framework::send() to use an out-of-class definition.
>  * Moved back trivial functions back to the header file.
>  * Moved private constructor to the top of the file in `framework.cpp`.
> 
> 
> Diffs
> -
> 
>   src/master/framework.cpp PRE-CREATION 
>   src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 
> 
> 
> Diff: https://reviews.apache.org/r/68166/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68141: Moved Framework implementation into separate file.

2018-08-02 Thread Alexander Rukletsov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/#review206799
---




src/Makefile.am
Lines 1021 (patched)


Please tabs in Makefile.


- Alexander Rukletsov


On Aug. 2, 2018, 1:23 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68141/
> ---
> 
> (Updated Aug. 2, 2018, 1:23 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-2633
> https://issues.apache.org/jira/browse/MESOS-2633
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change aims to reduce compile time and cognitive
> load when browsing the "master.hpp" header.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e 
>   src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66 
>   src/master/framework.cpp PRE-CREATION 
>   src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 
>   src/master/master.cpp 192fe8299777f68bf6f48d693ef79ff75fecfe00 
> 
> 
> Diff: https://reviews.apache.org/r/68141/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68166: Moved around some functions definitions between files.

2018-08-02 Thread Benno Evers


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68166/
---

(Updated Aug. 2, 2018, 1:23 p.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

This commit contains some fixups to the movement of the Framework
implementation code to a separate file in the previous commit.

 * Changed Framework::send() to use an out-of-class definition.
 * Moved back trivial functions back to the header file.
 * Moved private constructor to the top of the file in `framework.cpp`.


Diffs (updated)
-

  src/master/framework.cpp PRE-CREATION 
  src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 


Diff: https://reviews.apache.org/r/68166/diff/2/

Changes: https://reviews.apache.org/r/68166/diff/1-2/


Testing
---


Thanks,

Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

2018-08-02 Thread Benno Evers


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/
---

(Updated Aug. 2, 2018, 1:23 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Re-uploaded commits to investigate failure to apply patches.


Bugs: MESOS-2633
https://issues.apache.org/jira/browse/MESOS-2633


Repository: mesos


Description
---

This change aims to reduce compile time and cognitive
load when browsing the "master.hpp" header.


Diffs (updated)
-

  src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e 
  src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66 
  src/master/framework.cpp PRE-CREATION 
  src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 
  src/master/master.cpp 192fe8299777f68bf6f48d693ef79ff75fecfe00 


Diff: https://reviews.apache.org/r/68141/diff/4/

Changes: https://reviews.apache.org/r/68141/diff/3-4/


Testing
---

`make check`


Thanks,

Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

2018-08-02 Thread Alexander Rukletsov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/#review206797
---


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 2, 2018, 12:17 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68141/
> ---
> 
> (Updated Aug. 2, 2018, 12:17 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-2633
> https://issues.apache.org/jira/browse/MESOS-2633
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change aims to reduce compile time and cognitive
> load when browsing the "master.hpp" header.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e 
>   src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66 
>   src/master/framework.cpp PRE-CREATION 
>   src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 
>   src/master/master.cpp 192fe8299777f68bf6f48d693ef79ff75fecfe00 
> 
> 
> Diff: https://reviews.apache.org/r/68141/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68166: Moved around some functions definitions between files.

2018-08-02 Thread Alexander Rukletsov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68166/#review206796
---


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 2, 2018, 12:17 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68166/
> ---
> 
> (Updated Aug. 2, 2018, 12:17 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit contains some fixups to the movement of the Framework
> implementation code to a separate file in the previous commit.
> 
>  * Changed Framework::send() to use an out-of-class definition.
>  * Moved back trivial functions back to the header file.
>  * Moved private constructor to the top of the file in `framework.cpp`.
> 
> 
> Diffs
> -
> 
>   src/master/framework.cpp PRE-CREATION 
>   src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 
> 
> 
> Diff: https://reviews.apache.org/r/68166/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68141: Moved Framework implementation into separate file.

2018-08-02 Thread Benno Evers



> On Aug. 2, 2018, 10:33 a.m., Alexander Rukletsov wrote:
> > src/master/master.hpp
> > Lines 2981-2983 (original)
> > 
> >
> > I think these qualify to stay in ".hpp".

Letting functions stay in header files can of course be good for inlining, but 
there are advantages to moving even "small" functions to separate object files:
- it makes the function easier to grep for since one can use 
`Framework::active` as pattern
- it makes it easier to find the function when it is defined in the same file 
as all the other functions
- it removes subjectivity about when a function is "simple enough" to be 
defined inline from subsequent reviews

I moved them back to the `.hpp` in the subsequent review, but I changed them to 
be out-of-class definitions due to reasons (1) and (3) above.


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/#review206788
---


On Aug. 2, 2018, 12:17 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68141/
> ---
> 
> (Updated Aug. 2, 2018, 12:17 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-2633
> https://issues.apache.org/jira/browse/MESOS-2633
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change aims to reduce compile time and cognitive
> load when browsing the "master.hpp" header.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e 
>   src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66 
>   src/master/framework.cpp PRE-CREATION 
>   src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 
>   src/master/master.cpp 192fe8299777f68bf6f48d693ef79ff75fecfe00 
> 
> 
> Diff: https://reviews.apache.org/r/68141/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 68166: Moved around some functions definitions between files.

2018-08-02 Thread Benno Evers


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68166/
---

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

This commit contains some fixups to the movement of the Framework
implementation code to a separate file in the previous commit.

 * Changed Framework::send() to use an out-of-class definition.
 * Moved back trivial functions back to the header file.
 * Moved private constructor to the top of the file in `framework.cpp`.


Diffs
-

  src/master/framework.cpp PRE-CREATION 
  src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 


Diff: https://reviews.apache.org/r/68166/diff/1/


Testing
---


Thanks,

Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

2018-08-02 Thread Benno Evers


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/
---

(Updated Aug. 2, 2018, 12:17 p.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-2633
https://issues.apache.org/jira/browse/MESOS-2633


Repository: mesos


Description
---

This change aims to reduce compile time and cognitive
load when browsing the "master.hpp" header.


Diffs (updated)
-

  src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e 
  src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66 
  src/master/framework.cpp PRE-CREATION 
  src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 
  src/master/master.cpp 192fe8299777f68bf6f48d693ef79ff75fecfe00 


Diff: https://reviews.apache.org/r/68141/diff/3/

Changes: https://reviews.apache.org/r/68141/diff/2-3/


Testing
---

`make check`


Thanks,

Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

2018-08-02 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/#review206794
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68141']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2030/mesos-review-68141

Relevant logs:

- 
[mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2030/mesos-review-68141/logs/mesos-tests-cmake-stdout.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500):
 warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define 
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170):
 warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496):
 warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256):
 warning C4090: 'function': different 'const' qualifiers 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166):
 warning C4716: 'pthread_cond_broadcast': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
 warning C4716: 'pthread_cond_wait': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]

Re: Review Request 67894: Migrated mesos python package to python3.6.

2018-08-02 Thread Armand Grillet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67894/#review206792
---


Fix it, then Ship it!





src/python/lib/tox.ini
Line 7 (original), 7 (patched)


Changes to that file can be removed following the Mesos CLI update to 
Python 3.


- Armand Grillet


On July 12, 2018, 8:09 a.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67894/
> ---
> 
> (Updated July 12, 2018, 8:09 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, Kevin Klues, and Zhitao 
> Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Migrated mesos python package to python3.6.
> 
> 
> Diffs
> -
> 
>   src/python/lib/mesos/exceptions.py 63c7aa632da618d6efb74124d607f5744ca64ce5 
>   src/python/lib/mesos/http.py 073c159dc6916fa5d7349a033db022d7175aef05 
>   src/python/lib/tests/conftest.py d4d6efcc45d1266749c5750c3ab47dd742b927c1 
>   src/python/lib/tests/test_http.py 66dd6d7c6272d1828dd591829ca3543d3430f69b 
>   src/python/lib/tests/test_mesos.py 285a071e3d8ed2b61646264ddccd8bb38df2c0dd 
>   src/python/lib/tox.ini 05b633e837fa39a36fb2c5a0778513ce743099db 
> 
> 
> Diff: https://reviews.apache.org/r/67894/diff/1/
> 
> 
> Testing
> ---
> 
> Ran `tox` under `src/python/lib`
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

2018-08-02 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68163/#review206790
---



FAIL: Failed to apply the dependent review: 66811.

Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 66811`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2029/mesos-review-68163

Relevant logs:

- 
[apply-review-66811-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2029/mesos-review-68163/logs/apply-review-66811-stdout.log):

```
error: patch failed: 3rdparty/stout/CMakeLists.txt:30
error: 3rdparty/stout/CMakeLists.txt: patch does not apply
```

- Mesos Reviewbot Windows


On Aug. 2, 2018, 9:34 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68163/
> ---
> 
> (Updated Aug. 2, 2018, 9:34 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 6afc56cecbf6f06615dbc8632578332e6f7fb6ae 
> 
> 
> Diff: https://reviews.apache.org/r/68163/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68147: Added agent support to remove local resource providers.

2018-08-02 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68147/#review206789
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68143', '68144', '68145', '68146', '68147']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2028/mesos-review-68147

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2028/mesos-review-68147/logs/mesos-tests-stdout.log):

```
[--] 9 tests from Endpoint/SlaveEndpointTest (980 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (31 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (70 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (1166 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (1187 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (1891 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (1914 ms total)

[--] Global test environment tear-down
[==] 1017 tests from 98 test cases ran. (737321 ms total)
[  PASSED  ] 1015 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] DockerTest.ROOT_DOCKER_interface
[  FAILED  ] DockerTest.ROOT_DOCKER_kill

 2 FAILED TESTS
  YOU HAVE 222 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2028/mesos-review-68147/logs/mesos-tests-stderr.log):

```
I0802 11:12:05.241119 12580 slave.cpp:3939] Shutting down framework 
b05da931-60cd-4f01-95c3-fde8eb96c9e7-
I0802 11:12:05.241119  1596 master.cpp:10963] Updating the state of task 
ea44f51e-006c-4f2f-95a7-c1de36c6229f of framework 
b05da931-60cd-4f01-95c3-fde8eb96c9e7- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0802 11:12:05.241119 12580 slave.cpp:6658] Shutting down executor 
'ea44f51e-006c-4f2f-95a7-c1de36c6229f' of framework b05da931-60cd-I0802 
11:12:04.184103 11216 exec.cpp:162] Version: 1.7.0
I0802 11:12:04.209116 12352 exec.cpp:236] Executor registered on agent 
b05da931-60cd-4f01-95c3-fde8eb96c9e7-S0
I0802 11:12:04.214114 11908 executor.cpp:182] Received SUBSCRIBED event
I0802 11:12:04.218117 11908 executor.cpp:186] Subscribed executor on 
windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0802 11:12:04.219120 11908 executor.cpp:182] Received LAUNCH event
I0802 11:12:04.223115 11908 executor.cpp:679] Starting task 
ea44f51e-006c-4f2f-95a7-c1de36c6229f
I0802 11:12:04.308123 11908 executor.cpp:499] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0802 11:12:05.215116 11908 executor.cpp:693] Forked command at 14264
I0802 11:12:05.244125  9860 exec.cpp:445] Executor asked to shutdown
I0802 11:12:05.245126 11908 executor.cpp:182] Received SHUTDOWN event
I0802 11:12:05.245126 11908 executor.cpp:796] Shutting down
I0802 11:12:05.245126 11908 executor.cpp:909] Sending SIGTERM to process tree 
at pid 144f01-95c3-fde8eb96c9e7- at executor(1)@192.10.1.6:63036
I0802 11:12:05.243126  1596 master.cpp:11061] Removing task 
ea44f51e-006c-4f2f-95a7-c1de36c6229f with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework b05da931-60cd-4f01-95c3-fde8eb96c9e7- on 
agent b05da931-60cd-4f01-95c3-fde8eb96c9e7-S0 at slave(464)@192.10.1.6:61259 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0802 11:12:05.243126 12580 slave.cpp:931] Agent terminating
W0802 11:12:05.244125 12580 slave.cpp:3935] Ignoring shutdown framework 
b05da931-60cd-4f01-95c3-fde8eb96c9e7- because it is terminating
I0802 11:12:05.246127  1396 master.cpp:1338] Agent 
b05da931-60cd-4f01-95c3-fde8eb96c9e7-S0 at slave(464)@192.10.1.6:61259 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0802 11:12:05.246127  1396 master.cpp:3354] Disconnecting agent 
b05da931-60cd-4f01-95c3-fde8eb96c9e7-S0 at slave(464)@192.10.1.6:61259 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0802 11:12:05.247131  1396 master.cpp:3373] Deactivating agent 
b05da931-60cd-4f01-95c3-fde8eb96c9e7-S0 at slave(464)@192.10.1.6:61259

Re: Review Request 68141: Moved Framework implementation into separate file.

2018-08-02 Thread Alexander Rukletsov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/#review206788
---




src/master/master.hpp
Lines 2981-2983 (original)


I think these qualify to stay in ".hpp".



src/master/master.hpp
Lines 2985-2987 (original), 2449-2451 (patched)


Can you please move all `Framework::*` definitions from "master.cpp" to 
"framework.cpp"?


- Alexander Rukletsov


On Aug. 2, 2018, 10:26 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68141/
> ---
> 
> (Updated Aug. 2, 2018, 10:26 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-2633
> https://issues.apache.org/jira/browse/MESOS-2633
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change aims to reduce compile time and cognitive
> load when browsing the "master.hpp" header.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e 
>   src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66 
>   src/master/framework.cpp PRE-CREATION 
>   src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 
> 
> 
> Diff: https://reviews.apache.org/r/68141/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68141: Moved Framework implementation into separate file.

2018-08-02 Thread Benno Evers


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/
---

(Updated Aug. 2, 2018, 10:26 a.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-2633
https://issues.apache.org/jira/browse/MESOS-2633


Repository: mesos


Description (updated)
---

This change aims to reduce compile time and cognitive
load when browsing the "master.hpp" header.


Diffs
-

  src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e 
  src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66 
  src/master/framework.cpp PRE-CREATION 
  src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 


Diff: https://reviews.apache.org/r/68141/diff/2/


Testing
---

`make check`


Thanks,

Benno Evers

Re: Review Request 68141: Moved Framework implementation into separate file.

2018-08-02 Thread Benno Evers


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68141/
---

(Updated Aug. 2, 2018, 10:18 a.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rebased onto master.


Bugs: MESOS-2633
https://issues.apache.org/jira/browse/MESOS-2633


Repository: mesos


Description (updated)
---

Moved Framework implementation into separate file.

This change should hopefully reduce compile times and reduce cognitive load 
when browsing through through the `master.hpp` header.


Diffs (updated)
-

  src/CMakeLists.txt 398ffdddb757e96cfeda376bd983823b9a93904e 
  src/Makefile.am 2ad719e408e56294d308dca1da9f6ea800450a66 
  src/master/framework.cpp PRE-CREATION 
  src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 


Diff: https://reviews.apache.org/r/68141/diff/2/

Changes: https://reviews.apache.org/r/68141/diff/1-2/


Testing (updated)
---

`make check`


Thanks,

Benno Evers

Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.

2018-08-02 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68162/
---

(Updated Aug. 2, 2018, 5:38 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.


Diffs (updated)
-

  src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
84b342cdd4b8ef4803725ecfa9f922687ccdadd8 


Diff: https://reviews.apache.org/r/68162/diff/2/

Changes: https://reviews.apache.org/r/68162/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

2018-08-02 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68163/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
6afc56cecbf6f06615dbc8632578332e6f7fb6ae 


Diff: https://reviews.apache.org/r/68163/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang

Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.

2018-08-02 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68162/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.


Diffs
-

  src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
84b342cdd4b8ef4803725ecfa9f922687ccdadd8 


Diff: https://reviews.apache.org/r/68162/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 68161: Granted container user permissions for shared persistent volume.

2018-08-02 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68161/
---

(Updated Aug. 2, 2018, 5:31 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Granted container user permissions for shared persistent volume.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
a47899cb528eef103f299def3bd3466905ac5b51 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
f91a2eeb835bb65a855eeb314d4c69e3b58fecae 


Diff: https://reviews.apache.org/r/68161/diff/1/


Testing
---


Thanks,

Qian Zhang

Review Request 68161: Granted container user permissions for shared persistent volume.

2018-08-02 Thread Qian Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68161/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8812
https://issues.apache.org/jira/browse/MESOS-8812


Repository: mesos


Description
---

Granted container user permissions for shared persistent volume.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
a47899cb528eef103f299def3bd3466905ac5b51 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
f91a2eeb835bb65a855eeb314d4c69e3b58fecae 


Diff: https://reviews.apache.org/r/68161/diff/1/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 68154: Fixed gRPC compilation for standalone libprocess build with Clang.

2018-08-02 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68154/#review206787
---


Ship it!




Ship It!

- Benjamin Bannier


On Aug. 1, 2018, 11:53 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68154/
> ---
> 
> (Updated Aug. 1, 2018, 11:53 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-8395
> https://issues.apache.org/jira/browse/MESOS-8395
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When compiling gRPC with Clang, there are some array-out-of-bound
> warnings due to the use of GLIBC's `__strcmp_cg` macro in the c-ares
> library. With `-Werror` on, these warnings would stop gRPC from
> compiling. This patch ignores such errors.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> da350b1d36b9f545372999f38acc5022a9ca1034 
> 
> 
> Diff: https://reviews.apache.org/r/68154/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` for libprocess
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

2018-08-02 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68158/#review206785
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68158']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2027/mesos-review-68158

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2027/mesos-review-68158/logs/mesos-tests-stdout.log):

```
[--] 9 tests from Endpoint/SlaveEndpointTest (982 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (31 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (35 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (1201 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (1222 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (1389 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (1411 ms total)

[--] Global test environment tear-down
[==] 1013 tests from 98 test cases ran. (700445 ms total)
[  PASSED  ] 1011 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] DockerTest.ROOT_DOCKER_interface
[  FAILED  ] DockerTest.ROOT_DOCKER_kill

 2 FAILED TESTS
  YOU HAVE 222 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2027/mesos-review-68158/logs/mesos-tests-stderr.log):

```
I0802 07:06:49.881471 12444 slave.cpp:3939] Shutting down framework 
8297884e-f31b-4b26-9c8c-ccfb744f6787-
I0802 07:06:49.881471 11216 master.cpp:10963] Updating the state of task 
532adba1-32d4-44be-ad63-aba7a2b057a5 of framework 
8297884e-f31b-4b26-9c8c-ccfb744f6787- (latest state: TASK_KILLED, statI0802 
07:06:49.581436 12220 exec.cpp:162] Version: 1.7.0
I0802 07:06:49.606456  6056 exec.cpp:236] Executor registered on agent 
8297884e-f31b-4b26-9c8c-ccfb744f6787-S0
I0802 07:06:49.609436  7708 executor.cpp:182] Received SUBSCRIBED event
I0802 07:06:49.614432  7708 executor.cpp:186] Subscribed executor on 
windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0802 07:06:49.614432  7708 executor.cpp:182] Received LAUNCH event
I0802 07:06:49.619463  7708 executor.cpp:679] Starting task 
532adba1-32d4-44be-ad63-aba7a2b057a5
I0802 07:06:49.698460  7708 executor.cpp:499] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0802 07:06:49.853458  7708 executor.cpp:693] Forked command at 12168
I0802 07:06:49.883463  4152 exec.cpp:445] Executor asked to shutdown
I0802 07:06:49.884474 10908 executor.cpp:182] Received SHUTDOWN event
I0802 07:06:49.884474 10908 executor.cpp:796] Shutting down
I0802 07:06:49.884474 10908 executor.cpp:909] Sending SIGTERM to process tree 
at pid 12us update state: TASK_KILLED)
I0802 07:06:49.881471 12444 slave.cpp:6658] Shutting down executor 
'532adba1-32d4-44be-ad63-aba7a2b057a5' of framework 
8297884e-f31b-4b26-9c8c-ccfb744f6787- at executor(1)@192.10.1.6:60867
I0802 07:06:49.883463 12444 slave.cpp:931] Agent terminating
W0802 07:06:49.883463 12444 slave.cpp:3935] Ignoring shutdown framework 
8297884e-f31b-4b26-9c8c-ccfb744f6787- because it is terminating
I0802 07:06:49.883463 11216 master.cpp:11061] Removing task 
532adba1-32d4-44be-ad63-aba7a2b057a5 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 8297884e-f31b-4b26-9c8c-ccfb744f6787- on 
agent 8297884e-f31b-4b26-9c8c-ccfb744f6787-S0 at slave(462)@192.10.1.6:59164 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0802 07:06:49.887471 11216 master.cpp:1338] Agent 
8297884e-f31b-4b26-9c8c-ccfb744f6787-S0 at slave(462)@192.10.1.6:59164 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0802 07:06:49.887471 11216 master.cpp:3354] Disconnecting agent 
8297884e-f31b-4b26-9c8c-ccfb744f6787-S0 at slave(462)@192.10.1.6:59164 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0802 07:06:49.888473 11216 master.cpp:3373] Deactivating agent 
8297884e-f31b-4b26-9c8c-ccfb744f6787-S0 at slave(462)@192.10.1.6:59164

37 matches

Mail list logo