Re: Review Request 44669: Implemented create methods in MasterContender and MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated April 6, 2016, 4:03 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The create method can be used to create a MasterContender/Detector from a module (specified using the --modules flag on the command line). If the contender/detector module names have not been specified, the method will fall back to its prior behavior. Diffs (updated) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION src/master/contender/contender.cpp PRE-CREATION src/master/detector/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44670: Added master_detector and master_contender flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated April 6, 2016, 4:03 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The master_detector and master_contender flags allow modules to be used for specifying the MasterContender and MasterDetector implementations to use. Diffs (updated) - src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 src/master/main.cpp 181bbcb1758c0e9b83ef46496e990ce3d8c2195c src/slave/flags.hpp 69e1b01e09d2a15bee5e0745b751f47aaefe3fbe src/slave/flags.cpp 315cf47d268bce0a0255a061d64e414c736c8125 src/slave/main.cpp dc3a2d2908ec08df60651dec6bf8eac651579cea Diff: https://reviews.apache.org/r/44670/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh
Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated April 6, 2016, 4:03 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector are now defined in include/mesos/master/contender.hpp and detector.hpp. Diffs (updated) - src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44545: Separated standalone and zookeeper classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated April 6, 2016, 4:03 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. Diffs (updated) - src/Makefile.am 55d3b341361bed25f3aa966d77060c88be29e5b0 src/local/local.cpp 0d980188f933a8d543af696d8addd7ca5855413e src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/contender.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 src/master/contender/contender.cpp PRE-CREATION src/master/contender/standalone.hpp PRE-CREATION src/master/contender/standalone.cpp PRE-CREATION src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/detector/detector.cpp PRE-CREATION src/master/detector/standalone.cpp PRE-CREATION src/master/detector/zookeeper.hpp PRE-CREATION src/master/main.cpp 181bbcb1758c0e9b83ef46496e990ce3d8c2195c src/master/master.hpp e5b16f94fa5650b9db44cd7c975adeb5871e16f6 src/slave/main.cpp dc3a2d2908ec08df60651dec6bf8eac651579cea src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 src/tests/cluster.cpp eefc2fa55bca1ad6a53047046fa4f5996d5c3fef src/tests/containerizer/external_containerizer_test.cpp 5e2116355418f5a0716cfd1573bab48ba75df596 src/tests/containerizer/isolator_tests.cpp 7e16846e97e20a7ef058dd8ae4664fa1c554283d src/tests/fault_tolerance_tests.cpp 67238876952bb9a694cb04722113417a4b4eb58d src/tests/gc_tests.cpp 68a789cc77b5f1a17b8d002900095b18b1794ddd src/tests/master_allocator_tests.cpp 9d74b9ed4b6a4c708f3a044a03ce631899acf4aa src/tests/master_authorization_tests.cpp 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d src/tests/master_contender_detector_tests.cpp 616a2c7316adc116071feaad95e3901ff66213ad src/tests/master_slave_reconciliation_tests.cpp 988f1d46580ab5a707fe801824e24f94d4f50da7 src/tests/master_tests.cpp bb599c952128e80e71beb2686e8665e5554856bc src/tests/mesos.hpp 3b565b45f45c84aba42aa6fb29b21f8306c49861 src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e src/tests/persistent_volume_tests.cpp 47867505f2f1d7a722b5a0d4ff3a0fca3188a193 src/tests/reconciliation_tests.cpp 5f2a35efe039da41992057c50e0319c6827f8d22 src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd src/tests/scheduler_tests.cpp 0c66f65825a1fff01774bf0d94b08b9c22b1fbda src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44547: Added functions in promises to the future header.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated April 6, 2016, 4:03 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added functions in promises to the future header. Diffs (updated) - 3rdparty/libprocess/include/process/future.hpp ae4f2d659f1540c50dc1975f5771c6291c3b0c57 Diff: https://reviews.apache.org/r/44547/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44546: Moved functions in promises to a common header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated April 6, 2016, 4:03 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved functions in promises to a common header file. Diffs (updated) - src/master/detector/standalone.cpp PRE-CREATION src/master/detector/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44289: Added support for contender and detector modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated April 6, 2016, 4:03 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added support for contender and detector modules. Diffs (updated) - include/mesos/module/contender.hpp PRE-CREATION include/mesos/module/detector.hpp PRE-CREATION src/Makefile.am 55d3b341361bed25f3aa966d77060c88be29e5b0 src/examples/test_master_contender_module.cpp PRE-CREATION src/examples/test_master_detector_module.cpp PRE-CREATION src/local/local.cpp 0d980188f933a8d543af696d8addd7ca5855413e src/master/contender/zookeeper.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 src/master/detector/zookeeper.cpp PRE-CREATION src/module/manager.cpp 7850fd3e1e574e1a92289118e2e27c62b68eaf05 src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a Diff: https://reviews.apache.org/r/44289/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44544: Moved contender and detector definitions into separate directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated April 6, 2016, 4:03 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Updated Makefile.am. Diffs (updated) - src/Makefile.am 55d3b341361bed25f3aa966d77060c88be29e5b0 src/master/contender/contender.hpp PRE-CREATION src/master/contender/contender.cpp PRE-CREATION src/master/detector/detector.hpp PRE-CREATION src/master/detector/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44288: Changed MasterDetector/Contender namespace.
/resource_offers_tests.cpp 1cf292ee7931207596f8f06677386bef5965ef15 src/tests/role_tests.cpp 20ccca3ecdc53c65abd61190ef9f867c8e860578 src/tests/scheduler_driver_tests.cpp 824aa96106808f7e259fb755257034c89c997287 src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd src/tests/scheduler_tests.cpp 0c66f65825a1fff01774bf0d94b08b9c22b1fbda src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 src/tests/status_update_manager_tests.cpp af989a91ccc6d926aec1526dab1abb8ad9dc7a3d Diff: https://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated April 6, 2016, 4:02 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector abstract classes can be subclassed by user-provided classes to allow for arbitrary contender/detector implementations. Diffs (updated) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44546: Moved functions in promises to a common header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated April 6, 2016, 3:14 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved functions in promises to a common header file. Diffs (updated) - src/master/detector/standalone.cpp PRE-CREATION src/master/detector/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44669: Implemented create methods in MasterContender and MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated April 6, 2016, 3:14 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The create method can be used to create a MasterContender/Detector from a module (specified using the --modules flag on the command line). If the contender/detector module names have not been specified, the method will fall back to its prior behavior. Diffs (updated) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION src/master/contender/contender.cpp PRE-CREATION src/master/detector/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44288: Changed MasterDetector/Contender namespace.
/resource_offers_tests.cpp 1cf292ee7931207596f8f06677386bef5965ef15 src/tests/role_tests.cpp 20ccca3ecdc53c65abd61190ef9f867c8e860578 src/tests/scheduler_driver_tests.cpp 824aa96106808f7e259fb755257034c89c997287 src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd src/tests/scheduler_tests.cpp 0c66f65825a1fff01774bf0d94b08b9c22b1fbda src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 src/tests/status_update_manager_tests.cpp af989a91ccc6d926aec1526dab1abb8ad9dc7a3d Diff: https://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44545: Separated standalone and zookeeper classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated April 6, 2016, 3:14 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. Diffs (updated) - src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 src/local/local.cpp 0d980188f933a8d543af696d8addd7ca5855413e src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/contender.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 src/master/contender/contender.cpp PRE-CREATION src/master/contender/standalone.hpp PRE-CREATION src/master/contender/standalone.cpp PRE-CREATION src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/detector/detector.cpp PRE-CREATION src/master/detector/standalone.cpp PRE-CREATION src/master/detector/zookeeper.hpp PRE-CREATION src/master/main.cpp 181bbcb1758c0e9b83ef46496e990ce3d8c2195c src/master/master.hpp e5b16f94fa5650b9db44cd7c975adeb5871e16f6 src/slave/main.cpp dc3a2d2908ec08df60651dec6bf8eac651579cea src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 src/tests/cluster.cpp eefc2fa55bca1ad6a53047046fa4f5996d5c3fef src/tests/containerizer/external_containerizer_test.cpp 5e2116355418f5a0716cfd1573bab48ba75df596 src/tests/containerizer/isolator_tests.cpp 7e16846e97e20a7ef058dd8ae4664fa1c554283d src/tests/fault_tolerance_tests.cpp 67238876952bb9a694cb04722113417a4b4eb58d src/tests/gc_tests.cpp 68a789cc77b5f1a17b8d002900095b18b1794ddd src/tests/master_allocator_tests.cpp 9d74b9ed4b6a4c708f3a044a03ce631899acf4aa src/tests/master_authorization_tests.cpp 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d src/tests/master_contender_detector_tests.cpp 616a2c7316adc116071feaad95e3901ff66213ad src/tests/master_slave_reconciliation_tests.cpp 988f1d46580ab5a707fe801824e24f94d4f50da7 src/tests/master_tests.cpp bb599c952128e80e71beb2686e8665e5554856bc src/tests/mesos.hpp 98f97101d89cb91ca5e773e7a91f04ee1b8a0d88 src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e src/tests/persistent_volume_tests.cpp 47867505f2f1d7a722b5a0d4ff3a0fca3188a193 src/tests/reconciliation_tests.cpp 5f2a35efe039da41992057c50e0319c6827f8d22 src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd src/tests/scheduler_tests.cpp 0c66f65825a1fff01774bf0d94b08b9c22b1fbda src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44670: Added master_detector and master_contender flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated April 6, 2016, 3:14 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The master_detector and master_contender flags allow modules to be used for specifying the MasterContender and MasterDetector implementations to use. Diffs (updated) - src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 src/master/main.cpp 181bbcb1758c0e9b83ef46496e990ce3d8c2195c src/slave/flags.hpp d0c606eea74e1a2e69067c43a267047e65a22a04 src/slave/flags.cpp 04d4b61503091a67c1e31fc08b519c08385669e5 src/slave/main.cpp dc3a2d2908ec08df60651dec6bf8eac651579cea Diff: https://reviews.apache.org/r/44670/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh
Re: Review Request 44289: Added support for contender and detector modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated April 6, 2016, 3:14 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added support for contender and detector modules. Diffs (updated) - include/mesos/module/contender.hpp PRE-CREATION include/mesos/module/detector.hpp PRE-CREATION src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 src/examples/test_master_contender_module.cpp PRE-CREATION src/examples/test_master_detector_module.cpp PRE-CREATION src/local/local.cpp 0d980188f933a8d543af696d8addd7ca5855413e src/master/contender/zookeeper.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 src/master/detector/zookeeper.cpp PRE-CREATION src/module/manager.cpp 7850fd3e1e574e1a92289118e2e27c62b68eaf05 src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a Diff: https://reviews.apache.org/r/44289/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44547: Added functions in promises to the future header.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated April 6, 2016, 3:14 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added functions in promises to the future header. Diffs (updated) - 3rdparty/libprocess/include/process/future.hpp ae4f2d659f1540c50dc1975f5771c6291c3b0c57 Diff: https://reviews.apache.org/r/44547/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44544: Moved contender and detector definitions into separate directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated April 6, 2016, 3:13 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description (updated) --- Updated Makefile.am. Diffs (updated) - src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 src/master/contender/contender.hpp PRE-CREATION src/master/contender/contender.cpp PRE-CREATION src/master/detector/detector.hpp PRE-CREATION src/master/detector/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated April 6, 2016, 3:13 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector are now defined in include/mesos/master/contender.hpp and detector.hpp. Diffs (updated) - src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated April 6, 2016, 3:13 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector abstract classes can be subclassed by user-provided classes to allow for arbitrary contender/detector implementations. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp 96d395d37cdad706c2f23fdd9caeefc2a33e0541 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp ef365e4d714a2c25d358a702722c5f1216869382 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp 232588c46c8207c6a002f60d00aa675f9e505083 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp 46e3ec25cbf379fb2b82297849216b0866baf333 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 89dedec0c818263f17f220a2e71ed470bf75a42f 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp d634491b301632ce6468f86d04f21fa25afbbaaa 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 66e16abe914e2a1ee7599bab857ff478b7ec20dc 3rdparty/libprocess/include/process/network.hpp 2bc940fb3ba2bc6b2fed281a3920d13fdb1277e9 3rdparty/libprocess/src/encoder.hpp 69163830eaa9f77132a16fc14351b309144827bf 3rdparty/libprocess/src/poll_socket.cpp cb2878565a112017b190b4ff83dc65a876ea45f9 3rdparty/libprocess/src/time.cpp a6c3f3de69e056544406f4416c2d0aea06adc34d CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e docs/app-framework-development-guide.md c5badd00121e7d1752dd2a4b471f97b80ef07926 docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c docs/fetcher.md fd6d8a78bd35c5644dceff7005dd7dfd9f5f2171 include/mesos/docker/spec.hpp 2ebacc70d92a593c8dd006b34519c3a2a5225481 include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION include/mesos/scheduler.hpp 5b153d2acb705cc54fcca86914af72d8b2e3fb55 src/Makefile.am 55d3b341361bed25f3aa966d77060c88be29e5b0 src/docker/docker.hpp da6e9a25b99079940958001128ee949cdb9b931b src/docker/docker.cpp bb9ddde27464aa4d9215e3ca673fa87c6e00e326 src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d src/java/src/org/apache/mesos/SchedulerDriver.java 3f03e91b8d65bca725f8063eca54e362a640e298 src/launcher/executor.cpp 4658b9e5bb48b09e403991c8bdfdbf4d4dae0416 src/linux/cgroups.hpp 5f4010734ed9e3295dcc3a4390123e4f4ce99c16 src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f src/python/interface/src/mesos/interface/__init__.py 1da76ebe577639e8161b16a48a503aa76d568789 src/slave/containerizer/docker.cpp 0576eab65a1f3556644472d5c9baba4ea9c34346 src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp 703e49f86ae41c11ae350ae51107eda00d0d5b7e src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 654137c552a7c416f394365e43ea80770fe1ef8d src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f43ab071de42de16d330cfd2a3b76563bcb173c9 src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 21a86e3087bea46a2d2125e53292251243086554 src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 4f3f210b8d0ab9a453ab56c5e23024e2ab7c4259 src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6545a6d29cb91d6cf8919c7796c283084178e499 src/slave/flags.hpp 69e1b01e09d2a15bee5e0745b751f47aaefe3fbe src/slave/flags.cpp 315cf47d268bce0a0255a061d64e414c736c8125 src/tests/containerizer/docker_spec_tests.cpp 796b020f58f8451362bc1357ab6d7ceb4e946b3c src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 5565227bc0b18f1891265e6eff0c5a22a0c4ab86 src/tests/containerizer/port_mapping_tests.cpp ce985f44cffd74a853154309397b8ee596934f78 src/tests/environment.cpp acadb5bb0a1b1a9b0cee0345035b93147bf7164c src/tests/mesos.hpp 3b565b45f45c84aba42aa6fb29b21f8306c49861 src/tests/mesos.cpp cf38dbb05908800b3a771318fa6922548c86c1f2 support/test-upgrade.py 2c4061d71338f66e432dfa4ac86a9693f3ad38bf Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44547: Added functions in promises to the future header.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Summary (updated) - Added functions in promises to the future header. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description (updated) --- Added functions in promises to the future header. Diffs (updated) - 3rdparty/libprocess/include/process/future.hpp ae4f2d659f1540c50dc1975f5771c6291c3b0c57 Diff: https://reviews.apache.org/r/44547/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44545: Separated standalone and zookeeper classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. Diffs (updated) - src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 src/local/local.cpp 06f6118a5038149f87e970b5cdf7987a270d3fae src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/contender.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/contenders/standalone.cpp PRE-CREATION src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION src/master/detectors/standalone.cpp PRE-CREATION src/master/main.cpp 9dcdbda3fb21096ba954d57fec20a394a009a223 src/master/master.hpp 1751ee1fc4d3e15df018be8bfd4f8ef2a0e32abd src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 src/tests/cluster.cpp 14d0d34fcb4c408ad996672394c39c84fd2be918 src/tests/containerizer/external_containerizer_test.cpp 5e2116355418f5a0716cfd1573bab48ba75df596 src/tests/containerizer/isolator_tests.cpp 7e16846e97e20a7ef058dd8ae4664fa1c554283d src/tests/fault_tolerance_tests.cpp 67238876952bb9a694cb04722113417a4b4eb58d src/tests/gc_tests.cpp 89a7f735b27b7a836b4ce3af10f26a6d63887279 src/tests/master_allocator_tests.cpp 9d74b9ed4b6a4c708f3a044a03ce631899acf4aa src/tests/master_authorization_tests.cpp 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d src/tests/master_contender_detector_tests.cpp 616a2c7316adc116071feaad95e3901ff66213ad src/tests/master_slave_reconciliation_tests.cpp 988f1d46580ab5a707fe801824e24f94d4f50da7 src/tests/master_tests.cpp bb599c952128e80e71beb2686e8665e5554856bc src/tests/mesos.hpp 98f97101d89cb91ca5e773e7a91f04ee1b8a0d88 src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e src/tests/persistent_volume_tests.cpp 7cb153cc6c0a8ca25cd31096686c63e829f746cf src/tests/reconciliation_tests.cpp 5f541f5fe004ede943a1b022daab92f01d1f4853 src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd src/tests/scheduler_tests.cpp 0c66f65825a1fff01774bf0d94b08b9c22b1fbda src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44669: Implemented create methods in MasterContender and MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Summary (updated) - Implemented create methods in MasterContender and MasterDetector. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description (updated) --- The create method can be used to create a MasterContender/Detector from a module (specified using the --modules flag on the command line). If the contender/detector module names have not been specified, the method will fall back to its prior behavior. Diffs (updated) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44289: Added support for contender and detector modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added support for contender and detector modules. Diffs (updated) - include/mesos/module/contender.hpp PRE-CREATION include/mesos/module/detector.hpp PRE-CREATION src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 src/examples/test_master_contender_module.cpp PRE-CREATION src/examples/test_master_detector_module.cpp PRE-CREATION src/local/local.cpp 06f6118a5038149f87e970b5cdf7987a270d3fae src/master/contenders/zookeeper.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 src/master/detectors/zookeeper.cpp PRE-CREATION src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a Diff: https://reviews.apache.org/r/44289/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44546: Moved functions in promises to a common header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved functions in promises to a common header file. Diffs (updated) - src/master/detectors/standalone.cpp PRE-CREATION src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44544: Moved contender and detector definitions into separate directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated April 4, 2016, 5:08 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved contender and detector definitions into separate directories. Diffs (updated) - src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated April 4, 2016, 5:07 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector are now defined in include/mesos/master/contender.hpp and detector.hpp. Diffs (updated) - src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated April 4, 2016, 5:07 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector abstract classes can be subclassed by user-provided classes to allow for arbitrary contender/detector implementations. Diffs (updated) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44670: Added master_detector and master_contender flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated April 4, 2016, 5:07 p.m.) Review request for mesos, Benjamin Hindman and Kapil Arya. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The master_detector and master_contender flags allow modules to be used for specifying the MasterContender and MasterDetector implementations to use. Diffs (updated) - src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d src/master/flags.cpp 06852c9de68cce5d40f294f6402f7677ee6183d3 src/master/main.cpp 9dcdbda3fb21096ba954d57fec20a394a009a223 src/slave/flags.hpp d0c606eea74e1a2e69067c43a267047e65a22a04 src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 src/slave/main.cpp f5f21422c7cb94506b78cebf7f7341b5a078f3b2 Diff: https://reviews.apache.org/r/44670/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh
Re: Review Request 44670: Added master_detector and master_contender flags.
> On March 31, 2016, 5:26 p.m., Kapil Arya wrote: > > src/master/main.cpp, lines 247-248 > > <https://reviews.apache.org/r/44670/diff/7/?file=1308601#file1308601line247> > > > > These two should fit on one line :-). putting them on the same line is causing the line lenght to increase to 89. - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/#review126356 --- On March 23, 2016, 11:06 p.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44670/ > --- > > (Updated March 23, 2016, 11:06 p.m.) > > > Review request for mesos, Benjamin Hindman and Kapil Arya. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > --- > > The master_detector and master_contender flags allow modules to be > used for specifying the MasterContender and MasterDetector > implementations to use. > > > Diffs > - > > src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d > src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61 > src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 > src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 > > Diff: https://reviews.apache.org/r/44670/diff/ > > > Testing > --- > > In addition to all unit tests passing, we are currently using this > functionality in our environment with a custom consensus stack. In our world, > we have a C++ plugin that calls out to an HTTP REST service (implemented in > Java/Scala, not that it matters). > > > Thanks, > > Anurag Singh > >
Re: Review Request 44544: Moved contender and detector definitions into separate directories.
> On March 31, 2016, 5:25 p.m., Kapil Arya wrote: > > src/master/contenders/contender.cpp, lines 58-61 > > <https://reviews.apache.org/r/44544/diff/9/?file=1308543#file1308543line58> > > > > I am not sure if I understand this one here. Can you elaborate a bit? Dropped this issue since this part of the code was copied verbatim. - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/#review126329 --- On March 23, 2016, 11:05 p.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44544/ > --- > > (Updated March 23, 2016, 11:05 p.m.) > > > Review request for mesos, Benjamin Hindman and Kapil Arya. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > --- > > Moved contender and detector definitions into separate directories. > > > Diffs > - > > src/master/contenders/contender.hpp PRE-CREATION > src/master/contenders/contender.cpp PRE-CREATION > src/master/detectors/detector.hpp PRE-CREATION > src/master/detectors/detector.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44544/diff/ > > > Testing > --- > > See https://reviews.apache.org/r/44670/. > > > Thanks, > > Anurag Singh > >
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
> On March 31, 2016, 5:25 p.m., Kapil Arya wrote: > > include/mesos/master/contender.hpp, line 65 > > <https://reviews.apache.org/r/44287/diff/12/?file=1308472#file1308472line65> > > > > I am wondering if `type` can be replaced with `moduleName` or something > > more explicit. as discussed, we'll be dropping this method so I'll skip this comment. - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review125914 --- On March 23, 2016, 11:04 p.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44287/ > --- > > (Updated March 23, 2016, 11:04 p.m.) > > > Review request for mesos, Benjamin Hindman and Kapil Arya. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > --- > > MasterContender and MasterDetector abstract classes can be subclassed by > user-provided classes to allow for arbitrary contender/detector > implementations. > > > Diffs > - > > include/mesos/master/contender.hpp PRE-CREATION > include/mesos/master/detector.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44287/diff/ > > > Testing > --- > > See https://reviews.apache.org/r/44670/. > > > Thanks, > > Anurag Singh > >
Re: Review Request 44670: Added master_detector and master_contender flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 21, 2016, 3:45 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The master_detector and master_contender flags allow modules to be used for specifying the MasterContender and MasterDetector implementations to use. Diffs (updated) - src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61 src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 Diff: https://reviews.apache.org/r/44670/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh
Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 21, 2016, 3:45 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The createFromModule will be used to create a MasterContender/Detector from a module (specified using the --modules flag on the command line). Diffs (updated) - src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44289: Added support for contender and detector modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 21, 2016, 3:45 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added support for contender and detector modules. Diffs (updated) - include/mesos/module/contender.hpp PRE-CREATION include/mesos/module/detector.hpp PRE-CREATION src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf src/examples/test_contender_module.cpp PRE-CREATION src/examples/test_detector_module.cpp PRE-CREATION src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contenders/zookeeper.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/detectors/zookeeper.cpp PRE-CREATION src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a Diff: https://reviews.apache.org/r/44289/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44547: Added functions in promises to the collect header.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 21, 2016, 3:45 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added functions in promises to the collect header. Diffs (updated) - 3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc Diff: https://reviews.apache.org/r/44547/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44544: Moved contender and detector definitions into separate directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 21, 2016, 3:44 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved contender and detector definitions into separate directories. Diffs (updated) - src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44546: Moved functions in promises to a common header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 21, 2016, 3:44 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved functions in promises to a common header file. Diffs (updated) - src/master/detectors/standalone.cpp PRE-CREATION src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44545: Separated standalone and zookeeper classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 21, 2016, 3:44 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. Diffs (updated) - src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/contenders/standalone.cpp PRE-CREATION src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION src/master/detectors/standalone.cpp PRE-CREATION src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 src/tests/containerizer/external_containerizer_test.cpp 5e2116355418f5a0716cfd1573bab48ba75df596 src/tests/containerizer/isolator_tests.cpp 6a2e25b967742c034364d19372f06aa9f9cdf828 src/tests/fault_tolerance_tests.cpp f99413f56e96a796d3d45decad1f049e6a238789 src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50 src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31 src/tests/master_authorization_tests.cpp 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d src/tests/master_contender_detector_tests.cpp bbce379e5a0a0ca608579d0ab2b10970e9cd5ef1 src/tests/master_slave_reconciliation_tests.cpp 988f1d46580ab5a707fe801824e24f94d4f50da7 src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967 src/tests/reconciliation_tests.cpp 5f541f5fe004ede943a1b022daab92f01d1f4853 src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd src/tests/scheduler_tests.cpp 917058f4dcf32ddaaeda8a3ff21898571f4829dd src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 21, 2016, 3:43 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector are now defined in include/mesos/master/contender.hpp and detector.hpp. Diffs (updated) - src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44288: Changed MasterDetector/Contender namespace.
/resource_offers_tests.cpp 1cf292ee7931207596f8f06677386bef5965ef15 src/tests/role_tests.cpp 20ccca3ecdc53c65abd61190ef9f867c8e860578 src/tests/scheduler_driver_tests.cpp 824aa96106808f7e259fb755257034c89c997287 src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd src/tests/scheduler_tests.cpp 917058f4dcf32ddaaeda8a3ff21898571f4829dd src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 src/tests/status_update_manager_tests.cpp 801767ba6b4a08a4f653a7735bf3a581a0f8f95f Diff: https://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 21, 2016, 3:43 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector abstract classes can be subclassed by user-provided classes to allow for arbitrary contender/detector implementations. Diffs (updated) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
> On March 11, 2016, 9:40 p.m., Joseph Wu wrote: > > I think you should send an email to the user and dev mailing lists to ask > > for high-level feedback on this interface. We want to make sure the > > interface is broad enough to support different implementations. (And I'm > > no expert on leader election.) > > Anurag Singh wrote: > I'll do that and address your comments. I haven't seen any comments from the user and developer communities to my email on these changes. Do you want to wait longer? - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review122832 --- On March 15, 2016, 11:01 p.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44287/ > --- > > (Updated March 15, 2016, 11:01 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > --- > > MasterContender and MasterDetector abstract classes can be subclassed by > user-provided classes to allow for arbitrary contender/detector > implementations. > > > Diffs > - > > include/mesos/master/contender.hpp PRE-CREATION > include/mesos/master/detector.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44287/diff/ > > > Testing > --- > > See https://reviews.apache.org/r/44670/. > > > Thanks, > > Anurag Singh > >
Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The createFromModule will be used to create a MasterContender/Detector from a module (specified using the --modules flag on the command line). Diffs (updated) - src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector are now defined in include/mesos/master/contender.hpp and detector.hpp. Diffs (updated) - src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44545: Separated standalone and zookeeper classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. Diffs (updated) - src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/contenders/standalone.cpp PRE-CREATION src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION src/master/detectors/standalone.cpp PRE-CREATION src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 src/tests/containerizer/external_containerizer_test.cpp 5e2116355418f5a0716cfd1573bab48ba75df596 src/tests/containerizer/isolator_tests.cpp 6a2e25b967742c034364d19372f06aa9f9cdf828 src/tests/fault_tolerance_tests.cpp f99413f56e96a796d3d45decad1f049e6a238789 src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50 src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31 src/tests/master_authorization_tests.cpp 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d src/tests/master_contender_detector_tests.cpp bbce379e5a0a0ca608579d0ab2b10970e9cd5ef1 src/tests/master_slave_reconciliation_tests.cpp 988f1d46580ab5a707fe801824e24f94d4f50da7 src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c src/tests/mesos.hpp 93b9340d94d91663283fe5df5ad9febe69ffd2a3 src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967 src/tests/reconciliation_tests.cpp 5f541f5fe004ede943a1b022daab92f01d1f4853 src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd src/tests/scheduler_tests.cpp 917058f4dcf32ddaaeda8a3ff21898571f4829dd src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44546: Moved functions in promises to a common header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved functions in promises to a common header file. Diffs (updated) - src/master/detectors/standalone.cpp PRE-CREATION src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44547: Added functions in promises to the collect header.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added functions in promises to the collect header. Diffs (updated) - 3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc Diff: https://reviews.apache.org/r/44547/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44544: Moved contender and detector definitions into separate directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved contender and detector definitions into separate directories. Diffs (updated) - src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector abstract classes can be subclassed by user-provided classes to allow for arbitrary contender/detector implementations. Diffs (updated) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44670: Added master_detector and master_contender flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 18, 2016, 12:30 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The master_detector and master_contender flags allow modules to be used for specifying the MasterContender and MasterDetector implementations to use. Diffs (updated) - src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61 src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 Diff: https://reviews.apache.org/r/44670/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh
Re: Review Request 44547: Added functions in promises to the collect header.
> On March 18, 2016, 9:05 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/include/process/collect.hpp, line 260 > > <https://reviews.apache.org/r/44547/diff/8/?file=1304700#file1304700line260> > > > > Missed a couple extranous spaces here (i.e. `>* >*`). Thanks. I'm curious ... do you use a tool for checking the styling? Or have you written your own scripts? - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/#review124281 --- On March 18, 2016, 12:29 a.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44547/ > --- > > (Updated March 18, 2016, 12:29 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > --- > > Added functions in promises to the collect header. > > > Diffs > - > > 3rdparty/libprocess/include/process/collect.hpp > 5a92b72eb7668494dc832ec446a41b3d673a20cc > > Diff: https://reviews.apache.org/r/44547/diff/ > > > Testing > --- > > See https://reviews.apache.org/r/44670/. > > > Thanks, > > Anurag Singh > >
Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.
> On March 18, 2016, 9:03 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 16-17 > > <https://reviews.apache.org/r/44543/diff/8/?file=1304655#file1304655line16> > > > > You might have missed my earlier comment (because I didn't make it a RB > > "issue"). Are these two files deleted somewhere else? > > > > I can't seem to find where you deleted them. It's showing up in https://reviews.apache.org/r/44545/ - if you expand the changes, you'll see 'Was src/master/contender.hpp' for src/master/contenders/zookeeper.hpp. Similarly for the rest. - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/#review124284 ------- On March 18, 2016, 12:29 a.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44543/ > --- > > (Updated March 18, 2016, 12:29 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > --- > > MasterContender and MasterDetector are now defined in > include/mesos/master/contender.hpp and detector.hpp. > > > Diffs > - > > src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 > src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 > > Diff: https://reviews.apache.org/r/44543/diff/ > > > Testing > --- > > See https://reviews.apache.org/r/44670/. > > > Thanks, > > Anurag Singh > >
Re: Review Request 44288: Changed MasterDetector/Contender namespace.
/resource_offers_tests.cpp 1cf292ee7931207596f8f06677386bef5965ef15 src/tests/role_tests.cpp 20ccca3ecdc53c65abd61190ef9f867c8e860578 src/tests/scheduler_driver_tests.cpp 824aa96106808f7e259fb755257034c89c997287 src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd src/tests/scheduler_tests.cpp 917058f4dcf32ddaaeda8a3ff21898571f4829dd src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 src/tests/status_update_manager_tests.cpp 801767ba6b4a08a4f653a7735bf3a581a0f8f95f Diff: https://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
> On March 18, 2016, 9:01 p.m., Joseph Wu wrote: > > Sorry for the delay... > > > > As Vinod suggested, you might want to consider reaching out to another > > shepherd (as far as I can tell, BenH is not likely to have time in the > > foreseeable future). (And in case you don't know, I'm not a shepherd :) Will do. - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review124259 --- On March 18, 2016, 12:29 a.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44287/ > --- > > (Updated March 18, 2016, 12:29 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > --- > > MasterContender and MasterDetector abstract classes can be subclassed by > user-provided classes to allow for arbitrary contender/detector > implementations. > > > Diffs > - > > include/mesos/master/contender.hpp PRE-CREATION > include/mesos/master/detector.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44287/diff/ > > > Testing > --- > > See https://reviews.apache.org/r/44670/. > > > Thanks, > > Anurag Singh > >
Re: Review Request 44289: Added support for contender and detector modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added support for contender and detector modules. Diffs (updated) - include/mesos/module/contender.hpp PRE-CREATION include/mesos/module/detector.hpp PRE-CREATION src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf src/examples/test_contender_module.cpp PRE-CREATION src/examples/test_detector_module.cpp PRE-CREATION src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contenders/zookeeper.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/detectors/zookeeper.cpp PRE-CREATION src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a Diff: https://reviews.apache.org/r/44289/diff/ Testing --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44288: Changed MasterDetector/Contender namespace.
> On March 18, 2016, 9:03 p.m., Joseph Wu wrote: > > src/master/contender.cpp, line 91 > > <https://reviews.apache.org/r/44288/diff/10/?file=1304592#file1304592line91> > > > > Another spacing change seems to have snuck in. Apologies ... I forgot to add expandtab in my vimrc. Fixing it. - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review124274 --- On March 18, 2016, 12:29 a.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44288/ > --- > > (Updated March 18, 2016, 12:29 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > --- > > Also modified users of MasterContender and MasterDetector to use this > namespace. > > > Diffs > - > > include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 > include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1 > src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d > src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 > src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 > src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e > src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551 > src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 > src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f > src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 > src/scheduler/scheduler.cpp 6a834473ef35540eedac7e211b5204ab5f4eb7b2 > src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646 > src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 > src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 > src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 > src/tests/cluster.hpp 06424dd741aed2261a926429bb0fc7dea141c11b > src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 > src/tests/command_executor_tests.cpp > 970cdc39f4f2b0377d36acf2465d377d2a6e1d05 > src/tests/container_logger_tests.cpp > 71101c31cee6a400b89cf285cf0a105d2d1534a8 > src/tests/containerizer/docker_containerizer_tests.cpp > f6fce7df82417e029fadf805d6e0b793f396aa69 > src/tests/containerizer/external_containerizer_test.cpp > 5e2116355418f5a0716cfd1573bab48ba75df596 > src/tests/containerizer/filesystem_isolator_tests.cpp > b3bd5a03266150a0cd83c966d646a32c419bf512 > src/tests/containerizer/isolator_tests.cpp > 6a2e25b967742c034364d19372f06aa9f9cdf828 > src/tests/containerizer/memory_pressure_tests.cpp > be6c3a118b528c39c534da423c15e9dcbb970dbc > src/tests/containerizer/port_mapping_tests.cpp > de4b6f99f3a994bcedafa801eed9c4a7b79bac23 > src/tests/containerizer/provisioner_docker_tests.cpp > 72d4c3e8756e1bea2332db20654af0a5fbb124f1 > src/tests/containerizer/runtime_isolator_tests.cpp > 9f3b0b08da7cebba722062a9932fae1b5f825efb > src/tests/credentials_tests.cpp b61ba2ea5df8957f12659de219f6a57cf30d987a > src/tests/disk_quota_tests.cpp 7f5e32f3239db3adf6e4cec2df15ccf89b4f13f4 > src/tests/exception_tests.cpp a50ccf1255dee59fdbc6fb1539bd1f6429458fb4 > src/tests/executor_http_api_tests.cpp > ff7b672e03185fca8b408b8805223a314fa3e483 > src/tests/fault_tolerance_tests.cpp > f99413f56e96a796d3d45decad1f049e6a238789 > src/tests/fetcher_cache_tests.cpp 645dae208cb2b0aa2d2181d96eb1fd8893975430 > src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50 > src/tests/health_check_tests.cpp d32164aeb1eb439bd062afa28614dd919e24f06b > src/tests/hook_tests.cpp 595991deab38c34e918601e85d250dc995d0f34c > src/tests/http_fault_tolerance_tests.cpp > c06e07daf6d6519c10489310cd4275ae94f302c6 > src/tests/master_allocator_tests.cpp > b41ba2bda4d680f6fc42f525719973d56c11fe31 > src/tests/master_authorization_tests.cpp > 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d > src/tests/master_contender_detector_tests.cpp > bbce379e5a0a0ca608579d0ab2b10970e9cd5ef1 > src/tests/master_maintenance_tests.cpp > b42a81fc2e0982e8fca669bffb798c0acda684fc > src/tests/master_quota_tests.cpp c2b46d23002481e63ff162e8628f9b974e3e8ef9 > src/tests/master_slave_reconciliation_tests.cpp > 988f1d46580ab5a707fe801824e24f94d4f50da7 > src/tests/mas
Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 15, 2016, 11:02 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The createFromModule will be used to create a MasterContender/Detector from a module (specified using the --modules flag on the command line). Diffs - src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44546: Moved functions in promises to a common header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 15, 2016, 11:02 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved functions in promises to a common header file. Diffs - src/master/detectors/standalone.cpp PRE-CREATION src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44289: Added support for contender and detector modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 15, 2016, 11:02 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added support for contender and detector modules. Diffs - include/mesos/module/contender.hpp PRE-CREATION include/mesos/module/detector.hpp PRE-CREATION src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 src/examples/test_contender_module.cpp PRE-CREATION src/examples/test_detector_module.cpp PRE-CREATION src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contenders/zookeeper.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/detectors/zookeeper.cpp PRE-CREATION src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a Diff: https://reviews.apache.org/r/44289/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44547: Added functions in promises to the collect header.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 15, 2016, 11:02 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added functions in promises to the collect header. Diffs - 3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc Diff: https://reviews.apache.org/r/44547/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44545: Separated standalone and zookeeper classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. Diffs - src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/contenders/standalone.cpp PRE-CREATION src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION src/master/detectors/standalone.cpp PRE-CREATION src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 src/tests/cluster.cpp e5796d3cc17f814bec8f02dccf40515b65cfea91 src/tests/containerizer/external_containerizer_test.cpp 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 src/tests/containerizer/isolator_tests.cpp 342037ce0a5f8caa4e3cf1550b8f9a7cc328acf9 src/tests/fault_tolerance_tests.cpp 349669d6aa0ead63b2ebcfcc2f769c99a6db0192 src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 src/tests/master_authorization_tests.cpp 6a4de4709960d7ca505e99396e14a1bb51d6902d src/tests/master_contender_detector_tests.cpp 255ab8119a04b55bb4f1b61dee19c4be64499376 src/tests/master_slave_reconciliation_tests.cpp d41178eb41df519073fc0890c5716bbc9fed6ad2 src/tests/master_tests.cpp e8c39e775d6ca218ce74cfc6bb50c7576d73e90e src/tests/mesos.hpp 908a53a146208a6d41c0bda5208415e39e2eae05 src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 src/tests/persistent_volume_tests.cpp e9215de2e073025f67cdc73e8a8de38cf030671f src/tests/reconciliation_tests.cpp e8f3f29836652d20a6ee1bb5231a15e71eb76990 src/tests/reservation_tests.cpp c88091635949037fcfc6be504043764f9af35f79 src/tests/scheduler_event_call_tests.cpp 8c02ceeb3ec1783cb2f63f100700508e70f586e4 src/tests/scheduler_http_api_tests.cpp dfb0f51fec67a3951e396eab28eedb0dbf9493ae src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44545/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44544: Moved contender and detector definitions into separate directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved contender and detector definitions into separate directories. Diffs - src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector are now defined in include/mesos/master/contender.hpp and detector.hpp. Diffs - src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector abstract classes can be subclassed by user-provided classes to allow for arbitrary contender/detector implementations. Diffs - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44288: Changed MasterDetector/Contender namespace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Also modified users of MasterContender and MasterDetector to use this namespace. Diffs - include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1 src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 src/master/master.cpp d0380db3b90a9166607445f8dd50cc63d547228e src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 src/scheduler/scheduler.cpp 35f479483740baed3f7bdbf45bf1d5bba3b9febc src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 src/tests/cluster.cpp e5796d3cc17f814bec8f02dccf40515b65cfea91 src/tests/fault_tolerance_tests.cpp 349669d6aa0ead63b2ebcfcc2f769c99a6db0192 src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 src/tests/master_authorization_tests.cpp 6a4de4709960d7ca505e99396e14a1bb51d6902d src/tests/master_contender_detector_tests.cpp 255ab8119a04b55bb4f1b61dee19c4be64499376 src/tests/master_slave_reconciliation_tests.cpp d41178eb41df519073fc0890c5716bbc9fed6ad2 src/tests/master_tests.cpp e8c39e775d6ca218ce74cfc6bb50c7576d73e90e src/tests/mesos.hpp 908a53a146208a6d41c0bda5208415e39e2eae05 src/tests/mesos.cpp 7cca4ed4753fa365b209d1d22f0df4650b19bc6a src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 src/tests/persistent_volume_tests.cpp e9215de2e073025f67cdc73e8a8de38cf030671f src/tests/reconciliation_tests.cpp e8f3f29836652d20a6ee1bb5231a15e71eb76990 src/tests/reservation_tests.cpp c88091635949037fcfc6be504043764f9af35f79 src/tests/scheduler_event_call_tests.cpp 8c02ceeb3ec1783cb2f63f100700508e70f586e4 src/tests/scheduler_http_api_tests.cpp dfb0f51fec67a3951e396eab28eedb0dbf9493ae src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44288/diff/ Testing (updated) --- See https://reviews.apache.org/r/44670/. Thanks, Anurag Singh
Re: Review Request 44670: Added master_detector and master_contender flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The master_detector and master_contender flags allow modules to be used for specifying the MasterContender and MasterDetector implementations to use. Diffs (updated) - src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61 src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 src/slave/flags.cpp 5bacf109bcd9c9eae1b7ec3c32095c72899ebdbd src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb Diff: https://reviews.apache.org/r/44670/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh
Re: Review Request 44289: Added support for contender and detector modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added support for contender and detector modules. Diffs (updated) - include/mesos/module/contender.hpp PRE-CREATION include/mesos/module/detector.hpp PRE-CREATION src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 src/examples/test_contender_module.cpp PRE-CREATION src/examples/test_detector_module.cpp PRE-CREATION src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contenders/zookeeper.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/detectors/zookeeper.cpp PRE-CREATION src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a Diff: https://reviews.apache.org/r/44289/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh
Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The createFromModule will be used to create a MasterContender/Detector from a module (specified using the --modules flag on the command line). Diffs (updated) - src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44547: Added functions in promises to the collect header.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added functions in promises to the collect header. Diffs (updated) - 3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc Diff: https://reviews.apache.org/r/44547/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44546: Moved functions in promises to a common header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved functions in promises to a common header file. Diffs (updated) - src/master/detectors/standalone.cpp PRE-CREATION src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44545: Separated standalone and zookeeper classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. Diffs (updated) - src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/contenders/standalone.cpp PRE-CREATION src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION src/master/detectors/standalone.cpp PRE-CREATION src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 src/tests/cluster.cpp e5796d3cc17f814bec8f02dccf40515b65cfea91 src/tests/containerizer/external_containerizer_test.cpp 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 src/tests/containerizer/isolator_tests.cpp 342037ce0a5f8caa4e3cf1550b8f9a7cc328acf9 src/tests/fault_tolerance_tests.cpp 349669d6aa0ead63b2ebcfcc2f769c99a6db0192 src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 src/tests/master_authorization_tests.cpp 6a4de4709960d7ca505e99396e14a1bb51d6902d src/tests/master_contender_detector_tests.cpp 255ab8119a04b55bb4f1b61dee19c4be64499376 src/tests/master_slave_reconciliation_tests.cpp d41178eb41df519073fc0890c5716bbc9fed6ad2 src/tests/master_tests.cpp e8c39e775d6ca218ce74cfc6bb50c7576d73e90e src/tests/mesos.hpp 908a53a146208a6d41c0bda5208415e39e2eae05 src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 src/tests/persistent_volume_tests.cpp e9215de2e073025f67cdc73e8a8de38cf030671f src/tests/reconciliation_tests.cpp e8f3f29836652d20a6ee1bb5231a15e71eb76990 src/tests/reservation_tests.cpp c88091635949037fcfc6be504043764f9af35f79 src/tests/scheduler_event_call_tests.cpp 8c02ceeb3ec1783cb2f63f100700508e70f586e4 src/tests/scheduler_http_api_tests.cpp dfb0f51fec67a3951e396eab28eedb0dbf9493ae src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 15, 2016, 6:16 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector abstract classes can be subclassed by user-provided classes to allow for arbitrary contender/detector implementations. Diffs (updated) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44289/. Thanks, Anurag Singh
Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector are now defined in include/mesos/master/contender.hpp and detector.hpp. Diffs (updated) - src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44544: Moved contender and detector definitions into separate directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved contender and detector definitions into separate directories. Diffs (updated) - src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44288: Changed MasterDetector/Contender namespace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Also modified users of MasterContender and MasterDetector to use this namespace. Diffs (updated) - include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1 src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 src/master/master.cpp d0380db3b90a9166607445f8dd50cc63d547228e src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 src/scheduler/scheduler.cpp 35f479483740baed3f7bdbf45bf1d5bba3b9febc src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 src/tests/cluster.cpp e5796d3cc17f814bec8f02dccf40515b65cfea91 src/tests/fault_tolerance_tests.cpp 349669d6aa0ead63b2ebcfcc2f769c99a6db0192 src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 src/tests/master_authorization_tests.cpp 6a4de4709960d7ca505e99396e14a1bb51d6902d src/tests/master_contender_detector_tests.cpp 255ab8119a04b55bb4f1b61dee19c4be64499376 src/tests/master_slave_reconciliation_tests.cpp d41178eb41df519073fc0890c5716bbc9fed6ad2 src/tests/master_tests.cpp e8c39e775d6ca218ce74cfc6bb50c7576d73e90e src/tests/mesos.hpp 908a53a146208a6d41c0bda5208415e39e2eae05 src/tests/mesos.cpp 7cca4ed4753fa365b209d1d22f0df4650b19bc6a src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 src/tests/persistent_volume_tests.cpp e9215de2e073025f67cdc73e8a8de38cf030671f src/tests/reconciliation_tests.cpp e8f3f29836652d20a6ee1bb5231a15e71eb76990 src/tests/reservation_tests.cpp c88091635949037fcfc6be504043764f9af35f79 src/tests/scheduler_event_call_tests.cpp 8c02ceeb3ec1783cb2f63f100700508e70f586e4 src/tests/scheduler_http_api_tests.cpp dfb0f51fec67a3951e396eab28eedb0dbf9493ae src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44289/. Thanks, Anurag Singh
Re: Review Request 44545: Separated standalone and zookeeper classes.
> On March 11, 2016, 9:42 p.m., Joseph Wu wrote: > > src/master/detectors/standalone.cpp, lines 58-60 > > <https://reviews.apache.org/r/44545/diff/5/?file=1295061#file1295061line58> > > > > I don't see where these helpers are deleted in your later reviews. This may have happened during one of my rebase -i attempts. Fixing this now. - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/#review123201 --- On March 14, 2016, 11:51 p.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44545/ > --- > > (Updated March 14, 2016, 11:51 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > --- > > Instead of keeping standalone and zookeper contender/detector class > definitions and implementations in the same file, separated them. Also > made the necessary changes in users of class headers to point to the > new locations. > > > Diffs > - > > src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 > src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 > src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 > src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 > src/master/contenders/contender.hpp PRE-CREATION > src/master/contenders/contender.cpp PRE-CREATION > src/master/contenders/standalone.cpp PRE-CREATION > src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 > src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e > src/master/detectors/detector.hpp PRE-CREATION > src/master/detectors/detector.cpp PRE-CREATION > src/master/detectors/standalone.cpp PRE-CREATION > src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa > src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 > src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb > src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 > src/tests/cluster.cpp e5796d3cc17f814bec8f02dccf40515b65cfea91 > src/tests/containerizer/external_containerizer_test.cpp > 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 > src/tests/containerizer/isolator_tests.cpp > 342037ce0a5f8caa4e3cf1550b8f9a7cc328acf9 > src/tests/fault_tolerance_tests.cpp > 349669d6aa0ead63b2ebcfcc2f769c99a6db0192 > src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf > src/tests/master_allocator_tests.cpp > cba7c36471f93b678d94e1da0251a28a893696b1 > src/tests/master_authorization_tests.cpp > 6a4de4709960d7ca505e99396e14a1bb51d6902d > src/tests/master_contender_detector_tests.cpp > 255ab8119a04b55bb4f1b61dee19c4be64499376 > src/tests/master_slave_reconciliation_tests.cpp > d41178eb41df519073fc0890c5716bbc9fed6ad2 > src/tests/master_tests.cpp e8c39e775d6ca218ce74cfc6bb50c7576d73e90e > src/tests/mesos.hpp 908a53a146208a6d41c0bda5208415e39e2eae05 > src/tests/oversubscription_tests.cpp > e528476cd83b0e3f7ae8cea7d86dfabc1f66484e > src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 > src/tests/persistent_volume_tests.cpp > e9215de2e073025f67cdc73e8a8de38cf030671f > src/tests/reconciliation_tests.cpp e8f3f29836652d20a6ee1bb5231a15e71eb76990 > src/tests/reservation_tests.cpp c88091635949037fcfc6be504043764f9af35f79 > src/tests/scheduler_event_call_tests.cpp > 8c02ceeb3ec1783cb2f63f100700508e70f586e4 > src/tests/scheduler_http_api_tests.cpp > dfb0f51fec67a3951e396eab28eedb0dbf9493ae > src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 > src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c > src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 > > Diff: https://reviews.apache.org/r/44545/diff/ > > > Testing > --- > > > Thanks, > > Anurag Singh > >
Re: Review Request 44288: Changed MasterDetector/Contender namespace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 14, 2016, 11:49 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Also modified users of MasterContender and MasterDetector to use this namespace. Diffs (updated) - include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1 src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 src/master/master.cpp d0380db3b90a9166607445f8dd50cc63d547228e src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 src/scheduler/scheduler.cpp 35f479483740baed3f7bdbf45bf1d5bba3b9febc src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 src/tests/cluster.cpp e5796d3cc17f814bec8f02dccf40515b65cfea91 src/tests/fault_tolerance_tests.cpp 349669d6aa0ead63b2ebcfcc2f769c99a6db0192 src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 src/tests/master_authorization_tests.cpp 6a4de4709960d7ca505e99396e14a1bb51d6902d src/tests/master_contender_detector_tests.cpp 255ab8119a04b55bb4f1b61dee19c4be64499376 src/tests/master_slave_reconciliation_tests.cpp d41178eb41df519073fc0890c5716bbc9fed6ad2 src/tests/master_tests.cpp e8c39e775d6ca218ce74cfc6bb50c7576d73e90e src/tests/mesos.hpp 908a53a146208a6d41c0bda5208415e39e2eae05 src/tests/mesos.cpp 7cca4ed4753fa365b209d1d22f0df4650b19bc6a src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 src/tests/persistent_volume_tests.cpp e9215de2e073025f67cdc73e8a8de38cf030671f src/tests/reconciliation_tests.cpp e8f3f29836652d20a6ee1bb5231a15e71eb76990 src/tests/reservation_tests.cpp c88091635949037fcfc6be504043764f9af35f79 src/tests/scheduler_event_call_tests.cpp 8c02ceeb3ec1783cb2f63f100700508e70f586e4 src/tests/scheduler_http_api_tests.cpp dfb0f51fec67a3951e396eab28eedb0dbf9493ae src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44289/. Thanks, Anurag Singh
Re: Review Request 44670: Added master_detector and master_contender flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 14, 2016, 11:53 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The master_detector and master_contender flags allow modules to be used for specifying the MasterContender and MasterDetector implementations to use. Diffs (updated) - src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61 src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 src/slave/flags.cpp 5bacf109bcd9c9eae1b7ec3c32095c72899ebdbd src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb Diff: https://reviews.apache.org/r/44670/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh
Re: Review Request 44547: Added functions in promises to the collect header.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 14, 2016, 11:52 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added functions in promises to the collect header. Diffs (updated) - 3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc Diff: https://reviews.apache.org/r/44547/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44289: Added support for contender and detector modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 14, 2016, 11:52 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added support for contender and detector modules. Diffs (updated) - include/mesos/module/contender.hpp PRE-CREATION include/mesos/module/detector.hpp PRE-CREATION src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 src/examples/test_contender_module.cpp PRE-CREATION src/examples/test_detector_module.cpp PRE-CREATION src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contenders/zookeeper.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e src/module/manager.cpp 8c9aaf7cd00c904daba9994a99df9e1329831c01 src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a Diff: https://reviews.apache.org/r/44289/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh
Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 14, 2016, 11:52 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The createFromModule will be used to create a MasterContender/Detector from a module (specified using the --modules flag on the command line). Diffs (updated) - src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44545: Separated standalone and zookeeper classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 14, 2016, 11:51 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. Diffs (updated) - src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 src/local/local.cpp f8599e7378e9a0065bbd01ad8f23f11debb30c91 src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/contenders/standalone.cpp PRE-CREATION src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION src/master/detectors/standalone.cpp PRE-CREATION src/master/main.cpp 7c1656bcc266f6c94cb4befad37fa813a218b2fa src/master/master.hpp 124d43931a5c8a00ee0aaa604feb1761795209f2 src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 src/tests/cluster.cpp e5796d3cc17f814bec8f02dccf40515b65cfea91 src/tests/containerizer/external_containerizer_test.cpp 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 src/tests/containerizer/isolator_tests.cpp 342037ce0a5f8caa4e3cf1550b8f9a7cc328acf9 src/tests/fault_tolerance_tests.cpp 349669d6aa0ead63b2ebcfcc2f769c99a6db0192 src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 src/tests/master_authorization_tests.cpp 6a4de4709960d7ca505e99396e14a1bb51d6902d src/tests/master_contender_detector_tests.cpp 255ab8119a04b55bb4f1b61dee19c4be64499376 src/tests/master_slave_reconciliation_tests.cpp d41178eb41df519073fc0890c5716bbc9fed6ad2 src/tests/master_tests.cpp e8c39e775d6ca218ce74cfc6bb50c7576d73e90e src/tests/mesos.hpp 908a53a146208a6d41c0bda5208415e39e2eae05 src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 src/tests/persistent_volume_tests.cpp e9215de2e073025f67cdc73e8a8de38cf030671f src/tests/reconciliation_tests.cpp e8f3f29836652d20a6ee1bb5231a15e71eb76990 src/tests/reservation_tests.cpp c88091635949037fcfc6be504043764f9af35f79 src/tests/scheduler_event_call_tests.cpp 8c02ceeb3ec1783cb2f63f100700508e70f586e4 src/tests/scheduler_http_api_tests.cpp dfb0f51fec67a3951e396eab28eedb0dbf9493ae src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44544: Moved contender and detector definitions into separate directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 14, 2016, 11:50 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved contender and detector definitions into separate directories. Diffs (updated) - src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 14, 2016, 11:50 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector are now defined in include/mesos/master/contender.hpp and detector.hpp. Diffs (updated) - src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 Diff: https://reviews.apache.org/r/44543/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 14, 2016, 11:48 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector abstract classes can be subclassed by user-provided classes to allow for arbitrary contender/detector implementations. Diffs (updated) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44289/. Thanks, Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
> On March 11, 2016, 9:40 p.m., Joseph Wu wrote: > > I think you should send an email to the user and dev mailing lists to ask > > for high-level feedback on this interface. We want to make sure the > > interface is broad enough to support different implementations. (And I'm > > no expert on leader election.) I'll do that and address your comments. - Anurag --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review122832 --- On March 10, 2016, 11:45 p.m., Anurag Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44287/ > --- > > (Updated March 10, 2016, 11:45 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > --- > > MasterContender and MasterDetector abstract classes can be subclassed by > user-provided classes to allow for arbitrary contender/detector > implementations. > > > Diffs > - > > include/mesos/master/contender.hpp PRE-CREATION > include/mesos/master/detector.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44287/diff/ > > > Testing > --- > > See https://reviews.apache.org/r/44289/. > > > Thanks, > > Anurag Singh > >
Re: Review Request 44288: Changed MasterDetector/Contender namespace.
> On March 3, 2016, 10:15 p.m., Joseph Wu wrote:
> > src/master/contender.hpp, lines 17-18
> > <https://reviews.apache.org/r/44288/diff/3/?file=1279703#file1279703line17>
> >
> > This whole file seems like a pretty substantial change. I'd recommend
> > pulling it out into a separate review (rather than hiding it in this
> > review).
> >
> > Also, you'll want to consider making folders "contenders" and
> > "detectors". Then renaming this file "standalone.hpp".
>
> Anurag Singh wrote:
> Ok. Although then zookeeper's classes should also go into their own files.
>
> Anurag Singh wrote:
> Looking at this again, the changes in this file are really just namespace
> changes (the only thing substantial is the removal of the MasterContender
> class definition) - I can't put them into a different commit without breaking
> the build (I'm trying to make sure individual commits don't break builds,
> which I think is a sensible goal). However, I can leave this commit as is but
> create a separate commit to create the contenders/detectors directories. Is
> that acceptable to you?
>
> Anurag Singh wrote:
> Ping ... will the suggestion I made work for you?
>
> Joseph Wu wrote:
> Don't worry about having atomic commits (especially for verbose changes).
>
> There are a couple of changes to consider here, each of which might
> deserve its own review:
> - Pulling out the interface deletions. (You also consider pulling it
> into the previous review, as you're really moving the code from private to
> public headers.)
> - Adding a folder for each module you are adding ("contender" and
> "detector").
> - Breaking apart the Standalone vs Zookeeper logic.
>
> Anurag Singh wrote:
> While separating the zookeeper and standalone detectors and moving them
> into detectors, I realized that the functions in the 'promises' namespace
> will be duplicated unless I move them into their own header file. I can
> either put them in include/mesos and change the namespace to mesos
> mesos::internal::promises, or just leave the header file in detectors. Which
> one is preferable? bmahler had a todo for doing this so I'm not sure if your
> team already has some work planned in this area.
>
> Joseph Wu wrote:
> I would *tentatively* recommend putting those helpers inside
> `3rdparty/libprocess/include/process/collect.hpp`, where we have a bunch of
> other helpers that operate on groups of `Futures`. We definitely want those
> helpers in a libprocess header somewhere, but I'm not sure what the most
> acceptable place would be. (I'll ask BenM about it.)
>
> Anurag Singh wrote:
> The logic separation change has turned into a major change - if you see a
> lot of issues with the commits, we should spin the separation change into an
> issue by itself (I can work on that if needed). It will allow this review to
> proceed faster - unfortunately we're blocked on our module changes until this
> review completes.
Hi ... have you had a chance to take another look?
- Anurag
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44288/#review121944
---
On March 10, 2016, 11:45 p.m., Anurag Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44288/
> ---
>
> (Updated March 10, 2016, 11:45 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-4610
> https://issues.apache.org/jira/browse/MESOS-4610
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Also modified users of MasterContender and MasterDetector to use this
> namespace.
>
>
> Diffs
> -
>
> include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54
> include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1
> src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d
> src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9
> src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735
> src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e
> src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79
> src/master/master.hpp ea26670e6c6c67314406fded510e8fdd46053dc8
> src/master/master.cpp 57ff4a39039f573b8586bc03f873f97826b97f6f
> src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a20
Re: Review Request 44289: Added support for contender and detector modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added support for contender and detector modules. Diffs (updated) - include/mesos/module/contender.hpp PRE-CREATION include/mesos/module/detector.hpp PRE-CREATION src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 src/examples/test_contender_module.cpp PRE-CREATION src/examples/test_detector_module.cpp PRE-CREATION src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 src/master/contenders/zookeeper.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9 src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a Diff: https://reviews.apache.org/r/44289/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh
Re: Review Request 44288: Changed MasterDetector/Contender namespace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 10, 2016, 11:45 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Also modified users of MasterContender and MasterDetector to use this namespace. Diffs (updated) - include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 include/mesos/v1/scheduler.hpp 765935e97b6c1686ab464a5cf1cf2dfd816f51f1 src/cli/resolve.cpp 257e29034abf32491511f9a4e476b6859714829d src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 src/master/master.hpp ea26670e6c6c67314406fded510e8fdd46053dc8 src/master/master.cpp 57ff4a39039f573b8586bc03f873f97826b97f6f src/sched/sched.cpp 525255eec808c3fe5c0e38b3d1a2086bbd4eb171 src/scheduler/scheduler.cpp b010a819132fb80810e7f8ce96778109f2e8b35e src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 src/tests/fault_tolerance_tests.cpp d193897e636efd0e3ef67bf67fcd6255a3de0341 src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8 src/tests/master_contender_detector_tests.cpp 255ab8119a04b55bb4f1b61dee19c4be64499376 src/tests/master_slave_reconciliation_tests.cpp d41178eb41df519073fc0890c5716bbc9fed6ad2 src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 src/tests/persistent_volume_tests.cpp bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 src/tests/reservation_tests.cpp d7f9de6f2bce061316916260f356efdb96ecd482 src/tests/scheduler_event_call_tests.cpp 8c02ceeb3ec1783cb2f63f100700508e70f586e4 src/tests/scheduler_http_api_tests.cpp dfb0f51fec67a3951e396eab28eedb0dbf9493ae src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44288/diff/ Testing --- See https://reviews.apache.org/r/44289/. Thanks, Anurag Singh
Re: Review Request 44670: Added master_detector and master_contender flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The master_detector and master_contender flags allow modules to be used for specifying the MasterContender and MasterDetector implementations to use. Diffs (updated) - src/master/flags.hpp 6f53099eab9b0e5917e508bef24b2c85302b33e2 src/master/flags.cpp be981ed6155edce18bdb55188c78d73182159418 src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb Diff: https://reviews.apache.org/r/44670/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Anurag Singh
Re: Review Request 44546: Moved functions in promises to a common header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved functions in promises to a common header file. Diffs (updated) - src/master/detectors/standalone.cpp PRE-CREATION src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The createFromModule will be used to create a MasterContender/Detector from a module (specified using the --modules flag on the command line). Diffs (updated) - src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44544: Moved contender and detector definitions into separate directories.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved contender and detector definitions into separate directories. Diffs (updated) - src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44544/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44547: Added functions in promises to the collect header.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added functions in promises to the collect header. Diffs (updated) - 3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc Diff: https://reviews.apache.org/r/44547/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 10, 2016, 11:45 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- MasterContender and MasterDetector abstract classes can be subclassed by user-provided classes to allow for arbitrary contender/detector implementations. Diffs (updated) - include/mesos/master/contender.hpp PRE-CREATION include/mesos/master/detector.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44287/diff/ Testing --- See https://reviews.apache.org/r/44289/. Thanks, Anurag Singh
Re: Review Request 44545: Separated standalone and zookeeper classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 10, 2016, 11:46 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Instead of keeping standalone and zookeper contender/detector class definitions and implementations in the same file, separated them. Also made the necessary changes in users of class headers to point to the new locations. Diffs (updated) - src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/master/contenders/contender.hpp PRE-CREATION src/master/contenders/contender.cpp PRE-CREATION src/master/contenders/standalone.cpp PRE-CREATION src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e src/master/detectors/detector.hpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION src/master/detectors/standalone.cpp PRE-CREATION src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 src/master/master.hpp ea26670e6c6c67314406fded510e8fdd46053dc8 src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb src/tests/authentication_tests.cpp 85f14c3d453ca5aeffa1c915f38fe3031c2cf712 src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 src/tests/containerizer/external_containerizer_test.cpp 8e1dbe306a088eb16cd3b9c6174b95fad5685da4 src/tests/containerizer/isolator_tests.cpp 342037ce0a5f8caa4e3cf1550b8f9a7cc328acf9 src/tests/fault_tolerance_tests.cpp d193897e636efd0e3ef67bf67fcd6255a3de0341 src/tests/gc_tests.cpp 61a8abb9581dc4602b197a88a677b19386969cbf src/tests/master_allocator_tests.cpp cba7c36471f93b678d94e1da0251a28a893696b1 src/tests/master_authorization_tests.cpp 29c89fb11da792c3e71eb880a19657ea225b3cc8 src/tests/master_contender_detector_tests.cpp 255ab8119a04b55bb4f1b61dee19c4be64499376 src/tests/master_slave_reconciliation_tests.cpp d41178eb41df519073fc0890c5716bbc9fed6ad2 src/tests/master_tests.cpp 2f4d820e223a48700ce1ac3a91b7256cc836c268 src/tests/mesos.hpp 9c62833e0a64cfd62fce8cffd04f9cdd933646c8 src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e src/tests/partition_tests.cpp 3776a0a104582f60b9f19ea58b011485194399b9 src/tests/persistent_volume_tests.cpp bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 src/tests/reconciliation_tests.cpp 97112c4d64c75a16fdd7bbefd517a039fbf55b64 src/tests/reservation_tests.cpp d7f9de6f2bce061316916260f356efdb96ecd482 src/tests/scheduler_event_call_tests.cpp 8c02ceeb3ec1783cb2f63f100700508e70f586e4 src/tests/scheduler_http_api_tests.cpp dfb0f51fec67a3951e396eab28eedb0dbf9493ae src/tests/scheduler_tests.cpp fa42fb42f2d18060a867ade547cebbdcaead07d4 src/tests/slave_recovery_tests.cpp bd7b94f3f1fac6705e5bf14c6f6103b540cde56c src/tests/slave_tests.cpp 124e9587180f2a55e659d966d1c9060234c19457 Diff: https://reviews.apache.org/r/44545/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 10, 2016, 9:22 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- The createFromModule will be used to create a MasterContender/Detector from a module (specified using the --modules flag on the command line). Diffs (updated) - src/master/contenders/contender.cpp PRE-CREATION src/master/detectors/detector.cpp PRE-CREATION Diff: https://reviews.apache.org/r/44669/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44547: Added functions in promises to the collect header.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 10, 2016, 9:22 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Added functions in promises to the collect header. Diffs (updated) - 3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc Diff: https://reviews.apache.org/r/44547/diff/ Testing --- Thanks, Anurag Singh
Re: Review Request 44546: Moved functions in promises to a common header file.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 10, 2016, 9:22 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-4610 https://issues.apache.org/jira/browse/MESOS-4610 Repository: mesos Description --- Moved functions in promises to a common header file. Diffs (updated) - src/master/detectors/standalone.cpp PRE-CREATION src/master/detectors/zookeeper.cpp 9274435802d6292b183be48f42b43999476e016e Diff: https://reviews.apache.org/r/44546/diff/ Testing --- Thanks, Anurag Singh
