Review Request 51352: Make docker executor unversioned.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51352/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Qian Zhang, and Vinod Kone. Bugs: MESOS-5227 https://issues.apache.org/jira/browse/MESOS-5227 Repository: mesos Description --- This fix updates the docker executor so that it is unversioned (instead of v1). This fix is part of MESOS-5227. Diffs - src/docker/executor.cpp 8d679cd33b6ddf3a5c11bb8c458a97b8809473ac Diff: https://reviews.apache.org/r/51352/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 51351: Update HttpDockerExecutor with v1 API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51351/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Qian Zhang, and Vinod Kone. Bugs: MESOS-5227 https://issues.apache.org/jira/browse/MESOS-5227 Repository: mesos Description --- This patch is part of the MESOS-5227: Implement HTTP Docker Executor that uses the Executor Library. Diffs - src/docker/executor.cpp 8d679cd33b6ddf3a5c11bb8c458a97b8809473ac src/internal/devolve.hpp 90681ebe454e12e39b214248f7457931e32295dc src/internal/devolve.cpp efcc5d6050c5cb2fb79a4d676e4427f02e03eae9 Diff: https://reviews.apache.org/r/51351/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).
> On July 30, 2016, 5:36 p.m., haosdent huang wrote: > > support/mesos-style.py, line 20 > > <https://reviews.apache.org/r/50629/diff/1/?file=1458595#file1458595line20> > > > > I think we forgot update this since we update bundle dependencies last > > time. May you post this in a sperate patch? Need update according to > > current `*.tar.gz` under `3rdparty`. Thanks haosdent. Another review request: https://reviews.apache.org/r/50630/ has been created separately to cover the mesos-style.py changes. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50629/#review144266 ------- On July 30, 2016, 6 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50629/ > --- > > (Updated July 30, 2016, 6 p.m.) > > > Review request for mesos, haosdent huang and Deshi Xiao. > > > Bugs: MESOS-5186 > https://issues.apache.org/jira/browse/MESOS-5186 > > > Repository: mesos > > > Description > --- > > This fix updated the requirement in `python/interface/setup.py.in` > so that protobuf 3.0 is allowed. > > > Diffs > - > > src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa > > Diff: https://reviews.apache.org/r/50629/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50629/ --- (Updated July 30, 2016, 6 p.m.) Review request for mesos, haosdent huang and Deshi Xiao. Changes --- Split excluded_files in mesos-style.py to Review Request 50630 (https://reviews.apache.org/r/50630/) Bugs: MESOS-5186 https://issues.apache.org/jira/browse/MESOS-5186 Repository: mesos Description --- This fix updated the requirement in `python/interface/setup.py.in` so that protobuf 3.0 is allowed. Diffs (updated) - src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa Diff: https://reviews.apache.org/r/50629/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 50630: Update exclued_files in mesos-style.py.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50630/ --- Review request for mesos, haosdent huang and Deshi Xiao. Repository: mesos Description --- This fix updates excluded_files in mesos-style.py so that it matches the current 3rd party packages. This fix is related to https://reviews.apache.org/r/50629/ Diffs - support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 Diff: https://reviews.apache.org/r/50630/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50629/ --- Review request for mesos, haosdent huang and Deshi Xiao. Bugs: MESOS-5186 https://issues.apache.org/jira/browse/MESOS-5186 Repository: mesos Description --- This fix updated the requirement in `python/interface/setup.py.in` so that protobuf 3.0 is allowed. Diffs - src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 Diff: https://reviews.apache.org/r/50629/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).
> On July 26, 2016, 8:30 p.m., Greg Mann wrote: > > Hi Yong, > > Do you still have interest in getting this committed? If so, it looks like > > it needs to be rebased. Thanks Greg. I tried to rebase but my local copy has been lost. Don't know how to recover so I just created a new review request: https://reviews.apache.org/r/50473/ Please take a look and let me know if there are any issues. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45011/#review143603 --- On March 18, 2016, 10:49 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45011/ > --- > > (Updated March 18, 2016, 10:49 p.m.) > > > Review request for mesos, Jie Yu, Neil Conway, and Cong Wang. > > > Bugs: MESOS-4070 > https://issues.apache.org/jira/browse/MESOS-4070 > > > Repository: mesos > > > Description > --- > > This fix updated the implementation of numify() so that negative numbers > could be handled conssitently for hex and non-hex numbers. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp > 26a637bec1193dd51437bd689c34fbe6d1935d89 > 3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp > 444377df00922df12d4b3ed25b4cfe9071cff5c3 > > Diff: https://reviews.apache.org/r/45011/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Review Request 50473: Fix numify() to handle negative numbers consistently (MESOS-4070).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50473/ --- Review request for mesos, Greg Mann, Jie Yu, Neil Conway, and Cong Wang. Bugs: MESOS-4070 https://issues.apache.org/jira/browse/MESOS-4070 Repository: mesos Description --- This fix updated the implementation of numify() so that negative numbers could be handled conssitently for hex and non-hex numbers. Diffs - 3rdparty/stout/include/stout/numify.hpp 26a637bec1193dd51437bd689c34fbe6d1935d89 3rdparty/stout/tests/numify_tests.cpp 444377df00922df12d4b3ed25b4cfe9071cff5c3 Diff: https://reviews.apache.org/r/50473/diff/ Testing --- make check (Ubuntu 14.04) NOTE: This RR is from #45011. Thanks, Yong Tang
Review Request 49240: Update HttpDockerExecutor with v1 API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49240/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Qian Zhang, and Vinod Kone. Bugs: MESOS-5227 https://issues.apache.org/jira/browse/MESOS-5227 Repository: mesos Description --- This patch is part of the MESOS-5227: Implement HTTP Docker Executor that uses the Executor Library. Diffs - src/docker/executor.cpp 88b7fc4c36ed3974ac6b103a29e1d975619f0c69 src/internal/devolve.hpp 4a6ae681d37b3405ee81c4a58388b8d501743ebf src/internal/devolve.cpp cecb22e49614c6ee47489eead1d3161e033a53ef Diff: https://reviews.apache.org/r/49240/diff/ Testing --- make check on Ubuntu 14.04 Thanks, Yong Tang
Review Request 46617: Update HttpDockerExecutor with v1 API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46617/ --- Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone. Bugs: MESOS-5227 https://issues.apache.org/jira/browse/MESOS-5227 Repository: mesos Description --- This patch updatess HttpDockerExecutor with v1 API. This is the third step to: MESOS-5227: Implement HTTP Docker Executor that uses the Executor Library. Diffs - src/docker/http_docker_executor.cpp PRE-CREATION src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 Diff: https://reviews.apache.org/r/46617/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 46616: Add --http_docker_executor flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46616/ --- Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone. Bugs: MESOS-5227 https://issues.apache.org/jira/browse/MESOS-5227 Repository: mesos Description --- This patch adds http_docker_executor flag to command line options. This is the second step to: MESOS-5227: Implement HTTP Docker Executor that uses the Executor Library. Diffs - docs/configuration.md 86ba66ac62295ca148524bcb2e57fee560ac4ac5 src/slave/containerizer/docker.cpp 30f85a13f70fc2b1e04dbf0ca7f47bff806e4672 src/slave/flags.hpp ee520acc459564fe68272950948fc80c5e24513a src/slave/flags.cpp 10d2974bd2b6e79255fc894979607f0d2d00c315 Diff: https://reviews.apache.org/r/46616/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 46615: Add HTTP docker executor to Makefile.am.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46615/ --- Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone. Bugs: MESOS-5227 https://issues.apache.org/jira/browse/MESOS-5227 Repository: mesos Description --- This patch adds HTTP docker executor to Makefile.am, and adds docker/http_docker_executor.cpp, which is identical to docker/executor.cpp. This is the first step to: MESOS-5227: Implement HTTP Docker Executor that uses the Executor Library. Diffs - src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca src/docker/http_docker_executor.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46615/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.
> On April 21, 2016, 8:49 p.m., Vinod Kone wrote: > > Thanks for the detailed review. The path has been updated. Please let me know if there are any other issues. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review129948 --- On April 22, 2016, 5:28 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46364/ > --- > > (Updated April 22, 2016, 5:28 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-5014 and MESOS-5015 > https://issues.apache.org/jira/browse/MESOS-5014 > https://issues.apache.org/jira/browse/MESOS-5015 > > > Repository: mesos > > > Description > --- > > This patch changes from `default` statement to explicit case > statement (`UNKNOWN`) so that complier could help catching all > switches when new enums are introduced in the future. > > This patch is related to: > https://reviews.apache.org/r/45317/ (MESOS-5014) > https://reviews.apache.org/r/45304/ (MESOS-5015) > > > Diffs > - > > src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb > src/examples/long_lived_executor.cpp > ebb9cbf578d79fd87ac51ea85575950b7c0a1504 > src/examples/long_lived_framework.cpp > c696ccb6b2ace6e047f6509b291dd14be240cf70 > src/examples/test_http_executor.cpp > ceb489d43f35d24c8a7f5fbb0148529745ee357a > src/examples/test_http_framework.cpp > 8cc3107034d46cb6a2966835f509508223c6e674 > src/launcher/http_command_executor.cpp > 9dfe48108cababeb2d4a6af74434880d79245c21 > src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 > src/master/master.cpp 6dacf5fbd73771e5c31ffb0e8723cd2905dcefb3 > src/master/validation.cpp 0cd118ee4f89f749a063f6ba7f419d5a220dc1d4 > src/sched/sched.cpp 5393f0de655d03ac1a31b3144d4d764d4aeb56fb > src/slave/http.cpp f887a71684304a82ff0d81dbd240e29aa7e2ac67 > src/slave/validation.cpp ec1a4b6d9c55ab0c9894d5a49e290e15dee32c22 > src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b > > Diff: https://reviews.apache.org/r/46364/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 46470: Change to explicit case statements (`UNKNOWN`) for authorization.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46470/ --- (Updated April 22, 2016, 5:29 a.m.) Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. Changes --- Update review request from https://reviews.apache.org/r/46364/ Bugs: MESOS-5031 https://issues.apache.org/jira/browse/MESOS-5031 Repository: mesos Description --- This patch changes from `default` statement to explicit case statement (`UNKNOWN`) so that complier could help catching all switches when new enums are introduced in the future. This patch is related to: https://reviews.apache.org/r/45342/ (MESOS-5031) Diffs (updated) - src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1 Diff: https://reviews.apache.org/r/46470/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote:
> > can you also update cli/execute.cpp, examples/test_http_framework.cpp,
> > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp,
> > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp?
> >
> > make sure to grep through the code base to catch all other cases where
> > switch over an enum uses a "default".
>
> Yong Tang wrote:
> Thanks Vinod for the review. I just updated the listed files.
>
> Yong Tang wrote:
> Oh I noticed there are 54 other instances of "default:" (e.g.,
> src/slave/slave.cpp). I will rework on the review request.
>
> Yong Tang wrote:
> Hi Ben/Vinod,
>
> I take a second look at this issue and I am not so sure about the scope.
> Is the goal of this task to replace/remove ALL usages of `default:` in switch
> statement, or this taks is to replace only Event/Call related ones with
> 'UNKNOWN'? For example, I saw the usage of the following in
> src/docker/docker.cpp:
>
> ```
> if (volume.has_mode()) {
> switch (volume.mode()) {
> case Volume::RW: volumeConfig += ":rw"; break;
> case Volume::RO: volumeConfig += ":ro"; break;
> default: return Failure("Unsupported volume mode");
> }
> }
> ```
> I am not sure if we should remove the "default:" line in the above or not.
>
> Let me know which way is the preferred way and I will update the review
> request.
>
> Vinod Kone wrote:
> Just Event/Call in this review. And perhaps AuthZ Action in another
> review.
Thanks Vinod. The review request has been updated. I used grep and it should
have covered all Event/Call enum types. I also create another review request
https://reviews.apache.org/r/46470/ to cover authorization enum types. Let me
know if there are any issues.
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46364/#review129486
---
On April 21, 2016, 2:28 a.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46364/
> ---
>
> (Updated April 21, 2016, 2:28 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-5014 and MESOS-5015
> https://issues.apache.org/jira/browse/MESOS-5014
> https://issues.apache.org/jira/browse/MESOS-5015
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This patch changes from `default` statement to explicit case
> statement (`UNKNOWN`) so that complier could help catching all
> switches when new enums are introduced in the future.
>
> This patch is related to:
> https://reviews.apache.org/r/45317/ (MESOS-5014)
> https://reviews.apache.org/r/45304/ (MESOS-5015)
>
>
> Diffs
> -
>
> src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb
> src/examples/long_lived_executor.cpp
> ebb9cbf578d79fd87ac51ea85575950b7c0a1504
> src/examples/long_lived_framework.cpp
> c696ccb6b2ace6e047f6509b291dd14be240cf70
> src/examples/test_http_executor.cpp
> ceb489d43f35d24c8a7f5fbb0148529745ee357a
> src/examples/test_http_framework.cpp
> 8cc3107034d46cb6a2966835f509508223c6e674
> src/launcher/http_command_executor.cpp
> ad484e0e6f5067b6c166111c91b1ff1e8c05d9ac
> src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9
> src/master/master.cpp 6dacf5fbd73771e5c31ffb0e8723cd2905dcefb3
> src/master/validation.cpp 0cd118ee4f89f749a063f6ba7f419d5a220dc1d4
> src/sched/sched.cpp 5393f0de655d03ac1a31b3144d4d764d4aeb56fb
> src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c
> src/slave/validation.cpp ec1a4b6d9c55ab0c9894d5a49e290e15dee32c22
> src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
>
> Diff: https://reviews.apache.org/r/46364/diff/
>
>
> Testing
> ---
>
> make check (Ubuntu 14.04)
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/ --- (Updated April 21, 2016, 2:28 a.m.) Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. Changes --- Link review request to MESOS-5014/MESOS-5015. Bugs: MESOS-5014 and MESOS-5015 https://issues.apache.org/jira/browse/MESOS-5014 https://issues.apache.org/jira/browse/MESOS-5015 Repository: mesos Description --- This patch changes from `default` statement to explicit case statement (`UNKNOWN`) so that complier could help catching all switches when new enums are introduced in the future. This patch is related to: https://reviews.apache.org/r/45317/ (MESOS-5014) https://reviews.apache.org/r/45304/ (MESOS-5015) Diffs - src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb src/examples/long_lived_executor.cpp ebb9cbf578d79fd87ac51ea85575950b7c0a1504 src/examples/long_lived_framework.cpp c696ccb6b2ace6e047f6509b291dd14be240cf70 src/examples/test_http_executor.cpp ceb489d43f35d24c8a7f5fbb0148529745ee357a src/examples/test_http_framework.cpp 8cc3107034d46cb6a2966835f509508223c6e674 src/launcher/http_command_executor.cpp ad484e0e6f5067b6c166111c91b1ff1e8c05d9ac src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 src/master/master.cpp 6dacf5fbd73771e5c31ffb0e8723cd2905dcefb3 src/master/validation.cpp 0cd118ee4f89f749a063f6ba7f419d5a220dc1d4 src/sched/sched.cpp 5393f0de655d03ac1a31b3144d4d764d4aeb56fb src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c src/slave/validation.cpp ec1a4b6d9c55ab0c9894d5a49e290e15dee32c22 src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b Diff: https://reviews.apache.org/r/46364/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 46470: Change to explicit case statements (`UNKNOWN`) for authorization.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46470/ --- Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. Bugs: MESOS-5031 https://issues.apache.org/jira/browse/MESOS-5031 Repository: mesos Description --- This patch changes from `default` statement to explicit case statement (`UNKNOWN`) so that complier could help catching all switches when new enums are introduced in the future. This patch is related to: https://reviews.apache.org/r/45342/ (MESOS-5031) Diffs - src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1 Diff: https://reviews.apache.org/r/46470/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/ --- (Updated April 21, 2016, 2:25 a.m.) Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. Changes --- Update review request to cover all Event/Call enum types. Bugs: MESOS-5031 https://issues.apache.org/jira/browse/MESOS-5031 Repository: mesos Description (updated) --- This patch changes from `default` statement to explicit case statement (`UNKNOWN`) so that complier could help catching all switches when new enums are introduced in the future. This patch is related to: https://reviews.apache.org/r/45317/ (MESOS-5014) https://reviews.apache.org/r/45304/ (MESOS-5015) Diffs (updated) - src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb src/examples/long_lived_executor.cpp ebb9cbf578d79fd87ac51ea85575950b7c0a1504 src/examples/long_lived_framework.cpp c696ccb6b2ace6e047f6509b291dd14be240cf70 src/examples/test_http_executor.cpp ceb489d43f35d24c8a7f5fbb0148529745ee357a src/examples/test_http_framework.cpp 8cc3107034d46cb6a2966835f509508223c6e674 src/launcher/http_command_executor.cpp ad484e0e6f5067b6c166111c91b1ff1e8c05d9ac src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 src/master/master.cpp 6dacf5fbd73771e5c31ffb0e8723cd2905dcefb3 src/master/validation.cpp 0cd118ee4f89f749a063f6ba7f419d5a220dc1d4 src/sched/sched.cpp 5393f0de655d03ac1a31b3144d4d764d4aeb56fb src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c src/slave/validation.cpp ec1a4b6d9c55ab0c9894d5a49e290e15dee32c22 src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b Diff: https://reviews.apache.org/r/46364/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote:
> > can you also update cli/execute.cpp, examples/test_http_framework.cpp,
> > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp,
> > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp?
> >
> > make sure to grep through the code base to catch all other cases where
> > switch over an enum uses a "default".
>
> Yong Tang wrote:
> Thanks Vinod for the review. I just updated the listed files.
>
> Yong Tang wrote:
> Oh I noticed there are 54 other instances of "default:" (e.g.,
> src/slave/slave.cpp). I will rework on the review request.
Hi Ben/Vinod,
I take a second look at this issue and I am not so sure about the scope. Is the
goal of this task to replace/remove ALL usages of `default:` in switch
statement, or this taks is to replace only Event/Call related ones with
'UNKNOWN'? For example, I saw the usage of the following in
src/docker/docker.cpp:
```
if (volume.has_mode()) {
switch (volume.mode()) {
case Volume::RW: volumeConfig += ":rw"; break;
case Volume::RO: volumeConfig += ":ro"; break;
default: return Failure("Unsupported volume mode");
}
}
```
I am not sure if we should remove the "default:" line in the above or not.
Let me know which way is the preferred way and I will update the review request.
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46364/#review129486
---
On April 19, 2016, 3:19 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46364/
> ---
>
> (Updated April 19, 2016, 3:19 p.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-5031
> https://issues.apache.org/jira/browse/MESOS-5031
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This patch changes from `default` statement to explicit case
> statement (`UNKNOWN`) so that complier could help catching all
> switches when new enums are introduced in the future.
>
> This patch is related to:
> https://reviews.apache.org/r/45317/ (MESOS-5014)
> https://reviews.apache.org/r/45304/ (MESOS-5015)
> https://reviews.apache.org/r/45342/ (MESOS-5031)
>
>
> Diffs
> -
>
> src/authorizer/local/authorizer.cpp
> c744a16041c2466d3839a37fbee2bf86887bf4e1
> src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb
> src/examples/long_lived_framework.cpp
> c696ccb6b2ace6e047f6509b291dd14be240cf70
> src/examples/test_http_executor.cpp
> ceb489d43f35d24c8a7f5fbb0148529745ee357a
> src/examples/test_http_framework.cpp
> 8cc3107034d46cb6a2966835f509508223c6e674
> src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9
> src/master/master.cpp 6dacf5fbd73771e5c31ffb0e8723cd2905dcefb3
> src/master/validation.cpp 0cd118ee4f89f749a063f6ba7f419d5a220dc1d4
> src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c
> src/slave/validation.cpp ec1a4b6d9c55ab0c9894d5a49e290e15dee32c22
> src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
>
> Diff: https://reviews.apache.org/r/46364/diff/
>
>
> Testing
> ---
>
> make check (Ubuntu 14.04)
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote: > > can you also update cli/execute.cpp, examples/test_http_framework.cpp, > > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, > > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp? > > > > make sure to grep through the code base to catch all other cases where > > switch over an enum uses a "default". > > Yong Tang wrote: > Thanks Vinod for the review. I just updated the listed files. Oh I noticed there are 54 other instances of "default:" (e.g., src/slave/slave.cpp). I will rework on the review request. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review129486 --- On April 19, 2016, 3:19 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46364/ > --- > > (Updated April 19, 2016, 3:19 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-5031 > https://issues.apache.org/jira/browse/MESOS-5031 > > > Repository: mesos > > > Description > --- > > This patch changes from `default` statement to explicit case > statement (`UNKNOWN`) so that complier could help catching all > switches when new enums are introduced in the future. > > This patch is related to: > https://reviews.apache.org/r/45317/ (MESOS-5014) > https://reviews.apache.org/r/45304/ (MESOS-5015) > https://reviews.apache.org/r/45342/ (MESOS-5031) > > > Diffs > - > > src/authorizer/local/authorizer.cpp > c744a16041c2466d3839a37fbee2bf86887bf4e1 > src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb > src/examples/long_lived_framework.cpp > c696ccb6b2ace6e047f6509b291dd14be240cf70 > src/examples/test_http_executor.cpp > ceb489d43f35d24c8a7f5fbb0148529745ee357a > src/examples/test_http_framework.cpp > 8cc3107034d46cb6a2966835f509508223c6e674 > src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 > src/master/master.cpp 6dacf5fbd73771e5c31ffb0e8723cd2905dcefb3 > src/master/validation.cpp 0cd118ee4f89f749a063f6ba7f419d5a220dc1d4 > src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c > src/slave/validation.cpp ec1a4b6d9c55ab0c9894d5a49e290e15dee32c22 > src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b > > Diff: https://reviews.apache.org/r/46364/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.
> On April 19, 2016, 5:58 a.m., Vinod Kone wrote: > > can you also update cli/execute.cpp, examples/test_http_framework.cpp, > > examples/long_lived_framework.cpp, master/validation.cpp, master/http.cpp, > > master/master.cpp, slave/http.cpp, slave/validation.cpp and slave/http.cpp? > > > > make sure to grep through the code base to catch all other cases where > > switch over an enum uses a "default". Thanks Vinod for the review. I just updated the listed files. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review129486 ------- On April 19, 2016, 3:19 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46364/ > --- > > (Updated April 19, 2016, 3:19 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-5031 > https://issues.apache.org/jira/browse/MESOS-5031 > > > Repository: mesos > > > Description > --- > > This patch changes from `default` statement to explicit case > statement (`UNKNOWN`) so that complier could help catching all > switches when new enums are introduced in the future. > > This patch is related to: > https://reviews.apache.org/r/45317/ (MESOS-5014) > https://reviews.apache.org/r/45304/ (MESOS-5015) > https://reviews.apache.org/r/45342/ (MESOS-5031) > > > Diffs > - > > src/authorizer/local/authorizer.cpp > c744a16041c2466d3839a37fbee2bf86887bf4e1 > src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb > src/examples/long_lived_framework.cpp > c696ccb6b2ace6e047f6509b291dd14be240cf70 > src/examples/test_http_executor.cpp > ceb489d43f35d24c8a7f5fbb0148529745ee357a > src/examples/test_http_framework.cpp > 8cc3107034d46cb6a2966835f509508223c6e674 > src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 > src/master/master.cpp 6dacf5fbd73771e5c31ffb0e8723cd2905dcefb3 > src/master/validation.cpp 0cd118ee4f89f749a063f6ba7f419d5a220dc1d4 > src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c > src/slave/validation.cpp ec1a4b6d9c55ab0c9894d5a49e290e15dee32c22 > src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b > > Diff: https://reviews.apache.org/r/46364/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/ --- (Updated April 19, 2016, 3:19 p.m.) Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. Changes --- Replace UNREACHABLE with LOG(WARNING) based on review from Vinod. Bugs: MESOS-5031 https://issues.apache.org/jira/browse/MESOS-5031 Repository: mesos Description --- This patch changes from `default` statement to explicit case statement (`UNKNOWN`) so that complier could help catching all switches when new enums are introduced in the future. This patch is related to: https://reviews.apache.org/r/45317/ (MESOS-5014) https://reviews.apache.org/r/45304/ (MESOS-5015) https://reviews.apache.org/r/45342/ (MESOS-5031) Diffs (updated) - src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1 src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb src/examples/long_lived_framework.cpp c696ccb6b2ace6e047f6509b291dd14be240cf70 src/examples/test_http_executor.cpp ceb489d43f35d24c8a7f5fbb0148529745ee357a src/examples/test_http_framework.cpp 8cc3107034d46cb6a2966835f509508223c6e674 src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 src/master/master.cpp 6dacf5fbd73771e5c31ffb0e8723cd2905dcefb3 src/master/validation.cpp 0cd118ee4f89f749a063f6ba7f419d5a220dc1d4 src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c src/slave/validation.cpp ec1a4b6d9c55ab0c9894d5a49e290e15dee32c22 src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b Diff: https://reviews.apache.org/r/46364/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 46246: Log executor commands w/o verbose logs enabled.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46246/ --- Review request for mesos, Artem Harutyunyan and Joseph Wu. Bugs: MESOS-5197 https://issues.apache.org/jira/browse/MESOS-5197 Repository: mesos Description --- This patch changes the logging in docker.cpp from VLOG to LOG(INFO). The reason is that, the command line that has been executed by executor is useful in debug purposes. Diffs - src/docker/docker.cpp 19cf424dfd5748ae66a7023840aa2b0652e8f2c0 Diff: https://reviews.apache.org/r/46246/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/ --- (Updated April 4, 2016, 3:22 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Update the review request as https://reviews.apache.org/r/45033/ has changed. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description --- This is part of MESOS-4033: Add a commit hook for checking non-ascii characters. Note: The commit hook requires separate commits for libprocess and mesos. Diffs (updated) - src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 Diff: https://reviews.apache.org/r/45660/diff/ Testing --- make check Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).
> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote:
> > support/mesos-style.py, line 120
> > <https://reviews.apache.org/r/45033/diff/8/?file=1323577#file1323577line120>
> >
> > It would be great if we could `+ 1` the `chars` here like we already
> > do for the `line_number` in order to keep this all in one place. We could
> > also use this opportunity to go for less incidental list formatting, e.g.,
> >
> > chars=', '.join([str(char + 1) for char in char_errors]) # gives
> > e.g., "Line: 10, Chars: 1, 2, 3:
>
> Yong Tang wrote:
> Thanks Benjamin. In Ln 112 the "+ 1" of the Chars has already been
> processed ("offset + 1").
>
> Benjamin Bannier wrote:
> Exactly! My point was that I wasn't sure that doing these operations on
> `line_numer` and `char_errors` in different operations helped clarity.
>
> Yong Tang wrote:
> Oh I see. Let me update the review request.
Thanks for the review Benjamin. The review request has been updated. Let me
know if there are any other issues.
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review126806
---
On April 4, 2016, 3:21 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> ---
>
> (Updated April 4, 2016, 3:21 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi
> Xiao.
>
>
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This patch adds an addition check in mesos-style.pl to check
> for non-printable characters. It scans .cpp, .hpp, .cc, .h
> files and reports an error if non-printable characters exist.
>
> As part of this patch, two non-printable characters have been identified
> in versioning.md (one in Line 85 and another in Line 96) and are corrected
> accordingly.
>
> Note: Scanning .md files is skipped based on feedback from reviews.
>
> Note: This commit includes patches from Kevin Klues and haosdent.
>
>
> Diffs
> -
>
> docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b
> support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162
>
> Diff: https://reviews.apache.org/r/45033/diff/
>
>
> Testing
> ---
>
> Tested manually and found two non ascii characters in docs/versioning.md
> (fixed as part of this review request).
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/ --- (Updated April 4, 2016, 3:22 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Update the review request as https://reviews.apache.org/r/45033/ has changed. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description --- This is part of MESOS-4033: Add a commit hook for checking non-ascii characters. Note: The commit hook requires separate commits for libprocess and mesos. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238 Diff: https://reviews.apache.org/r/45659/diff/ Testing --- make check Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 4, 2016, 3:21 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Change the location of "+ 1" in chars for ease of readability. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description --- This patch adds an addition check in mesos-style.pl to check for non-printable characters. It scans .cpp, .hpp, .cc, .h files and reports an error if non-printable characters exist. As part of this patch, two non-printable characters have been identified in versioning.md (one in Line 85 and another in Line 96) and are corrected accordingly. Note: Scanning .md files is skipped based on feedback from reviews. Note: This commit includes patches from Kevin Klues and haosdent. Diffs (updated) - docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).
> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote:
> > support/mesos-style.py, line 120
> > <https://reviews.apache.org/r/45033/diff/8/?file=1323577#file1323577line120>
> >
> > It would be great if we could `+ 1` the `chars` here like we already
> > do for the `line_number` in order to keep this all in one place. We could
> > also use this opportunity to go for less incidental list formatting, e.g.,
> >
> > chars=', '.join([str(char + 1) for char in char_errors]) # gives
> > e.g., "Line: 10, Chars: 1, 2, 3:
>
> Yong Tang wrote:
> Thanks Benjamin. In Ln 112 the "+ 1" of the Chars has already been
> processed ("offset + 1").
>
> Benjamin Bannier wrote:
> Exactly! My point was that I wasn't sure that doing these operations on
> `line_numer` and `char_errors` in different operations helped clarity.
Oh I see. Let me update the review request.
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review126806
---
On April 4, 2016, 2:31 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> ---
>
> (Updated April 4, 2016, 2:31 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi
> Xiao.
>
>
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This patch adds an addition check in mesos-style.pl to check
> for non-printable characters. It scans .cpp, .hpp, .cc, .h
> files and reports an error if non-printable characters exist.
>
> As part of this patch, two non-printable characters have been identified
> in versioning.md (one in Line 85 and another in Line 96) and are corrected
> accordingly.
>
> Note: Scanning .md files is skipped based on feedback from reviews.
>
> Note: This commit includes patches from Kevin Klues and haosdent.
>
>
> Diffs
> -
>
> docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b
> support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162
>
> Diff: https://reviews.apache.org/r/45033/diff/
>
>
> Testing
> ---
>
> Tested manually and found two non ascii characters in docs/versioning.md
> (fixed as part of this review request).
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/ --- (Updated April 4, 2016, 2:35 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Update the review request as https://reviews.apache.org/r/45033/ has changed. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description --- This is part of MESOS-4033: Add a commit hook for checking non-ascii characters. Note: The commit hook requires separate commits for libprocess and mesos. Diffs (updated) - src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 Diff: https://reviews.apache.org/r/45660/diff/ Testing --- make check Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).
> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote:
> > support/mesos-style.py, line 120
> > <https://reviews.apache.org/r/45033/diff/8/?file=1323577#file1323577line120>
> >
> > It would be great if we could `+ 1` the `chars` here like we already
> > do for the `line_number` in order to keep this all in one place. We could
> > also use this opportunity to go for less incidental list formatting, e.g.,
> >
> > chars=', '.join([str(char + 1) for char in char_errors]) # gives
> > e.g., "Line: 10, Chars: 1, 2, 3:
Thanks Benjamin. In Ln 112 the "+ 1" of the Chars has already been processed
("offset + 1").
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review126806
-------
On April 4, 2016, 2:31 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> ---
>
> (Updated April 4, 2016, 2:31 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd
> Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi
> Xiao.
>
>
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This patch adds an addition check in mesos-style.pl to check
> for non-printable characters. It scans .cpp, .hpp, .cc, .h
> files and reports an error if non-printable characters exist.
>
> As part of this patch, two non-printable characters have been identified
> in versioning.md (one in Line 85 and another in Line 96) and are corrected
> accordingly.
>
> Note: Scanning .md files is skipped based on feedback from reviews.
>
> Note: This commit includes patches from Kevin Klues and haosdent.
>
>
> Diffs
> -
>
> docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b
> support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162
>
> Diff: https://reviews.apache.org/r/45033/diff/
>
>
> Testing
> ---
>
> Tested manually and found two non ascii characters in docs/versioning.md
> (fixed as part of this review request).
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/ --- (Updated April 4, 2016, 2:34 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Update the review request as https://reviews.apache.org/r/45033/ has changed. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description --- This is part of MESOS-4033: Add a commit hook for checking non-ascii characters. Note: The commit hook requires separate commits for libprocess and mesos. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238 Diff: https://reviews.apache.org/r/45659/diff/ Testing --- make check Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).
> On April 4, 2016, 8:36 a.m., Benjamin Bannier wrote: > > support/mesos-style.py, line 113 > > <https://reviews.apache.org/r/45033/diff/8/?file=1323577#file1323577line113> > > > > Nit-pick: We do not have a Python style, but e.g., the Google Python > > style guide would set `if` right below `offset` (btw, this is also what > > e.g., `pylint` advocates by default). Thanks Benjamin. The review request has been updated for the Google Python style change. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126806 --- On April 4, 2016, 2:31 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated April 4, 2016, 2:31 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This patch adds an addition check in mesos-style.pl to check > for non-printable characters. It scans .cpp, .hpp, .cc, .h > files and reports an error if non-printable characters exist. > > As part of this patch, two non-printable characters have been identified > in versioning.md (one in Line 85 and another in Line 96) and are corrected > accordingly. > > Note: Scanning .md files is skipped based on feedback from reviews. > > Note: This commit includes patches from Kevin Klues and haosdent. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 4, 2016, 2:31 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Update the review request to conform to Google Python style (feedback from Benjamin) Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description --- This patch adds an addition check in mesos-style.pl to check for non-printable characters. It scans .cpp, .hpp, .cc, .h files and reports an error if non-printable characters exist. As part of this patch, two non-printable characters have been identified in versioning.md (one in Line 85 and another in Line 96) and are corrected accordingly. Note: Scanning .md files is skipped based on feedback from reviews. Note: This commit includes patches from Kevin Klues and haosdent. Diffs (updated) - docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang
Re: Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.
> On April 3, 2016, 11:40 p.m., Michael Park wrote: > > Why did you replace `AWAIT_ASSERT_EQ(true/false` only? Why not > > `EQ(true/false` in general, so that we would catch the use of > > `EXPECT_SOME_EQ(true, expr);` in `src/tests/health_check_tests.cpp` for > > example? > > Is there perhaps a separate patch that I don't have a pointer to? > > Yong Tang wrote: > Thanks Michael. I was not sure when I did the change. Let me update the > review request shortly. > > Michael Park wrote: > Ah, ok. Thanks! Hi Michael, I tried to update the review request. However, it seems that the commit hook will not allow me to modify libprocess and mesos at the same time. As a result, I have to create two separate commit to add item (5) of MESOS-4112, then change `_EQ(true/false` to `_TRUE/_FALSE` (which makes the current review request https://reviews.apache.org/r/45356/ obsolete). The list of corect related review requests for MESOS-4112 are now in: https://reviews.apache.org/r/45357/ https://reviews.apache.org/r/45664/ https://reviews.apache.org/r/45663/ Please take a look and let me know if there are any issues. In the meantime, I will close the current review request https://reviews.apache.org/r/45356/. Thanks a lot for the review. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45356/#review126762 ------- On March 26, 2016, 10:35 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45356/ > --- > > (Updated March 26, 2016, 10:35 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4112 > https://issues.apache.org/jira/browse/MESOS-4112 > > > Repository: mesos > > > Description > --- > > This RR is a follow up to MESOS-4112 to replace `AWAIT_ASSERT_EQ(true/false` > with the newly defined `AWAIT_ASSERT_TRUE/_FALSE`. > > > Diffs > - > > src/tests/cram_md5_authentication_tests.cpp > 67f74e208ce138dc1e4667af108af3538b34aee9 > src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50 > src/tests/group_tests.cpp ed10f1fe8a5cd2a353175e13ec3c464da69956f4 > src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc > > Diff: https://reviews.apache.org/r/45356/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Review Request 45664: Replace `EQ(true/false` with `_TRUE/_FALSE` in tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45664/ --- Review request for mesos and Michael Park. Bugs: MESOS-4112 https://issues.apache.org/jira/browse/MESOS-4112 Repository: mesos Description --- This patch is a follow up to MESOS-4112 to replace: 1. AWAIT_EQ(true/false to AWAIT_TRUE/FALSE 2. AWAIT_ASSERT_EQ(true/false to AWAIT_ASSERT_TRUE/_FALSE 3. EXPECT_SOME_EQ(true/false to EXPECT_SOME_TRUE/_FALSE 4. EXPECT_EQ(true/falseto EXPECT_TRUE/_FALSE Diffs - src/tests/containerizer/docker_containerizer_tests.cpp b9c26b92c44e8ca718a5eb333855199bdf2a8e81 src/tests/cram_md5_authentication_tests.cpp 67f74e208ce138dc1e4667af108af3538b34aee9 src/tests/gc_tests.cpp 89a7f735b27b7a836b4ce3af10f26a6d63887279 src/tests/group_tests.cpp acfb1485f655f3bc39ee68448ba041af366f70f5 src/tests/health_check_tests.cpp eace7c35f7240dbdc1bd9dd0a44c2d72127bfa70 src/tests/reconciliation_tests.cpp 5f541f5fe004ede943a1b022daab92f01d1f4853 src/tests/registrar_tests.cpp f8e141bfc0023128f40ca8ecdae7a5609818c2b1 Diff: https://reviews.apache.org/r/45664/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 45663: Add AWAIT_TRUE_FOR/AWAIT_TRUE, AWAIT_FALSE_FOR/AWAIT_FALSE.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45663/ --- Review request for mesos and Michael Park. Bugs: MESOS-4112 https://issues.apache.org/jira/browse/MESOS-4112 Repository: mesos Description --- This is item (5) of MESOS-4112 with the following changes: 1. AWAIT_TRUE_FOR alias to AWAIT_ASSERT_TRUE_FOR. 2. AWAIT_TRUE alias to AWAIT_ASSERT_TRUE. 3. AWAIT_FALSE_FOR alias to AWAIT_ASSERT_FALSE_FOR. 4. AWAIT_FALSE alias to AWAIT_ASSERT_FALSE. Diffs - 3rdparty/libprocess/include/process/gtest.hpp 30d51d3704bd0ad82c6d21f1222d6158aaa61298 Diff: https://reviews.apache.org/r/45663/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 45357: Add HTTP response related macros (AWAIT_ASSERT_RESPONSE_...).
> On April 3, 2016, 11:21 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/gtest.hpp, lines 370-383 > > <https://reviews.apache.org/r/45357/diff/1/?file=1315578#file1315578line370> > > > > Can we introduce the `ASSERT_*` versions before the `EXPECT_*` versions > > for consistency? Here and below. Thanks Michael, just updated the review request. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45357/#review126760 --- On April 4, 2016, 1:56 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45357/ > --- > > (Updated April 4, 2016, 1:56 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4112 > https://issues.apache.org/jira/browse/MESOS-4112 > > > Repository: mesos > > > Description > --- > > This RR is the item (3) for MESOS-4112. It adds HTTP respose > related macros that were not defined before: > 1. AWAIT_ASSERT_RESPONSE_STATUS_EQ_FOR > 2. AWAIT_ASSERT_RESPONSE_STATUS_EQ > 3. AWAIT_ASSERT_RESPONSE_BODY_EQ_FOR > 4. AWAIT_ASSERT_RESPONSE_BODY_EQ > 5. AWAIT_ASSERT_RESPONSE_HEADER_EQ_FOR > 6. AWAIT_ASSERT_RESPONSE_HEADER_EQ > (The above are the counterpart of AWAIT_EXPECT_RESPONSE_...) > > > Diffs > - > > 3rdparty/libprocess/include/process/gtest.hpp > 30d51d3704bd0ad82c6d21f1222d6158aaa61298 > > Diff: https://reviews.apache.org/r/45357/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 45357: Add HTTP response related macros (AWAIT_ASSERT_RESPONSE_...).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45357/ --- (Updated April 4, 2016, 1:56 a.m.) Review request for mesos and Michael Park. Changes --- Update review request according to feedback. Bugs: MESOS-4112 https://issues.apache.org/jira/browse/MESOS-4112 Repository: mesos Description --- This RR is the item (3) for MESOS-4112. It adds HTTP respose related macros that were not defined before: 1. AWAIT_ASSERT_RESPONSE_STATUS_EQ_FOR 2. AWAIT_ASSERT_RESPONSE_STATUS_EQ 3. AWAIT_ASSERT_RESPONSE_BODY_EQ_FOR 4. AWAIT_ASSERT_RESPONSE_BODY_EQ 5. AWAIT_ASSERT_RESPONSE_HEADER_EQ_FOR 6. AWAIT_ASSERT_RESPONSE_HEADER_EQ (The above are the counterpart of AWAIT_EXPECT_RESPONSE_...) Diffs (updated) - 3rdparty/libprocess/include/process/gtest.hpp 30d51d3704bd0ad82c6d21f1222d6158aaa61298 Diff: https://reviews.apache.org/r/45357/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.
> On April 3, 2016, 11:40 p.m., Michael Park wrote: > > Why did you replace `AWAIT_ASSERT_EQ(true/false` only? Why not > > `EQ(true/false` in general, so that we would catch the use of > > `EXPECT_SOME_EQ(true, expr);` in `src/tests/health_check_tests.cpp` for > > example? > > Is there perhaps a separate patch that I don't have a pointer to? Thanks Michael. I was not sure when I did the change. Let me update the review request shortly. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45356/#review126762 --- On March 26, 2016, 10:35 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45356/ > --- > > (Updated March 26, 2016, 10:35 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4112 > https://issues.apache.org/jira/browse/MESOS-4112 > > > Repository: mesos > > > Description > --- > > This RR is a follow up to MESOS-4112 to replace `AWAIT_ASSERT_EQ(true/false` > with the newly defined `AWAIT_ASSERT_TRUE/_FALSE`. > > > Diffs > - > > src/tests/cram_md5_authentication_tests.cpp > 67f74e208ce138dc1e4667af108af3538b34aee9 > src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50 > src/tests/group_tests.cpp ed10f1fe8a5cd2a353175e13ec3c464da69956f4 > src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc > > Diff: https://reviews.apache.org/r/45356/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.
> On April 3, 2016, 10:19 p.m., Kevin Klues wrote: > > Looks great. Glad we are finally able to catch these now! > > > > Only comment would be on the summary line. We typically phrase the summary > > line in the past tense, with a period at the end, i.e.: > > > > ``` > > Changed some non-ascii characters to ascii equivalent. > > ``` The summary and commit message have been updated. Again thanks a lot for the detailed review and help! - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/#review126755 --- On April 3, 2016, 11:47 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45660/ > --- > > (Updated April 3, 2016, 11:47 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This is part of MESOS-4033: Add a commit hook for checking non-ascii > characters. > > Note: The commit hook requires separate commits for libprocess and mesos. > > > Diffs > - > > src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 > src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 > src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 > > Diff: https://reviews.apache.org/r/45660/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yong Tang > >
Re: Review Request 45660: Changed some non-ascii characters to ascii equivalent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/ --- (Updated April 3, 2016, 11:47 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Update the summary and commit message. Summary (updated) - Changed some non-ascii characters to ascii equivalent. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description (updated) --- This is part of MESOS-4033: Add a commit hook for checking non-ascii characters. Note: The commit hook requires separate commits for libprocess and mesos. Diffs (updated) - src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 Diff: https://reviews.apache.org/r/45660/diff/ Testing --- make check Thanks, Yong Tang
Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.
> On April 3, 2016, 10:20 p.m., Kevin Klues wrote: > > Only thing I'd suggest is to change the summary line to: > > > > ``` > > Changed some non-ascii characters in libprocess to their ascii equivalent. > > ``` Thanks the summary and the commit message have been updated. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/#review126756 --- On April 3, 2016, 11:46 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45659/ > --- > > (Updated April 3, 2016, 11:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This is part of MESOS-4033: Add a commit hook for checking non-ascii > characters. > > Note: The commit hook requires separate commits for libprocess and mesos. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp > a1bfc808eb1b1c372acb028019901f0ab3f15238 > > Diff: https://reviews.apache.org/r/45659/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yong Tang > >
Re: Review Request 45659: Changed some non-ascii characters in libprocess to ascii equivalent.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/ --- (Updated April 3, 2016, 11:46 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Update commit message and summary description. Summary (updated) - Changed some non-ascii characters in libprocess to ascii equivalent. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description (updated) --- This is part of MESOS-4033: Add a commit hook for checking non-ascii characters. Note: The commit hook requires separate commits for libprocess and mesos. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238 Diff: https://reviews.apache.org/r/45659/diff/ Testing --- make check Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 3, 2016, 11:45 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Update the commit message. Summary (updated) - Add a commit hook for checking non-printable characters (MESOS-4033). Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description (updated) --- This patch adds an addition check in mesos-style.pl to check for non-printable characters. It scans .cpp, .hpp, .cc, .h files and reports an error if non-printable characters exist. As part of this patch, two non-printable characters have been identified in versioning.md (one in Line 85 and another in Line 96) and are corrected accordingly. Note: Scanning .md files is skipped based on feedback from reviews. Note: This commit includes patches from Kevin Klues and haosdent. Diffs (updated) - docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-printable characters (MESOS-4033).
> On April 3, 2016, 10:13 p.m., Kevin Klues wrote: > > Thanks Yong! > > > > Patch looks great now. The only thing I'd change at this point is the > > wording in the commit message. > > > > Probably something like: > > ``` > > Add a commit hook for checking non-printable characters (MESOS-4033). > > > > This patch adds an addition check in mesos-style.pl to check > > for non-printable characters. It scans .cpp, .hpp, .cc, .h > > files and reports an error if non-printable characters exist. > > > > As part of this patch, two non-printable characters have been identified > > in versioning.md (one in Line 85 and another in Line 96) and are corrected > > accordingly. > > > > Note: Scanning .md files is skipped based on feedback from reviews. > > > > Note: This commit includes patches from Kevin Klues and haosdent. > > ``` > > > > Thanks! Thanks Kevin. The commit message was updated. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126754 --- On April 3, 2016, 11:45 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated April 3, 2016, 11:45 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This patch adds an addition check in mesos-style.pl to check > for non-printable characters. It scans .cpp, .hpp, .cc, .h > files and reports an error if non-printable characters exist. > > As part of this patch, two non-printable characters have been identified > in versioning.md (one in Line 85 and another in Line 96) and are corrected > accordingly. > > Note: Scanning .md files is skipped based on feedback from reviews. > > Note: This commit includes patches from Kevin Klues and haosdent. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Re: Review Request 45659: Fix non-printable chars in libprocess (format.hpp).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/ --- (Updated April 3, 2016, 9:01 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Update description and reviewer's list. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description (updated) --- This is part of MESOS-4033: Add a commit hook for checking non-ascii characters This commit fix the non-printable characters in the following files: 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp Note: The commit hook requires separate commits for libprocess and mesos. That is why this is a separate review request. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238 Diff: https://reviews.apache.org/r/45659/diff/ Testing --- make check Thanks, Yong Tang
Re: Review Request 45660: Fix non-printable chars in mesos source code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/ --- (Updated April 3, 2016, 8:58 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Update reviewer's list. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description (updated) --- This is part of MESOS-4033: Add a commit hook for checking non-ascii characters. This commit fix the non-printable characters in the following files: src/slave/flags.cpp src/uri/fetchers/curl.cpp src/uri/fetchers/docker.cpp Note: The commit hook requires separate commits for libprocess and mesos. That is why this is a separate review request. Diffs - src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 Diff: https://reviews.apache.org/r/45660/diff/ Testing --- make check Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
> On April 3, 2016, 7:51 p.m., Kevin Klues wrote: > > support/mesos-style.py, line 108 > > <https://reviews.apache.org/r/45033/diff/6/?file=1323542#file1323542line108> > > > > I might have slipped it in a little late, but I also had a comment > > about the actual matching going on here. > > > > This match doesn't exclude non-printable characters from the lower 127 > > ascii codes, nor does it exclude unicode characters (which I think we want > > to exclude). > > > > I updated the patch I referenced before to include this. > > Yong Tang wrote: > Thanks Kevin. Let me take a look and get this issue addressed. Thanks Kevin. I updated the review request with the latest changes. As part of MESOS-4033, I scan through the current source code and there are several .cpp and .hpp files that consists of non-printable characters. They are: 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp src/slave/flags.cpp src/uri/fetchers/curl.cpp src/uri/fetchers/docker.cpp I have to created two additional commits to change those non printable chars into printable chars, as the current commit hook will not allow me to check in code that across both libprocess and mesos. Those two commits are located: https://reviews.apache.org/r/45659/ https://reviews.apache.org/r/45660/ Please take a look and let me know if there are any issues. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126749 ------- On April 3, 2016, 8:36 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated April 3, 2016, 8:36 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add addition check in mesos-style.pl > for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h > files and report error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > Note: .md scan is skipped based on feedback from review request. > > Note: This commit includes patches from Kevin Klues and haosdent. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Review Request 45660: Fix non-printable chars in mesos source code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45660/ --- Review request for mesos, haosdent huang and Kevin Klues. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description --- Note: This is part of MESOS-4033: Add a commit hook for checking non-ascii characters Note: The commit hook requires separate commits for libprocess and mesos. Diffs - src/slave/flags.cpp 0551ec334c6747507bf7bb068d27d67f3fdd6c83 src/uri/fetchers/curl.cpp cb50103775fb69e0696e0c389f2119f397a1c499 src/uri/fetchers/docker.cpp fbfc96c3f86cd2d2d585516f37be12834c2bb3a4 Diff: https://reviews.apache.org/r/45660/diff/ Testing --- make check Thanks, Yong Tang
Review Request 45659: Fix non-printable chars in libprocess (format.hpp).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45659/ --- Review request for mesos, haosdent huang and Kevin Klues. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description --- Note: This is part of MESOS-4033: Add a commit hook for checking non-ascii characters Note: The commit hook requires separate commits for libprocess and mesos. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/windows/format.hpp a1bfc808eb1b1c372acb028019901f0ab3f15238 Diff: https://reviews.apache.org/r/45659/diff/ Testing --- make check Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
> On April 3, 2016, 7:51 p.m., Kevin Klues wrote: > > Yes string.printable is a better way of handling this issue. Let me update the review request shortly. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126749 --- On April 3, 2016, 7:46 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated April 3, 2016, 7:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add addition check in mesos-style.pl > for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h > files and report error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > Note: .md scan is skipped based on feedback from review request. > > Note: This commit includes patches from Kevin Klues and haosdent. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
> On April 3, 2016, 7:51 p.m., Kevin Klues wrote: > > support/mesos-style.py, line 108 > > <https://reviews.apache.org/r/45033/diff/6/?file=1323542#file1323542line108> > > > > I might have slipped it in a little late, but I also had a comment > > about the actual matching going on here. > > > > This match doesn't exclude non-printable characters from the lower 127 > > ascii codes, nor does it exclude unicode characters (which I think we want > > to exclude). > > > > I updated the patch I referenced before to include this. Thanks Kevin. Let me take a look and get this issue addressed. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126749 --- On April 3, 2016, 7:46 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated April 3, 2016, 7:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add addition check in mesos-style.pl > for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h > files and report error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > Note: .md scan is skipped based on feedback from review request. > > Note: This commit includes patches from Kevin Klues and haosdent. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
> On April 3, 2016, 4:21 p.m., Kevin Klues wrote: > > Thanks Yong for all your work on this! > > > > Just a few comments about style and one comment regarding the use of > > `re.match()` instead of `re.search()`. > > > > Please see my patch on github which applies all of the comments I've left: > > https://github.com/klueska-mesosphere/mesos/commits/r/yongtang/non-ascii > > > > Thanks! > > haosdent huang wrote: > Seems our reviews went into thread competition in real life. Sorry to > forgot check this before I public my comments. Thanks a lot for all the detailed reviews, Kevin and haosdent. And I really appreciate that. The review request has been updated. Please let me know if there are any additional issues. Again, thanks a lot for all the efforts! - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126733 --- On April 3, 2016, 7:46 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated April 3, 2016, 7:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add addition check in mesos-style.pl > for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h > files and report error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > Note: .md scan is skipped based on feedback from review request. > > Note: This commit includes patches from Kevin Klues and haosdent. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 3, 2016, 7:46 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Update review request with patches from Kevin Klues and feedback from haosdent. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description (updated) --- This review request tries to add addition check in mesos-style.pl for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h files and report error if non-ascii characters exists. As part of this review request, two non-ascii characters are identified in versioning.md (one in Ln 85 and another in Ln 96) and are corrected accordingly. Note: .md scan is skipped based on feedback from review request. Note: This commit includes patches from Kevin Klues and haosdent. Diffs (updated) - docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review126671 --- Thanks for all the input from every one. I updated the review request and merged the ascii check with mesos-style.py. I also skipped the .md check for now as there is another ticket MESOS-5077 for that. Let me know if there are other issues. - Yong Tang On April 2, 2016, 1:41 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated April 2, 2016, 1:41 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd > Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi > Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add addition check in mesos-style.pl > for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h > files and report error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > Note: .md scan is skipped based on feedback from review request. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated April 2, 2016, 1:41 a.m.) Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Bernd Mathiske, haosdent huang, Kevin Klues, Neil Conway, Vinod Kone, and Deshi Xiao. Changes --- Merge ascii check into mesos-style.py, leave .md check to MESOS-5077 according to feedbacks. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description (updated) --- This review request tries to add addition check in mesos-style.pl for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h files and report error if non-ascii characters exists. As part of this review request, two non-ascii characters are identified in versioning.md (one in Ln 85 and another in Ln 96) and are corrected accordingly. Note: .md scan is skipped based on feedback from review request. Diffs (updated) - docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b support/mesos-style.py 13616065ebe07ca401b385716d9b723f65bb2162 Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang
Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).
> On March 28, 2016, 10:23 p.m., Adam B wrote: > > Let's change the UNREACHABLE to an error+unauthorized. Thanks for the review Adam. I updated the review request. Let me know if the change meets the requirements or not. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review125768 --- On March 29, 2016, 2:04 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45342/ > --- > > (Updated March 29, 2016, 2:04 a.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone. > > > Bugs: MESOS-5031 > https://issues.apache.org/jira/browse/MESOS-5031 > > > Repository: mesos > > > Description > --- > > This fix tries to make the Action enum in Authorization optional > to support upgrades. See MESOS-4997 for details. > > > Diffs > - > > include/mesos/authorizer/authorizer.proto > 944a493e0979c7ffbd99f3a67785a10425fd9040 > src/authorizer/local/authorizer.cpp > 0f0d9276337858984f0b19a82ffca74ee84dc650 > > Diff: https://reviews.apache.org/r/45342/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/ --- (Updated March 29, 2016, 2:04 a.m.) Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone. Changes --- Update the review request and change UNREACHABLE to an error+unauthorized. Bugs: MESOS-5031 https://issues.apache.org/jira/browse/MESOS-5031 Repository: mesos Description --- This fix tries to make the Action enum in Authorization optional to support upgrades. See MESOS-4997 for details. Diffs (updated) - include/mesos/authorizer/authorizer.proto 944a493e0979c7ffbd99f3a67785a10425fd9040 src/authorizer/local/authorizer.cpp 0f0d9276337858984f0b19a82ffca74ee84dc650 Diff: https://reviews.apache.org/r/45342/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 45357: Add HTTP response related macros (AWAIT_ASSERT_RESPONSE_...).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45357/ --- Review request for mesos and Michael Park. Bugs: MESOS-4112 https://issues.apache.org/jira/browse/MESOS-4112 Repository: mesos Description --- This RR is the item (3) for MESOS-4112. It adds HTTP respose related macros that were not defined before: 1. AWAIT_ASSERT_RESPONSE_STATUS_EQ_FOR 2. AWAIT_ASSERT_RESPONSE_STATUS_EQ 3. AWAIT_ASSERT_RESPONSE_BODY_EQ_FOR 4. AWAIT_ASSERT_RESPONSE_BODY_EQ 5. AWAIT_ASSERT_RESPONSE_HEADER_EQ_FOR 6. AWAIT_ASSERT_RESPONSE_HEADER_EQ (The above are the counterpart of AWAIT_EXPECT_RESPONSE_...) Diffs - 3rdparty/libprocess/include/process/gtest.hpp 30d51d3704bd0ad82c6d21f1222d6158aaa61298 Diff: https://reviews.apache.org/r/45357/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 45356: Replace `AWAIT_ASSERT_EQ(true/false` with `AWAIT_ASSERT_TRUE/_FALSE`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45356/ --- Review request for mesos and Michael Park. Bugs: MESOS-4112 https://issues.apache.org/jira/browse/MESOS-4112 Repository: mesos Description --- This RR is a follow up to MESOS-4112 to replace `AWAIT_ASSERT_EQ(true/false` with the newly defined `AWAIT_ASSERT_TRUE/_FALSE`. Diffs - src/tests/cram_md5_authentication_tests.cpp 67f74e208ce138dc1e4667af108af3538b34aee9 src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50 src/tests/group_tests.cpp ed10f1fe8a5cd2a353175e13ec3c464da69956f4 src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc Diff: https://reviews.apache.org/r/45356/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.
> On March 25, 2016, 9:23 p.m., Vinod Kone wrote: > > Ship It! > > Vinod Kone wrote: > Can you rebase? Just rebased the review request. Thanks a lot! - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125476 --- On March 25, 2016, 9:25 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45304/ > --- > > (Updated March 25, 2016, 9:25 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5015 > https://issues.apache.org/jira/browse/MESOS-5015 > > > Repository: mesos > > > Description > --- > > This fix changes Call and Event Type enums in executor.proto > optional for the purpose of backwards compatibility. (MESOS-5015) > > > Diffs > - > > CHANGELOG cd551d896e8ba3ec9df17cc477f0abdd87917ab3 > include/mesos/executor/executor.proto > 6b4141f0aac27be5a4998f16e986fa87a7047834 > include/mesos/v1/executor/executor.proto > d7b1dd5eec9bcd424c7859d89471148bce8fe16e > src/examples/test_http_executor.cpp > 562b0acfd8555b9b773175f53defe0e7e2744641 > src/slave/validation.cpp bc8d6717eac103c41f8cc8720e8482589210ea72 > src/tests/mesos.hpp 23694885a69ddcbc7039de1186093ce0ad5eed22 > > Diff: https://reviews.apache.org/r/45304/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- (Updated March 25, 2016, 9:25 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Changes --- Rebase the review request. Bugs: MESOS-5015 https://issues.apache.org/jira/browse/MESOS-5015 Repository: mesos Description --- This fix changes Call and Event Type enums in executor.proto optional for the purpose of backwards compatibility. (MESOS-5015) Diffs (updated) - CHANGELOG cd551d896e8ba3ec9df17cc477f0abdd87917ab3 include/mesos/executor/executor.proto 6b4141f0aac27be5a4998f16e986fa87a7047834 include/mesos/v1/executor/executor.proto d7b1dd5eec9bcd424c7859d89471148bce8fe16e src/examples/test_http_executor.cpp 562b0acfd8555b9b773175f53defe0e7e2744641 src/slave/validation.cpp bc8d6717eac103c41f8cc8720e8482589210ea72 src/tests/mesos.hpp 23694885a69ddcbc7039de1186093ce0ad5eed22 Diff: https://reviews.apache.org/r/45304/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.
> On March 25, 2016, 8:22 p.m., Vinod Kone wrote: > > LGTM modulo Anand's comments. Please also update the CHANGELOG. Hi Vinod, the CHANGELOG has been updated. Let me know if there are other issues and thanks a lot for the review. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125465 --- On March 25, 2016, 9:19 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45304/ > --- > > (Updated March 25, 2016, 9:19 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5015 > https://issues.apache.org/jira/browse/MESOS-5015 > > > Repository: mesos > > > Description > --- > > This fix changes Call and Event Type enums in executor.proto > optional for the purpose of backwards compatibility. (MESOS-5015) > > > Diffs > - > > CHANGELOG fef0cbfc3ae282707569429d38e52c19d4eb9aba > include/mesos/executor/executor.proto > 6b4141f0aac27be5a4998f16e986fa87a7047834 > include/mesos/v1/executor/executor.proto > d7b1dd5eec9bcd424c7859d89471148bce8fe16e > src/examples/test_http_executor.cpp > 562b0acfd8555b9b773175f53defe0e7e2744641 > src/slave/validation.cpp bc8d6717eac103c41f8cc8720e8482589210ea72 > src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 > > Diff: https://reviews.apache.org/r/45304/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.
> On March 25, 2016, 8:18 p.m., Anand Mazumdar wrote: > > Can you also make a similar change as https://reviews.apache.org/r/45317/ > > to `src/slave/validation.cpp` if `Call::Type` is not present. Hi Anand, the review request has been updated. Let me know if there are other issues. Again, thanks a lot for the review. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125463 --- On March 25, 2016, 9:19 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45304/ > --- > > (Updated March 25, 2016, 9:19 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5015 > https://issues.apache.org/jira/browse/MESOS-5015 > > > Repository: mesos > > > Description > --- > > This fix changes Call and Event Type enums in executor.proto > optional for the purpose of backwards compatibility. (MESOS-5015) > > > Diffs > - > > CHANGELOG fef0cbfc3ae282707569429d38e52c19d4eb9aba > include/mesos/executor/executor.proto > 6b4141f0aac27be5a4998f16e986fa87a7047834 > include/mesos/v1/executor/executor.proto > d7b1dd5eec9bcd424c7859d89471148bce8fe16e > src/examples/test_http_executor.cpp > 562b0acfd8555b9b773175f53defe0e7e2744641 > src/slave/validation.cpp bc8d6717eac103c41f8cc8720e8482589210ea72 > src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 > > Diff: https://reviews.apache.org/r/45304/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- (Updated March 25, 2016, 9:19 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Changes --- Updated src/slave/validation.cpp and CHANGELOG based on the feedback from Anand and Vinod. Bugs: MESOS-5015 https://issues.apache.org/jira/browse/MESOS-5015 Repository: mesos Description --- This fix changes Call and Event Type enums in executor.proto optional for the purpose of backwards compatibility. (MESOS-5015) Diffs (updated) - CHANGELOG fef0cbfc3ae282707569429d38e52c19d4eb9aba include/mesos/executor/executor.proto 6b4141f0aac27be5a4998f16e986fa87a7047834 include/mesos/v1/executor/executor.proto d7b1dd5eec9bcd424c7859d89471148bce8fe16e src/examples/test_http_executor.cpp 562b0acfd8555b9b773175f53defe0e7e2744641 src/slave/validation.cpp bc8d6717eac103c41f8cc8720e8482589210ea72 src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 Diff: https://reviews.apache.org/r/45304/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.
> On March 25, 2016, 8:20 p.m., Vinod Kone wrote: > > LGTM. > > > > Can you update the CHANGELOG and call out this change in "Additonal API > > Changes" section for 0.29.0? Thanks Vinod. Just updated the CHANGELOG. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/#review125464 --- On March 25, 2016, 8:55 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45317/ > --- > > (Updated March 25, 2016, 8:55 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5014 > https://issues.apache.org/jira/browse/MESOS-5014 > > > Repository: mesos > > > Description > --- > > This fix changes Call and Event Type enums in scheduler.proto > optional for the purpose of backwards compatibility. (MESOS-5014) > > > Diffs > - > > CHANGELOG fef0cbfc3ae282707569429d38e52c19d4eb9aba > include/mesos/scheduler/scheduler.proto > 0049e1383f50574c3dad6a29b91811001694e82c > include/mesos/v1/scheduler/scheduler.proto > 09fafedd06837f2307fedc6fa0e7b4460b21e5b0 > src/master/validation.cpp 701a5c4b279f319dde15bd8f2e97b5fd8608e578 > src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 > > Diff: https://reviews.apache.org/r/45317/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/ --- (Updated March 25, 2016, 8:55 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Changes --- Updated the CHANGELOG to reference this change for 0.29.0. Bugs: MESOS-5014 https://issues.apache.org/jira/browse/MESOS-5014 Repository: mesos Description --- This fix changes Call and Event Type enums in scheduler.proto optional for the purpose of backwards compatibility. (MESOS-5014) Diffs (updated) - CHANGELOG fef0cbfc3ae282707569429d38e52c19d4eb9aba include/mesos/scheduler/scheduler.proto 0049e1383f50574c3dad6a29b91811001694e82c include/mesos/v1/scheduler/scheduler.proto 09fafedd06837f2307fedc6fa0e7b4460b21e5b0 src/master/validation.cpp 701a5c4b279f319dde15bd8f2e97b5fd8608e578 src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 Diff: https://reviews.apache.org/r/45317/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 45304: Change Call and Event Type enums in executor.proto optional.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- (Updated March 25, 2016, 6:58 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Changes --- Updated the review request based on feedback from MESOS-5014 (related). Add Anand to reviewers list. Bugs: MESOS-5015 https://issues.apache.org/jira/browse/MESOS-5015 Repository: mesos Description --- This fix changes Call and Event Type enums in executor.proto optional for the purpose of backwards compatibility. (MESOS-5015) Diffs (updated) - include/mesos/executor/executor.proto 6b4141f0aac27be5a4998f16e986fa87a7047834 include/mesos/v1/executor/executor.proto d7b1dd5eec9bcd424c7859d89471148bce8fe16e src/examples/test_http_executor.cpp 562b0acfd8555b9b773175f53defe0e7e2744641 src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 Diff: https://reviews.apache.org/r/45304/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/ --- (Updated March 25, 2016, 5:56 p.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Changes --- Add Anand to the reviewers list. Bugs: MESOS-5014 https://issues.apache.org/jira/browse/MESOS-5014 Repository: mesos Description --- This fix changes Call and Event Type enums in scheduler.proto optional for the purpose of backwards compatibility. (MESOS-5014) Diffs (updated) - include/mesos/scheduler/scheduler.proto 0049e1383f50574c3dad6a29b91811001694e82c include/mesos/v1/scheduler/scheduler.proto 09fafedd06837f2307fedc6fa0e7b4460b21e5b0 src/master/validation.cpp 701a5c4b279f319dde15bd8f2e97b5fd8608e578 src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 Diff: https://reviews.apache.org/r/45317/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.
> On March 25, 2016, 1:53 a.m., Anand Mazumdar wrote: > > LGTM, just some minor code comments. Thanks a lot for the review Anand. I just updated the review request with the fixes. Let me know if there are other issues. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45327/#review125378 --- On March 25, 2016, 2:28 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45327/ > --- > > (Updated March 25, 2016, 2:28 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5020 > https://issues.apache.org/jira/browse/MESOS-5020 > > > Repository: mesos > > > Description > --- > > This fix drops `404 Not Found` and `307 Temporary Redirect` in > the scheduler library, instead of treating them as Event::ERROR. > (MESOS-5020) > > > Diffs > - > > src/scheduler/scheduler.cpp 1f52a423c8c83c58d38ba6731ab2625136a271bb > > Diff: https://reviews.apache.org/r/45327/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 45327: Drop HTTP Status `404` and `307` in the scheduler library.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45327/ --- (Updated March 25, 2016, 2:28 a.m.) Review request for mesos, Anand Mazumdar and Vinod Kone. Changes --- Address comment issues based on the feedback from Anand. Bugs: MESOS-5020 https://issues.apache.org/jira/browse/MESOS-5020 Repository: mesos Description --- This fix drops `404 Not Found` and `307 Temporary Redirect` in the scheduler library, instead of treating them as Event::ERROR. (MESOS-5020) Diffs (updated) - src/scheduler/scheduler.cpp 1f52a423c8c83c58d38ba6731ab2625136a271bb Diff: https://reviews.apache.org/r/45327/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 45317: Change Call and Event Type enums in scheduler.proto optional.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45317/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5014 https://issues.apache.org/jira/browse/MESOS-5014 Repository: mesos Description --- This fix changes Call and Event Type enums in scheduler.proto optional for the purpose of backwards compatibility. (MESOS-5014) Diffs - include/mesos/scheduler/scheduler.proto 0049e1383f50574c3dad6a29b91811001694e82c include/mesos/v1/scheduler/scheduler.proto 09fafedd06837f2307fedc6fa0e7b4460b21e5b0 src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 Diff: https://reviews.apache.org/r/45317/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 45304: Change Call and Event Type enums in executor.proto optional.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5015 https://issues.apache.org/jira/browse/MESOS-5015 Repository: mesos Description --- This fix changes Call and Event Type enums in executor.proto optional for the purpose of backwards compatibility. (MESOS-5015) Diffs - include/mesos/executor/executor.proto ae211194a44e0bf2fadc79e833881e45ea3eb2c2 include/mesos/v1/executor/executor.proto 36a2b3f9bc3aaa524f655b9e686a6d33512e6aaa src/examples/test_http_executor.cpp 562b0acfd8555b9b773175f53defe0e7e2744641 src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 Diff: https://reviews.apache.org/r/45304/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review125032 --- Skipped the .md scan based on feedback from haosdent and Deshi. - Yong Tang On March 23, 2016, 2:46 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated March 23, 2016, 2:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, haosdent > huang, Neil Conway, and Deshi Xiao. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add a commit hook for checking non-ascii > characters. It scans .cpp, .hpp, .cc, .h files and report > error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > Note: .md scan is skipped based on feedback from review request. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 > support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 > support/non-ascii.py PRE-CREATION > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated March 23, 2016, 2:46 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, haosdent huang, Neil Conway, and Deshi Xiao. Changes --- Skipped .md scan based on feedback from haosdent and Deshi. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description (updated) --- This review request tries to add a commit hook for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h files and report error if non-ascii characters exists. As part of this review request, two non-ascii characters are identified in versioning.md (one in Ln 85 and another in Ln 96) and are corrected accordingly. Note: .md scan is skipped based on feedback from review request. Diffs (updated) - docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 support/non-ascii.py PRE-CREATION Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang
Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).
> On March 17, 2016, 4:09 p.m., Michael Park wrote: > > The patch looks good to me. Would you like to send an announcement email to > > the dev list about this upgrade? I can do it if you'd rather not. > > Yong Tang wrote: > Hi Michael, Thanks a lot for the help! I will send out the email to the > dev list shortly. Hi Michael, just sent out the email. Let me know if there is any additional issues. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review124038 --- On March 16, 2016, 1:37 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44758/ > --- > > (Updated March 16, 2016, 1:37 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4906 > https://issues.apache.org/jira/browse/MESOS-4906 > > > Repository: mesos > > > Description > --- > > Upgrade to clang-format-3.8 (MESOS-4906). > > > Diffs > - > > docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 > support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e > > Diff: https://reviews.apache.org/r/44758/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yong Tang > >
Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).
> On March 16, 2016, 7:57 p.m., Anand Mazumdar wrote: > > LGTM. Thanks for putting out a patch for this. > > > > Can you also add Jie as a reviewer and as a shepherd to the JIRA? Thanks a lot Anand! Just updated the review request and also added Jie as the reviewer. Let me know if there is anything else I need to do. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/#review123830 --- On March 17, 2016, 1:52 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44883/ > --- > > (Updated March 17, 2016, 1:52 a.m.) > > > Review request for mesos, Anand Mazumdar and Jie Yu. > > > Bugs: MESOS-4954 > https://issues.apache.org/jira/browse/MESOS-4954 > > > Repository: mesos > > > Description > --- > > This fix changes the URL fetcher error message from LOG(ERROR) > to LOG(INFO) as the plugin is actually skipped if it is not > created. > > > Diffs > - > > src/uri/fetcher.cpp 8645b66f6c64c76b6c02ef0b9827a7d694d5ba97 > > Diff: https://reviews.apache.org/r/44883/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Review Request 44911: Fix the issue related to --disable-optimize (MESOS-4621).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44911/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-4621 https://issues.apache.org/jira/browse/MESOS-4621 Repository: mesos Description --- This fix tries to address MESOS-4621 where --disable-optimize is not properly handled by configure.ac. Diffs - configure.ac 8e4f03593df4a8ba13f00292963e351acc3f71c1 Diff: https://reviews.apache.org/r/44911/diff/ Testing --- make check Also tested with configure --disable-optimize manually. Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
> On March 18, 2016, 7:03 p.m., haosdent huang wrote: > > support/non-ascii.py, line 21 > > <https://reviews.apache.org/r/45033/diff/1/?file=1305279#file1305279line21> > > > > Seems we have to update this when we update third part dependencies > > every time? For example, if we update protobuf to 2.6, this rule need > > update as well. Is it possible to avoid this? Hi haosdent, I take a look at this issue. The exclude_file pattern was from mesos-style.py. Not knowing enough about the source tree history of mesos though it turns out that 3rd party files are actually placed inside the build directory and is filtered out anyway. So those version specific patterns are not needed any more. I just removed those unneeded patterns. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124253 ------- On March 19, 2016, 6:26 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated March 19, 2016, 6:26 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and haosdent > huang. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add a commit hook for checking non-ascii > characters. It scans .cpp, .hpp, .cc, .h, and .md files and report > error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 > support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 > support/non-ascii.py PRE-CREATION > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated March 19, 2016, 6:26 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and haosdent huang. Changes --- Remove unneeded version filtering as is suggested by haosdent. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description --- This review request tries to add a commit hook for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h, and .md files and report error if non-ascii characters exists. As part of this review request, two non-ascii characters are identified in versioning.md (one in Ln 85 and another in Ln 96) and are corrected accordingly. Diffs (updated) - docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 support/non-ascii.py PRE-CREATION Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- (Updated March 19, 2016, 6:08 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and haosdent huang. Changes --- Address issues suggested by haosdent. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description --- This review request tries to add a commit hook for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h, and .md files and report error if non-ascii characters exists. As part of this review request, two non-ascii characters are identified in versioning.md (one in Ln 85 and another in Ln 96) and are corrected accordingly. Diffs (updated) - docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 support/non-ascii.py PRE-CREATION Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
> On March 18, 2016, 7:08 p.m., haosdent huang wrote:
> > support/non-ascii.py, line 47
> > <https://reviews.apache.org/r/45033/diff/1/?file=1305279#file1305279line47>
> >
> > Is it possible to print the match test as well? Sometimes find the
> > invalid char in a long line is not easy.
I added a position ("Pos") in addition to the line number. Printing out the
exact character is fairly complicated. We can certainly print out the hex value
like 0x0A, 0x80, etc. but that will not be too helpful. On the other hand,
since some of the characters are just invalide characters (not necessarily
unicode strings) so it may not be printable anyway. I think combining line
number with the position should be OK to figure out the place to make
adjustment.
- Yong
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45033/#review124256
---
On March 18, 2016, 11:11 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45033/
> ---
>
> (Updated March 18, 2016, 11:11 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and haosdent
> huang.
>
>
> Bugs: MESOS-4033
> https://issues.apache.org/jira/browse/MESOS-4033
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This review request tries to add a commit hook for checking non-ascii
> characters. It scans .cpp, .hpp, .cc, .h, and .md files and report
> error if non-ascii characters exists.
>
> As part of this review request, two non-ascii characters are identified
> in versioning.md (one in Ln 85 and another in Ln 96) and are corrected
> accordingly.
>
>
> Diffs
> -
>
> docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b
> support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453
> support/non-ascii.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45033/diff/
>
>
> Testing
> ---
>
> Tested manually and found two non ascii characters in docs/versioning.md
> (fixed as part of this review request).
>
>
> Thanks,
>
> Yong Tang
>
>
Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).
> On March 17, 2016, 4:09 p.m., Michael Park wrote: > > The patch looks good to me. Would you like to send an announcement email to > > the dev list about this upgrade? I can do it if you'd rather not. Hi Michael, Thanks a lot for the help! I will send out the email to the dev list shortly. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review124038 --- On March 16, 2016, 1:37 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44758/ > --- > > (Updated March 16, 2016, 1:37 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4906 > https://issues.apache.org/jira/browse/MESOS-4906 > > > Repository: mesos > > > Description > --- > > Upgrade to clang-format-3.8 (MESOS-4906). > > > Diffs > - > > docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 > support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e > > Diff: https://reviews.apache.org/r/44758/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yong Tang > >
Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ --- Review request for mesos, Alexander Rukletsov and Bernd Mathiske. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description --- This review request tries to add a commit hook for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h, and .md files and report error if non-ascii characters exists. As part of this review request, two non-ascii characters are identified in versioning.md (one in Ln 85 and another in Ln 96) and are corrected accordingly. Diffs - docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 support/non-ascii.py PRE-CREATION Diff: https://reviews.apache.org/r/45033/diff/ Testing --- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
> On March 18, 2016, 7:03 p.m., haosdent huang wrote: > > docs/versioning.md, line 85 > > <https://reviews.apache.org/r/45033/diff/1/?file=1305277#file1305277line85> > > > > Any reason we need change here? Hi haosdent, the left is one unicode (U+2026) of "Horizontal Ellipsis" (three dots). Inside the md file you will see it is 0xE2,0x80,0xA6 (UTF-8) if you use binary mode in vi. The right are three ascii characters of dot (0xA0). - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124253 --- On March 18, 2016, 2:48 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated March 18, 2016, 2:48 p.m.) > > > Review request for mesos, Alexander Rukletsov and Bernd Mathiske. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add a commit hook for checking non-ascii > characters. It scans .cpp, .hpp, .cc, .h, and .md files and report > error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 > support/non-ascii.py PRE-CREATION > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).
> On March 17, 2016, 8:34 p.m., Michael Park wrote: > > support/clang-format, line 3 > > <https://reviews.apache.org/r/44758/diff/3/?file=1300622#file1300622line3> > > > > Can we uncomment this? Our style by definition is > > > > > The Mesos codebase follows the Google C++ Style Guide with some > > notable differences, as described below. > > > > So basing off of Google and overriding the parts that don't match > > accurately defines our style guide. Thanks Michael. Just updated the review request. Let me know if there are other issues. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review124090 --- On March 17, 2016, 9:08 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44758/ > --- > > (Updated March 17, 2016, 9:08 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4906 > https://issues.apache.org/jira/browse/MESOS-4906 > > > Repository: mesos > > > Description > --- > > Upgrade to clang-format-3.8 (MESOS-4906). > > > Diffs > - > > docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 > support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e > > Diff: https://reviews.apache.org/r/44758/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yong Tang > >
Re: Review Request 44912: Used the same fixture for all related tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44912/#review123882 --- Ship it! Ship It! - Yong Tang On March 16, 2016, 3:47 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44912/ > --- > > (Updated March 16, 2016, 3:47 p.m.) > > > Review request for mesos, Joris Van Remoortere and Yong Tang. > > > Bugs: MESOS-4807 > https://issues.apache.org/jira/browse/MESOS-4807 > > > Repository: mesos > > > Description > --- > > The initial idea was to only use a fixture creating temporary working > directories when really needed. It was felt that this hinders > discoverability of related test. > > > Diffs > - > > 3rdparty/libprocess/src/tests/io_tests.cpp > 87fd3fafc29c01362bae0b77a2a332ec89a8b442 > > Diff: https://reviews.apache.org/r/44912/diff/ > > > Testing > --- > > make check (OS X, clang-trunk, not optimized) > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).
00e99777ba0294c9c12ac86594987afbd9388b51 src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd src/tests/scheduler_tests.cpp 917058f4dcf32ddaaeda8a3ff21898571f4829dd src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 src/tests/status_update_manager_tests.cpp 801767ba6b4a08a4f653a7735bf3a581a0f8f95f src/tests/teardown_tests.cpp a5f40f991e99ec0d452074a9d3c209b05b317f51 src/uri/fetcher.cpp 8645b66f6c64c76b6c02ef0b9827a7d694d5ba97 src/webui/master/static/offers.html 01213e9582f50072a9c729782271269f72972d28 Diff: https://reviews.apache.org/r/44883/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45011/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4070 https://issues.apache.org/jira/browse/MESOS-4070 Repository: mesos Description --- This fix updated the implementation of numify() so that negative numbers could be handled conssitently for hex and non-hex numbers. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 26a637bec1193dd51437bd689c34fbe6d1935d89 3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp 444377df00922df12d4b3ed25b4cfe9071cff5c3 Diff: https://reviews.apache.org/r/45011/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/ --- (Updated March 17, 2016, 1:52 a.m.) Review request for mesos, Anand Mazumdar and Jie Yu. Changes --- Fix review request update issue in the last update. Bugs: MESOS-4954 https://issues.apache.org/jira/browse/MESOS-4954 Repository: mesos Description --- This fix changes the URL fetcher error message from LOG(ERROR) to LOG(INFO) as the plugin is actually skipped if it is not created. Diffs (updated) - src/uri/fetcher.cpp 8645b66f6c64c76b6c02ef0b9827a7d694d5ba97 Diff: https://reviews.apache.org/r/44883/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).
> On March 15, 2016, 9:24 p.m., Michael Park wrote: > > support/clang-format, lines 101-107 > > <https://reviews.apache.org/r/44758/diff/2/?file=1296971#file1296971line101> > > > > We can help out a little more here: > > > > The following code orders the headers: > > (1) C standard library headers > > (2) C++ standard library headers > > (3) Our public headers > > (4) Our private headers > > > > ``` > > IncludeCategories: > > - Regex: '^<.*.h>' > > Priority:1 > > - Regex: '^<.*.hpp>' > > Priority:3 > > - Regex: '^<.*>' > > Priority:2 > > - Regex: '.*' > > Priority:4 > > ``` > > > > __NOTE__: 3 seems to need to appear before 2, probably because it's > > more specific. > > Yong Tang wrote: > Thanks for the help, Michael. Just updated the review request. Let me > know if there are any other issues. Hi Michael, any additional suggestions or update on this clang-format-3.8 issue (MESOS-4906)? Feedbacks are appreciated. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123734 --- On March 16, 2016, 1:37 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44758/ > --- > > (Updated March 16, 2016, 1:37 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4906 > https://issues.apache.org/jira/browse/MESOS-4906 > > > Repository: mesos > > > Description > --- > > Upgrade to clang-format-3.8 (MESOS-4906). > > > Diffs > - > > docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 > support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e > > Diff: https://reviews.apache.org/r/44758/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yong Tang > >
Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/ --- (Updated March 17, 2016, 9:08 p.m.) Review request for mesos and Michael Park. Changes --- Uncomment "BasedOnStyle: Google" based on the feedback from Michael. Bugs: MESOS-4906 https://issues.apache.org/jira/browse/MESOS-4906 Repository: mesos Description --- Upgrade to clang-format-3.8 (MESOS-4906). Diffs (updated) - docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e Diff: https://reviews.apache.org/r/44758/diff/ Testing --- make check Thanks, Yong Tang
Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).
> On March 18, 2016, 7:03 p.m., haosdent huang wrote: > > docs/versioning.md, line 85 > > <https://reviews.apache.org/r/45033/diff/1/?file=1305277#file1305277line85> > > > > Any reason we need change here? > > Yong Tang wrote: > Hi haosdent, the left is one unicode (U+2026) of "Horizontal Ellipsis" > (three dots). Inside the md file you will see it is 0xE2,0x80,0xA6 (UTF-8) if > you use binary mode in vi. The right are three ascii characters of dot > (0xA0). By the way, thanks for the review and the help. I will address the rest of the issues later. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124253 ------- On March 18, 2016, 2:48 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45033/ > --- > > (Updated March 18, 2016, 2:48 p.m.) > > > Review request for mesos, Alexander Rukletsov and Bernd Mathiske. > > > Bugs: MESOS-4033 > https://issues.apache.org/jira/browse/MESOS-4033 > > > Repository: mesos > > > Description > --- > > This review request tries to add a commit hook for checking non-ascii > characters. It scans .cpp, .hpp, .cc, .h, and .md files and report > error if non-ascii characters exists. > > As part of this review request, two non-ascii characters are identified > in versioning.md (one in Ln 85 and another in Ln 96) and are corrected > accordingly. > > > Diffs > - > > docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b > support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 > support/non-ascii.py PRE-CREATION > > Diff: https://reviews.apache.org/r/45033/diff/ > > > Testing > --- > > Tested manually and found two non ascii characters in docs/versioning.md > (fixed as part of this review request). > > > Thanks, > > Yong Tang > >
Review Request 45070: Clean up libprocess gtest macros (MESOS-4112).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45070/ --- Review request for mesos and Michael Park. Bugs: MESOS-4112 https://issues.apache.org/jira/browse/MESOS-4112 Repository: mesos Description --- This review request tries to clean up gtest macros in libprocess. The following items have been done: 1. AWAIT_EQ_FOR have be added for completeness. 2. Missing equivalents of EXPECT_TRUE/EXPECT_FALSE have been added: a) AWAIT_ASSERT_TRUE_FOR b) AWAIT_ASSERT_TRUE c) AWAIT_ASSERT_FALSE_FOR d) AWAIT_ASSERT_FALSE e) AWAIT_EXPECT_TRUE_FOR f) AWAIT_EXPECT_FALSE_FOR Diffs - 3rdparty/libprocess/include/process/gtest.hpp 049152c0535c78e6986346610735d301fb6876bc Diff: https://reviews.apache.org/r/45070/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).
> On March 15, 2016, 9:24 p.m., Michael Park wrote: > > support/clang-format, lines 101-107 > > <https://reviews.apache.org/r/44758/diff/2/?file=1296971#file1296971line101> > > > > We can help out a little more here: > > > > The following code orders the headers: > > (1) C standard library headers > > (2) C++ standard library headers > > (3) Our public headers > > (4) Our private headers > > > > ``` > > IncludeCategories: > > - Regex: '^<.*.h>' > > Priority:1 > > - Regex: '^<.*.hpp>' > > Priority:3 > > - Regex: '^<.*>' > > Priority:2 > > - Regex: '.*' > > Priority:4 > > ``` > > > > __NOTE__: 3 seems to need to appear before 2, probably because it's > > more specific. Thanks for the help, Michael. Just updated the review request. Let me know if there are any other issues. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123734 --- On March 16, 2016, 1:37 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44758/ > --- > > (Updated March 16, 2016, 1:37 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4906 > https://issues.apache.org/jira/browse/MESOS-4906 > > > Repository: mesos > > > Description > --- > > Upgrade to clang-format-3.8 (MESOS-4906). > > > Diffs > - > > docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 > support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e > > Diff: https://reviews.apache.org/r/44758/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yong Tang > >
Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/ --- (Updated March 16, 2016, 1:37 a.m.) Review request for mesos and Michael Park. Changes --- Update based on Michael's suggestions. Bugs: MESOS-4906 https://issues.apache.org/jira/browse/MESOS-4906 Repository: mesos Description --- Upgrade to clang-format-3.8 (MESOS-4906). Diffs (updated) - docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e Diff: https://reviews.apache.org/r/44758/diff/ Testing --- make check Thanks, Yong Tang
Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/ --- (Updated March 15, 2016, 3:37 p.m.) Review request for mesos and Benjamin Bannier. Changes --- Update review request for formatting. Bugs: MESOS-4807 https://issues.apache.org/jira/browse/MESOS-4807 Repository: mesos Description --- This commit changes IOTest.BufferedRead so that this specific test (not all IOTest) could be executed from temporary directories via TemporaryDirectoryTest fixture (MESOS-4807). Diffs (updated) - 3rdparty/libprocess/src/tests/io_tests.cpp 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 Diff: https://reviews.apache.org/r/44380/diff/ Testing --- make check Thanks, Yong Tang
Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.
> On March 4, 2016, 7:42 a.m., Benjamin Bannier wrote: > > I think using a `TemporaryDirectoryTest` fixture is the right approach, but > > what I find unfortunate about your approach is that with this patch we'd > > create a temporary directory and incur the overhead for all tests in this > > suite, even ones not creating any files. If that's something we wouldn't > > want, what about using separate suites for tests creating files (that would > > be `BufferedRead` and `Redirect`), and other ones? > > Yong Tang wrote: > Hi Benjamin, thanks for the suggestion. I splits IOTest into two test > suites. Those tests that will not write files to disk remains the same while > the rests (BufferedRead and Redirect) have been moved to > TemporaryDirectoryIOTest via TemporaryDirectoryTest fixture. Let me see if > there are any issues and I will fix it. > > Yong Tang wrote: > Hi Benjamin, are there any additional issues that need to be addressed in > this review request? Feedback is appreciated. > > Benjamin Bannier wrote: > Yong, you still need to find a committer to shepherd this patch for you. Thanks Benjamin. I pinged d...@mesos.apache.org for shepherd though I havent' received the response yet. Will try to ping again shortly. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/#review122030 ------- On March 15, 2016, 1:38 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44380/ > --- > > (Updated March 15, 2016, 1:38 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-4807 > https://issues.apache.org/jira/browse/MESOS-4807 > > > Repository: mesos > > > Description > --- > > This commit changes IOTest.BufferedRead so that this specific > test (not all IOTest) could be executed from temporary > directories via TemporaryDirectoryTest fixture (MESOS-4807). > > > Diffs > - > > 3rdparty/libprocess/src/tests/io_tests.cpp > 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 > > Diff: https://reviews.apache.org/r/44380/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yong Tang > >
Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.
> On March 14, 2016, 8:53 a.m., Benjamin Bannier wrote: > > Looks mostly good to me. I left some comments, but if you want to make any > > progress here you'll still need to find a shepherd (see > > http://mesos.apache.org/documentation/latest/submitting-a-patch/). > > Yong Tang wrote: > Thanks for the help Benjamin. Let me update the review request shortly. Just updated the review reuest. Please let me know if there are any other issues. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/#review123382 --- On March 15, 2016, 1:38 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44380/ > --- > > (Updated March 15, 2016, 1:38 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-4807 > https://issues.apache.org/jira/browse/MESOS-4807 > > > Repository: mesos > > > Description > --- > > This commit changes IOTest.BufferedRead so that this specific > test (not all IOTest) could be executed from temporary > directories via TemporaryDirectoryTest fixture (MESOS-4807). > > > Diffs > - > > 3rdparty/libprocess/src/tests/io_tests.cpp > 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 > > Diff: https://reviews.apache.org/r/44380/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yong Tang > >
Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.
> On March 14, 2016, 8:53 a.m., Benjamin Bannier wrote: > > Looks mostly good to me. I left some comments, but if you want to make any > > progress here you'll still need to find a shepherd (see > > http://mesos.apache.org/documentation/latest/submitting-a-patch/). Thanks for the help Benjamin. Let me update the review request shortly. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/#review123382 --- On March 4, 2016, 6:56 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44380/ > --- > > (Updated March 4, 2016, 6:56 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-4807 > https://issues.apache.org/jira/browse/MESOS-4807 > > > Repository: mesos > > > Description > --- > > This commit changes IOTest.BufferedRead so that this specific > test (not all IOTest) could be executed from temporary > directories via TemporaryDirectoryTest fixture (MESOS-4807). > > > Diffs > - > > 3rdparty/libprocess/src/tests/io_tests.cpp > 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 > > Diff: https://reviews.apache.org/r/44380/diff/ > > > Testing > --- > > make check > > > Thanks, > > Yong Tang > >
