Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-15 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review123738
---


Ship it!




Ship It!

- Joris Van Remoortere


On March 15, 2016, 3:37 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 15, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that this specific
> test (not all IOTest) could be executed from temporary
> directories via TemporaryDirectoryTest fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-15 Thread Yong Tang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/
---

(Updated March 15, 2016, 3:37 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
---

Update review request for formatting.


Bugs: MESOS-4807
https://issues.apache.org/jira/browse/MESOS-4807


Repository: mesos


Description
---

This commit changes IOTest.BufferedRead so that this specific
test (not all IOTest) could be executed from temporary
directories via TemporaryDirectoryTest fixture (MESOS-4807).


Diffs (updated)
-

  3rdparty/libprocess/src/tests/io_tests.cpp 
2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 

Diff: https://reviews.apache.org/r/44380/diff/


Testing
---

make check


Thanks,

Yong Tang



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-15 Thread Yong Tang


> On March 4, 2016, 7:42 a.m., Benjamin Bannier wrote:
> > I think using a `TemporaryDirectoryTest` fixture is the right approach, but 
> > what I find unfortunate about your approach is that with this patch we'd 
> > create a temporary directory and incur the overhead for all tests in this 
> > suite, even ones not creating any files. If that's something we wouldn't 
> > want, what about using separate suites for tests creating files (that would 
> > be `BufferedRead` and `Redirect`), and other ones?
> 
> Yong Tang wrote:
> Hi Benjamin, thanks for the suggestion. I splits IOTest into two test 
> suites. Those tests that will not write files to disk remains the same while 
> the rests (BufferedRead and Redirect) have been moved to 
> TemporaryDirectoryIOTest via TemporaryDirectoryTest fixture. Let me see if 
> there are any issues and I will fix it.
> 
> Yong Tang wrote:
> Hi Benjamin, are there any additional issues that need to be addressed in 
> this review request? Feedback is appreciated.
> 
> Benjamin Bannier wrote:
> Yong, you still need to find a committer to shepherd this patch for you.

Thanks Benjamin. I pinged d...@mesos.apache.org for shepherd though I havent' 
received the response yet. Will try to ping again shortly.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122030
---


On March 15, 2016, 1:38 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 15, 2016, 1:38 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that this specific
> test (not all IOTest) could be executed from temporary
> directories via TemporaryDirectoryTest fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-15 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review123660
---


Fix it, then Ship it!





3rdparty/libprocess/src/tests/io_tests.cpp (line 180)


Please keep two empty lines between top-level entities.



3rdparty/libprocess/src/tests/io_tests.cpp (line 295)


Please keep two empty lines between top-level entities.


- Benjamin Bannier


On March 15, 2016, 2:38 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 15, 2016, 2:38 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that this specific
> test (not all IOTest) could be executed from temporary
> directories via TemporaryDirectoryTest fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-15 Thread Benjamin Bannier


> On March 4, 2016, 8:42 a.m., Benjamin Bannier wrote:
> > I think using a `TemporaryDirectoryTest` fixture is the right approach, but 
> > what I find unfortunate about your approach is that with this patch we'd 
> > create a temporary directory and incur the overhead for all tests in this 
> > suite, even ones not creating any files. If that's something we wouldn't 
> > want, what about using separate suites for tests creating files (that would 
> > be `BufferedRead` and `Redirect`), and other ones?
> 
> Yong Tang wrote:
> Hi Benjamin, thanks for the suggestion. I splits IOTest into two test 
> suites. Those tests that will not write files to disk remains the same while 
> the rests (BufferedRead and Redirect) have been moved to 
> TemporaryDirectoryIOTest via TemporaryDirectoryTest fixture. Let me see if 
> there are any issues and I will fix it.
> 
> Yong Tang wrote:
> Hi Benjamin, are there any additional issues that need to be addressed in 
> this review request? Feedback is appreciated.

Yong, you still need to find a committer to shepherd this patch for you.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122030
---


On March 15, 2016, 2:38 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 15, 2016, 2:38 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that this specific
> test (not all IOTest) could be executed from temporary
> directories via TemporaryDirectoryTest fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-14 Thread Yong Tang


> On March 14, 2016, 8:53 a.m., Benjamin Bannier wrote:
> > Looks mostly good to me. I left some comments, but if you want to make any 
> > progress here you'll still need to find a shepherd (see 
> > http://mesos.apache.org/documentation/latest/submitting-a-patch/).
> 
> Yong Tang wrote:
> Thanks for the help Benjamin. Let me update the review request shortly.

Just updated the review reuest. Please let me know if there are any other 
issues.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review123382
---


On March 15, 2016, 1:38 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 15, 2016, 1:38 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that this specific
> test (not all IOTest) could be executed from temporary
> directories via TemporaryDirectoryTest fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-14 Thread Yong Tang


> On March 14, 2016, 8:53 a.m., Benjamin Bannier wrote:
> > Looks mostly good to me. I left some comments, but if you want to make any 
> > progress here you'll still need to find a shepherd (see 
> > http://mesos.apache.org/documentation/latest/submitting-a-patch/).

Thanks for the help Benjamin. Let me update the review request shortly.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review123382
---


On March 4, 2016, 6:56 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 4, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that this specific
> test (not all IOTest) could be executed from temporary
> directories via TemporaryDirectoryTest fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-14 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review123382
---



Looks mostly good to me. I left some comments, but if you want to make any 
progress here you'll still need to find a shepherd (see 
http://mesos.apache.org/documentation/latest/submitting-a-patch/).


3rdparty/libprocess/src/tests/io_tests.cpp (line 340)


IMO this is the right approach, but would pick a different name, e.g., what 
about `IOWriteTest` or similar?



3rdparty/libprocess/src/tests/io_tests.cpp (line 342)


Please keep this in its original location.



3rdparty/libprocess/src/tests/io_tests.cpp (line 395)


Please keep this in its original location.


- Benjamin Bannier


On March 4, 2016, 7:56 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 4, 2016, 7:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that this specific
> test (not all IOTest) could be executed from temporary
> directories via TemporaryDirectoryTest fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-13 Thread Yong Tang


> On March 4, 2016, 7:42 a.m., Benjamin Bannier wrote:
> > I think using a `TemporaryDirectoryTest` fixture is the right approach, but 
> > what I find unfortunate about your approach is that with this patch we'd 
> > create a temporary directory and incur the overhead for all tests in this 
> > suite, even ones not creating any files. If that's something we wouldn't 
> > want, what about using separate suites for tests creating files (that would 
> > be `BufferedRead` and `Redirect`), and other ones?
> 
> Yong Tang wrote:
> Hi Benjamin, thanks for the suggestion. I splits IOTest into two test 
> suites. Those tests that will not write files to disk remains the same while 
> the rests (BufferedRead and Redirect) have been moved to 
> TemporaryDirectoryIOTest via TemporaryDirectoryTest fixture. Let me see if 
> there are any issues and I will fix it.

Hi Benjamin, are there any additional issues that need to be addressed in this 
review request? Feedback is appreciated.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122030
---


On March 4, 2016, 6:56 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 4, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that this specific
> test (not all IOTest) could be executed from temporary
> directories via TemporaryDirectoryTest fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-04 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122168
---



Patch looks great!

Reviews applied: [44380]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 4, 2016, 6:56 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 4, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that this specific
> test (not all IOTest) could be executed from temporary
> directories via TemporaryDirectoryTest fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-04 Thread Yong Tang


> On March 4, 2016, 7:42 a.m., Benjamin Bannier wrote:
> > I think using a `TemporaryDirectoryTest` fixture is the right approach, but 
> > what I find unfortunate about your approach is that with this patch we'd 
> > create a temporary directory and incur the overhead for all tests in this 
> > suite, even ones not creating any files. If that's something we wouldn't 
> > want, what about using separate suites for tests creating files (that would 
> > be `BufferedRead` and `Redirect`), and other ones?

Hi Benjamin, thanks for the suggestion. I splits IOTest into two test suites. 
Those tests that will not write files to disk remains the same while the rests 
(BufferedRead and Redirect) have been moved to TemporaryDirectoryIOTest via 
TemporaryDirectoryTest fixture. Let me see if there are any issues and I will 
fix it.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122030
---


On March 4, 2016, 6:56 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 4, 2016, 6:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that this specific
> test (not all IOTest) could be executed from temporary
> directories via TemporaryDirectoryTest fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-04 Thread Yong Tang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/
---

(Updated March 4, 2016, 6:56 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
---

Split IOTest into two test suites. One is the IOTest that will not write files 
to disk, it will remains the same. Another is the TemporaryDirectoryIOTest 
fixture that includes BufferedRead and Redirect which will write files (to 
temporary directory) to disk.


Bugs: MESOS-4807
https://issues.apache.org/jira/browse/MESOS-4807


Repository: mesos


Description (updated)
---

This commit changes IOTest.BufferedRead so that this specific
test (not all IOTest) could be executed from temporary
directories via TemporaryDirectoryTest fixture (MESOS-4807).


Diffs (updated)
-

  3rdparty/libprocess/src/tests/io_tests.cpp 
2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 

Diff: https://reviews.apache.org/r/44380/diff/


Testing
---

make check


Thanks,

Yong Tang



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-04 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122073
---



Patch looks great!

Reviews applied: [44380]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 4, 2016, 7:27 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 4, 2016, 7:27 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that tests could be
> executed from temporary directories via TemporaryDirectoryTest
> fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-03 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122030
---



I think using a `TemporaryDirectoryTest` fixture is the right approach, but 
what I find unfortunate about your approach is that with this patch we'd create 
a temporary directory and incur the overhead for all tests in this suite, even 
ones not creating any files. If that's something we wouldn't want, what about 
using separate suites for tests creating files (that would be `BufferedRead` 
and `Redirect`), and other ones?

- Benjamin Bannier


On March 4, 2016, 8:27 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 4, 2016, 8:27 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that tests could be
> executed from temporary directories via TemporaryDirectoryTest
> fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

2016-03-03 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122027
---


Ship it!




Ship It!

- haosdent huang


On March 4, 2016, 7:27 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 4, 2016, 7:27 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that tests could be
> executed from temporary directories via TemporaryDirectoryTest
> fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>