Re: Review Request 37505: Fix broken health check in docker executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review99251
---


By the way your patch fails mesos style check. Did you run the mesos style 
python script?

- Timothy Chen


On Sept. 14, 2015, 12:59 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37505/
> ---
> 
> (Updated Sept. 14, 2015, 12:59 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3136
> https://issues.apache.org/jira/browse/MESOS-3136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix broken health check in docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403 
>   src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
>   src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
>   src/slave/containerizer/docker.cpp 289d4ec0fba9071dfe0cbf5391b5391d4566dd9c 
>   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
> 
> Diff: https://reviews.apache.org/r/37505/diff/
> 
> 
> Testing
> ---
> 
> # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
> HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
> # Docker health check command is run through "docker exec"
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" 
> --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37505: Fix broken health check in docker executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review99246
---


Overall looks good to me, some minor comments around style and wording, but I 
can fix them.
Let me test this patch locally first and if it looks good I'll merge.

- Timothy Chen


On Sept. 14, 2015, 12:59 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37505/
> ---
> 
> (Updated Sept. 14, 2015, 12:59 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3136
> https://issues.apache.org/jira/browse/MESOS-3136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix broken health check in docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403 
>   src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
>   src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
>   src/slave/containerizer/docker.cpp 289d4ec0fba9071dfe0cbf5391b5391d4566dd9c 
>   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
> 
> Diff: https://reviews.apache.org/r/37505/diff/
> 
> 
> Testing
> ---
> 
> # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
> HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
> # Docker health check command is run through "docker exec"
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" 
> --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37505: Fix broken health check in docker executor.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/
---

(Updated Sept. 14, 2015, 12:59 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

Rebase


Bugs: MESOS-3136
https://issues.apache.org/jira/browse/MESOS-3136


Repository: mesos


Description
---

Fix broken health check in docker executor.


Diffs (updated)
-

  src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403 
  src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
  src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
  src/slave/containerizer/docker.cpp 289d4ec0fba9071dfe0cbf5391b5391d4566dd9c 
  src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 

Diff: https://reviews.apache.org/r/37505/diff/


Testing
---

# Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
# Docker health check command is run through "docker exec"
sudo ./bin/mesos-tests.sh 
--gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
sudo ./bin/mesos-tests.sh 
--gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" --verbose


Thanks,

haosdent huang

Re: Review Request 37505: Fix broken health check in docker executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review98892
---


Patch looks great!

Reviews applied: [37505]

All tests passed.

- Mesos ReviewBot


On Sept. 14, 2015, 12:59 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37505/
> ---
> 
> (Updated Sept. 14, 2015, 12:59 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3136
> https://issues.apache.org/jira/browse/MESOS-3136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix broken health check in docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403 
>   src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
>   src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
>   src/slave/containerizer/docker.cpp 289d4ec0fba9071dfe0cbf5391b5391d4566dd9c 
>   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
> 
> Diff: https://reviews.apache.org/r/37505/diff/
> 
> 
> Testing
> ---
> 
> # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
> HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
> # Docker health check command is run through "docker exec"
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" 
> --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37505: Fix broken health check in docker executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review98364
---



src/tests/health_check_tests.cpp (line 258)


We should do ASSERT here, refer to your Docker exec patch and I commented 
the usual way we've done this.



src/tests/health_check_tests.cpp (line 501)


s/executor/execuotr/g.



src/tests/health_check_tests.cpp (line 507)


ASSERT style here too.


- Timothy Chen


On Sept. 10, 2015, 2:20 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37505/
> ---
> 
> (Updated Sept. 10, 2015, 2:20 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3136
> https://issues.apache.org/jira/browse/MESOS-3136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix broken health check in docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403 
>   src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
>   src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
>   src/slave/containerizer/docker.cpp 289d4ec0fba9071dfe0cbf5391b5391d4566dd9c 
>   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
> 
> Diff: https://reviews.apache.org/r/37505/diff/
> 
> 
> Testing
> ---
> 
> # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
> HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
> # Docker health check command is run through "docker exec"
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" 
> --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37505: Fix broken health check in docker executor.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/
---

(Updated Sept. 10, 2015, 7:16 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

Update according to @tnachen's reviews


Bugs: MESOS-3136
https://issues.apache.org/jira/browse/MESOS-3136


Repository: mesos


Description
---

Fix broken health check in docker executor.


Diffs (updated)
-

  src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403 
  src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
  src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
  src/slave/containerizer/docker.cpp 289d4ec0fba9071dfe0cbf5391b5391d4566dd9c 
  src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 

Diff: https://reviews.apache.org/r/37505/diff/


Testing
---

# Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
# Docker health check command is run through "docker exec"
sudo ./bin/mesos-tests.sh 
--gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
sudo ./bin/mesos-tests.sh 
--gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" --verbose


Thanks,

haosdent huang

Re: Review Request 37505: Fix broken health check in docker executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review98385
---


Patch looks great!

Reviews applied: [37505]

All tests passed.

- Mesos ReviewBot


On Sept. 10, 2015, 7:16 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37505/
> ---
> 
> (Updated Sept. 10, 2015, 7:16 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3136
> https://issues.apache.org/jira/browse/MESOS-3136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix broken health check in docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403 
>   src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
>   src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
>   src/slave/containerizer/docker.cpp 289d4ec0fba9071dfe0cbf5391b5391d4566dd9c 
>   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
> 
> Diff: https://reviews.apache.org/r/37505/diff/
> 
> 
> Testing
> ---
> 
> # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
> HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
> # Docker health check command is run through "docker exec"
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" 
> --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37505: Fix broken health check in docker executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review98357
---


Patch looks great!

Reviews applied: [37505]

All tests passed.

- Mesos ReviewBot


On Sept. 10, 2015, 2:20 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37505/
> ---
> 
> (Updated Sept. 10, 2015, 2:20 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3136
> https://issues.apache.org/jira/browse/MESOS-3136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix broken health check in docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403 
>   src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
>   src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
>   src/slave/containerizer/docker.cpp 289d4ec0fba9071dfe0cbf5391b5391d4566dd9c 
>   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
> 
> Diff: https://reviews.apache.org/r/37505/diff/
> 
> 
> Testing
> ---
> 
> # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
> HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
> # Docker health check command is run through "docker exec"
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" 
> --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37505: Fix broken health check in docker executor.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/
---

(Updated Sept. 10, 2015, 2:20 a.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-3136
https://issues.apache.org/jira/browse/MESOS-3136


Repository: mesos


Description
---

Fix broken health check in docker executor.


Diffs (updated)
-

  src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403 
  src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
  src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
  src/slave/containerizer/docker.cpp 289d4ec0fba9071dfe0cbf5391b5391d4566dd9c 
  src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 

Diff: https://reviews.apache.org/r/37505/diff/


Testing
---

# Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
# Docker health check command is run through "docker exec"
sudo ./bin/mesos-tests.sh 
--gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
sudo ./bin/mesos-tests.sh 
--gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" --verbose


Thanks,

haosdent huang

Re: Review Request 37505: Fix broken health check in docker executor.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/
---

(Updated Sept. 3, 2015, 1:25 p.m.)


Review request for mesos, Adam B and Timothy Chen.


Changes
---

Rebase code and update according @tnachen reviews.


Bugs: MESOS-3136
https://issues.apache.org/jira/browse/MESOS-3136


Repository: mesos


Description
---

Fix broken health check in docker executor.


Diffs (updated)
-

  src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403 
  src/docker/docker.cpp 2e17cedb3e29548bdd2d10bd87bd0f61bf123be8 
  src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e 
  src/slave/containerizer/docker.cpp 289d4ec0fba9071dfe0cbf5391b5391d4566dd9c 
  src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 

Diff: https://reviews.apache.org/r/37505/diff/


Testing
---

# Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
# Docker health check command is run through "docker exec"
sudo ./bin/mesos-tests.sh 
--gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
sudo ./bin/mesos-tests.sh 
--gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" --verbose


Thanks,

haosdent huang

Re: Review Request 37505: Fix broken health check in docker executor.

[haosdent huang]

> On Aug. 31, 2015, 4:32 a.m., Timothy Chen wrote:
> > src/docker/executor.cpp, line 361
> > 
> >
> > You should be able to push the arguments with another vector insert?
> > 
> > e.g:
> > 
> > argv.push_back("--executor");
> > argv.push_back(stringify(self());
> > .

If I use this way, I got error like this:
```
Failed to load non-boolean flag 'executor': Missing value

Usage: lt-mesos-health-check [options]

  --executor=VALUE  Executor UPID to send health check messages to
  --health_check_json=VALUE JSON describing health check to perform
  --[no-]help   Prints this help message (default: false)
  --task_id=VALUE   Task ID that this health check process is 
checking
```


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review97053
---


On Aug. 30, 2015, 10:23 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37505/
> ---
> 
> (Updated Aug. 30, 2015, 10:23 a.m.)
> 
> 
> Review request for mesos, Adam B and Timothy Chen.
> 
> 
> Bugs: MESOS-3136
> https://issues.apache.org/jira/browse/MESOS-3136
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix broken health check in docker executor.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b 
>   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
>   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
>   src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad 
>   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
> 
> Diff: https://reviews.apache.org/r/37505/diff/
> 
> 
> Testing
> ---
> 
> # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
> HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
> # Docker health check command is run through "docker exec"
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask" --verbose
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange" 
> --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37505: Fix broken health check in docker executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review97021
---


Patch looks great!

Reviews applied: [37505]

All tests passed.

- Mesos ReviewBot


On Aug. 30, 2015, 7:32 a.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37505/
 ---
 
 (Updated Aug. 30, 2015, 7:32 a.m.)
 
 
 Review request for mesos, Adam B and Timothy Chen.
 
 
 Bugs: MESOS-3136
 https://issues.apache.org/jira/browse/MESOS-3136
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Fix broken health check in docker executor.
 
 
 Diffs
 -
 
   src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b 
   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
   src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad 
   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
 
 Diff: https://reviews.apache.org/r/37505/diff/
 
 
 Testing
 ---
 
 # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
 HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
 # Docker health check command is run through docker exec
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange 
 --verbose
 
 
 Thanks,
 
 haosdent huang
 

Re: Review Request 37505: Fix broken health check in docker executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review97017
---



src/docker/docker.hpp (line 152)
https://reviews.apache.org/r/37505/#comment152735

The interface is confusing to me as I would assume it's checkin that the 
version of docker matches exactly the expectedVersion, but actually is making 
sure it's above the minimumVersion.
You should rename expectVersion to minVersion.
Also please add comments above.



src/tests/health_check_tests.cpp (line 573)
https://reviews.apache.org/r/37505/#comment152736

Docker tests should inherit from MesosTest which inherits from 
TemporrayDirectoryTest already, which means the current work directory is a 
temporary directory that you can use.

Just create the file in your current working directory and pass that path 
in.



src/tests/health_check_tests.cpp (line 626)
https://reviews.apache.org/r/37505/#comment152737

You don't need to clean up temp file if you just stick in the os::getcwd() 
child path.


- Timothy Chen


On Aug. 30, 2015, 7:32 a.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37505/
 ---
 
 (Updated Aug. 30, 2015, 7:32 a.m.)
 
 
 Review request for mesos, Adam B and Timothy Chen.
 
 
 Bugs: MESOS-3136
 https://issues.apache.org/jira/browse/MESOS-3136
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Fix broken health check in docker executor.
 
 
 Diffs
 -
 
   src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b 
   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
   src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad 
   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
 
 Diff: https://reviews.apache.org/r/37505/diff/
 
 
 Testing
 ---
 
 # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
 HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
 # Docker health check command is run through docker exec
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange 
 --verbose
 
 
 Thanks,
 
 haosdent huang
 

Re: Review Request 37505: Fix broken health check in docker executor.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/
---

(Updated Aug. 30, 2015, 10:23 a.m.)


Review request for mesos, Adam B and Timothy Chen.


Changes
---

Use sandbox directory as temp location.


Bugs: MESOS-3136
https://issues.apache.org/jira/browse/MESOS-3136


Repository: mesos


Description
---

Fix broken health check in docker executor.


Diffs (updated)
-

  src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b 
  src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
  src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
  src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad 
  src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 

Diff: https://reviews.apache.org/r/37505/diff/


Testing
---

# Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
# Docker health check command is run through docker exec
sudo ./bin/mesos-tests.sh 
--gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose
sudo ./bin/mesos-tests.sh 
--gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange --verbose


Thanks,

haosdent huang

Re: Review Request 37505: Fix broken health check in docker executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review97026
---


Patch looks great!

Reviews applied: [37505]

All tests passed.

- Mesos ReviewBot


On Aug. 30, 2015, 10:23 a.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37505/
 ---
 
 (Updated Aug. 30, 2015, 10:23 a.m.)
 
 
 Review request for mesos, Adam B and Timothy Chen.
 
 
 Bugs: MESOS-3136
 https://issues.apache.org/jira/browse/MESOS-3136
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Fix broken health check in docker executor.
 
 
 Diffs
 -
 
   src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b 
   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
   src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad 
   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
 
 Diff: https://reviews.apache.org/r/37505/diff/
 
 
 Testing
 ---
 
 # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
 HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
 # Docker health check command is run through docker exec
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange 
 --verbose
 
 
 Thanks,
 
 haosdent huang
 

Re: Review Request 37505: Fix broken health check in docker executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review97053
---



src/docker/executor.cpp (line 306)
https://reviews.apache.org/r/37505/#comment152772

End comment with period



src/docker/executor.cpp (line 310)
https://reviews.apache.org/r/37505/#comment152771

End comment with period



src/docker/executor.cpp (line 315)
https://reviews.apache.org/r/37505/#comment152770

You're still continuning to launch the health check even when the version 
is not met?



src/docker/executor.cpp (line 352)
https://reviews.apache.org/r/37505/#comment152773

Can you log that docker executor doesn't yet support the other health check 
type with a else block?



src/docker/executor.cpp (line 361)
https://reviews.apache.org/r/37505/#comment152774

You should be able to push the arguments with another vector insert?

e.g:

argv.push_back(--executor);
argv.push_back(stringify(self());
.



src/tests/health_check_tests.cpp (line 254)
https://reviews.apache.org/r/37505/#comment152775

We shouldn't run this if docker daemon is  1.3.0 right? You should check 
and disable the test if you found it.



src/tests/health_check_tests.cpp (line 322)
https://reviews.apache.org/r/37505/#comment152776

Why also test reconciliation?


- Timothy Chen


On Aug. 30, 2015, 10:23 a.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37505/
 ---
 
 (Updated Aug. 30, 2015, 10:23 a.m.)
 
 
 Review request for mesos, Adam B and Timothy Chen.
 
 
 Bugs: MESOS-3136
 https://issues.apache.org/jira/browse/MESOS-3136
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Fix broken health check in docker executor.
 
 
 Diffs
 -
 
   src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b 
   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
   src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad 
   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
 
 Diff: https://reviews.apache.org/r/37505/diff/
 
 
 Testing
 ---
 
 # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
 HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
 # Docker health check command is run through docker exec
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange 
 --verbose
 
 
 Thanks,
 
 haosdent huang
 

Re: Review Request 37505: Fix broken health check in docker executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review96545
---



src/docker/docker.hpp (line 48)
https://reviews.apache.org/r/37505/#comment152000

Why we need a default version?



src/health-check/main.cpp (line 322)
https://reviews.apache.org/r/37505/#comment152004

So I think that we can not need to modify the healthcheck at all if we 
provide the health check command a full command path to run each time, which 
the docker executor constructs the full path based on executable and container 
name.

Let me know if you think there is a reason we still need to.


- Timothy Chen


On Aug. 23, 2015, 9:44 a.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37505/
 ---
 
 (Updated Aug. 23, 2015, 9:44 a.m.)
 
 
 Review request for mesos, Adam B and Timothy Chen.
 
 
 Bugs: MESOS-3136
 https://issues.apache.org/jira/browse/MESOS-3136
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Fix broken health check in docker executor.
 
 
 Diffs
 -
 
   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
   src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
   src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
   src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
   src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad 
   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
 
 Diff: https://reviews.apache.org/r/37505/diff/
 
 
 Testing
 ---
 
 # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
 HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
 # Docker health check command is run through docker exec
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange 
 --verbose
 
 
 Thanks,
 
 haosdent huang
 

Re: Review Request 37505: Fix broken health check in docker executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review96557
---


Patch looks great!

Reviews applied: [37703, 37505]

All tests passed.

- Mesos ReviewBot


On Aug. 23, 2015, 9:44 a.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37505/
 ---
 
 (Updated Aug. 23, 2015, 9:44 a.m.)
 
 
 Review request for mesos, Adam B and Timothy Chen.
 
 
 Bugs: MESOS-3136
 https://issues.apache.org/jira/browse/MESOS-3136
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Fix broken health check in docker executor.
 
 
 Diffs
 -
 
   include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
   src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
   src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
   src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
   src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad 
   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
 
 Diff: https://reviews.apache.org/r/37505/diff/
 
 
 Testing
 ---
 
 # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
 HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
 # Docker health check command is run through docker exec
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange 
 --verbose
 
 
 Thanks,
 
 haosdent huang
 

Re: Review Request 37505: Fix broken health check in docker executor.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/
---

(Updated Aug. 23, 2015, 8:58 a.m.)


Review request for mesos, Adam B and Timothy Chen.


Bugs: MESOS-3136
https://issues.apache.org/jira/browse/MESOS-3136


Repository: mesos


Description
---

Fix broken health check in docker executor.


Diffs (updated)
-

  include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
  src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
  src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
  src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
  src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
  src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
  src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad 
  src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 

Diff: https://reviews.apache.org/r/37505/diff/


Testing
---

# Add a new test, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
sudo ./bin/mesos-tests.sh 
--gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose


Thanks,

haosdent huang

Re: Review Request 37505: Fix broken health check in docker executor.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/
---

(Updated Aug. 23, 2015, 8:59 a.m.)


Review request for mesos, Adam B and Timothy Chen.


Bugs: MESOS-3136
https://issues.apache.org/jira/browse/MESOS-3136


Repository: mesos


Description
---

Fix broken health check in docker executor.


Diffs
-

  include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
  src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
  src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
  src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
  src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
  src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
  src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad 
  src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 

Diff: https://reviews.apache.org/r/37505/diff/


Testing (updated)
---

# Add a new test, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
# Docker health check command is run through docker exec
sudo ./bin/mesos-tests.sh 
--gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose


Thanks,

haosdent huang

Re: Review Request 37505: Fix broken health check in docker executor.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/
---

(Updated Aug. 23, 2015, 9:44 a.m.)


Review request for mesos, Adam B and Timothy Chen.


Changes
---

Add a new test case.


Bugs: MESOS-3136
https://issues.apache.org/jira/browse/MESOS-3136


Repository: mesos


Description
---

Fix broken health check in docker executor.


Diffs (updated)
-

  include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193 
  src/docker/docker.hpp 38e5299ad38b9e20501387f2193b0fa448e49e3e 
  src/docker/docker.cpp 1367de8a7bbbda6348a30e4ef4c616378e450250 
  src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
  src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 
  src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
  src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad 
  src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 

Diff: https://reviews.apache.org/r/37505/diff/


Testing (updated)
---

# Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and 
HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
# Docker health check command is run through docker exec
sudo ./bin/mesos-tests.sh 
--gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose
sudo ./bin/mesos-tests.sh 
--gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange --verbose


Thanks,

haosdent huang

Re: Review Request 37505: Fix broken health check in docker executor.

[haosdent huang]

 On Aug. 17, 2015, 9:59 p.m., Timothy Chen wrote:
  Hi haosdent, thanks for working on this but I think running the healthcheck 
  outside of the container doesn't make much sense to me.
  I think we should try to run it inside of the container (docker exec), but 
  since docker exec is introduced until few later versions we also need to 
  check to make sure the right version is running on the slave.

got it. Let me update.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review95651
---


On Aug. 16, 2015, 9:12 a.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37505/
 ---
 
 (Updated Aug. 16, 2015, 9:12 a.m.)
 
 
 Review request for mesos, Adam B and Timothy Chen.
 
 
 Bugs: MESOS-3136
 https://issues.apache.org/jira/browse/MESOS-3136
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Fix broken health check in docker executor.
 
 
 Diffs
 -
 
   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
   src/launcher/executor.cpp 9fa7dcfc39a6706f545b3328e468d9cd25d603ae 
   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
 
 Diff: https://reviews.apache.org/r/37505/diff/
 
 
 Testing
 ---
 
 # Add a new test, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose
 
 
 Thanks,
 
 haosdent huang
 

Re: Review Request 37505: Fix broken health check in docker executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review95651
---


Hi haosdent, thanks for working on this but I think running the healthcheck 
outside of the container doesn't make much sense to me.
I think we should try to run it inside of the container (docker exec), but 
since docker exec is introduced until few later versions we also need to check 
to make sure the right version is running on the slave.

- Timothy Chen


On Aug. 16, 2015, 9:12 a.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37505/
 ---
 
 (Updated Aug. 16, 2015, 9:12 a.m.)
 
 
 Review request for mesos, Adam B and Timothy Chen.
 
 
 Bugs: MESOS-3136
 https://issues.apache.org/jira/browse/MESOS-3136
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Fix broken health check in docker executor.
 
 
 Diffs
 -
 
   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
   src/launcher/executor.cpp 9fa7dcfc39a6706f545b3328e468d9cd25d603ae 
   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
 
 Diff: https://reviews.apache.org/r/37505/diff/
 
 
 Testing
 ---
 
 # Add a new test, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose
 
 
 Thanks,
 
 haosdent huang
 

Review Request 37505: Fix broken health check in docker executor.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/
---

Review request for mesos, Adam B and Timothy Chen.


Bugs: MESOS-3136
https://issues.apache.org/jira/browse/MESOS-3136


Repository: mesos


Description
---

Fix broken health check in docker executor.


Diffs
-

  src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
  src/launcher/executor.cpp 9fa7dcfc39a6706f545b3328e468d9cd25d603ae 
  src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 

Diff: https://reviews.apache.org/r/37505/diff/


Testing
---

# Add a new test, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
sudo ./bin/mesos-tests.sh 
--gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose


Thanks,

haosdent huang

Re: Review Request 37505: Fix broken health check in docker executor.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review95541
---


Patch looks great!

Reviews applied: [37505]

All tests passed.

- Mesos ReviewBot


On Aug. 16, 2015, 9:12 a.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37505/
 ---
 
 (Updated Aug. 16, 2015, 9:12 a.m.)
 
 
 Review request for mesos, Adam B and Timothy Chen.
 
 
 Bugs: MESOS-3136
 https://issues.apache.org/jira/browse/MESOS-3136
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Fix broken health check in docker executor.
 
 
 Diffs
 -
 
   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
   src/launcher/executor.cpp 9fa7dcfc39a6706f545b3328e468d9cd25d603ae 
   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
 
 Diff: https://reviews.apache.org/r/37505/diff/
 
 
 Testing
 ---
 
 # Add a new test, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask
 sudo ./bin/mesos-tests.sh 
 --gtest_filter=HealthCheckTest.ROOT_DOCKER_DockerHealthyTask --verbose
 
 
 Thanks,
 
 haosdent huang